Re: [PATCH v2 2/5] dt-bindings: usb: cypress,hx3: Add support for all variants

Am Freitag, 25. April 2025, 17:18:07 Mitteleuropäische Sommerzeit schrieb Lukasz Czechowski:

The Cypress HX3 hubs use different default PID value depending on the variant. Update compatibles list. Becasuse all hub variants use the same driver data, allow the dt node to have two compatibles: leftmost which matches the HW exactly, and the second one as fallback.

Fixes: 1eca51f58a10 ("dt-bindings: usb: Add binding for Cypress HX3 USB 3.0 family") Cc: stable@vger.kernel.org # 6.6 Cc: stable@vger.kernel.org # Backport of the patch ("dt-bindings: usb: usb-device: relax compatible pattern to a contains") from list: https://lore.kernel.org/linux-usb/20250418-dt-binding-usb-device-compatibles... Cc: stable@vger.kernel.org # Backport of the patch in this series fixing product ID in onboard_dev_id_table in drivers/usb/misc/onboard_usb_dev.c driver Signed-off-by: Lukasz Czechowski lukasz.czechowski@thaumatec.com

Looking at linux-next, it seems like patch1 of this series was applied [0]. The general convention would be for the binding (this patch) also going through a driver tree.

I guess I _could_ apply it together with the board-level patches, but for that would need an Ack from Greg .

@Greg, do you want to merge this patch ?

Thanks a lot Heiko

[0] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?...

---

.../devicetree/bindings/usb/cypress,hx3.yaml | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/cypress,hx3.yaml b/Documentation/devicetree/bindings/usb/cypress,hx3.yaml index 1033b7a4b8f953424cc3d31d561992c17f3594b2..d6eac1213228d2acb50ebc959d1ff15134c5a91c 100644 --- a/Documentation/devicetree/bindings/usb/cypress,hx3.yaml +++ b/Documentation/devicetree/bindings/usb/cypress,hx3.yaml @@ -14,9 +14,22 @@ allOf: properties: compatible:

• enum:

•  - usb4b4,6504
  

•  - usb4b4,6506
  

• oneOf:

•  - enum:
  

•      - usb4b4,6504
  

•      - usb4b4,6506
  

•  - items:
  

•      - enum:
  

•          - usb4b4,6500
  

•          - usb4b4,6508
  

•      - const: usb4b4,6504
  

•  - items:
  

•      - enum:
  

•          - usb4b4,6502
  

•          - usb4b4,6503
  

•          - usb4b4,6507
  

•          - usb4b4,650a
  

•      - const: usb4b4,6506
  

reg: true