From: Werner Sembach wse@tuxedocomputers.com
[ Upstream commit 9cd51eefae3c871440b93c03716c5398f41bdf78 ]
Add the TUXEDO InfinityBook Pro AMD Gen9 to the acpi_ec_no_wakeup[] quirk list to prevent spurious wakeups.
Signed-off-by: Werner Sembach wse@tuxedocomputers.com Link: https://patch.msgid.link/20250508111625.12149-1-wse@tuxedocomputers.com Signed-off-by: Rafael J. Wysocki rafael.j.wysocki@intel.com Signed-off-by: Sasha Levin sashal@kernel.org ---
The search failed because this is the current version in the kernel tree, but the commit we're analyzing hasn't been applied yet. Let me analyze this commit based on the information provided. ## Analysis **YES** This commit should be backported to stable kernel trees. ### Detailed Analysis: **1. Nature of the Fix:** The commit adds the "TUXEDO InfinityBook Pro AMD Gen9" laptop to the `acpi_ec_no_wakeup[]` DMI quirk list. This is a targeted fix for spurious wakeups from suspend-to-idle (s2idle) caused by EC (Embedded Controller) interrupts on a specific laptop model. **2. Code Changes:** The change is minimal and surgical: - Adds a single new DMI entry to an existing quirk table - Uses `DMI_MATCH(DMI_BOARD_NAME, "GXxHRXx")` to identify the specific device - Includes a comment identifying the device clearly - No functional code logic changes - only data structure modification **3. Comparison with Historical Similar Commits:** Looking at the historical commits provided: - **Similar Commit #1 (NO):** Added HP ZHAN 66 Pro - marked as NO for backporting - **Similar Commit #2 (YES):** Fixed ThinkPad X1 Carbon 6th DMI matching - marked as YES - **Similar Commit #3 (NO):** Added ThinkPad X1 Yoga 3rd - marked as NO - **Similar Commit #4 (YES):** GPIO quirk for GPD G1619-04 with `Cc: stable@vger.kernel.org` - marked as YES - **Similar Commit #5 (YES):** Removed duplicate entry - marked as YES **4. Stable Tree Criteria Assessment:** ✅ **Fixes important user- visible bug:** Spurious wakeups significantly impact user experience and battery life ✅ **Small and contained change:** Only adds one DMI table entry, no logic changes ✅ **Low risk of regression:** DMI quirks are device-specific and don't affect other systems ✅ **Well-tested pattern:** The `acpi_ec_no_wakeup` mechanism is well-established and widely used ✅ **Critical subsystem appropriately handled:** ACPI EC is critical but this change is isolated to one device **5. Risk Assessment:** - **Risk to target device:** Minimal - disables EC wakeup which is the intended behavior to fix spurious wakeups - **Risk to other devices:** None - DMI matching is device-specific - **Risk of regression:** Very low - follows established pattern used by many other laptop models **6. Precedent Analysis:** The pattern shows that while some individual device additions were marked as NO (commits #1 and #3), those that include proper documentation, clear problem statements, or fix significant user issues tend to be marked YES (commits #2, #4, #5). This commit includes a clear problem statement ("prevent spurious wakeups") and follows the exact same pattern as successful backports. **7. User Impact:** Spurious wakeups during suspend-to-idle directly impact: - Battery life (system doesn't stay in low-power state) - User experience (unexpected wake-ups) - Power management effectiveness This is exactly the type of user-facing power management issue that stable trees aim to address. The commit is an ideal candidate for backporting: it's a small, safe, device-specific fix for a real user problem that follows well-established patterns with minimal risk.
drivers/acpi/ec.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c index 3c5f34892734e..6f4203716b53f 100644 --- a/drivers/acpi/ec.c +++ b/drivers/acpi/ec.c @@ -2329,6 +2329,12 @@ static const struct dmi_system_id acpi_ec_no_wakeup[] = { DMI_MATCH(DMI_PRODUCT_NAME, "83Q3"), } }, + { + // TUXEDO InfinityBook Pro AMD Gen9 + .matches = { + DMI_MATCH(DMI_BOARD_NAME, "GXxHRXx"), + }, + }, { }, };