On Sat, 26 Sep 2020 10:32:15 -0700 Linus Torvalds torvalds@linux-foundation.org wrote:
The explanations here do not make sense.
On Fri, Sep 25, 2020 at 9:19 PM Andrew Morton akpm@linux-foundation.org wrote:
There are 2 issues here:
a. The sysfs memory and node's layouts are broken due to these multiple links
b. The link errors in link_mem_sections() should not lead to a system panic.
To address a. register_mem_sect_under_node should not rely on the system state to detect whether the link operation is triggered by a hot plug operation or not. This is addressed by the patches 1 and 2 of this series.
The patch 3 is addressing the point b.
This patch (of 2):
The memmap_context enum is used to detect whether a memory operation is due to a hot-add operation or happening at boot time.
Make it general to the hotplug operation and rename it as meminit_context.
There is no functional change introduced by this patch
So far so good.
But there is no "patch 3" that addresses point (b) in this series.
I see it on lore, but it's not part of what actually got sent to me, so the commit message for patch 1 now makes no sense any more.
1/3 and 2/3 were cc:stable and 3/3 was not. As far as I can tell, 3/3 is rather theoretical once 2/3 has done its work, so I held it off for the next merge window.