On Fri, Mar 27, 2020 at 7:20 AM Martin K. Petersen martin.petersen@oracle.com wrote:
Sreekanth,
In the unload path driver call sas_remove_host() API before releasing the resources. This sas_remove_host() API waits for all the outstanding IOs to be completed. So here, indirectly driver is waiting for the outstanding IOs to be processed before releasing the HBA resources. So only in the cases where HBA is inaccessible (e.g. HBA unplug case), driver is flushing out the outstanding commands to avoid SCSI error handling over head and can quilkey complete the driver unload operation.
None of this is clear from the commit description. Please resubmit patch with a new description clarifying why and when it is safe to drop outstanding commands.
Martin,
Posted the patch with updated description. https://patchwork.kernel.org/patch/11462107/
Thanks & Regards, Sreekanth
-- Martin K. Petersen Oracle Linux Engineering