Re: [PATCH] platform/x86: amd-pmc: only use callbacks for suspend

On Fri, Dec 10, 2021 at 9:06 PM Mario Limonciello mario.limonciello@amd.com wrote:

This driver is intended to be used exclusively for suspend to idle so callbacks to send OS_HINT during hibernate and S5 will set OS_HINT at the wrong time leading to an undefined behavior.

...

static const struct dev_pm_ops amd_pmc_pm_ops = {

•   SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(amd_pmc_suspend, amd_pmc_resume)
  

•   .suspend_noirq = amd_pmc_suspend,
  

•   .resume_noirq = amd_pmc_resume,
  

Can you simply switch to SET_NOIRQ_SYSTEM_SLEEP_PM_OPS()?

};