Re: [PATCH] mmc: part_switch: fixes switch on gp3 partition

On Wed, Mar 6, 2024 at 10:05 AM Jorge Ramirez-Ortiz, Foundries jorge@foundries.io wrote:

That looked strange as there should be support for 4 GP but this code kind of convinced me of the opposite.

    if (idata->rpmb) {
            /* Support multiple RPMB partitions */
            target_part = idata->rpmb->part_index;
            target_part |= EXT_CSD_PART_CONFIG_ACC_RPMB;
    }

So if we apply the fix that you propose, how are multiple RPMB partitions (ie, 4) going to be identified as RPMB? Unless there can't be more than 3?

Sorry for writing bad code comments.

This comment means:

"support multiple RPMB partitions [on the same Linux system]"

not:

"support multiple RPMB partitions [on the same eMMC device]"

Yours, Linus Walleij