From: Val Packett val@packett.cool
[ Upstream commit 30ee285f1e3cdc88ec7010abeaba0cbed800bdcd ]
Allow these machines to access efivars through qseecom/uefisecapp.
Signed-off-by: Val Packett val@packett.cool Reviewed-by: Laurentiu Tudor laurentiu.tudor1@dell.com Tested-by: Bryan O'Donoghue bryan.odonoghue@linaro.org Link: https://lore.kernel.org/r/20250716003139.18543-5-val@packett.cool Signed-off-by: Bjorn Andersson andersson@kernel.org Signed-off-by: Sasha Levin sashal@kernel.org ---
LLM Generated explanations, may be completely bogus:
## Analysis Complete
**Backport Status: YES**
### Detailed Analysis
#### 1. **Code Changes (drivers/firmware/qcom/qcom_scm.c:1994-2014)**
The commit adds exactly **2 lines** to the `qcom_scm_qseecom_allowlist[]` static array:
```c { .compatible = "dell,inspiron-14-plus-7441" }, { .compatible = "dell,latitude-7455" }, ```
This is a minimal, surgical change that adds device tree compatible strings to an allowlist that gates access to the QSEECOM interface for UEFI variable access.
#### 2. **Stable Kernel Policy Compliance**
The Linux stable kernel rules (Documentation/process/stable-kernel- rules.rst:24) **explicitly allow** this type of commit:
**"New device IDs and quirks are also accepted."**
This commit adds new device identifiers to a quirk/allowlist table, which is precisely what the stable policy permits.
#### 3. **Risk Assessment: MINIMAL**
- **Scope**: Only affects Dell Inspiron 7441 and Latitude 7455 machines with matching device tree compatible strings - **Regression risk**: Zero risk to existing hardware - the allowlist check at qcom_scm.c:2063 means only machines explicitly listed can access this functionality - **Size**: 2 lines added, no algorithmic changes - **Side effects**: None - confined to enabling QSEECOM on specific machines
#### 4. **Historical Precedent: STRONG**
I identified **20+ similar commits** since 2024, all following the identical pattern: - `9b01fc6bb1fca` - Asus Vivobook S15 (in v6.14) - `96ac79829ccd7` - Windows Dev Kit 2023 (in v6.14, v6.15) - `eb47bca4cc8ab` - HP EliteBook Ultra G1q - `304c250ba121f` - Dell XPS 13 9345 (in v6.13, v6.14, v6.15) - `7d467c1b62d0b` - HP Omnibook X14 (in v6.14)
All of these allowlist additions have been backported to stable kernels, establishing clear precedent.
#### 5. **User Impact: SIGNIFICANT**
The commit message states: "Allow these machines to access efivars through qseecom/uefisecapp."
Without this commit, users of these Dell laptops cannot: - Access UEFI variables (needed for boot configuration) - Use efivarfs - Modify boot settings from Linux - Properly support firmware updates
This is a **real user-facing bug** that affects hardware functionality.
#### 6. **Testing and Review Quality**
The commit includes: - `Tested-by: Bryan O'Donoghue bryan.odonoghue@linaro.org` - `Reviewed-by: Laurentiu Tudor laurentiu.tudor1@dell.com` (Dell engineer)
Both Dell and Linaro have validated this change.
#### 7. **Already Selected for Backporting**
The commit **has already been backported** (commit `3301ae3f6d73a` by Sasha Levin on October 3, 2025), confirming the stable maintainer's assessment that it meets backporting criteria.
### Conclusion
**YES** - This commit is an excellent candidate for stable backporting because:
1. ✅ Explicitly permitted by stable rules (new device IDs) 2. ✅ Fixes real user-facing issue (UEFI variable access) 3. ✅ Minimal size (2 lines) 4. ✅ Zero regression risk (only affects listed machines) 5. ✅ Well-tested and reviewed 6. ✅ Follows established pattern (20+ similar backports) 7. ✅ Enables critical hardware functionality
drivers/firmware/qcom/qcom_scm.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c index 5243d5abbbe99..7f43f12e4e1b2 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -1994,6 +1994,8 @@ static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = { { .compatible = "asus,vivobook-s15" }, { .compatible = "asus,zenbook-a14-ux3407qa" }, { .compatible = "asus,zenbook-a14-ux3407ra" }, + { .compatible = "dell,inspiron-14-plus-7441" }, + { .compatible = "dell,latitude-7455" }, { .compatible = "dell,xps13-9345" }, { .compatible = "hp,elitebook-ultra-g1q" }, { .compatible = "hp,omnibook-x14" },