On Mon, Feb 24, 2025 at 02:33:49PM +0100, Geert Uytterhoeven wrote:
On Mon, 24 Feb 2025 at 13:35, Andy Shevchenko andy@kernel.org wrote:
On Mon, Feb 24, 2025 at 06:15:27PM +0800, Haoxiang Li wrote:
Variable allocated by charlcd_alloc() should be released by charlcd_free(). The following patch changed kfree() to charlcd_free() to fix an API misuse.
Fixes: 718e05ed92ec ("auxdisplay: Introduce hd44780_common.[ch]") Cc: stable@vger.kernel.org
Okay, looking closer to the current state of affairs, the change does not fix anything actually. OTOH it's correct semantically and allows to do any further development in charlcd_alloc(), if any.
That said, if Geert is okay with it, I would like to apply but without Fixes/Cc: stable@ tags.
I had mixed feelings about the Fixes-tag, too. Semantically, it's indeed a fix. If any further cleanups are ever done and backported, but this patch would be missed, it would introduce a bug.
Okay, I return it.