- Linux-stable-mirror - lists.linaro.org

Patch "ip6_tunnel: better validate user provided tunnel names" has been added to the 4.9-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled ip6_tunnel: better validate user provided tunnel names to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: ip6_tunnel-better-validate-user-provided-tunnel-names.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Wed Apr 11 10:26:56 CEST 2018 From: Eric Dumazet <edumazet(a)google.com> Date: Thu, 5 Apr 2018 06:39:30 -0700 Subject: ip6_tunnel: better validate user provided tunnel names From: Eric Dumazet <edumazet(a)google.com> [ Upstream commit db7a65e3ab78e5b1c4b17c0870ebee35a4ee3257 ] Use valid_name() to make sure user does not provide illegal device name. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Eric Dumazet <edumazet(a)google.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- net/ipv6/ip6_tunnel.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) --- a/net/ipv6/ip6_tunnel.c +++ b/net/ipv6/ip6_tunnel.c @@ -298,13 +298,16 @@ static struct ip6_tnl *ip6_tnl_create(st struct net_device *dev; struct ip6_tnl *t; char name[IFNAMSIZ]; - int err = -ENOMEM; + int err = -E2BIG; - if (p->name[0]) + if (p->name[0]) { + if (!dev_valid_name(p->name)) + goto failed; strlcpy(name, p->name, IFNAMSIZ); - else + } else { sprintf(name, "ip6tnl%%d"); - + } + err = -ENOMEM; dev = alloc_netdev(sizeof(*t), name, NET_NAME_UNKNOWN, ip6_tnl_dev_setup); if (!dev) Patches currently in stable-queue which might be from edumazet(a)google.com are queue-4.9/tcp-better-validation-of-received-ack-sequences.patch queue-4.9/sctp-sctp_sockaddr_af-must-check-minimal-addr-length-for-af_inet6.patch queue-4.9/net-fix-possible-out-of-bound-read-in-skb_network_protocol.patch queue-4.9/pptp-remove-a-buggy-dst-release-in-pptp_connect.patch queue-4.9/x86-asm-don-t-use-rbp-as-a-temporary-register-in-csum_partial_copy_generic.patch queue-4.9/net-fool-proof-dev_valid_name.patch queue-4.9/ipv6-the-entire-ipv6-header-chain-must-fit-the-first-fragment.patch queue-4.9/vti6-better-validate-user-provided-tunnel-names.patch queue-4.9/ipv6-sit-better-validate-user-provided-tunnel-names.patch queue-4.9/ip6_tunnel-better-validate-user-provided-tunnel-names.patch queue-4.9/sctp-do-not-leak-kernel-memory-to-user-space.patch queue-4.9/ip_tunnel-better-validate-user-provided-tunnel-names.patch queue-4.9/skbuff-only-inherit-relevant-tx_flags.patch queue-4.9/netlink-make-sure-nladdr-has-correct-size-in-netlink_connect.patch queue-4.9/ip6_gre-better-validate-user-provided-tunnel-names.patch

7 years, 4 months

1
0
0 0

Patch "ip6_gre: better validate user provided tunnel names" has been added to the 4.9-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled ip6_gre: better validate user provided tunnel names to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: ip6_gre-better-validate-user-provided-tunnel-names.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Wed Apr 11 10:26:56 CEST 2018 From: Eric Dumazet <edumazet(a)google.com> Date: Thu, 5 Apr 2018 06:39:29 -0700 Subject: ip6_gre: better validate user provided tunnel names From: Eric Dumazet <edumazet(a)google.com> [ Upstream commit 5f42df013b8bc1b6511af7a04bf93b014884ae2a ] Use dev_valid_name() to make sure user does not provide illegal device name. syzbot caught the following bug : BUG: KASAN: stack-out-of-bounds in strlcpy include/linux/string.h:300 [inline] BUG: KASAN: stack-out-of-bounds in ip6gre_tunnel_locate+0x334/0x860 net/ipv6/ip6_gre.c:339 Write of size 20 at addr ffff8801afb9f7b8 by task syzkaller851048/4466 CPU: 1 PID: 4466 Comm: syzkaller851048 Not tainted 4.16.0+ #1 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x1b9/0x29f lib/dump_stack.c:53 print_address_description+0x6c/0x20b mm/kasan/report.c:256 kasan_report_error mm/kasan/report.c:354 [inline] kasan_report.cold.7+0xac/0x2f5 mm/kasan/report.c:412 check_memory_region_inline mm/kasan/kasan.c:260 [inline] check_memory_region+0x13e/0x1b0 mm/kasan/kasan.c:267 memcpy+0x37/0x50 mm/kasan/kasan.c:303 strlcpy include/linux/string.h:300 [inline] ip6gre_tunnel_locate+0x334/0x860 net/ipv6/ip6_gre.c:339 ip6gre_tunnel_ioctl+0x69d/0x12e0 net/ipv6/ip6_gre.c:1195 dev_ifsioc+0x43e/0xb90 net/core/dev_ioctl.c:334 dev_ioctl+0x69a/0xcc0 net/core/dev_ioctl.c:525 sock_ioctl+0x47e/0x680 net/socket.c:1015 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:500 [inline] do_vfs_ioctl+0x1cf/0x1650 fs/ioctl.c:684 ksys_ioctl+0xa9/0xd0 fs/ioctl.c:701 SYSC_ioctl fs/ioctl.c:708 [inline] SyS_ioctl+0x24/0x30 fs/ioctl.c:706 do_syscall_64+0x29e/0x9d0 arch/x86/entry/common.c:287 entry_SYSCALL_64_after_hwframe+0x42/0xb7 Fixes: c12b395a4664 ("gre: Support GRE over IPv6") Signed-off-by: Eric Dumazet <edumazet(a)google.com> Reported-by: syzbot <syzkaller(a)googlegroups.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- net/ipv6/ip6_gre.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) --- a/net/ipv6/ip6_gre.c +++ b/net/ipv6/ip6_gre.c @@ -319,11 +319,13 @@ static struct ip6_tnl *ip6gre_tunnel_loc if (t || !create) return t; - if (parms->name[0]) + if (parms->name[0]) { + if (!dev_valid_name(parms->name)) + return NULL; strlcpy(name, parms->name, IFNAMSIZ); - else + } else { strcpy(name, "ip6gre%d"); - + } dev = alloc_netdev(sizeof(*t), name, NET_NAME_UNKNOWN, ip6gre_tunnel_setup); if (!dev) Patches currently in stable-queue which might be from edumazet(a)google.com are queue-4.9/tcp-better-validation-of-received-ack-sequences.patch queue-4.9/sctp-sctp_sockaddr_af-must-check-minimal-addr-length-for-af_inet6.patch queue-4.9/net-fix-possible-out-of-bound-read-in-skb_network_protocol.patch queue-4.9/pptp-remove-a-buggy-dst-release-in-pptp_connect.patch queue-4.9/x86-asm-don-t-use-rbp-as-a-temporary-register-in-csum_partial_copy_generic.patch queue-4.9/net-fool-proof-dev_valid_name.patch queue-4.9/ipv6-the-entire-ipv6-header-chain-must-fit-the-first-fragment.patch queue-4.9/vti6-better-validate-user-provided-tunnel-names.patch queue-4.9/ipv6-sit-better-validate-user-provided-tunnel-names.patch queue-4.9/ip6_tunnel-better-validate-user-provided-tunnel-names.patch queue-4.9/sctp-do-not-leak-kernel-memory-to-user-space.patch queue-4.9/ip_tunnel-better-validate-user-provided-tunnel-names.patch queue-4.9/skbuff-only-inherit-relevant-tx_flags.patch queue-4.9/netlink-make-sure-nladdr-has-correct-size-in-netlink_connect.patch queue-4.9/ip6_gre-better-validate-user-provided-tunnel-names.patch

7 years, 4 months

1
0
0 0

Patch "bonding: process the err returned by dev_set_allmulti properly in bond_enslave" has been added to the 4.9-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled bonding: process the err returned by dev_set_allmulti properly in bond_enslave to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: bonding-process-the-err-returned-by-dev_set_allmulti-properly-in-bond_enslave.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Wed Apr 11 10:26:56 CEST 2018 From: Xin Long <lucien.xin(a)gmail.com> Date: Mon, 26 Mar 2018 01:16:47 +0800 Subject: bonding: process the err returned by dev_set_allmulti properly in bond_enslave From: Xin Long <lucien.xin(a)gmail.com> [ Upstream commit 9f5a90c107741b864398f4ac0014711a8c1d8474 ] When dev_set_promiscuity(1) succeeds but dev_set_allmulti(1) fails, dev_set_promiscuity(-1) should be done before going to the err path. Otherwise, dev->promiscuity will leak. Fixes: 7e1a1ac1fbaa ("bonding: Check return of dev_set_promiscuity/allmulti") Signed-off-by: Xin Long <lucien.xin(a)gmail.com> Acked-by: Andy Gospodarek <andy(a)greyhouse.net> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/net/bonding/bond_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1700,8 +1700,11 @@ int bond_enslave(struct net_device *bond /* set allmulti level to new slave */ if (bond_dev->flags & IFF_ALLMULTI) { res = dev_set_allmulti(slave_dev, 1); - if (res) + if (res) { + if (bond_dev->flags & IFF_PROMISC) + dev_set_promiscuity(slave_dev, -1); goto err_sysfs_del; + } } netif_addr_lock_bh(bond_dev); Patches currently in stable-queue which might be from lucien.xin(a)gmail.com are queue-4.9/team-move-dev_mc_sync-after-master_upper_dev_link-in-team_port_add.patch queue-4.9/bonding-process-the-err-returned-by-dev_set_allmulti-properly-in-bond_enslave.patch queue-4.9/bonding-fix-the-err-path-for-dev-hwaddr-sync-in-bond_enslave.patch queue-4.9/bonding-move-dev_mc_sync-after-master_upper_dev_link-in-bond_enslave.patch queue-4.9/route-check-sysctl_fib_multipath_use_neigh-earlier-than-hash.patch queue-4.9/sctp-fix-recursive-locking-warning-in-sctp_do_peeloff.patch

7 years, 4 months

1
0
0 0

Patch "bonding: move dev_mc_sync after master_upper_dev_link in bond_enslave" has been added to the 4.9-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled bonding: move dev_mc_sync after master_upper_dev_link in bond_enslave to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: bonding-move-dev_mc_sync-after-master_upper_dev_link-in-bond_enslave.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Wed Apr 11 10:26:56 CEST 2018 From: Xin Long <lucien.xin(a)gmail.com> Date: Mon, 26 Mar 2018 01:16:46 +0800 Subject: bonding: move dev_mc_sync after master_upper_dev_link in bond_enslave From: Xin Long <lucien.xin(a)gmail.com> [ Upstream commit ae42cc62a9f07f1f6979054ed92606b9c30f4a2e ] Beniamino found a crash when adding vlan as slave of bond which is also the parent link: ip link add bond1 type bond ip link set bond1 up ip link add link bond1 vlan1 type vlan id 80 ip link set vlan1 master bond1 The call trace is as below: [<ffffffffa850842a>] queued_spin_lock_slowpath+0xb/0xf [<ffffffffa8515680>] _raw_spin_lock+0x20/0x30 [<ffffffffa83f6f07>] dev_mc_sync+0x37/0x80 [<ffffffffc08687dc>] vlan_dev_set_rx_mode+0x1c/0x30 [8021q] [<ffffffffa83efd2a>] __dev_set_rx_mode+0x5a/0xa0 [<ffffffffa83f7138>] dev_mc_sync_multiple+0x78/0x80 [<ffffffffc084127c>] bond_enslave+0x67c/0x1190 [bonding] [<ffffffffa8401909>] do_setlink+0x9c9/0xe50 [<ffffffffa8403bf2>] rtnl_newlink+0x522/0x880 [<ffffffffa8403ff7>] rtnetlink_rcv_msg+0xa7/0x260 [<ffffffffa8424ecb>] netlink_rcv_skb+0xab/0xc0 [<ffffffffa83fe498>] rtnetlink_rcv+0x28/0x30 [<ffffffffa8424850>] netlink_unicast+0x170/0x210 [<ffffffffa8424bf8>] netlink_sendmsg+0x308/0x420 [<ffffffffa83cc396>] sock_sendmsg+0xb6/0xf0 This is actually a dead lock caused by sync slave hwaddr from master when the master is the slave's 'slave'. This dead loop check is actually done by netdev_master_upper_dev_link. However, Commit 1f718f0f4f97 ("bonding: populate neighbour's private on enslave") moved it after dev_mc_sync. This patch is to fix it by moving dev_mc_sync after master_upper_dev_link, so that this loop check would be earlier than dev_mc_sync. It also moves if (mode == BOND_MODE_8023AD) into if (!bond_uses_primary) clause as an improvement. Note team driver also has this issue, I will fix it in another patch. Fixes: 1f718f0f4f97 ("bonding: populate neighbour's private on enslave") Reported-by: Beniamino Galvani <bgalvani(a)redhat.com> Signed-off-by: Xin Long <lucien.xin(a)gmail.com> Acked-by: Andy Gospodarek <andy(a)greyhouse.net> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/net/bonding/bond_main.c | 73 +++++++++++++++++++--------------------- 1 file changed, 35 insertions(+), 38 deletions(-) --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1524,44 +1524,11 @@ int bond_enslave(struct net_device *bond goto err_close; } - /* If the mode uses primary, then the following is handled by - * bond_change_active_slave(). - */ - if (!bond_uses_primary(bond)) { - /* set promiscuity level to new slave */ - if (bond_dev->flags & IFF_PROMISC) { - res = dev_set_promiscuity(slave_dev, 1); - if (res) - goto err_close; - } - - /* set allmulti level to new slave */ - if (bond_dev->flags & IFF_ALLMULTI) { - res = dev_set_allmulti(slave_dev, 1); - if (res) - goto err_close; - } - - netif_addr_lock_bh(bond_dev); - - dev_mc_sync_multiple(slave_dev, bond_dev); - dev_uc_sync_multiple(slave_dev, bond_dev); - - netif_addr_unlock_bh(bond_dev); - } - - if (BOND_MODE(bond) == BOND_MODE_8023AD) { - /* add lacpdu mc addr to mc list */ - u8 lacpdu_multicast[ETH_ALEN] = MULTICAST_LACPDU_ADDR; - - dev_mc_add(slave_dev, lacpdu_multicast); - } - res = vlan_vids_add_by_dev(slave_dev, bond_dev); if (res) { netdev_err(bond_dev, "Couldn't add bond vlan ids to %s\n", slave_dev->name); - goto err_hwaddr_unsync; + goto err_close; } prev_slave = bond_last_slave(bond); @@ -1719,6 +1686,37 @@ int bond_enslave(struct net_device *bond goto err_upper_unlink; } + /* If the mode uses primary, then the following is handled by + * bond_change_active_slave(). + */ + if (!bond_uses_primary(bond)) { + /* set promiscuity level to new slave */ + if (bond_dev->flags & IFF_PROMISC) { + res = dev_set_promiscuity(slave_dev, 1); + if (res) + goto err_sysfs_del; + } + + /* set allmulti level to new slave */ + if (bond_dev->flags & IFF_ALLMULTI) { + res = dev_set_allmulti(slave_dev, 1); + if (res) + goto err_sysfs_del; + } + + netif_addr_lock_bh(bond_dev); + dev_mc_sync_multiple(slave_dev, bond_dev); + dev_uc_sync_multiple(slave_dev, bond_dev); + netif_addr_unlock_bh(bond_dev); + + if (BOND_MODE(bond) == BOND_MODE_8023AD) { + /* add lacpdu mc addr to mc list */ + u8 lacpdu_multicast[ETH_ALEN] = MULTICAST_LACPDU_ADDR; + + dev_mc_add(slave_dev, lacpdu_multicast); + } + } + bond->slave_cnt++; bond_compute_features(bond); bond_set_carrier(bond); @@ -1742,6 +1740,9 @@ int bond_enslave(struct net_device *bond return 0; /* Undo stages on error */ +err_sysfs_del: + bond_sysfs_slave_del(new_slave); + err_upper_unlink: bond_upper_dev_unlink(bond, new_slave); @@ -1762,10 +1763,6 @@ err_detach: synchronize_rcu(); slave_disable_netpoll(new_slave); -err_hwaddr_unsync: - if (!bond_uses_primary(bond)) - bond_hw_addr_flush(bond_dev, slave_dev); - err_close: slave_dev->priv_flags &= ~IFF_BONDING; dev_close(slave_dev); Patches currently in stable-queue which might be from lucien.xin(a)gmail.com are queue-4.9/team-move-dev_mc_sync-after-master_upper_dev_link-in-team_port_add.patch queue-4.9/bonding-process-the-err-returned-by-dev_set_allmulti-properly-in-bond_enslave.patch queue-4.9/bonding-fix-the-err-path-for-dev-hwaddr-sync-in-bond_enslave.patch queue-4.9/bonding-move-dev_mc_sync-after-master_upper_dev_link-in-bond_enslave.patch queue-4.9/route-check-sysctl_fib_multipath_use_neigh-earlier-than-hash.patch queue-4.9/sctp-fix-recursive-locking-warning-in-sctp_do_peeloff.patch

7 years, 4 months

1
0
0 0

Patch "bonding: fix the err path for dev hwaddr sync in bond_enslave" has been added to the 4.9-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled bonding: fix the err path for dev hwaddr sync in bond_enslave to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: bonding-fix-the-err-path-for-dev-hwaddr-sync-in-bond_enslave.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Wed Apr 11 10:26:56 CEST 2018 From: Xin Long <lucien.xin(a)gmail.com> Date: Mon, 26 Mar 2018 01:16:45 +0800 Subject: bonding: fix the err path for dev hwaddr sync in bond_enslave From: Xin Long <lucien.xin(a)gmail.com> [ Upstream commit 5c78f6bfae2b10ff70e21d343e64584ea6280c26 ] vlan_vids_add_by_dev is called right after dev hwaddr sync, so on the err path it should unsync dev hwaddr. Otherwise, the slave dev's hwaddr will never be unsync when this err happens. Fixes: 1ff412ad7714 ("bonding: change the bond's vlan syncing functions with the standard ones") Signed-off-by: Xin Long <lucien.xin(a)gmail.com> Reviewed-by: Nikolay Aleksandrov <nikolay(a)cumulusnetworks.com> Acked-by: Andy Gospodarek <andy(a)greyhouse.net> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/net/bonding/bond_main.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1561,7 +1561,7 @@ int bond_enslave(struct net_device *bond if (res) { netdev_err(bond_dev, "Couldn't add bond vlan ids to %s\n", slave_dev->name); - goto err_close; + goto err_hwaddr_unsync; } prev_slave = bond_last_slave(bond); @@ -1749,9 +1749,6 @@ err_unregister: netdev_rx_handler_unregister(slave_dev); err_detach: - if (!bond_uses_primary(bond)) - bond_hw_addr_flush(bond_dev, slave_dev); - vlan_vids_del_by_dev(slave_dev, bond_dev); if (rcu_access_pointer(bond->primary_slave) == new_slave) RCU_INIT_POINTER(bond->primary_slave, NULL); @@ -1765,6 +1762,10 @@ err_detach: synchronize_rcu(); slave_disable_netpoll(new_slave); +err_hwaddr_unsync: + if (!bond_uses_primary(bond)) + bond_hw_addr_flush(bond_dev, slave_dev); + err_close: slave_dev->priv_flags &= ~IFF_BONDING; dev_close(slave_dev); Patches currently in stable-queue which might be from lucien.xin(a)gmail.com are queue-4.9/team-move-dev_mc_sync-after-master_upper_dev_link-in-team_port_add.patch queue-4.9/bonding-process-the-err-returned-by-dev_set_allmulti-properly-in-bond_enslave.patch queue-4.9/bonding-fix-the-err-path-for-dev-hwaddr-sync-in-bond_enslave.patch queue-4.9/bonding-move-dev_mc_sync-after-master_upper_dev_link-in-bond_enslave.patch queue-4.9/route-check-sysctl_fib_multipath_use_neigh-earlier-than-hash.patch queue-4.9/sctp-fix-recursive-locking-warning-in-sctp_do_peeloff.patch

7 years, 4 months

1
0
0 0

Patch "arp: fix arp_filter on l3slave devices" has been added to the 4.9-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled arp: fix arp_filter on l3slave devices to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: arp-fix-arp_filter-on-l3slave-devices.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Wed Apr 11 10:26:56 CEST 2018 From: Miguel Fadon Perlines <mfadon(a)teldat.com> Date: Thu, 5 Apr 2018 10:25:38 +0200 Subject: arp: fix arp_filter on l3slave devices From: Miguel Fadon Perlines <mfadon(a)teldat.com> [ Upstream commit 58b35f27689b5eb514fc293c332966c226b1b6e4 ] arp_filter performs an ip_route_output search for arp source address and checks if output device is the same where the arp request was received, if it is not, the arp request is not answered. This route lookup is always done on main route table so l3slave devices never find the proper route and arp is not answered. Passing l3mdev_master_ifindex_rcu(dev) return value as oif fixes the lookup for l3slave devices while maintaining same behavior for non l3slave devices as this function returns 0 in that case. Fixes: 613d09b30f8b ("net: Use VRF device index for lookups on TX") Signed-off-by: Miguel Fadon Perlines <mfadon(a)teldat.com> Acked-by: David Ahern <dsa(a)cumulusnetworks.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- net/ipv4/arp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/ipv4/arp.c +++ b/net/ipv4/arp.c @@ -437,7 +437,7 @@ static int arp_filter(__be32 sip, __be32 /*unsigned long now; */ struct net *net = dev_net(dev); - rt = ip_route_output(net, sip, tip, 0, 0); + rt = ip_route_output(net, sip, tip, 0, l3mdev_master_ifindex_rcu(dev)); if (IS_ERR(rt)) return 1; if (rt->dst.dev != dev) { Patches currently in stable-queue which might be from mfadon(a)teldat.com are queue-4.9/arp-fix-arp_filter-on-l3slave-devices.patch

7 years, 4 months

1
0
0 0

Re: [PATCH] writeback: safer lock nesting

by Greg Thelen

On Tue, Apr 10, 2018 at 7:44 PM Wang Long <wanglong19(a)meituan.com> wrote: > > Hi, > > > > [This is an automated email] > > > > This commit has been processed by the -stable helper bot and determined > > to be a high probability candidate for -stable trees. (score: 44.5575) > > > > The bot has tested the following trees: v4.16.1, v4.15.16, v4.14.33, v4.9.93, v4.4.127. > > > > v4.16.1: Build OK! > > v4.15.16: Build OK! > > v4.14.33: Build OK! > > v4.9.93: Build OK! > > v4.4.127: Failed to apply! Possible dependencies: > > 62cccb8c8e7a ("mm: simplify lock_page_memcg()") > Hi Sasha, > I test the memory cgroup in lts v4.4, for this issue, 62cccb8c8e7a ("mm: > simplify lock_page_memcg()") > need to adjust and there are several other places that need to be fixed. > I will make the patch for lts v4.4 if no one did. I'm testing a 4.4-stable patch right now. ETA is a few hours.

7 years, 4 months

1
2
0 0

[PATCH v4] writeback: safer lock nesting

by Greg Thelen

lock_page_memcg()/unlock_page_memcg() use spin_lock_irqsave/restore() if the page's memcg is undergoing move accounting, which occurs when a process leaves its memcg for a new one that has memory.move_charge_at_immigrate set. unlocked_inode_to_wb_begin,end() use spin_lock_irq/spin_unlock_irq() if the given inode is switching writeback domains. Switches occur when enough writes are issued from a new domain. This existing pattern is thus suspicious: lock_page_memcg(page); unlocked_inode_to_wb_begin(inode, &locked); ... unlocked_inode_to_wb_end(inode, locked); unlock_page_memcg(page); If both inode switch and process memcg migration are both in-flight then unlocked_inode_to_wb_end() will unconditionally enable interrupts while still holding the lock_page_memcg() irq spinlock. This suggests the possibility of deadlock if an interrupt occurs before unlock_page_memcg(). truncate __cancel_dirty_page lock_page_memcg unlocked_inode_to_wb_begin unlocked_inode_to_wb_end <interrupts mistakenly enabled> <interrupt> end_page_writeback test_clear_page_writeback lock_page_memcg <deadlock> unlock_page_memcg Due to configuration limitations this deadlock is not currently possible because we don't mix cgroup writeback (a cgroupv2 feature) and memory.move_charge_at_immigrate (a cgroupv1 feature). If the kernel is hacked to always claim inode switching and memcg moving_account, then this script triggers lockup in less than a minute: cd /mnt/cgroup/memory mkdir a b echo 1 > a/memory.move_charge_at_immigrate echo 1 > b/memory.move_charge_at_immigrate ( echo $BASHPID > a/cgroup.procs while true; do dd if=/dev/zero of=/mnt/big bs=1M count=256 done ) & while true; do sync done & sleep 1h & SLEEP=$! while true; do echo $SLEEP > a/cgroup.procs echo $SLEEP > b/cgroup.procs done The deadlock does not seem possible, so it's debatable if there's any reason to modify the kernel. I suggest we should to prevent future surprises. And Wang Long said "this deadlock occurs three times in our environment", so there's more reason to apply this, even to stable. Stable 4.4 has minor conflicts applying this patch. For a clean 4.4 patch see "[PATCH for-4.4] writeback: safer lock nesting" https://lkml.org/lkml/2018/4/11/146 Fixes: 682aa8e1a6a1 ("writeback: implement unlocked_inode_to_wb transaction and use it for stat updates") Cc: stable(a)vger.kernel.org # v4.2+ Reported-by: Wang Long <wanglong19(a)meituan.com> Signed-off-by: Greg Thelen <gthelen(a)google.com> Acked-by: Michal Hocko <mhocko(a)suse.com> Acked-by: Wang Long <wanglong19(a)meituan.com> --- Changelog since v3: - initialize wb_lock_cookie wiht {} rather than {0}. - comment grammar fix - commit log footer cleanup (-Change-Id, +Fixes, +Acks, +stable), though patch does not cleanly apply to 4.4. I'll post a 4.4-stable specific patch. Changelog since v2: - explicitly initialize wb_lock_cookie to silence compiler warnings. Changelog since v1: - add wb_lock_cookie to record lock context. fs/fs-writeback.c | 7 ++++--- include/linux/backing-dev-defs.h | 5 +++++ include/linux/backing-dev.h | 31 +++++++++++++++++-------------- mm/page-writeback.c | 18 +++++++++--------- 4 files changed, 35 insertions(+), 26 deletions(-) diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 1280f915079b..b1178acfcb08 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -745,11 +745,12 @@ int inode_congested(struct inode *inode, int cong_bits) */ if (inode && inode_to_wb_is_valid(inode)) { struct bdi_writeback *wb; - bool locked, congested; + struct wb_lock_cookie lock_cookie = {}; + bool congested; - wb = unlocked_inode_to_wb_begin(inode, &locked); + wb = unlocked_inode_to_wb_begin(inode, &lock_cookie); congested = wb_congested(wb, cong_bits); - unlocked_inode_to_wb_end(inode, locked); + unlocked_inode_to_wb_end(inode, &lock_cookie); return congested; } diff --git a/include/linux/backing-dev-defs.h b/include/linux/backing-dev-defs.h index bfe86b54f6c1..0bd432a4d7bd 100644 --- a/include/linux/backing-dev-defs.h +++ b/include/linux/backing-dev-defs.h @@ -223,6 +223,11 @@ static inline void set_bdi_congested(struct backing_dev_info *bdi, int sync) set_wb_congested(bdi->wb.congested, sync); } +struct wb_lock_cookie { + bool locked; + unsigned long flags; +}; + #ifdef CONFIG_CGROUP_WRITEBACK /** diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h index 3e4ce54d84ab..96f4a3ddfb81 100644 --- a/include/linux/backing-dev.h +++ b/include/linux/backing-dev.h @@ -346,7 +346,7 @@ static inline struct bdi_writeback *inode_to_wb(const struct inode *inode) /** * unlocked_inode_to_wb_begin - begin unlocked inode wb access transaction * @inode: target inode - * @lockedp: temp bool output param, to be passed to the end function + * @cookie: output param, to be passed to the end function * * The caller wants to access the wb associated with @inode but isn't * holding inode->i_lock, mapping->tree_lock or wb->list_lock. This @@ -354,12 +354,12 @@ static inline struct bdi_writeback *inode_to_wb(const struct inode *inode) * association doesn't change until the transaction is finished with * unlocked_inode_to_wb_end(). * - * The caller must call unlocked_inode_to_wb_end() with *@lockdep - * afterwards and can't sleep during transaction. IRQ may or may not be - * disabled on return. + * The caller must call unlocked_inode_to_wb_end() with *@cookie afterwards and + * can't sleep during the transaction. IRQs may or may not be disabled on + * return. */ static inline struct bdi_writeback * -unlocked_inode_to_wb_begin(struct inode *inode, bool *lockedp) +unlocked_inode_to_wb_begin(struct inode *inode, struct wb_lock_cookie *cookie) { rcu_read_lock(); @@ -367,10 +367,10 @@ unlocked_inode_to_wb_begin(struct inode *inode, bool *lockedp) * Paired with store_release in inode_switch_wb_work_fn() and * ensures that we see the new wb if we see cleared I_WB_SWITCH. */ - *lockedp = smp_load_acquire(&inode->i_state) & I_WB_SWITCH; + cookie->locked = smp_load_acquire(&inode->i_state) & I_WB_SWITCH; - if (unlikely(*lockedp)) - spin_lock_irq(&inode->i_mapping->tree_lock); + if (unlikely(cookie->locked)) + spin_lock_irqsave(&inode->i_mapping->tree_lock, cookie->flags); /* * Protected by either !I_WB_SWITCH + rcu_read_lock() or tree_lock. @@ -382,12 +382,14 @@ unlocked_inode_to_wb_begin(struct inode *inode, bool *lockedp) /** * unlocked_inode_to_wb_end - end inode wb access transaction * @inode: target inode - * @locked: *@lockedp from unlocked_inode_to_wb_begin() + * @cookie: @cookie from unlocked_inode_to_wb_begin() */ -static inline void unlocked_inode_to_wb_end(struct inode *inode, bool locked) +static inline void unlocked_inode_to_wb_end(struct inode *inode, + struct wb_lock_cookie *cookie) { - if (unlikely(locked)) - spin_unlock_irq(&inode->i_mapping->tree_lock); + if (unlikely(cookie->locked)) + spin_unlock_irqrestore(&inode->i_mapping->tree_lock, + cookie->flags); rcu_read_unlock(); } @@ -434,12 +436,13 @@ static inline struct bdi_writeback *inode_to_wb(struct inode *inode) } static inline struct bdi_writeback * -unlocked_inode_to_wb_begin(struct inode *inode, bool *lockedp) +unlocked_inode_to_wb_begin(struct inode *inode, struct wb_lock_cookie *cookie) { return inode_to_wb(inode); } -static inline void unlocked_inode_to_wb_end(struct inode *inode, bool locked) +static inline void unlocked_inode_to_wb_end(struct inode *inode, + struct wb_lock_cookie *cookie) { } diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 586f31261c83..8369572e1f7d 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -2501,13 +2501,13 @@ void account_page_redirty(struct page *page) if (mapping && mapping_cap_account_dirty(mapping)) { struct inode *inode = mapping->host; struct bdi_writeback *wb; - bool locked; + struct wb_lock_cookie cookie = {}; - wb = unlocked_inode_to_wb_begin(inode, &locked); + wb = unlocked_inode_to_wb_begin(inode, &cookie); current->nr_dirtied--; dec_node_page_state(page, NR_DIRTIED); dec_wb_stat(wb, WB_DIRTIED); - unlocked_inode_to_wb_end(inode, locked); + unlocked_inode_to_wb_end(inode, &cookie); } } EXPORT_SYMBOL(account_page_redirty); @@ -2613,15 +2613,15 @@ void __cancel_dirty_page(struct page *page) if (mapping_cap_account_dirty(mapping)) { struct inode *inode = mapping->host; struct bdi_writeback *wb; - bool locked; + struct wb_lock_cookie cookie = {}; lock_page_memcg(page); - wb = unlocked_inode_to_wb_begin(inode, &locked); + wb = unlocked_inode_to_wb_begin(inode, &cookie); if (TestClearPageDirty(page)) account_page_cleaned(page, mapping, wb); - unlocked_inode_to_wb_end(inode, locked); + unlocked_inode_to_wb_end(inode, &cookie); unlock_page_memcg(page); } else { ClearPageDirty(page); @@ -2653,7 +2653,7 @@ int clear_page_dirty_for_io(struct page *page) if (mapping && mapping_cap_account_dirty(mapping)) { struct inode *inode = mapping->host; struct bdi_writeback *wb; - bool locked; + struct wb_lock_cookie cookie = {}; /* * Yes, Virginia, this is indeed insane. @@ -2690,14 +2690,14 @@ int clear_page_dirty_for_io(struct page *page) * always locked coming in here, so we get the desired * exclusion. */ - wb = unlocked_inode_to_wb_begin(inode, &locked); + wb = unlocked_inode_to_wb_begin(inode, &cookie); if (TestClearPageDirty(page)) { dec_lruvec_page_state(page, NR_FILE_DIRTY); dec_zone_page_state(page, NR_ZONE_WRITE_PENDING); dec_wb_stat(wb, WB_RECLAIMABLE); ret = 1; } - unlocked_inode_to_wb_end(inode, locked); + unlocked_inode_to_wb_end(inode, &cookie); return ret; } return TestClearPageDirty(page); -- 2.17.0.484.g0c8726318c-goog

7 years, 4 months

1
0
0 0

FAILED: patch "[PATCH] vrf: Fix use after free and double free in vrf_finish_output" failed to apply to 4.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 82dd0d2a9a76fc8fa2b18d80b987d455728bf83a Mon Sep 17 00:00:00 2001 From: David Ahern <dsahern(a)gmail.com> Date: Thu, 29 Mar 2018 12:49:52 -0700 Subject: [PATCH] vrf: Fix use after free and double free in vrf_finish_output Miguel reported an skb use after free / double free in vrf_finish_output when neigh_output returns an error. The vrf driver should return after the call to neigh_output as it takes over the skb on error path as well. Patch is a simplified version of Miguel's patch which was written for 4.9, and updated to top of tree. Fixes: 8f58336d3f78a ("net: Add ethernet header for pass through VRF device") Signed-off-by: Miguel Fadon Perlines <mfadon(a)teldat.com> Signed-off-by: David Ahern <dsahern(a)gmail.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index 139c61c8244a..ac40924fe437 100644 --- a/drivers/net/vrf.c +++ b/drivers/net/vrf.c @@ -578,12 +578,13 @@ static int vrf_finish_output(struct net *net, struct sock *sk, struct sk_buff *s if (!IS_ERR(neigh)) { sock_confirm_neigh(skb, neigh); ret = neigh_output(neigh, skb); + rcu_read_unlock_bh(); + return ret; } rcu_read_unlock_bh(); err: - if (unlikely(ret < 0)) - vrf_tx_error(skb->dev, skb); + vrf_tx_error(skb->dev, skb); return ret; }

7 years, 4 months

1
0
0 0

[PATCH 0/4] usb: gadget: udc: renesas_usb3: fix some major issues

by Yoshihiro Shimoda

This patch set is based on v4.16. (I should have realized these issues in v4.16-rc cycle though...) Yoshihiro Shimoda (4): usb: gadget: udc: renesas_usb3: fix double phy_put() usb: gadget: udc: renesas_usb3: should remove debugfs usb: gadget: udc: renesas_usb3: should call pm_runtime_enable() before add udc usb: gadget: udc: renesas_usb3: should call devm_phy_get() before add udc drivers/usb/gadget/udc/renesas_usb3.c | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) -- 1.9.1

7 years, 4 months

3
16
0 0

v4.4.127 build: 3 failures 0 warnings (v4.4.127)

by Build bot for Mark Brown

Tree/Branch: v4.4.127 Git describe: v4.4.127 Commit: 2cad7a1d13 Linux 4.4.127 Build Time: 60 min 20 sec Passed: 7 / 10 ( 70.00 %) Failed: 3 / 10 ( 30.00 %) Errors: 37 Warnings: 0 Section Mismatches: 0 Failed defconfigs: arm-allmodconfig arm-multi_v7_defconfig arm-multi_v5_defconfig Errors: arm-allmodconfig ../net/core/sock.c:724:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:922:7: error: 'SO_ATTACH_BPF' undeclared (first use in this function) ../net/core/sock.c:939:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:978:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:983:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:996:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1002:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1075:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:1233:7: error: 'SO_GET_FILTER' undeclared (first use in this function) ../net/core/sock.c:1240:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1244:7: error: 'SO_BPF_EXTENSIONS' undeclared (first use in this function) ../net/core/sock.c:1248:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1253:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1258:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1262:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) Error: ../arch/arm/boot/dts/uniphier-ph1-pro4-sanji.dts:0.55-1.1 syntax error Error: ../arch/arm/boot/dts/tegra30.dtsi:1.1-9 syntax error Error: ../arch/arm/boot/dts/omap4-panda.dts:10.1-9 syntax error Error: ../arch/arm/boot/dts/tegra20.dtsi:1.1-9 syntax error Error: ../arch/arm/boot/dts/emev2.dtsi:11.1-9 syntax error Error: ../arch/arm/boot/dts/tegra20.dtsi:1.1-9 syntax error Error: ../arch/arm/boot/dts/tegra20.dtsi:1.1-9 syntax error ../arch/arm/boot/dts/omap3-gta04.dts:132:57: error: unterminated comment ../arch/arm/boot/dts/ccu8540.dts:13:23: fatal error: dbx5x0.dtsi: No such file or directory Error: ../arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts:203.16-17 syntax error Error: ../arch/arm/boot/dts/uniphier-ph1-pro4-ace.dts:0.53-1.1 syntax error Error: ../arch/arm/boot/dts/arm-realview-eb-11mp-revb.dts:0.57-1.1 syntax error Error: ../arch/arm/boot/dts/tegra20.dtsi:1.1-9 syntax error Error: ../arch/arm/boot/dts/tegra30.dtsi:1.1-9 syntax error Error: ../arch/arm/boot/dts/tegra20.dtsi:1.1-9 syntax error Error: ../arch/arm/boot/dts/r8a7790.dtsi:13.1-9 syntax error Error: ../arch/arm/boot/dts/omap4.dtsi:9.1-9 syntax error Error: ../arch/arm/boot/dts/vf610-colibri.dts:91.5-6 syntax error ../net/sunrpc/xprtsock.c:1738:38: error: 'SO_REUSEPORT' undeclared (first use in this function) ../arch/arm/include/asm/parport.h:12:22: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'parport_pc_find_isa_ports' ../arch/arm/include/asm/parport.h:13:22: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'parport_pc_find_nonpci_ports' ../drivers/parport/parport_pc.c:3070:2: error: implicit declaration of function 'parport_pc_find_nonpci_ports' [-Werror=implicit-function-declaration] ERROR (phandle_references): Reference to non-existent node or label "tc3589x_gpio" ERROR (phandle_references): Reference to non-existent node or label "tc3589x_gpio" ERROR (phandle_references): Reference to non-existent node or label "tc3589x_gpio" ERROR (phandle_references): Reference to non-existent node or label "tc3589x_gpio" ERROR: Input tree has errors, aborting (use -f to force output) ERROR (phandle_references): Reference to non-existent node or label "tc3589x_gpio" ERROR: Input tree has errors, aborting (use -f to force output) ERROR (phandle_references): Reference to non-existent node or label "mainpllclk" ERROR (phandle_references): Reference to non-existent node or label "refclksys" ERROR (phandle_references): Reference to non-existent node or label "papllclk" ERROR: Input tree has errors, aborting (use -f to force output) arm-multi_v7_defconfig ../net/core/sock.c:724:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:922:7: error: 'SO_ATTACH_BPF' undeclared (first use in this function) ../net/core/sock.c:939:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:978:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:983:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:996:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1002:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1075:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:1233:7: error: 'SO_GET_FILTER' undeclared (first use in this function) ../net/core/sock.c:1240:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1244:7: error: 'SO_BPF_EXTENSIONS' undeclared (first use in this function) ../net/core/sock.c:1248:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1253:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1258:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1262:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/sunrpc/xprtsock.c:1738:38: error: 'SO_REUSEPORT' undeclared (first use in this function) arm-multi_v5_defconfig ../net/core/sock.c:724:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:922:7: error: 'SO_ATTACH_BPF' undeclared (first use in this function) ../net/core/sock.c:939:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:978:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:983:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:996:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1002:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1075:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:1233:7: error: 'SO_GET_FILTER' undeclared (first use in this function) ../net/core/sock.c:1240:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1244:7: error: 'SO_BPF_EXTENSIONS' undeclared (first use in this function) ../net/core/sock.c:1248:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1253:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1258:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1262:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/sunrpc/xprtsock.c:1738:38: error: 'SO_REUSEPORT' undeclared (first use in this function) ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): ------------------------------------------------------------------------------- Errors summary: 37 5 Error: ../arch/arm/boot/dts/tegra20.dtsi:1.1-9 syntax error 5 ERROR (phandle_references): Reference to non-existent node or label "tc3589x_gpio" 3 ERROR: Input tree has errors, aborting (use -f to force output) 3 ../net/sunrpc/xprtsock.c:1738:38: error: 'SO_REUSEPORT' undeclared (first use in this function) 3 ../net/core/sock.c:996:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) 3 ../net/core/sock.c:983:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) 3 ../net/core/sock.c:978:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) 3 ../net/core/sock.c:939:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) 3 ../net/core/sock.c:922:7: error: 'SO_ATTACH_BPF' undeclared (first use in this function) 3 ../net/core/sock.c:724:7: error: 'SO_REUSEPORT' undeclared (first use in this function) 3 ../net/core/sock.c:1262:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) 3 ../net/core/sock.c:1258:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) 3 ../net/core/sock.c:1253:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) 3 ../net/core/sock.c:1248:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) 3 ../net/core/sock.c:1244:7: error: 'SO_BPF_EXTENSIONS' undeclared (first use in this function) 3 ../net/core/sock.c:1240:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) 3 ../net/core/sock.c:1233:7: error: 'SO_GET_FILTER' undeclared (first use in this function) 3 ../net/core/sock.c:1075:7: error: 'SO_REUSEPORT' undeclared (first use in this function) 3 ../net/core/sock.c:1002:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) 2 Error: ../arch/arm/boot/dts/tegra30.dtsi:1.1-9 syntax error 1 Error: ../arch/arm/boot/dts/vf610-colibri.dts:91.5-6 syntax error 1 Error: ../arch/arm/boot/dts/uniphier-ph1-pro4-sanji.dts:0.55-1.1 syntax error 1 Error: ../arch/arm/boot/dts/uniphier-ph1-pro4-ace.dts:0.53-1.1 syntax error 1 Error: ../arch/arm/boot/dts/r8a7790.dtsi:13.1-9 syntax error 1 Error: ../arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts:203.16-17 syntax error 1 Error: ../arch/arm/boot/dts/omap4.dtsi:9.1-9 syntax error 1 Error: ../arch/arm/boot/dts/omap4-panda.dts:10.1-9 syntax error 1 Error: ../arch/arm/boot/dts/emev2.dtsi:11.1-9 syntax error 1 Error: ../arch/arm/boot/dts/arm-realview-eb-11mp-revb.dts:0.57-1.1 syntax error 1 ERROR (phandle_references): Reference to non-existent node or label "refclksys" 1 ERROR (phandle_references): Reference to non-existent node or label "papllclk" 1 ERROR (phandle_references): Reference to non-existent node or label "mainpllclk" 1 ../drivers/parport/parport_pc.c:3070:2: error: implicit declaration of function 'parport_pc_find_nonpci_ports' [-Werror=implicit-function-declaration] 1 ../arch/arm/include/asm/parport.h:13:22: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'parport_pc_find_nonpci_ports' 1 ../arch/arm/include/asm/parport.h:12:22: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'parport_pc_find_isa_ports' 1 ../arch/arm/boot/dts/omap3-gta04.dts:132:57: error: unterminated comment 1 ../arch/arm/boot/dts/ccu8540.dts:13:23: fatal error: dbx5x0.dtsi: No such file or directory =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- arm-allmodconfig : FAIL, 48 errors, 0 warnings, 0 section mismatches Errors: ../net/core/sock.c:724:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:922:7: error: 'SO_ATTACH_BPF' undeclared (first use in this function) ../net/core/sock.c:939:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:978:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:983:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:996:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1002:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1075:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:1233:7: error: 'SO_GET_FILTER' undeclared (first use in this function) ../net/core/sock.c:1240:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1244:7: error: 'SO_BPF_EXTENSIONS' undeclared (first use in this function) ../net/core/sock.c:1248:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1253:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1258:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1262:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) Error: ../arch/arm/boot/dts/uniphier-ph1-pro4-sanji.dts:0.55-1.1 syntax error Error: ../arch/arm/boot/dts/tegra30.dtsi:1.1-9 syntax error Error: ../arch/arm/boot/dts/omap4-panda.dts:10.1-9 syntax error Error: ../arch/arm/boot/dts/tegra20.dtsi:1.1-9 syntax error Error: ../arch/arm/boot/dts/emev2.dtsi:11.1-9 syntax error Error: ../arch/arm/boot/dts/tegra20.dtsi:1.1-9 syntax error Error: ../arch/arm/boot/dts/tegra20.dtsi:1.1-9 syntax error ../arch/arm/boot/dts/omap3-gta04.dts:132:57: error: unterminated comment ../arch/arm/boot/dts/ccu8540.dts:13:23: fatal error: dbx5x0.dtsi: No such file or directory Error: ../arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts:203.16-17 syntax error Error: ../arch/arm/boot/dts/uniphier-ph1-pro4-ace.dts:0.53-1.1 syntax error Error: ../arch/arm/boot/dts/arm-realview-eb-11mp-revb.dts:0.57-1.1 syntax error Error: ../arch/arm/boot/dts/tegra20.dtsi:1.1-9 syntax error Error: ../arch/arm/boot/dts/tegra30.dtsi:1.1-9 syntax error Error: ../arch/arm/boot/dts/tegra20.dtsi:1.1-9 syntax error Error: ../arch/arm/boot/dts/r8a7790.dtsi:13.1-9 syntax error Error: ../arch/arm/boot/dts/omap4.dtsi:9.1-9 syntax error Error: ../arch/arm/boot/dts/vf610-colibri.dts:91.5-6 syntax error ../net/sunrpc/xprtsock.c:1738:38: error: 'SO_REUSEPORT' undeclared (first use in this function) ../arch/arm/include/asm/parport.h:12:22: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'parport_pc_find_isa_ports' ../arch/arm/include/asm/parport.h:13:22: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'parport_pc_find_nonpci_ports' ../drivers/parport/parport_pc.c:3070:2: error: implicit declaration of function 'parport_pc_find_nonpci_ports' [-Werror=implicit-function-declaration] ERROR (phandle_references): Reference to non-existent node or label "tc3589x_gpio" ERROR (phandle_references): Reference to non-existent node or label "tc3589x_gpio" ERROR (phandle_references): Reference to non-existent node or label "tc3589x_gpio" ERROR (phandle_references): Reference to non-existent node or label "tc3589x_gpio" ERROR: Input tree has errors, aborting (use -f to force output) ERROR (phandle_references): Reference to non-existent node or label "tc3589x_gpio" ERROR: Input tree has errors, aborting (use -f to force output) ERROR (phandle_references): Reference to non-existent node or label "mainpllclk" ERROR (phandle_references): Reference to non-existent node or label "refclksys" ERROR (phandle_references): Reference to non-existent node or label "papllclk" ERROR: Input tree has errors, aborting (use -f to force output) ------------------------------------------------------------------------------- arm-multi_v7_defconfig : FAIL, 16 errors, 0 warnings, 0 section mismatches Errors: ../net/core/sock.c:724:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:922:7: error: 'SO_ATTACH_BPF' undeclared (first use in this function) ../net/core/sock.c:939:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:978:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:983:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:996:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1002:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1075:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:1233:7: error: 'SO_GET_FILTER' undeclared (first use in this function) ../net/core/sock.c:1240:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1244:7: error: 'SO_BPF_EXTENSIONS' undeclared (first use in this function) ../net/core/sock.c:1248:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1253:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1258:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1262:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/sunrpc/xprtsock.c:1738:38: error: 'SO_REUSEPORT' undeclared (first use in this function) ------------------------------------------------------------------------------- arm-multi_v5_defconfig : FAIL, 16 errors, 0 warnings, 0 section mismatches Errors: ../net/core/sock.c:724:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:922:7: error: 'SO_ATTACH_BPF' undeclared (first use in this function) ../net/core/sock.c:939:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:978:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:983:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:996:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1002:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1075:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:1233:7: error: 'SO_GET_FILTER' undeclared (first use in this function) ../net/core/sock.c:1240:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1244:7: error: 'SO_BPF_EXTENSIONS' undeclared (first use in this function) ../net/core/sock.c:1248:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1253:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1258:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1262:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/sunrpc/xprtsock.c:1738:38: error: 'SO_REUSEPORT' undeclared (first use in this function) ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm64-allnoconfig arm64-allmodconfig x86_64-defconfig arm-allnoconfig x86_64-allnoconfig x86_64-allmodconfig arm64-defconfig

7 years, 4 months

1
0
0 0

[PATCH v2 1/2] Fix NULL pointer in page_cache_tree_insert

by Matthew Wilcox

From: Matthew Wilcox <mawilcox(a)microsoft.com> f2fs specifies the __GFP_ZERO flag for allocating some of its pages. Unfortunately, the page cache also uses the mapping's GFP flags for allocating radix tree nodes. It always masked off the __GFP_HIGHMEM flag, and masks off __GFP_ZERO in some paths, but not all. That causes radix tree nodes to be allocated with a NULL list_head, which causes backtraces like: [<ffffff80086f4de0>] __list_del_entry+0x30/0xd0 [<ffffff8008362018>] list_lru_del+0xac/0x1ac [<ffffff800830f04c>] page_cache_tree_insert+0xd8/0x110 The __GFP_DMA and __GFP_DMA32 flags would also be able to sneak through if they are ever used. Fix them all by using GFP_RECLAIM_MASK at the innermost location, and remove it from earlier in the callchain. Fixes: 449dd6984d0e ("mm: keep page cache radix tree nodes in check") Reported-by: Chris Fries <cfries(a)google.com> Debugged-by: Minchan Kim <minchan(a)kernel.org> Signed-off-by: Matthew Wilcox <mawilcox(a)microsoft.com> Acked-by: Johannes Weiner <hannes(a)cmpxchg.org> Acked-by: Michal Hocko <mhocko(a)suse.com> Reviewed-by: Jan Kara <jack(a)suse.cz> Cc: stable(a)vger.kernel.org --- mm/filemap.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index c2147682f4c3..1a4bfc5ed3dc 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -785,7 +785,7 @@ int replace_page_cache_page(struct page *old, struct page *new, gfp_t gfp_mask) VM_BUG_ON_PAGE(!PageLocked(new), new); VM_BUG_ON_PAGE(new->mapping, new); - error = radix_tree_preload(gfp_mask & ~__GFP_HIGHMEM); + error = radix_tree_preload(gfp_mask & GFP_RECLAIM_MASK); if (!error) { struct address_space *mapping = old->mapping; void (*freepage)(struct page *); @@ -841,7 +841,7 @@ static int __add_to_page_cache_locked(struct page *page, return error; } - error = radix_tree_maybe_preload(gfp_mask & ~__GFP_HIGHMEM); + error = radix_tree_maybe_preload(gfp_mask & GFP_RECLAIM_MASK); if (error) { if (!huge) mem_cgroup_cancel_charge(page, memcg, false); @@ -1574,8 +1574,7 @@ struct page *pagecache_get_page(struct address_space *mapping, pgoff_t offset, if (fgp_flags & FGP_ACCESSED) __SetPageReferenced(page); - err = add_to_page_cache_lru(page, mapping, offset, - gfp_mask & GFP_RECLAIM_MASK); + err = add_to_page_cache_lru(page, mapping, offset, gfp_mask); if (unlikely(err)) { put_page(page); page = NULL; @@ -2378,7 +2377,7 @@ static int page_cache_read(struct file *file, pgoff_t offset, gfp_t gfp_mask) if (!page) return -ENOMEM; - ret = add_to_page_cache_lru(page, mapping, offset, gfp_mask & GFP_KERNEL); + ret = add_to_page_cache_lru(page, mapping, offset, gfp_mask); if (ret == 0) ret = mapping->a_ops->readpage(file, page); else if (ret == -EEXIST) -- 2.16.3

7 years, 4 months

1
0
0 0

[patch 107/140] fs/reiserfs/journal.c: add missing resierfs_warning() arg

by akpm＠linux-foundation.org

From: Andrew Morton <akpm(a)linux-foundation.org> Subject: fs/reiserfs/journal.c: add missing resierfs_warning() arg One use of the reiserfs_warning() macro in journal_init_dev() is missing a parameter, causing the following warning: REISERFS warning (device loop0): journal_init_dev: Cannot open '%s': %i journal_init_dev: This also causes a WARN_ONCE() warning in the vsprintf code, and then a panic if panic_on_warn is set. Please remove unsupported %/ in format string WARNING: CPU: 1 PID: 4480 at lib/vsprintf.c:2138 format_decode+0x77f/0x830 lib/vsprintf.c:2138 Kernel panic - not syncing: panic_on_warn set ... Just add another string argument to the macro invocation. Addresses https://syzkaller.appspot.com/bug?id=0627d4551fdc39bf1ef5d82cd9eef587047f77… Link: http://lkml.kernel.org/r/d678ebe1-6f54-8090-df4c-b9affad62293@infradead.org Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> Reported-by: <syzbot+6bd77b88c1977c03f584(a)syzkaller.appspotmail.com> Tested-by: Randy Dunlap <rdunlap(a)infradead.org> Acked-by: Jeff Mahoney <jeffm(a)suse.com> Cc: Alexander Viro <viro(a)zeniv.linux.org.uk> Cc: Jan Kara <jack(a)suse.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- fs/reiserfs/journal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN fs/reiserfs/journal.c~fs-reiserfs-journalc-add-missing-resierfs_warning-arg fs/reiserfs/journal.c --- a/fs/reiserfs/journal.c~fs-reiserfs-journalc-add-missing-resierfs_warning-arg +++ a/fs/reiserfs/journal.c @@ -2643,7 +2643,7 @@ static int journal_init_dev(struct super if (IS_ERR(journal->j_dev_bd)) { result = PTR_ERR(journal->j_dev_bd); journal->j_dev_bd = NULL; - reiserfs_warning(super, + reiserfs_warning(super, "sh-457", "journal_init_dev: Cannot open '%s': %i", jdev_name, result); return result; _

7 years, 4 months

1
0
0 0

[patch 085/140] task_struct: only use anon struct under randstruct plugin

by akpm＠linux-foundation.org

From: Kees Cook <keescook(a)chromium.org> Subject: task_struct: only use anon struct under randstruct plugin The original intent for always adding the anonymous struct in task_struct was to make sure we had compiler coverage. However, this caused pathological padding of 40 bytes at the start of task_struct. Instead, move the anonymous struct to being only used when struct layout randomization is enabled. Link: http://lkml.kernel.org/r/20180327213609.GA2964@beast Fixes: 29e48ce87f1e ("task_struct: Allow randomized") Signed-off-by: Kees Cook <keescook(a)chromium.org> Reported-by: Peter Zijlstra <peterz(a)infradead.org> Cc: Peter Zijlstra <peterz(a)infradead.org> Cc: Ingo Molnar <mingo(a)kernel.org> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- include/linux/compiler-clang.h | 3 --- include/linux/compiler-gcc.h | 12 +++--------- 2 files changed, 3 insertions(+), 12 deletions(-) diff -puN include/linux/compiler-clang.h~task_struct-only-use-anon-struct-under-randstruct-plugin include/linux/compiler-clang.h --- a/include/linux/compiler-clang.h~task_struct-only-use-anon-struct-under-randstruct-plugin +++ a/include/linux/compiler-clang.h @@ -17,9 +17,6 @@ */ #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) -#define randomized_struct_fields_start struct { -#define randomized_struct_fields_end }; - /* all clang versions usable with the kernel support KASAN ABI version 5 */ #define KASAN_ABI_VERSION 5 diff -puN include/linux/compiler-gcc.h~task_struct-only-use-anon-struct-under-randstruct-plugin include/linux/compiler-gcc.h --- a/include/linux/compiler-gcc.h~task_struct-only-use-anon-struct-under-randstruct-plugin +++ a/include/linux/compiler-gcc.h @@ -242,6 +242,9 @@ #if defined(RANDSTRUCT_PLUGIN) && !defined(__CHECKER__) #define __randomize_layout __attribute__((randomize_layout)) #define __no_randomize_layout __attribute__((no_randomize_layout)) +/* This anon struct can add padding, so only enable it under randstruct. */ +#define randomized_struct_fields_start struct { +#define randomized_struct_fields_end } __randomize_layout; #endif #endif /* GCC_VERSION >= 40500 */ @@ -256,15 +259,6 @@ */ #define __visible __attribute__((externally_visible)) -/* - * RANDSTRUCT_PLUGIN wants to use an anonymous struct, but it is only - * possible since GCC 4.6. To provide as much build testing coverage - * as possible, this is used for all GCC 4.6+ builds, and not just on - * RANDSTRUCT_PLUGIN builds. - */ -#define randomized_struct_fields_start struct { -#define randomized_struct_fields_end } __randomize_layout; - #endif /* GCC_VERSION >= 40600 */ _

7 years, 4 months

1
0
0 0

[patch 034/140] mm/ksm.c: fix inconsistent accounting of zero pages

by akpm＠linux-foundation.org

From: Claudio Imbrenda <imbrenda(a)linux.vnet.ibm.com> Subject: mm/ksm.c: fix inconsistent accounting of zero pages When using KSM with use_zero_pages, we replace anonymous pages containing only zeroes with actual zero pages, which are not anonymous. We need to do proper accounting of the mm counters, otherwise we will get wrong values in /proc and a BUG message in dmesg when tearing down the mm. Link: http://lkml.kernel.org/r/1522931274-15552-1-git-send-email-imbrenda@linux.v… Fixes: e86c59b1b1 ("mm/ksm: improve deduplication of zero pages with colouring") Signed-off-by: Claudio Imbrenda <imbrenda(a)linux.vnet.ibm.com> Reviewed-by: Andrew Morton <akpm(a)linux-foundation.org> Cc: Andrea Arcangeli <aarcange(a)redhat.com> Cc: Minchan Kim <minchan(a)kernel.org> Cc: Kirill A. Shutemov <kirill.shutemov(a)linux.intel.com> Cc: Hugh Dickins <hughd(a)google.com> Cc: Christian Borntraeger <borntraeger(a)de.ibm.com> Cc: Gerald Schaefer <gerald.schaefer(a)de.ibm.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/ksm.c | 7 +++++++ 1 file changed, 7 insertions(+) diff -puN mm/ksm.c~mm-ksm-fix-inconsistent-accounting-of-zero-pages mm/ksm.c --- a/mm/ksm.c~mm-ksm-fix-inconsistent-accounting-of-zero-pages +++ a/mm/ksm.c @@ -1131,6 +1131,13 @@ static int replace_page(struct vm_area_s } else { newpte = pte_mkspecial(pfn_pte(page_to_pfn(kpage), vma->vm_page_prot)); + /* + * We're replacing an anonymous page with a zero page, which is + * not anonymous. We need to do proper accounting otherwise we + * will get wrong values in /proc, and a BUG message in dmesg + * when tearing down the mm. + */ + dec_mm_counter(mm, MM_ANONPAGES); } flush_cache_page(vma, addr, pte_pfn(*ptep)); _

7 years, 4 months

1
0
0 0

[patch 014/140] mm/hmm: hmm_pfns_bad() was accessing wrong struct

by akpm＠linux-foundation.org

From: Jérôme Glisse <jglisse(a)redhat.com> Subject: mm/hmm: hmm_pfns_bad() was accessing wrong struct The private field of mm_walk struct point to an hmm_vma_walk struct and not to the hmm_range struct desired. Fix to get proper struct pointer. Link: http://lkml.kernel.org/r/20180323005527.758-6-jglisse@redhat.com Signed-off-by: Jérôme Glisse <jglisse(a)redhat.com> Cc: Evgeny Baskakov <ebaskakov(a)nvidia.com> Cc: Ralph Campbell <rcampbell(a)nvidia.com> Cc: Mark Hairgrove <mhairgrove(a)nvidia.com> Cc: John Hubbard <jhubbard(a)nvidia.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/hmm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -puN mm/hmm.c~mm-hmm-hmm_pfns_bad-was-accessing-wrong-struct mm/hmm.c --- a/mm/hmm.c~mm-hmm-hmm_pfns_bad-was-accessing-wrong-struct +++ a/mm/hmm.c @@ -336,7 +336,8 @@ static int hmm_pfns_bad(unsigned long ad unsigned long end, struct mm_walk *walk) { - struct hmm_range *range = walk->private; + struct hmm_vma_walk *hmm_vma_walk = walk->private; + struct hmm_range *range = hmm_vma_walk->range; hmm_pfn_t *pfns = range->pfns; unsigned long i; _

7 years, 4 months

1
0
0 0

[patch 011/140] mm/hmm: fix header file if/else/endif maze

by akpm＠linux-foundation.org

From: Jérôme Glisse <jglisse(a)redhat.com> Subject: mm/hmm: fix header file if/else/endif maze The #if/#else/#endif for IS_ENABLED(CONFIG_HMM) were wrong. Because of this after multiple include there was multiple definition of both hmm_mm_init() and hmm_mm_destroy() leading to build failure if HMM was enabled (CONFIG_HMM set). Link: http://lkml.kernel.org/r/20180323005527.758-3-jglisse@redhat.com Signed-off-by: Jérôme Glisse <jglisse(a)redhat.com> Acked-by: Balbir Singh <bsingharora(a)gmail.com> Cc: Andrew Morton <akpm(a)linux-foundation.org> Cc: Ralph Campbell <rcampbell(a)nvidia.com> Cc: John Hubbard <jhubbard(a)nvidia.com> Cc: Evgeny Baskakov <ebaskakov(a)nvidia.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- include/linux/hmm.h | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff -puN include/linux/hmm.h~mm-hmm-fix-header-file-if-else-endif-maze-v2 include/linux/hmm.h --- a/include/linux/hmm.h~mm-hmm-fix-header-file-if-else-endif-maze-v2 +++ a/include/linux/hmm.h @@ -498,23 +498,16 @@ struct hmm_device { struct hmm_device *hmm_device_new(void *drvdata); void hmm_device_put(struct hmm_device *hmm_device); #endif /* CONFIG_DEVICE_PRIVATE || CONFIG_DEVICE_PUBLIC */ -#endif /* IS_ENABLED(CONFIG_HMM) */ /* Below are for HMM internal use only! Not to be used by device driver! */ -#if IS_ENABLED(CONFIG_HMM_MIRROR) void hmm_mm_destroy(struct mm_struct *mm); static inline void hmm_mm_init(struct mm_struct *mm) { mm->hmm = NULL; } -#else /* IS_ENABLED(CONFIG_HMM_MIRROR) */ -static inline void hmm_mm_destroy(struct mm_struct *mm) {} -static inline void hmm_mm_init(struct mm_struct *mm) {} -#endif /* IS_ENABLED(CONFIG_HMM_MIRROR) */ - - #else /* IS_ENABLED(CONFIG_HMM) */ static inline void hmm_mm_destroy(struct mm_struct *mm) {} static inline void hmm_mm_init(struct mm_struct *mm) {} +#endif /* IS_ENABLED(CONFIG_HMM) */ #endif /* LINUX_HMM_H */ _

7 years, 4 months

1
0
0 0

v4.14.33 build: 6 failures 2 warnings (v4.14.33)

by Build bot for Mark Brown

Tree/Branch: v4.14.33 Git describe: v4.14.33 Commit: b867b7a7e5 Linux 4.14.33 Build Time: 82 min 46 sec Passed: 5 / 11 ( 45.45 %) Failed: 6 / 11 ( 54.55 %) Errors: 75 Warnings: 2 Section Mismatches: 0 Failed defconfigs: arm64-allmodconfig arm-multi_v5_defconfig arm-multi_v7_defconfig arm-allmodconfig x86_64-allmodconfig arm64-defconfig Errors: arm64-allmodconfig Error: ../arch/arm64/boot/dts/socionext/uniphier-ph1-ld20-ref.dts:0.65-1.1 syntax error ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/cec/cec-core.c:234:27: error: 'CEC_CAP_NEEDS_HPD' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/linux/build_bug.h:30:45: error: bit-field '<anonymous>' width not an integer constant ../drivers/media/cec/cec-adap.c:136:22: error: 'CEC_EVENT_FL_DROPPED_EVENTS' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:161:8: error: 'CEC_EVENT_PIN_CEC_LOW' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:167:28: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:694:17: error: 'CEC_MSG_FL_REPLY_TO_FOLLOWERS' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1387:21: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1547:25: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1782:6: error: implicit declaration of function 'cec_is_cdc_only' [-Werror=implicit-function-declaration] ../drivers/media/cec/cec-adap.c:1862:33: error: 'CEC_LOG_ADDRS_FL_ALLOW_RC_PASSTHRU' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:2003:33: error: 'CEC_MSG_FL_REPLY_TO_FOLLOWERS' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/cec/cec-api.c:167:7: error: 'CEC_LOG_ADDRS_FL_ALLOW_RC_PASSTHRU' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:168:7: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:197:31: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:380:23: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:381:29: error: 'CEC_CAP_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:452:10: error: 'CEC_EVENT_PIN_CEC_LOW' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:599:27: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/platform/s5p-cec/s5p_cec.c:232:35: error: 'CEC_CAP_NEEDS_HPD' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/platform/vivid/vivid-cec.c:285:54: error: 'CEC_CAP_MONITOR_PIN' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) arm-multi_v5_defconfig ../net/socket.c:708:28: error: 'SCM_TIMESTAMPING_PKTINFO' undeclared (first use in this function) ../net/socket.c:764:30: error: 'SCM_TIMESTAMPING_OPT_STATS' undeclared (first use in this function) ../net/core/sock.c:727:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:930:7: error: 'SO_ATTACH_BPF' undeclared (first use in this function) ../net/core/sock.c:943:7: error: 'SO_ATTACH_REUSEPORT_CBPF' undeclared (first use in this function) ../net/core/sock.c:956:7: error: 'SO_ATTACH_REUSEPORT_EBPF' undeclared (first use in this function) ../net/core/sock.c:973:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1012:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1017:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1030:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1040:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1044:7: error: 'SO_CNX_ADVICE' undeclared (first use in this function) ../net/core/sock.c:1049:7: error: 'SO_ZEROCOPY' undeclared (first use in this function) ../net/core/sock.c:1144:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:1250:7: error: 'SO_PEERGROUPS' undeclared (first use in this function) ../net/core/sock.c:1323:7: error: 'SO_GET_FILTER' undeclared (first use in this function) ../net/core/sock.c:1330:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1334:7: error: 'SO_BPF_EXTENSIONS' undeclared (first use in this function) ../net/core/sock.c:1338:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1343:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1348:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1352:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1356:7: error: 'SO_MEMINFO' undeclared (first use in this function) ../net/core/sock.c:1373:7: error: 'SO_INCOMING_NAPI_ID' undeclared (first use in this function) ../net/core/sock.c:1383:7: error: 'SO_COOKIE' undeclared (first use in this function) ../net/core/sock.c:1390:7: error: 'SO_ZEROCOPY' undeclared (first use in this function) ../net/core/filter.c:3090:8: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/sunrpc/xprtsock.c:1772:38: error: 'SO_REUSEPORT' undeclared (first use in this function) arm-multi_v7_defconfig ../net/socket.c:708:28: error: 'SCM_TIMESTAMPING_PKTINFO' undeclared (first use in this function) ../net/socket.c:764:30: error: 'SCM_TIMESTAMPING_OPT_STATS' undeclared (first use in this function) ../net/core/sock.c:727:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:930:7: error: 'SO_ATTACH_BPF' undeclared (first use in this function) ../net/core/sock.c:943:7: error: 'SO_ATTACH_REUSEPORT_CBPF' undeclared (first use in this function) ../net/core/sock.c:956:7: error: 'SO_ATTACH_REUSEPORT_EBPF' undeclared (first use in this function) ../net/core/sock.c:973:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1012:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1017:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1030:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1040:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1044:7: error: 'SO_CNX_ADVICE' undeclared (first use in this function) ../net/core/sock.c:1049:7: error: 'SO_ZEROCOPY' undeclared (first use in this function) ../net/core/sock.c:1144:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:1250:7: error: 'SO_PEERGROUPS' undeclared (first use in this function) ../net/core/sock.c:1323:7: error: 'SO_GET_FILTER' undeclared (first use in this function) ../net/core/sock.c:1330:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1334:7: error: 'SO_BPF_EXTENSIONS' undeclared (first use in this function) ../net/core/sock.c:1338:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1343:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1348:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1352:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1356:7: error: 'SO_MEMINFO' undeclared (first use in this function) ../net/core/sock.c:1373:7: error: 'SO_INCOMING_NAPI_ID' undeclared (first use in this function) ../net/core/sock.c:1383:7: error: 'SO_COOKIE' undeclared (first use in this function) ../net/core/sock.c:1390:7: error: 'SO_ZEROCOPY' undeclared (first use in this function) ../net/core/filter.c:3090:8: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/sunrpc/xprtsock.c:1772:38: error: 'SO_REUSEPORT' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) arm-allmodconfig ../net/socket.c:708:28: error: 'SCM_TIMESTAMPING_PKTINFO' undeclared (first use in this function) ../net/socket.c:764:30: error: 'SCM_TIMESTAMPING_OPT_STATS' undeclared (first use in this function) Error: ../arch/arm/boot/dts/tegra20.dtsi:2.1-9 syntax error Error: ../arch/arm/boot/dts/uniphier-proxstream2-gentil.dts:0.59-1.1 syntax error Error: ../arch/arm/boot/dts/tegra20.dtsi:2.1-9 syntax error ../arch/arm/boot/dts/omap3-gta04.dts:132:57: error: unterminated comment Error: ../arch/arm/boot/dts/tegra20.dtsi:2.1-9 syntax error Error: ../arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts:203.16-17 syntax error Error: ../arch/arm/boot/dts/uniphier-ph1-pro4-ref.dts:0.53-1.1 syntax error Error: ../arch/arm/boot/dts/uniphier-ph1-sld8-ref.dts:0.53-1.1 syntax error Error: ../arch/arm/boot/dts/uniphier-ph1-ld6b-ref.dts:0.53-1.1 syntax error Error: ../arch/arm/boot/dts/uniphier-ph1-pro4-ace.dts:0.53-1.1 syntax error Error: ../arch/arm/boot/dts/uniphier-proxstream2-vodka.dts:0.58-1.1 syntax error Error: ../arch/arm/boot/dts/uniphier-ph1-pro4-sanji.dts:0.55-1.1 syntax error Error: ../arch/arm/boot/dts/tegra30.dtsi:2.1-9 syntax error Error: ../arch/arm/boot/dts/uniphier-ph1-ld4-ref.dts:0.52-1.1 syntax error Error: ../arch/arm/boot/dts/tegra20.dtsi:2.1-9 syntax error ../arch/arm/boot/dts/ccu8540.dts:13:23: fatal error: dbx5x0.dtsi: No such file or directory Error: ../arch/arm/boot/dts/r8a7790.dtsi:13.1-9 syntax error Error: ../arch/arm/boot/dts/arm-realview-eb-11mp-revb.dts:0.57-1.1 syntax error Error: ../arch/arm/boot/dts/vf610-colibri.dts:91.5-6 syntax error Error: ../arch/arm/boot/dts/uniphier-ph1-sld3-ref.dts:0.53-1.1 syntax error Error: ../arch/arm/boot/dts/tegra30.dtsi:2.1-9 syntax error Error: ../arch/arm/boot/dts/omap4-panda.dts:10.1-9 syntax error Error: ../arch/arm/boot/dts/tegra20.dtsi:2.1-9 syntax error Error: ../arch/arm/boot/dts/omap4.dtsi:9.1-9 syntax error Error: ../arch/arm/boot/dts/emev2.dtsi:11.1-9 syntax error ../net/core/sock.c:727:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:930:7: error: 'SO_ATTACH_BPF' undeclared (first use in this function) ../net/core/sock.c:943:7: error: 'SO_ATTACH_REUSEPORT_CBPF' undeclared (first use in this function) ../net/core/sock.c:956:7: error: 'SO_ATTACH_REUSEPORT_EBPF' undeclared (first use in this function) ../net/core/sock.c:973:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1012:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1017:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1030:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1040:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1044:7: error: 'SO_CNX_ADVICE' undeclared (first use in this function) ../net/core/sock.c:1049:7: error: 'SO_ZEROCOPY' undeclared (first use in this function) ../net/core/sock.c:1144:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:1250:7: error: 'SO_PEERGROUPS' undeclared (first use in this function) ../net/core/sock.c:1323:7: error: 'SO_GET_FILTER' undeclared (first use in this function) ../net/core/sock.c:1330:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1334:7: error: 'SO_BPF_EXTENSIONS' undeclared (first use in this function) ../net/core/sock.c:1338:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1343:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1348:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1352:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1356:7: error: 'SO_MEMINFO' undeclared (first use in this function) ../net/core/sock.c:1373:7: error: 'SO_INCOMING_NAPI_ID' undeclared (first use in this function) ../net/core/sock.c:1383:7: error: 'SO_COOKIE' undeclared (first use in this function) ../net/core/sock.c:1390:7: error: 'SO_ZEROCOPY' undeclared (first use in this function) ../net/core/filter.c:3090:8: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../net/sunrpc/xprtsock.c:1772:38: error: 'SO_REUSEPORT' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/cec/cec-core.c:234:27: error: 'CEC_CAP_NEEDS_HPD' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/linux/build_bug.h:30:45: error: bit-field '<anonymous>' width not an integer constant ../drivers/media/cec/cec-adap.c:136:22: error: 'CEC_EVENT_FL_DROPPED_EVENTS' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:161:8: error: 'CEC_EVENT_PIN_CEC_LOW' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:167:28: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:694:17: error: 'CEC_MSG_FL_REPLY_TO_FOLLOWERS' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1387:21: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1547:25: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1782:6: error: implicit declaration of function 'cec_is_cdc_only' [-Werror=implicit-function-declaration] ../drivers/media/cec/cec-adap.c:1862:33: error: 'CEC_LOG_ADDRS_FL_ALLOW_RC_PASSTHRU' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:2003:33: error: 'CEC_MSG_FL_REPLY_TO_FOLLOWERS' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/cec/cec-api.c:167:7: error: 'CEC_LOG_ADDRS_FL_ALLOW_RC_PASSTHRU' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:168:7: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:197:31: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:380:23: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:381:29: error: 'CEC_CAP_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:452:10: error: 'CEC_EVENT_PIN_CEC_LOW' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:599:27: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/cec/cec-pin.c:789:37: error: 'CEC_CAP_MONITOR_PIN' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../arch/arm/include/asm/parport.h:12:22: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'parport_pc_find_isa_ports' ../arch/arm/include/asm/parport.h:13:22: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'parport_pc_find_nonpci_ports' ../drivers/parport/parport_pc.c:3070:2: error: implicit declaration of function 'parport_pc_find_nonpci_ports' [-Werror=implicit-function-declaration] ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/platform/s5p-cec/s5p_cec.c:232:35: error: 'CEC_CAP_NEEDS_HPD' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/platform/vivid/vivid-cec.c:285:54: error: 'CEC_CAP_MONITOR_PIN' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ERROR: Input tree has errors, aborting (use -f to force output) ERROR: Input tree has errors, aborting (use -f to force output) ERROR: Input tree has errors, aborting (use -f to force output) x86_64-allmodconfig ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/cec/cec-core.c:234:27: error: 'CEC_CAP_NEEDS_HPD' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/linux/build_bug.h:30:45: error: bit-field '<anonymous>' width not an integer constant ../drivers/media/cec/cec-adap.c:136:22: error: 'CEC_EVENT_FL_DROPPED_EVENTS' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:161:8: error: 'CEC_EVENT_PIN_CEC_LOW' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:167:28: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:694:17: error: 'CEC_MSG_FL_REPLY_TO_FOLLOWERS' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1387:21: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1547:25: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1782:6: error: implicit declaration of function 'cec_is_cdc_only' [-Werror=implicit-function-declaration] ../drivers/media/cec/cec-adap.c:1862:33: error: 'CEC_LOG_ADDRS_FL_ALLOW_RC_PASSTHRU' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:2003:33: error: 'CEC_MSG_FL_REPLY_TO_FOLLOWERS' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/cec/cec-api.c:167:7: error: 'CEC_LOG_ADDRS_FL_ALLOW_RC_PASSTHRU' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:168:7: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:197:31: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:380:23: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:381:29: error: 'CEC_CAP_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:452:10: error: 'CEC_EVENT_PIN_CEC_LOW' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:599:27: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/platform/s5p-cec/s5p_cec.c:232:35: error: 'CEC_CAP_NEEDS_HPD' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/platform/vivid/vivid-cec.c:285:54: error: 'CEC_CAP_MONITOR_PIN' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) arm64-defconfig ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): 1 warnings 0 mismatches : arm64-allmodconfig 1 warnings 0 mismatches : arm-allmodconfig 2 warnings 0 mismatches : x86_64-allmodconfig ------------------------------------------------------------------------------- Errors summary: 75 134 ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) 5 Error: ../arch/arm/boot/dts/tegra20.dtsi:2.1-9 syntax error 3 ERROR: Input tree has errors, aborting (use -f to force output) 3 ../net/sunrpc/xprtsock.c:1772:38: error: 'SO_REUSEPORT' undeclared (first use in this function) 3 ../net/socket.c:764:30: error: 'SCM_TIMESTAMPING_OPT_STATS' undeclared (first use in this function) 3 ../net/socket.c:708:28: error: 'SCM_TIMESTAMPING_PKTINFO' undeclared (first use in this function) 3 ../net/core/sock.c:973:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) 3 ../net/core/sock.c:956:7: error: 'SO_ATTACH_REUSEPORT_EBPF' undeclared (first use in this function) 3 ../net/core/sock.c:943:7: error: 'SO_ATTACH_REUSEPORT_CBPF' undeclared (first use in this function) 3 ../net/core/sock.c:930:7: error: 'SO_ATTACH_BPF' undeclared (first use in this function) 3 ../net/core/sock.c:727:7: error: 'SO_REUSEPORT' undeclared (first use in this function) 3 ../net/core/sock.c:1390:7: error: 'SO_ZEROCOPY' undeclared (first use in this function) 3 ../net/core/sock.c:1383:7: error: 'SO_COOKIE' undeclared (first use in this function) 3 ../net/core/sock.c:1373:7: error: 'SO_INCOMING_NAPI_ID' undeclared (first use in this function) 3 ../net/core/sock.c:1356:7: error: 'SO_MEMINFO' undeclared (first use in this function) 3 ../net/core/sock.c:1352:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) 3 ../net/core/sock.c:1348:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) 3 ../net/core/sock.c:1343:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) 3 ../net/core/sock.c:1338:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) 3 ../net/core/sock.c:1334:7: error: 'SO_BPF_EXTENSIONS' undeclared (first use in this function) 3 ../net/core/sock.c:1330:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) 3 ../net/core/sock.c:1323:7: error: 'SO_GET_FILTER' undeclared (first use in this function) 3 ../net/core/sock.c:1250:7: error: 'SO_PEERGROUPS' undeclared (first use in this function) 3 ../net/core/sock.c:1144:7: error: 'SO_REUSEPORT' undeclared (first use in this function) 3 ../net/core/sock.c:1049:7: error: 'SO_ZEROCOPY' undeclared (first use in this function) 3 ../net/core/sock.c:1044:7: error: 'SO_CNX_ADVICE' undeclared (first use in this function) 3 ../net/core/sock.c:1040:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) 3 ../net/core/sock.c:1030:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) 3 ../net/core/sock.c:1017:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) 3 ../net/core/sock.c:1012:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) 3 ../net/core/filter.c:3090:8: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) 3 ../include/linux/build_bug.h:30:45: error: bit-field '<anonymous>' width not an integer constant 3 ../drivers/media/platform/vivid/vivid-cec.c:285:54: error: 'CEC_CAP_MONITOR_PIN' undeclared (first use in this function) 3 ../drivers/media/platform/s5p-cec/s5p_cec.c:232:35: error: 'CEC_CAP_NEEDS_HPD' undeclared (first use in this function) 3 ../drivers/media/cec/cec-core.c:234:27: error: 'CEC_CAP_NEEDS_HPD' undeclared (first use in this function) 3 ../drivers/media/cec/cec-api.c:599:27: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) 3 ../drivers/media/cec/cec-api.c:452:10: error: 'CEC_EVENT_PIN_CEC_LOW' undeclared (first use in this function) 3 ../drivers/media/cec/cec-api.c:381:29: error: 'CEC_CAP_MONITOR_PIN' undeclared (first use in this function) 3 ../drivers/media/cec/cec-api.c:380:23: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) 3 ../drivers/media/cec/cec-api.c:197:31: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) 3 ../drivers/media/cec/cec-api.c:168:7: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) 3 ../drivers/media/cec/cec-api.c:167:7: error: 'CEC_LOG_ADDRS_FL_ALLOW_RC_PASSTHRU' undeclared (first use in this function) 3 ../drivers/media/cec/cec-adap.c:694:17: error: 'CEC_MSG_FL_REPLY_TO_FOLLOWERS' undeclared (first use in this function) 3 ../drivers/media/cec/cec-adap.c:2003:33: error: 'CEC_MSG_FL_REPLY_TO_FOLLOWERS' undeclared (first use in this function) 3 ../drivers/media/cec/cec-adap.c:1862:33: error: 'CEC_LOG_ADDRS_FL_ALLOW_RC_PASSTHRU' undeclared (first use in this function) 3 ../drivers/media/cec/cec-adap.c:1782:6: error: implicit declaration of function 'cec_is_cdc_only' [-Werror=implicit-function-declaration] 3 ../drivers/media/cec/cec-adap.c:167:28: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) 3 ../drivers/media/cec/cec-adap.c:161:8: error: 'CEC_EVENT_PIN_CEC_LOW' undeclared (first use in this function) 3 ../drivers/media/cec/cec-adap.c:1547:25: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) 3 ../drivers/media/cec/cec-adap.c:1387:21: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) 3 ../drivers/media/cec/cec-adap.c:136:22: error: 'CEC_EVENT_FL_DROPPED_EVENTS' undeclared (first use in this function) 2 Error: ../arch/arm/boot/dts/tegra30.dtsi:2.1-9 syntax error 1 Error: ../arch/arm64/boot/dts/socionext/uniphier-ph1-ld20-ref.dts:0.65-1.1 syntax error 1 Error: ../arch/arm/boot/dts/vf610-colibri.dts:91.5-6 syntax error 1 Error: ../arch/arm/boot/dts/uniphier-proxstream2-vodka.dts:0.58-1.1 syntax error 1 Error: ../arch/arm/boot/dts/uniphier-proxstream2-gentil.dts:0.59-1.1 syntax error 1 Error: ../arch/arm/boot/dts/uniphier-ph1-sld8-ref.dts:0.53-1.1 syntax error 1 Error: ../arch/arm/boot/dts/uniphier-ph1-sld3-ref.dts:0.53-1.1 syntax error 1 Error: ../arch/arm/boot/dts/uniphier-ph1-pro4-sanji.dts:0.55-1.1 syntax error 1 Error: ../arch/arm/boot/dts/uniphier-ph1-pro4-ref.dts:0.53-1.1 syntax error 1 Error: ../arch/arm/boot/dts/uniphier-ph1-pro4-ace.dts:0.53-1.1 syntax error 1 Error: ../arch/arm/boot/dts/uniphier-ph1-ld6b-ref.dts:0.53-1.1 syntax error 1 Error: ../arch/arm/boot/dts/uniphier-ph1-ld4-ref.dts:0.52-1.1 syntax error 1 Error: ../arch/arm/boot/dts/r8a7790.dtsi:13.1-9 syntax error 1 Error: ../arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts:203.16-17 syntax error 1 Error: ../arch/arm/boot/dts/omap4.dtsi:9.1-9 syntax error 1 Error: ../arch/arm/boot/dts/omap4-panda.dts:10.1-9 syntax error 1 Error: ../arch/arm/boot/dts/emev2.dtsi:11.1-9 syntax error 1 Error: ../arch/arm/boot/dts/arm-realview-eb-11mp-revb.dts:0.57-1.1 syntax error 1 ../drivers/parport/parport_pc.c:3070:2: error: implicit declaration of function 'parport_pc_find_nonpci_ports' [-Werror=implicit-function-declaration] 1 ../drivers/media/cec/cec-pin.c:789:37: error: 'CEC_CAP_MONITOR_PIN' undeclared (first use in this function) 1 ../arch/arm/include/asm/parport.h:13:22: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'parport_pc_find_nonpci_ports' 1 ../arch/arm/include/asm/parport.h:12:22: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'parport_pc_find_isa_ports' 1 ../arch/arm/boot/dts/omap3-gta04.dts:132:57: error: unterminated comment 1 ../arch/arm/boot/dts/ccu8540.dts:13:23: fatal error: dbx5x0.dtsi: No such file or directory Warnings Summary: 2 3 ../drivers/media/cec/cec-adap.c:88:18: warning: unused variable 'max_events' [-Wunused-variable] 1 drivers/target/iscsi/.tmp_iscsi_target.o: warning: objtool: iscsit_handle_task_mgt_cmd()+0x78f: sibling call from callable instruction with modified stack frame =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- arm64-allmodconfig : FAIL, 55 errors, 1 warnings, 0 section mismatches Errors: Error: ../arch/arm64/boot/dts/socionext/uniphier-ph1-ld20-ref.dts:0.65-1.1 syntax error ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/cec/cec-core.c:234:27: error: 'CEC_CAP_NEEDS_HPD' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/linux/build_bug.h:30:45: error: bit-field '<anonymous>' width not an integer constant ../drivers/media/cec/cec-adap.c:136:22: error: 'CEC_EVENT_FL_DROPPED_EVENTS' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:161:8: error: 'CEC_EVENT_PIN_CEC_LOW' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:167:28: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:694:17: error: 'CEC_MSG_FL_REPLY_TO_FOLLOWERS' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1387:21: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1547:25: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1782:6: error: implicit declaration of function 'cec_is_cdc_only' [-Werror=implicit-function-declaration] ../drivers/media/cec/cec-adap.c:1862:33: error: 'CEC_LOG_ADDRS_FL_ALLOW_RC_PASSTHRU' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:2003:33: error: 'CEC_MSG_FL_REPLY_TO_FOLLOWERS' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/cec/cec-api.c:167:7: error: 'CEC_LOG_ADDRS_FL_ALLOW_RC_PASSTHRU' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:168:7: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:197:31: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:380:23: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:381:29: error: 'CEC_CAP_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:452:10: error: 'CEC_EVENT_PIN_CEC_LOW' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:599:27: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/platform/s5p-cec/s5p_cec.c:232:35: error: 'CEC_CAP_NEEDS_HPD' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/platform/vivid/vivid-cec.c:285:54: error: 'CEC_CAP_MONITOR_PIN' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) Warnings: ../drivers/media/cec/cec-adap.c:88:18: warning: unused variable 'max_events' [-Wunused-variable] ------------------------------------------------------------------------------- arm-multi_v5_defconfig : FAIL, 28 errors, 0 warnings, 0 section mismatches Errors: ../net/socket.c:708:28: error: 'SCM_TIMESTAMPING_PKTINFO' undeclared (first use in this function) ../net/socket.c:764:30: error: 'SCM_TIMESTAMPING_OPT_STATS' undeclared (first use in this function) ../net/core/sock.c:727:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:930:7: error: 'SO_ATTACH_BPF' undeclared (first use in this function) ../net/core/sock.c:943:7: error: 'SO_ATTACH_REUSEPORT_CBPF' undeclared (first use in this function) ../net/core/sock.c:956:7: error: 'SO_ATTACH_REUSEPORT_EBPF' undeclared (first use in this function) ../net/core/sock.c:973:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1012:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1017:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1030:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1040:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1044:7: error: 'SO_CNX_ADVICE' undeclared (first use in this function) ../net/core/sock.c:1049:7: error: 'SO_ZEROCOPY' undeclared (first use in this function) ../net/core/sock.c:1144:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:1250:7: error: 'SO_PEERGROUPS' undeclared (first use in this function) ../net/core/sock.c:1323:7: error: 'SO_GET_FILTER' undeclared (first use in this function) ../net/core/sock.c:1330:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1334:7: error: 'SO_BPF_EXTENSIONS' undeclared (first use in this function) ../net/core/sock.c:1338:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1343:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1348:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1352:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1356:7: error: 'SO_MEMINFO' undeclared (first use in this function) ../net/core/sock.c:1373:7: error: 'SO_INCOMING_NAPI_ID' undeclared (first use in this function) ../net/core/sock.c:1383:7: error: 'SO_COOKIE' undeclared (first use in this function) ../net/core/sock.c:1390:7: error: 'SO_ZEROCOPY' undeclared (first use in this function) ../net/core/filter.c:3090:8: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/sunrpc/xprtsock.c:1772:38: error: 'SO_REUSEPORT' undeclared (first use in this function) ------------------------------------------------------------------------------- arm-multi_v7_defconfig : FAIL, 51 errors, 0 warnings, 0 section mismatches Errors: ../net/socket.c:708:28: error: 'SCM_TIMESTAMPING_PKTINFO' undeclared (first use in this function) ../net/socket.c:764:30: error: 'SCM_TIMESTAMPING_OPT_STATS' undeclared (first use in this function) ../net/core/sock.c:727:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:930:7: error: 'SO_ATTACH_BPF' undeclared (first use in this function) ../net/core/sock.c:943:7: error: 'SO_ATTACH_REUSEPORT_CBPF' undeclared (first use in this function) ../net/core/sock.c:956:7: error: 'SO_ATTACH_REUSEPORT_EBPF' undeclared (first use in this function) ../net/core/sock.c:973:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1012:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1017:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1030:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1040:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1044:7: error: 'SO_CNX_ADVICE' undeclared (first use in this function) ../net/core/sock.c:1049:7: error: 'SO_ZEROCOPY' undeclared (first use in this function) ../net/core/sock.c:1144:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:1250:7: error: 'SO_PEERGROUPS' undeclared (first use in this function) ../net/core/sock.c:1323:7: error: 'SO_GET_FILTER' undeclared (first use in this function) ../net/core/sock.c:1330:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1334:7: error: 'SO_BPF_EXTENSIONS' undeclared (first use in this function) ../net/core/sock.c:1338:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1343:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1348:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1352:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1356:7: error: 'SO_MEMINFO' undeclared (first use in this function) ../net/core/sock.c:1373:7: error: 'SO_INCOMING_NAPI_ID' undeclared (first use in this function) ../net/core/sock.c:1383:7: error: 'SO_COOKIE' undeclared (first use in this function) ../net/core/sock.c:1390:7: error: 'SO_ZEROCOPY' undeclared (first use in this function) ../net/core/filter.c:3090:8: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/sunrpc/xprtsock.c:1772:38: error: 'SO_REUSEPORT' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ------------------------------------------------------------------------------- arm-allmodconfig : FAIL, 121 errors, 1 warnings, 0 section mismatches Errors: ../net/socket.c:708:28: error: 'SCM_TIMESTAMPING_PKTINFO' undeclared (first use in this function) ../net/socket.c:764:30: error: 'SCM_TIMESTAMPING_OPT_STATS' undeclared (first use in this function) Error: ../arch/arm/boot/dts/tegra20.dtsi:2.1-9 syntax error Error: ../arch/arm/boot/dts/uniphier-proxstream2-gentil.dts:0.59-1.1 syntax error Error: ../arch/arm/boot/dts/tegra20.dtsi:2.1-9 syntax error ../arch/arm/boot/dts/omap3-gta04.dts:132:57: error: unterminated comment Error: ../arch/arm/boot/dts/tegra20.dtsi:2.1-9 syntax error Error: ../arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts:203.16-17 syntax error Error: ../arch/arm/boot/dts/uniphier-ph1-pro4-ref.dts:0.53-1.1 syntax error Error: ../arch/arm/boot/dts/uniphier-ph1-sld8-ref.dts:0.53-1.1 syntax error Error: ../arch/arm/boot/dts/uniphier-ph1-ld6b-ref.dts:0.53-1.1 syntax error Error: ../arch/arm/boot/dts/uniphier-ph1-pro4-ace.dts:0.53-1.1 syntax error Error: ../arch/arm/boot/dts/uniphier-proxstream2-vodka.dts:0.58-1.1 syntax error Error: ../arch/arm/boot/dts/uniphier-ph1-pro4-sanji.dts:0.55-1.1 syntax error Error: ../arch/arm/boot/dts/tegra30.dtsi:2.1-9 syntax error Error: ../arch/arm/boot/dts/uniphier-ph1-ld4-ref.dts:0.52-1.1 syntax error Error: ../arch/arm/boot/dts/tegra20.dtsi:2.1-9 syntax error ../arch/arm/boot/dts/ccu8540.dts:13:23: fatal error: dbx5x0.dtsi: No such file or directory Error: ../arch/arm/boot/dts/r8a7790.dtsi:13.1-9 syntax error Error: ../arch/arm/boot/dts/arm-realview-eb-11mp-revb.dts:0.57-1.1 syntax error Error: ../arch/arm/boot/dts/vf610-colibri.dts:91.5-6 syntax error Error: ../arch/arm/boot/dts/uniphier-ph1-sld3-ref.dts:0.53-1.1 syntax error Error: ../arch/arm/boot/dts/tegra30.dtsi:2.1-9 syntax error Error: ../arch/arm/boot/dts/omap4-panda.dts:10.1-9 syntax error Error: ../arch/arm/boot/dts/tegra20.dtsi:2.1-9 syntax error Error: ../arch/arm/boot/dts/omap4.dtsi:9.1-9 syntax error Error: ../arch/arm/boot/dts/emev2.dtsi:11.1-9 syntax error ../net/core/sock.c:727:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:930:7: error: 'SO_ATTACH_BPF' undeclared (first use in this function) ../net/core/sock.c:943:7: error: 'SO_ATTACH_REUSEPORT_CBPF' undeclared (first use in this function) ../net/core/sock.c:956:7: error: 'SO_ATTACH_REUSEPORT_EBPF' undeclared (first use in this function) ../net/core/sock.c:973:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1012:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1017:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1030:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1040:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1044:7: error: 'SO_CNX_ADVICE' undeclared (first use in this function) ../net/core/sock.c:1049:7: error: 'SO_ZEROCOPY' undeclared (first use in this function) ../net/core/sock.c:1144:7: error: 'SO_REUSEPORT' undeclared (first use in this function) ../net/core/sock.c:1250:7: error: 'SO_PEERGROUPS' undeclared (first use in this function) ../net/core/sock.c:1323:7: error: 'SO_GET_FILTER' undeclared (first use in this function) ../net/core/sock.c:1330:7: error: 'SO_LOCK_FILTER' undeclared (first use in this function) ../net/core/sock.c:1334:7: error: 'SO_BPF_EXTENSIONS' undeclared (first use in this function) ../net/core/sock.c:1338:7: error: 'SO_SELECT_ERR_QUEUE' undeclared (first use in this function) ../net/core/sock.c:1343:7: error: 'SO_BUSY_POLL' undeclared (first use in this function) ../net/core/sock.c:1348:7: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../net/core/sock.c:1352:7: error: 'SO_INCOMING_CPU' undeclared (first use in this function) ../net/core/sock.c:1356:7: error: 'SO_MEMINFO' undeclared (first use in this function) ../net/core/sock.c:1373:7: error: 'SO_INCOMING_NAPI_ID' undeclared (first use in this function) ../net/core/sock.c:1383:7: error: 'SO_COOKIE' undeclared (first use in this function) ../net/core/sock.c:1390:7: error: 'SO_ZEROCOPY' undeclared (first use in this function) ../net/core/filter.c:3090:8: error: 'SO_MAX_PACING_RATE' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../net/sunrpc/xprtsock.c:1772:38: error: 'SO_REUSEPORT' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/cec/cec-core.c:234:27: error: 'CEC_CAP_NEEDS_HPD' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/linux/build_bug.h:30:45: error: bit-field '<anonymous>' width not an integer constant ../drivers/media/cec/cec-adap.c:136:22: error: 'CEC_EVENT_FL_DROPPED_EVENTS' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:161:8: error: 'CEC_EVENT_PIN_CEC_LOW' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:167:28: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:694:17: error: 'CEC_MSG_FL_REPLY_TO_FOLLOWERS' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1387:21: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1547:25: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1782:6: error: implicit declaration of function 'cec_is_cdc_only' [-Werror=implicit-function-declaration] ../drivers/media/cec/cec-adap.c:1862:33: error: 'CEC_LOG_ADDRS_FL_ALLOW_RC_PASSTHRU' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:2003:33: error: 'CEC_MSG_FL_REPLY_TO_FOLLOWERS' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/cec/cec-api.c:167:7: error: 'CEC_LOG_ADDRS_FL_ALLOW_RC_PASSTHRU' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:168:7: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:197:31: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:380:23: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:381:29: error: 'CEC_CAP_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:452:10: error: 'CEC_EVENT_PIN_CEC_LOW' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:599:27: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/cec/cec-pin.c:789:37: error: 'CEC_CAP_MONITOR_PIN' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../arch/arm/include/asm/parport.h:12:22: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'parport_pc_find_isa_ports' ../arch/arm/include/asm/parport.h:13:22: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'parport_pc_find_nonpci_ports' ../drivers/parport/parport_pc.c:3070:2: error: implicit declaration of function 'parport_pc_find_nonpci_ports' [-Werror=implicit-function-declaration] ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/platform/s5p-cec/s5p_cec.c:232:35: error: 'CEC_CAP_NEEDS_HPD' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/platform/vivid/vivid-cec.c:285:54: error: 'CEC_CAP_MONITOR_PIN' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ERROR: Input tree has errors, aborting (use -f to force output) ERROR: Input tree has errors, aborting (use -f to force output) ERROR: Input tree has errors, aborting (use -f to force output) Warnings: ../drivers/media/cec/cec-adap.c:88:18: warning: unused variable 'max_events' [-Wunused-variable] ------------------------------------------------------------------------------- x86_64-allmodconfig : FAIL, 53 errors, 2 warnings, 0 section mismatches Errors: ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/cec/cec-core.c:234:27: error: 'CEC_CAP_NEEDS_HPD' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/linux/build_bug.h:30:45: error: bit-field '<anonymous>' width not an integer constant ../drivers/media/cec/cec-adap.c:136:22: error: 'CEC_EVENT_FL_DROPPED_EVENTS' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:161:8: error: 'CEC_EVENT_PIN_CEC_LOW' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:167:28: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:694:17: error: 'CEC_MSG_FL_REPLY_TO_FOLLOWERS' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1387:21: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1547:25: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:1782:6: error: implicit declaration of function 'cec_is_cdc_only' [-Werror=implicit-function-declaration] ../drivers/media/cec/cec-adap.c:1862:33: error: 'CEC_LOG_ADDRS_FL_ALLOW_RC_PASSTHRU' undeclared (first use in this function) ../drivers/media/cec/cec-adap.c:2003:33: error: 'CEC_MSG_FL_REPLY_TO_FOLLOWERS' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/cec/cec-api.c:167:7: error: 'CEC_LOG_ADDRS_FL_ALLOW_RC_PASSTHRU' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:168:7: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:197:31: error: 'CEC_LOG_ADDRS_FL_CDC_ONLY' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:380:23: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:381:29: error: 'CEC_CAP_MONITOR_PIN' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:452:10: error: 'CEC_EVENT_PIN_CEC_LOW' undeclared (first use in this function) ../drivers/media/cec/cec-api.c:599:27: error: 'CEC_MODE_MONITOR_PIN' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/platform/s5p-cec/s5p_cec.c:232:35: error: 'CEC_CAP_NEEDS_HPD' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../drivers/media/platform/vivid/vivid-cec.c:285:54: error: 'CEC_CAP_MONITOR_PIN' undeclared (first use in this function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) Warnings: ../drivers/media/cec/cec-adap.c:88:18: warning: unused variable 'max_events' [-Wunused-variable] drivers/target/iscsi/.tmp_iscsi_target.o: warning: objtool: iscsit_handle_task_mgt_cmd()+0x78f: sibling call from callable instruction with modified stack frame ------------------------------------------------------------------------------- arm64-defconfig : FAIL, 3 errors, 0 warnings, 0 section mismatches Errors: ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ../include/media/cec.h:94:24: error: 'CEC_EVENT_PIN_CEC_HIGH' undeclared here (not in a function) ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: x86_64-allnoconfig arm64-allnoconfig arm-allnoconfig arm-multi_v4t_defconfig x86_64-defconfig

7 years, 4 months

1
0
0 0

[PATCH 0/5] libnvdimm: fix locked status detection

by Dan Williams

The new ACPI _LSx methods moved the 'dimm locked' error status from the result of ND_CMD_GET_CONFIG_SIZE to an error status result of ND_CMD_GET_CONFIG_DATA. Error code translation prevents the proper error code from making it back to the 'nd_dimm' driver. Fix the error code propagation and add some unit test infrastructure for regression testing this case. --- Dan Williams (5): libnvdimm, dimm: handle EACCES failures from label reads tools/testing/nvdimm: allow custom error code injection tools/testing/nvdimm: support nfit_test_dimm attributes under nfit_test.1 tools/testing/nvdimm: fix missing newline in nfit_test_dimm 'handle' attribute tools/testing/nvdimm: enable labels for nfit_test.1 dimms drivers/nvdimm/dimm_devs.c | 22 +++++----- tools/testing/nvdimm/test/nfit.c | 84 +++++++++++++++++++++++++++++--------- 2 files changed, 77 insertions(+), 29 deletions(-)

7 years, 4 months

1
1
0 0

[PATCHES] Networking

by David Miller

Please queue up the following networking bug fixes for v4.14, v4.15, and v4.16 -stable, respectively. Thank you!

7 years, 4 months

2
1
0 0

Patch "clk: at91: fix clk-generated compilation" has been added to the 4.9-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled clk: at91: fix clk-generated compilation to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: clk-at91-fix-clk-generated-compilation.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From 4a5f06a01cfd1f7a9141bdb760bf5b68cca7f224 Mon Sep 17 00:00:00 2001 From: Alexandre Belloni <alexandre.belloni(a)free-electrons.com> Date: Mon, 5 Jun 2017 00:02:57 +0200 Subject: clk: at91: fix clk-generated compilation From: Alexandre Belloni <alexandre.belloni(a)free-electrons.com> commit 4a5f06a01cfd1f7a9141bdb760bf5b68cca7f224 upstream. Fix missing } Signed-off-by: Alexandre Belloni <alexandre.belloni(a)free-electrons.com> Signed-off-by: Stephen Boyd <sboyd(a)codeaurora.org> Cc: Amit Pundir <amit.pundir(a)linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/clk/at91/clk-generated.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/clk/at91/clk-generated.c +++ b/drivers/clk/at91/clk-generated.c @@ -266,6 +266,7 @@ at91_clk_register_generated(struct regma if (ret) { kfree(gck); hw = ERR_PTR(ret); + } return hw; } Patches currently in stable-queue which might be from alexandre.belloni(a)free-electrons.com are queue-4.9/clk-at91-fix-clk-generated-parenting.patch queue-4.9/rtc-interface-validate-alarm-time-before-handling-rollover.patch queue-4.9/rtc-m41t80-fix-sqw-dividers-override-when-setting-a-date.patch queue-4.9/rtc-snvs-fix-an-incorrect-check-of-return-value.patch queue-4.9/clk-at91-fix-clk-generated-compilation.patch queue-4.9/rtc-opal-handle-disabled-tpo-in-opal_get_tpo_time.patch

7 years, 4 months

1
0
0 0

Patch "vlan: also check phy_driver ts_info for vlan's real device" has been added to the 4.16-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled vlan: also check phy_driver ts_info for vlan's real device to the 4.16-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: vlan-also-check-phy_driver-ts_info-for-vlan-s-real-device.patch and it can be found in the queue-4.16 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Tue Apr 10 23:19:25 CEST 2018 From: Hangbin Liu <liuhangbin(a)gmail.com> Date: Fri, 30 Mar 2018 09:44:00 +0800 Subject: vlan: also check phy_driver ts_info for vlan's real device From: Hangbin Liu <liuhangbin(a)gmail.com> [ Upstream commit ec1d8ccb07deaf30fd0508af6755364ac47dc08d ] Just like function ethtool_get_ts_info(), we should also consider the phy_driver ts_info call back. For example, driver dp83640. Fixes: 37dd9255b2f6 ("vlan: Pass ethtool get_ts_info queries to real device.") Acked-by: Richard Cochran <richardcochran(a)gmail.com> Signed-off-by: Hangbin Liu <liuhangbin(a)gmail.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- net/8021q/vlan_dev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c @@ -29,6 +29,7 @@ #include <linux/net_tstamp.h> #include <linux/etherdevice.h> #include <linux/ethtool.h> +#include <linux/phy.h> #include <net/arp.h> #include <net/switchdev.h> @@ -665,8 +666,11 @@ static int vlan_ethtool_get_ts_info(stru { const struct vlan_dev_priv *vlan = vlan_dev_priv(dev); const struct ethtool_ops *ops = vlan->real_dev->ethtool_ops; + struct phy_device *phydev = vlan->real_dev->phydev; - if (ops->get_ts_info) { + if (phydev && phydev->drv && phydev->drv->ts_info) { + return phydev->drv->ts_info(phydev, info); + } else if (ops->get_ts_info) { return ops->get_ts_info(vlan->real_dev, info); } else { info->so_timestamping = SOF_TIMESTAMPING_RX_SOFTWARE | Patches currently in stable-queue which might be from liuhangbin(a)gmail.com are queue-4.16/vlan-also-check-phy_driver-ts_info-for-vlan-s-real-device.patch

7 years, 4 months

1
0
0 0

Patch "sky2: Increase D3 delay to sky2 stops working after suspend" has been added to the 4.16-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled sky2: Increase D3 delay to sky2 stops working after suspend to the 4.16-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: sky2-increase-d3-delay-to-sky2-stops-working-after-suspend.patch and it can be found in the queue-4.16 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Tue Apr 10 23:19:25 CEST 2018 From: Kai-Heng Feng <kai.heng.feng(a)canonical.com> Date: Sat, 31 Mar 2018 23:42:03 +0800 Subject: sky2: Increase D3 delay to sky2 stops working after suspend From: Kai-Heng Feng <kai.heng.feng(a)canonical.com> [ Upstream commit afb133637071be6deeb8b3d0e55593ffbf63c527 ] The sky2 ethernet stops working after system resume from suspend: [ 582.852065] sky2 0000:04:00.0: Refused to change power state, currently in D3 The current 150ms delay is not enough, change it to 200ms can solve the issue. BugLink: https://bugs.launchpad.net/bugs/1758507 Cc: Stable <stable(a)vger.kernel.org> Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/net/ethernet/marvell/sky2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/marvell/sky2.c +++ b/drivers/net/ethernet/marvell/sky2.c @@ -5087,7 +5087,7 @@ static int sky2_probe(struct pci_dev *pd INIT_WORK(&hw->restart_work, sky2_restart); pci_set_drvdata(pdev, hw); - pdev->d3_delay = 150; + pdev->d3_delay = 200; return 0; Patches currently in stable-queue which might be from kai.heng.feng(a)canonical.com are queue-4.16/sky2-increase-d3-delay-to-sky2-stops-working-after-suspend.patch

7 years, 4 months

1
0
0 0

Patch "vti6: better validate user provided tunnel names" has been added to the 4.16-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled vti6: better validate user provided tunnel names to the 4.16-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: vti6-better-validate-user-provided-tunnel-names.patch and it can be found in the queue-4.16 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Tue Apr 10 23:19:25 CEST 2018 From: Eric Dumazet <edumazet(a)google.com> Date: Thu, 5 Apr 2018 06:39:31 -0700 Subject: vti6: better validate user provided tunnel names From: Eric Dumazet <edumazet(a)google.com> [ Upstream commit 537b361fbcbcc3cd6fe2bb47069fd292b9256d16 ] Use valid_name() to make sure user does not provide illegal device name. Fixes: ed1efb2aefbb ("ipv6: Add support for IPsec virtual tunnel interfaces") Signed-off-by: Eric Dumazet <edumazet(a)google.com> Cc: Steffen Klassert <steffen.klassert(a)secunet.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- net/ipv6/ip6_vti.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) --- a/net/ipv6/ip6_vti.c +++ b/net/ipv6/ip6_vti.c @@ -212,10 +212,13 @@ static struct ip6_tnl *vti6_tnl_create(s char name[IFNAMSIZ]; int err; - if (p->name[0]) + if (p->name[0]) { + if (!dev_valid_name(p->name)) + goto failed; strlcpy(name, p->name, IFNAMSIZ); - else + } else { sprintf(name, "ip6_vti%%d"); + } dev = alloc_netdev(sizeof(*t), name, NET_NAME_UNKNOWN, vti6_dev_setup); if (!dev) Patches currently in stable-queue which might be from edumazet(a)google.com are queue-4.16/sctp-sctp_sockaddr_af-must-check-minimal-addr-length-for-af_inet6.patch queue-4.16/pptp-remove-a-buggy-dst-release-in-pptp_connect.patch queue-4.16/net-fool-proof-dev_valid_name.patch queue-4.16/vti6-better-validate-user-provided-tunnel-names.patch queue-4.16/ipv6-sit-better-validate-user-provided-tunnel-names.patch queue-4.16/ip6_tunnel-better-validate-user-provided-tunnel-names.patch queue-4.16/sctp-do-not-leak-kernel-memory-to-user-space.patch queue-4.16/ip_tunnel-better-validate-user-provided-tunnel-names.patch queue-4.16/ip6_gre-better-validate-user-provided-tunnel-names.patch

7 years, 4 months

1
0
0 0

Patch "sctp: sctp_sockaddr_af must check minimal addr length for AF_INET6" has been added to the 4.16-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled sctp: sctp_sockaddr_af must check minimal addr length for AF_INET6 to the 4.16-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: sctp-sctp_sockaddr_af-must-check-minimal-addr-length-for-af_inet6.patch and it can be found in the queue-4.16 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Tue Apr 10 23:19:25 CEST 2018 From: Eric Dumazet <edumazet(a)google.com> Date: Sun, 8 Apr 2018 07:52:08 -0700 Subject: sctp: sctp_sockaddr_af must check minimal addr length for AF_INET6 From: Eric Dumazet <edumazet(a)google.com> [ Upstream commit 81e98370293afcb58340ce8bd71af7b97f925c26 ] Check must happen before call to ipv6_addr_v4mapped() syzbot report was : BUG: KMSAN: uninit-value in sctp_sockaddr_af net/sctp/socket.c:359 [inline] BUG: KMSAN: uninit-value in sctp_do_bind+0x60f/0xdc0 net/sctp/socket.c:384 CPU: 0 PID: 3576 Comm: syzkaller968804 Not tainted 4.16.0+ #82 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x185/0x1d0 lib/dump_stack.c:53 kmsan_report+0x142/0x240 mm/kmsan/kmsan.c:1067 __msan_warning_32+0x6c/0xb0 mm/kmsan/kmsan_instr.c:676 sctp_sockaddr_af net/sctp/socket.c:359 [inline] sctp_do_bind+0x60f/0xdc0 net/sctp/socket.c:384 sctp_bind+0x149/0x190 net/sctp/socket.c:332 inet6_bind+0x1fd/0x1820 net/ipv6/af_inet6.c:293 SYSC_bind+0x3f2/0x4b0 net/socket.c:1474 SyS_bind+0x54/0x80 net/socket.c:1460 do_syscall_64+0x309/0x430 arch/x86/entry/common.c:287 entry_SYSCALL_64_after_hwframe+0x3d/0xa2 RIP: 0033:0x43fd49 RSP: 002b:00007ffe99df3d28 EFLAGS: 00000213 ORIG_RAX: 0000000000000031 RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 000000000043fd49 RDX: 0000000000000010 RSI: 0000000020000000 RDI: 0000000000000003 RBP: 00000000006ca018 R08: 00000000004002c8 R09: 00000000004002c8 R10: 00000000004002c8 R11: 0000000000000213 R12: 0000000000401670 R13: 0000000000401700 R14: 0000000000000000 R15: 0000000000000000 Local variable description: ----address@SYSC_bind Variable was created at: SYSC_bind+0x6f/0x4b0 net/socket.c:1461 SyS_bind+0x54/0x80 net/socket.c:1460 Signed-off-by: Eric Dumazet <edumazet(a)google.com> Cc: Vlad Yasevich <vyasevich(a)gmail.com> Cc: Neil Horman <nhorman(a)tuxdriver.com> Reported-by: syzbot <syzkaller(a)googlegroups.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- net/sctp/socket.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -354,11 +354,14 @@ static struct sctp_af *sctp_sockaddr_af( if (!opt->pf->af_supported(addr->sa.sa_family, opt)) return NULL; - /* V4 mapped address are really of AF_INET family */ - if (addr->sa.sa_family == AF_INET6 && - ipv6_addr_v4mapped(&addr->v6.sin6_addr) && - !opt->pf->af_supported(AF_INET, opt)) - return NULL; + if (addr->sa.sa_family == AF_INET6) { + if (len < SIN6_LEN_RFC2133) + return NULL; + /* V4 mapped address are really of AF_INET family */ + if (ipv6_addr_v4mapped(&addr->v6.sin6_addr) && + !opt->pf->af_supported(AF_INET, opt)) + return NULL; + } /* If we get this far, af is valid. */ af = sctp_get_af_specific(addr->sa.sa_family); Patches currently in stable-queue which might be from edumazet(a)google.com are queue-4.16/sctp-sctp_sockaddr_af-must-check-minimal-addr-length-for-af_inet6.patch queue-4.16/pptp-remove-a-buggy-dst-release-in-pptp_connect.patch queue-4.16/net-fool-proof-dev_valid_name.patch queue-4.16/vti6-better-validate-user-provided-tunnel-names.patch queue-4.16/ipv6-sit-better-validate-user-provided-tunnel-names.patch queue-4.16/ip6_tunnel-better-validate-user-provided-tunnel-names.patch queue-4.16/sctp-do-not-leak-kernel-memory-to-user-space.patch queue-4.16/ip_tunnel-better-validate-user-provided-tunnel-names.patch queue-4.16/ip6_gre-better-validate-user-provided-tunnel-names.patch

7 years, 4 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror