- Linux-stable-mirror - lists.linaro.org

[PATCH] gpio: max7301: fix driver for use with CONFIG_VMAP_STACK

by Christophe Leroy

spi_read() and spi_write() require DMA-safe memory. When CONFIG_VMAP_STACK is selected, those functions cannot be used with buffers on stack. This patch replaces calls to spi_read() and spi_write() by spi_write_then_read() which doesn't require DMA-safe buffers. Fixes: 0c36ec314735 ("gpio: gpio driver for max7301 SPI GPIO expander") Cc: <stable(a)vger.kernel.org> Signed-off-by: Christophe Leroy <christophe.leroy(a)c-s.fr> --- drivers/gpio/gpio-max7301.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/gpio/gpio-max7301.c b/drivers/gpio/gpio-max7301.c index 68c7942d0a3c..6f7d12ba2f74 100644 --- a/drivers/gpio/gpio-max7301.c +++ b/drivers/gpio/gpio-max7301.c @@ -25,7 +25,7 @@ static int max7301_spi_write(struct device *dev, unsigned int reg, struct spi_device *spi = to_spi_device(dev); u16 word = ((reg & 0x7F) << 8) | (val & 0xFF); - return spi_write(spi, (const u8 *)&word, sizeof(word)); + return spi_write_then_read(spi, &word, sizeof(word), NULL, 0); } /* A read from the MAX7301 means two transfers; here, one message each */ @@ -37,14 +37,8 @@ static int max7301_spi_read(struct device *dev, unsigned int reg) struct spi_device *spi = to_spi_device(dev); word = 0x8000 | (reg << 8); - ret = spi_write(spi, (const u8 *)&word, sizeof(word)); - if (ret) - return ret; - /* - * This relies on the fact, that a transfer with NULL tx_buf shifts out - * zero bytes (=NOOP for MAX7301) - */ - ret = spi_read(spi, (u8 *)&word, sizeof(word)); + ret = spi_write_then_read(spi, &word, sizeof(word), &word, + sizeof(word)); if (ret) return ret; return word & 0xff; -- 2.13.3

6 years, 9 months

2
1
0 0

[PATCH 4.14 00/89] 4.14.89-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.14.89 release. There are 89 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun Dec 16 11:57:01 UTC 2018. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.89-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.14.89-rc1 Piotr Stankiewicz <piotr.stankiewicz(a)intel.com> IB/hfi1: Fix an out-of-bounds access in get_hw_stats Kailang Yang <kailang(a)realtek.com> ALSA: hda/realtek - Fixed headphone issue for ALC700 Takashi Sakamoto <o-takashi(a)sakamocchi.jp> ALSA: fireface: fix reference to wrong register for clock configuration Guenter Roeck <linux(a)roeck-us.net> staging: speakup: Replace strncpy with memcpy Tigran Mkrtchyan <tigran.mkrtchyan(a)desy.de> flexfiles: enforce per-mirror stateid only for v4 DSes Davidlohr Bueso <dave(a)stgolabs.net> lib/rbtree-test: lower default params Petr Mladek <pmladek(a)suse.com> printk: Wake klogd when passing console_lock owner Sergey Senozhatsky <sergey.senozhatsky.work(a)gmail.com> printk: Never set console_may_schedule in console_trylock() Petr Mladek <pmladek(a)suse.com> printk: Hide console waiter logic into helpers Steven Rostedt (VMware) <rostedt(a)goodmis.org> printk: Add console owner and waiter logic to load balance console writes Sasha Levin <sashal(a)kernel.org> Revert "printk: Never set console_may_schedule in console_trylock()" Pan Bian <bianpan2016(a)163.com> ocfs2: fix potential use after free Qian Cai <cai(a)gmx.us> debugobjects: avoid recursive calls with kmemleak Pan Bian <bianpan2016(a)163.com> hfsplus: do not free node before using Pan Bian <bianpan2016(a)163.com> hfs: do not free node before using Wei Yang <richard.weiyang(a)gmail.com> mm/page_alloc.c: fix calculation of pgdat->nr_zones Larry Chen <lchen(a)suse.com> ocfs2: fix deadlock caused by ocfs2_defrag_extent() Lorenzo Pieralisi <lorenzo.pieralisi(a)arm.com> ACPI/IORT: Fix iort_get_platform_device_domain() uninitialized pointer value Sagi Grimberg <sagi(a)grimberg.me> nvme: flush namespace scanning work just before removing namespaces Colin Ian King <colin.king(a)canonical.com> fscache, cachefiles: remove redundant variable 'cache' NeilBrown <neilb(a)suse.com> fscache: fix race between enablement and dropping of object Kees Cook <keescook(a)chromium.org> pstore/ram: Correctly calculate usable PRZ bytes Igor Druzhinin <igor.druzhinin(a)citrix.com> Revert "xen/balloon: Mark unallocated host memory as UNUSABLE" Srikanth Boddepalli <boddepalli.srikanth(a)gmail.com> xen: xlate_mmu: add missing header to fix 'W=1' warning Y.C. Chen <yc_chen(a)aspeedtech.com> drm/ast: fixed reading monitor EDID not stable issue shaoyunl <shaoyun.liu(a)amd.com> drm/amdgpu: Add delay after enable RLC ucode Pan Bian <bianpan2016(a)163.com> net: hisilicon: remove unexpected free_netdev Josh Elsasser <jelsasser(a)appneta.com> ixgbe: recognize 1000BaseLX SFP modules as 1Gbps Yunjian Wang <wangyunjian(a)huawei.com> igb: fix uninitialized variables Kiran Kumar Modukuri <kiran.modukuri(a)gmail.com> cachefiles: Fix page leak in cachefiles_read_backing_file while vmscan is active Taehee Yoo <ap420073(a)gmail.com> netfilter: nf_tables: deactivate expressions in rule replecement routine Marek Szyprowski <m.szyprowski(a)samsung.com> usb: gadget: u_ether: fix unsafe list iteration Lorenzo Bianconi <lorenzo.bianconi(a)redhat.com> net: thunderx: fix NULL pointer dereference in nic_remove Yi Wang <wang.yi59(a)zte.com.cn> x86/kvm/vmx: fix old-style function declaration Yi Wang <wang.yi59(a)zte.com.cn> KVM: x86: fix empty-body warnings Artemy Kovalyov <artemyko(a)mellanox.com> IB/mlx5: Fix page fault handling for MW Alin Nastac <alin.nastac(a)gmail.com> netfilter: ipv6: Preserve link scope traffic original oif Christian Hewitt <christianshewitt(a)gmail.com> drm/meson: add support for 1080p25 mode Aaro Koskinen <aaro.koskinen(a)iki.fi> USB: omap_udc: fix rejection of out transfers when DMA is used Aaro Koskinen <aaro.koskinen(a)iki.fi> USB: omap_udc: fix USB gadget functionality on Palm Tungsten E Aaro Koskinen <aaro.koskinen(a)iki.fi> USB: omap_udc: fix omap_udc_start() on 15xx machines Aaro Koskinen <aaro.koskinen(a)iki.fi> USB: omap_udc: fix crashes on probe error and module removal Aaro Koskinen <aaro.koskinen(a)iki.fi> USB: omap_udc: use devm_request_irq() Xin Long <lucien.xin(a)gmail.com> ipvs: call ip_vs_dst_notifier earlier than ipv6_dev_notf Martynas Pumputis <m(a)lambda.lt> bpf: fix check of allowed specifiers in bpf_trace_printk Pan Bian <bianpan2016(a)163.com> exportfs: do not read dentry after free Peter Ujfalusi <peter.ujfalusi(a)ti.com> ASoC: omap-dmic: Add pm_qos handling to avoid overruns with CPU_IDLE Peter Ujfalusi <peter.ujfalusi(a)ti.com> ASoC: omap-mcpdm: Add pm_qos handling to avoid under/overruns with CPU_IDLE Peter Ujfalusi <peter.ujfalusi(a)ti.com> ASoC: omap-mcbsp: Fix latency value calculation for pm_qos Kamal Heib <kamalheib1(a)gmail.com> RDMA/rdmavt: Fix rvt_create_ah function signature Majd Dibbiny <majd(a)mellanox.com> RDMA/mlx5: Fix fence type for IB_WR_LOCAL_INV WR Robbie Ko <robbieko(a)synology.com> Btrfs: send, fix infinite loop due to directory rename dependencies Romain Izard <romain.izard.pro(a)gmail.com> ARM: dts: at91: sama5d2: use the divided clock for SMC Artem Savkov <asavkov(a)redhat.com> objtool: Fix segfault in .cold detection with -ffunction-sections Artem Savkov <asavkov(a)redhat.com> objtool: Fix double-free in .cold detection error path Trent Piepho <tpiepho(a)impinj.com> PCI: imx6: Fix link training status detection in link up check Jiri Olsa <jolsa(a)kernel.org> perf tools: Restore proper cwd on return from mnt namespace Huacai Chen <chenhc(a)lemote.com> hwmon: (w83795) temp4_type has writable permission Taehee Yoo <ap420073(a)gmail.com> netfilter: xt_hashlimit: fix a possible memory leak in htable_create() Hans de Goede <hdegoede(a)redhat.com> iio/hid-sensors: Fix IIO_CHAN_INFO_RAW returning wrong values for signed numbers Tzung-Bi Shih <tzungbi(a)google.com> ASoC: dapm: Recalculate audio map forcely when card instantiated Peter Ujfalusi <peter.ujfalusi(a)ti.com> ASoC: omap-abe-twl6040: Fix missing audio card caused by deferred probing Nicolin Chen <nicoleotsuka(a)gmail.com> hwmon: (ina2xx) Fix current value calculation Thomas Richter <tmricht(a)linux.ibm.com> s390/cpum_cf: Reject request for sampling in event initialization Richard Fitzgerald <rf(a)opensource.cirrus.com> ASoC: wm_adsp: Fix dma-unsafe read of scratch registers Nicolin Chen <nicoleotsuka(a)gmail.com> hwmon (ina2xx) Fix NULL id pointer in probe() Florian Westphal <fw(a)strlen.de> netfilter: nf_tables: fix use-after-free when deleting compat expressions Florian Westphal <fw(a)strlen.de> selftests: add script to stress-test nft packet path vs. control plane YueHaibing <yuehaibing(a)huawei.com> sysv: return 'err' instead of 0 in __sysv_write_inode Janusz Krzysztofik <jmkrzyszt(a)gmail.com> ARM: OMAP1: ams-delta: Fix possible use of uninitialized field Adam Ford <aford173(a)gmail.com> ARM: dts: logicpd-somlv: Fix interrupt on mmc3_dat1 Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> staging: rtl8723bs: Fix the return value in case of error in 'rtw_wx_read32()' Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> ASoC: rsnd: fixup clock start checker Nathan Chancellor <natechancellor(a)gmail.com> ARM: OMAP2+: prm44xx: Fix section annotation on omap44xx_prm_enable_io_wakeup Jason Wang <jasowang(a)redhat.com> virtio-net: keep vnet header zeroed after processing XDP Nicolas Dichtel <nicolas.dichtel(a)6wind.com> tun: forbid iface creation with rtnl ops Yuchung Cheng <ycheng(a)google.com> tcp: fix NULL ref in tail loss probe Eric Dumazet <edumazet(a)google.com> tcp: Do not underestimate rwnd_limited Xin Long <lucien.xin(a)gmail.com> sctp: kfree_rcu asoc Eric Dumazet <edumazet(a)google.com> rtnetlink: ndo_dflt_fdb_dump() only work for ARPHRD_ETHER devices Christoph Paasch <cpaasch(a)apple.com> net: Prevent invalid access to skb->prev in __qdisc_drop_all Heiner Kallweit <hkallweit1(a)gmail.com> net: phy: don't allow __set_phy_supported to add unsupported modes Eran Ben Elisha <eranbe(a)mellanox.com> net/mlx4_en: Change min MTU size to ETH_MIN_MTU Tarick Bedeir <tarick(a)google.com> net/mlx4_core: Correctly set PFC param if global pause is turned off. Su Yanjun <suyj.fnst(a)cn.fujitsu.com> net: 8139cp: fix a BUG triggered by changing mtu with network traffic Shmulik Ladkani <shmulik(a)metanetworks.com> ipv6: sr: properly initialize flowi6 prior passing to ip6_route_output Stefano Brivio <sbrivio(a)redhat.com> neighbour: Avoid writing before skb->head in neigh_hh_output() Stefano Brivio <sbrivio(a)redhat.com> ipv6: Check available headroom in ip6_xmit() even without options Jiri Wiesner <jwiesner(a)suse.com> ipv4: ipv6: netfilter: Adjust the frag mem limit when truesize changes ------------- Diffstat: Makefile | 4 +- arch/arm/boot/dts/logicpd-som-lv.dtsi | 2 +- arch/arm/boot/dts/sama5d2.dtsi | 2 +- arch/arm/mach-omap1/board-ams-delta.c | 3 + arch/arm/mach-omap2/prm44xx.c | 2 +- arch/s390/kernel/perf_cpum_cf.c | 2 + arch/x86/kvm/lapic.c | 2 +- arch/x86/kvm/vmx.c | 8 +- arch/x86/xen/enlighten.c | 78 ---------- arch/x86/xen/setup.c | 6 +- drivers/acpi/arm64/iort.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 7 +- drivers/gpu/drm/ast/ast_mode.c | 36 ++++- drivers/gpu/drm/meson/meson_venc.c | 1 + drivers/hid/hid-sensor-custom.c | 2 +- drivers/hid/hid-sensor-hub.c | 13 +- drivers/hwmon/ina2xx.c | 6 +- drivers/hwmon/w83795.c | 2 +- drivers/iio/accel/hid-sensor-accel-3d.c | 5 +- drivers/iio/gyro/hid-sensor-gyro-3d.c | 5 +- drivers/iio/humidity/hid-sensor-humidity.c | 3 +- drivers/iio/light/hid-sensor-als.c | 8 +- drivers/iio/light/hid-sensor-prox.c | 8 +- drivers/iio/magnetometer/hid-sensor-magn-3d.c | 8 +- drivers/iio/orientation/hid-sensor-incl-3d.c | 8 +- drivers/iio/pressure/hid-sensor-press.c | 8 +- drivers/iio/temperature/hid-sensor-temperature.c | 3 +- drivers/infiniband/hw/hfi1/chip.c | 3 +- drivers/infiniband/hw/hfi1/hfi.h | 2 + drivers/infiniband/hw/hfi1/verbs.c | 2 +- drivers/infiniband/hw/mlx5/odp.c | 1 + drivers/infiniband/hw/mlx5/qp.c | 19 +-- drivers/infiniband/sw/rdmavt/ah.c | 4 +- drivers/infiniband/sw/rdmavt/ah.h | 3 +- drivers/net/ethernet/cavium/thunder/nic_main.c | 3 + drivers/net/ethernet/hisilicon/hip04_eth.c | 4 +- drivers/net/ethernet/intel/igb/e1000_i210.c | 1 + drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 4 +- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 4 +- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 4 +- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 1 - drivers/net/ethernet/realtek/8139cp.c | 5 + drivers/net/phy/phy_device.c | 19 ++- drivers/net/tun.c | 6 +- drivers/net/virtio_net.c | 14 +- drivers/nvme/host/core.c | 4 +- drivers/pci/dwc/pci-imx6.c | 10 +- drivers/rtc/rtc-hid-sensor-time.c | 2 +- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +- drivers/staging/speakup/kobjects.c | 4 +- drivers/usb/gadget/function/u_ether.c | 11 +- drivers/usb/gadget/udc/omap_udc.c | 88 ++++-------- drivers/xen/balloon.c | 65 ++------- drivers/xen/xlate_mmu.c | 1 + fs/btrfs/send.c | 11 +- fs/cachefiles/rdwr.c | 9 +- fs/exportfs/expfs.c | 2 +- fs/fscache/object.c | 3 + fs/hfs/btree.c | 3 +- fs/hfsplus/btree.c | 3 +- fs/nfs/flexfilelayout/flexfilelayout.c | 6 +- fs/ocfs2/export.c | 2 +- fs/ocfs2/move_extents.c | 47 +++--- fs/pstore/ram.c | 15 +- fs/sysv/inode.c | 2 +- include/linux/hid-sensor-hub.h | 4 +- include/linux/pstore.h | 5 +- include/net/neighbour.h | 28 +++- include/net/sctp/structs.h | 2 + include/xen/balloon.h | 5 - kernel/printk/printk.c | 160 ++++++++++++++++++++- kernel/trace/bpf_trace.c | 8 +- lib/debugobjects.c | 5 +- lib/interval_tree_test.c | 4 +- lib/rbtree_test.c | 2 +- mm/page_alloc.c | 4 +- net/core/rtnetlink.c | 3 + net/ipv4/ip_fragment.c | 7 + net/ipv4/tcp_output.c | 17 ++- net/ipv6/ip6_output.c | 42 +++--- net/ipv6/netfilter.c | 3 +- net/ipv6/netfilter/nf_conntrack_reasm.c | 8 +- net/ipv6/reassembly.c | 8 +- net/ipv6/seg6_iptunnel.c | 1 + net/netfilter/ipvs/ip_vs_ctl.c | 3 + net/netfilter/nf_tables_api.c | 20 +-- net/netfilter/nft_compat.c | 3 +- net/netfilter/xt_hashlimit.c | 9 +- net/sched/sch_netem.c | 3 + net/sctp/associola.c | 2 +- sound/firewire/fireface/ff-protocol-ff400.c | 2 +- sound/pci/hda/patch_realtek.c | 33 +++++ sound/soc/codecs/wm_adsp.c | 37 ++--- sound/soc/omap/omap-abe-twl6040.c | 67 ++++----- sound/soc/omap/omap-dmic.c | 9 ++ sound/soc/omap/omap-mcbsp.c | 6 +- sound/soc/omap/omap-mcpdm.c | 43 +++++- sound/soc/sh/rcar/ssi.c | 2 +- sound/soc/soc-core.c | 1 + tools/objtool/elf.c | 19 ++- tools/perf/util/namespaces.c | 17 ++- tools/perf/util/namespaces.h | 1 + tools/testing/selftests/Makefile | 1 + tools/testing/selftests/netfilter/Makefile | 6 + tools/testing/selftests/netfilter/config | 2 + .../selftests/netfilter/nft_trans_stress.sh | 78 ++++++++++ 106 files changed, 820 insertions(+), 483 deletions(-)

6 years, 9 months

10
102
0 0

[PATCH] mtd: rawnand: marvell: prevent timeouts on a loaded machine

by Miquel Raynal

marvell_nfc_wait_op() waits for completion during 'timeout_ms' milliseconds before throwing an error. While the logic is fine, the value of 'timeout_ms' is given by the core and actually correspond to the maximum time the NAND chip will take to complete the operation. Assuming there is no overhead in the propagation of the interrupt signal to the the NAND controller (through the Ready/Busy line), this delay does not take into account the latency of the operating system. For instance, for a page write, the delay given by the core is rounded up to 1ms. Hence, when the machine is over loaded, there is chances that this timeout will be reached. There are two ways to solve this issue that are not incompatible: 1/ Enlarge the timeout value (if so, how much?). 2/ Check after the waiting method if we did not miss any interrupt because of the OS latency (an interrupt is still pending). In this case, we assume the operation exited successfully. We choose the second approach that is a must in all cases, with the possibility to also modify the timeout value to be, e.g. at least 1 second in all cases. Fixes: 02f26ecf8c77 ("mtd: nand: add reworked Marvell NAND controller driver") Cc: stable(a)vger.kernel.org Signed-off-by: Miquel Raynal <miquel.raynal(a)bootlin.com> --- drivers/mtd/nand/raw/marvell_nand.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c index e6c3739cea73..bc0eef4ade4f 100644 --- a/drivers/mtd/nand/raw/marvell_nand.c +++ b/drivers/mtd/nand/raw/marvell_nand.c @@ -514,9 +514,14 @@ static void marvell_nfc_enable_int(struct marvell_nfc *nfc, u32 int_mask) writel_relaxed(reg & ~int_mask, nfc->regs + NDCR); } -static void marvell_nfc_clear_int(struct marvell_nfc *nfc, u32 int_mask) +static int marvell_nfc_clear_int(struct marvell_nfc *nfc, u32 int_mask) { + u32 reg; + + reg = readl_relaxed(nfc->regs + NDSR); writel_relaxed(int_mask, nfc->regs + NDSR); + + return reg & int_mask; } static void marvell_nfc_force_byte_access(struct nand_chip *chip, @@ -683,6 +688,7 @@ static int marvell_nfc_wait_cmdd(struct nand_chip *chip) static int marvell_nfc_wait_op(struct nand_chip *chip, unsigned int timeout_ms) { struct marvell_nfc *nfc = to_marvell_nfc(chip->controller); + int pending; int ret; /* Timeout is expressed in ms */ @@ -695,8 +701,13 @@ static int marvell_nfc_wait_op(struct nand_chip *chip, unsigned int timeout_ms) ret = wait_for_completion_timeout(&nfc->complete, msecs_to_jiffies(timeout_ms)); marvell_nfc_disable_int(nfc, NDCR_RDYM); - marvell_nfc_clear_int(nfc, NDSR_RDY(0) | NDSR_RDY(1)); - if (!ret) { + pending = marvell_nfc_clear_int(nfc, NDSR_RDY(0) | NDSR_RDY(1)); + + /* + * In case the interrupt was not served in the required time frame, + * check if the ISR was not served or if something went actually wrong. + */ + if (ret && !pending) { dev_err(nfc->dev, "Timeout waiting for RB signal\n"); return -ETIMEDOUT; } -- 2.19.1

6 years, 9 months

2
2
0 0

[PATCH v2] x86: vdso: Pass --eh-frame-hdr to ld

by Alistair Strachan

Commit 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link") accidentally broke unwinding from userspace, because ld would strip the .eh_frame sections when linking. Originally, the compiler would implicitly add --eh-frame-hdr when invoking the linker, but when this Makefile was converted from invoking ld via the compiler, to invoking it directly (like vmlinux does), the flag was missed. (The EH_FRAME section is important for the VDSO shared libraries, but not for vmlinux.) Fix the problem by explicitly specifying --eh-frame-hdr, which restores parity with the old method. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=201741 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1659295 Reported-by: Florian Weimer <fweimer(a)redhat.com> Reported-by: Carlos O'Donell <carlos(a)redhat.com> Reported-by: "H. J. Lu" <hjl.tools(a)gmail.com> Tested-by: Laura Abbott <labbott(a)redhat.com> Fixes: 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link") Cc: stable(a)vger.kernel.org Cc: Andy Lutomirski <luto(a)kernel.org> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: "H. Peter Anvin" <hpa(a)zytor.com> Cc: X86 ML <x86(a)kernel.org> Cc: Joel Fernandes <joel(a)joelfernandes.org> Cc: kernel-team(a)android.com Signed-off-by: Alistair Strachan <astrachan(a)google.com> --- v2: Updated commit message, no changes to the code arch/x86/entry/vdso/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile index 141d415a8c80..c3d7ccd25381 100644 --- a/arch/x86/entry/vdso/Makefile +++ b/arch/x86/entry/vdso/Makefile @@ -171,7 +171,8 @@ quiet_cmd_vdso = VDSO $@ sh $(srctree)/$(src)/checkundef.sh '$(NM)' '$@' VDSO_LDFLAGS = -shared $(call ld-option, --hash-style=both) \ - $(call ld-option, --build-id) -Bsymbolic + $(call ld-option, --build-id) $(call ld-option, --eh-frame-hdr) \ + -Bsymbolic GCOV_PROFILE := n # -- 2.20.0.405.gbc1bbc6f85-goog

6 years, 9 months

2
1
0 0

[PATCH v2] mtd: rawnand: omap2: Pass the parent of pdev to dma_request_chan()

by Boris Brezillon

Commit e1e6255c311b ("mtd: rawnand: omap2: convert driver to nand_scan()") moved part of the init code in the ->attach_chip hook and at the same time changed the struct device object passed to dma_request_chan() (&pdev->dev instead of pdev->dev.parent). Fixes: e1e6255c311b ("mtd: rawnand: omap2: convert driver to nand_scan()") Reported-by: Alexander Sverdlin <alexander.sverdlin(a)gmail.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Boris Brezillon <boris.brezillon(a)bootlin.com> --- Changes in v2: - Fix the prefix --- drivers/mtd/nand/raw/omap2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/omap2.c b/drivers/mtd/nand/raw/omap2.c index 886d05c391ef..68e8b9f7f372 100644 --- a/drivers/mtd/nand/raw/omap2.c +++ b/drivers/mtd/nand/raw/omap2.c @@ -1944,7 +1944,7 @@ static int omap_nand_attach_chip(struct nand_chip *chip) case NAND_OMAP_PREFETCH_DMA: dma_cap_zero(mask); dma_cap_set(DMA_SLAVE, mask); - info->dma = dma_request_chan(dev, "rxtx"); + info->dma = dma_request_chan(dev->parent, "rxtx"); if (IS_ERR(info->dma)) { dev_err(dev, "DMA engine request failed\n"); -- 2.17.1

6 years, 9 months

3
2
0 0

[PATCH] mtd: rawnand: Fix JEDEC detection

by Boris Brezillon

nand_jedec_detect() should return 1 when the PARAM page parsing succeeds, otherwise the core considers JEDEC detection failed and falls back to ID-based detection. Fixes: 480139d9229e ("mtd: rawnand: get rid of the JEDEC parameter page in nand_chip") Cc: <stable(a)vger.kernel.org> Signed-off-by: Boris Brezillon <boris.brezillon(a)bootlin.com> --- drivers/mtd/nand/raw/nand_jedec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/nand/raw/nand_jedec.c b/drivers/mtd/nand/raw/nand_jedec.c index 5c26492c841d..38b5dc22cb30 100644 --- a/drivers/mtd/nand/raw/nand_jedec.c +++ b/drivers/mtd/nand/raw/nand_jedec.c @@ -107,6 +107,8 @@ int nand_jedec_detect(struct nand_chip *chip) pr_warn("Invalid codeword size\n"); } + ret = 1; + free_jedec_param_page: kfree(p); return ret; -- 2.17.1

6 years, 9 months

2
3
0 0

[PATCH 3/3] ALSA: firewire-lib: use the same print format for 'without_header' tracepoints

by Takashi Sakamoto

An initial commit to add tracepoints for packets without CIP headers uses different print formats for added tracepoints. However this is not convenient for users/developers to prepare debug tools. This commit uses the same format for the two tracepoints. Cc: <stable(a)vger.kernel.org> # v4.12+ Fixes: b164d2fd6e49 ('ALSA: firewire_lib: add tracepoints for packets without CIP headers') Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- sound/firewire/amdtp-stream-trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/firewire/amdtp-stream-trace.h b/sound/firewire/amdtp-stream-trace.h index c05b3da0aa1c..ac20acf48fc6 100644 --- a/sound/firewire/amdtp-stream-trace.h +++ b/sound/firewire/amdtp-stream-trace.h @@ -131,7 +131,7 @@ TRACE_EVENT(in_packet_without_header, __entry->index = index; ), TP_printk( - "%02u %04u %04x %04x %02d %03u %3u %3u %02u %01u %02u", + "%02u %04u %04x %04x %02d %03u %02u %03u %02u %01u %02u", __entry->second, __entry->cycle, __entry->src, -- 2.19.1

6 years, 9 months

1
0
0 0

[PATCH 2/3] ALSA: firewire-lib: fix wrong assignment for 'out_packet_without_header' tracepoint

by Takashi Sakamoto

An initial commit to add tracepoints for packets without CIP headers introduces a wrong assignment to 'data_blocks' value of 'out_packet_without_header' tracepoint. This commit fixes the bug. Cc: <stable(a)vger.kernel.org> # v4.12+ Fixes: b164d2fd6e49 ('ALSA: firewire_lib: add tracepoints for packets without CIP headers') Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- sound/firewire/amdtp-stream-trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/firewire/amdtp-stream-trace.h b/sound/firewire/amdtp-stream-trace.h index 54cdd4ffa9ce..c05b3da0aa1c 100644 --- a/sound/firewire/amdtp-stream-trace.h +++ b/sound/firewire/amdtp-stream-trace.h @@ -169,7 +169,7 @@ TRACE_EVENT(out_packet_without_header, __entry->dest = fw_parent_device(s->unit)->node_id; __entry->payload_quadlets = payload_length / 4; __entry->data_blocks = data_blocks, - __entry->data_blocks = s->data_block_counter, + __entry->data_block_counter = s->data_block_counter, __entry->packet_index = s->packet_index; __entry->irq = !!in_interrupt(); __entry->index = index; -- 2.19.1

6 years, 9 months

1
0
0 0

[PATCH 1/3] ALSA: firewire-lib: fix wrong handling payload_length as payload_quadlet

by Takashi Sakamoto

In IEC 61883-1/6 engine of ALSA firewire stack, a packet handler has a second argument for 'the number of bytes in payload of isochronous packet'. However, an incoming packet handler without CIP header uses the value as 'the number of quadlets in the payload'. This brings userspace applications to receive the number of PCM frames as four times against real time. This commit fixes the bug. Cc: <stable(a)vger.kernel.org> # v4.12+ Fixes: 3b196c394dd ('ALSA: firewire-lib: add no-header packet processing') Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- sound/firewire/amdtp-stream.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/firewire/amdtp-stream.c b/sound/firewire/amdtp-stream.c index 9be76c808fcc..3ada55ed5381 100644 --- a/sound/firewire/amdtp-stream.c +++ b/sound/firewire/amdtp-stream.c @@ -654,15 +654,17 @@ static int handle_in_packet(struct amdtp_stream *s, } static int handle_in_packet_without_header(struct amdtp_stream *s, - unsigned int payload_quadlets, unsigned int cycle, + unsigned int payload_length, unsigned int cycle, unsigned int index) { __be32 *buffer; + unsigned int payload_quadlets; unsigned int data_blocks; struct snd_pcm_substream *pcm; unsigned int pcm_frames; buffer = s->buffer.packets[s->packet_index].buffer; + payload_quadlets = payload_length / 4; data_blocks = payload_quadlets / s->data_block_quadlets; trace_in_packet_without_header(s, cycle, payload_quadlets, data_blocks, -- 2.19.1

6 years, 9 months

1
0
0 0

Re: [PATCH] acpi / apei: fix NULL deref during init

by Borislav Petkov

On Fri, Dec 14, 2018 at 11:42:01PM +0100, Thomas Schöbel-Theuer wrote: > Ah, I overlooked that commit e56c92565dfe2 is already providing a different > solution to the same problem in newer kernels _only_, as a _side_ effect > (not clear to me from the description, but clear from reading the code). Damn, I missed the fact that this is not the upstream kernel: CPU: 0 PID: 1 UID: 0 Comm: swapper/0 Not tainted 4.4.0-ui18344.004-uiabi1-infong-amd64 #1 > So another alternative would be backporting e56c92565dfe2 to the 4.4 LTS > series. Also fine for me. That looks like the right fix. A note for the next time: do not send a fix for a stable kernel which is not upstream: >From Documentation/process/stable-kernel-rules.rst: " - It or an equivalent fix must already exist in Linus' tree (upstream)." The stable kernels track upstream so if a stable kernel has a problem, the first thing one needs to do is to check whether this has been fixed upstream and if so, to backport it. This is the case most of the time. In the very seldom cases where a separate fix is needed, it needs to be handled by asking Greg what to do. :-) Adding stable@ folks to CC to set me straight if I'm missing something. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

6 years, 9 months

2
1
0 0

Re: [PATCH v2] bcache: set max writeback rate when I/O request is idle

by Coly Li

On 12/15/18 2:10 AM, Michael Lyle wrote: > Coly-- > > Apologies for the late reply on this. I just noticed it based on Greg's > comment about stable. > > When I wrote the previous "accelerate writeback" patchset, my first > attempt was very much like this. I believe it was asked (by you?) > whether it would impact the latency of front-end I/O because of deep > backing device queues when a new request comes in. > > Won't this cause lots of requests to be pending to backing, so if there > is intermittent front-end I/O they'll have to wait for the device? > That's why I previous had it set to only complete one writeback at a > time, to bound the impact on latency-- based on that review feedback. Hi Mike, This patch is a much more conservative effort. It sets a high writeback rate only when all attached bcache device are idled for quite many seconds. In this situation, the cache set is really quite and spared. Commit b1092c9af9ed ("bcache: allow quick writeback when backing idle") just looks at single bcache device. If there are I/Os for other bcache device on the cache set, and a single bcache device is idle, a faster writeback rate for this single idle bcache device will happen, I/O to read dirty data on cache for writeback will have negative impact to I/O requests of other bcache devices. Therefore I give up a specific faster writeback, to make sure the latency of front end I/O in general. Thanks. Coly Li > On Mon, Jul 23, 2018 at 9:03 PM Coly Li <colyli(a)suse.de > <mailto:colyli@suse.de>> wrote: > > Commit b1092c9af9ed ("bcache: allow quick writeback when backing idle") > allows the writeback rate to be faster if there is no I/O request on a > bcache device. It works well if there is only one bcache device attached > to the cache set. If there are many bcache devices attached to a cache > set, it may introduce performance regression because multiple faster > writeback threads of the idle bcache devices will compete the btree > level > locks with the bcache device who have I/O requests coming. > > This patch fixes the above issue by only permitting fast writebac when > all bcache devices attached on the cache set are idle. And if one of the > bcache devices has new I/O request coming, minimized all writeback > throughput immediately and let PI controller __update_writeback_rate() > to decide the upcoming writeback rate for each bcache device. > > Also when all bcache devices are idle, limited wrieback rate to a small > number is wast of thoughput, especially when backing devices are slower > non-rotation devices (e.g. SATA SSD). This patch sets a max writeback > rate for each backing device if the whole cache set is idle. A faster > writeback rate in idle time means new I/Os may have more available space > for dirty data, and people may observe a better write performance then. > > Please note bcache may change its cache mode in run time, and this patch > still works if the cache mode is switched from writeback mode and there > is still dirty data on cache. > > Fixes: Commit b1092c9af9ed ("bcache: allow quick writeback when > backing idle") > Cc: stable(a)vger.kernel.org <mailto:stable@vger.kernel.org> #4.16+ > Signed-off-by: Coly Li <colyli(a)suse.de <mailto:colyli@suse.de>> > Tested-by: Kai Krakow <kai(a)kaishome.de <mailto:kai@kaishome.de>> > Cc: Michael Lyle <mlyle(a)lyle.org <mailto:mlyle@lyle.org>> > Cc: Stefan Priebe <s.priebe(a)profihost.ag <mailto:s.priebe@profihost.ag>> > --- > Channgelog: > v2, Fix a deadlock reported by Stefan Priebe. > v1, Initial version. > > drivers/md/bcache/bcache.h | 11 ++-- > drivers/md/bcache/request.c | 51 ++++++++++++++- > drivers/md/bcache/super.c | 1 + > drivers/md/bcache/sysfs.c | 14 +++-- > drivers/md/bcache/util.c | 2 +- > drivers/md/bcache/util.h | 2 +- > drivers/md/bcache/writeback.c | 115 ++++++++++++++++++++++++++-------- > 7 files changed, 155 insertions(+), 41 deletions(-) > > diff --git a/drivers/md/bcache/bcache.h b/drivers/md/bcache/bcache.h > index d6bf294f3907..469ab1a955e0 100644 > --- a/drivers/md/bcache/bcache.h > +++ b/drivers/md/bcache/bcache.h > @@ -328,13 +328,6 @@ struct cached_dev { > */ > atomic_t has_dirty; > > - /* > - * Set to zero by things that touch the backing volume-- except > - * writeback. Incremented by writeback. Used to determine > when to > - * accelerate idle writeback. > - */ > - atomic_t backing_idle; > - > struct bch_ratelimit writeback_rate; > struct delayed_work writeback_rate_update; > > @@ -514,6 +507,8 @@ struct cache_set { > struct cache_accounting accounting; > > unsigned long flags; > + atomic_t idle_counter; > + atomic_t at_max_writeback_rate; > > struct cache_sb sb; > > @@ -523,6 +518,8 @@ struct cache_set { > > struct bcache_device **devices; > unsigned devices_max_used; > + /* See set_at_max_writeback_rate() for how it is used */ > + unsigned previous_dirty_dc_nr; > struct list_head cached_devs; > uint64_t cached_dev_sectors; > struct closure caching; > diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c > index ae67f5fa8047..1af3d96abfa5 100644 > --- a/drivers/md/bcache/request.c > +++ b/drivers/md/bcache/request.c > @@ -1104,6 +1104,43 @@ static void detached_dev_do_request(struct > bcache_device *d, struct bio *bio) > > /* Cached devices - read & write stuff */ > > +static void quit_max_writeback_rate(struct cache_set *c, > + struct cached_dev *this_dc) > +{ > + int i; > + struct bcache_device *d; > + struct cached_dev *dc; > + > + /* > + * If bch_register_lock is acquired by other attach/detach > operations, > + * waiting here will increase I/O request latency for > seconds or more. > + * To avoid such situation, only writeback rate of current > cached device > + * is set to 1, and __update_write_back() will decide > writeback rate > + * of other cached devices (remember c->idle_counter is 0 now). > + */ > + if (mutex_trylock(&bch_register_lock)){ > + for (i = 0; i < c->devices_max_used; i++) { > + if (!c->devices[i]) > + continue; > + > + if (UUID_FLASH_ONLY(&c->uuids[i])) > + continue; > + > + d = c->devices[i]; > + dc = container_of(d, struct cached_dev, disk); > + /* > + * set writeback rate to default minimum value, > + * then let update_writeback_rate() to > decide the > + * upcoming rate. > + */ > + atomic64_set(&dc->writeback_rate.rate, 1); > + } > + > + mutex_unlock(&bch_register_lock); > + } else > + atomic64_set(&this_dc->writeback_rate.rate, 1); > +} > + > static blk_qc_t cached_dev_make_request(struct request_queue *q, > struct bio *bio) > { > @@ -1119,7 +1156,19 @@ static blk_qc_t > cached_dev_make_request(struct request_queue *q, > return BLK_QC_T_NONE; > } > > - atomic_set(&dc->backing_idle, 0); > + if (d->c) { > + atomic_set(&d->c->idle_counter, 0); > + /* > + * If at_max_writeback_rate of cache set is true and > new I/O > + * comes, quit max writeback rate of all cached devices > + * attached to this cache set, and set > at_max_writeback_rate > + * to false. > + */ > + if > (unlikely(atomic_read(&d->c->at_max_writeback_rate) == 1)) { > + atomic_set(&d->c->at_max_writeback_rate, 0); > + quit_max_writeback_rate(d->c, dc); > + } > + } > generic_start_io_acct(q, rw, bio_sectors(bio), &d->disk->part0); > > bio_set_dev(bio, dc->bdev); > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index fa4058e43202..fa532d9f9353 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -1687,6 +1687,7 @@ struct cache_set *bch_cache_set_alloc(struct > cache_sb *sb) > c->block_bits = ilog2(sb->block_size); > c->nr_uuids = bucket_bytes(c) / sizeof(struct > uuid_entry); > c->devices_max_used = 0; > + c->previous_dirty_dc_nr = 0; > c->btree_pages = bucket_pages(c); > if (c->btree_pages > BTREE_MAX_PAGES) > c->btree_pages = max_t(int, c->btree_pages / 4, > diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c > index 225b15aa0340..d719021bff81 100644 > --- a/drivers/md/bcache/sysfs.c > +++ b/drivers/md/bcache/sysfs.c > @@ -170,7 +170,8 @@ SHOW(__bch_cached_dev) > var_printf(writeback_running, "%i"); > var_print(writeback_delay); > var_print(writeback_percent); > - sysfs_hprint(writeback_rate, dc->writeback_rate.rate << 9); > + sysfs_hprint(writeback_rate, > + atomic64_read(&dc->writeback_rate.rate) << 9); > sysfs_hprint(io_errors, atomic_read(&dc->io_errors)); > sysfs_printf(io_error_limit, "%i", dc->error_limit); > sysfs_printf(io_disable, "%i", dc->io_disable); > @@ -188,7 +189,8 @@ SHOW(__bch_cached_dev) > char change[20]; > s64 next_io; > > - bch_hprint(rate, dc->writeback_rate.rate << 9); > + bch_hprint(rate, > + atomic64_read(&dc->writeback_rate.rate) > << 9); > bch_hprint(dirty, > bcache_dev_sectors_dirty(&dc->disk) << 9); > bch_hprint(target, dc->writeback_rate_target << 9); > > bch_hprint(proportional,dc->writeback_rate_proportional << 9); > @@ -255,8 +257,12 @@ STORE(__cached_dev) > > sysfs_strtoul_clamp(writeback_percent, > dc->writeback_percent, 0, 40); > > - sysfs_strtoul_clamp(writeback_rate, > - dc->writeback_rate.rate, 1, INT_MAX); > + if (attr == &sysfs_writeback_rate) { > + int v; > + > + sysfs_strtoul_clamp(writeback_rate, v, 1, INT_MAX); > + atomic64_set(&dc->writeback_rate.rate, v); > + } > > sysfs_strtoul_clamp(writeback_rate_update_seconds, > dc->writeback_rate_update_seconds, > diff --git a/drivers/md/bcache/util.c b/drivers/md/bcache/util.c > index fc479b026d6d..84f90c3d996d 100644 > --- a/drivers/md/bcache/util.c > +++ b/drivers/md/bcache/util.c > @@ -200,7 +200,7 @@ uint64_t bch_next_delay(struct bch_ratelimit *d, > uint64_t done) > { > uint64_t now = local_clock(); > > - d->next += div_u64(done * NSEC_PER_SEC, d->rate); > + d->next += div_u64(done * NSEC_PER_SEC, > atomic64_read(&d->rate)); > > /* Bound the time. Don't let us fall further than 2 seconds > behind > * (this prevents unnecessary backlog that would make it > impossible > diff --git a/drivers/md/bcache/util.h b/drivers/md/bcache/util.h > index cced87f8eb27..7e17f32ab563 100644 > --- a/drivers/md/bcache/util.h > +++ b/drivers/md/bcache/util.h > @@ -442,7 +442,7 @@ struct bch_ratelimit { > * Rate at which we want to do work, in units per second > * The units here correspond to the units passed to > bch_next_delay() > */ > - uint32_t rate; > + atomic64_t rate; > }; > > static inline void bch_ratelimit_reset(struct bch_ratelimit *d) > diff --git a/drivers/md/bcache/writeback.c > b/drivers/md/bcache/writeback.c > index ad45ebe1a74b..11ffadc3cf8f 100644 > --- a/drivers/md/bcache/writeback.c > +++ b/drivers/md/bcache/writeback.c > @@ -49,6 +49,80 @@ static uint64_t __calc_target_rate(struct > cached_dev *dc) > return (cache_dirty_target * bdev_share) >> > WRITEBACK_SHARE_SHIFT; > } > > +static bool set_at_max_writeback_rate(struct cache_set *c, > + struct cached_dev *dc) > +{ > + int i, dirty_dc_nr = 0; > + struct bcache_device *d; > + > + /* > + * bch_register_lock is acquired in > cached_dev_detach_finish() before > + * calling cancel_writeback_rate_update_dwork() to stop the > delayed > + * kworker writeback_rate_update (where the context we are > for now). > + * Therefore call mutex_lock() here may introduce deadlock > when shut > + * down the bcache device. > + * c->previous_dirty_dc_nr is used to record previous calculated > + * dirty_dc_nr when mutex_trylock() last time succeeded. Then if > + * mutex_trylock() failed here, use c->previous_dirty_dc_nr > as dirty > + * cached device number. Of cause it might be inaccurate, > but a few more > + * or less loop before setting c->at_max_writeback_rate is > much better > + * then a deadlock here. > + */ > + if (mutex_trylock(&bch_register_lock)) { > + for (i = 0; i < c->devices_max_used; i++) { > + if (!c->devices[i]) > + continue; > + if (UUID_FLASH_ONLY(&c->uuids[i])) > + continue; > + d = c->devices[i]; > + dc = container_of(d, struct cached_dev, disk); > + if (atomic_read(&dc->has_dirty)) > + dirty_dc_nr++; > + } > + c->previous_dirty_dc_nr = dirty_dc_nr; > + > + mutex_unlock(&bch_register_lock); > + } else > + dirty_dc_nr = c->previous_dirty_dc_nr; > + > + /* > + * Idle_counter is increased everytime when > update_writeback_rate() > + * is rescheduled in. If all backing devices attached to the > same > + * cache set has same dc->writeback_rate_update_seconds > value, it > + * is about 10 rounds of update_writeback_rate() is called > on each > + * backing device, then the code will fall through at set 1 to > + * c->at_max_writeback_rate, and a max wrteback rate to each > + * dc->writeback_rate.rate. This is not very accurate but > works well > + * to make sure the whole cache set has no new I/O coming before > + * writeback rate is set to a max number. > + */ > + if (atomic_inc_return(&c->idle_counter) < dirty_dc_nr * 10) > + return false; > + > + if (atomic_read(&c->at_max_writeback_rate) != 1) > + atomic_set(&c->at_max_writeback_rate, 1); > + > + > + atomic64_set(&dc->writeback_rate.rate, INT_MAX); > + > + /* keep writeback_rate_target as existing value */ > + dc->writeback_rate_proportional = 0; > + dc->writeback_rate_integral_scaled = 0; > + dc->writeback_rate_change = 0; > + > + /* > + * Check c->idle_counter and c->at_max_writeback_rate > agagain in case > + * new I/O arrives during before set_at_max_writeback_rate() > returns. > + * Then the writeback rate is set to 1, and its new value > should be > + * decided via __update_writeback_rate(). > + */ > + if (atomic_read(&c->idle_counter) < dirty_dc_nr * 10 || > + !atomic_read(&c->at_max_writeback_rate)) > + return false; > + > + return true; > +} > + > static void __update_writeback_rate(struct cached_dev *dc) > { > /* > @@ -104,8 +178,9 @@ static void __update_writeback_rate(struct > cached_dev *dc) > > dc->writeback_rate_proportional = proportional_scaled; > dc->writeback_rate_integral_scaled = integral_scaled; > - dc->writeback_rate_change = new_rate - dc->writeback_rate.rate; > - dc->writeback_rate.rate = new_rate; > + dc->writeback_rate_change = new_rate - > + atomic64_read(&dc->writeback_rate.rate); > + atomic64_set(&dc->writeback_rate.rate, new_rate); > dc->writeback_rate_target = target; > } > > @@ -138,9 +213,16 @@ static void update_writeback_rate(struct > work_struct *work) > > down_read(&dc->writeback_lock); > > - if (atomic_read(&dc->has_dirty) && > - dc->writeback_percent) > - __update_writeback_rate(dc); > + if (atomic_read(&dc->has_dirty) && dc->writeback_percent) { > + /* > + * If the whole cache set is idle, > set_at_max_writeback_rate() > + * will set writeback rate to a max number. Then it is > + * unncessary to update writeback rate for an idle > cache set > + * in maximum writeback rate number(s). > + */ > + if (!set_at_max_writeback_rate(c, dc)) > + __update_writeback_rate(dc); > + } > > up_read(&dc->writeback_lock); > > @@ -422,27 +504,6 @@ static void read_dirty(struct cached_dev *dc) > > delay = writeback_delay(dc, size); > > - /* If the control system would wait for at least half a > - * second, and there's been no reqs hitting the > backing disk > - * for awhile: use an alternate mode where we have > at most > - * one contiguous set of writebacks in flight at a > time. If > - * someone wants to do IO it will be quick, as it > will only > - * have to contend with one operation in flight, and > we'll > - * be round-tripping data to the backing disk as > quickly as > - * it can accept it. > - */ > - if (delay >= HZ / 2) { > - /* 3 means at least 1.5 seconds, up to 7.5 if we > - * have slowed way down. > - */ > - if (atomic_inc_return(&dc->backing_idle) >= 3) { > - /* Wait for current I/Os to finish */ > - closure_sync(&cl); > - /* And immediately launch a new set. */ > - delay = 0; > - } > - } > - > while (!kthread_should_stop() && > !test_bit(CACHE_SET_IO_DISABLE, > &dc->disk.c->flags) && > delay) { > @@ -715,7 +776,7 @@ void bch_cached_dev_writeback_init(struct > cached_dev *dc) > dc->writeback_running = true; > dc->writeback_percent = 10; > dc->writeback_delay = 30; > - dc->writeback_rate.rate = 1024; > + atomic64_set(&dc->writeback_rate.rate, 1024); > dc->writeback_rate_minimum = 8; > > dc->writeback_rate_update_seconds = > WRITEBACK_RATE_UPDATE_SECS_DEFAULT; > -- > 2.17.1 >

6 years, 9 months

2
2
0 0

[PATCH] x86: vdso: Pass --eh-frame-hdr to ld

by Alistair Strachan

Commit 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link") accidentally broke unwinding from userspace, because ld would strip the .eh_frame sections when linking. Originally, the compiler would implicitly add --eh-frame-hdr when invoking the linker, but when this Makefile was converted from invoking ld via the compiler, to invoking it directly (like vmlinux does), the flag was missed. (The EH_FRAME section is important for the VDSO shared libraries, but not for vmlinux.) Fix the problem by explicitly specifying --eh-frame-hdr, which restores parity with the old method. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=201741 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1659295 Reported-by: Laura Abbott <labbott(a)redhat.com> Fixes: 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link") Cc: stable(a)vger.kernel.org Cc: Andy Lutomirski <luto(a)kernel.org> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: "H. Peter Anvin" <hpa(a)zytor.com> Cc: X86 ML <x86(a)kernel.org> Cc: Florian Weimer <fweimer(a)redhat.com>, Cc: Carlos O'Donell <carlos(a)redhat.com>, Cc: "H. J. Lu" <hjl.tools(a)gmail.com> Cc: Joel Fernandes <joel(a)joelfernandes.org> Cc: kernel-team(a)android.com Signed-off-by: Alistair Strachan <astrachan(a)google.com> --- arch/x86/entry/vdso/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile index 141d415a8c80..c3d7ccd25381 100644 --- a/arch/x86/entry/vdso/Makefile +++ b/arch/x86/entry/vdso/Makefile @@ -171,7 +171,8 @@ quiet_cmd_vdso = VDSO $@ sh $(srctree)/$(src)/checkundef.sh '$(NM)' '$@' VDSO_LDFLAGS = -shared $(call ld-option, --hash-style=both) \ - $(call ld-option, --build-id) -Bsymbolic + $(call ld-option, --build-id) $(call ld-option, --eh-frame-hdr) \ + -Bsymbolic GCOV_PROFILE := n # -- 2.20.0.405.gbc1bbc6f85-goog

6 years, 9 months

2
1
0 0

[patch 11/11] scripts/spdxcheck.py: always open files in binary mode

by akpm＠linux-foundation.org

From: Thierry Reding <treding(a)nvidia.com> Subject: scripts/spdxcheck.py: always open files in binary mode The spdxcheck script currently falls over when confronted with a binary file (such as Documentation/logo.gif). To avoid that, always open files in binary mode and decode line-by-line, ignoring encoding errors. One tricky case is when piping data into the script and reading it from standard input. By default, standard input will be opened in text mode, so we need to reopen it in binary mode. The breakage only happens with python3 and results in a UnicodeDecodeError (according to Uwe). Link: http://lkml.kernel.org/r/20181212131210.28024-1-thierry.reding@gmail.com Fixes: 6f4d29df66ac ("scripts/spdxcheck.py: make python3 compliant") Signed-off-by: Thierry Reding <treding(a)nvidia.com> Reviewed-by: Jeremy Cline <jcline(a)redhat.com> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: Jonathan Corbet <corbet(a)lwn.net> Cc: Joe Perches <joe(a)perches.com> Cc: Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- scripts/spdxcheck.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/scripts/spdxcheck.py~scripts-spdxcheckpy-always-open-files-in-binary-mode +++ a/scripts/spdxcheck.py @@ -168,6 +168,7 @@ class id_parser(object): self.curline = 0 try: for line in fd: + line = line.decode(locale.getpreferredencoding(False), errors='ignore') self.curline += 1 if self.curline > maxlines: break @@ -249,12 +250,13 @@ if __name__ == '__main__': try: if len(args.path) and args.path[0] == '-': - parser.parse_lines(sys.stdin, args.maxlines, '-') + stdin = os.fdopen(sys.stdin.fileno(), 'rb') + parser.parse_lines(stdin, args.maxlines, '-') else: if args.path: for p in args.path: if os.path.isfile(p): - parser.parse_lines(open(p), args.maxlines, p) + parser.parse_lines(open(p, 'rb'), args.maxlines, p) elif os.path.isdir(p): scan_git_subtree(repo.head.reference.commit.tree, p) else: _

6 years, 9 months

1
0
0 0

[patch 09/11] userfaultfd: check VM_MAYWRITE was set after verifying the uffd is registered

by akpm＠linux-foundation.org

From: Andrea Arcangeli <aarcange(a)redhat.com> Subject: userfaultfd: check VM_MAYWRITE was set after verifying the uffd is registered Calling UFFDIO_UNREGISTER on virtual ranges not yet registered in uffd could trigger an harmless false positive WARN_ON. Check the vma is already registered before checking VM_MAYWRITE to shut off the false positive warning. Link: http://lkml.kernel.org/r/20181206212028.18726-2-aarcange@redhat.com Cc: <stable(a)vger.kernel.org> Fixes: 29ec90660d68 ("userfaultfd: shmem/hugetlbfs: only allow to register VM_MAYWRITE vmas") Signed-off-by: Andrea Arcangeli <aarcange(a)redhat.com> Reported-by: syzbot+06c7092e7d71218a2c16(a)syzkaller.appspotmail.com Acked-by: Mike Rapoport <rppt(a)linux.ibm.com> Acked-by: Hugh Dickins <hughd(a)google.com> Acked-by: Peter Xu <peterx(a)redhat.com> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- fs/userfaultfd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/fs/userfaultfd.c~userfaultfd-check-vm_maywrite-was-set-after-verifying-the-uffd-is-registered +++ a/fs/userfaultfd.c @@ -1566,7 +1566,6 @@ static int userfaultfd_unregister(struct cond_resched(); BUG_ON(!vma_can_userfault(vma)); - WARN_ON(!(vma->vm_flags & VM_MAYWRITE)); /* * Nothing to do: this vma is already registered into this @@ -1575,6 +1574,8 @@ static int userfaultfd_unregister(struct if (!vma->vm_userfaultfd_ctx.ctx) goto skip; + WARN_ON(!(vma->vm_flags & VM_MAYWRITE)); + if (vma->vm_start > start) start = vma->vm_start; vma_end = min(end, vma->vm_end); _

6 years, 9 months

1
0
0 0

[patch 08/11] fs/iomap.c: get/put the page in iomap_page_create/release()

by akpm＠linux-foundation.org

From: Piotr Jaroszynski <pjaroszynski(a)nvidia.com> Subject: fs/iomap.c: get/put the page in iomap_page_create/release() migrate_page_move_mapping() expects pages with private data set to have a page_count elevated by 1. This is what used to happen for xfs through the buffer_heads code before the switch to iomap in commit 82cb14175e7d ("xfs: add support for sub-pagesize writeback without buffer_heads"). Not having the count elevated causes move_pages() to fail on memory mapped files coming from xfs. Make iomap compatible with the migrate_page_move_mapping() assumption by elevating the page count as part of iomap_page_create() and lowering it in iomap_page_release(). It causes the move_pages() syscall to misbehave on memory mapped files from xfs. It does not not move any pages, which I suppose is "just" a perf issue, but it also ends up returning a positive number which is out of spec for the syscall. Talking to Michal Hocko, it sounds like returning positive numbers might be a necessary update to move_pages() anyway though (https://lkml.kernel.org/r/20181116114955.GJ14706@dhcp22.suse.cz). I only hit this in tests that verify that move_pages() actually moved the pages. The test also got confused by the positive return from move_pages() (it got treated as a success as positive numbers were not expected and not handled) making it a bit harder to track down what's going on. Link: http://lkml.kernel.org/r/20181115184140.1388751-1-pjaroszynski@nvidia.com Fixes: 82cb14175e7d ("xfs: add support for sub-pagesize writeback without buffer_heads") Signed-off-by: Piotr Jaroszynski <pjaroszynski(a)nvidia.com> Reviewed-by: Christoph Hellwig <hch(a)lst.de> Cc: William Kucharski <william.kucharski(a)oracle.com> Cc: Darrick J. Wong <darrick.wong(a)oracle.com> Cc: Brian Foster <bfoster(a)redhat.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- fs/iomap.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/fs/iomap.c~iomap-get-put-the-page-in-iomap_page_create-release +++ a/fs/iomap.c @@ -116,6 +116,12 @@ iomap_page_create(struct inode *inode, s atomic_set(&iop->read_count, 0); atomic_set(&iop->write_count, 0); bitmap_zero(iop->uptodate, PAGE_SIZE / SECTOR_SIZE); + + /* + * migrate_page_move_mapping() assumes that pages with private data have + * their count elevated by 1. + */ + get_page(page); set_page_private(page, (unsigned long)iop); SetPagePrivate(page); return iop; @@ -132,6 +138,7 @@ iomap_page_release(struct page *page) WARN_ON_ONCE(atomic_read(&iop->write_count)); ClearPagePrivate(page); set_page_private(page, 0); + put_page(page); kfree(iop); } _

6 years, 9 months

1
0
0 0

[RESEND PATCH v4 1/3] fs/dcache: Fix incorrect nr_dentry_unused accounting in shrink_dcache_sb()

by Waiman Long

The nr_dentry_unused per-cpu counter tracks dentries in both the LRU lists and the shrink lists where the DCACHE_LRU_LIST bit is set. The shrink_dcache_sb() function moves dentries from the LRU list to a shrink list and subtracts the dentry count from nr_dentry_unused. This is incorrect as the nr_dentry_unused count Will also be decremented in shrink_dentry_list() via d_shrink_del(). To fix this double decrement, the decrement in the shrink_dcache_sb() function is taken out. Fixes: 4e717f5c1083 ("list_lru: remove special case function list_lru_dispose_all." Cc: stable(a)vger.kernel.org Signed-off-by: Waiman Long <longman(a)redhat.com> Reviewed-by: Dave Chinner <dchinner(a)redhat.com> --- fs/dcache.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/dcache.c b/fs/dcache.c index 2593153..44e5652 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -1188,15 +1188,11 @@ static enum lru_status dentry_lru_isolate_shrink(struct list_head *item, */ void shrink_dcache_sb(struct super_block *sb) { - long freed; - do { LIST_HEAD(dispose); - freed = list_lru_walk(&sb->s_dentry_lru, + list_lru_walk(&sb->s_dentry_lru, dentry_lru_isolate_shrink, &dispose, 1024); - - this_cpu_sub(nr_dentry_unused, freed); shrink_dentry_list(&dispose); } while (list_lru_count(&sb->s_dentry_lru) > 0); } -- 1.8.3.1

6 years, 9 months

1
0
0 0

[PATCH] selftests: Fix test errors related to lib.mk khdr target

by shuah＠kernel.org

From: Shuah Khan <shuah(a)kernel.org> Commit b2d35fa5fc80 ("selftests: add headers_install to lib.mk") added khdr target to run headers_install target from the main Makefile. The logic uses KSFT_KHDR_INSTALL and top_srcdir as controls to initialize variables and include files to run headers_install from the top level Makefile. There are a few problems with this logic. 1. Exposes top_srcdir to all tests 2. Common logic impacts all tests 3. Uses KSFT_KHDR_INSTALL, top_srcdir, and khdr in an adhoc way. Tests add "khdr" dependency in their Makefiles to TEST_PROGS_EXTENDED in some cases, and STATIC_LIBS in other cases. This makes this framework confusing to use. The common logic that runs for all tests even when KSFT_KHDR_INSTALL isn't defined by the test. top_srcdir is initialized to a default value when test doesn't initialize it. It works for all tests without a sub-dir structure and tests with sub-dir structure fail to build. e.g: make -C sparc64/drivers/ or make -C drivers/dma-buf ../../lib.mk:20: ../../../../scripts/subarch.include: No such file or directory make: *** No rule to make target '../../../../scripts/subarch.include'. Stop. There is no reason to require all tests to define top_srcdir and there is no need to require tests to add khdr dependency using adhoc changes to TEST_* and other variables. Fix it with a consistent use of KSFT_KHDR_INSTALL and top_srcdir from tests that have the dependency on headers_install. Change common logic to include khdr target define and "all" target with dependency on khdr when KSFT_KHDR_INSTALL is defined. Only tests that have dependency on headers_install have to define just the KSFT_KHDR_INSTALL, and top_srcdir variables and there is no need to specify khdr dependency in the test Makefiles. Fixes: b2d35fa5fc80 ("selftests: add headers_install to lib.mk") Cc: stable(a)vger.kernel.org Signed-off-by: Shuah Khan <shuah(a)kernel.org> --- tools/testing/selftests/android/Makefile | 2 +- tools/testing/selftests/futex/functional/Makefile | 1 + tools/testing/selftests/gpio/Makefile | 6 +++--- tools/testing/selftests/kvm/Makefile | 2 +- tools/testing/selftests/lib.mk | 8 ++++---- tools/testing/selftests/networking/timestamping/Makefile | 1 + tools/testing/selftests/tc-testing/bpf/Makefile | 1 + tools/testing/selftests/vm/Makefile | 1 + 8 files changed, 13 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/android/Makefile b/tools/testing/selftests/android/Makefile index d9a725478375..72c25a3cb658 100644 --- a/tools/testing/selftests/android/Makefile +++ b/tools/testing/selftests/android/Makefile @@ -6,7 +6,7 @@ TEST_PROGS := run.sh include ../lib.mk -all: khdr +all: @for DIR in $(SUBDIRS); do \ BUILD_TARGET=$(OUTPUT)/$$DIR; \ mkdir $$BUILD_TARGET -p; \ diff --git a/tools/testing/selftests/futex/functional/Makefile b/tools/testing/selftests/futex/functional/Makefile index ad1eeb14fda7..30996306cabc 100644 --- a/tools/testing/selftests/futex/functional/Makefile +++ b/tools/testing/selftests/futex/functional/Makefile @@ -19,6 +19,7 @@ TEST_GEN_FILES := \ TEST_PROGS := run.sh top_srcdir = ../../../../.. +KSFT_KHDR_INSTALL := 1 include ../../lib.mk $(TEST_GEN_FILES): $(HEADERS) diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile index 46648427d537..07f572a1bd3f 100644 --- a/tools/testing/selftests/gpio/Makefile +++ b/tools/testing/selftests/gpio/Makefile @@ -10,8 +10,6 @@ TEST_PROGS_EXTENDED := gpio-mockup-chardev GPIODIR := $(realpath ../../../gpio) GPIOOBJ := gpio-utils.o -include ../lib.mk - all: $(TEST_PROGS_EXTENDED) override define CLEAN @@ -19,7 +17,9 @@ override define CLEAN $(MAKE) -C $(GPIODIR) OUTPUT=$(GPIODIR)/ clean endef -$(TEST_PROGS_EXTENDED):| khdr +KSFT_KHDR_INSTALL := 1 +include ../lib.mk + $(TEST_PROGS_EXTENDED): $(GPIODIR)/$(GPIOOBJ) $(GPIODIR)/$(GPIOOBJ): diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile index 01a219229238..52bfe5e76907 100644 --- a/tools/testing/selftests/kvm/Makefile +++ b/tools/testing/selftests/kvm/Makefile @@ -1,6 +1,7 @@ all: top_srcdir = ../../../.. +KSFT_KHDR_INSTALL := 1 UNAME_M := $(shell uname -m) LIBKVM = lib/assert.c lib/elf.c lib/io.c lib/kvm_util.c lib/ucall.c lib/sparsebit.c @@ -44,7 +45,6 @@ $(OUTPUT)/libkvm.a: $(LIBKVM_OBJ) all: $(STATIC_LIBS) $(TEST_GEN_PROGS): $(STATIC_LIBS) -$(STATIC_LIBS):| khdr cscope: include_paths = $(LINUX_TOOL_INCLUDE) $(LINUX_HDR_PATH) include lib .. cscope: diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk index 0a8e75886224..8b0f16409ed7 100644 --- a/tools/testing/selftests/lib.mk +++ b/tools/testing/selftests/lib.mk @@ -16,18 +16,18 @@ TEST_GEN_PROGS := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_PROGS)) TEST_GEN_PROGS_EXTENDED := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_PROGS_EXTENDED)) TEST_GEN_FILES := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_FILES)) +ifdef KSFT_KHDR_INSTALL top_srcdir ?= ../../../.. include $(top_srcdir)/scripts/subarch.include ARCH ?= $(SUBARCH) -all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) - .PHONY: khdr khdr: make ARCH=$(ARCH) -C $(top_srcdir) headers_install -ifdef KSFT_KHDR_INSTALL -$(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES):| khdr +all: khdr $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) +else +all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) endif .ONESHELL: diff --git a/tools/testing/selftests/networking/timestamping/Makefile b/tools/testing/selftests/networking/timestamping/Makefile index 14cfcf006936..c46c0eefab9e 100644 --- a/tools/testing/selftests/networking/timestamping/Makefile +++ b/tools/testing/selftests/networking/timestamping/Makefile @@ -6,6 +6,7 @@ TEST_PROGS := hwtstamp_config rxtimestamp timestamping txtimestamp all: $(TEST_PROGS) top_srcdir = ../../../../.. +KSFT_KHDR_INSTALL := 1 include ../../lib.mk clean: diff --git a/tools/testing/selftests/tc-testing/bpf/Makefile b/tools/testing/selftests/tc-testing/bpf/Makefile index dc92eb271d9a..be5a5e542804 100644 --- a/tools/testing/selftests/tc-testing/bpf/Makefile +++ b/tools/testing/selftests/tc-testing/bpf/Makefile @@ -4,6 +4,7 @@ APIDIR := ../../../../include/uapi TEST_GEN_FILES = action.o top_srcdir = ../../../../.. +KSFT_KHDR_INSTALL := 1 include ../../lib.mk CLANG ?= clang diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile index 6e67e726e5a5..e13eb6cc8901 100644 --- a/tools/testing/selftests/vm/Makefile +++ b/tools/testing/selftests/vm/Makefile @@ -25,6 +25,7 @@ TEST_GEN_FILES += virtual_address_range TEST_PROGS := run_vmtests +KSFT_KHDR_INSTALL := 1 include ../lib.mk $(OUTPUT)/userfaultfd: LDLIBS += -lpthread -- 2.17.1

6 years, 9 months

5
7
0 0

Re: [PATCH 4.14 12/89] tcp: Do not underestimate rwnd_limited

by Greg Kroah-Hartman

On Fri, Dec 14, 2018 at 06:29:54AM -0800, Eric Dumazet wrote: > On Fri, Dec 14, 2018 at 6:26 AM Greg Kroah-Hartman < > gregkh(a)linuxfoundation.org> wrote: > > > On Fri, Dec 14, 2018 at 02:03:55PM +0000, Sudip Mukherjee wrote: > > > Hi Greg, > > > > > > On Fri, Dec 14, 2018 at 12:08 PM Greg Kroah-Hartman > > > <gregkh(a)linuxfoundation.org> wrote: > > > > > > > > 4.14-stable review patch. If anyone has any objections, please let me > > know. > > > > > > > > ------------------ > > > > > > > > From: Eric Dumazet <edumazet(a)google.com> > > > > > > > > [ Upstream commit 41727549de3e7281feb174d568c6e46823db8684 ] > > > > > > There is one upstream commit which fixes this one. > > > f9bfe4e6a9d0 ("tcp: lack of available data can also cause TSO defer") > > > > I can take this if Eric and/or David ack it :) > > > > > I ack it, I guess David had this queued already. > > No big deal, that is only for tcp_info instrumentation accuracy. If this is already queued for the next round of stable patches, and it's not a major issue, I'll just wait and take it when it shows up in a week or so. thanks, greg k-h

6 years, 9 months

3
2
0 0

[PATCH] MIPS: Expand MIPS32 ASIDs to 64 bits

by Paul Burton

ASIDs have always been stored as unsigned longs, ie. 32 bits on MIPS32 kernels. This is problematic because it is feasible for the ASID version to overflow & wrap around to zero. We currently attempt to handle this overflow by simply setting the ASID version to 1, using asid_first_version(), but we make no attempt to account for the fact that there may be mm_structs with stale ASIDs that have versions which we now reuse due to the overflow & wrap around. Encountering this requires that: 1) A struct mm_struct X is active on CPU A using ASID (V,n). 2) That mm is not used on CPU A for the length of time that it takes for CPU A's asid_cache to overflow & wrap around to the same version V that the mm had in step 1. During this time tasks using the mm could either be sleeping or only scheduled on other CPUs. 3) Some other mm Y becomes active on CPU A and is allocated the same ASID (V,n). 4) mm X now becomes active on CPU A again, and now incorrectly has the same ASID as mm Y. Where struct mm_struct ASIDs are represented above in the format (version, EntryHi.ASID), and on a typical MIPS32 system version will be 24 bits wide & EntryHi.ASID will be 8 bits wide. The length of time required in step 2 is highly dependent upon the CPU & workload, but for a hypothetical 2GHz CPU running a workload which generates a new ASID every 10000 cycles this period is around 248 days. Due to this long period of time & the fact that tasks need to be scheduled in just the right (or wrong, depending upon your inclination) way, this is obviously a difficult bug to encounter but it's entirely possible as evidenced by reports. In order to fix this, simply extend ASIDs to 64 bits even on MIPS32 builds. This will extend the period of time required for the hypothetical system above to encounter the problem from 28 days to around 3 trillion years, which feels safely outside of the realms of possibility. The cost of this is slightly more generated code in some commonly executed paths, but this is pretty minimal: | Code Size Gain | Percentage -----------------------|----------------|------------- decstation_defconfig | +270 | +0.00% 32r2el_defconfig | +652 | +0.01% 32r6el_defconfig | +1000 | +0.01% I have been unable to measure any change in performance of the LMbench lat_ctx or lat_proc tests resulting from the 64b ASIDs on either 32r2el_defconfig+interAptiv or 32r6el_defconfig+I6500 systems. Signed-off-by: Paul Burton <paul.burton(a)mips.com> Suggested-by: James Hogan <jhogan(a)kernel.org> References: https://lore.kernel.org/linux-mips/80B78A8B8FEE6145A87579E8435D78C30205D5F3… References: https://lore.kernel.org/linux-mips/1488684260-18867-1-git-send-email-jiwei.… Cc: Jiwei Sun <jiwei.sun(a)windriver.com> Cc: Yu Huabing <yhb(a)ruijie.com.cn> Cc: stable(a)vger.kernel.org # 2.6.12+ --- arch/mips/include/asm/cpu-info.h | 2 +- arch/mips/include/asm/mmu.h | 2 +- arch/mips/include/asm/mmu_context.h | 8 ++++---- arch/mips/mm/c-r3k.c | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/mips/include/asm/cpu-info.h b/arch/mips/include/asm/cpu-info.h index a41059d47d31..ed7ffe4e63a3 100644 --- a/arch/mips/include/asm/cpu-info.h +++ b/arch/mips/include/asm/cpu-info.h @@ -50,7 +50,7 @@ struct guest_info { #define MIPS_CACHE_PINDEX 0x00000020 /* Physically indexed cache */ struct cpuinfo_mips { - unsigned long asid_cache; + u64 asid_cache; #ifdef CONFIG_MIPS_ASID_BITS_VARIABLE unsigned long asid_mask; #endif diff --git a/arch/mips/include/asm/mmu.h b/arch/mips/include/asm/mmu.h index 0740be7d5d4a..24d6b42345fb 100644 --- a/arch/mips/include/asm/mmu.h +++ b/arch/mips/include/asm/mmu.h @@ -7,7 +7,7 @@ #include <linux/wait.h> typedef struct { - unsigned long asid[NR_CPUS]; + u64 asid[NR_CPUS]; void *vdso; atomic_t fp_mode_switching; diff --git a/arch/mips/include/asm/mmu_context.h b/arch/mips/include/asm/mmu_context.h index 94414561de0e..fd869d538a3c 100644 --- a/arch/mips/include/asm/mmu_context.h +++ b/arch/mips/include/asm/mmu_context.h @@ -76,14 +76,14 @@ extern unsigned long pgd_current[]; * All unused by hardware upper bits will be considered * as a software asid extension. */ -static unsigned long asid_version_mask(unsigned int cpu) +static u64 asid_version_mask(unsigned int cpu) { unsigned long asid_mask = cpu_asid_mask(&cpu_data[cpu]); - return ~(asid_mask | (asid_mask - 1)); + return ~(u64)(asid_mask | (asid_mask - 1)); } -static unsigned long asid_first_version(unsigned int cpu) +static u64 asid_first_version(unsigned int cpu) { return ~asid_version_mask(cpu) + 1; } @@ -102,7 +102,7 @@ static inline void enter_lazy_tlb(struct mm_struct *mm, struct task_struct *tsk) static inline void get_new_mmu_context(struct mm_struct *mm, unsigned long cpu) { - unsigned long asid = asid_cache(cpu); + u64 asid = asid_cache(cpu); if (!((asid += cpu_asid_inc()) & cpu_asid_mask(&cpu_data[cpu]))) { if (cpu_has_vtag_icache) diff --git a/arch/mips/mm/c-r3k.c b/arch/mips/mm/c-r3k.c index 3466fcdae0ca..01848cdf2074 100644 --- a/arch/mips/mm/c-r3k.c +++ b/arch/mips/mm/c-r3k.c @@ -245,7 +245,7 @@ static void r3k_flush_cache_page(struct vm_area_struct *vma, pmd_t *pmdp; pte_t *ptep; - pr_debug("cpage[%08lx,%08lx]\n", + pr_debug("cpage[%08llx,%08lx]\n", cpu_context(smp_processor_id(), mm), addr); /* No ASID => no such page in the cache. */ -- 2.19.1

6 years, 9 months

1
2
0 0

stable-rc/linux-4.19.y boot: 117 boots: 0 failed, 116 passed with 1 offline (v4.19.9-143-g4875bf1f86d7)

by kernelci.org bot

stable-rc/linux-4.19.y boot: 117 boots: 0 failed, 116 passed with 1 offline (v4.19.9-143-g4875bf1f86d7) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.19.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.19.y/kernel/v4.19.9-143… Tree: stable-rc Branch: linux-4.19.y Git Describe: v4.19.9-143-g4875bf1f86d7 Git Commit: 4875bf1f86d7bdc8dbf3222ab4028239446fab3f Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 62 unique boards, 23 SoC families, 12 builds out of 202 Offline Platforms: arm: multi_v7_defconfig: stih410-b2120: 1 offline lab --- For more info write to <info(a)kernelci.org>

6 years, 9 months

1
0
0 0

[PATCH 4.19 000/110] 4.19.6-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.6 release. There are 110 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat Dec 1 13:58:54 UTC 2018. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.6-rc1… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.6-rc1 Hugues Fruchet <hugues.fruchet(a)st.com> media: ov5640: fix auto controls values when switching to manual mode Hugues Fruchet <hugues.fruchet(a)st.com> media: ov5640: fix wrong binning value in exposure calculation Hugues Fruchet <hugues.fruchet(a)st.com> media: ov5640: fix auto gain & exposure when changing mode Hugues Fruchet <hugues.fruchet(a)st.com> media: ov5640: fix exposure regression Jacopo Mondi <jacopo(a)jmondi.org> media: ov5640: Fix timings setup code Jacopo Mondi <jacopo(a)jmondi.org> media: ov5640: Re-work MIPI startup sequence Paul E. McKenney <paulmck(a)linux.vnet.ibm.com> rcu: Make need_resched() respond to urgent RCU-QS needs Andreas Gruenbacher <agruenba(a)redhat.com> gfs2: Fix iomap buffer head reference counting bug Greg Kroah-Hartman <greg(a)kroah.com> tty: wipe buffer if not echoing data Linus Torvalds <torvalds(a)linux-foundation.org> tty: wipe buffer. Sebastien Boisvert <sebhtml(a)videotron.qc.ca> include/linux/pfn_t.h: force '~' to be parsed as an unary operator Matthew Wilcox <willy(a)infradead.org> dax: Avoid losing wakeup in dax_lock_mapping_entry Michal Hocko <mhocko(a)suse.com> mm, page_alloc: check for max order in hot path Yufen Yu <yuyufen(a)huawei.com> tmpfs: make lseek(SEEK_DATA/SEK_HOLE) return ENXIO with a negative offset Michal Hocko <mhocko(a)suse.com> mm, memory_hotplug: check zone_movable in has_unmovable_pages Vitaly Wool <vitalywool(a)gmail.com> z3fold: fix possible reclaim races Ard Biesheuvel <ard.biesheuvel(a)linaro.org> efi/arm: Revert deferred unmap of early memmap mapping Satheesh Rajendran <sathnaga(a)linux.vnet.ibm.com> powerpc/numa: Suppress "VPHN is not supported" messages Trond Myklebust <trond.myklebust(a)hammerspace.com> NFSv4: Fix an Oops during delegation callbacks Prarit Bhargava <prarit(a)redhat.com> kdb: Use strscpy with destination buffer size Philip Yang <Philip.Yang(a)amd.com> drm/amdgpu: fix bug with IH ring setup Olof Johansson <olof(a)lixom.net> RISC-V: Silence some module warnings on 32-bit David Abdurachmanov <david.abdurachmanov(a)gmail.com> riscv: add missing vdso_install target Trond Myklebust <trond.myklebust(a)hammerspace.com> SUNRPC: Fix a bogus get/put in generic_key_to_expire() Hannes Reinecke <hare(a)suse.com> block: copy ioprio in __bio_clone_fast() and bounce Russell King <rmk+kernel(a)armlinux.org.uk> ARM: spectre-v2: per-CPU vtables to work around big.Little systems Russell King <rmk+kernel(a)armlinux.org.uk> ARM: add PROC_VTABLE and PROC_TABLE macros Russell King <rmk+kernel(a)armlinux.org.uk> ARM: clean up per-processor check_bugs method call Russell King <rmk+kernel(a)armlinux.org.uk> ARM: make lookup_processor_type() non-__init Kan Liang <kan.liang(a)linux.intel.com> perf/x86/intel/uncore: Add more IMC PCI IDs for KabyLake and CoffeeLake CPUs Patrick Bellasi <patrick.bellasi(a)arm.com> sched/fair: Fix cpu_util_wake() for 'execl' type workloads Michael Ellerman <mpe(a)ellerman.id.au> powerpc/io: Fix the IO workarounds code to work with Radix Jens Axboe <axboe(a)kernel.dk> floppy: fix race condition in __floppy_read_block_0() Ard Biesheuvel <ard.biesheuvel(a)linaro.org> crypto: simd - correctly take reqsize of wrapped skcipher into account Xulin Sun <xulin.sun(a)windriver.com> rtc: pcf2127: fix a kmemleak caused in pcf2127_i2c_gather_write Hans de Goede <hdegoede(a)redhat.com> rtc: cmos: Do not export alarm rtc_ops when we do not support alarms Anson Huang <anson.huang(a)nxp.com> cpufreq: imx6q: add return value check for voltage scale Scott Wood <oss(a)buserror.net> KVM: PPC: Move and undef TRACE_INCLUDE_PATH/FILE YueHaibing <yuehaibing(a)huawei.com> scsi: hisi_sas: Remove set but not used variable 'dq_list' Arnd Bergmann <arnd(a)arndb.de> scsi: lpfc: fix remoteport access Masayoshi Mizuma <m.mizuma(a)jp.fujitsu.com> tools/testing/nvdimm: Fix the array size for dimm devices. Jerome Brunet <jbrunet(a)baylibre.com> pinctrl: meson: fix meson8b ao pull register bits Jerome Brunet <jbrunet(a)baylibre.com> pinctrl: meson: fix meson8 ao pull register bits Jerome Brunet <jbrunet(a)baylibre.com> pinctrl: meson: fix gxl ao pull register bits Jerome Brunet <jbrunet(a)baylibre.com> pinctrl: meson: fix gxbb ao pull register bits Jerome Brunet <jbrunet(a)baylibre.com> pinctrl: meson: fix pinconf bias disable Amir Goldstein <amir73il(a)gmail.com> fanotify: fix handling of events on child sub-directory Amir Goldstein <amir73il(a)gmail.com> fsnotify: generalize handling of extra event flags Michael J. Ruhl <michael.j.ruhl(a)intel.com> IB/hfi1: Eliminate races in the SDMA send error path Erik Schmauss <erik.schmauss(a)intel.com> ACPICA: AML interpreter: add region addresses in global list during initialization Marc Kleine-Budde <mkl(a)pengutronix.de> can: flexcan: remove not needed struct flexcan_priv::tx_mb and struct flexcan_priv::tx_mb_idx Alexander Stein <alexander.stein(a)systec-electronic.com> can: flexcan: Always use last mailbox for TX Lukas Wunner <lukas(a)wunner.de> can: hi311x: Use level-triggered interrupt Oliver Hartkopp <socketcan(a)hartkopp.net> can: raw: check for CAN FD capable netdev in raw_sendmsg() Oleksij Rempel <o.rempel(a)pengutronix.de> can: flexcan: handle tx-complete CAN frames via rx-offload infrastructure Oleksij Rempel <o.rempel(a)pengutronix.de> can: flexcan: use can_rx_offload_queue_sorted() for flexcan_irq_bus_*() Oleksij Rempel <o.rempel(a)pengutronix.de> can: rx-offload: rename can_rx_offload_irq_queue_err_skb() to can_rx_offload_queue_tail() Oleksij Rempel <o.rempel(a)pengutronix.de> can: rx-offload: introduce can_rx_offload_get_echo_skb() and can_rx_offload_queue_sorted() functions Marc Kleine-Budde <mkl(a)pengutronix.de> can: dev: __can_get_echo_skb(): print error message, if trying to echo non existing skb Marc Kleine-Budde <mkl(a)pengutronix.de> can: dev: __can_get_echo_skb(): Don't crash the kernel if can_priv::echo_skb is accessed out of bounds Marc Kleine-Budde <mkl(a)pengutronix.de> can: dev: __can_get_echo_skb(): replace struct can_frame by canfd_frame to access frame length Marc Kleine-Budde <mkl(a)pengutronix.de> can: dev: can_get_echo_skb(): factor out non sending code to __can_get_echo_skb() Pankaj Bansal <pankaj.bansal(a)nxp.com> can: flexcan: Unlock the MB unconditionally Thomas Zimmermann <tzimmermann(a)suse.de> drm/ast: Remove existing framebuffers before loading driver Y.C. Chen <yc_chen(a)aspeedtech.com> drm/ast: fixed cursor may disappear sometimes Y.C. Chen <yc_chen(a)aspeedtech.com> drm/ast: change resolution may cause screen blurred Ville Syrjälä <ville.syrjala(a)linux.intel.com> drm/i915: Disable LP3 watermarks on all SNB machines Felix Kuehling <Felix.Kuehling(a)amd.com> drm/amdgpu: Fix oops when pp_funcs->switch_power_profile is unset Boris Brezillon <boris.brezillon(a)bootlin.com> drm/vc4: Set ->legacy_cursor_update to false when doing non-async updates Takashi Iwai <tiwai(a)suse.de> drm/amdgpu: Add missing firmware entry for HAINAN Paul Kocialkowski <paul.kocialkowski(a)bootlin.com> drm/fb-helper: Blacklist writeback when adding connectors to fbdev Eric Dumazet <edumazet(a)google.com> tcp: do not release socket ownership in tcp_close() Aneesh Kumar K.V <aneesh.kumar(a)linux.ibm.com> mm/memory.c: recheck page table entry with page table lock held Dmitry Vyukov <dvyukov(a)google.com> mm: don't warn about large allocations for slab Eric Dumazet <edumazet(a)google.com> llc: do not use sk_eat_skb() Andrew Price <anprice(a)redhat.com> gfs2: Don't leave s_fs_info pointing to freed memory in init_sbd Xin Long <lucien.xin(a)gmail.com> sctp: clear the transport of some out_chunk_list chunks in sctp_assoc_rm_peer Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> bfs: add sanity check at bfs_fill_super() Dmitry Torokhov <dmitry.torokhov(a)gmail.com> Input: synaptics - avoid using uninitialized variable when probing Tetsuo Handa <penguin-kernel(a)i-love.sakura.ne.jp> selinux: Add __GFP_NOWARN to allocation at str_read() Dominique Martinet <dominique.martinet(a)cea.fr> v9fs_dir_readdir: fix double-free on p9stat_read error Konstantin Khlebnikov <khlebnikov(a)yandex-team.ru> tools/power/cpupower: fix compilation with STATIC=true Keerthy <j-keerthy(a)ti.com> opp: ti-opp-supply: Correct the supply in _get_optimal_vdd_voltage call Keerthy <j-keerthy(a)ti.com> opp: ti-opp-supply: Dynamically update u_volt_min Rafał Miłecki <rafal(a)milecki.pl> brcmfmac: fix reporting support for 160 MHz channels Luca Coelho <luciano.coelho(a)intel.com> iwlwifi: mvm: don't use SAR Geo if basic SAR is not used Emmanuel Grumbach <emmanuel.grumbach(a)intel.com> iwlwifi: mvm: fix regulatory domain update when the firmware starts Emmanuel Grumbach <emmanuel.grumbach(a)intel.com> iwlwifi: mvm: support sta_statistics() even on older firmware Matt Chen <matt.chen(a)intel.com> iwlwifi: fix wrong WGDS_WIFI_DATA_SIZE Vladimir Zapolskiy <vz(a)mleia.com> gpio: don't free unallocated ida on gpiochip_add_data_with_key() error path Adrian Hunter <adrian.hunter(a)intel.com> mmc: sdhci-pci: Workaround GLK firmware failing to restore the tuning value Rajat Jain <rajatja(a)google.com> mmc: sdhci-pci: Try "cd" for card-detect lookup before using NULL Will Deacon <will.deacon(a)arm.com> Documentation/security-bugs: Postpone fix publication in exceptional cases Will Deacon <will.deacon(a)arm.com> Documentation/security-bugs: Clarify treatment of embargoed information Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> MAINTAINERS: Add Sasha as a stable branch maintainer Takashi Iwai <tiwai(a)suse.de> ALSA: oss: Use kvzalloc() for local buffer allocations Mathias Nyman <mathias.nyman(a)linux.intel.com> usb: xhci: Prevent bus suspend if a port connect change or polling state is detected Cherian, George <George.Cherian(a)cavium.com> xhci: Add quirk to workaround the errata seen on Cavium Thunder-X2 Soc Aaron Ma <aaron.ma(a)canonical.com> usb: xhci: fix timeout for transition from RExit to U0 Aaron Ma <aaron.ma(a)canonical.com> usb: xhci: fix uninitialized completion when USB3 port got wrong status Sandeep Singh <sandeep.singh(a)amd.com> xhci: Add check for invalid byte size error when UAS devices are connected. Mathias Nyman <mathias.nyman(a)linux.intel.com> xhci: handle port status events for removed USB3 hcd Mathias Nyman <mathias.nyman(a)linux.intel.com> xhci: Fix leaking USB3 shared_hcd at xhci removal Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy(a)linux.intel.com> usb: dwc3: Fix NULL pointer exception in dwc3_pci_remove() Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> usb: dwc3: core: Clean up ULPI device Thinh Nguyen <Thinh.Nguyen(a)synopsys.com> usb: dwc3: gadget: Properly check last unaligned/zero chain TRB Felipe Balbi <felipe.balbi(a)linux.intel.com> usb: dwc3: gadget: fix ISOC TRB type on unaligned transfers Dennis Wassenberg <dennis.wassenberg(a)secunet.com> usb: core: Fix hub port connection events lost Alistair Strachan <astrachan(a)google.com> efi/libstub: arm: support building with clang Rodrigo Rivas Costa <rodrigorivascosta(a)gmail.com> HID: steam: remove input device when a hid client is running. ------------- Diffstat: Documentation/admin-guide/security-bugs.rst | 48 ++-- .../devicetree/bindings/net/can/holt_hi311x.txt | 2 +- MAINTAINERS | 1 + Makefile | 4 +- arch/arm/include/asm/proc-fns.h | 61 ++++- arch/arm/kernel/bugs.c | 4 +- arch/arm/kernel/head-common.S | 6 +- arch/arm/kernel/setup.c | 9 +- arch/arm/kernel/smp.c | 31 +++ arch/arm/mm/proc-v7-bugs.c | 17 +- arch/powerpc/include/asm/io.h | 20 +- arch/powerpc/kvm/trace.h | 8 +- arch/powerpc/kvm/trace_booke.h | 9 +- arch/powerpc/kvm/trace_hv.h | 9 +- arch/powerpc/kvm/trace_pr.h | 9 +- arch/powerpc/mm/numa.c | 2 +- arch/riscv/Makefile | 4 + arch/riscv/kernel/module.c | 12 +- arch/x86/events/intel/uncore_snb.c | 115 ++++++++- block/bio.c | 1 + block/bounce.c | 1 + crypto/simd.c | 5 +- drivers/acpi/acpica/dsopcode.c | 4 + drivers/block/floppy.c | 3 +- drivers/cpufreq/imx6q-cpufreq.c | 7 +- drivers/firmware/efi/arm-init.c | 4 + drivers/firmware/efi/arm-runtime.c | 2 +- drivers/firmware/efi/libstub/Makefile | 3 +- drivers/firmware/efi/memmap.c | 3 + drivers/gpio/gpiolib.c | 5 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 7 +- drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 1 + drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 2 +- drivers/gpu/drm/ast/ast_drv.c | 21 ++ drivers/gpu/drm/ast/ast_mode.c | 3 +- drivers/gpu/drm/drm_fb_helper.c | 3 + drivers/gpu/drm/i915/intel_pm.c | 41 +++- drivers/gpu/drm/vc4/vc4_kms.c | 6 + drivers/hid/hid-steam.c | 154 +++++++----- drivers/infiniband/hw/hfi1/user_sdma.c | 87 +++---- drivers/infiniband/hw/hfi1/user_sdma.h | 3 - drivers/input/mouse/synaptics.c | 4 +- drivers/media/i2c/ov5640.c | 263 +++++++++++++-------- drivers/mmc/host/sdhci-pci-core.c | 86 ++++++- drivers/net/can/dev.c | 48 +++- drivers/net/can/flexcan.c | 108 +++++---- drivers/net/can/rx-offload.c | 51 +++- drivers/net/can/spi/hi311x.c | 2 +- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 3 +- drivers/net/wireless/intel/iwlwifi/fw/acpi.h | 4 +- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 38 ++- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 12 +- drivers/net/wireless/intel/iwlwifi/mvm/nvm.c | 5 +- drivers/opp/ti-opp-supply.c | 5 +- drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 2 +- drivers/pinctrl/meson/pinctrl-meson-gxl.c | 2 +- drivers/pinctrl/meson/pinctrl-meson.c | 2 +- drivers/pinctrl/meson/pinctrl-meson8.c | 2 +- drivers/pinctrl/meson/pinctrl-meson8b.c | 2 +- drivers/rtc/rtc-cmos.c | 16 +- drivers/rtc/rtc-pcf2127.c | 3 + drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 2 - drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 2 - drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 2 - drivers/scsi/lpfc/lpfc_debugfs.c | 2 + drivers/tty/n_tty.c | 20 +- drivers/tty/tty_buffer.c | 6 +- drivers/usb/core/hub.c | 4 +- drivers/usb/dwc3/core.c | 1 + drivers/usb/dwc3/dwc3-pci.c | 4 +- drivers/usb/dwc3/gadget.c | 8 +- drivers/usb/host/xhci-histb.c | 6 +- drivers/usb/host/xhci-hub.c | 66 ++++-- drivers/usb/host/xhci-mtk.c | 6 +- drivers/usb/host/xhci-pci.c | 6 + drivers/usb/host/xhci-plat.c | 6 +- drivers/usb/host/xhci-ring.c | 45 +++- drivers/usb/host/xhci-tegra.c | 1 + drivers/usb/host/xhci.c | 2 - drivers/usb/host/xhci.h | 3 +- fs/9p/vfs_dir.c | 11 - fs/bfs/inode.c | 9 +- fs/dax.c | 7 +- fs/gfs2/bmap.c | 40 ++-- fs/gfs2/ops_fstype.c | 2 +- fs/nfs/callback_proc.c | 4 +- fs/nfs/delegation.c | 11 +- fs/notify/fanotify/fanotify.c | 10 +- fs/notify/fsnotify.c | 15 +- include/linux/can/dev.h | 1 + include/linux/can/rx-offload.h | 7 +- include/linux/fsnotify_backend.h | 9 +- include/linux/pfn_t.h | 2 +- include/net/sock.h | 1 + kernel/debug/kdb/kdb_io.c | 15 +- kernel/debug/kdb/kdb_private.h | 2 +- kernel/debug/kdb/kdb_support.c | 10 +- kernel/rcu/tree.c | 9 + kernel/sched/fair.c | 62 +++-- mm/memory.c | 34 ++- mm/page_alloc.c | 28 ++- mm/shmem.c | 4 +- mm/slab.c | 4 + mm/slab_common.c | 12 +- mm/z3fold.c | 101 +++++--- net/can/raw.c | 15 +- net/core/sock.c | 2 +- net/ipv4/tcp.c | 11 +- net/llc/af_llc.c | 11 +- net/sctp/associola.c | 10 +- net/sunrpc/auth_generic.c | 8 +- security/selinux/ss/policydb.c | 2 +- sound/core/oss/pcm_oss.c | 6 +- sound/core/oss/pcm_plugin.c | 6 +- tools/power/cpupower/bench/Makefile | 2 +- tools/power/cpupower/lib/cpufreq.c | 2 +- tools/power/cpupower/lib/cpuidle.c | 2 +- tools/power/cpupower/lib/cpupower.c | 4 +- tools/power/cpupower/lib/cpupower_intern.h | 2 +- tools/testing/nvdimm/test/nfit.c | 8 +- 120 files changed, 1435 insertions(+), 653 deletions(-)

6 years, 9 months

13
142
0 0

stable-rc/linux-4.4.y boot: 93 boots: 1 failed, 91 passed with 1 offline (v4.4.167-89-g9c558d7fe359)

by kernelci.org bot

stable-rc/linux-4.4.y boot: 93 boots: 1 failed, 91 passed with 1 offline (v4.4.167-89-g9c558d7fe359) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.4.y/kernel/v4.4.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.167-89-… Tree: stable-rc Branch: linux-4.4.y Git Describe: v4.4.167-89-g9c558d7fe359 Git Commit: 9c558d7fe359a962e214e426ffeb338e012bba39 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 42 unique boards, 20 SoC families, 12 builds out of 187 Boot Failure Detected: arm64: defconfig qcom-qdf2400: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: stih410-b2120: 1 offline lab --- For more info write to <info(a)kernelci.org>

6 years, 9 months

1
0
0 0

Re: [PATCH v2] crypto: talitos - fix ablkcipher for CONFIG_VMAP_STACK

by Christophe Leroy

Le 14/12/2018 à 02:39, Sasha Levin a écrit : > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 4de9d0b547b9 crypto: talitos - Add ablkcipher algorithms. > > The bot has tested the following trees: v4.19.9, v4.14.88, v4.9.145, v4.4.167, v3.18.129, > > v4.19.9: Build OK! > v4.14.88: Failed to apply! Possible dependencies: > 2e13ce0812c6 ("crypto: talitos - DMA map key in setkey()") > 9a655608a468 ("crypto: talitos - simplify tests in ipsec_esp()") > da9de146ebd9 ("crypto: talitos - remove to_talitos_ptr_len()") > > v4.9.145: Failed to apply! Possible dependencies: > 2e13ce0812c6 ("crypto: talitos - DMA map key in setkey()") > 9a655608a468 ("crypto: talitos - simplify tests in ipsec_esp()") > da9de146ebd9 ("crypto: talitos - remove to_talitos_ptr_len()") > > v4.4.167: Failed to apply! Possible dependencies: > 246a87cda070 ("crypto: talitos - move mapping helpers before IPSEC functions") > 2e13ce0812c6 ("crypto: talitos - DMA map key in setkey()") > 549bd8bc5987 ("crypto: talitos - Implement AEAD for SEC1 using HMAC_SNOOP_NO_AFEU") > 6a1e8d14156d ("crypto: talitos - making mapping helpers more generic") > 8e409fe10695 ("crypto: talitos - check return value of sg_nents_for_len") > 9a655608a468 ("crypto: talitos - simplify tests in ipsec_esp()") > b096b544d6c3 ("crypto: talitos - using helpers for all talitos_ptr operations") > da9de146ebd9 ("crypto: talitos - remove to_talitos_ptr_len()") > e04a61bebc5d ("crypto: talitos - fix memory corruption on SEC2") > > v3.18.129: Failed to apply! Possible dependencies: > 032d197eaaea ("crypto: talitos - Refactor the sg in/out chain allocation") > 185eb79f6a65 ("crypto: talitos - Add a helper function to clear j_extent field") > 20ec9d814e68 ("crypto: sahara - fix spinlock initialization") > 538caf83374c ("crypto: talitos - helper function for ptr len") > 5a2bb93f5992 ("crypto: sahara - add support for SHA1/256") > 5be4d4c94b1f ("crypto: replace scatterwalk_sg_next with sg_next") > 922f9dc8d366 ("crypto: talitos - fill in talitos descriptor iaw SEC1 or SEC2+") > a2b35aa86eea ("crypto: talitos - remove param 'extent' in map_single_talitos_ptr()") > a861afbc931b ("crypto: ablkcipher - fixed style errors in ablkcipher.c") > aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface") > bde9079f3cd5 ("crypto: talitos - avoid out of bound scatterlist iterator") > c0c3c89ae347 ("crypto: sahara - replace tasklets with kthread") > edc6bd698a4d ("crypto: talitos - talitos_ptr renamed ptr for more lisibility") > f129430dd87d ("crypto: nx - Fixing the limit number of bytes to be processed") > > > How should we proceed with this patch? I'll backport it once it is in linux tree. Christophe > > -- > Thanks, > Sasha >

6 years, 9 months

1
0
0 0

stable-rc/linux-4.14.y boot: 116 boots: 1 failed, 111 passed with 2 offline, 2 untried/unknown (v4.14.88-90-g159976987c2f)

by kernelci.org bot

stable-rc/linux-4.14.y boot: 116 boots: 1 failed, 111 passed with 2 offline, 2 untried/unknown (v4.14.88-90-g159976987c2f) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.14.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.14.y/kernel/v4.14.88-90… Tree: stable-rc Branch: linux-4.14.y Git Describe: v4.14.88-90-g159976987c2f Git Commit: 159976987c2f89308c6293a31e8fa9543549b94b Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 60 unique boards, 23 SoC families, 12 builds out of 197 Boot Regressions Detected: arm64: defconfig: rk3399-firefly: lab-baylibre-seattle: failing since 5 days (last pass: v4.14.86-56-g555f40d53cca - first fail: v4.14.87) Boot Failure Detected: arm64: defconfig rk3399-firefly: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: stih410-b2120: 1 offline lab arm64: defconfig: sun50i-a64-pine64-plus: 1 offline lab --- For more info write to <info(a)kernelci.org>

6 years, 9 months

1
0
0 0

stable-rc/linux-4.9.y boot: 104 boots: 0 failed, 103 passed with 1 offline (v4.9.145-52-g88d902c956b8)

by kernelci.org bot

stable-rc/linux-4.9.y boot: 104 boots: 0 failed, 103 passed with 1 offline (v4.9.145-52-g88d902c956b8) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.9.y/kernel/v4.9.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.9.y/kernel/v4.9.145-52-… Tree: stable-rc Branch: linux-4.9.y Git Describe: v4.9.145-52-g88d902c956b8 Git Commit: 88d902c956b8078676b83e964db1f896bb548134 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 49 unique boards, 21 SoC families, 13 builds out of 193 Offline Platforms: arm: multi_v7_defconfig: stih410-b2120: 1 offline lab --- For more info write to <info(a)kernelci.org>

6 years, 9 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror