- Linux-stable-mirror - lists.linaro.org

FAILED: patch "[PATCH] svcrdma: Remove max_sge check at connect time" failed to apply to 4.18-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.18-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From e248aa7be86e8179f20ac0931774ecd746f3f5bf Mon Sep 17 00:00:00 2001 From: Chuck Lever <chuck.lever(a)oracle.com> Date: Fri, 25 Jan 2019 16:54:54 -0500 Subject: [PATCH] svcrdma: Remove max_sge check at connect time Two and a half years ago, the client was changed to use gathered Send for larger inline messages, in commit 655fec6987b ("xprtrdma: Use gathered Send for large inline messages"). Several fixes were required because there are a few in-kernel device drivers whose max_sge is 3, and these were broken by the change. Apparently my memory is going, because some time later, I submitted commit 25fd86eca11c ("svcrdma: Don't overrun the SGE array in svc_rdma_send_ctxt"), and after that, commit f3c1fd0ee294 ("svcrdma: Reduce max_send_sges"). These too incorrectly assumed in-kernel device drivers would have more than a few Send SGEs available. The fix for the server side is not the same. This is because the fundamental problem on the server is that, whether or not the client has provisioned a chunk for the RPC reply, the server must squeeze even the most complex RPC replies into a single RDMA Send. Failing in the send path because of Send SGE exhaustion should never be an option. Therefore, instead of failing when the send path runs out of SGEs, switch to using a bounce buffer mechanism to handle RPC replies that are too complex for the device to send directly. That allows us to remove the max_sge check to enable drivers with small max_sge to work again. Reported-by: Don Dutile <ddutile(a)redhat.com> Fixes: 25fd86eca11c ("svcrdma: Don't overrun the SGE array in ...") Cc: stable(a)vger.kernel.org Signed-off-by: Chuck Lever <chuck.lever(a)oracle.com> Signed-off-by: J. Bruce Fields <bfields(a)redhat.com> diff --git a/net/sunrpc/xprtrdma/svc_rdma_sendto.c b/net/sunrpc/xprtrdma/svc_rdma_sendto.c index cf51b8f9b15f..1f200119268c 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_sendto.c +++ b/net/sunrpc/xprtrdma/svc_rdma_sendto.c @@ -537,6 +537,99 @@ void svc_rdma_sync_reply_hdr(struct svcxprt_rdma *rdma, DMA_TO_DEVICE); } +/* If the xdr_buf has more elements than the device can + * transmit in a single RDMA Send, then the reply will + * have to be copied into a bounce buffer. + */ +static bool svc_rdma_pull_up_needed(struct svcxprt_rdma *rdma, + struct xdr_buf *xdr, + __be32 *wr_lst) +{ + int elements; + + /* xdr->head */ + elements = 1; + + /* xdr->pages */ + if (!wr_lst) { + unsigned int remaining; + unsigned long pageoff; + + pageoff = xdr->page_base & ~PAGE_MASK; + remaining = xdr->page_len; + while (remaining) { + ++elements; + remaining -= min_t(u32, PAGE_SIZE - pageoff, + remaining); + pageoff = 0; + } + } + + /* xdr->tail */ + if (xdr->tail[0].iov_len) + ++elements; + + /* assume 1 SGE is needed for the transport header */ + return elements >= rdma->sc_max_send_sges; +} + +/* The device is not capable of sending the reply directly. + * Assemble the elements of @xdr into the transport header + * buffer. + */ +static int svc_rdma_pull_up_reply_msg(struct svcxprt_rdma *rdma, + struct svc_rdma_send_ctxt *ctxt, + struct xdr_buf *xdr, __be32 *wr_lst) +{ + unsigned char *dst, *tailbase; + unsigned int taillen; + + dst = ctxt->sc_xprt_buf; + dst += ctxt->sc_sges[0].length; + + memcpy(dst, xdr->head[0].iov_base, xdr->head[0].iov_len); + dst += xdr->head[0].iov_len; + + tailbase = xdr->tail[0].iov_base; + taillen = xdr->tail[0].iov_len; + if (wr_lst) { + u32 xdrpad; + + xdrpad = xdr_padsize(xdr->page_len); + if (taillen && xdrpad) { + tailbase += xdrpad; + taillen -= xdrpad; + } + } else { + unsigned int len, remaining; + unsigned long pageoff; + struct page **ppages; + + ppages = xdr->pages + (xdr->page_base >> PAGE_SHIFT); + pageoff = xdr->page_base & ~PAGE_MASK; + remaining = xdr->page_len; + while (remaining) { + len = min_t(u32, PAGE_SIZE - pageoff, remaining); + + memcpy(dst, page_address(*ppages), len); + remaining -= len; + dst += len; + pageoff = 0; + } + } + + if (taillen) + memcpy(dst, tailbase, taillen); + + ctxt->sc_sges[0].length += xdr->len; + ib_dma_sync_single_for_device(rdma->sc_pd->device, + ctxt->sc_sges[0].addr, + ctxt->sc_sges[0].length, + DMA_TO_DEVICE); + + return 0; +} + /* svc_rdma_map_reply_msg - Map the buffer holding RPC message * @rdma: controlling transport * @ctxt: send_ctxt for the Send WR @@ -559,8 +652,10 @@ int svc_rdma_map_reply_msg(struct svcxprt_rdma *rdma, u32 xdr_pad; int ret; - if (++ctxt->sc_cur_sge_no >= rdma->sc_max_send_sges) - return -EIO; + if (svc_rdma_pull_up_needed(rdma, xdr, wr_lst)) + return svc_rdma_pull_up_reply_msg(rdma, ctxt, xdr, wr_lst); + + ++ctxt->sc_cur_sge_no; ret = svc_rdma_dma_map_buf(rdma, ctxt, xdr->head[0].iov_base, xdr->head[0].iov_len); @@ -591,8 +686,7 @@ int svc_rdma_map_reply_msg(struct svcxprt_rdma *rdma, while (remaining) { len = min_t(u32, PAGE_SIZE - page_off, remaining); - if (++ctxt->sc_cur_sge_no >= rdma->sc_max_send_sges) - return -EIO; + ++ctxt->sc_cur_sge_no; ret = svc_rdma_dma_map_page(rdma, ctxt, *ppages++, page_off, len); if (ret < 0) @@ -606,8 +700,7 @@ int svc_rdma_map_reply_msg(struct svcxprt_rdma *rdma, len = xdr->tail[0].iov_len; tail: if (len) { - if (++ctxt->sc_cur_sge_no >= rdma->sc_max_send_sges) - return -EIO; + ++ctxt->sc_cur_sge_no; ret = svc_rdma_dma_map_buf(rdma, ctxt, base, len); if (ret < 0) return ret; diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c index 924c17d46903..57f86c63a463 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c @@ -419,12 +419,9 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt) /* Transport header, head iovec, tail iovec */ newxprt->sc_max_send_sges = 3; /* Add one SGE per page list entry */ - newxprt->sc_max_send_sges += svcrdma_max_req_size / PAGE_SIZE; - if (newxprt->sc_max_send_sges > dev->attrs.max_send_sge) { - pr_err("svcrdma: too few Send SGEs available (%d needed)\n", - newxprt->sc_max_send_sges); - goto errout; - } + newxprt->sc_max_send_sges += (svcrdma_max_req_size / PAGE_SIZE) + 1; + if (newxprt->sc_max_send_sges > dev->attrs.max_send_sge) + newxprt->sc_max_send_sges = dev->attrs.max_send_sge; newxprt->sc_max_req_size = svcrdma_max_req_size; newxprt->sc_max_requests = svcrdma_max_requests; newxprt->sc_max_bc_requests = svcrdma_max_bc_requests;

6 years, 7 months

2
1
0 0

FAILED: patch "[PATCH] drm/amd/powerplay: Fix missing break in switch" failed to apply to 4.14-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 2f10d823739680d2477ce34437e8a08a53117f40 Mon Sep 17 00:00:00 2001 From: "Gustavo A. R. Silva" <gustavo(a)embeddedor.com> Date: Fri, 25 Jan 2019 15:55:33 -0600 Subject: [PATCH] drm/amd/powerplay: Fix missing break in switch Add missing break statement in order to prevent the code from falling through to the default case. The resoning for this is that pclk_vol_table is an automatic variable. So, it makes no sense to update it just before falling through to the default case and return -EINVAL. This bug was found thanks to the ongoing efforts to enabling -Wimplicit-fallthrough. Fixes: cd70f3d6e3fa ("drm/amd/powerplay: PP/DAL interface changes for dynamic clock switch") Cc: stable(a)vger.kernel.org Signed-off-by: Gustavo A. R. Silva <gustavo(a)embeddedor.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c index f95c5f50eb0f..5273de3c5b98 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c @@ -1033,6 +1033,7 @@ static int smu10_get_clock_by_type_with_latency(struct pp_hwmgr *hwmgr, break; case amd_pp_dpp_clock: pclk_vol_table = pinfo->vdd_dep_on_dppclk; + break; default: return -EINVAL; }

6 years, 7 months

1
0
0 0

FAILED: patch "[PATCH] MIPS: VDSO: Use same -m%-float cflag as the kernel proper" failed to apply to 4.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 0648e50e548d881d025b9419a1a168753c8e2bf7 Mon Sep 17 00:00:00 2001 From: Paul Burton <paul.burton(a)mips.com> Date: Mon, 28 Jan 2019 22:21:17 +0000 Subject: [PATCH] MIPS: VDSO: Use same -m%-float cflag as the kernel proper The MIPS VDSO build currently doesn't provide the -msoft-float flag to the compiler as the kernel proper does. This results in an attempt to use the compiler's default floating point configuration, which can be problematic in cases where this is incompatible with the target CPU's -march= flag. For example decstation_defconfig fails to build using toolchains in which gcc was configured --with-fp-32=xx with the following error: LDS arch/mips/vdso/vdso.lds cc1: error: '-march=r3000' requires '-mfp32' make[2]: *** [scripts/Makefile.build:379: arch/mips/vdso/vdso.lds] Error 1 The kernel proper avoids this error because we build with the -msoft-float compiler flag, rather than using the compiler's default. Pass this flag through to the VDSO build so that it too becomes agnostic to the toolchain's floating point configuration. Note that this is filtered out from KBUILD_CFLAGS rather than simply always using -msoft-float such that if we switch the kernel to use -mno-float in the future the VDSO will automatically inherit the change. The VDSO doesn't actually include any floating point code, and its .MIPS.abiflags section is already manually generated to specify that it's compatible with any floating point ABI. As such this change should have no effect on the resulting VDSO, apart from fixing the build failure for affected toolchains. Signed-off-by: Paul Burton <paul.burton(a)mips.com> Reported-by: Kevin Hilman <khilman(a)baylibre.com> Reported-by: Guenter Roeck <linux(a)roeck-us.net> Tested-by: Kevin Hilman <khilman(a)baylibre.com> References: https://lore.kernel.org/linux-mips/1477843551-21813-1-git-send-email-linux@… References: https://kernelci.org/build/id/5c4e4ae059b5142a249ad004/logs/ Fixes: ebb5e78cc634 ("MIPS: Initial implementation of a VDSO") Cc: Maciej W. Rozycki <macro(a)linux-mips.org> Cc: linux-mips(a)vger.kernel.org Cc: stable(a)vger.kernel.org # v4.4+ diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile index f6fd340e39c2..314949b2261d 100644 --- a/arch/mips/vdso/Makefile +++ b/arch/mips/vdso/Makefile @@ -8,6 +8,7 @@ ccflags-vdso := \ $(filter -E%,$(KBUILD_CFLAGS)) \ $(filter -mmicromips,$(KBUILD_CFLAGS)) \ $(filter -march=%,$(KBUILD_CFLAGS)) \ + $(filter -m%-float,$(KBUILD_CFLAGS)) \ -D__VDSO__ ifdef CONFIG_CC_IS_CLANG

6 years, 7 months

1
0
0 0

FAILED: patch "[PATCH] MIPS: VDSO: Use same -m%-float cflag as the kernel proper" failed to apply to 4.9-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.9-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 0648e50e548d881d025b9419a1a168753c8e2bf7 Mon Sep 17 00:00:00 2001 From: Paul Burton <paul.burton(a)mips.com> Date: Mon, 28 Jan 2019 22:21:17 +0000 Subject: [PATCH] MIPS: VDSO: Use same -m%-float cflag as the kernel proper The MIPS VDSO build currently doesn't provide the -msoft-float flag to the compiler as the kernel proper does. This results in an attempt to use the compiler's default floating point configuration, which can be problematic in cases where this is incompatible with the target CPU's -march= flag. For example decstation_defconfig fails to build using toolchains in which gcc was configured --with-fp-32=xx with the following error: LDS arch/mips/vdso/vdso.lds cc1: error: '-march=r3000' requires '-mfp32' make[2]: *** [scripts/Makefile.build:379: arch/mips/vdso/vdso.lds] Error 1 The kernel proper avoids this error because we build with the -msoft-float compiler flag, rather than using the compiler's default. Pass this flag through to the VDSO build so that it too becomes agnostic to the toolchain's floating point configuration. Note that this is filtered out from KBUILD_CFLAGS rather than simply always using -msoft-float such that if we switch the kernel to use -mno-float in the future the VDSO will automatically inherit the change. The VDSO doesn't actually include any floating point code, and its .MIPS.abiflags section is already manually generated to specify that it's compatible with any floating point ABI. As such this change should have no effect on the resulting VDSO, apart from fixing the build failure for affected toolchains. Signed-off-by: Paul Burton <paul.burton(a)mips.com> Reported-by: Kevin Hilman <khilman(a)baylibre.com> Reported-by: Guenter Roeck <linux(a)roeck-us.net> Tested-by: Kevin Hilman <khilman(a)baylibre.com> References: https://lore.kernel.org/linux-mips/1477843551-21813-1-git-send-email-linux@… References: https://kernelci.org/build/id/5c4e4ae059b5142a249ad004/logs/ Fixes: ebb5e78cc634 ("MIPS: Initial implementation of a VDSO") Cc: Maciej W. Rozycki <macro(a)linux-mips.org> Cc: linux-mips(a)vger.kernel.org Cc: stable(a)vger.kernel.org # v4.4+ diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile index f6fd340e39c2..314949b2261d 100644 --- a/arch/mips/vdso/Makefile +++ b/arch/mips/vdso/Makefile @@ -8,6 +8,7 @@ ccflags-vdso := \ $(filter -E%,$(KBUILD_CFLAGS)) \ $(filter -mmicromips,$(KBUILD_CFLAGS)) \ $(filter -march=%,$(KBUILD_CFLAGS)) \ + $(filter -m%-float,$(KBUILD_CFLAGS)) \ -D__VDSO__ ifdef CONFIG_CC_IS_CLANG

6 years, 7 months

1
0
0 0

FAILED: patch "[PATCH] MIPS: VDSO: Use same -m%-float cflag as the kernel proper" failed to apply to 4.14-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 0648e50e548d881d025b9419a1a168753c8e2bf7 Mon Sep 17 00:00:00 2001 From: Paul Burton <paul.burton(a)mips.com> Date: Mon, 28 Jan 2019 22:21:17 +0000 Subject: [PATCH] MIPS: VDSO: Use same -m%-float cflag as the kernel proper The MIPS VDSO build currently doesn't provide the -msoft-float flag to the compiler as the kernel proper does. This results in an attempt to use the compiler's default floating point configuration, which can be problematic in cases where this is incompatible with the target CPU's -march= flag. For example decstation_defconfig fails to build using toolchains in which gcc was configured --with-fp-32=xx with the following error: LDS arch/mips/vdso/vdso.lds cc1: error: '-march=r3000' requires '-mfp32' make[2]: *** [scripts/Makefile.build:379: arch/mips/vdso/vdso.lds] Error 1 The kernel proper avoids this error because we build with the -msoft-float compiler flag, rather than using the compiler's default. Pass this flag through to the VDSO build so that it too becomes agnostic to the toolchain's floating point configuration. Note that this is filtered out from KBUILD_CFLAGS rather than simply always using -msoft-float such that if we switch the kernel to use -mno-float in the future the VDSO will automatically inherit the change. The VDSO doesn't actually include any floating point code, and its .MIPS.abiflags section is already manually generated to specify that it's compatible with any floating point ABI. As such this change should have no effect on the resulting VDSO, apart from fixing the build failure for affected toolchains. Signed-off-by: Paul Burton <paul.burton(a)mips.com> Reported-by: Kevin Hilman <khilman(a)baylibre.com> Reported-by: Guenter Roeck <linux(a)roeck-us.net> Tested-by: Kevin Hilman <khilman(a)baylibre.com> References: https://lore.kernel.org/linux-mips/1477843551-21813-1-git-send-email-linux@… References: https://kernelci.org/build/id/5c4e4ae059b5142a249ad004/logs/ Fixes: ebb5e78cc634 ("MIPS: Initial implementation of a VDSO") Cc: Maciej W. Rozycki <macro(a)linux-mips.org> Cc: linux-mips(a)vger.kernel.org Cc: stable(a)vger.kernel.org # v4.4+ diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile index f6fd340e39c2..314949b2261d 100644 --- a/arch/mips/vdso/Makefile +++ b/arch/mips/vdso/Makefile @@ -8,6 +8,7 @@ ccflags-vdso := \ $(filter -E%,$(KBUILD_CFLAGS)) \ $(filter -mmicromips,$(KBUILD_CFLAGS)) \ $(filter -march=%,$(KBUILD_CFLAGS)) \ + $(filter -m%-float,$(KBUILD_CFLAGS)) \ -D__VDSO__ ifdef CONFIG_CC_IS_CLANG

6 years, 7 months

1
0
0 0

Applied "regulator: s2mpa01: Fix step values for some LDOs" to the regulator tree

by Mark Brown

The patch regulator: s2mpa01: Fix step values for some LDOs has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 28c4f730d2a44f2591cb104091da29a38dac49fe Mon Sep 17 00:00:00 2001 From: Stuart Menefy <stuart.menefy(a)mathembedded.com> Date: Tue, 12 Feb 2019 21:51:18 +0000 Subject: [PATCH] regulator: s2mpa01: Fix step values for some LDOs The step values for some of the LDOs appears to be incorrect, resulting in incorrect voltages (or at least, ones which are different from the Samsung 3.4 vendor kernel). Signed-off-by: Stuart Menefy <stuart.menefy(a)mathembedded.com> Reviewed-by: Krzysztof Kozlowski <krzk(a)kernel.org> Signed-off-by: Mark Brown <broonie(a)kernel.org> Cc: stable(a)vger.kernel.org --- drivers/regulator/s2mpa01.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/regulator/s2mpa01.c b/drivers/regulator/s2mpa01.c index 095d25f3d2ea..58a1fe583a6c 100644 --- a/drivers/regulator/s2mpa01.c +++ b/drivers/regulator/s2mpa01.c @@ -298,13 +298,13 @@ static const struct regulator_desc regulators[] = { regulator_desc_ldo(2, STEP_50_MV), regulator_desc_ldo(3, STEP_50_MV), regulator_desc_ldo(4, STEP_50_MV), - regulator_desc_ldo(5, STEP_50_MV), + regulator_desc_ldo(5, STEP_25_MV), regulator_desc_ldo(6, STEP_25_MV), regulator_desc_ldo(7, STEP_50_MV), regulator_desc_ldo(8, STEP_50_MV), regulator_desc_ldo(9, STEP_50_MV), regulator_desc_ldo(10, STEP_50_MV), - regulator_desc_ldo(11, STEP_25_MV), + regulator_desc_ldo(11, STEP_50_MV), regulator_desc_ldo(12, STEP_50_MV), regulator_desc_ldo(13, STEP_50_MV), regulator_desc_ldo(14, STEP_50_MV), @@ -315,11 +315,11 @@ static const struct regulator_desc regulators[] = { regulator_desc_ldo(19, STEP_50_MV), regulator_desc_ldo(20, STEP_50_MV), regulator_desc_ldo(21, STEP_50_MV), - regulator_desc_ldo(22, STEP_25_MV), - regulator_desc_ldo(23, STEP_25_MV), + regulator_desc_ldo(22, STEP_50_MV), + regulator_desc_ldo(23, STEP_50_MV), regulator_desc_ldo(24, STEP_50_MV), regulator_desc_ldo(25, STEP_50_MV), - regulator_desc_ldo(26, STEP_50_MV), + regulator_desc_ldo(26, STEP_25_MV), regulator_desc_buck1_4(1), regulator_desc_buck1_4(2), regulator_desc_buck1_4(3), -- 2.20.1

6 years, 7 months

1
0
0 0

v4.20.8 build: 0 failures 5 warnings (v4.20.8)

by Build bot for Mark Brown

Tree/Branch: v4.20.8 Git describe: v4.20.8 Commit: 0788acb1a3 Linux 4.20.8 Build Time: 130 min 17 sec Passed: 11 / 11 (100.00 %) Failed: 0 / 11 ( 0.00 %) Errors: 0 Warnings: 5 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): 1 warnings 0 mismatches : x86_64-allmodconfig 2 warnings 0 mismatches : arm64-allmodconfig 1 warnings 0 mismatches : arm-multi_v7_defconfig 4 warnings 0 mismatches : arm-allmodconfig 1 warnings 0 mismatches : arm64-defconfig ------------------------------------------------------------------------------- Warnings Summary: 5 5 ../include/linux/spinlock.h:279:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] 1 ../drivers/staging/erofs/unzip_vle.c:188:29: warning: array subscript is above array bounds [-Warray-bounds] 1 ../drivers/scsi/myrs.c:821:24: warning: 'sshdr.sense_key' may be used uninitialized in this function [-Wmaybe-uninitialized] 1 ../drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:216:1: warning: the frame size of 1064 bytes is larger than 1024 bytes [-Wframe-larger-than=] 1 ../drivers/isdn/hardware/eicon/message.c:5985:1: warning: the frame size of 2064 bytes is larger than 2048 bytes [-Wframe-larger-than=] =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- x86_64-allmodconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: ../include/linux/spinlock.h:279:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] ------------------------------------------------------------------------------- arm64-allmodconfig : PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: ../drivers/isdn/hardware/eicon/message.c:5985:1: warning: the frame size of 2064 bytes is larger than 2048 bytes [-Wframe-larger-than=] ../include/linux/spinlock.h:279:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] ------------------------------------------------------------------------------- arm-multi_v7_defconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: ../include/linux/spinlock.h:279:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] ------------------------------------------------------------------------------- arm-allmodconfig : PASS, 0 errors, 4 warnings, 0 section mismatches Warnings: ../drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:216:1: warning: the frame size of 1064 bytes is larger than 1024 bytes [-Wframe-larger-than=] ../drivers/staging/erofs/unzip_vle.c:188:29: warning: array subscript is above array bounds [-Warray-bounds] ../include/linux/spinlock.h:279:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] ../drivers/scsi/myrs.c:821:24: warning: 'sshdr.sense_key' may be used uninitialized in this function [-Wmaybe-uninitialized] ------------------------------------------------------------------------------- arm64-defconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: ../include/linux/spinlock.h:279:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm64-allnoconfig arm-multi_v5_defconfig x86_64-defconfig arm-allnoconfig x86_64-allnoconfig arm-multi_v4t_defconfig

6 years, 7 months

1
0
0 0

[tip:x86/urgent] x86/a.out: Clear the dump structure initially

by tip-bot for Borislav Petkov

Commit-ID: 10970e1b4be9c74fce8ab6e3c34a7d718f063f2c Gitweb: https://git.kernel.org/tip/10970e1b4be9c74fce8ab6e3c34a7d718f063f2c Author: Borislav Petkov <bp(a)suse.de> AuthorDate: Tue, 12 Feb 2019 14:28:03 +0100 Committer: Borislav Petkov <bp(a)suse.de> CommitDate: Wed, 13 Feb 2019 12:10:51 +0100 x86/a.out: Clear the dump structure initially dump_thread32() in aout_core_dump() does not clear the user32 structure allocated on the stack as the first thing on function entry. As a result, the dump.u_comm, dump.u_ar0 and dump.signal which get assigned before the clearing, get overwritten. Rename that function to fill_dump() to make it clear what it does and call it first thing. This was caught while staring at a patch by Derek Robson <robsonde(a)gmail.com>. Signed-off-by: Borislav Petkov <bp(a)suse.de> Cc: Derek Robson <robsonde(a)gmail.com> Cc: Linus Torvalds <torvalds(a)linux-foundation.org> Cc: Michael Matz <matz(a)suse.de> Cc: x86(a)kernel.org Cc: <stable(a)vger.kernel.org> Link: https://lkml.kernel.org/r/20190202005512.3144-1-robsonde@gmail.com --- arch/x86/ia32/ia32_aout.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/x86/ia32/ia32_aout.c b/arch/x86/ia32/ia32_aout.c index f65b78d32f5e..7dbbe9ffda17 100644 --- a/arch/x86/ia32/ia32_aout.c +++ b/arch/x86/ia32/ia32_aout.c @@ -51,7 +51,7 @@ static unsigned long get_dr(int n) /* * fill in the user structure for a core dump.. */ -static void dump_thread32(struct pt_regs *regs, struct user32 *dump) +static void fill_dump(struct pt_regs *regs, struct user32 *dump) { u32 fs, gs; memset(dump, 0, sizeof(*dump)); @@ -157,10 +157,12 @@ static int aout_core_dump(struct coredump_params *cprm) fs = get_fs(); set_fs(KERNEL_DS); has_dumped = 1; + + fill_dump(cprm->regs, &dump); + strncpy(dump.u_comm, current->comm, sizeof(current->comm)); dump.u_ar0 = offsetof(struct user32, regs); dump.signal = cprm->siginfo->si_signo; - dump_thread32(cprm->regs, &dump); /* * If the size of the dump file exceeds the rlimit, then see

6 years, 7 months

1
0
0 0

[PATCH] scsi: lpfc: fix calls to dma_set_mask_and_coherent()

by Ewan D. Milne

The change to use dma_set_mask_and_coherent() incorrectly made a second call with the 32 bit DMA mask value when the call with the 64 bit DMA mask value succeeded. This resulted in NVMe/FC connections failing due to corrupted data buffers, and various other SCSI/FCP I/O errors. Fixes: f30e1bfd6154 ("scsi: lpfc: use dma_set_mask_and_coherent") Cc: <stable(a)vger.kernel.org> Suggested-by: Don Dutile <ddutile(a)redhat.com> Signed-off-by: Ewan D. Milne <emilne(a)redhat.com> --- drivers/scsi/lpfc/lpfc_init.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index bede11e..60c178d 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -7367,9 +7367,9 @@ struct lpfc_rpi_hdr * return error; /* Set the device DMA mask size */ - if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)) || - dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32))) - return error; + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)) != 0) + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)) != 0) + return error; /* Get the bus address of Bar0 and Bar2 and the number of bytes * required by each mapping. @@ -9745,9 +9745,9 @@ struct lpfc_cq_event * return error; /* Set the device DMA mask size */ - if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)) || - dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32))) - return error; + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)) != 0) + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)) != 0) + return error; /* * The BARs and register set definitions and offset locations are -- 1.8.3.1

6 years, 7 months

5
6
0 0

Linux 4.4.174

by Greg KH

I'm announcing the release of the 4.4.174 kernel. All users of the 4.4 kernel series must upgrade. Many thanks to Ben Hutchings for this release, it's pretty much just his work here in doing the backporting of networking fixes to help resolve "FragmentSmack" (i.e. CVE-2018-5391). The updated 4.4.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.4.y and can be browsed at the normal kernel.org git web browser: http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Documentation/networking/ip-sysctl.txt | 13 Makefile | 2 include/linux/rhashtable.h | 143 ++++++-- include/linux/skbuff.h | 16 include/net/inet_frag.h | 133 +++---- include/net/ip.h | 1 include/net/ipv6.h | 26 - include/uapi/linux/snmp.h | 1 kernel/rcu/tree.c | 2 lib/rhashtable.c | 15 net/core/skbuff.c | 21 + net/ieee802154/6lowpan/6lowpan_i.h | 26 - net/ieee802154/6lowpan/reassembly.c | 148 ++++---- net/ipv4/inet_fragment.c | 389 ++++----------------- net/ipv4/ip_fragment.c | 571 +++++++++++++++++--------------- net/ipv4/proc.c | 7 net/ipv6/netfilter/nf_conntrack_reasm.c | 100 ++--- net/ipv6/proc.c | 5 net/ipv6/reassembly.c | 209 ++++++----- 19 files changed, 867 insertions(+), 961 deletions(-) Alexander Aring (1): net: ieee802154: 6lowpan: fix frag reassembly Ben Hutchings (1): rhashtable: Add rhashtable_lookup() Dan Carpenter (1): ipv4: frags: precedence bug in ip_expire() Dimitris Michailidis (1): net: fix pskb_trim_rcsum_slow() with odd trim offset Eric Dumazet (19): inet: frags: change inet_frags_init_net() return value inet: frags: add a pointer to struct netns_frags inet: frags: refactor ipfrag_init() inet: frags: refactor ipv6_frag_init() inet: frags: refactor lowpan_net_frag_init() rhashtable: add schedule points inet: frags: use rhashtables for reassembly units inet: frags: remove some helpers inet: frags: get rif of inet_frag_evicting() inet: frags: remove inet_frag_maybe_warn_overflow() inet: frags: break the 2GB limit for frags storage inet: frags: do not clone skb in ip_expire() ipv6: frags: rewrite ip6_expire_frag_queue() rhashtable: reorganize struct rhashtable layout inet: frags: reorganize struct netns_frags inet: frags: get rid of ipfrag_skb_cb/FRAG_CB inet: frags: fix ip6frag_low_thresh boundary net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends inet: frags: better deal with smp races Florian Westphal (1): ipv6: defrag: drop non-last frags smaller than min mtu Greg Kroah-Hartman (1): Linux 4.4.174 Michal Kubecek (1): net: ipv4: do not handle duplicate fragments as overlapping Pablo Neira Ayuso (1): rhashtable: add rhashtable_lookup_get_insert_key() Paolo Abeni (1): ipfrag: really prevent allocation on netns exit Paul E. McKenney (1): rcu: Force boolean subscript for expedited stall warnings Peter Oskolkov (5): ip: discard IPv4 datagrams with overlapping segments. net: modify skb_rbtree_purge to return the truesize of all purged skbs. ip: use rb trees for IP frag queue. ip: add helpers to process in-order fragments faster. ip: process in-order fragments efficiently Taehee Yoo (1): ip: frags: fix crash in ip_do_fragment()

6 years, 7 months

2
5
0 0

[PATCH v4 1/2] tpm: Unify the send callback behaviour

by Jarkko Sakkinen

The send() callback should never return length as it does not in every driver except tpm_crb in the success case. The reason is that the main transmit functionality only cares about whether the transmit was successful or not and ignores the count completely. Cc: stable(a)vger.kernel.org Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen(a)linux.intel.com> --- drivers/char/tpm/st33zp24/st33zp24.c | 2 +- drivers/char/tpm/tpm_atmel.c | 2 +- drivers/char/tpm/tpm_i2c_atmel.c | 6 +++++- drivers/char/tpm/tpm_i2c_infineon.c | 2 +- drivers/char/tpm/tpm_i2c_nuvoton.c | 2 +- drivers/char/tpm/tpm_ibmvtpm.c | 8 ++++---- drivers/char/tpm/tpm_infineon.c | 2 +- drivers/char/tpm/tpm_nsc.c | 2 +- drivers/char/tpm/tpm_tis_core.c | 2 +- drivers/char/tpm/tpm_vtpm_proxy.c | 3 +-- drivers/char/tpm/xen-tpmfront.c | 2 +- 11 files changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c index 64dc560859f2..13dc614b7ebc 100644 --- a/drivers/char/tpm/st33zp24/st33zp24.c +++ b/drivers/char/tpm/st33zp24/st33zp24.c @@ -436,7 +436,7 @@ static int st33zp24_send(struct tpm_chip *chip, unsigned char *buf, goto out_err; } - return len; + return 0; out_err: st33zp24_cancel(chip); release_locality(chip); diff --git a/drivers/char/tpm/tpm_atmel.c b/drivers/char/tpm/tpm_atmel.c index 66a14526aaf4..a290b30a0c35 100644 --- a/drivers/char/tpm/tpm_atmel.c +++ b/drivers/char/tpm/tpm_atmel.c @@ -105,7 +105,7 @@ static int tpm_atml_send(struct tpm_chip *chip, u8 *buf, size_t count) iowrite8(buf[i], priv->iobase); } - return count; + return 0; } static void tpm_atml_cancel(struct tpm_chip *chip) diff --git a/drivers/char/tpm/tpm_i2c_atmel.c b/drivers/char/tpm/tpm_i2c_atmel.c index 4720b2442ffe..aa11c8a1df5e 100644 --- a/drivers/char/tpm/tpm_i2c_atmel.c +++ b/drivers/char/tpm/tpm_i2c_atmel.c @@ -65,7 +65,11 @@ static int i2c_atmel_send(struct tpm_chip *chip, u8 *buf, size_t len) dev_dbg(&chip->dev, "%s(buf=%*ph len=%0zx) -> sts=%d\n", __func__, (int)min_t(size_t, 64, len), buf, len, status); - return status; + + if (status < 0) + return status; + + return 0; } static int i2c_atmel_recv(struct tpm_chip *chip, u8 *buf, size_t count) diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b/drivers/char/tpm/tpm_i2c_infineon.c index 3b490d9d90e7..3b4e9672ff6c 100644 --- a/drivers/char/tpm/tpm_i2c_infineon.c +++ b/drivers/char/tpm/tpm_i2c_infineon.c @@ -588,7 +588,7 @@ static int tpm_tis_i2c_send(struct tpm_chip *chip, u8 *buf, size_t len) /* go and do it */ iic_tpm_write(TPM_STS(tpm_dev.locality), &sts, 1); - return len; + return 0; out_err: tpm_tis_i2c_ready(chip); /* The TPM needs some time to clean up here, diff --git a/drivers/char/tpm/tpm_i2c_nuvoton.c b/drivers/char/tpm/tpm_i2c_nuvoton.c index 5700cc2ddee1..315a3b4548f7 100644 --- a/drivers/char/tpm/tpm_i2c_nuvoton.c +++ b/drivers/char/tpm/tpm_i2c_nuvoton.c @@ -465,7 +465,7 @@ static int i2c_nuvoton_send(struct tpm_chip *chip, u8 *buf, size_t len) } dev_dbg(dev, "%s() -> %zd\n", __func__, len); - return len; + return 0; } static bool i2c_nuvoton_req_canceled(struct tpm_chip *chip, u8 status) diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c index 07b5a487d0c8..757ca45b39b8 100644 --- a/drivers/char/tpm/tpm_ibmvtpm.c +++ b/drivers/char/tpm/tpm_ibmvtpm.c @@ -139,14 +139,14 @@ static int tpm_ibmvtpm_recv(struct tpm_chip *chip, u8 *buf, size_t count) } /** - * tpm_ibmvtpm_send - Send tpm request - * + * tpm_ibmvtpm_send() - Send a TPM command * @chip: tpm chip struct * @buf: buffer contains data to send * @count: size of buffer * * Return: - * Number of bytes sent or < 0 on error. + * 0 on success, + * -errno on error */ static int tpm_ibmvtpm_send(struct tpm_chip *chip, u8 *buf, size_t count) { @@ -192,7 +192,7 @@ static int tpm_ibmvtpm_send(struct tpm_chip *chip, u8 *buf, size_t count) rc = 0; ibmvtpm->tpm_processing_cmd = false; } else - rc = count; + rc = 0; spin_unlock(&ibmvtpm->rtce_lock); return rc; diff --git a/drivers/char/tpm/tpm_infineon.c b/drivers/char/tpm/tpm_infineon.c index d8f10047fbba..97f6d4fe0aee 100644 --- a/drivers/char/tpm/tpm_infineon.c +++ b/drivers/char/tpm/tpm_infineon.c @@ -354,7 +354,7 @@ static int tpm_inf_send(struct tpm_chip *chip, u8 * buf, size_t count) for (i = 0; i < count; i++) { wait_and_send(chip, buf[i]); } - return count; + return 0; } static void tpm_inf_cancel(struct tpm_chip *chip) diff --git a/drivers/char/tpm/tpm_nsc.c b/drivers/char/tpm/tpm_nsc.c index 5d6cce74cd3f..9bee3c5eb4bf 100644 --- a/drivers/char/tpm/tpm_nsc.c +++ b/drivers/char/tpm/tpm_nsc.c @@ -226,7 +226,7 @@ static int tpm_nsc_send(struct tpm_chip *chip, u8 * buf, size_t count) } outb(NSC_COMMAND_EOC, priv->base + NSC_COMMAND); - return count; + return 0; } static void tpm_nsc_cancel(struct tpm_chip *chip) diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c index 60e2038652b8..b9f64684c3fb 100644 --- a/drivers/char/tpm/tpm_tis_core.c +++ b/drivers/char/tpm/tpm_tis_core.c @@ -481,7 +481,7 @@ static int tpm_tis_send_main(struct tpm_chip *chip, const u8 *buf, size_t len) goto out_err; } } - return len; + return 0; out_err: tpm_tis_ready(chip); return rc; diff --git a/drivers/char/tpm/tpm_vtpm_proxy.c b/drivers/char/tpm/tpm_vtpm_proxy.c index 26a2be555288..d74f3de74ae6 100644 --- a/drivers/char/tpm/tpm_vtpm_proxy.c +++ b/drivers/char/tpm/tpm_vtpm_proxy.c @@ -335,7 +335,6 @@ static int vtpm_proxy_is_driver_command(struct tpm_chip *chip, static int vtpm_proxy_tpm_op_send(struct tpm_chip *chip, u8 *buf, size_t count) { struct proxy_dev *proxy_dev = dev_get_drvdata(&chip->dev); - int rc = 0; if (count > sizeof(proxy_dev->buffer)) { dev_err(&chip->dev, @@ -366,7 +365,7 @@ static int vtpm_proxy_tpm_op_send(struct tpm_chip *chip, u8 *buf, size_t count) wake_up_interruptible(&proxy_dev->wq); - return rc; + return 0; } static void vtpm_proxy_tpm_op_cancel(struct tpm_chip *chip) diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c index 1259e935fd58..4e2d00cb0d81 100644 --- a/drivers/char/tpm/xen-tpmfront.c +++ b/drivers/char/tpm/xen-tpmfront.c @@ -173,7 +173,7 @@ static int vtpm_send(struct tpm_chip *chip, u8 *buf, size_t count) return -ETIME; } - return count; + return 0; } static int vtpm_recv(struct tpm_chip *chip, u8 *buf, size_t count) -- 2.19.1

6 years, 7 months

4
15
0 0

patch "iio: adc: exynos-adc: Use proper number of channels for Exynos4x12" added to staging-testing

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled iio: adc: exynos-adc: Use proper number of channels for Exynos4x12 to my staging git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git in the staging-testing branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will be merged to the staging-next branch sometime soon, after it passes testing, and the merge window is open. If you have any questions about this process, please let me know. >From 103cda6a3b8d2c10d5f8cd7abad118e9db8f4776 Mon Sep 17 00:00:00 2001 From: Krzysztof Kozlowski <krzk(a)kernel.org> Date: Tue, 12 Feb 2019 18:45:49 +0100 Subject: iio: adc: exynos-adc: Use proper number of channels for Exynos4x12 Exynos4212 and Exynos4412 have only four ADC channels so using "samsung,exynos-adc-v1" compatible (for eight channels ADCv1) on them is wrong. Add a new compatible for Exynos4x12. Signed-off-by: Krzysztof Kozlowski <krzk(a)kernel.org> Cc: <Stable(a)vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron(a)huawei.com> --- .../bindings/iio/adc/samsung,exynos-adc.txt | 4 +++- drivers/iio/adc/exynos_adc.c | 17 +++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.txt b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.txt index a10c1f89037d..e1fe02f3e3e9 100644 --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.txt +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.txt @@ -11,11 +11,13 @@ New driver handles the following Required properties: - compatible: Must be "samsung,exynos-adc-v1" - for exynos4412/5250 controllers. + for Exynos5250 controllers. Must be "samsung,exynos-adc-v2" for future controllers. Must be "samsung,exynos3250-adc" for controllers compatible with ADC of Exynos3250. + Must be "samsung,exynos4212-adc" for + controllers compatible with ADC of Exynos4212 and Exynos4412. Must be "samsung,exynos7-adc" for the ADC in Exynos7 and compatibles Must be "samsung,s3c2410-adc" for diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c index 41da522fc673..1ca2c4d39f87 100644 --- a/drivers/iio/adc/exynos_adc.c +++ b/drivers/iio/adc/exynos_adc.c @@ -115,6 +115,7 @@ #define MAX_ADC_V2_CHANNELS 10 #define MAX_ADC_V1_CHANNELS 8 #define MAX_EXYNOS3250_ADC_CHANNELS 2 +#define MAX_EXYNOS4212_ADC_CHANNELS 4 #define MAX_S5PV210_ADC_CHANNELS 10 /* Bit definitions common for ADC_V1 and ADC_V2 */ @@ -271,6 +272,19 @@ static void exynos_adc_v1_start_conv(struct exynos_adc *info, writel(con1 | ADC_CON_EN_START, ADC_V1_CON(info->regs)); } +/* Exynos4212 and 4412 is like ADCv1 but with four channels only */ +static const struct exynos_adc_data exynos4212_adc_data = { + .num_channels = MAX_EXYNOS4212_ADC_CHANNELS, + .mask = ADC_DATX_MASK, /* 12 bit ADC resolution */ + .needs_adc_phy = true, + .phy_offset = EXYNOS_ADCV1_PHY_OFFSET, + + .init_hw = exynos_adc_v1_init_hw, + .exit_hw = exynos_adc_v1_exit_hw, + .clear_irq = exynos_adc_v1_clear_irq, + .start_conv = exynos_adc_v1_start_conv, +}; + static const struct exynos_adc_data exynos_adc_v1_data = { .num_channels = MAX_ADC_V1_CHANNELS, .mask = ADC_DATX_MASK, /* 12 bit ADC resolution */ @@ -492,6 +506,9 @@ static const struct of_device_id exynos_adc_match[] = { }, { .compatible = "samsung,s5pv210-adc", .data = &exynos_adc_s5pv210_data, + }, { + .compatible = "samsung,exynos4212-adc", + .data = &exynos4212_adc_data, }, { .compatible = "samsung,exynos-adc-v1", .data = &exynos_adc_v1_data, -- 2.20.1

6 years, 7 months

1
0
0 0

patch "iio: adc: exynos-adc: Fix NULL pointer exception on unbind" added to staging-testing

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled iio: adc: exynos-adc: Fix NULL pointer exception on unbind to my staging git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git in the staging-testing branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will be merged to the staging-next branch sometime soon, after it passes testing, and the merge window is open. If you have any questions about this process, please let me know. >From 2ea8bab4dd2a9014e723b28091831fa850b82d83 Mon Sep 17 00:00:00 2001 From: Krzysztof Kozlowski <krzk(a)kernel.org> Date: Sat, 9 Feb 2019 00:39:27 +0100 Subject: iio: adc: exynos-adc: Fix NULL pointer exception on unbind Fix NULL pointer exception on device unbind when device tree does not contain "has-touchscreen" property. In such case the input device is not registered so it should not be unregistered. $ echo "12d10000.adc" > /sys/bus/platform/drivers/exynos-adc/unbind Unable to handle kernel NULL pointer dereference at virtual address 00000474 ... (input_unregister_device) from [<c0772060>] (exynos_adc_remove+0x20/0x80) (exynos_adc_remove) from [<c0587d5c>] (platform_drv_remove+0x20/0x40) (platform_drv_remove) from [<c05860f0>] (device_release_driver_internal+0xdc/0x1ac) (device_release_driver_internal) from [<c0583ecc>] (unbind_store+0x60/0xd4) (unbind_store) from [<c031b89c>] (kernfs_fop_write+0x100/0x1e0) (kernfs_fop_write) from [<c029709c>] (__vfs_write+0x2c/0x17c) (__vfs_write) from [<c0297374>] (vfs_write+0xa4/0x184) (vfs_write) from [<c0297594>] (ksys_write+0x4c/0xac) (ksys_write) from [<c0101000>] (ret_fast_syscall+0x0/0x28) Fixes: 2bb8ad9b44c5 ("iio: exynos-adc: add experimental touchscreen support") Cc: <stable(a)vger.kernel.org> Signed-off-by: Krzysztof Kozlowski <krzk(a)kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron(a)huawei.com> --- drivers/iio/adc/exynos_adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c index fa2d2b5767f3..41da522fc673 100644 --- a/drivers/iio/adc/exynos_adc.c +++ b/drivers/iio/adc/exynos_adc.c @@ -929,7 +929,7 @@ static int exynos_adc_remove(struct platform_device *pdev) struct iio_dev *indio_dev = platform_get_drvdata(pdev); struct exynos_adc *info = iio_priv(indio_dev); - if (IS_REACHABLE(CONFIG_INPUT)) { + if (IS_REACHABLE(CONFIG_INPUT) && info->input) { free_irq(info->tsirq, info); input_unregister_device(info->input); } -- 2.20.1

6 years, 7 months

1
0
0 0

[tip:perf/urgent] perf/core: Fix impossible ring-buffer sizes warning

by tip-bot for Ingo Molnar

Commit-ID: 528871b456026e6127d95b1b2bd8e3a003dc1614 Gitweb: https://git.kernel.org/tip/528871b456026e6127d95b1b2bd8e3a003dc1614 Author: Ingo Molnar <mingo(a)kernel.org> AuthorDate: Wed, 13 Feb 2019 07:57:02 +0100 Committer: Ingo Molnar <mingo(a)kernel.org> CommitDate: Wed, 13 Feb 2019 08:05:02 +0100 perf/core: Fix impossible ring-buffer sizes warning The following commit: 9dff0aa95a32 ("perf/core: Don't WARN() for impossible ring-buffer sizes") results in perf recording failures with larger mmap areas: root@skl:/tmp# perf record -g -a failed to mmap with 12 (Cannot allocate memory) The root cause is that the following condition is buggy: if (order_base_2(size) >= MAX_ORDER) goto fail; The problem is that @size is in bytes and MAX_ORDER is in pages, so the right test is: if (order_base_2(size) >= PAGE_SHIFT+MAX_ORDER) goto fail; Fix it. Reported-by: "Jin, Yao" <yao.jin(a)linux.intel.com> Bisected-by: Borislav Petkov <bp(a)alien8.de> Analyzed-by: Peter Zijlstra <peterz(a)infradead.org> Cc: Julien Thierry <julien.thierry(a)arm.com> Cc: Mark Rutland <mark.rutland(a)arm.com> Cc: Alexander Shishkin <alexander.shishkin(a)linux.intel.com> Cc: Arnaldo Carvalho de Melo <acme(a)redhat.com> Cc: Jiri Olsa <jolsa(a)redhat.com> Cc: Linus Torvalds <torvalds(a)linux-foundation.org> Cc: Namhyung Kim <namhyung(a)kernel.org> Cc: Peter Zijlstra <peterz(a)infradead.org> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: <stable(a)vger.kernel.org> Fixes: 9dff0aa95a32 ("perf/core: Don't WARN() for impossible ring-buffer sizes") Signed-off-by: Ingo Molnar <mingo(a)kernel.org> --- kernel/events/ring_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/events/ring_buffer.c b/kernel/events/ring_buffer.c index 309ef5a64af5..5ab4fe3b1dcc 100644 --- a/kernel/events/ring_buffer.c +++ b/kernel/events/ring_buffer.c @@ -734,7 +734,7 @@ struct ring_buffer *rb_alloc(int nr_pages, long watermark, int cpu, int flags) size = sizeof(struct ring_buffer); size += nr_pages * sizeof(void *); - if (order_base_2(size) >= MAX_ORDER) + if (order_base_2(size) >= PAGE_SHIFT+MAX_ORDER) goto fail; rb = kzalloc(size, GFP_KERNEL);

6 years, 7 months

1
0
0 0

[tip:perf/urgent] perf/core: Fix impossible ring-buffer sizes warning

by tip-bot for Ingo Molnar

Commit-ID: 528467ac19b279c06a55f3da99a24ebcb6e2adb1 Gitweb: https://git.kernel.org/tip/528467ac19b279c06a55f3da99a24ebcb6e2adb1 Author: Ingo Molnar <mingo(a)kernel.org> AuthorDate: Wed, 13 Feb 2019 07:57:02 +0100 Committer: Ingo Molnar <mingo(a)kernel.org> CommitDate: Wed, 13 Feb 2019 08:03:55 +0100 perf/core: Fix impossible ring-buffer sizes warning The following commit: 9dff0aa95a32 ("perf/core: Don't WARN() for impossible ring-buffer sizes") results in perf recording failures with larger mmap areas: root@skl:/tmp# perf record -g -a failed to mmap with 12 (Cannot allocate memory) The root cause is that the following condition is buggy: if (order_base_2(size) >= MAX_ORDER) goto fail; The problem is that @size is in bytes and MAX_ORDER is in pages, so the right test is: if (order_base_2(size) >= PAGE_SHIFT+MAX_ORDER) goto fail; Fix it. Reported-by: "Jin, Yao" <yao.jin(a)linux.intel.com> Bisected-by: Borislav Petkov <bp(a)alien8.de> Analyzed-by: Peter Zijlstra <peterz(a)infradead.org> Cc: Julien Thierry <julien.thierry(a)arm.com> Cc: Mark Rutland <mark.rutland(a)arm.com> Cc: Alexander Shishkin <alexander.shishkin(a)linux.intel.com> Cc: Arnaldo Carvalho de Melo <acme(a)redhat.com> Cc: Jiri Olsa <jolsa(a)redhat.com> Cc: Linus Torvalds <torvalds(a)linux-foundation.org> Cc: Namhyung Kim <namhyung(a)kernel.org> Cc: Peter Zijlstra <peterz(a)infradead.org> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: <stable(a)vger.kernel.org> Signed-off-by: Ingo Molnar <mingo(a)kernel.org> --- kernel/events/ring_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/events/ring_buffer.c b/kernel/events/ring_buffer.c index 309ef5a64af5..5ab4fe3b1dcc 100644 --- a/kernel/events/ring_buffer.c +++ b/kernel/events/ring_buffer.c @@ -734,7 +734,7 @@ struct ring_buffer *rb_alloc(int nr_pages, long watermark, int cpu, int flags) size = sizeof(struct ring_buffer); size += nr_pages * sizeof(void *); - if (order_base_2(size) >= MAX_ORDER) + if (order_base_2(size) >= PAGE_SHIFT+MAX_ORDER) goto fail; rb = kzalloc(size, GFP_KERNEL);

6 years, 7 months

1
0
0 0

stable-rc/linux-4.4.y boot: 85 boots: 2 failed, 74 passed with 9 offline (v4.4.174-98-g5062d93ab138)

by kernelci.org bot

stable-rc/linux-4.4.y boot: 85 boots: 2 failed, 74 passed with 9 offline (v4.4.174-98-g5062d93ab138) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.4.y/kernel/v4.4.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.174-98-… Tree: stable-rc Branch: linux-4.4.y Git Describe: v4.4.174-98-g5062d93ab138 Git Commit: 5062d93ab13826310546a78df8e9757ce64fb6d2 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 40 unique boards, 20 SoC families, 12 builds out of 187 Boot Failures Detected: arm: multi_v7_defconfig: gcc-7: stih410-b2120: 1 failed lab arm64: defconfig: gcc-7: qcom-qdf2400: 1 failed lab Offline Platforms: arm: qcom_defconfig: gcc-7 qcom-apq8064-cm-qs600: 1 offline lab qcom-apq8064-ifc6410: 1 offline lab sunxi_defconfig: gcc-7 sun5i-r8-chip: 1 offline lab sun7i-a20-bananapi: 1 offline lab multi_v7_defconfig: gcc-7 qcom-apq8064-cm-qs600: 1 offline lab qcom-apq8064-ifc6410: 1 offline lab sun5i-r8-chip: 1 offline lab sun7i-a20-bananapi: 1 offline lab arm64: defconfig: gcc-7 apq8016-sbc: 1 offline lab --- For more info write to <info(a)kernelci.org>

6 years, 7 months

1
0
0 0

stable-rc/linux-4.19.y boot: 112 boots: 0 failed, 100 passed with 11 offline, 1 untried/unknown (v4.19.21)

by kernelci.org bot

stable-rc/linux-4.19.y boot: 112 boots: 0 failed, 100 passed with 11 offline, 1 untried/unknown (v4.19.21) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.19.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.19.y/kernel/v4.19.21/ Tree: stable-rc Branch: linux-4.19.y Git Describe: v4.19.21 Git Commit: 43d3d5141515dd201aa6d268e3c02fb7383769f6 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 62 unique boards, 23 SoC families, 12 builds out of 202 Offline Platforms: arm: qcom_defconfig: gcc-7 qcom-apq8064-cm-qs600: 1 offline lab qcom-apq8064-ifc6410: 1 offline lab sunxi_defconfig: gcc-7 sun5i-r8-chip: 1 offline lab sun7i-a20-bananapi: 1 offline lab multi_v7_defconfig: gcc-7 qcom-apq8064-cm-qs600: 1 offline lab qcom-apq8064-ifc6410: 1 offline lab sun5i-r8-chip: 1 offline lab sun7i-a20-bananapi: 1 offline lab arm64: defconfig: gcc-7 apq8016-sbc: 1 offline lab meson-gxbb-odroidc2: 1 offline lab mt7622-rfb1: 1 offline lab --- For more info write to <info(a)kernelci.org>

6 years, 7 months

1
0
0 0

[PATCH 4.9 000/137] 4.9.156-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.9.156 release. There are 137 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed Feb 13 14:17:22 UTC 2019. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.156-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.9.156-rc1 Andi Kleen <ak(a)linux.intel.com> perf: Add support for supplementary event registers Mike Marciniszyn <mike.marciniszyn(a)intel.com> IB/hfi1: Add limit test for RC/UC send via loopback Scott Bauer <scott.bauer(a)intel.com> PCI: vmd: Free up IRQs on suspend path Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> oom, oom_reaper: do not enqueue same task twice Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> serial: fix race between flush_to_ldisc and tty_open Gustavo A. R. Silva <gustavo(a)embeddedor.com> perf tests evsel-tp-sched: Fix bitwise operator Mark Rutland <mark.rutland(a)arm.com> perf/core: Don't WARN() for impossible ring-buffer sizes Tony Luck <tony.luck(a)intel.com> x86/MCE: Initialize mce.bank in the case of a fatal error in mce_no_way_out() Kan Liang <kan.liang(a)linux.intel.com> perf/x86/intel/uncore: Add Node ID mask Peter Shier <pshier(a)google.com> KVM: nVMX: unconditionally cancel preemption timer in free_nested (CVE-2019-7221) Jann Horn <jannh(a)google.com> kvm: fix kvm_ioctl_create_device() reference counting (CVE-2019-6974) Paolo Bonzini <pbonzini(a)redhat.com> KVM: x86: work around leak of uninitialized stack contents (CVE-2019-7222) James Bottomley <James.Bottomley(a)HansenPartnership.com> scsi: aic94xx: fix module loading Paul Elder <paul.elder(a)ideasonboard.com> usb: gadget: musb: fix short isoc packets with inventra dma Gustavo A. R. Silva <gustavo(a)embeddedor.com> usb: gadget: udc: net2272: Fix bitwise and boolean operations Bin Liu <b-liu(a)ti.com> usb: phy: am335x: fix race condition in _probe Leonid Iziumtsev <leonid.iziumtsev(a)gmail.com> dmaengine: imx-dma: fix wrong callback invoke Lukas Wunner <lukas(a)wunner.de> dmaengine: bcm2835: Fix abort of transactions Lukas Wunner <lukas(a)wunner.de> dmaengine: bcm2835: Fix interrupt race on RT Miklos Szeredi <mszeredi(a)redhat.com> fuse: handle zero sized retrieve correctly Miklos Szeredi <mszeredi(a)redhat.com> fuse: decrement NR_WRITEBACK_TEMP on the right page Jann Horn <jannh(a)google.com> fuse: call pipe_buf_release() under pipe lock Takashi Iwai <tiwai(a)suse.de> ALSA: hda - Serialize codec registrations Charles Keepax <ckeepax(a)opensource.cirrus.com> ALSA: compress: Fix stop handling on compressed capture streams Govindarajulu Varadarajan <gvaradar(a)cisco.com> enic: fix checksum validation for IPv6 Rundong Ge <rdong.ge(a)gmail.com> net: dsa: slave: Don't propagate flag changes on down slave interfaces Cong Wang <xiyou.wangcong(a)gmail.com> net/mlx5e: Force CHECKSUM_UNNECESSARY for short ethernet frames Florian Fainelli <f.fainelli(a)gmail.com> net: systemport: Fix WoL with password after deep sleep Eric Dumazet <edumazet(a)google.com> rds: fix refcount bug in rds_sock_addref Dan Carpenter <dan.carpenter(a)oracle.com> skge: potential memory corruption in skge_get_regs() Eric Dumazet <edumazet(a)google.com> rxrpc: bad unlock balance in rxrpc_recvmsg Sebastian Andrzej Siewior <bigeasy(a)linutronix.de> net: dp83640: expire old TX-skb Eric Dumazet <edumazet(a)google.com> dccp: fool proof ccid_hc_[rt]x_parse_options() Eduardo Valentin <edubezval(a)gmail.com> thermal: hwmon: inline helpers when CONFIG_THERMAL_HWMON is not set Oleg Nesterov <oleg(a)redhat.com> exec: load_script: don't blindly truncate shebang string Davidlohr Bueso <dave(a)stgolabs.net> fs/epoll: drop ovflist branch prediction Cheng Lin <cheng.lin130(a)zte.com.cn> proc/sysctl: fix return error for proc_doulongvec_minmax() Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> kernel/hung_task.c: break RCU locks based on jiffies Benjamin Gordon <bmgordon(a)google.com> fs/proc/base.c: use ns_capable instead of capable for timerslack_ns Aditya Pakki <pakki001(a)umn.edu> HID: lenovo: Add checks to fix of_led_classdev_register Bjorn Andersson <bjorn.andersson(a)linaro.org> thermal: generic-adc: Fix adc to temp interpolation Finn Thain <fthain(a)telegraphics.com.au> block/swim3: Fix -EBUSY error when re-opening device after unmount Scott Wood <oss(a)buserror.net> fsl/fman: Use GFP_ATOMIC in {memac,tgec}_add_hash_mac_address() Wenwen Wang <wang6495(a)umn.edu> gdrom: fix a memory leak bug Jia-Ju Bai <baijiaju1990(a)gmail.com> isdn: hisax: hfc_pci: Fix a possible concurrency use-after-free bug in HFCPCI_l1hw() Junxiao Bi <junxiao.bi(a)oracle.com> ocfs2: don't clear bh uptodate for block read Marc Zyngier <marc.zyngier(a)arm.com> scripts/decode_stacktrace: only strip base path when a prefix of the path Sahitya Tummala <stummala(a)codeaurora.org> f2fs: fix sbi->extent_list corruption issue Kangjie Lu <kjlu(a)umn.edu> niu: fix missing checks of niu_pci_eeprom_read Anton Ivanov <anton.ivanov(a)cambridgegreys.com> um: Avoid marking pages with "changed protection" Ronnie Sahlberg <lsahlber(a)redhat.com> cifs: check ntwrk_buf_start for NULL before dereferencing it Stefan Roese <sr(a)denx.de> MIPS: ralink: Select CONFIG_CPU_MIPSR2_IRQ_VI on MT7620/8 Nathan Chancellor <natechancellor(a)gmail.com> crypto: ux500 - Use proper enum in hash_set_dma_transfer Nathan Chancellor <natechancellor(a)gmail.com> crypto: ux500 - Use proper enum in cryp_set_dma_transfer Michael Ellerman <mpe(a)ellerman.id.au> seq_buf: Make seq_buf_puts() null-terminate the buffer Kangjie Lu <kjlu(a)umn.edu> hwmon: (lm80) fix a missing check of bus read in lm80 probe Kangjie Lu <kjlu(a)umn.edu> hwmon: (lm80) fix a missing check of the status of SMBus read Chris Perl <cperl(a)janestreet.com> NFS: nfs_compare_mount_options always compare auth flavors. Vitaly Kuznetsov <vkuznets(a)redhat.com> KVM: x86: svm: report MSR_IA32_MCG_EXT_CTL as unsupported Martin Blumenstingl <martin.blumenstingl(a)googlemail.com> pinctrl: meson: meson8b: fix the GPIO function for the GPIOAO pins Martin Blumenstingl <martin.blumenstingl(a)googlemail.com> pinctrl: meson: meson8: fix the GPIO function for the GPIOAO pins Noralf Trønnes <noralf(a)tronnes.org> fbdev: fbcon: Fix unregister crash when more than one framebuffer Kai-Heng Feng <kai.heng.feng(a)canonical.com> igb: Fix an issue that PME is not enabled during runtime suspend Konstantin Khorenko <khorenko(a)virtuozzo.com> i40e: define proper net_device::neigh_priv_len Peter Rosin <peda(a)axentia.se> fbdev: fbmem: behave better with small rotated displays and many CPUs Alexey Khoroshilov <khoroshilov(a)ispras.ru> video: clps711x-fb: release disp device node in probe() Nathan Chancellor <natechancellor(a)gmail.com> drbd: Avoid Clang warning about pointless switch statment Lars Ellenberg <lars.ellenberg(a)linbit.com> drbd: skip spurious timeout (ping-timeo) when failing promote Lars Ellenberg <lars.ellenberg(a)linbit.com> drbd: disconnect, if the wrong UUIDs are attached on a connected peer Roland Kammerer <roland.kammerer(a)linbit.com> drbd: narrow rcu_read_lock in drbd_sync_handshake Jia-Ju Bai <baijiaju1990(a)gmail.com> cw1200: Fix concurrency use-after-free bugs in cw1200_hw_scan() Dave Carroll <david.carroll(a)microsemi.com> scsi: smartpqi: correct volume status Mahesh Rajashekhara <mahesh.rajashekhara(a)microsemi.com> scsi: smartpqi: correct host serial num for ssa Johan Hedberg <johan.hedberg(a)intel.com> Bluetooth: Fix unnecessary error message for HCI request completion YueHaibing <yuehaibing(a)huawei.com> xfrm6_tunnel: Fix spi check in __xfrm6_tunnel_alloc_spi Johannes Berg <johannes.berg(a)intel.com> mac80211: fix radiotap vendor presence bitmap handling Christophe Leroy <christophe.leroy(a)c-s.fr> powerpc/uaccess: fix warning/error with access_ok() Mark Rutland <mark.rutland(a)arm.com> arm64: KVM: Skip MMIO insn after emulation Michael Mueller <mimu(a)linux.ibm.com> KVM: s390: unregister debug feature on failing arch init Arnaldo Carvalho de Melo <acme(a)redhat.com> perf probe: Fix unchecked usage of strncpy() Arnaldo Carvalho de Melo <acme(a)redhat.com> perf header: Fix unchecked usage of strncpy() Beomho Seo <beomho.seo(a)samsung.com> tty: serial: samsung: Properly set flags in autoCTS mode Kai-Heng Feng <kai.heng.feng(a)canonical.com> memstick: Prevent memstick host from getting runtime suspended during card detection Arnd Bergmann <arnd(a)arndb.de> ARM: mmp: fix timer_init calls Fabio Estevam <festevam(a)gmail.com> ASoC: fsl: Fix SND_SOC_EUKREA_TLV320 build error on i.MX8M Arnd Bergmann <arnd(a)arndb.de> ARM: pxa: avoid section mismatch warning Jan Kara <jack(a)suse.cz> udf: Fix BUG on corrupted inode Adamski, Krzysztof (Nokia - PL/Wroclaw) <krzysztof.adamski(a)nokia.com> i2c-axxia: check for error conditions first Yangtao Li <tiny.windzz(a)gmail.com> cpuidle: big.LITTLE: fix refcount leak Anson Huang <anson.huang(a)nxp.com> clk: imx6sl: ensure MMDC CH0 handshake is bypassed Sergei Shtylyov <sergei.shtylyov(a)cogentembedded.com> sata_rcar: fix deferred probing Will Deacon <will.deacon(a)arm.com> iommu/arm-smmu-v3: Use explicit mb() when moving cons pointer Vivek Gautam <vivek.gautam(a)codeaurora.org> iommu/arm-smmu: Add support for qcom,smmu-v2 variant Dan Carpenter <dan.carpenter(a)oracle.com> tracing: Have trace_stack nr_entries compare not be so subtle Jiong Wang <jiong.wang(a)netronome.com> mips: bpf: fix encoding bug for mm_srlv32_op Russell King - ARM Linux <linux(a)armlinux.org.uk> ARM: dts: Fix OMAP4430 SDP Ethernet startup Yu Zhao <yuzhao(a)google.com> iommu/amd: Fix amd_iommu=force_isolation Chen-Yu Tsai <wens(a)csie.org> clk: sunxi-ng: a33: Set CLK_SET_RATE_PARENT for all audio module clocks Bart Van Assche <bvanassche(a)acm.org> timekeeping: Use proper seqcount initializer Mathias Nyman <mathias.nyman(a)linux.intel.com> usb: hub: delay hub autosuspend if USB3 port is still link training Zoran Markovic <zmarkovic(a)sierrawireless.com> smack: fix access permissions for keyring Alexey Khoroshilov <khoroshilov(a)ispras.ru> media: DaVinci-VPBE: fix error handling in vpbe_initialize() Sebastian Andrzej Siewior <bigeasy(a)linutronix.de> x86/fpu: Add might_fault() to user_insn() Lubomir Rintel <lkundrak(a)v3.sk> ARM: mmp/mmp2: dt: enable the clock Lubomir Rintel <lkundrak(a)v3.sk> ARM: dts: mmp2: fix TWSI2 Mark Rutland <mark.rutland(a)arm.com> arm64: ftrace: don't adjust the LR value Arend van Spriel <arend.vanspriel(a)broadcom.com> firmware/efi: Add NULL pointer checks in efivars API functions Wei Wang <wvw(a)google.com> Thermal: do not clear passive state during system sleep J. Bruce Fields <bfields(a)redhat.com> nfsd4: fix crash on writing v4_end_grace before nfsd startup Yangtao Li <tiny.windzz(a)gmail.com> soc: bcm: brcmstb: Don't leak device tree node reference Young Xiao <YangX92(a)hotmail.com> sunvdc: Do not spin in an infinite loop when vio_ldc_send() returns EAGAIN Tiezhu Yang <kernelpatch(a)126.com> f2fs: fix wrong return value of f2fs_acl_create Jaegeuk Kim <jaegeuk(a)kernel.org> f2fs: avoid build warn of fall_through Yunlei He <heyunlei(a)huawei.com> f2fs: move dir data flush to write checkpoint process Hans Verkuil <hverkuil-cisco(a)xs4all.nl> media: adv*/tc358743/ths8200: fill in min width/height/pixelclock Hans de Goede <hdegoede(a)redhat.com> iio: accel: kxcjk1013: Add KIOX010A ACPI Hardware-ID Nathan Chancellor <natechancellor(a)gmail.com> dmaengine: xilinx_dma: Remove __aligned attribute on zynqmp_dma_desc_ll Alexey Khoroshilov <khoroshilov(a)ispras.ru> media: mtk-vcodec: Release device nodes in mtk_vcodec_init_enc_pm() Yangtao Li <tiny.windzz(a)gmail.com> soc/tegra: Don't leak device tree node reference Pu Wen <puwen(a)hygon.cn> perf tools: Add Hygon Dhyana support Sami Tolvanen <samitolvanen(a)google.com> modpost: validate symbol names also in find_elf_symbol Nathan Chancellor <natechancellor(a)gmail.com> ARM: OMAP2+: hwmod: Fix some section annotations Renato Lui Geh <renatogeh(a)gmail.com> staging: iio: ad7780: update voltage on read Matheus Tavares <matheus.bernardino(a)usp.br> staging:iio:ad2s90: Make probe handle spi_setup failure Miroslav Lichvar <mlichvar(a)redhat.com> ptp: check gettime64 return code in PTP_SYS_OFFSET ioctl Andy Duan <fugang.duan(a)nxp.com> serial: fsl_lpuart: clear parity enable bit when disable parity Boris Brezillon <boris.brezillon(a)bootlin.com> drm/vc4: ->x_scaling[1] should never be set to VC4_SCALING_NONE Frank Rowand <frank.rowand(a)sony.com> powerpc/pseries: add of_node_put() in dlpar_detach_node() Colin Ian King <colin.king(a)canonical.com> x86/PCI: Fix Broadcom CNB20LE unintended sign extension (redux) Bob Peterson <rpeterso(a)redhat.com> dlm: Don't swamp the CPU with callbacks queued during recovery Yufen Wang <wangyufen(a)huawei.com> ARM: 8808/1: kexec:offline panic_smp_self_stop CPU James Smart <jsmart2021(a)gmail.com> scsi: lpfc: Correct LCB RJT handling Lorenzo Bianconi <lorenzo.bianconi(a)redhat.com> ath9k: dynack: use authentication messages for 'late' ack Steve Longerbeam <slongerbeam(a)gmail.com> gpu: ipu-v3: image-convert: Prevent race between run and unprepare Arnd Bergmann <arnd(a)arndb.de> ASoC: Intel: mrfld: fix uninitialized variable access Slawomir Stepien <sst(a)poczta.fm> staging: iio: adc: ad7280a: handle error from __ad7280_read32() Gustavo A. R. Silva <gustavo(a)embeddedor.com> drm/bufs: Fix Spectre v1 vulnerability ------------- Diffstat: Makefile | 4 +- arch/arm/boot/dts/mmp2.dtsi | 9 +- arch/arm/boot/dts/omap4-sdp.dts | 1 + arch/arm/kernel/smp.c | 15 ++++ arch/arm/kvm/mmio.c | 11 +-- arch/arm/mach-mmp/common.h | 2 +- arch/arm/mach-mmp/mmp2.c | 2 +- arch/arm/mach-mmp/pxa168.c | 2 +- arch/arm/mach-mmp/pxa910.c | 2 +- arch/arm/mach-mmp/time.c | 32 ++++--- arch/arm/mach-omap2/omap_hwmod.c | 6 +- arch/arm/mach-pxa/cm-x300.c | 2 +- arch/arm/mach-pxa/littleton.c | 2 +- arch/arm/mach-pxa/zeus.c | 2 +- arch/arm64/kernel/entry-ftrace.S | 1 - arch/mips/include/uapi/asm/inst.h | 2 +- arch/mips/ralink/Kconfig | 1 + arch/powerpc/include/asm/uaccess.h | 2 +- arch/powerpc/platforms/pseries/dlpar.c | 2 + arch/s390/kvm/kvm-s390.c | 17 +++- arch/um/include/asm/pgtable.h | 9 +- arch/x86/events/intel/core.c | 10 ++- arch/x86/events/intel/uncore_snbep.c | 4 +- arch/x86/include/asm/fpu/internal.h | 3 + arch/x86/kernel/cpu/mcheck/mce.c | 1 + arch/x86/kvm/svm.c | 7 ++ arch/x86/kvm/vmx.c | 1 + arch/x86/kvm/x86.c | 7 ++ arch/x86/pci/broadcom_bus.c | 4 +- drivers/ata/sata_rcar.c | 4 +- drivers/block/drbd/drbd_nl.c | 15 ++-- drivers/block/drbd/drbd_receiver.c | 13 +-- drivers/block/sunvdc.c | 5 ++ drivers/block/swim3.c | 6 +- drivers/cdrom/gdrom.c | 1 + drivers/clk/imx/clk-imx6sl.c | 6 ++ drivers/clk/sunxi-ng/ccu-sun8i-a33.c | 6 +- drivers/cpuidle/cpuidle-big_little.c | 7 +- drivers/crypto/ux500/cryp/cryp_core.c | 4 +- drivers/crypto/ux500/hash/hash_core.c | 2 +- drivers/dma/bcm2835-dma.c | 70 ++++++--------- drivers/dma/imx-dma.c | 8 +- drivers/dma/xilinx/zynqmp_dma.c | 2 +- drivers/firmware/efi/vars.c | 99 +++++++++++++++++----- drivers/gpu/drm/drm_bufs.c | 3 + drivers/gpu/drm/vc4/vc4_plane.c | 12 +-- drivers/gpu/ipu-v3/ipu-image-convert.c | 10 ++- drivers/hid/hid-lenovo.c | 10 ++- drivers/hwmon/lm80.c | 26 ++++-- drivers/i2c/busses/i2c-axxia.c | 32 +++---- drivers/iio/accel/kxcjk-1013.c | 1 + drivers/infiniband/hw/hfi1/ruc.c | 7 +- drivers/infiniband/hw/qib/qib_ruc.c | 7 +- drivers/iommu/amd_iommu.c | 9 +- drivers/iommu/arm-smmu-v3.c | 8 +- drivers/iommu/arm-smmu.c | 3 + drivers/isdn/hisax/hfc_pci.c | 2 + drivers/media/i2c/ad9389b.c | 2 +- drivers/media/i2c/adv7511.c | 2 +- drivers/media/i2c/adv7604.c | 4 +- drivers/media/i2c/adv7842.c | 4 +- drivers/media/i2c/tc358743.c | 2 +- drivers/media/i2c/ths8200.c | 2 +- drivers/media/platform/davinci/vpbe.c | 7 +- .../media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c | 10 ++- drivers/memstick/core/memstick.c | 3 + drivers/net/ethernet/broadcom/bcmsysport.c | 25 +++--- drivers/net/ethernet/broadcom/bcmsysport.h | 2 + drivers/net/ethernet/cisco/enic/enic_main.c | 2 +- drivers/net/ethernet/freescale/fman/fman_memac.c | 2 +- drivers/net/ethernet/freescale/fman/fman_tgec.c | 2 +- drivers/net/ethernet/intel/i40e/i40e_main.c | 3 + drivers/net/ethernet/intel/igb/igb_main.c | 8 +- drivers/net/ethernet/marvell/skge.c | 6 +- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 14 +++ drivers/net/ethernet/sun/niu.c | 10 ++- drivers/net/phy/dp83640.c | 13 ++- drivers/net/wireless/ath/ath9k/dynack.c | 3 +- drivers/net/wireless/st/cw1200/scan.c | 13 ++- drivers/pci/host/vmd.c | 15 ++++ drivers/pinctrl/meson/pinctrl-meson8.c | 3 + drivers/pinctrl/meson/pinctrl-meson8b.c | 13 +-- drivers/ptp/ptp_chardev.c | 5 +- drivers/scsi/aic94xx/aic94xx_init.c | 8 +- drivers/scsi/lpfc/lpfc_els.c | 3 + drivers/scsi/smartpqi/smartpqi_init.c | 6 ++ drivers/soc/bcm/brcmstb/common.c | 6 +- drivers/soc/tegra/common.c | 6 +- drivers/staging/iio/adc/ad7280a.c | 17 +++- drivers/staging/iio/adc/ad7780.c | 6 +- drivers/staging/iio/resolver/ad2s90.c | 7 +- drivers/thermal/thermal-generic-adc.c | 12 ++- drivers/thermal/thermal_core.c | 12 ++- drivers/thermal/thermal_hwmon.h | 4 +- drivers/tty/serial/fsl_lpuart.c | 4 + drivers/tty/serial/samsung.c | 3 + drivers/tty/serial/serial_core.c | 6 ++ drivers/usb/core/hub.c | 10 +++ drivers/usb/gadget/udc/net2272.c | 2 +- drivers/usb/musb/musb_gadget.c | 13 +-- drivers/usb/musb/musbhsdma.c | 21 ++--- drivers/usb/phy/phy-am335x.c | 5 +- drivers/video/console/fbcon.c | 2 +- drivers/video/fbdev/clps711x-fb.c | 5 +- drivers/video/fbdev/core/fbmem.c | 8 +- fs/binfmt_script.c | 10 ++- fs/cifs/readdir.c | 9 +- fs/dlm/ast.c | 10 +++ fs/eventpoll.c | 2 +- fs/f2fs/acl.c | 14 +-- fs/f2fs/f2fs.h | 12 ++- fs/f2fs/file.c | 3 + fs/f2fs/shrinker.c | 2 +- fs/fuse/dev.c | 4 +- fs/fuse/file.c | 2 +- fs/nfs/super.c | 3 +- fs/nfsd/nfsctl.c | 2 + fs/ocfs2/buffer_head_io.c | 2 - fs/proc/base.c | 12 ++- fs/udf/inode.c | 6 ++ include/linux/genl_magic_struct.h | 5 +- include/linux/sched.h | 1 + include/sound/compress_driver.h | 6 +- kernel/events/ring_buffer.c | 3 + kernel/hung_task.c | 8 +- kernel/sysctl.c | 2 + kernel/time/timekeeping.c | 4 +- kernel/trace/trace_stack.c | 2 +- lib/seq_buf.c | 6 +- mm/oom_kill.c | 4 +- net/bluetooth/hci_event.c | 6 ++ net/dccp/ccid.h | 4 +- net/dsa/slave.c | 12 ++- net/ipv6/xfrm6_tunnel.c | 3 + net/mac80211/rx.c | 5 +- net/rds/bind.c | 6 +- net/rxrpc/recvmsg.c | 3 +- scripts/decode_stacktrace.sh | 2 +- scripts/mod/modpost.c | 50 +++++------ security/smack/smack_lsm.c | 12 ++- sound/pci/hda/hda_bind.c | 3 +- sound/pci/hda/hda_codec.h | 1 + sound/pci/hda/hda_intel.c | 2 + sound/soc/fsl/Kconfig | 2 +- sound/soc/intel/atom/sst/sst_loader.c | 8 +- tools/perf/arch/x86/util/kvm-stat.c | 2 +- tools/perf/tests/evsel-tp-sched.c | 2 +- tools/perf/util/header.c | 2 +- tools/perf/util/probe-file.c | 2 +- virt/kvm/kvm_main.c | 3 +- 150 files changed, 779 insertions(+), 367 deletions(-)

6 years, 7 months

9
148
0 0

[PATCH AUTOSEL 3.18 01/14] mfd: ti_am335x_tscadc: Use PLATFORM_DEVID_AUTO while registering mfd cells

by Sasha Levin

From: Vignesh R <vigneshr(a)ti.com> [ Upstream commit b40ee006fe6a8a25093434e5d394128c356a48f3 ] Use PLATFORM_DEVID_AUTO to number mfd cells while registering, so that different instances are uniquely identified. This is required in order to support registering of multiple instances of same ti_am335x_tscadc IP. Signed-off-by: Vignesh R <vigneshr(a)ti.com> Signed-off-by: Lee Jones <lee.jones(a)linaro.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/mfd/ti_am335x_tscadc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c index 5726bf4e6c61..e8d5d171ab04 100644 --- a/drivers/mfd/ti_am335x_tscadc.c +++ b/drivers/mfd/ti_am335x_tscadc.c @@ -282,8 +282,9 @@ static int ti_tscadc_probe(struct platform_device *pdev) cell->pdata_size = sizeof(tscadc); } - err = mfd_add_devices(&pdev->dev, pdev->id, tscadc->cells, - tscadc->used_cells, NULL, 0, NULL); + err = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO, + tscadc->cells, tscadc->used_cells, NULL, + 0, NULL); if (err < 0) goto err_disable_clk; -- 2.19.1

6 years, 7 months

1
13
0 0

[PATCH AUTOSEL 4.4 01/16] mfd: ti_am335x_tscadc: Use PLATFORM_DEVID_AUTO while registering mfd cells

by Sasha Levin

From: Vignesh R <vigneshr(a)ti.com> [ Upstream commit b40ee006fe6a8a25093434e5d394128c356a48f3 ] Use PLATFORM_DEVID_AUTO to number mfd cells while registering, so that different instances are uniquely identified. This is required in order to support registering of multiple instances of same ti_am335x_tscadc IP. Signed-off-by: Vignesh R <vigneshr(a)ti.com> Signed-off-by: Lee Jones <lee.jones(a)linaro.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/mfd/ti_am335x_tscadc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c index 4a0f076c91ba..faf8ce5be576 100644 --- a/drivers/mfd/ti_am335x_tscadc.c +++ b/drivers/mfd/ti_am335x_tscadc.c @@ -279,8 +279,9 @@ static int ti_tscadc_probe(struct platform_device *pdev) cell->pdata_size = sizeof(tscadc); } - err = mfd_add_devices(&pdev->dev, pdev->id, tscadc->cells, - tscadc->used_cells, NULL, 0, NULL); + err = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO, + tscadc->cells, tscadc->used_cells, NULL, + 0, NULL); if (err < 0) goto err_disable_clk; -- 2.19.1

6 years, 7 months

1
15
0 0

[PATCH AUTOSEL 4.9 01/21] mfd: ti_am335x_tscadc: Use PLATFORM_DEVID_AUTO while registering mfd cells

by Sasha Levin

From: Vignesh R <vigneshr(a)ti.com> [ Upstream commit b40ee006fe6a8a25093434e5d394128c356a48f3 ] Use PLATFORM_DEVID_AUTO to number mfd cells while registering, so that different instances are uniquely identified. This is required in order to support registering of multiple instances of same ti_am335x_tscadc IP. Signed-off-by: Vignesh R <vigneshr(a)ti.com> Signed-off-by: Lee Jones <lee.jones(a)linaro.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/mfd/ti_am335x_tscadc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c index 798f0a829637..60286adbd6a1 100644 --- a/drivers/mfd/ti_am335x_tscadc.c +++ b/drivers/mfd/ti_am335x_tscadc.c @@ -264,8 +264,9 @@ static int ti_tscadc_probe(struct platform_device *pdev) cell->pdata_size = sizeof(tscadc); } - err = mfd_add_devices(&pdev->dev, pdev->id, tscadc->cells, - tscadc->used_cells, NULL, 0, NULL); + err = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO, + tscadc->cells, tscadc->used_cells, NULL, + 0, NULL); if (err < 0) goto err_disable_clk; -- 2.19.1

6 years, 7 months

1
20
0 0

[PATCH AUTOSEL 4.14 01/34] mfd: ti_am335x_tscadc: Use PLATFORM_DEVID_AUTO while registering mfd cells

by Sasha Levin

From: Vignesh R <vigneshr(a)ti.com> [ Upstream commit b40ee006fe6a8a25093434e5d394128c356a48f3 ] Use PLATFORM_DEVID_AUTO to number mfd cells while registering, so that different instances are uniquely identified. This is required in order to support registering of multiple instances of same ti_am335x_tscadc IP. Signed-off-by: Vignesh R <vigneshr(a)ti.com> Signed-off-by: Lee Jones <lee.jones(a)linaro.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/mfd/ti_am335x_tscadc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c index 7dc1cbcd2fb8..5894d6c16fab 100644 --- a/drivers/mfd/ti_am335x_tscadc.c +++ b/drivers/mfd/ti_am335x_tscadc.c @@ -265,8 +265,9 @@ static int ti_tscadc_probe(struct platform_device *pdev) cell->pdata_size = sizeof(tscadc); } - err = mfd_add_devices(&pdev->dev, pdev->id, tscadc->cells, - tscadc->used_cells, NULL, 0, NULL); + err = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO, + tscadc->cells, tscadc->used_cells, NULL, + 0, NULL); if (err < 0) goto err_disable_clk; -- 2.19.1

6 years, 7 months

1
33
0 0

[PATCH AUTOSEL 4.19 01/83] backlight: pwm_bl: Fix devicetree parsing with auto-generated brightness tables

by Sasha Levin

From: Heiko Stuebner <heiko.stuebner(a)bq.com> [ Upstream commit 61170ee9386888f1e6f7e9cc58e8d9a8c2a3c1dd ] Commit 88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED linearly to human eye") made the parse-dt function return early when using an auto- generated brightness-table, but didn't take into account that some more settings were handled below the brightness handling, like power-on-delays and also setting the pdata enable-gpio to -EINVAL. This surfaces for example in the case of a backlight without any enable-gpio which then tries to use gpio-0 in error. Fix this by simply moving the trailing settings above the brightness handling. Fixes: 88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED linearly to human eye") Signed-off-by: Heiko Stuebner <heiko.stuebner(a)bq.com> Acked-by: Daniel Thompson <daniel.thompson(a)linaro.org> Signed-off-by: Lee Jones <lee.jones(a)linaro.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/video/backlight/pwm_bl.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index bdfcc0a71db1..6bde543452f2 100644 --- a/drivers/video/backlight/pwm_bl.c +++ b/drivers/video/backlight/pwm_bl.c @@ -262,6 +262,16 @@ static int pwm_backlight_parse_dt(struct device *dev, memset(data, 0, sizeof(*data)); + /* + * These values are optional and set as 0 by default, the out values + * are modified only if a valid u32 value can be decoded. + */ + of_property_read_u32(node, "post-pwm-on-delay-ms", + &data->post_pwm_on_delay); + of_property_read_u32(node, "pwm-off-delay-ms", &data->pwm_off_delay); + + data->enable_gpio = -EINVAL; + /* * Determine the number of brightness levels, if this property is not * set a default table of brightness levels will be used. @@ -374,15 +384,6 @@ static int pwm_backlight_parse_dt(struct device *dev, data->max_brightness--; } - /* - * These values are optional and set as 0 by default, the out values - * are modified only if a valid u32 value can be decoded. - */ - of_property_read_u32(node, "post-pwm-on-delay-ms", - &data->post_pwm_on_delay); - of_property_read_u32(node, "pwm-off-delay-ms", &data->pwm_off_delay); - - data->enable_gpio = -EINVAL; return 0; } -- 2.19.1

6 years, 7 months

1
82
0 0

[PATCH AUTOSEL 4.20 001/105] backlight: pwm_bl: Fix devicetree parsing with auto-generated brightness tables

by Sasha Levin

From: Heiko Stuebner <heiko.stuebner(a)bq.com> [ Upstream commit 61170ee9386888f1e6f7e9cc58e8d9a8c2a3c1dd ] Commit 88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED linearly to human eye") made the parse-dt function return early when using an auto- generated brightness-table, but didn't take into account that some more settings were handled below the brightness handling, like power-on-delays and also setting the pdata enable-gpio to -EINVAL. This surfaces for example in the case of a backlight without any enable-gpio which then tries to use gpio-0 in error. Fix this by simply moving the trailing settings above the brightness handling. Fixes: 88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED linearly to human eye") Signed-off-by: Heiko Stuebner <heiko.stuebner(a)bq.com> Acked-by: Daniel Thompson <daniel.thompson(a)linaro.org> Signed-off-by: Lee Jones <lee.jones(a)linaro.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/video/backlight/pwm_bl.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index f9ef0673a083..aded3213bfb5 100644 --- a/drivers/video/backlight/pwm_bl.c +++ b/drivers/video/backlight/pwm_bl.c @@ -268,6 +268,16 @@ static int pwm_backlight_parse_dt(struct device *dev, memset(data, 0, sizeof(*data)); + /* + * These values are optional and set as 0 by default, the out values + * are modified only if a valid u32 value can be decoded. + */ + of_property_read_u32(node, "post-pwm-on-delay-ms", + &data->post_pwm_on_delay); + of_property_read_u32(node, "pwm-off-delay-ms", &data->pwm_off_delay); + + data->enable_gpio = -EINVAL; + /* * Determine the number of brightness levels, if this property is not * set a default table of brightness levels will be used. @@ -380,15 +390,6 @@ static int pwm_backlight_parse_dt(struct device *dev, data->max_brightness--; } - /* - * These values are optional and set as 0 by default, the out values - * are modified only if a valid u32 value can be decoded. - */ - of_property_read_u32(node, "post-pwm-on-delay-ms", - &data->post_pwm_on_delay); - of_property_read_u32(node, "pwm-off-delay-ms", &data->pwm_off_delay); - - data->enable_gpio = -EINVAL; return 0; } -- 2.19.1

6 years, 7 months

1
104
0 0

stable-rc/linux-3.18.y boot: 49 boots: 0 failed, 48 passed with 1 untried/unknown (v3.18.134-75-gb65f5f433007)

by kernelci.org bot

stable-rc/linux-3.18.y boot: 49 boots: 0 failed, 48 passed with 1 untried/unknown (v3.18.134-75-gb65f5f433007) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-3.18.y/kernel/v3.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-3.18.y/kernel/v3.18.134-7… Tree: stable-rc Branch: linux-3.18.y Git Describe: v3.18.134-75-gb65f5f433007 Git Commit: b65f5f433007fcf27d7bb54ebbfde49635b5becf Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 20 unique boards, 11 SoC families, 11 builds out of 185 --- For more info write to <info(a)kernelci.org>

6 years, 7 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror