- Linux-stable-mirror - lists.linaro.org

[PATCH] block: Fix blk_mq_try_issue_directly()

by Bart Van Assche

If blk_mq_try_issue_directly() returns BLK_STS*_RESOURCE that means that the request has not been queued and that the caller should retry to submit the request. Both blk_mq_request_bypass_insert() and blk_mq_sched_insert_request() guarantee that a request will be processed. Hence return BLK_STS_OK if one of these functions is called. This patch avoids that blk_mq_dispatch_rq_list() crashes when using dm-mpath. Cc: Christoph Hellwig <hch(a)infradead.org> Cc: Hannes Reinecke <hare(a)suse.com> Cc: James Smart <james.smart(a)broadcom.com> Cc: Ming Lei <ming.lei(a)redhat.com> Cc: Jianchao Wang <jianchao.w.wang(a)oracle.com> Cc: Keith Busch <keith.busch(a)intel.com> Cc: Dongli Zhang <dongli.zhang(a)oracle.com> Cc: Laurence Oberman <loberman(a)redhat.com> Tested-by: Laurence Oberman <loberman(a)redhat.com> Reviewed-by: Laurence Oberman <loberman(a)redhat.com> Reported-by: Laurence Oberman <loberman(a)redhat.com> Fixes: 7f556a44e61d ("blk-mq: refactor the code of issue request directly") # v5.0. Cc: <stable(a)vger.kernel.org> Signed-off-by: Bart Van Assche <bvanassche(a)acm.org> --- block/blk-mq.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 652d0c6d5945..b2c20dce8a30 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1859,16 +1859,11 @@ blk_status_t blk_mq_try_issue_directly(struct blk_mq_hw_ctx *hctx, case BLK_STS_RESOURCE: if (force) { blk_mq_request_bypass_insert(rq, run_queue); - /* - * We have to return BLK_STS_OK for the DM - * to avoid livelock. Otherwise, we return - * the real result to indicate whether the - * request is direct-issued successfully. - */ - ret = bypass ? BLK_STS_OK : ret; + ret = BLK_STS_OK; } else if (!bypass) { blk_mq_sched_insert_request(rq, false, run_queue, false); + ret = BLK_STS_OK; } break; default: -- 2.21.0.196.g041f5ea1cf98

6 years, 5 months

4
12
0 0

+ mm-vmstat-fix-proc-vmstat-format-for-config_debug_tlbflush=y-config_smp=n.patch added to -mm tree

by akpm＠linux-foundation.org

The patch titled Subject: mm/vmstat.c: fix /proc/vmstat format for CONFIG_DEBUG_TLBFLUSH=y CONFIG_SMP=n has been added to the -mm tree. Its filename is mm-vmstat-fix-proc-vmstat-format-for-config_debug_tlbflush=y-config_smp=n.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-vmstat-fix-proc-vmstat-format-f… and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-vmstat-fix-proc-vmstat-format-f… Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Konstantin Khlebnikov <khlebnikov(a)yandex-team.ru> Subject: mm/vmstat.c: fix /proc/vmstat format for CONFIG_DEBUG_TLBFLUSH=y CONFIG_SMP=n 58bc4c34d249 ("mm/vmstat.c: skip NR_TLB_REMOTE_FLUSH* properly") depends on skipping vmstat entries with empty name introduced in 7aaf77272358 ("mm: don't show nr_indirectly_reclaimable in /proc/vmstat") but reverted in b29940c1abd7 ("mm: rename and change semantics of nr_indirectly_reclaimable_bytes"). So skipping no longer works and /proc/vmstat has misformatted lines " 0". This patch simply shows debug counters "nr_tlb_remote_*" for UP. Link: http://lkml.kernel.org/r/155481488468.467.4295519102880913454.stgit@buzz Fixes: 58bc4c34d249 ("mm/vmstat.c: skip NR_TLB_REMOTE_FLUSH* properly") Signed-off-by: Konstantin Khlebnikov <khlebnikov(a)yandex-team.ru> Acked-by: Vlastimil Babka <vbabka(a)suse.cz> Cc: Roman Gushchin <guro(a)fb.com> Cc: Jann Horn <jannh(a)google.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/vmstat.c | 5 ----- 1 file changed, 5 deletions(-) --- a/mm/vmstat.c~mm-vmstat-fix-proc-vmstat-format-for-config_debug_tlbflush=y-config_smp=n +++ a/mm/vmstat.c @@ -1274,13 +1274,8 @@ const char * const vmstat_text[] = { #endif #endif /* CONFIG_MEMORY_BALLOON */ #ifdef CONFIG_DEBUG_TLBFLUSH -#ifdef CONFIG_SMP "nr_tlb_remote_flush", "nr_tlb_remote_flush_received", -#else - "", /* nr_tlb_remote_flush */ - "", /* nr_tlb_remote_flush_received */ -#endif /* CONFIG_SMP */ "nr_tlb_local_flush_all", "nr_tlb_local_flush_one", #endif /* CONFIG_DEBUG_TLBFLUSH */ _ Patches currently in -mm which might be from khlebnikov(a)yandex-team.ru are mm-vmstat-fix-proc-vmstat-format-for-config_debug_tlbflush=y-config_smp=n.patch

6 years, 5 months

1
0
0 0

[PATCH] cifs: fix handle leak in smb2_query_symlink()

by Ronnie Sahlberg

If we enter smb2_query_symlink() for something that is not a symlink and where the SMB2_open() would succeed we would never end up closing this handle and would thus leak a handle on the server. Fix this by immediately calling SMB2_close() on successfull open. Signed-off-by: Ronnie Sahlberg <lsahlber(a)redhat.com> CC: Stable <stable(a)vger.kernel.org> --- fs/cifs/smb2ops.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index 83a100dd2497..ab4737e3c31f 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -2397,6 +2397,8 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon, rc = SMB2_open(xid, &oparms, utf16_path, &oplock, NULL, &err_iov, &resp_buftype); + if (!rc) + SMB2_close(xid, tcon, fid.persistent_fid, fid.volatile_fid); if (!rc || !err_iov.iov_base) { rc = -ENOENT; goto free_path; -- 2.13.6

6 years, 5 months

2
1
0 0

Re: 5.0.7: WARNING: CPU: 1 PID: 169 at net/netfilter/nft_compat.c:82 and genreal protection fault

by Florian Westphal

Hello -stable team, Frederik Himpe <fhimpe(a)ai.vub.ac.be> wrote: > On Mon, 2019-04-08 at 22:19 +0200, Florian Westphal wrote: > > Frederik Himpe <fhimpe(a)ai.vub.ac.be> wrote: > > > [ 29.015565] general protection fault: 0000 [#1] SMP PTI > > > [ 29.015574] CPU: 3 PID: 2069 Comm: ip6tables-resto Tainted: > > > > Does this problem go away when you apply this commit on top of 5.0.7? > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… > > Indeed, the problem does not happen any more with this patch applied to > 5.0.7. Thanks! Could you please pick up following patches for 5.0.y? Fix tested by Frederik: b8e204006340b7aaf32bd2b9806c692f6e0cb38a netfilter: nft_compat: use .release_ops and remove list of extension Two followup-ups: 3f3a390dbd59d236f62cff8e8b20355ef7069e3d netfilter: nf_tables: use-after-free in dynamic operations b25a31bf0ca091aa8bdb9ab329b0226257568bbe netfilter: nf_tables: add missing ->release_ops() in error path of newrule() These are clean cherry-picks.

6 years, 5 months

3
2
0 0

netfilter fixes for 5.0.7 stable

by Pablo Neira Ayuso

Hi Sasha, Would you mind to cherry-pick these two patches into 5.0.y? b8e204006340 ("netfilter: nft_compat: use .release_ops and remove list of extension") b25a31bf0ca0 ("netfilter: nf_tables: add missing ->release_ops() in error path of newrule()") Thanks.

6 years, 5 months

1
1
0 0

[PATCH] virtio: Honour 'may_reduce_num' in vring_create_virtqueue

by Cornelia Huck

vring_create_virtqueue() allows the caller to specify via the may_reduce_num parameter whether the vring code is allowed to allocate a smaller ring than specified. However, the split ring allocation code tries to allocate a smaller ring on allocation failure regardless of what the caller specified. This may cause trouble for e.g. virtio-pci in legacy mode, which does not support ring resizing. (The packed ring code does not resize in any case.) Let's fix this by bailing out immediately in the split ring code if the requested size cannot be allocated and may_reduce_num has not been specified. While at it, fix a typo in the usage instructions. Fixes: 2a2d1382fe9d ("virtio: Add improved queue allocation API") Cc: stable(a)vger.kernel.org # v4.6+ Signed-off-by: Cornelia Huck <cohuck(a)redhat.com> --- drivers/virtio/virtio_ring.c | 2 ++ include/linux/virtio_ring.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 18846afb39da..5df92c308286 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -882,6 +882,8 @@ static struct virtqueue *vring_create_virtqueue_split( GFP_KERNEL|__GFP_NOWARN|__GFP_ZERO); if (queue) break; + if (!may_reduce_num) + return NULL; } if (!num) diff --git a/include/linux/virtio_ring.h b/include/linux/virtio_ring.h index fab02133a919..3dc70adfe5f5 100644 --- a/include/linux/virtio_ring.h +++ b/include/linux/virtio_ring.h @@ -63,7 +63,7 @@ struct virtqueue; /* * Creates a virtqueue and allocates the descriptor ring. If * may_reduce_num is set, then this may allocate a smaller ring than - * expected. The caller should query virtqueue_get_ring_size to learn + * expected. The caller should query virtqueue_get_vring_size to learn * the actual size of the ring. */ struct virtqueue *vring_create_virtqueue(unsigned int index, -- 2.17.2

6 years, 5 months

4
3
0 0

[RFC/RFT PATCH 04/18] crypto: skcipher - restore default skcipher_walk::iv on error

by Eric Biggers

From: Eric Biggers <ebiggers(a)google.com> When the user-provided IV buffer is not aligned to the algorithm's alignmask, skcipher_walk_virt() allocates an aligned buffer and copies the IV into it. However, skcipher_walk_virt() can fail after that point, and in this case the buffer will be freed. This causes a use-after-free read in callers that read from walk->iv unconditionally, e.g. the LRW template. For example, this can be reproduced by trying to encrypt fewer than 16 bytes using "lrw(aes)". Fix it by making skcipher_walk_first() reset walk->iv to walk->oiv if skcipher_walk_next() fails. This addresses a similar problem as commit 2b4f27c36bcd ("crypto: skcipher - set walk.iv for zero-length inputs"), but that didn't consider the case where skcipher_walk_virt() fails after copying the IV. This bug was detected by my patches that improve testmgr to fuzz algorithms against their generic implementation, when the extra self-tests were run on a KASAN-enabled kernel. Fixes: b286d8b1a690 ("crypto: skcipher - Add skcipher walk interface") Cc: <stable(a)vger.kernel.org> # v4.10+ Signed-off-by: Eric Biggers <ebiggers(a)google.com> --- crypto/skcipher.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/crypto/skcipher.c b/crypto/skcipher.c index bcf13d95f54ac..0f639f018047d 100644 --- a/crypto/skcipher.c +++ b/crypto/skcipher.c @@ -426,19 +426,27 @@ static int skcipher_copy_iv(struct skcipher_walk *walk) static int skcipher_walk_first(struct skcipher_walk *walk) { + int err; + if (WARN_ON_ONCE(in_irq())) return -EDEADLK; walk->buffer = NULL; if (unlikely(((unsigned long)walk->iv & walk->alignmask))) { - int err = skcipher_copy_iv(walk); + err = skcipher_copy_iv(walk); if (err) return err; } walk->page = NULL; - return skcipher_walk_next(walk); + err = skcipher_walk_next(walk); + + /* On error, don't leave 'walk->iv' pointing to freed buffer. */ + if (unlikely(err)) + walk->iv = walk->oiv; + + return err; } static int skcipher_walk_skcipher(struct skcipher_walk *walk, -- 2.21.0

6 years, 5 months

2
3
0 0

Re: [PATCH v2] mm: Fix modifying of page protection by insert_pfn_pmd()

by Aneesh Kumar K.V

Sasha Levin <sashal(a)kernel.org> writes: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a -stable tag. > The stable tag indicates that it's relevant for the following trees: all > > The bot has tested the following trees: v5.0.5, v4.19.32, v4.14.109, v4.9.166, v4.4.177, v3.18.137. > > v5.0.5: Build OK! > v4.19.32: Build OK! Considering this only impact ppc64 for now I guess it is ok to apply this to the above two kernel versions. The SCM support for ppc64 was added via git describe --contains b5beae5e224f1c72c4482b0ab36fc3d89481a6b2 v4.20-rc1~24^2~68 powerpc/pseries: Add driver for PAPR SCM regions -aneesh

6 years, 5 months

1
0
0 0

[PATCH] ALSA: hda - Add two more machines to the power_save_blacklist

by Hui Wang

Recently we set CONFIG_SND_HDA_POWER_SAVE_DEFAULT to 1 when configuring the kernel, then two machines were reported to have noise after installing the new kernel. Put them in the blacklist, the noise disappears. https://bugs.launchpad.net/bugs/1821663 Cc: <stable(a)vger.kernel.org> Signed-off-by: Hui Wang <hui.wang(a)canonical.com> --- sound/pci/hda/hda_intel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index ece256a3b48f..f62fb8b16c49 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2150,6 +2150,9 @@ static struct snd_pci_quirk power_save_blacklist[] = { SND_PCI_QUIRK(0x17aa, 0x367b, "Lenovo IdeaCentre B550", 0), /* https://bugzilla.redhat.com/show_bug.cgi?id=1572975 */ SND_PCI_QUIRK(0x17aa, 0x36a7, "Lenovo C50 All in one", 0), + /* https://bugs.launchpad.net/bugs/1821663 */ + SND_PCI_QUIRK(0x1631, 0xe017, "Packard Bell NEC IMEDIA 5204", 0), + SND_PCI_QUIRK(0x8086, 0x2064, "Intel Laptop 8086:2064", 0), {} }; #endif /* CONFIG_PM */ -- 2.17.1

6 years, 5 months

4
4
0 0

[PATCH net] ipv6: un-do: defrag: drop non-last frags smaller than min mtu

by Captain Wiggum

Hi Greg, A previous bad patch breaks 18 test cases for IPv6 fragment headers. This has already been un-done in upstream, but not in any of the LTS. However two upstream patches are first needed to cover a DoS vulnerability. For background, there are two mail threads in [netdev] on this subject: 1) Subject: TAHI testing fails for IPv6 Fragments in Kernel 4.9 (from captwiggum) 2) Subject: Please merge IPv6 fix for drop fragment smaller than MTU (from captwiggum) Two patches from upstream needed first to cover the DoS: commit d4289fcc9b16b89619ee1c54f829e05e56de8b9a net: IP6 defrag: use rbtrees for IPv6 defrag commit 997dd96471641e147cb2c33ad54284000d0f5e35 net: IP6 defrag: use rbtrees in nf_conntrack_reasm.c One undo-patch to fix the IPv6 fragment headers: ipv6: defrag: drop non-last frags smaller than min mtu UN-DO: commit a8444b1ccb20339774af58e40ad42296074fb484 Thanks! --John Masinter (captwiggum)

6 years, 5 months

6
13
0 0

Re: [RESEND PATCH v2] usb: dwc2: disable power_down on rockchip for regression

by Doug Anderson

Hi, On Fri, Oct 26, 2018 at 7:38 AM Hal Emmerich <hal(a)halemmerich.com> wrote: > > > From 04fbf78e4e569bf872f1ffcb0a6f9b89569dc913 Mon Sep 17 00:00:00 2001 > From: Hal Emmerich <hal(a)halemmerich.com> > Date: Thu, 19 Jul 2018 21:48:08 -0500 > Subject: [PATCH] usb: dwc2: disable power_down on rockchip devices > > The bug would let the usb controller enter partial power down, > which was formally known as hibernate, upon boot if nothing was plugged > in to the port. Partial power down couldn't be exited properly, so any > usb devices plugged in after boot would not be usable. > > Before the name change, params.hibernation was false by default, so > _dwc2_hcd_suspend() would skip entering hibernation. With the > rename, _dwc2_hcd_suspend() was changed to use params.power_down > to decide whether or not to enter partial power down. > > Since params.power_down is non-zero by default, it needs to be set > to 0 for rockchip devices to restore functionality. > > This bug was reported in the linux-usb thread: > REGRESSION: usb: dwc2: USB device not seen after boot > > The commit that caused this regression is: > 6d23ee9caa6790aea047f9aca7f3c03cb8d96eb6 > > Signed-off-by: Hal Emmerich <hal(a)halemmerich.com> > Acked-by: Minas Harutyunyan <hminas(a)synopsys.com> > --- > drivers/usb/dwc2/params.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c > index bf7052e037d6..09292dc977e4 100644 > --- a/drivers/usb/dwc2/params.c > +++ b/drivers/usb/dwc2/params.c > @@ -81,6 +81,7 @@ static void dwc2_set_rk_params(struct dwc2_hsotg *hsotg) > p->host_perio_tx_fifo_size = 256; > p->ahbcfg = GAHBCFG_HBSTLEN_INCR16 << > GAHBCFG_HBSTLEN_SHIFT; > + p->power_down = 0; This landed as commit c216765d3a1d ("usb: dwc2: disable power_down on rockchip devices"). Can it please go to stable? Hotplug of USB on v4.19 stable, for example, is currently broken due to the lack of this patch. Thanks! -Doug

6 years, 5 months

1
0
0 0

+ ocfs2-fix-ocfs2-read-inode-data-panic-in-ocfs2_iget.patch added to -mm tree

by akpm＠linux-foundation.org

The patch titled Subject: ocfs2: fix ocfs2 read inode data panic in ocfs2_iget has been added to the -mm tree. Its filename is ocfs2-fix-ocfs2-read-inode-data-panic-in-ocfs2_iget.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/ocfs2-fix-ocfs2-read-inode-data-pa… and later at http://ozlabs.org/~akpm/mmotm/broken-out/ocfs2-fix-ocfs2-read-inode-data-pa… Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Shuning Zhang <sunny.s.zhang(a)oracle.com> Subject: ocfs2: fix ocfs2 read inode data panic in ocfs2_iget In some cases, ocfs2_iget() reads the data of inode, which has been deleted for some reason. That will make the system panic. So We should judge whether this inode has been deleted, and tell the caller that the inode is a bad inode. For example, the ocfs2 is used as the backed of nfs, and the client is nfsv3. This issue can be reproduced by the following steps. on the nfs server side, ..../patha/pathb Step 1: The process A was scheduled before calling the function fh_verify. Step 2: The process B is removing the 'pathb', and just completed the call to function dput. Then the dentry of 'pathb' has been deleted from the dcache, and all ancestors have been deleted also. The relationship of dentry and inode was deleted through the function hlist_del_init. The following is the call stack. dentry_iput->hlist_del_init(&dentry->d_u.d_alias) At this time, the inode is still in the dcache. Step 3: The process A call the function ocfs2_get_dentry, which get the inode from dcache. Then the refcount of inode is 1. The following is the call stack. nfsd3_proc_getacl->fh_verify->exportfs_decode_fh->fh_to_dentry(ocfs2_get_dentry) Step 4: Dirty pages are flushed by bdi threads. So the inode of 'patha' is evicted, and this directory was deleted. But the inode of 'pathb' can't be evicted, because the refcount of the inode was 1. Step 5: The process A keep running, and call the function reconnect_path(in exportfs_decode_fh), which call function ocfs2_get_parent of ocfs2. Get the block number of parent directory(patha) by the name of ... Then read the data from disk by the block number. But this inode has been deleted, so the system panic. Process A Process B 1. in nfsd3_proc_getacl | 2. | dput 3. fh_to_dentry(ocfs2_get_dentry) | 4. bdi flush dirty cache | 5. ocfs2_iget | [283465.542049] OCFS2: ERROR (device sdp): ocfs2_validate_inode_block: Invalid dinode #580640: OCFS2_VALID_FL not set [283465.545490] Kernel panic - not syncing: OCFS2: (device sdp): panic forced after error [283465.546889] CPU: 5 PID: 12416 Comm: nfsd Tainted: G W 4.1.12-124.18.6.el6uek.bug28762940v3.x86_64 #2 [283465.548382] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 09/21/2015 [283465.549657] 0000000000000000 ffff8800a56fb7b8 ffffffff816e839c ffffffffa0514758 [283465.550392] 000000000008dc20 ffff8800a56fb838 ffffffff816e62d3 0000000000000008 [283465.551056] ffff880000000010 ffff8800a56fb848 ffff8800a56fb7e8 ffff88005df9f000 [283465.551710] Call Trace: [283465.552516] [<ffffffff816e839c>] dump_stack+0x63/0x81 [283465.553291] [<ffffffff816e62d3>] panic+0xcb/0x21b [283465.554037] [<ffffffffa04e66b0>] ocfs2_handle_error+0xf0/0xf0 [ocfs2] [283465.554882] [<ffffffffa04e7737>] __ocfs2_error+0x67/0x70 [ocfs2] [283465.555768] [<ffffffffa049c0f9>] ocfs2_validate_inode_block+0x229/0x230 [ocfs2] [283465.556683] [<ffffffffa047bcbc>] ocfs2_read_blocks+0x46c/0x7b0 [ocfs2] [283465.557408] [<ffffffffa049bed0>] ? ocfs2_inode_cache_io_unlock+0x20/0x20 [ocfs2] [283465.557973] [<ffffffffa049f0eb>] ocfs2_read_inode_block_full+0x3b/0x60 [ocfs2] [283465.558525] [<ffffffffa049f5ba>] ocfs2_iget+0x4aa/0x880 [ocfs2] [283465.559082] [<ffffffffa049146e>] ocfs2_get_parent+0x9e/0x220 [ocfs2] [283465.559622] [<ffffffff81297c05>] reconnect_path+0xb5/0x300 [283465.560156] [<ffffffff81297f46>] exportfs_decode_fh+0xf6/0x2b0 [283465.560708] [<ffffffffa062faf0>] ? nfsd_proc_getattr+0xa0/0xa0 [nfsd] [283465.561262] [<ffffffff810a8196>] ? prepare_creds+0x26/0x110 [283465.561932] [<ffffffffa0630860>] fh_verify+0x350/0x660 [nfsd] [283465.562862] [<ffffffffa0637804>] ? nfsd_cache_lookup+0x44/0x630 [nfsd] [283465.563697] [<ffffffffa063a8b9>] nfsd3_proc_getattr+0x69/0xf0 [nfsd] [283465.564510] [<ffffffffa062cf60>] nfsd_dispatch+0xe0/0x290 [nfsd] [283465.565358] [<ffffffffa05eb892>] ? svc_tcp_adjust_wspace+0x12/0x30 [sunrpc] [283465.566272] [<ffffffffa05ea652>] svc_process_common+0x412/0x6a0 [sunrpc] [283465.567155] [<ffffffffa05eaa03>] svc_process+0x123/0x210 [sunrpc] [283465.568020] [<ffffffffa062c90f>] nfsd+0xff/0x170 [nfsd] [283465.568962] [<ffffffffa062c810>] ? nfsd_destroy+0x80/0x80 [nfsd] [283465.570112] [<ffffffff810a622b>] kthread+0xcb/0xf0 [283465.571099] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 [283465.572114] [<ffffffff816f11b8>] ret_from_fork+0x58/0x90 [283465.573156] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 Link: http://lkml.kernel.org/r/1554185919-3010-1-git-send-email-sunny.s.zhang@ora… Signed-off-by: Shuning Zhang <sunny.s.zhang(a)oracle.com> Reviewed-by: Joseph Qi <jiangqi903(a)gmail.com> Cc: Mark Fasheh <mark(a)fasheh.com> Cc: Joel Becker <jlbec(a)evilplan.org> Cc: Junxiao Bi <junxiao.bi(a)oracle.com> Cc: Changwei Ge <gechangwei(a)live.cn> Cc: piaojun <piaojun(a)huawei.com> Cc: "Gang He" <ghe(a)suse.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- fs/ocfs2/export.c | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) --- a/fs/ocfs2/export.c~ocfs2-fix-ocfs2-read-inode-data-panic-in-ocfs2_iget +++ a/fs/ocfs2/export.c @@ -148,16 +148,24 @@ static struct dentry *ocfs2_get_parent(s u64 blkno; struct dentry *parent; struct inode *dir = d_inode(child); + int set; trace_ocfs2_get_parent(child, child->d_name.len, child->d_name.name, (unsigned long long)OCFS2_I(dir)->ip_blkno); + status = ocfs2_nfs_sync_lock(OCFS2_SB(dir->i_sb), 1); + if (status < 0) { + mlog(ML_ERROR, "getting nfs sync lock(EX) failed %d\n", status); + parent = ERR_PTR(status); + goto bail; + } + status = ocfs2_inode_lock(dir, NULL, 0); if (status < 0) { if (status != -ENOENT) mlog_errno(status); parent = ERR_PTR(status); - goto bail; + goto unlock_nfs_sync; } status = ocfs2_lookup_ino_from_name(dir, "..", 2, &blkno); @@ -166,11 +174,31 @@ static struct dentry *ocfs2_get_parent(s goto bail_unlock; } + status = ocfs2_test_inode_bit(OCFS2_SB(dir->i_sb), blkno, &set); + if (status < 0) { + if (status == -EINVAL) { + status = -ESTALE; + } else + mlog(ML_ERROR, "test inode bit failed %d\n", status); + parent = ERR_PTR(status); + goto bail_unlock; + } + + trace_ocfs2_get_dentry_test_bit(status, set); + if (!set) { + status = -ESTALE; + parent = ERR_PTR(status); + goto bail_unlock; + } + parent = d_obtain_alias(ocfs2_iget(OCFS2_SB(dir->i_sb), blkno, 0, 0)); bail_unlock: ocfs2_inode_unlock(dir, 0); +unlock_nfs_sync: + ocfs2_nfs_sync_unlock(OCFS2_SB(dir->i_sb), 1); + bail: trace_ocfs2_get_parent_end(parent); _ Patches currently in -mm which might be from sunny.s.zhang(a)oracle.com are ocfs2-fix-ocfs2-read-inode-data-panic-in-ocfs2_iget.patch

6 years, 5 months

1
0
0 0

+ mm-memory_hotplug-do-not-unlock-when-fails-to-take-the-device_hotplug_lock.patch added to -mm tree

by akpm＠linux-foundation.org

The patch titled Subject: mm/memory_hotplug: do not unlock after failing to take the device_hotplug_lock has been added to the -mm tree. Its filename is mm-memory_hotplug-do-not-unlock-when-fails-to-take-the-device_hotplug_lock.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-memory_hotplug-do-not-unlock-wh… and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-memory_hotplug-do-not-unlock-wh… Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: zhong jiang <zhongjiang(a)huawei.com> Subject: mm/memory_hotplug: do not unlock after failing to take the device_hotplug_lock When adding memory by probing a memory block in the sysfs interface, there is an obvious issue where we will unlock the device_hotplug_lock when we failed to takes it. That issue was introduced in 8df1d0e4a265 ("mm/memory_hotplug: make add_memory() take the device_hotplug_lock"). We should drop out in time when failing to take the device_hotplug_lock. Link: http://lkml.kernel.org/r/1554696437-9593-1-git-send-email-zhongjiang@huawei… Fixes: 8df1d0e4a265 ("mm/memory_hotplug: make add_memory() take the device_hotplug_lock") Signed-off-by: zhong jiang <zhongjiang(a)huawei.com> Reported-by: Yang yingliang <yangyingliang(a)huawei.com> Acked-by: Michal Hocko <mhocko(a)suse.com> Reviewed-by: David Hildenbrand <david(a)redhat.com> Reviewed-by: Oscar Salvador <osalvador(a)suse.de> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- drivers/base/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/base/memory.c~mm-memory_hotplug-do-not-unlock-when-fails-to-take-the-device_hotplug_lock +++ a/drivers/base/memory.c @@ -506,7 +506,7 @@ static ssize_t probe_store(struct device ret = lock_device_hotplug_sysfs(); if (ret) - goto out; + return ret; nid = memory_add_physaddr_to_nid(phys_addr); ret = __add_memory(nid, phys_addr, _ Patches currently in -mm which might be from zhongjiang(a)huawei.com are mm-memory_hotplug-do-not-unlock-when-fails-to-take-the-device_hotplug_lock.patch

6 years, 5 months

1
0
0 0

[PATCH 4/8] ACPICA: Namespace: remove address node from global list after method termination

by Erik Schmauss

ACPICA commit b233720031a480abd438f2e9c643080929d144c3 ASL operation_regions declare a range of addresses that it uses. In a perfect world, the range of addresses should be used exclusively by the AML interpreter. The OS can use this information to decide which drivers to load so that the AML interpreter and device drivers use different regions of memory. During table load, the address information is added to a global address range list. Each node in this list contains an address range as well as a namespace node of the operation_region. This list is deleted at ACPI shutdown. Unfortunately, ASL operation_regions can be declared inside of control methods. Although this is not recommended, modern firmware contains such code. New module level code changes unintentionally removed the functionality of adding and removing nodes to the global address range list. A few months ago, support for adding addresses has been re- implemented. However, the removal of the address range list was missed and resulted in some systems to crash due to the address list containing bogus namespace nodes from operation_regions declared in control methods. In order to fix the crash, this change removes dynamic operation_regions after control method termination. Link: https://github.com/acpica/acpica/commit/b2337200 Link: https://bugzilla.kernel.org/show_bug.cgi?id=202475 Cc: stable(a)vger.kernel.org # 4.20+ Fixes: 4abb951b73ff (ACPICA: AML interpreter: add region addresses in global list during initialization) Reported-by: Michael J Gruber <mjg(a)fedoraproject.org> Signed-off-by: Erik Schmauss <erik.schmauss(a)intel.com> Signed-off-by: Bob Moore <robert.moore(a)intel.com> --- drivers/acpi/acpica/nsobject.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/acpi/acpica/nsobject.c b/drivers/acpi/acpica/nsobject.c index 8638f43cfc3d..79d86da1c892 100644 --- a/drivers/acpi/acpica/nsobject.c +++ b/drivers/acpi/acpica/nsobject.c @@ -186,6 +186,10 @@ void acpi_ns_detach_object(struct acpi_namespace_node *node) } } + if (obj_desc->common.type == ACPI_TYPE_REGION) { + acpi_ut_remove_address_range(obj_desc->region.space_id, node); + } + /* Clear the Node entry in all cases */ node->object = NULL; -- 2.17.2

6 years, 5 months

1
0
0 0

[PATCH 4/8] ACPICA: Namespace: remove address node from global list after method termination

by Erik Schmauss

ACPICA commit b233720031a480abd438f2e9c643080929d144c3 ASL operation_regions declare a range of addresses that it uses. In a perfect world, the range of addresses should be used exclusively by the AML interpreter. The OS can use this information to decide which drivers to load so that the AML interpreter and device drivers use different regions of memory. During table load, the address information is added to a global address range list. Each node in this list contains an address range as well as a namespace node of the operation_region. This list is deleted at ACPI shutdown. Unfortunately, ASL operation_regions can be declared inside of control methods. Although this is not recommended, modern firmware contains such code. New module level code changes unintentionally removed the functionality of adding and removing nodes to the global address range list. A few months ago, support for adding addresses has been re- implemented. However, the removal of the address range list was missed and resulted in some systems to crash due to the address list containing bogus namespace nodes from operation_regions declared in control methods. In order to fix the crash, this change removes dynamic operation_regions after control method termination. Link: https://github.com/acpica/acpica/commit/b2337200 Link: https://bugzilla.kernel.org/show_bug.cgi?id=202475 Cc: stable(a)vger.kernel.org # 4.20+ Fixes: 4abb951b73ff (ACPICA: AML interpreter: add region addresses in global list during initialization) Reported-by: Michael J Gruber <mjg(a)fedoraproject.org> Signed-off-by: Erik Schmauss <erik.schmauss(a)intel.com> Signed-off-by: Bob Moore <robert.moore(a)intel.com> --- drivers/acpi/acpica/nsobject.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/acpi/acpica/nsobject.c b/drivers/acpi/acpica/nsobject.c index 8638f43cfc3d..79d86da1c892 100644 --- a/drivers/acpi/acpica/nsobject.c +++ b/drivers/acpi/acpica/nsobject.c @@ -186,6 +186,10 @@ void acpi_ns_detach_object(struct acpi_namespace_node *node) } } + if (obj_desc->common.type == ACPI_TYPE_REGION) { + acpi_ut_remove_address_range(obj_desc->region.space_id, node); + } + /* Clear the Node entry in all cases */ node->object = NULL; -- 2.17.2

6 years, 5 months

1
0
0 0

[PATCH 4.20 000/171] 4.20.16-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.20.16 release. There are 171 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu Mar 14 17:02:23 UTC 2019. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.20.16-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.20.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.20.16-rc1 Peter Zijlstra (Intel) <peterz(a)infradead.org> perf/x86/intel: Implement support for TSX Force Abort Peter Zijlstra (Intel) <peterz(a)infradead.org> x86: Add TSX Force Abort CPUID/MSR Peter Zijlstra (Intel) <peterz(a)infradead.org> perf/x86/intel: Generalize dynamic constraint creation Peter Zijlstra (Intel) <peterz(a)infradead.org> perf/x86/intel: Make cpuc allocations consistent Daniel F. Dickinson <cshored(a)thecshore.com> ath9k: Avoid OF no-EEPROM quirks without qca,no-eeprom Gao Xiang <gaoxiang25(a)huawei.com> staging: erofs: keep corrupted fs from crashing kernel in erofs_namei() Andreas Gruenbacher <agruenba(a)redhat.com> gfs2: Fix missed wakeups in find_insert_glock Jakub Sitnicki <jakub(a)cloudflare.com> bpf: Stop the psock parser before canceling its work Jakub Sitnicki <jakub(a)cloudflare.com> sk_msg: Always cancel strp work before freeing the psock Mika Westerberg <mika.westerberg(a)linux.intel.com> Revert "PCI/PME: Implement runtime PM callbacks" Sean Young <sean(a)mess.org> media: Revert "media: rc: some events are dropped by userspace" Ard Biesheuvel <ard.biesheuvel(a)linaro.org> drm: disable uncached DMA optimization for ARM and arm64 Marek Szyprowski <m.szyprowski(a)samsung.com> ARM: dts: exynos: Fix max voltage for buck8 regulator on Odroid XU3/XU4 Marek Szyprowski <m.szyprowski(a)samsung.com> ARM: dts: exynos: Add minimal clkout parameters to Exynos3250 PMU Marek Szyprowski <m.szyprowski(a)samsung.com> ARM: dts: exynos: Fix pinctrl definition for eMMC RTSN line on Odroid X2/U3 Alistair Strachan <astrachan(a)google.com> arm64: dts: hikey: Revert "Enable HS200 mode on eMMC" Jan Kiszka <jan.kiszka(a)siemens.com> arm64: dts: hikey: Give wifi some time after power-on Jan Kiszka <jan.kiszka(a)siemens.com> arm64: dts: zcu100-revC: Give wifi some time after power-on Alexander Shishkin <alexander.shishkin(a)linux.intel.com> x86/PCI: Fixup RTIT_BAR of Intel Denverton Trace Hub Gustavo A. R. Silva <gustavo(a)embeddedor.com> scsi: aacraid: Fix missing break in switch statement Gustavo A. R. Silva <gustavo(a)embeddedor.com> iscsi_ibft: Fix missing break in switch statement Vincent Batts <vbatts(a)hashbangbash.com> Input: elan_i2c - add id for touchpad found in Lenovo s21e-20 Jason Gerecke <jason.gerecke(a)wacom.com> Input: wacom_serial4 - add support for Wacom ArtPad II tablet Florian Westphal <fw(a)strlen.de> netfilter: nft_compat: don't use refcount_inc on newly allocated entry Pablo Neira Ayuso <pablo(a)netfilter.org> netfilter: nf_tables: unbind set in rule from commit path Keith Busch <keith.busch(a)intel.com> nvme-pci: add missing unlock for reset error Liu Bo <bo.liu(a)linux.alibaba.com> blk-iolatency: fix IO hang due to negative inflight counter Sudarsana Reddy Kalluru <skalluru(a)marvell.com> qede: Fix system crash on configuring channels. Sudarsana Reddy Kalluru <skalluru(a)marvell.com> qed: Consider TX tcs while deriving the max num_queues for PF. Manish Chopra <manishc(a)marvell.com> qed: Fix EQ full firmware assert. Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> fs: ratelimit __find_get_block_slow() failure message. Keith Busch <keith.busch(a)intel.com> nvme-pci: fix rapid add remove sequence Keith Busch <keith.busch(a)intel.com> nvme: lock NS list changes while handling command effects Tomi Valkeinen <tomi.valkeinen(a)ti.com> drm/omap: dsi: Hack-fix DSI bus flags Tomi Valkeinen <tomi.valkeinen(a)ti.com> drm/omap: dsi: Fix OF platform depopulate Tomi Valkeinen <tomi.valkeinen(a)ti.com> drm/omap: dsi: Fix crash in DSI debug dumps Philip Yang <Philip.Yang(a)amd.com> drm/amdgpu: use spin_lock_irqsave to protect vm_manager.pasid_idr Tony Lindgren <tony(a)atomide.com> i2c: omap: Use noirq system sleep pm ops to idle device for suspend Ross Lagerwall <ross.lagerwall(a)citrix.com> Revert "scsi: libfc: Add WARN_ON() when deleting rports" Jun-Ru Chang <jrjang(a)realtek.com> MIPS: Remove function size check in get_frame_info() Huacai Chen <chenhc(a)lemote.com> MIPS: Loongson: Introduce and use loongson_llsc_mb() Arnaldo Carvalho de Melo <acme(a)redhat.com> perf trace: Support multiple "vfs_getname" probes Jiri Olsa <jolsa(a)redhat.com> perf symbols: Filter out hidden symbols from labels Julian Wiedmann <jwi(a)linux.ibm.com> s390/qeth: conclude all event processing before offlining a card Julian Wiedmann <jwi(a)linux.ibm.com> s390/qeth: cancel close_dev work before removing a card Julian Wiedmann <jwi(a)linux.ibm.com> s390/qeth: fix use-after-free in error path Julian Wiedmann <jwi(a)linux.ibm.com> s390/qeth: release cmd buffer in error paths Martynas Pumputis <martynas(a)weave.works> netfilter: nf_nat: skip nat clash resolution for same-origin entries Florian Westphal <fw(a)strlen.de> selftests: netfilter: add simple masq/redirect test cases Naresh Kamboju <naresh.kamboju(a)linaro.org> selftests: netfilter: fix config fragment CONFIG_NF_TABLES_INET Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> dmaengine: dmatest: Abort test in case of mapping error Stefano Garzarella <sgarzare(a)redhat.com> vsock/virtio: reset connected sockets on device removal Stefano Garzarella <sgarzare(a)redhat.com> vsock/virtio: fix kernel panic after device hot-unplug Codrin Ciubotariu <codrin.ciubotariu(a)microchip.com> dmaengine: at_xdmac: Fix wrongfull report of a channel as in use Paul Kocialkowski <paul.kocialkowski(a)bootlin.com> drm/sun4i: tcon: Prepare and enable TCON channel 0 clock at init Huang Rui <ray.huang(a)amd.com> drm/amdgpu: fix the incorrect external id for raven series Jay Cornwall <Jay.Cornwall(a)amd.com> drm/amdgpu: Implement doorbell self-ring for NBIO 7.4 Martin KaFai Lau <kafai(a)fb.com> bpf: Fix syscall's stackmap lookup potential deadlock Alexei Starovoitov <ast(a)kernel.org> bpf: fix potential deadlock in bpf_prog_register Alexei Starovoitov <ast(a)kernel.org> bpf: fix lockdep false positive in percpu_freelist Alexei Starovoitov <ast(a)kernel.org> bpf: run bpf programs with preemption disabled Martynas Pumputis <m(a)lambda.lt> bpf, selftests: fix handling of sparse CPU allocations Brian Norris <briannorris(a)chromium.org> ath10k: correct bus type for WCN3990 Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> relay: check return of create_buf_file() properly Zenghui Yu <yuzenghui(a)huawei.com> irqchip/gic-v3-its: Fix ITT_entry_size accessor Jose Abreu <jose.abreu(a)synopsys.com> net: stmmac: Disable EEE mode earlier in XMIT callback Jose Abreu <jose.abreu(a)synopsys.com> net: stmmac: Send TSO packets always from Queue 0 Jose Abreu <jose.abreu(a)synopsys.com> net: stmmac: Fallback to Platform Data clock in Watchdog conversion Chris Wilson <chris(a)chris-wilson.co.uk> drm/amdgpu: Transfer fences to dmabuf importer Alex Deucher <alexander.deucher(a)amd.com> drm/radeon: check if device is root before getting pci speed caps Alex Deucher <alexander.deucher(a)amd.com> drm/amdgpu: Add missing power attribute to APU check Lubomir Rintel <lkundrak(a)v3.sk> irqchip/mmp: Only touch the PJ4 IRQ & FIQ bits on enable/disable Marc Zyngier <marc.zyngier(a)arm.com> irqchip/gic-v3-its: Gracefully fail on LPI exhaustion Heyi Guo <guoheyi(a)huawei.com> irqchip/gic-v4: Fix occasional VLPI drop Alexey Khoroshilov <khoroshilov(a)ispras.ru> usb: dwc3: exynos: Fix error handling of clk_prepare_enable Anders Roxell <anders.roxell(a)linaro.org> usb: phy: fix link errors Zhou Yanjie <zhouyanjie(a)cduestc.edu.cn> DTS: CI20: Fix bugs in ci20's device tree. Paul Cercueil <paul(a)crapouillou.net> MIPS: DTS: jz4740: Correct interrupt number of DMA core Felix Fietkau <nbd(a)nbd.name> batman-adv: release station info tidstats Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> arm64: dts: add msm8996 compatible to gicv3 Heiko Schocher <hs(a)denx.de> ARM: dts: am335x-shc.dts: fix wrong cd pin level Arthur Demchenkov <spinal.by(a)gmail.com> ARM: dts: n900: fix mmc1 card detect gpio polarity Tony Lindgren <tony(a)atomide.com> ARM: dts: omap3-gta04: Fix graph_port warning Peng Hao <peng.hao2(a)zte.com.cn> ARM: pxa: ssp: unneeded to free devm_ allocated data Yafang Shao <laoar.shao(a)gmail.com> bpf: sock recvbuff must be limited by rmem_max in bpf_setsockopt() Paolo Abeni <pabeni(a)redhat.com> bpftool: fix percpu maps updating Jiri Olsa <jolsa(a)kernel.org> bpftool: Fix prog dump by tag Ulf Hansson <ulf.hansson(a)linaro.org> wlcore: sdio: Fixup power on/off sequence Jason Kridner <jkridner(a)gmail.com> pinctrl: mcp23s08: spi: Fix regmap allocation for mcp23s18 Madalin Bucur <madalin.bucur(a)nxp.com> soc: fsl: qbman: avoid race in clearing QMan interrupt Geert Uytterhoeven <geert+renesas(a)glider.be> arm64: dts: renesas: r8a77965: Enable DMA for SCIF2 Geert Uytterhoeven <geert+renesas(a)glider.be> arm64: dts: renesas: r8a7796: Enable DMA for SCIF2 Anson Huang <anson.huang(a)nxp.com> ARM: dts: imx6sx: correct backward compatible of gpt Eric W. Biederman <ebiederm(a)xmission.com> signal: Make siginmask safe when passed a signal of 0 Martin Blumenstingl <martin.blumenstingl(a)googlemail.com> ARM: dts: meson8m2: mxiii-plus: mark the SD card detection GPIO active-low Martin Blumenstingl <martin.blumenstingl(a)googlemail.com> ARM: dts: meson8b: ec100: mark the SD card detection GPIO active-low Martin Blumenstingl <martin.blumenstingl(a)googlemail.com> ARM: dts: meson8b: odroidc1: mark the SD card detection GPIO active-low Carlo Caione <ccaione(a)baylibre.com> arm: dts: meson: Fix IRQ trigger type for macirq Jernej Skrabec <jernej.skrabec(a)siol.net> ARM: dts: sun8i: h3: Add ethernet0 alias to Beelink X2 Tony Lindgren <tony(a)atomide.com> ARM: dts: omap4-droid4: Fix typo in cpcap IRQ flags Aaro Koskinen <aaro.koskinen(a)iki.fi> ARM: OMAP: dts: N950/N9: fix onenand timings Michal Hocko <mhocko(a)suse.com> mm, memory_hotplug: fix off-by-one in is_pageblock_removable Ian Kent <raven(a)themaw.net> autofs: fix error return in autofs_fill_super() Pan Bian <bianpan2016(a)163.com> autofs: drop dentry reference only when it is never used Jan Kara <jack(a)suse.cz> fs/drop_caches.c: avoid softlockups in drop_pagecache_sb() Dan Carpenter <dan.carpenter(a)oracle.com> lib/test_kmod.c: potential double free in error handling Johannes Weiner <hannes(a)cmpxchg.org> psi: fix aggregation idle shut-off Mikhail Zaslonko <zaslonko(a)linux.ibm.com> mm, memory_hotplug: test_pages_in_a_zone do not pass the end of zone Michal Hocko <mhocko(a)suse.com> mm, memory_hotplug: is_mem_section_removable do not pass the end of a zone Qian Cai <cai(a)lca.pw> x86_64: increase stack size for KASAN_EXTRA Alexey Dobriyan <adobriyan(a)gmail.com> proc: fix /proc/net/* after setns(2) Kairui Song <kasong(a)redhat.com> x86/kexec: Don't setup EFI info if EFI runtime is not enabled John Johansen <john.johansen(a)canonical.com> apparmor: Fix aa_label_build() error handling for failed merges James Morse <james.morse(a)arm.com> arm64: kprobe: Always blacklist the KVM world-switch code Petr Vorel <pvorel(a)suse.cz> apparmor: Fix warning about unused function apparmor_ipv6_postroute Thomas Lendacky <Thomas.Lendacky(a)amd.com> x86/microcode/amd: Don't falsely trick the late loading mechanism Ronnie Sahlberg <lsahlber(a)redhat.com> cifs: fix computation for MAX_SMB2_HDR_SIZE Wei Huang <wei(a)redhat.com> x86/boot/compressed/64: Set EFER.LME=1 in 32-bit trampoline before returning to long mode Harini Katakam <harini.katakam(a)xilinx.com> net: macb: Apply RXUBR workaround only to versions with errata Kan Liang <kan.liang(a)linux.intel.com> x86/cpu: Add Atom Tremont (Jacobsville) Sinan Kaya <okaya(a)kernel.org> platform/x86: Fix unmet dependency warning for SAMSUNG_Q10 Sinan Kaya <okaya(a)kernel.org> platform/x86: Fix unmet dependency warning for ACPI_CMPC Dan Carpenter <dan.carpenter(a)oracle.com> scsi: 53c700: pass correct "dev" to dma_alloc_attrs() Dan Carpenter <dan.carpenter(a)oracle.com> scsi: bnx2fc: Fix error handling in probe() Douglas Gilbert <dgilbert(a)interlog.com> scsi: scsi_debug: fix write_same with virtual_gb problem Ming Lu <ming.lu(a)citrix.com> scsi: libfc: free skb when receiving invalid flogi resp Manish Chopra <manishc(a)marvell.com> qed: Fix stack out of bounds bug Manish Chopra <manishc(a)marvell.com> qed: Fix system crash in ll2 xmit Manish Chopra <manishc(a)marvell.com> qed: Fix VF probe failure while FLR Manish Chopra <manishc(a)marvell.com> qed: Fix LACP pdu drops for VFs Manish Chopra <manishc(a)marvell.com> qed: Fix bug in tx promiscuous mode settings Yao Liu <yotta.liu(a)ucloud.cn> nfs: Fix NULL pointer dereference of dev_name Fathi Boudra <fathi.boudra(a)linaro.org> selftests: timers: use LDLIBS instead of LDFLAGS Fathi Boudra <fathi.boudra(a)linaro.org> selftests: net: use LDLIBS instead of LDFLAGS Andrew Lunn <andrew(a)lunn.ch> gpio: vf610: Mask all GPIO interrupts Florian Westphal <fw(a)strlen.de> netfilter: ebtables: compat: un-break 32bit setsockopt when no rules are present Alexey Khoroshilov <khoroshilov(a)ispras.ru> net: stmmac: dwmac-rk: fix error handling in rk_gmac_powerup() Yonglong Liu <liuyonglong(a)huawei.com> net: hns: Fix wrong read accesses via Clause 45 MDIO protocol Yonglong Liu <liuyonglong(a)huawei.com> net: hns: Restart autoneg need return failed when autoneg off Yonglong Liu <liuyonglong(a)huawei.com> net: hns: Fix for missing of_node_put() after of_parse_phandle() Tomonori Sakita <tomonori.sakita(a)sord.co.jp> net: altera_tse: fix msgdma_tx_completion on non-zero fill_level case Max Filippov <jcmvbkbc(a)gmail.com> xtensa: SMP: limit number of possible CPUs by NR_CPUS Christoph Hellwig <hch(a)lst.de> iomap: fix a use after free in iomap_dio_rw Piotr Jaroszynski <pjaroszynski(a)nvidia.com> iomap: get/put the page in iomap_page_create/release() Max Filippov <jcmvbkbc(a)gmail.com> xtensa: SMP: mark each possible CPU as present Max Filippov <jcmvbkbc(a)gmail.com> xtensa: smp_lx200_defconfig: fix vectors clash Max Filippov <jcmvbkbc(a)gmail.com> xtensa: SMP: fix secondary CPU initialization Colin Ian King <colin.king(a)canonical.com> selftests: cpu-hotplug: fix case where CPUs offline > CPUs present Feras Daoud <ferasda(a)mellanox.com> IB/ipoib: Fix for use-after-free in ipoib_cm_tx_start Alexandre Ghiti <aghiti(a)upmem.com> riscv: Adjust mmap base address at a third of task size Artemy Kovalyov <artemyko(a)mellanox.com> RDMA/umem: Add missing initialization of owning_mm Max Filippov <jcmvbkbc(a)gmail.com> xtensa: SMP: fix ccount_timer_shutdown Taniya Das <tdas(a)codeaurora.org> clk: qcom: gcc: Use active only source for CPUSS clocks Dan Carpenter <dan.carpenter(a)oracle.com> clk: ti: Fix error handling in ti_clk_parse_divider_data() Suravee Suthikulpanit <suravee.suthikulpanit(a)amd.com> iommu/amd: Fix IOMMU page flush when detach device from a domain ZhangXiaoxu <zhangxiaoxu5(a)huawei.com> ipvs: Fix signed integer overflow when setsockopt timeout Guo Ren <ren_guo(a)c-sky.com> riscv: fixup max_low_pfn with PFN_DOWN. Jerry Snitselaar <jsnitsel(a)redhat.com> iommu/amd: Unmap all mapped pages in error path of map_sg Jerry Snitselaar <jsnitsel(a)redhat.com> iommu/amd: Call free_iova_fast with pfn in map_sg Brian Welty <brian.welty(a)intel.com> IB/{hfi1, qib}: Fix WC.byte_len calculation for UD_SEND_WITH_IMM Tony Jones <tonyj(a)suse.de> perf script: Fix crash when processing recorded stat data Stephane Eranian <eranian(a)google.com> perf tools: Handle TOPOLOGY headers with no CPU Arnaldo Carvalho de Melo <acme(a)redhat.com> perf python: Remove -fstack-clash-protection when building with some clang versions Stephane Eranian <eranian(a)google.com> perf core: Fix perf_proc_update_handler() bug Andi Kleen <ak(a)linux.intel.com> perf script: Fix crash with printing mixed trace point and other events Florian Westphal <fw(a)strlen.de> netfilter: nft_compat: destroy function must not have side effects Florian Westphal <fw(a)strlen.de> netfilter: nft_compat: make lists per netns Florian Westphal <fw(a)strlen.de> netfilter: nft_compat: use refcnt_t type for nft_xt reference count Jiri Olsa <jolsa(a)kernel.org> perf ordered_events: Fix crash in ordered_events__free Su Yanjun <suyj.fnst(a)cn.fujitsu.com> vti4: Fix a ipip packet processing bug in 'IPCOMP' virtual tunnel Alistair Strachan <astrachan(a)google.com> media: uvcvideo: Fix 'type' check leading to overflow ------------- Diffstat: Makefile | 4 +- arch/arm/boot/dts/am335x-shc.dts | 2 +- arch/arm/boot/dts/exynos3250.dtsi | 3 + arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 13 +- arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +- arch/arm/boot/dts/imx6sx.dtsi | 2 +- arch/arm/boot/dts/meson.dtsi | 2 +- arch/arm/boot/dts/meson8b-ec100.dts | 3 +- arch/arm/boot/dts/meson8b-odroidc1.dts | 4 +- arch/arm/boot/dts/meson8m2-mxiii-plus.dts | 3 +- arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi | 2 +- arch/arm/boot/dts/omap3-gta04.dtsi | 4 - arch/arm/boot/dts/omap3-n900.dts | 2 +- arch/arm/boot/dts/omap3-n950-n9.dtsi | 42 +- arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 2 +- arch/arm/plat-pxa/ssp.c | 3 - arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 2 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 3 + arch/arm64/boot/dts/renesas/r8a77965.dtsi | 3 + arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 1 + arch/arm64/kernel/probes/kprobes.c | 6 +- arch/mips/Kconfig | 15 + arch/mips/boot/dts/ingenic/ci20.dts | 8 +- arch/mips/boot/dts/ingenic/jz4740.dtsi | 2 +- arch/mips/include/asm/atomic.h | 6 + arch/mips/include/asm/barrier.h | 36 + arch/mips/include/asm/bitops.h | 5 + arch/mips/include/asm/futex.h | 3 + arch/mips/include/asm/pgtable.h | 2 + arch/mips/kernel/process.c | 7 +- arch/mips/loongson64/Platform | 23 + arch/mips/mm/tlbex.c | 10 + arch/riscv/include/asm/processor.h | 2 +- arch/riscv/kernel/setup.c | 2 +- arch/riscv/mm/init.c | 3 +- arch/x86/boot/compressed/head_64.S | 8 + arch/x86/boot/compressed/pgtable.h | 2 +- arch/x86/events/core.c | 13 +- arch/x86/events/intel/core.c | 154 ++++- arch/x86/events/perf_event.h | 17 +- arch/x86/include/asm/cpufeatures.h | 1 + arch/x86/include/asm/intel-family.h | 3 +- arch/x86/include/asm/msr-index.h | 6 + arch/x86/include/asm/page_64_types.h | 4 + arch/x86/kernel/cpu/microcode/amd.c | 2 +- arch/x86/kernel/kexec-bzimage64.c | 3 + arch/x86/pci/fixup.c | 16 + arch/xtensa/configs/smp_lx200_defconfig | 1 + arch/xtensa/kernel/head.S | 5 +- arch/xtensa/kernel/smp.c | 41 +- arch/xtensa/kernel/time.c | 2 +- block/blk-iolatency.c | 52 +- drivers/clk/qcom/gcc-sdm845.c | 14 +- drivers/clk/ti/divider.c | 11 +- drivers/dma/at_xdmac.c | 19 +- drivers/dma/dmatest.c | 28 +- drivers/firmware/iscsi_ibft.c | 1 + drivers/gpio/gpio-vf610.c | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c | 59 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 +- drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 13 + drivers/gpu/drm/amd/amdgpu/soc15.c | 6 +- drivers/gpu/drm/omapdrm/dss/dsi.c | 27 +- drivers/gpu/drm/radeon/ci_dpm.c | 5 +- drivers/gpu/drm/radeon/si_dpm.c | 5 +- drivers/gpu/drm/sun4i/sun4i_tcon.c | 2 + drivers/i2c/busses/i2c-omap.c | 13 +- drivers/infiniband/core/umem_odp.c | 3 + drivers/infiniband/hw/hfi1/ud.c | 1 - drivers/infiniband/hw/qib/qib_ud.c | 1 - drivers/infiniband/ulp/ipoib/ipoib.h | 1 - drivers/infiniband/ulp/ipoib/ipoib_cm.c | 3 +- drivers/input/mouse/elan_i2c_core.c | 1 + drivers/input/tablet/wacom_serial4.c | 2 + drivers/iommu/amd_iommu.c | 19 +- drivers/irqchip/irq-gic-v3-its.c | 69 +- drivers/irqchip/irq-mmp.c | 6 +- drivers/media/rc/rc-main.c | 13 +- drivers/media/usb/uvc/uvc_driver.c | 14 +- drivers/net/ethernet/altera/altera_msgdma.c | 3 +- drivers/net/ethernet/cadence/macb.h | 3 + drivers/net/ethernet/cadence/macb_main.c | 28 +- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 5 + drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 16 +- drivers/net/ethernet/hisilicon/hns_mdio.c | 2 +- drivers/net/ethernet/qlogic/qed/qed_dev.c | 8 +- drivers/net/ethernet/qlogic/qed/qed_l2.c | 17 +- drivers/net/ethernet/qlogic/qed/qed_l2.h | 3 + drivers/net/ethernet/qlogic/qed/qed_ll2.c | 20 +- drivers/net/ethernet/qlogic/qed/qed_sp.h | 1 + drivers/net/ethernet/qlogic/qed/qed_spq.c | 15 +- drivers/net/ethernet/qlogic/qed/qed_sriov.c | 10 +- drivers/net/ethernet/qlogic/qed/qed_vf.c | 10 + drivers/net/ethernet/qlogic/qede/qede.h | 3 + drivers/net/ethernet/qlogic/qede/qede_fp.c | 13 + drivers/net/ethernet/qlogic/qede/qede_main.c | 3 + drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 4 +- .../net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 14 +- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 17 +- drivers/net/wireless/ath/ath10k/core.c | 2 +- drivers/net/wireless/ath/ath9k/init.c | 6 +- drivers/net/wireless/ti/wlcore/sdio.c | 15 +- drivers/nvme/host/core.c | 8 +- drivers/nvme/host/nvme.h | 1 + drivers/nvme/host/pci.c | 30 +- drivers/pci/pcie/pme.c | 27 - drivers/pinctrl/pinctrl-mcp23s08.c | 7 +- drivers/platform/x86/Kconfig | 2 + drivers/s390/net/qeth_core.h | 3 +- drivers/s390/net/qeth_core_main.c | 31 +- drivers/s390/net/qeth_l2_main.c | 8 +- drivers/s390/net/qeth_l3_main.c | 3 + drivers/scsi/53c700.c | 2 +- drivers/scsi/aacraid/commsup.c | 5 +- drivers/scsi/bnx2fc/bnx2fc_io.c | 4 +- drivers/scsi/libfc/fc_lport.c | 6 +- drivers/scsi/libfc/fc_rport.c | 1 - drivers/scsi/scsi_debug.c | 41 +- drivers/soc/fsl/qbman/qman.c | 9 +- drivers/staging/erofs/namei.c | 183 ++--- drivers/usb/dwc3/dwc3-exynos.c | 4 +- drivers/usb/phy/Kconfig | 2 +- fs/autofs/expire.c | 3 +- fs/autofs/inode.c | 4 +- fs/buffer.c | 19 +- fs/cifs/smb2pdu.h | 4 +- fs/drop_caches.c | 8 +- fs/gfs2/glock.c | 2 +- fs/iomap.c | 37 +- fs/nfs/super.c | 5 + fs/proc/generic.c | 4 +- fs/proc/internal.h | 1 + fs/proc/proc_net.c | 20 + include/drm/drm_cache.h | 18 + include/linux/filter.h | 21 +- include/linux/irqchip/arm-gic-v3.h | 2 +- include/linux/signal.h | 2 +- include/linux/stmmac.h | 1 + include/net/netfilter/nf_tables.h | 17 +- kernel/bpf/cgroup.c | 2 +- kernel/bpf/hashtab.c | 4 +- kernel/bpf/percpu_freelist.c | 41 +- kernel/bpf/percpu_freelist.h | 4 + kernel/bpf/syscall.c | 12 +- kernel/events/core.c | 14 +- kernel/relay.c | 4 +- kernel/sched/psi.c | 21 +- kernel/trace/bpf_trace.c | 14 +- kernel/workqueue.c | 23 + kernel/workqueue_internal.h | 6 +- lib/test_kmod.c | 2 +- mm/memory_hotplug.c | 29 +- net/batman-adv/bat_v_elp.c | 3 + net/bridge/netfilter/ebtables.c | 9 +- net/core/filter.c | 2 + net/core/skmsg.c | 4 +- net/ipv4/ip_vti.c | 50 ++ net/netfilter/ipvs/ip_vs_ctl.c | 12 + net/netfilter/nf_conntrack_core.c | 16 + net/netfilter/nf_tables_api.c | 85 ++- net/netfilter/nft_compat.c | 177 +++-- net/netfilter/nft_dynset.c | 18 +- net/netfilter/nft_immediate.c | 6 +- net/netfilter/nft_lookup.c | 18 +- net/netfilter/nft_objref.c | 18 +- net/vmw_vsock/virtio_transport.c | 29 +- security/apparmor/domain.c | 5 +- security/apparmor/lsm.c | 2 + tools/bpf/bpftool/map.c | 16 + tools/bpf/bpftool/prog.c | 5 +- tools/perf/builtin-script.c | 9 +- tools/perf/builtin-trace.c | 25 +- tools/perf/util/cpumap.c | 11 +- tools/perf/util/ordered-events.c | 6 +- tools/perf/util/setup.py | 2 + tools/perf/util/symbol-elf.c | 9 +- tools/testing/selftests/bpf/bpf_util.h | 30 +- .../selftests/cpu-hotplug/cpu-on-off-test.sh | 13 +- tools/testing/selftests/net/Makefile | 2 +- tools/testing/selftests/netfilter/Makefile | 2 +- tools/testing/selftests/netfilter/config | 2 +- tools/testing/selftests/netfilter/nft_nat.sh | 762 +++++++++++++++++++++ tools/testing/selftests/proc/.gitignore | 1 + tools/testing/selftests/proc/Makefile | 1 + tools/testing/selftests/proc/setns-dcache.c | 129 ++++ tools/testing/selftests/timers/Makefile | 2 +- 188 files changed, 2601 insertions(+), 732 deletions(-)

6 years, 5 months

5
177
0 0

Re: [tip:sched/core] sched/fair: Limit sched_cfs_period_timer loop to avoid hard lockup

by Phil Auld

On Fri, Apr 05, 2019 at 02:15:23PM +0000 Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a -stable tag. > The stable tag indicates that it's relevant for the following trees: all > > The bot has tested the following trees: v5.0.6, v4.19.33, v4.14.110, v4.9.167, v4.4.178, v3.18.138. > > v5.0.6: Failed to apply! Possible dependencies: > c0ad4aa4d841 ("sched/fair: Robustify CFS-bandwidth timer locking") > > v4.19.33: Failed to apply! Possible dependencies: > c0ad4aa4d841 ("sched/fair: Robustify CFS-bandwidth timer locking") > > v4.14.110: Failed to apply! Possible dependencies: > c0ad4aa4d841 ("sched/fair: Robustify CFS-bandwidth timer locking") > This is a minor context difference. There is no actual dependency on the c0ad4aa4d841 patch. It would be easy to produce new version that could go in these trees. I'm not sure what the right action is in that case. Should I spin a new version with the different locking in the context? Also, I can't find this commit in tip. It's visible in gitweb but it's not in the tip tree as far as I can tell. > v4.9.167: Failed to apply! Possible dependencies: > 8a8c69c32778 ("sched/core: Add rq->lock wrappers") > 92509b732baf ("sched/core: Reset RQCF_ACT_SKIP before unpinning rq->lock") > c0ad4aa4d841 ("sched/fair: Robustify CFS-bandwidth timer locking") > cb42c9a3ebbb ("sched/core: Add debugging code to catch missing update_rq_clock() calls") > d1ccc66df8bf ("sched/core: Clean up comments") > d8ac897137a2 ("sched/core: Add wrappers for lockdep_(un)pin_lock()") > > v4.4.178: Failed to apply! Possible dependencies: > 2a67e741bbbc ("rcu: Create transitive rnp->lock acquisition functions") > 3e71a462dd48 ("sched/core: Move task_rq_lock() out of line") > 3ea94de15ce9 ("sched/core: Fix incorrect wait time and wait count statistics") > 46a5d164db53 ("rcu: Stop disabling interrupts in scheduler fastpaths") > 8a8c69c32778 ("sched/core: Add rq->lock wrappers") > 958c5f848e17 ("stop_machine: Change stop_one_cpu() to rely on cpu_stop_queue_work()") > bf89a304722f ("stop_machine: Avoid a sleep and wakeup in stop_one_cpu()") > c0ad4aa4d841 ("sched/fair: Robustify CFS-bandwidth timer locking") > cb2517653fcc ("sched/debug: Make schedstats a runtime tunable that is disabled by default") > d8ac897137a2 ("sched/core: Add wrappers for lockdep_(un)pin_lock()") > e7904a28f533 ("locking/lockdep, sched/core: Implement a better lock pinning scheme") > fecbf6f01fbd ("rcu: Simplify rcu_sched_qs() control flow") > > v3.18.138: Failed to apply! Possible dependencies: > 1a43a14a5bd9 ("sched: Fix schedule_tail() to disable preemption") > 1b537c7d1e58 ("sched/core: Remove check of p->sched_class") > 1d7e974cbf2f ("sched/deadline: Don't check SD_BALANCE_FORK") > 3960c8c0c789 ("sched: Make dl_task_time() use task_rq_lock()") > 3e71a462dd48 ("sched/core: Move task_rq_lock() out of line") > 4c9a4bc89a9c ("sched: Allow balance callbacks for check_class_changed()") > 5cc389bcee08 ("sched: Move code around") > 5e16bbc2fb40 ("sched: Streamline the task migration locking a little") > 67dfa1b756f2 ("sched/deadline: Implement cancel_dl_timer() to use in switched_from_dl()") > 6c1d9410f007 ("sched: Move p->nr_cpus_allowed check to select_task_rq()") > 74b8a4cb6ce3 ("sched: Clarify ordering between task_rq_lock() and move_queued_task()") > 8a8c69c32778 ("sched/core: Add rq->lock wrappers") > c0ad4aa4d841 ("sched/fair: Robustify CFS-bandwidth timer locking") > cbce1a686700 ("sched,lockdep: Employ lock pinning") > dfa50b605c2a ("sched: Make finish_task_switch() return 'struct rq *'") > f4e9d94a5bf6 ("sched/deadline: Don't balance during wakeup if wakee is pinned") > > > How should we proceed with this patch? > I haven't look that far back. This patch should be pretty self contained. I don't think it's worth pulling it back to these trees if it would require all of these patches. The risk would out-weigh the reward. Cheers, Phil > -- > Thanks, > Sasha --

6 years, 5 months

2
4
0 0

[PATCH] arm64: backtrace: Don't bother trying to unwind the userspace stack

by Will Deacon

Calling dump_backtrace() with a pt_regs argument corresponding to userspace doesn't make any sense and our unwinder will simply print "Call trace:" before unwinding the stack looking for user frames. Rather than go through this song and dance, just return early if we're passed a user register state. Cc: <stable(a)vger.kernel.org> Fixes: 1149aad10b1e ("arm64: Add dump_backtrace() in show_regs") Reported-by: Kefeng Wang <wangkefeng.wang(a)huawei.com> Signed-off-by: Will Deacon <will.deacon(a)arm.com> --- arch/arm64/kernel/traps.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c index 8ad119c3f665..29755989f616 100644 --- a/arch/arm64/kernel/traps.c +++ b/arch/arm64/kernel/traps.c @@ -102,10 +102,16 @@ static void dump_instr(const char *lvl, struct pt_regs *regs) void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk) { struct stackframe frame; - int skip; + int skip = 0; pr_debug("%s(regs = %p tsk = %p)\n", __func__, regs, tsk); + if (regs) { + if (user_mode(regs)) + return; + skip = 1; + } + if (!tsk) tsk = current; @@ -126,7 +132,6 @@ void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk) frame.graph = 0; #endif - skip = !!regs; printk("Call trace:\n"); do { /* skip until specified stack frame */ @@ -176,15 +181,13 @@ static int __die(const char *str, int err, struct pt_regs *regs) return ret; print_modules(); - __show_regs(regs); pr_emerg("Process %.*s (pid: %d, stack limit = 0x%p)\n", TASK_COMM_LEN, tsk->comm, task_pid_nr(tsk), end_of_stack(tsk)); + show_regs(regs); - if (!user_mode(regs)) { - dump_backtrace(regs, tsk); + if (!user_mode(regs)) dump_instr(KERN_EMERG, regs); - } return ret; } -- 2.11.0

6 years, 5 months

1
0
0 0

[PATCH for 4.14] drm/i915/gvt: do not let pin count of shadow mm go negative

by Yan Zhao

shadow mm's pin count got increased in workload preparation phase, which is after workload scanning. it will get decreased in complete_current_workload() anyway after workload completion. Sometimes, if a workload meets a scanning error, its shadow mm pin count will not get increased but will get decreased in the end. This patch lets shadow mm's pin count not go below 0. v2: add fixes tag and cc stable kernel (zhenyu wang) Fixes: 2707e4446688 ("drm/i915/gvt: vGPU graphics memory virtualization") Cc: zhenyuw(a)linux.intel.com Cc: stable(a)vger.kernel.org #4.14+ Signed-off-by: Yan Zhao <yan.y.zhao(a)intel.com> --- upstream commit id: 663a50ceac75c2208d2ad95365bc8382fd42f44d --- drivers/gpu/drm/i915/gvt/gtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c index dadacbe558ab..1a1f7eb46d1e 100644 --- a/drivers/gpu/drm/i915/gvt/gtt.c +++ b/drivers/gpu/drm/i915/gvt/gtt.c @@ -1629,7 +1629,7 @@ void intel_vgpu_unpin_mm(struct intel_vgpu_mm *mm) if (WARN_ON(mm->type != INTEL_GVT_MM_PPGTT)) return; - atomic_dec(&mm->pincount); + atomic_dec_if_positive(&mm->pincount); } /** -- 2.17.1

6 years, 5 months

2
1
0 0

request for 4.14-stable: 5b06bbcfc2c6 ("x86/power: Fix some ordering bugs in __restore_processor_context()")

by Sudip Mukherjee

Hi Greg, This was not marked for stable but it fixes a commit which has been backported to 4.14-stable. 1) 5b06bbcfc2c6 fixes ca37e57bbe0c 2) 7ee18d677989 will again fix 5b06bbcfc2c6 But you will need to add: 090edbe23ff5 ("x86/power/64: Use struct desc_ptr for the IDT in struct saved_context") and 896c80bef4d3 ("x86/power/32: Move SYSENTER MSR restoration to fix_processor_context()") to apply 7ee18d677989. All of them are attached to this mail for you. -- Regards Sudip

6 years, 5 months

2
1
0 0

[stable-4.19] kvm: nVMX: NMI-window and interrupt-window exiting should wake L2 from HLT

by Mark Mielke

This commit was first released with 5.0: commit 9ebdfe5230f2e50e3ba05c57723a06e90946815a Author: Jim Mattson <jmattson(a)google.com> Date: Mon Nov 26 11:22:32 2018 -0800 kvm: nVMX: NMI-window and interrupt-window exiting should wake L2 from HLT According to the SDM, "NMI-window exiting" VM-exits wake a logical processor from the same inactive states as would an NMI and "interrupt-window exiting" VM-exits wake a logical processor from the same inactive states as would an external interrupt. Specifically, they wake a logical processor from the shutdown state and from the states entered using the HLT and MWAIT instructions. Fixes: 6dfacadd5858 ("KVM: nVMX: Add support for activity state HLT") Signed-off-by: Jim Mattson <jmattson(a)google.com> Reviewed-by: Peter Shier <pshier(a)google.com> Suggested-by: Sean Christopherson <sean.j.christopherson(a)intel.com> [Squashed comments of two Jim's patches and used the simplified code hunk provided by Sean. - Radim] Signed-off-by: Radim Krčmář <rkrcmar(a)redhat.com> This commit does not apply clean to 4.19, only due to restructuring that split out a portion of arch/x86/kvm/vmx.c into arch/x86/kvm/vmx/nested.c. The following procedure can be followed to allow the patch to apply clean to 4.19: git checkout linux-4.19.y git format-patch -1 9ebdfe5230f2e50e3ba05c57723a06e90946815a perl -pi -e 's[arch/x86/kvm/vmx/nested.c][arch/x86/kvm/vmx.c]g' 0001-kvm-nVMX-NMI-window-and-interrupt-window-exiting-sho.patch git am 0001-kvm-nVMX-NMI-window-and-interrupt-window-exiting-sho.patch I have been using this patch in our own 4.19-based production environment (which heavily uses nested KVM for product simulation) since January, 2019, along with several other nVMX patches. All of the other nVMX patches have since made it into 4.19 except for this one. I expect this one did not make the stable list because it did not apply cleanly without help. I don't have a specific test to reproduce the problem that this fix addresses. I had specific problems that were addressed by other nVMX patches, but this was one I chose to add as a preventative measure based upon the description and the likelihood that the problem might impact us. Please consider including this patch into 4.19. I don't mind maintaining it local if there is some reason it doesn't qualify for stable. But, if this could help others, I'm happy to share the above method of getting it into 4.19 safely. Thank you! -- Mark Mielke <mark.mielke(a)gmail.com>

6 years, 5 months

2
1
0 0

[PATCH] objtool: Don't use -Werror

by Luis Ressel

-Werror can be handy for development, but enabling it for production builds is a bad idea -- other compilers might produce unexpected warnings, or #included library headers might trigger warnings. In my case, libelf's (not elfutil's!) headers trigger several -Wundef warnings. This wasn't a problem before 056d28d135bc, since gcc doesn't emit warnings for system headers, but now that there's a -I/usr/include/libelf/ in the gcc command line, those warnings appear and break the build. CC'ing stable@ since 056d28d135bc has also been included in stable versions. Fixes: 056d28d135bc ("objtool: Query pkg-config for libelf location") Signed-off-by: Luis Ressel <aranea(a)aixah.de> Cc: stable(a)vger.kernel.org --- tools/objtool/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile index 53f8be0f4a1f..ad2c11a881db 100644 --- a/tools/objtool/Makefile +++ b/tools/objtool/Makefile @@ -34,7 +34,7 @@ INCLUDES := -I$(srctree)/tools/include \ -I$(srctree)/tools/arch/$(HOSTARCH)/include/uapi \ -I$(srctree)/tools/objtool/arch/$(ARCH)/include WARNINGS := $(EXTRA_WARNINGS) -Wno-switch-default -Wno-switch-enum -Wno-packed -CFLAGS += -Werror $(WARNINGS) $(KBUILD_HOSTCFLAGS) -g $(INCLUDES) $(LIBELF_FLAGS) +CFLAGS += $(WARNINGS) $(KBUILD_HOSTCFLAGS) -g $(INCLUDES) $(LIBELF_FLAGS) LDFLAGS += $(LIBELF_LIBS) $(LIBSUBCMD) $(KBUILD_HOSTLDFLAGS) # Allow old libelf to be used: -- 2.21.0

6 years, 5 months

4
16
0 0

[PATCH v2] ALSA: hda - Add two more machines to the power_save_blacklist

by Hui Wang

Recently we set CONFIG_SND_HDA_POWER_SAVE_DEFAULT to 1 when configuring the kernel, then two machines were reported to have noise after installing the new kernel. Put them in the blacklist, the noise disappears. https://bugs.launchpad.net/bugs/1821663 Cc: <stable(a)vger.kernel.org> Signed-off-by: Hui Wang <hui.wang(a)canonical.com> --- In the V2, put the Intel entry in the blacklist according to pciid's order, and change the machine name "Intel Laptop 8086:2064" to "Intel SDP 8086:2064". sound/pci/hda/hda_intel.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index ece256a3b48f..2ec91085fa3e 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2142,6 +2142,8 @@ static struct snd_pci_quirk power_save_blacklist[] = { SND_PCI_QUIRK(0x8086, 0x2040, "Intel DZ77BH-55K", 0), /* https://bugzilla.kernel.org/show_bug.cgi?id=199607 */ SND_PCI_QUIRK(0x8086, 0x2057, "Intel NUC5i7RYB", 0), + /* https://bugs.launchpad.net/bugs/1821663 */ + SND_PCI_QUIRK(0x8086, 0x2064, "Intel SDP 8086:2064", 0), /* https://bugzilla.redhat.com/show_bug.cgi?id=1520902 */ SND_PCI_QUIRK(0x8086, 0x2068, "Intel NUC7i3BNB", 0), /* https://bugzilla.kernel.org/show_bug.cgi?id=198611 */ @@ -2150,6 +2152,8 @@ static struct snd_pci_quirk power_save_blacklist[] = { SND_PCI_QUIRK(0x17aa, 0x367b, "Lenovo IdeaCentre B550", 0), /* https://bugzilla.redhat.com/show_bug.cgi?id=1572975 */ SND_PCI_QUIRK(0x17aa, 0x36a7, "Lenovo C50 All in one", 0), + /* https://bugs.launchpad.net/bugs/1821663 */ + SND_PCI_QUIRK(0x1631, 0xe017, "Packard Bell NEC IMEDIA 5204", 0), {} }; #endif /* CONFIG_PM */ -- 2.17.1

6 years, 5 months

2
1
0 0

[PATCH v2] i3c: dw: Fix dw_i3c_master_disable controller by using correct mask

by Vitor Soares

The controller was being disabled incorrectly. The correct way is to clear the DEV_CTRL_ENABLE bit. Fix this by by clearing this bit. Signed-off-by: Vitor Soares <vitor.soares(a)synopsys.com> Cc: Boris Brezillon <bbrezillon(a)kernel.org> Cc: <stable(a)vger.kernel.org> --- Changes v1 to v2: Fix commit Message Add Cc: <stable(a)vger.kernel.org> drivers/i3c/master/dw-i3c-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c index 5927922..10c26ff 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -300,7 +300,7 @@ to_dw_i3c_master(struct i3c_master_controller *master) static void dw_i3c_master_disable(struct dw_i3c_master *master) { - writel(readl(master->regs + DEVICE_CTRL) & DEV_CTRL_ENABLE, + writel(readl(master->regs + DEVICE_CTRL) & ~DEV_CTRL_ENABLE, master->regs + DEVICE_CTRL); } -- 2.7.4

6 years, 5 months

1
0
0 0

[PATCH] ARM: dts: imx: Fix the AR803X phy-mode

by Fabio Estevam

Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") exposed an issue on imx DTS files using AR8031/AR8035 PHYs. The end result is that the boards can no longer obtain an IP address via UDHCP, for example. Quoting Andrew Lunn: "The problem here is, all the DTs were broken since day 0. However, because the PHY driver was also broken, nobody noticed and it worked. Now that the PHY driver has been fixed, all the bugs in the DTs now become an issue" To fix this problem, the phy-mode property needs to be "rgmii-id", which has the following meaning as per Documentation/devicetree/bindings/net/ethernet.txt: "RGMII with internal RX and TX delays provided by the PHY, the MAC should not add the RX or TX delays in this case)" Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with successfully restored networking. Based on the initial submission from Steve Twiss for the imx6qdl-sabresd. Cc: <stable(a)vger.kernel.org> # 4.9+ Signed-off-by: Fabio Estevam <festevam(a)gmail.com> Tested-by: Baruch Siach <baruch(a)tkos.co.il> Tested-by: Soeren Moch <smoch(a)web.de> Tested-by: Steve Twiss <stwiss.opensource(a)diasemi.com> Tested-by: Adam Thomson <Adam.Thomson(a)diasemi.com> Signed-off-by: Steve Twiss <stwiss.opensource(a)diasemi.com> Tested-by: Marc Kleine-Budde <mkl(a)pengutronix.de> Signed-off-by: Marc Kleine-Budde <mkl(a)pengutronix.de> --- arch/arm/boot/dts/imx6dl-riotboard.dts | 2 +- arch/arm/boot/dts/imx6q-tbs2910.dts | 2 +- arch/arm/boot/dts/imx6qdl-apf6.dtsi | 2 +- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 2 +- arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +- arch/arm/boot/dts/imx6qdl-sr-som.dtsi | 2 +- arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 2 +- arch/arm/boot/dts/imx6sx-sabreauto.dts | 2 +- arch/arm/boot/dts/imx6sx-sdb.dtsi | 2 +- arch/arm/boot/dts/imx7d-pico.dtsi | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts index 65c184bb8fb0..d9de49efa802 100644 --- a/arch/arm/boot/dts/imx6dl-riotboard.dts +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts @@ -92,7 +92,7 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>; interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; diff --git a/arch/arm/boot/dts/imx6q-tbs2910.dts b/arch/arm/boot/dts/imx6q-tbs2910.dts index 2ce8399a10ba..bfff87ce2e1f 100644 --- a/arch/arm/boot/dts/imx6q-tbs2910.dts +++ b/arch/arm/boot/dts/imx6q-tbs2910.dts @@ -98,7 +98,7 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx6qdl-apf6.dtsi b/arch/arm/boot/dts/imx6qdl-apf6.dtsi index 1ebf29f43a24..4738c3c1ab50 100644 --- a/arch/arm/boot/dts/imx6qdl-apf6.dtsi +++ b/arch/arm/boot/dts/imx6qdl-apf6.dtsi @@ -51,7 +51,7 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-reset-duration = <10>; phy-reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>; status = "okay"; diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi index 1280de50a984..f3404dd10537 100644 --- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi @@ -292,7 +292,7 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; fsl,err006687-workaround-present; diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi index a0705066ccba..185fb17a3500 100644 --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi @@ -202,7 +202,7 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi index 4ccb7afc4b35..6d7f6b9035bc 100644 --- a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi @@ -53,7 +53,7 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_microsom_enet_ar8035>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-reset-duration = <2>; phy-reset-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>; status = "okay"; diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi index b7d5fb421404..50d9a989e06a 100644 --- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi +++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi @@ -224,7 +224,7 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-reset-gpios = <&gpio3 29 GPIO_ACTIVE_LOW>; interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/imx6sx-sabreauto.dts index b0ee324afe58..315044ccd65f 100644 --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts @@ -75,7 +75,7 @@ &fec1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet1>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-handle = <&ethphy1>; fsl,magic-packet; status = "okay"; diff --git a/arch/arm/boot/dts/imx6sx-sdb.dtsi b/arch/arm/boot/dts/imx6sx-sdb.dtsi index 08ede56c3f10..f6972deb5e39 100644 --- a/arch/arm/boot/dts/imx6sx-sdb.dtsi +++ b/arch/arm/boot/dts/imx6sx-sdb.dtsi @@ -191,7 +191,7 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet1>; phy-supply = <&reg_enet_3v3>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-handle = <&ethphy1>; phy-reset-gpios = <&gpio2 7 GPIO_ACTIVE_LOW>; status = "okay"; diff --git a/arch/arm/boot/dts/imx7d-pico.dtsi b/arch/arm/boot/dts/imx7d-pico.dtsi index 3fd595a71202..6f50ebf31a0a 100644 --- a/arch/arm/boot/dts/imx7d-pico.dtsi +++ b/arch/arm/boot/dts/imx7d-pico.dtsi @@ -92,7 +92,7 @@ <&clks IMX7D_ENET1_TIME_ROOT_CLK>; assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>; assigned-clock-rates = <0>, <100000000>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-handle = <&ethphy0>; fsl,magic-packet; phy-reset-gpios = <&gpio6 11 GPIO_ACTIVE_LOW>; -- 2.17.1

6 years, 5 months

3
7
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror