August 2023 - Linux-stable-mirror

[PATCH mm-unstable] mm: multi-gen LRU: don't spin during memcg release

by T.J. Mercier

When a memcg is in the process of being released mem_cgroup_tryget will fail because its reference count has already reached 0. This can happen during reclaim if the memcg has already been offlined, and we reclaim all remaining pages attributed to the offlined memcg. shrink_many attempts to skip the empty memcg in this case, and continue reclaiming from the remaining memcgs in the old generation. If there is only one memcg remaining, or if all remaining memcgs are in the process of being released then shrink_many will spin until all memcgs have finished being released. The release occurs through a workqueue, so it can take a while before kswapd is able to make any further progress. This fix results in reductions in kswapd activity and direct reclaim in a test where 28 apps (working set size > total memory) are repeatedly launched in a random sequence: A B delta ratio(%) allocstall_movable 5962 3539 -2423 -40.64 allocstall_normal 2661 2417 -244 -9.17 kswapd_high_wmark_hit_quickly 53152 7594 -45558 -85.71 pageoutrun 57365 11750 -45615 -79.52 Fixes: e4dde56cd208 ("mm: multi-gen LRU: per-node lru_gen_folio lists") Cc: stable(a)vger.kernel.org Signed-off-by: T.J. Mercier <tjmercier(a)google.com> --- mm/vmscan.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 157ed68470ee..c7c149cb8d66 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -4856,16 +4856,17 @@ void lru_gen_release_memcg(struct mem_cgroup *memcg) spin_lock_irq(&pgdat->memcg_lru.lock); - VM_WARN_ON_ONCE(hlist_nulls_unhashed(&lruvec->lrugen.list)); + if (hlist_nulls_unhashed(&lruvec->lrugen.list)) + goto unlock; gen = lruvec->lrugen.gen; - hlist_nulls_del_rcu(&lruvec->lrugen.list); + hlist_nulls_del_init_rcu(&lruvec->lrugen.list); pgdat->memcg_lru.nr_memcgs[gen]--; if (!pgdat->memcg_lru.nr_memcgs[gen] && gen == get_memcg_gen(pgdat->memcg_lru.seq)) WRITE_ONCE(pgdat->memcg_lru.seq, pgdat->memcg_lru.seq + 1); - +unlock: spin_unlock_irq(&pgdat->memcg_lru.lock); } } @@ -5447,8 +5448,10 @@ static void shrink_many(struct pglist_data *pgdat, struct scan_control *sc) rcu_read_lock(); hlist_nulls_for_each_entry_rcu(lrugen, pos, &pgdat->memcg_lru.fifo[gen][bin], list) { - if (op) + if (op) { lru_gen_rotate_memcg(lruvec, op); + op = 0; + } mem_cgroup_put(memcg); @@ -5456,7 +5459,7 @@ static void shrink_many(struct pglist_data *pgdat, struct scan_control *sc) memcg = lruvec_memcg(lruvec); if (!mem_cgroup_tryget(memcg)) { - op = 0; + lru_gen_release_memcg(memcg); memcg = NULL; continue; } -- 2.41.0.640.ga95def55d0-goog

1 year, 4 months

2
1
0 0

RE: AWS RE:INVENT ATTENDEES EMAIL LIST- 2023

by Yenny Miller

Hi, Would you be interested in acquiring AWS reinvent/ Amazon Web Services Attendees Email List- 2023? List contains: Company Name, Contact Name, Title, Address, Street, City, Zip code, State, Country, Telephone, Email address and more, Number of Attendees: 45,369 Attendees List Cost: $2,099 Interested? Email me back; I would love to provide more information on the list. Kind Regards, Yenny Miller Marketing Coordinator

1 year, 4 months

1
0
0 0

Re: Fwd: [PATCH 3/3] pinctrl: tigerlake: Add Alder Lake-P ACPI ID

by Greg KH

On Mon, Aug 14, 2023 at 05:35:37PM +0300, Александр Офицеров wrote: > > > > -------- Перенаправленное сообщение -------- > Тема: [PATCH 3/3] pinctrl: tigerlake: Add Alder Lake-P ACPI ID > Дата: Thu, 10 Aug 2023 14:59:38 +0300 > От: Alexander Ofitserov <oficerovas(a)altlinux.org> > Кому: oficerovas(a)altlinux.org, Mika Westerberg > <mika.westerberg(a)linux.intel.com>, Andy Shevchenko <andy(a)kernel.org>, Linus > Walleij <linus.walleij(a)linaro.org> > Копия: linux-gpio(a)vger.kernel.org, linux-kernel(a)vger.kernel.org > > > > Intel Alder Lake-P has the same pin layout as the Tiget Lake-LP > so add support for this to the existing Tiger Lake driver. > > Signed-off-by: Alexander Ofitserov <oficerovas(a)altlinux.org> > --- > drivers/pinctrl/intel/pinctrl-tigerlake.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/intel/pinctrl-tigerlake.c > b/drivers/pinctrl/intel/pinctrl-tigerlake.c > index bed769d99b8be0..3ddaeffc04150a 100644 > --- a/drivers/pinctrl/intel/pinctrl-tigerlake.c > +++ b/drivers/pinctrl/intel/pinctrl-tigerlake.c > @@ -748,6 +748,7 @@ static const struct intel_pinctrl_soc_data tglh_soc_data > = { > static const struct acpi_device_id tgl_pinctrl_acpi_match[] = { > { "INT34C5", (kernel_ulong_t)&tgllp_soc_data }, > { "INT34C6", (kernel_ulong_t)&tglh_soc_data }, > + { "INTC1055", (kernel_ulong_t)&tgllp_soc_data }, > { } > }; > MODULE_DEVICE_TABLE(acpi, tgl_pinctrl_acpi_match); > > -- > 2.33.8 <formletter> This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. </formletter>

1 year, 4 months

1
0
0 0

Re: Fwd: [PATCH 2/3] mfd: intel-lpss: Add Alder Lake's PCI devices IDs

by Greg KH

On Mon, Aug 14, 2023 at 05:35:19PM +0300, Александр Офицеров wrote: > > > > -------- Перенаправленное сообщение -------- > Тема: [PATCH 2/3] mfd: intel-lpss: Add Alder Lake's PCI devices IDs > Дата: Thu, 10 Aug 2023 14:59:37 +0300 > От: Alexander Ofitserov <oficerovas(a)altlinux.org> > Кому: oficerovas(a)altlinux.org, Lee Jones <lee.jones(a)linaro.org> > Копия: linux-kernel(a)vger.kernel.org > > > > Intel Alder Lake PCH has the same LPSS as Intel Broxton. > Add the new IDs to the list of supported devices. > > Signed-off-by: Alexander Ofitserov <oficerovas(a)altlinux.org> <formletter> This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. </formletter>

1 year, 4 months

1
0
0 0

Re: Fwd: [PATCH 1/3] i2c: i801: Add support for Intel Alder Lake PCH

by Greg KH

On Mon, Aug 14, 2023 at 05:34:27PM +0300, Александр Офицеров wrote: > I'm sorry, this is my first time I ever send patches, I messed up with git > send-email, so you received cover letter with no patches. > > Now I'm sending you patches, that i wanted to send. <formletter> This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. </formletter>

1 year, 4 months

1
0
0 0

[PATCH 5.10 000/201] 5.10.190-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.10.190 release. There are 201 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Fri, 11 Aug 2023 10:36:10 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.190-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.10.190-rc1 Xu Yang <xu.yang_2(a)nxp.com> ARM: dts: nxp/imx6sll: fix wrong property name in usbphy node Andreas Kemnade <andreas(a)kemnade.info> ARM: dts: imx6sll: fixup of operating points Peng Fan <peng.fan(a)nxp.com> ARM: dts: imx: add usb alias Paul Fertser <fercerpav(a)gmail.com> wifi: mt76: mt7615: do not advertise 5 GHz on first phy of MT7615D (DBDC) Gustavo A. R. Silva <gustavoars(a)kernel.org> mt76: mt7615: Fix fall-through warnings for Clang Lorenzo Bianconi <lorenzo(a)kernel.org> mt76: move band capabilities in mt76_phy Namjae Jeon <linkinjeon(a)kernel.org> exfat: check if filename entries exceeds max filename length Yuezhang Mo <Yuezhang.Mo(a)sony.com> exfat: support dynamic allocate bh for exfat_entry_set_cache Hyeongseok Kim <hyeongseok(a)gmail.com> exfat: speed up iterate/lookup by fixing start point of traversing cluster chain Johan Hovold <johan+linaro(a)kernel.org> PM: sleep: wakeirq: fix wake irq arming Chunfeng Yun <chunfeng.yun(a)mediatek.com> PM / wakeirq: support enabling wake-up irq after runtime_suspend called Johan Hovold <johan+linaro(a)kernel.org> soundwire: fix enumeration completion Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> soundwire: bus: pm_runtime_request_resume on peripheral attachment Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> soundwire: bus: add better dev_dbg to track complete() calls Sean Christopherson <seanjc(a)google.com> selftests/rseq: Play nice with binaries statically linked against glibc 2.35+ Michael Jeanson <mjeanson(a)efficios.com> selftests/rseq: check if libc rseq support is registered Aneesh Kumar K.V <aneesh.kumar(a)linux.ibm.com> powerpc/mm/altmap: Fix altmap boundary check Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> mtd: rawnand: fsl_upm: Fix an off-by one test in fun_exec_op() Roger Quadros <rogerq(a)kernel.org> mtd: rawnand: omap_elm: Fix incorrect type in assignment Jan Kara <jack(a)suse.cz> ext2: Drop fragment support Jan Kara <jack(a)suse.cz> fs: Protect reconfiguration of sb read-write from racing writes Alan Stern <stern(a)rowland.harvard.edu> net: usbnet: Fix WARNING in usbnet_start_xmit/usb_submit_urb Sungwoo Kim <iam(a)sung-woo.kim> Bluetooth: L2CAP: Fix use-after-free in l2cap_sock_ready_cb Prince Kumar Maurya <princekumarmaurya06(a)gmail.com> fs/sysv: Null check to prevent null-ptr-deref bug Douglas Anderson <dianders(a)chromium.org> tracing: Fix sleeping while atomic in kdb ftdump Linus Torvalds <torvalds(a)linux-foundation.org> file: reinstate f_pos locking optimization for regular files Guchun Chen <guchun.chen(a)amd.com> drm/ttm: check null pointer before accessing when swapping Aleksa Sarai <cyphar(a)cyphar.com> open: make RESOLVE_CACHED correctly test for O_TMPFILE Jiri Olsa <jolsa(a)kernel.org> bpf: Disable preemption in bpf_event_output Laszlo Ersek <lersek(a)redhat.com> net: tap_open(): set sk_uid from current_fsuid() Laszlo Ersek <lersek(a)redhat.com> net: tun_chr_open(): set sk_uid from current_fsuid() Dinh Nguyen <dinguyen(a)kernel.org> arm64: dts: stratix10: fix incorrect I2C property for SCL signal Arseniy Krasnov <AVKrasnov(a)sberdevices.ru> mtd: rawnand: meson: fix OOB available bytes for ECC Olivier Maignial <olivier.maignial(a)hotmail.fr> mtd: spinand: toshiba: Fix ecc_get_status Sungjong Seo <sj1557.seo(a)samsung.com> exfat: release s_lock before calling dir_emit() gaoming <gaoming20(a)hihonor.com> exfat: use kvmalloc_array/kvfree instead of kmalloc_array/kfree Xiubo Li <xiubli(a)redhat.com> ceph: defer stopping mdsc delayed_work Ross Maynard <bids.7405(a)bigpond.com> USB: zaurus: Add ID for A-300/B-500/C-700 Ilya Dryomov <idryomov(a)gmail.com> libceph: fix potential hang in ceph_osdc_notify() Steffen Maier <maier(a)linux.ibm.com> scsi: zfcp: Defer fc_rport blocking until after ADISC response Eric Dumazet <edumazet(a)google.com> tcp_metrics: fix data-race in tcpm_suck_dst() vs fastopen Eric Dumazet <edumazet(a)google.com> tcp_metrics: annotate data-races around tm->tcpm_net Eric Dumazet <edumazet(a)google.com> tcp_metrics: annotate data-races around tm->tcpm_vals[] Eric Dumazet <edumazet(a)google.com> tcp_metrics: annotate data-races around tm->tcpm_lock Eric Dumazet <edumazet(a)google.com> tcp_metrics: annotate data-races around tm->tcpm_stamp Eric Dumazet <edumazet(a)google.com> tcp_metrics: fix addr_same() helper Jianbo Liu <jianbol(a)nvidia.com> net/mlx5: fs_core: Skip the FTs in the same FS_TYPE_PRIO_CHAINS fs_prio Jianbo Liu <jianbol(a)nvidia.com> net/mlx5: fs_core: Make find_closest_ft more generic Benjamin Poirier <bpoirier(a)nvidia.com> vxlan: Fix nexthop hash size Yue Haibing <yuehaibing(a)huawei.com> ip6mr: Fix skb_under_panic in ip6mr_cache_report() Alexandra Winter <wintera(a)linux.ibm.com> s390/qeth: Don't call dev_close/dev_open (DOWN/UP) Lin Ma <linma(a)zju.edu.cn> net: dcb: choose correct policy to parse DCB_ATTR_BCN Mark Brown <broonie(a)kernel.org> net: netsec: Ignore 'phy-mode' on SynQuacer in DT mode Dan Carpenter <dan.carpenter(a)linaro.org> net: ll_temac: fix error checking of irq_of_parse_and_map() Yang Yingliang <yangyingliang(a)huawei.com> net: ll_temac: Switch to use dev_err_probe() helper Tomas Glozar <tglozar(a)redhat.com> bpf: sockmap: Remove preempt_disable in sock_map_sk_acquire valis <sec(a)valis.email> net/sched: cls_route: No longer copy tcf_result on update to avoid use-after-free valis <sec(a)valis.email> net/sched: cls_fw: No longer copy tcf_result on update to avoid use-after-free valis <sec(a)valis.email> net/sched: cls_u32: No longer copy tcf_result on update to avoid use-after-free Eric Dumazet <edumazet(a)google.com> net: add missing data-race annotation for sk_ll_usec Eric Dumazet <edumazet(a)google.com> net: add missing data-race annotations around sk->sk_peek_off Eric Dumazet <edumazet(a)google.com> net: add missing READ_ONCE(sk->sk_rcvbuf) annotation Eric Dumazet <edumazet(a)google.com> net: add missing READ_ONCE(sk->sk_sndbuf) annotation Eric Dumazet <edumazet(a)google.com> net: add missing READ_ONCE(sk->sk_rcvlowat) annotation Eric Dumazet <edumazet(a)google.com> net: annotate data-races around sk->sk_max_pacing_rate Chengfeng Ye <dg573847474(a)gmail.com> mISDN: hfcpci: Fix potential deadlock on &hc->lock Jamal Hadi Salim <jhs(a)mojatatu.com> net: sched: cls_u32: Fix match key mis-addressing Georg Müller <georgmueller(a)gmx.net> perf test uprobe_from_different_cu: Skip if there is no gcc Yuanjun Gong <ruc_gongyuanjun(a)163.com> net: dsa: fix value check in bcm_sf2_sw_probe() Lin Ma <linma(a)zju.edu.cn> rtnetlink: let rtnl_bridge_setlink checks IFLA_BRIDGE_MODE length Lin Ma <linma(a)zju.edu.cn> bpf: Add length check for SK_DIAG_BPF_STORAGE_REQ_MAP_FD parsing Yuanjun Gong <ruc_gongyuanjun(a)163.com> net/mlx5e: fix return value check in mlx5e_ipsec_remove_trailer() Zhengchao Shao <shaozhengchao(a)huawei.com> net/mlx5: DR, fix memory leak in mlx5dr_cmd_create_reformat_ctx Ilan Peer <ilan.peer(a)intel.com> wifi: cfg80211: Fix return value in scan logic Heiko Carstens <hca(a)linux.ibm.com> KVM: s390: fix sthyi error handling ndesaulniers(a)google.com <ndesaulniers(a)google.com> word-at-a-time: use the same return type for has_zero regardless of endianness Hugo Villeneuve <hvilleneuve(a)dimonoff.com> arm64: dts: imx8mn-var-som: add missing pull-up for onboard PHY reset pinmux Bart Van Assche <bvanassche(a)acm.org> loop: Select I/O scheduler 'none' from inside add_disk() Peter Zijlstra <peterz(a)infradead.org> perf: Fix function pointer case Jens Axboe <axboe(a)kernel.dk> io_uring: gate iowait schedule on having pending requests Nadav Amit <namit(a)vmware.com> x86/kprobes: Fix JNG/JNLE emulation Masami Hiramatsu (Google) <mhiramat(a)kernel.org> x86/kprobes: Update kcb status flag after singlestepping Wei Yongjun <weiyongjun1(a)huawei.com> x86/kprobes: Move 'inline' to the beginning of the kprobe_is_ss() declaration Masami Hiramatsu <mhiramat(a)kernel.org> x86/kprobes: Fix to identify indirect jmp and others using range case Masami Hiramatsu <mhiramat(a)kernel.org> x86/kprobes: Use int3 instead of debug trap for single-step Masami Hiramatsu <mhiramat(a)kernel.org> x86/kprobes: Identify far indirect JMP correctly Masami Hiramatsu <mhiramat(a)kernel.org> x86/kprobes: Retrieve correct opcode for group instruction Masami Hiramatsu <mhiramat(a)kernel.org> x86/kprobes: Do not decode opcode in resume_execution() Gustavo A. R. Silva <gustavoars(a)kernel.org> kprobes/x86: Fix fall-through warnings for Clang Thomas Petazzoni <thomas.petazzoni(a)bootlin.com> ASoC: cs42l51: fix driver to properly autoload with automatic module loading Jens Axboe <axboe(a)kernel.dk> io_uring: treat -EAGAIN for REQ_F_NOWAIT as final for io-wq Matthieu Baerts <matthieu.baerts(a)tessares.net> selftests: mptcp: depend on SYN_COOKIES Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> cpufreq: intel_pstate: Drop ACPI _PSS states table patching Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> ACPI: processor: perflib: Avoid updating frequency QoS unnecessarily Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> ACPI: processor: perflib: Use the "no limit" frequency QoS Christian König <christian.koenig(a)amd.com> drm/ttm: make ttm_bo_unpin more defensive Joe Thornber <ejt(a)redhat.com> dm cache policy smq: ensure IO doesn't prevent cleaner policy progress Xiubo Li <xiubli(a)redhat.com> ceph: never send metrics if disable_send_metrics is set Mark Brown <broonie(a)kernel.org> ASoC: wm8904: Fill the cache for WM8904_ADC_TEST_0 register Stefan Haberland <sth(a)linux.ibm.com> s390/dasd: fix hanging device after quiesce/resume Jason Wang <jasowang(a)redhat.com> virtio-net: fix race between set queues and probe Filipe Manana <fdmanana(a)suse.com> btrfs: check if the transaction was aborted at btrfs_wait_for_commit() Larry Finger <Larry.Finger(a)lwfinger.net> staging: r8712: Fix memory leak in _r8712_init_xmit_priv() Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> staging: rtl8712: Use constants from <linux/ieee80211.h> Sean Christopherson <seanjc(a)google.com> KVM: VMX: Don't fudge CR0 and CR4 for restricted L2 guest Sean Christopherson <seanjc(a)google.com> KVM: nVMX: Do not clear CR3 load/store exiting bits if L1 wants 'em Sean Christopherson <seanjc(a)google.com> KVM: VMX: Fold ept_update_paging_mode_cr0() back into vmx_set_cr0() Sean Christopherson <seanjc(a)google.com> KVM: VMX: Invert handling of CR0.WP for EPT without unrestricted guest Marc Zyngier <maz(a)kernel.org> irqchip/gic-v4.1: Properly lock VPEs when doing a directLPI invalidation Jonas Gorski <jonas.gorski(a)gmail.com> irq-bcm6345-l1: Do not assume a fixed block to cpu mapping Alexander Steffen <Alexander.Steffen(a)infineon.com> tpm_tis: Explicitly check for error code Trond Myklebust <trond.myklebust(a)hammerspace.com> nfsd: Remove incorrect check in nfsd4_validate_stateid Christian Brauner <brauner(a)kernel.org> file: always lock position for FMODE_ATOMIC_POS Filipe Manana <fdmanana(a)suse.com> btrfs: check for commit error at btrfs_attach_transaction_barrier() Gilles Buloz <Gilles.Buloz(a)kontron.com> hwmon: (nct7802) Fix for temp6 (PECI1) processed even if PECI1 disabled Luka Guzenko <l.guzenko(a)web.de> ALSA: hda/relatek: Enable Mute LED on HP 250 G8 Chaoyuan Peng <hedonistsmith(a)gmail.com> tty: n_gsm: fix UAF in gsm_cleanup_mux Zhang Shurong <zhang_shurong(a)foxmail.com> staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext() Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Documentation: security-bugs.rst: clarify CVE handling Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Documentation: security-bugs.rst: update preferences when dealing with the linux-distros group Dan Carpenter <dan.carpenter(a)linaro.org> Revert "usb: xhci: tegra: Fix error check" Ricardo Ribalda <ribalda(a)chromium.org> usb: xhci-mtk: set the dma max_seg_size Łukasz Bartosik <lb(a)semihalf.com> USB: quirks: add quirk for Focusrite Scarlett Guiting Shen <aarongt.shen(a)gmail.com> usb: ohci-at91: Fix the unhandle interrupt when resume Jisheng Zhang <jszhang(a)kernel.org> usb: dwc3: don't reset device side if dwc3 was configured as host-only Gratian Crisan <gratian.crisan(a)ni.com> usb: dwc3: pci: skip BYT GPIO lookup table for hardwired phy Jakub Vanek <linuxtardis(a)gmail.com> Revert "usb: dwc3: core: Enable AutoRetry feature in the controller" Marc Kleine-Budde <mkl(a)pengutronix.de> can: gs_usb: gs_can_close(): add missing set of CAN state to CAN_STATE_STOPPED Johan Hovold <johan(a)kernel.org> USB: serial: simple: sort driver entries Oliver Neukum <oneukum(a)suse.com> USB: serial: simple: add Kaufmann RKS+CAN VCP Mohsen Tahmasebi <moh53n(a)moh53n.ir> USB: serial: option: add Quectel EC200A module support Jerry Meng <jerry-meng(a)foxmail.com> USB: serial: option: support Quectel EM060K_128 Samuel Holland <samuel.holland(a)sifive.com> serial: sifive: Fix sifive_serial_console_setup() section Ruihong Luo <colorsu1922(a)gmail.com> serial: 8250_dw: Preserve original value of DLF register Johan Hovold <johan+linaro(a)kernel.org> serial: qcom-geni: drop bogus runtime pm state update Zqiang <qiang.zhang1211(a)gmail.com> USB: gadget: Fix the memory leak in raw_gadget driver Dan Carpenter <dan.carpenter(a)linaro.org> Revert "usb: gadget: tegra-xudc: Fix error check in tegra_xudc_powerdomain_init()" Zheng Yejian <zhengyejian1(a)huawei.com> tracing: Fix warning in trace_buffered_event_disable() Zheng Yejian <zhengyejian1(a)huawei.com> ring-buffer: Fix wrong stat of cpu_buffer->read Arnd Bergmann <arnd(a)arndb.de> ata: pata_ns87415: mark ns87560_tf_read static Yu Kuai <yukuai3(a)huawei.com> dm raid: protect md_stop() with 'reconfig_mutex' Yu Kuai <yukuai3(a)huawei.com> dm raid: clean up four equivalent goto tags in raid_ctr() Yu Kuai <yukuai3(a)huawei.com> dm raid: fix missing reconfig_mutex unlock in raid_ctr() error paths Bart Van Assche <bvanassche(a)acm.org> block: Fix a source code comment in include/uapi/linux/blkzoned.h Matus Gajdos <matuszpd(a)gmail.com> ASoC: fsl_spdif: Silence output on stop Gaosheng Cui <cuigaosheng1(a)huawei.com> drm/msm: Fix IS_ERR_OR_NULL() vs NULL check in a5xx_submit_in_rb() Thomas Bogendoerfer <tbogendoerfer(a)suse.de> RDMA/mthca: Fix crash when polling CQ for shared QPs Rob Clark <robdclark(a)chromium.org> drm/msm/adreno: Fix snapshot BINDLESS_DATA size Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> drm/msm/dpu: drop enum dpu_core_perf_data_bus_id Dan Carpenter <dan.carpenter(a)linaro.org> RDMA/mlx4: Make check for invalid flags stricter Fedor Pchelkin <pchelkin(a)ispras.ru> tipc: stop tipc crypto on failure in tipc_node_create Yuanjun Gong <ruc_gongyuanjun(a)163.com> tipc: check return value of pskb_trim() Yuanjun Gong <ruc_gongyuanjun(a)163.com> benet: fix return value check in be_lancer_xmit_workarounds() Lin Ma <linma(a)zju.edu.cn> net/sched: mqprio: Add length check for TCA_MQPRIO_{MAX/MIN}_RATE64 Vladimir Oltean <vladimir.oltean(a)nxp.com> net/sched: mqprio: add extack to mqprio_parse_nlattr() Vladimir Oltean <vladimir.oltean(a)nxp.com> net/sched: mqprio: refactor nlattr parsing to a separate function Pablo Neira Ayuso <pablo(a)netfilter.org> netfilter: nf_tables: disallow rule addition to bound chain via NFTA_RULE_CHAIN_ID Pablo Neira Ayuso <pablo(a)netfilter.org> netfilter: nf_tables: skip immediate deactivate in _PREPARE_ERROR Pablo Neira Ayuso <pablo(a)netfilter.org> netfilter: nftables: add helper function to validate set element data Florian Westphal <fw(a)strlen.de> netfilter: nft_set_rbtree: fix overlap expiration walk Maxim Mikityanskiy <maxtram95(a)gmail.com> platform/x86: msi-laptop: Fix rfkill out-of-sync on MSI Wind U100 Hangbin Liu <liuhangbin(a)gmail.com> team: reset team's flags when down link is P2P device Hangbin Liu <liuhangbin(a)gmail.com> bonding: reset bond's flags when down link is P2P device Jedrzej Jagielski <jedrzej.jagielski(a)intel.com> ice: Fix memory management in ice_ethtool_fdir.c Stewart Smith <trawets(a)amazon.com> tcp: Reduce chance of collisions in inet6_hashfn(). Maciej Żenczykowski <maze(a)google.com> ipv6 addrconf: fix bug where deleting a mngtmpaddr can create a new temporary address Yuanjun Gong <ruc_gongyuanjun(a)163.com> ethernet: atheros: fix return value check in atl1e_tso_csum() Harshit Mogalapalli <harshit.m.mogalapalli(a)oracle.com> phy: hisilicon: Fix an out of bounds check in hisi_inno_phy_probe() Jiri Benc <jbenc(a)redhat.com> vxlan: calculate correct header length for GPE Roopa Prabhu <roopa(a)nvidia.com> vxlan: move to its own directory Jijie Shao <shaojijie(a)huawei.com> net: hns3: fix wrong bw weight of disabled tc issue Guangbin Huang <huangguangbin2(a)huawei.com> net: hns3: reconstruct function hclge_ets_validate() Jiawen Wu <jiawenwu(a)trustnetic.com> net: phy: marvell10g: fix 88x3310 power up Wang Ming <machel(a)vivo.com> i40e: Fix an NULL vs IS_ERR() bug for debugfs_create_dir() Sakari Ailus <sakari.ailus(a)linux.intel.com> media: staging: atomisp: select V4L2_FWNODE Adrien Thierry <athierry(a)redhat.com> phy: qcom-snps-femto-v2: properly enable ref clock Adrien Thierry <athierry(a)redhat.com> phy: qcom-snps-femto-v2: keep cfg_ahb_clk enabled during runtime suspend Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> phy: qcom-snps: correct struct qcom_snps_hsphy kerneldoc Yuan Can <yuancan(a)huawei.com> phy: qcom-snps: Use dev_err_probe() to simplify code Chao Yu <chao(a)kernel.org> ext4: fix to check return value of freeze_bdev() in ext4_shutdown() Heiner Kallweit <hkallweit1(a)gmail.com> pwm: meson: fix handling of period/duty if greater than UINT_MAX Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> pwm: meson: Simplify duplicated per-channel tracking Masami Hiramatsu <mhiramat(a)kernel.org> tracing: Show real address for trace event arguments Christian König <christian.koenig(a)amd.com> drm/ttm: never consider pinned BOs for eviction&swap Christian König <christian.koenig(a)amd.com> drm/ttm: add ttm_bo_pin()/ttm_bo_unpin() v2 Alexander Aring <aahringo(a)redhat.com> fs: dlm: interrupt posix locks only when process is killed Alexander Aring <aahringo(a)redhat.com> dlm: rearrange async condition return Alexander Aring <aahringo(a)redhat.com> dlm: cleanup plock_op vs plock_xop Ilpo Järvinen <ilpo.jarvinen(a)linux.intel.com> PCI/ASPM: Avoid link retraining race Ilpo Järvinen <ilpo.jarvinen(a)linux.intel.com> PCI/ASPM: Factor out pcie_wait_for_retrain() Bjorn Helgaas <bhelgaas(a)google.com> PCI/ASPM: Return 0 or -ETIMEDOUT from pcie_retrain_link() Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> i2c: nomadik: Remove a useless call in the remove function Andi Shyti <andi.shyti(a)kernel.org> i2c: nomadik: Use devm_clk_get_enabled() Andi Shyti <andi.shyti(a)kernel.org> i2c: nomadik: Remove unnecessary goto label Markus Elfring <elfring(a)users.sourceforge.net> i2c: Improve size determinations Markus Elfring <elfring(a)users.sourceforge.net> i2c: Delete error messages for failed memory allocations Filipe Manana <fdmanana(a)suse.com> btrfs: fix extent buffer leak after tree mod log failure at split_node() Filipe Manana <fdmanana(a)suse.com> btrfs: fix race between quota disable and relocation Hans de Goede <hdegoede(a)redhat.com> gpio: tps68470: Make tps68470_gpio_output() always set the initial value Ondrej Mosnacek <omosnace(a)redhat.com> io_uring: don't audit the capability check in io_uring_create() Claudio Imbrenda <imbrenda(a)linux.ibm.com> KVM: s390: pv: fix index value of replaced ASCE ------------- Diffstat: Documentation/admin-guide/security-bugs.rst | 37 +- Makefile | 4 +- arch/arm/boot/dts/imx6qdl.dtsi | 4 + arch/arm/boot/dts/imx6sl.dtsi | 3 + arch/arm/boot/dts/imx6sll.dtsi | 26 +- arch/arm/boot/dts/imx6sx.dtsi | 3 + arch/arm/boot/dts/imx6ul.dtsi | 2 + arch/arm/boot/dts/imx7d.dtsi | 6 + arch/arm/boot/dts/imx7s.dtsi | 2 + .../boot/dts/altera/socfpga_stratix10_socdk.dts | 2 +- .../dts/altera/socfpga_stratix10_socdk_nand.dts | 2 +- arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 2 +- arch/powerpc/include/asm/word-at-a-time.h | 2 +- arch/powerpc/mm/init_64.c | 3 +- arch/s390/kernel/sthyi.c | 6 +- arch/s390/kvm/intercept.c | 9 +- arch/s390/mm/gmap.c | 1 + arch/x86/include/asm/kprobes.h | 24 +- arch/x86/kernel/kprobes/core.c | 639 +++++++++++++-------- arch/x86/kernel/traps.c | 3 - arch/x86/kvm/vmx/vmx.c | 87 +-- drivers/acpi/processor_perflib.c | 42 +- drivers/ata/pata_ns87415.c | 2 +- drivers/base/power/power.h | 8 +- drivers/base/power/runtime.c | 6 +- drivers/base/power/wakeirq.c | 111 +++- drivers/block/loop.c | 3 +- drivers/char/tpm/tpm_tis_core.c | 10 +- drivers/cpufreq/intel_pstate.c | 14 - drivers/gpio/gpio-tps68470.c | 6 +- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 13 - drivers/gpu/drm/ttm/ttm_bo.c | 16 +- drivers/gpu/drm/ttm/ttm_bo_util.c | 2 +- drivers/hwmon/nct7802.c | 2 +- drivers/i2c/busses/i2c-ibm_iic.c | 4 +- drivers/i2c/busses/i2c-nomadik.c | 42 +- drivers/i2c/busses/i2c-sh7760.c | 3 +- drivers/i2c/busses/i2c-tiny-usb.c | 4 +- drivers/infiniband/hw/mlx4/qp.c | 18 +- drivers/infiniband/hw/mthca/mthca_qp.c | 2 +- drivers/irqchip/irq-bcm6345-l1.c | 14 +- drivers/irqchip/irq-gic-v3-its.c | 75 ++- drivers/isdn/hardware/mISDN/hfcpci.c | 10 +- drivers/md/dm-cache-policy-smq.c | 28 +- drivers/md/dm-raid.c | 20 +- drivers/md/md.c | 2 + drivers/mtd/nand/raw/fsl_upm.c | 2 +- drivers/mtd/nand/raw/meson_nand.c | 3 +- drivers/mtd/nand/raw/omap_elm.c | 24 +- drivers/mtd/nand/spi/toshiba.c | 4 +- drivers/net/Makefile | 2 +- drivers/net/bonding/bond_main.c | 5 + drivers/net/can/usb/gs_usb.c | 2 + drivers/net/dsa/bcm_sf2.c | 8 +- drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 7 +- drivers/net/ethernet/emulex/benet/be_main.c | 3 +- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c | 60 +- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 3 +- drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 2 +- drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c | 26 +- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +- .../mellanox/mlx5/core/en_accel/ipsec_rxtx.c | 4 +- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 105 +++- .../ethernet/mellanox/mlx5/core/steering/dr_cmd.c | 5 +- drivers/net/ethernet/socionext/netsec.c | 11 + drivers/net/ethernet/xilinx/ll_temac_main.c | 16 +- drivers/net/phy/marvell10g.c | 7 + drivers/net/tap.c | 2 +- drivers/net/team/team.c | 9 + drivers/net/tun.c | 2 +- drivers/net/usb/cdc_ether.c | 21 + drivers/net/usb/usbnet.c | 6 + drivers/net/usb/zaurus.c | 21 + drivers/net/virtio_net.c | 4 +- drivers/net/vxlan/Makefile | 7 + drivers/net/{vxlan.c => vxlan/vxlan_core.c} | 23 +- drivers/net/wireless/mediatek/mt76/mac80211.c | 8 +- drivers/net/wireless/mediatek/mt76/mt76.h | 2 +- drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c | 2 +- drivers/net/wireless/mediatek/mt76/mt7615/dma.c | 2 +- drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c | 22 +- drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c | 6 +- drivers/net/wireless/mediatek/mt76/mt76x0/init.c | 4 +- drivers/net/wireless/mediatek/mt76/mt76x0/phy.c | 4 +- .../net/wireless/mediatek/mt76/mt76x02_eeprom.c | 8 +- drivers/net/wireless/mediatek/mt76/mt7915/eeprom.c | 8 +- drivers/net/wireless/mediatek/mt76/mt7915/init.c | 5 +- drivers/pci/pcie/aspm.c | 55 +- drivers/phy/hisilicon/phy-hisi-inno-usb2.c | 2 +- drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c | 86 +-- drivers/platform/x86/msi-laptop.c | 8 +- drivers/pwm/pwm-meson.c | 25 +- drivers/s390/block/dasd_ioctl.c | 1 + drivers/s390/net/qeth_core.h | 1 - drivers/s390/net/qeth_core_main.c | 2 - drivers/s390/net/qeth_l2_main.c | 9 +- drivers/s390/net/qeth_l3_main.c | 8 +- drivers/s390/scsi/zfcp_fc.c | 6 +- drivers/soundwire/bus.c | 31 +- drivers/staging/ks7010/ks_wlan_net.c | 6 +- drivers/staging/media/atomisp/Kconfig | 1 + drivers/staging/rtl8712/ieee80211.c | 12 +- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 8 +- drivers/staging/rtl8712/rtl871x_mlme.c | 10 +- drivers/staging/rtl8712/rtl871x_xmit.c | 46 +- drivers/staging/rtl8712/wifi.h | 15 - drivers/staging/rtl8712/xmit_linux.c | 6 + drivers/tty/n_gsm.c | 4 +- drivers/tty/serial/8250/8250_dwlib.c | 6 +- drivers/tty/serial/qcom_geni_serial.c | 7 - drivers/tty/serial/sifive.c | 2 +- drivers/usb/core/quirks.c | 4 + drivers/usb/dwc3/core.c | 20 +- drivers/usb/dwc3/core.h | 3 - drivers/usb/dwc3/dwc3-pci.c | 6 +- drivers/usb/gadget/legacy/raw_gadget.c | 12 +- drivers/usb/gadget/udc/tegra-xudc.c | 8 +- drivers/usb/host/ohci-at91.c | 8 +- drivers/usb/host/xhci-mtk.c | 1 + drivers/usb/host/xhci-tegra.c | 8 +- drivers/usb/serial/option.c | 6 + drivers/usb/serial/usb-serial-simple.c | 73 +-- fs/btrfs/ctree.c | 2 + fs/btrfs/qgroup.c | 18 +- fs/btrfs/transaction.c | 10 +- fs/ceph/mds_client.c | 4 +- fs/ceph/mds_client.h | 5 + fs/ceph/metric.c | 2 +- fs/ceph/super.c | 10 + fs/dlm/plock.c | 100 ++-- fs/exfat/balloc.c | 6 +- fs/exfat/dir.c | 70 ++- fs/exfat/exfat_fs.h | 7 +- fs/exfat/namei.c | 9 +- fs/ext2/ext2.h | 12 - fs/ext2/super.c | 23 +- fs/ext4/ioctl.c | 5 +- fs/file.c | 24 +- fs/nfsd/nfs4state.c | 2 - fs/open.c | 2 +- fs/super.c | 11 +- fs/sysv/itree.c | 4 + include/asm-generic/word-at-a-time.h | 2 +- include/drm/ttm/ttm_bo_api.h | 28 + include/linux/pm_wakeirq.h | 9 +- include/linux/trace_events.h | 4 + include/net/ipv6.h | 8 +- include/net/vxlan.h | 17 +- include/trace/trace_events.h | 2 +- include/uapi/linux/blkzoned.h | 10 +- io_uring/io_uring.c | 33 +- kernel/events/core.c | 8 +- kernel/trace/bpf_trace.c | 6 +- kernel/trace/ring_buffer.c | 22 +- kernel/trace/trace.c | 76 ++- kernel/trace/trace.h | 2 + kernel/trace/trace_events.c | 14 +- kernel/trace/trace_output.c | 12 +- net/bluetooth/l2cap_sock.c | 2 + net/ceph/osd_client.c | 20 +- net/core/bpf_sk_storage.c | 5 +- net/core/rtnetlink.c | 8 +- net/core/sock.c | 21 +- net/core/sock_map.c | 2 - net/dcb/dcbnl.c | 2 +- net/ipv4/tcp_metrics.c | 70 ++- net/ipv6/addrconf.c | 14 +- net/ipv6/ip6mr.c | 2 +- net/netfilter/nf_tables_api.c | 20 +- net/netfilter/nft_immediate.c | 27 +- net/netfilter/nft_set_rbtree.c | 20 +- net/sched/cls_fw.c | 1 - net/sched/cls_route.c | 1 - net/sched/cls_u32.c | 57 +- net/sched/sch_mqprio.c | 144 +++-- net/tipc/crypto.c | 3 +- net/tipc/node.c | 2 +- net/unix/af_unix.c | 2 +- net/wireless/scan.c | 2 +- sound/pci/hda/patch_realtek.c | 1 + sound/soc/codecs/cs42l51-i2c.c | 6 + sound/soc/codecs/cs42l51.c | 7 - sound/soc/codecs/cs42l51.h | 1 - sound/soc/codecs/wm8904.c | 3 + sound/soc/fsl/fsl_spdif.c | 2 + .../tests/shell/test_uprobe_from_different_cu.sh | 8 +- tools/testing/selftests/net/mptcp/config | 1 + tools/testing/selftests/rseq/rseq.c | 31 +- 190 files changed, 2159 insertions(+), 1206 deletions(-)

1 year, 4 months

6
206
0 0

[PATCH v0 9/9] media: qcom: camss: Fix csid-gen2 for test pattern generator

by Bryan O'Donoghue

From: Andrey Konovalov <andrey.konovalov(a)linaro.org> In the current driver csid Test Pattern Generator (TPG) doesn't work. This change: - fixes writing frame width and height values into CSID_TPG_DT_n_CFG_0 - fixes the shift by one between test_pattern control value and the actual pattern. So that TPG starts working, but with the below limitations: - only test_pattern=9 works as it should - test_pattern=8 and test_pattern=7 produce black frame (all zeroes) - the rest of test_pattern's don't work (yavta doesn't get the data) - regardless of the CFA pattern set by 'media-ctl -V' the actual pixel order is always the same (RGGB for any RAW8 or RAW10P format in 4608x2592 resolution). Tested with: RAW10P format, VC0: media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4608x2592 field:none]' media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4608x2592 field:none]' media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]' v4l2-ctl -d /dev/v4l-subdev6 -c test_pattern=9 yavta -B capture-mplane --capture=3 -n 3 -f SRGGB10P -s 4608x2592 /dev/video0 RAW10P format, VC1: media-ctl -V '"msm_csid0":2[fmt:SRGGB10/4608x2592 field:none]' media-ctl -V '"msm_vfe0_rdi1":0[fmt:SRGGB10/4608x2592 field:none]' media-ctl -l '"msm_csid0":2->"msm_vfe0_rdi1":0[1]' v4l2-ctl -d /dev/v4l-subdev6 -c test_pattern=9 yavta -B capture-mplane --capture=3 -n 3 -f SRGGB10P -s 4608x2592 /dev/video1 RAW8 format, VC0: media-ctl --reset media-ctl -V '"msm_csid0":0[fmt:SRGGB8/4608x2592 field:none]' media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB8/4608x2592 field:none]' media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]' yavta -B capture-mplane --capture=3 -n 3 -f SRGGB8 -s 4608x2592 /dev/video0 Fixes: eebe6d00e9bf ("media: camss: Add support for CSID hardware version Titan 170") Cc: stable(a)vger.kernel.org Signed-off-by: Andrey Konovalov <andrey.konovalov(a)linaro.org> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue(a)linaro.org> --- drivers/media/platform/qcom/camss/camss-csid-gen2.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss-csid-gen2.c b/drivers/media/platform/qcom/camss/camss-csid-gen2.c index 9ac253111e572..b0890259af4ee 100644 --- a/drivers/media/platform/qcom/camss/camss-csid-gen2.c +++ b/drivers/media/platform/qcom/camss/camss-csid-gen2.c @@ -355,9 +355,6 @@ static void __csid_configure_stream(struct csid_device *csid, u8 enable, u8 vc) u8 dt_id = vc * 4; if (tg->enabled) { - /* Config Test Generator */ - vc = 0xa; - /* configure one DT, infinite frames */ val = vc << TPG_VC_CFG0_VC_NUM; val |= INTELEAVING_MODE_ONE_SHOT << TPG_VC_CFG0_LINE_INTERLEAVING_MODE; @@ -370,14 +367,14 @@ static void __csid_configure_stream(struct csid_device *csid, u8 enable, u8 vc) writel_relaxed(0x12345678, csid->base + CSID_TPG_LFSR_SEED); - val = input_format->height & 0x1fff << TPG_DT_n_CFG_0_FRAME_HEIGHT; - val |= input_format->width & 0x1fff << TPG_DT_n_CFG_0_FRAME_WIDTH; + val = (input_format->height & 0x1fff) << TPG_DT_n_CFG_0_FRAME_HEIGHT; + val |= (input_format->width & 0x1fff) << TPG_DT_n_CFG_0_FRAME_WIDTH; writel_relaxed(val, csid->base + CSID_TPG_DT_n_CFG_0(0)); val = format->data_type << TPG_DT_n_CFG_1_DATA_TYPE; writel_relaxed(val, csid->base + CSID_TPG_DT_n_CFG_1(0)); - val = tg->mode << TPG_DT_n_CFG_2_PAYLOAD_MODE; + val = (tg->mode - 1) << TPG_DT_n_CFG_2_PAYLOAD_MODE; val |= 0xBE << TPG_DT_n_CFG_2_USER_SPECIFIED_PAYLOAD; val |= format->decode_format << TPG_DT_n_CFG_2_ENCODE_FORMAT; writel_relaxed(val, csid->base + CSID_TPG_DT_n_CFG_2(0)); -- 2.41.0

1 year, 4 months

1
0
0 0

[PATCH v0 6/9] media: qcom: camss: Fix missing vfe_lite clocks check

by Bryan O'Donoghue

check_clock doesn't account for vfe_lite which means that vfe_lite will never get validated by this routine. Add the clock name to the expected set to remediate. Fixes: 7319cdf189bb ("media: camss: Add support for VFE hardware version Titan 170") Cc: stable(a)vger.kernel.org Signed-off-by: Bryan O'Donoghue <bryan.odonoghue(a)linaro.org> --- drivers/media/platform/qcom/camss/camss-vfe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c index 938f373bcd1fd..b021f81cef123 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe.c +++ b/drivers/media/platform/qcom/camss/camss-vfe.c @@ -535,7 +535,8 @@ static int vfe_check_clock_rates(struct vfe_device *vfe) struct camss_clock *clock = &vfe->clock[i]; if (!strcmp(clock->name, "vfe0") || - !strcmp(clock->name, "vfe1")) { + !strcmp(clock->name, "vfe1") || + !strcmp(clock->name, "vfe_lite")) { u64 min_rate = 0; unsigned long rate; -- 2.41.0

1 year, 4 months

1
0
0 0

[PATCH v0 5/9] media: qcom: camss: Fix VFE-480 vfe_disable_output()

by Bryan O'Donoghue

vfe-480 is copied from vfe-17x and has the same racy idle timeout bug as in 17x. Fix the vfe_disable_output() logic to no longer be racy and to conform to the 17x way of quiescing and then resetting the VFE. Fixes: 4edc8eae715c ("media: camss: Add initial support for VFE hardware version Titan 480") Cc: stable(a)vger.kernel.org Signed-off-by: Bryan O'Donoghue <bryan.odonoghue(a)linaro.org> --- .../media/platform/qcom/camss/camss-vfe-480.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss-vfe-480.c b/drivers/media/platform/qcom/camss/camss-vfe-480.c index f70aad2e8c237..a64d660abc538 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-480.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-480.c @@ -334,28 +334,15 @@ static int vfe_disable_output(struct vfe_line *line) struct vfe_output *output = &line->output; unsigned long flags; unsigned int i; - bool done; - int timeout = 0; - - do { - spin_lock_irqsave(&vfe->output_lock, flags); - done = !output->gen2.active_num; - spin_unlock_irqrestore(&vfe->output_lock, flags); - usleep_range(10000, 20000); - - if (timeout++ == 100) { - dev_err(vfe->camss->dev, "VFE idle timeout - resetting\n"); - vfe_reset(vfe); - output->gen2.active_num = 0; - return 0; - } - } while (!done); spin_lock_irqsave(&vfe->output_lock, flags); for (i = 0; i < output->wm_num; i++) vfe_wm_stop(vfe, output->wm_idx[i]); + output->gen2.active_num = 0; spin_unlock_irqrestore(&vfe->output_lock, flags); + vfe_reset(vfe); + return 0; } -- 2.41.0

1 year, 4 months

1
0
0 0

[PATCH v0 4/9] media: qcom: camss: Fix VFE-17x vfe_disable_output()

by Bryan O'Donoghue

There are two problems with the current vfe_disable_output() routine. Firstly we rightly use a spinlock to protect output->gen2.active_num everywhere except for in the IDLE timeout path of vfe_disable_output(). Even if that is not racy "in practice" somehow it is by happenstance not by design. Secondly we do not get consistent behaviour from this routine. On sc8280xp 50% of the time I get "VFE idle timeout - resetting". In this case the subsequent capture will succeed. The other 50% of the time, we don't hit the idle timeout, never do the VFE reset and subsequent captures stall indefinitely. Rewrite the vfe_disable_output() routine to - Quiesce write masters with vfe_wm_stop() - Set active_num = 0 remembering to hold the spinlock when we do so followed by - Reset the VFE Testing on sc8280xp and sdm845 shows this to be a valid fix. Fixes: 7319cdf189bb ("media: camss: Add support for VFE hardware version Titan 170") Cc: stable(a)vger.kernel.org Signed-off-by: Bryan O'Donoghue <bryan.odonoghue(a)linaro.org> --- .../media/platform/qcom/camss/camss-vfe-170.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss-vfe-170.c b/drivers/media/platform/qcom/camss/camss-vfe-170.c index 02494c89da91c..ae9137633c301 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-170.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-170.c @@ -500,28 +500,15 @@ static int vfe_disable_output(struct vfe_line *line) struct vfe_output *output = &line->output; unsigned long flags; unsigned int i; - bool done; - int timeout = 0; - - do { - spin_lock_irqsave(&vfe->output_lock, flags); - done = !output->gen2.active_num; - spin_unlock_irqrestore(&vfe->output_lock, flags); - usleep_range(10000, 20000); - - if (timeout++ == 100) { - dev_err(vfe->camss->dev, "VFE idle timeout - resetting\n"); - vfe_reset(vfe); - output->gen2.active_num = 0; - return 0; - } - } while (!done); spin_lock_irqsave(&vfe->output_lock, flags); for (i = 0; i < output->wm_num; i++) vfe_wm_stop(vfe, output->wm_idx[i]); + output->gen2.active_num = 0; spin_unlock_irqrestore(&vfe->output_lock, flags); + vfe_reset(vfe); + return 0; } -- 2.41.0

1 year, 4 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror August 2023