July 2023 - Linux-stable-mirror

by Greg Kroah-Hartman

I'm announcing the release of the 6.4.2 kernel. All users of the 6.4 kernel series must upgrade. The updated 6.4.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.4.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Documentation/process/changes.rst | 7 ++++ Makefile | 2 - arch/arm64/mm/fault.c | 2 - drivers/cxl/core/pci.c | 27 ++-------------- drivers/cxl/cxl.h | 1 drivers/cxl/port.c | 14 +++----- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 ++ drivers/md/dm-ioctl.c | 33 +++++++++++++------- drivers/nubus/proc.c | 22 ++++++++++--- drivers/pci/pci-acpi.c | 53 ++++++++++++++++++++++++--------- fs/hugetlbfs/inode.c | 8 +--- fs/nfs/inode.c | 2 - include/linux/mm.h | 4 +- mm/hugetlb.c | 12 +++---- mm/nommu.c | 7 +++- scripts/tags.sh | 9 ++++- tools/include/nolibc/arch-x86_64.h | 2 - tools/testing/cxl/Kbuild | 1 tools/testing/cxl/test/mock.c | 15 --------- 19 files changed, 127 insertions(+), 98 deletions(-) Ahmed S. Darwish (2): scripts/tags.sh: Resolve gtags empty index generation docs: Set minimal gtags / GNU GLOBAL version to 6.6.5 Bas Nieuwenhuizen (1): drm/amdgpu: Validate VM ioctl flags. Bjorn Helgaas (1): PCI/ACPI: Validate acpi_pci_set_power_state() parameter Dan Williams (1): Revert "cxl/port: Enable the HDM decoder capability for switch ports" Demi Marie Obenour (1): dm ioctl: Avoid double-fetch of version Finn Thain (1): nubus: Partially revert proc_create_single_data() conversion Greg Kroah-Hartman (1): Linux 6.4.2 Jeff Layton (1): nfs: don't report STATX_BTIME in ->getattr Linus Torvalds (1): execve: always mark stack as growing down during early stack setup Mario Limonciello (1): PCI/ACPI: Call _REG when transitioning D-states Max Filippov (1): xtensa: fix lock_mm_and_find_vma in case VMA not found Mike Kravetz (1): hugetlb: revert use of page_cache_next_miss() SeongJae Park (1): arch/arm64/mm/fault: Fix undeclared variable error in do_page_fault() Thomas Weißschuh (1): tools/nolibc: x86_64: disable stack protector for _start

1 year, 9 months

1
1
0 0

Linux 6.3.12

by Greg Kroah-Hartman

I'm announcing the release of the 6.3.12 kernel. All users of the 6.3 kernel series must upgrade. The updated 6.3.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.3.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Documentation/process/changes.rst | 7 ++++ Makefile | 2 - drivers/cxl/core/pci.c | 27 ++------------- drivers/cxl/cxl.h | 1 drivers/cxl/port.c | 14 ++------ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 ++ drivers/gpu/drm/amd/display/dc/core/dc.c | 49 +++++++++++++++++----------- drivers/md/dm-ioctl.c | 33 ++++++++++++------- drivers/nubus/proc.c | 22 +++++++++--- drivers/pci/pci-acpi.c | 53 +++++++++++++++++++++++-------- fs/nfs/inode.c | 2 - include/linux/mm.h | 4 +- mm/nommu.c | 7 +++- scripts/tags.sh | 9 ++++- tools/testing/cxl/Kbuild | 1 tools/testing/cxl/test/mock.c | 15 -------- 16 files changed, 147 insertions(+), 103 deletions(-) Ahmed S. Darwish (2): scripts/tags.sh: Resolve gtags empty index generation docs: Set minimal gtags / GNU GLOBAL version to 6.6.5 Aric Cyr (1): drm/amd/display: Do not update DRR while BW optimizations pending Bas Nieuwenhuizen (1): drm/amdgpu: Validate VM ioctl flags. Bjorn Helgaas (1): PCI/ACPI: Validate acpi_pci_set_power_state() parameter Dan Williams (1): Revert "cxl/port: Enable the HDM decoder capability for switch ports" Demi Marie Obenour (1): dm ioctl: Avoid double-fetch of version Finn Thain (1): nubus: Partially revert proc_create_single_data() conversion Greg Kroah-Hartman (1): Linux 6.3.12 Jeff Layton (1): nfs: don't report STATX_BTIME in ->getattr Linus Torvalds (1): execve: always mark stack as growing down during early stack setup Mario Limonciello (1): PCI/ACPI: Call _REG when transitioning D-states Max Filippov (1): xtensa: fix lock_mm_and_find_vma in case VMA not found Rodrigo Siqueira (1): drm/amd/display: Ensure vmin and vmax adjust for DCE

1 year, 9 months

1
1
0 0

Linux 6.1.38

by Greg Kroah-Hartman

I'm announcing the release of the 6.1.38 kernel. All users of the 6.1 kernel series must upgrade. The updated 6.1.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.1.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Documentation/process/changes.rst | 7 ++++ Makefile | 2 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 ++ drivers/gpu/drm/amd/display/dc/core/dc.c | 50 ++++++++++++++++------------- drivers/nubus/proc.c | 22 +++++++++--- drivers/pci/pci-acpi.c | 53 +++++++++++++++++++++++-------- include/linux/mm.h | 4 +- mm/nommu.c | 7 +++- scripts/tags.sh | 9 ++++- tools/perf/util/symbol.c | 17 ++++++++- 10 files changed, 130 insertions(+), 45 deletions(-) Ahmed S. Darwish (2): scripts/tags.sh: Resolve gtags empty index generation docs: Set minimal gtags / GNU GLOBAL version to 6.6.5 Alvin Lee (1): drm/amd/display: Remove optimization for VRR updates Aric Cyr (1): drm/amd/display: Do not update DRR while BW optimizations pending Bas Nieuwenhuizen (1): drm/amdgpu: Validate VM ioctl flags. Bjorn Helgaas (1): PCI/ACPI: Validate acpi_pci_set_power_state() parameter Finn Thain (1): nubus: Partially revert proc_create_single_data() conversion Greg Kroah-Hartman (1): Linux 6.1.38 Krister Johansen (1): perf symbols: Symbol lookup with kcore can fail if multiple segments match stext Linus Torvalds (1): execve: always mark stack as growing down during early stack setup Mario Limonciello (1): PCI/ACPI: Call _REG when transitioning D-states Max Filippov (1): xtensa: fix lock_mm_and_find_vma in case VMA not found Rodrigo Siqueira (1): drm/amd/display: Ensure vmin and vmax adjust for DCE

1 year, 9 months

1
1
0 0

Linux 5.15.120

by Greg Kroah-Hartman

I'm announcing the release of the 5.15.120 kernel. All users of the 5.15 kernel series must upgrade. The updated 5.15.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.15.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 - arch/parisc/include/asm/assembly.h | 4 -- arch/x86/kernel/cpu/microcode/amd.c | 2 - arch/x86/kernel/smpboot.c | 24 ++++++++------- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 1 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 ++ drivers/hid/hid-logitech-hidpp.c | 2 - drivers/hid/wacom_wac.c | 6 +-- drivers/hid/wacom_wac.h | 2 - drivers/nubus/proc.c | 22 ++++++++++--- drivers/thermal/mtk_thermal.c | 14 +------- include/linux/highmem.h | 24 +++++++++++++++ include/linux/mm.h | 5 ++- kernel/bpf/verifier.c | 7 +++- mm/memory.c | 33 ++++++++++++++------ net/can/isotp.c | 5 +-- net/mptcp/protocol.c | 46 +++++++++++++---------------- net/mptcp/subflow.c | 17 ++++++---- scripts/tags.sh | 9 +++++ tools/perf/util/symbol.c | 17 +++++++++- 20 files changed, 158 insertions(+), 88 deletions(-) Ahmed S. Darwish (1): scripts/tags.sh: Resolve gtags empty index generation Bas Nieuwenhuizen (1): drm/amdgpu: Validate VM ioctl flags. Ben Hutchings (1): parisc: Delete redundant register definitions in <asm/assembly.h> Borislav Petkov (AMD) (1): x86/microcode/AMD: Load late on both threads too Finn Thain (1): nubus: Partially revert proc_create_single_data() conversion Greg Kroah-Hartman (1): Linux 5.15.120 Jane Chu (1): mm, hwpoison: when copy-on-write hits poison, take page offline Jason Gerecke (1): HID: wacom: Use ktime_t rather than int when dealing with timestamps Krister Johansen (2): bpf: ensure main program has an extable perf symbols: Symbol lookup with kcore can fail if multiple segments match stext Mike Hommey (1): HID: logitech-hidpp: add HIDPP_QUIRK_DELAYED_INIT for the T651. Oliver Hartkopp (1): can: isotp: isotp_sendmsg(): fix return error fix on TX path Paolo Abeni (2): mptcp: fix possible divide by zero in recvmsg() mptcp: consolidate fallback and non fallback state machine Philip Yang (1): drm/amdgpu: Set vmbo destroy after pt bo is created Ricardo Cañuelo (1): Revert "thermal/drivers/mediatek: Use devm_of_iomap to avoid resource leak in mtk_thermal_probe" Thomas Gleixner (1): x86/smp: Use dedicated cache-line for mwait_play_dead() Tony Luck (1): mm, hwpoison: try to recover from copy-on write faults

1 year, 9 months

1
1
0 0

[PATCH 6.3 00/13] 6.3.12-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.3.12 release. There are 13 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 05 Jul 2023 18:45:08 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.3.12-rc1… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.3.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 6.3.12-rc1 Bas Nieuwenhuizen <bas(a)basnieuwenhuizen.nl> drm/amdgpu: Validate VM ioctl flags. Demi Marie Obenour <demi(a)invisiblethingslab.com> dm ioctl: Avoid double-fetch of version Ahmed S. Darwish <darwi(a)linutronix.de> docs: Set minimal gtags / GNU GLOBAL version to 6.6.5 Ahmed S. Darwish <darwi(a)linutronix.de> scripts/tags.sh: Resolve gtags empty index generation Mike Kravetz <mike.kravetz(a)oracle.com> hugetlb: revert use of page_cache_next_miss() Finn Thain <fthain(a)linux-m68k.org> nubus: Partially revert proc_create_single_data() conversion Dan Williams <dan.j.williams(a)intel.com> Revert "cxl/port: Enable the HDM decoder capability for switch ports" Jeff Layton <jlayton(a)kernel.org> nfs: don't report STATX_BTIME in ->getattr Linus Torvalds <torvalds(a)linux-foundation.org> execve: always mark stack as growing down during early stack setup Mario Limonciello <mario.limonciello(a)amd.com> PCI/ACPI: Call _REG when transitioning D-states Bjorn Helgaas <bhelgaas(a)google.com> PCI/ACPI: Validate acpi_pci_set_power_state() parameter Aric Cyr <aric.cyr(a)amd.com> drm/amd/display: Do not update DRR while BW optimizations pending Max Filippov <jcmvbkbc(a)gmail.com> xtensa: fix lock_mm_and_find_vma in case VMA not found ------------- Diffstat: Documentation/process/changes.rst | 7 +++++ Makefile | 4 +-- drivers/cxl/core/pci.c | 27 +++------------- drivers/cxl/cxl.h | 1 - drivers/cxl/port.c | 14 +++------ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 +++ drivers/gpu/drm/amd/display/dc/core/dc.c | 48 +++++++++++++++++------------ drivers/md/dm-ioctl.c | 33 ++++++++++++-------- drivers/nubus/proc.c | 22 ++++++++++--- drivers/pci/pci-acpi.c | 53 ++++++++++++++++++++++++-------- fs/hugetlbfs/inode.c | 8 ++--- fs/nfs/inode.c | 2 +- include/linux/mm.h | 4 ++- mm/hugetlb.c | 12 ++++---- mm/nommu.c | 7 ++++- scripts/tags.sh | 9 +++++- tools/testing/cxl/Kbuild | 1 - tools/testing/cxl/test/mock.c | 15 --------- 18 files changed, 156 insertions(+), 115 deletions(-)

1 year, 9 months

7
25
0 0

+ fork-lock-vmas-of-the-parent-process-when-forking-v3.patch added to mm-hotfixes-unstable branch

by Andrew Morton

The patch titled Subject: fork: lock VMAs of the parent process when forking has been added to the -mm mm-hotfixes-unstable branch. Its filename is fork-lock-vmas-of-the-parent-process-when-forking-v3.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patche… This patch will later appear in the mm-hotfixes-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Suren Baghdasaryan <surenb(a)google.com> Subject: fork: lock VMAs of the parent process when forking Date: Wed, 5 Jul 2023 10:12:11 -0700 Patch series "Avoid memory corruption caused by per-VMA locks", v3. A memory corruption was reported in [1] with bisection pointing to the patch [2] enabling per-VMA locks for x86. Based on the reproducer provided in [1] we suspect this is caused by the lack of VMA locking while forking a child process. Patch 1/2 in the series implements proper VMA locking during fork. I tested the fix locally using the reproducer and was unable to reproduce the memory corruption problem. This fix can potentially regress some fork-heavy workloads. Kernel build time did not show noticeable regression on a 56-core machine while a stress test mapping 10000 VMAs and forking 5000 times in a tight loop shows ~5% regression. If such fork time regression is unacceptable, disabling CONFIG_PER_VMA_LOCK should restore its performance. Further optimizations are possible if this regression proves to be problematic. This patch (of 2): When forking a child process, parent write-protects an anonymous page and COW-shares it with the child being forked using copy_present_pte(). Parent's TLB is flushed right before we drop the parent's mmap_lock in dup_mmap(). If we get a write-fault before that TLB flush in the parent, and we end up replacing that anonymous page in the parent process in do_wp_page() (because, COW-shared with the child), this might lead to some stale writable TLB entries targeting the wrong (old) page. Similar issue happened in the past with userfaultfd (see flush_tlb_page() call inside do_wp_page()). Lock VMAs of the parent process when forking a child, which prevents concurrent page faults during fork operation and avoids this issue. This fix can potentially regress some fork-heavy workloads. Kernel build time did not show noticeable regression on a 56-core machine while a stress test mapping 10000 VMAs and forking 5000 times in a tight loop shows ~5% regression. If such fork time regression is unacceptable, disabling CONFIG_PER_VMA_LOCK should restore its performance. Further optimizations are possible if this regression proves to be problematic. Link: https://lkml.kernel.org/r/20230705171213.2843068-2-surenb@google.com Fixes: 0bff0aaea03e ("x86/mm: try VMA lock-based page fault handling first"= Signed-off-by: Suren Baghdasaryan <surenb(a)google.com> Suggested-by: David Hildenbrand <david(a)redhat.com> Reported-by: Jiri Slaby <jirislaby(a)kernel.org> Closes: https://lore.kernel.org/all/dbdef34c-3a07-5951-e1ae-e9c6e3cdf51b@ke= rnel.org/ Reported-by: Holger Hoffst��tte <holger(a)applied-asynchrony.com> Closes: https://lore.kernel.org/all/b198d649-f4bf-b971-31d0-e8433ec2a34c@ap= plied-asynchrony.com/ Reported-by: Jacob Young <jacobly.alt(a)gmail.com> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=3D217624 ) Cc: Andy Lutomirski <luto(a)kernel.org> Cc: Axel Rasmussen <axelrasmussen(a)google.com> Cc: Chris Li <chriscli(a)google.com> Cc: David Hildenbrand <david(a)redhat.com> Cc: David Howells <dhowells(a)redhat.com> Cc: Davidlohr Bueso <dave(a)stgolabs.net> Cc: David Rientjes <rientjes(a)google.com> Cc: Eric Dumazet <edumazet(a)google.com> Cc: Greg Thelen <gthelen(a)google.com> Cc: Hans de Goede <hdegoede(a)redhat.com> Cc: Hugh Dickins <hughd(a)google.com> Cc: Ingo Molnar <mingo(a)redhat.com> Cc: Jann Horn <jannh(a)google.com> Cc: Jiri Slaby <jirislaby(a)kernel.org> Cc: Joel Fernandes <joelaf(a)google.com> Cc: Johannes Weiner <hannes(a)cmpxchg.org> Cc: Kent Overstreet <kent.overstreet(a)linux.dev> Cc: Laurent Dufour <ldufour(a)linux.ibm.com> Cc: Liam R. Howlett <Liam.Howlett(a)oracle.com> Cc: Lorenzo Stoakes <lstoakes(a)gmail.com> Cc: Matthew Wilcox <willy(a)infradead.org> Cc: Mel Gorman <mgorman(a)techsingularity.net> Cc: Michal Hocko <mhocko(a)suse.com> Cc: Michel Lespinasse <michel(a)lespinasse.org> Cc: Mike Rapoport (IBM) <rppt(a)kernel.org> Cc: Minchan Kim <minchan(a)google.com> Cc: "Paul E. McKenney" <paulmck(a)kernel.org> Cc: Peter Xu <peterx(a)redhat.com> Cc: <peterz(a)infradead.org> Cc: Punit Agrawal <punit.agrawal(a)bytedance.com> Cc: Sebastian Andrzej Siewior <bigeasy(a)linutronix.de> Cc: Shakeel Butt <shakeelb(a)google.com> Cc: Song Liu <songliubraving(a)fb.com> Cc: Suren Baghdasaryan <surenb(a)google.com> Cc: Vlastimil Babka <vbabka(a)suse.cz> Cc: Will Deacon <will(a)kernel.org> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- kernel/fork.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/kernel/fork.c~fork-lock-vmas-of-the-parent-process-when-forking-v3 +++ a/kernel/fork.c @@ -658,6 +658,12 @@ static __latent_entropy int dup_mmap(str retval = -EINTR; goto fail_uprobe_end; } +#ifdef CONFIG_PER_VMA_LOCK + /* Disallow any page faults before calling flush_cache_dup_mm */ + for_each_vma(old_vmi, mpnt) + vma_start_write(mpnt); + vma_iter_init(&old_vmi, oldmm, 0); +#endif flush_cache_dup_mm(oldmm); uprobe_dup_mmap(oldmm, mm); /* _ Patches currently in -mm which might be from surenb(a)google.com are fork-lock-vmas-of-the-parent-process-when-forking-v3.patch mm-disable-config_per_vma_lock-until-its-fixed.patch swap-remove-remnants-of-polling-from-read_swap_cache_async.patch mm-add-missing-vm_fault_result_trace-name-for-vm_fault_completed.patch mm-drop-per-vma-lock-when-returning-vm_fault_retry-or-vm_fault_completed.patch mm-change-folio_lock_or_retry-to-use-vm_fault-directly.patch mm-handle-swap-page-faults-under-per-vma-lock.patch mm-handle-userfaults-under-vma-lock.patch

1 year, 9 months

1
0
0 0

[to-be-updated] fork-lock-vmas-of-the-parent-process-when-forking.patch removed from -mm tree

by Andrew Morton

The quilt patch titled Subject: fork: lock VMAs of the parent process when forking has been removed from the -mm tree. Its filename was fork-lock-vmas-of-the-parent-process-when-forking.patch This patch was dropped because an updated version will be merged ------------------------------------------------------ From: Suren Baghdasaryan <surenb(a)google.com> Subject: fork: lock VMAs of the parent process when forking Date: Tue, 4 Jul 2023 23:37:10 -0700 Patch series "Avoid memory corruption caused by per-VMA locks", v2. A memory corruption was reported in [1] with bisection pointing to the patch [2] enabling per-VMA locks for x86. Based on the reproducer provided in [1] we suspect this is caused by the lack of VMA locking while forking a child process. Patch 1/2 in the series implements proper VMA locking during fork. I tested the fix locally using the reproducer and was unable to reproduce the memory corruption problem. This fix can potentially regress some fork-heavy workloads. Kernel build time did not show noticeable regression on a 56-core machine while a stress test mapping 10000 VMAs and forking 5000 times in a tight loop shows ~5% regression. If such fork time regression is unacceptable, disabling CONFIG_PER_VMA_LOCK should restore its performance. Further optimizations are possible if this regression proves to be problematic. Patch 2/2 disabled per-VMA locks until the fix is tested and verified. This patch (of 2): When forking a child process, parent write-protects an anonymous page and COW-shares it with the child being forked using copy_present_pte(). Parent's TLB is flushed right before we drop the parent's mmap_lock in dup_mmap(). If we get a write-fault before that TLB flush in the parent, and we end up replacing that anonymous page in the parent process in do_wp_page() (because, COW-shared with the child), this might lead to some stale writable TLB entries targeting the wrong (old) page. Similar issue happened in the past with userfaultfd (see flush_tlb_page() call inside do_wp_page()). Lock VMAs of the parent process when forking a child, which prevents concurrent page faults during fork operation and avoids this issue. This fix can potentially regress some fork-heavy workloads. Kernel build time did not show noticeable regression on a 56-core machine while a stress test mapping 10000 VMAs and forking 5000 times in a tight loop shows ~5% regression. If such fork time regression is unacceptable, disabling CONFIG_PER_VMA_LOCK should restore its performance. Further optimizations are possible if this regression proves to be problematic. Link: https://lkml.kernel.org/r/20230705063711.2670599-1-surenb@google.com Link: https://lkml.kernel.org/r/20230705063711.2670599-2-surenb@google.com Signed-off-by: Suren Baghdasaryan <surenb(a)google.com> Suggested-by: David Hildenbrand <david(a)redhat.com> Reported-by: Jiri Slaby <jirislaby(a)kernel.org> Closes: https://lore.kernel.org/all/dbdef34c-3a07-5951-e1ae-e9c6e3cdf51b@kernel.org/ Reported-by: Holger Hoffst��tte <holger(a)applied-asynchrony.com> Closes: https://lore.kernel.org/all/b198d649-f4bf-b971-31d0-e8433ec2a34c@applied-as… Reported-by: Jacob Young <jacobly.alt(a)gmail.com> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=3D217624 Fixes: 0bff0aaea03e ("x86/mm: try VMA lock-based page fault handling first") Acked-by: David Hildenbrand <david(a)redhat.com> Cc: Bagas Sanjaya <bagasdotme(a)gmail.com> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: Laurent Dufour <ldufour(a)linux.ibm.com> Cc: <regressions(a)lists.linux.dev> Cc: Andy Lutomirski <luto(a)kernel.org> Cc: Axel Rasmussen <axelrasmussen(a)google.com> Cc: Chris Li <chriscli(a)google.com> Cc: David Howells <dhowells(a)redhat.com> Cc: Davidlohr Bueso <dave(a)stgolabs.net> Cc: David Rientjes <rientjes(a)google.com> Cc: Eric Dumazet <edumazet(a)google.com> Cc: Greg Thelen <gthelen(a)google.com> Cc: Hans de Goede <hdegoede(a)redhat.com> Cc: Hugh Dickins <hughd(a)google.com> Cc: Ingo Molnar <mingo(a)redhat.com> Cc: Jann Horn <jannh(a)google.com> Cc: Joel Fernandes <joelaf(a)google.com> Cc: Johannes Weiner <hannes(a)cmpxchg.org> Cc: Kent Overstreet <kent.overstreet(a)linux.dev> Cc: Liam R. Howlett <Liam.Howlett(a)oracle.com> Cc: Lorenzo Stoakes <lstoakes(a)gmail.com> Cc: Matthew Wilcox <willy(a)infradead.org> Cc: Mel Gorman <mgorman(a)techsingularity.net> Cc: Michal Hocko <mhocko(a)suse.com> Cc: Michel Lespinasse <michel(a)lespinasse.org> Cc: Mike Rapoport (IBM) <rppt(a)kernel.org> Cc: Minchan Kim <minchan(a)google.com> Cc: "Paul E. McKenney" <paulmck(a)kernel.org> Cc: Peter Xu <peterx(a)redhat.com> Cc: <peterz(a)infradead.org> Cc: Punit Agrawal <punit.agrawal(a)bytedance.com> Cc: Sebastian Andrzej Siewior <bigeasy(a)linutronix.de> Cc: Shakeel Butt <shakeelb(a)google.com> Cc: Song Liu <songliubraving(a)fb.com> Cc: Vlastimil Babka <vbabka(a)suse.cz> Cc: Will Deacon <will(a)kernel.org> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- kernel/fork.c | 1 + 1 file changed, 1 insertion(+) --- a/kernel/fork.c~fork-lock-vmas-of-the-parent-process-when-forking +++ a/kernel/fork.c @@ -686,6 +686,7 @@ static __latent_entropy int dup_mmap(str for_each_vma(old_vmi, mpnt) { struct file *file; + vma_start_write(mpnt); if (mpnt->vm_flags & VM_DONTCOPY) { vm_stat_account(mm, mpnt->vm_flags, -vma_pages(mpnt)); continue; _ Patches currently in -mm which might be from surenb(a)google.com are fork-lock-vmas-of-the-parent-process-when-forking-v3.patch mm-disable-config_per_vma_lock-until-its-fixed.patch swap-remove-remnants-of-polling-from-read_swap_cache_async.patch mm-add-missing-vm_fault_result_trace-name-for-vm_fault_completed.patch mm-drop-per-vma-lock-when-returning-vm_fault_retry-or-vm_fault_completed.patch mm-change-folio_lock_or_retry-to-use-vm_fault-directly.patch mm-handle-swap-page-faults-under-per-vma-lock.patch mm-handle-userfaults-under-vma-lock.patch

1 year, 9 months

1
0
0 0

[PATCH] mpt3sas: Perform additional retries if Doorbell read returns 0

by Ranjan Kumar

Doorbell and Host diagnostic registers could return 0 even after 3 retries and that leads to occasional resets of the controllers, hence increased the retry count to thirty. 'Fixes: b899202901a8 ("mpt3sas: Add separate function for aero doorbell reads ")' Cc: stable(a)vger.kernel.org Signed-off-by: Ranjan Kumar <ranjan.kumar(a)broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c | 50 ++++++++++++++++------------- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++- 2 files changed, 31 insertions(+), 23 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 53f5492579cb..44e7ccb6f780 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -201,20 +201,20 @@ module_param_call(mpt3sas_fwfault_debug, _scsih_set_fwfault_debug, * while reading the system interface register. */ static inline u32 -_base_readl_aero(const volatile void __iomem *addr) +_base_readl_aero(const volatile void __iomem *addr, u8 retry_count) { u32 i = 0, ret_val; do { ret_val = readl(addr); i++; - } while (ret_val == 0 && i < 3); + } while (ret_val == 0 && i < retry_count); return ret_val; } static inline u32 -_base_readl(const volatile void __iomem *addr) +_base_readl(const volatile void __iomem *addr, u8 retry_count) { return readl(addr); } @@ -940,7 +940,7 @@ mpt3sas_halt_firmware(struct MPT3SAS_ADAPTER *ioc) dump_stack(); - doorbell = ioc->base_readl(&ioc->chip->Doorbell); + doorbell = ioc->base_readl(&ioc->chip->Doorbell, READL_RETRY_COUNT_OF_THIRTY); if ((doorbell & MPI2_IOC_STATE_MASK) == MPI2_IOC_STATE_FAULT) { mpt3sas_print_fault_code(ioc, doorbell & MPI2_DOORBELL_DATA_MASK); @@ -1617,10 +1617,10 @@ mpt3sas_base_mask_interrupts(struct MPT3SAS_ADAPTER *ioc) u32 him_register; ioc->mask_interrupts = 1; - him_register = ioc->base_readl(&ioc->chip->HostInterruptMask); + him_register = ioc->base_readl(&ioc->chip->HostInterruptMask, READL_RETRY_COUNT_OF_THREE); him_register |= MPI2_HIM_DIM + MPI2_HIM_RIM + MPI2_HIM_RESET_IRQ_MASK; writel(him_register, &ioc->chip->HostInterruptMask); - ioc->base_readl(&ioc->chip->HostInterruptMask); + ioc->base_readl(&ioc->chip->HostInterruptMask, READL_RETRY_COUNT_OF_THREE); } /** @@ -1634,7 +1634,7 @@ mpt3sas_base_unmask_interrupts(struct MPT3SAS_ADAPTER *ioc) { u32 him_register; - him_register = ioc->base_readl(&ioc->chip->HostInterruptMask); + him_register = ioc->base_readl(&ioc->chip->HostInterruptMask, READL_RETRY_COUNT_OF_THREE); him_register &= ~MPI2_HIM_RIM; writel(him_register, &ioc->chip->HostInterruptMask); ioc->mask_interrupts = 0; @@ -6686,7 +6686,7 @@ mpt3sas_base_get_iocstate(struct MPT3SAS_ADAPTER *ioc, int cooked) { u32 s, sc; - s = ioc->base_readl(&ioc->chip->Doorbell); + s = ioc->base_readl(&ioc->chip->Doorbell, READL_RETRY_COUNT_OF_THIRTY); sc = s & MPI2_IOC_STATE_MASK; return cooked ? sc : s; } @@ -6760,7 +6760,8 @@ _base_wait_for_doorbell_int(struct MPT3SAS_ADAPTER *ioc, int timeout) count = 0; cntdn = 1000 * timeout; do { - int_status = ioc->base_readl(&ioc->chip->HostInterruptStatus); + int_status = ioc->base_readl(&ioc->chip->HostInterruptStatus, + READL_RETRY_COUNT_OF_THREE); if (int_status & MPI2_HIS_IOC2SYS_DB_STATUS) { dhsprintk(ioc, ioc_info(ioc, "%s: successful count(%d), timeout(%d)\n", @@ -6786,7 +6787,8 @@ _base_spin_on_doorbell_int(struct MPT3SAS_ADAPTER *ioc, int timeout) count = 0; cntdn = 2000 * timeout; do { - int_status = ioc->base_readl(&ioc->chip->HostInterruptStatus); + int_status = ioc->base_readl(&ioc->chip->HostInterruptStatus, + READL_RETRY_COUNT_OF_THREE); if (int_status & MPI2_HIS_IOC2SYS_DB_STATUS) { dhsprintk(ioc, ioc_info(ioc, "%s: successful count(%d), timeout(%d)\n", @@ -6824,14 +6826,16 @@ _base_wait_for_doorbell_ack(struct MPT3SAS_ADAPTER *ioc, int timeout) count = 0; cntdn = 1000 * timeout; do { - int_status = ioc->base_readl(&ioc->chip->HostInterruptStatus); + int_status = ioc->base_readl(&ioc->chip->HostInterruptStatus, + READL_RETRY_COUNT_OF_THREE); if (!(int_status & MPI2_HIS_SYS2IOC_DB_STATUS)) { dhsprintk(ioc, ioc_info(ioc, "%s: successful count(%d), timeout(%d)\n", __func__, count, timeout)); return 0; } else if (int_status & MPI2_HIS_IOC2SYS_DB_STATUS) { - doorbell = ioc->base_readl(&ioc->chip->Doorbell); + doorbell = ioc->base_readl(&ioc->chip->Doorbell, + READL_RETRY_COUNT_OF_THIRTY); if ((doorbell & MPI2_IOC_STATE_MASK) == MPI2_IOC_STATE_FAULT) { mpt3sas_print_fault_code(ioc, doorbell); @@ -6871,7 +6875,7 @@ _base_wait_for_doorbell_not_used(struct MPT3SAS_ADAPTER *ioc, int timeout) count = 0; cntdn = 1000 * timeout; do { - doorbell_reg = ioc->base_readl(&ioc->chip->Doorbell); + doorbell_reg = ioc->base_readl(&ioc->chip->Doorbell, READL_RETRY_COUNT_OF_THIRTY); if (!(doorbell_reg & MPI2_DOORBELL_USED)) { dhsprintk(ioc, ioc_info(ioc, "%s: successful count(%d), timeout(%d)\n", @@ -7019,13 +7023,13 @@ _base_handshake_req_reply_wait(struct MPT3SAS_ADAPTER *ioc, int request_bytes, __le32 *mfp; /* make sure doorbell is not in use */ - if ((ioc->base_readl(&ioc->chip->Doorbell) & MPI2_DOORBELL_USED)) { + if ((ioc->base_readl(&ioc->chip->Doorbell, READL_RETRY_COUNT_OF_THIRTY) & MPI2_DOORBELL_USED)) { ioc_err(ioc, "doorbell is in use (line=%d)\n", __LINE__); return -EFAULT; } /* clear pending doorbell interrupts from previous state changes */ - if (ioc->base_readl(&ioc->chip->HostInterruptStatus) & + if (ioc->base_readl(&ioc->chip->HostInterruptStatus, READL_RETRY_COUNT_OF_THREE) & MPI2_HIS_IOC2SYS_DB_STATUS) writel(0, &ioc->chip->HostInterruptStatus); @@ -7068,7 +7072,7 @@ _base_handshake_req_reply_wait(struct MPT3SAS_ADAPTER *ioc, int request_bytes, } /* read the first two 16-bits, it gives the total length of the reply */ - reply[0] = le16_to_cpu(ioc->base_readl(&ioc->chip->Doorbell) + reply[0] = le16_to_cpu(ioc->base_readl(&ioc->chip->Doorbell, READL_RETRY_COUNT_OF_THIRTY) & MPI2_DOORBELL_DATA_MASK); writel(0, &ioc->chip->HostInterruptStatus); if ((_base_wait_for_doorbell_int(ioc, 5))) { @@ -7076,7 +7080,7 @@ _base_handshake_req_reply_wait(struct MPT3SAS_ADAPTER *ioc, int request_bytes, __LINE__); return -EFAULT; } - reply[1] = le16_to_cpu(ioc->base_readl(&ioc->chip->Doorbell) + reply[1] = le16_to_cpu(ioc->base_readl(&ioc->chip->Doorbell, READL_RETRY_COUNT_OF_THIRTY) & MPI2_DOORBELL_DATA_MASK); writel(0, &ioc->chip->HostInterruptStatus); @@ -7087,10 +7091,10 @@ _base_handshake_req_reply_wait(struct MPT3SAS_ADAPTER *ioc, int request_bytes, return -EFAULT; } if (i >= reply_bytes/2) /* overflow case */ - ioc->base_readl(&ioc->chip->Doorbell); + ioc->base_readl(&ioc->chip->Doorbell, READL_RETRY_COUNT_OF_THIRTY); else reply[i] = le16_to_cpu( - ioc->base_readl(&ioc->chip->Doorbell) + ioc->base_readl(&ioc->chip->Doorbell, READL_RETRY_COUNT_OF_THIRTY) & MPI2_DOORBELL_DATA_MASK); writel(0, &ioc->chip->HostInterruptStatus); } @@ -7949,14 +7953,15 @@ _base_diag_reset(struct MPT3SAS_ADAPTER *ioc) goto out; } - host_diagnostic = ioc->base_readl(&ioc->chip->HostDiagnostic); + host_diagnostic = ioc->base_readl(&ioc->chip->HostDiagnostic, + READL_RETRY_COUNT_OF_THIRTY); drsprintk(ioc, ioc_info(ioc, "wrote magic sequence: count(%d), host_diagnostic(0x%08x)\n", count, host_diagnostic)); } while ((host_diagnostic & MPI2_DIAG_DIAG_WRITE_ENABLE) == 0); - hcb_size = ioc->base_readl(&ioc->chip->HCBSize); + hcb_size = ioc->base_readl(&ioc->chip->HCBSize, READL_RETRY_COUNT_OF_THREE); drsprintk(ioc, ioc_info(ioc, "diag reset: issued\n")); writel(host_diagnostic | MPI2_DIAG_RESET_ADAPTER, @@ -7969,7 +7974,8 @@ _base_diag_reset(struct MPT3SAS_ADAPTER *ioc) for (count = 0; count < (300000000 / MPI2_HARD_RESET_PCIE_SECOND_READ_DELAY_MICRO_SEC); count++) { - host_diagnostic = ioc->base_readl(&ioc->chip->HostDiagnostic); + host_diagnostic = ioc->base_readl(&ioc->chip->HostDiagnostic, + READL_RETRY_COUNT_OF_THIRTY); if (host_diagnostic == 0xFFFFFFFF) { ioc_info(ioc, diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index 05364aa15ecd..3b8ec4fd2d21 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.h +++ b/drivers/scsi/mpt3sas/mpt3sas_base.h @@ -160,6 +160,8 @@ #define IOC_OPERATIONAL_WAIT_COUNT 10 +#define READL_RETRY_COUNT_OF_THIRTY 30 +#define READL_RETRY_COUNT_OF_THREE 3 /* * NVMe defines */ @@ -994,7 +996,7 @@ typedef void (*NVME_BUILD_PRP)(struct MPT3SAS_ADAPTER *ioc, u16 smid, typedef void (*PUT_SMID_IO_FP_HIP) (struct MPT3SAS_ADAPTER *ioc, u16 smid, u16 funcdep); typedef void (*PUT_SMID_DEFAULT) (struct MPT3SAS_ADAPTER *ioc, u16 smid); -typedef u32 (*BASE_READ_REG) (const volatile void __iomem *addr); +typedef u32 (*BASE_READ_REG) (const volatile void __iomem *addr, u8 retry_count); /* * To get high iops reply queue's msix index when high iops mode is enabled * else get the msix index of general reply queues. -- 2.31.1

1 year, 9 months

3
9
0 0

[PATCH net v2] nfp: clean mc addresses in application firmware when closing port

by Louis Peens

From: Yinjun Zhang <yinjun.zhang(a)corigine.com> When moving devices from one namespace to another, mc addresses are cleaned in software while not removed from application firmware. Thus the mc addresses are remained and will cause resource leak. Now use `__dev_mc_unsync` to clean mc addresses when closing port. Fixes: e20aa071cd95 ("nfp: fix schedule in atomic context when sync mc address") Cc: stable(a)vger.kernel.org Signed-off-by: Yinjun Zhang <yinjun.zhang(a)corigine.com> Acked-by: Simon Horman <simon.horman(a)corigine.com> Signed-off-by: Louis Peens <louis.peens(a)corigine.com> --- Changes since v1: * Use __dev_mc_unsyc to clean mc addresses instead of tracking mc addresses by driver itself. * Clean mc addresses when closing port instead of driver exits, so that the issue of moving devices between namespaces can be fixed. * Modify commit message accordingly. .../ethernet/netronome/nfp/nfp_net_common.c | 171 +++++++++--------- 1 file changed, 87 insertions(+), 84 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c index 49f2f081ebb5..37b6a034c5d2 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c @@ -914,6 +914,90 @@ static void nfp_net_write_mac_addr(struct nfp_net *nn, const u8 *addr) nn_writew(nn, NFP_NET_CFG_MACADDR + 6, get_unaligned_be16(addr + 4)); } +int nfp_net_sched_mbox_amsg_work(struct nfp_net *nn, u32 cmd, const void *data, size_t len, + int (*cb)(struct nfp_net *, struct nfp_mbox_amsg_entry *)) +{ + struct nfp_mbox_amsg_entry *entry; + + entry = kmalloc(sizeof(*entry) + len, GFP_ATOMIC); + if (!entry) + return -ENOMEM; + + memcpy(entry->msg, data, len); + entry->cmd = cmd; + entry->cfg = cb; + + spin_lock_bh(&nn->mbox_amsg.lock); + list_add_tail(&entry->list, &nn->mbox_amsg.list); + spin_unlock_bh(&nn->mbox_amsg.lock); + + schedule_work(&nn->mbox_amsg.work); + + return 0; +} + +static void nfp_net_mbox_amsg_work(struct work_struct *work) +{ + struct nfp_net *nn = container_of(work, struct nfp_net, mbox_amsg.work); + struct nfp_mbox_amsg_entry *entry, *tmp; + struct list_head tmp_list; + + INIT_LIST_HEAD(&tmp_list); + + spin_lock_bh(&nn->mbox_amsg.lock); + list_splice_init(&nn->mbox_amsg.list, &tmp_list); + spin_unlock_bh(&nn->mbox_amsg.lock); + + list_for_each_entry_safe(entry, tmp, &tmp_list, list) { + int err = entry->cfg(nn, entry); + + if (err) + nn_err(nn, "Config cmd %d to HW failed %d.\n", entry->cmd, err); + + list_del(&entry->list); + kfree(entry); + } +} + +static int nfp_net_mc_cfg(struct nfp_net *nn, struct nfp_mbox_amsg_entry *entry) +{ + unsigned char *addr = entry->msg; + int ret; + + ret = nfp_net_mbox_lock(nn, NFP_NET_CFG_MULTICAST_SZ); + if (ret) + return ret; + + nn_writel(nn, nn->tlv_caps.mbox_off + NFP_NET_CFG_MULTICAST_MAC_HI, + get_unaligned_be32(addr)); + nn_writew(nn, nn->tlv_caps.mbox_off + NFP_NET_CFG_MULTICAST_MAC_LO, + get_unaligned_be16(addr + 4)); + + return nfp_net_mbox_reconfig_and_unlock(nn, entry->cmd); +} + +static int nfp_net_mc_sync(struct net_device *netdev, const unsigned char *addr) +{ + struct nfp_net *nn = netdev_priv(netdev); + + if (netdev_mc_count(netdev) > NFP_NET_CFG_MAC_MC_MAX) { + nn_err(nn, "Requested number of MC addresses (%d) exceeds maximum (%d).\n", + netdev_mc_count(netdev), NFP_NET_CFG_MAC_MC_MAX); + return -EINVAL; + } + + return nfp_net_sched_mbox_amsg_work(nn, NFP_NET_CFG_MBOX_CMD_MULTICAST_ADD, addr, + NFP_NET_CFG_MULTICAST_SZ, nfp_net_mc_cfg); +} + +static int nfp_net_mc_unsync(struct net_device *netdev, const unsigned char *addr) +{ + struct nfp_net *nn = netdev_priv(netdev); + + return nfp_net_sched_mbox_amsg_work(nn, NFP_NET_CFG_MBOX_CMD_MULTICAST_DEL, addr, + NFP_NET_CFG_MULTICAST_SZ, nfp_net_mc_cfg); +} + /** * nfp_net_clear_config_and_disable() - Clear control BAR and disable NFP * @nn: NFP Net device to reconfigure @@ -1084,6 +1168,9 @@ static int nfp_net_netdev_close(struct net_device *netdev) /* Step 2: Tell NFP */ + if (nn->cap_w1 & NFP_NET_CFG_CTRL_MCAST_FILTER) + __dev_mc_unsync(netdev, nfp_net_mc_unsync); + nfp_net_clear_config_and_disable(nn); nfp_port_configure(netdev, false); @@ -1335,90 +1422,6 @@ int nfp_ctrl_open(struct nfp_net *nn) return err; } -int nfp_net_sched_mbox_amsg_work(struct nfp_net *nn, u32 cmd, const void *data, size_t len, - int (*cb)(struct nfp_net *, struct nfp_mbox_amsg_entry *)) -{ - struct nfp_mbox_amsg_entry *entry; - - entry = kmalloc(sizeof(*entry) + len, GFP_ATOMIC); - if (!entry) - return -ENOMEM; - - memcpy(entry->msg, data, len); - entry->cmd = cmd; - entry->cfg = cb; - - spin_lock_bh(&nn->mbox_amsg.lock); - list_add_tail(&entry->list, &nn->mbox_amsg.list); - spin_unlock_bh(&nn->mbox_amsg.lock); - - schedule_work(&nn->mbox_amsg.work); - - return 0; -} - -static void nfp_net_mbox_amsg_work(struct work_struct *work) -{ - struct nfp_net *nn = container_of(work, struct nfp_net, mbox_amsg.work); - struct nfp_mbox_amsg_entry *entry, *tmp; - struct list_head tmp_list; - - INIT_LIST_HEAD(&tmp_list); - - spin_lock_bh(&nn->mbox_amsg.lock); - list_splice_init(&nn->mbox_amsg.list, &tmp_list); - spin_unlock_bh(&nn->mbox_amsg.lock); - - list_for_each_entry_safe(entry, tmp, &tmp_list, list) { - int err = entry->cfg(nn, entry); - - if (err) - nn_err(nn, "Config cmd %d to HW failed %d.\n", entry->cmd, err); - - list_del(&entry->list); - kfree(entry); - } -} - -static int nfp_net_mc_cfg(struct nfp_net *nn, struct nfp_mbox_amsg_entry *entry) -{ - unsigned char *addr = entry->msg; - int ret; - - ret = nfp_net_mbox_lock(nn, NFP_NET_CFG_MULTICAST_SZ); - if (ret) - return ret; - - nn_writel(nn, nn->tlv_caps.mbox_off + NFP_NET_CFG_MULTICAST_MAC_HI, - get_unaligned_be32(addr)); - nn_writew(nn, nn->tlv_caps.mbox_off + NFP_NET_CFG_MULTICAST_MAC_LO, - get_unaligned_be16(addr + 4)); - - return nfp_net_mbox_reconfig_and_unlock(nn, entry->cmd); -} - -static int nfp_net_mc_sync(struct net_device *netdev, const unsigned char *addr) -{ - struct nfp_net *nn = netdev_priv(netdev); - - if (netdev_mc_count(netdev) > NFP_NET_CFG_MAC_MC_MAX) { - nn_err(nn, "Requested number of MC addresses (%d) exceeds maximum (%d).\n", - netdev_mc_count(netdev), NFP_NET_CFG_MAC_MC_MAX); - return -EINVAL; - } - - return nfp_net_sched_mbox_amsg_work(nn, NFP_NET_CFG_MBOX_CMD_MULTICAST_ADD, addr, - NFP_NET_CFG_MULTICAST_SZ, nfp_net_mc_cfg); -} - -static int nfp_net_mc_unsync(struct net_device *netdev, const unsigned char *addr) -{ - struct nfp_net *nn = netdev_priv(netdev); - - return nfp_net_sched_mbox_amsg_work(nn, NFP_NET_CFG_MBOX_CMD_MULTICAST_DEL, addr, - NFP_NET_CFG_MULTICAST_SZ, nfp_net_mc_cfg); -} - static void nfp_net_set_rx_mode(struct net_device *netdev) { struct nfp_net *nn = netdev_priv(netdev); -- 2.34.1

1 year, 9 months

5
4
0 0

[PATCH v2 0/2] Avoid memory corruption caused by per-VMA locks

by Suren Baghdasaryan

A memory corruption was reported in [1] with bisection pointing to the patch [2] enabling per-VMA locks for x86. Based on the reproducer provided in [1] we suspect this is caused by the lack of VMA locking while forking a child process. Patch 1/2 in the series implements proper VMA locking during fork. I tested the fix locally using the reproducer and was unable to reproduce the memory corruption problem. This fix can potentially regress some fork-heavy workloads. Kernel build time did not show noticeable regression on a 56-core machine while a stress test mapping 10000 VMAs and forking 5000 times in a tight loop shows ~5% regression. If such fork time regression is unacceptable, disabling CONFIG_PER_VMA_LOCK should restore its performance. Further optimizations are possible if this regression proves to be problematic. Patch 2/2 disabled per-VMA locks until the fix is tested and verified. Both patches apply cleanly over Linus' ToT and stable 6.4.y branch. [1] https://bugzilla.kernel.org/show_bug.cgi?id=217624 [2] https://lore.kernel.org/all/20230227173632.3292573-30-surenb@google.com Suren Baghdasaryan (2): fork: lock VMAs of the parent process when forking mm: disable CONFIG_PER_VMA_LOCK until its fixed kernel/fork.c | 1 + mm/Kconfig | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.41.0.255.g8b1d071c50-goog

1 year, 9 months

2
5
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror July 2023