June 2023 - Linux-stable-mirror

by Greg Kroah-Hartman

I'm announcing the release of the 4.19.285 kernel. All users of the 4.19 kernel series must upgrade. The updated 4.19.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.19.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 6 arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 82 ++ arch/arm/kernel/unwind.c | 25 arch/arm64/mm/fault.c | 4 arch/x86/boot/boot.h | 36 - arch/x86/boot/main.c | 2 drivers/acpi/thermal.c | 2 drivers/ata/libata-scsi.c | 34 - drivers/base/regmap/regmap.c | 6 drivers/block/nbd.c | 4 drivers/dma/pl330.c | 8 drivers/hid/hid-google-hammer.c | 2 drivers/hid/hid-ids.h | 1 drivers/hid/wacom_wac.c | 2 drivers/hwmon/scmi-hwmon.c | 2 drivers/iio/adc/mxs-lradc-adc.c | 10 drivers/iio/dac/Makefile | 2 drivers/iio/dac/mcp4725.c | 16 drivers/mailbox/mailbox-test.c | 13 drivers/media/dvb-core/dvb_ca_en50221.c | 49 + drivers/media/dvb-core/dvb_demux.c | 4 drivers/media/dvb-core/dvb_frontend.c | 16 drivers/media/dvb-core/dvb_net.c | 38 + drivers/media/dvb-frontends/mn88443x.c | 2 drivers/media/pci/netup_unidvb/netup_unidvb_core.c | 17 drivers/media/platform/rcar-vin/rcar-dma.c | 1 drivers/media/usb/dvb-usb-v2/ce6230.c | 8 drivers/media/usb/dvb-usb-v2/ec168.c | 12 drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 20 drivers/media/usb/dvb-usb/az6027.c | 12 drivers/media/usb/dvb-usb/digitv.c | 4 drivers/media/usb/dvb-usb/dw2102.c | 2 drivers/media/usb/ttusb-dec/ttusb_dec.c | 3 drivers/mmc/host/vub300.c | 3 drivers/net/dsa/mv88e6xxx/chip.c | 2 drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 12 drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h | 1 drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 2 drivers/net/ethernet/sun/cassini.c | 4 drivers/net/usb/cdc_ncm.c | 435 +++++++++++---- drivers/net/usb/huawei_cdc_ncm.c | 8 drivers/net/usb/qmi_wwan.c | 2 drivers/net/wireless/broadcom/b43/b43.h | 2 drivers/net/wireless/broadcom/b43legacy/b43legacy.h | 2 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 10 drivers/net/wireless/rsi/rsi_91x_mac80211.c | 2 drivers/power/supply/bq24190_charger.c | 13 drivers/power/supply/bq27xxx_battery.c | 4 drivers/power/supply/power_supply_core.c | 57 + drivers/regulator/da9052-regulator.c | 2 drivers/regulator/da9055-regulator.c | 2 drivers/scsi/Kconfig | 2 drivers/scsi/dpt_i2o.c | 269 --------- drivers/scsi/dpti.h | 1 drivers/scsi/scsi_lib.c | 2 drivers/scsi/stex.c | 4 drivers/tty/serial/fsl_lpuart.c | 44 - drivers/usb/gadget/function/f_fs.c | 2 drivers/video/fbdev/core/bitblit.c | 3 drivers/video/fbdev/core/modedb.c | 5 drivers/video/fbdev/stifb.c | 1 drivers/watchdog/menz69_wdt.c | 16 fs/ext4/ext4.h | 2 fs/ext4/xattr.c | 4 fs/ocfs2/dlm/dlmcommon.h | 4 include/linux/bitops.h | 1 include/linux/power_supply.h | 5 include/linux/usb/cdc_ncm.h | 15 include/media/dvb_net.h | 4 include/net/ip.h | 2 include/net/sock.h | 4 include/uapi/linux/in.h | 2 kernel/extable.c | 3 lib/dynamic_debug.c | 2 net/atm/resources.c | 2 net/bluetooth/hci_sock.c | 28 net/core/sock.c | 2 net/ipv4/af_inet.c | 2 net/ipv4/inet_connection_sock.c | 1 net/ipv4/ip_sockglue.c | 12 net/ipv4/raw.c | 5 net/ipv4/tcp.c | 9 net/ipv6/raw.c | 3 net/netfilter/nf_conntrack_netlink.c | 12 net/netlink/af_netlink.c | 2 net/netrom/nr_subr.c | 7 net/packet/af_packet.c | 8 net/packet/diag.c | 2 net/sched/cls_flower.c | 3 net/sched/sch_api.c | 16 net/sched/sch_ingress.c | 16 net/xfrm/xfrm_policy.c | 11 security/selinux/Makefile | 6 sound/core/oss/pcm_plugin.h | 16 sound/soc/codecs/ssm2602.c | 15 sound/soc/dwc/dwc-i2s.c | 4 98 files changed, 1017 insertions(+), 575 deletions(-) Adam Borowski (1): ACPI: thermal: drop an always true check Alexander Bersenev (2): cdc_ncm: Implement the 32-bit version of NCM Transfer Block cdc_ncm: Fix the build warning Andreas Svensson (1): net: dsa: mv88e6xxx: Increase wait after reset deactivation Andy Shevchenko (1): ocfs2/dlm: move BITS_TO_BYTES() to bitops.h for wider use Arnd Bergmann (3): wifi: b43: fix incorrect __packed annotation ALSA: oss: avoid missing-prototype warnings atm: hide unused procfs functions Bart Van Assche (1): scsi: stex: Fix gcc 13 warnings Ben Hutchings (2): scsi: dpt_i2o: Remove broken pass-through ioctl (I2OUSERCMD) scsi: dpt_i2o: Do not process completions with invalid addresses Benedict Wong (1): xfrm: Check if_id in inbound policy/secpath match Cambda Zhu (1): tcp: Return user_mss for TCP_MAXSEG in CLOSE/LISTEN state if user_mss set Damien Le Moal (1): ata: libata-scsi: Use correct device no in ata_find_dev() Dan Carpenter (1): mailbox: mailbox-test: fix a locking issue in mbox_test_message_write() Dario Binacchi (1): ARM: dts: stm32: add pin map for CAN controller on stm32f7 Deren Wu (1): mmc: vub300: fix invalid response handling Eric Dumazet (3): netrom: fix info-leak in nr_write_internal() af_packet: do not use READ_ONCE() in packet_bind() tcp: deny tcp_disconnect() when threads are waiting Greg Kroah-Hartman (1): Linux 4.19.285 Haibo Li (1): ARM: 9295/1: unwind:fix unwind abort for uleb128 case Hangyu Hua (1): net/sched: flower: fix possible OOB write in fl_set_geneve_opt() Hans de Goede (3): power: supply: bq27xxx: After charger plug in/out wait 0.5s for things to stabilize power: supply: core: Refactor power_supply_set_input_current_limit_from_supplier() power: supply: bq24190: Call power_supply_changed() after updating input current Helge Deller (3): fbdev: modedb: Add 1920x1080 at 60 Hz video mode fbdev: stifb: Fix info entry in sti_struct on error path fbcon: Fix null-ptr-deref in soft_cursor Hyunwoo Kim (3): media: ttusb-dec: fix memory leak in ttusb_dec_exit_dvb() media: dvb-core: Fix use-after-free due on race condition at dvb_net media: dvb-core: Fix use-after-free due to race condition at dvb_ca_en50221 Ivan Orlov (1): nbd: Fix debugfs_create_dir error checking Jakub Kicinski (1): wifi: rtlwifi: remove always-true condition pointed out by GCC 12 Jiakai Luo (1): iio: adc: mxs-lradc: fix the order of two cleanup operations Jim Wylder (1): regmap: Account for register length when chunking Johannes Thumshirn (1): watchdog: menz069_wdt: fix watchdog initialisation Kees Cook (1): x86/boot: Wrap literal addresses in absolute_pointer() Krzysztof Kozlowski (1): media: mn88443x: fix !CONFIG_OF error by drop of_match_ptr from ID table Kuniyuki Iwashima (1): af_packet: Fix data-races of pkt_sk(sk)->num. Lee Jones (1): mailbox: mailbox-test: Fix potential double-free in mbox_test_message_write() Linus Torvalds (1): gcc-12: disable '-Wdangling-pointer' warning for now Lukas Bulwahn (1): iio: dac: build ad5758 driver when AD5758 is selected Marek Vasut (1): iio: dac: mcp4725: Fix i2c_master_send() return value handling Martin Liška (1): eth: sun: cassini: remove dead code Maxim Kochetkov (1): ASoC: dwc: limit the number of overrun messages Min-Hua Chen (1): arm64/mm: mark private VM_FAULT_X defines as vm_fault_t Nathan Chancellor (5): kernel/extable.c: use address-of operator on section symbols lib/dynamic_debug.c: use address-of operator on section symbols hwmon: (scmi) Remove redundant pointer check regulator: da905{2,5}: Remove unnecessary array check rsi: Remove unnecessary boolean condition Nicolas Dichtel (1): ipv{4,6}/raw: fix output xfrm lookup wrt protocol Nikita Zhandarovich (1): HID: wacom: avoid integer overflow in wacom_intuos_inout() Niklas Söderlund (1): media: rcar-vin: Select correct interrupt mode for V4L2_FIELD_ALTERNATE Paul Blakey (1): netfilter: ctnetlink: Support offloaded conntrack entry deletion Paul Moore (1): selinux: don't use make's grouped targets feature yet Paweł Anikiel (1): ASoC: ssm2602: Add workaround for playback distortions Pedro Tammela (1): net/netlink: fix NETLINK_LIST_MEMBERSHIPS length report Peilin Ye (4): net/sched: sch_ingress: Only create under TC_H_INGRESS net/sched: sch_clsact: Only create under TC_H_CLSACT net/sched: Reserve TC_H_INGRESS (TC_H_CLSACT) for ingress (clsact) Qdiscs net/sched: Prohibit regrafting ingress or clsact Qdiscs Ping-Ke Shih (1): wifi: rtlwifi: 8192de: correct checking of IQK reload Raju Rangoju (1): amd-xgbe: fix the false linkup in xgbe_phy_status Randy Dunlap (1): dmaengine: pl330: rename _start to prevent build error Ruihan Li (1): bluetooth: Add cmd validity checks at the start of hci_sock_ioctl() Sebastian Krzyszkowiak (1): net: usb: qmi_wwan: Set DTR quirk for BroadMobi BM818 Shay Drory (1): net/mlx5: fw_tracer, Fix event handling Sherry Sun (1): tty: serial: fsl_lpuart: use UARTCTRL_TXINV to send break instead of UARTCTRL_SBK Sung-Chi Li (1): HID: google: add jewel USB id Takashi Iwai (1): media: dvb-core: Fix kernel WARNING for blocking operation in wait_event*() Theodore Ts'o (1): ext4: add lockdep annotations for i_data_sem for ea_inode's Tom Rix (1): netfilter: conntrack: define variables exp_nat_nla_policy and any_addr with CONFIG_NF_NAT Tudor Ambarus (1): net: cdc_ncm: Deal with too low values of dwNtbOutMaxSize Uttkarsh Aggarwal (1): usb: gadget: f_fs: Add unbind event before functionfs_unbind Vladislav Efanov (1): udp6: Fix race condition in udp6_sendmsg & connect Wei Chen (6): media: dvb-usb: az6027: fix three null-ptr-deref in az6027_i2c_xfer() media: dvb-usb-v2: ec168: fix null-ptr-deref in ec168_i2c_xfer() media: dvb-usb-v2: ce6230: fix null-ptr-deref in ce6230_i2c_master_xfer() media: dvb-usb: digitv: fix null-ptr-deref in digitv_i2c_xfer() media: dvb-usb: dw2102: fix uninit-value in su3000_read_mac_address media: netup_unidvb: fix irq init by register it at the end of probe Wenchao Hao (1): scsi: core: Decrease scsi_device's iorequest_cnt if dispatch failed YongSu Yoo (2): media: dvb_demux: fix a bug for the continuity counter media: dvb_ca_en50221: fix a size write bug Yun Lu (1): wifi: rtl8xxxu: fix authentication timeout due to incorrect RCR value Zhang Shurong (1): media: dvb-usb-v2: rtl28xxu: fix null-ptr-deref in rtl28xxu_i2c_xfer Zhengchao Shao (1): net: sched: fix NULL pointer dereference in mq_attach

1 year, 7 months

1
1
0 0

Linux 4.14.317

by Greg Kroah-Hartman

I'm announcing the release of the 4.14.317 kernel. All users of the 4.14 kernel series must upgrade. The updated 4.14.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.14.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 6 arch/arm/kernel/unwind.c | 25 - arch/x86/boot/boot.h | 36 - arch/x86/boot/main.c | 2 drivers/acpi/thermal.c | 2 drivers/ata/libata-scsi.c | 34 + drivers/block/nbd.c | 4 drivers/dma/pl330.c | 8 drivers/hid/wacom_wac.c | 2 drivers/iio/adc/mxs-lradc-adc.c | 10 drivers/iio/dac/mcp4725.c | 16 drivers/mailbox/mailbox-test.c | 13 drivers/media/dvb-core/dvb_ca_en50221.c | 37 + drivers/media/dvb-core/dvb_frontend.c | 16 drivers/media/pci/netup_unidvb/netup_unidvb_core.c | 17 drivers/media/usb/dvb-usb-v2/ce6230.c | 8 drivers/media/usb/dvb-usb-v2/ec168.c | 12 drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 20 drivers/media/usb/dvb-usb/az6027.c | 12 drivers/media/usb/dvb-usb/digitv.c | 4 drivers/media/usb/dvb-usb/dw2102.c | 2 drivers/media/usb/ttusb-dec/ttusb_dec.c | 3 drivers/mmc/host/vub300.c | 3 drivers/net/dsa/mv88e6xxx/chip.c | 2 drivers/net/ethernet/sun/cassini.c | 4 drivers/net/usb/cdc_ncm.c | 435 ++++++++++++++---- drivers/net/usb/huawei_cdc_ncm.c | 8 drivers/net/usb/qmi_wwan.c | 2 drivers/net/wireless/broadcom/b43/b43.h | 2 drivers/net/wireless/broadcom/b43legacy/b43legacy.h | 2 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 10 drivers/power/supply/bq27xxx_battery.c | 4 drivers/regulator/da9052-regulator.c | 2 drivers/regulator/da9055-regulator.c | 2 drivers/scsi/Kconfig | 2 drivers/scsi/dpt_i2o.c | 262 ---------- drivers/scsi/dpti.h | 1 drivers/scsi/scsi_lib.c | 2 drivers/scsi/stex.c | 4 drivers/tty/serial/fsl_lpuart.c | 44 - drivers/usb/gadget/function/f_fs.c | 2 drivers/vhost/net.c | 15 drivers/video/fbdev/core/bitblit.c | 3 drivers/video/fbdev/core/modedb.c | 5 drivers/video/fbdev/stifb.c | 1 fs/ext4/ext4.h | 2 fs/ext4/xattr.c | 4 include/linux/usb/cdc_ncm.h | 15 kernel/extable.c | 3 lib/dynamic_debug.c | 2 net/atm/resources.c | 2 net/bluetooth/hci_sock.c | 28 + net/core/sock.c | 2 net/ipv4/tcp.c | 3 net/netfilter/nf_conntrack_netlink.c | 4 net/netrom/nr_subr.c | 7 net/packet/af_packet.c | 8 net/packet/diag.c | 2 security/selinux/Makefile | 6 sound/core/oss/pcm_plugin.h | 16 sound/soc/codecs/ssm2602.c | 15 sound/soc/dwc/dwc-i2s.c | 4 sound/soc/intel/skylake/skl-tplg-interface.h | 3 65 files changed, 747 insertions(+), 490 deletions(-) Adam Borowski (1): ACPI: thermal: drop an always true check Al Viro (1): Fix double fget() in vhost_net_set_backend() Alexander Bersenev (2): cdc_ncm: Implement the 32-bit version of NCM Transfer Block cdc_ncm: Fix the build warning Andreas Svensson (1): net: dsa: mv88e6xxx: Increase wait after reset deactivation Arnd Bergmann (3): wifi: b43: fix incorrect __packed annotation ALSA: oss: avoid missing-prototype warnings atm: hide unused procfs functions Bart Van Assche (1): scsi: stex: Fix gcc 13 warnings Ben Hutchings (2): scsi: dpt_i2o: Remove broken pass-through ioctl (I2OUSERCMD) scsi: dpt_i2o: Do not process completions with invalid addresses Cambda Zhu (1): tcp: Return user_mss for TCP_MAXSEG in CLOSE/LISTEN state if user_mss set Cezary Rojewski (1): ASoC: Intel: Skylake: Fix declaration of enum skl_ch_cfg Damien Le Moal (1): ata: libata-scsi: Use correct device no in ata_find_dev() Dan Carpenter (1): mailbox: mailbox-test: fix a locking issue in mbox_test_message_write() Deren Wu (1): mmc: vub300: fix invalid response handling Eric Dumazet (2): netrom: fix info-leak in nr_write_internal() af_packet: do not use READ_ONCE() in packet_bind() Greg Kroah-Hartman (1): Linux 4.14.317 Haibo Li (1): ARM: 9295/1: unwind:fix unwind abort for uleb128 case Hans de Goede (1): power: supply: bq27xxx: After charger plug in/out wait 0.5s for things to stabilize Helge Deller (3): fbdev: modedb: Add 1920x1080 at 60 Hz video mode fbdev: stifb: Fix info entry in sti_struct on error path fbcon: Fix null-ptr-deref in soft_cursor Hyunwoo Kim (2): media: ttusb-dec: fix memory leak in ttusb_dec_exit_dvb() media: dvb-core: Fix use-after-free due to race condition at dvb_ca_en50221 Ivan Orlov (1): nbd: Fix debugfs_create_dir error checking Jakub Kicinski (1): wifi: rtlwifi: remove always-true condition pointed out by GCC 12 Jiakai Luo (1): iio: adc: mxs-lradc: fix the order of two cleanup operations Kees Cook (1): x86/boot: Wrap literal addresses in absolute_pointer() Kuniyuki Iwashima (1): af_packet: Fix data-races of pkt_sk(sk)->num. Lee Jones (1): mailbox: mailbox-test: Fix potential double-free in mbox_test_message_write() Linus Torvalds (1): gcc-12: disable '-Wdangling-pointer' warning for now Marek Vasut (1): iio: dac: mcp4725: Fix i2c_master_send() return value handling Martin Liška (1): eth: sun: cassini: remove dead code Maxim Kochetkov (1): ASoC: dwc: limit the number of overrun messages Nathan Chancellor (3): kernel/extable.c: use address-of operator on section symbols lib/dynamic_debug.c: use address-of operator on section symbols regulator: da905{2,5}: Remove unnecessary array check Nikita Zhandarovich (1): HID: wacom: avoid integer overflow in wacom_intuos_inout() Paul Moore (1): selinux: don't use make's grouped targets feature yet Paweł Anikiel (1): ASoC: ssm2602: Add workaround for playback distortions Ping-Ke Shih (1): wifi: rtlwifi: 8192de: correct checking of IQK reload Randy Dunlap (1): dmaengine: pl330: rename _start to prevent build error Ruihan Li (1): bluetooth: Add cmd validity checks at the start of hci_sock_ioctl() Sebastian Krzyszkowiak (1): net: usb: qmi_wwan: Set DTR quirk for BroadMobi BM818 Sherry Sun (1): tty: serial: fsl_lpuart: use UARTCTRL_TXINV to send break instead of UARTCTRL_SBK Takashi Iwai (1): media: dvb-core: Fix kernel WARNING for blocking operation in wait_event*() Theodore Ts'o (1): ext4: add lockdep annotations for i_data_sem for ea_inode's Tom Rix (1): netfilter: conntrack: define variables exp_nat_nla_policy and any_addr with CONFIG_NF_NAT Tudor Ambarus (1): net: cdc_ncm: Deal with too low values of dwNtbOutMaxSize Uttkarsh Aggarwal (1): usb: gadget: f_fs: Add unbind event before functionfs_unbind Vladislav Efanov (1): udp6: Fix race condition in udp6_sendmsg & connect Wei Chen (6): media: dvb-usb: az6027: fix three null-ptr-deref in az6027_i2c_xfer() media: dvb-usb-v2: ec168: fix null-ptr-deref in ec168_i2c_xfer() media: dvb-usb-v2: ce6230: fix null-ptr-deref in ce6230_i2c_master_xfer() media: dvb-usb: digitv: fix null-ptr-deref in digitv_i2c_xfer() media: dvb-usb: dw2102: fix uninit-value in su3000_read_mac_address media: netup_unidvb: fix irq init by register it at the end of probe Wenchao Hao (1): scsi: core: Decrease scsi_device's iorequest_cnt if dispatch failed Yun Lu (1): wifi: rtl8xxxu: fix authentication timeout due to incorrect RCR value Zhang Shurong (1): media: dvb-usb-v2: rtl28xxu: fix null-ptr-deref in rtl28xxu_i2c_xfer

1 year, 7 months

1
1
0 0

[PATCH] MIPS: cpu-features: Use boot_cpu_type for CPU type based features

by Jiaxun Yang

Some CPU feature macros were using current_cpu_type to mark feature availability. However current_cpu_type will use smp_processor_id, which is prohibited under preemptable context. Since those features are all uniform on all CPUs in a SMP system, use boot_cpu_type instead of current_cpu_type to fix preemptable kernel. Cc: stable(a)vger.kernel.org Signed-off-by: Jiaxun Yang <jiaxun.yang(a)flygoat.com> --- arch/mips/include/asm/cpu-features.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/include/asm/cpu-features.h b/arch/mips/include/asm/cpu-features.h index 2a0b90077b50..8c6d4a87db37 100644 --- a/arch/mips/include/asm/cpu-features.h +++ b/arch/mips/include/asm/cpu-features.h @@ -125,7 +125,7 @@ ({ \ int __res; \ \ - switch (current_cpu_type()) { \ + switch (boot_cpu_type()) { \ case CPU_CAVIUM_OCTEON: \ case CPU_CAVIUM_OCTEON_PLUS: \ case CPU_CAVIUM_OCTEON2: \ @@ -373,7 +373,7 @@ ({ \ int __res; \ \ - switch (current_cpu_type()) { \ + switch (boot_cpu_type()) { \ case CPU_M14KC: \ case CPU_74K: \ case CPU_1074K: \ -- 2.39.2 (Apple Git-143)

1 year, 7 months

2
1
0 0

[PATCH 1/2] mfd: pm8008: fix module autoloading

by Johan Hovold

Add the missing module device table alias to that the driver can be autoloaded when built as a module. Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC") Cc: stable(a)vger.kernel.org # 5.14 Signed-off-by: Johan Hovold <johan+linaro(a)kernel.org> --- drivers/mfd/qcom-pm8008.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c index 837246aab4ac..29ec3901564b 100644 --- a/drivers/mfd/qcom-pm8008.c +++ b/drivers/mfd/qcom-pm8008.c @@ -199,6 +199,7 @@ static const struct of_device_id pm8008_match[] = { { .compatible = "qcom,pm8008", }, { }, }; +MODULE_DEVICE_TABLE(of, pm8008_match); static struct i2c_driver pm8008_mfd_driver = { .driver = { -- 2.39.3

1 year, 7 months

4
7
0 0

+ nilfs2-fix-buffer-corruption-due-to-concurrent-device-reads.patch added to mm-hotfixes-unstable branch

by Andrew Morton

The patch titled Subject: nilfs2: fix buffer corruption due to concurrent device reads has been added to the -mm mm-hotfixes-unstable branch. Its filename is nilfs2-fix-buffer-corruption-due-to-concurrent-device-reads.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patche… This patch will later appear in the mm-hotfixes-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Ryusuke Konishi <konishi.ryusuke(a)gmail.com> Subject: nilfs2: fix buffer corruption due to concurrent device reads Date: Fri, 9 Jun 2023 12:57:32 +0900 As a result of analysis of a syzbot report, it turned out that in three cases where nilfs2 allocates block device buffers directly via sb_getblk, concurrent reads to the device can corrupt the allocated buffers. Nilfs2 uses sb_getblk for segment summary blocks, that make up a log header, and the super root block, that is the trailer, and when moving and writing the second super block after fs resize. In any of these, since the uptodate flag is not set when storing metadata to be written in the allocated buffers, the stored metadata will be overwritten if a device read of the same block occurs concurrently before the write. This causes metadata corruption and misbehavior in the log write itself, causing warnings in nilfs_btree_assign() as reported. Fix these issues by setting an uptodate flag on the buffer head on the first or before modifying each buffer obtained with sb_getblk, and clearing the flag on failure. When setting the uptodate flag, the lock_buffer/unlock_buffer pair is used to perform necessary exclusive control, and the buffer is filled to ensure that uninitialized bytes are not mixed into the data read from others. As for buffers for segment summary blocks, they are filled incrementally, so if the uptodate flag was unset on their allocation, set the flag and zero fill the buffer once at that point. Also, regarding the superblock move routine, the starting point of the memset call to zerofill the block is incorrectly specified, which can cause a buffer overflow on file systems with block sizes greater than 4KiB. In addition, if the superblock is moved within a large block, it is necessary to assume the possibility that the data in the superblock will be destroyed by zero-filling before copying. So fix these potential issues as well. Link: https://lkml.kernel.org/r/20230609035732.20426-1-konishi.ryusuke@gmail.com Signed-off-by: Ryusuke Konishi <konishi.ryusuke(a)gmail.com> Reported-by: syzbot+31837fe952932efc8fb9(a)syzkaller.appspotmail.com Closes: https://lkml.kernel.org/r/00000000000030000a05e981f475@google.com Tested-by: Ryusuke Konishi <konishi.ryusuke(a)gmail.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- fs/nilfs2/segbuf.c | 6 ++++++ fs/nilfs2/segment.c | 7 +++++++ fs/nilfs2/super.c | 23 ++++++++++++++++++++++- 3 files changed, 35 insertions(+), 1 deletion(-) --- a/fs/nilfs2/segbuf.c~nilfs2-fix-buffer-corruption-due-to-concurrent-device-reads +++ a/fs/nilfs2/segbuf.c @@ -101,6 +101,12 @@ int nilfs_segbuf_extend_segsum(struct ni if (unlikely(!bh)) return -ENOMEM; + lock_buffer(bh); + if (!buffer_uptodate(bh)) { + memset(bh->b_data, 0, bh->b_size); + set_buffer_uptodate(bh); + } + unlock_buffer(bh); nilfs_segbuf_add_segsum_buffer(segbuf, bh); return 0; } --- a/fs/nilfs2/segment.c~nilfs2-fix-buffer-corruption-due-to-concurrent-device-reads +++ a/fs/nilfs2/segment.c @@ -981,10 +981,13 @@ static void nilfs_segctor_fill_in_super_ unsigned int isz, srsz; bh_sr = NILFS_LAST_SEGBUF(&sci->sc_segbufs)->sb_super_root; + + lock_buffer(bh_sr); raw_sr = (struct nilfs_super_root *)bh_sr->b_data; isz = nilfs->ns_inode_size; srsz = NILFS_SR_BYTES(isz); + raw_sr->sr_sum = 0; /* Ensure initialization within this update */ raw_sr->sr_bytes = cpu_to_le16(srsz); raw_sr->sr_nongc_ctime = cpu_to_le64(nilfs_doing_gc() ? @@ -998,6 +1001,8 @@ static void nilfs_segctor_fill_in_super_ nilfs_write_inode_common(nilfs->ns_sufile, (void *)raw_sr + NILFS_SR_SUFILE_OFFSET(isz), 1); memset((void *)raw_sr + srsz, 0, nilfs->ns_blocksize - srsz); + set_buffer_uptodate(bh_sr); + unlock_buffer(bh_sr); } static void nilfs_redirty_inodes(struct list_head *head) @@ -1780,6 +1785,7 @@ static void nilfs_abort_logs(struct list list_for_each_entry(segbuf, logs, sb_list) { list_for_each_entry(bh, &segbuf->sb_segsum_buffers, b_assoc_buffers) { + clear_buffer_uptodate(bh); if (bh->b_page != bd_page) { if (bd_page) end_page_writeback(bd_page); @@ -1791,6 +1797,7 @@ static void nilfs_abort_logs(struct list b_assoc_buffers) { clear_buffer_async_write(bh); if (bh == segbuf->sb_super_root) { + clear_buffer_uptodate(bh); if (bh->b_page != bd_page) { end_page_writeback(bd_page); bd_page = bh->b_page; --- a/fs/nilfs2/super.c~nilfs2-fix-buffer-corruption-due-to-concurrent-device-reads +++ a/fs/nilfs2/super.c @@ -372,10 +372,31 @@ static int nilfs_move_2nd_super(struct s goto out; } nsbp = (void *)nsbh->b_data + offset; - memset(nsbp, 0, nilfs->ns_blocksize); + lock_buffer(nsbh); if (sb2i >= 0) { + /* + * The position of the second superblock only changes by 4KiB, + * which is larger than the maximum superblock data size + * (= 1KiB), so there is no need to use memmove() to allow + * overlap between source and destination. + */ memcpy(nsbp, nilfs->ns_sbp[sb2i], nilfs->ns_sbsize); + + /* + * Zero fill after copy to avoid overwriting in case of move + * within the same block. + */ + memset(nsbh->b_data, 0, offset); + memset((void *)nsbp + nilfs->ns_sbsize, 0, + nsbh->b_size - offset - nilfs->ns_sbsize); + } else { + memset(nsbh->b_data, 0, nsbh->b_size); + } + set_buffer_uptodate(nsbh); + unlock_buffer(nsbh); + + if (sb2i >= 0) { brelse(nilfs->ns_sbh[sb2i]); nilfs->ns_sbh[sb2i] = nsbh; nilfs->ns_sbp[sb2i] = nsbp; _ Patches currently in -mm which might be from konishi.ryusuke(a)gmail.com are nilfs2-fix-buffer-corruption-due-to-concurrent-device-reads.patch

1 year, 7 months

1
0
0 0

[PATCH V2 1/1] net: usb: qmi_wwan: add support for Compal RXM-G1

by Wes Huang

From: Wes Huang <wes.huang(a)moxa.com> Add support for Compal RXM-G1 which is based on Qualcomm SDX55 chip. This patch adds support for two compositions: 0x9091: DIAG + MODEM + QMI_RMNET + ADB 0x90db: DIAG + DUN + RMNET + DPL + QDSS(Trace) + ADB T: Bus=03 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=5000 MxCh= 0 D: Ver= 3.20 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 9 #Cfgs= 1 P: Vendor=05c6 ProdID=9091 Rev= 4.14 S: Manufacturer=QCOM S: Product=SDXPRAIRIE-MTP _SN:719AB680 S: SerialNumber=719ab680 C:* #Ifs= 4 Cfg#= 1 Atr=80 MxPwr=896mA I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=(none) E: Ad=81(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms E: Ad=01(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) E: Ad=83(I) Atr=03(Int.) MxPS= 10 Ivl=32ms E: Ad=82(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms E: Ad=02(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan E: Ad=84(I) Atr=03(Int.) MxPS= 8 Ivl=32ms E: Ad=8e(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms E: Ad=0f(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms I:* If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none) E: Ad=03(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms E: Ad=85(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms T: Bus=03 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=5000 MxCh= 0 D: Ver= 3.20 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 9 #Cfgs= 1 P: Vendor=05c6 ProdID=90db Rev= 4.14 S: Manufacturer=QCOM S: Product=SDXPRAIRIE-MTP _SN:719AB680 S: SerialNumber=719ab680 C:* #Ifs= 6 Cfg#= 1 Atr=80 MxPwr=896mA I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=(none) E: Ad=81(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms E: Ad=01(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) E: Ad=83(I) Atr=03(Int.) MxPS= 10 Ivl=32ms E: Ad=82(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms E: Ad=02(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan E: Ad=84(I) Atr=03(Int.) MxPS= 8 Ivl=32ms E: Ad=8e(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms E: Ad=0f(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms I:* If#= 3 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) E: Ad=8f(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms I:* If#= 4 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) E: Ad=85(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms I:* If#= 5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none) E: Ad=03(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms E: Ad=86(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms Cc: stable(a)vger.kernel.org Signed-off-by: Wes Huang <wes.huang(a)moxa.com> --- V1 -> V2: No code change, just add "From" to the email body to let author information is correct. drivers/net/usb/qmi_wwan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 571e37e67f9c..90f4655a671d 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c @@ -1220,7 +1220,9 @@ static const struct usb_device_id products[] = { {QMI_FIXED_INTF(0x05c6, 0x9080, 8)}, {QMI_FIXED_INTF(0x05c6, 0x9083, 3)}, {QMI_FIXED_INTF(0x05c6, 0x9084, 4)}, + {QMI_QUIRK_SET_DTR(0x05c6, 0x9091, 2)}, /* Compal RXM-G1 */ {QMI_FIXED_INTF(0x05c6, 0x90b2, 3)}, /* ublox R410M */ + {QMI_QUIRK_SET_DTR(0x05c6, 0x90db, 2)}, /* Compal RXM-G1 */ {QMI_FIXED_INTF(0x05c6, 0x920d, 0)}, {QMI_FIXED_INTF(0x05c6, 0x920d, 5)}, {QMI_QUIRK_SET_DTR(0x05c6, 0x9625, 4)}, /* YUGA CLM920-NC5 */ -- 2.30.2

1 year, 7 months

3
2
0 0

[PATCH v8 1/2] usb: gadget: udc: core: Offload usb_udc_vbus_handler processing

by Badhri Jagan Sridharan

usb_udc_vbus_handler() can be invoked from interrupt context by irq handlers of the gadget drivers, however, usb_udc_connect_control() has to run in non-atomic context due to the following: a. Some of the gadget driver implementations expect the ->pullup callback to be invoked in non-atomic context. b. usb_gadget_disconnect() acquires udc_lock which is a mutex. Hence offload invocation of usb_udc_connect_control() to workqueue. UDC should not be pulled up unless gadget driver is bound. The new flag "allow_connect" is now set by gadget_bind_driver() and cleared by gadget_unbind_driver(). This prevents work item to pull up the gadget even if queued when the gadget driver is already unbound. Cc: stable(a)vger.kernel.org Fixes: 1016fc0c096c ("USB: gadget: Fix obscure lockdep violation for udc_mutex") Signed-off-by: Badhri Jagan Sridharan <badhri(a)google.com> Reviewed-by: Alan Stern <stern(a)rowland.harvard.edu> --- Changes since v1: - Address Alan Stern's comment on usb_udc_vbus_handler invocation from atomic context: * vbus_events_lock is now a spinlock and allocations in * usb_udc_vbus_handler are atomic now. Changes since v2: - Addressing Alan Stern's comments: ** connect_lock is now held by callers of * usb_gadget_pullup_update_locked() and gadget_(un)bind_driver() does * notdirectly hold the lock. ** Both usb_gadget_(dis)connect() and usb_udc_vbus_handler() would * set/clear udc->vbus and invoke usb_gadget_pullup_update_locked. ** Add "unbinding" to prevent new connections after the gadget is being * unbound. Changes since v3: ** Made a minor cleanup which I missed to do in v3 in * usb_udc_vbus_handler(). Changes since v4: - Addressing Alan Stern's comments: ** usb_udc_vbus_handler() now offloads invocation of usb_udc_connect_control() * from workqueue. ** Dropped vbus_events list as this was redundant. Updating to the * latest value is suffice Changes since v5: - Addressing Alan Stern's comments: ** Squashed allow_connect logic to this patch. ** Fixed comment length to wrap at 76 ** Cancelling vbus_work in del_gadget() Changes since v6: - Added reviewed by tag Changes since v7: - None --- drivers/usb/gadget/udc/core.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index 52e6d2e84e35..d2e4f78c53e3 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -37,6 +37,9 @@ static const struct bus_type gadget_bus_type; * @vbus: for udcs who care about vbus status, this value is real vbus status; * for udcs who do not care about vbus status, this value is always true * @started: the UDC's started state. True if the UDC had started. + * @allow_connect: Indicates whether UDC is allowed to be pulled up. + * Set/cleared by gadget_(un)bind_driver() after gadget driver is bound or + * unbound. * * This represents the internal data structure which is used by the UDC-class * to hold information about udc driver and gadget together. @@ -48,6 +51,8 @@ struct usb_udc { struct list_head list; bool vbus; bool started; + bool allow_connect; + struct work_struct vbus_work; }; static struct class *udc_class; @@ -706,7 +711,7 @@ int usb_gadget_connect(struct usb_gadget *gadget) goto out; } - if (gadget->deactivated) { + if (gadget->deactivated || !gadget->udc->allow_connect) { /* * If gadget is deactivated we only save new state. * Gadget will be connected automatically after activation. @@ -1086,6 +1091,13 @@ static void usb_udc_connect_control(struct usb_udc *udc) usb_gadget_disconnect(udc->gadget); } +static void vbus_event_work(struct work_struct *work) +{ + struct usb_udc *udc = container_of(work, struct usb_udc, vbus_work); + + usb_udc_connect_control(udc); +} + /** * usb_udc_vbus_handler - updates the udc core vbus status, and try to * connect or disconnect gadget @@ -1094,6 +1106,14 @@ static void usb_udc_connect_control(struct usb_udc *udc) * * The udc driver calls it when it wants to connect or disconnect gadget * according to vbus status. + * + * This function can be invoked from interrupt context by irq handlers of + * the gadget drivers, however, usb_udc_connect_control() has to run in + * non-atomic context due to the following: + * a. Some of the gadget driver implementations expect the ->pullup + * callback to be invoked in non-atomic context. + * b. usb_gadget_disconnect() acquires udc_lock which is a mutex. + * Hence offload invocation of usb_udc_connect_control() to workqueue. */ void usb_udc_vbus_handler(struct usb_gadget *gadget, bool status) { @@ -1101,7 +1121,7 @@ void usb_udc_vbus_handler(struct usb_gadget *gadget, bool status) if (udc) { udc->vbus = status; - usb_udc_connect_control(udc); + schedule_work(&udc->vbus_work); } } EXPORT_SYMBOL_GPL(usb_udc_vbus_handler); @@ -1328,6 +1348,7 @@ int usb_add_gadget(struct usb_gadget *gadget) mutex_lock(&udc_lock); list_add_tail(&udc->list, &udc_list); mutex_unlock(&udc_lock); + INIT_WORK(&udc->vbus_work, vbus_event_work); ret = device_add(&udc->dev); if (ret) @@ -1459,6 +1480,7 @@ void usb_del_gadget(struct usb_gadget *gadget) flush_work(&gadget->work); device_del(&gadget->dev); ida_free(&gadget_id_numbers, gadget->id_number); + cancel_work_sync(&udc->vbus_work); device_unregister(&udc->dev); } EXPORT_SYMBOL_GPL(usb_del_gadget); @@ -1527,6 +1549,7 @@ static int gadget_bind_driver(struct device *dev) if (ret) goto err_start; usb_gadget_enable_async_callbacks(udc); + udc->allow_connect = true; usb_udc_connect_control(udc); kobject_uevent(&udc->dev.kobj, KOBJ_CHANGE); @@ -1558,6 +1581,8 @@ static void gadget_unbind_driver(struct device *dev) kobject_uevent(&udc->dev.kobj, KOBJ_CHANGE); + udc->allow_connect = false; + cancel_work_sync(&udc->vbus_work); usb_gadget_disconnect(gadget); usb_gadget_disable_async_callbacks(udc); if (gadget->irq) base-commit: d37537a1f7cf09e304fe7993cb5e732534a0fb22 -- 2.41.0.162.gfafddb0af9-goog

1 year, 7 months

2
2
0 0

[PATCH v7 1/2] usb: gadget: udc: core: Offload usb_udc_vbus_handler processing

by Badhri Jagan Sridharan

usb_udc_vbus_handler() can be invoked from interrupt context by irq handlers of the gadget drivers, however, usb_udc_connect_control() has to run in non-atomic context due to the following: a. Some of the gadget driver implementations expect the ->pullup callback to be invoked in non-atomic context. b. usb_gadget_disconnect() acquires udc_lock which is a mutex. Hence offload invocation of usb_udc_connect_control() to workqueue. UDC should not be pulled up unless gadget driver is bound. The new flag "allow_connect" is now set by gadget_bind_driver() and cleared by gadget_unbind_driver(). This prevents work item to pull up the gadget even if queued when the gadget driver is already unbound. Cc: stable(a)vger.kernel.org Fixes: 1016fc0c096c ("USB: gadget: Fix obscure lockdep violation for udc_mutex") Signed-off-by: Badhri Jagan Sridharan <badhri(a)google.com> Reviewed-by: Alan Stern <stern(a)rowland.harvard.edu> --- Changes since v1: - Address Alan Stern's comment on usb_udc_vbus_handler invocation from atomic context: * vbus_events_lock is now a spinlock and allocations in * usb_udc_vbus_handler are atomic now. Changes since v2: - Addressing Alan Stern's comments: ** connect_lock is now held by callers of * usb_gadget_pullup_update_locked() and gadget_(un)bind_driver() does * notdirectly hold the lock. ** Both usb_gadget_(dis)connect() and usb_udc_vbus_handler() would * set/clear udc->vbus and invoke usb_gadget_pullup_update_locked. ** Add "unbinding" to prevent new connections after the gadget is being * unbound. Changes since v3: ** Made a minor cleanup which I missed to do in v3 in * usb_udc_vbus_handler(). Changes since v4: - Addressing Alan Stern's comments: ** usb_udc_vbus_handler() now offloads invocation of usb_udc_connect_control() * from workqueue. ** Dropped vbus_events list as this was redundant. Updating to the * latest value is suffice Changes since v5: - Addressing Alan Stern's comments: ** Squashed allow_connect logic to this patch. ** Fixed comment length to wrap at 76 ** Cancelling vbus_work in del_gadget() Changes since v6: - Added reviewed by tag --- drivers/usb/gadget/udc/core.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index 52e6d2e84e35..d2e4f78c53e3 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -37,6 +37,9 @@ static const struct bus_type gadget_bus_type; * @vbus: for udcs who care about vbus status, this value is real vbus status; * for udcs who do not care about vbus status, this value is always true * @started: the UDC's started state. True if the UDC had started. + * @allow_connect: Indicates whether UDC is allowed to be pulled up. + * Set/cleared by gadget_(un)bind_driver() after gadget driver is bound or + * unbound. * * This represents the internal data structure which is used by the UDC-class * to hold information about udc driver and gadget together. @@ -48,6 +51,8 @@ struct usb_udc { struct list_head list; bool vbus; bool started; + bool allow_connect; + struct work_struct vbus_work; }; static struct class *udc_class; @@ -706,7 +711,7 @@ int usb_gadget_connect(struct usb_gadget *gadget) goto out; } - if (gadget->deactivated) { + if (gadget->deactivated || !gadget->udc->allow_connect) { /* * If gadget is deactivated we only save new state. * Gadget will be connected automatically after activation. @@ -1086,6 +1091,13 @@ static void usb_udc_connect_control(struct usb_udc *udc) usb_gadget_disconnect(udc->gadget); } +static void vbus_event_work(struct work_struct *work) +{ + struct usb_udc *udc = container_of(work, struct usb_udc, vbus_work); + + usb_udc_connect_control(udc); +} + /** * usb_udc_vbus_handler - updates the udc core vbus status, and try to * connect or disconnect gadget @@ -1094,6 +1106,14 @@ static void usb_udc_connect_control(struct usb_udc *udc) * * The udc driver calls it when it wants to connect or disconnect gadget * according to vbus status. + * + * This function can be invoked from interrupt context by irq handlers of + * the gadget drivers, however, usb_udc_connect_control() has to run in + * non-atomic context due to the following: + * a. Some of the gadget driver implementations expect the ->pullup + * callback to be invoked in non-atomic context. + * b. usb_gadget_disconnect() acquires udc_lock which is a mutex. + * Hence offload invocation of usb_udc_connect_control() to workqueue. */ void usb_udc_vbus_handler(struct usb_gadget *gadget, bool status) { @@ -1101,7 +1121,7 @@ void usb_udc_vbus_handler(struct usb_gadget *gadget, bool status) if (udc) { udc->vbus = status; - usb_udc_connect_control(udc); + schedule_work(&udc->vbus_work); } } EXPORT_SYMBOL_GPL(usb_udc_vbus_handler); @@ -1328,6 +1348,7 @@ int usb_add_gadget(struct usb_gadget *gadget) mutex_lock(&udc_lock); list_add_tail(&udc->list, &udc_list); mutex_unlock(&udc_lock); + INIT_WORK(&udc->vbus_work, vbus_event_work); ret = device_add(&udc->dev); if (ret) @@ -1459,6 +1480,7 @@ void usb_del_gadget(struct usb_gadget *gadget) flush_work(&gadget->work); device_del(&gadget->dev); ida_free(&gadget_id_numbers, gadget->id_number); + cancel_work_sync(&udc->vbus_work); device_unregister(&udc->dev); } EXPORT_SYMBOL_GPL(usb_del_gadget); @@ -1527,6 +1549,7 @@ static int gadget_bind_driver(struct device *dev) if (ret) goto err_start; usb_gadget_enable_async_callbacks(udc); + udc->allow_connect = true; usb_udc_connect_control(udc); kobject_uevent(&udc->dev.kobj, KOBJ_CHANGE); @@ -1558,6 +1581,8 @@ static void gadget_unbind_driver(struct device *dev) kobject_uevent(&udc->dev.kobj, KOBJ_CHANGE); + udc->allow_connect = false; + cancel_work_sync(&udc->vbus_work); usb_gadget_disconnect(gadget); usb_gadget_disable_async_callbacks(udc); if (gadget->irq) base-commit: d37537a1f7cf09e304fe7993cb5e732534a0fb22 -- 2.41.0.162.gfafddb0af9-goog

1 year, 7 months

2
3
0 0

+ afs-fix-waiting-for-writeback-then-skipping-folio.patch added to mm-hotfixes-unstable branch

by Andrew Morton

The patch titled Subject: afs: fix waiting for writeback then skipping folio has been added to the -mm mm-hotfixes-unstable branch. Its filename is afs-fix-waiting-for-writeback-then-skipping-folio.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patche… This patch will later appear in the mm-hotfixes-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: "Vishal Moola (Oracle)" <vishal.moola(a)gmail.com> Subject: afs: fix waiting for writeback then skipping folio Date: Wed, 7 Jun 2023 13:41:20 -0700 Commit acc8d8588cb7 converted afs_writepages_region() to write back a folio batch. The function waits for writeback to a folio, but then proceeds to the rest of the batch without trying to write that folio again. This patch fixes has it attempt to write the folio again. This has only been compile tested. Link: https://lkml.kernel.org/r/20230607204120.89416-2-vishal.moola@gmail.com Fixes: acc8d8588cb7 ("afs: convert afs_writepages_region() to use filemap_get_folios_tag()") Signed-off-by: Vishal Moola (Oracle) <vishal.moola(a)gmail.com> Cc: David Howells <dhowells(a)redhat.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- fs/afs/write.c | 2 ++ 1 file changed, 2 insertions(+) --- a/fs/afs/write.c~afs-fix-waiting-for-writeback-then-skipping-folio +++ a/fs/afs/write.c @@ -731,6 +731,7 @@ static int afs_writepages_region(struct * (changing page->mapping to NULL), or even swizzled * back from swapper_space to tmpfs file mapping */ +try_again: if (wbc->sync_mode != WB_SYNC_NONE) { ret = folio_lock_killable(folio); if (ret < 0) { @@ -757,6 +758,7 @@ static int afs_writepages_region(struct #ifdef CONFIG_AFS_FSCACHE folio_wait_fscache(folio); #endif + goto try_again; } else { start += folio_size(folio); } _ Patches currently in -mm which might be from vishal.moola(a)gmail.com are afs-fix-dangling-folio-ref-counts-in-writeback.patch afs-fix-waiting-for-writeback-then-skipping-folio.patch

1 year, 7 months

1
0
0 0

+ afs-fix-dangling-folio-ref-counts-in-writeback.patch added to mm-hotfixes-unstable branch

by Andrew Morton

The patch titled Subject: afs: fix dangling folio ref counts in writeback has been added to the -mm mm-hotfixes-unstable branch. Its filename is afs-fix-dangling-folio-ref-counts-in-writeback.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patche… This patch will later appear in the mm-hotfixes-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: "Vishal Moola (Oracle)" <vishal.moola(a)gmail.com> Subject: afs: fix dangling folio ref counts in writeback Date: Wed, 7 Jun 2023 13:41:19 -0700 Commit acc8d8588cb7 converted afs_writepages_region() to write back a folio batch. If writeback needs rescheduling, the function exits without dropping the references to the folios in fbatch. This patch fixes that. Link: https://lkml.kernel.org/r/20230607204120.89416-1-vishal.moola@gmail.com Fixes: acc8d8588cb7 ("afs: convert afs_writepages_region() to use filemap_get_folios_tag()") Signed-off-by: Vishal Moola (Oracle) <vishal.moola(a)gmail.com> Cc: David Howells <dhowells(a)redhat.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- fs/afs/write.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/afs/write.c~afs-fix-dangling-folio-ref-counts-in-writeback +++ a/fs/afs/write.c @@ -764,6 +764,7 @@ static int afs_writepages_region(struct if (skips >= 5 || need_resched()) { *_next = start; _leave(" = 0 [%llx]", *_next); + folio_batch_release(&fbatch); return 0; } skips++; _ Patches currently in -mm which might be from vishal.moola(a)gmail.com are afs-fix-dangling-folio-ref-counts-in-writeback.patch afs-fix-waiting-for-writeback-then-skipping-folio.patch

1 year, 7 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror June 2023