This is the start of the stable review cycle for the 4.19.286 release.
There are 23 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Wed, 14 Jun 2023 10:16:41 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.286-r…
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Linux 4.19.286-rc1
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Revert "staging: rtl8192e: Replace macro RTL_PCI_DEVICE with PCI_DEVICE"
Zixuan Fu <r33s3n6(a)gmail.com>
btrfs: unset reloc control if transaction commit fails in prepare_to_relocate()
Josef Bacik <josef(a)toxicpanda.com>
btrfs: check return value of btrfs_commit_transaction in relocation
Theodore Ts'o <tytso(a)mit.edu>
ext4: only check dquot_initialize_needed() when debugging
Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de>
i2c: sprd: Delete i2c adapter in .remove's error path
Martin Hundebøll <martin(a)geanix.com>
pinctrl: meson-axg: add missing GPIOA_18 gpio group
Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com>
Bluetooth: Fix use-after-free in hci_remove_ltk/hci_remove_irk
Xiubo Li <xiubli(a)redhat.com>
ceph: fix use-after-free bug for inodes when flushing capsnaps
Chia-I Wu <olvaffe(a)gmail.com>
drm/amdgpu: fix xclk freq on CHIP_STONEY
Dmitry Torokhov <dmitry.torokhov(a)gmail.com>
Input: psmouse - fix OOB access in Elantech protocol
Ismael Ferreras Morezuelas <swyterzone(a)gmail.com>
Input: xpad - delete a Razer DeathAdder mouse VID/PID entry
Vladislav Efanov <VEfanov(a)ispras.ru>
batman-adv: Broken sync while rescheduling delayed work
Ben Hutchings <ben(a)decadent.org.uk>
lib: cpu_rmap: Fix potential use-after-free in irq_cpu_rmap_release()
Hangyu Hua <hbh25y(a)gmail.com>
net: sched: fix possible refcount leak in tc_chain_tmplt_add()
Eric Dumazet <edumazet(a)google.com>
net: sched: move rtm_tca_policy declaration to include file
Eric Dumazet <edumazet(a)google.com>
rfs: annotate lockless accesses to RFS sock flow table
Eric Dumazet <edumazet(a)google.com>
rfs: annotate lockless accesses to sk->sk_rxhash
Sungwoo Kim <iam(a)sung-woo.kim>
Bluetooth: L2CAP: Add missing checks for invalid DCID
Ying Hsu <yinghsu(a)chromium.org>
Bluetooth: Fix l2cap_disconnect_req deadlock
Alexander Sverdlin <alexander.sverdlin(a)siemens.com>
net: dsa: lan9303: allow vid != 0 in port_fdb_{add|del} methods
Stephan Gerhold <stephan(a)gerhold.net>
spi: qup: Request DMA before enabling clocks
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
i40e: fix build warnings in i40e_alloc.h
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
i40iw: fix build warning in i40iw_manage_apbvt()
-------------
Diffstat:
Makefile | 4 +--
drivers/gpu/drm/amd/amdgpu/vi.c | 11 +++++++--
drivers/i2c/busses/i2c-sprd.c | 6 +++--
drivers/infiniband/hw/i40iw/i40iw.h | 5 ++--
drivers/input/joystick/xpad.c | 1 -
drivers/input/mouse/elantech.c | 9 ++++---
drivers/net/dsa/lan9303-core.c | 4 ---
drivers/net/ethernet/intel/i40e/i40e_alloc.h | 17 +++++--------
drivers/pinctrl/meson/pinctrl-meson-axg.c | 1 +
drivers/spi/spi-qup.c | 37 ++++++++++++++--------------
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 ++---
drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 5 ++++
fs/btrfs/relocation.c | 14 ++++++++---
fs/ceph/caps.c | 6 +++++
fs/ceph/snap.c | 4 ++-
fs/ext4/xattr.c | 6 +++--
include/linux/netdevice.h | 7 ++++--
include/net/pkt_sched.h | 2 ++
include/net/sock.h | 18 ++++++++++----
lib/cpu_rmap.c | 2 +-
net/batman-adv/distributed-arp-table.c | 2 +-
net/bluetooth/hci_core.c | 8 +++---
net/bluetooth/l2cap_core.c | 13 ++++++++++
net/core/dev.c | 6 +++--
net/sched/cls_api.c | 3 +--
25 files changed, 122 insertions(+), 75 deletions(-)
Hi there, hello,
Sometimes when I suspend (by closing the lid, less often - by pressing
Fn+F1 (sleep key combo)) or poweroff my laptop (both by pressing powerit
button and running "loginctl poweroff"), it goes in such a state when it
doesn't respond to opening/closing the lid, power button nor
Ctrl+Alt+Del, but, unlike in sleep mode, the fan is rotating and the
"awake status" LED is on. I checked /var/log/kern.log, but it didn't
report suspend at that moment at all: went straight from [UFW BLOCK] to
"Microcode updated" on force reboot (marked with an arrow):
Apr 13 10:40:32 bong kernel: asus_wmi: Unknown key code 0xcf
Apr 13 10:44:05 bong kernel: [UFW BLOCK] IN=wlan0 OUT= MAC=/*confidential*/
Apr 13 10:47:45 bong kernel: [UFW BLOCK] IN=wlan0 OUT= MAC=/*confidential*/
Apr 13 10:47:46 bong kernel: ICMPv6: NA: /*router*/ advertised our address /*ipv6*/ on wlan0!
Apr 13 10:47:48 bong last message buffered 2 times
-> Apr 13 10:49:11 bong kernel: [UFW BLOCK] IN=wlan0 OUT= MAC=/*confidential*/
Apr 13 10:52:34 bong kernel: microcode: microcode updated early to revision 0xf0, date = 2021-11-12
Apr 13 10:52:34 bong kernel: Linux version 6.1.23-bong+ (acid@bong) (gcc (Gentoo Hardened 12.2.1_p20230121-r1 p10) 12.2.1 20230121, GNU ld (Gentoo 2.39 p5) 2.39.0) #1 SMP PREEMPT_DYNAMIC Tue Apr 11 15:21:57 EEST 2023
Apr 13 10:52:34 bong kernel: Command line: root=/dev/genston/root ro loglevel=4 rd.lvm.vg=genston rd.luks.uuid=97d10669-2da1-452d-a372-887e420b2ad4 rd.luks.allow-discards pci=nomsi initrd=\x5cinitramfs-6.1.23-bong+.img
Apr 13 10:52:34 bong kernel: x86/fpu: Supporting XSAVE feature 0x001: 'x87 floating point registers'
Apr 13 10:52:34 bong kernel: x86/fpu: Supporting XSAVE feature 0x002: 'SSE registers'
Apr 13 10:52:34 bong kernel: x86/fpu: Supporting XSAVE feature 0x004: 'AVX registers'
Normally it starts like this (taken from dmesg to sync with elogind messages)
[ 7835.869228] elogind-daemon[2033]: Lid closed.
[ 7835.872875] elogind-daemon[2033]: Suspending...
[ 7835.873955] elogind-daemon[2033]: Suspending system...
[ 7835.873970] PM: suspend entry (deep)
[ 7835.902814] Filesystems sync: 0.028 seconds
[ 7835.920362] Freezing user space processes
[ 7835.923030] Freezing user space processes completed (elapsed 0.002 seconds)
[ 7835.923046] OOM killer disabled.
[ 7835.923049] Freezing remaining freezable tasks
[ 7835.924445] Freezing remaining freezable tasks completed (elapsed 0.001 seconds)
[ 7835.924624] printk: Suspending console(s) (use no_console_suspend to debug)
The issue appeared when I was using pf-kernel with genpatches and
updated from 6.1-pf2 to 6.1-pf3 (corresponding to vanilla versions 6.1.3
-> 6.1.6). I used that fork until 6.2-pf2, but since then (early March)
moved to vanilla sources and started following the 6.1.y branch when it
was declared LTS. And the issue was present on all of them.
The hang was last detected 3 days ago on 6.1.22 and today on 6.1.23.
I'd like to bisect it, but it could take ages for a couple of reasons:
1) I don't know exact patterns it follows. One of the scenarios I've
noticed was this one (sorry if too ridiculous):
- put the laptop on the nearby couch and simultaneously close
the lid; the loose charger jack might disconnect;
- lay the mouse upside down (so it doesn't wake up when I
reconnect the charger),
but it's not a 100% guarantee of the bug and, as I said earlier, the
laptop also misbehaves on shutdown.
2) The issue happens rarely, once in a few days (sometimes up to a week;
I haven't measured it precisely back then).
Hardware: https://tilde.cafe/u/acidbong/kernel/lspci (`lspci -vvnn`)
Config (latest vanilla): https://git.sr.ht/~acid-bong/kernel/tree/806e6639da610952798e1b5d8c0d700062…
Built with KCFLAGS="-march=native"
Isolated cmdline: root=/dev/genston/root ro loglevel=4 rd.lvm.vg=genston rd.luks.uuid=97d10669-2da1-452d-a372-887e420b2ad4 rd.luks.allow-discards pci=nomsi initrd=\initramfs-6.1.23-bong+.img
# regzbot introduced v6.1.3..v6.1.6
---
Regards,
~acidbong
On Wed, Jun 14, 2023 at 9:54 AM Stefan Hansson <newbyte(a)disroot.org> wrote:
> On 2023-06-13 23:31, Linus Walleij wrote:
> > I had the following weird phenomena on a mobile phone: while
> > the capacity in /sys/class/power_supply/ab8500_fg/capacity
> > would reflect the actual charge and capacity of the battery,
> > only 1/3 of the value was shown on the battery status
> > indicator and warnings for low battery appeared.
> >
> > It turns out that utemp, the Freedesktop temperature daemon,
> > will average all the power supplies of type "battery" in
> > /sys/class/power_supply/* if there is more than one battery.
>
> I assume you meant to say UPower rather than utemp here?
Yeah of course. Maybe Sebastian can fix with a bit of
git commit --amend when applying?
Thanks!
Yours,
Linus Walleij
If clk_get_rate() fails, the clk that has just been allocated needs to be
freed.
Cc: <stable(a)vger.kernel.org> # v3.3+
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org>
Reviewed-by: Andi Shyti <andi.shyti(a)kernel.org>
Fixes: 5f5a7a5578c5 ("serial: samsung: switch to clkdev based clock lookup")
Signed-off-by: Christophe JAILLET <christophe.jaillet(a)wanadoo.fr>
---
v2: Add an error message [Andi Shyti]
Add Cc: stable [Andi Shyti]
Add R-b tags
v1: https://lore.kernel.org/all/e4359d5ef206f5b349c1d15a515a1205e78dda55.168628…
Slightly unsure if Krzysztof's R-b should be kept or not.
v2 is not the same as v1, but the change looks small.
Sorry if I did wrong.
---
drivers/tty/serial/samsung_tty.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index 2a7520ad3abd..a92a23e1964e 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -1459,8 +1459,12 @@ static unsigned int s3c24xx_serial_getclk(struct s3c24xx_uart_port *ourport,
continue;
rate = clk_get_rate(clk);
- if (!rate)
+ if (!rate) {
+ dev_err(ourport->port.dev,
+ "Failed to get clock rate for %s.\n", clkname);
+ clk_put(clk);
continue;
+ }
if (ourport->info->has_divslot) {
unsigned long div = rate / req_baud;
--
2.34.1