May 2023 - Linux-stable-mirror

[iwlwifi] 6.3 regression, AX201 crash on traffic activity with Pixel 7, bisected

by evgeny nikiforov

Hello I have a laptop with Intel Wi-Fi 6 AX201. After updating from 6.2 to 6.3, I'm experiencing wifi crashes, wifi restart when traffic is flowing with Pixel 7 Pro (wifi 6E/802.11ax). Other older wifi devices probably not affected (tried Xiaomi pad with wifi 5/802.11ac). Tested with iperf3 in both directions, rsyncing Pixel photos to laptop, via router (wifi 5) or via Pixel wifi hotspot. The whole system freezes for seconds, no cursor movements possible at these moments (libinput "Touch jump detected and discarded" in logs indicating this). No problem with the 6.2 kernel. Bisecting leads to this commit of bumping FW API to 74 9ad1e7e5b0c488e4518edd698238a87ac6a73caa, looking strange to me, but reverting from 74 to 72 in 6.3 indeed successful with no crash. May 05 00:58:55 wpa_supplicant[862]: TDLS: Creating peer entry for ca:0e:48:5e:0d:f2 May 05 00:58:56 wpa_supplicant[862]: TDLS: Dialog Token in TPK M1 88 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: Error sending ADD_STA: time out after 2000ms. May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: Current CMD queue read_ptr 222 write_ptr 223 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: Start IWL Error Log Dump: May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: Transport status: 0x0000004A, valid: 6 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: Loaded firmware version: 74.a5e9588b.0 QuZ-a0-hr-b0-74.ucode May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000084 | NMI_INTERRUPT_UNKNOWN May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x000022F0 | trm_hw_status0 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000000 | trm_hw_status1 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x004CC44C | branchlink2 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00008A7E | interruptlink1 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00008A7E | interruptlink2 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x004C402C | data1 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x01000000 | data2 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000000 | data3 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x98001858 | beacon time May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x36EE67BE | tsf low May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000000 | tsf hi May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000000 | time gp1 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x0A2DDA07 | time gp2 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000001 | uCode revision type May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x0000004A | uCode version major May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0xA5E9588B | uCode version minor May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000351 | hw version May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x18C89001 | board version May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x80FAFD0B | hcmd May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00020000 | isr0 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000000 | isr1 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x28F04002 | isr2 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00C3030C | isr3 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000000 | isr4 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x04D2001C | last cmd Id May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x004C402C | wait_event May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000000 | l2p_control May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000000 | l2p_duration May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000000 | l2p_mhvalid May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000000 | l2p_addr_match May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000048 | lmpm_pmg_sel May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000000 | timestamp May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00008854 | flow_handler May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: Start IWL Error Log Dump: May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: Transport status: 0x0000004A, valid: 7 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x20000066 | NMI_INTERRUPT_HOST May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000000 | umac branchlink1 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x80456052 | umac branchlink2 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x804725A6 | umac interruptlink1 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x804658FE | umac interruptlink2 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x01000000 | umac data1 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x804658FE | umac data2 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000000 | umac data3 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x0000004A | umac major May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0xA5E9588B | umac minor May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x0A2DDA05 | frame pointer May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0xC0887EB0 | stack pointer May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00DE0118 | last host cmd May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00004008 | isr status reg May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: IML/ROM dump: May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000003 | IML/ROM error/state May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00005799 | IML/ROM data1 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000080 | IML/ROM WFPM_AUTH_KEY_0 May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: Fseq Registers: May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x60000041 | FSEQ_ERROR_CODE May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00290033 | FSEQ_TOP_INIT_VERSION May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00090006 | FSEQ_CNVIO_INIT_VERSION May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x0000A482 | FSEQ_OTP_VERSION May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x00000003 | FSEQ_TOP_CONTENT_VERSION May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x4552414E | FSEQ_ALIVE_TOKEN May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x20000302 | FSEQ_CNVI_ID May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x01300504 | FSEQ_CNVR_ID May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x20000302 | CNVI_AUX_MISC_CHIP May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x01300504 | CNVR_AUX_MISC_CHIP May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x05B0905B | CNVR_SCU_SD_REGS_SD_REG_DIG_DCDC_VTRIM May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: 0x0000025B | CNVR_SCU_SD_REGS_SD_REG_ACTIVE_VDIG_MIRROR May 05 00:58:58 kernel: iwlwifi 0000:00:14.3: WRT: Collecting data: ini trigger 4 fired (delay=0ms). May 05 00:58:58 kernel: ieee80211 phy0: Hardware restart was requested May 05 00:59:00 gnome-shell[1450]: libinput error: event10 - MSFT0004:00 06CB:CE2D Touchpad: kernel bug: Touch jump detected and discarded. May 05 00:59:00 gnome-shell[1450]: See https://wayland.freedesktop.org/libinput/doc/1.23.0/touchpad-jumping-cursor… for details May 05 00:59:02 kernel: ------------[ cut here ]------------ May 05 00:59:02 kernel: WARNING: CPU: 2 PID: 862 at drivers/net/wireless/intel/iwlwifi/mvm/../iwl-trans.h:1362 iwl_mvm_wait_sta_queues_empty+0x92/0xc0 [iwlmvm] May 05 00:59:02 kernel: Modules linked in: ccm snd_seq_dummy snd_hrtimer snd_seq rfcomm snd_seq_device cmac algif_hash algif_skcipher af_alg bridge stp llc bnep snd_ctl_led snd_soc_skl_hda_dsp snd_soc_intel_hda_dsp_common snd_sof_probes snd_soc_hdac_hdmi hid_sensor_prox hid_sensor_trigger industrialio_triggered_buffer hid_sensor_iio_common kfifo_buf industrialio hid_sensor_custom hid_sensor_hub intel_ishtp_hid vfat fat snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic iwlmvm ledtrig_audio snd_soc_dmic snd_sof_pci_intel_tgl snd_sof_intel_hda_common btusb btrtl snd_soc_hdac_hda btbcm snd_sof_pci btintel snd_sof_xtensa_dsp joydev btmtk mousedev snd_sof_intel_hda mac80211 bluetooth snd_sof snd_sof_utils snd_hda_ext_core snd_soc_acpi_intel_match snd_soc_acpi crc16 uvcvideo ecdh_generic snd_soc_core videobuf2_vmalloc videobuf2_memops snd_compress uvc videobuf2_v4l2 snd_hda_intel videodev snd_intel_dspcfg snd_hda_codec iTCO_wdt hid_multitouch x86_pkg_temp_thermal intel_pmc_bxt intel_powerclamp coretemp kvm_intel May 05 00:59:02 kernel: videobuf2_common mc libarc4 kvm iwlwifi mei_pxp mei_hdcp iTCO_vendor_support pmt_telemetry intel_rapl_msr snd_hwdep irqbypass pmt_class snd_hda_core rapl snd_pcm intel_cstate snd_timer cfg80211 intel_uncore spi_nor processor_thermal_device_pci_legacy pcspkr snd mei_me ucsi_acpi intel_soc_dts_iosf intel_ish_ipc processor_thermal_device processor_thermal_rfim typec_ucsi mtd intel_lpss_pci i2c_i801 processor_thermal_mbox intel_lpss roles i2c_smbus mei soundcore wmi_bmof processor_thermal_rapl idma64 intel_vsec typec intel_ishtp intel_rapl_common i2c_hid_acpi igen6_edac ideapad_laptop i2c_hid platform_profile rfkill int3403_thermal int340x_thermal_zone intel_hid int3400_thermal acpi_thermal_rel sparse_keymap acpi_pad mac_hid usbip_host usbip_core pkcs8_key_parser dm_multipath sg fuse crypto_user loop zram ip_tables x_tables dm_crypt cbc encrypted_keys trusted asn1_encoder tee dm_mod sdhci_pci cqhci crct10dif_pclmul crc32_pclmul sdhci polyval_clmulni polyval_generic nvme serio_raw mmc_core gf128mul atkbd May 05 00:59:02 kernel: ghash_clmulni_intel libps2 sha512_ssse3 vivaldi_fmap nvme_core aesni_intel crypto_simd i8042 cryptd xhci_pci spi_intel_pci spi_intel nvme_common xhci_pci_renesas serio i915 i2c_algo_bit drm_buddy intel_gtt video wmi drm_display_helper cec ttm btrfs blake2b_generic xor raid6_pq libcrc32c crc32c_generic crc32c_intel May 05 00:59:02 kernel: CPU: 2 PID: 862 Comm: wpa_supplicant Not tainted 6.3.1 #46 872b0abba9595f0d8ed586113c455b0be8334e0d May 05 00:59:02 kernel: Hardware name: LENOVO 82L3/LNVNB161216, BIOS GDCN63WW(V2.08) 09/26/2022 May 05 00:59:02 kernel: RIP: 0010:iwl_mvm_wait_sta_queues_empty+0x92/0xc0 [iwlmvm] May 05 00:59:02 kernel: Code: c3 28 4c 39 eb 75 b4 31 c0 5b 5d 41 5c 41 5d 41 5e c3 cc cc cc cc 0f 0b b8 f4 fd ff ff 5b 5d 41 5c 41 5d 41 5e c3 cc cc cc cc <0f> 0b 48 8b 7f 40 48 c7 c1 40 fb 96 c1 48 c7 c2 2e 00 98 c1 31 f6 May 05 00:59:02 kernel: RSP: 0018:ffffb4e74472f7a8 EFLAGS: 00010293 May 05 00:59:02 kernel: RAX: ffffffffc141d6d0 RBX: ffffa04dc5ff6d10 RCX: ffffa04dc6b220c8 May 05 00:59:02 kernel: RDX: 0000000000000001 RSI: 0000000000000004 RDI: ffffa04dc30e0028 May 05 00:59:02 kernel: RBP: 0000000000000004 R08: 0000000000000000 R09: 0000000000000000 May 05 00:59:02 kernel: R10: 0000000000000001 R11: 0000000000000100 R12: ffffa04dc5ff6cfc May 05 00:59:02 kernel: R13: ffffa04dc5ff6e78 R14: ffffa04dc6b22088 R15: 0000000000000000 May 05 00:59:02 kernel: FS: 00007fa743655ec0(0000) GS:ffffa0512fa80000(0000) knlGS:0000000000000000 May 05 00:59:02 kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 May 05 00:59:02 kernel: CR2: 000055665036a000 CR3: 0000000108e2e006 CR4: 0000000000f70ee0 May 05 00:59:02 kernel: PKRU: 55555554 May 05 00:59:02 kernel: Call Trace: May 05 00:59:02 kernel: <TASK> May 05 00:59:02 kernel: iwl_mvm_mac_flush+0x182/0x2e0 [iwlmvm 6d10fca3210c7a35f49263fea34411a52b4718fd] May 05 00:59:02 kernel: __ieee80211_flush_queues+0xaf/0x250 [mac80211 fdf58da67d59aa11fd56ae8c66d9a6051a561028] May 05 00:59:02 kernel: ieee80211_tdls_mgmt+0x104/0x420 [mac80211 fdf58da67d59aa11fd56ae8c66d9a6051a561028] May 05 00:59:02 kernel: nl80211_tdls_mgmt+0x110/0x210 [cfg80211 60e8cee0162d4fb4509cf55476b07c3f6e97646f] May 05 00:59:02 kernel: genl_family_rcv_msg_doit.isra.0+0xe3/0x140 May 05 00:59:02 kernel: genl_rcv_msg+0x1b6/0x2c0 May 05 00:59:02 kernel: ? __pfx_nl80211_pre_doit+0x10/0x10 [cfg80211 60e8cee0162d4fb4509cf55476b07c3f6e97646f] May 05 00:59:02 kernel: ? __pfx_nl80211_tdls_mgmt+0x10/0x10 [cfg80211 60e8cee0162d4fb4509cf55476b07c3f6e97646f] May 05 00:59:02 kernel: ? __pfx_nl80211_post_doit+0x10/0x10 [cfg80211 60e8cee0162d4fb4509cf55476b07c3f6e97646f] May 05 00:59:02 kernel: ? __pfx_genl_rcv_msg+0x10/0x10 May 05 00:59:02 kernel: netlink_rcv_skb+0x58/0x110 May 05 00:59:02 kernel: genl_rcv+0x28/0x40 May 05 00:59:02 kernel: netlink_unicast+0x19e/0x290 May 05 00:59:02 kernel: netlink_sendmsg+0x254/0x4d0 May 05 00:59:02 kernel: sock_sendmsg+0x93/0xa0 May 05 00:59:02 kernel: ____sys_sendmsg+0x27d/0x310 May 05 00:59:02 kernel: ? copy_msghdr_from_user+0x7d/0xc0 May 05 00:59:02 kernel: ___sys_sendmsg+0x9a/0xe0 May 05 00:59:02 kernel: __sys_sendmsg+0x7a/0xd0 May 05 00:59:02 kernel: do_syscall_64+0x5c/0x90 May 05 00:59:02 kernel: ? do_syscall_64+0x6b/0x90 May 05 00:59:02 kernel: ? _copy_from_user+0x4a/0x60 May 05 00:59:02 kernel: ? netlink_setsockopt+0x323/0x4a0 May 05 00:59:02 kernel: ? __sys_setsockopt+0xf2/0x1d0 May 05 00:59:02 kernel: ? syscall_exit_to_user_mode+0x1b/0x40 May 05 00:59:02 kernel: ? do_syscall_64+0x6b/0x90 May 05 00:59:02 kernel: ? do_syscall_64+0x6b/0x90 May 05 00:59:02 kernel: ? syscall_exit_to_user_mode+0x1b/0x40 May 05 00:59:02 kernel: ? do_syscall_64+0x6b/0x90 May 05 00:59:02 kernel: ? do_syscall_64+0x6b/0x90 May 05 00:59:02 kernel: entry_SYSCALL_64_after_hwframe+0x72/0xdc May 05 00:59:02 kernel: RIP: 0033:0x7fa743122e64 May 05 00:59:02 kernel: Code: 15 f9 de 0c 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 f3 0f 1e fa 80 3d 9d 66 0d 00 00 74 13 b8 2e 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 c3 0f 1f 00 48 83 ec 28 89 54 24 1c 48 89 May 05 00:59:02 kernel: RSP: 002b:00007ffc48fa8da8 EFLAGS: 00000202 ORIG_RAX: 000000000000002e May 05 00:59:02 kernel: RAX: ffffffffffffffda RBX: 0000560c9d3059d0 RCX: 00007fa743122e64 May 05 00:59:02 kernel: RDX: 0000000000000000 RSI: 00007ffc48fa8de0 RDI: 0000000000000006 May 05 00:59:02 kernel: RBP: 0000560c9d3a9d10 R08: 0000000000000004 R09: 0000000000000001 May 05 00:59:02 kernel: R10: 00007ffc48fa8ec0 R11: 0000000000000202 R12: 0000560c9d305cb0 May 05 00:59:02 kernel: R13: 00007ffc48fa8de0 R14: 0000000000000000 R15: 00007ffc48fa8ec0 May 05 00:59:02 kernel: </TASK> May 05 00:59:02 kernel: ---[ end trace 0000000000000000 ]--- May 05 00:59:02 kernel: iwlwifi 0000:00:14.3: iwl_trans_wait_txq_empty bad state = 0 May 05 00:59:02 wpa_supplicant[862]: wlan0: CTRL-EVENT-REGDOM-CHANGE init=DRIVER type=WORLD May 05 00:59:02 wpa_supplicant[862]: wlan0: CTRL-EVENT-SIGNAL-CHANGE above=1 signal=-46 noise=9999 txrate=26000 May 05 00:59:03 wpa_supplicant[862]: TDLS: Creating peer entry for ca:0e:48:5e:0d:f2 May 05 00:59:04 wpa_supplicant[862]: TDLS: Dialog Token in TPK M1 90 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: Error sending ADD_STA: time out after 2000ms. May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: Current CMD queue read_ptr 80 write_ptr 81 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: Start IWL Error Log Dump: May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: Transport status: 0x0000004A, valid: 6 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: Loaded firmware version: 74.a5e9588b.0 QuZ-a0-hr-b0-74.ucode May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00000084 | NMI_INTERRUPT_UNKNOWN May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x0080A210 | trm_hw_status0 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00000000 | trm_hw_status1 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x004CC44C | branchlink2 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x004C2616 | interruptlink1 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x004C2616 | interruptlink2 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00014D94 | data1 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x01000000 | data2 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00000000 | data3 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x08C189F2 | beacon time May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x3766D630 | tsf low May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00000000 | tsf hi May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00000000 | time gp1 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00379615 | time gp2 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00000001 | uCode revision type May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x0000004A | uCode version major May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0xA5E9588B | uCode version minor May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00000351 | hw version May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x18C89001 | board version May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x80C8F400 | hcmd May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x24020000 | isr0 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x01000000 | isr1 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x08F0000A | isr2 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00C300CC | isr3 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00000000 | isr4 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x0200001C | last cmd Id May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00014D94 | wait_event May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00000080 | l2p_control May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00010034 | l2p_duration May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x0000003F | l2p_mhvalid May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x000000CE | l2p_addr_match May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00000009 | lmpm_pmg_sel May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00000000 | timestamp May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x0000A8A8 | flow_handler May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: Start IWL Error Log Dump: May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: Transport status: 0x0000004A, valid: 7 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x20000066 | NMI_INTERRUPT_HOST May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00000000 | umac branchlink1 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x80456052 | umac branchlink2 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x804725A6 | umac interruptlink1 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x804725A6 | umac interruptlink2 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x01000000 | umac data1 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x804725A6 | umac data2 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00000000 | umac data3 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x0000004A | umac major May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0xA5E9588B | umac minor May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00379613 | frame pointer May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0xC0886260 | stack pointer May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00500118 | last host cmd May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00000000 | isr status reg May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: IML/ROM dump: May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00000003 | IML/ROM error/state May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00005751 | IML/ROM data1 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00000080 | IML/ROM WFPM_AUTH_KEY_0 May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: Fseq Registers: May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x60000000 | FSEQ_ERROR_CODE May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x80290033 | FSEQ_TOP_INIT_VERSION May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00090006 | FSEQ_CNVIO_INIT_VERSION May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x0000A482 | FSEQ_OTP_VERSION May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x00000003 | FSEQ_TOP_CONTENT_VERSION May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x4552414E | FSEQ_ALIVE_TOKEN May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x20000302 | FSEQ_CNVI_ID May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x01300504 | FSEQ_CNVR_ID May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x20000302 | CNVI_AUX_MISC_CHIP May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x01300504 | CNVR_AUX_MISC_CHIP May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x05B0905B | CNVR_SCU_SD_REGS_SD_REG_DIG_DCDC_VTRIM May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: 0x0000025B | CNVR_SCU_SD_REGS_SD_REG_ACTIVE_VDIG_MIRROR May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: WRT: Collecting data: ini trigger 4 fired (delay=0ms). May 05 00:59:06 kernel: ieee80211 phy0: Hardware restart was requested May 05 00:59:06 kernel: iwlwifi 0000:00:14.3: iwl_trans_wait_txq_empty bad state = 0 May 05 00:59:11 wpa_supplicant[862]: wlan0: CTRL-EVENT-REGDOM-CHANGE init=DRIVER type=WORLD May 05 00:59:11 wpa_supplicant[862]: wlan0: CTRL-EVENT-SIGNAL-CHANGE above=1 signal=-46 noise=9999 txrate=26000 May 05 00:59:20 wpa_supplicant[862]: wlan0: CTRL-EVENT-SIGNAL-CHANGE above=1 signal=-39 noise=9999 txrate=234000 $ iperf3 -s ----------------------------------------------------------- Server listening on 5201 (test #1) ----------------------------------------------------------- Accepted connection from 192.168.1.121, port 45048 [ 5] local 192.168.1.179 port 5201 connected to 192.168.1.121 port 45058 [ ID] Interval Transfer Bitrate [ 5] 0.00-1.00 sec 21.2 KBytes 174 Kbits/sec [ 5] 1.00-2.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 2.00-3.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 3.00-4.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 4.00-5.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 5.00-6.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 6.00-7.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 7.00-8.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 8.00-9.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 9.00-10.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 10.00-10.13 sec 0.00 Bytes 0.00 bits/sec - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bitrate [ 5] 0.00-10.13 sec 21.2 KBytes 17.2 Kbits/sec receiver ----------------------------------------------------------- Server listening on 5201 (test #2) ----------------------------------------------------------- Accepted connection from 192.168.1.121, port 52066 [ 5] local 192.168.1.179 port 5201 connected to 192.168.1.121 port 52082 [ ID] Interval Transfer Bitrate [ 5] 0.00-1.00 sec 16.2 MBytes 136 Mbits/sec [ 5] 1.00-2.00 sec 8.06 MBytes 67.5 Mbits/sec [ 5] 2.00-3.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 3.00-4.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 4.00-5.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 5.00-6.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 6.00-7.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 7.00-8.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 8.00-9.00 sec 11.9 MBytes 100 Mbits/sec [ 5] 9.00-10.00 sec 4.60 MBytes 38.6 Mbits/sec - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bitrate [ 5] 0.00-10.01 sec 40.8 MBytes 34.2 Mbits/sec receiver Linux 6.2.14, no crash, good performance: May 05 00:35:22 kernel: iwlwifi 0000:00:14.3: TLV_FW_FSEQ_VERSION: FSEQ Version: 89.3.35.37 May 05 00:35:22 kernel: iwlwifi 0000:00:14.3: loaded firmware version 72.daa05125.0 QuZ-a0-hr-b0-72.ucode op_mode iwlmvm May 05 00:35:23 kernel: iwlwifi 0000:00:14.3: Detected Intel(R) Wi-Fi 6 AX201 160MHz, REV=0x351 May 05 00:35:23 kernel: iwlwifi 0000:00:14.3: Detected RF HR B3, rfid=0x10a100 May 05 01:03:35 wpa_supplicant[845]: TDLS: Creating peer entry for ca:0e:48:5e:0d:f2 May 05 01:03:36 wpa_supplicant[845]: TDLS: Dialog Token in TPK M1 92 May 05 01:03:36 wpa_supplicant[845]: nl80211: kernel reports: key addition failed May 05 01:03:36 wpa_supplicant[845]: TDLS: Failed to set TPK to the driver May 05 01:03:36 kernel: iwlwifi 0000:00:14.3: Unhandled alg: 0x2000707 $ iperf3 -s ----------------------------------------------------------- Server listening on 5201 (test #1) ----------------------------------------------------------- Accepted connection from 192.168.1.121, port 39920 [ 5] local 192.168.1.179 port 5201 connected to 192.168.1.121 port 39934 [ ID] Interval Transfer Bitrate [ 5] 0.00-1.00 sec 17.8 MBytes 149 Mbits/sec [ 5] 1.00-2.00 sec 9.93 MBytes 83.3 Mbits/sec [ 5] 2.00-3.00 sec 27.8 MBytes 233 Mbits/sec [ 5] 3.00-4.00 sec 32.9 MBytes 276 Mbits/sec [ 5] 4.00-5.00 sec 32.7 MBytes 274 Mbits/sec [ 5] 5.00-6.00 sec 33.4 MBytes 280 Mbits/sec [ 5] 6.00-7.00 sec 32.0 MBytes 269 Mbits/sec [ 5] 7.00-8.00 sec 32.6 MBytes 273 Mbits/sec [ 5] 8.00-9.00 sec 32.5 MBytes 273 Mbits/sec [ 5] 9.00-10.00 sec 33.2 MBytes 278 Mbits/sec [ 5] 10.00-10.04 sec 1.28 MBytes 270 Mbits/sec - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bitrate [ 5] 0.00-10.04 sec 286 MBytes 239 Mbits/sec receiver

2 years

7
12
0 0

stable-rc/linux-4.14.y bisection: baseline.login on meson8b-odroidc1

by Ricardo Cañuelo

Culprit: https://lore.kernel.org/r/20211227180026.4068352-2-martin.blumenstingl@goog… On lun 27-12-2021 19:00:24, Martin Blumenstingl wrote: > The dt-bindings for the UART controller only allow the following values > for Meson6 SoCs: > - "amlogic,meson6-uart", "amlogic,meson-ao-uart" > - "amlogic,meson6-uart" > > Use the correct fallback compatible string "amlogic,meson-ao-uart" for > AO UART. Drop the "amlogic,meson-uart" compatible string from the EE > domain UART controllers. KernelCI detected that this patch introduced a regression in stable-rc/linux-4.14.y (4.14.267) on a meson8b-odroidc1. After this patch was applied the tests running on this platform don't show any serial output. This doesn't happen in other stable branches nor in mainline, but 4.14 hasn't still reached EOL and it'd be good to find a fix. Here's the bisection report: https://groups.io/g/kernelci-results/message/40147 KernelCI info: https://linux.kernelci.org/test/case/id/64234f7761021a30b262f776/ Test log: https://storage.kernelci.org/stable-rc/linux-4.14.y/v4.14.311-43-g88e481d60… Thanks, Ricardo

2 years

3
6
0 0

[PATCH v2 3/9] PCI/ASPM: Use RMW accessors for changing LNKCTL

by Ilpo Järvinen

Don't assume that the device is fully under the control of ASPM and use RMW capability accessors which do proper locking to avoid losing concurrent updates to the register values. If configuration fails in pcie_aspm_configure_common_clock(), the function attempts to restore the old PCI_EXP_LNKCTL_CCC settings. Store only the old PCI_EXP_LNKCTL_CCC bit for the relevant devices rather than the content of the whole LNKCTL registers. It aligns better with how pcie_lnkctl_clear_and_set() expects its parameter and makes the code more obvious to understand. Fixes: 4ec73791a64b ("PCI: Work around Pericom PCIe-to-PCI bridge Retrain Link erratum") Fixes: 86fa6a344209 ("PCI: Factor out pcie_retrain_link() function") Fixes: 2a42d9dba784 ("PCIe: ASPM: Break out of endless loop waiting for PCI config bits to switch") Fixes: 7d715a6c1ae5 ("PCI: add PCI Express ASPM support") Suggested-by: Lukas Wunner <lukas(a)wunner.de> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen(a)linux.intel.com> Cc: stable(a)vger.kernel.org --- drivers/pci/pcie/aspm.c | 39 ++++++++++++++++----------------------- 1 file changed, 16 insertions(+), 23 deletions(-) diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c index dde1ef13d0d1..426fb0bd8e3a 100644 --- a/drivers/pci/pcie/aspm.c +++ b/drivers/pci/pcie/aspm.c @@ -213,7 +213,6 @@ static bool pcie_wait_for_retrain(struct pci_dev *pdev) static bool pcie_retrain_link(struct pcie_link_state *link) { struct pci_dev *parent = link->pdev; - u16 reg16; /* * Ensure the updated LNKCTL parameters are used during link @@ -224,17 +223,14 @@ static bool pcie_retrain_link(struct pcie_link_state *link) if (!pcie_wait_for_retrain(parent)) return false; - pcie_capability_read_word(parent, PCI_EXP_LNKCTL, &reg16); - reg16 |= PCI_EXP_LNKCTL_RL; - pcie_capability_write_word(parent, PCI_EXP_LNKCTL, reg16); + pcie_capability_set_word(parent, PCI_EXP_LNKCTL, PCI_EXP_LNKCTL_RL); if (parent->clear_retrain_link) { /* * Due to an erratum in some devices the Retrain Link bit * needs to be cleared again manually to allow the link * training to succeed. */ - reg16 &= ~PCI_EXP_LNKCTL_RL; - pcie_capability_write_word(parent, PCI_EXP_LNKCTL, reg16); + pcie_capability_clear_word(parent, PCI_EXP_LNKCTL, PCI_EXP_LNKCTL_RL); } return pcie_wait_for_retrain(parent); @@ -248,7 +244,7 @@ static bool pcie_retrain_link(struct pcie_link_state *link) static void pcie_aspm_configure_common_clock(struct pcie_link_state *link) { int same_clock = 1; - u16 reg16, parent_reg, child_reg[8]; + u16 reg16, parent_old_ccc, child_old_ccc[8]; struct pci_dev *child, *parent = link->pdev; struct pci_bus *linkbus = parent->subordinate; /* @@ -270,6 +266,7 @@ static void pcie_aspm_configure_common_clock(struct pcie_link_state *link) /* Port might be already in common clock mode */ pcie_capability_read_word(parent, PCI_EXP_LNKCTL, &reg16); + parent_old_ccc = reg16 & PCI_EXP_LNKCTL_CCC; if (same_clock && (reg16 & PCI_EXP_LNKCTL_CCC)) { bool consistent = true; @@ -289,22 +286,16 @@ static void pcie_aspm_configure_common_clock(struct pcie_link_state *link) /* Configure downstream component, all functions */ list_for_each_entry(child, &linkbus->devices, bus_list) { pcie_capability_read_word(child, PCI_EXP_LNKCTL, &reg16); - child_reg[PCI_FUNC(child->devfn)] = reg16; - if (same_clock) - reg16 |= PCI_EXP_LNKCTL_CCC; - else - reg16 &= ~PCI_EXP_LNKCTL_CCC; - pcie_capability_write_word(child, PCI_EXP_LNKCTL, reg16); + child_old_ccc[PCI_FUNC(child->devfn)] = reg16 & PCI_EXP_LNKCTL_CCC; + pcie_capability_clear_and_set_word(child, PCI_EXP_LNKCTL, + PCI_EXP_LNKCTL_CCC, + same_clock ? PCI_EXP_LNKCTL_CCC : 0); } /* Configure upstream component */ - pcie_capability_read_word(parent, PCI_EXP_LNKCTL, &reg16); - parent_reg = reg16; - if (same_clock) - reg16 |= PCI_EXP_LNKCTL_CCC; - else - reg16 &= ~PCI_EXP_LNKCTL_CCC; - pcie_capability_write_word(parent, PCI_EXP_LNKCTL, reg16); + pcie_capability_clear_and_set_word(parent, PCI_EXP_LNKCTL, + PCI_EXP_LNKCTL_CCC, + same_clock ? PCI_EXP_LNKCTL_CCC : 0); if (pcie_retrain_link(link)) return; @@ -312,9 +303,11 @@ static void pcie_aspm_configure_common_clock(struct pcie_link_state *link) /* Training failed. Restore common clock configurations */ pci_err(parent, "ASPM: Could not configure common clock\n"); list_for_each_entry(child, &linkbus->devices, bus_list) - pcie_capability_write_word(child, PCI_EXP_LNKCTL, - child_reg[PCI_FUNC(child->devfn)]); - pcie_capability_write_word(parent, PCI_EXP_LNKCTL, parent_reg); + pcie_capability_clear_and_set_word(child, PCI_EXP_LNKCTL, + PCI_EXP_LNKCTL_CCC, + child_old_ccc[PCI_FUNC(child->devfn)]); + pcie_capability_clear_and_set_word(parent, PCI_EXP_LNKCTL, + PCI_EXP_LNKCTL_CCC, parent_old_ccc); } /* Convert L0s latency encoding to ns */ -- 2.30.2

2 years

4
5
0 0

[PATCH 1/2] usb: gadget: f_ncm: Add OS descriptor support

by Joakim Tjernlund

From: Romain Izard <romain.izard.pro(a)gmail.com> To be able to use the default USB class drivers available in Microsoft Windows, we need to add OS descriptors to the exported USB gadget to tell the OS that we are compatible with the built-in drivers. Copy the OS descriptor support from f_rndis into f_ncm. As a result, using the WINNCM compatible ID, the UsbNcm driver is loaded on enumeration without the need for a custom driver or inf file. Signed-off-by: Romain Izard <romain.izard.pro(a)gmail.com> Signed-off-by: Felipe Balbi <felipe.balbi(a)linux.intel.com> Signed-off-by: Joakim Tjernlund <joakim.tjernlund(a)infinera.com> Cc: stable(a)vger.kernel.org # v4.19 --- Seems to have been forgotten when backporting NCM fixes. Needed to make Win10 accept Linux NCM gadget ethernet drivers/usb/gadget/function/f_ncm.c | 47 +++++++++++++++++++++++++++-- drivers/usb/gadget/function/u_ncm.h | 3 ++ 2 files changed, 47 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/function/f_ncm.c b/drivers/usb/gadget/function/f_ncm.c index e4aa370e86a9..b4571633f7b5 100644 --- a/drivers/usb/gadget/function/f_ncm.c +++ b/drivers/usb/gadget/function/f_ncm.c @@ -23,6 +23,7 @@ #include "u_ether.h" #include "u_ether_configfs.h" #include "u_ncm.h" +#include "configfs.h" /* * This function is a "CDC Network Control Model" (CDC NCM) Ethernet link. @@ -1432,6 +1433,16 @@ static int ncm_bind(struct usb_configuration *c, struct usb_function *f) return -EINVAL; ncm_opts = container_of(f->fi, struct f_ncm_opts, func_inst); + + if (cdev->use_os_string) { + f->os_desc_table = kzalloc(sizeof(*f->os_desc_table), + GFP_KERNEL); + if (!f->os_desc_table) + return -ENOMEM; + f->os_desc_n = 1; + f->os_desc_table[0].os_desc = &ncm_opts->ncm_os_desc; + } + /* * in drivers/usb/gadget/configfs.c:configfs_composite_bind() * configurations are bound in sequence with list_for_each_entry, @@ -1445,13 +1456,15 @@ static int ncm_bind(struct usb_configuration *c, struct usb_function *f) status = gether_register_netdev(ncm_opts->net); mutex_unlock(&ncm_opts->lock); if (status) - return status; + goto fail; ncm_opts->bound = true; } us = usb_gstrings_attach(cdev, ncm_strings, ARRAY_SIZE(ncm_string_defs)); - if (IS_ERR(us)) - return PTR_ERR(us); + if (IS_ERR(us)) { + status = PTR_ERR(us); + goto fail; + } ncm_control_intf.iInterface = us[STRING_CTRL_IDX].id; ncm_data_nop_intf.iInterface = us[STRING_DATA_IDX].id; ncm_data_intf.iInterface = us[STRING_DATA_IDX].id; @@ -1468,6 +1481,10 @@ static int ncm_bind(struct usb_configuration *c, struct usb_function *f) ncm_control_intf.bInterfaceNumber = status; ncm_union_desc.bMasterInterface0 = status; + if (cdev->use_os_string) + f->os_desc_table[0].if_id = + ncm_iad_desc.bFirstInterface; + status = usb_interface_id(c, f); if (status < 0) goto fail; @@ -1547,6 +1564,9 @@ static int ncm_bind(struct usb_configuration *c, struct usb_function *f) return 0; fail: + kfree(f->os_desc_table); + f->os_desc_n = 0; + if (ncm->notify_req) { kfree(ncm->notify_req->buf); usb_ep_free_request(ncm->notify, ncm->notify_req); @@ -1601,16 +1621,22 @@ static void ncm_free_inst(struct usb_function_instance *f) gether_cleanup(netdev_priv(opts->net)); else free_netdev(opts->net); + kfree(opts->ncm_interf_group); kfree(opts); } static struct usb_function_instance *ncm_alloc_inst(void) { struct f_ncm_opts *opts; + struct usb_os_desc *descs[1]; + char *names[1]; + struct config_group *ncm_interf_group; opts = kzalloc(sizeof(*opts), GFP_KERNEL); if (!opts) return ERR_PTR(-ENOMEM); + opts->ncm_os_desc.ext_compat_id = opts->ncm_ext_compat_id; + mutex_init(&opts->lock); opts->func_inst.free_func_inst = ncm_free_inst; opts->net = gether_setup_default(); @@ -1619,8 +1645,20 @@ static struct usb_function_instance *ncm_alloc_inst(void) kfree(opts); return ERR_CAST(net); } + INIT_LIST_HEAD(&opts->ncm_os_desc.ext_prop); + + descs[0] = &opts->ncm_os_desc; + names[0] = "ncm"; config_group_init_type_name(&opts->func_inst.group, "", &ncm_func_type); + ncm_interf_group = + usb_os_desc_prepare_interf_dir(&opts->func_inst.group, 1, descs, + names, THIS_MODULE); + if (IS_ERR(ncm_interf_group)) { + ncm_free_inst(&opts->func_inst); + return ERR_CAST(ncm_interf_group); + } + opts->ncm_interf_group = ncm_interf_group; return &opts->func_inst; } @@ -1646,6 +1684,9 @@ static void ncm_unbind(struct usb_configuration *c, struct usb_function *f) hrtimer_cancel(&ncm->task_timer); + kfree(f->os_desc_table); + f->os_desc_n = 0; + ncm_string_defs[0].id = 0; usb_free_all_descriptors(f); diff --git a/drivers/usb/gadget/function/u_ncm.h b/drivers/usb/gadget/function/u_ncm.h index 67324f983343..dfd75ad61b3f 100644 --- a/drivers/usb/gadget/function/u_ncm.h +++ b/drivers/usb/gadget/function/u_ncm.h @@ -20,6 +20,9 @@ struct f_ncm_opts { struct net_device *net; bool bound; + struct config_group *ncm_interf_group; + struct usb_os_desc ncm_os_desc; + char ncm_ext_compat_id[16]; /* * Read/write access to configfs attributes is handled by configfs. * -- 2.39.3

2 years

4
9
0 0

[PATCH AUTOSEL 6.1 01/33] power: supply: ab8500: Fix external_power_changed race

by Sasha Levin

From: Hans de Goede <hdegoede(a)redhat.com> [ Upstream commit a5299ce4e96f3e8930e9c051b28d8093ada87b08 ] ab8500_btemp_external_power_changed() dereferences di->btemp_psy, which gets sets in ab8500_btemp_probe() like this: di->btemp_psy = devm_power_supply_register(dev, &ab8500_btemp_desc, &psy_cfg); As soon as devm_power_supply_register() has called device_add() the external_power_changed callback can get called. So there is a window where ab8500_btemp_external_power_changed() may get called while di->btemp_psy has not been set yet leading to a NULL pointer dereference. Fixing this is easy. The external_power_changed callback gets passed the power_supply which will eventually get stored in di->btemp_psy, so ab8500_btemp_external_power_changed() can simply directly use the passed in psy argument which is always valid. And the same applies to ab8500_fg_external_power_changed(). Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> Reviewed-by: Linus Walleij <linus.walleij(a)linaro.org> Signed-off-by: Sebastian Reichel <sebastian.reichel(a)collabora.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/power/supply/ab8500_btemp.c | 6 ++---- drivers/power/supply/ab8500_fg.c | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/power/supply/ab8500_btemp.c b/drivers/power/supply/ab8500_btemp.c index 307ee6f71042e..6f83e99d2eb72 100644 --- a/drivers/power/supply/ab8500_btemp.c +++ b/drivers/power/supply/ab8500_btemp.c @@ -624,10 +624,8 @@ static int ab8500_btemp_get_ext_psy_data(struct device *dev, void *data) */ static void ab8500_btemp_external_power_changed(struct power_supply *psy) { - struct ab8500_btemp *di = power_supply_get_drvdata(psy); - - class_for_each_device(power_supply_class, NULL, - di->btemp_psy, ab8500_btemp_get_ext_psy_data); + class_for_each_device(power_supply_class, NULL, psy, + ab8500_btemp_get_ext_psy_data); } /* ab8500 btemp driver interrupts and their respective isr */ diff --git a/drivers/power/supply/ab8500_fg.c b/drivers/power/supply/ab8500_fg.c index c6c9804280dbe..71ce28eed463f 100644 --- a/drivers/power/supply/ab8500_fg.c +++ b/drivers/power/supply/ab8500_fg.c @@ -2407,10 +2407,8 @@ static int ab8500_fg_init_hw_registers(struct ab8500_fg *di) */ static void ab8500_fg_external_power_changed(struct power_supply *psy) { - struct ab8500_fg *di = power_supply_get_drvdata(psy); - - class_for_each_device(power_supply_class, NULL, - di->fg_psy, ab8500_fg_get_ext_psy_data); + class_for_each_device(power_supply_class, NULL, psy, + ab8500_fg_get_ext_psy_data); } /** -- 2.39.2

2 years

2
33
0 0

[PATCH AUTOSEL 5.10 01/21] power: supply: ab8500: Fix external_power_changed race

by Sasha Levin

From: Hans de Goede <hdegoede(a)redhat.com> [ Upstream commit a5299ce4e96f3e8930e9c051b28d8093ada87b08 ] ab8500_btemp_external_power_changed() dereferences di->btemp_psy, which gets sets in ab8500_btemp_probe() like this: di->btemp_psy = devm_power_supply_register(dev, &ab8500_btemp_desc, &psy_cfg); As soon as devm_power_supply_register() has called device_add() the external_power_changed callback can get called. So there is a window where ab8500_btemp_external_power_changed() may get called while di->btemp_psy has not been set yet leading to a NULL pointer dereference. Fixing this is easy. The external_power_changed callback gets passed the power_supply which will eventually get stored in di->btemp_psy, so ab8500_btemp_external_power_changed() can simply directly use the passed in psy argument which is always valid. And the same applies to ab8500_fg_external_power_changed(). Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> Reviewed-by: Linus Walleij <linus.walleij(a)linaro.org> Signed-off-by: Sebastian Reichel <sebastian.reichel(a)collabora.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/power/supply/ab8500_btemp.c | 6 ++---- drivers/power/supply/ab8500_fg.c | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/power/supply/ab8500_btemp.c b/drivers/power/supply/ab8500_btemp.c index 4417d64c31f97..5a1adceb6974d 100644 --- a/drivers/power/supply/ab8500_btemp.c +++ b/drivers/power/supply/ab8500_btemp.c @@ -921,10 +921,8 @@ static int ab8500_btemp_get_ext_psy_data(struct device *dev, void *data) */ static void ab8500_btemp_external_power_changed(struct power_supply *psy) { - struct ab8500_btemp *di = power_supply_get_drvdata(psy); - - class_for_each_device(power_supply_class, NULL, - di->btemp_psy, ab8500_btemp_get_ext_psy_data); + class_for_each_device(power_supply_class, NULL, psy, + ab8500_btemp_get_ext_psy_data); } /* ab8500 btemp driver interrupts and their respective isr */ diff --git a/drivers/power/supply/ab8500_fg.c b/drivers/power/supply/ab8500_fg.c index a6b4a94c27662..a88590563647e 100644 --- a/drivers/power/supply/ab8500_fg.c +++ b/drivers/power/supply/ab8500_fg.c @@ -2380,10 +2380,8 @@ static int ab8500_fg_init_hw_registers(struct ab8500_fg *di) */ static void ab8500_fg_external_power_changed(struct power_supply *psy) { - struct ab8500_fg *di = power_supply_get_drvdata(psy); - - class_for_each_device(power_supply_class, NULL, - di->fg_psy, ab8500_fg_get_ext_psy_data); + class_for_each_device(power_supply_class, NULL, psy, + ab8500_fg_get_ext_psy_data); } /** -- 2.39.2

2 years

2
21
0 0

[PATCH AUTOSEL 4.14 01/10] power: supply: ab8500: Fix external_power_changed race

by Sasha Levin

From: Hans de Goede <hdegoede(a)redhat.com> [ Upstream commit a5299ce4e96f3e8930e9c051b28d8093ada87b08 ] ab8500_btemp_external_power_changed() dereferences di->btemp_psy, which gets sets in ab8500_btemp_probe() like this: di->btemp_psy = devm_power_supply_register(dev, &ab8500_btemp_desc, &psy_cfg); As soon as devm_power_supply_register() has called device_add() the external_power_changed callback can get called. So there is a window where ab8500_btemp_external_power_changed() may get called while di->btemp_psy has not been set yet leading to a NULL pointer dereference. Fixing this is easy. The external_power_changed callback gets passed the power_supply which will eventually get stored in di->btemp_psy, so ab8500_btemp_external_power_changed() can simply directly use the passed in psy argument which is always valid. And the same applies to ab8500_fg_external_power_changed(). Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> Reviewed-by: Linus Walleij <linus.walleij(a)linaro.org> Signed-off-by: Sebastian Reichel <sebastian.reichel(a)collabora.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/power/supply/ab8500_btemp.c | 6 ++---- drivers/power/supply/ab8500_fg.c | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/power/supply/ab8500_btemp.c b/drivers/power/supply/ab8500_btemp.c index 97423a04fc0f0..c58644a3345ce 100644 --- a/drivers/power/supply/ab8500_btemp.c +++ b/drivers/power/supply/ab8500_btemp.c @@ -976,10 +976,8 @@ static int ab8500_btemp_get_ext_psy_data(struct device *dev, void *data) */ static void ab8500_btemp_external_power_changed(struct power_supply *psy) { - struct ab8500_btemp *di = power_supply_get_drvdata(psy); - - class_for_each_device(power_supply_class, NULL, - di->btemp_psy, ab8500_btemp_get_ext_psy_data); + class_for_each_device(power_supply_class, NULL, psy, + ab8500_btemp_get_ext_psy_data); } /* ab8500 btemp driver interrupts and their respective isr */ diff --git a/drivers/power/supply/ab8500_fg.c b/drivers/power/supply/ab8500_fg.c index b00844103a07a..f99e248f6aed3 100644 --- a/drivers/power/supply/ab8500_fg.c +++ b/drivers/power/supply/ab8500_fg.c @@ -2384,10 +2384,8 @@ static int ab8500_fg_init_hw_registers(struct ab8500_fg *di) */ static void ab8500_fg_external_power_changed(struct power_supply *psy) { - struct ab8500_fg *di = power_supply_get_drvdata(psy); - - class_for_each_device(power_supply_class, NULL, - di->fg_psy, ab8500_fg_get_ext_psy_data); + class_for_each_device(power_supply_class, NULL, psy, + ab8500_fg_get_ext_psy_data); } /** -- 2.39.2

2 years

2
11
0 0

[PATCH AUTOSEL 6.1 01/57] nvme-pci: add NVME_QUIRK_BOGUS_NID for HS-SSD-FUTURE 2048G

by Sasha Levin

From: Sagi Grimberg <sagi(a)grimberg.me> [ Upstream commit 1616d6c3717bae9041a4240d381ec56ccdaafedc ] Add a quirk to fix HS-SSD-FUTURE 2048G SSD drives reporting duplicate nsids. Link: https://bugzilla.kernel.org/show_bug.cgi?id=217384 Reported-by: Andrey God <andreygod83(a)protonmail.com> Signed-off-by: Sagi Grimberg <sagi(a)grimberg.me> Signed-off-by: Christoph Hellwig <hch(a)lst.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/nvme/host/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 581bf94416e6d..3347e86b3c55f 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -3554,6 +3554,8 @@ static const struct pci_device_id nvme_id_table[] = { NVME_QUIRK_IGNORE_DEV_SUBNQN, }, { PCI_DEVICE(0x10ec, 0x5763), /* TEAMGROUP T-FORCE CARDEA ZERO Z330 SSD */ .driver_data = NVME_QUIRK_BOGUS_NID, }, + { PCI_DEVICE(0x1e4b, 0x1602), /* HS-SSD-FUTURE 2048G */ + .driver_data = NVME_QUIRK_BOGUS_NID, }, { PCI_DEVICE(PCI_VENDOR_ID_AMAZON, 0x0061), .driver_data = NVME_QUIRK_DMA_ADDRESS_BITS_48, }, { PCI_DEVICE(PCI_VENDOR_ID_AMAZON, 0x0065), -- 2.39.2

2 years

2
58
0 0

[PATCH AUTOSEL 6.3 01/67] nvme-pci: add NVME_QUIRK_BOGUS_NID for HS-SSD-FUTURE 2048G

by Sasha Levin

From: Sagi Grimberg <sagi(a)grimberg.me> [ Upstream commit 1616d6c3717bae9041a4240d381ec56ccdaafedc ] Add a quirk to fix HS-SSD-FUTURE 2048G SSD drives reporting duplicate nsids. Link: https://bugzilla.kernel.org/show_bug.cgi?id=217384 Reported-by: Andrey God <andreygod83(a)protonmail.com> Signed-off-by: Sagi Grimberg <sagi(a)grimberg.me> Signed-off-by: Christoph Hellwig <hch(a)lst.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/nvme/host/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index cd7873de31215..bbf96567365cd 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -3445,6 +3445,8 @@ static const struct pci_device_id nvme_id_table[] = { NVME_QUIRK_IGNORE_DEV_SUBNQN, }, { PCI_DEVICE(0x10ec, 0x5763), /* TEAMGROUP T-FORCE CARDEA ZERO Z330 SSD */ .driver_data = NVME_QUIRK_BOGUS_NID, }, + { PCI_DEVICE(0x1e4b, 0x1602), /* HS-SSD-FUTURE 2048G */ + .driver_data = NVME_QUIRK_BOGUS_NID, }, { PCI_DEVICE(PCI_VENDOR_ID_AMAZON, 0x0061), .driver_data = NVME_QUIRK_DMA_ADDRESS_BITS_48, }, { PCI_DEVICE(PCI_VENDOR_ID_AMAZON, 0x0065), -- 2.39.2

2 years

4
71
0 0

[PATCH AUTOSEL 4.14 01/20] ASoC: dwc: limit the number of overrun messages

by Sasha Levin

From: Maxim Kochetkov <fido_max(a)inbox.ru> [ Upstream commit ab6ecfbf40fccf74b6ec2ba7ed6dd2fc024c3af2 ] On slow CPU (FPGA/QEMU emulated) printing overrun messages from interrupt handler to uart console may leads to more overrun errors. So use dev_err_ratelimited to limit the number of error messages. Signed-off-by: Maxim Kochetkov <fido_max(a)inbox.ru Link: https://lore.kernel.org/r/20230505062820.21840-1-fido_max@inbox.ru Signed-off-by: Mark Brown <broonie(a)kernel.org Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/dwc/dwc-i2s.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c index e27e21f8569a0..e6a0ec3c0e764 100644 --- a/sound/soc/dwc/dwc-i2s.c +++ b/sound/soc/dwc/dwc-i2s.c @@ -132,13 +132,13 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id) /* Error Handling: TX */ if (isr[i] & ISR_TXFO) { - dev_err(dev->dev, "TX overrun (ch_id=%d)\n", i); + dev_err_ratelimited(dev->dev, "TX overrun (ch_id=%d)\n", i); irq_valid = true; } /* Error Handling: TX */ if (isr[i] & ISR_RXFO) { - dev_err(dev->dev, "RX overrun (ch_id=%d)\n", i); + dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i); irq_valid = true; } } -- 2.39.2

2 years

3
22
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror May 2023