April 2023 - Linux-stable-mirror

[PATCH STABLE 5.15.y] Reduce IPI overload when multiple CPUs cat /proc/cpuinfo.

by Imran Khan

On large systems with few hundred CPUs, when applications on each or most of these CPUs read proc/cpuinfo we get an IPI storm and situation gets worse if one of the CPUs can't respond to these IPIs timely. commit f4deaf90212c ('x86/cpu: Avoid cpuinfo-induced IPI pileups') addresses this but in the following call chain: show_cpuinfo | |-- aperfmperf_get_khz | |-- aperfmperf_snapshot_cpu aperfmperf_snapshot_cpu gets invoked with wait=true and this means we endup doing a smp_call_function_single to destination CPU, even if its ->scfpending is set. Avoid this by making sure that even with wait=true, IPI is send only if ->scfpending is not set. Signed-off-by: Imran Khan <imran.f.khan(a)oracle.com> --- I am trying this approach (assuming that its okay) to avoid backporting multiple upstream patches to fix this single issue. Kindly let me know if its okay or would it be better to backport the relevant upstream patches instead. arch/x86/kernel/cpu/aperfmperf.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/aperfmperf.c b/arch/x86/kernel/cpu/aperfmperf.c index 22911deacb6e4..39fc390cc56af 100644 --- a/arch/x86/kernel/cpu/aperfmperf.c +++ b/arch/x86/kernel/cpu/aperfmperf.c @@ -69,6 +69,7 @@ static void aperfmperf_snapshot_khz(void *dummy) static bool aperfmperf_snapshot_cpu(int cpu, ktime_t now, bool wait) { + int this_cpu; s64 time_delta = ktime_ms_delta(now, per_cpu(samples.time, cpu)); struct aperfmperf_sample *s = per_cpu_ptr(&samples, cpu); @@ -76,8 +77,14 @@ static bool aperfmperf_snapshot_cpu(int cpu, ktime_t now, bool wait) if (time_delta < APERFMPERF_CACHE_THRESHOLD_MS) return true; - if (!atomic_xchg(&s->scfpending, 1) || wait) + if (!atomic_xchg(&s->scfpending, 1)) smp_call_function_single(cpu, aperfmperf_snapshot_khz, NULL, wait); + else if (wait) { + this_cpu = get_cpu(); + while (atomic_read(&s->scfpending)) + cpu_relax(); + put_cpu(); + } /* Return false if the previous iteration was too long ago. */ return time_delta <= APERFMPERF_STALE_THRESHOLD_MS; -- 2.34.1

2 years, 1 month

2
1
0 0

[PATCH 5.10 000/173] 5.10.177-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.10.177 release. There are 173 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 05 Apr 2023 14:03:18 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.177-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.10.177-rc1 Matthieu Baerts <matthieu.baerts(a)tessares.net> hsr: ratelimit only when errors are printed Andreas Gruenbacher <agruenba(a)redhat.com> gfs2: Always check inode size of inline inodes Ye Bin <yebin10(a)huawei.com> ext4: fix kernel BUG in 'ext4_write_inline_data_end()' Andrii Nakryiko <andrii(a)kernel.org> libbpf: Fix btf_dump's packed struct determination Andrii Nakryiko <andrii(a)kernel.org> selftests/bpf: Add few corner cases to test padding handling of btf_dump Andrii Nakryiko <andrii(a)kernel.org> libbpf: Fix BTF-to-C converter's padding logic Eduard Zingerman <eddyz87(a)gmail.com> selftests/bpf: Test btf dump for struct with padding only fields Damien Le Moal <damien.lemoal(a)opensource.wdc.com> zonefs: Fix error message in zonefs_file_dio_append() Anand Jain <anand.jain(a)oracle.com> btrfs: scan device in non-exclusive mode Heiko Carstens <hca(a)linux.ibm.com> s390/uaccess: add missing earlyclobber annotations to __clear_user() Fangzhi Zuo <Jerry.Zuo(a)amd.com> drm/amd/display: Add DSC Support for Synaptics Cascaded MST Hub Lucas Stach <l.stach(a)pengutronix.de> drm/etnaviv: fix reference leak when mmaping imported buffer Douglas Raillard <douglas.raillard(a)arm.com> rcu: Fix rcu_torture_read ftrace event Max Filippov <jcmvbkbc(a)gmail.com> xtensa: fix KASAN report for show_stack huangwenhui <huangwenhuia(a)uniontech.com> ALSA: hda/realtek: Add quirk for Lenovo ZhaoYang CF4620Z Takashi Iwai <tiwai(a)suse.de> ALSA: usb-audio: Fix regression on detection of Roland VS-100 Takashi Iwai <tiwai(a)suse.de> ALSA: hda/conexant: Partial revert of a quirk for Lenovo Trond Myklebust <trond.myklebust(a)hammerspace.com> NFSv4: Fix hangs when recovering open state after a server reboot Jens Axboe <axboe(a)kernel.dk> powerpc: Don't try to copy PPR for task with NULL pt_regs Johan Hovold <johan+linaro(a)kernel.org> pinctrl: at91-pio4: fix domain name assignment Kornel Dulęba <korneld(a)chromium.org> pinctrl: amd: Disable and mask interrupts on resume Josua Mayer <josua(a)solid-run.com> net: phy: dp83869: fix default value for tx-/rx-internal-delay Juergen Gross <jgross(a)suse.com> xen/netback: don't do grant copy across page boundary Filipe Manana <fdmanana(a)suse.com> btrfs: fix race between quota disable and quota assign ioctls Hans de Goede <hdegoede(a)redhat.com> Input: goodix - add Lenovo Yoga Book X90F to nine_bytes_report DMI table David Disseldorp <ddiss(a)suse.de> cifs: fix DFS traversal oops without CONFIG_CIFS_DFS_UPCALL Paulo Alcantara <pc(a)manguebit.com> cifs: prevent infinite recursion in CIFSGetDFSRefer() Jason A. Donenfeld <Jason(a)zx2c4.com> Input: focaltech - use explicitly signed char type msizanoen <msizanoen(a)qtmlabs.xyz> Input: alps - fix compatibility with -funsigned-char Horatiu Vultur <horatiu.vultur(a)microchip.com> pinctrl: ocelot: Fix alt mode for ocelot Steffen Bätz <steffen(a)innosonix.de> net: dsa: mv88e6xxx: Enable IGMP snooping on user ports only Michael Chan <michael.chan(a)broadcom.com> bnxt_en: Add missing 200G link speed reporting Kalesh AP <kalesh-anakkur.purayil(a)broadcom.com> bnxt_en: Fix typo in PCI id to device description string mapping Radoslaw Tyl <radoslawx.tyl(a)intel.com> i40e: fix registers dump after run ethtool adapter self test Alex Elder <elder(a)linaro.org> net: ipa: compute DMA pool size properly Tasos Sahanidis <tasos(a)tasossah.com> ALSA: ymfpci: Fix BUG_ON in probe function Takashi Iwai <tiwai(a)suse.de> ALSA: ymfpci: Fix assignment in if condition Tony Krowiak <akrowiak(a)linux.ibm.com> s390/vfio-ap: fix memory leak in vfio_ap device driver Ivan Orlov <ivan.orlov0322(a)gmail.com> can: bcm: bcm_tx_setup(): fix KMSAN uninit-value in vfs_write Vladimir Oltean <vladimir.oltean(a)nxp.com> net: stmmac: don't reject VLANs when IFF_PROMISC is set Faicker Mo <faicker.mo(a)ucloud.cn> net/net_failover: fix txq exceeding warning Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> regulator: Handle deferred clk ChunHao Lin <hau(a)realtek.com> r8169: fix RTL8168H and RTL8107E rx crc error SongJingyi <u201912584(a)hust.edu.cn> ptp_qoriq: fix memory leak in probe() Tomas Henzl <thenzl(a)redhat.com> scsi: megaraid_sas: Fix crash after a double completion Íñigo Huguet <ihuguet(a)redhat.com> sfc: ef10: don't overwrite offload features at NIC reset Arseniy Krasnov <avkrasnov(a)sberdevices.ru> mtd: rawnand: meson: invalidate cache on polling ECC bit Álvaro Fernández Rojas <noltari(a)gmail.com> mips: bmips: BCM6358: disable RAC flush for TP1 Harshit Mogalapalli <harshit.m.mogalapalli(a)oracle.com> ca8210: Fix unsigned mac_len comparison with zero in ca8210_skb_tx() Anton Gusev <aagusev(a)ispras.ru> tracing: Fix wrong return in kprobe_event_gen_test.c Prarit Bhargava <prarit(a)redhat.com> tools/power turbostat: Fix /dev/cpu_dma_latency warnings Wei Chen <harperchen1110(a)gmail.com> fbdev: au1200fb: Fix potential divide by zero Wei Chen <harperchen1110(a)gmail.com> fbdev: lxfb: Fix potential divide by zero Wei Chen <harperchen1110(a)gmail.com> fbdev: intelfb: Fix potential divide by zero Wei Chen <harperchen1110(a)gmail.com> fbdev: nvidia: Fix potential divide by zero Linus Torvalds <torvalds(a)linux-foundation.org> sched_getaffinity: don't assume 'cpumask_size()' is fully initialized Wei Chen <harperchen1110(a)gmail.com> fbdev: tgafb: Fix potential divide by zero Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> ALSA: hda/ca0132: fixup buffer overrun at tuning_ctl_set() Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> ALSA: asihpi: check pao in control_message() Kristian Overskeid <koverskeid(a)gmail.com> net: hsr: Don't log netdev_err message on unknown prp dst node NeilBrown <neilb(a)suse.de> md: avoid signed overflow in slot_store() Eric Biggers <ebiggers(a)google.com> fsverity: don't drop pagecache at end of FS_IOC_ENABLE_VERITY Mike Snitzer <snitzer(a)kernel.org> dm crypt: avoid accessing uninitialized tasklet Ivan Bornyakov <i.bornyakov(a)metrotek.ru> bus: imx-weim: fix branch condition evaluates to a garbage value Johan Hovold <johan+linaro(a)kernel.org> drm/meson: fix missing component unbind on bind errors Martin Blumenstingl <martin.blumenstingl(a)googlemail.com> drm/meson: Fix error handling when afbcd.ops->init fails Marco Elver <elver(a)google.com> kcsan: avoid passing -g for test Anders Roxell <anders.roxell(a)linaro.org> kernel: kcsan: kcsan_test: build without structleak plugin Wesley Cheng <quic_wcheng(a)quicinc.com> usb: dwc3: gadget: Add 1ms delay after end transfer command without IOC Michael Grzeschik <m.grzeschik(a)pengutronix.de> usb: dwc3: gadget: move cmd_endtransfer to extra function Dai Ngo <dai.ngo(a)oracle.com> NFSD: fix use-after-free in __nfs42_ssc_open() Miaohe Lin <linmiaohe(a)huawei.com> KVM: fix memoryleak in kvm_init() Brian Foster <bfoster(a)redhat.com> xfs: don't reuse busy extents on extent trim Darrick J. Wong <djwong(a)kernel.org> xfs: shut down the filesystem if we screw up quota reservation Jan Kara via Ocfs2-devel <ocfs2-devel(a)oss.oracle.com> ocfs2: fix data corruption after failed write Vincent Guittot <vincent.guittot(a)linaro.org> sched/fair: Sanitize vruntime of entity being migrated Zhang Qiao <zhangqiao22(a)huawei.com> sched/fair: sanitize vruntime of entity being placed Mikulas Patocka <mpatocka(a)redhat.com> dm crypt: add cond_resched() to dmcrypt_write() Jiasheng Jiang <jiasheng(a)iscas.ac.cn> dm stats: check for and propagate alloc_percpu failure Wei Chen <harperchen1110(a)gmail.com> i2c: xgene-slimpro: Fix out-of-bounds bug in xgene_slimpro_i2c_xfer() Cristian Marussi <cristian.marussi(a)arm.com> firmware: arm_scmi: Fix device node validation for mailbox transport Rijo Thomas <Rijo-john.Thomas(a)amd.com> tee: amdtee: fix race condition in amdtee_open_session Ville Syrjälä <ville.syrjala(a)linux.intel.com> drm/i915: Preserve crtc_state->inherited during state clearing Nirmoy Das <nirmoy.das(a)intel.com> drm/i915/active: Fix missing debug object activation Ryusuke Konishi <konishi.ryusuke(a)gmail.com> nilfs2: fix kernel-infoleak in nilfs_ioctl_wrap_copy() Felix Fietkau <nbd(a)nbd.name> wifi: mac80211: fix qos on mesh interfaces Hans de Goede <hdegoede(a)redhat.com> usb: ucsi: Fix NULL pointer deref in ucsi_connector_change() Xu Yang <xu.yang_2(a)nxp.com> usb: chipidea: core: fix possible concurrent when switch role Xu Yang <xu.yang_2(a)nxp.com> usb: chipdea: core: fix return -EINVAL if request role is the same with current role Pawel Laszczak <pawell(a)cadence.com> usb: cdns3: Fix issue with using incorrect PCI device function Coly Li <colyli(a)suse.de> dm thin: fix deadlock when swapping to thin device Lin Ma <linma(a)zju.edu.cn> igb: revert rtnl_lock() that causes deadlock Nathan Huckleberry <nhuck(a)google.com> fsverity: Remove WQ_UNBOUND from fsverity read workqueue Alvin Šipraga <alsi(a)bang-olufsen.dk> usb: gadget: u_audio: don't let userspace block driver unbind Fabrice Gasnier <fabrice.gasnier(a)foss.st.com> usb: dwc2: fix a devres leak in hw_enable upon suspend resume Joel Selvaraj <joelselvaraj.oss(a)gmail.com> scsi: core: Add BLIST_SKIP_VPD_PAGES for SKhynix H28U74301AMR Shyam Prasad N <sprasad(a)microsoft.com> cifs: empty interface list when server doesn't support query interfaces Al Viro <viro(a)zeniv.linux.org.uk> sh: sanitize the flags on sigreturn Enrico Sau <enrico.sau(a)gmail.com> net: usb: qmi_wwan: add Telit 0x1080 composition Enrico Sau <enrico.sau(a)gmail.com> net: usb: cdc_mbim: avoid altsetting toggling for Telit FE990 Michael Kelley <mikelley(a)microsoft.com> scsi: storvsc: Handle BlockSize change in Hyper-V VHD/VHDX file Jakob Koschel <jkl820.git(a)gmail.com> scsi: lpfc: Avoid usage of list iterator variable after loop Adrien Thierry <athierry(a)redhat.com> scsi: ufs: core: Add soft dependency on governor_simpleondemand Kang Chen <void0red(a)gmail.com> scsi: hisi_sas: Check devm_add_action() return value Maurizio Lombardi <mlombard(a)redhat.com> scsi: target: iscsi: Fix an error message in iscsi_check_key() Lorenz Bauer <lorenz.bauer(a)isovalent.com> selftests/bpf: check that modifier resolves after pointer Michael Schmitz <schmitzmic(a)gmail.com> m68k: Only force 030 bus error if PC not in exception table Alexander Aring <aahringo(a)redhat.com> ca8210: fix mac_len negative array access Danny Kaehn <kaehndan(a)gmail.com> HID: cp2112: Fix driver not registering GPIO IRQ chip as threaded Alexandre Ghiti <alex(a)ghiti.fr> riscv: Bump COMMAND_LINE_SIZE value to 1024 Mario Limonciello <mario.limonciello(a)amd.com> thunderbolt: Use const qualifier for `ring_interrupt_index` Mika Westerberg <mika.westerberg(a)linux.intel.com> thunderbolt: Use scale field when allocating USB3 bandwidth Yaroslav Furman <yaro330(a)gmail.com> uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2 Nilesh Javali <njavali(a)marvell.com> scsi: qla2xxx: Perform lockless command completion in abort path Frank Crawford <frank(a)crawford.emu.id.au> hwmon (it87): Fix voltage scaling for chips with 10.9mV ADCs Phinex Hung <phinex(a)realtek.com> hwmon: fix potential sensor registration fail if of_node is missing Tzung-Bi Shih <tzungbi(a)kernel.org> platform/chrome: cros_ec_chardev: fix kernel data leak from ioctl Zheng Wang <zyytlz.wz(a)163.com> Bluetooth: btsdio: fix use after free bug in btsdio_remove due to unfinished work Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> Bluetooth: L2CAP: Fix responding with wrong PDU type Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> Bluetooth: L2CAP: Fix not checking for maximum number of DCID Stephan Gerhold <stephan.gerhold(a)kernkonzept.com> Bluetooth: btqcomsmd: Fix command timeout after setting BD address Liang He <windhl(a)126.com> net: mdio: thunder: Add missing fwnode_handle_put() Arınç ÜNAL <arinc.unal(a)arinc9.com> net: dsa: mt7530: move setting ssc_delta to PHY_INTERFACE_MODE_TRGMII case Joshua Washington <joshwash(a)google.com> gve: Cache link_speed value from device Caleb Sander <csander(a)purestorage.com> nvme-tcp: fix nvme_tcp_term_pdu to match spec Zhang Changzhong <zhangchangzhong(a)huawei.com> net/sonic: use dma_mapping_error() for error check Eric Dumazet <edumazet(a)google.com> erspan: do not use skb_mac_header() in ndo_start_xmit() Li Zetao <lizetao1(a)huawei.com> atm: idt77252: fix kmemleak when rmmod idt77252 Dan Carpenter <error27(a)gmail.com> net/mlx5: E-Switch, Fix an Oops in error handling code Maher Sanalla <msanalla(a)nvidia.com> net/mlx5: Read the TC mapping of all priorities on ETS query Lama Kayal <lkayal(a)nvidia.com> net/mlx5: Fix steering rules cleanup Daniel Borkmann <daniel(a)iogearbox.net> bpf: Adjust insufficient default bpf_jit_limit David Howells <dhowells(a)redhat.com> keys: Do not cache key in task struct if key is requested from kernel thread Masami Hiramatsu (Google) <mhiramat(a)kernel.org> bootconfig: Fix testcase to increase max node Geoff Levand <geoff(a)infradead.org> net/ps3_gelic_net: Use dma_mapping_error Geoff Levand <geoff(a)infradead.org> net/ps3_gelic_net: Fix RX sk_buff length Zheng Wang <zyytlz.wz(a)163.com> net: qcom/emac: Fix use after free bug in emac_remove due to race condition Maxime Bizon <mbizon(a)freebox.fr> net: mdio: fix owner field for mdio buses registered using device-tree Florian Fainelli <f.fainelli(a)gmail.com> net: phy: Ensure state transitions are processed from phy_stop() Zheng Wang <zyytlz.wz(a)163.com> xirc2ps_cs: Fix use after free bug in xirc2ps_detach Daniil Tatianin <d-tatianin(a)yandex-team.ru> qed/qed_sriov: guard against NULL derefs from qed_iov_get_vf_info Szymon Heidrich <szymon.heidrich(a)gmail.com> net: usb: smsc95xx: Limit packet length to skb->len Yu Kuai <yukuai3(a)huawei.com> scsi: scsi_dh_alua: Fix memleak for 'qdata' in alua_activate() Alexander Stein <alexander.stein(a)ew.tq-group.com> i2c: imx-lpi2c: check only for enabled interrupt flags AKASHI Takahiro <takahiro.akashi(a)linaro.org> igc: fix the validation logic for taprio's gate list Akihiko Odaki <akihiko.odaki(a)daynix.com> igbvf: Regard vf reset nack as success Gaosheng Cui <cuigaosheng1(a)huawei.com> intel/igbvf: free irq on the error path in igbvf_request_msix() Alexander Lobakin <aleksander.lobakin(a)intel.com> iavf: fix non-tunneled IPv6 UDP packet type and hashing Alexander Lobakin <aleksander.lobakin(a)intel.com> iavf: fix inverted Rx hash condition leading to disabled hash Kal Conley <kal.conley(a)dectris.com> xsk: Add missing overflow check in xdp_umem_reg Peng Fan <peng.fan(a)nxp.com> ARM: dts: imx6sl: tolino-shine2hd: fix usbotg1 pinctrl Peng Fan <peng.fan(a)nxp.com> ARM: dts: imx6sll: e60k02: fix usbotg1 pinctrl Zheng Wang <zyytlz.wz(a)163.com> power: supply: da9150: Fix use after free bug in da9150_charger_remove due to race condition Zheng Wang <zyytlz.wz(a)163.com> power: supply: bq24190: Fix use after free bug in bq24190_remove due to race condition Minghao Chi <chi.minghao(a)zte.com.cn> power: supply: bq24190_charger: using pm_runtime_resume_and_get instead of pm_runtime_get_sync Hangyu Hua <hbh25y(a)gmail.com> net: tls: fix possible race condition between do_tls_getsockopt_conf() and do_tls_setsockopt_conf() Johan Hovold <johan+linaro(a)kernel.org> drm/sun4i: fix missing component unbind on bind errors Randy Dunlap <rdunlap(a)infradead.org> serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it Geert Uytterhoeven <geert+renesas(a)glider.be> serial: 8250: SERIAL_8250_ASPEED_VUART should depend on ARCH_ASPEED Alexander Sverdlin <alexander.sverdlin(a)siemens.com> tty: serial: fsl_lpuart: fix race on RX DMA shutdown Jason Wang <wangborong(a)cdjrlc.com> serial: fsl_lpuart: Fix comment typo Sean Christopherson <seanjc(a)google.com> KVM: Register /dev/kvm as the _very_ last thing during initialization Vitaly Kuznetsov <vkuznets(a)redhat.com> KVM: Pre-allocate cpumasks for kvm_make_all_cpus_request_except() Vitaly Kuznetsov <vkuznets(a)redhat.com> KVM: Optimize kvm_make_vcpus_request_mask() a bit Sean Christopherson <seanjc(a)google.com> KVM: KVM: Use cpumask_available() to check for NULL cpumask when kicking vCPUs Sean Christopherson <seanjc(a)google.com> KVM: Clean up benign vcpu->cpu data races when kicking vCPUs Corey Minyard <cminyard(a)mvista.com> ipmi:ssif: Add a timer between request retries Corey Minyard <cminyard(a)mvista.com> ipmi:ssif: resend_msg() cannot fail Corey Minyard <cminyard(a)mvista.com> ipmi:ssif: Increase the message retry time Liguang Zhang <zhangliguang(a)linux.alibaba.com> ipmi:ssif: make ssif_i2c_send() void Song Liu <song(a)kernel.org> perf: fix perf_event_context->time Yang Jihong <yangjihong1(a)huawei.com> perf/core: Fix perf_output_begin parameter is incorrectly invoked in perf_event_bpf_output Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> interconnect: qcom: osm-l3: fix icc_onecell_data allocation ------------- Diffstat: Makefile | 4 +- arch/arm/boot/dts/e60k02.dtsi | 1 + arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts | 1 + arch/m68k/kernel/traps.c | 4 +- arch/mips/bmips/dma.c | 5 + arch/mips/bmips/setup.c | 8 + arch/powerpc/kernel/ptrace/ptrace-view.c | 6 + arch/riscv/include/uapi/asm/setup.h | 8 + arch/s390/lib/uaccess.c | 2 +- arch/sh/include/asm/processor_32.h | 1 + arch/sh/kernel/signal_32.c | 3 + arch/xtensa/kernel/traps.c | 16 +- drivers/atm/idt77252.c | 11 ++ drivers/bluetooth/btqcomsmd.c | 17 +- drivers/bluetooth/btsdio.c | 1 + drivers/bus/imx-weim.c | 2 +- drivers/char/ipmi/ipmi_ssif.c | 137 ++++++----------- drivers/firmware/arm_scmi/mailbox.c | 37 +++++ .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 19 +++ .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.h | 12 ++ drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 10 +- drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/i915_active.c | 3 +- drivers/gpu/drm/meson/meson_drv.c | 20 ++- drivers/gpu/drm/sun4i/sun4i_drv.c | 4 +- drivers/hid/hid-cp2112.c | 1 + drivers/hwmon/hwmon.c | 7 +- drivers/hwmon/it87.c | 4 +- drivers/i2c/busses/i2c-imx-lpi2c.c | 4 + drivers/i2c/busses/i2c-xgene-slimpro.c | 3 + drivers/input/mouse/alps.c | 16 +- drivers/input/mouse/focaltech.c | 8 +- drivers/input/touchscreen/goodix.c | 14 +- drivers/interconnect/qcom/osm-l3.c | 2 +- drivers/md/dm-crypt.c | 16 +- drivers/md/dm-stats.c | 7 +- drivers/md/dm-stats.h | 2 +- drivers/md/dm-thin.c | 2 + drivers/md/dm.c | 4 +- drivers/md/md.c | 3 + drivers/mtd/nand/raw/meson_nand.c | 8 +- drivers/net/dsa/mt7530.c | 9 +- drivers/net/dsa/mv88e6xxx/chip.c | 9 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 +- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 + drivers/net/ethernet/google/gve/gve_ethtool.c | 5 +- drivers/net/ethernet/intel/i40e/i40e_diag.c | 11 +- drivers/net/ethernet/intel/i40e/i40e_diag.h | 2 +- drivers/net/ethernet/intel/iavf/iavf_common.c | 2 +- drivers/net/ethernet/intel/iavf/iavf_txrx.c | 2 +- drivers/net/ethernet/intel/igb/igb_main.c | 2 - drivers/net/ethernet/intel/igbvf/netdev.c | 8 +- drivers/net/ethernet/intel/igbvf/vf.c | 13 +- drivers/net/ethernet/intel/igc/igc_main.c | 20 +-- drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 6 +- .../mellanox/mlx5/core/esw/acl/ingress_ofld.c | 3 +- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 1 + drivers/net/ethernet/natsemi/sonic.c | 4 +- drivers/net/ethernet/qlogic/qed/qed_sriov.c | 5 +- drivers/net/ethernet/qualcomm/emac/emac.c | 6 + drivers/net/ethernet/realtek/r8169_phy_config.c | 3 + drivers/net/ethernet/sfc/ef10.c | 38 +++-- drivers/net/ethernet/sfc/efx.c | 17 +- drivers/net/ethernet/stmicro/stmmac/common.h | 1 - drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 61 +------- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 41 ++--- drivers/net/ethernet/toshiba/ps3_gelic_net.h | 5 +- drivers/net/ethernet/xircom/xirc2ps_cs.c | 5 + drivers/net/ieee802154/ca8210.c | 5 +- drivers/net/ipa/gsi_trans.c | 2 +- drivers/net/mdio/mdio-thunder.c | 1 + drivers/net/mdio/of_mdio.c | 12 +- drivers/net/net_failover.c | 8 +- drivers/net/phy/dp83869.c | 6 +- drivers/net/phy/mdio_devres.c | 11 +- drivers/net/phy/phy.c | 23 ++- drivers/net/usb/cdc_mbim.c | 5 + drivers/net/usb/qmi_wwan.c | 1 + drivers/net/usb/smsc95xx.c | 6 + drivers/net/xen-netback/common.h | 2 +- drivers/net/xen-netback/netback.c | 25 ++- drivers/pinctrl/pinctrl-amd.c | 36 +++-- drivers/pinctrl/pinctrl-at91-pio4.c | 1 - drivers/pinctrl/pinctrl-ocelot.c | 2 +- drivers/platform/chrome/cros_ec_chardev.c | 2 +- drivers/power/supply/bq24190_charger.c | 64 +++----- drivers/power/supply/da9150-charger.c | 1 + drivers/ptp/ptp_qoriq.c | 2 +- drivers/regulator/fixed.c | 2 +- drivers/s390/crypto/vfio_ap_drv.c | 3 +- drivers/scsi/device_handler/scsi_dh_alua.c | 6 +- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 3 +- drivers/scsi/lpfc/lpfc_sli.c | 8 +- drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 +- drivers/scsi/qla2xxx/qla_os.c | 11 ++ drivers/scsi/scsi_devinfo.c | 1 + drivers/scsi/storvsc_drv.c | 16 ++ drivers/scsi/ufs/ufshcd.c | 1 + drivers/target/iscsi/iscsi_target_parameters.c | 12 +- drivers/tee/amdtee/core.c | 29 ++-- drivers/thunderbolt/nhi.c | 2 +- drivers/thunderbolt/usb4.c | 22 ++- drivers/tty/serial/8250/Kconfig | 4 +- drivers/tty/serial/fsl_lpuart.c | 13 +- drivers/usb/cdns3/cdns3-pci-wrap.c | 5 + drivers/usb/chipidea/ci.h | 2 + drivers/usb/chipidea/core.c | 11 +- drivers/usb/chipidea/otg.c | 5 +- drivers/usb/dwc2/platform.c | 16 +- drivers/usb/dwc3/gadget.c | 79 ++++++---- drivers/usb/gadget/function/u_audio.c | 2 +- drivers/usb/storage/unusual_uas.h | 7 + drivers/usb/typec/ucsi/ucsi.c | 11 +- drivers/video/fbdev/au1200fb.c | 3 + drivers/video/fbdev/geode/lxfb_core.c | 3 + drivers/video/fbdev/intelfb/intelfbdrv.c | 3 + drivers/video/fbdev/nvidia/nvidia.c | 2 + drivers/video/fbdev/tgafb.c | 3 + fs/btrfs/ioctl.c | 2 + fs/btrfs/qgroup.c | 11 +- fs/btrfs/volumes.c | 11 +- fs/cifs/cifsfs.h | 5 +- fs/cifs/cifssmb.c | 9 +- fs/cifs/smb2ops.c | 2 +- fs/ext4/inode.c | 3 +- fs/gfs2/aops.c | 2 - fs/gfs2/bmap.c | 3 - fs/gfs2/glops.c | 3 + fs/nfs/nfs4proc.c | 5 +- fs/nfsd/nfs4proc.c | 22 +-- fs/nilfs2/ioctl.c | 2 +- fs/ocfs2/aops.c | 18 ++- fs/verity/enable.c | 24 +-- fs/verity/verify.c | 12 +- fs/xfs/xfs_extent_busy.c | 14 -- fs/xfs/xfs_trans_dquot.c | 13 +- fs/zonefs/super.c | 2 +- include/linux/nvme-tcp.h | 5 +- include/linux/of_mdio.h | 22 ++- include/net/bluetooth/l2cap.h | 1 + include/trace/events/rcu.h | 2 +- kernel/bpf/core.c | 2 +- kernel/compat.c | 2 +- kernel/events/core.c | 4 +- kernel/kcsan/Makefile | 3 +- kernel/sched/core.c | 7 +- kernel/sched/fair.c | 54 ++++++- kernel/trace/kprobe_event_gen_test.c | 4 +- net/bluetooth/l2cap_core.c | 129 +++++++++++----- net/can/bcm.c | 16 +- net/hsr/hsr_framereg.c | 2 +- net/ipv4/ip_gre.c | 4 +- net/ipv6/ip6_gre.c | 4 +- net/mac80211/wme.c | 6 +- net/tls/tls_main.c | 9 +- net/xdp/xdp_umem.c | 13 +- security/keys/request_key.c | 9 +- sound/pci/asihpi/hpi6205.c | 2 +- sound/pci/hda/patch_ca0132.c | 4 +- sound/pci/hda/patch_conexant.c | 6 +- sound/pci/hda/patch_realtek.c | 1 + sound/pci/ymfpci/ymfpci.c | 71 +++++---- sound/pci/ymfpci/ymfpci_main.c | 74 ++++++--- sound/usb/format.c | 8 +- tools/bootconfig/test-bootconfig.sh | 12 +- tools/lib/bpf/btf_dump.c | 154 +++++++++++++------ tools/power/x86/turbostat/turbostat.8 | 2 + tools/power/x86/turbostat/turbostat.c | 2 +- tools/testing/selftests/bpf/prog_tests/btf.c | 28 ++++ .../bpf/progs/btf_dump_test_case_bitfields.c | 2 +- .../bpf/progs/btf_dump_test_case_packing.c | 80 +++++++++- .../bpf/progs/btf_dump_test_case_padding.c | 171 ++++++++++++++++++--- virt/kvm/kvm_main.c | 149 +++++++++++++----- 174 files changed, 1652 insertions(+), 803 deletions(-)

2 years, 1 month

14
191
0 0

[PATCH] ALSA: hda/hdmi: disable KAE for Intel DG2

by Kai Vehmanen

Use of keep-alive (KAE) has resulted in loss of audio on some A750/770 cards as the transition from keep-alive to stream playback is not working as expected. As there is limited benefit of the new KAE mode on discrete cards, revert back to older silent-stream implementation on these systems. Cc: stable(a)vger.kernel.org Fixes: 15175a4f2bbb ("ALSA: hda/hdmi: add keep-alive support for ADL-P and DG2") Link: https://gitlab.freedesktop.org/drm/intel/-/issues/8307 Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> --- sound/pci/hda/patch_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 4ffa3a59f419..5c6980394dce 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -4604,7 +4604,7 @@ HDA_CODEC_ENTRY(0x80862814, "DG1 HDMI", patch_i915_tgl_hdmi), HDA_CODEC_ENTRY(0x80862815, "Alderlake HDMI", patch_i915_tgl_hdmi), HDA_CODEC_ENTRY(0x80862816, "Rocketlake HDMI", patch_i915_tgl_hdmi), HDA_CODEC_ENTRY(0x80862818, "Raptorlake HDMI", patch_i915_tgl_hdmi), -HDA_CODEC_ENTRY(0x80862819, "DG2 HDMI", patch_i915_adlp_hdmi), +HDA_CODEC_ENTRY(0x80862819, "DG2 HDMI", patch_i915_tgl_hdmi), HDA_CODEC_ENTRY(0x8086281a, "Jasperlake HDMI", patch_i915_icl_hdmi), HDA_CODEC_ENTRY(0x8086281b, "Elkhartlake HDMI", patch_i915_icl_hdmi), HDA_CODEC_ENTRY(0x8086281c, "Alderlake-P HDMI", patch_i915_adlp_hdmi), base-commit: be6247640eea9d9b0ff15607fab7a12f40974985 -- 2.40.0

2 years, 1 month

2
1
0 0

DETAILS

by Global LendersⒸ

-- Need a convenient business/personal loan today? - no paperwork, collateral or guarantors needed. Payback in 3 - 24 months.Minimal interest Mark Tucker Global LendersⒸ Sent from my iPad

2 years, 1 month

1
0
0 0

DETAILS

by Global LendersⒸ

-- Need a convenient business/personal loan today? - no paperwork, collateral or guarantors needed. Payback in 3 - 24 months.Minimal interest Mark Tucker Global LendersⒸ Sent from my iPad

2 years, 1 month

1
0
0 0

[PATCH] ceph: do not touch cap when trimming the caps

by xiubli＠redhat.com

From: Xiubo Li <xiubli(a)redhat.com> When trimming the caps it maybe queued to release in the next loop, and just after the 'session->s_cap_lock' lock is released the 'session->s_cap_iterator' will be set to NULL and the cap also has been removed from 'session->s_caps' list, then the '__touch_cap()' could continue and add the cap back to the 'session->s_caps' list. That means this cap could be iterated twice to call 'trim_caps_cb()' and the second time will trigger use-after-free bug. Cc: stable(a)vger.kernel.org URL: https://bugzilla.redhat.com/show_bug.cgi?id=2186264 Signed-off-by: Xiubo Li <xiubli(a)redhat.com> --- fs/ceph/caps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c index cf29e395af23..186c9818ab0d 100644 --- a/fs/ceph/caps.c +++ b/fs/ceph/caps.c @@ -846,7 +846,7 @@ static void __touch_cap(struct ceph_cap *cap) struct ceph_mds_session *s = cap->session; spin_lock(&s->s_cap_lock); - if (!s->s_cap_iterator) { + if (!s->s_cap_iterator && !list_empty(&cap->session_caps) && !cap->queue_release) { dout("__touch_cap %p cap %p mds%d\n", &cap->ci->netfs.inode, cap, s->s_mds); list_move_tail(&cap->session_caps, &s->s_caps); -- 2.39.1

2 years, 1 month

2
1
0 0

[PATCH] ring-buffer: Prevent inconsistent operation on cpu_buffer->resize_disabled

by Tze-nan Wu

Sometimes, write to buffer_size_kb can be permanently failure if we change the cpu_online_mask between two for_each_online_buffer_cpu loops in function ring_buffer_reset_online_cpus. The number of increasing and decreasing on cpu_buffer->resize_disable may be inconsistent, leading the resize_disabled in some CPUs becoming none zero after ring_buffer_reset_online_cpus return. This issue can be reproduced by "echo 0 > trace" and hotplug cpu at the same time. After reproducing succeess, we can find out the attempt to write to buffer_size_kb node failure every time. This patch prevent the inconsistent increasing and decreasing on cpu_buffer->resize_disabled by copying the cpu_online_mask at the beginning of the function. But I wonder if there's any side-effect of this patch, since the behavior changed, if we turn on a cpu between the two loops, reset_disabled_cpu_buffer() of that cpu won't be run as before, meaning the cpu_buffer on that cpu just awake will not be cleaned up. Cc: stable(a)vger.kernel.org Signed-off-by: Tze-nan Wu <Tze-nan.Wu(a)mediatek.com> --- kernel/trace/ring_buffer.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c index 76a2d91eecad..468f46bba71e 100644 --- a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c @@ -288,9 +288,6 @@ EXPORT_SYMBOL_GPL(ring_buffer_event_data); #define for_each_buffer_cpu(buffer, cpu) \ for_each_cpu(cpu, buffer->cpumask) -#define for_each_online_buffer_cpu(buffer, cpu) \ - for_each_cpu_and(cpu, buffer->cpumask, cpu_online_mask) - #define TS_SHIFT 27 #define TS_MASK ((1ULL << TS_SHIFT) - 1) #define TS_DELTA_TEST (~TS_MASK) @@ -5353,12 +5350,15 @@ EXPORT_SYMBOL_GPL(ring_buffer_reset_cpu); void ring_buffer_reset_online_cpus(struct trace_buffer *buffer) { struct ring_buffer_per_cpu *cpu_buffer; + cpumask_var_t reset_online_mask; int cpu; /* prevent another thread from changing buffer sizes */ mutex_lock(&buffer->mutex); - for_each_online_buffer_cpu(buffer, cpu) { + cpumask_copy(reset_online_mask, cpu_online_mask); + + for_each_cpu_and(cpu, buffer->cpumask, reset_online_mask) { cpu_buffer = buffer->buffers[cpu]; atomic_inc(&cpu_buffer->resize_disabled); @@ -5368,7 +5368,7 @@ void ring_buffer_reset_online_cpus(struct trace_buffer *buffer) /* Make sure all commits have finished */ synchronize_rcu(); - for_each_online_buffer_cpu(buffer, cpu) { + for_each_cpu_and(cpu, buffer->cpumask, reset_online_mask) { cpu_buffer = buffer->buffers[cpu]; reset_disabled_cpu_buffer(cpu_buffer); -- 2.18.0

2 years, 1 month

5
11
0 0

[PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for T-FORCE Z330 SSD

by Duy Truong

Added a quirk to fix the TeamGroup T-Force Cardea Zero Z330 SSDs reporting duplicate NGUIDs. Signed-off-by: Duy Truong <dory(a)dory.moe> Cc: stable(a)vger.kernel.org --- drivers/nvme/host/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 282d808400c5..cd7873de3121 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -3443,6 +3443,8 @@ static const struct pci_device_id nvme_id_table[] = { { PCI_DEVICE(0x1d97, 0x2269), /* Lexar NM760 */ .driver_data = NVME_QUIRK_BOGUS_NID | NVME_QUIRK_IGNORE_DEV_SUBNQN, }, + { PCI_DEVICE(0x10ec, 0x5763), /* TEAMGROUP T-FORCE CARDEA ZERO Z330 SSD */ + .driver_data = NVME_QUIRK_BOGUS_NID, }, { PCI_DEVICE(PCI_VENDOR_ID_AMAZON, 0x0061), .driver_data = NVME_QUIRK_DMA_ADDRESS_BITS_48, }, { PCI_DEVICE(PCI_VENDOR_ID_AMAZON, 0x0065), -- 2.40.0

2 years, 1 month

1
0
0 0

[PATCH 5.10 5.4 4.19 4.14] watchdog: sbsa_wdog: Make sure the timeout programming is within the limits

by Tyler Hicks (Microsoft)

From: George Cherian <george.cherian(a)marvell.com> [ Upstream commit 000987a38b53c172f435142a4026dd71378ca464 ] Make sure to honour the max_hw_heartbeat_ms while programming the timeout value to WOR. Clamp the timeout passed to sbsa_gwdt_set_timeout() to make sure the programmed value is within the permissible range. Fixes: abd3ac7902fb ("watchdog: sbsa: Support architecture version 1") Signed-off-by: George Cherian <george.cherian(a)marvell.com> Reviewed-by: Guenter Roeck <linux(a)roeck-us.net> Link: https://lore.kernel.org/r/20230209021117.1512097-1-george.cherian@marvell.c… Signed-off-by: Guenter Roeck <linux(a)roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim(a)linux-watchdog.org> Signed-off-by: Tyler Hicks (Microsoft) <code(a)tyhicks.com> --- The Fixes line in the original commit is incorrect. This commit fixes a bug that goes all the way back to v4.6 commit 57d2caaabfc7 ("Watchdog: introduce ARM SBSA watchdog driver") when only 32-bit Watchdog Offset Registers (WOR) were supported. Without this fix, there's a truncation on the first argument, of u32 type, passed to writel() in the following situation situation: Generic Watchdog architecture version is 1 (WOR is 32-bit) action is 1 timeout is 240s CNTFRQ_EL0 is 25000050 Hz wdd.max_hw_heartbeat_ms is 171s 25000050 * 240 = 6000012000 <--- requires 33 bits to store 6000012000 & 0xFFFFFFFF = 1705044704 <--- truncated value written to WOR 1705044704 / 25000050 = 68.2s <--- timeout incorrectly set to 68.2s The timeout from userspace is greater than wdd.max_hw_heartbeat_ms so the watchdog core pings at 69s (240 - 171) which results in intermittent and unexpected panics (action=1). With this patch applied, the timeout passed to writel() never exceeds 32-bits and the watchdog core + systemd keeps the watchdog happy. I've validated this fix on real hardware running a linux-5.10.y stable kernel. Please apply this patch to 5.10 through 4.14. Thanks! Tyler drivers/watchdog/sbsa_gwdt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c index f0f1e3b2e463..4cbe6ba52754 100644 --- a/drivers/watchdog/sbsa_gwdt.c +++ b/drivers/watchdog/sbsa_gwdt.c @@ -121,6 +121,7 @@ static int sbsa_gwdt_set_timeout(struct watchdog_device *wdd, struct sbsa_gwdt *gwdt = watchdog_get_drvdata(wdd); wdd->timeout = timeout; + timeout = clamp_t(unsigned int, timeout, 1, wdd->max_hw_heartbeat_ms / 1000); if (action) writel(gwdt->clk * timeout, -- 2.34.1

2 years, 1 month

2
1
0 0

[PATCH v1] clk: microchip: fix potential UAF in auxdev release callback

by Conor Dooley

From: Conor Dooley <conor.dooley(a)microchip.com> Similar to commit 1c11289b34ab ("peci: cpu: Fix use-after-free in adev_release()"), the auxiliary device is not torn down in the correct order. If auxiliary_device_add() fails, the release callback will be called twice, resulting in a UAF. Due to timing, the auxdev code in this driver "took inspiration" from the aforementioned commit, and thus its bugs too! Moving auxiliary_device_uninit() to the unregister callback instead avoids the issue. CC: stable(a)vger.kernel.org Fixes: b56bae2dd6fd ("clk: microchip: mpfs: add reset controller") Signed-off-by: Conor Dooley <conor.dooley(a)microchip.com> --- Stephen, Claudiu is on leave at the moment, and although I can push stuff to the at-91 tree etc, it's probably simpler if you just take this yourself? CC: Stephen Boyd <sboyd(a)kernel.org> CC: Conor Dooley <conor.dooley(a)microchip.com> CC: Daire McNamara <daire.mcnamara(a)microchip.com> CC: Michael Turquette <mturquette(a)baylibre.com> CC: Stephen Boyd <sboyd(a)kernel.org> CC: Claudiu Beznea <claudiu.beznea(a)microchip.com> CC: linux-clk(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org --- drivers/clk/microchip/clk-mpfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/clk/microchip/clk-mpfs.c b/drivers/clk/microchip/clk-mpfs.c index 4f0a19db7ed7..cc5d7dee59f0 100644 --- a/drivers/clk/microchip/clk-mpfs.c +++ b/drivers/clk/microchip/clk-mpfs.c @@ -374,14 +374,13 @@ static void mpfs_reset_unregister_adev(void *_adev) struct auxiliary_device *adev = _adev; auxiliary_device_delete(adev); + auxiliary_device_uninit(adev); } static void mpfs_reset_adev_release(struct device *dev) { struct auxiliary_device *adev = to_auxiliary_dev(dev); - auxiliary_device_uninit(adev); - kfree(adev); } -- 2.39.2

2 years, 1 month

2
1
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror April 2023