April 2023 - Linux-stable-mirror

[PATCH v3 2/6] PCI: hv: Fix a race condition in hv_irq_unmask() that can cause panic

by Dexuan Cui

When the host tries to remove a PCI device, the host first sends a PCI_EJECT message to the guest, and the guest is supposed to gracefully remove the PCI device and send a PCI_EJECTION_COMPLETE message to the host; the host then sends a VMBus message CHANNELMSG_RESCIND_CHANNELOFFER to the guest (when the guest receives this message, the device is already unassigned from the guest) and the guest can do some final cleanup work; if the guest fails to respond to the PCI_EJECT message within one minute, the host sends the VMBus message CHANNELMSG_RESCIND_CHANNELOFFER and removes the PCI device forcibly. In the case of fast device addition/removal, it's possible that the PCI device driver is still configuring MSI-X interrupts when the guest receives the PCI_EJECT message; the channel callback calls hv_pci_eject_device(), which sets hpdev->state to hv_pcichild_ejecting, and schedules a work hv_eject_device_work(); if the PCI device driver is calling pci_alloc_irq_vectors() -> ... -> hv_compose_msi_msg(), we can break the while loop in hv_compose_msi_msg() due to the updated hpdev->state, and leave data->chip_data with its default value of NULL; later, when the PCI device driver calls request_irq() -> ... -> hv_irq_unmask(), the guest crashes in hv_arch_irq_unmask() due to data->chip_data being NULL. Fix the issue by not testing hpdev->state in the while loop: when the guest receives PCI_EJECT, the device is still assigned to the guest, and the guest has one minute to finish the device removal gracefully. We don't really need to (and we should not) test hpdev->state in the loop. Fixes: de0aa7b2f97d ("PCI: hv: Fix 2 hang issues in hv_compose_msi_msg()") Signed-off-by: Dexuan Cui <decui(a)microsoft.com> Reviewed-by: Michael Kelley <mikelley(a)microsoft.com> Cc: stable(a)vger.kernel.org --- v2: Removed the "debug code". No change to the patch body. Added Cc:stable v3: Added Michael's Reviewed-by. drivers/pci/controller/pci-hyperv.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c index b82c7cde19e66..1b11cf7391933 100644 --- a/drivers/pci/controller/pci-hyperv.c +++ b/drivers/pci/controller/pci-hyperv.c @@ -643,6 +643,11 @@ static void hv_arch_irq_unmask(struct irq_data *data) pbus = pdev->bus; hbus = container_of(pbus->sysdata, struct hv_pcibus_device, sysdata); int_desc = data->chip_data; + if (!int_desc) { + dev_warn(&hbus->hdev->device, "%s() can not unmask irq %u\n", + __func__, data->irq); + return; + } spin_lock_irqsave(&hbus->retarget_msi_interrupt_lock, flags); @@ -1911,12 +1916,6 @@ static void hv_compose_msi_msg(struct irq_data *data, struct msi_msg *msg) hv_pci_onchannelcallback(hbus); spin_unlock_irqrestore(&channel->sched_lock, flags); - if (hpdev->state == hv_pcichild_ejecting) { - dev_err_once(&hbus->hdev->device, - "the device is being ejected\n"); - goto enable_tasklet; - } - udelay(100); } -- 2.25.1

1 year, 9 months

2
2
0 0

[PATCH v3 1/6] PCI: hv: Fix a race condition bug in hv_pci_query_relations()

by Dexuan Cui

Fix the longstanding race between hv_pci_query_relations() and survey_child_resources() by flushing the workqueue before we exit from hv_pci_query_relations(). Fixes: 4daace0d8ce8 ("PCI: hv: Add paravirtual PCI front-end for Microsoft Hyper-V VMs") Signed-off-by: Dexuan Cui <decui(a)microsoft.com> Reviewed-by: Michael Kelley <mikelley(a)microsoft.com> Cc: stable(a)vger.kernel.org --- v2: Removed the "debug code". No change to the patch body. Added Cc:stable v3: Added Michael's Reviewed-by. drivers/pci/controller/pci-hyperv.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c index f33370b756283..b82c7cde19e66 100644 --- a/drivers/pci/controller/pci-hyperv.c +++ b/drivers/pci/controller/pci-hyperv.c @@ -3308,6 +3308,19 @@ static int hv_pci_query_relations(struct hv_device *hdev) if (!ret) ret = wait_for_response(hdev, &comp); + /* + * In the case of fast device addition/removal, it's possible that + * vmbus_sendpacket() or wait_for_response() returns -ENODEV but we + * already got a PCI_BUS_RELATIONS* message from the host and the + * channel callback already scheduled a work to hbus->wq, which can be + * running survey_child_resources() -> complete(&hbus->survey_event), + * even after hv_pci_query_relations() exits and the stack variable + * 'comp' is no longer valid. This can cause a strange hang issue + * or sometimes a page fault. Flush hbus->wq before we exit from + * hv_pci_query_relations() to avoid the issues. + */ + flush_workqueue(hbus->wq); + return ret; } -- 2.25.1

1 year, 9 months

2
2
0 0

[REGRESSION] Asus X541UAK hangs on suspend and poweroff (v6.1.6 onward)

by Acid Bong

Hi there, hello, Sometimes when I suspend (by closing the lid, less often - by pressing Fn+F1 (sleep key combo)) or poweroff my laptop (both by pressing powerit button and running "loginctl poweroff"), it goes in such a state when it doesn't respond to opening/closing the lid, power button nor Ctrl+Alt+Del, but, unlike in sleep mode, the fan is rotating and the "awake status" LED is on. I checked /var/log/kern.log, but it didn't report suspend at that moment at all: went straight from [UFW BLOCK] to "Microcode updated" on force reboot (marked with an arrow): Apr 13 10:40:32 bong kernel: asus_wmi: Unknown key code 0xcf Apr 13 10:44:05 bong kernel: [UFW BLOCK] IN=wlan0 OUT= MAC=/*confidential*/ Apr 13 10:47:45 bong kernel: [UFW BLOCK] IN=wlan0 OUT= MAC=/*confidential*/ Apr 13 10:47:46 bong kernel: ICMPv6: NA: /*router*/ advertised our address /*ipv6*/ on wlan0! Apr 13 10:47:48 bong last message buffered 2 times -> Apr 13 10:49:11 bong kernel: [UFW BLOCK] IN=wlan0 OUT= MAC=/*confidential*/ Apr 13 10:52:34 bong kernel: microcode: microcode updated early to revision 0xf0, date = 2021-11-12 Apr 13 10:52:34 bong kernel: Linux version 6.1.23-bong+ (acid@bong) (gcc (Gentoo Hardened 12.2.1_p20230121-r1 p10) 12.2.1 20230121, GNU ld (Gentoo 2.39 p5) 2.39.0) #1 SMP PREEMPT_DYNAMIC Tue Apr 11 15:21:57 EEST 2023 Apr 13 10:52:34 bong kernel: Command line: root=/dev/genston/root ro loglevel=4 rd.lvm.vg=genston rd.luks.uuid=97d10669-2da1-452d-a372-887e420b2ad4 rd.luks.allow-discards pci=nomsi initrd=\x5cinitramfs-6.1.23-bong+.img Apr 13 10:52:34 bong kernel: x86/fpu: Supporting XSAVE feature 0x001: 'x87 floating point registers' Apr 13 10:52:34 bong kernel: x86/fpu: Supporting XSAVE feature 0x002: 'SSE registers' Apr 13 10:52:34 bong kernel: x86/fpu: Supporting XSAVE feature 0x004: 'AVX registers' Normally it starts like this (taken from dmesg to sync with elogind messages) [ 7835.869228] elogind-daemon[2033]: Lid closed. [ 7835.872875] elogind-daemon[2033]: Suspending... [ 7835.873955] elogind-daemon[2033]: Suspending system... [ 7835.873970] PM: suspend entry (deep) [ 7835.902814] Filesystems sync: 0.028 seconds [ 7835.920362] Freezing user space processes [ 7835.923030] Freezing user space processes completed (elapsed 0.002 seconds) [ 7835.923046] OOM killer disabled. [ 7835.923049] Freezing remaining freezable tasks [ 7835.924445] Freezing remaining freezable tasks completed (elapsed 0.001 seconds) [ 7835.924624] printk: Suspending console(s) (use no_console_suspend to debug) The issue appeared when I was using pf-kernel with genpatches and updated from 6.1-pf2 to 6.1-pf3 (corresponding to vanilla versions 6.1.3 -> 6.1.6). I used that fork until 6.2-pf2, but since then (early March) moved to vanilla sources and started following the 6.1.y branch when it was declared LTS. And the issue was present on all of them. The hang was last detected 3 days ago on 6.1.22 and today on 6.1.23. I'd like to bisect it, but it could take ages for a couple of reasons: 1) I don't know exact patterns it follows. One of the scenarios I've noticed was this one (sorry if too ridiculous): - put the laptop on the nearby couch and simultaneously close the lid; the loose charger jack might disconnect; - lay the mouse upside down (so it doesn't wake up when I reconnect the charger), but it's not a 100% guarantee of the bug and, as I said earlier, the laptop also misbehaves on shutdown. 2) The issue happens rarely, once in a few days (sometimes up to a week; I haven't measured it precisely back then). Hardware: https://tilde.cafe/u/acidbong/kernel/lspci (`lspci -vvnn`) Config (latest vanilla): https://git.sr.ht/~acid-bong/kernel/tree/806e6639da610952798e1b5d8c0d700062… Built with KCFLAGS="-march=native" Isolated cmdline: root=/dev/genston/root ro loglevel=4 rd.lvm.vg=genston rd.luks.uuid=97d10669-2da1-452d-a372-887e420b2ad4 rd.luks.allow-discards pci=nomsi initrd=\initramfs-6.1.23-bong+.img # regzbot introduced v6.1.3..v6.1.6 --- Regards, ~acidbong

1 year, 9 months

5
18
0 0

[PATCH v1 1/5] hostfs: Fix ephemeral inodes

by Mickaël Salaün

hostfs creates a new inode for each opened or created file, which created useless inode allocations and forbade identifying a host file with a kernel inode. Fix this uncommon filesystem behavior by tying kernel inodes to host file's inode and device IDs. Even if the host filesystem inodes may be recycled, this cannot happen while a file referencing it is open, which is the case with hostfs. It should be noted that hostfs inode IDs may not be unique for the same hostfs superblock because multiple host's (backed) superblocks may be used. Delete inodes when dropping them to force backed host's file descriptors closing. This enables to entirely remove ARCH_EPHEMERAL_INODES, and then makes Landlock fully supported by UML. This is very useful for testing (ongoing and backported) changes. These changes also factor out and simplify some helpers thanks to the new hostfs_inode_update() and the hostfs_iget() revamp: read_name(), hostfs_create(), hostfs_lookup(), hostfs_mknod(), and hostfs_fill_sb_common(). A following commit with new Landlock tests check this new hostfs inode consistency. Cc: Anton Ivanov <anton.ivanov(a)cambridgegreys.com> Cc: Johannes Berg <johannes(a)sipsolutions.net> Cc: Richard Weinberger <richard(a)nod.at> Cc: <stable(a)vger.kernel.org> # 5.15.x: ce72750f04d6: hostfs: Fix writeback of dirty pages Cc: <stable(a)vger.kernel.org> # 5.15+ Signed-off-by: Mickaël Salaün <mic(a)digikod.net> Link: https://lore.kernel.org/r/20230309165455.175131-2-mic@digikod.net --- arch/Kconfig | 7 -- arch/um/Kconfig | 1 - fs/hostfs/hostfs.h | 1 + fs/hostfs/hostfs_kern.c | 213 +++++++++++++++++++------------------- fs/hostfs/hostfs_user.c | 1 + security/landlock/Kconfig | 2 +- 6 files changed, 109 insertions(+), 116 deletions(-) diff --git a/arch/Kconfig b/arch/Kconfig index e3511afbb7f2..d5f0841ac3c1 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -1156,13 +1156,6 @@ config COMPAT_32BIT_TIME config ARCH_NO_PREEMPT bool -config ARCH_EPHEMERAL_INODES - def_bool n - help - An arch should select this symbol if it doesn't keep track of inode - instances on its own, but instead relies on something else (e.g. the - host kernel for an UML kernel). - config ARCH_SUPPORTS_RT bool diff --git a/arch/um/Kconfig b/arch/um/Kconfig index 541a9b18e343..4057d5267c6a 100644 --- a/arch/um/Kconfig +++ b/arch/um/Kconfig @@ -5,7 +5,6 @@ menu "UML-specific options" config UML bool default y - select ARCH_EPHEMERAL_INODES select ARCH_HAS_FORTIFY_SOURCE select ARCH_HAS_GCOV_PROFILE_ALL select ARCH_HAS_KCOV diff --git a/fs/hostfs/hostfs.h b/fs/hostfs/hostfs.h index 69cb796f6270..0239e3af3945 100644 --- a/fs/hostfs/hostfs.h +++ b/fs/hostfs/hostfs.h @@ -65,6 +65,7 @@ struct hostfs_stat { unsigned long long blocks; unsigned int maj; unsigned int min; + dev_t dev; }; extern int stat_file(const char *path, struct hostfs_stat *p, int fd); diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c index 28b4f15c19eb..19496f732016 100644 --- a/fs/hostfs/hostfs_kern.c +++ b/fs/hostfs/hostfs_kern.c @@ -26,6 +26,7 @@ struct hostfs_inode_info { fmode_t mode; struct inode vfs_inode; struct mutex open_mutex; + dev_t dev; }; static inline struct hostfs_inode_info *HOSTFS_I(struct inode *inode) @@ -182,14 +183,6 @@ static char *follow_link(char *link) return ERR_PTR(n); } -static struct inode *hostfs_iget(struct super_block *sb) -{ - struct inode *inode = new_inode(sb); - if (!inode) - return ERR_PTR(-ENOMEM); - return inode; -} - static int hostfs_statfs(struct dentry *dentry, struct kstatfs *sf) { /* @@ -228,6 +221,7 @@ static struct inode *hostfs_alloc_inode(struct super_block *sb) return NULL; hi->fd = -1; hi->mode = 0; + hi->dev = 0; inode_init_once(&hi->vfs_inode); mutex_init(&hi->open_mutex); return &hi->vfs_inode; @@ -240,6 +234,7 @@ static void hostfs_evict_inode(struct inode *inode) if (HOSTFS_I(inode)->fd != -1) { close_file(&HOSTFS_I(inode)->fd); HOSTFS_I(inode)->fd = -1; + HOSTFS_I(inode)->dev = 0; } } @@ -265,6 +260,7 @@ static int hostfs_show_options(struct seq_file *seq, struct dentry *root) static const struct super_operations hostfs_sbops = { .alloc_inode = hostfs_alloc_inode, .free_inode = hostfs_free_inode, + .drop_inode = generic_delete_inode, .evict_inode = hostfs_evict_inode, .statfs = hostfs_statfs, .show_options = hostfs_show_options, @@ -512,18 +508,31 @@ static const struct address_space_operations hostfs_aops = { .write_end = hostfs_write_end, }; -static int read_name(struct inode *ino, char *name) +static int hostfs_inode_update(struct inode *ino, const struct hostfs_stat *st) +{ + set_nlink(ino, st->nlink); + i_uid_write(ino, st->uid); + i_gid_write(ino, st->gid); + ino->i_atime = + (struct timespec64){ st->atime.tv_sec, st->atime.tv_nsec }; + ino->i_mtime = + (struct timespec64){ st->mtime.tv_sec, st->mtime.tv_nsec }; + ino->i_ctime = + (struct timespec64){ st->ctime.tv_sec, st->ctime.tv_nsec }; + ino->i_size = st->size; + ino->i_blocks = st->blocks; + return 0; +} + +static int hostfs_inode_set(struct inode *ino, void *data) { + struct hostfs_stat *st = data; dev_t rdev; - struct hostfs_stat st; - int err = stat_file(name, &st, -1); - if (err) - return err; /* Reencode maj and min with the kernel encoding.*/ - rdev = MKDEV(st.maj, st.min); + rdev = MKDEV(st->maj, st->min); - switch (st.mode & S_IFMT) { + switch (st->mode & S_IFMT) { case S_IFLNK: ino->i_op = &hostfs_link_iops; break; @@ -535,7 +544,7 @@ static int read_name(struct inode *ino, char *name) case S_IFBLK: case S_IFIFO: case S_IFSOCK: - init_special_inode(ino, st.mode & S_IFMT, rdev); + init_special_inode(ino, st->mode & S_IFMT, rdev); ino->i_op = &hostfs_iops; break; case S_IFREG: @@ -547,17 +556,42 @@ static int read_name(struct inode *ino, char *name) return -EIO; } - ino->i_ino = st.ino; - ino->i_mode = st.mode; - set_nlink(ino, st.nlink); - i_uid_write(ino, st.uid); - i_gid_write(ino, st.gid); - ino->i_atime = (struct timespec64){ st.atime.tv_sec, st.atime.tv_nsec }; - ino->i_mtime = (struct timespec64){ st.mtime.tv_sec, st.mtime.tv_nsec }; - ino->i_ctime = (struct timespec64){ st.ctime.tv_sec, st.ctime.tv_nsec }; - ino->i_size = st.size; - ino->i_blocks = st.blocks; - return 0; + HOSTFS_I(ino)->dev = st->dev; + ino->i_ino = st->ino; + ino->i_mode = st->mode; + return hostfs_inode_update(ino, st); +} + +static int hostfs_inode_test(struct inode *inode, void *data) +{ + const struct hostfs_stat *st = data; + + return inode->i_ino == st->ino && HOSTFS_I(inode)->dev == st->dev; +} + +static struct inode *hostfs_iget(struct super_block *sb, char *name) +{ + struct inode *inode; + struct hostfs_stat st; + int err = stat_file(name, &st, -1); + + if (err) + return ERR_PTR(err); + + inode = iget5_locked(sb, st.ino, hostfs_inode_test, hostfs_inode_set, + &st); + if (!inode) + return ERR_PTR(-ENOMEM); + + if (inode->i_state & I_NEW) { + unlock_new_inode(inode); + } else { + spin_lock(&inode->i_lock); + hostfs_inode_update(inode, &st); + spin_unlock(&inode->i_lock); + } + + return inode; } static int hostfs_create(struct mnt_idmap *idmap, struct inode *dir, @@ -565,62 +599,48 @@ static int hostfs_create(struct mnt_idmap *idmap, struct inode *dir, { struct inode *inode; char *name; - int error, fd; - - inode = hostfs_iget(dir->i_sb); - if (IS_ERR(inode)) { - error = PTR_ERR(inode); - goto out; - } + int fd; - error = -ENOMEM; name = dentry_name(dentry); if (name == NULL) - goto out_put; + return -ENOMEM; fd = file_create(name, mode & 0777); - if (fd < 0) - error = fd; - else - error = read_name(inode, name); + if (fd < 0) { + __putname(name); + return fd; + } + inode = hostfs_iget(dir->i_sb, name); __putname(name); - if (error) - goto out_put; + if (IS_ERR(inode)) + return PTR_ERR(inode); HOSTFS_I(inode)->fd = fd; HOSTFS_I(inode)->mode = FMODE_READ | FMODE_WRITE; d_instantiate(dentry, inode); return 0; - - out_put: - iput(inode); - out: - return error; } static struct dentry *hostfs_lookup(struct inode *ino, struct dentry *dentry, unsigned int flags) { - struct inode *inode; + struct inode *inode = NULL; char *name; - int err; - - inode = hostfs_iget(ino->i_sb); - if (IS_ERR(inode)) - goto out; - err = -ENOMEM; name = dentry_name(dentry); - if (name) { - err = read_name(inode, name); - __putname(name); - } - if (err) { - iput(inode); - inode = (err == -ENOENT) ? NULL : ERR_PTR(err); + if (name == NULL) + return ERR_PTR(-ENOMEM); + + inode = hostfs_iget(ino->i_sb, name); + __putname(name); + if (IS_ERR(inode)) { + if (PTR_ERR(inode) == -ENOENT) + inode = NULL; + else + return ERR_CAST(inode); } - out: + return d_splice_alias(inode, dentry); } @@ -704,35 +724,23 @@ static int hostfs_mknod(struct mnt_idmap *idmap, struct inode *dir, char *name; int err; - inode = hostfs_iget(dir->i_sb); - if (IS_ERR(inode)) { - err = PTR_ERR(inode); - goto out; - } - - err = -ENOMEM; name = dentry_name(dentry); if (name == NULL) - goto out_put; + return -ENOMEM; err = do_mknod(name, mode, MAJOR(dev), MINOR(dev)); - if (err) - goto out_free; + if (err) { + __putname(name); + return err; + } - err = read_name(inode, name); + inode = hostfs_iget(dir->i_sb, name); __putname(name); - if (err) - goto out_put; + if (IS_ERR(inode)) + return PTR_ERR(inode); d_instantiate(dentry, inode); return 0; - - out_free: - __putname(name); - out_put: - iput(inode); - out: - return err; } static int hostfs_rename2(struct mnt_idmap *idmap, @@ -929,49 +937,40 @@ static int hostfs_fill_sb_common(struct super_block *sb, void *d, int silent) sb->s_maxbytes = MAX_LFS_FILESIZE; err = super_setup_bdi(sb); if (err) - goto out; + return err; /* NULL is printed as '(null)' by printf(): avoid that. */ if (req_root == NULL) req_root = ""; - err = -ENOMEM; sb->s_fs_info = host_root_path = kasprintf(GFP_KERNEL, "%s/%s", root_ino, req_root); if (host_root_path == NULL) - goto out; - - root_inode = new_inode(sb); - if (!root_inode) - goto out; + return -ENOMEM; - err = read_name(root_inode, host_root_path); - if (err) - goto out_put; + root_inode = hostfs_iget(sb, host_root_path); + if (IS_ERR(root_inode)) + return PTR_ERR(root_inode); if (S_ISLNK(root_inode->i_mode)) { - char *name = follow_link(host_root_path); - if (IS_ERR(name)) { - err = PTR_ERR(name); - goto out_put; - } - err = read_name(root_inode, name); + char *name; + + iput(root_inode); + name = follow_link(host_root_path); + if (IS_ERR(name)) + return PTR_ERR(name); + + root_inode = hostfs_iget(sb, name); kfree(name); - if (err) - goto out_put; + if (IS_ERR(root_inode)) + return PTR_ERR(root_inode); } - err = -ENOMEM; sb->s_root = d_make_root(root_inode); if (sb->s_root == NULL) - goto out; + return -ENOMEM; return 0; - -out_put: - iput(root_inode); -out: - return err; } static struct dentry *hostfs_read_sb(struct file_system_type *type, diff --git a/fs/hostfs/hostfs_user.c b/fs/hostfs/hostfs_user.c index 5ecc4706172b..840619e39a1a 100644 --- a/fs/hostfs/hostfs_user.c +++ b/fs/hostfs/hostfs_user.c @@ -36,6 +36,7 @@ static void stat64_to_hostfs(const struct stat64 *buf, struct hostfs_stat *p) p->blocks = buf->st_blocks; p->maj = os_major(buf->st_rdev); p->min = os_minor(buf->st_rdev); + p->dev = buf->st_dev; } int stat_file(const char *path, struct hostfs_stat *p, int fd) diff --git a/security/landlock/Kconfig b/security/landlock/Kconfig index 8e33c4e8ffb8..c1e862a38410 100644 --- a/security/landlock/Kconfig +++ b/security/landlock/Kconfig @@ -2,7 +2,7 @@ config SECURITY_LANDLOCK bool "Landlock support" - depends on SECURITY && !ARCH_EPHEMERAL_INODES + depends on SECURITY select SECURITY_PATH help Landlock is a sandboxing mechanism that enables processes to restrict -- 2.39.2

1 year, 9 months

3
6
0 0

[PATCH 5.10 000/124] 5.10.178-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.10.178 release. There are 124 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.178-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.10.178-rc1 Kuniyuki Iwashima <kuniyu(a)amazon.com> sysctl: Fix data-races in proc_dou8vec_minmax(). Valentin Schneider <vschneid(a)redhat.com> panic, kexec: make __crash_kexec() NMI safe Valentin Schneider <vschneid(a)redhat.com> kexec: turn all kexec_mutex acquisitions into trylocks Arnd Bergmann <arnd(a)arndb.de> kexec: move locking into do_kexec_load Nathan Chancellor <nathan(a)kernel.org> riscv: Handle zicsr/zifencei issues between clang and binutils Masahiro Yamada <masahiroy(a)kernel.org> kbuild: check CONFIG_AS_IS_LLVM instead of LLVM_IAS Nathan Chancellor <nathan(a)kernel.org> kbuild: Switch to 'f' variants of integrated assembler flag Masahiro Yamada <masahiroy(a)kernel.org> kbuild: check the minimum assembler version in Kconfig Steve Clevenger <scclevenger(a)os.amperecomputing.com> coresight-etm4: Fix for() loop drvdata->nr_addr_cmp range bug George Cherian <george.cherian(a)marvell.com> watchdog: sbsa_wdog: Make sure the timeout programming is within the limits Waiman Long <longman(a)redhat.com> cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods Waiman Long <longman(a)redhat.com> cgroup/cpuset: Make cpuset_fork() handle CLONE_INTO_CGROUP properly Waiman Long <longman(a)redhat.com> cgroup/cpuset: Skip spread flags update on v2 Waiman Long <longman(a)redhat.com> cgroup/cpuset: Change references of cpuset_mutex to cpuset_rwsem Gregor Herburger <gregor.herburger(a)tq-group.com> i2c: ocores: generate stop condition after timeout in polling mode Matija Glavinic Pecotic <matija.glavinic-pecotic.ext(a)nokia.com> x86/rtc: Remove __init for runtime functions Vincent Guittot <vincent.guittot(a)linaro.org> sched/fair: Fix imbalance overflow zgpeng <zgpeng.linux(a)gmail.com> sched/fair: Move calculate of avg_load to a better location Aneesh Kumar K.V <aneesh.kumar(a)linux.ibm.com> powerpc/papr_scm: Update the NUMA distance table for the target node Aneesh Kumar K.V <aneesh.kumar(a)linux.ibm.com> powerpc/pseries: Add support for FORM2 associativity Aneesh Kumar K.V <aneesh.kumar(a)linux.ibm.com> powerpc/pseries: Add a helper for form1 cpu distance Aneesh Kumar K.V <aneesh.kumar(a)linux.ibm.com> powerpc/pseries: Consolidate different NUMA distance update code paths Aneesh Kumar K.V <aneesh.kumar(a)linux.ibm.com> powerpc/pseries: Rename TYPE1_AFFINITY to FORM1_AFFINITY Aneesh Kumar K.V <aneesh.kumar(a)linux.ibm.com> powerpc/pseries: rename min_common_depth to primary_domain_index ZhaoLong Wang <wangzhaolong1(a)huawei.com> ubi: Fix deadlock caused by recursively holding work_sem Lee Jones <lee.jones(a)linaro.org> mtd: ubi: wl: Fix a couple of kernel-doc issues Zhihao Cheng <chengzhihao1(a)huawei.com> ubi: Fix failure attaching when vid_hdr offset equals to (sub)page size Waiman Long <longman(a)redhat.com> cgroup/cpuset: Wake up cpuset_attach_wq tasks in cpuset_cancel_attach() Basavaraj Natikar <Basavaraj.Natikar(a)amd.com> x86/PCI: Add quirk for AMD XHCI controller that loses MSI-X state in D3hot Jiri Kosina <jkosina(a)suse.cz> scsi: ses: Handle enclosure with just a primary component gracefully Ivan Bornyakov <i.bornyakov(a)metrotek.ru> net: sfp: initialize sfp->i2c_block_size at sfp allocation Mathis Salmen <mathis.salmen(a)matsal.de> riscv: add icache flush for nommu sigreturn trampoline Robbie Harwood <rharwood(a)redhat.com> asymmetric_keys: log on fatal failures in PE/pkcs7 Robbie Harwood <rharwood(a)redhat.com> verify_pefile: relax wrapper length check Hans de Goede <hdegoede(a)redhat.com> drm: panel-orientation-quirks: Add quirk for Lenovo Yoga Book X90F Hans de Goede <hdegoede(a)redhat.com> efi: sysfb_efi: Add quirk for Lenovo Yoga Book X91F/L Alexander Stein <alexander.stein(a)ew.tq-group.com> i2c: imx-lpi2c: clean rx/tx buffers upon new message Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> wifi: mwifiex: mark OF related data as maybe unused Grant Grundler <grundler(a)chromium.org> power: supply: cros_usbpd: reclassify "default case!" as debug Andrii Nakryiko <andrii(a)kernel.org> libbpf: Fix single-line struct definition output in btf_dump Roman Gushchin <roman.gushchin(a)linux.dev> net: macb: fix a memory corruption in extended buffer descriptor mode Eric Dumazet <edumazet(a)google.com> udp6: fix potential access to stale information Saravanan Vajravel <saravanan.vajravel(a)broadcom.com> RDMA/core: Fix GID entry ref leak when create_ah fails Xin Long <lucien.xin(a)gmail.com> sctp: fix a potential overflow in sctp_ifwdtsn_skip Ziyang Xuan <william.xuanziyang(a)huawei.com> net: qrtr: Fix an uninit variable access bug in qrtr_tx_resume() Denis Plotnikov <den-plotnikov(a)yandex-team.ru> qlcnic: check pci_reset_function result Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> drm/armada: Fix a potential double free in an error handling path YueHaibing <yuehaibing(a)huawei.com> tcp: restrict net.ipv4.tcp_app_win Eric Dumazet <edumazet(a)google.com> tcp: convert elligible sysctls to u8 Eric Dumazet <edumazet(a)google.com> ipv4: shrink netns_ipv4 with sysctl conversions Eric Dumazet <edumazet(a)google.com> sysctl: add proc_dou8vec_minmax() Harshit Mogalapalli <harshit.m.mogalapalli(a)oracle.com> niu: Fix missing unwind goto in niu_alloc_channels() Zheng Wang <zyytlz.wz(a)163.com> 9p/xen : Fix use after free bug in xen_9pfs_front_remove due to race condition Mark Zhang <markzhang(a)nvidia.com> RDMA/cma: Allow UD qp_type to join multicast only Maher Sanalla <msanalla(a)nvidia.com> IB/mlx5: Add support for 400G_8X lane speed Meir Lichtinger <meirl(a)mellanox.com> IB/mlx5: Add support for NDR link speed Chunyan Zhang <chunyan.zhang(a)unisoc.com> clk: sprd: set max_register according to mapping range Christophe Kerello <christophe.kerello(a)foss.st.com> mtd: rawnand: stm32_fmc2: use timings.mode instead of checking tRC_min Christophe Kerello <christophe.kerello(a)foss.st.com> mtd: rawnand: stm32_fmc2: remove unsupported EDO mode Arseniy Krasnov <avkrasnov(a)sberdevices.ru> mtd: rawnand: meson: fix bitmask for length in command word Bang Li <libang.linuxer(a)gmail.com> mtdblock: tolerate corrected bit-flips Daniel Vetter <daniel.vetter(a)ffwll.ch> fbmem: Reject FB_ACTIVATE_KD_TEXT from userspace Christoph Hellwig <hch(a)lst.de> btrfs: fix fast csum implementation detection David Sterba <dsterba(a)suse.com> btrfs: print checksum type and implementation at mount time Min Li <lm0963hack(a)gmail.com> Bluetooth: Fix race condition in hidp_session_thread Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> Bluetooth: L2CAP: Fix use-after-free in l2cap_disconnect_{req,rsp} Oswald Buddenhagen <oswald.buddenhagen(a)gmx.de> ALSA: hda/sigmatel: fix S/PDIF out on Intel D*45* motherboards Xu Biang <xubiang(a)hust.edu.cn> ALSA: firewire-tascam: add missing unwind goto in snd_tscm_stream_start_duplex() Oswald Buddenhagen <oswald.buddenhagen(a)gmx.de> ALSA: i2c/cs8427: fix iec958 mixer control deactivation Oswald Buddenhagen <oswald.buddenhagen(a)gmx.de> ALSA: hda/sigmatel: add pin overrides for Intel DP45SG motherboard Oswald Buddenhagen <oswald.buddenhagen(a)gmx.de> ALSA: emu10k1: fix capture interrupt handler unlinking Kornel Dulęba <korneld(a)chromium.org> Revert "pinctrl: amd: Disable and mask interrupts on resume" Eduard Zingerman <eddyz87(a)gmail.com> bpftool: Print newline before '}' for struct with padding only fields Heming Zhao <ocfs2-devel(a)oss.oracle.com> ocfs2: fix freeing uninitialized resource on ocfs2_dlm_shutdown Gaosheng Cui <cuigaosheng1(a)huawei.com> Revert "media: ti: cal: fix possible memory leak in cal_ctx_create()" Robert Foss <robert.foss(a)linaro.org> drm/bridge: lt9611: Fix PLL being unable to lock Tommi Rantala <tommi.t.rantala(a)nokia.com> selftests: intel_pstate: ftime() is deprecated Rongwei Wang <rongwei.wang(a)linux.alibaba.com> mm/swap: fix swap_info_struct race between swapoff and get_swap_pages() Zheng Yejian <zhengyejian1(a)huawei.com> ring-buffer: Fix race while reader and writer are on the same page Karol Herbst <kherbst(a)redhat.com> drm/nouveau/disp: Support more modes by checking with lower bpc Boris Brezillon <boris.brezillon(a)collabora.com> drm/panfrost: Fix the panfrost_mmu_map_fault_addr() error path Jason Montleon <jmontleo(a)redhat.com> ASoC: hdac_hdmi: use set_stream() instead of set_tdm_slots() Steven Rostedt (Google) <rostedt(a)goodmis.org> tracing: Free error logs of tracing instances Michal Sojka <michal.sojka(a)cvut.cz> can: isotp: isotp_ops: fix poll() to not report false EPOLLOUT events Oleksij Rempel <linux(a)rempel-privat.de> can: j1939: j1939_tp_tx_dat_new(): fix out-of-bounds memory access Zheng Yejian <zhengyejian1(a)huawei.com> ftrace: Fix issue that 'direct->addr' not restored in modify_ftrace_direct() John Keeping <john(a)metanate.com> ftrace: Mark get_lock_parent_ip() __always_inline Kan Liang <kan.liang(a)linux.intel.com> perf/core: Fix the same task check in perf_event_set_output Zhong Jinghua <zhongjinghua(a)huawei.com> scsi: iscsi_tcp: Check that sock is valid before iscsi_set_param() Nuno Sá <nuno.sa(a)analog.com> iio: adc: ad7791: fix IRQ flags Jeremy Soller <jeremy(a)system76.com> ALSA: hda/realtek: Add quirk for Clevo X370SNW Geert Uytterhoeven <geert+renesas(a)glider.be> dt-bindings: serial: renesas,scif: Fix 4th IRQ for 4-IRQ SCIFs Ryusuke Konishi <konishi.ryusuke(a)gmail.com> nilfs2: fix sysfs interface lifetime Ryusuke Konishi <konishi.ryusuke(a)gmail.com> nilfs2: fix potential UAF of struct nilfs_sc_info in nilfs_segctor_thread() Sherry Sun <sherry.sun(a)nxp.com> tty: serial: fsl_lpuart: avoid checking for transfer complete when UARTCTRL_SBK is asserted in lpuart32_tx_empty Biju Das <biju.das.jz(a)bp.renesas.com> tty: serial: sh-sci: Fix Rx on RZ/G2L SCI Biju Das <biju.das.jz(a)bp.renesas.com> tty: serial: sh-sci: Fix transmit end interrupt handler Kai-Heng Feng <kai.heng.feng(a)canonical.com> iio: light: cm32181: Unregister second I2C client if present William Breathitt Gray <william.gray(a)linaro.org> iio: dac: cio-dac: Fix max DAC write value check for 12-bit Lars-Peter Clausen <lars(a)metafoo.de> iio: adc: ti-ads7950: Set `can_sleep` flag for GPIO chip Bjørn Mork <bjorn(a)mork.no> USB: serial: option: add Quectel RM500U-CN modem Enrico Sau <enrico.sau(a)gmail.com> USB: serial: option: add Telit FE990 compositions RD Babiera <rdbabiera(a)google.com> usb: typec: altmodes/displayport: Fix configure initial pin assignment Kees Jan Koster <kjkoster(a)kjkoster.org> USB: serial: cp210x: add Silicon Labs IFS-USB-DATACABLE IDs D Scott Phillips <scott(a)os.amperecomputing.com> xhci: also avoid the XHCI_ZERO_64B_REGS quirk with a passthrough iommu Wayne Chang <waynec(a)nvidia.com> usb: xhci: tegra: fix sleep in atomic call Dai Ngo <dai.ngo(a)oracle.com> NFSD: callback request does not use correct credential for AUTH_SYS Jeff Layton <jlayton(a)kernel.org> sunrpc: only free unix grouplist after RCU settles Corinna Vinschen <vinschen(a)redhat.com> net: stmmac: fix up RX flow hash indirection table when setting channels Siddharth Vadapalli <s-vadapalli(a)ti.com> net: ethernet: ti: am65-cpsw: Fix mdio cleanup in probe Dhruva Gole <d-gole(a)ti.com> gpio: davinci: Add irq chip flag to skip set wake Ziyang Xuan <william.xuanziyang(a)huawei.com> ipv6: Fix an uninit variable access bug in __ip6_make_skb() Sricharan Ramabadhran <quic_srichara(a)quicinc.com> net: qrtr: Do not do DEL_SERVER broadcast after DEL_CLIENT Xin Long <lucien.xin(a)gmail.com> sctp: check send stream number after wait_for_sndbuf Jakub Kicinski <kuba(a)kernel.org> net: don't let netpoll invoke NAPI if in xmit context Eric Dumazet <edumazet(a)google.com> icmp: guard against too small mtu Ziyang Xuan <william.xuanziyang(a)huawei.com> net: qrtr: Fix a refcount bug in qrtr_recvmsg() Luca Weiss <luca(a)z3ntu.xyz> net: qrtr: combine nameservice into main module Felix Fietkau <nbd(a)nbd.name> wifi: mac80211: fix invalid drv_sta_pre_rcu_remove calls for non-uploaded sta Nico Boehr <nrb(a)linux.ibm.com> KVM: s390: pv: fix external interruption loop not always detected Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> pwm: sprd: Explicitly set .polarity in .get_state() Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> pwm: cros-ec: Explicitly set .polarity in .get_state() Mohammed Gamal <mgamal(a)redhat.com> Drivers: vmbus: Check for channel allocation before looking up relids Randy Dunlap <rdunlap(a)infradead.org> gpio: GPIO_REGMAP: select REGMAP instead of depending on it ------------- Diffstat: .../devicetree/bindings/serial/renesas,scif.yaml | 4 +- Documentation/networking/ip-sysctl.rst | 2 + Documentation/powerpc/associativity.rst | 104 +++++ Documentation/sound/hd-audio/models.rst | 2 +- Makefile | 12 +- arch/powerpc/include/asm/firmware.h | 7 +- arch/powerpc/include/asm/prom.h | 3 +- arch/powerpc/include/asm/topology.h | 6 +- arch/powerpc/kernel/prom_init.c | 3 +- arch/powerpc/mm/numa.c | 433 ++++++++++++++++----- arch/powerpc/platforms/pseries/firmware.c | 3 +- arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 + arch/powerpc/platforms/pseries/hotplug-memory.c | 2 + arch/powerpc/platforms/pseries/lpar.c | 4 +- arch/powerpc/platforms/pseries/papr_scm.c | 7 + arch/riscv/Kconfig | 22 ++ arch/riscv/Makefile | 12 +- arch/riscv/kernel/signal.c | 9 +- arch/s390/kvm/intercept.c | 32 +- arch/x86/kernel/sysfb_efi.c | 8 + arch/x86/kernel/x86_init.c | 4 +- arch/x86/pci/fixup.c | 21 + crypto/asymmetric_keys/pkcs7_verify.c | 10 +- crypto/asymmetric_keys/verify_pefile.c | 32 +- drivers/clk/sprd/common.c | 9 +- drivers/gpio/Kconfig | 2 +- drivers/gpio/gpio-davinci.c | 2 +- drivers/gpu/drm/armada/armada_drv.c | 1 - drivers/gpu/drm/bridge/lontium-lt9611.c | 1 + drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +- drivers/gpu/drm/nouveau/dispnv50/disp.c | 32 ++ drivers/gpu/drm/nouveau/nouveau_dp.c | 8 +- drivers/gpu/drm/panfrost/panfrost_mmu.c | 1 + drivers/hv/connection.c | 4 + drivers/hwtracing/coresight/coresight-etm4x-core.c | 2 +- drivers/i2c/busses/i2c-imx-lpi2c.c | 2 + drivers/i2c/busses/i2c-ocores.c | 35 +- drivers/iio/adc/ad7791.c | 2 +- drivers/iio/adc/ti-ads7950.c | 1 + drivers/iio/dac/cio-dac.c | 4 +- drivers/iio/light/cm32181.c | 12 + drivers/infiniband/core/cma.c | 60 +-- drivers/infiniband/core/verbs.c | 2 + drivers/infiniband/hw/mlx5/main.c | 16 + drivers/media/platform/ti-vpe/cal.c | 4 +- drivers/mtd/mtdblock.c | 12 +- drivers/mtd/nand/raw/meson_nand.c | 6 +- drivers/mtd/nand/raw/stm32_fmc2_nand.c | 3 + drivers/mtd/ubi/build.c | 21 +- drivers/mtd/ubi/wl.c | 5 +- drivers/net/ethernet/cadence/macb_main.c | 4 + drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c | 8 +- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +- drivers/net/ethernet/sun/niu.c | 2 +- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 6 +- drivers/net/phy/sfp.c | 13 +- drivers/net/wireless/marvell/mwifiex/pcie.c | 2 +- drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +- drivers/pinctrl/pinctrl-amd.c | 36 +- drivers/power/supply/cros_usbpd-charger.c | 2 +- drivers/pwm/pwm-cros-ec.c | 1 + drivers/pwm/pwm-sprd.c | 1 + drivers/scsi/iscsi_tcp.c | 3 +- drivers/scsi/ses.c | 20 +- drivers/tty/serial/fsl_lpuart.c | 8 +- drivers/tty/serial/sh-sci.c | 10 +- drivers/usb/host/xhci-tegra.c | 6 +- drivers/usb/host/xhci.c | 6 +- drivers/usb/serial/cp210x.c | 1 + drivers/usb/serial/option.c | 10 + drivers/usb/typec/altmodes/displayport.c | 6 +- drivers/video/fbdev/core/fbmem.c | 2 + drivers/watchdog/sbsa_gwdt.c | 1 + fs/btrfs/disk-io.c | 17 + fs/btrfs/super.c | 2 - fs/nfsd/nfs4callback.c | 4 +- fs/nilfs2/segment.c | 3 +- fs/nilfs2/super.c | 2 + fs/nilfs2/the_nilfs.c | 12 +- fs/ocfs2/dlmglue.c | 8 +- fs/ocfs2/super.c | 3 +- fs/proc/proc_sysctl.c | 6 + include/linux/ftrace.h | 2 +- include/linux/kexec.h | 2 +- include/linux/sysctl.h | 2 + include/net/netns/ipv4.h | 100 ++--- init/Kconfig | 12 + kernel/cgroup/cpuset.c | 214 +++++++--- kernel/events/core.c | 2 +- kernel/kexec.c | 41 +- kernel/kexec_core.c | 28 +- kernel/kexec_file.c | 4 +- kernel/kexec_internal.h | 15 +- kernel/ksysfs.c | 7 +- kernel/sched/fair.c | 15 +- kernel/sysctl.c | 65 ++++ kernel/trace/ftrace.c | 15 +- kernel/trace/ring_buffer.c | 13 +- kernel/trace/trace.c | 1 + mm/swapfile.c | 3 +- net/9p/trans_xen.c | 4 + net/bluetooth/hidp/core.c | 2 +- net/bluetooth/l2cap_core.c | 24 +- net/can/isotp.c | 17 +- net/can/j1939/transport.c | 5 +- net/core/netpoll.c | 19 +- net/ipv4/icmp.c | 5 + net/ipv4/sysctl_net_ipv4.c | 203 +++++----- net/ipv6/ip6_output.c | 7 +- net/ipv6/udp.c | 8 +- net/mac80211/sta_info.c | 3 +- net/qrtr/Makefile | 3 +- net/qrtr/{qrtr.c => af_qrtr.c} | 15 + net/qrtr/ns.c | 15 +- net/sctp/socket.c | 4 + net/sctp/stream_interleave.c | 3 +- net/sunrpc/svcauth_unix.c | 17 +- scripts/Kconfig.include | 6 + scripts/as-version.sh | 69 ++++ scripts/dummy-tools/gcc | 6 + sound/firewire/tascam/tascam-stream.c | 2 +- sound/i2c/cs8427.c | 7 +- sound/pci/emu10k1/emupcm.c | 4 +- sound/pci/hda/patch_realtek.c | 1 + sound/pci/hda/patch_sigmatel.c | 10 + sound/soc/codecs/hdac_hdmi.c | 17 +- tools/lib/bpf/btf_dump.c | 11 +- tools/testing/selftests/intel_pstate/aperf.c | 22 +- 128 files changed, 1652 insertions(+), 615 deletions(-)

1 year, 9 months

12
140
0 0

[PATCH 5.15 00/93] 5.15.107-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.15.107 release. There are 93 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Fri, 14 Apr 2023 08:28:02 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.107-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.15.107-rc1 Alistair Popple <apopple(a)nvidia.com> mm: take a page reference when removing device exclusive entries Robert Foss <robert.foss(a)linaro.org> drm/bridge: lt9611: Fix PLL being unable to lock Rongwei Wang <rongwei.wang(a)linux.alibaba.com> mm/swap: fix swap_info_struct race between swapoff and get_swap_pages() Zheng Yejian <zhengyejian1(a)huawei.com> ring-buffer: Fix race while reader and writer are on the same page Karol Herbst <kherbst(a)redhat.com> drm/nouveau/disp: Support more modes by checking with lower bpc Boris Brezillon <boris.brezillon(a)collabora.com> drm/panfrost: Fix the panfrost_mmu_map_fault_addr() error path Yafang Shao <laoar.shao(a)gmail.com> mm: vmalloc: avoid warn_alloc noise caused by fatal signal Jason Montleon <jmontleo(a)redhat.com> ASoC: hdac_hdmi: use set_stream() instead of set_tdm_slots() Steven Rostedt (Google) <rostedt(a)goodmis.org> tracing: Free error logs of tracing instances Michal Sojka <michal.sojka(a)cvut.cz> can: isotp: isotp_ops: fix poll() to not report false EPOLLOUT events Oleksij Rempel <linux(a)rempel-privat.de> can: j1939: j1939_tp_tx_dat_new(): fix out-of-bounds memory access Christian Brauner <brauner(a)kernel.org> fs: drop peer group ids under namespace lock Zheng Yejian <zhengyejian1(a)huawei.com> ftrace: Fix issue that 'direct->addr' not restored in modify_ftrace_direct() John Keeping <john(a)metanate.com> ftrace: Mark get_lock_parent_ip() __always_inline Kan Liang <kan.liang(a)linux.intel.com> perf/core: Fix the same task check in perf_event_set_output Thiago Rafael Becker <tbecker(a)redhat.com> cifs: sanitize paths in cifs_update_super_prepath. Steve French <stfrench(a)microsoft.com> smb3: lower default deferred close timeout to address perf regression Steve French <stfrench(a)microsoft.com> smb3: allow deferred close timeout to be configurable Zhong Jinghua <zhongjinghua(a)huawei.com> scsi: iscsi_tcp: Check that sock is valid before iscsi_set_param() Li Zetao <lizetao1(a)huawei.com> scsi: qla2xxx: Fix memory leak in qla2x00_probe_one() Nuno Sá <nuno.sa(a)analog.com> iio: adc: ad7791: fix IRQ flags Steve Clevenger <scclevenger(a)os.amperecomputing.com> coresight-etm4: Fix for() loop drvdata->nr_addr_cmp range bug Suzuki K Poulose <suzuki.poulose(a)arm.com> coresight: etm4x: Do not access TRCIDR1 for identification Jeremy Soller <jeremy(a)system76.com> ALSA: hda/realtek: Add quirk for Clevo X370SNW Marios Makassikis <mmakassikis(a)freebox.fr> ksmbd: do not call kvmalloc() with __GFP_NORETRY | __GFP_NO_WARN Geert Uytterhoeven <geert+renesas(a)glider.be> dt-bindings: serial: renesas,scif: Fix 4th IRQ for 4-IRQ SCIFs Ryusuke Konishi <konishi.ryusuke(a)gmail.com> nilfs2: fix sysfs interface lifetime Ryusuke Konishi <konishi.ryusuke(a)gmail.com> nilfs2: fix potential UAF of struct nilfs_sc_info in nilfs_segctor_thread() Sherry Sun <sherry.sun(a)nxp.com> tty: serial: fsl_lpuart: avoid checking for transfer complete when UARTCTRL_SBK is asserted in lpuart32_tx_empty Biju Das <biju.das.jz(a)bp.renesas.com> tty: serial: sh-sci: Fix Rx on RZ/G2L SCI Biju Das <biju.das.jz(a)bp.renesas.com> tty: serial: sh-sci: Fix transmit end interrupt handler Kai-Heng Feng <kai.heng.feng(a)canonical.com> iio: light: cm32181: Unregister second I2C client if present William Breathitt Gray <william.gray(a)linaro.org> iio: dac: cio-dac: Fix max DAC write value check for 12-bit Lars-Peter Clausen <lars(a)metafoo.de> iio: adc: ti-ads7950: Set `can_sleep` flag for GPIO chip Arnd Bergmann <arnd(a)arndb.de> iio: adis16480: select CONFIG_CRC32 Bjørn Mork <bjorn(a)mork.no> USB: serial: option: add Quectel RM500U-CN modem Enrico Sau <enrico.sau(a)gmail.com> USB: serial: option: add Telit FE990 compositions RD Babiera <rdbabiera(a)google.com> usb: typec: altmodes/displayport: Fix configure initial pin assignment Kees Jan Koster <kjkoster(a)kjkoster.org> USB: serial: cp210x: add Silicon Labs IFS-USB-DATACABLE IDs Heikki Krogerus <heikki.krogerus(a)linux.intel.com> usb: dwc3: pci: add support for the Intel Meteor Lake-S Pawel Laszczak <pawell(a)cadence.com> usb: cdnsp: Fixes error: uninitialized symbol 'len' D Scott Phillips <scott(a)os.amperecomputing.com> xhci: also avoid the XHCI_ZERO_64B_REGS quirk with a passthrough iommu Wayne Chang <waynec(a)nvidia.com> usb: xhci: tegra: fix sleep in atomic call Masahiro Yamada <masahiroy(a)kernel.org> kbuild: refactor single builds of *.ko Shailend Chand <shailend(a)google.com> gve: Secure enough bytes in the first TX desc for all TCP pkts Andy Roulin <aroulin(a)nvidia.com> ethtool: reset #lanes when lanes is omitted Lingyu Liu <lingyu.liu(a)intel.com> ice: Reset FDIR counter in FDIR init stage Simei Su <simei.su(a)intel.com> ice: fix wrong fallback logic for FDIR Dai Ngo <dai.ngo(a)oracle.com> NFSD: callback request does not use correct credential for AUTH_SYS Jeff Layton <jlayton(a)kernel.org> sunrpc: only free unix grouplist after RCU settles Corinna Vinschen <vinschen(a)redhat.com> net: stmmac: fix up RX flow hash indirection table when setting channels Siddharth Vadapalli <s-vadapalli(a)ti.com> net: ethernet: ti: am65-cpsw: Fix mdio cleanup in probe Dhruva Gole <d-gole(a)ti.com> gpio: davinci: Add irq chip flag to skip set wake Mark Pearson <mpearson-lenovo(a)squebb.ca> platform/x86: think-lmi: Clean up display of current_value on Thinkstation Mark Pearson <mpearson-lenovo(a)squebb.ca> platform/x86: think-lmi: Fix memory leaks when parsing ThinkStation WMI strings Armin Wolf <W_Armin(a)gmx.de> platform/x86: think-lmi: Fix memory leak when showing current settings Ziyang Xuan <william.xuanziyang(a)huawei.com> ipv6: Fix an uninit variable access bug in __ip6_make_skb() Sricharan Ramabadhran <quic_srichara(a)quicinc.com> net: qrtr: Do not do DEL_SERVER broadcast after DEL_CLIENT Xin Long <lucien.xin(a)gmail.com> sctp: check send stream number after wait_for_sndbuf Gustav Ekelund <gustaek(a)axis.com> net: dsa: mv88e6xxx: Reset mv88e6393x force WD event bit Jakub Kicinski <kuba(a)kernel.org> net: don't let netpoll invoke NAPI if in xmit context Eric Dumazet <edumazet(a)google.com> icmp: guard against too small mtu Chuck Lever <chuck.lever(a)oracle.com> NFSD: Avoid calling OPDESC() with ops->opnum == OP_ILLEGAL Ziyang Xuan <william.xuanziyang(a)huawei.com> net: qrtr: Fix a refcount bug in qrtr_recvmsg() Luca Weiss <luca(a)z3ntu.xyz> net: qrtr: combine nameservice into main module Felix Fietkau <nbd(a)nbd.name> wifi: mac80211: fix invalid drv_sta_pre_rcu_remove calls for non-uploaded sta Nico Boehr <nrb(a)linux.ibm.com> KVM: s390: pv: fix external interruption loop not always detected Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> pwm: sprd: Explicitly set .polarity in .get_state() Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> pwm: cros-ec: Explicitly set .polarity in .get_state() Mohammed Gamal <mgamal(a)redhat.com> Drivers: vmbus: Check for channel allocation before looking up relids Randy Dunlap <rdunlap(a)infradead.org> gpio: GPIO_REGMAP: select REGMAP instead of depending on it Tonghao Zhang <tong(a)infragraf.org> bpf: hash map, avoid deadlock with suitable hash mask Christian König <christian.koenig(a)amd.com> drm/amdgpu: fix amdgpu_job_free_resources v2 Andrey Grodzovsky <andrey.grodzovsky(a)amd.com> drm/amdgpu: Prevent race between late signaled fences and GPU reset. Matthew Howell <matthew.howell(a)sealevel.com> serial: exar: Add support for Sealevel 7xxxC serial cards Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> serial: 8250_exar: derive nr_ports from PCI ID for Acces I/O cards Daniil Tatianin <d-tatianin(a)yandex-team.ru> iavf/iavf_main: actually log ->src mask when talking about it Jacob Keller <jacob.e.keller(a)intel.com> iavf: return errno code instead of status code Hans de Goede <hdegoede(a)redhat.com> platform/x86: int3472/discrete: Ensure the clk/power enable pins are in output mode Hans de Goede <hdegoede(a)redhat.com> platform/x86: int3472: Split into 2 drivers Mustafa Ismail <mustafa.ismail(a)intel.com> RDMA/irdma: Do not request 2-level PBLEs for CQ alloc Brian Foster <bfoster(a)redhat.com> NFSD: pass range end to vfs_fsync_range() instead of count Chuck Lever <chuck.lever(a)oracle.com> NFSD: Fix sparse warning Li Zetao <ocfs2-devel(a)oss.oracle.com> ocfs2: fix memory leak in ocfs2_mount_volume() Heming Zhao via Ocfs2-devel <ocfs2-devel(a)oss.oracle.com> ocfs2: rewrite error handling of ocfs2_fill_super Heming Zhao via Ocfs2-devel <ocfs2-devel(a)oss.oracle.com> ocfs2: ocfs2_mount_volume does cleanup job before return error Yang Yingliang <yangyingliang(a)huawei.com> soc: sifive: ccache: fix missing of_node_put() in sifive_ccache_init() Yang Yingliang <yangyingliang(a)huawei.com> soc: sifive: ccache: fix missing free_irq() in error path in sifive_ccache_init() Yang Yingliang <yangyingliang(a)huawei.com> soc: sifive: ccache: fix missing iounmap() in error path in sifive_ccache_init() Ben Dooks <ben.dooks(a)sifive.com> soc: sifive: ccache: use pr_fmt() to remove CCACHE: prefixes Ben Dooks <ben.dooks(a)sifive.com> soc: sifive: ccache: reduce printing on init Zong Li <zong.li(a)sifive.com> soc: sifive: ccache: determine the cache level from dts Greentime Hu <greentime.hu(a)sifive.com> soc: sifive: ccache: Rename SiFive L2 cache to Composable cache. ------------- Diffstat: .../devicetree/bindings/serial/renesas,scif.yaml | 4 +- Makefile | 20 +- arch/s390/kvm/intercept.c | 32 ++- drivers/edac/Kconfig | 2 +- drivers/edac/sifive_edac.c | 12 +- drivers/gpio/Kconfig | 2 +- drivers/gpio/gpio-davinci.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 + drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 18 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 1 + drivers/gpu/drm/bridge/lontium-lt9611.c | 1 + drivers/gpu/drm/nouveau/dispnv50/disp.c | 32 +++ drivers/gpu/drm/nouveau/nouveau_dp.c | 8 +- drivers/gpu/drm/panfrost/panfrost_mmu.c | 1 + drivers/hv/connection.c | 4 + drivers/hwtracing/coresight/coresight-etm4x-core.c | 24 +- drivers/hwtracing/coresight/coresight-etm4x.h | 20 +- drivers/iio/adc/ad7791.c | 2 +- drivers/iio/adc/ti-ads7950.c | 1 + drivers/iio/dac/cio-dac.c | 4 +- drivers/iio/imu/Kconfig | 1 + drivers/iio/light/cm32181.c | 12 + drivers/infiniband/hw/irdma/verbs.c | 15 +- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- drivers/net/dsa/mv88e6xxx/global2.c | 20 ++ drivers/net/dsa/mv88e6xxx/global2.h | 1 + drivers/net/ethernet/google/gve/gve.h | 2 + drivers/net/ethernet/google/gve/gve_tx.c | 12 +- drivers/net/ethernet/intel/iavf/iavf_main.c | 22 +- drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 23 +- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 6 +- drivers/platform/x86/intel/int3472/Makefile | 9 +- ...472_clk_and_regulator.c => clk_and_regulator.c} | 5 +- drivers/platform/x86/intel/int3472/common.c | 54 +++++ .../{intel_skl_int3472_common.h => common.h} | 3 - .../{intel_skl_int3472_discrete.c => discrete.c} | 32 ++- .../x86/intel/int3472/intel_skl_int3472_common.c | 106 -------- .../{intel_skl_int3472_tps68470.c => tps68470.c} | 23 +- drivers/platform/x86/think-lmi.c | 20 +- drivers/pwm/pwm-cros-ec.c | 1 + drivers/pwm/pwm-sprd.c | 1 + drivers/scsi/iscsi_tcp.c | 3 +- drivers/scsi/qla2xxx/qla_os.c | 1 + drivers/soc/sifive/Kconfig | 6 +- drivers/soc/sifive/Makefile | 2 +- drivers/soc/sifive/sifive_ccache.c | 266 +++++++++++++++++++++ drivers/soc/sifive/sifive_l2_cache.c | 237 ------------------ drivers/tty/serial/8250/8250_exar.c | 51 ++-- drivers/tty/serial/fsl_lpuart.c | 8 +- drivers/tty/serial/sh-sci.c | 10 +- drivers/usb/cdns3/cdnsp-ep0.c | 3 +- drivers/usb/dwc3/dwc3-pci.c | 4 + drivers/usb/host/xhci-tegra.c | 6 +- drivers/usb/host/xhci.c | 6 +- drivers/usb/serial/cp210x.c | 1 + drivers/usb/serial/option.c | 10 + drivers/usb/typec/altmodes/displayport.c | 6 +- fs/cifs/cifsfs.c | 1 + fs/cifs/connect.c | 2 + fs/cifs/file.c | 4 +- fs/cifs/fs_context.c | 22 +- fs/cifs/fs_context.h | 11 + fs/cifs/misc.c | 2 +- fs/ksmbd/connection.c | 5 +- fs/namespace.c | 2 +- fs/nfsd/nfs4callback.c | 4 +- fs/nfsd/nfs4proc.c | 7 +- fs/nfsd/nfs4xdr.c | 4 +- fs/nilfs2/segment.c | 3 +- fs/nilfs2/super.c | 2 + fs/nilfs2/the_nilfs.c | 12 +- fs/ocfs2/journal.c | 2 +- fs/ocfs2/journal.h | 1 + fs/ocfs2/super.c | 105 ++++---- include/linux/ftrace.h | 2 +- include/soc/sifive/sifive_ccache.h | 16 ++ include/soc/sifive/sifive_l2_cache.h | 16 -- kernel/bpf/hashtab.c | 4 +- kernel/events/core.c | 2 +- kernel/trace/ftrace.c | 15 +- kernel/trace/ring_buffer.c | 13 +- kernel/trace/trace.c | 1 + mm/memory.c | 16 +- mm/swapfile.c | 3 +- mm/vmalloc.c | 8 +- net/can/isotp.c | 17 +- net/can/j1939/transport.c | 5 +- net/core/netpoll.c | 19 +- net/ethtool/linkmodes.c | 7 +- net/ipv4/icmp.c | 5 + net/ipv6/ip6_output.c | 7 +- net/mac80211/sta_info.c | 3 +- net/qrtr/Makefile | 3 +- net/qrtr/{qrtr.c => af_qrtr.c} | 2 + net/qrtr/ns.c | 15 +- net/sctp/socket.c | 4 + net/sunrpc/svcauth_unix.c | 17 +- sound/pci/hda/patch_realtek.c | 1 + sound/soc/codecs/hdac_hdmi.c | 17 +- 101 files changed, 968 insertions(+), 639 deletions(-)

1 year, 9 months

10
105
0 0

kernel error at led trigger "phy0tpt"

by Tobias Dahms

Hello, since some kernel versions I get a kernel errror while setting led trigger to phy0tpt. command to reproduce: echo phy0tpt > /sys/class/leds/bpi-r2\:isink\:blue/trigger same trigger, other led location => no error: echo phy0tpt > /sys/class/leds/bpi-r2\:pio\:blue/trigger other trigger, same led location => no error: echo phy0tx > /sys/class/leds/bpi-r2\:isink\:blue/trigger last good kernel: bpi-r2 5.19.17-bpi-r2 error at kernel versions: bpi-r2 6.0.19-bpi-r2 up to bpi-r2 6.3.0-rc1-bpi-r2+ wireless lan card: 01:00.0 Network controller: MEDIATEK Corp. MT7612E 802.11acbgn PCI Express Wireless Network Adapter distribution: Arch-Linux-ARM (with vanilla kernel instead of original distribution kernel) board: BananaPi-R2 log messages: Mär 12 12:54:55 bpi-r2 kernel: BUG: scheduling while atomic: swapper/0/0/0x00000100 Mär 12 12:54:55 bpi-r2 kernel: Modules linked in: aes_arm_bs crypto_simd cryptd nft_masq nft_ct nf_log_syslog nft_log nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables nfnetlink mt76x2e mt76x2_common mt76x02_lib mt76 spi_mt65xx pwm_mediatek mt6577_auxadc sch_fq_codel fuse configfs ip_tables x_tables Mär 12 12:54:55 bpi-r2 kernel: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.3.0-rc1-bpi-r2+ #1 Mär 12 12:54:55 bpi-r2 kernel: Hardware name: Mediatek Cortex-A7 (Device Tree) Mär 12 12:54:55 bpi-r2 kernel: Backtrace: Mär 12 12:54:55 bpi-r2 kernel: dump_backtrace from show_stack+0x20/0x24 Mär 12 12:54:55 bpi-r2 kernel: r7:c14ab340 r6:00000000 r5:c12507fc r4:600f0113 Mär 12 12:54:55 bpi-r2 kernel: show_stack from dump_stack_lvl+0x48/0x54 Mär 12 12:54:55 bpi-r2 kernel: dump_stack_lvl from dump_stack+0x18/0x1c Mär 12 12:54:55 bpi-r2 kernel: r5:c1508fc0 r4:00000000 Mär 12 12:54:55 bpi-r2 kernel: dump_stack from __schedule_bug+0x60/0x70 Mär 12 12:54:55 bpi-r2 kernel: __schedule_bug from __schedule+0x6b0/0x904 Mär 12 12:54:55 bpi-r2 kernel: r5:c1508fc0 r4:eed9d340 Mär 12 12:54:55 bpi-r2 kernel: __schedule from schedule+0x6c/0xe8 Mär 12 12:54:55 bpi-r2 kernel: r10:c1501ba0 r9:00000000 r8:00001b58 r7:c1508fc0 r6:00001b58 r5:0000004a Mär 12 12:54:55 bpi-r2 kernel: r4:c1508fc0 Mär 12 12:54:55 bpi-r2 kernel: schedule from schedule_hrtimeout_range_clock+0xec/0x14c Mär 12 12:54:55 bpi-r2 kernel: r5:0000004a r4:47ac1837 Mär 12 12:54:55 bpi-r2 kernel: schedule_hrtimeout_range_clock from schedule_hrtimeout_range+0x28/0x30 Mär 12 12:54:55 bpi-r2 kernel: r10:c1501c50 r9:c1508fc0 r8:00000002 r7:00000000 r6:c1501ba0 r5:00000000 Mär 12 12:54:55 bpi-r2 kernel: r4:00001b58 Mär 12 12:54:55 bpi-r2 kernel: schedule_hrtimeout_range from usleep_range_state+0x6c/0x90 Mär 12 12:54:55 bpi-r2 kernel: usleep_range_state from pwrap_read16+0xfc/0x2a0 Mär 12 12:54:55 bpi-r2 kernel: r9:0000004a r8:4844840c r7:0000004a r6:48447f8a r5:01980000 r4:c2703940 Mär 12 12:54:55 bpi-r2 kernel: pwrap_read16 from pwrap_regmap_read+0x24/0x28 Mär 12 12:54:55 bpi-r2 kernel: r10:00001f00 r9:00000000 r8:00000f00 r7:c2703940 r6:c1501c50 r5:00000330 Mär 12 12:54:55 bpi-r2 kernel: r4:c196e000 r3:c06f3fbc Mär 12 12:54:55 bpi-r2 kernel: pwrap_regmap_read from _regmap_read+0x70/0x160 Mär 12 12:54:55 bpi-r2 kernel: _regmap_read from _regmap_update_bits+0xc8/0x108 Mär 12 12:54:55 bpi-r2 kernel: r10:00001f00 r9:00000000 r8:00000f00 r7:c1508fc0 r6:00000330 r5:00000000 Mär 12 12:54:55 bpi-r2 kernel: r4:c196e000 r3:00000000 Mär 12 12:54:55 bpi-r2 kernel: _regmap_update_bits from regmap_update_bits_base+0x60/0x84 Mär 12 12:54:55 bpi-r2 kernel: r10:00000000 r9:00000f00 r8:00000000 r7:00001f00 r6:00000000 r5:00000330 Mär 12 12:54:55 bpi-r2 kernel: r4:c196e000 Mär 12 12:54:55 bpi-r2 kernel: regmap_update_bits_base from mt6323_led_set_blink+0xf0/0x148 Mär 12 12:54:55 bpi-r2 kernel: r10:eed94800 r9:c16998c0 r8:c196e000 r7:c31f0c48 r6:c2456f48 r5:00000000 Mär 12 12:54:55 bpi-r2 kernel: r4:0000014e Mär 12 12:54:55 bpi-r2 kernel: mt6323_led_set_blink from led_blink_setup+0x3c/0x110 Mär 12 12:54:55 bpi-r2 kernel: r9:c16998c0 r8:00000770 r7:c1501d60 r6:c1501d5c r5:c1501d60 r4:c31f0c48 Mär 12 12:54:55 bpi-r2 kernel: led_blink_setup from led_blink_set+0x60/0x64 Mär 12 12:54:55 bpi-r2 kernel: r7:c1501d60 r6:c1501d5c r5:c31f0c58 r4:c31f0c48 Mär 12 12:54:55 bpi-r2 kernel: led_blink_set from led_trigger_blink+0x44/0x58 Mär 12 12:54:55 bpi-r2 kernel: r7:c1501d60 r6:c1501d5c r5:c5b69740 r4:c31f0c48 Mär 12 12:54:55 bpi-r2 kernel: led_trigger_blink from tpt_trig_timer+0x10c/0x130 Mär 12 12:54:55 bpi-r2 kernel: r7:c0df71f0 r6:c1508fc0 r5:c5b685a0 r4:c597b628 Mär 12 12:54:55 bpi-r2 kernel: tpt_trig_timer from call_timer_fn+0x48/0x168 Mär 12 12:54:55 bpi-r2 kernel: r6:c597b628 r5:00000100 r4:c16998c0 Mär 12 12:54:55 bpi-r2 kernel: call_timer_fn from run_timer_softirq+0x600/0x6c8 Mär 12 12:54:55 bpi-r2 kernel: r9:c16998c0 r8:00000000 r7:00000770 r6:00000000 r5:c1501de4 r4:c597b628 Mär 12 12:54:55 bpi-r2 kernel: run_timer_softirq from __do_softirq+0x140/0x34c Mär 12 12:54:55 bpi-r2 kernel: r10:00000082 r9:00000100 r8:c1698481 r7:c1698f60 r6:00000001 r5:00000002 Mär 12 12:54:55 bpi-r2 kernel: r4:c1503084 Mär 12 12:54:55 bpi-r2 kernel: __do_softirq from irq_exit+0xb8/0xe8 Mär 12 12:54:55 bpi-r2 kernel: r10:10c5387d r9:c1508fc0 r8:c1698481 r7:c1501f0c r6:00000000 r5:c1501ed8 Mär 12 12:54:55 bpi-r2 kernel: r4:c14aaf58 Mär 12 12:54:55 bpi-r2 kernel: irq_exit from generic_handle_arch_irq+0x48/0x4c Mär 12 12:54:55 bpi-r2 kernel: r5:c1501ed8 r4:c14aaf58 Mär 12 12:54:55 bpi-r2 kernel: generic_handle_arch_irq from __irq_svc+0x88/0xb0 Mär 12 12:54:55 bpi-r2 kernel: Exception stack(0xc1501ed8 to 0xc1501f20) Mär 12 12:54:55 bpi-r2 kernel: 1ec0: 000862f4 2d8f2000 Mär 12 12:54:55 bpi-r2 kernel: 1ee0: c1508fc0 00000000 c1699cc0 c1504f10 c1504f70 00000001 c1698481 c123a9b4 Mär 12 12:54:55 bpi-r2 kernel: 1f00: 10c5387d c1501f3c 00000001 c1501f28 c0e36fa0 c0e3767c 600f0013 ffffffff Mär 12 12:54:55 bpi-r2 kernel: r7:c1501f0c r6:ffffffff r5:600f0013 r4:c0e3767c Mär 12 12:54:55 bpi-r2 kernel: default_idle_call from do_idle+0xc4/0x124 Mär 12 12:54:55 bpi-r2 kernel: r5:c1504f10 r4:00000001 Mär 12 12:54:55 bpi-r2 kernel: do_idle from cpu_startup_entry+0x28/0x2c Mär 12 12:54:55 bpi-r2 kernel: r9:efffcd40 r8:00000000 r7:00000045 r6:c1326068 r5:c16fb9b8 r4:000000ec Mär 12 12:54:55 bpi-r2 kernel: cpu_startup_entry from rest_init+0xc0/0xc4 Mär 12 12:54:55 bpi-r2 kernel: rest_init from arch_post_acpi_subsys_init+0x0/0x30 Mär 12 12:54:55 bpi-r2 kernel: r5:c16fb9b8 r4:c16cc038 Mär 12 12:54:55 bpi-r2 kernel: arch_call_rest_init from start_kernel+0x6c0/0x704 Mär 12 12:54:55 bpi-r2 kernel: start_kernel from 0x0 Mär 12 12:54:55 bpi-r2 kernel: bad: scheduling from the idle thread! Mär 12 12:54:55 bpi-r2 kernel: CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W 6.3.0-rc1-bpi-r2+ #1 Mär 12 12:54:55 bpi-r2 kernel: Hardware name: Mediatek Cortex-A7 (Device Tree) Mär 12 12:54:55 bpi-r2 kernel: Backtrace: Mär 12 12:54:55 bpi-r2 kernel: dump_backtrace from show_stack+0x20/0x24 Mär 12 12:54:55 bpi-r2 kernel: r7:c14ab340 r6:00000001 r5:c12507fc r4:60070013 Mär 12 12:54:55 bpi-r2 kernel: show_stack from dump_stack_lvl+0x48/0x54 Mär 12 12:54:55 bpi-r2 kernel: dump_stack_lvl from dump_stack+0x18/0x1c Mär 12 12:54:55 bpi-r2 kernel: r5:c1508fc0 r4:eed9d340 Mär 12 12:54:55 bpi-r2 kernel: dump_stack from dequeue_task_idle+0x30/0x44 Mär 12 12:54:55 bpi-r2 kernel: dequeue_task_idle from __schedule+0x4bc/0x904 Mär 12 12:54:55 bpi-r2 kernel: r5:c1508fc0 r4:eed9d340 Mär 12 12:54:55 bpi-r2 kernel: __schedule from schedule+0x6c/0xe8 Mär 12 12:54:55 bpi-r2 kernel: r10:c1501ba0 r9:00000000 r8:00001b58 r7:c1508fc0 r6:00001b58 r5:0000004a Mär 12 12:54:55 bpi-r2 kernel: r4:c1508fc0 Mär 12 12:54:55 bpi-r2 kernel: schedule from schedule_hrtimeout_range_clock+0xec/0x14c Mär 12 12:54:55 bpi-r2 kernel: r5:0000004a r4:492d8817 Mär 12 12:54:55 bpi-r2 kernel: schedule_hrtimeout_range_clock from schedule_hrtimeout_range+0x28/0x30 Mär 12 12:54:55 bpi-r2 kernel: r10:c1501c50 r9:c1508fc0 r8:00000002 r7:00000000 r6:c1501ba0 r5:00000000 Mär 12 12:54:55 bpi-r2 kernel: r4:00001b58 Mär 12 12:54:55 bpi-r2 kernel: schedule_hrtimeout_range from usleep_range_state+0x6c/0x90 Mär 12 12:54:55 bpi-r2 kernel: usleep_range_state from pwrap_read16+0xfc/0x2a0 Mär 12 12:54:55 bpi-r2 kernel: r9:0000004a r8:49c5f439 r7:0000004a r6:49c5f0eb r5:01990000 r4:c2703940 Mär 12 12:54:55 bpi-r2 kernel: pwrap_read16 from pwrap_regmap_read+0x24/0x28 Mär 12 12:54:55 bpi-r2 kernel: r10:0000ffff r9:00000000 r8:0000014d r7:c2703940 r6:c1501c50 r5:00000332 Mär 12 12:54:55 bpi-r2 kernel: r4:c196e000 r3:c06f3fbc Mär 12 12:54:55 bpi-r2 kernel: pwrap_regmap_read from _regmap_read+0x70/0x160 Mär 12 12:54:55 bpi-r2 kernel: _regmap_read from _regmap_update_bits+0xc8/0x108 Mär 12 12:54:55 bpi-r2 kernel: r10:0000ffff r9:00000000 r8:0000014d r7:c1508fc0 r6:00000332 r5:00000000 Mär 12 12:54:55 bpi-r2 kernel: r4:c196e000 r3:00000000 Mär 12 12:54:55 bpi-r2 kernel: _regmap_update_bits from regmap_update_bits_base+0x60/0x84 Mär 12 12:54:55 bpi-r2 kernel: r10:00000000 r9:0000014d r8:00000000 r7:0000ffff r6:00000000 r5:00000332 Mär 12 12:54:55 bpi-r2 kernel: r4:c196e000 Mär 12 12:54:55 bpi-r2 kernel: regmap_update_bits_base from mt6323_led_set_blink+0x138/0x148 Mär 12 12:54:55 bpi-r2 kernel: r10:eed94800 r9:00000000 r8:c196e000 r7:c31f0c48 r6:c2456f48 r5:00000000 Mär 12 12:54:55 bpi-r2 kernel: r4:0000014e Mär 12 12:54:55 bpi-r2 kernel: mt6323_led_set_blink from led_blink_setup+0x3c/0x110 Mär 12 12:54:55 bpi-r2 kernel: r9:c16998c0 r8:00000770 r7:c1501d60 r6:c1501d5c r5:c1501d60 r4:c31f0c48 Mär 12 12:54:55 bpi-r2 kernel: led_blink_setup from led_blink_set+0x60/0x64 Mär 12 12:54:55 bpi-r2 kernel: r7:c1501d60 r6:c1501d5c r5:c31f0c58 r4:c31f0c48 Mär 12 12:54:55 bpi-r2 kernel: led_blink_set from led_trigger_blink+0x44/0x58 Mär 12 12:54:55 bpi-r2 kernel: r7:c1501d60 r6:c1501d5c r5:c5b69740 r4:c31f0c48 Mär 12 12:54:55 bpi-r2 kernel: led_trigger_blink from tpt_trig_timer+0x10c/0x130 Mär 12 12:54:55 bpi-r2 kernel: r7:c0df71f0 r6:c1508fc0 r5:c5b685a0 r4:c597b628 Mär 12 12:54:55 bpi-r2 kernel: tpt_trig_timer from call_timer_fn+0x48/0x168 Mär 12 12:54:55 bpi-r2 kernel: r6:c597b628 r5:00000100 r4:c16998c0 Mär 12 12:54:55 bpi-r2 kernel: call_timer_fn from run_timer_softirq+0x600/0x6c8 Mär 12 12:54:55 bpi-r2 kernel: r9:c16998c0 r8:00000000 r7:00000770 r6:00000000 r5:c1501de4 r4:c597b628 Mär 12 12:54:55 bpi-r2 kernel: run_timer_softirq from __do_softirq+0x140/0x34c Mär 12 12:54:55 bpi-r2 kernel: r10:00000082 r9:00000100 r8:c1698481 r7:c1698f60 r6:00000001 r5:00000002 Mär 12 12:54:55 bpi-r2 kernel: r4:c1503084 Mär 12 12:54:55 bpi-r2 kernel: __do_softirq from irq_exit+0xb8/0xe8 Mär 12 12:54:55 bpi-r2 kernel: r10:10c5387d r9:c1508fc0 r8:c1698481 r7:c1501f0c r6:00000000 r5:c1501ed8 Mär 12 12:54:55 bpi-r2 kernel: r4:c14aaf58 Mär 12 12:54:55 bpi-r2 kernel: irq_exit from generic_handle_arch_irq+0x48/0x4c Mär 12 12:54:55 bpi-r2 kernel: r5:c1501ed8 r4:c14aaf58 Mär 12 12:54:55 bpi-r2 kernel: generic_handle_arch_irq from __irq_svc+0x88/0xb0 Mär 12 12:54:55 bpi-r2 kernel: Exception stack(0xc1501ed8 to 0xc1501f20) Mär 12 12:54:55 bpi-r2 kernel: 1ec0: 000862f4 2d8f2000 Mär 12 12:54:55 bpi-r2 kernel: 1ee0: c1508fc0 00000000 c1699cc0 c1504f10 c1504f70 00000001 c1698481 c123a9b4 Mär 12 12:54:55 bpi-r2 kernel: 1f00: 10c5387d c1501f3c 00000001 c1501f28 c0e36fa0 c0e3767c 600f0013 ffffffff Mär 12 12:54:55 bpi-r2 kernel: r7:c1501f0c r6:ffffffff r5:600f0013 r4:c0e3767c Mär 12 12:54:55 bpi-r2 kernel: default_idle_call from do_idle+0xc4/0x124 Mär 12 12:54:55 bpi-r2 kernel: r5:c1504f10 r4:00000001 Mär 12 12:54:55 bpi-r2 kernel: do_idle from cpu_startup_entry+0x28/0x2c Mär 12 12:54:55 bpi-r2 kernel: r9:efffcd40 r8:00000000 r7:00000045 r6:c1326068 r5:c16fb9b8 r4:000000ec Mär 12 12:54:55 bpi-r2 kernel: cpu_startup_entry from rest_init+0xc0/0xc4 Mär 12 12:54:55 bpi-r2 kernel: rest_init from arch_post_acpi_subsys_init+0x0/0x30 Mär 12 12:54:55 bpi-r2 kernel: r5:c16fb9b8 r4:c16cc038 Mär 12 12:54:55 bpi-r2 kernel: arch_call_rest_init from start_kernel+0x6c0/0x704 Mär 12 12:54:55 bpi-r2 kernel: start_kernel from 0x0 Mär 12 12:54:55 bpi-r2 kernel: ------------[ cut here ]------------ best regards Tobias Dahms

1 year, 10 months

5
9
0 0

[PATCH v5 0/2] KEYS: asymmetric: Copy sig and digest in public_key_verify_signature()

by Roberto Sassu

From: Roberto Sassu <roberto.sassu(a)huawei.com> Changelog: v4: - Replace sg_init_table()/sg_set_buf() with sg_init_one() (suggested by Eric) v3: v2: - Add patch by Herbert to take only the needed bytes for a MPI from the scatterlist - Use only one scatterlist for signature and digest (suggested by Eric) - Rename key variable to buf (suggested by Eric) - Rename key_max_len variable to buf_len - Use size_t for the buf_len variable instead of u32 v1: - Unconditionally copy the signature and digest to the buffer to keep the code simple (suggested by Eric) Herbert Xu (1): lib/mpi: Fix buffer overrun when SG is too long Roberto Sassu (1): KEYS: asymmetric: Copy sig and digest in public_key_verify_signature() crypto/asymmetric_keys/public_key.c | 38 ++++++++++++++++------------- lib/mpi/mpicoder.c | 3 ++- 2 files changed, 23 insertions(+), 18 deletions(-) -- 2.25.1

1 year, 10 months

8
24
0 0

[PATCH v4 1/2] usb: gadget: udc: core: Invoke usb_gadget_connect only when started

by Badhri Jagan Sridharan

usb_udc_connect_control does not check to see if the udc has already been started. This causes gadget->ops->pullup to be called through usb_gadget_connect when invoked from usb_udc_vbus_handler even before usb_gadget_udc_start is called. Guard this by checking for udc->started in usb_udc_connect_control before invoking usb_gadget_connect. Guarding udc->vbus, udc->started, gadget->connect, gadget->deactivate related functions with connect_lock. usb_gadget_connect_locked, usb_gadget_disconnect_locked, usb_udc_connect_control_locked, usb_gadget_udc_start_locked, usb_gadget_udc_stop_locked are called with this lock held as they can be simulataneously invoked from different code paths. Adding an additional check to make sure udc is started(udc->started) before pullup callback is invoked. Cc: stable(a)vger.kernel.org Fixes: 628ef0d273a6 ("usb: udc: add usb_udc_vbus_handler") Signed-off-by: Badhri Jagan Sridharan <badhri(a)google.com> --- Changes since v3: * Make internal gadget_connect/disconnect functions static Changes since v2: * Added __must_hold marking for connect_lock Changes since v1: * Fixed commit message comments. * Renamed udc_connect_control_lock to connect_lock and made it per device. * udc->vbus, udc->started, gadget->connect, gadget->deactivate are all now guarded by connect_lock. * Code now checks for udc->started to be set before invoking pullup callback. --- drivers/usb/gadget/udc/core.c | 148 ++++++++++++++++++++++++---------- 1 file changed, 104 insertions(+), 44 deletions(-) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index 3dcbba739db6..af92c2e8e10c 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -37,6 +37,10 @@ static struct bus_type gadget_bus_type; * @vbus: for udcs who care about vbus status, this value is real vbus status; * for udcs who do not care about vbus status, this value is always true * @started: the UDC's started state. True if the UDC had started. + * @connect_lock: protects udc->vbus, udc->started, gadget->connect, gadget->deactivate related + * functions. usb_gadget_connect_locked, usb_gadget_disconnect_locked, + * usb_udc_connect_control_locked, usb_gadget_udc_start_locked, usb_gadget_udc_stop_locked are + * called with this lock held. * * This represents the internal data structure which is used by the UDC-class * to hold information about udc driver and gadget together. @@ -48,6 +52,7 @@ struct usb_udc { struct list_head list; bool vbus; bool started; + struct mutex connect_lock; }; static struct class *udc_class; @@ -687,17 +692,9 @@ int usb_gadget_vbus_disconnect(struct usb_gadget *gadget) } EXPORT_SYMBOL_GPL(usb_gadget_vbus_disconnect); -/** - * usb_gadget_connect - software-controlled connect to USB host - * @gadget:the peripheral being connected - * - * Enables the D+ (or potentially D-) pullup. The host will start - * enumerating this gadget when the pullup is active and a VBUS session - * is active (the link is powered). - * - * Returns zero on success, else negative errno. - */ -int usb_gadget_connect(struct usb_gadget *gadget) +/* Internal version of usb_gadget_connect needs to be called with connect_lock held. */ +static int usb_gadget_connect_locked(struct usb_gadget *gadget) + __must_hold(&gadget->udc->connect_lock) { int ret = 0; @@ -706,10 +703,12 @@ int usb_gadget_connect(struct usb_gadget *gadget) goto out; } - if (gadget->deactivated) { + if (gadget->deactivated || !gadget->udc->started) { /* * If gadget is deactivated we only save new state. * Gadget will be connected automatically after activation. + * + * udc first needs to be started before gadget can be pulled up. */ gadget->connected = true; goto out; @@ -724,22 +723,32 @@ int usb_gadget_connect(struct usb_gadget *gadget) return ret; } -EXPORT_SYMBOL_GPL(usb_gadget_connect); /** - * usb_gadget_disconnect - software-controlled disconnect from USB host - * @gadget:the peripheral being disconnected - * - * Disables the D+ (or potentially D-) pullup, which the host may see - * as a disconnect (when a VBUS session is active). Not all systems - * support software pullup controls. + * usb_gadget_connect - software-controlled connect to USB host + * @gadget:the peripheral being connected * - * Following a successful disconnect, invoke the ->disconnect() callback - * for the current gadget driver so that UDC drivers don't need to. + * Enables the D+ (or potentially D-) pullup. The host will start + * enumerating this gadget when the pullup is active and a VBUS session + * is active (the link is powered). * * Returns zero on success, else negative errno. */ -int usb_gadget_disconnect(struct usb_gadget *gadget) +int usb_gadget_connect(struct usb_gadget *gadget) +{ + int ret; + + mutex_lock(&gadget->udc->connect_lock); + ret = usb_gadget_connect_locked(gadget); + mutex_unlock(&gadget->udc->connect_lock); + + return ret; +} +EXPORT_SYMBOL_GPL(usb_gadget_connect); + +/* Internal version of usb_gadget_disconnect needs to be called with connect_lock held. */ +static int usb_gadget_disconnect_locked(struct usb_gadget *gadget) + __must_hold(&gadget->udc->connect_lock) { int ret = 0; @@ -751,10 +760,12 @@ int usb_gadget_disconnect(struct usb_gadget *gadget) if (!gadget->connected) goto out; - if (gadget->deactivated) { + if (gadget->deactivated || !gadget->udc->started) { /* * If gadget is deactivated we only save new state. * Gadget will stay disconnected after activation. + * + * udc should have been started before gadget being pulled down. */ gadget->connected = false; goto out; @@ -774,6 +785,30 @@ int usb_gadget_disconnect(struct usb_gadget *gadget) return ret; } + +/** + * usb_gadget_disconnect - software-controlled disconnect from USB host + * @gadget:the peripheral being disconnected + * + * Disables the D+ (or potentially D-) pullup, which the host may see + * as a disconnect (when a VBUS session is active). Not all systems + * support software pullup controls. + * + * Following a successful disconnect, invoke the ->disconnect() callback + * for the current gadget driver so that UDC drivers don't need to. + * + * Returns zero on success, else negative errno. + */ +int usb_gadget_disconnect(struct usb_gadget *gadget) +{ + int ret; + + mutex_lock(&gadget->udc->connect_lock); + ret = usb_gadget_disconnect_locked(gadget); + mutex_unlock(&gadget->udc->connect_lock); + + return ret; +} EXPORT_SYMBOL_GPL(usb_gadget_disconnect); /** @@ -794,10 +829,11 @@ int usb_gadget_deactivate(struct usb_gadget *gadget) if (gadget->deactivated) goto out; + mutex_lock(&gadget->udc->connect_lock); if (gadget->connected) { - ret = usb_gadget_disconnect(gadget); + ret = usb_gadget_disconnect_locked(gadget); if (ret) - goto out; + goto unlock; /* * If gadget was being connected before deactivation, we want @@ -807,6 +843,8 @@ int usb_gadget_deactivate(struct usb_gadget *gadget) } gadget->deactivated = true; +unlock: + mutex_unlock(&gadget->udc->connect_lock); out: trace_usb_gadget_deactivate(gadget, ret); @@ -830,6 +868,7 @@ int usb_gadget_activate(struct usb_gadget *gadget) if (!gadget->deactivated) goto out; + mutex_lock(&gadget->udc->connect_lock); gadget->deactivated = false; /* @@ -837,7 +876,8 @@ int usb_gadget_activate(struct usb_gadget *gadget) * while it was being deactivated, we call usb_gadget_connect(). */ if (gadget->connected) - ret = usb_gadget_connect(gadget); + ret = usb_gadget_connect_locked(gadget); + mutex_unlock(&gadget->udc->connect_lock); out: trace_usb_gadget_activate(gadget, ret); @@ -1078,12 +1118,13 @@ EXPORT_SYMBOL_GPL(usb_gadget_set_state); /* ------------------------------------------------------------------------- */ -static void usb_udc_connect_control(struct usb_udc *udc) +/* Acquire connect_lock before calling this function. */ +static void usb_udc_connect_control_locked(struct usb_udc *udc) __must_hold(&udc->connect_lock) { - if (udc->vbus) - usb_gadget_connect(udc->gadget); + if (udc->vbus && udc->started) + usb_gadget_connect_locked(udc->gadget); else - usb_gadget_disconnect(udc->gadget); + usb_gadget_disconnect_locked(udc->gadget); } /** @@ -1099,10 +1140,12 @@ void usb_udc_vbus_handler(struct usb_gadget *gadget, bool status) { struct usb_udc *udc = gadget->udc; + mutex_lock(&udc->connect_lock); if (udc) { udc->vbus = status; - usb_udc_connect_control(udc); + usb_udc_connect_control_locked(udc); } + mutex_unlock(&udc->connect_lock); } EXPORT_SYMBOL_GPL(usb_udc_vbus_handler); @@ -1124,7 +1167,7 @@ void usb_gadget_udc_reset(struct usb_gadget *gadget, EXPORT_SYMBOL_GPL(usb_gadget_udc_reset); /** - * usb_gadget_udc_start - tells usb device controller to start up + * usb_gadget_udc_start_locked - tells usb device controller to start up * @udc: The UDC to be started * * This call is issued by the UDC Class driver when it's about @@ -1135,8 +1178,11 @@ EXPORT_SYMBOL_GPL(usb_gadget_udc_reset); * necessary to have it powered on. * * Returns zero on success, else negative errno. + * + * Caller should acquire connect_lock before invoking this function. */ -static inline int usb_gadget_udc_start(struct usb_udc *udc) +static inline int usb_gadget_udc_start_locked(struct usb_udc *udc) + __must_hold(&udc->connect_lock) { int ret; @@ -1153,7 +1199,7 @@ static inline int usb_gadget_udc_start(struct usb_udc *udc) } /** - * usb_gadget_udc_stop - tells usb device controller we don't need it anymore + * usb_gadget_udc_stop_locked - tells usb device controller we don't need it anymore * @udc: The UDC to be stopped * * This call is issued by the UDC Class driver after calling @@ -1162,8 +1208,11 @@ static inline int usb_gadget_udc_start(struct usb_udc *udc) * The details are implementation specific, but it can go as * far as powering off UDC completely and disable its data * line pullups. + * + * Caller should acquire connect lock before invoking this function. */ -static inline void usb_gadget_udc_stop(struct usb_udc *udc) +static inline void usb_gadget_udc_stop_locked(struct usb_udc *udc) + __must_hold(&udc->connect_lock) { if (!udc->started) { dev_err(&udc->dev, "UDC had already stopped\n"); @@ -1322,6 +1371,7 @@ int usb_add_gadget(struct usb_gadget *gadget) udc->gadget = gadget; gadget->udc = udc; + mutex_init(&udc->connect_lock); udc->started = false; @@ -1523,11 +1573,15 @@ static int gadget_bind_driver(struct device *dev) if (ret) goto err_bind; - ret = usb_gadget_udc_start(udc); - if (ret) + mutex_lock(&udc->connect_lock); + ret = usb_gadget_udc_start_locked(udc); + if (ret) { + mutex_unlock(&udc->connect_lock); goto err_start; + } usb_gadget_enable_async_callbacks(udc); - usb_udc_connect_control(udc); + usb_udc_connect_control_locked(udc); + mutex_unlock(&udc->connect_lock); kobject_uevent(&udc->dev.kobj, KOBJ_CHANGE); return 0; @@ -1558,12 +1612,14 @@ static void gadget_unbind_driver(struct device *dev) kobject_uevent(&udc->dev.kobj, KOBJ_CHANGE); - usb_gadget_disconnect(gadget); + mutex_lock(&udc->connect_lock); + usb_gadget_disconnect_locked(gadget); usb_gadget_disable_async_callbacks(udc); if (gadget->irq) synchronize_irq(gadget->irq); udc->driver->unbind(gadget); - usb_gadget_udc_stop(udc); + usb_gadget_udc_stop_locked(udc); + mutex_unlock(&udc->connect_lock); mutex_lock(&udc_lock); driver->is_bound = false; @@ -1649,11 +1705,15 @@ static ssize_t soft_connect_store(struct device *dev, } if (sysfs_streq(buf, "connect")) { - usb_gadget_udc_start(udc); - usb_gadget_connect(udc->gadget); + mutex_lock(&udc->connect_lock); + usb_gadget_udc_start_locked(udc); + usb_gadget_connect_locked(udc->gadget); + mutex_unlock(&udc->connect_lock); } else if (sysfs_streq(buf, "disconnect")) { - usb_gadget_disconnect(udc->gadget); - usb_gadget_udc_stop(udc); + mutex_lock(&udc->connect_lock); + usb_gadget_disconnect_locked(udc->gadget); + usb_gadget_udc_stop_locked(udc); + mutex_unlock(&udc->connect_lock); } else { dev_err(dev, "unsupported command '%s'\n", buf); ret = -EINVAL; base-commit: d629c0e221cd99198b843d8351a0a9bfec6c0423 -- 2.40.0.577.gac1e443424-goog

1 year, 10 months

5
8
0 0

[PATCH AUTOSEL 6.2 01/30] drm/cirrus: NULL-check pipe->plane.state->fb in cirrus_pipe_update()

by Sasha Levin

From: Alexandr Sapozhnikov <alsp705(a)gmail.com> [ Upstream commit 7245e629dcaaf308f1868aeffa218e9849c77893 ] After having been compared to NULL value at cirrus.c:455, pointer 'pipe->plane.state->fb' is passed as 1st parameter in call to function 'cirrus_fb_blit_rect' at cirrus.c:461, where it is dereferenced at cirrus.c:316. Found by Linux Verification Center (linuxtesting.org) with SVACE. v2: * aligned commit message to line-length limits Signed-off-by: Alexandr Sapozhnikov <alsp705(a)gmail.com> Reviewed-by: Thomas Zimmermann <tzimmermann(a)suse.de> Signed-off-by: Thomas Zimmermann <tzimmermann(a)suse.de> Link: https://patchwork.freedesktop.org/patch/msgid/20230215171549.16305-1-alsp70… Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/tiny/cirrus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tiny/cirrus.c b/drivers/gpu/drm/tiny/cirrus.c index 678c2ef1cae70..ffa7e61dd1835 100644 --- a/drivers/gpu/drm/tiny/cirrus.c +++ b/drivers/gpu/drm/tiny/cirrus.c @@ -455,7 +455,7 @@ static void cirrus_pipe_update(struct drm_simple_display_pipe *pipe, if (state->fb && cirrus->cpp != cirrus_cpp(state->fb)) cirrus_mode_set(cirrus, &crtc->mode, state->fb); - if (drm_atomic_helper_damage_merged(old_state, state, &rect)) + if (state->fb && drm_atomic_helper_damage_merged(old_state, state, &rect)) cirrus_fb_blit_rect(state->fb, &shadow_plane_state->data[0], &rect); } -- 2.39.2

1 year, 10 months

4
40
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror April 2023