December 2023 - Linux-stable-mirror

[PATCH 1/4] ext4: fix double-free of blocks due to wrong extents moved_len

by Baokun Li

In ext4_move_extents(), moved_len is only updated when all moves are successfully executed, and only discards orig_inode and donor_inode preallocations when moved_len is not zero. When the loop fails to exit after successfully moving some extents, moved_len is not updated and remains at 0, so it does not discard the preallocations. If the moved extents overlap with the preallocated extents, the overlapped extents are freed twice in ext4_mb_release_inode_pa() and ext4_process_freed_data() (as described in commit 94d7c16cbbbd), and bb_free is incremented twice. Hence when trim is executed, a zero-division bug is triggered in mb_update_avg_fragment_size() because bb_free is not zero and bb_fragments is zero. Therefore, update move_len after each extent move to avoid the issue. Reported-by: Wei Chen <harperchen1110(a)gmail.com> Reported-by: xingwei lee <xrivendell7(a)gmail.com> Closes: https://lore.kernel.org/r/CAO4mrferzqBUnCag8R3m2zf897ts9UEuhjFQGPtODT92rYyR… Fixes: fcf6b1b729bc ("ext4: refactor ext4_move_extents code base") CC: stable(a)vger.kernel.org # 3.18 Signed-off-by: Baokun Li <libaokun1(a)huawei.com> --- fs/ext4/move_extent.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index 3aa57376d9c2..4b9b503c6346 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c @@ -672,7 +672,7 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp, __u64 orig_blk, */ ext4_double_up_write_data_sem(orig_inode, donor_inode); /* Swap original branches with new branches */ - move_extent_per_page(o_filp, donor_inode, + *moved_len += move_extent_per_page(o_filp, donor_inode, orig_page_index, donor_page_index, offset_in_page, cur_len, unwritten, &ret); @@ -682,7 +682,6 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp, __u64 orig_blk, o_start += cur_len; d_start += cur_len; } - *moved_len = o_start - orig_blk; if (*moved_len > len) *moved_len = len; -- 2.31.1

1 year, 10 months

2
2
0 0

stable-rc/linux-4.19.y baseline: 95 runs, 3 regressions (v4.19.302-37-gc6ac8872cc6c4)

by kernelci.org bot

stable-rc/linux-4.19.y baseline: 95 runs, 3 regressions (v4.19.302-37-gc6ac8872cc6c4) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ------------------+------+---------------+----------+---------------------+------------ at91sam9g20ek | arm | lab-broonie | gcc-10 | multi_v5_defconfig | 1 beaglebone-black | arm | lab-broonie | gcc-10 | omap2plus_defconfig | 1 rk3288-veyron-jaq | arm | lab-collabora | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/linux-4.19.y/kernel/v4.19.30… Test: baseline Tree: stable-rc Branch: linux-4.19.y Describe: v4.19.302-37-gc6ac8872cc6c4 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: c6ac8872cc6c4a8be4cb67fc13d5ab7e2004813b Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ------------------+------+---------------+----------+---------------------+------------ at91sam9g20ek | arm | lab-broonie | gcc-10 | multi_v5_defconfig | 1 Details: https://kernelci.org/test/plan/id/6580764dc034c4e1f7e134af Results: 42 PASS, 9 FAIL, 1 SKIP Full config: multi_v5_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/linux-4.19.y/v4.19.302-37-gc6ac8872… HTML log: https://storage.kernelci.org//stable-rc/linux-4.19.y/v4.19.302-37-gc6ac8872… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/6580764dc034c4e1f7e134e0 failing since 20 days (last pass: v4.19.299-93-g263cae4d5493f, first fail: v4.19.299-93-gc66845304b463) 2023-12-18T16:41:11.758141 + set +x 2023-12-18T16:41:11.758611 <8><LAVA_SIGNAL_ENDRUN 0_dmesg 369773_1.5.2.4.1> 2023-12-18T16:41:11.870723 / # # 2023-12-18T16:41:11.973772 export SHELL=/bin/sh 2023-12-18T16:41:11.974605 # 2023-12-18T16:41:12.076642 / # export SHELL=/bin/sh. /lava-369773/environment 2023-12-18T16:41:12.077435 2023-12-18T16:41:12.179589 / # . /lava-369773/environment/lava-369773/bin/lava-test-runner /lava-369773/1 2023-12-18T16:41:12.181012 2023-12-18T16:41:12.183507 / # /lava-369773/bin/lava-test-runner /lava-369773/1 ... (12 line(s) more) platform | arch | lab | compiler | defconfig | regressions ------------------+------+---------------+----------+---------------------+------------ beaglebone-black | arm | lab-broonie | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/plan/id/65807711c2c1a06fdfe134d7 Results: 41 PASS, 10 FAIL, 1 SKIP Full config: omap2plus_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/linux-4.19.y/v4.19.302-37-gc6ac8872… HTML log: https://storage.kernelci.org//stable-rc/linux-4.19.y/v4.19.302-37-gc6ac8872… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/65807711c2c1a06fdfe13509 new failure (last pass: v4.19.302-32-gb2fab883a7817) 2023-12-18T16:44:25.903778 + set +x 2023-12-18T16:44:25.907812 <8>[ 18.595603] <LAVA_SIGNAL_ENDRUN 0_dmesg 369786_1.5.2.4.1> 2023-12-18T16:44:26.017893 / # # 2023-12-18T16:44:26.119817 export SHELL=/bin/sh 2023-12-18T16:44:26.120339 # 2023-12-18T16:44:26.221700 / # export SHELL=/bin/sh. /lava-369786/environment 2023-12-18T16:44:26.222298 2023-12-18T16:44:26.323608 / # . /lava-369786/environment/lava-369786/bin/lava-test-runner /lava-369786/1 2023-12-18T16:44:26.324283 2023-12-18T16:44:26.332985 / # /lava-369786/bin/lava-test-runner /lava-369786/1 ... (12 line(s) more) platform | arch | lab | compiler | defconfig | regressions ------------------+------+---------------+----------+---------------------+------------ rk3288-veyron-jaq | arm | lab-collabora | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/65807aaeb351ca3fe3e13486 Results: 60 PASS, 9 FAIL, 1 SKIP Full config: multi_v7_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/linux-4.19.y/v4.19.302-37-gc6ac8872… HTML log: https://storage.kernelci.org//stable-rc/linux-4.19.y/v4.19.302-37-gc6ac8872… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.cros-ec-keyb-probed: https://kernelci.org/test/case/id/65807aaeb351ca3fe3e134bd new failure (last pass: v4.19.302-32-gb2fab883a7817) 2023-12-18T17:07:49.860741 <8>[ 10.344823] <LAVA_SIGNAL_TESTCASE TEST_CASE_ID=cros-ec-keyb-driver-present RESULT=pass> 2023-12-18T17:07:50.872403 /lava-12305479/1/../bin/lava-test-case 2023-12-18T17:07:50.881002 <8>[ 11.365862] <LAVA_SIGNAL_TESTCASE TEST_CASE_ID=cros-ec-keyb-probed RESULT=fail>

1 year, 10 months

1
0
0 0

IMA performance regression in 5.10.194 when using overlayfs

by rkolchmeyer＠google.com

Hi all, 5.10.194 includes 331d85f0bc6e (ovl: Always reevaluate the file signature for IMA), which resulted in a performance regression for workloads that use IMA and run from overlayfs. 5.10.202 includes cd5a262a07a5 (ima: detect changes to the backing overlay file), which resolved the regression in the upstream kernel. However, from my testing [1], this change doesn't resolve the regression on stable kernels. From what I can tell, cd5a262a07a5 (ima: detect changes to the backing overlay file) depends on both db1d1e8b9867 (IMA: use vfs_getattr_nosec to get the i_version) and a1175d6b1bda (vfs: plumb i_version handling into struct kstat). These two dependent changes were not backported to stable kernels. As a result, IMA seems to be caching the wrong i_version value when using overlayfs. From my testing, backporting these two dependent changes is sufficient to resolve the issue in stable kernels. Would it make sense to backport those changes to stable kernels? It's possible that they may not follow the stable kernel patching rules. I think the issue can also be fixed directly in stable trees with the following diff (which doesn't make sense in the upstream kernel): diff --git a/security/integrity/ima/ima_api.c b/security/integrity/ima/ima_api.c index 70efd4aa1bd1..c84ae6b62b3a 100644 --- a/security/integrity/ima/ima_api.c +++ b/security/integrity/ima/ima_api.c @@ -239,7 +239,7 @@ int ima_collect_measurement(struct integrity_iint_cache *iint, * which do not support i_version, support is limited to an initial * measurement/appraisal/audit. */ - i_version = inode_query_iversion(inode); + i_version = inode_query_iversion(real_inode); hash.hdr.algo = algo; /* Initialize hash digest to 0's in case of failure */ I've verified that this diff resolves the performance regression. Which approach would make the most sense to fix the issue in stable kernels? Backporting the dependent commits, or merging the above diff? I'd be happy to prepare and mail patches either way. Looking forward to your thoughts. Thanks, -Robert [1] I'm benchmarking with the following: cat <<EOF > /sys/kernel/security/ima/policy audit func=BPRM_CHECK audit func=FILE_MMAP mask=MAY_EXEC EOF docker run --rm debian bash -c "TIMEFORMAT=%3R; time bash -c :" A good result looks like 0.002 (units are seconds), and a bad result looks like 0.034.

1 year, 10 months

4
5
0 0

[PATCH] regulator: qcom_smd: Add LDO5 MP5496 regulator

by Varadarajan Narayanan

Add support for LDO5 regulator. This is used by IPQ9574 USB. Signed-off-by: Varadarajan Narayanan <quic_varada(a)quicinc.com> --- drivers/regulator/qcom_smd-regulator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c index 09c471a0ba2e..d1be9568025e 100644 --- a/drivers/regulator/qcom_smd-regulator.c +++ b/drivers/regulator/qcom_smd-regulator.c @@ -796,6 +796,7 @@ static const struct rpm_regulator_data rpm_mp5496_regulators[] = { { "s1", QCOM_SMD_RPM_SMPA, 1, &mp5496_smps, "s1" }, { "s2", QCOM_SMD_RPM_SMPA, 2, &mp5496_smps, "s2" }, { "l2", QCOM_SMD_RPM_LDOA, 2, &mp5496_ldoa2, "l2" }, + { "l5", QCOM_SMD_RPM_LDOA, 5, &mp5496_ldoa2, "l5" }, {} }; -- 2.34.1

1 year, 10 months

4
4
0 0

stable-rc/queue/6.1 baseline: 109 runs, 3 regressions (v6.1.68-106-ge1524ddfd1363)

by kernelci.org bot

stable-rc/queue/6.1 baseline: 109 runs, 3 regressions (v6.1.68-106-ge1524ddfd1363) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions -------------------+-------+---------------+----------+-----------+------------ r8a77960-ulcb | arm64 | lab-collabora | gcc-10 | defconfig | 1 sun50i-h6-pine-h64 | arm64 | lab-clabbe | gcc-10 | defconfig | 1 sun50i-h6-pine-h64 | arm64 | lab-collabora | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F6.1/kernel/v6.1.68-1… Test: baseline Tree: stable-rc Branch: queue/6.1 Describe: v6.1.68-106-ge1524ddfd1363 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: e1524ddfd136335ae3100dc3c8df219da10f6d44 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions -------------------+-------+---------------+----------+-----------+------------ r8a77960-ulcb | arm64 | lab-collabora | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/65805bb906ab90788fe13594 Results: 4 PASS, 2 FAIL, 1 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-6.1/v6.1.68-106-ge1524ddfd136… HTML log: https://storage.kernelci.org//stable-rc/queue-6.1/v6.1.68-106-ge1524ddfd136… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/65805bb906ab90788fe13599 failing since 25 days (last pass: v6.1.31-26-gef50524405c2, first fail: v6.1.63-176-gecc0fed1ffa4) 2023-12-18T14:55:38.003286 / # # 2023-12-18T14:55:38.105428 export SHELL=/bin/sh 2023-12-18T14:55:38.106132 # 2023-12-18T14:55:38.207525 / # export SHELL=/bin/sh. /lava-12303951/environment 2023-12-18T14:55:38.208235 2023-12-18T14:55:38.309830 / # . /lava-12303951/environment/lava-12303951/bin/lava-test-runner /lava-12303951/1 2023-12-18T14:55:38.310768 2023-12-18T14:55:38.327838 / # /lava-12303951/bin/lava-test-runner /lava-12303951/1 2023-12-18T14:55:38.376449 + export 'TESTRUN_ID=1_bootrr' 2023-12-18T14:55:38.376949 + cd /lav<8>[ 19.115576] <LAVA_SIGNAL_STARTRUN 1_bootrr 12303951_1.5.2.4.5> ... (28 line(s) more) platform | arch | lab | compiler | defconfig | regressions -------------------+-------+---------------+----------+-----------+------------ sun50i-h6-pine-h64 | arm64 | lab-clabbe | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/65805ba3fa15b47c3ce1348d Results: 5 PASS, 1 FAIL, 1 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-6.1/v6.1.68-106-ge1524ddfd136… HTML log: https://storage.kernelci.org//stable-rc/queue-6.1/v6.1.68-106-ge1524ddfd136… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/65805ba3fa15b47c3ce13492 failing since 25 days (last pass: v6.1.22-372-g971903477e72, first fail: v6.1.63-176-gecc0fed1ffa4) 2023-12-18T14:47:45.827145 <8>[ 18.098414] <LAVA_SIGNAL_ENDRUN 0_dmesg 448727_1.5.2.4.1> 2023-12-18T14:47:45.932100 / # # 2023-12-18T14:47:46.033845 export SHELL=/bin/sh 2023-12-18T14:47:46.034459 # 2023-12-18T14:47:46.135494 / # export SHELL=/bin/sh. /lava-448727/environment 2023-12-18T14:47:46.136132 2023-12-18T14:47:46.237143 / # . /lava-448727/environment/lava-448727/bin/lava-test-runner /lava-448727/1 2023-12-18T14:47:46.238128 2023-12-18T14:47:46.242310 / # /lava-448727/bin/lava-test-runner /lava-448727/1 2023-12-18T14:47:46.321370 + export 'TESTRUN_ID=1_bootrr' ... (12 line(s) more) platform | arch | lab | compiler | defconfig | regressions -------------------+-------+---------------+----------+-----------+------------ sun50i-h6-pine-h64 | arm64 | lab-collabora | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/65805bba1a4e0bdcaae13475 Results: 5 PASS, 1 FAIL, 1 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-6.1/v6.1.68-106-ge1524ddfd136… HTML log: https://storage.kernelci.org//stable-rc/queue-6.1/v6.1.68-106-ge1524ddfd136… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/65805bba1a4e0bdcaae1347a failing since 25 days (last pass: v6.1.22-372-g971903477e72, first fail: v6.1.63-176-gecc0fed1ffa4) 2023-12-18T14:55:51.454715 / # # 2023-12-18T14:55:51.556773 export SHELL=/bin/sh 2023-12-18T14:55:51.557459 # 2023-12-18T14:55:51.658679 / # export SHELL=/bin/sh. /lava-12303962/environment 2023-12-18T14:55:51.659317 2023-12-18T14:55:51.760500 / # . /lava-12303962/environment/lava-12303962/bin/lava-test-runner /lava-12303962/1 2023-12-18T14:55:51.761032 2023-12-18T14:55:51.762841 / # /lava-12303962/bin/lava-test-runner /lava-12303962/1 2023-12-18T14:55:51.844003 + export 'TESTRUN_ID=1_bootrr' 2023-12-18T14:55:51.844536 + cd /lava-1230396<8>[ 19.222591] <LAVA_SIGNAL_STARTRUN 1_bootrr 12303962_1.5.2.4.5> ... (11 line(s) more)

1 year, 10 months

1
0
0 0

stable-rc/queue/4.19 baseline: 91 runs, 19 regressions (v4.19.302-36-ge049e5b8ef404)

by kernelci.org bot

stable-rc/queue/4.19 baseline: 91 runs, 19 regressions (v4.19.302-36-ge049e5b8ef404) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ at91sam9g20ek | arm | lab-broonie | gcc-10 | multi_v5_defconfig | 1 qemu_arm64-virt-gicv2 | arm64 | lab-broonie | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv2 | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv2 | arm64 | lab-collabora | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv2 | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv2-uefi | arm64 | lab-broonie | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv2-uefi | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv2-uefi | arm64 | lab-collabora | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv2-uefi | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv3 | arm64 | lab-broonie | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv3 | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv3 | arm64 | lab-collabora | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv3 | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv3-uefi | arm64 | lab-broonie | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv3-uefi | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv3-uefi | arm64 | lab-collabora | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv3-uefi | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 rk3399-gru-kevin | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 2 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F4.19/kernel/v4.19.30… Test: baseline Tree: stable-rc Branch: queue/4.19 Describe: v4.19.302-36-ge049e5b8ef404 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: e049e5b8ef404a5d70e76a7de06375177a7c57ea Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ at91sam9g20ek | arm | lab-broonie | gcc-10 | multi_v5_defconfig | 1 Details: https://kernelci.org/test/plan/id/6580728d9b88359652e134ce Results: 42 PASS, 9 FAIL, 1 SKIP Full config: multi_v5_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/6580728d9b88359652e13500 failing since 7 days (last pass: v4.19.301-37-g7937796e4223d, first fail: v4.19.301-40-g06ec8b55a272a) 2023-12-18T16:25:09.647216 + set +x 2023-12-18T16:25:09.647730 <8><LAVA_SIGNAL_ENDRUN 0_dmesg 369063_1.5.2.4.1> 2023-12-18T16:25:09.760807 / # # 2023-12-18T16:25:09.863831 export SHELL=/bin/sh 2023-12-18T16:25:09.864614 # 2023-12-18T16:25:09.966524 / # export SHELL=/bin/sh. /lava-369063/environment 2023-12-18T16:25:09.967375 2023-12-18T16:25:10.069382 / # . /lava-369063/environment/lava-369063/bin/lava-test-runner /lava-369063/1 2023-12-18T16:25:10.070673 2023-12-18T16:25:10.074344 / # /lava-369063/bin/lava-test-runner /lava-369063/1 ... (12 line(s) more) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2 | arm64 | lab-broonie | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/65805fa7efdb818972e134e2 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/65805fa7efdb818972e134e3 failing since 510 days (last pass: v4.19.230-58-gbd840138c177, first fail: v4.19.253-43-g91137b502cfbd) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2 | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/65806123308e9effd9e13481 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/65806123308e9effd9e13482 failing since 510 days (last pass: v4.19.230-58-gbd840138c177, first fail: v4.19.253-43-g91137b502cfbd) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2 | arm64 | lab-collabora | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/65805e28091c855fece13478 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/65805e28091c855fece13479 failing since 510 days (last pass: v4.19.230-58-gbd840138c177, first fail: v4.19.253-43-g91137b502cfbd) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2 | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/65805ec5e09c4a685ee13493 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/65805ec5e09c4a685ee13494 failing since 510 days (last pass: v4.19.230-58-gbd840138c177, first fail: v4.19.253-43-g91137b502cfbd) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2-uefi | arm64 | lab-broonie | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/65805fbb8d3497a759e13477 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/65805fbb8d3497a759e13478 failing since 510 days (last pass: v4.19.230-58-gbd840138c177, first fail: v4.19.253-43-g91137b502cfbd) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2-uefi | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/6580603389faeb27c1e134cb Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/6580603389faeb27c1e134cc failing since 510 days (last pass: v4.19.230-58-gbd840138c177, first fail: v4.19.253-43-g91137b502cfbd) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2-uefi | arm64 | lab-collabora | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/65805e255d07f7f72fe13496 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/65805e255d07f7f72fe13497 failing since 510 days (last pass: v4.19.230-58-gbd840138c177, first fail: v4.19.253-43-g91137b502cfbd) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2-uefi | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/65805e61bd8446c9c7e13482 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/65805e61bd8446c9c7e13483 failing since 510 days (last pass: v4.19.230-58-gbd840138c177, first fail: v4.19.253-43-g91137b502cfbd) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3 | arm64 | lab-broonie | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/65805ecb128e6f1ff9e1347b Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/65805ecb128e6f1ff9e1347c failing since 510 days (last pass: v4.19.230-58-gbd840138c177, first fail: v4.19.253-43-g91137b502cfbd) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3 | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/65806047f68afeb303e134d7 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/65806047f68afeb303e134d8 failing since 510 days (last pass: v4.19.230-58-gbd840138c177, first fail: v4.19.253-43-g91137b502cfbd) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3 | arm64 | lab-collabora | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/65805e2806bcd8fd05e1347c Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/65805e2806bcd8fd05e1347d failing since 510 days (last pass: v4.19.230-58-gbd840138c177, first fail: v4.19.253-43-g91137b502cfbd) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3 | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/65805e62d3660e70f9e13488 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/65805e62d3660e70f9e13489 failing since 510 days (last pass: v4.19.230-58-gbd840138c177, first fail: v4.19.253-43-g91137b502cfbd) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3-uefi | arm64 | lab-broonie | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/65805fc789faeb27c1e13476 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/65805fc789faeb27c1e13477 failing since 510 days (last pass: v4.19.230-58-gbd840138c177, first fail: v4.19.253-43-g91137b502cfbd) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3-uefi | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/6580610f308e9effd9e13477 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/6580610f308e9effd9e13478 failing since 510 days (last pass: v4.19.230-58-gbd840138c177, first fail: v4.19.253-43-g91137b502cfbd) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3-uefi | arm64 | lab-collabora | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/65805e294884dfb35ee13475 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/65805e294884dfb35ee13476 failing since 510 days (last pass: v4.19.230-58-gbd840138c177, first fail: v4.19.253-43-g91137b502cfbd) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3-uefi | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/65805e638e2349fcdee13495 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/65805e638e2349fcdee13496 failing since 510 days (last pass: v4.19.230-58-gbd840138c177, first fail: v4.19.253-43-g91137b502cfbd) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+---------------+----------+----------------------------+------------ rk3399-gru-kevin | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 2 Details: https://kernelci.org/test/plan/id/65805e4d17d4e366dae13481 Results: 77 PASS, 5 FAIL, 1 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.302-36-ge049e5b8ef… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.rockchip-usb2phy1-probed: https://kernelci.org/test/case/id/65805e4d17d4e366dae13487 failing since 279 days (last pass: v4.19.275-252-gcb3c41fc75db9, first fail: v4.19.276-34-ge787294ce440f) 2023-12-18T14:59:36.515487 /lava-12304140/1/../bin/lava-test-case 2023-12-18T14:59:36.524122 <8>[ 37.371536] <LAVA_SIGNAL_TESTCASE TEST_CASE_ID=rockchip-usb2phy1-probed RESULT=fail> * baseline.bootrr.rockchip-usb2phy0-probed: https://kernelci.org/test/case/id/65805e4d17d4e366dae13488 failing since 279 days (last pass: v4.19.275-252-gcb3c41fc75db9, first fail: v4.19.276-34-ge787294ce440f) 2023-12-18T14:59:35.493834 /lava-12304140/1/../bin/lava-test-case 2023-12-18T14:59:35.502127 <8>[ 36.349582] <LAVA_SIGNAL_TESTCASE TEST_CASE_ID=rockchip-usb2phy0-probed RESULT=fail>

1 year, 10 months

1
0
0 0

FAILED: patch "[PATCH] USB: gadget: core: adjust uevent timing on gadget unbind" failed to apply to 5.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 73ea73affe8622bdf292de898da869d441da6a9d # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2023121132-these-deviation-5ab6@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: 73ea73affe86 ("USB: gadget: core: adjust uevent timing on gadget unbind") 50966da807c8 ("usb: gadget: udc: core: Offload usb_udc_vbus_handler processing") 1016fc0c096c ("USB: gadget: Fix obscure lockdep violation for udc_mutex") f9d76d15072c ("USB: gadget: Add ID numbers to gadget names") fc274c1e9973 ("USB: gadget: Add a new bus for gadgets") 6ebb449f9f25 ("USB: gadget: Register udc before gadget") af1969a2d734 ("USB: gadget: Rename usb_gadget_probe_driver()") 710f5d627a98 ("Merge tag 'usb-5.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 73ea73affe8622bdf292de898da869d441da6a9d Mon Sep 17 00:00:00 2001 From: Roy Luo <royluo(a)google.com> Date: Tue, 28 Nov 2023 22:17:56 +0000 Subject: [PATCH] USB: gadget: core: adjust uevent timing on gadget unbind The KOBJ_CHANGE uevent is sent before gadget unbind is actually executed, resulting in inaccurate uevent emitted at incorrect timing (the uevent would have USB_UDC_DRIVER variable set while it would soon be removed). Move the KOBJ_CHANGE uevent to the end of the unbind function so that uevent is sent only after the change has been made. Fixes: 2ccea03a8f7e ("usb: gadget: introduce UDC Class") Cc: stable(a)vger.kernel.org Signed-off-by: Roy Luo <royluo(a)google.com> Link: https://lore.kernel.org/r/20231128221756.2591158-1-royluo@google.com Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index ded9531f141b..d59f94464b87 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -1646,8 +1646,6 @@ static void gadget_unbind_driver(struct device *dev) dev_dbg(&udc->dev, "unbinding gadget driver [%s]\n", driver->function); - kobject_uevent(&udc->dev.kobj, KOBJ_CHANGE); - udc->allow_connect = false; cancel_work_sync(&udc->vbus_work); mutex_lock(&udc->connect_lock); @@ -1667,6 +1665,8 @@ static void gadget_unbind_driver(struct device *dev) driver->is_bound = false; udc->driver = NULL; mutex_unlock(&udc_lock); + + kobject_uevent(&udc->dev.kobj, KOBJ_CHANGE); } /* ------------------------------------------------------------------------- */

1 year, 10 months

3
3
0 0

stable-rc/queue/5.10 baseline: 48 runs, 1 regressions (v5.10.204-62-gd1ec28a08d6ea)

by kernelci.org bot

stable-rc/queue/5.10 baseline: 48 runs, 1 regressions (v5.10.204-62-gd1ec28a08d6ea) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions -----------------+------+-------------+----------+---------------------+------------ beaglebone-black | arm | lab-broonie | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F5.10/kernel/v5.10.20… Test: baseline Tree: stable-rc Branch: queue/5.10 Describe: v5.10.204-62-gd1ec28a08d6ea URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: d1ec28a08d6ea016241f2ce60f801546b75de141 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions -----------------+------+-------------+----------+---------------------+------------ beaglebone-black | arm | lab-broonie | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/plan/id/65805f665acfeff476e13499 Results: 51 PASS, 4 FAIL, 1 SKIP Full config: omap2plus_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.10/v5.10.204-62-gd1ec28a08d… HTML log: https://storage.kernelci.org//stable-rc/queue-5.10/v5.10.204-62-gd1ec28a08d… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/65805f665acfeff476e134cf failing since 307 days (last pass: v5.10.167-127-g921934d621e4, first fail: v5.10.167-139-gf9519a5a1701) 2023-12-18T15:03:49.537173 + set +x 2023-12-18T15:03:49.541115 <8>[ 19.054490] <LAVA_SIGNAL_ENDRUN 0_dmesg 368846_1.5.2.4.1> 2023-12-18T15:03:49.649928 / # # 2023-12-18T15:03:49.751604 export SHELL=/bin/sh 2023-12-18T15:03:49.752008 # 2023-12-18T15:03:49.853240 / # export SHELL=/bin/sh. /lava-368846/environment 2023-12-18T15:03:49.853652 2023-12-18T15:03:49.954976 / # . /lava-368846/environment/lava-368846/bin/lava-test-runner /lava-368846/1 2023-12-18T15:03:49.955586 2023-12-18T15:03:49.959865 / # /lava-368846/bin/lava-test-runner /lava-368846/1 ... (12 line(s) more)

1 year, 10 months

1
0
0 0

FAILED: patch "[PATCH] mm/damon/core: make damon_start() waits until kdamond_fn()" failed to apply to 6.6-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x 6376a824595607e99d032a39ba3394988b4fce96 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2023121843-pension-tactile-868b@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^.. Possible dependencies: 6376a8245956 ("mm/damon/core: make damon_start() waits until kdamond_fn() starts") 4472edf63d66 ("mm/damon/core: use number of passed access sampling as a timer") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 6376a824595607e99d032a39ba3394988b4fce96 Mon Sep 17 00:00:00 2001 From: SeongJae Park <sj(a)kernel.org> Date: Fri, 8 Dec 2023 17:50:18 +0000 Subject: [PATCH] mm/damon/core: make damon_start() waits until kdamond_fn() starts The cleanup tasks of kdamond threads including reset of corresponding DAMON context's ->kdamond field and decrease of global nr_running_ctxs counter is supposed to be executed by kdamond_fn(). However, commit 0f91d13366a4 ("mm/damon: simplify stop mechanism") made neither damon_start() nor damon_stop() ensure the corresponding kdamond has started the execution of kdamond_fn(). As a result, the cleanup can be skipped if damon_stop() is called fast enough after the previous damon_start(). Especially the skipped reset of ->kdamond could cause a use-after-free. Fix it by waiting for start of kdamond_fn() execution from damon_start(). Link: https://lkml.kernel.org/r/20231208175018.63880-1-sj@kernel.org Fixes: 0f91d13366a4 ("mm/damon: simplify stop mechanism") Signed-off-by: SeongJae Park <sj(a)kernel.org> Reported-by: Jakub Acs <acsjakub(a)amazon.de> Cc: Changbin Du <changbin.du(a)intel.com> Cc: Jakub Acs <acsjakub(a)amazon.de> Cc: <stable(a)vger.kernel.org> # 5.15.x Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> diff --git a/include/linux/damon.h b/include/linux/damon.h index ab2f17d9926b..e00ddf1ed39c 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -559,6 +559,8 @@ struct damon_ctx { * update */ unsigned long next_ops_update_sis; + /* for waiting until the execution of the kdamond_fn is started */ + struct completion kdamond_started; /* public: */ struct task_struct *kdamond; diff --git a/mm/damon/core.c b/mm/damon/core.c index ce1562783e7e..3a05e71509b9 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -445,6 +445,8 @@ struct damon_ctx *damon_new_ctx(void) if (!ctx) return NULL; + init_completion(&ctx->kdamond_started); + ctx->attrs.sample_interval = 5 * 1000; ctx->attrs.aggr_interval = 100 * 1000; ctx->attrs.ops_update_interval = 60 * 1000 * 1000; @@ -668,11 +670,14 @@ static int __damon_start(struct damon_ctx *ctx) mutex_lock(&ctx->kdamond_lock); if (!ctx->kdamond) { err = 0; + reinit_completion(&ctx->kdamond_started); ctx->kdamond = kthread_run(kdamond_fn, ctx, "kdamond.%d", nr_running_ctxs); if (IS_ERR(ctx->kdamond)) { err = PTR_ERR(ctx->kdamond); ctx->kdamond = NULL; + } else { + wait_for_completion(&ctx->kdamond_started); } } mutex_unlock(&ctx->kdamond_lock); @@ -1433,6 +1438,7 @@ static int kdamond_fn(void *data) pr_debug("kdamond (%d) starts\n", current->pid); + complete(&ctx->kdamond_started); kdamond_init_intervals_sis(ctx); if (ctx->ops.init)

1 year, 10 months

2
1
0 0

FAILED: patch "[PATCH] mm/damon/core: make damon_start() waits until kdamond_fn()" failed to apply to 6.1-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x 6376a824595607e99d032a39ba3394988b4fce96 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2023121849-ambulance-violate-e5b2@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^.. Possible dependencies: 6376a8245956 ("mm/damon/core: make damon_start() waits until kdamond_fn() starts") 4472edf63d66 ("mm/damon/core: use number of passed access sampling as a timer") 2f5bef5a590b ("mm/damon/core: update monitoring results for new monitoring attributes") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 6376a824595607e99d032a39ba3394988b4fce96 Mon Sep 17 00:00:00 2001 From: SeongJae Park <sj(a)kernel.org> Date: Fri, 8 Dec 2023 17:50:18 +0000 Subject: [PATCH] mm/damon/core: make damon_start() waits until kdamond_fn() starts The cleanup tasks of kdamond threads including reset of corresponding DAMON context's ->kdamond field and decrease of global nr_running_ctxs counter is supposed to be executed by kdamond_fn(). However, commit 0f91d13366a4 ("mm/damon: simplify stop mechanism") made neither damon_start() nor damon_stop() ensure the corresponding kdamond has started the execution of kdamond_fn(). As a result, the cleanup can be skipped if damon_stop() is called fast enough after the previous damon_start(). Especially the skipped reset of ->kdamond could cause a use-after-free. Fix it by waiting for start of kdamond_fn() execution from damon_start(). Link: https://lkml.kernel.org/r/20231208175018.63880-1-sj@kernel.org Fixes: 0f91d13366a4 ("mm/damon: simplify stop mechanism") Signed-off-by: SeongJae Park <sj(a)kernel.org> Reported-by: Jakub Acs <acsjakub(a)amazon.de> Cc: Changbin Du <changbin.du(a)intel.com> Cc: Jakub Acs <acsjakub(a)amazon.de> Cc: <stable(a)vger.kernel.org> # 5.15.x Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> diff --git a/include/linux/damon.h b/include/linux/damon.h index ab2f17d9926b..e00ddf1ed39c 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -559,6 +559,8 @@ struct damon_ctx { * update */ unsigned long next_ops_update_sis; + /* for waiting until the execution of the kdamond_fn is started */ + struct completion kdamond_started; /* public: */ struct task_struct *kdamond; diff --git a/mm/damon/core.c b/mm/damon/core.c index ce1562783e7e..3a05e71509b9 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -445,6 +445,8 @@ struct damon_ctx *damon_new_ctx(void) if (!ctx) return NULL; + init_completion(&ctx->kdamond_started); + ctx->attrs.sample_interval = 5 * 1000; ctx->attrs.aggr_interval = 100 * 1000; ctx->attrs.ops_update_interval = 60 * 1000 * 1000; @@ -668,11 +670,14 @@ static int __damon_start(struct damon_ctx *ctx) mutex_lock(&ctx->kdamond_lock); if (!ctx->kdamond) { err = 0; + reinit_completion(&ctx->kdamond_started); ctx->kdamond = kthread_run(kdamond_fn, ctx, "kdamond.%d", nr_running_ctxs); if (IS_ERR(ctx->kdamond)) { err = PTR_ERR(ctx->kdamond); ctx->kdamond = NULL; + } else { + wait_for_completion(&ctx->kdamond_started); } } mutex_unlock(&ctx->kdamond_lock); @@ -1433,6 +1438,7 @@ static int kdamond_fn(void *data) pr_debug("kdamond (%d) starts\n", current->pid); + complete(&ctx->kdamond_started); kdamond_init_intervals_sis(ctx); if (ctx->ops.init)

1 year, 10 months

2
1
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror December 2023