November 2023 - Linux-stable-mirror

[PATCH v2] usb: dwc3: set the dma max_seg_size

by Ricardo Ribalda

Allow devices to have dma operations beyond 4K, and avoid warnings such as: DMA-API: dwc3 a600000.usb: mapping sg segment longer than device claims to support [len=86016] [max=65536] Cc: stable(a)vger.kernel.org Fixes: 72246da40f37 ("usb: Introduce DesignWare USB3 DRD Driver") Reported-by: Zubin Mithra <zsm(a)chromium.org> Signed-off-by: Ricardo Ribalda <ribalda(a)chromium.org> --- Found while running yavta -f YUYV -s 1280x720 -c /dev/video0 with: CONFIG_DMA_API_DEBUG=y --- Changes in v2: - Add stable tag - Link to v1: https://lore.kernel.org/r/20231026-dwc3-v1-1-643c74771599@chromium.org --- drivers/usb/dwc3/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 343d2570189f..65f73dd8ef47 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -1918,6 +1918,8 @@ static int dwc3_probe(struct platform_device *pdev) pm_runtime_put(dev); + dma_set_max_seg_size(dev, UINT_MAX); + return 0; err_exit_debugfs: --- base-commit: 611da07b89fdd53f140d7b33013f255bf0ed8f34 change-id: 20231026-dwc3-fac74fcb3b2a Best regards, -- Ricardo Ribalda <ribalda(a)chromium.org>

1 year, 1 month

3
5
0 0

[PATCH 1/3] USB: dwc3: qcom: fix resource leaks on probe deferral

by Johan Hovold

The driver needs to deregister and free the newly allocated dwc3 core platform device on ACPI probe errors (e.g. probe deferral) and on driver unbind but instead it leaked those resources while erroneously dropping a reference to the parent platform device which is still in use. For OF probing the driver takes a reference to the dwc3 core platform device which has also always been leaked. Fix the broken ACPI tear down and make sure to drop the dwc3 core reference for both OF and ACPI. Fixes: 8fd95da2cfb5 ("usb: dwc3: qcom: Release the correct resources in dwc3_qcom_remove()") Fixes: 2bc02355f8ba ("usb: dwc3: qcom: Add support for booting with ACPI") Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver") Cc: stable(a)vger.kernel.org # 4.18 Cc: Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> Cc: Lee Jones <lee(a)kernel.org> Signed-off-by: Johan Hovold <johan+linaro(a)kernel.org> --- drivers/usb/dwc3/dwc3-qcom.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index 3de43df6bbe8..00c3021b43ce 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -758,6 +758,7 @@ static int dwc3_qcom_of_register_core(struct platform_device *pdev) if (!qcom->dwc3) { ret = -ENODEV; dev_err(dev, "failed to get dwc3 platform device\n"); + of_platform_depopulate(dev); } node_put: @@ -899,7 +900,7 @@ static int dwc3_qcom_probe(struct platform_device *pdev) if (ret) { dev_err(dev, "failed to register DWC3 Core, err=%d\n", ret); - goto depopulate; + goto clk_disable; } ret = dwc3_qcom_interconnect_init(qcom); @@ -934,7 +935,8 @@ static int dwc3_qcom_probe(struct platform_device *pdev) if (np) of_platform_depopulate(&pdev->dev); else - platform_device_put(pdev); + platform_device_del(qcom->dwc3); + platform_device_put(qcom->dwc3); clk_disable: for (i = qcom->num_clocks - 1; i >= 0; i--) { clk_disable_unprepare(qcom->clks[i]); @@ -957,7 +959,8 @@ static void dwc3_qcom_remove(struct platform_device *pdev) if (np) of_platform_depopulate(&pdev->dev); else - platform_device_put(pdev); + platform_device_del(qcom->dwc3); + platform_device_put(qcom->dwc3); for (i = qcom->num_clocks - 1; i >= 0; i--) { clk_disable_unprepare(qcom->clks[i]); -- 2.41.0

1 year, 1 month

2
1
0 0

[PATCH 4.19 00/88] 4.19.299-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.299 release. There are 88 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Fri, 17 Nov 2023 19:14:03 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.299-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.299-rc1 Filipe Manana <fdmanana(a)suse.com> btrfs: use u64 for buffer sizes in the tree search ioctls Dominique Martinet <dominique.martinet(a)atmark-techno.com> Revert "mmc: core: Capture correct oemid-bits for eMMC cards" Arnd Bergmann <arnd(a)arndb.de> fbdev: fsl-diu-fb: mark wr_reg_wa() static Dan Carpenter <dan.carpenter(a)linaro.org> fbdev: imsttfb: fix a resource leak in probe Helge Deller <deller(a)gmx.de> fbdev: imsttfb: Fix error path of imsttfb_probe() Maciej Żenczykowski <zenczykowski(a)gmail.com> netfilter: xt_recent: fix (increase) ipv6 literal buffer length Heiner Kallweit <hkallweit1(a)gmail.com> r8169: respect userspace disabling IFF_MULTICAST George Shuklin <george.shuklin(a)gmail.com> tg3: power down device only on SYSTEM_POWER_OFF D. Wythe <alibuda(a)linux.alibaba.com> net/smc: fix dangling sock under state SMC_APPFINCLOSEWAIT Karsten Graul <kgraul(a)linux.ibm.com> net/smc: wait for pending work before clcsock release_sock Ursula Braun <ubraun(a)linux.ibm.com> net/smc: postpone release of clcsock Patrick Thompson <ptf(a)google.com> net: r8169: Disable multicast filter for RTL8168H and RTL8107E Heiner Kallweit <hkallweit1(a)gmail.com> r8169: improve rtl_set_rx_mode Kuniyuki Iwashima <kuniyu(a)amazon.com> dccp/tcp: Call security_inet_conn_request() after setting IPv6 addresses. Kuniyuki Iwashima <kuniyu(a)amazon.com> dccp: Call security_inet_conn_request() after setting IPv4 addresses. Shigeru Yoshida <syoshida(a)redhat.com> tipc: Change nla_policy for bearer-related names to NLA_NUL_STRING Willem de Bruijn <willemb(a)google.com> llc: verify mac len before reading mac header Dan Carpenter <dan.carpenter(a)linaro.org> Input: synaptics-rmi4 - fix use after free in rmi_unregister_function() Florian Fainelli <florian.fainelli(a)broadcom.com> pwm: brcmstb: Utilize appropriate clock APIs in suspend/resume Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> pwm: sti: Reduce number of allocations and drop usage of chip_data Thierry Reding <thierry.reding(a)gmail.com> pwm: sti: Avoid conditional gotos Hans Verkuil <hverkuil-cisco(a)xs4all.nl> media: dvb-usb-v2: af9035: fix missing unlock Katya Orlova <e.orlova(a)ispras.ru> media: s3c-camif: Avoid inappropriate kfree() Zheng Wang <zyytlz.wz(a)163.com> media: bttv: fix use after free error due to btv->timeout timer Yang Yingliang <yangyingliang(a)huawei.com> pcmcia: ds: fix possible name leak in error path in pcmcia_device_add() Yang Yingliang <yangyingliang(a)huawei.com> pcmcia: ds: fix refcount leak in pcmcia_device_add() Yang Yingliang <yangyingliang(a)huawei.com> pcmcia: cs: fix possible hung task and memory leak pccardd() Chao Yu <chao(a)kernel.org> f2fs: fix to initialize map.m_pblk in f2fs_precache_extents() Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> dmaengine: pxa_dma: Remove an erroneous BUG_ON() in pxad_free_desc() Jonas Blixt <jonas.blixt(a)actia.se> USB: usbip: fix stub_dev hub disconnect Matti Vaittinen <mazziesaccount(a)gmail.com> tools: iio: iio_generic_buffer ensure alignment Chenyuan Mi <michenyuan(a)huawei.com> tools: iio: iio_generic_buffer: Fix some integer type and calculation Alexandru Ardelean <alexandru.ardelean(a)analog.com> tools: iio: privatize globals and functions in iio_generic_buffer.c file Jinjie Ruan <ruanjinjie(a)huawei.com> misc: st_core: Do not call kfree_skb() under spin_lock_irqsave() Dan Carpenter <dan.carpenter(a)linaro.org> dmaengine: ti: edma: handle irq_of_parse_and_map() errors Jia-Ju Bai <baijiaju(a)buaa.edu.cn> usb: dwc2: fix possible NULL pointer dereference caused by driver concurrency Yi Yang <yiyang13(a)huawei.com> tty: tty_jobctrl: fix pid memleak in disassociate_ctty() Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> leds: trigger: ledtrig-cpu:: Fix 'output may be truncated' issue for 'cpu' Pavel Machek <pavel(a)ucw.cz> ledtrig-cpu: Limit to 8 CPUs Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> leds: pwm: Don't disable the PWM when the LED should be off Uwe Kleine-König <uwe(a)kleine-koenig.org> leds: pwm: convert to atomic PWM API Uwe Kleine-König <uwe(a)kleine-koenig.org> leds: pwm: simplify if condition Dinghao Liu <dinghao.liu(a)zju.edu.cn> mfd: dln2: Fix double put in dln2_probe Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> ASoC: ams-delta.c: use component after check Cezary Rojewski <cezary.rojewski(a)intel.com> ASoC: Intel: Skylake: Fix mem leak when parsing UUIDs fails Geert Uytterhoeven <geert+renesas(a)glider.be> sh: bios: Revive earlyprintk support Leon Romanovsky <leonro(a)nvidia.com> RDMA/hfi1: Workaround truncation compilation error Gou Hao <gouhao(a)uniontech.com> ext4: move 'ix' sanity check to corrent position Kursad Oney <kursad.oney(a)broadcom.com> ARM: 9321/1: memset: cast the constant byte to unsigned char Danny Kaehn <danny.kaehn(a)plexus.com> hid: cp2112: Fix duplicate workqueue initialization Linus Walleij <linus.walleij(a)linaro.org> HID: cp2112: Use irqchip template Tomas Glozar <tglozar(a)redhat.com> nd_btt: Make BTT lanes preemptible Thomas Gleixner <tglx(a)linutronix.de> sched/rt: Provide migrate_disable/enable() inlines Jonas Gorski <jonas.gorski(a)gmail.com> hwrng: geode - fix accessing registers Sudeep Holla <sudeep.holla(a)arm.com> clk: scmi: Free scmi_clk allocated when the clocks with invalid info are skipped Dhruva Gole <d-gole(a)ti.com> firmware: ti_sci: Mark driver as non removable Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> ARM: dts: qcom: mdm9615: populate vsdcc fixed regulator Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> drm/rockchip: cdn-dp: Fix some error handling paths in cdn_dp_probe() Konstantin Meskhidze <konstantin.meskhidze(a)huawei.com> drm/radeon: possible buffer overflow Jonas Karlman <jonas(a)kwiboo.se> drm/rockchip: vop: Fix reset of state in duplicate state crtc funcs Zhang Rui <rui.zhang(a)intel.com> hwmon: (coretemp) Fix potentially truncated sysfs attribute name Armin Wolf <W_Armin(a)gmx.de> platform/x86: wmi: Fix opening of char device Barnabás Pőcze <pobrn(a)protonmail.com> platform/x86: wmi: remove unnecessary initializations Armin Wolf <W_Armin(a)gmx.de> platform/x86: wmi: Fix probe failure when failing to register WMI devices Jiasheng Jiang <jiasheng(a)iscas.ac.cn> clk: mediatek: clk-mt2701: Add check for mtk_alloc_clk_data Jiasheng Jiang <jiasheng(a)iscas.ac.cn> clk: mediatek: clk-mt6797: Add check for mtk_alloc_clk_data Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> clk: npcm7xx: Fix incorrect kfree Dan Carpenter <dan.carpenter(a)linaro.org> clk: keystone: pll: fix a couple NULL vs IS_ERR() checks Devi Priya <quic_devipriy(a)quicinc.com> clk: qcom: clk-rcg2: Fix clock rate overflow for high parent frequencies Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> regmap: debugfs: Fix a erroneous check after snprintf() Eric Dumazet <edumazet(a)google.com> ipvlan: properly track tx_errors Eric Dumazet <edumazet(a)google.com> net: add DEV_STATS_READ() helper Eric Dumazet <edumazet(a)google.com> macsec: use DEV_STATS_INC() Clayton Yager <Clayton_Yager(a)selinc.com> macsec: Fix traffic counters/statistics Yan Zhai <yan(a)cloudflare.com> ipv6: avoid atomic fragment on GSO packets Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> ACPI: sysfs: Fix create_pnp_modalias() and create_of_modalias() Eric Dumazet <edumazet(a)google.com> chtls: fix tp->rcv_tstamp initialization Dan Carpenter <dan.carpenter(a)linaro.org> thermal: core: prevent potential string overflow Marc Kleine-Budde <mkl(a)pengutronix.de> can: dev: can_restart(): fix race condition between controller restart and netif_carrier_on() Marc Kleine-Budde <mkl(a)pengutronix.de> can: dev: can_restart(): don't crash kernel if carrier is OK Marc Kleine-Budde <mkl(a)pengutronix.de> can: dev: move driver related infrastructure into separate subdir Dmitry Antipov <dmantipov(a)yandex.ru> wifi: rtlwifi: fix EDCA limit set by BT coexistence Eric Dumazet <edumazet(a)google.com> tcp_metrics: do not create an entry from tcp_init_metrics() Eric Dumazet <edumazet(a)google.com> tcp_metrics: properly set tp->snd_ssthresh in tcp_init_metrics() Eric Dumazet <edumazet(a)google.com> tcp_metrics: add missing barriers on delete Andrii Staikov <andrii.staikov(a)intel.com> i40e: fix potential memory leaks in i40e_remove() Chen Yu <yu.c.chen(a)intel.com> genirq/matrix: Exclude managed interrupts in irq_matrix_allocated() Reuben Hawkins <reubenhwk(a)gmail.com> vfs: fix readahead(2) on block devices ------------- Diffstat: Makefile | 4 +- arch/arm/boot/dts/qcom-mdm9615.dtsi | 14 ++-- arch/arm/lib/memset.S | 1 + arch/sh/Kconfig.debug | 11 ++++ drivers/acpi/device_sysfs.c | 10 +-- drivers/base/regmap/regmap-debugfs.c | 2 +- drivers/char/hw_random/geode-rng.c | 6 +- drivers/clk/clk-npcm7xx.c | 2 +- drivers/clk/clk-scmi.c | 1 + drivers/clk/keystone/pll.c | 15 +++-- drivers/clk/mediatek/clk-mt2701.c | 8 +++ drivers/clk/mediatek/clk-mt6797.c | 6 ++ drivers/clk/qcom/clk-rcg2.c | 14 ++-- drivers/crypto/chelsio/chtls/chtls_cm.c | 2 +- drivers/dma/pxa_dma.c | 1 - drivers/dma/ti/edma.c | 4 +- drivers/firmware/ti_sci.c | 46 +------------ drivers/gpu/drm/radeon/evergreen.c | 7 +- drivers/gpu/drm/rockchip/cdn-dp-core.c | 15 ++++- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 +- drivers/hid/hid-cp2112.c | 23 +++---- drivers/hwmon/coretemp.c | 2 +- drivers/infiniband/hw/hfi1/efivar.c | 2 +- drivers/input/rmi4/rmi_bus.c | 2 +- drivers/leds/leds-pwm.c | 41 +++--------- drivers/leds/trigger/ledtrig-cpu.c | 17 +++-- drivers/media/pci/bt8xx/bttv-driver.c | 1 + drivers/media/platform/s3c-camif/camif-capture.c | 6 +- drivers/media/usb/dvb-usb-v2/af9035.c | 13 ++-- drivers/mfd/dln2.c | 1 - drivers/misc/ti-st/st_core.c | 7 +- drivers/mmc/core/mmc.c | 2 +- drivers/net/can/Makefile | 7 +- drivers/net/can/dev/Makefile | 7 ++ drivers/net/can/{ => dev}/dev.c | 10 +-- drivers/net/can/{ => dev}/rx-offload.c | 0 drivers/net/ethernet/broadcom/tg3.c | 3 +- drivers/net/ethernet/intel/i40e/i40e_main.c | 10 ++- drivers/net/ethernet/realtek/r8169_main.c | 56 ++++++++-------- drivers/net/ipvlan/ipvlan_core.c | 8 +-- drivers/net/ipvlan/ipvlan_main.c | 1 + drivers/net/macsec.c | 70 +++++++++++++++----- .../net/wireless/realtek/rtlwifi/rtl8188ee/dm.c | 2 +- .../wireless/realtek/rtlwifi/rtl8192c/dm_common.c | 2 +- .../net/wireless/realtek/rtlwifi/rtl8723ae/dm.c | 2 +- drivers/nvdimm/region_devs.c | 8 +-- drivers/pcmcia/cs.c | 1 + drivers/pcmcia/ds.c | 14 ++-- drivers/platform/x86/wmi.c | 50 ++++++--------- drivers/pwm/pwm-brcmstb.c | 4 +- drivers/pwm/pwm-sti.c | 75 ++++++++++------------ drivers/thermal/thermal_core.c | 6 +- drivers/tty/tty_jobctrl.c | 17 +++-- drivers/usb/dwc2/hcd.c | 2 +- drivers/usb/usbip/stub_dev.c | 9 ++- drivers/video/fbdev/fsl-diu-fb.c | 2 +- drivers/video/fbdev/imsttfb.c | 33 ++++++---- fs/btrfs/ioctl.c | 10 +-- fs/ext4/extents.c | 10 +-- fs/f2fs/file.c | 1 + include/linux/netdevice.h | 1 + include/linux/preempt.h | 30 +++++++++ kernel/irq/matrix.c | 6 +- mm/readahead.c | 3 +- net/dccp/ipv4.c | 6 +- net/dccp/ipv6.c | 6 +- net/ipv4/tcp_metrics.c | 15 ++--- net/ipv6/ip6_output.c | 8 ++- net/ipv6/syncookies.c | 7 +- net/llc/llc_input.c | 10 ++- net/llc/llc_s_ac.c | 3 + net/llc/llc_station.c | 3 + net/netfilter/xt_recent.c | 2 +- net/smc/af_smc.c | 43 +++++++------ net/smc/smc.h | 5 ++ net/smc/smc_cdc.c | 2 +- net/smc/smc_close.c | 26 +++++++- net/smc/smc_close.h | 1 + net/tipc/netlink.c | 4 +- sound/soc/intel/skylake/skl-sst-utils.c | 1 + sound/soc/omap/ams-delta.c | 4 +- tools/iio/iio_generic_buffer.c | 59 +++++++++++------ 82 files changed, 548 insertions(+), 406 deletions(-)

1 year, 1 month

4
91
0 0

[PATCH 4.14 00/45] 4.14.330-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.14.330 release. There are 45 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Fri, 17 Nov 2023 19:14:03 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.330-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.14.330-rc1 Filipe Manana <fdmanana(a)suse.com> btrfs: use u64 for buffer sizes in the tree search ioctls Dominique Martinet <dominique.martinet(a)atmark-techno.com> Revert "mmc: core: Capture correct oemid-bits for eMMC cards" Arnd Bergmann <arnd(a)arndb.de> fbdev: fsl-diu-fb: mark wr_reg_wa() static Maciej Żenczykowski <zenczykowski(a)gmail.com> netfilter: xt_recent: fix (increase) ipv6 literal buffer length George Shuklin <george.shuklin(a)gmail.com> tg3: power down device only on SYSTEM_POWER_OFF Kuniyuki Iwashima <kuniyu(a)amazon.com> dccp/tcp: Call security_inet_conn_request() after setting IPv6 addresses. Kuniyuki Iwashima <kuniyu(a)amazon.com> dccp: Call security_inet_conn_request() after setting IPv4 addresses. Shigeru Yoshida <syoshida(a)redhat.com> tipc: Change nla_policy for bearer-related names to NLA_NUL_STRING Willem de Bruijn <willemb(a)google.com> llc: verify mac len before reading mac header Florian Fainelli <florian.fainelli(a)broadcom.com> pwm: brcmstb: Utilize appropriate clock APIs in suspend/resume Hans Verkuil <hverkuil-cisco(a)xs4all.nl> media: dvb-usb-v2: af9035: fix missing unlock Katya Orlova <e.orlova(a)ispras.ru> media: s3c-camif: Avoid inappropriate kfree() Yang Yingliang <yangyingliang(a)huawei.com> pcmcia: ds: fix possible name leak in error path in pcmcia_device_add() Yang Yingliang <yangyingliang(a)huawei.com> pcmcia: ds: fix refcount leak in pcmcia_device_add() Yang Yingliang <yangyingliang(a)huawei.com> pcmcia: cs: fix possible hung task and memory leak pccardd() Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> dmaengine: pxa_dma: Remove an erroneous BUG_ON() in pxad_free_desc() Jonas Blixt <jonas.blixt(a)actia.se> USB: usbip: fix stub_dev hub disconnect Jinjie Ruan <ruanjinjie(a)huawei.com> misc: st_core: Do not call kfree_skb() under spin_lock_irqsave() Dan Carpenter <dan.carpenter(a)linaro.org> dmaengine: ti: edma: handle irq_of_parse_and_map() errors Jia-Ju Bai <baijiaju(a)buaa.edu.cn> usb: dwc2: fix possible NULL pointer dereference caused by driver concurrency Yi Yang <yiyang13(a)huawei.com> tty: tty_jobctrl: fix pid memleak in disassociate_ctty() Dinghao Liu <dinghao.liu(a)zju.edu.cn> mfd: dln2: Fix double put in dln2_probe Cezary Rojewski <cezary.rojewski(a)intel.com> ASoC: Intel: Skylake: Fix mem leak when parsing UUIDs fails Geert Uytterhoeven <geert+renesas(a)glider.be> sh: bios: Revive earlyprintk support Leon Romanovsky <leonro(a)nvidia.com> RDMA/hfi1: Workaround truncation compilation error Gou Hao <gouhao(a)uniontech.com> ext4: move 'ix' sanity check to corrent position Kursad Oney <kursad.oney(a)broadcom.com> ARM: 9321/1: memset: cast the constant byte to unsigned char Jonas Gorski <jonas.gorski(a)gmail.com> hwrng: geode - fix accessing registers Dhruva Gole <d-gole(a)ti.com> firmware: ti_sci: Mark driver as non removable Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> ARM: dts: qcom: mdm9615: populate vsdcc fixed regulator Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> drm/rockchip: cdn-dp: Fix some error handling paths in cdn_dp_probe() Konstantin Meskhidze <konstantin.meskhidze(a)huawei.com> drm/radeon: possible buffer overflow Jonas Karlman <jonas(a)kwiboo.se> drm/rockchip: vop: Fix reset of state in duplicate state crtc funcs Armin Wolf <W_Armin(a)gmx.de> platform/x86: wmi: Fix probe failure when failing to register WMI devices Jiasheng Jiang <jiasheng(a)iscas.ac.cn> clk: mediatek: clk-mt2701: Add check for mtk_alloc_clk_data Jiasheng Jiang <jiasheng(a)iscas.ac.cn> clk: mediatek: clk-mt6797: Add check for mtk_alloc_clk_data Dan Carpenter <dan.carpenter(a)linaro.org> clk: keystone: pll: fix a couple NULL vs IS_ERR() checks Devi Priya <quic_devipriy(a)quicinc.com> clk: qcom: clk-rcg2: Fix clock rate overflow for high parent frequencies Yan Zhai <yan(a)cloudflare.com> ipv6: avoid atomic fragment on GSO packets Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> ACPI: sysfs: Fix create_pnp_modalias() and create_of_modalias() Dan Carpenter <dan.carpenter(a)linaro.org> thermal: core: prevent potential string overflow Dmitry Antipov <dmantipov(a)yandex.ru> wifi: rtlwifi: fix EDCA limit set by BT coexistence Eric Dumazet <edumazet(a)google.com> tcp_metrics: do not create an entry from tcp_init_metrics() Eric Dumazet <edumazet(a)google.com> tcp_metrics: properly set tp->snd_ssthresh in tcp_init_metrics() Andrii Staikov <andrii.staikov(a)intel.com> i40e: fix potential memory leaks in i40e_remove() ------------- Diffstat: Makefile | 4 +- arch/arm/boot/dts/qcom-mdm9615.dtsi | 14 +++---- arch/arm/lib/memset.S | 1 + arch/sh/Kconfig.debug | 11 ++++++ drivers/acpi/device_sysfs.c | 10 +++-- drivers/char/hw_random/geode-rng.c | 6 ++- drivers/clk/keystone/pll.c | 15 ++++--- drivers/clk/mediatek/clk-mt2701.c | 8 ++++ drivers/clk/mediatek/clk-mt6797.c | 6 +++ drivers/clk/qcom/clk-rcg2.c | 14 ++----- drivers/dma/edma.c | 4 +- drivers/dma/pxa_dma.c | 1 - drivers/firmware/ti_sci.c | 46 +--------------------- drivers/gpu/drm/radeon/evergreen.c | 7 ++-- drivers/gpu/drm/rockchip/cdn-dp-core.c | 15 ++++++- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 +- drivers/infiniband/hw/hfi1/efivar.c | 2 +- drivers/media/platform/s3c-camif/camif-capture.c | 6 +-- drivers/media/usb/dvb-usb-v2/af9035.c | 13 ++++-- drivers/mfd/dln2.c | 1 - drivers/misc/ti-st/st_core.c | 7 ++-- drivers/mmc/core/mmc.c | 2 +- drivers/net/ethernet/broadcom/tg3.c | 3 +- drivers/net/ethernet/intel/i40e/i40e_main.c | 10 +++-- .../net/wireless/realtek/rtlwifi/rtl8188ee/dm.c | 2 +- .../wireless/realtek/rtlwifi/rtl8192c/dm_common.c | 2 +- .../net/wireless/realtek/rtlwifi/rtl8723ae/dm.c | 2 +- drivers/pcmcia/cs.c | 1 + drivers/pcmcia/ds.c | 14 ++++--- drivers/platform/x86/wmi.c | 16 ++++---- drivers/pwm/pwm-brcmstb.c | 4 +- drivers/thermal/thermal_core.c | 6 ++- drivers/tty/tty_jobctrl.c | 17 +++++--- drivers/usb/dwc2/hcd.c | 2 +- drivers/usb/usbip/stub_dev.c | 9 ++++- drivers/video/fbdev/fsl-diu-fb.c | 2 +- fs/btrfs/ioctl.c | 10 ++--- fs/ext4/extents.c | 10 ++--- net/dccp/ipv4.c | 6 +-- net/dccp/ipv6.c | 6 +-- net/ipv4/tcp_metrics.c | 11 +++--- net/ipv6/ip6_output.c | 8 +++- net/ipv6/syncookies.c | 7 ++-- net/llc/llc_input.c | 10 ++++- net/llc/llc_s_ac.c | 3 ++ net/llc/llc_station.c | 3 ++ net/netfilter/xt_recent.c | 2 +- net/tipc/netlink.c | 4 +- sound/soc/intel/skylake/skl-sst-utils.c | 1 + 49 files changed, 202 insertions(+), 165 deletions(-)

1 year, 1 month

5
49
0 0

[PATCH] usb: config: fix iteration issue in 'usb_get_bos_descriptor()'

by Niklas Neronin

The BOS descriptor defines a root descriptor and is the base descriptor for accessing a family of related descriptors. Function 'usb_get_bos_descriptor()' encounters an iteration issue when skipping the 'USB_DT_DEVICE_CAPABILITY' descriptor type. This results in the same descriptor being read repeatedly. To address this issue, a 'goto' statement is introduced to ensure that the pointer and the amount read is updated correctly. This ensures that the function iterates to the next descriptor instead of reading the same descriptor repeatedly. Cc: stable(a)vger.kernel.org Fixes: 3dd550a2d365 ("USB: usbcore: Fix slab-out-of-bounds bug during device reset") Signed-off-by: Niklas Neronin <niklas.neronin(a)linux.intel.com> --- drivers/usb/core/config.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c index b19e38d5fd10..7f8d33f92ddb 100644 --- a/drivers/usb/core/config.c +++ b/drivers/usb/core/config.c @@ -1047,7 +1047,7 @@ int usb_get_bos_descriptor(struct usb_device *dev) if (cap->bDescriptorType != USB_DT_DEVICE_CAPABILITY) { dev_notice(ddev, "descriptor type invalid, skip\n"); - continue; + goto skip_to_next_descriptor; } switch (cap_type) { @@ -1078,6 +1078,7 @@ int usb_get_bos_descriptor(struct usb_device *dev) break; } +skip_to_next_descriptor: total_len -= length; buffer += length; } -- 2.42.0

1 year, 1 month

3
2
0 0

+ mm-fix-oops-when-filemap_map_pmd-without-prealloc_pte.patch added to mm-hotfixes-unstable branch

by Andrew Morton

The patch titled Subject: mm: fix oops when filemap_map_pmd() without prealloc_pte has been added to the -mm mm-hotfixes-unstable branch. Its filename is mm-fix-oops-when-filemap_map_pmd-without-prealloc_pte.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patche… This patch will later appear in the mm-hotfixes-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Hugh Dickins <hughd(a)google.com> Subject: mm: fix oops when filemap_map_pmd() without prealloc_pte Date: Fri, 17 Nov 2023 00:49:18 -0800 (PST) syzbot reports oops in lockdep's __lock_acquire(), called from __pte_offset_map_lock() called from filemap_map_pages(); or when I run the repro, the oops comes in pmd_install(), called from filemap_map_pmd() called from filemap_map_pages(), just before the __pte_offset_map_lock(). The problem is that filemap_map_pmd() has been assuming that when it finds pmd_none(), a page table has already been prepared in prealloc_pte; and indeed do_fault_around() has been careful to preallocate one there, when it finds pmd_none(): but what if *pmd became none in between? My 6.6 mods in mm/khugepaged.c, avoiding mmap_lock for write, have made it easy for *pmd to be cleared while servicing a page fault; but even before those, a huge *pmd might be zapped while a fault is serviced. The difference in symptomatic stack traces comes from the "memory model" in use: pmd_install() uses pmd_populate() uses page_to_pfn(): in some models that is strict, and will oops on the NULL prealloc_pte; in other models, it will construct a bogus value to be populated into *pmd, then __pte_offset_map_lock() oops when trying to access split ptlock pointer (or some other symptom in normal case of ptlock embedded not pointer). Link: https://lore.kernel.org/linux-mm/20231115065506.19780-1-jose.pekkarinen@fox… Link: https://lkml.kernel.org/r/6ed0c50c-78ef-0719-b3c5-60c0c010431c@google.com Fixes: f9ce0be71d1f ("mm: Cleanup faultaround and finish_fault() codepaths") Signed-off-by: Hugh Dickins <hughd(a)google.com> Reported-and-tested-by: syzbot+89edd67979b52675ddec(a)syzkaller.appspotmail.com Closes: https://lore.kernel.org/linux-mm/0000000000005e44550608a0806c@google.com/ Cc: Jann Horn <jannh(a)google.com>, Cc: Jos�� Pekkarinen <jose.pekkarinen(a)foxhound.fi> Cc: Kirill A. Shutemov <kirill.shutemov(a)linux.intel.com> Cc: Matthew Wilcox (Oracle) <willy(a)infradead.org> Cc: <stable(a)vger.kernel.org> [5.12+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/filemap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/filemap.c~mm-fix-oops-when-filemap_map_pmd-without-prealloc_pte +++ a/mm/filemap.c @@ -3371,7 +3371,7 @@ static bool filemap_map_pmd(struct vm_fa } } - if (pmd_none(*vmf->pmd)) + if (pmd_none(*vmf->pmd) && vmf->prealloc_pte) pmd_install(mm, vmf->pmd, &vmf->prealloc_pte); return false; _ Patches currently in -mm which might be from hughd(a)google.com are mm-fix-oops-when-filemap_map_pmd-without-prealloc_pte.patch

1 year, 1 month

1
0
0 0

[PATCH v3] devcoredump: Send uevent once devcd is ready

by Mukesh Ojha

dev_coredumpm() creates a devcoredump device and adds it to the core kernel framework which eventually end up sending uevent to the user space and later creates a symbolic link to the failed device. An application running in userspace may be interested in this symbolic link to get the name of the failed device. In a issue scenario, once uevent sent to the user space it start reading '/sys/class/devcoredump/devcdX/failing_device' to get the actual name of the device which might not been created and it is in its path of creation. To fix this, suppress sending uevent till the failing device symbolic link gets created and send uevent once symbolic link is created successfully. Fixes: 833c95456a70 ("device coredump: add new device coredump class") Signed-off-by: Mukesh Ojha <quic_mojha(a)quicinc.com> Cc: stable(a)vger.kernel.org --- Change in v3: - Cced stable. Change in v2: - Added Fixes tag as per suggestion from [Johannes] drivers/base/devcoredump.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/base/devcoredump.c b/drivers/base/devcoredump.c index 91536ee05f14..7e2d1f0d903a 100644 --- a/drivers/base/devcoredump.c +++ b/drivers/base/devcoredump.c @@ -362,6 +362,7 @@ void dev_coredumpm(struct device *dev, struct module *owner, devcd->devcd_dev.class = &devcd_class; mutex_lock(&devcd->mutex); + dev_set_uevent_suppress(&devcd->devcd_dev, true); if (device_add(&devcd->devcd_dev)) goto put_device; @@ -376,6 +377,8 @@ void dev_coredumpm(struct device *dev, struct module *owner, "devcoredump")) dev_warn(dev, "devcoredump create_link failed\n"); + dev_set_uevent_suppress(&devcd->devcd_dev, false); + kobject_uevent(&devcd->devcd_dev.kobj, KOBJ_ADD); INIT_DELAYED_WORK(&devcd->del_wk, devcd_del); schedule_delayed_work(&devcd->del_wk, DEVCD_TIMEOUT); mutex_unlock(&devcd->mutex); -- 2.7.4

1 year, 1 month

1
0
0 0

[PATCH v1] net: can: j1939: enhanced error handling for tightly received RTS messages in xtp_rx_rts_session_new

by Oleksij Rempel

This patch enhances error handling in scenarios with RTS (Request to Send) messages arriving closely. It replaces the less informative WARN_ON_ONCE backtraces with a new error handling method. This provides clearer error messages and allows for the early termination of problematic sessions. Previously, sessions were only released at the end of j1939_xtp_rx_rts(). Potentially this could be reproduced with something like: testj1939 -r vcan0:0x80 & while true; do # send first RTS cansend vcan0 18EC8090#1014000303002301; # send second RTS cansend vcan0 18EC8090#1014000303002301; # send abort cansend vcan0 18EC8090#ff00000000002301; done Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol") Reported-by: syzbot+daa36413a5cedf799ae4(a)syzkaller.appspotmail.com Cc: stable(a)vger.kernel.org Signed-off-by: Oleksij Rempel <o.rempel(a)pengutronix.de> --- net/can/j1939/transport.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/net/can/j1939/transport.c b/net/can/j1939/transport.c index fe3df23a2595..c6569f98d251 100644 --- a/net/can/j1939/transport.c +++ b/net/can/j1939/transport.c @@ -1593,8 +1593,8 @@ j1939_session *j1939_xtp_rx_rts_session_new(struct j1939_priv *priv, struct j1939_sk_buff_cb skcb = *j1939_skb_to_cb(skb); struct j1939_session *session; const u8 *dat; + int len, ret; pgn_t pgn; - int len; netdev_dbg(priv->ndev, "%s\n", __func__); @@ -1653,7 +1653,22 @@ j1939_session *j1939_xtp_rx_rts_session_new(struct j1939_priv *priv, session->tskey = priv->rx_tskey++; j1939_sk_errqueue(session, J1939_ERRQUEUE_RX_RTS); - WARN_ON_ONCE(j1939_session_activate(session)); + ret = j1939_session_activate(session); + if (ret) { + /* Entering this scope indicates an issue with the J1939 bus. + * Possible scenarios include: + * - A time lapse occurred, and a new session was initiated + * due to another packet being sent correctly. This could + * have been caused by too long interrupt, debugger, or being + * out-scheduled by another task. + * - The bus is receiving numerous erroneous packets, either + * from a malfunctioning device or during a test scenario. + */ + netdev_alert(priv->ndev, "%s: 0x%p: concurrent session with same addr (%02x %02x) is already active.\n", + __func__, session, skcb.addr.sa, skcb.addr.da); + j1939_session_put(session); + return NULL; + } return session; } -- 2.39.2

1 year, 1 month

1
0
0 0

[PATCH 2/6] PCI: vmd: Fix deadlock when enabling ASPM

by Johan Hovold

The vmd_pm_enable_quirk() helper is called from pci_walk_bus() during probe to enable ASPM for controllers with VMD_FEAT_BIOS_PM_QUIRK set. Since pci_walk_bus() already holds a pci_bus_sem read lock, use the new locked helper to enable link states in order to avoid a potential deadlock (e.g. in case someone takes a write lock before reacquiring the read lock). Fixes: f492edb40b54 ("PCI: vmd: Add quirk to configure PCIe ASPM and LTR") Cc: stable(a)vger.kernel.org # 6.3 Cc: Michael Bottini <michael.a.bottini(a)linux.intel.com> Cc: David E. Box <david.e.box(a)linux.intel.com> Signed-off-by: Johan Hovold <johan+linaro(a)kernel.org> --- drivers/pci/controller/vmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c index 94ba61fe1c44..0452cbc362ee 100644 --- a/drivers/pci/controller/vmd.c +++ b/drivers/pci/controller/vmd.c @@ -751,7 +751,7 @@ static int vmd_pm_enable_quirk(struct pci_dev *pdev, void *userdata) if (!(features & VMD_FEAT_BIOS_PM_QUIRK)) return 0; - pci_enable_link_state(pdev, PCIE_LINK_STATE_ALL); + pci_enable_link_state_locked(pdev, PCIE_LINK_STATE_ALL); pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_LTR); if (!pos) -- 2.41.0

1 year, 1 month

2
1
0 0

[PATCH] scsi: qedi: Fix an endian bug in qedi_ring_doorbell

by Kunwu Chan

drivers/scsi/qedi/qedi_fw.c:932:40: sparse: sparse: incorrect type in assignment (different base types) expected restricted __le16 [usertype] sq_prod got unsigned short [usertype] fw_sq_prod_idx Cc: stable(a)vger.kernel.org Reported-by: kernel test robot <lkp(a)intel.com> Closes: https://lore.kernel.org/r/202311161351.7sPcpket-lkp@intel.com/ Signed-off-by: Kunwu Chan <chentao(a)kylinos.cn> --- drivers/scsi/qedi/qedi_fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c index 6901738324da..72da9dce4e6f 100644 --- a/drivers/scsi/qedi/qedi_fw.c +++ b/drivers/scsi/qedi/qedi_fw.c @@ -922,7 +922,7 @@ void qedi_fp_process_cqes(struct qedi_work *work) static void qedi_ring_doorbell(struct qedi_conn *qedi_conn) { - qedi_conn->ep->db_data.sq_prod = qedi_conn->ep->fw_sq_prod_idx; + qedi_conn->ep->db_data.sq_prod = cpu_to_le16(qedi_conn->ep->fw_sq_prod_idx); /* wmb - Make sure fw idx is coherent */ wmb(); -- 2.34.1

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror November 2023