October 2023 - Linux-stable-mirror

[merged mm-stable] mm-damon-implement-a-function-for-max-nr_accesses-safe-calculation.patch removed from -mm tree

by Andrew Morton

The quilt patch titled Subject: mm/damon: implement a function for max nr_accesses safe calculation has been removed from the -mm tree. Its filename was mm-damon-implement-a-function-for-max-nr_accesses-safe-calculation.patch This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm ------------------------------------------------------ From: SeongJae Park <sj(a)kernel.org> Subject: mm/damon: implement a function for max nr_accesses safe calculation Date: Thu, 19 Oct 2023 19:49:20 +0000 Patch series "avoid divide-by-zero due to max_nr_accesses overflow". The maximum nr_accesses of given DAMON context can be calculated by dividing the aggregation interval by the sampling interval. Some logics in DAMON uses the maximum nr_accesses as a divisor. Hence, the value shouldn't be zero. Such case is avoided since DAMON avoids setting the agregation interval as samller than the sampling interval. However, since nr_accesses is unsigned int while the intervals are unsigned long, the maximum nr_accesses could be zero while casting. Avoid the divide-by-zero by implementing a function that handles the corner case (first patch), and replaces the vulnerable direct max nr_accesses calculations (remaining patches). Note that the patches for the replacements are divided for broken commits, to make backporting on required tres easier. Especially, the last patch is for a patch that not yet merged into the mainline but in mm tree. This patch (of 4): The maximum nr_accesses of given DAMON context can be calculated by dividing the aggregation interval by the sampling interval. Some logics in DAMON uses the maximum nr_accesses as a divisor. Hence, the value shouldn't be zero. Such case is avoided since DAMON avoids setting the agregation interval as samller than the sampling interval. However, since nr_accesses is unsigned int while the intervals are unsigned long, the maximum nr_accesses could be zero while casting. Implement a function that handles the corner case. Note that this commit is not fixing the real issue since this is only introducing the safe function that will replaces the problematic divisions. The replacements will be made by followup commits, to make backporting on stable series easier. Link: https://lkml.kernel.org/r/20231019194924.100347-1-sj@kernel.org Link: https://lkml.kernel.org/r/20231019194924.100347-2-sj@kernel.org Fixes: 198f0f4c58b9 ("mm/damon/vaddr,paddr: support pageout prioritization") Signed-off-by: SeongJae Park <sj(a)kernel.org> Reported-by: Jakub Acs <acsjakub(a)amazon.de> Cc: <stable(a)vger.kernel.org> [5.16+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- include/linux/damon.h | 7 +++++++ 1 file changed, 7 insertions(+) --- a/include/linux/damon.h~mm-damon-implement-a-function-for-max-nr_accesses-safe-calculation +++ a/include/linux/damon.h @@ -681,6 +681,13 @@ static inline bool damon_target_has_pid( return ctx->ops.id == DAMON_OPS_VADDR || ctx->ops.id == DAMON_OPS_FVADDR; } +static inline unsigned int damon_max_nr_accesses(const struct damon_attrs *attrs) +{ + /* {aggr,sample}_interval are unsigned long, hence could overflow */ + return min(attrs->aggr_interval / attrs->sample_interval, + (unsigned long)UINT_MAX); +} + int damon_start(struct damon_ctx **ctxs, int nr_ctxs, bool exclusive); int damon_stop(struct damon_ctx **ctxs, int nr_ctxs); _ Patches currently in -mm which might be from sj(a)kernel.org are mm-damon-sysfs-remove-requested-targets-when-online-commit-inputs.patch

1 year, 3 months

1
0
0 0

stable/linux-5.15.y baseline: 259 runs, 1 regressions (v5.15.137)

by kernelci.org bot

stable/linux-5.15.y baseline: 259 runs, 1 regressions (v5.15.137) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions --------------+-------+------------+----------+-----------+------------ rk3399-roc-pc | arm64 | lab-clabbe | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/job/stable/branch/linux-5.15.y/kernel/v5.15.137/p… Test: baseline Tree: stable Branch: linux-5.15.y Describe: v5.15.137 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git SHA: 12952a23a5da6459aaaaa3ae4bc8ce8fef952ef5 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions --------------+-------+------------+----------+-----------+------------ rk3399-roc-pc | arm64 | lab-clabbe | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/65396a9d949627589eefcefa Results: 5 PASS, 1 FAIL, 1 SKIP Full config: defconfig Compiler: gcc-10 Plain log: https://storage.kernelci.org//stable/linux-5.15.y/v5.15.137/arm64/defconfig… HTML log: https://storage.kernelci.org//stable/linux-5.15.y/v5.15.137/arm64/defconfig… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/65396a9d949627589eefcf03 new failure (last pass: v5.15.136) 2023-10-25T19:20:38.114559 <8>[ 16.116512] <LAVA_SIGNAL_ENDRUN 0_dmesg 440396_1.5.2.4.1> 2023-10-25T19:20:38.219994 / # # 2023-10-25T19:20:38.321621 export SHELL=/bin/sh 2023-10-25T19:20:38.322193 # 2023-10-25T19:20:38.423242 / # export SHELL=/bin/sh. /lava-440396/environment 2023-10-25T19:20:38.423773 2023-10-25T19:20:38.524782 / # . /lava-440396/environment/lava-440396/bin/lava-test-runner /lava-440396/1 2023-10-25T19:20:38.525693 2023-10-25T19:20:38.530864 / # /lava-440396/bin/lava-test-runner /lava-440396/1 2023-10-25T19:20:38.576004 + export 'TESTRUN_ID=1_bootrr' ... (40 line(s) more)

1 year, 3 months

1
0
0 0

stable-rc/linux-5.10.y baseline: 168 runs, 1 regressions (v5.10.199)

by kernelci.org bot

stable-rc/linux-5.10.y baseline: 168 runs, 1 regressions (v5.10.199) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ---------+------+--------------+----------+--------------------+------------ panda | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/linux-5.10.y/kernel/v5.10.19… Test: baseline Tree: stable-rc Branch: linux-5.10.y Describe: v5.10.199 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: cb49f0e441ce7db63ef67ccfa9d9562c22f5d6c3 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ---------+------+--------------+----------+--------------------+------------ panda | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/653966117a9004113aefcefe Results: 5 PASS, 1 FAIL, 1 SKIP Full config: multi_v7_defconfig Compiler: gcc-10 Plain log: https://storage.kernelci.org//stable-rc/linux-5.10.y/v5.10.199/arm/multi_v7… HTML log: https://storage.kernelci.org//stable-rc/linux-5.10.y/v5.10.199/arm/multi_v7… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/653966117a9004113aefcf07 failing since 0 day (last pass: v5.10.148-5-gac0fb49345ee, first fail: v5.10.198-200-ge31b6513c43d) 2023-10-25T19:01:21.459095 <8>[ 24.783966] <LAVA_SIGNAL_ENDRUN 0_dmesg 3814643_1.5.2.4.1> 2023-10-25T19:01:21.565768 / # # 2023-10-25T19:01:21.666861 export SHELL=/bin/sh 2023-10-25T19:01:21.667200 # 2023-10-25T19:01:21.767958 / # export SHELL=/bin/sh. /lava-3814643/environment 2023-10-25T19:01:21.768318 2023-10-25T19:01:21.869091 / # . /lava-3814643/environment/lava-3814643/bin/lava-test-runner /lava-3814643/1 2023-10-25T19:01:21.869654 2023-10-25T19:01:21.874614 / # /lava-3814643/bin/lava-test-runner /lava-3814643/1 2023-10-25T19:01:21.932745 + export 'TESTRUN_ID=1_bootrr' ... (11 line(s) more)

1 year, 3 months

1
0
0 0

stable-rc/linux-5.4.y baseline: 154 runs, 2 regressions (v5.4.259)

by kernelci.org bot

stable-rc/linux-5.4.y baseline: 154 runs, 2 regressions (v5.4.259) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ----------------+-------+--------------+----------+--------------------+------------ meson-gxbb-p200 | arm64 | lab-baylibre | gcc-10 | defconfig | 1 panda | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/linux-5.4.y/kernel/v5.4.259/… Test: baseline Tree: stable-rc Branch: linux-5.4.y Describe: v5.4.259 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 86ea40e6ad22d9d7daa54b9e8167ad1e4a8a48ee Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ----------------+-------+--------------+----------+--------------------+------------ meson-gxbb-p200 | arm64 | lab-baylibre | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/6539637d595e489851efcef5 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 Plain log: https://storage.kernelci.org//stable-rc/linux-5.4.y/v5.4.259/arm64/defconfi… HTML log: https://storage.kernelci.org//stable-rc/linux-5.4.y/v5.4.259/arm64/defconfi… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/6539637d595e489851efcef6 new failure (last pass: v5.4.258-121-g18f5a3e6c35c) platform | arch | lab | compiler | defconfig | regressions ----------------+-------+--------------+----------+--------------------+------------ panda | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/653962de22637550e2efcef6 Results: 5 PASS, 1 FAIL, 1 SKIP Full config: multi_v7_defconfig Compiler: gcc-10 Plain log: https://storage.kernelci.org//stable-rc/linux-5.4.y/v5.4.259/arm/multi_v7_d… HTML log: https://storage.kernelci.org//stable-rc/linux-5.4.y/v5.4.259/arm/multi_v7_d… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/653962de22637550e2efceff failing since 0 day (last pass: v5.4.218-5-g5a1de46f7e74, first fail: v5.4.258-121-g18f5a3e6c35c) 2023-10-25T18:47:34.464333 <8>[ 21.144439] <LAVA_SIGNAL_ENDRUN 0_dmesg 3814585_1.5.2.4.1> 2023-10-25T18:47:34.572041 / # # 2023-10-25T18:47:34.673866 export SHELL=/bin/sh 2023-10-25T18:47:34.674354 # 2023-10-25T18:47:34.775250 / # export SHELL=/bin/sh. /lava-3814585/environment 2023-10-25T18:47:34.775939 2023-10-25T18:47:34.877089 / # . /lava-3814585/environment/lava-3814585/bin/lava-test-runner /lava-3814585/1 2023-10-25T18:47:34.878114 2023-10-25T18:47:34.883067 / # /lava-3814585/bin/lava-test-runner /lava-3814585/1 2023-10-25T18:47:34.937208 + export 'TESTRUN_ID=1_bootrr' ... (11 line(s) more)

1 year, 3 months

1
0
0 0

stable/linux-5.4.y baseline: 153 runs, 2 regressions (v5.4.259)

by kernelci.org bot

stable/linux-5.4.y baseline: 153 runs, 2 regressions (v5.4.259) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ---------+------+--------------+----------+---------------------+------------ panda | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 panda | arm | lab-baylibre | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/job/stable/branch/linux-5.4.y/kernel/v5.4.259/pla… Test: baseline Tree: stable Branch: linux-5.4.y Describe: v5.4.259 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git SHA: 86ea40e6ad22d9d7daa54b9e8167ad1e4a8a48ee Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ---------+------+--------------+----------+---------------------+------------ panda | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/65394d49c8ac80869cefcf15 Results: 5 PASS, 1 FAIL, 1 SKIP Full config: multi_v7_defconfig Compiler: gcc-10 Plain log: https://storage.kernelci.org//stable/linux-5.4.y/v5.4.259/arm/multi_v7_defc… HTML log: https://storage.kernelci.org//stable/linux-5.4.y/v5.4.259/arm/multi_v7_defc… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/65394d49c8ac80869cefcf1e new failure (last pass: v5.4.218) 2023-10-25T17:15:26.648063 + <8>[ 21.045318] <LAVA_SIGNAL_ENDRUN 0_dmesg 3814384_1.5.2.4.1> 2023-10-25T17:15:26.648278 set +x 2023-10-25T17:15:26.752570 / # # 2023-10-25T17:15:26.853605 export SHELL=/bin/sh 2023-10-25T17:15:26.853922 # 2023-10-25T17:15:26.954642 / # export SHELL=/bin/sh. /lava-3814384/environment 2023-10-25T17:15:26.954955 2023-10-25T17:15:27.055692 / # . /lava-3814384/environment/lava-3814384/bin/lava-test-runner /lava-3814384/1 2023-10-25T17:15:27.056224 2023-10-25T17:15:27.061227 / # /lava-3814384/bin/lava-test-runner /lava-3814384/1 ... (12 line(s) more) platform | arch | lab | compiler | defconfig | regressions ---------+------+--------------+----------+---------------------+------------ panda | arm | lab-baylibre | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/plan/id/65394a8d7cd2f603b3efcf17 Results: 5 PASS, 1 FAIL, 1 SKIP Full config: omap2plus_defconfig Compiler: gcc-10 Plain log: https://storage.kernelci.org//stable/linux-5.4.y/v5.4.259/arm/omap2plus_def… HTML log: https://storage.kernelci.org//stable/linux-5.4.y/v5.4.259/arm/omap2plus_def… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/65394a8d7cd2f603b3efcf20 new failure (last pass: v5.4.218) 2023-10-25T17:03:54.091350 <8>[ 20.709594] <LAVA_SIGNAL_ENDRUN 0_dmesg 3814301_1.5.2.4.1> 2023-10-25T17:03:54.102886 <6>[ 20.713592] smsc95xx 3-1.1:1.0 eth0: register 'smsc95xx' at usb-4a064c00.ehci-1.1, smsc95xx USB 2.0 Ethernet, 02:03:01:8c:13:b0 2023-10-25T17:03:54.108407 <6>[ 20.728118] usbcore: registered new interface driver smsc95xx 2023-10-25T17:03:54.217627 <3>[ 20.735504] omap-abe-twl6040 sound: AS# 2023-10-25T17:03:54.218477 oC: failed to init link DMIC: -517 2023-10-25T17:03:54.218785 / # <3>[ 20.743469] omap-abe-twl6040 sound: devm_snd_soc_register_card() failed: -517 2023-10-25T17:03:54.320107 #export SHELL=/bin/sh 2023-10-25T17:03:54.320526 2023-10-25T17:03:54.320764 / # <6>[ 20.881469] [drm] Cannot find any crtc or sizes 2023-10-25T17:03:54.421686 export SHELL=/bin/sh. /lava-3814301/environment ... (17 line(s) more)

1 year, 3 months

1
0
0 0

stable-rc/linux-5.15.y baseline: 147 runs, 1 regressions (v5.15.137)

by kernelci.org bot

stable-rc/linux-5.15.y baseline: 147 runs, 1 regressions (v5.15.137) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ---------+------+--------------+----------+--------------------+------------ panda | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/linux-5.15.y/kernel/v5.15.13… Test: baseline Tree: stable-rc Branch: linux-5.15.y Describe: v5.15.137 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 12952a23a5da6459aaaaa3ae4bc8ce8fef952ef5 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ---------+------+--------------+----------+--------------------+------------ panda | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/6539425bc3c04fb105efcf0e Results: 5 PASS, 1 FAIL, 1 SKIP Full config: multi_v7_defconfig Compiler: gcc-10 Plain log: https://storage.kernelci.org//stable-rc/linux-5.15.y/v5.15.137/arm/multi_v7… HTML log: https://storage.kernelci.org//stable-rc/linux-5.15.y/v5.15.137/arm/multi_v7… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/6539425bc3c04fb105efcf16 failing since 0 day (last pass: v5.15.74-2-g741b5047a5f58, first fail: v5.15.135-237-gbc0ffd9b5ee2) 2023-10-25T16:28:59.288638 + <8>[ 11.654632] <LAVA_SIGNAL_ENDRUN 0_dmesg 3814138_1.5.2.4.1> 2023-10-25T16:28:59.288855 set +x 2023-10-25T16:28:59.393322 / # # 2023-10-25T16:28:59.494657 export SHELL=/bin/sh 2023-10-25T16:28:59.495157 # 2023-10-25T16:28:59.595991 / # export SHELL=/bin/sh. /lava-3814138/environment 2023-10-25T16:28:59.596491 2023-10-25T16:28:59.697336 / # . /lava-3814138/environment/lava-3814138/bin/lava-test-runner /lava-3814138/1 2023-10-25T16:28:59.698048 2023-10-25T16:28:59.703091 / # /lava-3814138/bin/lava-test-runner /lava-3814138/1 ... (12 line(s) more)

1 year, 3 months

1
0
0 0

[PATCH] hwmon: nct6775: Fix incorrect variable reuse in fan_div calculation

by Zev Weiss

In the regmap conversion in commit 4ef2774511dc ("hwmon: (nct6775) Convert register access to regmap API") I reused the 'reg' variable for all three register reads in the fan speed calculation loop in nct6775_update_device(), but failed to notice that the value from the first one (data->REG_FAN[i]) is actually used in the call to nct6775_select_fan_div() at the end of the loop body. Since that patch the register value passed to nct6775_select_fan_div() has been (conditionally) incorrectly clobbered with the value of a different register than intended, which has in at least some cases resulted in fan speeds being adjusted down to zero. Fix this by using dedicated temporaries for the two intermediate register reads instead of 'reg'. Signed-off-by: Zev Weiss <zev(a)bewilderbeest.net> Fixes: 4ef2774511dc ("hwmon: (nct6775) Convert register access to regmap API") Reported-by: Thomas Zajic <zlatko(a)gmx.at> Tested-by: Thomas Zajic <zlatko(a)gmx.at> Cc: stable(a)vger.kernel.org # v5.19+ --- drivers/hwmon/nct6775-core.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/hwmon/nct6775-core.c b/drivers/hwmon/nct6775-core.c index b5b81bd83bb1..d928eb8ae5a3 100644 --- a/drivers/hwmon/nct6775-core.c +++ b/drivers/hwmon/nct6775-core.c @@ -1614,17 +1614,21 @@ struct nct6775_data *nct6775_update_device(struct device *dev) data->fan_div[i]); if (data->has_fan_min & BIT(i)) { - err = nct6775_read_value(data, data->REG_FAN_MIN[i], &reg); + u16 tmp; + + err = nct6775_read_value(data, data->REG_FAN_MIN[i], &tmp); if (err) goto out; - data->fan_min[i] = reg; + data->fan_min[i] = tmp; } if (data->REG_FAN_PULSES[i]) { - err = nct6775_read_value(data, data->REG_FAN_PULSES[i], &reg); + u16 tmp; + + err = nct6775_read_value(data, data->REG_FAN_PULSES[i], &tmp); if (err) goto out; - data->fan_pulses[i] = (reg >> data->FAN_PULSE_SHIFT[i]) & 0x03; + data->fan_pulses[i] = (tmp >> data->FAN_PULSE_SHIFT[i]) & 0x03; } err = nct6775_select_fan_div(dev, data, i, reg); -- 2.42.0

1 year, 3 months

2
1
0 0

stable/linux-5.10.y baseline: 171 runs, 1 regressions (v5.10.199)

by kernelci.org bot

stable/linux-5.10.y baseline: 171 runs, 1 regressions (v5.10.199) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ---------+------+--------------+----------+--------------------+------------ panda | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/job/stable/branch/linux-5.10.y/kernel/v5.10.199/p… Test: baseline Tree: stable Branch: linux-5.10.y Describe: v5.10.199 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git SHA: cb49f0e441ce7db63ef67ccfa9d9562c22f5d6c3 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ---------+------+--------------+----------+--------------------+------------ panda | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/65393d32c56c634badefcef3 Results: 5 PASS, 1 FAIL, 1 SKIP Full config: multi_v7_defconfig Compiler: gcc-10 Plain log: https://storage.kernelci.org//stable/linux-5.10.y/v5.10.199/arm/multi_v7_de… HTML log: https://storage.kernelci.org//stable/linux-5.10.y/v5.10.199/arm/multi_v7_de… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/65393d32c56c634badefcefc new failure (last pass: v5.10.148) 2023-10-25T16:06:55.028018 + <8>[ 24.847930] <LAVA_SIGNAL_ENDRUN 0_dmesg 3813999_1.5.2.4.1> 2023-10-25T16:06:55.028245 set +x 2023-10-25T16:06:55.133717 / # # 2023-10-25T16:06:55.234988 export SHELL=/bin/sh 2023-10-25T16:06:55.235350 # 2023-10-25T16:06:55.336128 / # export SHELL=/bin/sh. /lava-3813999/environment 2023-10-25T16:06:55.336497 2023-10-25T16:06:55.437331 / # . /lava-3813999/environment/lava-3813999/bin/lava-test-runner /lava-3813999/1 2023-10-25T16:06:55.438038 2023-10-25T16:06:55.443282 / # /lava-3813999/bin/lava-test-runner /lava-3813999/1 ... (12 line(s) more)

1 year, 3 months

1
0
0 0

[PATCH] drm/i915/pmu: Check if pmu is closed before stopping event

by Umesh Nerlige Ramappa

When the driver unbinds, pmu is unregistered and i915->uabi_engines is set to RB_ROOT. Due to this, when i915 PMU tries to stop the engine events, it issues a warn_on because engine lookup fails. All perf hooks are taking care of this using a pmu->closed flag that is set when PMU unregisters. The stop event seems to have been left out. Check for pmu->closed in pmu_event_stop as well. Based on discussion here - https://patchwork.freedesktop.org/patch/492079/?series=105790&rev=2 v2: s/is/if/ in commit title v3: Add fixes tag and cc stable Cc: <stable(a)vger.kernel.org> # v5.11+ Fixes: b00bccb3f0bb ("drm/i915/pmu: Handle PCI unbind") Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa(a)intel.com> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin(a)intel.com> --- drivers/gpu/drm/i915/i915_pmu.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c index 108b675088ba..f861863eb7c1 100644 --- a/drivers/gpu/drm/i915/i915_pmu.c +++ b/drivers/gpu/drm/i915/i915_pmu.c @@ -831,9 +831,18 @@ static void i915_pmu_event_start(struct perf_event *event, int flags) static void i915_pmu_event_stop(struct perf_event *event, int flags) { + struct drm_i915_private *i915 = + container_of(event->pmu, typeof(*i915), pmu.base); + struct i915_pmu *pmu = &i915->pmu; + + if (pmu->closed) + goto out; + if (flags & PERF_EF_UPDATE) i915_pmu_event_read(event); i915_pmu_disable(event); + +out: event->hw.state = PERF_HES_STOPPED; } -- 2.38.1

1 year, 3 months

2
3
0 0

stable/linux-6.1.y baseline: 169 runs, 2 regressions (v6.1.60)

by kernelci.org bot

stable/linux-6.1.y baseline: 169 runs, 2 regressions (v6.1.60) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions -------------------+-------+-------------+----------+-----------+------------ kontron-pitx-imx8m | arm64 | lab-kontron | gcc-10 | defconfig | 2 Details: https://kernelci.org/test/job/stable/branch/linux-6.1.y/kernel/v6.1.60/plan… Test: baseline Tree: stable Branch: linux-6.1.y Describe: v6.1.60 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git SHA: 32c9cdbe383c153af23cfa1df0a352b97ab3df7a Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions -------------------+-------+-------------+----------+-----------+------------ kontron-pitx-imx8m | arm64 | lab-kontron | gcc-10 | defconfig | 2 Details: https://kernelci.org/test/plan/id/65393a8cc4bb93a73fefcf1f Results: 50 PASS, 2 FAIL, 1 SKIP Full config: defconfig Compiler: gcc-10 Plain log: https://storage.kernelci.org//stable/linux-6.1.y/v6.1.60/arm64/defconfig/gc… HTML log: https://storage.kernelci.org//stable/linux-6.1.y/v6.1.60/arm64/defconfig/gc… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/65393a8cc4bb93a73fefcf26 new failure (last pass: v6.1.59) 2023-10-25T15:55:42.539365 / # # 2023-10-25T15:55:42.641336 export SHELL=/bin/sh 2023-10-25T15:55:42.641668 # 2023-10-25T15:55:42.742405 / # export SHELL=/bin/sh. /lava-388657/environment 2023-10-25T15:55:42.743182 2023-10-25T15:55:42.844427 / # . /lava-388657/environment/lava-388657/bin/lava-test-runner /lava-388657/1 2023-10-25T15:55:42.845580 2023-10-25T15:55:42.851322 / # /lava-388657/bin/lava-test-runner /lava-388657/1 2023-10-25T15:55:42.916339 + export 'TESTRUN_ID=1_bootrr' 2023-10-25T15:55:42.916749 + cd /lava-388657/1/tests/1_bootrr ... (10 line(s) more) * baseline.bootrr.dwc3-usb1-probed: https://kernelci.org/test/case/id/65393a8cc4bb93a73fefcf36 new failure (last pass: v6.1.59) 2023-10-25T15:55:45.287082 /lava-388657/1/../bin/lava-test-case 2023-10-25T15:55:45.287443 <8>[ 17.006305] <LAVA_SIGNAL_TESTCASE TEST_CASE_ID=dwc3-usb1-probed RESULT=fail> 2023-10-25T15:55:45.287681 /lava-388657/1/../bin/lava-test-case

1 year, 3 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror October 2023