August 2022 - Linux-stable-mirror

by Greg Kroah-Hartman

I'm announcing the release of the 4.14.291 kernel. All users of the 4.14 kernel series must upgrade. The updated 4.14.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.14.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 6 + arch/arm/boot/dts/aspeed-ast2500-evb.dts | 2 arch/arm/boot/dts/imx6ul.dtsi | 5 - arch/arm/boot/dts/qcom-pm8841.dtsi | 1 arch/arm/lib/findbit.S | 16 +-- arch/arm/lib/xor-neon.c | 3 arch/arm/mach-bcm/bcm_kona_smc.c | 1 arch/arm/mach-omap2/display.c | 1 arch/arm/mach-zynq/common.c | 1 arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 arch/arm64/include/asm/processor.h | 3 arch/arm64/kernel/armv8_deprecated.c | 9 + arch/ia64/include/asm/processor.h | 2 arch/mips/cavium-octeon/octeon-platform.c | 3 arch/mips/kernel/proc.c | 2 arch/mips/mm/tlbex.c | 4 arch/nios2/include/asm/entry.h | 3 arch/nios2/include/asm/ptrace.h | 2 arch/nios2/kernel/entry.S | 22 +++- arch/nios2/kernel/signal.c | 3 arch/nios2/kernel/syscall_table.c | 1 arch/parisc/kernel/drivers.c | 9 - arch/powerpc/kernel/pci-common.c | 45 ++++++--- arch/powerpc/kernel/prom.c | 7 + arch/powerpc/mm/dump_linuxpagetables.c | 13 -- arch/powerpc/platforms/cell/axon_msi.c | 1 arch/powerpc/platforms/cell/spufs/inode.c | 1 arch/powerpc/platforms/powernv/rng.c | 2 arch/powerpc/sysdev/fsl_pci.c | 8 + arch/powerpc/sysdev/fsl_pci.h | 1 arch/powerpc/sysdev/xive/spapr.c | 1 arch/s390/include/asm/archrandom.h | 9 + arch/x86/boot/Makefile | 2 arch/x86/boot/compressed/Makefile | 4 arch/x86/entry/vdso/Makefile | 2 arch/x86/kernel/pmem.c | 7 + arch/x86/kvm/emulate.c | 23 ++-- arch/x86/kvm/hyperv.c | 3 arch/x86/kvm/lapic.c | 4 arch/x86/kvm/svm.c | 2 arch/x86/mm/numa.c | 4 arch/x86/platform/olpc/olpc-xo1-sci.c | 2 drivers/acpi/acpi_lpss.c | 3 drivers/acpi/property.c | 8 - drivers/acpi/sleep.c | 8 + drivers/acpi/video_detect.c | 55 +++++++---- drivers/ata/libata-eh.c | 1 drivers/atm/idt77252.c | 1 drivers/bluetooth/hci_intel.c | 6 + drivers/clk/qcom/gcc-ipq8074.c | 1 drivers/fpga/altera-pr-ip-core.c | 2 drivers/gpio/gpiolib-of.c | 4 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 17 ++- drivers/gpu/drm/bridge/sil-sii8620.c | 4 drivers/gpu/drm/mediatek/mtk_dpi.c | 31 +----- drivers/gpu/drm/mediatek/mtk_dsi.c | 2 drivers/gpu/drm/meson/meson_drv.c | 5 - drivers/gpu/drm/nouveau/nvkm/subdev/bios/base.c | 2 drivers/gpu/drm/radeon/ni_dpm.c | 6 - drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 drivers/gpu/drm/vc4/vc4_dsi.c | 6 - drivers/hid/wacom_sys.c | 2 drivers/hid/wacom_wac.c | 43 +++++---- drivers/hwtracing/intel_th/pci.c | 15 +++ drivers/i2c/busses/i2c-cadence.c | 10 +- drivers/i2c/i2c-core-base.c | 3 drivers/i2c/muxes/i2c-mux-gpmux.c | 1 drivers/iio/light/isl29028.c | 2 drivers/infiniband/hw/hfi1/file_ops.c | 4 drivers/infiniband/sw/rxe/rxe_qp.c | 12 +- drivers/iommu/exynos-iommu.c | 6 + drivers/iommu/qcom_iommu.c | 7 + drivers/irqchip/irq-tegra.c | 10 +- drivers/macintosh/adb.c | 2 drivers/md/dm-raid.c | 4 drivers/md/dm.c | 5 + drivers/md/raid10.c | 5 - drivers/md/raid5.c | 2 drivers/media/platform/mtk-mdp/mtk_mdp_ipi.h | 2 drivers/media/usb/hdpvr/hdpvr-video.c | 2 drivers/memstick/core/ms_block.c | 11 +- drivers/mfd/rtsx_pcr.c | 6 + drivers/mfd/t7l66xb.c | 6 - drivers/misc/cxl/irq.c | 1 drivers/mmc/host/cavium-octeon.c | 1 drivers/mmc/host/cavium-thunderx.c | 4 drivers/mmc/host/sdhci-of-at91.c | 9 + drivers/mmc/host/sdhci-of-esdhc.c | 1 drivers/mtd/devices/st_spi_fsm.c | 8 + drivers/mtd/maps/physmap_of_versatile.c | 2 drivers/mtd/sm_ftl.c | 2 drivers/net/can/pch_can.c | 8 - drivers/net/can/rcar/rcar_can.c | 8 - drivers/net/can/sja1000/sja1000.c | 7 - drivers/net/can/spi/hi311x.c | 5 - drivers/net/can/sun4i_can.c | 9 - drivers/net/can/usb/ems_usb.c | 2 drivers/net/can/usb/usb_8dev.c | 7 - drivers/net/ethernet/freescale/fec_ptp.c | 6 - drivers/net/ethernet/intel/i40e/i40e_main.c | 4 drivers/net/ethernet/intel/igb/igb.h | 2 drivers/net/ethernet/intel/igb/igb_main.c | 12 ++ drivers/net/geneve.c | 3 drivers/net/sungem_phy.c | 1 drivers/net/usb/ax88179_178a.c | 16 +-- drivers/net/usb/usbnet.c | 8 - drivers/net/wireless/ath/ath9k/htc.h | 10 +- drivers/net/wireless/ath/ath9k/htc_drv_init.c | 3 drivers/net/wireless/ath/wil6210/debugfs.c | 18 +-- drivers/net/wireless/intel/iwlegacy/4965-rs.c | 5 - drivers/net/wireless/intersil/p54/main.c | 2 drivers/net/wireless/intersil/p54/p54spi.c | 3 drivers/net/wireless/marvell/libertas/if_usb.c | 1 drivers/net/wireless/mediatek/mt7601u/usb.c | 1 drivers/pci/quirks.c | 3 drivers/pinctrl/nomadik/pinctrl-nomadik.c | 4 drivers/pinctrl/qcom/pinctrl-msm8916.c | 4 drivers/platform/olpc/olpc-ec.c | 2 drivers/regulator/of_regulator.c | 6 + drivers/remoteproc/qcom_wcnss.c | 10 +- drivers/s390/char/zcore.c | 11 ++ drivers/s390/cio/vfio_ccw_drv.c | 14 -- drivers/s390/scsi/zfcp_fc.c | 29 ++++-- drivers/s390/scsi/zfcp_fc.h | 6 - drivers/s390/scsi/zfcp_fsf.c | 4 drivers/scsi/sg.c | 57 +++++++----- drivers/scsi/smartpqi/smartpqi_init.c | 4 drivers/scsi/ufs/ufshcd-pltfrm.c | 15 ++- drivers/soc/fsl/guts.c | 2 drivers/tty/n_gsm.c | 83 +++++++++++++++-- drivers/tty/serial/ucc_uart.c | 2 drivers/usb/core/hcd.c | 26 +++-- drivers/usb/gadget/legacy/inode.c | 1 drivers/usb/gadget/udc/Kconfig | 2 drivers/usb/host/ehci-ppc-of.c | 1 drivers/usb/host/ohci-nxp.c | 1 drivers/usb/host/ohci-ppc-of.c | 1 drivers/usb/serial/sierra.c | 3 drivers/usb/serial/usb-serial.c | 2 drivers/usb/serial/usb_wwan.c | 3 drivers/vfio/vfio.c | 1 drivers/video/fbdev/amba-clcd.c | 24 +++-- drivers/video/fbdev/arkfb.c | 9 + drivers/video/fbdev/i740fb.c | 9 + drivers/video/fbdev/s3fb.c | 2 drivers/video/fbdev/sis/init.c | 4 drivers/video/fbdev/vt8623fb.c | 2 drivers/xen/xenbus/xenbus_dev_frontend.c | 4 fs/attr.c | 2 fs/btrfs/disk-io.c | 14 ++ fs/btrfs/raid56.c | 74 ++++++++++++--- fs/btrfs/tree-log.c | 4 fs/cifs/smb2ops.c | 5 - fs/ext2/super.c | 12 ++ fs/ext4/inline.c | 3 fs/ext4/inode.c | 10 +- fs/ext4/migrate.c | 4 fs/ext4/namei.c | 23 +++- fs/ext4/resize.c | 11 ++ fs/ext4/xattr.c | 6 - fs/ext4/xattr.h | 13 ++ fs/fuse/inode.c | 6 + fs/jbd2/transaction.c | 14 ++ fs/namei.c | 2 fs/nfs/nfs4idmap.c | 46 +++++---- fs/nfs/nfs4proc.c | 3 fs/ntfs/attrib.c | 8 + fs/splice.c | 10 -- include/linux/buffer_head.h | 25 +++++ include/linux/kfifo.h | 2 include/linux/kvm_host.h | 28 +++++ include/linux/mfd/t7l66xb.h | 1 include/linux/pci_ids.h | 2 include/linux/usb/hcd.h | 1 include/net/bluetooth/l2cap.h | 1 include/sound/core.h | 8 + include/trace/events/spmi.h | 12 +- include/uapi/linux/can/error.h | 5 - kernel/kprobes.c | 3 kernel/power/user.c | 13 ++ kernel/profile.c | 7 + mm/mmap.c | 1 net/9p/client.c | 4 net/bluetooth/l2cap_core.c | 68 ++++++++++---- net/dccp/proto.c | 10 +- net/ipv4/tcp_output.c | 30 ++++-- net/ipv6/ping.c | 6 + net/netfilter/nf_tables_api.c | 3 net/netfilter/nfnetlink_queue.c | 7 + net/rds/ib_recv.c | 1 net/rose/af_rose.c | 11 +- net/rose/rose_route.c | 2 net/sched/cls_route.c | 8 + net/sunrpc/backchannel_rqst.c | 14 ++ net/vmw_vsock/af_vsock.c | 10 +- security/apparmor/audit.c | 2 security/apparmor/label.c | 6 - security/apparmor/mount.c | 8 + security/selinux/ss/policydb.h | 2 sound/core/info.c | 6 - sound/core/misc.c | 94 ++++++++++++++++++++ sound/core/timer.c | 11 +- sound/pci/hda/patch_cirrus.c | 1 sound/pci/hda/patch_conexant.c | 11 ++ sound/soc/codecs/da7210.c | 2 sound/soc/mediatek/mt8173/mt8173-rt5650-rt5676.c | 10 +- sound/soc/mediatek/mt8173/mt8173-rt5650.c | 9 + sound/usb/bcd2000/bcd2000.c | 3 tools/build/feature/test-libcrypto.c | 15 ++- tools/perf/util/genelf.c | 6 + tools/testing/selftests/timers/clocksource-switch.c | 6 - tools/testing/selftests/timers/valid-adjtimex.c | 2 tools/thermal/tmon/sysfs.c | 24 ++--- tools/thermal/tmon/tmon.h | 3 virt/kvm/kvm_main.c | 10 +- 216 files changed, 1337 insertions(+), 540 deletions(-) Al Viro (6): nios2: page fault et.al. are *not* restartable syscalls... nios2: don't leave NULLs in sys_call_table[] nios2: traced syscall does need to check the syscall number nios2: fix syscall restart checks nios2: restarts apply only to the first sigframe we build... nios2: add force_successful_syscall_return() Alan Brady (1): i40e: Fix to stop tx_timeout recovery if GLOBR fails Alexander Gordeev (1): s390/zcore: fix race when reading from hardware system area Alexander Lobakin (2): ia64, processor: fix -Wincompatible-pointer-types in ia64_get_irr() x86/olpc: fix 'logical not is only applied to the left hand side' Alexander Shishkin (3): intel_th: pci: Add Raptor Lake-S CPU support intel_th: pci: Add Raptor Lake-S PCH support intel_th: pci: Add Meteor Lake-P support Alexander Stein (2): ARM: dts: imx6ul: add missing properties for sram ARM: dts: imx6ul: fix qspi node compatible Alexey Kodanev (2): drm/radeon: fix potential buffer overflow in ni_set_mc_special_registers() wifi: iwlegacy: 4965: fix potential off-by-one overflow in il4965_rs_fill_link_cmd() Allen Ballway (1): ALSA: hda/cirrus - support for iMac 12,1 model Amadeusz Sławiński (1): ALSA: info: Fix llseek return value when using callback Ammar Faizi (1): wifi: wil6210: debugfs: fix uninitialized variable use in `wil_write_file_wmi()` AngeloGioacchino Del Regno (1): media: platform: mtk-mdp: Fix mdp_ipi_comm structure alignment Arnaldo Carvalho de Melo (1): genelf: Use HAVE_LIBCRYPTO_SUPPORT, not the never defined HAVE_LIBCRYPTO Baokun Li (4): ext4: add EXT4_INODE_HAS_XATTR_SPACE macro in xattr.h ext4: fix use-after-free in ext4_xattr_set_entry ext4: correct max_inline_xattr_value_size computing ext4: correct the misjudgment in ext4_iget_extra_inode Bo-Chen Chen (1): drm/mediatek: dpi: Remove output format of YUV Brian Norris (1): drm/rockchip: vop: Don't crash for invalid duplicate_state() Chen Zhongjin (2): profiling: fix shift too large makes kernel panic kprobes: Forbid probing on trampoline and BPF code areas ChenXiaoSong (1): ntfs: fix use-after-free in ntfs_ucsncmp() Christophe JAILLET (5): wifi: p54: Fix an error handling path in p54spi_probe() misc: rtsx: Fix an error handling path in rtsx_pci_probe() memstick/ms_block: Fix some incorrect memory allocation memstick/ms_block: Fix a memory leak cxl: Fix a memory leak in an error handling path Christophe Leroy (1): powerpc/ptdump: Fix display of RW pages on FSL_BOOK3E Csókás Bence (1): fec: Fix timer capture timing in `fec_ptp_enable_pps()` Damien Le Moal (1): ata: libata-eh: Add missing command name Dan Carpenter (4): wifi: wil6210: debugfs: fix info leak in wil_write_file_wmi() platform/olpc: Fix uninitialized data in debugfs write kfifo: fix kfifo_to_user() return type xen/xenbus: fix return type in xenbus_file_read() Daniel Starke (5): tty: n_gsm: fix non flow control frames during mux flow off tty: n_gsm: fix packet re-transmission without open control channel tty: n_gsm: fix race condition in gsmld_write() tty: n_gsm: fix wrong T1 retry count handling tty: n_gsm: fix DM command Dave Stevenson (1): drm/vc4: dsi: Correct DSI divider calculations David Collins (1): spmi: trace: fix stack-out-of-bound access in SPMI tracing functions David Howells (1): vfs: Check the truncate maximum size in inode_newsize_ok() Duoming Zhou (2): mtd: sm_ftl: Fix deadlock caused by cancel_work_sync in sm_release atm: idt77252: fix use-after-free bugs caused by tst_timer Eric Dumazet (2): net: rose: fix netdev reference changes tcp: fix over estimation in sk_forced_mem_schedule() Eric Farman (1): vfio/ccw: Do not change FSM state in subchannel event Eric Whitney (1): ext4: fix extent status tree race in writeback error recovery path Eugen Hristev (1): mmc: sdhci-of-at91: fix set_uhs_signaling rewriting of MC1R Filipe Manana (1): btrfs: fix lost error handling when looking up extended ref on log replay Florian Fainelli (1): tools/thermal: Fix possible path truncations Florian Westphal (2): netfilter: nf_queue: do not allow packet truncation below transport header offset netfilter: nf_tables: fix null deref due to zeroed list head Francis Laniel (1): arm64: Do not forget syscall when starting a new thread. Greg Kroah-Hartman (2): ARM: crypto: comment out gcc warning that breaks clang builds Linux 4.14.291 Hangyu Hua (3): drm: bridge: sii8620: fix possible off-by-one wifi: libertas: Fix possible refcount leak in if_usb_probe() dccp: put dccp_qpolicy_full() and dccp_qpolicy_push() in the same lock Harald Freudenberger (1): s390/archrandom: prevent CPACF trng invocations in interrupt context Helge Deller (1): parisc: Fix device names in /proc/iomem Huacai Chen (1): MIPS: cpuinfo: Fix a warning for CONFIG_CPUMASK_OFFSTACK Jamal Hadi Salim (1): net_sched: cls_route: disallow handle of 0 Jan Kara (1): ext2: Add more validity checks for inode counts Jason A. Donenfeld (1): fs: check FMODE_LSEEK to control internal pipe splicing Jianglei Nie (1): RDMA/hfi1: fix potential memory leak in setup_base_ctxt() Jiasheng Jiang (3): drm: bridge: adv7511: Add check for mipi_dsi_driver_register Bluetooth: hci_intel: Add check for platform_driver_register ASoC: codecs: da7210: add check for i2c_add_driver Johan Hovold (2): x86/pmem: Fix platform-device leak in error path USB: serial: fix tty-port initialized comments John Johansen (2): apparmor: fix quiet_denied for file rules apparmor: Fix failed mount permission check error message Jose Alonso (1): Revert "net: usb: ax88179_178a needs FLAG_SEND_ZLP" Jozef Martiniak (1): gadgetfs: ep_io - wait until IRQ finishes Kiselev, Oleg (1): ext4: avoid resizing to a partial cluster size Krzysztof Kozlowski (2): ARM: dts: ast2500-evb: fix board compatible ARM: dts: qcom: pm8841: add required thermal-sensor-cells Kuniyuki Iwashima (1): net: ping6: Fix memleak in ipv6_renew_options(). Lars-Peter Clausen (1): i2c: cadence: Support PEC for SMBus block read Leo Li (1): drm/amdgpu: Check BO's requested pinning domains against its preferred_domains Li Lingfeng (1): ext4: recover csum seed of tmp_inode after migrating to extents Liang He (14): scsi: ufs: host: Hold reference returned by of_parse_phandle() net: sungem_phy: Add of_node_put() for reference returned by of_get_parent() ARM: OMAP2+: display: Fix refcount leak bug regulator: of: Fix refcount leak bug in of_get_regulation_constraints() i2c: mux-gpmux: Add of_node_put() when breaking out of loop gpio: gpiolib-of: Fix refcount bugs in of_mm_gpiochip_add_data() mmc: cavium-octeon: Add of_node_put() when breaking out of loop mmc: cavium-thunderx: Add of_node_put() when breaking out of loop iommu/arm-smmu: qcom_iommu: Add of_node_put() when breaking out of loop video: fbdev: amba-clcd: Fix refcount leak bugs drm/meson: Fix refcount bugs in meson_vpu_has_available_connectors() usb: host: ohci-ppc-of: Fix refcount leak bug tty: serial: Fix refcount leak bug in ucc_uart.c mips: cavium-octeon: Fix missing of_node_put() in octeon2_usb_clocks_start Lin Ma (1): igb: Add lock to avoid data race Luiz Augusto von Dentz (2): Bluetooth: L2CAP: Fix use-after-free caused by l2cap_chan_put Bluetooth: L2CAP: Fix l2cap_global_chan_by_psm regression Lukas Czerner (1): ext4: make sure ext4_append() always allocates new block Lukas Wunner (1): usbnet: Fix linkwatch use-after-free on disconnect Maciej S. Szmigiero (1): KVM: SVM: Don't BUG if userspace injects an interrupt with GIF=0 Mahesh Rajashekhara (1): scsi: smartpqi: Fix DMA direction for RAID requests Manyi Li (1): ACPI: PM: save NVS memory for Lenovo G40-45 Marc Kleine-Budde (1): can: ems_usb: fix clang's -Wunaligned-access warning Marco Pagani (1): fpga: altera-pr-ip: fix unsigned comparison with less than zero Markus Mayer (1): thermal/tools/tmon: Include pthread and time headers in tmon.h Masahiro Yamada (1): kbuild: clear LDFLAGS in the top Makefile Matthias May (1): geneve: do not use RT_TOS for IPv6 flowlabel Meng Tang (1): ALSA: hda/conexant: Add quirk for LENOVO 20149 Notebook model Miaohe Lin (1): mm/mmap.c: fix missing call to vm_unacct_memory in mmap_region Miaoqian Lin (13): ARM: bcm: Fix refcount leak in bcm_kona_smc_init cpufreq: zynq: Fix refcount leak in zynq_get_revision mtd: maps: Fix refcount leak in of_flash_probe_versatile mtd: maps: Fix refcount leak in ap_flash_init usb: host: Fix refcount leak in ehci_hcd_ppc_of_probe usb: ohci-nxp: Fix refcount leak in ohci_hcd_nxp_probe mmc: sdhci-of-esdhc: Fix refcount leak in esdhc_signal_voltage_switch ASoC: mediatek: mt8173: Fix refcount leak in mt8173_rt5650_rt5676_dev_probe ASoC: mediatek: mt8173-rt5650: Fix refcount leak in mt8173_rt5650_dev_probe powerpc/spufs: Fix refcount leak in spufs_init_isolated_loader powerpc/xive: Fix refcount leak in xive_get_max_prio powerpc/cell/axon_msi: Fix refcount leak in setup_msi_msg_address pinctrl: nomadik: Fix refcount leak in nmk_pinctrl_dt_subnode_to_map Michael Ellerman (3): powerpc/powernv: Avoid crashing if rng is NULL powerpc/pci: Fix PHB numbering when using opal-phbid powerpc/pci: Fix get_phb_number() locking Michael Walle (1): soc: fsl: guts: machine variable might be unset Mike Snitzer (1): dm: return early from dm_pr_call() if DM device is suspended Miklos Szeredi (1): fuse: limit nsec Mikulas Patocka (5): add barriers to buffer_uptodate and set_buffer_uptodate md-raid10: fix KASAN warning dm raid: fix address sanitizer warning in raid_resume dm raid: fix address sanitizer warning in raid_status rds: add missing barrier to release_refill Nathan Chancellor (1): MIPS: tlbex: Explicitly compare _PAGE_NO_EXEC against 0 Nick Desaulniers (2): Makefile: link with -z noexecstack --no-warn-rwx-segments x86: link vdso and boot with -z noexecstack --no-warn-rwx-segments Niels Dossche (1): media: hdpvr: fix error value returns in hdpvr_read Nikita Travkin (1): pinctrl: qcom: msm8916: Allow CAMSS GP clocks to be muxed Ning Qiang (1): macintosh/adb: fix oob read in do_adb_query() function Pablo Neira Ayuso (1): netfilter: nf_tables: really skip inactive sets when allocating name Pali Rohár (3): PCI: Add defines for normal and subtractive PCI bridges powerpc/fsl-pci: Fix Class Code of PCIe Root Port powerpc/pci: Prefer PCI domain assignment via DT 'linux,pci-domain' and alias Pavan Chebbi (1): PCI: Add ACS quirk for Broadcom BCM5750x NICs Pavel Skripkin (1): ath9k: fix use-after-free in ath9k_hif_usb_rx_cb Peilin Ye (2): vsock: Fix memory leak in vsock_connect() vsock: Set socket state back to SS_UNCONNECTED in vsock_connect_timeout() Ping Cheng (1): HID: wacom: Don't register pad_input for touch switch Qu Wenruo (3): btrfs: reject log replay if there is unsupported RO compat flag btrfs: only write the sectors in the vertical stripe which has data stripes btrfs: raid56: don't trust any cached sector in __raid56_parity_recover() Randy Dunlap (1): usb: gadget: udc: amd5536 depends on HAS_DMA Robert Marko (1): clk: qcom: ipq8074: dont disable gcc_sleep_clk_src Roberto Sassu (1): tools build: Switch to new openssl API for test-libcrypto Russell King (Oracle) (1): ARM: findbit: fix overflowing offset Rustam Subkhankulov (2): wifi: p54: add missing parentheses in p54_flush() video: fbdev: sis: fix typos in SiS_GetModeID() Sai Prakash Ranjan (1): irqchip/tegra: Fix overflow implicit truncation warnings Sakari Ailus (1): ACPI: property: Return type of acpi_add_nondev_subnodes() should be bool Sam Protsenko (1): iommu/exynos: Handle failed IOMMU device registration properly Schspa Shi (1): vfio: Clear the caps->buf to NULL after free Sean Christopherson (3): KVM: x86: Mark TSS busy during LTR emulation _after_ all fault checks KVM: x86: Set error code to segment selector on LLDT/LTR non-canonical #GP KVM: Add infrastructure and macro to mark VM as bugged Siddh Raman Pant (1): x86/numa: Use cpumask_available instead of hardcoded NULL check Sireesh Kodali (2): arm64: dts: qcom: msm8916: Fix typo in pronto remoteproc node remoteproc: qcom: wcnss: Fix handling of IRQs Steffen Maier (1): scsi: zfcp: Fix missing auto port scan and thus missing target ports Steve French (1): smb3: check xattr value length earlier Takashi Iwai (2): ALSA: core: Add async signal helpers ALSA: timer: Use deferred fasync helper Tetsuo Handa (1): PM: hibernate: defer device probing when resuming from hibernation Thadeu Lima de Souza Cascardo (1): net_sched: cls_route: remove from list when handle is 0 Theodore Ts'o (1): ext4: update s_overhead_clusters in the superblock during an on-line resize Timur Tabi (1): drm/nouveau: fix another off-by-one in nvbios_addr Tom Rix (1): apparmor: fix aa_label_asxprint return check Tony Battersby (1): scsi: sg: Allow waiting for commands to complete on removed device Trond Myklebust (2): NFSv4: Fix races in the legacy idmapper upcall SUNRPC: Reinitialise the backchannel request buffers before reuse Tyler Hicks (1): net/9p: Initialize the iounit field during fid creation Uwe Kleine-König (2): mtd: st_spi_fsm: Add a clk_disable_unprepare() in .probe()'s error path mfd: t7l66xb: Drop platform disable callback Vincent Mailhol (8): can: pch_can: do not report txerr and rxerr during bus-off can: rcar_can: do not report txerr and rxerr during bus-off can: sja1000: do not report txerr and rxerr during bus-off can: hi311x: do not report txerr and rxerr during bus-off can: sun4i_can: do not report txerr and rxerr during bus-off can: usb_8dev: do not report txerr and rxerr during bus-off can: error: specify the values of data[5..7] of CAN error frames can: pch_can: pch_can_error(): initialize errc before using it Vitaly Kuznetsov (2): KVM: x86: Check lapic_in_kernel() before attempting to set a SynIC irq KVM: x86: Avoid theoretical NULL pointer dereference in kvm_irq_delivery_to_apic_fast() Wei Mingzhi (1): mt7601u: add USB device ID for some versions of XiaoDu WiFi Dongle. Weitao Wang (1): USB: HCD: Fix URB giveback issue in tasklet function Wentao_Liang (1): drivers:md:fix a potential use-after-free bug Werner Sembach (2): ACPI: video: Force backlight native for some TongFang devices ACPI: video: Shortening quirk list by identifying Clevo by board_name only Wolfram Sang (2): selftests: timers: valid-adjtimex: build fix for newer toolchains selftests: timers: clocksource-switch: fix passing errors from child Xin Xiong (1): apparmor: fix reference count leak in aa_pivotroot() Xinlei Lee (1): drm/mediatek: Add pull-down MIPI operation in mtk_dsi_poweroff function Xiu Jianfeng (1): selinux: Add boundary check in put_entry() Xu Wang (1): i2c: Fix a potential use after free Yang Xu (1): fs: Add missing umask strip in vfs_tmpfile Ye Bin (1): ext4: avoid remove directory when directory is corrupted Yonglong Li (1): tcp: make retransmitted SKB fit into the send window Zhang Xianwei (1): NFSv4.1: RECLAIM_COMPLETE must handle EACCES Zheyu Ma (7): ALSA: bcd2000: Fix a UAF bug on the error path of probing iio: light: isl29028: Fix the warning in isl29028_remove() video: fbdev: arkfb: Fix a divide-by-zero bug in ark_set_pixclock() video: fbdev: vt8623fb: Check the size of screen before memset_io() video: fbdev: arkfb: Check the size of screen before memset_io() video: fbdev: s3fb: Check the size of screen before memset_io() video: fbdev: i740fb: Check the argument of i740_calc_vclk() Zhihao Cheng (1): jbd2: fix assertion 'jh->b_frozen_data == NULL' failure when journal aborted Zhouyi Zhou (1): powerpc/64: Init jump labels before parse_early_param() Zhu Yanjun (1): RDMA/rxe: Fix error unwind in rxe_create_qp() haibinzhang (张海斌) (1): arm64: fix oops in concurrently setting insn_emulation sysctls huhai (1): ACPI: LPSS: Fix missing check in register_device_clock()

2 years, 4 months

1
1
0 0

Linux 4.9.326

by Greg Kroah-Hartman

I'm announcing the release of the 4.9.326 kernel. All users of the 4.9 kernel series must upgrade. The updated 4.9.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.9.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 arch/arm/lib/xor-neon.c | 3 arch/ia64/include/asm/processor.h | 2 arch/mips/cavium-octeon/octeon-platform.c | 3 arch/mips/kernel/proc.c | 2 arch/mips/mm/tlbex.c | 4 arch/nios2/include/asm/entry.h | 3 arch/nios2/include/asm/ptrace.h | 2 arch/nios2/kernel/entry.S | 22 ++-- arch/nios2/kernel/signal.c | 3 arch/nios2/kernel/syscall_table.c | 1 arch/nios2/kernel/time.c | 5 arch/parisc/kernel/drivers.c | 9 - arch/powerpc/kernel/prom.c | 7 + arch/powerpc/platforms/powernv/rng.c | 2 arch/powerpc/sysdev/fsl_pci.c | 8 + arch/powerpc/sysdev/fsl_pci.h | 1 arch/x86/kvm/emulate.c | 19 +-- arch/x86/kvm/svm.c | 2 arch/x86/platform/olpc/olpc-xo1-sci.c | 2 drivers/acpi/video_detect.c | 55 ++++++---- drivers/ata/libata-eh.c | 1 drivers/atm/idt77252.c | 1 drivers/gpu/drm/nouveau/nvkm/subdev/bios/base.c | 2 drivers/irqchip/irq-tegra.c | 10 - drivers/macintosh/adb.c | 2 drivers/md/dm-raid.c | 2 drivers/md/raid10.c | 5 drivers/md/raid5.c | 2 drivers/misc/cxl/irq.c | 1 drivers/net/can/usb/ems_usb.c | 2 drivers/net/ethernet/freescale/fec_ptp.c | 6 - drivers/net/sungem_phy.c | 1 drivers/net/usb/ax88179_178a.c | 14 +- drivers/net/usb/usbnet.c | 8 - drivers/net/wireless/mediatek/mt7601u/usb.c | 1 drivers/pinctrl/nomadik/pinctrl-nomadik.c | 4 drivers/pinctrl/qcom/pinctrl-msm8916.c | 4 drivers/s390/scsi/zfcp_fc.c | 29 +++-- drivers/s390/scsi/zfcp_fc.h | 6 - drivers/s390/scsi/zfcp_fsf.c | 4 drivers/scsi/sg.c | 57 ++++++----- drivers/scsi/ufs/ufshcd-pltfrm.c | 15 ++ drivers/staging/android/ion/ion-ioctl.c | 8 - drivers/tty/serial/ucc_uart.c | 2 drivers/usb/core/hcd.c | 26 ++--- drivers/usb/gadget/legacy/inode.c | 1 drivers/usb/host/ohci-ppc-of.c | 1 drivers/vfio/vfio.c | 1 drivers/video/fbdev/i740fb.c | 9 + drivers/xen/xenbus/xenbus_dev_frontend.c | 4 fs/attr.c | 2 fs/btrfs/disk-io.c | 14 ++ fs/btrfs/tree-log.c | 4 fs/ext4/inline.c | 3 fs/ext4/inode.c | 7 + fs/ext4/namei.c | 23 +++- fs/ext4/resize.c | 11 ++ fs/ext4/xattr.c | 6 - fs/ext4/xattr.h | 13 ++ fs/fuse/inode.c | 6 + fs/nfs/nfs4proc.c | 3 fs/ntfs/attrib.c | 8 + fs/proc/base.c | 23 +--- fs/proc/fd.c | 6 - fs/proc/internal.h | 2 fs/proc/namespaces.c | 3 include/linux/bpf.h | 11 ++ include/linux/buffer_head.h | 25 ++++ include/linux/pci_ids.h | 2 include/linux/usb/hcd.h | 1 include/net/bluetooth/l2cap.h | 1 include/sound/core.h | 8 + include/trace/events/spmi.h | 12 +- include/uapi/linux/swab.h | 4 init/main.c | 14 -- kernel/bpf/core.c | 16 ++- kernel/bpf/syscall.c | 36 +++++-- net/9p/client.c | 4 net/bluetooth/l2cap_core.c | 68 +++++++++---- net/ipv4/tcp_output.c | 7 - net/ipv6/ping.c | 6 + net/netfilter/nf_tables_api.c | 3 net/netfilter/nfnetlink_queue.c | 7 + net/rds/ib_recv.c | 1 net/sched/cls_route.c | 8 + net/sunrpc/backchannel_rqst.c | 14 ++ net/vmw_vsock/af_vsock.c | 9 + security/selinux/hooks.c | 123 +++++++++++++++--------- security/selinux/include/objsec.h | 5 security/selinux/selinuxfs.c | 4 sound/core/info.c | 6 - sound/core/misc.c | 94 ++++++++++++++++++ sound/core/timer.c | 11 +- sound/pci/hda/patch_cirrus.c | 1 sound/pci/hda/patch_conexant.c | 11 +- sound/usb/bcd2000/bcd2000.c | 3 97 files changed, 742 insertions(+), 293 deletions(-) Al Viro (6): nios2: page fault et.al. are *not* restartable syscalls... nios2: don't leave NULLs in sys_call_table[] nios2: traced syscall does need to check the syscall number nios2: fix syscall restart checks nios2: restarts apply only to the first sigframe we build... nios2: add force_successful_syscall_return() Alexander Lobakin (2): ia64, processor: fix -Wincompatible-pointer-types in ia64_get_irr() x86/olpc: fix 'logical not is only applied to the left hand side' Allen Ballway (1): ALSA: hda/cirrus - support for iMac 12,1 model Amadeusz Sławiński (1): ALSA: info: Fix llseek return value when using callback Andreas Gruenbacher (4): selinux: Minor cleanups proc: Pass file mode to proc_pid_make_inode selinux: Clean up initialization of isec->sclass selinux: Convert isec->lock into a spinlock Baokun Li (3): ext4: add EXT4_INODE_HAS_XATTR_SPACE macro in xattr.h ext4: fix use-after-free in ext4_xattr_set_entry ext4: correct max_inline_xattr_value_size computing ChenXiaoSong (1): ntfs: fix use-after-free in ntfs_ucsncmp() Christian Borntraeger (1): include/uapi/linux/swab.h: fix userspace breakage, use __BITS_PER_LONG for swap Christophe JAILLET (1): cxl: Fix a memory leak in an error handling path Csókás Bence (1): fec: Fix timer capture timing in `fec_ptp_enable_pps()` Damien Le Moal (1): ata: libata-eh: Add missing command name Dan Carpenter (1): xen/xenbus: fix return type in xenbus_file_read() Daniel Borkmann (1): bpf: fix overflow in prog accounting Daniel Micay (1): init/main.c: extract early boot entropy from the passed cmdline David Collins (1): spmi: trace: fix stack-out-of-bound access in SPMI tracing functions David Howells (1): vfs: Check the truncate maximum size in inode_newsize_ok() Duoming Zhou (1): atm: idt77252: fix use-after-free bugs caused by tst_timer Eric Dumazet (1): tcp: fix over estimation in sk_forced_mem_schedule() Eric Whitney (1): ext4: fix extent status tree race in writeback error recovery path Filipe Manana (1): btrfs: fix lost error handling when looking up extended ref on log replay Florian Westphal (2): netfilter: nf_queue: do not allow packet truncation below transport header offset netfilter: nf_tables: fix null deref due to zeroed list head Greg Kroah-Hartman (2): ARM: crypto: comment out gcc warning that breaks clang builds Linux 4.9.326 Guenter Roeck (1): nios2: time: Read timer in get_cycles only if initialized Hans-Christian Noren Egtvedt (1): random: only call boot_init_stack_canary() once Helge Deller (1): parisc: Fix device names in /proc/iomem Huacai Chen (1): MIPS: cpuinfo: Fix a warning for CONFIG_CPUMASK_OFFSTACK Jamal Hadi Salim (1): net_sched: cls_route: disallow handle of 0 Jose Alonso (1): Revert "net: usb: ax88179_178a needs FLAG_SEND_ZLP" Jozef Martiniak (1): gadgetfs: ep_io - wait until IRQ finishes Kiselev, Oleg (1): ext4: avoid resizing to a partial cluster size Kuniyuki Iwashima (1): net: ping6: Fix memleak in ipv6_renew_options(). Laura Abbott (1): init: move stack canary initialization after setup_arch Liang He (5): scsi: ufs: host: Hold reference returned by of_parse_phandle() net: sungem_phy: Add of_node_put() for reference returned by of_get_parent() usb: host: ohci-ppc-of: Fix refcount leak bug tty: serial: Fix refcount leak bug in ucc_uart.c mips: cavium-octeon: Fix missing of_node_put() in octeon2_usb_clocks_start Luiz Augusto von Dentz (2): Bluetooth: L2CAP: Fix use-after-free caused by l2cap_chan_put Bluetooth: L2CAP: Fix l2cap_global_chan_by_psm regression Lukas Czerner (1): ext4: make sure ext4_append() always allocates new block Lukas Wunner (1): usbnet: Fix linkwatch use-after-free on disconnect Maciej S. Szmigiero (1): KVM: SVM: Don't BUG if userspace injects an interrupt with GIF=0 Marc Kleine-Budde (1): can: ems_usb: fix clang's -Wunaligned-access warning Meng Tang (1): ALSA: hda/conexant: Add quirk for LENOVO 20149 Notebook model Miaoqian Lin (1): pinctrl: nomadik: Fix refcount leak in nmk_pinctrl_dt_subnode_to_map Michael Ellerman (1): powerpc/powernv: Avoid crashing if rng is NULL Miklos Szeredi (1): fuse: limit nsec Mikulas Patocka (4): add barriers to buffer_uptodate and set_buffer_uptodate md-raid10: fix KASAN warning dm raid: fix address sanitizer warning in raid_status rds: add missing barrier to release_refill Nathan Chancellor (2): ion: Make user_ion_handle_put_nolock() a void function MIPS: tlbex: Explicitly compare _PAGE_NO_EXEC against 0 Nikita Travkin (1): pinctrl: qcom: msm8916: Allow CAMSS GP clocks to be muxed Ning Qiang (1): macintosh/adb: fix oob read in do_adb_query() function Pablo Neira Ayuso (1): netfilter: nf_tables: really skip inactive sets when allocating name Pali Rohár (2): PCI: Add defines for normal and subtractive PCI bridges powerpc/fsl-pci: Fix Class Code of PCIe Root Port Paul Moore (1): selinux: fix inode_doinit_with_dentry() LABEL_INVALID error handling Peilin Ye (1): vsock: Fix memory leak in vsock_connect() Qu Wenruo (1): btrfs: reject log replay if there is unsupported RO compat flag Sai Prakash Ranjan (1): irqchip/tegra: Fix overflow implicit truncation warnings Schspa Shi (1): vfio: Clear the caps->buf to NULL after free Sean Christopherson (1): KVM: x86: Mark TSS busy during LTR emulation _after_ all fault checks Steffen Maier (1): scsi: zfcp: Fix missing auto port scan and thus missing target ports Takashi Iwai (2): ALSA: core: Add async signal helpers ALSA: timer: Use deferred fasync helper Thadeu Lima de Souza Cascardo (1): net_sched: cls_route: remove from list when handle is 0 Theodore Ts'o (1): ext4: update s_overhead_clusters in the superblock during an on-line resize Tianyue Ren (1): selinux: fix error initialization in inode_doinit_with_dentry() Timur Tabi (1): drm/nouveau: fix another off-by-one in nvbios_addr Tony Battersby (1): scsi: sg: Allow waiting for commands to complete on removed device Trond Myklebust (1): SUNRPC: Reinitialise the backchannel request buffers before reuse Tyler Hicks (1): net/9p: Initialize the iounit field during fid creation Viresh Kumar (2): init/main: Fix double "the" in comment init/main: properly align the multi-line comment Wei Mingzhi (1): mt7601u: add USB device ID for some versions of XiaoDu WiFi Dongle. Weitao Wang (1): USB: HCD: Fix URB giveback issue in tasklet function Wentao_Liang (1): drivers:md:fix a potential use-after-free bug Werner Sembach (2): ACPI: video: Force backlight native for some TongFang devices ACPI: video: Shortening quirk list by identifying Clevo by board_name only Ye Bin (1): ext4: avoid remove directory when directory is corrupted Zhang Xianwei (1): NFSv4.1: RECLAIM_COMPLETE must handle EACCES Zheyu Ma (2): ALSA: bcd2000: Fix a UAF bug on the error path of probing video: fbdev: i740fb: Check the argument of i740_calc_vclk() Zhouyi Zhou (1): powerpc/64: Init jump labels before parse_early_param()

2 years, 4 months

1
1
0 0

Re: [PATCH 5.4 000/389] 5.4.211-rc1 review

by Greg Kroah-Hartman

On Thu, Aug 25, 2022 at 05:20:46PM +0800, zhouzhixiu wrote: > > On 2022/8/23 16:21, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.4.211 release. > > There are 389 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. Responses should be made by Thu, 25 Aug 2022 08:00:15 > > +0000. Anything received after that time might be too late. The whole > > patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.211-rc… > > or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > > linux-5.4.y and the diffstat can be found below. thanks, greg k-h > > Tested on arm64 and x86 for 5.4.211-rc1, > > Kernel repo: > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > > Branch: linux-5.10.yVersion: > 5.4.211-rc1Commit:1cece69eaa889a27cf3e9f2051fcc57eda957271Compiler: gcc > version 7.3.0 (GCC) arm64:--------------------------------------------------------------------Testcase > Result Summary:total: 9017passed: 9017failed: 0timeout: 0--------------------------------------------------------------------x86:--------------------------------------------------------------------Testcase > Result Summary:total: 9017passed: 9017failed: 0timeout: 0--------------------------------------------------------------------Tested-by: > Hulk Robot <hulkrobot(a)huawei.com> Your emails are being sent in html format and not being accepted by the mialing list. Also this response is very odd :(

2 years, 4 months

1
0
0 0

[PATCH] xen/privcmd: fix error exit of privcmd_ioctl_dm_op()

by Juergen Gross

The error exit of privcmd_ioctl_dm_op() is calling unlock_pages() potentially with pages being NULL, leading to a NULL dereference. Fix that by calling unlock_pages only if lock_pages() was at least partially successful. Cc: <stable(a)vger.kernel.org> Fixes: ab520be8cd5d ("xen/privcmd: Add IOCTL_PRIVCMD_DM_OP") Reported-by: Rustam Subkhankulov <subkhankulov(a)ispras.ru> Signed-off-by: Juergen Gross <jgross(a)suse.com> --- drivers/xen/privcmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 3369734108af..ec87968b4459 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -679,7 +679,7 @@ static long privcmd_ioctl_dm_op(struct file *file, void __user *udata) rc = lock_pages(kbufs, kdata.num, pages, nr_pages, &pinned); if (rc < 0) { nr_pages = pinned; - goto out; + goto unlock; } for (i = 0; i < kdata.num; i++) { @@ -691,8 +691,9 @@ static long privcmd_ioctl_dm_op(struct file *file, void __user *udata) rc = HYPERVISOR_dm_op(kdata.dom, kdata.num, xbufs); xen_preemptible_hcall_end(); -out: + unlock: unlock_pages(pages, nr_pages); + out: kfree(xbufs); kfree(pages); kfree(kbufs); -- 2.35.3

2 years, 4 months

3
3
0 0

Re: stable-rc/linux-5.18.y bisection: baseline.login on panda

by Mark Brown

On Wed, Aug 24, 2022 at 01:22:12PM -0700, KernelCI bot wrote: The KernelCI bisection bot identified 7eea9a60703ca ("usbnet: smsc95xx: Forward PHY interrupts to PHY driver to avoid polling") as causing a boot regression on Panda in v5.18. The board stops detecting a link which breks NFS boot: <6>[ 4.953613] smsc95xx 2-1.1:1.0 eth0: register 'smsc95xx' at usb-4a064c00.ehci-1.1, smsc95xx USB 2.0 Ethernet, 02:03:01:8c:13:b0 <6>[ 5.032928] smsc95xx 2-1.1:1.0 eth0: hardware isn't capable of remote wakeup <6>[ 5.044036] smsc95xx 2-1.1:1.0 eth0: Link is Down <6>[ 25.053924] Waiting up to 100 more seconds for network. <6>[ 45.074005] Waiting up to 80 more seconds for network. <6>[ 65.093933] Waiting up to 60 more seconds for network. <6>[ 85.123992] Waiting up to 40 more seconds for network. <6>[ 105.143951] Waiting up to 20 more seconds for network. <5>[ 125.084014] Sending DHCP requests ...... timed out! <6>[ 207.765808] smsc95xx 2-1.1:1.0 eth0: hardware isn't capable of remote wakeup <3>[ 207.773468] IP-Config: Reopening network devices... <6>[ 207.840332] smsc95xx 2-1.1:1.0 eth0: hardware isn't capable of remote wakeup <6>[ 207.851226] smsc95xx 2-1.1:1.0 eth0: Link is Down <6>[ 227.873931] Waiting up to 100 more seconds for network. <6>[ 247.873931] Waiting up to 80 more seconds for network. We're seen other failures on this board in mainline which stop boot sooner so can't confirm if there's a similar issue there. I've left the whole report, including links to more details like full logs and a tag for the bot below: > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > * This automated bisection report was sent to you on the basis * > * that you may be involved with the breaking commit it has * > * found. No manual investigation has been done to verify it, * > * and the root cause of the problem may be somewhere else. * > * * > * If you do send a fix, please include this trailer: * > * Reported-by: "kernelci.org bot" <bot(a)kernelci.org> * > * * > * Hope this helps! * > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > > stable-rc/linux-5.18.y bisection: baseline.login on panda > > Summary: > Start: 22a992953741a Linux 5.18.19 > Plain log: https://storage.kernelci.org/stable-rc/linux-5.18.y/v5.18.19/arm/multi_v7_d… > HTML log: https://storage.kernelci.org/stable-rc/linux-5.18.y/v5.18.19/arm/multi_v7_d… > Result: 7eea9a60703ca usbnet: smsc95xx: Forward PHY interrupts to PHY driver to avoid polling > > Checks: > revert: PASS > verify: PASS > > Parameters: > Tree: stable-rc > URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > Branch: linux-5.18.y > Target: panda > CPU arch: arm > Lab: lab-baylibre > Compiler: gcc-10 > Config: multi_v7_defconfig > Test case: baseline.login > > Breaking commit found: > > ------------------------------------------------------------------------------- > commit 7eea9a60703caf1b04eccba93cd103f1c8fc6809 > Author: Lukas Wunner <lukas(a)wunner.de> > Date: Thu May 12 10:42:05 2022 +0200 > > usbnet: smsc95xx: Forward PHY interrupts to PHY driver to avoid polling > > [ Upstream commit 1ce8b37241ed291af56f7a49bbdbf20c08728e88 ] > > Link status of SMSC LAN95xx chips is polled once per second, even though > they're capable of signaling PHY interrupts through the MAC layer. > > Forward those interrupts to the PHY driver to avoid polling. Benefits > are reduced bus traffic, reduced CPU overhead and quicker interface > bringup. > > Polling was introduced in 2016 by commit d69d16949346 ("usbnet: > smsc95xx: fix link detection for disabled autonegotiation"). > Back then, the LAN95xx driver neglected to enable the ENERGYON interrupt, > hence couldn't detect link-up events when auto-negotiation was disabled. > The proper solution would have been to enable the ENERGYON interrupt > instead of polling. > > Since then, PHY handling was moved from the LAN95xx driver to the SMSC > PHY driver with commit 05b35e7eb9a1 ("smsc95xx: add phylib support"). > That PHY driver is capable of link detection with auto-negotiation > disabled because it enables the ENERGYON interrupt. > > Note that signaling interrupts through the MAC layer not only works with > the integrated PHY, but also with an external PHY, provided its > interrupt pin is attached to LAN95xx's nPHY_INT pin. > > In the unlikely event that the interrupt pin of an external PHY is > attached to a GPIO of the SoC (or not connected at all), the driver can > be amended to retrieve the irq from the PHY's of_node. > > To forward PHY interrupts to phylib, it is not sufficient to call > phy_mac_interrupt(). Instead, the PHY's interrupt handler needs to run > so that PHY interrupts are cleared. That's because according to page > 119 of the LAN950x datasheet, "The source of this interrupt is a level. > The interrupt persists until it is cleared in the PHY." > > https://www.microchip.com/content/dam/mchp/documents/UNG/ProductDocuments/D… > > Therefore, create an IRQ domain with a single IRQ for the PHY. In the > future, the IRQ domain may be extended to support the 11 GPIOs on the > LAN95xx. > > Normally the PHY interrupt should be masked until the PHY driver has > cleared it. However masking requires a (sleeping) USB transaction and > interrupts are received in (non-sleepable) softirq context. I decided > not to mask the interrupt at all (by using the dummy_irq_chip's noop > ->irq_mask() callback): The USB interrupt endpoint is polled in 1 msec > intervals and normally that's sufficient to wake the PHY driver's IRQ > thread and have it clear the interrupt. If it does take longer, worst > thing that can happen is the IRQ thread is woken again. No big deal. > > Because PHY interrupts are now perpetually enabled, there's no need to > selectively enable them on suspend. So remove all invocations of > smsc95xx_enable_phy_wakeup_interrupts(). > > In smsc95xx_resume(), move the call of phy_init_hw() before > usbnet_resume() (which restarts the status URB) to ensure that the PHY > is fully initialized when an interrupt is handled. > > Tested-by: Oleksij Rempel <o.rempel(a)pengutronix.de> # LAN9514/9512/9500 > Tested-by: Ferry Toth <fntoth(a)gmail.com> # LAN9514 > Signed-off-by: Lukas Wunner <lukas(a)wunner.de> > Reviewed-by: Andrew Lunn <andrew(a)lunn.ch> # from a PHY perspective > Cc: Andre Edich <andre.edich(a)microchip.com> > Signed-off-by: David S. Miller <davem(a)davemloft.net> > Signed-off-by: Sasha Levin <sashal(a)kernel.org> > > diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c > index f5a208948d22a..358b170cc8fb7 100644 > --- a/drivers/net/usb/smsc95xx.c > +++ b/drivers/net/usb/smsc95xx.c > @@ -18,6 +18,8 @@ > #include <linux/usb/usbnet.h> > #include <linux/slab.h> > #include <linux/of_net.h> > +#include <linux/irq.h> > +#include <linux/irqdomain.h> > #include <linux/mdio.h> > #include <linux/phy.h> > #include <net/selftests.h> > @@ -53,6 +55,9 @@ > #define SUSPEND_ALLMODES (SUSPEND_SUSPEND0 | SUSPEND_SUSPEND1 | \ > SUSPEND_SUSPEND2 | SUSPEND_SUSPEND3) > > +#define SMSC95XX_NR_IRQS (1) /* raise to 12 for GPIOs */ > +#define PHY_HWIRQ (SMSC95XX_NR_IRQS - 1) > + > struct smsc95xx_priv { > u32 mac_cr; > u32 hash_hi; > @@ -61,6 +66,9 @@ struct smsc95xx_priv { > spinlock_t mac_cr_lock; > u8 features; > u8 suspend_flags; > + struct irq_chip irqchip; > + struct irq_domain *irqdomain; > + struct fwnode_handle *irqfwnode; > struct mii_bus *mdiobus; > struct phy_device *phydev; > }; > @@ -597,6 +605,8 @@ static void smsc95xx_mac_update_fullduplex(struct usbnet *dev) > > static void smsc95xx_status(struct usbnet *dev, struct urb *urb) > { > + struct smsc95xx_priv *pdata = dev->driver_priv; > + unsigned long flags; > u32 intdata; > > if (urb->actual_length != 4) { > @@ -608,11 +618,15 @@ static void smsc95xx_status(struct usbnet *dev, struct urb *urb) > intdata = get_unaligned_le32(urb->transfer_buffer); > netif_dbg(dev, link, dev->net, "intdata: 0x%08X\n", intdata); > > + local_irq_save(flags); > + > if (intdata & INT_ENP_PHY_INT_) > - ; > + generic_handle_domain_irq(pdata->irqdomain, PHY_HWIRQ); > else > netdev_warn(dev->net, "unexpected interrupt, intdata=0x%08X\n", > intdata); > + > + local_irq_restore(flags); > } > > /* Enable or disable Tx & Rx checksum offload engines */ > @@ -1098,8 +1112,9 @@ static int smsc95xx_bind(struct usbnet *dev, struct usb_interface *intf) > { > struct smsc95xx_priv *pdata; > bool is_internal_phy; > + char usb_path[64]; > + int ret, phy_irq; > u32 val; > - int ret; > > printk(KERN_INFO SMSC_CHIPNAME " v" SMSC_DRIVER_VERSION "\n"); > > @@ -1139,10 +1154,38 @@ static int smsc95xx_bind(struct usbnet *dev, struct usb_interface *intf) > if (ret) > goto free_pdata; > > + /* create irq domain for use by PHY driver and GPIO consumers */ > + usb_make_path(dev->udev, usb_path, sizeof(usb_path)); > + pdata->irqfwnode = irq_domain_alloc_named_fwnode(usb_path); > + if (!pdata->irqfwnode) { > + ret = -ENOMEM; > + goto free_pdata; > + } > + > + pdata->irqdomain = irq_domain_create_linear(pdata->irqfwnode, > + SMSC95XX_NR_IRQS, > + &irq_domain_simple_ops, > + pdata); > + if (!pdata->irqdomain) { > + ret = -ENOMEM; > + goto free_irqfwnode; > + } > + > + phy_irq = irq_create_mapping(pdata->irqdomain, PHY_HWIRQ); > + if (!phy_irq) { > + ret = -ENOENT; > + goto remove_irqdomain; > + } > + > + pdata->irqchip = dummy_irq_chip; > + pdata->irqchip.name = SMSC_CHIPNAME; > + irq_set_chip_and_handler_name(phy_irq, &pdata->irqchip, > + handle_simple_irq, "phy"); > + > pdata->mdiobus = mdiobus_alloc(); > if (!pdata->mdiobus) { > ret = -ENOMEM; > - goto free_pdata; > + goto dispose_irq; > } > > ret = smsc95xx_read_reg(dev, HW_CFG, &val); > @@ -1175,6 +1218,7 @@ static int smsc95xx_bind(struct usbnet *dev, struct usb_interface *intf) > goto unregister_mdio; > } > > + pdata->phydev->irq = phy_irq; > pdata->phydev->is_internal = is_internal_phy; > > /* detect device revision as different features may be available */ > @@ -1217,6 +1261,15 @@ static int smsc95xx_bind(struct usbnet *dev, struct usb_interface *intf) > free_mdio: > mdiobus_free(pdata->mdiobus); > > +dispose_irq: > + irq_dispose_mapping(phy_irq); > + > +remove_irqdomain: > + irq_domain_remove(pdata->irqdomain); > + > +free_irqfwnode: > + irq_domain_free_fwnode(pdata->irqfwnode); > + > free_pdata: > kfree(pdata); > return ret; > @@ -1229,6 +1282,9 @@ static void smsc95xx_unbind(struct usbnet *dev, struct usb_interface *intf) > phy_disconnect(dev->net->phydev); > mdiobus_unregister(pdata->mdiobus); > mdiobus_free(pdata->mdiobus); > + irq_dispose_mapping(irq_find_mapping(pdata->irqdomain, PHY_HWIRQ)); > + irq_domain_remove(pdata->irqdomain); > + irq_domain_free_fwnode(pdata->irqfwnode); > netif_dbg(dev, ifdown, dev->net, "free pdata\n"); > kfree(pdata); > } > @@ -1253,29 +1309,6 @@ static u32 smsc_crc(const u8 *buffer, size_t len, int filter) > return crc << ((filter % 2) * 16); > } > > -static int smsc95xx_enable_phy_wakeup_interrupts(struct usbnet *dev, u16 mask) > -{ > - int ret; > - > - netdev_dbg(dev->net, "enabling PHY wakeup interrupts\n"); > - > - /* read to clear */ > - ret = smsc95xx_mdio_read_nopm(dev, PHY_INT_SRC); > - if (ret < 0) > - return ret; > - > - /* enable interrupt source */ > - ret = smsc95xx_mdio_read_nopm(dev, PHY_INT_MASK); > - if (ret < 0) > - return ret; > - > - ret |= mask; > - > - smsc95xx_mdio_write_nopm(dev, PHY_INT_MASK, ret); > - > - return 0; > -} > - > static int smsc95xx_link_ok_nopm(struct usbnet *dev) > { > int ret; > @@ -1442,7 +1475,6 @@ static int smsc95xx_enter_suspend3(struct usbnet *dev) > static int smsc95xx_autosuspend(struct usbnet *dev, u32 link_up) > { > struct smsc95xx_priv *pdata = dev->driver_priv; > - int ret; > > if (!netif_running(dev->net)) { > /* interface is ifconfig down so fully power down hw */ > @@ -1461,27 +1493,10 @@ static int smsc95xx_autosuspend(struct usbnet *dev, u32 link_up) > } > > netdev_dbg(dev->net, "autosuspend entering SUSPEND1\n"); > - > - /* enable PHY wakeup events for if cable is attached */ > - ret = smsc95xx_enable_phy_wakeup_interrupts(dev, > - PHY_INT_MASK_ANEG_COMP_); > - if (ret < 0) { > - netdev_warn(dev->net, "error enabling PHY wakeup ints\n"); > - return ret; > - } > - > netdev_info(dev->net, "entering SUSPEND1 mode\n"); > return smsc95xx_enter_suspend1(dev); > } > > - /* enable PHY wakeup events so we remote wakeup if cable is pulled */ > - ret = smsc95xx_enable_phy_wakeup_interrupts(dev, > - PHY_INT_MASK_LINK_DOWN_); > - if (ret < 0) { > - netdev_warn(dev->net, "error enabling PHY wakeup ints\n"); > - return ret; > - } > - > netdev_dbg(dev->net, "autosuspend entering SUSPEND3\n"); > return smsc95xx_enter_suspend3(dev); > } > @@ -1547,13 +1562,6 @@ static int smsc95xx_suspend(struct usb_interface *intf, pm_message_t message) > } > > if (pdata->wolopts & WAKE_PHY) { > - ret = smsc95xx_enable_phy_wakeup_interrupts(dev, > - (PHY_INT_MASK_ANEG_COMP_ | PHY_INT_MASK_LINK_DOWN_)); > - if (ret < 0) { > - netdev_warn(dev->net, "error enabling PHY wakeup ints\n"); > - goto done; > - } > - > /* if link is down then configure EDPD and enter SUSPEND1, > * otherwise enter SUSPEND0 below > */ > @@ -1787,11 +1795,12 @@ static int smsc95xx_resume(struct usb_interface *intf) > return ret; > } > > + phy_init_hw(pdata->phydev); > + > ret = usbnet_resume(intf); > if (ret < 0) > netdev_warn(dev->net, "usbnet_resume error\n"); > > - phy_init_hw(pdata->phydev); > return ret; > } > ------------------------------------------------------------------------------- > > > Git bisection log: > > ------------------------------------------------------------------------------- > git bisect start > # good: [9aa5a042881d4a99657f82c774e9e15353ebeb2d] Linux 5.18.14 > git bisect good 9aa5a042881d4a99657f82c774e9e15353ebeb2d > # bad: [22a992953741ad79c07890d3f4104585e52ef26b] Linux 5.18.19 > git bisect bad 22a992953741ad79c07890d3f4104585e52ef26b > # good: [77d5174ed962c259965226386f71575790646ec0] drm/mediatek: dpi: Remove output format of YUV > git bisect good 77d5174ed962c259965226386f71575790646ec0 > # good: [598bc9541e2f82a7fe8dfe23891201b355a56cda] usb: dwc3: core: Do not perform GCTL_CORE_SOFTRESET during bootup > git bisect good 598bc9541e2f82a7fe8dfe23891201b355a56cda > # good: [876f57cc94922896cc71dd4696013a7c0558c9b4] f2fs: give priority to select unpinned section for foreground GC > git bisect good 876f57cc94922896cc71dd4696013a7c0558c9b4 > # bad: [5f4e505909fe50a4e256704076594ee3def0b9b1] block: add a bdev_max_zone_append_sectors helper > git bisect bad 5f4e505909fe50a4e256704076594ee3def0b9b1 > # good: [b9c3401f7cac6ae291a16784dadcd1bf116218fe] x86/kprobes: Update kcb status flag after singlestepping > git bisect good b9c3401f7cac6ae291a16784dadcd1bf116218fe > # bad: [73ce2046e04ad488cecc66757c36cbe1bdf089d4] iommu/vt-d: avoid invalid memory access via node_online(NUMA_NO_NODE) > git bisect bad 73ce2046e04ad488cecc66757c36cbe1bdf089d4 > # good: [f624c94ad56b663693a9413d8c8c03635435f369] drm/vc4: drv: Adopt the dma configuration from the HVS or V3D component > git bisect good f624c94ad56b663693a9413d8c8c03635435f369 > # bad: [87c4896d5dd7fd9927c814cf3c6289f41de3b562] firmware: arm_scpi: Ensure scpi_info is not assigned if the probe fails > git bisect bad 87c4896d5dd7fd9927c814cf3c6289f41de3b562 > # good: [9b61971cab92a918cab7168d439a351b1c799aca] usbnet: smsc95xx: Avoid link settings race on interrupt reception > git bisect good 9b61971cab92a918cab7168d439a351b1c799aca > # bad: [e81395cfbe62518f41af79a1b287fc8fe7c96b37] usbnet: smsc95xx: Fix deadlock on runtime resume > git bisect bad e81395cfbe62518f41af79a1b287fc8fe7c96b37 > # bad: [7eea9a60703caf1b04eccba93cd103f1c8fc6809] usbnet: smsc95xx: Forward PHY interrupts to PHY driver to avoid polling > git bisect bad 7eea9a60703caf1b04eccba93cd103f1c8fc6809 > # first bad commit: [7eea9a60703caf1b04eccba93cd103f1c8fc6809] usbnet: smsc95xx: Forward PHY interrupts to PHY driver to avoid polling > ------------------------------------------------------------------------------- > > > -=-=-=-=-=-=-=-=-=-=-=- > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#30878): https://groups.io/g/kernelci-results/message/30878 > Mute This Topic: https://groups.io/mt/93235418/1131744 > Group Owner: kernelci-results+owner(a)groups.io > Unsubscribe: https://groups.io/g/kernelci-results/unsub [broonie(a)kernel.org] > -=-=-=-=-=-=-=-=-=-=-=- > >

2 years, 4 months

2
1
0 0

[PATCH ghak138] audit: move audit_return_fixup before the filters

by Richard Guy Briggs

The success and return_code are needed by the filters. Move audit_return_fixup() before the filters. The pid member of struct audit_context is never used. Remove it. The audit_reset_context() comment about unconditionally resetting "ctx->state" should read "ctx->context". The proctitle is intentionally stored between syscalls. Only free it in audit_free_context(). Be explicit in checking the struct audit_context "context" member enum value rather than assuming the order of context enum values. Cc: stable(a)vger.kernel.org Fixes: 12c5e81d3fd0 ("audit: prepare audit_context for use in calling contexts beyond syscalls") Signed-off-by: Richard Guy Briggs <rgb(a)redhat.com> --- kernel/audit.h | 2 +- kernel/auditsc.c | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/kernel/audit.h b/kernel/audit.h index 58b66543b4d5..d6eb7b59c791 100644 --- a/kernel/audit.h +++ b/kernel/audit.h @@ -133,7 +133,7 @@ struct audit_context { struct sockaddr_storage *sockaddr; size_t sockaddr_len; /* Save things to print about task_struct */ - pid_t pid, ppid; + pid_t ppid; kuid_t uid, euid, suid, fsuid; kgid_t gid, egid, sgid, fsgid; unsigned long personality; diff --git a/kernel/auditsc.c b/kernel/auditsc.c index 9226746dcf0a..9f8c05228d6d 100644 --- a/kernel/auditsc.c +++ b/kernel/auditsc.c @@ -965,7 +965,7 @@ static void audit_reset_context(struct audit_context *ctx) if (!ctx) return; - /* if ctx is non-null, reset the "ctx->state" regardless */ + /* if ctx is non-null, reset the "ctx->context" regardless */ ctx->context = AUDIT_CTX_UNUSED; if (ctx->dummy) return; @@ -1002,7 +1002,7 @@ static void audit_reset_context(struct audit_context *ctx) kfree(ctx->sockaddr); ctx->sockaddr = NULL; ctx->sockaddr_len = 0; - ctx->pid = ctx->ppid = 0; + ctx->ppid = 0; ctx->uid = ctx->euid = ctx->suid = ctx->fsuid = KUIDT_INIT(0); ctx->gid = ctx->egid = ctx->sgid = ctx->fsgid = KGIDT_INIT(0); ctx->personality = 0; @@ -1016,7 +1016,6 @@ static void audit_reset_context(struct audit_context *ctx) WARN_ON(!list_empty(&ctx->killed_trees)); audit_free_module(ctx); ctx->fds[0] = -1; - audit_proctitle_free(ctx); ctx->type = 0; /* reset last for audit_free_*() */ } @@ -1077,6 +1076,7 @@ static inline void audit_free_context(struct audit_context *context) { /* resetting is extra work, but it is likely just noise */ audit_reset_context(context); + audit_proctitle_free(context); free_tree_refs(context); kfree(context->filterkey); kfree(context); @@ -1940,6 +1940,7 @@ void __audit_uring_exit(int success, long code) goto out; } + audit_return_fixup(ctx, success, code); if (ctx->context == AUDIT_CTX_SYSCALL) { /* * NOTE: See the note in __audit_uring_entry() about the case @@ -1981,7 +1982,6 @@ void __audit_uring_exit(int success, long code) audit_filter_inodes(current, ctx); if (ctx->current_state != AUDIT_STATE_RECORD) goto out; - audit_return_fixup(ctx, success, code); audit_log_exit(); out: @@ -2065,13 +2065,13 @@ void __audit_syscall_exit(int success, long return_code) if (!list_empty(&context->killed_trees)) audit_kill_trees(context); + audit_return_fixup(context, success, return_code); /* run through both filters to ensure we set the filterkey properly */ audit_filter_syscall(current, context); audit_filter_inodes(current, context); - if (context->current_state < AUDIT_STATE_RECORD) + if (context->current_state != AUDIT_STATE_RECORD) goto out; - audit_return_fixup(context, success, return_code); audit_log_exit(); out: -- 2.27.0

2 years, 4 months

1
0
0 0

[PATCH AUTOSEL 4.9 1/3] s390/hypfs: avoid error message under KVM

by Sasha Levin

From: Juergen Gross <jgross(a)suse.com> [ Upstream commit 7b6670b03641ac308aaa6fa2e6f964ac993b5ea3 ] When booting under KVM the following error messages are issued: hypfs.7f5705: The hardware system does not support hypfs hypfs.7a79f0: Initialization of hypfs failed with rc=-61 Demote the severity of first message from "error" to "info" and issue the second message only in other error cases. Signed-off-by: Juergen Gross <jgross(a)suse.com> Acked-by: Heiko Carstens <hca(a)linux.ibm.com> Acked-by: Christian Borntraeger <borntraeger(a)linux.ibm.com> Link: https://lore.kernel.org/r/20220620094534.18967-1-jgross@suse.com [arch/s390/hypfs/hypfs_diag.c changed description] Signed-off-by: Alexander Gordeev <agordeev(a)linux.ibm.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- arch/s390/hypfs/hypfs_diag.c | 2 +- arch/s390/hypfs/inode.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/s390/hypfs/hypfs_diag.c b/arch/s390/hypfs/hypfs_diag.c index 794bebb43d23..64448c0998eb 100644 --- a/arch/s390/hypfs/hypfs_diag.c +++ b/arch/s390/hypfs/hypfs_diag.c @@ -436,7 +436,7 @@ __init int hypfs_diag_init(void) int rc; if (diag204_probe()) { - pr_err("The hardware system does not support hypfs\n"); + pr_info("The hardware system does not support hypfs\n"); return -ENODATA; } if (diag204_info_type == DIAG204_INFO_EXT) { diff --git a/arch/s390/hypfs/inode.c b/arch/s390/hypfs/inode.c index 224aeda1e8cc..d73d2d001a62 100644 --- a/arch/s390/hypfs/inode.c +++ b/arch/s390/hypfs/inode.c @@ -493,9 +493,9 @@ static int __init hypfs_init(void) hypfs_vm_exit(); fail_hypfs_diag_exit: hypfs_diag_exit(); + pr_err("Initialization of hypfs failed with rc=%i\n", rc); fail_dbfs_exit: hypfs_dbfs_exit(); - pr_err("Initialization of hypfs failed with rc=%i\n", rc); return rc; } -- 2.35.1

2 years, 4 months

1
2
0 0

[PATCH AUTOSEL 4.14 1/4] neigh: fix possible DoS due to net iface start/stop loop

by Sasha Levin

From: "Denis V. Lunev" <den(a)openvz.org> [ Upstream commit 66ba215cb51323e4e55e38fd5f250e0fae0cbc94 ] Normal processing of ARP request (usually this is Ethernet broadcast packet) coming to the host is looking like the following: * the packet comes to arp_process() call and is passed through routing procedure * the request is put into the queue using pneigh_enqueue() if corresponding ARP record is not local (common case for container records on the host) * the request is processed by timer (within 80 jiffies by default) and ARP reply is sent from the same arp_process() using NEIGH_CB(skb)->flags & LOCALLY_ENQUEUED condition (flag is set inside pneigh_enqueue()) And here the problem comes. Linux kernel calls pneigh_queue_purge() which destroys the whole queue of ARP requests on ANY network interface start/stop event through __neigh_ifdown(). This is actually not a problem within the original world as network interface start/stop was accessible to the host 'root' only, which could do more destructive things. But the world is changed and there are Linux containers available. Here container 'root' has an access to this API and could be considered as untrusted user in the hosting (container's) world. Thus there is an attack vector to other containers on node when container's root will endlessly start/stop interfaces. We have observed similar situation on a real production node when docker container was doing such activity and thus other containers on the node become not accessible. The patch proposed doing very simple thing. It drops only packets from the same namespace in the pneigh_queue_purge() where network interface state change is detected. This is enough to prevent the problem for the whole node preserving original semantics of the code. v2: - do del_timer_sync() if queue is empty after pneigh_queue_purge() v3: - rebase to net tree Cc: "David S. Miller" <davem(a)davemloft.net> Cc: Eric Dumazet <edumazet(a)google.com> Cc: Jakub Kicinski <kuba(a)kernel.org> Cc: Paolo Abeni <pabeni(a)redhat.com> Cc: Daniel Borkmann <daniel(a)iogearbox.net> Cc: David Ahern <dsahern(a)kernel.org> Cc: Yajun Deng <yajun.deng(a)linux.dev> Cc: Roopa Prabhu <roopa(a)nvidia.com> Cc: Christian Brauner <brauner(a)kernel.org> Cc: netdev(a)vger.kernel.org Cc: linux-kernel(a)vger.kernel.org Cc: Alexey Kuznetsov <kuznet(a)ms2.inr.ac.ru> Cc: Alexander Mikhalitsyn <alexander.mikhalitsyn(a)virtuozzo.com> Cc: Konstantin Khorenko <khorenko(a)virtuozzo.com> Cc: kernel(a)openvz.org Cc: devel(a)openvz.org Investigated-by: Alexander Mikhalitsyn <alexander.mikhalitsyn(a)virtuozzo.com> Signed-off-by: Denis V. Lunev <den(a)openvz.org> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- net/core/neighbour.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 358e84af0210..8af9761768e0 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -222,14 +222,23 @@ static int neigh_del_timer(struct neighbour *n) return 0; } -static void pneigh_queue_purge(struct sk_buff_head *list) +static void pneigh_queue_purge(struct sk_buff_head *list, struct net *net) { + unsigned long flags; struct sk_buff *skb; - while ((skb = skb_dequeue(list)) != NULL) { - dev_put(skb->dev); - kfree_skb(skb); + spin_lock_irqsave(&list->lock, flags); + skb = skb_peek(list); + while (skb != NULL) { + struct sk_buff *skb_next = skb_peek_next(skb, list); + if (net == NULL || net_eq(dev_net(skb->dev), net)) { + __skb_unlink(skb, list); + dev_put(skb->dev); + kfree_skb(skb); + } + skb = skb_next; } + spin_unlock_irqrestore(&list->lock, flags); } static void neigh_flush_dev(struct neigh_table *tbl, struct net_device *dev) @@ -295,9 +304,9 @@ int neigh_ifdown(struct neigh_table *tbl, struct net_device *dev) write_lock_bh(&tbl->lock); neigh_flush_dev(tbl, dev); pneigh_ifdown_and_unlock(tbl, dev); - - del_timer_sync(&tbl->proxy_timer); - pneigh_queue_purge(&tbl->proxy_queue); + pneigh_queue_purge(&tbl->proxy_queue, dev_net(dev)); + if (skb_queue_empty_lockless(&tbl->proxy_queue)) + del_timer_sync(&tbl->proxy_timer); return 0; } EXPORT_SYMBOL(neigh_ifdown); @@ -1609,7 +1618,7 @@ int neigh_table_clear(int index, struct neigh_table *tbl) /* It is not clean... Fix it to unload IPv6 module safely */ cancel_delayed_work_sync(&tbl->gc_work); del_timer_sync(&tbl->proxy_timer); - pneigh_queue_purge(&tbl->proxy_queue); + pneigh_queue_purge(&tbl->proxy_queue, NULL); neigh_ifdown(tbl, NULL); if (atomic_read(&tbl->entries)) pr_crit("neighbour leakage\n"); -- 2.35.1

2 years, 4 months

1
3
0 0

[PATCH AUTOSEL 4.19 1/5] drm/amd/display: clear optc underflow before turn off odm clock

by Sasha Levin

From: Fudong Wang <Fudong.Wang(a)amd.com> [ Upstream commit b2a93490201300a749ad261b5c5d05cb50179c44 ] [Why] After ODM clock off, optc underflow bit will be kept there always and clear not work. We need to clear that before clock off. [How] Clear that if have when clock off. Reviewed-by: Alvin Lee <alvin.lee2(a)amd.com> Acked-by: Tom Chung <chiahsuan.chung(a)amd.com> Signed-off-by: Fudong Wang <Fudong.Wang(a)amd.com> Tested-by: Daniel Wheeler <daniel.wheeler(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c index 411f89218e01..cb5c44b339e0 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c @@ -452,6 +452,11 @@ void optc1_enable_optc_clock(struct timing_generator *optc, bool enable) OTG_CLOCK_ON, 1, 1, 1000); } else { + + //last chance to clear underflow, otherwise, it will always there due to clock is off. + if (optc->funcs->is_optc_underflow_occurred(optc) == true) + optc->funcs->clear_optc_underflow(optc); + REG_UPDATE_2(OTG_CLOCK_CONTROL, OTG_CLOCK_GATE_DIS, 0, OTG_CLOCK_EN, 0); -- 2.35.1

2 years, 4 months

1
4
0 0

[PATCH AUTOSEL 5.4 1/8] drm/amd/display: Avoid MPC infinite loop

by Sasha Levin

From: Josip Pavic <Josip.Pavic(a)amd.com> [ Upstream commit 8de297dc046c180651c0500f8611663ae1c3828a ] [why] In some cases MPC tree bottom pipe ends up point to itself. This causes iterating from top to bottom to hang the system in an infinite loop. [how] When looping to next MPC bottom pipe, check that the pointer is not same as current to avoid infinite loop. Reviewed-by: Josip Pavic <Josip.Pavic(a)amd.com> Reviewed-by: Jun Lei <Jun.Lei(a)amd.com> Acked-by: Alex Hung <alex.hung(a)amd.com> Signed-off-by: Aric Cyr <aric.cyr(a)amd.com> Tested-by: Daniel Wheeler <daniel.wheeler(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c | 6 ++++++ drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c index 8b2f29f6dabd..068e79fa3490 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c @@ -118,6 +118,12 @@ struct mpcc *mpc1_get_mpcc_for_dpp(struct mpc_tree *tree, int dpp_id) while (tmp_mpcc != NULL) { if (tmp_mpcc->dpp_id == dpp_id) return tmp_mpcc; + + /* avoid circular linked list */ + ASSERT(tmp_mpcc != tmp_mpcc->mpcc_bot); + if (tmp_mpcc == tmp_mpcc->mpcc_bot) + break; + tmp_mpcc = tmp_mpcc->mpcc_bot; } return NULL; diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c index 5a188b2bc033..0a00bd8e00ab 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c @@ -488,6 +488,12 @@ struct mpcc *mpc2_get_mpcc_for_dpp(struct mpc_tree *tree, int dpp_id) while (tmp_mpcc != NULL) { if (tmp_mpcc->dpp_id == 0xf || tmp_mpcc->dpp_id == dpp_id) return tmp_mpcc; + + /* avoid circular linked list */ + ASSERT(tmp_mpcc != tmp_mpcc->mpcc_bot); + if (tmp_mpcc == tmp_mpcc->mpcc_bot) + break; + tmp_mpcc = tmp_mpcc->mpcc_bot; } return NULL; -- 2.35.1

2 years, 4 months

1
7
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror August 2022