July 2022 - Linux-stable-mirror

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.9.324 release. There are 28 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 21 Jul 2022 11:43:40 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.324-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.9.324-rc1 Marc Kleine-Budde <mkl(a)pengutronix.de> can: m_can: m_can_tx_handler(): fix use after free of skb Rik van Riel <riel(a)surriel.com> mm: invalidate hwpoison page cache page in fault path Yi Yang <yiyang13(a)huawei.com> serial: 8250: fix return error code in serial8250_request_std_resource() Chanho Park <chanho61.park(a)samsung.com> tty: serial: samsung_tty: set dma burst_size to 1 Thinh Nguyen <Thinh.Nguyen(a)synopsys.com> usb: dwc3: gadget: Fix event pending check Lucien Buchmann <lucien.buchmann(a)gmx.net> USB: serial: ftdi_sio: add Belimo device ids Linus Torvalds <torvalds(a)linux-foundation.org> signal handling: don't use BUG_ON() for debugging Juergen Gross <jgross(a)suse.com> x86: Clear .brk area at early boot Charles Keepax <ckeepax(a)opensource.cirrus.com> ASoC: wm5110: Fix DRE control Mark Brown <broonie(a)kernel.org> ASoC: ops: Fix off by one in range control validation Michael Walle <michael(a)walle.cc> NFC: nxp-nci: don't print header length mismatch on i2c error Hangyu Hua <hbh25y(a)gmail.com> net: tipc: fix possible refcount leak in tipc_sk_create() Liang He <windhl(a)126.com> cpufreq: pmac32-cpufreq: Fix refcount leak bug Stephan Gerhold <stephan.gerhold(a)kernkonzept.com> virtio_mmio: Restore guest page size on resume Stephan Gerhold <stephan.gerhold(a)kernkonzept.com> virtio_mmio: Add missing PM calls to freeze/restore Íñigo Huguet <ihuguet(a)redhat.com> sfc: fix kernel panic when creating VF Íñigo Huguet <ihuguet(a)redhat.com> sfc: fix use after free when disabling sriov Kuniyuki Iwashima <kuniyu(a)amazon.com> ipv4: Fix data-races around sysctl_ip_dynaddr. Kuniyuki Iwashima <kuniyu(a)amazon.com> icmp: Fix data-races around sysctl. Kuniyuki Iwashima <kuniyu(a)amazon.com> cipso: Fix data-races around sysctl. Ard Biesheuvel <ardb(a)kernel.org> ARM: 9209/1: Spectre-BHB: avoid pr_info() every time a CPU comes out of idle Doug Berger <opendmb(a)gmail.com> net: dsa: bcm_sf2: force pause link settings Ryusuke Konishi <konishi.ryusuke(a)gmail.com> nilfs2: fix incorrect masking of permission flags for symlinks Dmitry Osipenko <dmitry.osipenko(a)collabora.com> ARM: 9213/1: Print message about disabled Spectre workarounds only once Steven Rostedt (Google) <rostedt(a)goodmis.org> net: sock: tracing: Fix sock_exceed_buf_limit not to dereference stale pointer Juergen Gross <jgross(a)suse.com> xen/netback: avoid entering xenvif_rx_next_skb() with an empty rx queue Meng Tang <tangmeng(a)uniontech.com> ALSA: hda - Add fixup for Dell Latitidue E5430 James Morse <james.morse(a)arm.com> arm64: entry: Restore tramp_map_kernel ISB ------------- Diffstat: Documentation/networking/ip-sysctl.txt | 4 ++-- Makefile | 4 ++-- arch/arm/mm/proc-v7-bugs.c | 9 ++++----- arch/arm64/kernel/entry.S | 1 + arch/x86/kernel/head64.c | 2 ++ drivers/cpufreq/pmac32-cpufreq.c | 4 ++++ drivers/net/can/m_can/m_can.c | 5 +++-- drivers/net/dsa/bcm_sf2.c | 19 +++++++++++++++++++ drivers/net/ethernet/sfc/ef10.c | 3 +++ drivers/net/ethernet/sfc/ef10_sriov.c | 10 +++++++--- drivers/net/xen-netback/rx.c | 1 + drivers/nfc/nxp-nci/i2c.c | 8 ++++++-- drivers/tty/serial/8250/8250_port.c | 4 +++- drivers/tty/serial/samsung.c | 5 ++--- drivers/usb/dwc3/gadget.c | 4 +++- drivers/usb/serial/ftdi_sio.c | 3 +++ drivers/usb/serial/ftdi_sio_ids.h | 6 ++++++ drivers/virtio/virtio_mmio.c | 26 ++++++++++++++++++++++++++ fs/nilfs2/nilfs.h | 3 +++ include/trace/events/sock.h | 6 ++++-- kernel/signal.c | 8 ++++---- mm/memory.c | 9 +++++++-- net/ipv4/af_inet.c | 4 ++-- net/ipv4/cipso_ipv4.c | 12 +++++++----- net/ipv4/icmp.c | 5 +++-- net/tipc/socket.c | 1 + sound/pci/hda/patch_realtek.c | 1 + sound/soc/codecs/wm5110.c | 8 ++++++-- sound/soc/soc-ops.c | 4 ++-- 29 files changed, 137 insertions(+), 42 deletions(-)

2 years, 5 months

5
32
0 0

[PATCH 4.14 00/43] 4.14.289-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.14.289 release. There are 43 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 21 Jul 2022 11:43:40 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.289-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.14.289-rc1 Marc Kleine-Budde <mkl(a)pengutronix.de> can: m_can: m_can_tx_handler(): fix use after free of skb Rik van Riel <riel(a)surriel.com> mm: invalidate hwpoison page cache page in fault path Yi Yang <yiyang13(a)huawei.com> serial: 8250: fix return error code in serial8250_request_std_resource() Chanho Park <chanho61.park(a)samsung.com> tty: serial: samsung_tty: set dma burst_size to 1 Thinh Nguyen <Thinh.Nguyen(a)synopsys.com> usb: dwc3: gadget: Fix event pending check Lucien Buchmann <lucien.buchmann(a)gmx.net> USB: serial: ftdi_sio: add Belimo device ids Linus Torvalds <torvalds(a)linux-foundation.org> signal handling: don't use BUG_ON() for debugging Juergen Gross <jgross(a)suse.com> x86: Clear .brk area at early boot Stafford Horne <shorne(a)gmail.com> irqchip: or1k-pic: Undefine mask_ack for level triggered hardware Charles Keepax <ckeepax(a)opensource.cirrus.com> ASoC: wm5110: Fix DRE control Mark Brown <broonie(a)kernel.org> ASoC: ops: Fix off by one in range control validation Jianglei Nie <niejianglei2021(a)163.com> net: sfp: fix memory leak in sfp_probe() Michael Walle <michael(a)walle.cc> NFC: nxp-nci: don't print header length mismatch on i2c error Hangyu Hua <hbh25y(a)gmail.com> net: tipc: fix possible refcount leak in tipc_sk_create() Kai-Heng Feng <kai.heng.feng(a)canonical.com> platform/x86: hp-wmi: Ignore Sanitization Mode event Liang He <windhl(a)126.com> cpufreq: pmac32-cpufreq: Fix refcount leak bug Florian Westphal <fw(a)strlen.de> netfilter: br_netfilter: do not skip all hooks with 0 priority Stephan Gerhold <stephan.gerhold(a)kernkonzept.com> virtio_mmio: Restore guest page size on resume Stephan Gerhold <stephan.gerhold(a)kernkonzept.com> virtio_mmio: Add missing PM calls to freeze/restore Íñigo Huguet <ihuguet(a)redhat.com> sfc: fix kernel panic when creating VF Andrea Mayer <andrea.mayer(a)uniroma2.it> seg6: fix skb checksum in SRv6 End.B6 and End.B6.Encaps behaviors Andrea Mayer <andrea.mayer(a)uniroma2.it> seg6: fix skb checksum evaluation in SRH encapsulation/insertion Íñigo Huguet <ihuguet(a)redhat.com> sfc: fix use after free when disabling sriov Kuniyuki Iwashima <kuniyu(a)amazon.com> ipv4: Fix data-races around sysctl_ip_dynaddr. Kuniyuki Iwashima <kuniyu(a)amazon.com> icmp: Fix a data-race around sysctl_icmp_ratemask. Kuniyuki Iwashima <kuniyu(a)amazon.com> icmp: Fix a data-race around sysctl_icmp_ratelimit. Michal Suchanek <msuchanek(a)suse.de> ARM: dts: sunxi: Fix SPI NOR campatible on Orange Pi Zero Kuniyuki Iwashima <kuniyu(a)amazon.com> icmp: Fix data-races around sysctl. Kuniyuki Iwashima <kuniyu(a)amazon.com> cipso: Fix data-races around sysctl. Kuniyuki Iwashima <kuniyu(a)amazon.com> net: Fix data-races around sysctl_mem. Kuniyuki Iwashima <kuniyu(a)amazon.com> inetpeer: Fix data-races around sysctl. Ard Biesheuvel <ardb(a)kernel.org> ARM: 9209/1: Spectre-BHB: avoid pr_info() every time a CPU comes out of idle Mathias Nyman <mathias.nyman(a)linux.intel.com> xhci: make xhci_handshake timeout for xhci_reset() adjustable Mathias Nyman <mathias.nyman(a)linux.intel.com> xhci: bail out early if driver can't accress host in resume Doug Berger <opendmb(a)gmail.com> net: dsa: bcm_sf2: force pause link settings Ryusuke Konishi <konishi.ryusuke(a)gmail.com> nilfs2: fix incorrect masking of permission flags for symlinks Tejun Heo <tj(a)kernel.org> cgroup: Use separate src/dst nodes when preloading css_sets for migration Ard Biesheuvel <ardb(a)kernel.org> ARM: 9214/1: alignment: advance IT state after emulating Thumb instruction Dmitry Osipenko <dmitry.osipenko(a)collabora.com> ARM: 9213/1: Print message about disabled Spectre workarounds only once Steven Rostedt (Google) <rostedt(a)goodmis.org> net: sock: tracing: Fix sock_exceed_buf_limit not to dereference stale pointer Juergen Gross <jgross(a)suse.com> xen/netback: avoid entering xenvif_rx_next_skb() with an empty rx queue Meng Tang <tangmeng(a)uniontech.com> ALSA: hda/conexant: Apply quirk for another HP ProDesk 600 G3 model Meng Tang <tangmeng(a)uniontech.com> ALSA: hda - Add fixup for Dell Latitidue E5430 ------------- Diffstat: Documentation/networking/ip-sysctl.txt | 4 +-- Makefile | 4 +-- arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 2 +- arch/arm/include/asm/ptrace.h | 26 ++++++++++++++++ arch/arm/mm/alignment.c | 3 ++ arch/arm/mm/proc-v7-bugs.c | 9 +++--- arch/arm/probes/decode.h | 26 +--------------- arch/x86/kernel/head64.c | 2 ++ drivers/cpufreq/pmac32-cpufreq.c | 4 +++ drivers/irqchip/irq-or1k-pic.c | 1 - drivers/net/can/m_can/m_can.c | 5 +-- drivers/net/dsa/bcm_sf2.c | 19 ++++++++++++ drivers/net/ethernet/sfc/ef10.c | 3 ++ drivers/net/ethernet/sfc/ef10_sriov.c | 10 ++++-- drivers/net/phy/sfp.c | 2 +- drivers/net/xen-netback/rx.c | 1 + drivers/nfc/nxp-nci/i2c.c | 8 +++-- drivers/platform/x86/hp-wmi.c | 3 ++ drivers/tty/serial/8250/8250_port.c | 4 ++- drivers/tty/serial/samsung.c | 5 ++- drivers/usb/dwc3/gadget.c | 4 ++- drivers/usb/host/xhci-hub.c | 2 +- drivers/usb/host/xhci-mem.c | 2 +- drivers/usb/host/xhci.c | 22 +++++++------- drivers/usb/host/xhci.h | 7 +++-- drivers/usb/serial/ftdi_sio.c | 3 ++ drivers/usb/serial/ftdi_sio_ids.h | 6 ++++ drivers/virtio/virtio_mmio.c | 26 ++++++++++++++++ fs/nilfs2/nilfs.h | 3 ++ include/linux/cgroup-defs.h | 3 +- include/net/sock.h | 2 +- include/trace/events/sock.h | 6 ++-- kernel/cgroup/cgroup.c | 37 ++++++++++++++--------- kernel/signal.c | 8 ++--- mm/memory.c | 9 ++++-- net/bridge/br_netfilter_hooks.c | 21 +++++++++++-- net/ipv4/af_inet.c | 4 +-- net/ipv4/cipso_ipv4.c | 12 +++++--- net/ipv4/icmp.c | 10 +++--- net/ipv4/inetpeer.c | 12 +++++--- net/ipv6/seg6_iptunnel.c | 5 ++- net/ipv6/seg6_local.c | 2 -- net/tipc/socket.c | 1 + sound/pci/hda/patch_conexant.c | 1 + sound/pci/hda/patch_realtek.c | 1 + sound/soc/codecs/wm5110.c | 8 +++-- sound/soc/soc-ops.c | 4 +-- 47 files changed, 249 insertions(+), 113 deletions(-)

2 years, 5 months

4
46
0 0

[PATCH v2 1/3] btrfs: enhance unsupported compat RO flags handling

by Qu Wenruo

Currently there are two corner cases not handling compat RO flags correctly: - Remount We can still mount the fs RO with compat RO flags, then remount it RW. We should not allow any write into a fs with unsupported RO flags. - Still try to search block group items In fact, behavior/on-disk format change to extent tree should not need a full incompat flag. And since we can ensure fs with unsupported RO flags never got any writes (with above case fixed), then we can even skip block group items search at mount time. This patch will enhance the unsupported RO compat flags by: - Reject RW remount if there is unsupported RO compat flags - Go dummy block group items directly for unsupported RO compat flags In fact, only changes to chunk/subvolume/root/csum trees should go incompat flags. The latter part should allow future change to extent tree to be compat RO flags. Thus this patch also needs to be backported to all stable trees. Cc: stable(a)vger.kernel.org Signed-off-by: Qu Wenruo <wqu(a)suse.com> --- fs/btrfs/block-group.c | 11 ++++++++++- fs/btrfs/super.c | 9 +++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c index c9475219c70c..88d23d6760f0 100644 --- a/fs/btrfs/block-group.c +++ b/fs/btrfs/block-group.c @@ -2206,7 +2206,16 @@ int btrfs_read_block_groups(struct btrfs_fs_info *info) int need_clear = 0; u64 cache_gen; - if (!root) + /* + * Either no extent root (with ibadroots rescue option) or we have + * unsupporter RO options. The fs can never be mounted RW, so no + * need to waste time search block group items. + * + * This also allows new extent tree related changes to be RO compat, + * no need for a full incompat flag. + */ + if (!root || (btrfs_super_compat_ro_flags(info->super_copy) & + ~BTRFS_FEATURE_COMPAT_RO_SUPP)) return fill_dummy_bgs(info); key.objectid = 0; diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 4c7089b1681b..7d3213e67fb5 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -2110,6 +2110,15 @@ static int btrfs_remount(struct super_block *sb, int *flags, char *data) ret = -EINVAL; goto restore; } + if (btrfs_super_compat_ro_flags(fs_info->super_copy) & + ~BTRFS_FEATURE_COMPAT_RO_SUPP) { + btrfs_err(fs_info, + "can not remount read-write due to unsupported optional flags 0x%llx", + btrfs_super_compat_ro_flags(fs_info->super_copy) & + ~BTRFS_FEATURE_COMPAT_RO_SUPP); + ret = -EINVAL; + goto restore; + } if (fs_info->fs_devices->rw_devices == 0) { ret = -EACCES; goto restore; -- 2.37.0

2 years, 5 months

2
1
0 0

[PATCH net] mlxsw: spectrum_router: Fix IPv4 nexthop gateway indication

by Ido Schimmel

mlxsw needs to distinguish nexthops with a gateway from connected nexthops in order to write the former to the adjacency table of the device. The check used to rely on the fact that nexthops with a gateway have a 'link' scope whereas connected nexthops have a 'host' scope. This is no longer correct after commit 747c14307214 ("ip: fix dflt addr selection for connected nexthop"). Fix that by instead checking the address family of the gateway IP. This is a more direct way and also consistent with the IPv6 counterpart in mlxsw_sp_rt6_is_gateway(). Cc: stable(a)vger.kernel.org Fixes: 747c14307214 ("ip: fix dflt addr selection for connected nexthop") Fixes: 597cfe4fc339 ("nexthop: Add support for IPv4 nexthops") Signed-off-by: Ido Schimmel <idosch(a)nvidia.com> Reviewed-by: Amit Cohen <amcohen(a)nvidia.com> --- Copied stable since Nicolas' patch has stable copied and I don't want stable trees to have his patch, but not mine. To make it clear how far this patch needs to be backported, I have included the same Fixes tag as him. --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c index 23d526f13f1c..abc0096a20a9 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c @@ -5292,7 +5292,7 @@ static bool mlxsw_sp_fi_is_gateway(const struct mlxsw_sp *mlxsw_sp, { const struct fib_nh *nh = fib_info_nh(fi, 0); - return nh->fib_nh_scope == RT_SCOPE_LINK || + return nh->fib_nh_gw_family || mlxsw_sp_nexthop4_ipip_type(mlxsw_sp, nh, NULL); } -- 2.36.1

2 years, 5 months

4
3
0 0

[PATCH v3 5.18 0/2] Backport support for Telit FN980 v1 and FN990

by Fabio Porcedda

Hi, these two patches are the backport for 5.18.y of the following commits: commit a96ef8b504efb2ad445dfb6d54f9488c3ddf23d2 bus: mhi: host: pci_generic: add Telit FN980 v1 hardware revisio commit 77fc41204734042861210b9d05338c9b8360affb bus: mhi: host: pci_generic: add Telit FN990 The cherry-pick of the original commits don't apply because the commit 89ad19bea649 (bus: mhi: host: pci_generic: Sort mhi_pci_id_table based on the PID, 2022-04-11) was not cherry-picked. Another solution is to cherry-pick those three commits all togheter. Thanks! v3: - fixed typo in the cover letter 3.18.y -> 5.18.y v2: - fixed my email Daniele Palmas (2): bus: mhi: host: pci_generic: add Telit FN980 v1 hardware revision bus: mhi: host: pci_generic: add Telit FN990 drivers/bus/mhi/pci_generic.c | 79 +++++++++++++++++++++++++++++++++++ 1 file changed, 79 insertions(+) -- 2.37.1

2 years, 5 months

1
3
0 0

[PATCH 4.19] ext4: fix race condition between ext4_ioctl_setflags and ext4_fiemap

by Baokun Li

This patch and problem analysis is based on v4.19 LTS. The d3b6f23f7167("ext4: move ext4_fiemap to use iomap framework") patch is incorporated in v5.7-rc1. This patch avoids this problem by switching to iomap in ext4_fiemap. Hulk Robot reported a BUG on stable 4.19.252: ================================================================== kernel BUG at fs/ext4/extents_status.c:762! invalid opcode: 0000 [#1] SMP KASAN PTI CPU: 7 PID: 2845 Comm: syz-executor Not tainted 4.19.252 #46 RIP: 0010:ext4_es_cache_extent+0x30e/0x370 [...] Call Trace: ext4_cache_extents+0x238/0x2f0 ext4_find_extent+0x785/0xa40 ext4_fiemap+0x36d/0xe90 do_vfs_ioctl+0x6af/0x1200 [...] ================================================================== Above issue may happen as follows: ------------------------------------- cpu1 cpu2 _____________________|_____________________ do_vfs_ioctl ext4_ioctl ext4_ioctl_setflags ext4_ind_migrate do_vfs_ioctl ioctl_fiemap ext4_fiemap ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS) ext4_fill_fiemap_extents down_write(&EXT4_I(inode)->i_data_sem); ext4_ext_check_inode ext4_clear_inode_flag(inode, EXT4_INODE_EXTENTS) memset(ei->i_data, 0, sizeof(ei->i_data)) up_write(&EXT4_I(inode)->i_data_sem); down_read(&EXT4_I(inode)->i_data_sem); ext4_find_extent ext4_cache_extents ext4_es_cache_extent BUG_ON(end < lblk) We can easily reproduce this problem with the syzkaller testcase: ``` 02:37:07 executing program 3: r0 = openat(0xffffffffffffff9c, &(0x7f0000000040)='./file0\x00', 0x26e1, 0x0) ioctl$FS_IOC_FSSETXATTR(r0, 0x40086602, &(0x7f0000000080)={0x17e}) mkdirat(0xffffffffffffff9c, &(0x7f00000000c0)='./file1\x00', 0x1ff) r1 = openat(0xffffffffffffff9c, &(0x7f0000000100)='./file1\x00', 0x0, 0x0) ioctl$FS_IOC_FIEMAP(r1, 0xc020660b, &(0x7f0000000180)={0x0, 0x1, 0x0, 0xef3, 0x6, []}) (async, rerun: 32) ioctl$FS_IOC_FSSETXATTR(r1, 0x40086602, &(0x7f0000000140)={0x17e}) (rerun: 32) ``` To solve this issue, we use __generic_block_fiemap() instead of generic_block_fiemap() and add inode_lock_shared to avoid race condition. Reported-by: Hulk Robot <hulkci(a)huawei.com> Signed-off-by: Baokun Li <libaokun1(a)huawei.com> --- fs/ext4/extents.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 6c492fca60c4..38aaf48e94cb 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -5198,13 +5198,18 @@ int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, return error; } + inode_lock_shared(inode); /* fallback to generic here if not in extents fmt */ - if (!(ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))) - return generic_block_fiemap(inode, fieinfo, start, len, + if (!(ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))) { + error = __generic_block_fiemap(inode, fieinfo, start, len, ext4_get_block); + goto out_unlock; + } - if (fiemap_check_flags(fieinfo, EXT4_FIEMAP_FLAGS)) - return -EBADR; + if (fiemap_check_flags(fieinfo, EXT4_FIEMAP_FLAGS)) { + error = -EBADR; + goto out_unlock; + } if (fieinfo->fi_flags & FIEMAP_FLAG_XATTR) { error = ext4_xattr_fiemap(inode, fieinfo); @@ -5225,6 +5230,8 @@ int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, error = ext4_fill_fiemap_extents(inode, start_blk, len_blks, fieinfo); } +out_unlock: + inode_unlock_shared(inode); return error; } -- 2.31.1

2 years, 5 months

3
10
0 0

warning: stable kernel rule is not satisfied

by kernel test robot

Hi, Thanks for your patch. FYI: kernel test robot notices the stable kernel rule is not satisfied. Rule: 'Cc: stable(a)vger.kernel.org' or 'commit <sha1> upstream.' Subject: [PATCH] lockdown: Fix kexec lockdown bypass with ima policy Link: https://lore.kernel.org/stable/20220719171647.3574253-1-eric.snowberg@oracl… The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html -- 0-DAY CI Kernel Test Service https://01.org/lkp

2 years, 5 months

1
0
0 0

[PATCH AUTOSEL 4.9 1/6] ARM: rockchip: Add missing of_node_put() in rockchip_suspend_init()

by Sasha Levin

From: Liang He <windhl(a)126.com> [ Upstream commit f4470dbfb5ff92804650bc71d115c3f150d430f6 ] In rockchip_suspend_init(), of_find_matching_node_and_match() will return a node pointer with refcount incremented. We should use of_node_put() in fail path or when it is not used anymore. Signed-off-by: Liang He <windhl(a)126.com> Link: https://lore.kernel.org/r/20220616021713.3973472-1-windhl@126.com Signed-off-by: Heiko Stuebner <heiko(a)sntech.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- arch/arm/mach-rockchip/pm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-rockchip/pm.c b/arch/arm/mach-rockchip/pm.c index bee8c8051929..199c1681e8cd 100644 --- a/arch/arm/mach-rockchip/pm.c +++ b/arch/arm/mach-rockchip/pm.c @@ -318,7 +318,7 @@ void __init rockchip_suspend_init(void) &match); if (!match) { pr_err("Failed to find PMU node\n"); - return; + goto out_put; } pm_data = (struct rockchip_pm_data *) match->data; @@ -327,9 +327,12 @@ void __init rockchip_suspend_init(void) if (ret) { pr_err("%s: matches init error %d\n", __func__, ret); - return; + goto out_put; } } suspend_set_ops(pm_data->ops); + +out_put: + of_node_put(np); } -- 2.35.1

2 years, 5 months

1
5
0 0

[PATCH AUTOSEL 4.14 1/6] ARM: rockchip: Add missing of_node_put() in rockchip_suspend_init()

by Sasha Levin

From: Liang He <windhl(a)126.com> [ Upstream commit f4470dbfb5ff92804650bc71d115c3f150d430f6 ] In rockchip_suspend_init(), of_find_matching_node_and_match() will return a node pointer with refcount incremented. We should use of_node_put() in fail path or when it is not used anymore. Signed-off-by: Liang He <windhl(a)126.com> Link: https://lore.kernel.org/r/20220616021713.3973472-1-windhl@126.com Signed-off-by: Heiko Stuebner <heiko(a)sntech.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- arch/arm/mach-rockchip/pm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-rockchip/pm.c b/arch/arm/mach-rockchip/pm.c index 0592534e0b88..66ea37a846c8 100644 --- a/arch/arm/mach-rockchip/pm.c +++ b/arch/arm/mach-rockchip/pm.c @@ -318,7 +318,7 @@ void __init rockchip_suspend_init(void) &match); if (!match) { pr_err("Failed to find PMU node\n"); - return; + goto out_put; } pm_data = (struct rockchip_pm_data *) match->data; @@ -327,9 +327,12 @@ void __init rockchip_suspend_init(void) if (ret) { pr_err("%s: matches init error %d\n", __func__, ret); - return; + goto out_put; } } suspend_set_ops(pm_data->ops); + +out_put: + of_node_put(np); } -- 2.35.1

2 years, 5 months

1
5
0 0

[PATCH AUTOSEL 4.19 1/8] ARM: rockchip: Add missing of_node_put() in rockchip_suspend_init()

by Sasha Levin

From: Liang He <windhl(a)126.com> [ Upstream commit f4470dbfb5ff92804650bc71d115c3f150d430f6 ] In rockchip_suspend_init(), of_find_matching_node_and_match() will return a node pointer with refcount incremented. We should use of_node_put() in fail path or when it is not used anymore. Signed-off-by: Liang He <windhl(a)126.com> Link: https://lore.kernel.org/r/20220616021713.3973472-1-windhl@126.com Signed-off-by: Heiko Stuebner <heiko(a)sntech.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- arch/arm/mach-rockchip/pm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-rockchip/pm.c b/arch/arm/mach-rockchip/pm.c index 0592534e0b88..66ea37a846c8 100644 --- a/arch/arm/mach-rockchip/pm.c +++ b/arch/arm/mach-rockchip/pm.c @@ -318,7 +318,7 @@ void __init rockchip_suspend_init(void) &match); if (!match) { pr_err("Failed to find PMU node\n"); - return; + goto out_put; } pm_data = (struct rockchip_pm_data *) match->data; @@ -327,9 +327,12 @@ void __init rockchip_suspend_init(void) if (ret) { pr_err("%s: matches init error %d\n", __func__, ret); - return; + goto out_put; } } suspend_set_ops(pm_data->ops); + +out_put: + of_node_put(np); } -- 2.35.1

2 years, 5 months

1
7
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror July 2022