June 2022 - Linux-stable-mirror

FAILED: patch "[PATCH] net: phy: dp83867: retrigger SGMII AN when link change" failed to apply to 4.19-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From c76acfb7e19dcc3a0964e0563770b1d11b8d4540 Mon Sep 17 00:00:00 2001 From: Tan Tee Min <tee.min.tan(a)linux.intel.com> Date: Thu, 26 May 2022 17:03:47 +0800 Subject: [PATCH] net: phy: dp83867: retrigger SGMII AN when link change There is a limitation in TI DP83867 PHY device where SGMII AN is only triggered once after the device is booted up. Even after the PHY TPI is down and up again, SGMII AN is not triggered and hence no new in-band message from PHY to MAC side SGMII. This could cause an issue during power up, when PHY is up prior to MAC. At this condition, once MAC side SGMII is up, MAC side SGMII wouldn`t receive new in-band message from TI PHY with correct link status, speed and duplex info. As suggested by TI, implemented a SW solution here to retrigger SGMII Auto-Neg whenever there is a link change. v2: Add Fixes tag in commit message. Fixes: 2a10154abcb7 ("net: phy: dp83867: Add TI dp83867 phy") Cc: <stable(a)vger.kernel.org> # 5.4.x Signed-off-by: Sit, Michael Wei Hong <michael.wei.hong.sit(a)intel.com> Reviewed-by: Voon Weifeng <weifeng.voon(a)intel.com> Signed-off-by: Tan Tee Min <tee.min.tan(a)linux.intel.com> Reviewed-by: Andrew Lunn <andrew(a)lunn.ch> Link: https://lore.kernel.org/r/20220526090347.128742-1-tee.min.tan@linux.intel.c… Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 8561f2d4443b..13dafe7a29bd 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -137,6 +137,7 @@ #define DP83867_DOWNSHIFT_2_COUNT 2 #define DP83867_DOWNSHIFT_4_COUNT 4 #define DP83867_DOWNSHIFT_8_COUNT 8 +#define DP83867_SGMII_AUTONEG_EN BIT(7) /* CFG3 bits */ #define DP83867_CFG3_INT_OE BIT(7) @@ -855,6 +856,32 @@ static int dp83867_phy_reset(struct phy_device *phydev) DP83867_PHYCR_FORCE_LINK_GOOD, 0); } +static void dp83867_link_change_notify(struct phy_device *phydev) +{ + /* There is a limitation in DP83867 PHY device where SGMII AN is + * only triggered once after the device is booted up. Even after the + * PHY TPI is down and up again, SGMII AN is not triggered and + * hence no new in-band message from PHY to MAC side SGMII. + * This could cause an issue during power up, when PHY is up prior + * to MAC. At this condition, once MAC side SGMII is up, MAC side + * SGMII wouldn`t receive new in-band message from TI PHY with + * correct link status, speed and duplex info. + * Thus, implemented a SW solution here to retrigger SGMII Auto-Neg + * whenever there is a link change. + */ + if (phydev->interface == PHY_INTERFACE_MODE_SGMII) { + int val = 0; + + val = phy_clear_bits(phydev, DP83867_CFG2, + DP83867_SGMII_AUTONEG_EN); + if (val < 0) + return; + + phy_set_bits(phydev, DP83867_CFG2, + DP83867_SGMII_AUTONEG_EN); + } +} + static struct phy_driver dp83867_driver[] = { { .phy_id = DP83867_PHY_ID, @@ -879,6 +906,8 @@ static struct phy_driver dp83867_driver[] = { .suspend = genphy_suspend, .resume = genphy_resume, + + .link_change_notify = dp83867_link_change_notify, }, }; module_phy_driver(dp83867_driver);

2 years, 10 months

1
0
0 0

FAILED: patch "[PATCH] net: phy: dp83867: retrigger SGMII AN when link change" failed to apply to 5.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From c76acfb7e19dcc3a0964e0563770b1d11b8d4540 Mon Sep 17 00:00:00 2001 From: Tan Tee Min <tee.min.tan(a)linux.intel.com> Date: Thu, 26 May 2022 17:03:47 +0800 Subject: [PATCH] net: phy: dp83867: retrigger SGMII AN when link change There is a limitation in TI DP83867 PHY device where SGMII AN is only triggered once after the device is booted up. Even after the PHY TPI is down and up again, SGMII AN is not triggered and hence no new in-band message from PHY to MAC side SGMII. This could cause an issue during power up, when PHY is up prior to MAC. At this condition, once MAC side SGMII is up, MAC side SGMII wouldn`t receive new in-band message from TI PHY with correct link status, speed and duplex info. As suggested by TI, implemented a SW solution here to retrigger SGMII Auto-Neg whenever there is a link change. v2: Add Fixes tag in commit message. Fixes: 2a10154abcb7 ("net: phy: dp83867: Add TI dp83867 phy") Cc: <stable(a)vger.kernel.org> # 5.4.x Signed-off-by: Sit, Michael Wei Hong <michael.wei.hong.sit(a)intel.com> Reviewed-by: Voon Weifeng <weifeng.voon(a)intel.com> Signed-off-by: Tan Tee Min <tee.min.tan(a)linux.intel.com> Reviewed-by: Andrew Lunn <andrew(a)lunn.ch> Link: https://lore.kernel.org/r/20220526090347.128742-1-tee.min.tan@linux.intel.c… Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 8561f2d4443b..13dafe7a29bd 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -137,6 +137,7 @@ #define DP83867_DOWNSHIFT_2_COUNT 2 #define DP83867_DOWNSHIFT_4_COUNT 4 #define DP83867_DOWNSHIFT_8_COUNT 8 +#define DP83867_SGMII_AUTONEG_EN BIT(7) /* CFG3 bits */ #define DP83867_CFG3_INT_OE BIT(7) @@ -855,6 +856,32 @@ static int dp83867_phy_reset(struct phy_device *phydev) DP83867_PHYCR_FORCE_LINK_GOOD, 0); } +static void dp83867_link_change_notify(struct phy_device *phydev) +{ + /* There is a limitation in DP83867 PHY device where SGMII AN is + * only triggered once after the device is booted up. Even after the + * PHY TPI is down and up again, SGMII AN is not triggered and + * hence no new in-band message from PHY to MAC side SGMII. + * This could cause an issue during power up, when PHY is up prior + * to MAC. At this condition, once MAC side SGMII is up, MAC side + * SGMII wouldn`t receive new in-band message from TI PHY with + * correct link status, speed and duplex info. + * Thus, implemented a SW solution here to retrigger SGMII Auto-Neg + * whenever there is a link change. + */ + if (phydev->interface == PHY_INTERFACE_MODE_SGMII) { + int val = 0; + + val = phy_clear_bits(phydev, DP83867_CFG2, + DP83867_SGMII_AUTONEG_EN); + if (val < 0) + return; + + phy_set_bits(phydev, DP83867_CFG2, + DP83867_SGMII_AUTONEG_EN); + } +} + static struct phy_driver dp83867_driver[] = { { .phy_id = DP83867_PHY_ID, @@ -879,6 +906,8 @@ static struct phy_driver dp83867_driver[] = { .suspend = genphy_suspend, .resume = genphy_resume, + + .link_change_notify = dp83867_link_change_notify, }, }; module_phy_driver(dp83867_driver);

2 years, 10 months

1
0
0 0

stable-rc/queue/5.18 build: 155 builds: 3 failed, 152 passed, 7 errors, 289 warnings (v5.18.2-1173-g45fe14d45d6c3)

by kernelci.org bot

stable-rc/queue/5.18 build: 155 builds: 3 failed, 152 passed, 7 errors, 289 warnings (v5.18.2-1173-g45fe14d45d6c3) Full Build Summary: https://kernelci.org/build/stable-rc/branch/queue%2F5.18/kernel/v5.18.2-117… Tree: stable-rc Branch: queue/5.18 Git Describe: v5.18.2-1173-g45fe14d45d6c3 Git Commit: 45fe14d45d6c394194f3e262ed5988da2478118e Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Built: 7 unique architectures Build Failures Detected: arm: rpc_defconfig: (gcc-10) FAIL i386: i386_defconfig: (gcc-10) FAIL mips: decstation_64_defconfig: (gcc-10) FAIL Errors and Warnings Detected: arc: allnoconfig (gcc-10): 2 warnings axs103_defconfig (gcc-10): 2 warnings axs103_smp_defconfig (gcc-10): 2 warnings haps_hs_smp_defconfig (gcc-10): 2 warnings nsimosci_hs_defconfig (gcc-10): 2 warnings nsimosci_hs_smp_defconfig (gcc-10): 2 warnings vdk_hs38_defconfig (gcc-10): 2 warnings arm64: arm: am200epdkit_defconfig (gcc-10): 2 warnings aspeed_g4_defconfig (gcc-10): 2 warnings assabet_defconfig (gcc-10): 2 warnings at91_dt_defconfig (gcc-10): 2 warnings axm55xx_defconfig (gcc-10): 2 warnings badge4_defconfig (gcc-10): 2 warnings cerfcube_defconfig (gcc-10): 2 warnings cm_x300_defconfig (gcc-10): 3 warnings colibri_pxa270_defconfig (gcc-10): 2 warnings colibri_pxa300_defconfig (gcc-10): 2 warnings collie_defconfig (gcc-10): 2 warnings corgi_defconfig (gcc-10): 2 warnings davinci_all_defconfig (gcc-10): 2 warnings dove_defconfig (gcc-10): 2 warnings ep93xx_defconfig (gcc-10): 2 warnings exynos_defconfig (gcc-10): 2 warnings ezx_defconfig (gcc-10): 3 warnings footbridge_defconfig (gcc-10): 2 warnings gemini_defconfig (gcc-10): 2 warnings h3600_defconfig (gcc-10): 2 warnings h5000_defconfig (gcc-10): 2 warnings hackkit_defconfig (gcc-10): 2 warnings hisi_defconfig (gcc-10): 2 warnings imx_v4_v5_defconfig (gcc-10): 2 warnings imx_v6_v7_defconfig (gcc-10): 2 warnings integrator_defconfig (gcc-10): 2 warnings iop32x_defconfig (gcc-10): 2 warnings ixp4xx_defconfig (gcc-10): 2 warnings jornada720_defconfig (gcc-10): 2 warnings keystone_defconfig (gcc-10): 2 warnings lart_defconfig (gcc-10): 2 warnings lpc18xx_defconfig (gcc-10): 2 warnings lpc32xx_defconfig (gcc-10): 2 warnings lpd270_defconfig (gcc-10): 2 warnings lubbock_defconfig (gcc-10): 2 warnings magician_defconfig (gcc-10): 2 warnings mainstone_defconfig (gcc-10): 2 warnings milbeaut_m10v_defconfig (gcc-10): 2 warnings mini2440_defconfig (gcc-10): 2 warnings mmp2_defconfig (gcc-10): 2 warnings moxart_defconfig (gcc-10): 2 warnings mps2_defconfig (gcc-10): 2 warnings multi_v4t_defconfig (gcc-10): 2 warnings multi_v5_defconfig (gcc-10): 2 warnings multi_v7_defconfig (gcc-10): 2 warnings mvebu_v5_defconfig (gcc-10): 2 warnings mvebu_v7_defconfig (gcc-10): 2 warnings mxs_defconfig (gcc-10): 2 warnings neponset_defconfig (gcc-10): 2 warnings netwinder_defconfig (gcc-10): 2 warnings nhk8815_defconfig (gcc-10): 3 warnings omap1_defconfig (gcc-10): 2 warnings omap2plus_defconfig (gcc-10): 2 warnings orion5x_defconfig (gcc-10): 2 warnings oxnas_v6_defconfig (gcc-10): 2 warnings pcm027_defconfig (gcc-10): 2 warnings pleb_defconfig (gcc-10): 2 warnings pxa168_defconfig (gcc-10): 2 warnings pxa255-idp_defconfig (gcc-10): 2 warnings pxa3xx_defconfig (gcc-10): 2 warnings pxa910_defconfig (gcc-10): 2 warnings pxa_defconfig (gcc-10): 3 warnings realview_defconfig (gcc-10): 2 warnings rpc_defconfig (gcc-10): 2 errors s3c2410_defconfig (gcc-10): 3 warnings s3c6400_defconfig (gcc-10): 2 warnings sama5_defconfig (gcc-10): 2 warnings sama7_defconfig (gcc-10): 2 warnings shannon_defconfig (gcc-10): 2 warnings shmobile_defconfig (gcc-10): 2 warnings simpad_defconfig (gcc-10): 2 warnings socfpga_defconfig (gcc-10): 2 warnings spear13xx_defconfig (gcc-10): 2 warnings spear3xx_defconfig (gcc-10): 2 warnings spear6xx_defconfig (gcc-10): 2 warnings spitz_defconfig (gcc-10): 2 warnings stm32_defconfig (gcc-10): 2 warnings sunxi_defconfig (gcc-10): 2 warnings tct_hammer_defconfig (gcc-10): 2 warnings tegra_defconfig (gcc-10): 2 warnings trizeps4_defconfig (gcc-10): 3 warnings u8500_defconfig (gcc-10): 2 warnings versatile_defconfig (gcc-10): 2 warnings vexpress_defconfig (gcc-10): 2 warnings vf610m4_defconfig (gcc-10): 2 warnings viper_defconfig (gcc-10): 2 warnings xcep_defconfig (gcc-10): 2 warnings zeus_defconfig (gcc-10): 2 warnings i386: allnoconfig (gcc-10): 2 warnings i386_defconfig (gcc-10): 2 errors, 1 warning tinyconfig (gcc-10): 2 warnings mips: 32r2el_defconfig (gcc-10): 3 warnings ar7_defconfig (gcc-10): 2 warnings ath25_defconfig (gcc-10): 2 warnings ath79_defconfig (gcc-10): 2 warnings bcm47xx_defconfig (gcc-10): 2 warnings bcm63xx_defconfig (gcc-10): 2 warnings capcella_defconfig (gcc-10): 2 warnings ci20_defconfig (gcc-10): 2 warnings cobalt_defconfig (gcc-10): 2 warnings cu1000-neo_defconfig (gcc-10): 2 warnings cu1830-neo_defconfig (gcc-10): 2 warnings decstation_defconfig (gcc-10): 2 warnings decstation_r4k_defconfig (gcc-10): 2 warnings e55_defconfig (gcc-10): 2 warnings fuloong2e_defconfig (gcc-10): 1 error, 1 warning gcw0_defconfig (gcc-10): 2 warnings gpr_defconfig (gcc-10): 2 warnings ip22_defconfig (gcc-10): 3 warnings ip32_defconfig (gcc-10): 1 warning jazz_defconfig (gcc-10): 3 warnings lemote2f_defconfig (gcc-10): 1 error, 1 warning loongson1b_defconfig (gcc-10): 2 warnings loongson1c_defconfig (gcc-10): 2 warnings loongson2k_defconfig (gcc-10): 1 error, 1 warning malta_defconfig (gcc-10): 2 warnings malta_kvm_defconfig (gcc-10): 2 warnings malta_qemu_32r6_defconfig (gcc-10): 3 warnings maltaaprp_defconfig (gcc-10): 3 warnings maltaup_defconfig (gcc-10): 3 warnings maltaup_xpa_defconfig (gcc-10): 2 warnings mpc30x_defconfig (gcc-10): 2 warnings omega2p_defconfig (gcc-10): 2 warnings pic32mzda_defconfig (gcc-10): 2 warnings qi_lb60_defconfig (gcc-10): 2 warnings rb532_defconfig (gcc-10): 3 warnings rbtx49xx_defconfig (gcc-10): 2 warnings rm200_defconfig (gcc-10): 3 warnings rs90_defconfig (gcc-10): 2 warnings tb0219_defconfig (gcc-10): 2 warnings tb0226_defconfig (gcc-10): 2 warnings vocore2_defconfig (gcc-10): 2 warnings workpad_defconfig (gcc-10): 2 warnings riscv: rv32_defconfig (gcc-10): 2 warnings x86_64: Errors summary: 3 cc1: error: ‘-mloongson-mmi’ must be used with ‘-mhard-float’ 2 include/linux/minmax.h:20:28: error: comparison of distinct pointer types lacks a cast [-Werror] 1 arch/arm/kernel/head.S:319: Error: missing expression -- `ldr r7,=0x' 1 arch/arm/kernel/head.S:319: Error: missing expression -- `ldr r3,=0x' Warnings summary: 270 include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast 16 fs/cifs/connect.c:3422:7: warning: unused variable ‘nodfs’ [-Wunused-variable] 1 cc1: warning: result of ‘-117440512 << 16’ requires 44 bits to represent, but ‘int’ only has 32 bits [-Wshift-overflow=] 1 cc1: all warnings being treated as errors 1 arch/mips/boot/dts/img/boston.dts:128.19-178.5: Warning (pci_device_reg): /pci@14000000/pci2_root@0,0,0: PCI unit address format error, expected "0,0" ================================================================================ Detailed per-defconfig build reports: -------------------------------------------------------------------------------- 32r2el_defconfig (mips, gcc-10) — PASS, 0 errors, 3 warnings, 0 section mismatches Warnings: arch/mips/boot/dts/img/boston.dts:128.19-178.5: Warning (pci_device_reg): /pci@14000000/pci2_root@0,0,0: PCI unit address format error, expected "0,0" include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- allnoconfig (arc, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- allnoconfig (x86_64, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- allnoconfig (i386, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- am200epdkit_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- ar7_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- aspeed_g4_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- assabet_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- at91_dt_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- ath25_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- ath79_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- axm55xx_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- axs103_defconfig (arc, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- axs103_smp_defconfig (arc, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- badge4_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- bcm47xx_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- bcm63xx_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- bigsur_defconfig (mips, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- capcella_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- cavium_octeon_defconfig (mips, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- cerfcube_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- ci20_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- cm_x300_defconfig (arm, gcc-10) — PASS, 0 errors, 3 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast fs/cifs/connect.c:3422:7: warning: unused variable ‘nodfs’ [-Wunused-variable] -------------------------------------------------------------------------------- cobalt_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- colibri_pxa270_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- colibri_pxa300_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- collie_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- corgi_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- cu1000-neo_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- cu1830-neo_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- davinci_all_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- decstation_64_defconfig (mips, gcc-10) — FAIL, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- decstation_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- decstation_r4k_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- defconfig (riscv, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- defconfig (arm64, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- defconfig+arm64-chromebook (arm64, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- dove_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- e55_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- ep93xx_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- exynos_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- ezx_defconfig (arm, gcc-10) — PASS, 0 errors, 3 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast fs/cifs/connect.c:3422:7: warning: unused variable ‘nodfs’ [-Wunused-variable] -------------------------------------------------------------------------------- footbridge_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- fuloong2e_defconfig (mips, gcc-10) — PASS, 1 error, 1 warning, 0 section mismatches Errors: cc1: error: ‘-mloongson-mmi’ must be used with ‘-mhard-float’ Warnings: fs/cifs/connect.c:3422:7: warning: unused variable ‘nodfs’ [-Wunused-variable] -------------------------------------------------------------------------------- gcw0_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- gemini_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- gpr_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- h3600_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- h5000_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- hackkit_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- haps_hs_smp_defconfig (arc, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- hisi_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- i386_defconfig (i386, gcc-10) — FAIL, 2 errors, 1 warning, 0 section mismatches Errors: include/linux/minmax.h:20:28: error: comparison of distinct pointer types lacks a cast [-Werror] include/linux/minmax.h:20:28: error: comparison of distinct pointer types lacks a cast [-Werror] Warnings: cc1: all warnings being treated as errors -------------------------------------------------------------------------------- imx_v4_v5_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- imx_v6_v7_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- integrator_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- iop32x_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- ip22_defconfig (mips, gcc-10) — PASS, 0 errors, 3 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast fs/cifs/connect.c:3422:7: warning: unused variable ‘nodfs’ [-Wunused-variable] -------------------------------------------------------------------------------- ip27_defconfig (mips, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- ip28_defconfig (mips, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- ip32_defconfig (mips, gcc-10) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: fs/cifs/connect.c:3422:7: warning: unused variable ‘nodfs’ [-Wunused-variable] -------------------------------------------------------------------------------- ixp4xx_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- jazz_defconfig (mips, gcc-10) — PASS, 0 errors, 3 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast fs/cifs/connect.c:3422:7: warning: unused variable ‘nodfs’ [-Wunused-variable] -------------------------------------------------------------------------------- jornada720_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- keystone_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- lart_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- lemote2f_defconfig (mips, gcc-10) — PASS, 1 error, 1 warning, 0 section mismatches Errors: cc1: error: ‘-mloongson-mmi’ must be used with ‘-mhard-float’ Warnings: fs/cifs/connect.c:3422:7: warning: unused variable ‘nodfs’ [-Wunused-variable] -------------------------------------------------------------------------------- loongson1b_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- loongson1c_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- loongson2k_defconfig (mips, gcc-10) — PASS, 1 error, 1 warning, 0 section mismatches Errors: cc1: error: ‘-mloongson-mmi’ must be used with ‘-mhard-float’ Warnings: fs/cifs/connect.c:3422:7: warning: unused variable ‘nodfs’ [-Wunused-variable] -------------------------------------------------------------------------------- lpc18xx_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- lpc32xx_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- lpd270_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- lubbock_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- magician_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- mainstone_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- malta_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- malta_kvm_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- malta_qemu_32r6_defconfig (mips, gcc-10) — PASS, 0 errors, 3 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast fs/cifs/connect.c:3422:7: warning: unused variable ‘nodfs’ [-Wunused-variable] -------------------------------------------------------------------------------- maltaaprp_defconfig (mips, gcc-10) — PASS, 0 errors, 3 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast fs/cifs/connect.c:3422:7: warning: unused variable ‘nodfs’ [-Wunused-variable] -------------------------------------------------------------------------------- maltaup_defconfig (mips, gcc-10) — PASS, 0 errors, 3 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast fs/cifs/connect.c:3422:7: warning: unused variable ‘nodfs’ [-Wunused-variable] -------------------------------------------------------------------------------- maltaup_xpa_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- milbeaut_m10v_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- mini2440_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- mmp2_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- moxart_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- mpc30x_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- mps2_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- multi_v4t_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- multi_v5_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- multi_v7_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- mvebu_v5_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- mvebu_v7_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- mxs_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- neponset_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- netwinder_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- nhk8815_defconfig (arm, gcc-10) — PASS, 0 errors, 3 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast fs/cifs/connect.c:3422:7: warning: unused variable ‘nodfs’ [-Wunused-variable] -------------------------------------------------------------------------------- nommu_k210_defconfig (riscv, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- nommu_k210_sdcard_defconfig (riscv, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- nsimosci_hs_defconfig (arc, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- nsimosci_hs_smp_defconfig (arc, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- omap1_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- omap2plus_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- omega2p_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- orion5x_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- oxnas_v6_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- pcm027_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- pic32mzda_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- pleb_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- pxa168_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- pxa255-idp_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- pxa3xx_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- pxa910_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- pxa_defconfig (arm, gcc-10) — PASS, 0 errors, 3 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast fs/cifs/connect.c:3422:7: warning: unused variable ‘nodfs’ [-Wunused-variable] -------------------------------------------------------------------------------- qi_lb60_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- rb532_defconfig (mips, gcc-10) — PASS, 0 errors, 3 warnings, 0 section mismatches Warnings: cc1: warning: result of ‘-117440512 << 16’ requires 44 bits to represent, but ‘int’ only has 32 bits [-Wshift-overflow=] include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- rbtx49xx_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- realview_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- rm200_defconfig (mips, gcc-10) — PASS, 0 errors, 3 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast fs/cifs/connect.c:3422:7: warning: unused variable ‘nodfs’ [-Wunused-variable] -------------------------------------------------------------------------------- rpc_defconfig (arm, gcc-10) — FAIL, 2 errors, 0 warnings, 0 section mismatches Errors: arch/arm/kernel/head.S:319: Error: missing expression -- `ldr r7,=0x' arch/arm/kernel/head.S:319: Error: missing expression -- `ldr r3,=0x' -------------------------------------------------------------------------------- rs90_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- rv32_defconfig (riscv, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- s3c2410_defconfig (arm, gcc-10) — PASS, 0 errors, 3 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast fs/cifs/connect.c:3422:7: warning: unused variable ‘nodfs’ [-Wunused-variable] -------------------------------------------------------------------------------- s3c6400_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- sama5_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- sama7_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- sb1250_swarm_defconfig (mips, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- shannon_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- shmobile_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- simpad_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- socfpga_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- spear13xx_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- spear3xx_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- spear6xx_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- spitz_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- stm32_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- sunxi_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- tb0219_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- tb0226_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- tct_hammer_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- tegra_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- tinyconfig (x86_64, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- tinyconfig (i386, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- trizeps4_defconfig (arm, gcc-10) — PASS, 0 errors, 3 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast fs/cifs/connect.c:3422:7: warning: unused variable ‘nodfs’ [-Wunused-variable] -------------------------------------------------------------------------------- u8500_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- vdk_hs38_defconfig (arc, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- versatile_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- vexpress_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- vf610m4_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- viper_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- vocore2_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- workpad_defconfig (mips, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- x86_64_defconfig (x86_64, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- xcep_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast -------------------------------------------------------------------------------- zeus_defconfig (arm, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast --- For more info write to <info(a)kernelci.org>

2 years, 10 months

1
0
0 0

FAILED: patch "[PATCH] KVM: SVM: fix tsc scaling cache logic" failed to apply to 5.17-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.17-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 11d39e8cc43e1c6737af19ca9372e590061b5ad2 Mon Sep 17 00:00:00 2001 From: Maxim Levitsky <mlevitsk(a)redhat.com> Date: Mon, 6 Jun 2022 21:11:49 +0300 Subject: [PATCH] KVM: SVM: fix tsc scaling cache logic SVM uses a per-cpu variable to cache the current value of the tsc scaling multiplier msr on each cpu. Commit 1ab9287add5e2 ("KVM: X86: Add vendor callbacks for writing the TSC multiplier") broke this caching logic. Refactor the code so that all TSC scaling multiplier writes go through a single function which checks and updates the cache. This fixes the following scenario: 1. A CPU runs a guest with some tsc scaling ratio. 2. New guest with different tsc scaling ratio starts on this CPU and terminates almost immediately. This ensures that the short running guest had set the tsc scaling ratio just once when it was set via KVM_SET_TSC_KHZ. Due to the bug, the per-cpu cache is not updated. 3. The original guest continues to run, it doesn't restore the msr value back to its own value, because the cache matches, and thus continues to run with a wrong tsc scaling ratio. Fixes: 1ab9287add5e2 ("KVM: X86: Add vendor callbacks for writing the TSC multiplier") Signed-off-by: Maxim Levitsky <mlevitsk(a)redhat.com> Message-Id: <20220606181149.103072-1-mlevitsk(a)redhat.com> Cc: stable(a)vger.kernel.org Signed-off-by: Paolo Bonzini <pbonzini(a)redhat.com> diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c index bed5e1692cef..3361258640a2 100644 --- a/arch/x86/kvm/svm/nested.c +++ b/arch/x86/kvm/svm/nested.c @@ -982,7 +982,7 @@ int nested_svm_vmexit(struct vcpu_svm *svm) if (svm->tsc_ratio_msr != kvm_default_tsc_scaling_ratio) { WARN_ON(!svm->tsc_scaling_enabled); vcpu->arch.tsc_scaling_ratio = vcpu->arch.l1_tsc_scaling_ratio; - svm_write_tsc_multiplier(vcpu, vcpu->arch.tsc_scaling_ratio); + __svm_write_tsc_multiplier(vcpu->arch.tsc_scaling_ratio); } svm->nested.ctl.nested_cr3 = 0; @@ -1387,7 +1387,7 @@ void nested_svm_update_tsc_ratio_msr(struct kvm_vcpu *vcpu) vcpu->arch.tsc_scaling_ratio = kvm_calc_nested_tsc_multiplier(vcpu->arch.l1_tsc_scaling_ratio, svm->tsc_ratio_msr); - svm_write_tsc_multiplier(vcpu, vcpu->arch.tsc_scaling_ratio); + __svm_write_tsc_multiplier(vcpu->arch.tsc_scaling_ratio); } /* Inverse operation of nested_copy_vmcb_control_to_cache(). asid is copied too. */ diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index 63880b33ce37..478e6ee81d88 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -465,11 +465,24 @@ static int has_svm(void) return 1; } +void __svm_write_tsc_multiplier(u64 multiplier) +{ + preempt_disable(); + + if (multiplier == __this_cpu_read(current_tsc_ratio)) + goto out; + + wrmsrl(MSR_AMD64_TSC_RATIO, multiplier); + __this_cpu_write(current_tsc_ratio, multiplier); +out: + preempt_enable(); +} + static void svm_hardware_disable(void) { /* Make sure we clean up behind us */ if (tsc_scaling) - wrmsrl(MSR_AMD64_TSC_RATIO, SVM_TSC_RATIO_DEFAULT); + __svm_write_tsc_multiplier(SVM_TSC_RATIO_DEFAULT); cpu_svm_disable(); @@ -515,8 +528,7 @@ static int svm_hardware_enable(void) * Set the default value, even if we don't use TSC scaling * to avoid having stale value in the msr */ - wrmsrl(MSR_AMD64_TSC_RATIO, SVM_TSC_RATIO_DEFAULT); - __this_cpu_write(current_tsc_ratio, SVM_TSC_RATIO_DEFAULT); + __svm_write_tsc_multiplier(SVM_TSC_RATIO_DEFAULT); } @@ -999,11 +1011,12 @@ static void svm_write_tsc_offset(struct kvm_vcpu *vcpu, u64 offset) vmcb_mark_dirty(svm->vmcb, VMCB_INTERCEPTS); } -void svm_write_tsc_multiplier(struct kvm_vcpu *vcpu, u64 multiplier) +static void svm_write_tsc_multiplier(struct kvm_vcpu *vcpu, u64 multiplier) { - wrmsrl(MSR_AMD64_TSC_RATIO, multiplier); + __svm_write_tsc_multiplier(multiplier); } + /* Evaluate instruction intercepts that depend on guest CPUID features. */ static void svm_recalc_instruction_intercepts(struct kvm_vcpu *vcpu, struct vcpu_svm *svm) @@ -1363,13 +1376,8 @@ static void svm_prepare_switch_to_guest(struct kvm_vcpu *vcpu) sev_es_prepare_switch_to_guest(hostsa); } - if (tsc_scaling) { - u64 tsc_ratio = vcpu->arch.tsc_scaling_ratio; - if (tsc_ratio != __this_cpu_read(current_tsc_ratio)) { - __this_cpu_write(current_tsc_ratio, tsc_ratio); - wrmsrl(MSR_AMD64_TSC_RATIO, tsc_ratio); - } - } + if (tsc_scaling) + __svm_write_tsc_multiplier(vcpu->arch.tsc_scaling_ratio); if (likely(tsc_aux_uret_slot >= 0)) kvm_set_user_return_msr(tsc_aux_uret_slot, svm->tsc_aux, -1ull); diff --git a/arch/x86/kvm/svm/svm.h b/arch/x86/kvm/svm/svm.h index 45a87b2a8b3c..29d6fd205a49 100644 --- a/arch/x86/kvm/svm/svm.h +++ b/arch/x86/kvm/svm/svm.h @@ -590,7 +590,7 @@ int nested_svm_check_exception(struct vcpu_svm *svm, unsigned nr, bool has_error_code, u32 error_code); int nested_svm_exit_special(struct vcpu_svm *svm); void nested_svm_update_tsc_ratio_msr(struct kvm_vcpu *vcpu); -void svm_write_tsc_multiplier(struct kvm_vcpu *vcpu, u64 multiplier); +void __svm_write_tsc_multiplier(u64 multiplier); void nested_copy_vmcb_control_to_cache(struct vcpu_svm *svm, struct vmcb_control_area *control); void nested_copy_vmcb_save_to_cache(struct vcpu_svm *svm,

2 years, 10 months

1
0
0 0

FAILED: patch "[PATCH] KVM: SVM: fix tsc scaling cache logic" failed to apply to 5.15-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 11d39e8cc43e1c6737af19ca9372e590061b5ad2 Mon Sep 17 00:00:00 2001 From: Maxim Levitsky <mlevitsk(a)redhat.com> Date: Mon, 6 Jun 2022 21:11:49 +0300 Subject: [PATCH] KVM: SVM: fix tsc scaling cache logic SVM uses a per-cpu variable to cache the current value of the tsc scaling multiplier msr on each cpu. Commit 1ab9287add5e2 ("KVM: X86: Add vendor callbacks for writing the TSC multiplier") broke this caching logic. Refactor the code so that all TSC scaling multiplier writes go through a single function which checks and updates the cache. This fixes the following scenario: 1. A CPU runs a guest with some tsc scaling ratio. 2. New guest with different tsc scaling ratio starts on this CPU and terminates almost immediately. This ensures that the short running guest had set the tsc scaling ratio just once when it was set via KVM_SET_TSC_KHZ. Due to the bug, the per-cpu cache is not updated. 3. The original guest continues to run, it doesn't restore the msr value back to its own value, because the cache matches, and thus continues to run with a wrong tsc scaling ratio. Fixes: 1ab9287add5e2 ("KVM: X86: Add vendor callbacks for writing the TSC multiplier") Signed-off-by: Maxim Levitsky <mlevitsk(a)redhat.com> Message-Id: <20220606181149.103072-1-mlevitsk(a)redhat.com> Cc: stable(a)vger.kernel.org Signed-off-by: Paolo Bonzini <pbonzini(a)redhat.com> diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c index bed5e1692cef..3361258640a2 100644 --- a/arch/x86/kvm/svm/nested.c +++ b/arch/x86/kvm/svm/nested.c @@ -982,7 +982,7 @@ int nested_svm_vmexit(struct vcpu_svm *svm) if (svm->tsc_ratio_msr != kvm_default_tsc_scaling_ratio) { WARN_ON(!svm->tsc_scaling_enabled); vcpu->arch.tsc_scaling_ratio = vcpu->arch.l1_tsc_scaling_ratio; - svm_write_tsc_multiplier(vcpu, vcpu->arch.tsc_scaling_ratio); + __svm_write_tsc_multiplier(vcpu->arch.tsc_scaling_ratio); } svm->nested.ctl.nested_cr3 = 0; @@ -1387,7 +1387,7 @@ void nested_svm_update_tsc_ratio_msr(struct kvm_vcpu *vcpu) vcpu->arch.tsc_scaling_ratio = kvm_calc_nested_tsc_multiplier(vcpu->arch.l1_tsc_scaling_ratio, svm->tsc_ratio_msr); - svm_write_tsc_multiplier(vcpu, vcpu->arch.tsc_scaling_ratio); + __svm_write_tsc_multiplier(vcpu->arch.tsc_scaling_ratio); } /* Inverse operation of nested_copy_vmcb_control_to_cache(). asid is copied too. */ diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index 63880b33ce37..478e6ee81d88 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -465,11 +465,24 @@ static int has_svm(void) return 1; } +void __svm_write_tsc_multiplier(u64 multiplier) +{ + preempt_disable(); + + if (multiplier == __this_cpu_read(current_tsc_ratio)) + goto out; + + wrmsrl(MSR_AMD64_TSC_RATIO, multiplier); + __this_cpu_write(current_tsc_ratio, multiplier); +out: + preempt_enable(); +} + static void svm_hardware_disable(void) { /* Make sure we clean up behind us */ if (tsc_scaling) - wrmsrl(MSR_AMD64_TSC_RATIO, SVM_TSC_RATIO_DEFAULT); + __svm_write_tsc_multiplier(SVM_TSC_RATIO_DEFAULT); cpu_svm_disable(); @@ -515,8 +528,7 @@ static int svm_hardware_enable(void) * Set the default value, even if we don't use TSC scaling * to avoid having stale value in the msr */ - wrmsrl(MSR_AMD64_TSC_RATIO, SVM_TSC_RATIO_DEFAULT); - __this_cpu_write(current_tsc_ratio, SVM_TSC_RATIO_DEFAULT); + __svm_write_tsc_multiplier(SVM_TSC_RATIO_DEFAULT); } @@ -999,11 +1011,12 @@ static void svm_write_tsc_offset(struct kvm_vcpu *vcpu, u64 offset) vmcb_mark_dirty(svm->vmcb, VMCB_INTERCEPTS); } -void svm_write_tsc_multiplier(struct kvm_vcpu *vcpu, u64 multiplier) +static void svm_write_tsc_multiplier(struct kvm_vcpu *vcpu, u64 multiplier) { - wrmsrl(MSR_AMD64_TSC_RATIO, multiplier); + __svm_write_tsc_multiplier(multiplier); } + /* Evaluate instruction intercepts that depend on guest CPUID features. */ static void svm_recalc_instruction_intercepts(struct kvm_vcpu *vcpu, struct vcpu_svm *svm) @@ -1363,13 +1376,8 @@ static void svm_prepare_switch_to_guest(struct kvm_vcpu *vcpu) sev_es_prepare_switch_to_guest(hostsa); } - if (tsc_scaling) { - u64 tsc_ratio = vcpu->arch.tsc_scaling_ratio; - if (tsc_ratio != __this_cpu_read(current_tsc_ratio)) { - __this_cpu_write(current_tsc_ratio, tsc_ratio); - wrmsrl(MSR_AMD64_TSC_RATIO, tsc_ratio); - } - } + if (tsc_scaling) + __svm_write_tsc_multiplier(vcpu->arch.tsc_scaling_ratio); if (likely(tsc_aux_uret_slot >= 0)) kvm_set_user_return_msr(tsc_aux_uret_slot, svm->tsc_aux, -1ull); diff --git a/arch/x86/kvm/svm/svm.h b/arch/x86/kvm/svm/svm.h index 45a87b2a8b3c..29d6fd205a49 100644 --- a/arch/x86/kvm/svm/svm.h +++ b/arch/x86/kvm/svm/svm.h @@ -590,7 +590,7 @@ int nested_svm_check_exception(struct vcpu_svm *svm, unsigned nr, bool has_error_code, u32 error_code); int nested_svm_exit_special(struct vcpu_svm *svm); void nested_svm_update_tsc_ratio_msr(struct kvm_vcpu *vcpu); -void svm_write_tsc_multiplier(struct kvm_vcpu *vcpu, u64 multiplier); +void __svm_write_tsc_multiplier(u64 multiplier); void nested_copy_vmcb_control_to_cache(struct vcpu_svm *svm, struct vmcb_control_area *control); void nested_copy_vmcb_save_to_cache(struct vcpu_svm *svm,

2 years, 10 months

1
0
0 0

stable-rc/queue/5.17 baseline: 95 runs, 2 regressions (v5.17.13-1024-gb80ef70132a79)

by kernelci.org bot

stable-rc/queue/5.17 baseline: 95 runs, 2 regressions (v5.17.13-1024-gb80ef70132a79) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions -----------------------------+-------+---------------+----------+----------------------------+------------ jetson-tk1 | arm | lab-baylibre | gcc-10 | tegra_defconfig | 1 mt8183-kukui-...uniper-sku16 | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F5.17/kernel/v5.17.13… Test: baseline Tree: stable-rc Branch: queue/5.17 Describe: v5.17.13-1024-gb80ef70132a79 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: b80ef70132a794057d4c61d9c9db5ec52110f498 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions -----------------------------+-------+---------------+----------+----------------------------+------------ jetson-tk1 | arm | lab-baylibre | gcc-10 | tegra_defconfig | 1 Details: https://kernelci.org/test/plan/id/62a6add2d3349c07e7a39bd4 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: tegra_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.17/v5.17.13-1024-gb80ef7013… HTML log: https://storage.kernelci.org//stable-rc/queue-5.17/v5.17.13-1024-gb80ef7013… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6add2d3349c07e7a39bd5 failing since 2 days (last pass: v5.17.13-907-ga980fa631e355, first fail: v5.17.13-928-gfe5fcee7b41f8) platform | arch | lab | compiler | defconfig | regressions -----------------------------+-------+---------------+----------+----------------------------+------------ mt8183-kukui-...uniper-sku16 | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/62a6ac1ef28deb76efa39c3f Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.17/v5.17.13-1024-gb80ef7013… HTML log: https://storage.kernelci.org//stable-rc/queue-5.17/v5.17.13-1024-gb80ef7013… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6ac1ef28deb76efa39c40 new failure (last pass: v5.17.13-771-g1bf589e90ab9c)

2 years, 10 months

1
0
0 0

stable-rc/queue/4.9 baseline: 113 runs, 18 regressions (v4.9.317-157-g7c98708692ab9)

by kernelci.org bot

stable-rc/queue/4.9 baseline: 113 runs, 18 regressions (v4.9.317-157-g7c98708692ab9) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ jetson-tk1 | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 jetson-tk1 | arm | lab-baylibre | gcc-10 | tegra_defconfig | 1 qemu_arm64-virt-gicv2 | arm64 | lab-baylibre | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv2 | arm64 | lab-baylibre | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv2 | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv2 | arm64 | lab-broonie | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv2-uefi | arm64 | lab-baylibre | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv2-uefi | arm64 | lab-baylibre | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv2-uefi | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv2-uefi | arm64 | lab-broonie | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv3 | arm64 | lab-baylibre | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv3 | arm64 | lab-baylibre | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv3 | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv3 | arm64 | lab-broonie | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv3-uefi | arm64 | lab-baylibre | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv3-uefi | arm64 | lab-baylibre | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv3-uefi | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv3-uefi | arm64 | lab-broonie | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F4.9/kernel/v4.9.317-… Test: baseline Tree: stable-rc Branch: queue/4.9 Describe: v4.9.317-157-g7c98708692ab9 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 7c98708692ab9609d7a6ab50a06a528efb2d6088 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ jetson-tk1 | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/62a6abe3d1d927482ba39bdc Results: 0 PASS, 1 FAIL, 0 SKIP Full config: multi_v7_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6abe3d1d927482ba39bdd failing since 20 days (last pass: v4.9.313-7-gbabb34651fcb2, first fail: v4.9.315-25-gebb662d6916b) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ jetson-tk1 | arm | lab-baylibre | gcc-10 | tegra_defconfig | 1 Details: https://kernelci.org/test/plan/id/62a6a928d1f7e62a91a39bfe Results: 0 PASS, 1 FAIL, 0 SKIP Full config: tegra_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6a928d1f7e62a91a39bff failing since 20 days (last pass: v4.9.313-7-gbabb34651fcb2, first fail: v4.9.315-25-gebb662d6916b) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2 | arm64 | lab-baylibre | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/62a6a910a8a1005e9fa39bf3 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6a910a8a1005e9fa39bf4 failing since 33 days (last pass: v4.9.312-43-g8ccd2ae24f47, first fail: v4.9.312-64-g69b9f3e8fce2) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2 | arm64 | lab-baylibre | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/62a6aa77d245e6992da39bcd Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6aa77d245e6992da39bce failing since 33 days (last pass: v4.9.312-43-g5b8113699dd5, first fail: v4.9.312-64-g69b9f3e8fce2) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2 | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/62a6a953b9415a4faea39bef Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6a953b9415a4faea39bf0 failing since 33 days (last pass: v4.9.312-43-g8ccd2ae24f47, first fail: v4.9.312-64-g69b9f3e8fce2) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2 | arm64 | lab-broonie | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/62a6ab0b19c271a7b8a39bcd Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6ab0b19c271a7b8a39bce failing since 33 days (last pass: v4.9.312-43-g5b8113699dd5, first fail: v4.9.312-64-g69b9f3e8fce2) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2-uefi | arm64 | lab-baylibre | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/62a6a90fd1f7e62a91a39bd8 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6a90fd1f7e62a91a39bd9 failing since 33 days (last pass: v4.9.312-43-g8ccd2ae24f47, first fail: v4.9.312-64-g69b9f3e8fce2) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2-uefi | arm64 | lab-baylibre | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/62a6aa4f1f60ad3cbba39bd0 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6aa4f1f60ad3cbba39bd1 failing since 33 days (last pass: v4.9.312-43-g5b8113699dd5, first fail: v4.9.312-64-g69b9f3e8fce2) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2-uefi | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/62a6a92ccdc9fdd291a39bdb Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6a92ccdc9fdd291a39bdc failing since 33 days (last pass: v4.9.312-43-g8ccd2ae24f47, first fail: v4.9.312-64-g69b9f3e8fce2) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2-uefi | arm64 | lab-broonie | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/62a6aaf75f6e68b65ea39c20 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6aaf75f6e68b65ea39c21 failing since 33 days (last pass: v4.9.312-43-g5b8113699dd5, first fail: v4.9.312-64-g69b9f3e8fce2) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3 | arm64 | lab-baylibre | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/62a6a8e6b9c8a6ce0fa39bfa Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6a8e6b9c8a6ce0fa39bfb failing since 33 days (last pass: v4.9.312-43-g8ccd2ae24f47, first fail: v4.9.312-64-g69b9f3e8fce2) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3 | arm64 | lab-baylibre | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/62a6aa78d245e6992da39bd6 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6aa78d245e6992da39bd7 failing since 33 days (last pass: v4.9.312-43-g5b8113699dd5, first fail: v4.9.312-64-g69b9f3e8fce2) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3 | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/62a6a92b1501e1de6ba39bdf Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6a92b1501e1de6ba39be0 failing since 33 days (last pass: v4.9.312-43-g8ccd2ae24f47, first fail: v4.9.312-64-g69b9f3e8fce2) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3 | arm64 | lab-broonie | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/62a6ab33b88cf81931a39beb Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6ab33b88cf81931a39bec failing since 33 days (last pass: v4.9.312-43-g5b8113699dd5, first fail: v4.9.312-64-g69b9f3e8fce2) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3-uefi | arm64 | lab-baylibre | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/62a6a9112aad59d3f9a39bf1 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6a9112aad59d3f9a39bf2 failing since 33 days (last pass: v4.9.312-43-g8ccd2ae24f47, first fail: v4.9.312-64-g69b9f3e8fce2) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3-uefi | arm64 | lab-baylibre | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/62a6aa79d245e6992da39be4 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6aa79d245e6992da39be5 failing since 33 days (last pass: v4.9.312-43-g5b8113699dd5, first fail: v4.9.312-64-g69b9f3e8fce2) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3-uefi | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/62a6aa6b1f60ad3cbba39be9 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6aa6b1f60ad3cbba39bea failing since 33 days (last pass: v4.9.312-43-g8ccd2ae24f47, first fail: v4.9.312-64-g69b9f3e8fce2) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3-uefi | arm64 | lab-broonie | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/62a6abd3a5f17bc10ba39bce Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.317-157-g7c98708692a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62a6abd3a5f17bc10ba39bcf failing since 33 days (last pass: v4.9.312-43-g5b8113699dd5, first fail: v4.9.312-64-g69b9f3e8fce2)

2 years, 10 months

1
0
0 0

FAILED: patch "[PATCH] random: account for arch randomness in bits" failed to apply to 5.18-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.18-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 77fc95f8c0dc9e1f8e620ec14d2fb65028fb7adc Mon Sep 17 00:00:00 2001 From: "Jason A. Donenfeld" <Jason(a)zx2c4.com> Date: Tue, 7 Jun 2022 17:04:38 +0200 Subject: [PATCH] random: account for arch randomness in bits Rather than accounting in bytes and multiplying (shifting), we can just account in bits and avoid the shift. The main motivation for this is there are other patches in flux that expand this code a bit, and avoiding the duplication of "* 8" everywhere makes things a bit clearer. Cc: stable(a)vger.kernel.org Fixes: 12e45a2a6308 ("random: credit architectural init the exact amount") Signed-off-by: Jason A. Donenfeld <Jason(a)zx2c4.com> diff --git a/drivers/char/random.c b/drivers/char/random.c index 0d6fb3eaf609..60d701a2516b 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -776,7 +776,7 @@ static struct notifier_block pm_notifier = { .notifier_call = random_pm_notifica int __init random_init(const char *command_line) { ktime_t now = ktime_get_real(); - unsigned int i, arch_bytes; + unsigned int i, arch_bits; unsigned long entropy; #if defined(LATENT_ENTROPY_PLUGIN) @@ -784,12 +784,12 @@ int __init random_init(const char *command_line) _mix_pool_bytes(compiletime_seed, sizeof(compiletime_seed)); #endif - for (i = 0, arch_bytes = BLAKE2S_BLOCK_SIZE; + for (i = 0, arch_bits = BLAKE2S_BLOCK_SIZE * 8; i < BLAKE2S_BLOCK_SIZE; i += sizeof(entropy)) { if (!arch_get_random_seed_long_early(&entropy) && !arch_get_random_long_early(&entropy)) { entropy = random_get_entropy(); - arch_bytes -= sizeof(entropy); + arch_bits -= sizeof(entropy) * 8; } _mix_pool_bytes(&entropy, sizeof(entropy)); } @@ -801,8 +801,8 @@ int __init random_init(const char *command_line) if (crng_ready()) crng_reseed(); else if (trust_cpu) - _credit_init_bits(arch_bytes * 8); - used_arch_random = arch_bytes * 8 >= POOL_READY_BITS; + _credit_init_bits(arch_bits); + used_arch_random = arch_bits >= POOL_READY_BITS; WARN_ON(register_pm_notifier(&pm_notifier));

2 years, 10 months

1
0
0 0

FAILED: patch "[PATCH] random: account for arch randomness in bits" failed to apply to 5.15-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 77fc95f8c0dc9e1f8e620ec14d2fb65028fb7adc Mon Sep 17 00:00:00 2001 From: "Jason A. Donenfeld" <Jason(a)zx2c4.com> Date: Tue, 7 Jun 2022 17:04:38 +0200 Subject: [PATCH] random: account for arch randomness in bits Rather than accounting in bytes and multiplying (shifting), we can just account in bits and avoid the shift. The main motivation for this is there are other patches in flux that expand this code a bit, and avoiding the duplication of "* 8" everywhere makes things a bit clearer. Cc: stable(a)vger.kernel.org Fixes: 12e45a2a6308 ("random: credit architectural init the exact amount") Signed-off-by: Jason A. Donenfeld <Jason(a)zx2c4.com> diff --git a/drivers/char/random.c b/drivers/char/random.c index 0d6fb3eaf609..60d701a2516b 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -776,7 +776,7 @@ static struct notifier_block pm_notifier = { .notifier_call = random_pm_notifica int __init random_init(const char *command_line) { ktime_t now = ktime_get_real(); - unsigned int i, arch_bytes; + unsigned int i, arch_bits; unsigned long entropy; #if defined(LATENT_ENTROPY_PLUGIN) @@ -784,12 +784,12 @@ int __init random_init(const char *command_line) _mix_pool_bytes(compiletime_seed, sizeof(compiletime_seed)); #endif - for (i = 0, arch_bytes = BLAKE2S_BLOCK_SIZE; + for (i = 0, arch_bits = BLAKE2S_BLOCK_SIZE * 8; i < BLAKE2S_BLOCK_SIZE; i += sizeof(entropy)) { if (!arch_get_random_seed_long_early(&entropy) && !arch_get_random_long_early(&entropy)) { entropy = random_get_entropy(); - arch_bytes -= sizeof(entropy); + arch_bits -= sizeof(entropy) * 8; } _mix_pool_bytes(&entropy, sizeof(entropy)); } @@ -801,8 +801,8 @@ int __init random_init(const char *command_line) if (crng_ready()) crng_reseed(); else if (trust_cpu) - _credit_init_bits(arch_bytes * 8); - used_arch_random = arch_bytes * 8 >= POOL_READY_BITS; + _credit_init_bits(arch_bits); + used_arch_random = arch_bits >= POOL_READY_BITS; WARN_ON(register_pm_notifier(&pm_notifier));

2 years, 10 months

1
0
0 0

FAILED: patch "[PATCH] random: account for arch randomness in bits" failed to apply to 5.17-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.17-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 77fc95f8c0dc9e1f8e620ec14d2fb65028fb7adc Mon Sep 17 00:00:00 2001 From: "Jason A. Donenfeld" <Jason(a)zx2c4.com> Date: Tue, 7 Jun 2022 17:04:38 +0200 Subject: [PATCH] random: account for arch randomness in bits Rather than accounting in bytes and multiplying (shifting), we can just account in bits and avoid the shift. The main motivation for this is there are other patches in flux that expand this code a bit, and avoiding the duplication of "* 8" everywhere makes things a bit clearer. Cc: stable(a)vger.kernel.org Fixes: 12e45a2a6308 ("random: credit architectural init the exact amount") Signed-off-by: Jason A. Donenfeld <Jason(a)zx2c4.com> diff --git a/drivers/char/random.c b/drivers/char/random.c index 0d6fb3eaf609..60d701a2516b 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -776,7 +776,7 @@ static struct notifier_block pm_notifier = { .notifier_call = random_pm_notifica int __init random_init(const char *command_line) { ktime_t now = ktime_get_real(); - unsigned int i, arch_bytes; + unsigned int i, arch_bits; unsigned long entropy; #if defined(LATENT_ENTROPY_PLUGIN) @@ -784,12 +784,12 @@ int __init random_init(const char *command_line) _mix_pool_bytes(compiletime_seed, sizeof(compiletime_seed)); #endif - for (i = 0, arch_bytes = BLAKE2S_BLOCK_SIZE; + for (i = 0, arch_bits = BLAKE2S_BLOCK_SIZE * 8; i < BLAKE2S_BLOCK_SIZE; i += sizeof(entropy)) { if (!arch_get_random_seed_long_early(&entropy) && !arch_get_random_long_early(&entropy)) { entropy = random_get_entropy(); - arch_bytes -= sizeof(entropy); + arch_bits -= sizeof(entropy) * 8; } _mix_pool_bytes(&entropy, sizeof(entropy)); } @@ -801,8 +801,8 @@ int __init random_init(const char *command_line) if (crng_ready()) crng_reseed(); else if (trust_cpu) - _credit_init_bits(arch_bytes * 8); - used_arch_random = arch_bytes * 8 >= POOL_READY_BITS; + _credit_init_bits(arch_bits); + used_arch_random = arch_bits >= POOL_READY_BITS; WARN_ON(register_pm_notifier(&pm_notifier));

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror June 2022