May 2022 - Linux-stable-mirror

[PATCH 1/1] radeon: fix a possible null pointer dereference

by Yuanjun Gong

From: Gong Yuanjun <ruc_gongyuanjun(a)163.com> In radeon_fp_native_mode(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. The failure status of drm_cvt_mode() on the other path is checked too. Signed-off-by: Gong Yuanjun <ruc_gongyuanjun(a)163.com> --- drivers/gpu/drm/radeon/radeon_connectors.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c index 0cb1345c6ba4..fabe4f4ca124 100644 --- a/drivers/gpu/drm/radeon/radeon_connectors.c +++ b/drivers/gpu/drm/radeon/radeon_connectors.c @@ -473,6 +473,8 @@ static struct drm_display_mode *radeon_fp_native_mode(struct drm_encoder *encode native_mode->vdisplay != 0 && native_mode->clock != 0) { mode = drm_mode_duplicate(dev, native_mode); + if (!mode) + return NULL; mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER; drm_mode_set_name(mode); @@ -487,6 +489,8 @@ static struct drm_display_mode *radeon_fp_native_mode(struct drm_encoder *encode * simpler. */ mode = drm_cvt_mode(dev, native_mode->hdisplay, native_mode->vdisplay, 60, true, false, false); + if (!mode) + return NULL; mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER; DRM_DEBUG_KMS("Adding cvt approximation of native panel mode %s\n", mode->name); } -- 2.17.1

2 years, 8 months

2
1
0 0

[PATCH 1/1] drm/amd/pm: fix a potential gpu_metrics_table memory leak

by Yuanjun Gong

From: Gong Yuanjun <ruc_gongyuanjun(a)163.com> gpu_metrics_table is allocated in yellow_carp_init_smc_tables() but not freed in yellow_carp_fini_smc_tables(). Signed-off-by: Gong Yuanjun <ruc_gongyuanjun(a)163.com> --- drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c index e2d099409123..c66c39ccf19c 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c @@ -190,6 +190,9 @@ static int yellow_carp_fini_smc_tables(struct smu_context *smu) kfree(smu_table->watermarks_table); smu_table->watermarks_table = NULL; + kfree(smu_table->gpu_metrics_table); + smu_table->gpu_metrics_table = NULL; + return 0; } -- 2.17.1

2 years, 8 months

2
1
0 0

Re: [PATCH] dma-buf: fix use of DMA_BUF_SET_NAME_{A,B} in userspace

by Jérôme Pouiller

[add stable(a)vger.kernel.org to the recipients] On Tuesday 17 May 2022 09:30:24 CEST Christian König wrote: > Am 17.05.22 um 09:27 schrieb Jerome Pouiller: > > From: Jérôme Pouiller <jerome.pouiller(a)silabs.com> > > > > The typedefs u32 and u64 are not available in userspace. Thus user get > > an error he try to use DMA_BUF_SET_NAME_A or DMA_BUF_SET_NAME_B: > > > > $ gcc -Wall -c -MMD -c -o ioctls_list.o ioctls_list.c > > In file included from /usr/include/x86_64-linux-gnu/asm/ioctl.h:1, > > from /usr/include/linux/ioctl.h:5, > > from /usr/include/asm-generic/ioctls.h:5, > > from ioctls_list.c:11: > > ioctls_list.c:463:29: error: ‘u32’ undeclared here (not in a function) > > 463 | { "DMA_BUF_SET_NAME_A", DMA_BUF_SET_NAME_A, -1, -1 }, // linux/dma-buf.h > > | ^~~~~~~~~~~~~~~~~~ > > ioctls_list.c:464:29: error: ‘u64’ undeclared here (not in a function) > > 464 | { "DMA_BUF_SET_NAME_B", DMA_BUF_SET_NAME_B, -1, -1 }, // linux/dma-buf.h > > | ^~~~~~~~~~~~~~~~~~ > > > > The issue was initially reported here[1]. > > > > [1]: https://urldefense.com/v3/__https://nam11.safelinks.protection.outlook.com/… > > > > Signed-off-by: Jérôme Pouiller <jerome.pouiller(a)silabs.com> > > Good catch, Reviewed-by: Christian König <christian.koenig(a)amd.com> > > CC: stable? Done > Fixes: ? Fixes: a5bff92eaac4 ("dma-buf: Fix SET_NAME ioctl uapi") -- Jérôme Pouiller

2 years, 8 months

2
1
0 0

Please can i have your attention

by Julian Bikram

Dear , Please can I have your attention and possibly help me for humanity's sake please. I am writing this message with a heavy heart filled with sorrows and sadness. Please if you can respond, i have an issue that i will be most grateful if you could help me deal with it please. Julian

2 years, 8 months

1
0
0 0

[PATCH 5.10 00/66] 5.10.117-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.10.117 release. There are 66 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 18 May 2022 19:36:02 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.117-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.10.117-rc1 Dan Vacura <w36195(a)motorola.com> usb: gadget: uvc: allow for application to cleanly shutdown Michael Tretter <m.tretter(a)pengutronix.de> usb: gadget: uvc: rename function to be more consistent Nicolas Dichtel <nicolas.dichtel(a)6wind.com> ping: fix address binding wrt vrf Mike Rapoport <rppt(a)kernel.org> arm[64]/memremap: don't abuse pfn_valid() to ensure presence of linear map Francesco Dolcini <francesco.dolcini(a)toradex.com> net: phy: Fix race condition on link status change Trond Myklebust <trond.myklebust(a)hammerspace.com> SUNRPC: Ensure we flush any closed sockets before xs_xprt_free() Trond Myklebust <trond.myklebust(a)hammerspace.com> SUNRPC: Don't call connect() more than once on a TCP socket Trond Myklebust <trond.myklebust(a)hammerspace.com> SUNRPC: Prevent immediate close+reconnect Trond Myklebust <trond.myklebust(a)hammerspace.com> SUNRPC: Clean up scheduling of autoclose Zack Rusin <zackr(a)vmware.com> drm/vmwgfx: Initialize drm_mode_fb_cmd2 Waiman Long <longman(a)redhat.com> cgroup/cpuset: Remove cpus_allowed/mems_allowed setup in cpuset_init_smp() Manuel Ullmann <labre(a)posteo.de> net: atlantic: always deep reset on pm op, fixing up my null deref regression Xiaomeng Tong <xiam0nd.tong(a)gmail.com> i40e: i40e_main: fix a missing check on list iterator Robin Murphy <robin.murphy(a)arm.com> drm/nouveau/tegra: Stop using iommu_present() Jeff Layton <jlayton(a)kernel.org> ceph: fix setting of xattrs on async created inodes AngeloGioacchino Del Regno <angelogioacchino.delregno(a)collabora.com> serial: 8250_mtk: Fix register address for XON/XOFF character AngeloGioacchino Del Regno <angelogioacchino.delregno(a)collabora.com> serial: 8250_mtk: Fix UART_EFR register address Miaoqian Lin <linmq006(a)gmail.com> slimbus: qcom: Fix IRQ check in qcom_slim_probe Sven Schwermer <sven.schwermer(a)disruptive-technologies.com> USB: serial: option: add Fibocom MA510 modem Sven Schwermer <sven.schwermer(a)disruptive-technologies.com> USB: serial: option: add Fibocom L610 modem Ethan Yang <etyang(a)sierrawireless.com> USB: serial: qcserial: add support for Sierra Wireless EM7590 Scott Chen <scott(a)labau.com.tw> USB: serial: pl2303: add device id for HP LM930 Display ChiYuan Huang <cy_huang(a)richtek.com> usb: typec: tcpci_mt6360: Update for BMC PHY setting Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> usb: typec: tcpci: Don't skip cleanup in .remove() on error Sergey Ryazanov <ryazanov.s.a(a)gmail.com> usb: cdc-wdm: fix reading stuck on device close Daniel Starke <daniel.starke(a)siemens.com> tty: n_gsm: fix mux activation issues in gsm_config() Yang Yingliang <yangyingliang(a)huawei.com> tty/serial: digicolor: fix possible null-ptr-deref in digicolor_uart_probe() Thiébaud Weksteen <tweek(a)google.com> firmware_loader: use kernel credentials when reading firmware Eric Dumazet <edumazet(a)google.com> tcp: resalt the secret every 10 seconds Matthew Hagan <mnhagan88(a)gmail.com> net: sfp: Add tx-fault workaround for Huawei MA5671A SFP ONT Shravya Kumbham <shravya.kumbham(a)xilinx.com> net: emaclite: Don't advertise 1000BASE-T and do auto negotiation Sven Schnelle <svens(a)linux.ibm.com> s390: disable -Warray-bounds Mark Brown <broonie(a)kernel.org> ASoC: ops: Validate input values in snd_soc_put_volsw_range() Mark Brown <broonie(a)kernel.org> ASoC: max98090: Generate notifications on changes for custom control Mark Brown <broonie(a)kernel.org> ASoC: max98090: Reject invalid values in custom control put() Ji-Ze Hong (Peter Hong) <hpeter(a)gmail.com> hwmon: (f71882fg) Fix negative temperature Andreas Gruenbacher <agruenba(a)redhat.com> gfs2: Fix filesystem block deallocation for short writes Maxim Mikityanskiy <maximmi(a)nvidia.com> tls: Fix context leak on tls_device_down Taehee Yoo <ap420073(a)gmail.com> net: sfc: ef10: fix memory leak in efx_ef10_mtd_probe() Guangguan Wang <guangguan.wang(a)linux.alibaba.com> net/smc: non blocking recvmsg() return -EAGAIN when no data and signal_pending Florian Fainelli <f.fainelli(a)gmail.com> net: dsa: bcm_sf2: Fix Wake-on-LAN with mac_link_down() Florian Fainelli <f.fainelli(a)gmail.com> net: bcmgenet: Check for Wake-on-LAN interrupt probe deferral Paolo Abeni <pabeni(a)redhat.com> net/sched: act_pedit: really ensure the skb is writable Alexandra Winter <wintera(a)linux.ibm.com> s390/lcs: fix variable dereferenced before check Alexandra Winter <wintera(a)linux.ibm.com> s390/ctcm: fix potential memory leak Alexandra Winter <wintera(a)linux.ibm.com> s390/ctcm: fix variable dereferenced before check Joel Savitz <jsavitz(a)redhat.com> selftests: vm: Makefile: rename TARGETS to VMTARGETS Randy Dunlap <rdunlap(a)infradead.org> hwmon: (ltq-cputemp) restrict it to SOC_XWAY Jesse Brandeburg <jesse.brandeburg(a)intel.com> dim: initialize all struct fields Yang Yingliang <yangyingliang(a)huawei.com> ionic: fix missing pci_release_regions() on error in ionic_probe() Dan Aloni <dan.aloni(a)vastdata.com> nfs: fix broken handling of the softreval mount option Johannes Berg <johannes.berg(a)intel.com> mac80211_hwsim: call ieee80211_tx_prepare_skb under RCU protection Taehee Yoo <ap420073(a)gmail.com> net: sfc: fix memory leak due to ptp channel Jiapeng Chong <jiapeng.chong(a)linux.alibaba.com> sfc: Use swap() instead of open coding it Eric Dumazet <edumazet(a)google.com> netlink: do not reset transport header in netlink_recvmsg() Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> drm/nouveau: Fix a potential theorical leak in nouveau_get_backlight_name() Lokesh Dhoundiyal <lokesh.dhoundiyal(a)alliedtelesis.co.nz> ipv4: drop dst in multicast routing path Vladimir Oltean <vladimir.oltean(a)nxp.com> net: mscc: ocelot: avoid corrupting hardware counters when moving VCAP filters Vladimir Oltean <vladimir.oltean(a)nxp.com> net: mscc: ocelot: restrict tc-trap actions to VCAP IS2 lookup 0 Vladimir Oltean <vladimir.oltean(a)nxp.com> net: mscc: ocelot: fix VCAP IS2 filters matching on both lookups Vladimir Oltean <vladimir.oltean(a)nxp.com> net: mscc: ocelot: fix last VCAP IS1/IS2 filter persisting in hardware when deleted Tariq Toukan <tariqt(a)nvidia.com> net: Fix features skip in for_each_netdev_feature() Manikanta Pubbisetty <quic_mpubbise(a)quicinc.com> mac80211: Reset MBSSID parameters upon connection Camel Guo <camel.guo(a)axis.com> hwmon: (tmp401) Add OF device ID table Guenter Roeck <linux(a)roeck-us.net> iwlwifi: iwl-dbg: Use del_timer_sync() before freeing Sven Eckelmann <sven(a)narfation.org> batman-adv: Don't skb_split skbuffs with frag_list ------------- Diffstat: Makefile | 4 +- arch/arm/include/asm/io.h | 3 ++ arch/arm/mm/ioremap.c | 8 ++++ arch/arm64/include/asm/io.h | 4 ++ arch/arm64/mm/ioremap.c | 9 +++++ arch/s390/Makefile | 10 +++++ drivers/base/firmware_loader/main.c | 17 ++++++++ drivers/gpu/drm/nouveau/nouveau_backlight.c | 9 +++-- drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 2 +- drivers/hwmon/Kconfig | 2 +- drivers/hwmon/f71882fg.c | 5 ++- drivers/hwmon/tmp401.c | 11 ++++++ drivers/net/dsa/bcm_sf2.c | 3 ++ .../net/ethernet/aquantia/atlantic/aq_pci_func.c | 4 +- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 ++ drivers/net/ethernet/intel/i40e/i40e_main.c | 27 ++++++------- drivers/net/ethernet/mscc/ocelot_flower.c | 5 ++- drivers/net/ethernet/mscc/ocelot_vcap.c | 9 ++++- .../net/ethernet/pensando/ionic/ionic_bus_pci.c | 3 +- drivers/net/ethernet/sfc/ef10.c | 5 +++ drivers/net/ethernet/sfc/efx_channels.c | 21 +++++----- drivers/net/ethernet/sfc/ptp.c | 14 ++++++- drivers/net/ethernet/sfc/ptp.h | 1 + drivers/net/ethernet/xilinx/xilinx_emaclite.c | 15 -------- drivers/net/phy/phy.c | 45 +++++++++++++++++++--- drivers/net/phy/sfp.c | 12 +++++- drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 2 +- drivers/net/wireless/mac80211_hwsim.c | 3 ++ drivers/s390/net/ctcm_mpc.c | 6 +-- drivers/s390/net/ctcm_sysfs.c | 5 ++- drivers/s390/net/lcs.c | 7 ++-- drivers/slimbus/qcom-ctrl.c | 4 +- drivers/tty/n_gsm.c | 12 ++++-- drivers/tty/serial/8250/8250_mtk.c | 22 ++++++----- drivers/tty/serial/digicolor-usart.c | 5 +-- drivers/usb/class/cdc-wdm.c | 1 + drivers/usb/gadget/function/f_uvc.c | 32 +++++++++++++-- drivers/usb/gadget/function/uvc.h | 2 + drivers/usb/gadget/function/uvc_v4l2.c | 3 +- drivers/usb/serial/option.c | 4 ++ drivers/usb/serial/pl2303.c | 1 + drivers/usb/serial/pl2303.h | 1 + drivers/usb/serial/qcserial.c | 2 + drivers/usb/typec/tcpm/tcpci.c | 2 +- drivers/usb/typec/tcpm/tcpci_mt6360.c | 26 +++++++++++++ fs/ceph/file.c | 16 ++++++-- fs/file_table.c | 1 + fs/gfs2/bmap.c | 11 +++--- fs/nfs/fs_context.c | 2 +- include/linux/netdev_features.h | 4 +- include/linux/sunrpc/xprtsock.h | 1 + include/net/tc_act/tc_pedit.h | 1 + include/trace/events/sunrpc.h | 1 - kernel/cgroup/cpuset.c | 7 +++- lib/dim/net_dim.c | 44 ++++++++++----------- net/batman-adv/fragmentation.c | 11 ++++++ net/core/secure_seq.c | 12 ++++-- net/ipv4/ping.c | 15 +++++++- net/ipv4/route.c | 1 + net/mac80211/mlme.c | 6 +++ net/netlink/af_netlink.c | 1 - net/sched/act_pedit.c | 26 +++++++++++-- net/smc/smc_rx.c | 4 +- net/sunrpc/xprt.c | 36 ++++++++--------- net/sunrpc/xprtsock.c | 35 +++++++++++------ net/tls/tls_device.c | 3 ++ sound/soc/codecs/max98090.c | 5 ++- sound/soc/soc-ops.c | 18 ++++++++- tools/testing/selftests/vm/Makefile | 10 ++--- 70 files changed, 482 insertions(+), 183 deletions(-)

2 years, 8 months

3
68
0 0

[PATCH] Revert "clk: sunxi-ng: sun6i-rtc: Add support for H6"

by Jernej Skrabec

This reverts commit 1738890a3165ccd0da98ebd3e2d5f9b230d5afa8. Commit 1738890a3165 ("clk: sunxi-ng: sun6i-rtc: Add support for H6") breaks HDMI output on Tanix TX6 mini board. Exact reason isn't known, but because that commit doesn't actually improve anything, let's just revert it. Cc: stable(a)vger.kernel.org Signed-off-by: Jernej Skrabec <jernej.skrabec(a)gmail.com> --- drivers/clk/sunxi-ng/ccu-sun6i-rtc.c | 15 --------------- drivers/rtc/rtc-sun6i.c | 17 +++++++++++++++++ 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c index 2f3ddc908ebd..d65398497d5f 100644 --- a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c +++ b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c @@ -298,10 +298,6 @@ static const struct sunxi_ccu_desc sun6i_rtc_ccu_desc = { .hw_clks = &sun6i_rtc_ccu_hw_clks, }; -static const struct clk_parent_data sun50i_h6_osc32k_fanout_parents[] = { - { .hw = &osc32k_clk.common.hw }, -}; - static const struct clk_parent_data sun50i_h616_osc32k_fanout_parents[] = { { .hw = &osc32k_clk.common.hw }, { .fw_name = "pll-32k" }, @@ -314,13 +310,6 @@ static const struct clk_parent_data sun50i_r329_osc32k_fanout_parents[] = { { .hw = &osc24M_32k_clk.common.hw } }; -static const struct sun6i_rtc_match_data sun50i_h6_rtc_ccu_data = { - .have_ext_osc32k = true, - .have_iosc_calibration = true, - .osc32k_fanout_parents = sun50i_h6_osc32k_fanout_parents, - .osc32k_fanout_nparents = ARRAY_SIZE(sun50i_h6_osc32k_fanout_parents), -}; - static const struct sun6i_rtc_match_data sun50i_h616_rtc_ccu_data = { .have_iosc_calibration = true, .rtc_32k_single_parent = true, @@ -335,10 +324,6 @@ static const struct sun6i_rtc_match_data sun50i_r329_rtc_ccu_data = { }; static const struct of_device_id sun6i_rtc_ccu_match[] = { - { - .compatible = "allwinner,sun50i-h6-rtc", - .data = &sun50i_h6_rtc_ccu_data, - }, { .compatible = "allwinner,sun50i-h616-rtc", .data = &sun50i_h616_rtc_ccu_data, diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c index 5b3e4da63406..5252ce4cbda4 100644 --- a/drivers/rtc/rtc-sun6i.c +++ b/drivers/rtc/rtc-sun6i.c @@ -370,6 +370,23 @@ CLK_OF_DECLARE_DRIVER(sun8i_h3_rtc_clk, "allwinner,sun8i-h3-rtc", CLK_OF_DECLARE_DRIVER(sun50i_h5_rtc_clk, "allwinner,sun50i-h5-rtc", sun8i_h3_rtc_clk_init); +static const struct sun6i_rtc_clk_data sun50i_h6_rtc_data = { + .rc_osc_rate = 16000000, + .fixed_prescaler = 32, + .has_prescaler = 1, + .has_out_clk = 1, + .export_iosc = 1, + .has_losc_en = 1, + .has_auto_swt = 1, +}; + +static void __init sun50i_h6_rtc_clk_init(struct device_node *node) +{ + sun6i_rtc_clk_init(node, &sun50i_h6_rtc_data); +} +CLK_OF_DECLARE_DRIVER(sun50i_h6_rtc_clk, "allwinner,sun50i-h6-rtc", + sun50i_h6_rtc_clk_init); + /* * The R40 user manual is self-conflicting on whether the prescaler is * fixed or configurable. The clock diagram shows it as fixed, but there -- 2.36.1

2 years, 8 months

2
1
0 0

[git:media_stage/master] media: i2c: imx412: Fix power_off ordering

by Mauro Carvalho Chehab

This is an automatic generated email to let you know that the following patch were queued: Subject: media: i2c: imx412: Fix power_off ordering Author: Bryan O'Donoghue <bryan.odonoghue(a)linaro.org> Date: Fri Apr 15 13:59:52 2022 +0200 The enable path does - gpio - clock The disable path does - gpio - clock Fix the order on the power-off path so that power-off and power-on have the same ordering for clock and gpio. Fixes: 9214e86c0cc1 ("media: i2c: Add imx412 camera sensor driver") Cc: stable(a)vger.kernel.org Signed-off-by: Bryan O'Donoghue <bryan.odonoghue(a)linaro.org> Reviewed-by: Jacopo Mondi <jacopo(a)jmondi.org> Reviewed-by: Daniele Alessandrelli <daniele.alessandrelli(a)intel.com> Signed-off-by: Sakari Ailus <sakari.ailus(a)linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab(a)kernel.org> drivers/media/i2c/imx412.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- diff --git a/drivers/media/i2c/imx412.c b/drivers/media/i2c/imx412.c index e6be6b4250f5..84279a680873 100644 --- a/drivers/media/i2c/imx412.c +++ b/drivers/media/i2c/imx412.c @@ -1040,10 +1040,10 @@ static int imx412_power_off(struct device *dev) struct v4l2_subdev *sd = dev_get_drvdata(dev); struct imx412 *imx412 = to_imx412(sd); - gpiod_set_value_cansleep(imx412->reset_gpio, 1); - clk_disable_unprepare(imx412->inclk); + gpiod_set_value_cansleep(imx412->reset_gpio, 1); + return 0; }

2 years, 8 months

1
0
0 0

[git:media_stage/master] media: i2c: imx412: Fix reset GPIO polarity

by Mauro Carvalho Chehab

This is an automatic generated email to let you know that the following patch were queued: Subject: media: i2c: imx412: Fix reset GPIO polarity Author: Bryan O'Donoghue <bryan.odonoghue(a)linaro.org> Date: Fri Apr 15 13:59:51 2022 +0200 The imx412/imx577 sensor has a reset line that is active low not active high. Currently the logic for this is inverted. The right way to define the reset line is to declare it active low in the DTS and invert the logic currently contained in the driver. The DTS should represent the hardware does i.e. reset is active low. So: + reset-gpios = <&tlmm 78 GPIO_ACTIVE_LOW>; not: - reset-gpios = <&tlmm 78 GPIO_ACTIVE_HIGH>; I was a bit reticent about changing this logic since I thought it might negatively impact @intel.com users. Googling a bit though I believe this sensor is used on "Keem Bay" which is clearly a DTS based system and is not upstream yet. Fixes: 9214e86c0cc1 ("media: i2c: Add imx412 camera sensor driver") Cc: stable(a)vger.kernel.org Signed-off-by: Bryan O'Donoghue <bryan.odonoghue(a)linaro.org> Reviewed-by: Jacopo Mondi <jacopo(a)jmondi.org> Reviewed-by: Daniele Alessandrelli <daniele.alessandrelli(a)intel.com> Signed-off-by: Sakari Ailus <sakari.ailus(a)linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab(a)kernel.org> drivers/media/i2c/imx412.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- diff --git a/drivers/media/i2c/imx412.c b/drivers/media/i2c/imx412.c index be3f6ea55559..e6be6b4250f5 100644 --- a/drivers/media/i2c/imx412.c +++ b/drivers/media/i2c/imx412.c @@ -1011,7 +1011,7 @@ static int imx412_power_on(struct device *dev) struct imx412 *imx412 = to_imx412(sd); int ret; - gpiod_set_value_cansleep(imx412->reset_gpio, 1); + gpiod_set_value_cansleep(imx412->reset_gpio, 0); ret = clk_prepare_enable(imx412->inclk); if (ret) { @@ -1024,7 +1024,7 @@ static int imx412_power_on(struct device *dev) return 0; error_reset: - gpiod_set_value_cansleep(imx412->reset_gpio, 0); + gpiod_set_value_cansleep(imx412->reset_gpio, 1); return ret; } @@ -1040,7 +1040,7 @@ static int imx412_power_off(struct device *dev) struct v4l2_subdev *sd = dev_get_drvdata(dev); struct imx412 *imx412 = to_imx412(sd); - gpiod_set_value_cansleep(imx412->reset_gpio, 0); + gpiod_set_value_cansleep(imx412->reset_gpio, 1); clk_disable_unprepare(imx412->inclk);

2 years, 8 months

1
0
0 0

Hello

by Mrs.cecille Letty Tan

How are you doing today, I hope you get my message urgently, please.

2 years, 8 months

1
0
0 0

stable-rc/queue/5.4 baseline: 122 runs, 16 regressions (v5.4.194-43-gc3af9d8d19824)

by kernelci.org bot

stable-rc/queue/5.4 baseline: 122 runs, 16 regressions (v5.4.194-43-gc3af9d8d19824) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2 | arm64 | lab-baylibre | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv2 | arm64 | lab-baylibre | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv2 | arm64 | lab-broonie | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv2 | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv2-uefi | arm64 | lab-baylibre | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv2-uefi | arm64 | lab-baylibre | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv2-uefi | arm64 | lab-broonie | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv2-uefi | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv3 | arm64 | lab-baylibre | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv3 | arm64 | lab-baylibre | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv3 | arm64 | lab-broonie | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv3 | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv3-uefi | arm64 | lab-baylibre | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv3-uefi | arm64 | lab-baylibre | gcc-10 | defconfig+arm64-chromebook | 1 qemu_arm64-virt-gicv3-uefi | arm64 | lab-broonie | gcc-10 | defconfig | 1 qemu_arm64-virt-gicv3-uefi | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F5.4/kernel/v5.4.194-… Test: baseline Tree: stable-rc Branch: queue/5.4 Describe: v5.4.194-43-gc3af9d8d19824 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: c3af9d8d1982499d5654721039ae943574474aee Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2 | arm64 | lab-baylibre | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/6282f77e6bc2339ece8f573a Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/6282f77e6bc2339ece8f573b failing since 6 days (last pass: v5.4.191-77-g1a3b249e415b, first fail: v5.4.191-125-g5917d1547e6e) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2 | arm64 | lab-baylibre | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/6282f84957751a7ece8f5762 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/6282f84957751a7ece8f5763 failing since 6 days (last pass: v5.4.191-84-g56ce42d78d96, first fail: v5.4.191-125-g5917d1547e6e) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2 | arm64 | lab-broonie | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/6282f7e8eda415ba818f571d Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/6282f7e8eda415ba818f571e failing since 6 days (last pass: v5.4.191-77-g1a3b249e415b, first fail: v5.4.191-125-g5917d1547e6e) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2 | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/6282f979d7290ade008f5759 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/6282f979d7290ade008f575a failing since 6 days (last pass: v5.4.191-84-g56ce42d78d96, first fail: v5.4.191-125-g5917d1547e6e) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2-uefi | arm64 | lab-baylibre | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/6282f79510a2ed45378f5723 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/6282f79510a2ed45378f5724 failing since 6 days (last pass: v5.4.191-77-g1a3b249e415b, first fail: v5.4.191-125-g5917d1547e6e) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2-uefi | arm64 | lab-baylibre | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/6282f84757751a7ece8f575c Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/6282f84757751a7ece8f575d failing since 6 days (last pass: v5.4.191-84-g56ce42d78d96, first fail: v5.4.191-125-g5917d1547e6e) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2-uefi | arm64 | lab-broonie | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/6282f7fe4e48f012e88f5722 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/6282f7fe4e48f012e88f5723 failing since 6 days (last pass: v5.4.191-77-g1a3b249e415b, first fail: v5.4.191-125-g5917d1547e6e) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv2-uefi | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/6282f964d7290ade008f5726 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/6282f964d7290ade008f5727 failing since 6 days (last pass: v5.4.191-84-g56ce42d78d96, first fail: v5.4.191-125-g5917d1547e6e) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3 | arm64 | lab-baylibre | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/6282f79310a2ed45378f571d Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/6282f79310a2ed45378f571e failing since 6 days (last pass: v5.4.191-77-g1a3b249e415b, first fail: v5.4.191-125-g5917d1547e6e) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3 | arm64 | lab-baylibre | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/6282f84a169e8271c08f572d Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/6282f84a169e8271c08f572e failing since 6 days (last pass: v5.4.191-84-g56ce42d78d96, first fail: v5.4.191-125-g5917d1547e6e) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3 | arm64 | lab-broonie | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/6282f7d4b59f82c52b8f577f Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/6282f7d4b59f82c52b8f5780 failing since 6 days (last pass: v5.4.191-77-g1a3b249e415b, first fail: v5.4.191-125-g5917d1547e6e) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3 | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/6282f98d82f8343dce8f5725 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/6282f98d82f8343dce8f5726 failing since 6 days (last pass: v5.4.191-84-g56ce42d78d96, first fail: v5.4.191-125-g5917d1547e6e) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3-uefi | arm64 | lab-baylibre | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/6282f7940b027f115a8f5730 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/6282f7940b027f115a8f5731 failing since 6 days (last pass: v5.4.191-77-g1a3b249e415b, first fail: v5.4.191-125-g5917d1547e6e) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3-uefi | arm64 | lab-baylibre | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/6282f84857751a7ece8f575f Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/6282f84857751a7ece8f5760 failing since 6 days (last pass: v5.4.191-84-g56ce42d78d96, first fail: v5.4.191-125-g5917d1547e6e) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3-uefi | arm64 | lab-broonie | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/6282f7fcba3dff77bc8f5723 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/6282f7fcba3dff77bc8f5724 failing since 6 days (last pass: v5.4.191-77-g1a3b249e415b, first fail: v5.4.191-125-g5917d1547e6e) platform | arch | lab | compiler | defconfig | regressions ---------------------------+-------+--------------+----------+----------------------------+------------ qemu_arm64-virt-gicv3-uefi | arm64 | lab-broonie | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/6282f9660f85a641d18f5717 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.194-43-gc3af9d8d1982… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/6282f9660f85a641d18f5718 failing since 6 days (last pass: v5.4.191-84-g56ce42d78d96, first fail: v5.4.191-125-g5917d1547e6e)

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror May 2022