March 2022 - Linux-stable-mirror

[char-misc-next] mei: avoid iterator usage outside of list_for_each_entry

by Tomas Winkler

From: Alexander Usyskin <alexander.usyskin(a)intel.com> Usage of the iterator outside of the list_for_each_entry is considered harmful. https://lkml.org/lkml/2022/2/17/1032 Do not reference the loop variable outside of the loop, by rearranging the orders of execution. Instead of performing search loop and checking outside the loop if the end of the list was hit and no matching element was found, the execution is performed inside the loop upon a successful match followed by a goto statement to the next step, therefore no condition has to be performed after the loop has ended. Cc: <stable(a)vger.kernel.org> Signed-off-by: Alexander Usyskin <alexander.usyskin(a)intel.com> Signed-off-by: Tomas Winkler <tomas.winkler(a)intel.com> --- drivers/misc/mei/interrupt.c | 35 +++++++++++++++-------------------- 1 file changed, 15 insertions(+), 20 deletions(-) diff --git a/drivers/misc/mei/interrupt.c b/drivers/misc/mei/interrupt.c index a67f4f2d33a9..0706322154cb 100644 --- a/drivers/misc/mei/interrupt.c +++ b/drivers/misc/mei/interrupt.c @@ -424,31 +424,26 @@ int mei_irq_read_handler(struct mei_device *dev, list_for_each_entry(cl, &dev->file_list, link) { if (mei_cl_hbm_equal(cl, mei_hdr)) { cl_dbg(dev, cl, "got a message\n"); - break; + ret = mei_cl_irq_read_msg(cl, mei_hdr, meta_hdr, cmpl_list); + goto reset_slots; } } /* if no recipient cl was found we assume corrupted header */ - if (&cl->link == &dev->file_list) { - /* A message for not connected fixed address clients - * should be silently discarded - * On power down client may be force cleaned, - * silently discard such messages - */ - if (hdr_is_fixed(mei_hdr) || - dev->dev_state == MEI_DEV_POWER_DOWN) { - mei_irq_discard_msg(dev, mei_hdr, mei_hdr->length); - ret = 0; - goto reset_slots; - } - dev_err(dev->dev, "no destination client found 0x%08X\n", - dev->rd_msg_hdr[0]); - ret = -EBADMSG; - goto end; + /* A message for not connected fixed address clients + * should be silently discarded + * On power down client may be force cleaned, + * silently discard such messages + */ + if (hdr_is_fixed(mei_hdr) || + dev->dev_state == MEI_DEV_POWER_DOWN) { + mei_irq_discard_msg(dev, mei_hdr, mei_hdr->length); + ret = 0; + goto reset_slots; } - - ret = mei_cl_irq_read_msg(cl, mei_hdr, meta_hdr, cmpl_list); - + dev_err(dev->dev, "no destination client found 0x%08X\n", dev->rd_msg_hdr[0]); + ret = -EBADMSG; + goto end; reset_slots: /* reset the number of slots and header */ -- 2.35.1

3 years, 9 months

1
0
0 0

Please I need your help my name is Mariam.

by Miss. Mariam Musa

Good day, Can I write you here? I have urgent information for you here, With utmost good faith?, as you know that my country have been in deep crisis due to the war, Miss. Mariam Musa.

3 years, 9 months

1
0
0 0

Pytanie o samochód

by Marcin Chruszcz

Dzień dobry, Czy interesuje Państwa rozwiązanie umożliwiające monitorowanie samochodów firmowych oraz optymalizację kosztów ich utrzymania? Pozdrawiam, Marcin Chruszcz

3 years, 9 months

1
0
0 0

stable-rc/queue/5.10 baseline: 117 runs, 3 regressions (v5.10.103-105-gf074cce6ae0d)

by kernelci.org bot

stable-rc/queue/5.10 baseline: 117 runs, 3 regressions (v5.10.103-105-gf074cce6ae0d) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions -------------------------+-------+---------------+----------+----------------------------+------------ imx6q-var-dt6customboard | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 2 rk3399-gru-kevin | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F5.10/kernel/v5.10.10… Test: baseline Tree: stable-rc Branch: queue/5.10 Describe: v5.10.103-105-gf074cce6ae0d URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: f074cce6ae0da57a1e46c555c2c25fa66b630463 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions -------------------------+-------+---------------+----------+----------------------------+------------ imx6q-var-dt6customboard | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 2 Details: https://kernelci.org/test/plan/id/62267cd1be3f2a7df8c629c8 Results: 4 PASS, 2 FAIL, 1 SKIP Full config: multi_v7_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.10/v5.10.103-105-gf074cce6a… HTML log: https://storage.kernelci.org//stable-rc/queue-5.10/v5.10.103-105-gf074cce6a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.dmesg.alert: https://kernelci.org/test/case/id/62267cd1be3f2a7df8c629cc new failure (last pass: v5.10.103-99-g803f589c9a5f) 4 lines 2022-03-07T21:44:32.664688 kern :alert : 8<--- cut here --- 2022-03-07T21:44:32.695635 kern :alert : Unhandled fault: alignment exception (0x001) at 0xcec60217 2022-03-07T21:44:32.695893 kern :alert : pgd = a43a2a39 2022-03-07T21:44:32.696991 kern :alert : [<8>[ 14.609385] <LAVA_SIGNAL_TESTCASE TEST_CASE_ID=alert RESULT=fail UNITS=lines MEASUREMENT=4> 2022-03-07T21:44:32.697250 cec60217] *pgd=1ec1141e(bad) * baseline.dmesg.emerg: https://kernelci.org/test/case/id/62267cd1be3f2a7df8c629cd new failure (last pass: v5.10.103-99-g803f589c9a5f) 26 lines 2022-03-07T21:44:32.748350 kern :emerg : Internal error: : 1 [#1] SMP ARM 2022-03-07T21:44:32.748618 kern :emerg : Process kworker/0:3 (pid: 52, stack limit = 0x24fcbb5d) 2022-03-07T21:44:32.749098 kern :emerg : Stack: (0xc2395eb0 to<8>[ 14.656402] <LAVA_SIGNAL_TESTCASE TEST_CASE_ID=emerg RESULT=fail UNITS=lines MEASUREMENT=26> 2022-03-07T21:44:32.749338 0xc2396000) 2022-03-07T21:44:32.749561 kern :emerg : 5ea0<8>[ 14.667663] <LAVA_SIGNAL_ENDRUN 0_dmesg 1656325_1.5.2.4.1> 2022-03-07T21:44:32.749781 : 1e9b10fe 862c74a2 c2394000 cec60217 platform | arch | lab | compiler | defconfig | regressions -------------------------+-------+---------------+----------+----------------------------+------------ rk3399-gru-kevin | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/62267e4b1e5009e48fc629b7 Results: 90 PASS, 2 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.10/v5.10.103-105-gf074cce6a… HTML log: https://storage.kernelci.org//stable-rc/queue-5.10/v5.10.103-105-gf074cce6a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.bootrr.rockchip-i2s1-probed: https://kernelci.org/test/case/id/62267e4b1e5009e48fc629db new failure (last pass: v5.10.103-56-ge5a40f18f4ce) 2022-03-07T21:50:41.806124 /lava-5831647/1/../bin/lava-test-case

3 years, 9 months

1
0
0 0

stable-rc/queue/4.19 baseline: 86 runs, 1 regressions (v4.19.232-52-g77cac508ebda)

by kernelci.org bot

stable-rc/queue/4.19 baseline: 86 runs, 1 regressions (v4.19.232-52-g77cac508ebda) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions -----------------+-------+---------------+----------+----------------------------+------------ rk3399-gru-kevin | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F4.19/kernel/v4.19.23… Test: baseline Tree: stable-rc Branch: queue/4.19 Describe: v4.19.232-52-g77cac508ebda URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 77cac508ebda6a4b835d670c84cfa1b748f53b68 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions -----------------+-------+---------------+----------+----------------------------+------------ rk3399-gru-kevin | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/622677f159527cf156c6297c Results: 83 PASS, 7 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.232-52-g77cac508eb… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.232-52-g77cac508eb… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.bootrr.rockchip-i2s1-probed: https://kernelci.org/test/case/id/622677f159527cf156c629a2 failing since 1 day (last pass: v4.19.232-31-g5cf846953aa2, first fail: v4.19.232-44-gfd65e02206f4) 2022-03-07T21:23:47.505016 /lava-5831397/1/../bin/lava-test-case<8>[ 35.816265] <LAVA_SIGNAL_TESTCASE TEST_CASE_ID=rockchip-i2s0-probed RESULT=pass> 2022-03-07T21:23:47.505277 2022-03-07T21:23:48.520393 /lava-5831397/1/../bin/lava-test-case

3 years, 9 months

1
0
0 0

stable-rc/linux-4.19.y baseline: 87 runs, 1 regressions (v4.19.232-53-ge227a7bfe445)

by kernelci.org bot

stable-rc/linux-4.19.y baseline: 87 runs, 1 regressions (v4.19.232-53-ge227a7bfe445) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ------------------------+-------+------------+----------+-----------+------------ sun50i-a64-bananapi-m64 | arm64 | lab-clabbe | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/linux-4.19.y/kernel/v4.19.23… Test: baseline Tree: stable-rc Branch: linux-4.19.y Describe: v4.19.232-53-ge227a7bfe445 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: e227a7bfe445a282a8ba16771c3716b19839820b Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ------------------------+-------+------------+----------+-----------+------------ sun50i-a64-bananapi-m64 | arm64 | lab-clabbe | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/622671ebc804a96074c629ee Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/linux-4.19.y/v4.19.232-53-ge227a7bf… HTML log: https://storage.kernelci.org//stable-rc/linux-4.19.y/v4.19.232-53-ge227a7bf… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/622671ebc804a96074c629ef new failure (last pass: v4.19.232-45-g5da8d73687e7)

3 years, 9 months

1
0
0 0

stable-rc/linux-5.15.y baseline: 124 runs, 3 regressions (v5.15.26-258-g7b9aacd770fa)

by kernelci.org bot

stable-rc/linux-5.15.y baseline: 124 runs, 3 regressions (v5.15.26-258-g7b9aacd770fa) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions --------------------------+--------+---------------+----------+------------------------------+------------ beagle-xm | arm | lab-baylibre | gcc-10 | omap2plus_defconfig | 1 hp-x360-12b-n4000-octopus | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 rk3399-gru-kevin | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/job/stable-rc/branch/linux-5.15.y/kernel/v5.15.26… Test: baseline Tree: stable-rc Branch: linux-5.15.y Describe: v5.15.26-258-g7b9aacd770fa URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 7b9aacd770fa105a0a5f0be43bc72ce176d30331 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions --------------------------+--------+---------------+----------+------------------------------+------------ beagle-xm | arm | lab-baylibre | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/plan/id/62266d1084375c6f51c62999 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: omap2plus_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/linux-5.15.y/v5.15.26-258-g7b9aacd7… HTML log: https://storage.kernelci.org//stable-rc/linux-5.15.y/v5.15.26-258-g7b9aacd7… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62266d1084375c6f51c6299a failing since 46 days (last pass: v5.15.14-70-g9cb47c4d3cbf, first fail: v5.15.16) platform | arch | lab | compiler | defconfig | regressions --------------------------+--------+---------------+----------+------------------------------+------------ hp-x360-12b-n4000-octopus | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/plan/id/62266f6a7a839ea807c62989 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig+x86-chromebook Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/linux-5.15.y/v5.15.26-258-g7b9aacd7… HTML log: https://storage.kernelci.org//stable-rc/linux-5.15.y/v5.15.26-258-g7b9aacd7… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62266f6a7a839ea807c6298a new failure (last pass: v5.15.26-246-ged373242c999) platform | arch | lab | compiler | defconfig | regressions --------------------------+--------+---------------+----------+------------------------------+------------ rk3399-gru-kevin | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/62267208de6a7904e8c6298d Results: 88 PASS, 4 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/linux-5.15.y/v5.15.26-258-g7b9aacd7… HTML log: https://storage.kernelci.org//stable-rc/linux-5.15.y/v5.15.26-258-g7b9aacd7… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.bootrr.rockchip-i2s1-probed: https://kernelci.org/test/case/id/62267208de6a7904e8c629b1 new failure (last pass: v5.15.26) 2022-03-07T20:58:21.290565 /lava-5831128/1/../bin/lava-test-case

3 years, 9 months

1
0
0 0

stable-rc/linux-5.10.y baseline: 130 runs, 2 regressions (v5.10.103-106-g79bd6348914c)

by kernelci.org bot

stable-rc/linux-5.10.y baseline: 130 runs, 2 regressions (v5.10.103-106-g79bd6348914c) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ------------------------+-------+---------------+----------+----------------------------+------------ rk3399-gru-kevin | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 sun50i-a64-bananapi-m64 | arm64 | lab-clabbe | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/linux-5.10.y/kernel/v5.10.10… Test: baseline Tree: stable-rc Branch: linux-5.10.y Describe: v5.10.103-106-g79bd6348914c URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 79bd6348914c7f6f715fb706a7dde1de833e6fef Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ------------------------+-------+---------------+----------+----------------------------+------------ rk3399-gru-kevin | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/62266d9ebd8d55406cc629a6 Results: 90 PASS, 2 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/linux-5.10.y/v5.10.103-106-g79bd634… HTML log: https://storage.kernelci.org//stable-rc/linux-5.10.y/v5.10.103-106-g79bd634… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.bootrr.rockchip-i2s1-probed: https://kernelci.org/test/case/id/62266d9ebd8d55406cc629cc new failure (last pass: v5.10.103) 2022-03-07T20:39:52.088819 /lava-5831090/1/../bin/lava-test-case platform | arch | lab | compiler | defconfig | regressions ------------------------+-------+---------------+----------+----------------------------+------------ sun50i-a64-bananapi-m64 | arm64 | lab-clabbe | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/622666fa1ec13e925ac62976 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/linux-5.10.y/v5.10.103-106-g79bd634… HTML log: https://storage.kernelci.org//stable-rc/linux-5.10.y/v5.10.103-106-g79bd634… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/622666fa1ec13e925ac62977 new failure (last pass: v5.10.103-95-g552e594da6e8)

3 years, 9 months

1
0
0 0

stable-rc/queue/5.4 baseline: 83 runs, 2 regressions (v5.4.182-65-g5aabde525ba7)

by kernelci.org bot

stable-rc/queue/5.4 baseline: 83 runs, 2 regressions (v5.4.182-65-g5aabde525ba7) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions -----------------+-------+---------------+----------+----------------------------+------------ meson-gxm-q200 | arm64 | lab-baylibre | gcc-10 | defconfig | 1 rk3399-gru-kevin | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F5.4/kernel/v5.4.182-… Test: baseline Tree: stable-rc Branch: queue/5.4 Describe: v5.4.182-65-g5aabde525ba7 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 5aabde525ba7e106feb1a768e9ec3dd78b472dc3 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions -----------------+-------+---------------+----------+----------------------------+------------ meson-gxm-q200 | arm64 | lab-baylibre | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/62266e7cde060a42ecc629a4 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.182-65-g5aabde525ba7… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.182-65-g5aabde525ba7… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/62266e7cde060a42ecc629a5 failing since 1 day (last pass: v5.4.182-53-ge31c0b084082, first fail: v5.4.182-53-gb54ccf4e0b7c) platform | arch | lab | compiler | defconfig | regressions -----------------+-------+---------------+----------+----------------------------+------------ rk3399-gru-kevin | arm64 | lab-collabora | gcc-10 | defconfig+arm64-chromebook | 1 Details: https://kernelci.org/test/plan/id/622664c7afeaac1554c6296e Results: 88 PASS, 2 FAIL, 0 SKIP Full config: defconfig+arm64-chromebook Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.182-65-g5aabde525ba7… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.182-65-g5aabde525ba7… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.bootrr.rockchip-i2s1-probed: https://kernelci.org/test/case/id/622664c7afeaac1554c62994 failing since 1 day (last pass: v5.4.182-30-g45ccd59cc16f, first fail: v5.4.182-53-ge31c0b084082) 2022-03-07T20:02:01.215385 <8>[ 31.703669] <LAVA_SIGNAL_TESTCASE TEST_CASE_ID=rockchip-i2s0-probed RESULT=pass> 2022-03-07T20:02:02.227187 /lava-5830692/1/../bin/lava-test-case

3 years, 9 months

1
0
0 0

+ hugetlb-do-not-demote-poisoned-hugetlb-pages.patch added to -mm tree

by Andrew Morton

The patch titled Subject: hugetlb: do not demote poisoned hugetlb pages has been added to the -mm tree. Its filename is hugetlb-do-not-demote-poisoned-hugetlb-pages.patch This patch should soon appear at https://ozlabs.org/~akpm/mmots/broken-out/hugetlb-do-not-demote-poisoned-hu… and later at https://ozlabs.org/~akpm/mmotm/broken-out/hugetlb-do-not-demote-poisoned-hu… Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Mike Kravetz <mike.kravetz(a)oracle.com> Subject: hugetlb: do not demote poisoned hugetlb pages It is possible for poisoned hugetlb pages to reside on the free lists. The huge page allocation routines which dequeue entries from the free lists make a point of avoiding poisoned pages. There is no such check and avoidance in the demote code path. If a hugetlb page on the is on a free list, poison will only be set in the head page rather then the page with the actual error. If such a page is demoted, then the poison flag may follow the wrong page. A page without error could have poison set, and a page with poison could not have the flag set. Check for poison before attempting to demote a hugetlb page. Also, return -EBUSY to the caller if only poisoned pages are on the free list. Link: https://lkml.kernel.org/r/20220307215707.50916-1-mike.kravetz@oracle.com Fixes: 8531fc6f52f5 ("hugetlb: add hugetlb demote page support") Signed-off-by: Mike Kravetz <mike.kravetz(a)oracle.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/hugetlb.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) --- a/mm/hugetlb.c~hugetlb-do-not-demote-poisoned-hugetlb-pages +++ a/mm/hugetlb.c @@ -3469,7 +3469,6 @@ static int demote_pool_huge_page(struct { int nr_nodes, node; struct page *page; - int rc = 0; lockdep_assert_held(&hugetlb_lock); @@ -3480,15 +3479,19 @@ static int demote_pool_huge_page(struct } for_each_node_mask_to_free(h, nr_nodes, node, nodes_allowed) { - if (!list_empty(&h->hugepage_freelists[node])) { - page = list_entry(h->hugepage_freelists[node].next, - struct page, lru); - rc = demote_free_huge_page(h, page); - break; + list_for_each_entry(page, &h->hugepage_freelists[node], lru) { + if (PageHWPoison(page)) + continue; + + return demote_free_huge_page(h, page); } } - return rc; + /* + * Only way to get here is if all pages on free lists are poisoned. + * Return -EBUSY so that caller will not retry. + */ + return -EBUSY; } #define HSTATE_ATTR_RO(_name) \ _ Patches currently in -mm which might be from mike.kravetz(a)oracle.com are hugetlb-do-not-demote-poisoned-hugetlb-pages.patch hugetlb-clean-up-potential-spectre-issue-warnings.patch hugetlb-clean-up-potential-spectre-issue-warnings-v2.patch mm-enable-madv_dontneed-for-hugetlb-mappings.patch selftests-vm-add-hugetlb-madvise-madv_dontneed-madv_remove-test.patch userfaultfd-selftests-enable-hugetlb-remap-and-remove-event-testing.patch

3 years, 9 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror March 2022