February 2022 - Linux-stable-mirror

[PATCH 1/3] ice: Fix race conditions between virtchnl handling and VF ndo ops

by Jacob Keller

From: Brett Creeley <brett.creeley(a)intel.com> commit e6ba5273d4ede03d075d7a116b8edad1f6115f4d upstream. [I had to fix the cherry-pick manually as the patch added a line around some context that was missing.] The VF can be configured via the PF's ndo ops at the same time the PF is receiving/handling virtchnl messages. This has many issues, with one of them being the ndo op could be actively resetting a VF (i.e. resetting it to the default state and deleting/re-adding the VF's VSI) while a virtchnl message is being handled. The following error was seen because a VF ndo op was used to change a VF's trust setting while the VIRTCHNL_OP_CONFIG_VSI_QUEUES was ongoing: [35274.192484] ice 0000:88:00.0: Failed to set LAN Tx queue context, error: ICE_ERR_PARAM [35274.193074] ice 0000:88:00.0: VF 0 failed opcode 6, retval: -5 [35274.193640] iavf 0000:88:01.0: PF returned error -5 (IAVF_ERR_PARAM) to our request 6 Fix this by making sure the virtchnl handling and VF ndo ops that trigger VF resets cannot run concurrently. This is done by adding a struct mutex cfg_lock to each VF structure. For VF ndo ops, the mutex will be locked around the critical operations and VFR. Since the ndo ops will trigger a VFR, the virtchnl thread will use mutex_trylock(). This is done because if any other thread (i.e. VF ndo op) has the mutex, then that means the current VF message being handled is no longer valid, so just ignore it. This issue can be seen using the following commands: for i in {0..50}; do rmmod ice modprobe ice sleep 1 echo 1 > /sys/class/net/ens785f0/device/sriov_numvfs echo 1 > /sys/class/net/ens785f1/device/sriov_numvfs ip link set ens785f1 vf 0 trust on ip link set ens785f0 vf 0 trust on sleep 2 echo 0 > /sys/class/net/ens785f0/device/sriov_numvfs echo 0 > /sys/class/net/ens785f1/device/sriov_numvfs sleep 1 echo 1 > /sys/class/net/ens785f0/device/sriov_numvfs echo 1 > /sys/class/net/ens785f1/device/sriov_numvfs ip link set ens785f1 vf 0 trust on ip link set ens785f0 vf 0 trust on done Fixes: 7c710869d64e ("ice: Add handlers for VF netdevice operations") Cc: <stable(a)vger.kernel.org> # 5.13.x Signed-off-by: Brett Creeley <brett.creeley(a)intel.com> Tested-by: Konrad Jankowski <konrad0.jankowski(a)intel.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen(a)intel.com> Signed-off-by: Jacob Keller <jacob.e.keller(a)intel.com> --- This should apply to 5.13 .../net/ethernet/intel/ice/ice_virtchnl_pf.c | 25 +++++++++++++++++++ .../net/ethernet/intel/ice/ice_virtchnl_pf.h | 5 ++++ 2 files changed, 30 insertions(+) diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c index 671902d9fc35..2629d670bbbf 100644 --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c @@ -647,6 +647,8 @@ void ice_free_vfs(struct ice_pf *pf) set_bit(ICE_VF_STATE_DIS, pf->vf[i].vf_states); ice_free_vf_res(&pf->vf[i]); } + + mutex_destroy(&pf->vf[i].cfg_lock); } if (ice_sriov_free_msix_res(pf)) @@ -1893,6 +1895,8 @@ static void ice_set_dflt_settings_vfs(struct ice_pf *pf) */ ice_vf_ctrl_invalidate_vsi(vf); ice_vf_fdir_init(vf); + + mutex_init(&vf->cfg_lock); } } @@ -3955,6 +3959,8 @@ ice_set_vf_port_vlan(struct net_device *netdev, int vf_id, u16 vlan_id, u8 qos, return 0; } + mutex_lock(&vf->cfg_lock); + vf->port_vlan_info = vlanprio; if (vf->port_vlan_info) @@ -3964,6 +3970,7 @@ ice_set_vf_port_vlan(struct net_device *netdev, int vf_id, u16 vlan_id, u8 qos, dev_info(dev, "Clearing port VLAN on VF %d\n", vf_id); ice_vc_reset_vf(vf); + mutex_unlock(&vf->cfg_lock); return 0; } @@ -4338,6 +4345,15 @@ void ice_vc_process_vf_msg(struct ice_pf *pf, struct ice_rq_event_info *event) return; } + /* VF is being configured in another context that triggers a VFR, so no + * need to process this message + */ + if (!mutex_trylock(&vf->cfg_lock)) { + dev_info(dev, "VF %u is being configured in another context that will trigger a VFR, so there is no need to handle this message\n", + vf->vf_id); + return; + } + switch (v_opcode) { case VIRTCHNL_OP_VERSION: err = ice_vc_get_ver_msg(vf, msg); @@ -4426,6 +4442,8 @@ void ice_vc_process_vf_msg(struct ice_pf *pf, struct ice_rq_event_info *event) dev_info(dev, "PF failed to honor VF %d, opcode %d, error %d\n", vf_id, v_opcode, err); } + + mutex_unlock(&vf->cfg_lock); } /** @@ -4540,6 +4558,8 @@ int ice_set_vf_mac(struct net_device *netdev, int vf_id, u8 *mac) return -EINVAL; } + mutex_lock(&vf->cfg_lock); + /* VF is notified of its new MAC via the PF's response to the * VIRTCHNL_OP_GET_VF_RESOURCES message after the VF has been reset */ @@ -4557,6 +4577,7 @@ int ice_set_vf_mac(struct net_device *netdev, int vf_id, u8 *mac) } ice_vc_reset_vf(vf); + mutex_unlock(&vf->cfg_lock); return 0; } @@ -4586,11 +4607,15 @@ int ice_set_vf_trust(struct net_device *netdev, int vf_id, bool trusted) if (trusted == vf->trusted) return 0; + mutex_lock(&vf->cfg_lock); + vf->trusted = trusted; ice_vc_reset_vf(vf); dev_info(ice_pf_to_dev(pf), "VF %u is now %strusted\n", vf_id, trusted ? "" : "un"); + mutex_unlock(&vf->cfg_lock); + return 0; } diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h index d800ed83d6c3..3da39d63a24b 100644 --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h @@ -69,6 +69,11 @@ struct ice_mdd_vf_events { struct ice_vf { struct ice_pf *pf; + /* Used during virtchnl message handling and NDO ops against the VF + * that will trigger a VFR + */ + struct mutex cfg_lock; + u16 vf_id; /* VF ID in the PF space */ u16 lan_vsi_idx; /* index into PF struct */ u16 ctrl_vsi_idx; -- 2.35.1.355.ge7e302376dd6

3 years, 9 months

2
3
0 0

[PATCH 1/2] KEYS: asymmetric: enforce that sig algo matches key algo

by Eric Biggers

From: Eric Biggers <ebiggers(a)google.com> Most callers of public_key_verify_signature(), including most indirect callers via verify_signature() as well as pkcs7_verify_sig_chain(), don't check that public_key_signature::pkey_algo matches public_key::pkey_algo. These should always match. However, a malicious signature could intentionally declare an unintended algorithm. It is essential that such signatures be rejected outright, or that the algorithm of the *key* be used -- not the algorithm of the signature as that would allow attackers to choose the algorithm used. Currently, public_key_verify_signature() correctly uses the key's algorithm when deciding which akcipher to allocate. That's good. However, it uses the signature's algorithm when deciding whether to do the first step of SM2, which is incorrect. Also, v4.19 and older kernels used the signature's algorithm for the entire process. Prevent such errors by making public_key_verify_signature() enforce that the signature's algorithm matches the key's algorithm. Also remove two checks of this done by callers, which are now redundant. Cc: stable(a)vger.kernel.org Signed-off-by: Eric Biggers <ebiggers(a)google.com> --- crypto/asymmetric_keys/pkcs7_verify.c | 6 ------ crypto/asymmetric_keys/public_key.c | 15 +++++++++++++++ crypto/asymmetric_keys/x509_public_key.c | 6 ------ 3 files changed, 15 insertions(+), 12 deletions(-) diff --git a/crypto/asymmetric_keys/pkcs7_verify.c b/crypto/asymmetric_keys/pkcs7_verify.c index 0b4d07aa88111..f94a1d1ad3a6c 100644 --- a/crypto/asymmetric_keys/pkcs7_verify.c +++ b/crypto/asymmetric_keys/pkcs7_verify.c @@ -174,12 +174,6 @@ static int pkcs7_find_key(struct pkcs7_message *pkcs7, pr_devel("Sig %u: Found cert serial match X.509[%u]\n", sinfo->index, certix); - if (strcmp(x509->pub->pkey_algo, sinfo->sig->pkey_algo) != 0) { - pr_warn("Sig %u: X.509 algo and PKCS#7 sig algo don't match\n", - sinfo->index); - continue; - } - sinfo->signer = x509; return 0; } diff --git a/crypto/asymmetric_keys/public_key.c b/crypto/asymmetric_keys/public_key.c index 4fefb219bfdc8..aba7113d86c76 100644 --- a/crypto/asymmetric_keys/public_key.c +++ b/crypto/asymmetric_keys/public_key.c @@ -325,6 +325,21 @@ int public_key_verify_signature(const struct public_key *pkey, BUG_ON(!sig); BUG_ON(!sig->s); + /* + * The signature's claimed public key algorithm *must* match the key's + * actual public key algorithm. + * + * Small exception: ECDSA signatures don't specify the curve, but ECDSA + * keys do. So the strings can mismatch slightly in that case: + * "ecdsa-nist-*" for the key, but "ecdsa" for the signature. + */ + if (!sig->pkey_algo) + return -EINVAL; + if (strcmp(pkey->pkey_algo, sig->pkey_algo) != 0 && + (strncmp(pkey->pkey_algo, "ecdsa-", 6) != 0 || + strcmp(sig->pkey_algo, "ecdsa") != 0)) + return -EKEYREJECTED; + ret = software_key_determine_akcipher(sig->encoding, sig->hash_algo, pkey, alg_name); diff --git a/crypto/asymmetric_keys/x509_public_key.c b/crypto/asymmetric_keys/x509_public_key.c index fe14cae115b51..71cc1738fbfd2 100644 --- a/crypto/asymmetric_keys/x509_public_key.c +++ b/crypto/asymmetric_keys/x509_public_key.c @@ -128,12 +128,6 @@ int x509_check_for_self_signed(struct x509_certificate *cert) goto out; } - ret = -EKEYREJECTED; - if (strcmp(cert->pub->pkey_algo, cert->sig->pkey_algo) != 0 && - (strncmp(cert->pub->pkey_algo, "ecdsa-", 6) != 0 || - strcmp(cert->sig->pkey_algo, "ecdsa") != 0)) - goto out; - ret = public_key_verify_signature(cert->pub, cert->sig); if (ret < 0) { if (ret == -ENOPKG) { -- 2.35.1

3 years, 9 months

3
7
0 0

[PATCH] arm64: dts: qcom: ipq8074: fix the sleep clock frequency

by Kathiravan T

Sleep clock frequency should be 32768Hz. Lets fix it. Cc: stable(a)vger.kernel.org Fixes: 41dac73e243d ("arm64: dts: Add ipq8074 SoC and HK01 board support") Link: https://lore.kernel.org/all/e2a447f8-6024-0369-f698-2027b6edcf9e@codeaurora… Signed-off-by: Kathiravan T <quic_kathirav(a)quicinc.com> --- arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi index 26ba7ce9222c..b6287355ad08 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi @@ -13,7 +13,7 @@ clocks { sleep_clk: sleep_clk { compatible = "fixed-clock"; - clock-frequency = <32000>; + clock-frequency = <32768>; #clock-cells = <0>; }; -- 2.7.4

3 years, 9 months

3
3
0 0

[PATCH net] net: macb: Fix lost RX packet wakeup race in NAPI receive

by Robert Hancock

There is an oddity in the way the RSR register flags propagate to the ISR register (and the actual interrupt output) on this hardware: it appears that RSR register bits only result in ISR being asserted if the interrupt was actually enabled at the time, so enabling interrupts with RSR bits already set doesn't trigger an interrupt to be raised. There was already a partial fix for this race in the macb_poll function where it checked for RSR bits being set and re-triggered NAPI receive. However, there was a still a race window between checking RSR and actually enabling interrupts, where a lost wakeup could happen. It's necessary to check again after enabling interrupts to see if RSR was set just prior to the interrupt being enabled, and re-trigger receive in that case. This issue was noticed in a point-to-point UDP request-response protocol which periodically saw timeouts or abnormally high response times due to received packets not being processed in a timely fashion. In many applications, more packets arriving, including TCP retransmissions, would cause the original packet to be processed, thus masking the issue. Also change from using napi_reschedule to napi_schedule, as the only difference is the presence of a return value which wasn't used here anyway. Fixes: 02f7a34f34e3 ("net: macb: Re-enable RX interrupt only when RX is done") Cc: stable(a)vger.kernel.org Co-developed-by: Scott McNutt <scott.mcnutt(a)siriusxm.com> Signed-off-by: Scott McNutt <scott.mcnutt(a)siriusxm.com> Signed-off-by: Robert Hancock <robert.hancock(a)calian.com> --- drivers/net/ethernet/cadence/macb_main.c | 26 ++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 98498a76ae16..338660fe1d93 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -1573,14 +1573,36 @@ static int macb_poll(struct napi_struct *napi, int budget) if (work_done < budget) { napi_complete_done(napi, work_done); - /* Packets received while interrupts were disabled */ + /* RSR bits only seem to propagate to raise interrupts when + * interrupts are enabled at the time, so if bits are already + * set due to packets received while interrupts were disabled, + * they will not cause another interrupt to be generated when + * interrupts are re-enabled. + * Check for this case here. + */ status = macb_readl(bp, RSR); if (status) { if (bp->caps & MACB_CAPS_ISR_CLEAR_ON_WRITE) queue_writel(queue, ISR, MACB_BIT(RCOMP)); - napi_reschedule(napi); + napi_schedule(napi); } else { queue_writel(queue, IER, bp->rx_intr_mask); + + /* Packets could have been received in the window + * between the check above and re-enabling interrupts. + * Therefore, a double-check is required to avoid + * losing a wakeup. This can potentially race with + * the interrupt handler doing the same actions if an + * interrupt is raised just after enabling them, but + * this should be harmless. + */ + status = macb_readl(bp, RSR); + if (unlikely(status)) { + queue_writel(queue, IDR, bp->rx_intr_mask); + if (bp->caps & MACB_CAPS_ISR_CLEAR_ON_WRITE) + queue_writel(queue, ISR, MACB_BIT(RCOMP)); + napi_schedule(napi); + } } } -- 2.31.1

3 years, 9 months

2
2
0 0

[stable] usb: gadget: Fix potential use-after-free

by Ben Hutchings

Please pick these two commits for all stable branches: commit 89f3594d0de58e8a57d92d497dea9fee3d4b9cda Author: Hangyu Hua <hbh25y(a)gmail.com> Date: Sat Jan 1 01:21:37 2022 +0800 usb: gadget: don't release an existing dev->buf commit 501e38a5531efbd77d5c73c0ba838a889bfc1d74 Author: Hangyu Hua <hbh25y(a)gmail.com> Date: Sat Jan 1 01:21:38 2022 +0800 usb: gadget: clear related members when goto fail Ben. -- Ben Hutchings The first rule of tautology club is the first rule of tautology club.

3 years, 9 months

3
4
0 0

[PATCH AUTOSEL 4.19 01/13] mac80211_hwsim: report NOACK frames in tx_status

by Sasha Levin

From: Benjamin Beichler <benjamin.beichler(a)uni-rostock.de> [ Upstream commit 42a79960ffa50bfe9e0bf5d6280be89bf563a5dd ] Add IEEE80211_TX_STAT_NOACK_TRANSMITTED to tx_status flags to have proper statistics for non-acked frames. Signed-off-by: Benjamin Beichler <benjamin.beichler(a)uni-rostock.de> Link: https://lore.kernel.org/r/20220111221327.1499881-1-benjamin.beichler@uni-ro… Signed-off-by: Johannes Berg <johannes.berg(a)intel.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/net/wireless/mac80211_hwsim.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index 3564f5869b444..6cd9a8b610107 100644 --- a/drivers/net/wireless/mac80211_hwsim.c +++ b/drivers/net/wireless/mac80211_hwsim.c @@ -3176,6 +3176,10 @@ static int hwsim_tx_info_frame_received_nl(struct sk_buff *skb_2, } txi->flags |= IEEE80211_TX_STAT_ACK; } + + if (hwsim_flags & HWSIM_TX_CTL_NO_ACK) + txi->flags |= IEEE80211_TX_STAT_NOACK_TRANSMITTED; + ieee80211_tx_status_irqsafe(data2->hw, skb); return 0; out: -- 2.34.1

3 years, 9 months

2
16
0 0

[PATCH 4.9 00/29] 4.9.304-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.9.304 release. There are 29 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 02 Mar 2022 17:20:16 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.304-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.9.304-rc1 Linus Torvalds <torvalds(a)linux-foundation.org> fget: clarify and improve __fget_files() implementation Miaohe Lin <linmiaohe(a)huawei.com> memblock: use kfree() to release kmalloced memblock regions daniel.starke(a)siemens.com <daniel.starke(a)siemens.com> tty: n_gsm: fix proper link termination after failed open daniel.starke(a)siemens.com <daniel.starke(a)siemens.com> tty: n_gsm: fix encoding of control signal octet bit DV Hongyu Xie <xiehongyu1(a)kylinos.cn> xhci: Prevent futile URB re-submissions due to incorrect return value. Sebastian Andrzej Siewior <bigeasy(a)linutronix.de> usb: dwc3: gadget: Let the interrupt handler disable bottom halves. Daniele Palmas <dnlplm(a)gmail.com> USB: serial: option: add Telit LE910R1 compositions Slark Xiao <slark_xiao(a)163.com> USB: serial: option: add support for DW5829e Steven Rostedt (Google) <rostedt(a)goodmis.org> tracefs: Set the group ownership in apply_options() not parse_options() Szymon Heidrich <szymon.heidrich(a)gmail.com> USB: gadget: validate endpoint index for xilinx udc Daehwan Jung <dh10.jung(a)samsung.com> usb: gadget: rndis: add spinlock for rndis response list Dmytro Bagrii <dimich.dmb(a)gmail.com> Revert "USB: serial: ch341: add new Product ID for CH341A" Sergey Shtylyov <s.shtylyov(a)omp.ru> ata: pata_hpt37x: disable primary channel on HPT371 Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> iio: adc: men_z188_adc: Fix a resource leak in an error handling path Bart Van Assche <bvanassche(a)acm.org> RDMA/ib_srp: Fix a deadlock ChenXiaoSong <chenxiaosong2(a)huawei.com> configfs: fix a race in configfs_{,un}register_subsystem() Gal Pressman <gal(a)nvidia.com> net/mlx5e: Fix wrong return value on ioctl EEPROM query failure Maxime Ripard <maxime(a)cerno.tech> drm/edid: Always set RGB444 Paul Blakey <paulb(a)nvidia.com> openvswitch: Fix setting ipv6 fields causing hw csum failure Tao Liu <thomas.liu(a)ucloud.cn> gso: do not skip outer ip header in case of ipip and net_failover Eric Dumazet <edumazet(a)google.com> net: __pskb_pull_tail() & pskb_carve_frag_list() drop_monitor friends Robert Hancock <robert.hancock(a)calian.com> serial: 8250: of: Fix mapped region size when using reg-offset property Alexey Khoroshilov <khoroshilov(a)ispras.ru> serial: 8250: fix error handling in of_platform_serial_probe() Oliver Neukum <oneukum(a)suse.com> USB: zaurus: support another broken Zaurus Oliver Neukum <oneukum(a)suse.com> sr9700: sanity check for packet length Helge Deller <deller(a)gmx.de> parisc/unaligned: Fix ldw() and stw() unalignment handlers Helge Deller <deller(a)gmx.de> parisc/unaligned: Fix fldd and fstd unaligned handlers on 32-bit kernel Stefano Garzarella <sgarzare(a)redhat.com> vhost/vsock: don't check owner in vhost_vsock_stop() while releasing david regan <dregan(a)mail.com> mtd: rawnand: brcmnand: Fixed incorrect sub-page ECC status ------------- Diffstat: Makefile | 4 +- arch/parisc/kernel/unaligned.c | 14 ++--- drivers/ata/pata_hpt37x.c | 14 +++++ drivers/gpu/drm/drm_edid.c | 2 +- drivers/iio/adc/men_z188_adc.c | 9 ++- drivers/infiniband/ulp/srp/ib_srp.c | 6 +- drivers/mtd/nand/brcmnand/brcmnand.c | 2 +- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 2 +- drivers/net/usb/cdc_ether.c | 12 ++++ drivers/net/usb/sr9700.c | 2 +- drivers/net/usb/zaurus.c | 12 ++++ drivers/tty/n_gsm.c | 4 +- drivers/tty/serial/8250/8250_of.c | 30 ++++++--- drivers/usb/dwc3/gadget.c | 2 + drivers/usb/gadget/function/rndis.c | 8 +++ drivers/usb/gadget/function/rndis.h | 1 + drivers/usb/gadget/udc/udc-xilinx.c | 6 ++ drivers/usb/host/xhci.c | 9 ++- drivers/usb/serial/ch341.c | 1 - drivers/usb/serial/option.c | 12 ++++ drivers/vhost/vsock.c | 21 ++++--- fs/configfs/dir.c | 14 +++++ fs/file.c | 73 +++++++++++++++++----- fs/tracefs/inode.c | 5 +- include/net/checksum.h | 5 ++ mm/memblock.c | 10 ++- net/core/skbuff.c | 4 +- net/ipv4/af_inet.c | 5 +- net/ipv6/ip6_offload.c | 2 + net/openvswitch/actions.c | 46 +++++++++++--- 30 files changed, 269 insertions(+), 68 deletions(-)

3 years, 9 months

8
36
0 0

FAILED: patch "[PATCH] block: Fix fsync always failed if once failed" failed to apply to 5.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 8a7518931baa8ea023700987f3db31cb0a80610b Mon Sep 17 00:00:00 2001 From: Ye Bin <yebin10(a)huawei.com> Date: Mon, 29 Nov 2021 09:26:59 +0800 Subject: [PATCH] block: Fix fsync always failed if once failed We do test with inject error fault base on v4.19, after test some time we found sync /dev/sda always failed. [root@localhost] sync /dev/sda sync: error syncing '/dev/sda': Input/output error scsi log as follows: [19069.812296] sd 0:0:0:0: [sda] tag#64 Send: scmd 0x00000000d03a0b6b [19069.812302] sd 0:0:0:0: [sda] tag#64 CDB: Synchronize Cache(10) 35 00 00 00 00 00 00 00 00 00 [19069.812533] sd 0:0:0:0: [sda] tag#64 Done: SUCCESS Result: hostbyte=DID_OK driverbyte=DRIVER_OK [19069.812536] sd 0:0:0:0: [sda] tag#64 CDB: Synchronize Cache(10) 35 00 00 00 00 00 00 00 00 00 [19069.812539] sd 0:0:0:0: [sda] tag#64 scsi host busy 1 failed 0 [19069.812542] sd 0:0:0:0: Notifying upper driver of completion (result 0) [19069.812546] sd 0:0:0:0: [sda] tag#64 sd_done: completed 0 of 0 bytes [19069.812549] sd 0:0:0:0: [sda] tag#64 0 sectors total, 0 bytes done. [19069.812564] print_req_error: I/O error, dev sda, sector 0 ftrace log as follows: rep-306069 [007] .... 19654.923315: block_bio_queue: 8,0 FWS 0 + 0 [rep] rep-306069 [007] .... 19654.923333: block_getrq: 8,0 FWS 0 + 0 [rep] kworker/7:1H-250 [007] .... 19654.923352: block_rq_issue: 8,0 FF 0 () 0 + 0 [kworker/7:1H] <idle>-0 [007] ..s. 19654.923562: block_rq_complete: 8,0 FF () 18446744073709551615 + 0 [0] <idle>-0 [007] d.s. 19654.923576: block_rq_complete: 8,0 WS () 0 + 0 [-5] As 8d6996630c03 introduce 'fq->rq_status', this data only update when 'flush_rq' reference count isn't zero. If flush request once failed and record error code in 'fq->rq_status'. If there is no chance to update 'fq->rq_status',then do fsync will always failed. To address this issue reset 'fq->rq_status' after return error code to upper layer. Fixes: 8d6996630c03("block: fix null pointer dereference in blk_mq_rq_timed_out()") Signed-off-by: Ye Bin <yebin10(a)huawei.com> Reviewed-by: Ming Lei <ming.lei(a)redhat.com> Link: https://lore.kernel.org/r/20211129012659.1553733-1-yebin10@huawei.com Signed-off-by: Jens Axboe <axboe(a)kernel.dk> diff --git a/block/blk-flush.c b/block/blk-flush.c index fd5187a0898d..f78bb39e589e 100644 --- a/block/blk-flush.c +++ b/block/blk-flush.c @@ -242,8 +242,10 @@ static void flush_end_io(struct request *flush_rq, blk_status_t error) * avoiding use-after-free. */ WRITE_ONCE(flush_rq->state, MQ_RQ_IDLE); - if (fq->rq_status != BLK_STS_OK) + if (fq->rq_status != BLK_STS_OK) { error = fq->rq_status; + fq->rq_status = BLK_STS_OK; + } if (!q->elevator) { flush_rq->tag = BLK_MQ_NO_TAG;

3 years, 9 months

2
1
0 0

[PATCH 4.19 000/247] 4.19.178-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.178 release. There are 247 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 03 Mar 2021 16:09:49 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.178-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.178-rc1 Takeshi Misawa <jeliantsurux(a)gmail.com> net: qrtr: Fix memory leak in qrtr_tun_open Nikos Tsironis <ntsironis(a)arrikto.com> dm era: Update in-core bitset after committing the metadata Jason A. Donenfeld <Jason(a)zx2c4.com> net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending Leon Romanovsky <leonro(a)nvidia.com> ipv6: silence compilation warning for non-IPV6 builds Eric Dumazet <edumazet(a)google.com> ipv6: icmp6: avoid indirect call for icmpv6_send() Jason A. Donenfeld <Jason(a)zx2c4.com> xfrm: interface: use icmp_ndo_send helper Jason A. Donenfeld <Jason(a)zx2c4.com> sunvnet: use icmp_ndo_send helper Jason A. Donenfeld <Jason(a)zx2c4.com> gtp: use icmp_ndo_send helper Jason A. Donenfeld <Jason(a)zx2c4.com> icmp: introduce helper for nat'd source address in network device context Nikos Tsironis <ntsironis(a)arrikto.com> dm era: only resize metadata in preresume Nikos Tsironis <ntsironis(a)arrikto.com> dm era: Reinitialize bitset cache before digesting a new writeset Nikos Tsironis <ntsironis(a)arrikto.com> dm era: Use correct value size in equality function of writeset tree Nikos Tsironis <ntsironis(a)arrikto.com> dm era: Fix bitset memory leaks Nikos Tsironis <ntsironis(a)arrikto.com> dm era: Verify the data block size hasn't changed Nikos Tsironis <ntsironis(a)arrikto.com> dm era: Recover committed writeset after crash Mikulas Patocka <mpatocka(a)redhat.com> dm: fix deadlock when swapping to encrypted device Bob Peterson <rpeterso(a)redhat.com> gfs2: Don't skip dlm unlock if glock has an lvb Al Viro <viro(a)zeniv.linux.org.uk> sparc32: fix a user-triggerable oops in clear_user() Chao Yu <yuchao0(a)huawei.com> f2fs: fix out-of-repair __setattr_copy() Chen Yu <yu.c.chen(a)intel.com> cpufreq: intel_pstate: Get per-CPU max freq via MSR_HWP_CAPABILITIES if available Muchun Song <songmuchun(a)bytedance.com> printk: fix deadlock when kernel panic Maxim Kiselev <bigunclemax(a)gmail.com> gpio: pcf857x: Fix missing first interrupt Frank Li <Frank.Li(a)nxp.com> mmc: sdhci-esdhc-imx: fix kernel panic when remove module Fangrui Song <maskray(a)google.com> module: Ignore _GLOBAL_OFFSET_TABLE_ when warning for undefined symbols Suzuki K Poulose <suzuki.poulose(a)arm.com> arm64: Extend workaround for erratum 1024718 to all versions of Cortex-A55 Dan Williams <dan.j.williams(a)intel.com> libnvdimm/dimm: Avoid race between probe and available_slots_show() Mike Kravetz <mike.kravetz(a)oracle.com> hugetlb: fix copy_huge_page_from_user contig page struct assumption NeilBrown <neilb(a)suse.de> x86: fix seq_file iteration for pat/memtype.c NeilBrown <neilb(a)suse.de> seq_file: document how per-entry resources are managed. Pan Bian <bianpan2016(a)163.com> fs/affs: release old buffer head on error path Pan Bian <bianpan2016(a)163.com> mtd: spi-nor: hisi-sfc: Put child node np on error path Alexander Usyskin <alexander.usyskin(a)intel.com> watchdog: mei_wdt: request stop on unregister He Zhe <zhe.he(a)windriver.com> arm64: uprobe: Return EOPNOTSUPP for AARCH32 instruction probing Jiri Kosina <jkosina(a)suse.cz> floppy: reintroduce O_NDELAY fix Sean Christopherson <seanjc(a)google.com> x86/reboot: Force all cpus to exit VMX root if VMX is supported Pavel Machek <pavel(a)denx.de> media: ipu3-cio2: Fix mbus_code processing in cio2_subdev_set_fmt() Martin Kaiser <martin(a)kaiser.cx> staging: rtl8188eu: Add Edimax EW-7811UN V2 to device table Amey Narkhede <ameynarkhede03(a)gmail.com> staging: gdm724x: Fix DMA from stack Ilya Lipnitskiy <ilya.lipnitskiy(a)gmail.com> staging/mt7621-dma: mtk-hsdma.c->hsdma-mt7621.c Frank Wunderlich <frank-w(a)public-files.de> dts64: mt7622: fix slow sd card access Jiri Bohac <jbohac(a)suse.cz> pstore: Fix typo in compression option name Sabyrzhan Tasbolatov <snovitoll(a)gmail.com> drivers/misc/vmw_vmci: restrict too big queue size in qp_host_alloc_queue Ricky Wu <ricky_wu(a)realtek.com> misc: rtsx: init of rts522a add OCP power off when no card is present Paul Cercueil <paul(a)crapouillou.net> seccomp: Add missing return in non-void function Corentin Labbe <clabbe(a)baylibre.com> crypto: sun4i-ss - handle BigEndian for cipher Corentin Labbe <clabbe(a)baylibre.com> crypto: sun4i-ss - IV register does not work on A10 and A13 Corentin Labbe <clabbe(a)baylibre.com> crypto: sun4i-ss - checking sg length is not sufficient Ard Biesheuvel <ardb(a)kernel.org> crypto: arm64/sha - add missing module aliases Filipe Manana <fdmanana(a)suse.com> btrfs: fix extent buffer leak on failure to copy root Josef Bacik <josef(a)toxicpanda.com> btrfs: fix reloc root leak with 0 ref reloc roots on recovery Josef Bacik <josef(a)toxicpanda.com> btrfs: abort the transaction if we fail to inc ref in btrfs_copy_root Jarkko Sakkinen <jarkko(a)kernel.org> KEYS: trusted: Fix migratable=1 failing James Bottomley <James.Bottomley(a)HansenPartnership.com> tpm_tis: Clean up locality release James Bottomley <James.Bottomley(a)HansenPartnership.com> tpm_tis: Fix check_locality for correct locality acquisition PeiSen Hou <pshou(a)realtek.com> ALSA: hda/realtek: modify EAPD in the ALC886 Dan Carpenter <dan.carpenter(a)oracle.com> USB: serial: mos7720: fix error code in mos7720_write() Dan Carpenter <dan.carpenter(a)oracle.com> USB: serial: mos7840: fix error code in mos7840_write() Johan Hovold <johan(a)kernel.org> USB: serial: ftdi_sio: fix FTX sub-integer prescaler Thinh Nguyen <Thinh.Nguyen(a)synopsys.com> usb: dwc3: gadget: Fix dep->interval for fullspeed interrupt Thinh Nguyen <Thinh.Nguyen(a)synopsys.com> usb: dwc3: gadget: Fix setting of DEPCFG.bInterval_m1 Paul Cercueil <paul(a)crapouillou.net> usb: musb: Fix runtime PM race in musb_queue_resume_work Lech Perczak <lech.perczak(a)gmail.com> USB: serial: option: update interface mapping for ZTE P685M Marcos Paulo de Souza <mpdesouza(a)suse.com> Input: i8042 - add ASUS Zenbook Flip to noselftest list Dan Carpenter <dan.carpenter(a)oracle.com> Input: joydev - prevent potential read overflow in ioctl Olivier Crête <olivier.crete(a)ocrete.ca> Input: xpad - add support for PowerA Enhanced Wired Controller for Xbox Series X|S jeffrey.lin <jeffrey.lin(a)rad-ic.com> Input: raydium_ts_i2c - do not send zero length Jason Gerecke <killertofu(a)gmail.com> HID: wacom: Ignore attempts to overwrite the touch_max value from HID Qinglang Miao <miaoqinglang(a)huawei.com> ACPI: configfs: add missing check after configfs_register_default_group() Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> ACPI: property: Fix fwnode string properties matching Mikulas Patocka <mpatocka(a)redhat.com> blk-settings: align max_sectors on "logical_block_size" boundary Randy Dunlap <rdunlap(a)infradead.org> scsi: bnx2fc: Fix Kconfig warning & CNIC build errors Miaohe Lin <linmiaohe(a)huawei.com> mm/rmap: fix potential pte_unmap on an not mapped pte Maxime Ripard <maxime(a)cerno.tech> i2c: brcmstb: Fix brcmstd_send_i2c_cmd condition Marc Zyngier <maz(a)kernel.org> arm64: Add missing ISB after invalidating TLB in __primary_switch Heiner Kallweit <hkallweit1(a)gmail.com> r8169: fix jumbo packet handling on RTL8168e Miaohe Lin <linmiaohe(a)huawei.com> mm/hugetlb: fix potential double free in hugetlb_register_node() error path Miaohe Lin <linmiaohe(a)huawei.com> mm/memory.c: fix potential pte_unmap_unlock pte error Dan Carpenter <dan.carpenter(a)oracle.com> ocfs2: fix a use after free on error Taehee Yoo <ap420073(a)gmail.com> vxlan: move debug check after netdev unregister Chuhong Yuan <hslester96(a)gmail.com> net/mlx4_core: Add missed mlx4_free_cmd_mailbox() Mateusz Palczewski <mateusz.palczewski(a)intel.com> i40e: Fix add TC filter for IPv6 Jann Horn <jannh(a)google.com> Take mmap lock in cacheflush syscall Sylwester Dziedziuch <sylwesterx.dziedziuch(a)intel.com> i40e: Fix VFs not created Mateusz Palczewski <mateusz.palczewski(a)intel.com> i40e: Fix overwriting flow control settings during driver loading Mateusz Palczewski <mateusz.palczewski(a)intel.com> i40e: Add zero-initialization of AQ command structures Slawomir Laba <slawomirx.laba(a)intel.com> i40e: Fix flow for IPv6 next header (extension header) Bard Liao <yung-chuan.liao(a)linux.intel.com> regmap: sdw: use _no_pm functions in regmap_read/write Theodore Ts'o <tytso(a)mit.edu> ext4: fix potential htree index checksum corruption Konrad Dybcio <konrad.dybcio(a)somainline.org> drm/msm/dsi: Correct io_start for MSM8994 (20nm PHY) Heiner Kallweit <hkallweit1(a)gmail.com> PCI: Align checking of syscall user config accessors Jorgen Hansen <jhansen(a)vmware.com> VMCI: Use set_page_dirty_lock() when unregistering guest memory Simon South <simon(a)simonsouth.net> pwm: rockchip: rockchip_pwm_probe(): Remove superfluous clk_unprepare() Aswath Govindraju <a-govindraju(a)ti.com> misc: eeprom_93xx46: Add module alias to avoid breaking support for non device tree users Aswath Govindraju <a-govindraju(a)ti.com> misc: eeprom_93xx46: Fix module alias to enable module autoprobe Randy Dunlap <rdunlap(a)infradead.org> sparc64: only select COMPAT_BINFMT_ELF if BINFMT_ELF is set Dan Carpenter <dan.carpenter(a)oracle.com> Input: elo - fix an error code in elo_connect() Namhyung Kim <namhyung(a)kernel.org> perf test: Fix unaligned access in sample parsing test Adrian Hunter <adrian.hunter(a)intel.com> perf intel-pt: Fix missing CYC processing in PSB Dan Carpenter <dan.carpenter(a)oracle.com> Input: sur40 - fix an error code in sur40_probe() Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> spi: pxa2xx: Fix the controller numbering for Wildcat Point AngeloGioacchino Del Regno <angelogioacchino.delregno(a)somainline.org> clk: qcom: gcc-msm8998: Fix Alpha PLL type for all GPLLs Christophe Leroy <christophe.leroy(a)csgroup.eu> powerpc/8xx: Fix software emulation interrupt Nathan Lynch <nathanl(a)linux.ibm.com> powerpc/pseries/dlpar: handle ibm, configure-connector delay status Dan Carpenter <dan.carpenter(a)oracle.com> mfd: wm831x-auxadc: Prevent use after free in wm831x_auxadc_read_irq() Alain Volmat <alain.volmat(a)foss.st.com> spi: stm32: properly handle 0 byte transfer Bob Pearson <rpearsonhpe(a)gmail.com> RDMA/rxe: Correct skb on loopback path Bob Pearson <rpearsonhpe(a)gmail.com> RDMA/rxe: Fix coding error in rxe_recv.c Arnaldo Carvalho de Melo <acme(a)redhat.com> perf tools: Fix DSO filtering when not finding a map for a sampled address Steven Rostedt (VMware) <rostedt(a)goodmis.org> tracepoint: Do not fail unregistering a probe due to memory failure Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> amba: Fix resource leak for drivers without .remove Vladimir Murzin <vladimir.murzin(a)arm.com> ARM: 9046/1: decompressor: Do not clear SCTLR.nTLSMD for ARMv7+ cores Takeshi Saito <takeshi.saito.xv(a)renesas.com> mmc: renesas_sdhi_internal_dmac: Fix DMA buffer alignment from 8 to 128-bytes Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> mmc: usdhi6rol0: Fix a resource leak in the error handling path of the probe Christophe Leroy <christophe.leroy(a)csgroup.eu> powerpc/47x: Disable 256k page size Cédric Le Goater <clg(a)kaod.org> KVM: PPC: Make the VMX instruction emulation routines static Shay Drory <shayd(a)nvidia.com> IB/umad: Return EPOLLERR in case of when device disassociated Shay Drory <shayd(a)nvidia.com> IB/umad: Return EIO in case of when device disassociated Geert Uytterhoeven <geert(a)linux-m68k.org> auxdisplay: ht16k33: Fix refresh rate handling Pan Bian <bianpan2016(a)163.com> isofs: release buffer head before return Krzysztof Kozlowski <krzk(a)kernel.org> regulator: s5m8767: Drop regulators OF node reference Pan Bian <bianpan2016(a)163.com> spi: atmel: Put allocated master before return David Howells <dhowells(a)redhat.com> certs: Fix blacklist flag type confusion Pan Bian <bianpan2016(a)163.com> regulator: axp20x: Fix reference cout leak Andre Przywara <andre.przywara(a)arm.com> clk: sunxi-ng: h6: Fix clock divider range on some clocks Yishai Hadas <yishaih(a)nvidia.com> RDMA/mlx5: Use the correct obj_id upon DEVX TIR creation Tom Rix <trix(a)redhat.com> clocksource/drivers/mxs_timer: Add missing semicolon when DEBUG is defined Bartosz Golaszewski <bgolaszewski(a)baylibre.com> rtc: s5m: select REGMAP_I2C Claudiu Beznea <claudiu.beznea(a)microchip.com> power: reset: at91-sama5d2_shdwc: fix wkupdbc mask Nicolas Boichat <drinkcat(a)chromium.org> of/fdt: Make sure no-map does not remove already reserved regions KarimAllah Ahmed <karahmed(a)amazon.de> fdt: Properly handle "no-map" field in the memory region Yoshihiro Shimoda <yoshihiro.shimoda.uh(a)renesas.com> mfd: bd9571mwv: Use devm_mfd_add_devices() Ferry Toth <ftoth(a)exalondelft.nl> dmaengine: hsu: disable spurious interrupt Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> dmaengine: owl-dma: Fix a resource leak in the remove function Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> dmaengine: fsldma: Fix a resource leak in an error handling path of the probe function Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> dmaengine: fsldma: Fix a resource leak in the remove function Randy Dunlap <rdunlap(a)infradead.org> HID: core: detect and skip invalid inputs to snto32() Andre Przywara <andre.przywara(a)arm.com> clk: sunxi-ng: h6: Fix CEC clock Pratyush Yadav <p.yadav(a)ti.com> spi: cadence-quadspi: Abort read if dummy cycles required are too many Jan Kara <jack(a)suse.cz> quota: Fix memory leak when handling corrupted quota file Martin Blumenstingl <martin.blumenstingl(a)googlemail.com> clk: meson: clk-pll: fix initializing the old rate (fallback) for a PLL Eric W. Biederman <ebiederm(a)xmission.com> capabilities: Don't allow writing ambiguous v3 file capabilities Tom Rix <trix(a)redhat.com> jffs2: fix use after free in jffs2_sum_write_data() Colin Ian King <colin.king(a)canonical.com> fs/jfs: fix potential integer overflow on shift of a int Lakshmi Ramasubramanian <nramas(a)linux.microsoft.com> ima: Free IMA measurement buffer after kexec syscall Lakshmi Ramasubramanian <nramas(a)linux.microsoft.com> ima: Free IMA measurement buffer on error Daniele Alessandrelli <daniele.alessandrelli(a)intel.com> crypto: ecdh_helper - Ensure 'len >= secret.len' in decode_key() Jan Henrik Weinstock <jan.weinstock(a)rwth-aachen.de> hwrng: timeriomem - Fix cooldown period calculation Zhihao Cheng <chengzhihao1(a)huawei.com> btrfs: clarify error returns values in __load_free_space_cache Andrea Parri (Microsoft) <parri.andrea(a)gmail.com> Drivers: hv: vmbus: Avoid use-after-free in vmbus_onoffer_rescind() Dan Carpenter <dan.carpenter(a)oracle.com> drm/amdgpu: Prevent shift wrapping in amdgpu_read_mask() Yi Chen <chenyi77(a)huawei.com> f2fs: fix to avoid inconsistent quota data Sebastian Reichel <sre(a)kernel.org> ASoC: cpcap: fix microphone timeslot mask Florian Fainelli <f.fainelli(a)gmail.com> ata: ahci_brcm: Add back regulators management Christophe Leroy <christophe.leroy(a)csgroup.eu> crypto: talitos - Work around SEC6 ERRATA (AES-CTR mode data size error) Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> media: uvcvideo: Accept invalid bFormatIndex and bFrameIndex values Tom Rix <trix(a)redhat.com> media: pxa_camera: declare variable when DEBUG is defined Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> media: cx25821: Fix a bug when reallocating some dma memory Luo Meng <luomeng12(a)huawei.com> media: qm1d1c0042: fix error return code in qm1d1c0042_init() Joe Perches <joe(a)perches.com> media: lmedm04: Fix misuse of comma Mario Kleiner <mario.kleiner.de(a)gmail.com> drm/amd/display: Fix 10/12 bpc setup in DCE output bit depth reduction. Jiri Olsa <jolsa(a)kernel.org> crypto: bcm - Rename struct device_private to bcm_device_private Dan Carpenter <dan.carpenter(a)oracle.com> ASoC: cs42l56: fix up error handling in probe Dinghao Liu <dinghao.liu(a)zju.edu.cn> media: tm6000: Fix memleak in tm6000_start_stream Dinghao Liu <dinghao.liu(a)zju.edu.cn> media: media/pci: Fix memleak in empress_init Dinghao Liu <dinghao.liu(a)zju.edu.cn> media: em28xx: Fix use-after-free in em28xx_alloc_urbs Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> media: vsp1: Fix an error handling path in the probe function Dan Carpenter <dan.carpenter(a)oracle.com> media: camss: missing error code in msm_video_register() Jacopo Mondi <jacopo(a)jmondi.org> media: i2c: ov5670: Fix PIXEL_RATE minimum value Nathan Chancellor <natechancellor(a)gmail.com> MIPS: lantiq: Explicitly compare LTQ_EBU_PCC_ISTAT against 0 Nathan Chancellor <natechancellor(a)gmail.com> MIPS: c-r4k: Fix section mismatch for loongson2_sc_init Chenyang Li <lichenyang(a)loongson.cn> drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition Corentin Labbe <clabbe(a)baylibre.com> crypto: sun4i-ss - fix kmap usage Dan Carpenter <dan.carpenter(a)oracle.com> gma500: clean up error handling in init Jialin Zhang <zhangjialin11(a)huawei.com> drm/gma500: Fix error return code in psb_driver_load() Randy Dunlap <rdunlap(a)infradead.org> fbdev: aty: SPARC64 requires FB_ATY_CT Maxime Chevallier <maxime.chevallier(a)bootlin.com> net: mvneta: Remove per-cpu queue mapping for Armada 3700 Shyam Sundar S K <Shyam-sundar.S-k(a)amd.com> net: amd-xgbe: Fix network fluctuations when using 1G BELFUSE SFP Shyam Sundar S K <Shyam-sundar.S-k(a)amd.com> net: amd-xgbe: Reset link when the link never comes back Shyam Sundar S K <Shyam-sundar.S-k(a)amd.com> net: amd-xgbe: Fix NETDEV WATCHDOG transmit queue timeout warning Shyam Sundar S K <Shyam-sundar.S-k(a)amd.com> net: amd-xgbe: Reset the PHY rx data path when mailbox command timeout Lijun Pan <ljp(a)linux.ibm.com> ibmvnic: skip send_request_unmap for timeout reset Lijun Pan <ljp(a)linux.ibm.com> ibmvnic: add memory barrier to protect long term buffer Colin Ian King <colin.king(a)canonical.com> b43: N-PHY: Fix the update of coef for the PHY revision >= 3case Ayush Sawal <ayush.sawal(a)chelsio.com> cxgb4/chtls/cxgbit: Keeping the max ofld immediate data size same in cxgb4 and ulds Eric Dumazet <edumazet(a)google.com> tcp: fix SO_RCVLOWAT related hangs under mem pressure Jesper Dangaard Brouer <brouer(a)redhat.com> bpf: Fix bpf_fib_lookup helper MTU check for SKB ctx Colin Ian King <colin.king(a)canonical.com> mac80211: fix potential overflow when multiplying to u32 integers Juergen Gross <jgross(a)suse.com> xen/netback: fix spurious event detection for common event case Edwin Peer <edwin.peer(a)broadcom.com> bnxt_en: reverse order of TX disable and carrier off Sukadev Bhattiprolu <sukadev(a)linux.ibm.com> ibmvnic: Set to CLOSED state even on error Linus Lüssing <ll(a)simonwunderlich.de> ath9k: fix data bus crash when setting nf_override via debugfs Marco Elver <elver(a)google.com> bpf_lru_list: Read double-checked variable once without lock Jae Hyun Yoo <jae.hyun.yoo(a)intel.com> soc: aspeed: snoop: Add clock control logic Arnd Bergmann <arnd(a)arndb.de> ARM: s3c: fix fiq for clang IAS Vincent Knecht <vincent.knecht(a)mailoo.org> arm64: dts: msm8916: Fix reserved and rfsa nodes unit address Rosen Penev <rosenp(a)gmail.com> ARM: dts: armada388-helios4: assign pinctrl to each fan Rosen Penev <rosenp(a)gmail.com> ARM: dts: armada388-helios4: assign pinctrl to LEDs Chen-Yu Tsai <wens(a)csie.org> staging: rtl8723bs: wifi_regd.c: Fix incorrect number of regulatory rules Guenter Roeck <linux(a)roeck-us.net> usb: dwc2: Make "trimming xfer length" a debug message Guenter Roeck <linux(a)roeck-us.net> usb: dwc2: Abort transaction after errors with unknown reason Guenter Roeck <linux(a)roeck-us.net> usb: dwc2: Do not update data length if it is 0 on inbound transfers Tony Lindgren <tony(a)atomide.com> ARM: dts: Configure missing thermal interrupt for 4430 Pan Bian <bianpan2016(a)163.com> memory: ti-aemif: Drop child node when jumping out loop Pan Bian <bianpan2016(a)163.com> Bluetooth: Put HCI device if inquiry procedure interrupts Pan Bian <bianpan2016(a)163.com> Bluetooth: drop HCI device reference before return Jack Pham <jackp(a)codeaurora.org> usb: gadget: u_audio: Free requests only after callback Maximilian Luz <luzmaximilian(a)gmail.com> ACPICA: Fix exception code class checks Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> cpufreq: brcmstb-avs-cpufreq: Fix resource leaks in ->remove() Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> cpufreq: brcmstb-avs-cpufreq: Free resources in error path Andre Przywara <andre.przywara(a)arm.com> arm64: dts: allwinner: A64: Limit MMC2 bus frequency to 150 MHz Andre Przywara <andre.przywara(a)arm.com> arm64: dts: allwinner: Drop non-removable from SoPine/LTS SD card Andre Przywara <andre.przywara(a)arm.com> arm64: dts: allwinner: A64: properly connect USB PHY to port 0 Andrii Nakryiko <andrii(a)kernel.org> bpf: Avoid warning when re-casting __bpf_call_base into __bpf_call_base_args Krzysztof Kozlowski <krzk(a)kernel.org> arm64: dts: exynos: correct PMIC interrupt trigger level on Espresso Krzysztof Kozlowski <krzk(a)kernel.org> arm64: dts: exynos: correct PMIC interrupt trigger level on TM2 Krzysztof Kozlowski <krzk(a)kernel.org> ARM: dts: exynos: correct PMIC interrupt trigger level on Odroid XU3 family Krzysztof Kozlowski <krzk(a)kernel.org> ARM: dts: exynos: correct PMIC interrupt trigger level on Arndale Octa Krzysztof Kozlowski <krzk(a)kernel.org> ARM: dts: exynos: correct PMIC interrupt trigger level on Spring Krzysztof Kozlowski <krzk(a)kernel.org> ARM: dts: exynos: correct PMIC interrupt trigger level on Rinato Krzysztof Kozlowski <krzk(a)kernel.org> ARM: dts: exynos: correct PMIC interrupt trigger level on Monk Krzysztof Kozlowski <krzk(a)kernel.org> ARM: dts: exynos: correct PMIC interrupt trigger level on Artik 5 Christopher William Snowhill <chris(a)kode54.net> Bluetooth: Fix initializing response id after clearing struct Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> Bluetooth: btqcomsmd: Fix a resource leak in error handling paths in the probe function Rakesh Pillai <pillair(a)codeaurora.org> ath10k: Fix error handling in case of CE pipe init failure Eric Biggers <ebiggers(a)google.com> random: fix the RNDRESEEDCRNG ioctl Alexander Lobakin <alobakin(a)pm.me> MIPS: vmlinux.lds.S: add missing PAGE_ALIGNED_DATA() section Takashi Iwai <tiwai(a)suse.de> ALSA: usb-audio: Fix PCM buffer allocation in non-vmalloc mode Jan Kara <jack(a)suse.cz> bfq: Avoid false bfq queue merging Ansuel Smith <ansuelsmth(a)gmail.com> PCI: qcom: Use PHY_REFCLK_USE_PAD only for ipq8064 Sumit Garg <sumit.garg(a)linaro.org> kdb: Make memory allocations more robust Nick Desaulniers <ndesaulniers(a)google.com> vmlinux.lds.h: add DWARF v5 sections Peter Zijlstra <peterz(a)infradead.org> locking/static_key: Fix false positive warnings on concurrent dec/inc Peter Zijlstra <peterz(a)infradead.org> jump_label/lockdep: Assert we hold the hotplug lock for _cpuslocked() operations Rong Chen <rong.a.chen(a)intel.com> scripts/recordmcount.pl: support big endian for ARCH sh Shyam Prasad N <sprasad(a)microsoft.com> cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath. Christoph Schemmel <christoph.schemmel(a)gmail.com> NET: usb: qmi_wwan: Adding support for Cinterion MV31 Ming Lei <ming.lei(a)redhat.com> block: don't release queue's sysfs lock during switching elevator Ming Lei <ming.lei(a)redhat.com> block: fix race between switching elevator and removing queues Ming Lei <ming.lei(a)redhat.com> block: split .sysfs_lock into two locks Ming Lei <ming.lei(a)redhat.com> block: add helper for checking if queue is registered Rolf Eike Beer <eb(a)emlix.com> scripts: set proper OpenSSL include dir also for sign-file Rolf Eike Beer <eb(a)emlix.com> scripts: use pkg-config to locate libcrypto Sameer Pujar <spujar(a)nvidia.com> arm64: tegra: Add power-domain for Tegra210 HDA Rustam Kovhaev <rkovhaev(a)gmail.com> ntfs: check for valid standard information attribute Stefan Ursella <stefan.ursella(a)wolfvision.net> usb: quirks: add quirk to start video capture on ELMO L-12F document camera reliable Johan Hovold <johan(a)kernel.org> USB: quirks: sort quirk entries Will McVicker <willmcvicker(a)google.com> HID: make arrays usage and value to be the same ------------- Diffstat: Documentation/filesystems/seq_file.txt | 6 + Makefile | 4 +- arch/arm/boot/compressed/head.S | 4 +- arch/arm/boot/dts/armada-388-helios4.dts | 28 +++- arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +- arch/arm/boot/dts/exynos3250-monk.dts | 2 +- arch/arm/boot/dts/exynos3250-rinato.dts | 2 +- arch/arm/boot/dts/exynos5250-spring.dts | 2 +- arch/arm/boot/dts/exynos5420-arndale-octa.dts | 2 +- arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +- arch/arm/boot/dts/omap443x.dtsi | 2 + arch/arm64/Kconfig | 2 +- .../boot/dts/allwinner/sun50i-a64-pinebook.dts | 5 +- .../boot/dts/allwinner/sun50i-a64-sopine.dtsi | 1 - arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 6 +- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +- arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 2 +- arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 + arch/arm64/boot/dts/nvidia/tegra210.dtsi | 1 + arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 +- arch/arm64/crypto/sha1-ce-glue.c | 1 + arch/arm64/crypto/sha2-ce-glue.c | 2 + arch/arm64/crypto/sha3-ce-glue.c | 4 + arch/arm64/crypto/sha512-ce-glue.c | 2 + arch/arm64/kernel/cpufeature.c | 2 +- arch/arm64/kernel/head.S | 1 + arch/arm64/kernel/probes/uprobes.c | 2 +- arch/mips/kernel/vmlinux.lds.S | 1 + arch/mips/lantiq/irq.c | 2 +- arch/mips/mm/c-r4k.c | 2 +- arch/nios2/kernel/sys_nios2.c | 11 +- arch/powerpc/Kconfig | 2 +- arch/powerpc/kernel/head_8xx.S | 2 +- arch/powerpc/kvm/powerpc.c | 8 +- arch/powerpc/platforms/pseries/dlpar.c | 7 +- arch/sparc/Kconfig | 2 +- arch/sparc/lib/memset.S | 1 + arch/x86/kernel/reboot.c | 29 ++-- arch/x86/mm/pat.c | 3 +- block/bfq-iosched.c | 1 + block/blk-core.c | 1 + block/blk-mq-sysfs.c | 12 +- block/blk-settings.c | 12 ++ block/blk-sysfs.c | 49 ++++--- block/blk-wbt.c | 2 +- block/blk.h | 2 +- block/elevator.c | 30 ++-- certs/blacklist.c | 2 +- crypto/ecdh_helper.c | 3 + drivers/acpi/acpi_configfs.c | 7 +- drivers/acpi/property.c | 44 ++++-- drivers/amba/bus.c | 20 +-- drivers/ata/ahci_brcm.c | 14 +- drivers/auxdisplay/ht16k33.c | 3 +- drivers/base/regmap/regmap-sdw.c | 4 +- drivers/block/floppy.c | 27 ++-- drivers/bluetooth/btqcomsmd.c | 27 ++-- drivers/char/hw_random/timeriomem-rng.c | 2 +- drivers/char/random.c | 2 +- drivers/char/tpm/tpm_tis_core.c | 50 +------ drivers/clk/meson/clk-pll.c | 2 +- drivers/clk/qcom/gcc-msm8998.c | 100 ++++++------- drivers/clk/sunxi-ng/ccu-sun50i-h6.c | 10 +- drivers/clocksource/mxs_timer.c | 5 +- drivers/cpufreq/brcmstb-avs-cpufreq.c | 24 +++- drivers/cpufreq/intel_pstate.c | 5 +- drivers/crypto/bcm/cipher.c | 2 +- drivers/crypto/bcm/cipher.h | 4 +- drivers/crypto/bcm/util.c | 2 +- drivers/crypto/chelsio/chtls/chtls_cm.h | 3 - drivers/crypto/sunxi-ss/sun4i-ss-cipher.c | 159 +++++++++++++-------- drivers/crypto/talitos.c | 28 ++-- drivers/crypto/talitos.h | 1 + drivers/dma/fsldma.c | 6 + drivers/dma/hsu/pci.c | 21 +-- drivers/dma/owl-dma.c | 1 + drivers/gpio/gpio-pcf857x.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +- drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 8 +- drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 22 +-- drivers/gpu/drm/gma500/psb_drv.c | 2 + drivers/gpu/drm/msm/dsi/phy/dsi_phy_20nm.c | 2 +- drivers/hid/hid-core.c | 9 +- drivers/hid/wacom_wac.c | 7 +- drivers/hv/channel_mgmt.c | 3 +- drivers/i2c/busses/i2c-brcmstb.c | 2 +- drivers/infiniband/core/user_mad.c | 17 ++- drivers/infiniband/hw/mlx5/devx.c | 4 +- drivers/infiniband/sw/rxe/rxe_net.c | 5 + drivers/infiniband/sw/rxe/rxe_recv.c | 11 +- drivers/input/joydev.c | 7 +- drivers/input/joystick/xpad.c | 1 + drivers/input/serio/i8042-x86ia64io.h | 4 + drivers/input/touchscreen/elo.c | 4 +- drivers/input/touchscreen/raydium_i2c_ts.c | 3 +- drivers/input/touchscreen/sur40.c | 1 + drivers/md/dm-core.h | 4 + drivers/md/dm-crypt.c | 1 + drivers/md/dm-era-target.c | 93 +++++++----- drivers/md/dm.c | 60 ++++++++ drivers/media/i2c/ov5670.c | 3 +- drivers/media/pci/cx25821/cx25821-core.c | 4 +- drivers/media/pci/intel/ipu3/ipu3-cio2.c | 2 +- drivers/media/pci/saa7134/saa7134-empress.c | 5 +- drivers/media/platform/pxa_camera.c | 3 + drivers/media/platform/qcom/camss/camss-video.c | 1 + drivers/media/platform/vsp1/vsp1_drv.c | 4 +- drivers/media/tuners/qm1d1c0042.c | 4 +- drivers/media/usb/dvb-usb-v2/lmedm04.c | 2 +- drivers/media/usb/em28xx/em28xx-core.c | 6 +- drivers/media/usb/tm6000/tm6000-dvb.c | 4 + drivers/media/usb/uvc/uvc_v4l2.c | 18 +-- drivers/memory/ti-aemif.c | 8 +- drivers/mfd/bd9571mwv.c | 6 +- drivers/mfd/wm831x-auxadc.c | 3 +- drivers/misc/aspeed-lpc-snoop.c | 30 +++- drivers/misc/cardreader/rts5227.c | 5 + drivers/misc/eeprom/eeprom_93xx46.c | 1 + drivers/misc/vmw_vmci/vmci_queue_pair.c | 5 +- drivers/mmc/host/renesas_sdhi_internal_dmac.c | 4 +- drivers/mmc/host/sdhci-esdhc-imx.c | 3 +- drivers/mmc/host/usdhi6rol0.c | 4 +- drivers/mtd/spi-nor/cadence-quadspi.c | 2 +- drivers/mtd/spi-nor/hisi-sfc.c | 4 +- drivers/net/ethernet/amd/xgbe/xgbe-common.h | 14 ++ drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 1 + drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 3 +- drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 39 ++++- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 3 + drivers/net/ethernet/chelsio/cxgb4/sge.c | 11 +- drivers/net/ethernet/ibm/ibmvnic.c | 16 ++- drivers/net/ethernet/intel/i40e/i40e_main.c | 41 ++---- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 9 +- drivers/net/ethernet/marvell/mvneta.c | 9 +- .../net/ethernet/mellanox/mlx4/resource_tracker.c | 1 + drivers/net/ethernet/realtek/r8169.c | 4 +- drivers/net/ethernet/sun/sunvnet_common.c | 23 +-- drivers/net/gtp.c | 5 +- drivers/net/usb/qmi_wwan.c | 1 + drivers/net/vxlan.c | 11 +- drivers/net/wireless/ath/ath10k/snoc.c | 5 +- drivers/net/wireless/ath/ath9k/debug.c | 5 +- drivers/net/wireless/broadcom/b43/phy_n.c | 2 +- drivers/net/xen-netback/interface.c | 8 +- drivers/nvdimm/dimm_devs.c | 18 ++- drivers/of/fdt.c | 12 +- drivers/pci/controller/dwc/pcie-qcom.c | 4 +- drivers/pci/syscall.c | 10 +- drivers/power/reset/at91-sama5d2_shdwc.c | 2 +- drivers/pwm/pwm-rockchip.c | 1 - drivers/regulator/axp20x-regulator.c | 7 +- drivers/regulator/s5m8767.c | 8 +- drivers/rtc/Kconfig | 1 + drivers/scsi/bnx2fc/Kconfig | 1 + drivers/spi/spi-atmel.c | 2 +- drivers/spi/spi-pxa2xx-pci.c | 27 ++-- drivers/spi/spi-s3c24xx-fiq.S | 9 +- drivers/spi/spi-stm32.c | 4 + drivers/staging/gdm724x/gdm_usb.c | 10 +- drivers/staging/mt7621-dma/Makefile | 2 +- .../mt7621-dma/{mtk-hsdma.c => hsdma-mt7621.c} | 2 +- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 + drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 2 +- drivers/target/iscsi/cxgbit/cxgbit_target.c | 3 +- drivers/usb/core/quirks.c | 9 +- drivers/usb/dwc2/hcd.c | 15 +- drivers/usb/dwc2/hcd_intr.c | 14 +- drivers/usb/dwc3/gadget.c | 19 ++- drivers/usb/gadget/function/u_audio.c | 17 ++- drivers/usb/musb/musb_core.c | 31 ++-- drivers/usb/serial/ftdi_sio.c | 5 +- drivers/usb/serial/mos7720.c | 4 +- drivers/usb/serial/mos7840.c | 4 +- drivers/usb/serial/option.c | 3 +- drivers/video/fbdev/Kconfig | 2 +- drivers/watchdog/mei_wdt.c | 1 + fs/affs/namei.c | 4 +- fs/btrfs/ctree.c | 7 +- fs/btrfs/free-space-cache.c | 6 +- fs/btrfs/relocation.c | 4 +- fs/cifs/connect.c | 1 + fs/ext4/namei.c | 7 +- fs/f2fs/file.c | 7 +- fs/f2fs/inline.c | 4 + fs/gfs2/lock_dlm.c | 8 +- fs/isofs/dir.c | 1 + fs/isofs/namei.c | 1 + fs/jffs2/summary.c | 3 + fs/jfs/jfs_dmap.c | 2 +- fs/ntfs/inode.c | 6 + fs/ocfs2/cluster/heartbeat.c | 8 +- fs/pstore/platform.c | 4 +- fs/quota/quota_v2.c | 11 +- include/acpi/acexcep.h | 10 +- include/asm-generic/vmlinux.lds.h | 7 +- include/linux/blkdev.h | 2 + include/linux/device-mapper.h | 5 + include/linux/filter.h | 2 +- include/linux/icmpv6.h | 44 +++++- include/linux/ipv6.h | 2 +- include/linux/kexec.h | 5 + include/linux/key.h | 1 + include/linux/rmap.h | 3 +- include/net/icmp.h | 10 ++ include/net/tcp.h | 9 +- kernel/bpf/bpf_lru_list.c | 7 +- kernel/debug/kdb/kdb_private.h | 2 +- kernel/jump_label.c | 26 ++-- kernel/kexec_file.c | 5 + kernel/module.c | 21 ++- kernel/printk/printk_safe.c | 16 ++- kernel/seccomp.c | 2 + kernel/tracepoint.c | 80 ++++++++--- mm/hugetlb.c | 4 +- mm/memory.c | 16 ++- net/bluetooth/a2mp.c | 3 +- net/bluetooth/hci_core.c | 6 +- net/core/filter.c | 13 +- net/ipv4/icmp.c | 34 +++++ net/ipv6/icmp.c | 19 +-- net/ipv6/ip6_icmp.c | 46 +++++- net/mac80211/mesh_hwmp.c | 2 +- net/qrtr/tun.c | 12 +- net/xfrm/xfrm_interface.c | 6 +- scripts/Makefile | 9 +- scripts/recordmcount.pl | 6 +- security/commoncap.c | 12 +- security/integrity/ima/ima_kexec.c | 3 + security/integrity/ima/ima_mok.c | 5 +- security/keys/key.c | 2 + security/keys/trusted.c | 2 +- sound/pci/hda/patch_realtek.c | 11 ++ sound/soc/codecs/cpcap.c | 12 +- sound/soc/codecs/cs42l56.c | 3 +- sound/usb/pcm.c | 2 +- tools/perf/tests/sample-parsing.c | 2 +- tools/perf/util/event.c | 2 + .../perf/util/intel-pt-decoder/intel-pt-decoder.c | 3 + 240 files changed, 1568 insertions(+), 737 deletions(-)

3 years, 9 months

11
276
0 0

[PATCHv2 1/3] powerpc: lib: sstep: fix 'sthcx' instruction

by Anders Roxell

Looks like there been a copy paste mistake when added the instruction 'stbcx' twice and one was probably meant to be 'sthcx'. Changing to 'sthcx' from 'stbcx'. Cc: <stable(a)vger.kernel.org> # v4.13+ Fixes: 350779a29f11 ("powerpc: Handle most loads and stores in instruction emulation code") Reported-by: Arnd Bergmann <arnd(a)arndb.de> Signed-off-by: Anders Roxell <anders.roxell(a)linaro.org> --- arch/powerpc/lib/sstep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c index bd3734d5be89..d2d29243fa6d 100644 --- a/arch/powerpc/lib/sstep.c +++ b/arch/powerpc/lib/sstep.c @@ -3389,7 +3389,7 @@ int emulate_loadstore(struct pt_regs *regs, struct instruction_op *op) __put_user_asmx(op->val, ea, err, "stbcx.", cr); break; case 2: - __put_user_asmx(op->val, ea, err, "stbcx.", cr); + __put_user_asmx(op->val, ea, err, "sthcx.", cr); break; #endif case 4: -- 2.34.1

3 years, 9 months

2
3
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror February 2022