February 2022 - Linux-stable-mirror

Re: FAILED: patch "[PATCH] cgroup-v1: Require capabilities to set release_agent" failed to apply to 4.9-stable tree

by Greg KH

On Fri, Feb 04, 2022 at 11:28:19AM -0600, Tabitha Sable wrote: > I'm happy to help with this, but I'm not familiar with the conventions for > sending in backport diffs. > > I've read through the docs on kernelnewbies and found them to be both > overwhelmingly big and also not directly relevant to this particular > situation. I think if I simply try to follow them I'll foul things up. Yeah, it's not the same thing at all. > Can I simply make the changes against the appropriate git branch, build and > test, and then email in the diff to stable(a)vger.kernel.org copying most of > what you've put in the original email, greg? Yes, that's exactly what we need here. Be sure to let me know what the git id of the commit is in Linus's tree so we can properly track it (you can put it in the changelog text somewhere.) thanks, greg k-h

2 years, 10 months

1
0
0 0

[PATCH 5.16 00/43] 5.16.6-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.16.6 release. There are 43 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 06 Feb 2022 09:19:05 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.16.6-rc1… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.16.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.16.6-rc1 Eric Dumazet <edumazet(a)google.com> tcp: add missing tcp_skb_can_collapse() test in tcp_shift_skb_data() Eric Dumazet <edumazet(a)google.com> tcp: fix mem under-charging with zerocopy sendmsg() Eric Dumazet <edumazet(a)google.com> af_packet: fix data-race in packet_setsockopt / packet_setsockopt Sasha Neftin <sasha.neftin(a)intel.com> e1000e: Handshake with CSME starts from ADL platforms Tianchen Ding <dtcccc(a)linux.alibaba.com> cpuset: Fix the bug that subpart_cpus updated wrongly in update_cpumask() He Fengqing <hefengqing(a)huawei.com> bpf: Fix possible race in inc_misses_counter Alex Elder <elder(a)linaro.org> net: ipa: request IPA register values be retained Eric Dumazet <edumazet(a)google.com> rtnetlink: make sure to refresh master_dev/m_ops in __rtnl_newlink() Eric Dumazet <edumazet(a)google.com> net: sched: fix use-after-free in tc_new_tfilter() Dan Carpenter <dan.carpenter(a)oracle.com> fanotify: Fix stale file descriptor in copy_event_to_user() Shyam Sundar S K <Shyam-sundar.S-k(a)amd.com> net: amd-xgbe: Fix skb data length underflow Raju Rangoju <Raju.Rangoju(a)amd.com> net: amd-xgbe: ensure to reset the tx_timer_active flag Karen Sornek <karen.sornek(a)intel.com> i40e: Fix reset path while removing the driver Jedrzej Jagielski <jedrzej.jagielski(a)intel.com> i40e: Fix reset bw limit when DCB enabled with 1 TC Georgi Valkov <gvalkov(a)abv.bg> ipheth: fix EOVERFLOW in ipheth_rcvbulk_callback Roi Dayan <roid(a)nvidia.com> net/mlx5e: Avoid implicit modify hdr for decap drop rule Maor Dickman <maord(a)nvidia.com> net/mlx5: E-Switch, Fix uninitialized variable modact Khalid Manaa <khalidm(a)nvidia.com> net/mlx5e: Fix broken SKB allocation in HW-GRO Khalid Manaa <khalidm(a)nvidia.com> net/mlx5e: Fix wrong calculation of header index in HW_GRO Kees Cook <keescook(a)chromium.org> net/mlx5e: Avoid field-overflowing memcpy() Roi Dayan <roid(a)nvidia.com> net/mlx5: Bridge, Fix devlink deadlock on net namespace deletion Maxim Mikityanskiy <maximmi(a)nvidia.com> net/mlx5e: Don't treat small ceil values as unlimited in HTB offload Dima Chumak <dchumak(a)nvidia.com> net/mlx5: Fix offloading with ESWITCH_IPV4_TTL_MODIFY_ENABLE Roi Dayan <roid(a)nvidia.com> net/mlx5e: TC, Reject rules with forward and drop actions Gal Pressman <gal(a)nvidia.com> net/mlx5e: Fix module EEPROM query Maher Sanalla <msanalla(a)nvidia.com> net/mlx5: Use del_timer_sync in fw reset flow of halting poll Maor Dickman <maord(a)nvidia.com> net/mlx5e: Fix handling of wrong devices during bond netevent Vlad Buslov <vladbu(a)nvidia.com> net/mlx5: Bridge, ensure dev_name is null-terminated Vlad Buslov <vladbu(a)nvidia.com> net/mlx5: Bridge, take rtnl lock in init error handler Roi Dayan <roid(a)nvidia.com> net/mlx5e: TC, Reject rules with drop and modify hdr action Raed Salem <raeds(a)nvidia.com> net/mlx5e: IPsec: Fix tunnel mode crypto offload for non TCP/UDP traffic Raed Salem <raeds(a)nvidia.com> net/mlx5e: IPsec: Fix crypto offload for non TCP/UDP encapsulated traffic J. Bruce Fields <bfields(a)redhat.com> lockd: fix failure to cleanup client locks J. Bruce Fields <bfields(a)redhat.com> lockd: fix server crash on reboot of client holding lock Miklos Szeredi <mszeredi(a)redhat.com> ovl: don't fail copy up if no fileattr support on upper Jonathan McDowell <noodles(a)earth.li> net: phy: Fix qca8081 with speeds lower than 2.5Gb/s John Hubbard <jhubbard(a)nvidia.com> Revert "mm/gup: small refactoring: simplify try_grab_page()" Eric W. Biederman <ebiederm(a)xmission.com> cgroup-v1: Require capabilities to set release_agent Maxime Ripard <maxime(a)cerno.tech> drm/vc4: hdmi: Make sure the device is powered with CEC Alex Elder <elder(a)linaro.org> net: ipa: prevent concurrent replenish Alex Elder <elder(a)linaro.org> net: ipa: use a bitmap for endpoint replenish_enabled Paolo Abeni <pabeni(a)redhat.com> selftests: mptcp: fix ipv6 routing setup Lukas Wunner <lukas(a)wunner.de> PCI: pciehp: Fix infinite loop in IRQ handler upon power fault ------------- Diffstat: Makefile | 4 +- drivers/gpu/drm/vc4/vc4_hdmi.c | 25 ++++++----- drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 14 +++++- drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++- drivers/net/ethernet/intel/i40e/i40e.h | 1 + drivers/net/ethernet/intel/i40e/i40e_main.c | 31 ++++++++++++- drivers/net/ethernet/mellanox/mlx5/core/en.h | 6 +-- drivers/net/ethernet/mellanox/mlx5/core/en/qos.c | 3 +- .../net/ethernet/mellanox/mlx5/core/en/rep/bond.c | 32 ++++++------- .../ethernet/mellanox/mlx5/core/en/rep/bridge.c | 6 ++- drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h | 5 +++ drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 4 +- .../mellanox/mlx5/core/en_accel/ipsec_rxtx.c | 13 +++++- .../mellanox/mlx5/core/en_accel/ipsec_rxtx.h | 9 ++-- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 30 ++++++++----- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 15 ++++++- .../net/ethernet/mellanox/mlx5/core/esw/bridge.c | 4 ++ .../mlx5/core/esw/diag/bridge_tracepoint.h | 2 +- drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c | 2 +- .../ethernet/mellanox/mlx5/core/lib/fs_chains.c | 9 ++-- drivers/net/ethernet/mellanox/mlx5/core/port.c | 9 ++-- drivers/net/ipa/ipa_endpoint.c | 21 +++++++-- drivers/net/ipa/ipa_endpoint.h | 17 ++++++- drivers/net/ipa/ipa_power.c | 52 ++++++++++++++++++++++ drivers/net/ipa/ipa_power.h | 7 +++ drivers/net/ipa/ipa_uc.c | 5 +++ drivers/net/phy/at803x.c | 26 +++++------ drivers/net/usb/ipheth.c | 6 +-- drivers/pci/hotplug/pciehp_hpc.c | 7 +-- fs/lockd/svcsubs.c | 18 ++++---- fs/notify/fanotify/fanotify_user.c | 6 +-- fs/overlayfs/copy_up.c | 12 ++++- kernel/bpf/trampoline.c | 5 ++- kernel/cgroup/cgroup-v1.c | 14 ++++++ kernel/cgroup/cpuset.c | 3 +- mm/gup.c | 35 ++++++++++++--- net/core/rtnetlink.c | 6 ++- net/ipv4/tcp.c | 7 ++- net/ipv4/tcp_input.c | 2 + net/packet/af_packet.c | 8 +++- net/sched/cls_api.c | 11 +++-- tools/testing/selftests/net/mptcp/mptcp_join.sh | 5 ++- 42 files changed, 374 insertions(+), 129 deletions(-)

2 years, 10 months

12
54
0 0

[PATCH v2] drm/dp: Fix off-by-one in register cache size

by Kees Cook

The pcon_dsc_dpcd array holds 13 registers (0x92 through 0x9E). Fix the math to calculate the max size. Found from a -Warray-bounds build: drivers/gpu/drm/drm_dp_helper.c: In function 'drm_dp_pcon_dsc_bpp_incr': drivers/gpu/drm/drm_dp_helper.c:3130:28: error: array subscript 12 is outside array bounds of 'const u8[12]' {aka 'const unsigned char[12]'} [-Werror=array-bounds] 3130 | buf = pcon_dsc_dpcd[DP_PCON_DSC_BPP_INCR - DP_PCON_DSC_ENCODER]; | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/drm_dp_helper.c:3126:39: note: while referencing 'pcon_dsc_dpcd' 3126 | int drm_dp_pcon_dsc_bpp_incr(const u8 pcon_dsc_dpcd[DP_PCON_DSC_ENCODER_CAP_SIZE]) | ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Cc: Maxime Ripard <mripard(a)kernel.org> Cc: Thomas Zimmermann <tzimmermann(a)suse.de> Cc: David Airlie <airlied(a)linux.ie> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: dri-devel(a)lists.freedesktop.org Fixes: e2e16da398d9 ("drm/dp_helper: Add support for Configuring DSC for HDMI2.1 Pcon") Cc: stable(a)vger.kernel.org Reviewed-by: Gustavo A. R. Silva <gustavoars(a)kernel.org> Link: https://lore.kernel.org/lkml/20211214001849.GA62559@embeddedor/ Signed-off-by: Kees Cook <keescook(a)chromium.org> --- v1: https://lore.kernel.org/lkml/20211203084333.3105038-1-keescook@chromium.org/ v2: - add reviewed-by - add cc:stable --- include/drm/drm_dp_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 30359e434c3f..472dac376284 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -456,7 +456,7 @@ struct drm_panel; #define DP_FEC_CAPABILITY_1 0x091 /* 2.0 */ /* DP-HDMI2.1 PCON DSC ENCODER SUPPORT */ -#define DP_PCON_DSC_ENCODER_CAP_SIZE 0xC /* 0x9E - 0x92 */ +#define DP_PCON_DSC_ENCODER_CAP_SIZE 0xD /* 0x92 through 0x9E */ #define DP_PCON_DSC_ENCODER 0x092 # define DP_PCON_DSC_ENCODER_SUPPORTED (1 << 0) # define DP_PCON_DSC_PPS_ENC_OVERRIDE (1 << 1) -- 2.30.2

2 years, 10 months

1
1
0 0

[PATCH rcu 09/10] rcu: Don't deboost before reporting expedited quiescent state

by Paul E. McKenney

Currently rcu_preempt_deferred_qs_irqrestore() releases rnp->boost_mtx before reporting the expedited quiescent state. Under heavy real-time load, this can result in this function being preempted before the quiescent state is reported, which can in turn prevent the expedited grace period from completing. Tim Murray reports that the resulting expedited grace periods can take hundreds of milliseconds and even more than one second, when they should normally complete in less than a millisecond. This was fine given that there were no particular response-time constraints for synchronize_rcu_expedited(), as it was designed for throughput rather than latency. However, some users now need sub-100-millisecond response-time constratints. This patch therefore follows Neeraj's suggestion (seconded by Tim and by Uladzislau Rezki) of simply reversing the two operations. Reported-by: Tim Murray <timmurray(a)google.com> Reported-by: Joel Fernandes <joelaf(a)google.com> Reported-by: Neeraj Upadhyay <quic_neeraju(a)quicinc.com> Reviewed-by: Neeraj Upadhyay <quic_neeraju(a)quicinc.com> Reviewed-by: Uladzislau Rezki (Sony) <urezki(a)gmail.com> Tested-by: Tim Murray <timmurray(a)google.com> Cc: Todd Kjos <tkjos(a)google.com> Cc: Sandeep Patil <sspatil(a)google.com> Cc: <stable(a)vger.kernel.org> # 5.4.x Signed-off-by: Paul E. McKenney <paulmck(a)kernel.org> --- kernel/rcu/tree_plugin.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h index 109429e70a642..02ac057ba3f83 100644 --- a/kernel/rcu/tree_plugin.h +++ b/kernel/rcu/tree_plugin.h @@ -556,16 +556,16 @@ rcu_preempt_deferred_qs_irqrestore(struct task_struct *t, unsigned long flags) raw_spin_unlock_irqrestore_rcu_node(rnp, flags); } - /* Unboost if we were boosted. */ - if (IS_ENABLED(CONFIG_RCU_BOOST) && drop_boost_mutex) - rt_mutex_futex_unlock(&rnp->boost_mtx.rtmutex); - /* * If this was the last task on the expedited lists, * then we need to report up the rcu_node hierarchy. */ if (!empty_exp && empty_exp_now) rcu_report_exp_rnp(rnp, true); + + /* Unboost if we were boosted. */ + if (IS_ENABLED(CONFIG_RCU_BOOST) && drop_boost_mutex) + rt_mutex_futex_unlock(&rnp->boost_mtx.rtmutex); } else { local_irq_restore(flags); } -- 2.31.1.189.g2e36527f23

2 years, 10 months

1
0
0 0

[PATCH] coredump: Also dump first pages of non-executable ELF libraries

by Jann Horn

When I rewrote the VMA dumping logic for coredumps, I changed it to recognize ELF library mappings based on the file being executable instead of the mapping having an ELF header. But turns out, distros ship many ELF libraries as non-executable, so the heuristic goes wrong... Restore the old behavior where FILTER(ELF_HEADERS) dumps the first page of any offset-0 readable mapping that starts with the ELF magic. This fix is technically layer-breaking a bit, because it checks for something ELF-specific in fs/coredump.c; but since we probably want to share this between standard ELF and FDPIC ELF anyway, I guess it's fine? And this also keeps the change small for backporting. Cc: stable(a)vger.kernel.org Fixes: 429a22e776a2 ("coredump: rework elf/elf_fdpic vma_dump_size() into common helper") Reported-by: Bill Messmer <wmessmer(a)microsoft.com> Signed-off-by: Jann Horn <jannh(a)google.com> --- @Bill: If you happen to have a kernel tree lying around, you could give this a try and report back whether this solves your issues? But if not, it's also fine, I've tested myself that with this patch applied, the first 0x1000 bytes of non-executable libraries are dumped into the coredump according to "readelf". fs/coredump.c | 39 ++++++++++++++++++++++++++++++++++----- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/fs/coredump.c b/fs/coredump.c index 1c060c0a2d72..b73817712dd2 100644 --- a/fs/coredump.c +++ b/fs/coredump.c @@ -42,6 +42,7 @@ #include <linux/path.h> #include <linux/timekeeping.h> #include <linux/sysctl.h> +#include <linux/elf.h> #include <linux/uaccess.h> #include <asm/mmu_context.h> @@ -980,6 +981,8 @@ static bool always_dump_vma(struct vm_area_struct *vma) return false; } +#define DUMP_SIZE_MAYBE_ELFHDR_PLACEHOLDER 1 + /* * Decide how much of @vma's contents should be included in a core dump. */ @@ -1039,9 +1042,20 @@ static unsigned long vma_dump_size(struct vm_area_struct *vma, * dump the first page to aid in determining what was mapped here. */ if (FILTER(ELF_HEADERS) && - vma->vm_pgoff == 0 && (vma->vm_flags & VM_READ) && - (READ_ONCE(file_inode(vma->vm_file)->i_mode) & 0111) != 0) - return PAGE_SIZE; + vma->vm_pgoff == 0 && (vma->vm_flags & VM_READ)) { + if ((READ_ONCE(file_inode(vma->vm_file)->i_mode) & 0111) != 0) + return PAGE_SIZE; + + /* + * ELF libraries aren't always executable. + * We'll want to check whether the mapping starts with the ELF + * magic, but not now - we're holding the mmap lock, + * so copy_from_user() doesn't work here. + * Use a placeholder instead, and fix it up later in + * dump_vma_snapshot(). + */ + return DUMP_SIZE_MAYBE_ELFHDR_PLACEHOLDER; + } #undef FILTER @@ -1116,8 +1130,6 @@ int dump_vma_snapshot(struct coredump_params *cprm, int *vma_count, m->end = vma->vm_end; m->flags = vma->vm_flags; m->dump_size = vma_dump_size(vma, cprm->mm_flags); - - vma_data_size += m->dump_size; } mmap_write_unlock(mm); @@ -1127,6 +1139,23 @@ int dump_vma_snapshot(struct coredump_params *cprm, int *vma_count, return -EFAULT; } + for (i = 0; i < *vma_count; i++) { + struct core_vma_metadata *m = (*vma_meta) + i; + + if (m->dump_size == DUMP_SIZE_MAYBE_ELFHDR_PLACEHOLDER) { + char elfmag[SELFMAG]; + + if (copy_from_user(elfmag, (void __user *)m->start, SELFMAG) || + memcmp(elfmag, ELFMAG, SELFMAG) != 0) { + m->dump_size = 0; + } else { + m->dump_size = PAGE_SIZE; + } + } + + vma_data_size += m->dump_size; + } + *vma_data_size_ptr = vma_data_size; return 0; } base-commit: 0280e3c58f92b2fe0e8fbbdf8d386449168de4a8 -- 2.35.0.rc0.227.g00780c9af4-goog

2 years, 10 months

4
5
0 0

stable-rc/linux-5.16.y baseline: 92 runs, 1 regressions (v5.16.5-45-gf58321948b36)

by kernelci.org bot

stable-rc/linux-5.16.y baseline: 92 runs, 1 regressions (v5.16.5-45-gf58321948b36) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions -------------------------+--------+---------------+----------+------------------------------+------------ asus-C523NA-A20057-coral | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/job/stable-rc/branch/linux-5.16.y/kernel/v5.16.5-… Test: baseline Tree: stable-rc Branch: linux-5.16.y Describe: v5.16.5-45-gf58321948b36 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: f58321948b36b3589e2af9c3fc5718862597e364 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions -------------------------+--------+---------------+----------+------------------------------+------------ asus-C523NA-A20057-coral | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/plan/id/61fd7c01cd73d7d01a5d6ee8 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig+x86-chromebook Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/linux-5.16.y/v5.16.5-45-gf58321948b… HTML log: https://storage.kernelci.org//stable-rc/linux-5.16.y/v5.16.5-45-gf58321948b… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/61fd7c01cd73d7d01a5d6ee9 new failure (last pass: v5.16.4)

2 years, 10 months

1
0
0 0

stable-rc/linux-5.15.y baseline: 136 runs, 4 regressions (v5.15.19-34-g61f904d1d627)

by kernelci.org bot

stable-rc/linux-5.15.y baseline: 136 runs, 4 regressions (v5.15.19-34-g61f904d1d627) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ------------------------+--------+---------------+----------+------------------------------+------------ beagle-xm | arm | lab-baylibre | gcc-10 | omap2plus_defconfig | 1 hp-x360-14-G1-sona | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 r8a77950-salvator-x | arm64 | lab-baylibre | gcc-10 | defconfig | 1 sun50i-a64-bananapi-m64 | arm64 | lab-clabbe | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/linux-5.15.y/kernel/v5.15.19… Test: baseline Tree: stable-rc Branch: linux-5.15.y Describe: v5.15.19-34-g61f904d1d627 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 61f904d1d62716d179a70419e910118621910751 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ------------------------+--------+---------------+----------+------------------------------+------------ beagle-xm | arm | lab-baylibre | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/plan/id/61fd4ddde5e333c00b5d6f58 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: omap2plus_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/linux-5.15.y/v5.15.19-34-g61f904d1d… HTML log: https://storage.kernelci.org//stable-rc/linux-5.15.y/v5.15.19-34-g61f904d1d… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/61fd4ddde5e333c00b5d6f59 failing since 14 days (last pass: v5.15.14-70-g9cb47c4d3cbf, first fail: v5.15.16) platform | arch | lab | compiler | defconfig | regressions ------------------------+--------+---------------+----------+------------------------------+------------ hp-x360-14-G1-sona | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/plan/id/61fd4e5b2c921f0f305d6ef5 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig+x86-chromebook Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/linux-5.15.y/v5.15.19-34-g61f904d1d… HTML log: https://storage.kernelci.org//stable-rc/linux-5.15.y/v5.15.19-34-g61f904d1d… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/61fd4e5b2c921f0f305d6ef6 new failure (last pass: v5.15.19) platform | arch | lab | compiler | defconfig | regressions ------------------------+--------+---------------+----------+------------------------------+------------ r8a77950-salvator-x | arm64 | lab-baylibre | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/61fd4a9d49a369bbef5d6f21 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/linux-5.15.y/v5.15.19-34-g61f904d1d… HTML log: https://storage.kernelci.org//stable-rc/linux-5.15.y/v5.15.19-34-g61f904d1d… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/61fd4a9d49a369bbef5d6f22 new failure (last pass: v5.15.19) platform | arch | lab | compiler | defconfig | regressions ------------------------+--------+---------------+----------+------------------------------+------------ sun50i-a64-bananapi-m64 | arm64 | lab-clabbe | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/61fd4a5f314a6412a75d6f34 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/linux-5.15.y/v5.15.19-34-g61f904d1d… HTML log: https://storage.kernelci.org//stable-rc/linux-5.15.y/v5.15.19-34-g61f904d1d… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/61fd4a5f314a6412a75d6f35 new failure (last pass: v5.15.19)

2 years, 10 months

1
0
0 0

[PATCH 4/4 4/4] thermal/drivers/int340x: Fix RFIM mailbox write commands

by Sumeet Pawnikar

The existing mail mechanism only supports writing of workload types. However, mailbox command for RFIM (cmd = 0x08) also requires write operation which is ignored. This results in failing to store RFI restriction. Fixint this requires enhancing mailbox writes for non workload commands too, so remove the check for MBOX_CMD_WORKLOAD_TYPE_WRITE in mailbox write to allow this other write commands to be supoorted. At the same time, however, we have to make sure that there is no impact on read commands, by avoiding to write anything into the mailbox data register. To properly implement that, add two separate functions for mbox read and write commands for the processor thermal workload command type. This helps to distinguish the read and write workload command types from each other while sending mbox commands. Fixes: 5d6fbc96bd36 ("thermal/drivers/int340x: processor_thermal: Export additional attributes") Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com> Cc: 5.14+ <stable(a)vger.kernel.org> # 5.14+ Acked-by: Srinivas Pandruvada <srinivas.pandruvada(a)linux.intel.com> [ rjw: Changelog edits ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> --- .../processor_thermal_device.h | 3 +- .../int340x_thermal/processor_thermal_mbox.c | 100 +++++++++++------- .../int340x_thermal/processor_thermal_rfim.c | 23 ++-- 3 files changed, 73 insertions(+), 53 deletions(-) diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.h b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.h index be27f633e40a..9b2a64ef55d0 100644 --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.h +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.h @@ -80,7 +80,8 @@ void proc_thermal_rfim_remove(struct pci_dev *pdev); int proc_thermal_mbox_add(struct pci_dev *pdev, struct proc_thermal_device *proc_priv); void proc_thermal_mbox_remove(struct pci_dev *pdev); -int processor_thermal_send_mbox_cmd(struct pci_dev *pdev, u16 cmd_id, u32 cmd_data, u64 *cmd_resp); +int processor_thermal_send_mbox_read_cmd(struct pci_dev *pdev, u16 id, u64 *resp); +int processor_thermal_send_mbox_write_cmd(struct pci_dev *pdev, u16 id, u32 data); int proc_thermal_add(struct device *dev, struct proc_thermal_device *priv); void proc_thermal_remove(struct proc_thermal_device *proc_priv); int proc_thermal_suspend(struct device *dev); diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c index 01008ae00e7f..0b89a4340ff4 100644 --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c @@ -24,19 +24,15 @@ static DEFINE_MUTEX(mbox_lock); -static int send_mbox_cmd(struct pci_dev *pdev, u16 cmd_id, u32 cmd_data, u64 *cmd_resp) +static int wait_for_mbox_ready(struct proc_thermal_device *proc_priv) { - struct proc_thermal_device *proc_priv; u32 retries, data; int ret; - mutex_lock(&mbox_lock); - proc_priv = pci_get_drvdata(pdev); - /* Poll for rb bit == 0 */ retries = MBOX_RETRY_COUNT; do { - data = readl((void __iomem *) (proc_priv->mmio_base + MBOX_OFFSET_INTERFACE)); + data = readl(proc_priv->mmio_base + MBOX_OFFSET_INTERFACE); if (data & BIT_ULL(MBOX_BUSY_BIT)) { ret = -EBUSY; continue; @@ -45,53 +41,78 @@ static int send_mbox_cmd(struct pci_dev *pdev, u16 cmd_id, u32 cmd_data, u64 *cm break; } while (--retries); + return ret; +} + +static int send_mbox_write_cmd(struct pci_dev *pdev, u16 id, u32 data) +{ + struct proc_thermal_device *proc_priv; + u32 reg_data; + int ret; + + proc_priv = pci_get_drvdata(pdev); + + mutex_lock(&mbox_lock); + + ret = wait_for_mbox_ready(proc_priv); if (ret) goto unlock_mbox; - if (cmd_id == MBOX_CMD_WORKLOAD_TYPE_WRITE) - writel(cmd_data, (void __iomem *) ((proc_priv->mmio_base + MBOX_OFFSET_DATA))); - + writel(data, (proc_priv->mmio_base + MBOX_OFFSET_DATA)); /* Write command register */ - data = BIT_ULL(MBOX_BUSY_BIT) | cmd_id; - writel(data, (void __iomem *) ((proc_priv->mmio_base + MBOX_OFFSET_INTERFACE))); + reg_data = BIT_ULL(MBOX_BUSY_BIT) | id; + writel(reg_data, (proc_priv->mmio_base + MBOX_OFFSET_INTERFACE)); - /* Poll for rb bit == 0 */ - retries = MBOX_RETRY_COUNT; - do { - data = readl((void __iomem *) (proc_priv->mmio_base + MBOX_OFFSET_INTERFACE)); - if (data & BIT_ULL(MBOX_BUSY_BIT)) { - ret = -EBUSY; - continue; - } + ret = wait_for_mbox_ready(proc_priv); - if (data) { - ret = -ENXIO; - goto unlock_mbox; - } +unlock_mbox: + mutex_unlock(&mbox_lock); + return ret; +} - ret = 0; +static int send_mbox_read_cmd(struct pci_dev *pdev, u16 id, u64 *resp) +{ + struct proc_thermal_device *proc_priv; + u32 reg_data; + int ret; - if (!cmd_resp) - break; + proc_priv = pci_get_drvdata(pdev); - if (cmd_id == MBOX_CMD_WORKLOAD_TYPE_READ) - *cmd_resp = readl((void __iomem *) (proc_priv->mmio_base + MBOX_OFFSET_DATA)); - else - *cmd_resp = readq((void __iomem *) (proc_priv->mmio_base + MBOX_OFFSET_DATA)); + mutex_lock(&mbox_lock); - break; - } while (--retries); + ret = wait_for_mbox_ready(proc_priv); + if (ret) + goto unlock_mbox; + + /* Write command register */ + reg_data = BIT_ULL(MBOX_BUSY_BIT) | id; + writel(reg_data, (proc_priv->mmio_base + MBOX_OFFSET_INTERFACE)); + + ret = wait_for_mbox_ready(proc_priv); + if (ret) + goto unlock_mbox; + + if (id == MBOX_CMD_WORKLOAD_TYPE_READ) + *resp = readl(proc_priv->mmio_base + MBOX_OFFSET_DATA); + else + *resp = readq(proc_priv->mmio_base + MBOX_OFFSET_DATA); unlock_mbox: mutex_unlock(&mbox_lock); return ret; } -int processor_thermal_send_mbox_cmd(struct pci_dev *pdev, u16 cmd_id, u32 cmd_data, u64 *cmd_resp) +int processor_thermal_send_mbox_read_cmd(struct pci_dev *pdev, u16 id, u64 *resp) { - return send_mbox_cmd(pdev, cmd_id, cmd_data, cmd_resp); + return send_mbox_read_cmd(pdev, id, resp); } -EXPORT_SYMBOL_GPL(processor_thermal_send_mbox_cmd); +EXPORT_SYMBOL_NS_GPL(processor_thermal_send_mbox_read_cmd, INT340X_THERMAL); + +int processor_thermal_send_mbox_write_cmd(struct pci_dev *pdev, u16 id, u32 data) +{ + return send_mbox_write_cmd(pdev, id, data); +} +EXPORT_SYMBOL_NS_GPL(processor_thermal_send_mbox_write_cmd, INT340X_THERMAL); /* List of workload types */ static const char * const workload_types[] = { @@ -104,7 +125,6 @@ static const char * const workload_types[] = { NULL }; - static ssize_t workload_available_types_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -146,7 +166,7 @@ static ssize_t workload_type_store(struct device *dev, data |= ret; - ret = send_mbox_cmd(pdev, MBOX_CMD_WORKLOAD_TYPE_WRITE, data, NULL); + ret = send_mbox_write_cmd(pdev, MBOX_CMD_WORKLOAD_TYPE_WRITE, data); if (ret) return false; @@ -161,7 +181,7 @@ static ssize_t workload_type_show(struct device *dev, u64 cmd_resp; int ret; - ret = send_mbox_cmd(pdev, MBOX_CMD_WORKLOAD_TYPE_READ, 0, &cmd_resp); + ret = send_mbox_read_cmd(pdev, MBOX_CMD_WORKLOAD_TYPE_READ, &cmd_resp); if (ret) return false; @@ -186,8 +206,6 @@ static const struct attribute_group workload_req_attribute_group = { .name = "workload_request" }; - - static bool workload_req_created; int proc_thermal_mbox_add(struct pci_dev *pdev, struct proc_thermal_device *proc_priv) @@ -196,7 +214,7 @@ int proc_thermal_mbox_add(struct pci_dev *pdev, struct proc_thermal_device *proc int ret; /* Check if there is a mailbox support, if fails return success */ - ret = send_mbox_cmd(pdev, MBOX_CMD_WORKLOAD_TYPE_READ, 0, &cmd_resp); + ret = send_mbox_read_cmd(pdev, MBOX_CMD_WORKLOAD_TYPE_READ, &cmd_resp); if (ret) return 0; diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_rfim.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_rfim.c index e693ec8234fb..8c42e7662033 100644 --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_rfim.c +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_rfim.c @@ -9,6 +9,8 @@ #include <linux/pci.h> #include "processor_thermal_device.h" +MODULE_IMPORT_NS(INT340X_THERMAL); + struct mmio_reg { int read_only; u32 offset; @@ -194,8 +196,7 @@ static ssize_t rfi_restriction_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { - u16 cmd_id = 0x0008; - u64 cmd_resp; + u16 id = 0x0008; u32 input; int ret; @@ -203,7 +204,7 @@ static ssize_t rfi_restriction_store(struct device *dev, if (ret) return ret; - ret = processor_thermal_send_mbox_cmd(to_pci_dev(dev), cmd_id, input, &cmd_resp); + ret = processor_thermal_send_mbox_write_cmd(to_pci_dev(dev), id, input); if (ret) return ret; @@ -214,30 +215,30 @@ static ssize_t rfi_restriction_show(struct device *dev, struct device_attribute *attr, char *buf) { - u16 cmd_id = 0x0007; - u64 cmd_resp; + u16 id = 0x0007; + u64 resp; int ret; - ret = processor_thermal_send_mbox_cmd(to_pci_dev(dev), cmd_id, 0, &cmd_resp); + ret = processor_thermal_send_mbox_read_cmd(to_pci_dev(dev), id, &resp); if (ret) return ret; - return sprintf(buf, "%llu\n", cmd_resp); + return sprintf(buf, "%llu\n", resp); } static ssize_t ddr_data_rate_show(struct device *dev, struct device_attribute *attr, char *buf) { - u16 cmd_id = 0x0107; - u64 cmd_resp; + u16 id = 0x0107; + u64 resp; int ret; - ret = processor_thermal_send_mbox_cmd(to_pci_dev(dev), cmd_id, 0, &cmd_resp); + ret = processor_thermal_send_mbox_read_cmd(to_pci_dev(dev), id, &resp); if (ret) return ret; - return sprintf(buf, "%llu\n", cmd_resp); + return sprintf(buf, "%llu\n", resp); } static DEVICE_ATTR_RW(rfi_restriction); -- 2.17.1

2 years, 11 months

2
1
0 0

stable-rc/queue/5.4 baseline: 91 runs, 4 regressions (v5.4.176-10-gac53e07b07a0)

by kernelci.org bot

stable-rc/queue/5.4 baseline: 91 runs, 4 regressions (v5.4.176-10-gac53e07b07a0) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions -------------------------+------+--------------+----------+--------------------+------------ qemu_arm-virt-gicv2-uefi | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 qemu_arm-virt-gicv2-uefi | arm | lab-broonie | gcc-10 | multi_v7_defconfig | 1 qemu_arm-virt-gicv3-uefi | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 qemu_arm-virt-gicv3-uefi | arm | lab-broonie | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F5.4/kernel/v5.4.176-… Test: baseline Tree: stable-rc Branch: queue/5.4 Describe: v5.4.176-10-gac53e07b07a0 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: ac53e07b07a0c02a3684c6b295fefa9703e47c2d Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions -------------------------+------+--------------+----------+--------------------+------------ qemu_arm-virt-gicv2-uefi | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/61fd353ea1f5c607895d6f00 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: multi_v7_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.176-10-gac53e07b07a0… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.176-10-gac53e07b07a0… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/61fd353ea1f5c607895d6f01 failing since 50 days (last pass: v5.4.165-9-g27d736c7bdee, first fail: v5.4.165-18-ge938927511cb) platform | arch | lab | compiler | defconfig | regressions -------------------------+------+--------------+----------+--------------------+------------ qemu_arm-virt-gicv2-uefi | arm | lab-broonie | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/61fd350179b142a03a5d6efc Results: 0 PASS, 1 FAIL, 0 SKIP Full config: multi_v7_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.176-10-gac53e07b07a0… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.176-10-gac53e07b07a0… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/61fd350179b142a03a5d6efd failing since 50 days (last pass: v5.4.165-9-g27d736c7bdee, first fail: v5.4.165-18-ge938927511cb) platform | arch | lab | compiler | defconfig | regressions -------------------------+------+--------------+----------+--------------------+------------ qemu_arm-virt-gicv3-uefi | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/61fd34eeba1c90d8895d6ee8 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: multi_v7_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.176-10-gac53e07b07a0… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.176-10-gac53e07b07a0… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/61fd34eeba1c90d8895d6ee9 failing since 50 days (last pass: v5.4.165-9-g27d736c7bdee, first fail: v5.4.165-18-ge938927511cb) platform | arch | lab | compiler | defconfig | regressions -------------------------+------+--------------+----------+--------------------+------------ qemu_arm-virt-gicv3-uefi | arm | lab-broonie | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/61fd34ff79b142a03a5d6eef Results: 0 PASS, 1 FAIL, 0 SKIP Full config: multi_v7_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.176-10-gac53e07b07a0… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.176-10-gac53e07b07a0… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.login: https://kernelci.org/test/case/id/61fd34ff79b142a03a5d6ef0 failing since 50 days (last pass: v5.4.165-9-g27d736c7bdee, first fail: v5.4.165-18-ge938927511cb)

2 years, 11 months

1
0
0 0

stable-rc/queue/4.9 baseline: 87 runs, 1 regressions (v4.9.299-32-gd7365d857865)

by kernelci.org bot

stable-rc/queue/4.9 baseline: 87 runs, 1 regressions (v4.9.299-32-gd7365d857865) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ---------+------+---------------+----------+---------------------+------------ panda | arm | lab-collabora | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F4.9/kernel/v4.9.299-… Test: baseline Tree: stable-rc Branch: queue/4.9 Describe: v4.9.299-32-gd7365d857865 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: d7365d85786503014dd1c0fb13092979cfffdc60 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ---------+------+---------------+----------+---------------------+------------ panda | arm | lab-collabora | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/plan/id/61fd338f0d52563ab45d6f12 Results: 4 PASS, 1 FAIL, 1 SKIP Full config: omap2plus_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.299-32-gd7365d857865… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.299-32-gd7365d857865… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2022… * baseline.dmesg.emerg: https://kernelci.org/test/case/id/61fd338f0d52563ab45d6f18 failing since 2 days (last pass: v4.9.299-13-g3de150ae8483, first fail: v4.9.299-25-g8ae76dc07a67) 2 lines 2022-02-04T14:09:02.289029 [ 20.128570] <LAVA_SIGNAL_TESTCASE TEST_CASE_ID=alert RESULT=pass UNITS=lines MEASUREMENT=0> 2022-02-04T14:09:02.331049 kern :emerg : BUG: spinlock bad magic on CPU#0, udevd/118 2022-02-04T14:09:02.340201 kern :emerg : lock: emif_lock+0x0/0xfffff230 [emif], .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0

2 years, 11 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror February 2022