On 03.01.22 19:26, Leon Romanovsky wrote:
> On Mon, Jan 03, 2022 at 02:15:59PM +0100, Thorsten Leemhuis wrote:
>> Hi, this is your Linux kernel regression tracker speaking.
>>
>> On 03.01.22 10:51, Leon Romanovsky wrote:
>>> On Wed, Dec 22, 2021 at 10:51:58AM +0800, Tony Lu wrote:
>>>> On Tue, Dec 21, 2021 at 11:46:41AM +0200, Leon Romanovsky wrote:
>>>>> From: Maor Gottlieb <maorg(a)nvidia.com>
>>>>>
>>>>> The cited commit moved umem into the union, hence
>>>>> umem could be accessed only for user MRs. Add udata check
>>>>> before access umem in the dereg flow.
>>>>>
>>>>> Fixes: f0ae4afe3d35 ("RDMA/mlx5: Fix releasing unallocated memory in dereg MR flow")
>>>>> Tested-by: Chuck Lever <chuck.lever(a)oracle.com>
>>>>> Signed-off-by: Maor Gottlieb <maorg(a)nvidia.com>
>>>>> Signed-off-by: Leon Romanovsky <leonro(a)nvidia.com>
>>>>> ---
>>>>> drivers/infiniband/hw/mlx5/mlx5_ib.h | 2 +-
>>>>> drivers/infiniband/hw/mlx5/mr.c | 4 ++--
>>>>> drivers/infiniband/hw/mlx5/odp.c | 4 ++--
>>>>> 3 files changed, 5 insertions(+), 5 deletions(-)
>>>>>
>>>>> diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/drivers/infiniband/hw/mlx5/mlx5_ib.h
>>>>
>>>> This patch was tested and works for me in our environment for SMC. It
>>>> wouldn't panic when release link and call ib_dereg_mr.
>>>>
>>>> Tested-by: Tony Lu <tonylu(a)linux.alibaba.com>
>>>
>>> Thanks, unfortunately, this patch is incomplete.
>>
>> Could you be a bit more verbose and give a status update? It's hard to
>> follow from the outside. But according to the "Fixes: f0ae4afe3d35"
>> above this was supposed to fix a regression introduced in v5.16-rc5 that
>> was also reported here:
>> https://lore.kernel.org/linux-rdma/9974ea8c-f1cb-aeb4-cf1b-19d37536894a@lin…
>
> The problematic commit f0ae4afe3d35 ("RDMA/mlx5: Fix releasing unallocated memory in dereg MR flow")
> should be reverted https://lore.kernel.org/all/20211222101312.1358616-1-maorg@nvidia.com
> and rewritten from the beginning.
Thx for the clarification. Is anyone tasked for sending the revert
upstream, to make sure the revert makes it into 5.16, which is due on
Sunday night?
And someone likely should ensure the change backported to 5.15.y as
e3bc4d4b50cae7db08e50dbe43f771c906e97701 is reverted as well. CCing a
few lists and Greg to make sure everyone is in the loop.
Ciao, Thorsten
This is the start of the stable review cycle for the 5.10.90 release.
There are 48 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Wed, 05 Jan 2022 14:20:40 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.90-rc…
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Linux 5.10.90-rc1
Daniel Borkmann <daniel(a)iogearbox.net>
bpf: Add kconfig knob for disabling unpriv bpf by default
Adrian Hunter <adrian.hunter(a)intel.com>
perf script: Fix CPU filtering of a script's switch events
Muchun Song <songmuchun(a)bytedance.com>
net: fix use-after-free in tw_timer_handler
Leo L. Schwab <ewhac(a)ewhac.org>
Input: spaceball - fix parsing of movement data packets
Pavel Skripkin <paskripkin(a)gmail.com>
Input: appletouch - initialize work before device registration
Alexey Makhalov <amakhalov(a)vmware.com>
scsi: vmw_pvscsi: Set residual data length conditionally
Todd Kjos <tkjos(a)google.com>
binder: fix async_free_space accounting for empty parcels
Chunfeng Yun <chunfeng.yun(a)mediatek.com>
usb: mtu3: set interval of FS intr and isoc endpoint
Chunfeng Yun <chunfeng.yun(a)mediatek.com>
usb: mtu3: fix list_head check warning
Chunfeng Yun <chunfeng.yun(a)mediatek.com>
usb: mtu3: add memory barrier before set GPD's HWO
Vincent Pelletier <plr.vincent(a)gmail.com>
usb: gadget: f_fs: Clear ffs_eventfd in ffs_data_clear.
Mathias Nyman <mathias.nyman(a)linux.intel.com>
xhci: Fresco FL1100 controller should not have BROKEN_MSI quirk set.
Alex Deucher <alexander.deucher(a)amd.com>
drm/amdgpu: add support for IP discovery gc_info table v2
chen gong <curry.gong(a)amd.com>
drm/amdgpu: When the VCN(1.0) block is suspended, powergating is explicitly enabled
Dmitry V. Levin <ldv(a)altlinux.org>
uapi: fix linux/nfc.h userspace compilation errors
Krzysztof Kozlowski <krzysztof.kozlowski(a)canonical.com>
nfc: uapi: use kernel size_t to fix user-space builds
Pavel Skripkin <paskripkin(a)gmail.com>
i2c: validate user data in compat ioctl
Miaoqian Lin <linmq006(a)gmail.com>
fsl/fman: Fix missing put_device() call in fman_port_probe
Jiasheng Jiang <jiasheng(a)iscas.ac.cn>
net/ncsi: check for error return from call to nla_put_u32
wujianguo <wujianguo(a)chinatelecom.cn>
selftests/net: udpgso_bench_tx: fix dst ip argument
Gal Pressman <gal(a)nvidia.com>
net/mlx5e: Fix wrong features assignment in case of error
Christophe JAILLET <christophe.jaillet(a)wanadoo.fr>
ionic: Initialize the 'lif->dbid_inuse' bitmap
James McLaughlin <james.mclaughlin(a)qsc.com>
igc: Fix TX timestamp support for non-MSI-X platforms
Dust Li <dust.li(a)linux.alibaba.com>
net/smc: fix kernel panic caused by race of smc_sock
Dust Li <dust.li(a)linux.alibaba.com>
net/smc: don't send CDC/LLC message if link not ready
Karsten Graul <kgraul(a)linux.ibm.com>
net/smc: improved fix wait on already cleared link
Wei Yongjun <weiyongjun1(a)huawei.com>
NFC: st21nfca: Fix memory leak in device probe and remove
Aleksander Jan Bajkowski <olek2(a)wp.pl>
net: lantiq_xrx200: fix statistics of received bytes
Christophe JAILLET <christophe.jaillet(a)wanadoo.fr>
net: ag71xx: Fix a potential double free in error handling paths
Matthias-Christian Ott <ott(a)mirix.org>
net: usb: pegasus: Do not drop long Ethernet frames
Karsten Graul <kgraul(a)linux.ibm.com>
net/smc: fix using of uninitialized completions
Xin Long <lucien.xin(a)gmail.com>
sctp: use call_rcu to free endpoint
Miaoqian Lin <linmq006(a)gmail.com>
net: phy: fixed_phy: Fix NULL vs IS_ERR() checking in __fixed_phy_register
Coco Li <lixiaoyan(a)google.com>
selftests: Calculate udpgso segment count without header adjustment
Coco Li <lixiaoyan(a)google.com>
udp: using datalen to cap ipv6 udp max gso segments
Maxim Mikityanskiy <maximmi(a)mellanox.com>
net/mlx5e: Fix ICOSQ recovery flow for XSK
Amir Tzin <amirtz(a)nvidia.com>
net/mlx5e: Wrap the tx reporter dump callback to extract the sq
Miaoqian Lin <linmq006(a)gmail.com>
net/mlx5: DR, Fix NULL vs IS_ERR checking in dr_domain_init_resources
Dan Carpenter <dan.carpenter(a)oracle.com>
scsi: lpfc: Terminate string in lpfc_debugfs_nvmeio_trc_write()
Tom Rix <trix(a)redhat.com>
selinux: initialize proto variable in selinux_ip_postroute_compat()
Heiko Carstens <hca(a)linux.ibm.com>
recordmcount.pl: fix typo in s390 mcount regex
Jackie Liu <liuyun01(a)kylinos.cn>
memblock: fix memblock_phys_alloc() section mismatch error
Wang Qing <wangqing(a)vivo.com>
platform/x86: apple-gmux: use resource_size() with res
Helge Deller <deller(a)gmx.de>
parisc: Clear stale IIR value on instruction access rights trap
Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp>
tomoyo: use hwight16() in tomoyo_domain_quota_is_ok()
Dmitry Vyukov <dvyukov(a)google.com>
tomoyo: Check exceeded quota early in tomoyo_domain_quota_is_ok().
Samuel Čavoj <samuel(a)cavoj.net>
Input: i8042 - enable deferred probe quirk for ASUS UM325UA
Takashi Iwai <tiwai(a)suse.de>
Input: i8042 - add deferred probe support
-------------
Diffstat:
Documentation/admin-guide/kernel-parameters.txt | 2 +
Documentation/admin-guide/sysctl/kernel.rst | 17 ++++-
Makefile | 4 +-
arch/parisc/kernel/traps.c | 2 +
drivers/android/binder_alloc.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 76 +++++++++++++++-------
drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 7 ++
drivers/gpu/drm/amd/include/discovery.h | 49 ++++++++++++++
drivers/i2c/i2c-dev.c | 3 +
drivers/input/joystick/spaceball.c | 11 +++-
drivers/input/mouse/appletouch.c | 4 +-
drivers/input/serio/i8042-x86ia64io.h | 21 ++++++
drivers/input/serio/i8042.c | 54 +++++++++------
drivers/net/ethernet/atheros/ag71xx.c | 23 +++----
drivers/net/ethernet/freescale/fman/fman_port.c | 12 ++--
drivers/net/ethernet/intel/igc/igc_main.c | 6 ++
drivers/net/ethernet/lantiq_xrx200.c | 2 +-
drivers/net/ethernet/mellanox/mlx5/core/en.h | 3 -
.../ethernet/mellanox/mlx5/core/en/reporter_tx.c | 10 ++-
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 41 ++++++++----
.../mellanox/mlx5/core/steering/dr_domain.c | 5 +-
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 2 +-
drivers/net/phy/fixed_phy.c | 4 +-
drivers/net/usb/pegasus.c | 4 +-
drivers/nfc/st21nfca/i2c.c | 29 ++++++---
drivers/platform/x86/apple-gmux.c | 2 +-
drivers/scsi/lpfc/lpfc_debugfs.c | 4 +-
drivers/scsi/vmw_pvscsi.c | 7 +-
drivers/usb/gadget/function/f_fs.c | 9 ++-
drivers/usb/host/xhci-pci.c | 5 +-
drivers/usb/mtu3/mtu3_gadget.c | 8 +++
drivers/usb/mtu3/mtu3_qmu.c | 7 +-
include/linux/memblock.h | 4 +-
include/net/sctp/sctp.h | 6 +-
include/net/sctp/structs.h | 3 +-
include/uapi/linux/nfc.h | 6 +-
init/Kconfig | 10 +++
kernel/bpf/syscall.c | 3 +-
kernel/sysctl.c | 29 +++++++--
net/ipv4/af_inet.c | 10 ++-
net/ipv6/udp.c | 2 +-
net/ncsi/ncsi-netlink.c | 6 +-
net/sctp/diag.c | 12 ++--
net/sctp/endpointola.c | 23 ++++---
net/sctp/socket.c | 23 ++++---
net/smc/smc.h | 5 ++
net/smc/smc_cdc.c | 59 ++++++++---------
net/smc/smc_cdc.h | 2 +-
net/smc/smc_core.c | 47 ++++++++-----
net/smc/smc_core.h | 6 ++
net/smc/smc_ib.c | 4 +-
net/smc/smc_ib.h | 1 +
net/smc/smc_llc.c | 65 +++++++++++++-----
net/smc/smc_tx.c | 22 ++-----
net/smc/smc_wr.c | 51 +++------------
net/smc/smc_wr.h | 17 ++++-
scripts/recordmcount.pl | 2 +-
security/selinux/hooks.c | 2 +-
security/tomoyo/util.c | 31 ++++-----
tools/perf/builtin-script.c | 2 +-
tools/testing/selftests/net/udpgso.c | 12 ++--
tools/testing/selftests/net/udpgso_bench_tx.c | 8 ++-
62 files changed, 597 insertions(+), 311 deletions(-)
This is the start of the stable review cycle for the 5.4.170 release.
There are 37 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Wed, 05 Jan 2022 14:20:40 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.170-rc…
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Linux 5.4.170-rc1
Adrian Hunter <adrian.hunter(a)intel.com>
perf script: Fix CPU filtering of a script's switch events
Muchun Song <songmuchun(a)bytedance.com>
net: fix use-after-free in tw_timer_handler
Leo L. Schwab <ewhac(a)ewhac.org>
Input: spaceball - fix parsing of movement data packets
Pavel Skripkin <paskripkin(a)gmail.com>
Input: appletouch - initialize work before device registration
Alexey Makhalov <amakhalov(a)vmware.com>
scsi: vmw_pvscsi: Set residual data length conditionally
Todd Kjos <tkjos(a)google.com>
binder: fix async_free_space accounting for empty parcels
Chunfeng Yun <chunfeng.yun(a)mediatek.com>
usb: mtu3: set interval of FS intr and isoc endpoint
Chunfeng Yun <chunfeng.yun(a)mediatek.com>
usb: mtu3: fix list_head check warning
Chunfeng Yun <chunfeng.yun(a)mediatek.com>
usb: mtu3: add memory barrier before set GPD's HWO
Vincent Pelletier <plr.vincent(a)gmail.com>
usb: gadget: f_fs: Clear ffs_eventfd in ffs_data_clear.
Mathias Nyman <mathias.nyman(a)linux.intel.com>
xhci: Fresco FL1100 controller should not have BROKEN_MSI quirk set.
Dmitry V. Levin <ldv(a)altlinux.org>
uapi: fix linux/nfc.h userspace compilation errors
Krzysztof Kozlowski <krzysztof.kozlowski(a)canonical.com>
nfc: uapi: use kernel size_t to fix user-space builds
Pavel Skripkin <paskripkin(a)gmail.com>
i2c: validate user data in compat ioctl
Miaoqian Lin <linmq006(a)gmail.com>
fsl/fman: Fix missing put_device() call in fman_port_probe
Jiasheng Jiang <jiasheng(a)iscas.ac.cn>
net/ncsi: check for error return from call to nla_put_u32
wujianguo <wujianguo(a)chinatelecom.cn>
selftests/net: udpgso_bench_tx: fix dst ip argument
Gal Pressman <gal(a)nvidia.com>
net/mlx5e: Fix wrong features assignment in case of error
Christophe JAILLET <christophe.jaillet(a)wanadoo.fr>
ionic: Initialize the 'lif->dbid_inuse' bitmap
Wei Yongjun <weiyongjun1(a)huawei.com>
NFC: st21nfca: Fix memory leak in device probe and remove
Aleksander Jan Bajkowski <olek2(a)wp.pl>
net: lantiq_xrx200: fix statistics of received bytes
Matthias-Christian Ott <ott(a)mirix.org>
net: usb: pegasus: Do not drop long Ethernet frames
Xin Long <lucien.xin(a)gmail.com>
sctp: use call_rcu to free endpoint
Miaoqian Lin <linmq006(a)gmail.com>
net: phy: fixed_phy: Fix NULL vs IS_ERR() checking in __fixed_phy_register
Coco Li <lixiaoyan(a)google.com>
selftests: Calculate udpgso segment count without header adjustment
Coco Li <lixiaoyan(a)google.com>
udp: using datalen to cap ipv6 udp max gso segments
Miaoqian Lin <linmq006(a)gmail.com>
net/mlx5: DR, Fix NULL vs IS_ERR checking in dr_domain_init_resources
Dan Carpenter <dan.carpenter(a)oracle.com>
scsi: lpfc: Terminate string in lpfc_debugfs_nvmeio_trc_write()
Tom Rix <trix(a)redhat.com>
selinux: initialize proto variable in selinux_ip_postroute_compat()
Heiko Carstens <hca(a)linux.ibm.com>
recordmcount.pl: fix typo in s390 mcount regex
Jackie Liu <liuyun01(a)kylinos.cn>
memblock: fix memblock_phys_alloc() section mismatch error
Wang Qing <wangqing(a)vivo.com>
platform/x86: apple-gmux: use resource_size() with res
Dmitry Vyukov <dvyukov(a)google.com>
tomoyo: Check exceeded quota early in tomoyo_domain_quota_is_ok().
Samuel Čavoj <samuel(a)cavoj.net>
Input: i8042 - enable deferred probe quirk for ASUS UM325UA
Takashi Iwai <tiwai(a)suse.de>
Input: i8042 - add deferred probe support
Jens Wiklander <jens.wiklander(a)linaro.org>
tee: handle lookup of shm with reference count 0
Hans de Goede <hdegoede(a)redhat.com>
HID: asus: Add depends on USB_HID to HID_ASUS Kconfig option
-------------
Diffstat:
Documentation/admin-guide/kernel-parameters.txt | 2 +
Makefile | 4 +-
drivers/android/binder_alloc.c | 2 +-
drivers/hid/Kconfig | 1 +
drivers/i2c/i2c-dev.c | 3 +
drivers/input/joystick/spaceball.c | 11 +-
drivers/input/mouse/appletouch.c | 4 +-
drivers/input/serio/i8042-x86ia64io.h | 21 +++
drivers/input/serio/i8042.c | 54 ++++---
drivers/net/ethernet/freescale/fman/fman_port.c | 12 +-
drivers/net/ethernet/lantiq_xrx200.c | 2 +-
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 11 +-
.../mellanox/mlx5/core/steering/dr_domain.c | 5 +-
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 2 +-
drivers/net/phy/fixed_phy.c | 4 +-
drivers/net/usb/pegasus.c | 4 +-
drivers/nfc/st21nfca/i2c.c | 29 ++--
drivers/platform/x86/apple-gmux.c | 2 +-
drivers/scsi/lpfc/lpfc_debugfs.c | 4 +-
drivers/scsi/vmw_pvscsi.c | 7 +-
drivers/tee/tee_shm.c | 177 ++++++++-------------
drivers/usb/gadget/function/f_fs.c | 9 +-
drivers/usb/host/xhci-pci.c | 5 +-
drivers/usb/mtu3/mtu3_gadget.c | 8 +
drivers/usb/mtu3/mtu3_qmu.c | 7 +-
include/linux/memblock.h | 4 +-
include/linux/tee_drv.h | 4 +-
include/net/sctp/sctp.h | 6 +-
include/net/sctp/structs.h | 3 +-
include/uapi/linux/nfc.h | 6 +-
net/ipv4/af_inet.c | 10 +-
net/ipv6/udp.c | 2 +-
net/ncsi/ncsi-netlink.c | 6 +-
net/sctp/diag.c | 12 +-
net/sctp/endpointola.c | 23 ++-
net/sctp/socket.c | 23 ++-
scripts/recordmcount.pl | 2 +-
security/selinux/hooks.c | 2 +-
security/tomoyo/util.c | 14 +-
tools/perf/builtin-script.c | 2 +-
tools/testing/selftests/net/udpgso.c | 12 +-
tools/testing/selftests/net/udpgso_bench_tx.c | 8 +-
42 files changed, 297 insertions(+), 232 deletions(-)
Greetings!
I am Mrs. Clementine Toussaint, I have decided to donate what I have
to you/Churches/ Motherless babies/Less privileged/Widows' because I
have been suffering from throat cancer for two years now and I have a
short life to leave according to my doctor, I am entrusting this
charity project to you, I do not have formal relationship with you but
because of my present predicament and circumstances I am, I made to
contact you.
I have made up my mind to donate my inheritance of $8.5million to the
less p rivileged please help me to fulfill my last wish. At the
momentI cannot take any telephone calls right now due to the fact that
I am unable to talk due to my health status. I have adjusted my will
and my lawyer is aware.
I have willed those properties to you by quoting my Personal File
Routing and Account Information. And I have also notified the bank
that I am willing that properties to you for a good, effective and
prudent work. I know I don't know you but I have been directed to do
this by God. I will be going in for a surgery soon and I want to make
sure that I make this donation before undergoing this surgery.
I will need your support to make this dream come through, could you
let me know your interest to enable me give you further information? I
hereby advice to contact me by this email address
(tmrsclementine(a)gmail.com)
Yours Faithfully,
Mrs. Clementine Toussaint.