January 2022 - Linux-stable-mirror

Re:

by Fredrik Elvebakk

Hello Kindly get back to me for an important discussion Best regards Fredrik Elvebakk

2 years, 12 months

1
0
0 0

[PATCH v3 1/2] tpm: Fix error handling in async work

by Tadeusz Struk

When an invalid (non existing) handle is used in a TPM command, that uses the resource manager interface (/dev/tpmrm0) the resource manager tries to load it from its internal cache, but fails and the tpm_dev_transmit returns an -EINVAL error to the caller. The existing async handler doesn't handle these error cases currently and the condition in the poll handler never returns mask with EPOLLIN set. The result is that the poll call blocks and the application gets stuck until the user_read_timer wakes it up after 120 sec. Change the tpm_dev_async_work function to handle error conditions returned from tpm_dev_transmit they are also reflected in the poll mask and a correct error code could passed back to the caller. Cc: Jarkko Sakkinen <jarkko(a)kernel.org> Cc: Jason Gunthorpe <jgg(a)ziepe.ca> Cc: <linux-integrity(a)vger.kernel.org> Cc: <stable(a)vger.kernel.org> Cc: <linux-kernel(a)vger.kernel.org> Fixes: 9e1b74a63f77 ("tpm: add support for nonblocking operation") Signed-off-by: Tadeusz Struk <tstruk(a)gmail.com> --- Changed in v2: - Updated commit message with better problem description - Fixed typeos. Changed in v3: - Added a comment to tpm_dev_async_work. - Updated commit message. --- drivers/char/tpm/tpm-dev-common.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpm-dev-common.c b/drivers/char/tpm/tpm-dev-common.c index c08cbb306636..50df8f09ff79 100644 --- a/drivers/char/tpm/tpm-dev-common.c +++ b/drivers/char/tpm/tpm-dev-common.c @@ -69,7 +69,13 @@ static void tpm_dev_async_work(struct work_struct *work) ret = tpm_dev_transmit(priv->chip, priv->space, priv->data_buffer, sizeof(priv->data_buffer)); tpm_put_ops(priv->chip); - if (ret > 0) { + + /* + * If ret is > 0 then tpm_dev_transmit returned the size of the + * response. If ret is < 0 then tpm_dev_transmit failed and + * returned a return code. + */ + if (ret != 0) { priv->response_length = ret; mod_timer(&priv->user_read_timer, jiffies + (120 * HZ)); } -- 2.30.2

2 years, 12 months

3
5
0 0

I Need Your Co-operation

by Mr.John Mark

Good Day My Good Friend Let me start by introducing myself I am Mr. John Mark from Burkina Faso, I am writing you this letter based on latest development in my bank which i we like to bring you in. The sum of Ten Million Five Hundred Thousand United State Dollars ($ 10.5Million) this is legitimate Transition after the transfer we will share it, 50% for me and 50% for you. Let me know if your interested in the deal kindly Contact me for more details Kind Regards Mr.Mark John +226 78531 732

2 years, 12 months

1
0
0 0

[PATCH for-rc 3/4] IB/hfi1: Fix AIP early init panic

by mike.marciniszyn＠cornelisnetworks.com

From: Mike Marciniszyn <mike.marciniszyn(a)cornelisnetworks.com> An early failure in hfi1_ipoib_setup_rn() can lead to the following panic: [ 355.625765] BUG: unable to handle kernel NULL pointer dereference at 00000000000001b0 [ 355.634188] PGD 0 P4D 0 [ 355.636731] Oops: 0002 [#1] SMP NOPTI [ 355.659994] Workqueue: events work_for_cpu_fn [ 355.664371] RIP: 0010:try_to_grab_pending+0x2b/0x140 [ 355.669361] Code: 1f 44 00 00 41 55 41 54 55 48 89 d5 53 48 89 fb 9c 58 0f 1f 44 00 00 48 89 c2 fa 66 0f 1f 44 00 00 48 89 55 00 40 84 f6 75 77 <f0> 48 0f ba 2b 00 72 09 31 c0 5b 5d 41 5c 41 5d c3 48 89 df e8 6c [ 355.688238] RSP: 0018:ffffb6b3cf7cfa48 EFLAGS: 00010046 [ 355.693491] RAX: 0000000000000246 RBX: 00000000000001b0 RCX: 0000000000000000 [ 355.700664] RDX: 0000000000000246 RSI: 0000000000000000 RDI: 00000000000001b0 [ 355.707836] RBP: ffffb6b3cf7cfa70 R08: 0000000000000f09 R09: 0000000000000001 [ 355.715007] R10: 0000000000000000 R11: 0000000000000001 R12: 0000000000000000 [ 355.722178] R13: ffffb6b3cf7cfa90 R14: ffffffff9b2fbfc0 R15: ffff8a4fdf244690 [ 355.729351] FS: 0000000000000000(0000) GS:ffff8a527f400000(0000) knlGS:0000000000000000 [ 355.737485] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 355.743260] CR2: 00000000000001b0 CR3: 00000017e2410003 CR4: 00000000007706f0 [ 355.750434] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 355.757607] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 355.764780] PKRU: 55555554 [ 355.767497] Call Trace: [ 355.769954] __cancel_work_timer+0x42/0x190 [ 355.774159] ? dev_printk_emit+0x4e/0x70 [ 355.778115] iowait_cancel_work+0x15/0x30 [hfi1] [ 355.782768] hfi1_ipoib_txreq_deinit+0x5a/0x220 [hfi1] [ 355.787933] ? dev_err+0x6c/0x90 [ 355.791188] hfi1_ipoib_netdev_dtor+0x15/0x30 [hfi1] [ 355.796188] hfi1_ipoib_setup_rn+0x10e/0x150 [hfi1] [ 355.801094] rdma_init_netdev+0x5a/0x80 [ib_core] [ 355.805832] ? hfi1_ipoib_free_rdma_netdev+0x20/0x20 [hfi1] [ 355.811434] ipoib_intf_init+0x6c/0x350 [ib_ipoib] [ 355.816251] ipoib_intf_alloc+0x5c/0xc0 [ib_ipoib] [ 355.821068] ipoib_add_one+0xbe/0x300 [ib_ipoib] [ 355.825712] add_client_context+0x12c/0x1a0 [ib_core] [ 355.830794] enable_device_and_get+0xdc/0x1d0 [ib_core] [ 355.836049] ib_register_device+0x572/0x6b0 [ib_core] [ 355.841128] rvt_register_device+0x11b/0x220 [rdmavt] [ 355.846219] hfi1_register_ib_device+0x6b4/0x770 [hfi1] [ 355.851486] do_init_one.isra.20+0x3e3/0x680 [hfi1] [ 355.856389] local_pci_probe+0x41/0x90 [ 355.860154] work_for_cpu_fn+0x16/0x20 [ 355.863921] process_one_work+0x1a7/0x360 [ 355.867948] ? create_worker+0x1a0/0x1a0 [ 355.871888] worker_thread+0x1cf/0x390 [ 355.875655] ? create_worker+0x1a0/0x1a0 [ 355.879594] kthread+0x116/0x130 [ 355.882838] ? kthread_flush_work_fn+0x10/0x10 [ 355.887302] ret_from_fork+0x1f/0x40 [ 355.890893] Modules linked in: rpcrdma sunrpc rdma_ucm ib_srpt ib_isert acpi_cpufreq(-) iscsi_target_mod target_core_mod ib_iser libiscsi scsi_transport_iscsi ib_umad rdma_cm ib_ipoib iw_cm ib_cm mlx5_ib intel_rapl_msr intel_rapl_ common isst_if_common x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm irqbypass mlx5_core crct10dif_pclmul crc32_pclmul hfi1(OE+) tls ghash_clmulni_intel rdmavt(OE) mgag200 drm_kms_helper mlxfw mei_me syscopyarea sysfill rect ib_uverbs sysimgblt fb_sys_fops rapl ioatdma intel_cstate tg3 i2c_algo_bit mei hpwdt ses drm ib_core pci_hyperv_intf uas enclosure hpilo pcspkr intel_uncore wmi lpc_ich dca acpi_tad ipmi_ssif acpi_power_meter binfmt_misc xpmem(O ) numatools(O) fuse ip_tables dm_mod xfs libcrc32c vfat fat ext4 mbcache jbd2 sd_mod t10_pi sg smartpqi ipmi_si scsi_transport_sas usb_storage ipmi_devintf ipmi_msghandler crc32c_intel [last unloaded: mlxfw] [ 355.970226] CR2: 00000000000001b0 [ 355.973583] The panic happens in hfi1_ipoib_txreq_deinit() because there is a NULL deref when hfi1_ipoib_netdev_dtor() is called in this error case. hfi1_ipoib_txreq_init() and hfi1_ipoib_rxq_init() are self unwinding so fix by adjusting the error paths accordingly. Other changes: - hfi1_ipoib_free_rdma_netdev() is deleted including the free_netdev() since the netdev core code deletes calls free_netdev() - The switch to the accelerated entrances is moved to the success path. Fixes: d99dc602e2a5 ("IB/hfi1: Add functions to transmit datagram ipoib packets") Cc: stable(a)vger.kernel.org Reviewed-by: Dennis Dalessandro <dennis.dalessandro(a)cornelisnetworks.com> Signed-off-by: Mike Marciniszyn <mike.marciniszyn(a)cornelisnetworks.com> --- drivers/infiniband/hw/hfi1/ipoib_main.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/ipoib_main.c b/drivers/infiniband/hw/hfi1/ipoib_main.c index e1a2b02..8306ed5 100644 --- a/drivers/infiniband/hw/hfi1/ipoib_main.c +++ b/drivers/infiniband/hw/hfi1/ipoib_main.c @@ -168,12 +168,6 @@ static void hfi1_ipoib_netdev_dtor(struct net_device *dev) free_percpu(dev->tstats); } -static void hfi1_ipoib_free_rdma_netdev(struct net_device *dev) -{ - hfi1_ipoib_netdev_dtor(dev); - free_netdev(dev); -} - static void hfi1_ipoib_set_id(struct net_device *dev, int id) { struct hfi1_ipoib_dev_priv *priv = hfi1_ipoib_priv(dev); @@ -211,24 +205,23 @@ static int hfi1_ipoib_setup_rn(struct ib_device *device, priv->port_num = port_num; priv->netdev_ops = netdev->netdev_ops; - netdev->netdev_ops = &hfi1_ipoib_netdev_ops; - ib_query_pkey(device, port_num, priv->pkey_index, &priv->pkey); rc = hfi1_ipoib_txreq_init(priv); if (rc) { dd_dev_err(dd, "IPoIB netdev TX init - failed(%d)\n", rc); - hfi1_ipoib_free_rdma_netdev(netdev); return rc; } rc = hfi1_ipoib_rxq_init(netdev); if (rc) { dd_dev_err(dd, "IPoIB netdev RX init - failed(%d)\n", rc); - hfi1_ipoib_free_rdma_netdev(netdev); + hfi1_ipoib_txreq_deinit(priv); return rc; } + netdev->netdev_ops = &hfi1_ipoib_netdev_ops; + netdev->priv_destructor = hfi1_ipoib_netdev_dtor; netdev->needs_free_netdev = true; -- 1.8.3.1

2 years, 12 months

1
0
0 0

[PATCH for-rc 2/4] IB/hfi1: Fix alloc failure with larger txqueuelen

by mike.marciniszyn＠cornelisnetworks.com

From: Mike Marciniszyn <mike.marciniszyn(a)cornelisnetworks.com> The following allocation with large txqueuelen will result in the following warning: [ 136.166367] Call Trace: [ 136.169661] __alloc_pages_nodemask+0x283/0x2c0 [ 136.175273] kmalloc_large_node+0x3c/0xa0 [ 136.180289] __kmalloc_node+0x22a/0x2f0 [ 136.185110] ? __kmalloc_node+0x22a/0x2f0 [ 136.190169] hfi1_ipoib_txreq_init+0x19f/0x330 [hfi1] [ 136.196453] hfi1_ipoib_setup_rn+0xd3/0x1a0 [hfi1] [ 136.202396] rdma_init_netdev+0x5a/0x80 [ib_core] [ 136.208210] ? hfi1_ipoib_set_id+0x30/0x30 [hfi1] [ 136.213995] ipoib_intf_init+0x6c/0x350 [ib_ipoib] [ 136.219873] ipoib_intf_alloc+0x5c/0xc0 [ib_ipoib] [ 136.225751] ipoib_add_one+0xbe/0x300 [ib_ipoib] [ 136.231563] add_client_context+0x12c/0x1a0 [ib_core] [ 136.237739] ib_register_client+0x147/0x190 [ib_core] [ 136.243906] ? 0xffffffffc0570000 [ 136.248123] ipoib_init_module+0xdd/0x132 [ib_ipoib] [ 136.254212] do_one_initcall+0x46/0x1c3 [ 136.259136] ? do_init_module+0x22/0x220 [ 136.264043] ? kmem_cache_alloc_trace+0x131/0x270 [ 136.269813] do_init_module+0x5a/0x220 [ 136.274547] load_module+0x14c5/0x17f0 [ 136.279246] ? __do_sys_init_module+0x13b/0x180 [ 136.284810] __do_sys_init_module+0x13b/0x180 [ 136.290295] do_syscall_64+0x5b/0x1a0 [ 136.294914] entry_SYSCALL_64_after_hwframe+0x65/0xca [ 136.301070] RIP: 0033:0x7f3eacd0d80e For ipoib, the txqueuelen is modified with the module parameter send_queue_size. Fix by changing to use kv versions of the same allocator to handle the large allocations. The allocation embeds a hdr struct that is dma mapped. Change that struct to a pointer to a kzalloced struct. Fixes: d99dc602e2a5 ("IB/hfi1: Add functions to transmit datagram ipoib packets") Cc: stable(a)vger.kernel.org Reviewed-by: Dennis Dalessandro <dennis.dalessandro(a)cornelisnetworks.com> Signed-off-by: Mike Marciniszyn <mike.marciniszyn(a)cornelisnetworks.com> --- drivers/infiniband/hw/hfi1/ipoib.h | 2 +- drivers/infiniband/hw/hfi1/ipoib_tx.c | 36 ++++++++++++++++++++++++----------- 2 files changed, 26 insertions(+), 12 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/ipoib.h b/drivers/infiniband/hw/hfi1/ipoib.h index 9091229..aec60d4 100644 --- a/drivers/infiniband/hw/hfi1/ipoib.h +++ b/drivers/infiniband/hw/hfi1/ipoib.h @@ -55,7 +55,7 @@ */ struct ipoib_txreq { struct sdma_txreq txreq; - struct hfi1_sdma_header sdma_hdr; + struct hfi1_sdma_header *sdma_hdr; int sdma_status; int complete; struct hfi1_ipoib_dev_priv *priv; diff --git a/drivers/infiniband/hw/hfi1/ipoib_tx.c b/drivers/infiniband/hw/hfi1/ipoib_tx.c index bf62956..d6bbdb8 100644 --- a/drivers/infiniband/hw/hfi1/ipoib_tx.c +++ b/drivers/infiniband/hw/hfi1/ipoib_tx.c @@ -122,7 +122,7 @@ static void hfi1_ipoib_free_tx(struct ipoib_txreq *tx, int budget) dd_dev_warn(priv->dd, "%s: Status = 0x%x pbc 0x%llx txq = %d sde = %d\n", __func__, tx->sdma_status, - le64_to_cpu(tx->sdma_hdr.pbc), tx->txq->q_idx, + le64_to_cpu(tx->sdma_hdr->pbc), tx->txq->q_idx, tx->txq->sde->this_idx); } @@ -231,7 +231,7 @@ static int hfi1_ipoib_build_tx_desc(struct ipoib_txreq *tx, { struct hfi1_devdata *dd = txp->dd; struct sdma_txreq *txreq = &tx->txreq; - struct hfi1_sdma_header *sdma_hdr = &tx->sdma_hdr; + struct hfi1_sdma_header *sdma_hdr = tx->sdma_hdr; u16 pkt_bytes = sizeof(sdma_hdr->pbc) + (txp->hdr_dwords << 2) + tx->skb->len; int ret; @@ -256,7 +256,7 @@ static void hfi1_ipoib_build_ib_tx_headers(struct ipoib_txreq *tx, struct ipoib_txparms *txp) { struct hfi1_ipoib_dev_priv *priv = tx->txq->priv; - struct hfi1_sdma_header *sdma_hdr = &tx->sdma_hdr; + struct hfi1_sdma_header *sdma_hdr = tx->sdma_hdr; struct sk_buff *skb = tx->skb; struct hfi1_pportdata *ppd = ppd_from_ibp(txp->ibp); struct rdma_ah_attr *ah_attr = txp->ah_attr; @@ -483,7 +483,7 @@ static int hfi1_ipoib_send_dma_single(struct net_device *dev, if (likely(!ret)) { tx_ok: trace_sdma_output_ibhdr(txq->priv->dd, - &tx->sdma_hdr.hdr, + &tx->sdma_hdr->hdr, ib_is_sc5(txp->flow.sc5)); hfi1_ipoib_check_queue_depth(txq); return NETDEV_TX_OK; @@ -547,7 +547,7 @@ static int hfi1_ipoib_send_dma_list(struct net_device *dev, hfi1_ipoib_check_queue_depth(txq); trace_sdma_output_ibhdr(txq->priv->dd, - &tx->sdma_hdr.hdr, + &tx->sdma_hdr->hdr, ib_is_sc5(txp->flow.sc5)); if (!netdev_xmit_more()) @@ -683,7 +683,8 @@ int hfi1_ipoib_txreq_init(struct hfi1_ipoib_dev_priv *priv) { struct net_device *dev = priv->netdev; u32 tx_ring_size, tx_item_size; - int i; + struct hfi1_ipoib_circ_buf *tx_ring; + int i, j; /* * Ring holds 1 less than tx_ring_size @@ -701,7 +702,9 @@ int hfi1_ipoib_txreq_init(struct hfi1_ipoib_dev_priv *priv) for (i = 0; i < dev->num_tx_queues; i++) { struct hfi1_ipoib_txq *txq = &priv->txqs[i]; + struct ipoib_txreq *tx; + tx_ring = &txq->tx_ring; iowait_init(&txq->wait, 0, hfi1_ipoib_flush_txq, @@ -725,14 +728,19 @@ int hfi1_ipoib_txreq_init(struct hfi1_ipoib_dev_priv *priv) priv->dd->node); txq->tx_ring.items = - kcalloc_node(tx_ring_size, tx_item_size, - GFP_KERNEL, priv->dd->node); + kvzalloc_node(array_size(tx_ring_size, tx_item_size), + GFP_KERNEL, priv->dd->node); if (!txq->tx_ring.items) goto free_txqs; txq->tx_ring.max_items = tx_ring_size; txq->tx_ring.shift = ilog2(tx_item_size); txq->tx_ring.avail = hfi1_ipoib_ring_hwat(txq); + tx_ring = &txq->tx_ring; + for (j = 0; j < tx_ring_size; j++) + hfi1_txreq_from_idx(tx_ring, j)->sdma_hdr = + kzalloc_node(sizeof(*tx->sdma_hdr), + GFP_KERNEL, priv->dd->node); netif_tx_napi_add(dev, &txq->napi, hfi1_ipoib_poll_tx_ring, @@ -746,7 +754,10 @@ int hfi1_ipoib_txreq_init(struct hfi1_ipoib_dev_priv *priv) struct hfi1_ipoib_txq *txq = &priv->txqs[i]; netif_napi_del(&txq->napi); - kfree(txq->tx_ring.items); + tx_ring = &txq->tx_ring; + for (j = 0; j < tx_ring_size; j++) + kfree(hfi1_txreq_from_idx(tx_ring, j)->sdma_hdr); + kvfree(tx_ring->items); } kfree(priv->txqs); @@ -780,17 +791,20 @@ static void hfi1_ipoib_drain_tx_list(struct hfi1_ipoib_txq *txq) void hfi1_ipoib_txreq_deinit(struct hfi1_ipoib_dev_priv *priv) { - int i; + int i, j; for (i = 0; i < priv->netdev->num_tx_queues; i++) { struct hfi1_ipoib_txq *txq = &priv->txqs[i]; + struct hfi1_ipoib_circ_buf *tx_ring = &txq->tx_ring; iowait_cancel_work(&txq->wait); iowait_sdma_drain(&txq->wait); hfi1_ipoib_drain_tx_list(txq); netif_napi_del(&txq->napi); hfi1_ipoib_drain_tx_ring(txq); - kfree(txq->tx_ring.items); + for (j = 0; j < tx_ring->max_items; j++) + kfree(hfi1_txreq_from_idx(tx_ring, j)->sdma_hdr); + kvfree(tx_ring->items); } kfree(priv->txqs); -- 1.8.3.1

2 years, 12 months

1
0
0 0

[PATCH for-rc 1/4] IB/hfi1: Fix panic with larger ipoib send_queue_size

by mike.marciniszyn＠cornelisnetworks.com

From: Mike Marciniszyn <mike.marciniszyn(a)cornelisnetworks.com> When the ipoib send_queue_size is increased from the default the following panic happens: [ 219.242960] RIP: 0010:hfi1_ipoib_drain_tx_ring+0x45/0xf0 [hfi1] [ 219.250708] Code: 31 e4 eb 0f 8b 85 c8 02 00 00 41 83 c4 01 44 39 e0 76 60 8b 8d cc 02 00 00 44 89 e3 be 01 00 00 00 d3 e3 48 03 9d c0 02 00 00 <c7> 83 18 01 00 00 00 00 00 00 48 8b bb 30 01 00 00 e8 25 af a7 e0 [ 219.273764] RSP: 0018:ffffc9000798f4a0 EFLAGS: 00010286 [ 219.280740] RAX: 0000000000008000 RBX: ffffc9000aa0f000 RCX: 000000000000000f [ 219.289842] RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000 [ 219.298864] RBP: ffff88810ff08000 R08: ffff88889476d900 R09: 0000000000000101 [ 219.307907] R10: 0000000000000000 R11: ffffc90006590ff8 R12: 0000000000000200 [ 219.317016] R13: ffffc9000798fba8 R14: 0000000000000000 R15: 0000000000000001 [ 219.326100] FS: 00007fd0f79cc3c0(0000) GS:ffff88885fb00000(0000) knlGS:0000000000000000 [ 219.336171] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 219.343639] CR2: ffffc9000aa0f118 CR3: 0000000889c84001 CR4: 00000000001706e0 [ 219.352589] Call Trace: [ 219.356340] <TASK> [ 219.359804] hfi1_ipoib_napi_tx_disable+0x45/0x60 [hfi1] [ 219.366887] hfi1_ipoib_dev_stop+0x18/0x80 [hfi1] [ 219.373313] ipoib_ib_dev_stop+0x1d/0x40 [ib_ipoib] [ 219.379814] ipoib_stop+0x48/0xc0 [ib_ipoib] [ 219.385604] __dev_close_many+0x9e/0x110 [ 219.391001] __dev_change_flags+0xd9/0x210 [ 219.396618] dev_change_flags+0x21/0x60 [ 219.401878] do_setlink+0x31c/0x10f0 [ 219.406841] ? __nla_validate_parse+0x12d/0x1a0 [ 219.412902] ? __nla_parse+0x21/0x30 [ 219.417844] ? inet6_validate_link_af+0x5e/0xf0 [ 219.423913] ? cpumask_next+0x1f/0x20 [ 219.428914] ? __snmp6_fill_stats64.isra.53+0xbb/0x140 [ 219.435648] ? __nla_validate_parse+0x47/0x1a0 [ 219.441564] __rtnl_newlink+0x530/0x910 [ 219.446818] ? pskb_expand_head+0x73/0x300 [ 219.452198] ? __kmalloc_node_track_caller+0x109/0x280 [ 219.458999] ? __nla_put+0xc/0x20 [ 219.463733] ? cpumask_next_and+0x20/0x30 [ 219.469166] ? update_sd_lb_stats.constprop.144+0xd3/0x820 [ 219.476325] ? _raw_spin_unlock_irqrestore+0x25/0x37 [ 219.482815] ? __wake_up_common_lock+0x87/0xc0 [ 219.488761] ? kmem_cache_alloc_trace+0x3d/0x3d0 [ 219.494917] rtnl_newlink+0x43/0x60 The issue happens when the shift that should have been a function of the txq item size mistakenly used the ring size. Fix by using the item size. Fixes: d47dfc2b00e6 ("IB/hfi1: Remove cache and embed txreq in ring") Cc: stable(a)vger.kernel.org Reviewed-by: Dennis Dalessandro <dennis.dalessandro(a)cornelisnetworks.com> Signed-off-by: Mike Marciniszyn <mike.marciniszyn(a)cornelisnetworks.com> --- drivers/infiniband/hw/hfi1/ipoib_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/hfi1/ipoib_tx.c b/drivers/infiniband/hw/hfi1/ipoib_tx.c index f401089..bf62956 100644 --- a/drivers/infiniband/hw/hfi1/ipoib_tx.c +++ b/drivers/infiniband/hw/hfi1/ipoib_tx.c @@ -731,7 +731,7 @@ int hfi1_ipoib_txreq_init(struct hfi1_ipoib_dev_priv *priv) goto free_txqs; txq->tx_ring.max_items = tx_ring_size; - txq->tx_ring.shift = ilog2(tx_ring_size); + txq->tx_ring.shift = ilog2(tx_item_size); txq->tx_ring.avail = hfi1_ipoib_ring_hwat(txq); netif_tx_napi_add(dev, &txq->napi, -- 1.8.3.1

2 years, 12 months

1
0
0 0

[PATCH net v4] net: phy: marvell: add Marvell specific PHY loopback

by Mohammad Athari Bin Ismail

Existing genphy_loopback() is not applicable for Marvell PHY. Besides configuring bit-6 and bit-13 in Page 0 Register 0 (Copper Control Register), it is also required to configure same bits in Page 2 Register 21 (MAC Specific Control Register 2) according to speed of the loopback is operating. Tested working on Marvell88E1510 PHY for all speeds (1000/100/10Mbps). FIXME: Based on trial and error test, it seem 1G need to have delay between soft reset and loopback enablement. Fixes: 014068dcb5b1 ("net: phy: genphy_loopback: add link speed configuration") Cc: <stable(a)vger.kernel.org> # 5.15.x Signed-off-by: Mohammad Athari Bin Ismail <mohammad.athari.ismail(a)intel.com> --- v4 changelog: - Rename the function to m88e1510_loopback(). Commented by Heiner Kallweit <hkallweit1(a)gmail.com>. v3 changelog: - Use phy_write() to configure speed for BMCR. - Add error handling. All commented by Russell King <linux(a)armlinux.org.uk> v2 changelog: - For loopback enabled, add bit-6 and bit-13 configuration in both Page 0 Register 0 and Page 2 Register 21. Commented by Heiner Kallweit <hkallweit1(a)gmail.com>. - For loopback disabled, follow genphy_loopback() implementation --- drivers/net/phy/marvell.c | 56 ++++++++++++++++++++++++++++++++++++++- 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 4fcfca4e1702..0ff94400510f 100644 --- a/drivers/net/phy/marvell.c +++ b/drivers/net/phy/marvell.c @@ -189,6 +189,8 @@ #define MII_88E1510_GEN_CTRL_REG_1_MODE_RGMII_SGMII 0x4 #define MII_88E1510_GEN_CTRL_REG_1_RESET 0x8000 /* Soft reset */ +#define MII_88E1510_MSCR_2 0x15 + #define MII_VCT5_TX_RX_MDI0_COUPLING 0x10 #define MII_VCT5_TX_RX_MDI1_COUPLING 0x11 #define MII_VCT5_TX_RX_MDI2_COUPLING 0x12 @@ -1932,6 +1934,58 @@ static void marvell_get_stats(struct phy_device *phydev, data[i] = marvell_get_stat(phydev, i); } +static int m88e1510_loopback(struct phy_device *phydev, bool enable) +{ + int err; + + if (enable) { + u16 bmcr_ctl = 0, mscr2_ctl = 0; + + if (phydev->speed == SPEED_1000) + bmcr_ctl = BMCR_SPEED1000; + else if (phydev->speed == SPEED_100) + bmcr_ctl = BMCR_SPEED100; + + if (phydev->duplex == DUPLEX_FULL) + bmcr_ctl |= BMCR_FULLDPLX; + + err = phy_write(phydev, MII_BMCR, bmcr_ctl); + if (err < 0) + return err; + + if (phydev->speed == SPEED_1000) + mscr2_ctl = BMCR_SPEED1000; + else if (phydev->speed == SPEED_100) + mscr2_ctl = BMCR_SPEED100; + + err = phy_modify_paged(phydev, MII_MARVELL_MSCR_PAGE, + MII_88E1510_MSCR_2, BMCR_SPEED1000 | + BMCR_SPEED100, mscr2_ctl); + if (err < 0) + return err; + + /* Need soft reset to have speed configuration takes effect */ + err = genphy_soft_reset(phydev); + if (err < 0) + return err; + + /* FIXME: Based on trial and error test, it seem 1G need to have + * delay between soft reset and loopback enablement. + */ + if (phydev->speed == SPEED_1000) + msleep(1000); + + return phy_modify(phydev, MII_BMCR, BMCR_LOOPBACK, + BMCR_LOOPBACK); + } else { + err = phy_modify(phydev, MII_BMCR, BMCR_LOOPBACK, 0); + if (err < 0) + return err; + + return phy_config_aneg(phydev); + } +} + static int marvell_vct5_wait_complete(struct phy_device *phydev) { int i; @@ -3078,7 +3132,7 @@ static struct phy_driver marvell_drivers[] = { .get_sset_count = marvell_get_sset_count, .get_strings = marvell_get_strings, .get_stats = marvell_get_stats, - .set_loopback = genphy_loopback, + .set_loopback = m88e1510_loopback, .get_tunable = m88e1011_get_tunable, .set_tunable = m88e1011_set_tunable, .cable_test_start = marvell_vct7_cable_test_start, -- 2.17.1

2 years, 12 months

2
1
0 0

Re:

by Fredrik Elvebakk

Hello Kindly get back to me for an important discussion Best regards Fredrik Elvebakk

2 years, 12 months

1
0
0 0

[PATCH 5.15 00/41] 5.15.15-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.15.15 release. There are 41 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 16 Jan 2022 08:15:33 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.15-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.15.15-rc1 Arnd Bergmann <arnd(a)arndb.de> staging: greybus: fix stack size warning with UBSAN Nathan Chancellor <nathan(a)kernel.org> drm/i915: Avoid bitwise vs logical OR warning in snb_wm_latency_quirk() Nathan Chancellor <nathan(a)kernel.org> staging: wlan-ng: Avoid bitwise vs logical OR warning in hfa384x_usb_throttlefn() Ricardo Ribalda <ribalda(a)chromium.org> media: Revert "media: uvcvideo: Set unique vdev name based in type" Alex Hung <alex.hung(a)canonical.com> platform/x86/intel: hid: add quirk to support Surface Go 3 Dominik Brodowski <linux(a)dominikbrodowski.net> random: fix crash on multiple early calls to add_bootloader_randomness() Eric Biggers <ebiggers(a)google.com> random: fix data race on crng init time Eric Biggers <ebiggers(a)google.com> random: fix data race on crng_node_pool Brian Silverman <brian.silverman(a)bluerivertech.com> can: gs_usb: gs_can_start_xmit(): zero-initialize hf->{flags,reserved} Marc Kleine-Budde <mkl(a)pengutronix.de> can: isotp: convert struct tpcon::{idx,len} to unsigned int Marc Kleine-Budde <mkl(a)pengutronix.de> can: gs_usb: fix use of uninitialized variable, detach device on reception of invalid USB data Borislav Petkov <bp(a)suse.de> x86/mce: Remove noinstr annotation from mce_setup() Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> mfd: intel-lpss: Fix too early PM enablement in the ACPI ->probe() Daniel Borkmann <daniel(a)iogearbox.net> veth: Do not record rx queue hint in veth_xmit Aditya Garg <gargaditya08(a)live.com> Bluetooth: btbcm: disable read tx power for MacBook Air 8,1 and 8,2 Aditya Garg <gargaditya08(a)live.com> Bluetooth: btbcm: disable read tx power for some Macs with the T2 Security chip Aditya Garg <gargaditya08(a)live.com> Bluetooth: add quirk disabling LE Read Transmit Power Adrian Hunter <adrian.hunter(a)intel.com> mmc: sdhci-pci: Add PCI ID for Intel ADL Sven Eckelmann <sven(a)narfation.org> ath11k: Fix buffer overflow when scanning with extraie Alan Stern <stern(a)rowland.harvard.edu> USB: Fix "slab-out-of-bounds Write" bug in usb_hcd_poll_rh_status Alan Stern <stern(a)rowland.harvard.edu> USB: core: Fix bug in resuming hub's handling of wakeup requests Paul Cercueil <paul(a)crapouillou.net> ARM: dts: exynos: Fix BCM4330 Bluetooth reset polarity in I9100 Johan Hovold <johan(a)kernel.org> Bluetooth: bfusb: fix division by zero in send path Aaron Ma <aaron.ma(a)canonical.com> Bluetooth: btusb: Add support for Foxconn QCA 0xe0d0 Tedd Ho-Jeong An <tedd.an(a)intel.com> Bluetooth: btintel: Fix broken LED quirk for legacy ROM devices Aaron Ma <aaron.ma(a)canonical.com> Bluetooth: btusb: Add support for Foxconn MT7922A Zijun Hu <quic_zijuhu(a)quicinc.com> Bluetooth: btusb: Add two more Bluetooth parts for WCN6855 Zijun Hu <quic_zijuhu(a)quicinc.com> Bluetooth: btusb: Add one more Bluetooth part for WCN6855 Linus Torvalds <torvalds(a)linux-foundation.org> fget: clarify and improve __fget_files() implementation tjiang(a)codeaurora.org <tjiang(a)codeaurora.org> Bluetooth: btusb: Add the new support IDs for WCN6855 Larry Finger <Larry.Finger(a)lwfinger.net> Bluetooth: btusb: Add one more Bluetooth part for the Realtek RTL8852AE mark-yw.chen <mark-yw.chen(a)mediatek.com> Bluetooth: btusb: enable Mediatek to support AOSP extension Mark-YW.Chen <mark-yw.chen(a)mediatek.com> Bluetooth: btusb: fix memory leak in btusb_mtk_submit_wmt_recv_urb() Larry Finger <Larry.Finger(a)lwfinger.net> Bbluetooth: btusb: Add another Bluetooth part for Realtek 8852AE mark-yw.chen <mark-yw.chen(a)mediatek.com> Bluetooth: btusb: Add support for IMC Networks Mediatek Chip(MT7921) Max Chou <max.chou(a)realtek.com> Bluetooth: btusb: Add the new support ID for Realtek RTL8852A mark-yw.chen <mark-yw.chen(a)mediatek.com> Bluetooth: btusb: Add protocol for MediaTek bluetooth devices(MT7922) Daniel Borkmann <daniel(a)iogearbox.net> bpf: Fix out of bounds access from invalid *_or_null type verification Martin Kaiser <martin(a)kaiser.cx> staging: r8188eu: switch the led off during deinit Frederic Weisbecker <frederic(a)kernel.org> workqueue: Fix unbind_workers() VS wq_worker_running() race Alexander Egorenkov <egorenar(a)linux.ibm.com> s390/kexec: handle R_390_PLT32DBL rela in arch_kexec_apply_relocations_add() ------------- Diffstat: Makefile | 4 +- arch/arm/boot/dts/exynos4210-i9100.dts | 2 +- arch/s390/kernel/machine_kexec_file.c | 4 ++ arch/x86/kernel/cpu/mce/core.c | 26 +++++-- drivers/bluetooth/bfusb.c | 3 + drivers/bluetooth/btbcm.c | 51 ++++++++++++++ drivers/bluetooth/btintel.c | 20 +++--- drivers/bluetooth/btintel.h | 2 +- drivers/bluetooth/btusb.c | 61 ++++++++++++++-- drivers/char/random.c | 117 ++++++++++++++++++------------- drivers/gpu/drm/i915/intel_pm.c | 6 +- drivers/media/usb/uvc/uvc_driver.c | 7 +- drivers/mfd/intel-lpss-acpi.c | 7 +- drivers/mmc/host/sdhci-pci-core.c | 1 + drivers/mmc/host/sdhci-pci.h | 1 + drivers/net/can/usb/gs_usb.c | 5 +- drivers/net/veth.c | 1 - drivers/net/wireless/ath/ath11k/wmi.c | 6 +- drivers/platform/x86/intel/hid.c | 7 ++ drivers/staging/greybus/audio_topology.c | 92 ++++++++++++------------ drivers/staging/r8188eu/core/rtw_led.c | 1 + drivers/staging/wlan-ng/hfa384x_usb.c | 22 +++--- drivers/usb/core/hcd.c | 9 ++- drivers/usb/core/hub.c | 2 +- fs/file.c | 72 ++++++++++++++----- include/net/bluetooth/hci.h | 9 +++ kernel/bpf/verifier.c | 6 +- kernel/workqueue.c | 9 +++ net/bluetooth/hci_core.c | 3 +- net/can/isotp.c | 4 +- 30 files changed, 389 insertions(+), 171 deletions(-)

2 years, 12 months

11
55
0 0

[PATCH 5.16 00/37] 5.16.1-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.16.1 release. There are 37 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 16 Jan 2022 08:15:33 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.16.1-rc1… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.16.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.16.1-rc1 Helge Deller <deller(a)gmx.de> parisc: Fix pdc_toc_pim_11 and pdc_toc_pim_20 definitions Arnd Bergmann <arnd(a)arndb.de> staging: greybus: fix stack size warning with UBSAN Nathan Chancellor <nathan(a)kernel.org> drm/i915: Avoid bitwise vs logical OR warning in snb_wm_latency_quirk() Ricardo Ribalda <ribalda(a)chromium.org> media: Revert "media: uvcvideo: Set unique vdev name based in type" Alex Hung <alex.hung(a)canonical.com> platform/x86/intel: hid: add quirk to support Surface Go 3 Dominik Brodowski <linux(a)dominikbrodowski.net> random: fix crash on multiple early calls to add_bootloader_randomness() Eric Biggers <ebiggers(a)google.com> random: fix data race on crng init time Eric Biggers <ebiggers(a)google.com> random: fix data race on crng_node_pool Brian Silverman <brian.silverman(a)bluerivertech.com> can: gs_usb: gs_can_start_xmit(): zero-initialize hf->{flags,reserved} Marc Kleine-Budde <mkl(a)pengutronix.de> can: isotp: convert struct tpcon::{idx,len} to unsigned int Marc Kleine-Budde <mkl(a)pengutronix.de> can: gs_usb: fix use of uninitialized variable, detach device on reception of invalid USB data Orlando Chamberlain <redecorating(a)protonmail.com> mfd: intel-lpss-pci: Fix clock speed for 38a8 UART Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> mfd: intel-lpss: Fix too early PM enablement in the ACPI ->probe() Daniel Borkmann <daniel(a)iogearbox.net> veth: Do not record rx queue hint in veth_xmit Aditya Garg <gargaditya08(a)live.com> Bluetooth: btbcm: disable read tx power for MacBook Air 8,1 and 8,2 Aditya Garg <gargaditya08(a)live.com> Bluetooth: btbcm: disable read tx power for some Macs with the T2 Security chip Aditya Garg <gargaditya08(a)live.com> Bluetooth: add quirk disabling LE Read Transmit Power Adrian Hunter <adrian.hunter(a)intel.com> mmc: sdhci-pci: Add PCI ID for Intel ADL Sven Eckelmann <sven(a)narfation.org> ath11k: Fix buffer overflow when scanning with extraie Alan Stern <stern(a)rowland.harvard.edu> USB: Fix "slab-out-of-bounds Write" bug in usb_hcd_poll_rh_status Alan Stern <stern(a)rowland.harvard.edu> USB: core: Fix bug in resuming hub's handling of wakeup requests Paul Cercueil <paul(a)crapouillou.net> ARM: dts: exynos: Fix BCM4330 Bluetooth reset polarity in I9100 Johan Hovold <johan(a)kernel.org> Bluetooth: bfusb: fix division by zero in send path Aaron Ma <aaron.ma(a)canonical.com> Bluetooth: btusb: Add support for Foxconn QCA 0xe0d0 Tedd Ho-Jeong An <tedd.an(a)intel.com> Bluetooth: btintel: Fix broken LED quirk for legacy ROM devices Aaron Ma <aaron.ma(a)canonical.com> Bluetooth: btusb: Add support for Foxconn MT7922A Zijun Hu <quic_zijuhu(a)quicinc.com> Bluetooth: btusb: Add two more Bluetooth parts for WCN6855 Zijun Hu <quic_zijuhu(a)quicinc.com> Bluetooth: btusb: Add one more Bluetooth part for WCN6855 tjiang(a)codeaurora.org <tjiang(a)codeaurora.org> Bluetooth: btusb: Add the new support IDs for WCN6855 mark-yw.chen <mark-yw.chen(a)mediatek.com> Bluetooth: btusb: enable Mediatek to support AOSP extension Mark-YW.Chen <mark-yw.chen(a)mediatek.com> Bluetooth: btusb: fix memory leak in btusb_mtk_submit_wmt_recv_urb() David Yang <davidcomponentone(a)gmail.com> Bluetooth: btusb: Fix application of sizeof to pointer Larry Finger <Larry.Finger(a)lwfinger.net> Bluetooth: btusb: Add one more Bluetooth part for the Realtek RTL8852AE Daniel Borkmann <daniel(a)iogearbox.net> bpf: Fix out of bounds access from invalid *_or_null type verification Martin Kaiser <martin(a)kaiser.cx> staging: r8188eu: switch the led off during deinit Frederic Weisbecker <frederic(a)kernel.org> workqueue: Fix unbind_workers() VS wq_worker_sleeping() race Frederic Weisbecker <frederic(a)kernel.org> workqueue: Fix unbind_workers() VS wq_worker_running() race ------------- Diffstat: Makefile | 4 +- arch/arm/boot/dts/exynos4210-i9100.dts | 2 +- arch/parisc/include/uapi/asm/pdc.h | 32 ++++++--- drivers/bluetooth/bfusb.c | 3 + drivers/bluetooth/btbcm.c | 51 ++++++++++++++ drivers/bluetooth/btintel.c | 20 +++--- drivers/bluetooth/btintel.h | 2 +- drivers/bluetooth/btusb.c | 49 +++++++++++-- drivers/char/random.c | 117 ++++++++++++++++++------------- drivers/gpu/drm/i915/intel_pm.c | 6 +- drivers/media/usb/uvc/uvc_driver.c | 7 +- drivers/mfd/intel-lpss-acpi.c | 7 +- drivers/mfd/intel-lpss-pci.c | 2 +- drivers/mmc/host/sdhci-pci-core.c | 1 + drivers/mmc/host/sdhci-pci.h | 1 + drivers/net/can/usb/gs_usb.c | 5 +- drivers/net/veth.c | 1 - drivers/net/wireless/ath/ath11k/wmi.c | 6 +- drivers/platform/x86/intel/hid.c | 7 ++ drivers/staging/greybus/audio_topology.c | 92 ++++++++++++------------ drivers/staging/r8188eu/core/rtw_led.c | 1 + drivers/usb/core/hcd.c | 9 ++- drivers/usb/core/hub.c | 2 +- include/net/bluetooth/hci.h | 9 +++ kernel/bpf/verifier.c | 6 +- kernel/workqueue.c | 19 +++++ net/bluetooth/hci_core.c | 3 +- net/can/isotp.c | 4 +- 28 files changed, 323 insertions(+), 145 deletions(-)

2 years, 12 months

10
46
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror January 2022