This is an automatic generated email to let you know that the following patch were queued:
Subject: media: dvbdev: Fix memory leak in dvb_media_device_free()
Author: Peilin Ye <yepeilin.cs(a)gmail.com>
Date: Fri Dec 11 09:30:39 2020 +0100
dvb_media_device_free() is leaking memory. Free `dvbdev->adapter->conn`
before setting it to NULL, as documented in include/media/media-device.h:
"The media_entity instance itself must be freed explicitly by the driver
if required."
Link: https://syzkaller.appspot.com/bug?id=9bbe4b842c98f0ed05c5eed77a226e9de33bf2…
Link: https://lore.kernel.org/linux-media/20201211083039.521617-1-yepeilin.cs@gma…
Cc: stable(a)vger.kernel.org
Fixes: 0230d60e4661 ("[media] dvbdev: Add RF connector if needed")
Reported-by: syzbot+7f09440acc069a0d38ac(a)syzkaller.appspotmail.com
Signed-off-by: Peilin Ye <yepeilin.cs(a)gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org>
drivers/media/dvb-core/dvbdev.c | 1 +
1 file changed, 1 insertion(+)
---
diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c
index 5ff7bedee247..3862ddc86ec4 100644
--- a/drivers/media/dvb-core/dvbdev.c
+++ b/drivers/media/dvb-core/dvbdev.c
@@ -241,6 +241,7 @@ static void dvb_media_device_free(struct dvb_device *dvbdev)
if (dvbdev->adapter->conn) {
media_device_unregister_entity(dvbdev->adapter->conn);
+ kfree(dvbdev->adapter->conn);
dvbdev->adapter->conn = NULL;
kfree(dvbdev->adapter->conn_pads);
dvbdev->adapter->conn_pads = NULL;