February 2021 - Linux-stable-mirror

by Greg Kroah-Hartman

I'm announcing the release of the 4.4.257 kernel. All users of the 4.4 kernel series must upgrade. The updated 4.4.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.4.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 10 - arch/arm/mach-footbridge/dc21285.c | 12 - arch/mips/Kconfig | 1 arch/x86/Makefile | 3 arch/x86/include/asm/apic.h | 10 - arch/x86/include/asm/barrier.h | 18 ++ arch/x86/kernel/apic/apic.c | 4 arch/x86/kernel/apic/x2apic_cluster.c | 3 arch/x86/kernel/apic/x2apic_phys.c | 3 drivers/acpi/thermal.c | 54 ++++-- drivers/input/joystick/xpad.c | 17 +- drivers/input/serio/i8042-x86ia64io.h | 2 drivers/mmc/core/sdio_cis.c | 6 drivers/scsi/ibmvscsi/ibmvfc.c | 4 drivers/scsi/libfc/fc_exch.c | 16 + drivers/usb/class/usblp.c | 19 +- drivers/usb/dwc2/gadget.c | 8 drivers/usb/gadget/legacy/ether.c | 4 drivers/usb/gadget/udc/udc-core.c | 13 + drivers/usb/serial/cp210x.c | 2 drivers/usb/serial/option.c | 6 fs/Kconfig.binfmt | 8 fs/cifs/dir.c | 22 ++ fs/hugetlbfs/inode.c | 3 include/linux/elfcore.h | 22 ++ include/linux/hugetlb.h | 3 kernel/Makefile | 3 kernel/elfcore.c | 25 --- kernel/futex.c | 278 +++++++++++++++++++--------------- kernel/kprobes.c | 4 kernel/locking/rtmutex-debug.c | 9 - kernel/locking/rtmutex-debug.h | 3 kernel/locking/rtmutex.c | 127 +++++++++------ kernel/locking/rtmutex.h | 2 kernel/locking/rtmutex_common.h | 12 - mm/hugetlb.c | 9 - net/lapb/lapb_out.c | 3 net/mac80211/driver-ops.c | 5 net/mac80211/rate.c | 3 net/sched/sch_api.c | 3 sound/pci/hda/patch_realtek.c | 2 41 files changed, 468 insertions(+), 293 deletions(-) Alexey Dobriyan (1): Input: i8042 - unbreak Pegatron C15B Arnd Bergmann (1): elfcore: fix building with clang Aurelien Aptel (1): cifs: report error instead of invalid when revalidating a dentry fails Benjamin Valentin (1): Input: xpad - sync supported devices with fork on GitHub Brian King (1): scsi: ibmvfc: Set default timeout to avoid crash during migration Chenxin Jin (1): USB: serial: cp210x: add new VID/PID for supporting Teraoka AD2000 Christoph Schemmel (1): USB: serial: option: Adding support for Cinterion MV31 Dan Carpenter (1): USB: gadget: legacy: fix an error code in eth_bind() Dave Hansen (1): x86/apic: Add extra serialization for non-serializing MSRs Eric Dumazet (1): net_sched: reject silly cell_log in qdisc_get_rtab() Felix Fietkau (1): mac80211: fix station rate table updates on assoc Fengnan Chang (1): mmc: core: Limit retries when analyse of SDIO tuples fails Greg Kroah-Hartman (1): Linux 4.4.257 Heiko Stuebner (1): usb: dwc2: Fix endpoint direction check in ep_from_windex Javed Hasan (1): scsi: libfc: Avoid invoking response handler twice if ep is already completed Jeremy Figgins (1): USB: usblp: don't call usb_set_interface if there's a single alt Josh Poimboeuf (1): x86/build: Disable CET instrumentation in the kernel Lee Jones (10): futex,rt_mutex: Provide futex specific rt_mutex API futex: Remove rt_mutex_deadlock_account_*() futex: Rework inconsistent rt_mutex/futex_q state futex: Avoid violating the 10th rule of futex futex: Replace pointless printk in fixup_owner() futex: Provide and use pi_state_update_owner() rtmutex: Remove unused argument from rt_mutex_proxy_unlock() futex: Use pi_state_update_owner() in put_pi_state() futex: Simplify fixup_pi_state_owner() futex: Handle faults correctly for PI futexes Muchun Song (3): mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page mm: hugetlb: fix a race between isolating and freeing page mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active Pho Tran (1): USB: serial: cp210x: add pid/vid for WSDA-200-USB Rafael J. Wysocki (1): ACPI: thermal: Do not call acpi_thermal_check() directly Ralf Baechle (1): ELF/MIPS build fix Russell King (1): ARM: footbridge: fix dc21285 PCI configuration accessors Sasha Levin (1): stable: clamp SUBLEVEL in 4.4 and 4.9 Shih-Yuan Lee (FourDollars) (1): ALSA: hda/realtek - Fix typo of pincfg for Dell quirk Thinh Nguyen (1): usb: udc: core: Use lock when write to soft_connect Wang ShaoBo (1): kretprobe: Avoid re-registration of the same kretprobe earlier Xie He (1): net: lapb: Copy the skb before sending a packet

3 years, 8 months

1
1
0 0

[PATCH 5.4 00/65] 5.4.97-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.4.97 release. There are 65 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 10 Feb 2021 14:57:55 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.97-rc1… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.4.97-rc1 Pali Rohár <pali(a)kernel.org> usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720 Alexander Ovechkin <ovov(a)yandex-team.ru> net: sched: replaced invalid qdisc tree flush helper in qdisc_replace DENG Qingfang <dqfext(a)gmail.com> net: dsa: mv88e6xxx: override existent unicast portvec in port_fdb_add Vadim Fedorenko <vfedorenko(a)novek.ru> net: ip_tunnel: fix mtu calculation Chinmay Agarwal <chinagar(a)codeaurora.org> neighbour: Prevent a dead entry from updating gc_list Kai-Heng Feng <kai.heng.feng(a)canonical.com> igc: Report speed and duplex as unknown when device is runtime suspended Xiao Ni <xni(a)redhat.com> md: Set prev_flush_start and flush_bio in an atomic way Nadav Amit <namit(a)vmware.com> iommu/vt-d: Do not use flush-queue when caching-mode is on Benjamin Valentin <benpicco(a)googlemail.com> Input: xpad - sync supported devices with fork on GitHub Luca Coelho <luciano.coelho(a)intel.com> iwlwifi: mvm: don't send RFH_QUEUE_CONFIG_CMD with no queues Dave Hansen <dave.hansen(a)linux.intel.com> x86/apic: Add extra serialization for non-serializing MSRs Josh Poimboeuf <jpoimboe(a)redhat.com> x86/build: Disable CET instrumentation in the kernel Hugh Dickins <hughd(a)google.com> mm: thp: fix MADV_REMOVE deadlock on shmem THP Rokudo Yan <wu-yan(a)tcl.com> mm, compaction: move high_pfn to the for loop scope Muchun Song <songmuchun(a)bytedance.com> mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active Muchun Song <songmuchun(a)bytedance.com> mm: hugetlb: fix a race between isolating and freeing page Muchun Song <songmuchun(a)bytedance.com> mm: hugetlb: fix a race between freeing and dissolving the page Muchun Song <songmuchun(a)bytedance.com> mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page Russell King <rmk+kernel(a)armlinux.org.uk> ARM: footbridge: fix dc21285 PCI configuration accessors Sean Christopherson <seanjc(a)google.com> KVM: x86: Update emulator context mode if SYSENTER xfers to 64-bit mode Sean Christopherson <seanjc(a)google.com> KVM: SVM: Treat SVM as unsupported when running as an SEV guest Thorsten Leemhuis <linux(a)leemhuis.info> nvme-pci: avoid the deepest sleep state on Kingston A2000 SSDs Stylon Wang <stylon.wang(a)amd.com> drm/amd/display: Revert "Fix EDID parsing after resume from suspend" Fengnan Chang <fengnanchang(a)gmail.com> mmc: core: Limit retries when analyse of SDIO tuples fails Pavel Shilovsky <pshilov(a)microsoft.com> smb3: fix crediting for compounding when only one request in flight Gustavo A. R. Silva <gustavoars(a)kernel.org> smb3: Fix out-of-bounds bug in SMB2_negotiate() Aurelien Aptel <aaptel(a)suse.com> cifs: report error instead of invalid when revalidating a dentry fails Mathias Nyman <mathias.nyman(a)linux.intel.com> xhci: fix bounce buffer usage for non-sg list case Marc Zyngier <maz(a)kernel.org> genirq/msi: Activate Multi-MSI early when MSI_FLAG_ACTIVATE_EARLY is set Dan Williams <dan.j.williams(a)intel.com> libnvdimm/dimm: Avoid race between probe and available_slots_show() Wang ShaoBo <bobo.shaobowang(a)huawei.com> kretprobe: Avoid re-registration of the same kretprobe earlier Steven Rostedt (VMware) <rostedt(a)goodmis.org> fgraph: Initialize tracing_graph_pause at task creation Felix Fietkau <nbd(a)nbd.name> mac80211: fix station rate table updates on assoc Liangyan <liangyan.peng(a)linux.alibaba.com> ovl: fix dentry leak in ovl_get_redirect Peter Chen <peter.chen(a)nxp.com> usb: host: xhci-plat: add priv quirk for skip PHY initialization Chunfeng Yun <chunfeng.yun(a)mediatek.com> usb: xhci-mtk: break loop when find the endpoint to drop Chunfeng Yun <chunfeng.yun(a)mediatek.com> usb: xhci-mtk: skip dropping bandwidth of unchecked endpoints Ikjoon Jang <ikjn(a)chromium.org> usb: xhci-mtk: fix unreleased bandwidth data Gary Bisson <gary.bisson(a)boundarydevices.com> usb: dwc3: fix clock issue during resume in OTG mode Heiko Stuebner <heiko.stuebner(a)theobroma-systems.com> usb: dwc2: Fix endpoint direction check in ep_from_windex Yoshihiro Shimoda <yoshihiro.shimoda.uh(a)renesas.com> usb: renesas_usbhs: Clear pipe running flag in usbhs_pkt_pop() Jeremy Figgins <kernel(a)jeremyfiggins.com> USB: usblp: don't call usb_set_interface if there's a single alt Dan Carpenter <dan.carpenter(a)oracle.com> USB: gadget: legacy: fix an error code in eth_bind() Roman Gushchin <guro(a)fb.com> memblock: do not start bottom-up allocations with kernel_end Sagi Grimberg <sagi(a)grimberg.me> nvmet-tcp: fix out-of-bounds access when receiving multiple h2cdata PDUs Hermann Lauer <Hermann.Lauer(a)uni-heidelberg.de> ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode Heiner Kallweit <hkallweit1(a)gmail.com> r8169: fix WoL on shutdown if CONFIG_DEBUG_SHIRQ is set Stefan Chulski <stefanc(a)marvell.com> net: mvpp2: TCAM entry enable should be written after SRAM data Xie He <xie.he.0141(a)gmail.com> net: lapb: Copy the skb before sending a packet Maor Gottlieb <maorg(a)nvidia.com> net/mlx5: Fix leak upon failure of rule creation Aleksandr Loktionov <aleksandr.loktionov(a)intel.com> i40e: Revert "i40e: don't report link up for a VF who hasn't enabled queues" Kevin Lo <kevlo(a)kevlo.org> igc: check return value of ret_val in igc_config_fc_after_link_up Kevin Lo <kevlo(a)kevlo.org> igc: set the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr Zyta Szpak <zr(a)semihalf.com> arm64: dts: ls1046a: fix dcfg address range David Howells <dhowells(a)redhat.com> rxrpc: Fix deadlock around release of dst cached on udp tunnel Johannes Berg <johannes.berg(a)intel.com> um: virtio: free vu_dev only with the contained struct device Loris Reiff <loris.reiff(a)liblor.ch> bpf, cgroup: Fix problematic bounds check Loris Reiff <loris.reiff(a)liblor.ch> bpf, cgroup: Fix optlen WARN_ON_ONCE toctou Sandy Huang <hjc(a)rock-chips.com> arm64: dts: rockchip: fix vopl iommu irq on px30 Serge Semin <Sergey.Semin(a)baikalelectronics.ru> arm64: dts: amlogic: meson-g12: Set FL-adj property value Alexey Dobriyan <adobriyan(a)gmail.com> Input: i8042 - unbreak Pegatron C15B Shawn Guo <shawn.guo(a)linaro.org> arm64: dts: qcom: c630: keep both touchpad devices enabled Christoph Schemmel <christoph.schemmel(a)gmail.com> USB: serial: option: Adding support for Cinterion MV31 Chenxin Jin <bg4akv(a)hotmail.com> USB: serial: cp210x: add new VID/PID for supporting Teraoka AD2000 Pho Tran <Pho.Tran(a)silabs.com> USB: serial: cp210x: add pid/vid for WSDA-200-USB ------------- Diffstat: Makefile | 10 +- arch/arm/boot/dts/sun7i-a20-bananapro.dts | 2 +- arch/arm/mach-footbridge/dc21285.c | 12 +- arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +- arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +- .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 10 +- arch/arm64/boot/dts/rockchip/px30.dtsi | 2 +- arch/um/drivers/virtio_uml.c | 3 +- arch/x86/Makefile | 3 + arch/x86/include/asm/apic.h | 10 -- arch/x86/include/asm/barrier.h | 18 +++ arch/x86/kernel/apic/apic.c | 4 + arch/x86/kernel/apic/x2apic_cluster.c | 6 +- arch/x86/kernel/apic/x2apic_phys.c | 9 +- arch/x86/kvm/emulate.c | 2 + arch/x86/kvm/svm.c | 5 + arch/x86/mm/mem_encrypt.c | 1 + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 - drivers/input/joystick/xpad.c | 17 ++- drivers/input/serio/i8042-x86ia64io.h | 2 + drivers/iommu/intel-iommu.c | 6 + drivers/md/md.c | 2 + drivers/mmc/core/sdio_cis.c | 6 + drivers/net/dsa/mv88e6xxx/chip.c | 6 +- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 13 +-- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h | 1 - drivers/net/ethernet/intel/igc/igc_ethtool.c | 3 +- drivers/net/ethernet/intel/igc/igc_i225.c | 3 +- drivers/net/ethernet/intel/igc/igc_mac.c | 2 +- drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c | 10 +- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 5 + drivers/net/ethernet/realtek/r8169_main.c | 4 +- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 9 +- drivers/nvdimm/dimm_devs.c | 18 ++- drivers/nvme/host/pci.c | 2 + drivers/nvme/target/tcp.c | 3 +- drivers/usb/class/usblp.c | 19 +-- drivers/usb/dwc2/gadget.c | 8 +- drivers/usb/dwc3/core.c | 2 +- drivers/usb/gadget/legacy/ether.c | 4 +- drivers/usb/host/xhci-mtk-sch.c | 130 +++++++++++++++------ drivers/usb/host/xhci-mtk.c | 2 + drivers/usb/host/xhci-mtk.h | 15 +++ drivers/usb/host/xhci-mvebu.c | 42 +++++++ drivers/usb/host/xhci-mvebu.h | 6 + drivers/usb/host/xhci-plat.c | 26 ++++- drivers/usb/host/xhci-plat.h | 1 + drivers/usb/host/xhci-ring.c | 31 +++-- drivers/usb/host/xhci.c | 8 +- drivers/usb/host/xhci.h | 5 + drivers/usb/renesas_usbhs/fifo.c | 1 + drivers/usb/serial/cp210x.c | 2 + drivers/usb/serial/option.c | 6 + fs/afs/main.c | 6 +- fs/cifs/dir.c | 22 +++- fs/cifs/smb2pdu.h | 2 +- fs/cifs/transport.c | 18 ++- fs/hugetlbfs/inode.c | 3 +- fs/overlayfs/dir.c | 2 +- include/linux/hugetlb.h | 2 + include/linux/msi.h | 6 + include/net/sch_generic.h | 2 +- init/init_task.c | 3 +- kernel/bpf/cgroup.c | 7 +- kernel/irq/msi.c | 44 ++++--- kernel/kprobes.c | 4 + kernel/trace/fgraph.c | 2 - mm/compaction.c | 3 +- mm/huge_memory.c | 37 +++--- mm/hugetlb.c | 48 +++++++- mm/memblock.c | 49 +------- net/core/neighbour.c | 7 +- net/ipv4/ip_tunnel.c | 16 ++- net/lapb/lapb_out.c | 3 +- net/mac80211/driver-ops.c | 5 +- net/mac80211/rate.c | 3 +- net/rxrpc/af_rxrpc.c | 6 +- 77 files changed, 558 insertions(+), 265 deletions(-)

3 years, 8 months

6
71
0 0

[PATCH 05/20] bcache: Move journal work to new flush wq

by Coly Li

From: Kai Krakow <kai(a)kaishome.de> This is potentially long running and not latency sensitive, let's get it out of the way of other latency sensitive events. As observed in the previous commit, the `system_wq` comes easily congested by bcache, and this fixes a few more stalls I was observing every once in a while. Let's not make this `WQ_MEM_RECLAIM` as it showed to reduce performance of boot and file system operations in my tests. Also, without `WQ_MEM_RECLAIM`, I no longer see desktop stalls. This matches the previous behavior as `system_wq` also does no memory reclaim: > // workqueue.c: > system_wq = alloc_workqueue("events", 0, 0); Cc: Coly Li <colyli(a)suse.de> Cc: stable(a)vger.kernel.org # 5.4+ Signed-off-by: Kai Krakow <kai(a)kaishome.de> Signed-off-by: Coly Li <colyli(a)suse.de> --- drivers/md/bcache/bcache.h | 1 + drivers/md/bcache/journal.c | 4 ++-- drivers/md/bcache/super.c | 16 ++++++++++++++++ 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/md/bcache/bcache.h b/drivers/md/bcache/bcache.h index 2b8c7dd2cfae..848dd4db1659 100644 --- a/drivers/md/bcache/bcache.h +++ b/drivers/md/bcache/bcache.h @@ -1005,6 +1005,7 @@ void bch_write_bdev_super(struct cached_dev *dc, struct closure *parent); extern struct workqueue_struct *bcache_wq; extern struct workqueue_struct *bch_journal_wq; +extern struct workqueue_struct *bch_flush_wq; extern struct mutex bch_register_lock; extern struct list_head bch_cache_sets; diff --git a/drivers/md/bcache/journal.c b/drivers/md/bcache/journal.c index aefbdb7e003b..c6613e817333 100644 --- a/drivers/md/bcache/journal.c +++ b/drivers/md/bcache/journal.c @@ -932,8 +932,8 @@ atomic_t *bch_journal(struct cache_set *c, journal_try_write(c); } else if (!w->dirty) { w->dirty = true; - schedule_delayed_work(&c->journal.work, - msecs_to_jiffies(c->journal_delay_ms)); + queue_delayed_work(bch_flush_wq, &c->journal.work, + msecs_to_jiffies(c->journal_delay_ms)); spin_unlock(&c->journal.lock); } else { spin_unlock(&c->journal.lock); diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 85a44a0cffe0..0228ccb293fc 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -49,6 +49,7 @@ static int bcache_major; static DEFINE_IDA(bcache_device_idx); static wait_queue_head_t unregister_wait; struct workqueue_struct *bcache_wq; +struct workqueue_struct *bch_flush_wq; struct workqueue_struct *bch_journal_wq; @@ -2821,6 +2822,8 @@ static void bcache_exit(void) destroy_workqueue(bcache_wq); if (bch_journal_wq) destroy_workqueue(bch_journal_wq); + if (bch_flush_wq) + destroy_workqueue(bch_flush_wq); bch_btree_exit(); if (bcache_major) @@ -2884,6 +2887,19 @@ static int __init bcache_init(void) if (!bcache_wq) goto err; + /* + * Let's not make this `WQ_MEM_RECLAIM` for the following reasons: + * + * 1. It used `system_wq` before which also does no memory reclaim. + * 2. With `WQ_MEM_RECLAIM` desktop stalls, increased boot times, and + * reduced throughput can be observed. + * + * We still want to user our own queue to not congest the `system_wq`. + */ + bch_flush_wq = alloc_workqueue("bch_flush", 0, 0); + if (!bch_flush_wq) + goto err; + bch_journal_wq = alloc_workqueue("bch_journal", WQ_MEM_RECLAIM, 0); if (!bch_journal_wq) goto err; -- 2.26.2

3 years, 8 months

1
0
0 0

[PATCH 04/20] bcache: Give btree_io_wq correct semantics again

by Coly Li

From: Kai Krakow <kai(a)kaishome.de> Before killing `btree_io_wq`, the queue was allocated using `create_singlethread_workqueue()` which has `WQ_MEM_RECLAIM`. After killing it, it no longer had this property but `system_wq` is not single threaded. Let's combine both worlds and make it multi threaded but able to reclaim memory. Cc: Coly Li <colyli(a)suse.de> Cc: stable(a)vger.kernel.org # 5.4+ Signed-off-by: Kai Krakow <kai(a)kaishome.de> Signed-off-by: Coly Li <colyli(a)suse.de> --- drivers/md/bcache/btree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c index 952f022db5a5..fe6dce125aba 100644 --- a/drivers/md/bcache/btree.c +++ b/drivers/md/bcache/btree.c @@ -2775,7 +2775,7 @@ void bch_btree_exit(void) int __init bch_btree_init(void) { - btree_io_wq = create_singlethread_workqueue("bch_btree_io"); + btree_io_wq = alloc_workqueue("bch_btree_io", WQ_MEM_RECLAIM, 0); if (!btree_io_wq) return -ENOMEM; -- 2.26.2

3 years, 8 months

1
0
0 0

[PATCH 03/20] Revert "bcache: Kill btree_io_wq"

by Coly Li

From: Kai Krakow <kai(a)kaishome.de> This reverts commit 56b30770b27d54d68ad51eccc6d888282b568cee. With the btree using the `system_wq`, I seem to see a lot more desktop latency than I should. After some more investigation, it looks like the original assumption of 56b3077 no longer is true, and bcache has a very high potential of congesting the `system_wq`. In turn, this introduces laggy desktop performance, IO stalls (at least with btrfs), and input events may be delayed. So let's revert this. It's important to note that the semantics of using `system_wq` previously mean that `btree_io_wq` should be created before and destroyed after other bcache wqs to keep the same assumptions. Cc: Coly Li <colyli(a)suse.de> Cc: stable(a)vger.kernel.org # 5.4+ Signed-off-by: Kai Krakow <kai(a)kaishome.de> Signed-off-by: Coly Li <colyli(a)suse.de> --- drivers/md/bcache/bcache.h | 2 ++ drivers/md/bcache/btree.c | 21 +++++++++++++++++++-- drivers/md/bcache/super.c | 4 ++++ 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/md/bcache/bcache.h b/drivers/md/bcache/bcache.h index d7a84327b7f1..2b8c7dd2cfae 100644 --- a/drivers/md/bcache/bcache.h +++ b/drivers/md/bcache/bcache.h @@ -1046,5 +1046,7 @@ void bch_debug_exit(void); void bch_debug_init(void); void bch_request_exit(void); int bch_request_init(void); +void bch_btree_exit(void); +int bch_btree_init(void); #endif /* _BCACHE_H */ diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c index 910df242c83d..952f022db5a5 100644 --- a/drivers/md/bcache/btree.c +++ b/drivers/md/bcache/btree.c @@ -99,6 +99,8 @@ #define PTR_HASH(c, k) \ (((k)->ptr[0] >> c->bucket_bits) | PTR_GEN(k, 0)) +static struct workqueue_struct *btree_io_wq; + #define insert_lock(s, b) ((b)->level <= (s)->lock) @@ -308,7 +310,7 @@ static void __btree_node_write_done(struct closure *cl) btree_complete_write(b, w); if (btree_node_dirty(b)) - schedule_delayed_work(&b->work, 30 * HZ); + queue_delayed_work(btree_io_wq, &b->work, 30 * HZ); closure_return_with_destructor(cl, btree_node_write_unlock); } @@ -481,7 +483,7 @@ static void bch_btree_leaf_dirty(struct btree *b, atomic_t *journal_ref) BUG_ON(!i->keys); if (!btree_node_dirty(b)) - schedule_delayed_work(&b->work, 30 * HZ); + queue_delayed_work(btree_io_wq, &b->work, 30 * HZ); set_btree_node_dirty(b); @@ -2764,3 +2766,18 @@ void bch_keybuf_init(struct keybuf *buf) spin_lock_init(&buf->lock); array_allocator_init(&buf->freelist); } + +void bch_btree_exit(void) +{ + if (btree_io_wq) + destroy_workqueue(btree_io_wq); +} + +int __init bch_btree_init(void) +{ + btree_io_wq = create_singlethread_workqueue("bch_btree_io"); + if (!btree_io_wq) + return -ENOMEM; + + return 0; +} diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index e7d1b52c5cc8..85a44a0cffe0 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -2821,6 +2821,7 @@ static void bcache_exit(void) destroy_workqueue(bcache_wq); if (bch_journal_wq) destroy_workqueue(bch_journal_wq); + bch_btree_exit(); if (bcache_major) unregister_blkdev(bcache_major, "bcache"); @@ -2876,6 +2877,9 @@ static int __init bcache_init(void) return bcache_major; } + if (bch_btree_init()) + goto err; + bcache_wq = alloc_workqueue("bcache", WQ_MEM_RECLAIM, 0); if (!bcache_wq) goto err; -- 2.26.2

3 years, 8 months

1
0
0 0

[PATCH 4.4 00/38] 4.4.257-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.4.257 release. There are 38 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 10 Feb 2021 14:57:55 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.257-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.4.257-rc1 Shih-Yuan Lee (FourDollars) <sylee(a)canonical.com> ALSA: hda/realtek - Fix typo of pincfg for Dell quirk Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> ACPI: thermal: Do not call acpi_thermal_check() directly Benjamin Valentin <benpicco(a)googlemail.com> Input: xpad - sync supported devices with fork on GitHub Dave Hansen <dave.hansen(a)linux.intel.com> x86/apic: Add extra serialization for non-serializing MSRs Josh Poimboeuf <jpoimboe(a)redhat.com> x86/build: Disable CET instrumentation in the kernel Muchun Song <songmuchun(a)bytedance.com> mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active Muchun Song <songmuchun(a)bytedance.com> mm: hugetlb: fix a race between isolating and freeing page Muchun Song <songmuchun(a)bytedance.com> mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page Russell King <rmk+kernel(a)armlinux.org.uk> ARM: footbridge: fix dc21285 PCI configuration accessors Fengnan Chang <fengnanchang(a)gmail.com> mmc: core: Limit retries when analyse of SDIO tuples fails Aurelien Aptel <aaptel(a)suse.com> cifs: report error instead of invalid when revalidating a dentry fails Wang ShaoBo <bobo.shaobowang(a)huawei.com> kretprobe: Avoid re-registration of the same kretprobe earlier Felix Fietkau <nbd(a)nbd.name> mac80211: fix station rate table updates on assoc Heiko Stuebner <heiko.stuebner(a)theobroma-systems.com> usb: dwc2: Fix endpoint direction check in ep_from_windex Jeremy Figgins <kernel(a)jeremyfiggins.com> USB: usblp: don't call usb_set_interface if there's a single alt Dan Carpenter <dan.carpenter(a)oracle.com> USB: gadget: legacy: fix an error code in eth_bind() Arnd Bergmann <arnd(a)arndb.de> elfcore: fix building with clang Ralf Baechle <ralf(a)linux-mips.org> ELF/MIPS build fix Xie He <xie.he.0141(a)gmail.com> net: lapb: Copy the skb before sending a packet Alexey Dobriyan <adobriyan(a)gmail.com> Input: i8042 - unbreak Pegatron C15B Christoph Schemmel <christoph.schemmel(a)gmail.com> USB: serial: option: Adding support for Cinterion MV31 Chenxin Jin <bg4akv(a)hotmail.com> USB: serial: cp210x: add new VID/PID for supporting Teraoka AD2000 Pho Tran <Pho.Tran(a)silabs.com> USB: serial: cp210x: add pid/vid for WSDA-200-USB Sasha Levin <sashal(a)kernel.org> stable: clamp SUBLEVEL in 4.4 and 4.9 Brian King <brking(a)linux.vnet.ibm.com> scsi: ibmvfc: Set default timeout to avoid crash during migration Javed Hasan <jhasan(a)marvell.com> scsi: libfc: Avoid invoking response handler twice if ep is already completed Thinh Nguyen <Thinh.Nguyen(a)synopsys.com> usb: udc: core: Use lock when write to soft_connect Lee Jones <lee.jones(a)linaro.org> futex: Handle faults correctly for PI futexes Lee Jones <lee.jones(a)linaro.org> futex: Simplify fixup_pi_state_owner() Lee Jones <lee.jones(a)linaro.org> futex: Use pi_state_update_owner() in put_pi_state() Lee Jones <lee.jones(a)linaro.org> rtmutex: Remove unused argument from rt_mutex_proxy_unlock() Lee Jones <lee.jones(a)linaro.org> futex: Provide and use pi_state_update_owner() Lee Jones <lee.jones(a)linaro.org> futex: Replace pointless printk in fixup_owner() Lee Jones <lee.jones(a)linaro.org> futex: Avoid violating the 10th rule of futex Lee Jones <lee.jones(a)linaro.org> futex: Rework inconsistent rt_mutex/futex_q state Lee Jones <lee.jones(a)linaro.org> futex: Remove rt_mutex_deadlock_account_*() Lee Jones <lee.jones(a)linaro.org> futex,rt_mutex: Provide futex specific rt_mutex API Eric Dumazet <edumazet(a)google.com> net_sched: reject silly cell_log in qdisc_get_rtab() ------------- Diffstat: Makefile | 12 +- arch/arm/mach-footbridge/dc21285.c | 12 +- arch/mips/Kconfig | 1 + arch/x86/Makefile | 3 + arch/x86/include/asm/apic.h | 10 -- arch/x86/include/asm/barrier.h | 18 +++ arch/x86/kernel/apic/apic.c | 4 + arch/x86/kernel/apic/x2apic_cluster.c | 3 +- arch/x86/kernel/apic/x2apic_phys.c | 3 +- drivers/acpi/thermal.c | 54 +++++-- drivers/input/joystick/xpad.c | 17 ++- drivers/input/serio/i8042-x86ia64io.h | 2 + drivers/mmc/core/sdio_cis.c | 6 + drivers/scsi/ibmvscsi/ibmvfc.c | 4 +- drivers/scsi/libfc/fc_exch.c | 16 +- drivers/usb/class/usblp.c | 19 ++- drivers/usb/dwc2/gadget.c | 8 +- drivers/usb/gadget/legacy/ether.c | 4 +- drivers/usb/gadget/udc/udc-core.c | 13 +- drivers/usb/serial/cp210x.c | 2 + drivers/usb/serial/option.c | 6 + fs/Kconfig.binfmt | 8 + fs/cifs/dir.c | 22 ++- fs/hugetlbfs/inode.c | 3 +- include/linux/elfcore.h | 22 +++ include/linux/hugetlb.h | 3 + kernel/Makefile | 3 - kernel/elfcore.c | 25 --- kernel/futex.c | 278 +++++++++++++++++++--------------- kernel/kprobes.c | 4 + kernel/locking/rtmutex-debug.c | 9 -- kernel/locking/rtmutex-debug.h | 3 - kernel/locking/rtmutex.c | 127 ++++++++++------ kernel/locking/rtmutex.h | 2 - kernel/locking/rtmutex_common.h | 12 +- mm/hugetlb.c | 9 +- net/lapb/lapb_out.c | 3 +- net/mac80211/driver-ops.c | 5 +- net/mac80211/rate.c | 3 +- net/sched/sch_api.c | 3 +- sound/pci/hda/patch_realtek.c | 2 +- 41 files changed, 469 insertions(+), 294 deletions(-)

3 years, 8 months

5
45
0 0

[PATCH 4.19 00/38] 4.19.175-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.175 release. There are 38 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 10 Feb 2021 14:57:55 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.175-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.175-rc1 DENG Qingfang <dqfext(a)gmail.com> net: dsa: mv88e6xxx: override existent unicast portvec in port_fdb_add Vadim Fedorenko <vfedorenko(a)novek.ru> net: ip_tunnel: fix mtu calculation Xiao Ni <xni(a)redhat.com> md: Set prev_flush_start and flush_bio in an atomic way Nadav Amit <namit(a)vmware.com> iommu/vt-d: Do not use flush-queue when caching-mode is on Benjamin Valentin <benpicco(a)googlemail.com> Input: xpad - sync supported devices with fork on GitHub Dave Hansen <dave.hansen(a)linux.intel.com> x86/apic: Add extra serialization for non-serializing MSRs Josh Poimboeuf <jpoimboe(a)redhat.com> x86/build: Disable CET instrumentation in the kernel Hugh Dickins <hughd(a)google.com> mm: thp: fix MADV_REMOVE deadlock on shmem THP Muchun Song <songmuchun(a)bytedance.com> mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active Muchun Song <songmuchun(a)bytedance.com> mm: hugetlb: fix a race between isolating and freeing page Muchun Song <songmuchun(a)bytedance.com> mm: hugetlb: fix a race between freeing and dissolving the page Muchun Song <songmuchun(a)bytedance.com> mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page Russell King <rmk+kernel(a)armlinux.org.uk> ARM: footbridge: fix dc21285 PCI configuration accessors Sean Christopherson <seanjc(a)google.com> KVM: SVM: Treat SVM as unsupported when running as an SEV guest Thorsten Leemhuis <linux(a)leemhuis.info> nvme-pci: avoid the deepest sleep state on Kingston A2000 SSDs Fengnan Chang <fengnanchang(a)gmail.com> mmc: core: Limit retries when analyse of SDIO tuples fails Gustavo A. R. Silva <gustavoars(a)kernel.org> smb3: Fix out-of-bounds bug in SMB2_negotiate() Aurelien Aptel <aaptel(a)suse.com> cifs: report error instead of invalid when revalidating a dentry fails Mathias Nyman <mathias.nyman(a)linux.intel.com> xhci: fix bounce buffer usage for non-sg list case Marc Zyngier <maz(a)kernel.org> genirq/msi: Activate Multi-MSI early when MSI_FLAG_ACTIVATE_EARLY is set Wang ShaoBo <bobo.shaobowang(a)huawei.com> kretprobe: Avoid re-registration of the same kretprobe earlier Felix Fietkau <nbd(a)nbd.name> mac80211: fix station rate table updates on assoc Liangyan <liangyan.peng(a)linux.alibaba.com> ovl: fix dentry leak in ovl_get_redirect Gary Bisson <gary.bisson(a)boundarydevices.com> usb: dwc3: fix clock issue during resume in OTG mode Heiko Stuebner <heiko.stuebner(a)theobroma-systems.com> usb: dwc2: Fix endpoint direction check in ep_from_windex Yoshihiro Shimoda <yoshihiro.shimoda.uh(a)renesas.com> usb: renesas_usbhs: Clear pipe running flag in usbhs_pkt_pop() Jeremy Figgins <kernel(a)jeremyfiggins.com> USB: usblp: don't call usb_set_interface if there's a single alt Dan Carpenter <dan.carpenter(a)oracle.com> USB: gadget: legacy: fix an error code in eth_bind() Roman Gushchin <guro(a)fb.com> memblock: do not start bottom-up allocations with kernel_end Stefan Chulski <stefanc(a)marvell.com> net: mvpp2: TCAM entry enable should be written after SRAM data Xie He <xie.he.0141(a)gmail.com> net: lapb: Copy the skb before sending a packet Zyta Szpak <zr(a)semihalf.com> arm64: dts: ls1046a: fix dcfg address range David Howells <dhowells(a)redhat.com> rxrpc: Fix deadlock around release of dst cached on udp tunnel Alexey Dobriyan <adobriyan(a)gmail.com> Input: i8042 - unbreak Pegatron C15B Arnd Bergmann <arnd(a)arndb.de> elfcore: fix building with clang Christoph Schemmel <christoph.schemmel(a)gmail.com> USB: serial: option: Adding support for Cinterion MV31 Chenxin Jin <bg4akv(a)hotmail.com> USB: serial: cp210x: add new VID/PID for supporting Teraoka AD2000 Pho Tran <Pho.Tran(a)silabs.com> USB: serial: cp210x: add pid/vid for WSDA-200-USB ------------- Diffstat: Makefile | 10 ++---- arch/arm/mach-footbridge/dc21285.c | 12 +++---- arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +- arch/x86/Makefile | 3 ++ arch/x86/include/asm/apic.h | 10 ------ arch/x86/include/asm/barrier.h | 18 ++++++++++ arch/x86/kernel/apic/apic.c | 4 +++ arch/x86/kernel/apic/x2apic_cluster.c | 6 ++-- arch/x86/kernel/apic/x2apic_phys.c | 6 ++-- arch/x86/kvm/svm.c | 5 +++ drivers/input/joystick/xpad.c | 17 ++++++++- drivers/input/serio/i8042-x86ia64io.h | 2 ++ drivers/iommu/intel-iommu.c | 6 ++++ drivers/md/md.c | 2 ++ drivers/mmc/core/sdio_cis.c | 6 ++++ drivers/net/dsa/mv88e6xxx/chip.c | 6 +++- drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c | 10 +++--- drivers/nvme/host/pci.c | 2 ++ drivers/usb/class/usblp.c | 19 +++++----- drivers/usb/dwc2/gadget.c | 8 +---- drivers/usb/dwc3/core.c | 2 +- drivers/usb/gadget/legacy/ether.c | 4 ++- drivers/usb/host/xhci-ring.c | 31 ++++++++++------ drivers/usb/renesas_usbhs/fifo.c | 1 + drivers/usb/serial/cp210x.c | 2 ++ drivers/usb/serial/option.c | 6 ++++ fs/afs/main.c | 6 ++-- fs/cifs/dir.c | 22 ++++++++++-- fs/cifs/smb2pdu.h | 2 +- fs/hugetlbfs/inode.c | 3 +- fs/overlayfs/dir.c | 2 +- include/linux/elfcore.h | 22 ++++++++++++ include/linux/hugetlb.h | 3 ++ include/linux/msi.h | 6 ++++ kernel/Makefile | 1 - kernel/elfcore.c | 26 -------------- kernel/irq/msi.c | 44 +++++++++++------------ kernel/kprobes.c | 4 +++ mm/huge_memory.c | 37 +++++++++++-------- mm/hugetlb.c | 48 ++++++++++++++++++++++--- mm/memblock.c | 49 ++++---------------------- net/ipv4/ip_tunnel.c | 16 ++++----- net/lapb/lapb_out.c | 3 +- net/mac80211/driver-ops.c | 5 ++- net/mac80211/rate.c | 3 +- net/rxrpc/af_rxrpc.c | 6 ++-- 46 files changed, 308 insertions(+), 200 deletions(-)

3 years, 8 months

6
43
0 0

FAILED: patch "[PATCH] tracing/kprobe: Fix to support kretprobe events on unloaded" failed to apply to 5.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 97c753e62e6c31a404183898d950d8c08d752dbd Mon Sep 17 00:00:00 2001 From: Masami Hiramatsu <mhiramat(a)kernel.org> Date: Thu, 28 Jan 2021 00:37:51 +0900 Subject: [PATCH] tracing/kprobe: Fix to support kretprobe events on unloaded modules Fix kprobe_on_func_entry() returns error code instead of false so that register_kretprobe() can return an appropriate error code. append_trace_kprobe() expects the kprobe registration returns -ENOENT when the target symbol is not found, and it checks whether the target module is unloaded or not. If the target module doesn't exist, it defers to probe the target symbol until the module is loaded. However, since register_kretprobe() returns -EINVAL instead of -ENOENT in that case, it always fail on putting the kretprobe event on unloaded modules. e.g. Kprobe event: /sys/kernel/debug/tracing # echo p xfs:xfs_end_io >> kprobe_events [ 16.515574] trace_kprobe: This probe might be able to register after target module is loaded. Continue. Kretprobe event: (p -> r) /sys/kernel/debug/tracing # echo r xfs:xfs_end_io >> kprobe_events sh: write error: Invalid argument /sys/kernel/debug/tracing # cat error_log [ 41.122514] trace_kprobe: error: Failed to register probe event Command: r xfs:xfs_end_io ^ To fix this bug, change kprobe_on_func_entry() to detect symbol lookup failure and return -ENOENT in that case. Otherwise it returns -EINVAL or 0 (succeeded, given address is on the entry). Link: https://lkml.kernel.org/r/161176187132.1067016.8118042342894378981.stgit@de… Cc: stable(a)vger.kernel.org Fixes: 59158ec4aef7 ("tracing/kprobes: Check the probe on unloaded module correctly") Reported-by: Jianlin Lv <Jianlin.Lv(a)arm.com> Signed-off-by: Masami Hiramatsu <mhiramat(a)kernel.org> Signed-off-by: Steven Rostedt (VMware) <rostedt(a)goodmis.org> diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h index b3a36b0cfc81..1883a4a9f16a 100644 --- a/include/linux/kprobes.h +++ b/include/linux/kprobes.h @@ -266,7 +266,7 @@ extern void kprobes_inc_nmissed_count(struct kprobe *p); extern bool arch_within_kprobe_blacklist(unsigned long addr); extern int arch_populate_kprobe_blacklist(void); extern bool arch_kprobe_on_func_entry(unsigned long offset); -extern bool kprobe_on_func_entry(kprobe_opcode_t *addr, const char *sym, unsigned long offset); +extern int kprobe_on_func_entry(kprobe_opcode_t *addr, const char *sym, unsigned long offset); extern bool within_kprobe_blacklist(unsigned long addr); extern int kprobe_add_ksym_blacklist(unsigned long entry); diff --git a/kernel/kprobes.c b/kernel/kprobes.c index f7fb5d135930..1a5bc321e0a5 100644 --- a/kernel/kprobes.c +++ b/kernel/kprobes.c @@ -1954,29 +1954,45 @@ bool __weak arch_kprobe_on_func_entry(unsigned long offset) return !offset; } -bool kprobe_on_func_entry(kprobe_opcode_t *addr, const char *sym, unsigned long offset) +/** + * kprobe_on_func_entry() -- check whether given address is function entry + * @addr: Target address + * @sym: Target symbol name + * @offset: The offset from the symbol or the address + * + * This checks whether the given @addr+@offset or @sym+@offset is on the + * function entry address or not. + * This returns 0 if it is the function entry, or -EINVAL if it is not. + * And also it returns -ENOENT if it fails the symbol or address lookup. + * Caller must pass @addr or @sym (either one must be NULL), or this + * returns -EINVAL. + */ +int kprobe_on_func_entry(kprobe_opcode_t *addr, const char *sym, unsigned long offset) { kprobe_opcode_t *kp_addr = _kprobe_addr(addr, sym, offset); if (IS_ERR(kp_addr)) - return false; + return PTR_ERR(kp_addr); - if (!kallsyms_lookup_size_offset((unsigned long)kp_addr, NULL, &offset) || - !arch_kprobe_on_func_entry(offset)) - return false; + if (!kallsyms_lookup_size_offset((unsigned long)kp_addr, NULL, &offset)) + return -ENOENT; - return true; + if (!arch_kprobe_on_func_entry(offset)) + return -EINVAL; + + return 0; } int register_kretprobe(struct kretprobe *rp) { - int ret = 0; + int ret; struct kretprobe_instance *inst; int i; void *addr; - if (!kprobe_on_func_entry(rp->kp.addr, rp->kp.symbol_name, rp->kp.offset)) - return -EINVAL; + ret = kprobe_on_func_entry(rp->kp.addr, rp->kp.symbol_name, rp->kp.offset); + if (ret) + return ret; if (kretprobe_blacklist_size) { addr = kprobe_addr(&rp->kp); diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index e6fba1798771..56c7fbff7bd7 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -221,9 +221,9 @@ bool trace_kprobe_on_func_entry(struct trace_event_call *call) { struct trace_kprobe *tk = trace_kprobe_primary_from_call(call); - return tk ? kprobe_on_func_entry(tk->rp.kp.addr, + return tk ? (kprobe_on_func_entry(tk->rp.kp.addr, tk->rp.kp.addr ? NULL : tk->rp.kp.symbol_name, - tk->rp.kp.addr ? 0 : tk->rp.kp.offset) : false; + tk->rp.kp.addr ? 0 : tk->rp.kp.offset) == 0) : false; } bool trace_kprobe_error_injectable(struct trace_event_call *call) @@ -828,9 +828,11 @@ static int trace_kprobe_create(int argc, const char *argv[]) } if (is_return) flags |= TPARG_FL_RETURN; - if (kprobe_on_func_entry(NULL, symbol, offset)) + ret = kprobe_on_func_entry(NULL, symbol, offset); + if (ret == 0) flags |= TPARG_FL_FENTRY; - if (offset && is_return && !(flags & TPARG_FL_FENTRY)) { + /* Defer the ENOENT case until register kprobe */ + if (ret == -EINVAL && is_return) { trace_probe_log_err(0, BAD_RETPROBE); goto parse_error; }

3 years, 8 months

3
2
0 0

FAILED: patch "[PATCH] remoteproc: qcom_q6v5_mss: Validate modem blob firmware size" failed to apply to 4.19-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 135b9e8d1cd8ba5ac9ad9bcf24b464b7b052e5b8 Mon Sep 17 00:00:00 2001 From: Sibi Sankar <sibis(a)codeaurora.org> Date: Thu, 23 Jul 2020 01:40:46 +0530 Subject: [PATCH] remoteproc: qcom_q6v5_mss: Validate modem blob firmware size before load The following mem abort is observed when one of the modem blob firmware size exceeds the allocated mpss region. Fix this by restricting the copy size to segment size using request_firmware_into_buf before load. Err Logs: Unable to handle kernel paging request at virtual address Mem abort info: ... Call trace: __memcpy+0x110/0x180 rproc_start+0xd0/0x190 rproc_boot+0x404/0x550 state_store+0x54/0xf8 dev_attr_store+0x44/0x60 sysfs_kf_write+0x58/0x80 kernfs_fop_write+0x140/0x230 vfs_write+0xc4/0x208 ksys_write+0x74/0xf8 ... Reviewed-by: Bjorn Andersson <bjorn.andersson(a)linaro.org> Fixes: 051fb70fd4ea4 ("remoteproc: qcom: Driver for the self-authenticating Hexagon v5") Cc: stable(a)vger.kernel.org Signed-off-by: Sibi Sankar <sibis(a)codeaurora.org> Link: https://lore.kernel.org/r/20200722201047.12975-3-sibis@codeaurora.org Signed-off-by: Bjorn Andersson <bjorn.andersson(a)linaro.org> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c index 7826f229957d..8199d9f59209 100644 --- a/drivers/remoteproc/qcom_q6v5_mss.c +++ b/drivers/remoteproc/qcom_q6v5_mss.c @@ -1173,15 +1173,14 @@ static int q6v5_mpss_load(struct q6v5 *qproc) } else if (phdr->p_filesz) { /* Replace "xxx.xxx" with "xxx.bxx" */ sprintf(fw_name + fw_name_len - 3, "b%02d", i); - ret = request_firmware(&seg_fw, fw_name, qproc->dev); + ret = request_firmware_into_buf(&seg_fw, fw_name, qproc->dev, + ptr, phdr->p_filesz); if (ret) { dev_err(qproc->dev, "failed to load %s\n", fw_name); iounmap(ptr); goto release_firmware; } - memcpy(ptr, seg_fw->data, seg_fw->size); - release_firmware(seg_fw); }

3 years, 8 months

2
1
0 0

[patch 14/14] nilfs2: make splice write available again

by Andrew Morton

From: Joachim Henke <joachim.henke(a)t-systems.com> Subject: nilfs2: make splice write available again Since 5.10, splice() or sendfile() to NILFS2 return EINVAL. This was caused by commit 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops"). This patch initializes the splice_write field in file_operations, like most file systems do, to restore the functionality. Link: https://lkml.kernel.org/r/1612784101-14353-1-git-send-email-konishi.ryusuke… Signed-off-by: Joachim Henke <joachim.henke(a)t-systems.com> Signed-off-by: Ryusuke Konishi <konishi.ryusuke(a)gmail.com> Tested-by: Ryusuke Konishi <konishi.ryusuke(a)gmail.com> Cc: <stable(a)vger.kernel.org> [5.10+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- fs/nilfs2/file.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/nilfs2/file.c~nilfs2-make-splice-write-available-again +++ a/fs/nilfs2/file.c @@ -141,6 +141,7 @@ const struct file_operations nilfs_file_ /* .release = nilfs_release_file, */ .fsync = nilfs_sync_file, .splice_read = generic_file_splice_read, + .splice_write = iter_file_splice_write, }; const struct inode_operations nilfs_file_inode_operations = { _

3 years, 8 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror February 2021