February 2021 - Linux-stable-mirror

[PATCH 2/2] tpm, tpm_tis: Decorate tpm_tis_gen_interrupt() with request_locality()

by Jarkko Sakkinen

From: Lukasz Majczak <lma(a)semihalf.com> This is shown with Samsung Chromebook Pro (Caroline) with TPM 1.2 (SLB 9670): [ 4.324298] TPM returned invalid status [ 4.324806] WARNING: CPU: 2 PID: 1 at drivers/char/tpm/tpm_tis_core.c:275 tpm_tis_status+0x86/0x8f Background ========== TCG PC Client Platform TPM Profile (PTP) Specification, paragraph 6.1 FIFO Interface Locality Usage per Register, Table 39 Register Behavior Based on Locality Setting for FIFO - a read attempt to TPM_STS_x Registers returns 0xFF in case of lack of locality. The fix ======= Decorate tpm_tis_gen_interrupt() with request_locality() and release_locality(). Cc: Laurent Bigonville <bigon(a)debian.org> Cc: James Bottomley <James.Bottomley(a)HansenPartnership.com> Cc: Guenter Roeck <linux(a)roeck-us.net> Cc: stable(a)vger.kernel.org Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()") Signed-off-by: Lukasz Majczak <lma(a)semihalf.com> Signed-off-by: Jarkko Sakkinen <jarkko(a)kernel.org> --- drivers/char/tpm/tpm_tis_core.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c index 30843954aa36..a2e0395cbe61 100644 --- a/drivers/char/tpm/tpm_tis_core.c +++ b/drivers/char/tpm/tpm_tis_core.c @@ -707,12 +707,22 @@ static int tpm_tis_gen_interrupt(struct tpm_chip *chip) const char *desc = "attempting to generate an interrupt"; u32 cap2; cap_t cap; + int ret; + /* TPM 2.0 */ if (chip->flags & TPM_CHIP_FLAG_TPM2) return tpm2_get_tpm_pt(chip, 0x100, &cap2, desc); - else - return tpm1_getcap(chip, TPM_CAP_PROP_TIS_TIMEOUT, &cap, desc, - 0); + + /* TPM 1.2 */ + ret = request_locality(chip, 0); + if (ret < 0) + return ret; + + ret = tpm1_getcap(chip, TPM_CAP_PROP_TIS_TIMEOUT, &cap, desc, 0); + + release_locality(chip, 0); + + return ret; } /* Register the IRQ and issue a command that will cause an interrupt. If an -- 2.30.1

3 years, 10 months

1
0
0 0

[PATCH] tools/resolve_btfids: Fix build error with older host toolchain

by Kun-Chuan Hsieh

Older verions of libelf cannot recognize the compressed section. However, it's only required to fix the compressed section info when compiling with CONFIG_DEBUG_INFO_COMPRESSED flag is set. Only compile the compressed_section_fix function when necessary will make it easier to enable the BTF function. Since the tool resolve_btfids is compiled with host toolchain. The host toolchain might be older than the cross compile toolchain. Cc: stable <stable(a)vger.kernel.org> Signed-off-by: Kun-Chuan Hsieh <jetswayss(a)gmail.com> --- tools/bpf/resolve_btfids/main.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c index 7409d7860aa6..ad40346c6631 100644 --- a/tools/bpf/resolve_btfids/main.c +++ b/tools/bpf/resolve_btfids/main.c @@ -260,6 +260,7 @@ static struct btf_id *add_symbol(struct rb_root *root, char *name, size_t size) return btf_id__add(root, id, false); } +#ifdef CONFIG_DEBUG_INFO_COMPRESSED /* * The data of compressed section should be aligned to 4 * (for 32bit) or 8 (for 64 bit) bytes. The binutils ld @@ -292,6 +293,7 @@ static int compressed_section_fix(Elf *elf, Elf_Scn *scn, GElf_Shdr *sh) } return 0; } +#endif static int elf_collect(struct object *obj) { @@ -370,8 +372,10 @@ static int elf_collect(struct object *obj) obj->efile.idlist_addr = sh.sh_addr; } +#ifdef CONFIG_DEBUG_INFO_COMPRESSED if (compressed_section_fix(elf, scn, &sh)) return -1; +#endif } return 0; -- 2.25.1

3 years, 10 months

1
0
0 0

[PATCH v2] MIPS: use FR=0 for FPXX binary

by YunQiang Su

some binary, for example the output of golang, may be mark as FPXX, while in fact they are still FP32. Since FPXX binary can work with both FR=1 and FR=0, we force it to use FR=0 here. https://go-review.googlesource.com/c/go/+/239217 https://go-review.googlesource.com/c/go/+/237058 v1->v2: Fix bad commit message: in fact, we are switching to FR=0 --- arch/mips/kernel/elf.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/arch/mips/kernel/elf.c b/arch/mips/kernel/elf.c index 7b045d2a0b51..bf798ce0ec0e 100644 --- a/arch/mips/kernel/elf.c +++ b/arch/mips/kernel/elf.c @@ -234,9 +234,10 @@ int arch_check_elf(void *_ehdr, bool has_interpreter, void *_interp_ehdr, * fpxx case. This is because, in any-ABI (or no-ABI) we have no FPU * instructions so we don't care about the mode. We will simply use * the one preferred by the hardware. In fpxx case, that ABI can - * handle both FR=1 and FR=0, so, again, we simply choose the one - * preferred by the hardware. Next, if we only use single-precision - * FPU instructions, and the default ABI FPU mode is not good + * handle both FR=1 and FR=0. Here, we use FR=0, because some + * binaries may be mark as FPXX by mistake (ie, output of golang). + * - If we only use single-precision FPU instructions, + * and the default ABI FPU mode is not good * (ie single + any ABI combination), we set again the FPU mode to the * one is preferred by the hardware. Next, if we know that the code * will only use single-precision instructions, shown by single being @@ -248,8 +249,9 @@ int arch_check_elf(void *_ehdr, bool has_interpreter, void *_interp_ehdr, */ if (prog_req.fre && !prog_req.frdefault && !prog_req.fr1) state->overall_fp_mode = FP_FRE; - else if ((prog_req.fr1 && prog_req.frdefault) || - (prog_req.single && !prog_req.frdefault)) + else if (prog_req.fr1 && prog_req.frdefault) + state->overall_fp_mode = FP_FR0; + else if (prog_req.single && !prog_req.frdefault) /* Make sure 64-bit MIPS III/IV/64R1 will not pick FR1 */ state->overall_fp_mode = ((raw_current_cpu_data.fpu_id & MIPS_FPIR_F64) && cpu_has_mips_r2_r6) ? -- 2.20.1

3 years, 10 months

2
1
0 0

[PATCH] MIPS: use FR=1 for FPXX binary

by YunQiang Su

some binary, for example the output of golang, may be mark as FPXX, while in fact they are still FP32. Since FPXX binary can work with both FR=1 and FR=0, we force it to use FR=1 here. https://go-review.googlesource.com/c/go/+/239217 https://go-review.googlesource.com/c/go/+/237058 --- arch/mips/kernel/elf.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/arch/mips/kernel/elf.c b/arch/mips/kernel/elf.c index 7b045d2a0b51..bf798ce0ec0e 100644 --- a/arch/mips/kernel/elf.c +++ b/arch/mips/kernel/elf.c @@ -234,9 +234,10 @@ int arch_check_elf(void *_ehdr, bool has_interpreter, void *_interp_ehdr, * fpxx case. This is because, in any-ABI (or no-ABI) we have no FPU * instructions so we don't care about the mode. We will simply use * the one preferred by the hardware. In fpxx case, that ABI can - * handle both FR=1 and FR=0, so, again, we simply choose the one - * preferred by the hardware. Next, if we only use single-precision - * FPU instructions, and the default ABI FPU mode is not good + * handle both FR=1 and FR=0. Here, we use FR=0, because some + * binaries may be mark as FPXX by mistake (ie, output of golang). + * - If we only use single-precision FPU instructions, + * and the default ABI FPU mode is not good * (ie single + any ABI combination), we set again the FPU mode to the * one is preferred by the hardware. Next, if we know that the code * will only use single-precision instructions, shown by single being @@ -248,8 +249,9 @@ int arch_check_elf(void *_ehdr, bool has_interpreter, void *_interp_ehdr, */ if (prog_req.fre && !prog_req.frdefault && !prog_req.fr1) state->overall_fp_mode = FP_FRE; - else if ((prog_req.fr1 && prog_req.frdefault) || - (prog_req.single && !prog_req.frdefault)) + else if (prog_req.fr1 && prog_req.frdefault) + state->overall_fp_mode = FP_FR0; + else if (prog_req.single && !prog_req.frdefault) /* Make sure 64-bit MIPS III/IV/64R1 will not pick FR1 */ state->overall_fp_mode = ((raw_current_cpu_data.fpu_id & MIPS_FPIR_F64) && cpu_has_mips_r2_r6) ? -- 2.20.1

3 years, 10 months

2
1
0 0

[PATCH 1/2] io_uring: wait potential ->release() on resurrect

by Pavel Begunkov

There is a short window where percpu_refs are already turned zero, but we try to do resurrect(). Play nicer and wait for all users to leave RCU section. Cc: <stable(a)vger.kernel.org> # 5.5+ Signed-off-by: Pavel Begunkov <asml.silence(a)gmail.com> --- fs/io_uring.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/io_uring.c b/fs/io_uring.c index f3af499b12a9..ce5fccf00367 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -7351,6 +7351,7 @@ static int io_rsrc_ref_quiesce(struct fixed_rsrc_data *data, break; percpu_ref_resurrect(&data->refs); + synchronize_rcu(); io_sqe_rsrc_set_node(ctx, data, backup_node); reinit_completion(&data->done); mutex_unlock(&ctx->uring_lock); @@ -10089,6 +10090,7 @@ static int __io_uring_register(struct io_ring_ctx *ctx, unsigned opcode, if (ret) { percpu_ref_resurrect(&ctx->refs); + synchronize_rcu(); goto out_quiesce; } } -- 2.24.0

3 years, 10 months

2
3
0 0

[PATCH 1/2] tpm, tpm_tis: Decorate tpm_get_timeouts() with request_locality()

by Jarkko Sakkinen

This is shown with Samsung Chromebook Pro (Caroline) with TPM 1.2 (SLB 9670): [ 4.324298] TPM returned invalid status [ 4.324806] WARNING: CPU: 2 PID: 1 at drivers/char/tpm/tpm_tis_core.c:275 tpm_tis_status+0x86/0x8f Background ========== TCG PC Client Platform TPM Profile (PTP) Specification, paragraph 6.1 FIFO Interface Locality Usage per Register, Table 39 Register Behavior Based on Locality Setting for FIFO - a read attempt to TPM_STS_x Registers returns 0xFF in case of lack of locality. The fix ======= Decorate tpm_get_timeouts() with request_locality() and release_locality(). Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()") Cc: James Bottomley <James.Bottomley(a)HansenPartnership.com> Cc: Guenter Roeck <linux(a)roeck-us.net> Cc: Laurent Bigonville <bigon(a)debian.org> Cc: stable(a)vger.kernel.org Reported-by: Lukasz Majczak <lma(a)semihalf.com> Signed-off-by: Jarkko Sakkinen <jarkko(a)kernel.org> --- drivers/char/tpm/tpm_tis_core.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c index 431919d5f48a..30843954aa36 100644 --- a/drivers/char/tpm/tpm_tis_core.c +++ b/drivers/char/tpm/tpm_tis_core.c @@ -1019,11 +1019,21 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq, init_waitqueue_head(&priv->read_queue); init_waitqueue_head(&priv->int_queue); if (irq != -1) { - /* Before doing irq testing issue a command to the TPM in polling mode + /* + * Before doing irq testing issue a command to the TPM in polling mode * to make sure it works. May as well use that command to set the * proper timeouts for the driver. */ - if (tpm_get_timeouts(chip)) { + + rc = request_locality(chip, 0); + if (rc < 0) + goto out_err; + + rc = tpm_get_timeouts(chip); + + release_locality(chip, 0); + + if (rc) { dev_err(dev, "Could not get TPM timeouts and durations\n"); rc = -ENODEV; goto out_err; -- 2.30.1

3 years, 10 months

1
0
0 0

[PATCH 03/13] drm/amd/display: Add vupdate_no_lock interrupts for DCN2.1

by Bindu Ramamurthy

From: Rodrigo Siqueira <Rodrigo.Siqueira(a)amd.com> When run igt@kms_vrr in a device that uses DCN2.1 architecture, we noticed multiple failures. Furthermore, when we tested a VRR demo, we noticed a system hang where the mouse pointer still works, but the entire system freezes; in this case, we don't see any dmesg warning or failure messages kernel. This happens due to a lack of vupdate_no_lock interrupt, making the userspace wait eternally to get the event back. For fixing this issue, we need to add the vupdate_no_lock interrupt in the interrupt list. Cc: stable(a)vger.kernel.org Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira(a)amd.com> Acked-by: Bindu Ramamurthy <bindu.r(a)amd.com> --- .../display/dc/irq/dcn21/irq_service_dcn21.c | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c b/drivers/gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c index 1b971265418b..0e0f494fbb5e 100644 --- a/drivers/gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c @@ -168,6 +168,11 @@ static const struct irq_source_info_funcs vblank_irq_info_funcs = { .ack = NULL }; +static const struct irq_source_info_funcs vupdate_no_lock_irq_info_funcs = { + .set = NULL, + .ack = NULL +}; + #undef BASE_INNER #define BASE_INNER(seg) DMU_BASE__INST0_SEG ## seg @@ -230,6 +235,17 @@ static const struct irq_source_info_funcs vblank_irq_info_funcs = { .funcs = &vblank_irq_info_funcs\ } +/* vupdate_no_lock_int_entry maps to DC_IRQ_SOURCE_VUPDATEx, to match semantic + * of DCE's DC_IRQ_SOURCE_VUPDATEx. + */ +#define vupdate_no_lock_int_entry(reg_num)\ + [DC_IRQ_SOURCE_VUPDATE1 + reg_num] = {\ + IRQ_REG_ENTRY(OTG, reg_num,\ + OTG_GLOBAL_SYNC_STATUS, VUPDATE_NO_LOCK_INT_EN,\ + OTG_GLOBAL_SYNC_STATUS, VUPDATE_NO_LOCK_EVENT_CLEAR),\ + .funcs = &vupdate_no_lock_irq_info_funcs\ + } + #define vblank_int_entry(reg_num)\ [DC_IRQ_SOURCE_VBLANK1 + reg_num] = {\ IRQ_REG_ENTRY(OTG, reg_num,\ @@ -338,6 +354,12 @@ irq_source_info_dcn21[DAL_IRQ_SOURCES_NUMBER] = { vupdate_int_entry(3), vupdate_int_entry(4), vupdate_int_entry(5), + vupdate_no_lock_int_entry(0), + vupdate_no_lock_int_entry(1), + vupdate_no_lock_int_entry(2), + vupdate_no_lock_int_entry(3), + vupdate_no_lock_int_entry(4), + vupdate_no_lock_int_entry(5), vblank_int_entry(0), vblank_int_entry(1), vblank_int_entry(2), -- 2.25.1

3 years, 10 months

1
0
0 0

[PATCH 5.10 000/104] 5.10.17-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.10.17 release. There are 104 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 17 Feb 2021 15:27:00 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.17-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.10.17-rc1 Andrey Konovalov <andreyknvl(a)google.com> kcov, usb: only collect coverage from __usb_hcd_giveback_urb in softirq Miklos Szeredi <mszeredi(a)redhat.com> ovl: expand warning in ovl_d_real() Sabyrzhan Tasbolatov <snovitoll(a)gmail.com> net/qrtr: restrict user-controlled length in qrtr_tun_write_iter() Sabyrzhan Tasbolatov <snovitoll(a)gmail.com> net/rds: restrict iovecs length for RDS_CMSG_RDMA_ARGS Stefano Garzarella <sgarzare(a)redhat.com> vsock: fix locking in vsock_shutdown() Stefano Garzarella <sgarzare(a)redhat.com> vsock/virtio: update credit only if socket is not closed Horatiu Vultur <horatiu.vultur(a)microchip.com> switchdev: mrp: Remove SWITCHDEV_ATTR_ID_MRP_PORT_STAT Horatiu Vultur <horatiu.vultur(a)microchip.com> bridge: mrp: Fix the usage of br_mrp_port_switchdev_set_state Edwin Peer <edwin.peer(a)broadcom.com> net: watchdog: hold device global xmit lock during tx disable Norbert Slusarek <nslusarek(a)gmx.net> net/vmw_vsock: improve locking in vsock_connect_timeout() Norbert Slusarek <nslusarek(a)gmx.net> net/vmw_vsock: fix NULL pointer dereference NeilBrown <neilb(a)suse.de> net: fix iteration for sctp transport seq_files Eric Dumazet <edumazet(a)google.com> net: gro: do not keep too many GRO packets in napi->rx_list Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> cpufreq: ACPI: Update arch scale-invariance max perf ratio if CPPC is not there Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> cpufreq: ACPI: Extend frequency tables to cover boost frequencies Vladimir Oltean <vladimir.oltean(a)nxp.com> net: dsa: call teardown method on probe failure Willem de Bruijn <willemb(a)google.com> udp: fix skb_copy_and_csum_datagram with odd segment sizes David Howells <dhowells(a)redhat.com> rxrpc: Fix clearance of Tx/Rx ring when releasing a call Catalin Marinas <catalin.marinas(a)arm.com> arm64: mte: Allow PTRACE_PEEKMTETAGS access to the zero page Thomas Gleixner <tglx(a)linutronix.de> x86/pci: Create PCI/MSI irqdomain after x86_init.pci.arch_init() Rolf Eike Beer <eb(a)emlix.com> scripts: set proper OpenSSL include dir also for sign-file Randy Dunlap <rdunlap(a)infradead.org> h8300: fix PREEMPTION build, TI_PRE_COUNT undefined Alain Volmat <alain.volmat(a)foss.st.com> i2c: stm32f7: fix configuration of the digital filter Jernej Skrabec <jernej.skrabec(a)siol.net> clk: sunxi-ng: mp: fix parent rate change flag check Jernej Skrabec <jernej.skrabec(a)siol.net> drm/sun4i: dw-hdmi: Fix max. frequency for H6 Jernej Skrabec <jernej.skrabec(a)siol.net> drm/sun4i: Fix H6 HDMI PHY configuration Jernej Skrabec <jernej.skrabec(a)siol.net> drm/sun4i: dw-hdmi: always set clock rate Jernej Skrabec <jernej.skrabec(a)siol.net> drm/sun4i: tcon: set sync polarity for tcon1 channel Fangrui Song <maskray(a)google.com> firmware_loader: align .builtin_fw to 8 Yufeng Mo <moyufeng(a)huawei.com> net: hns3: add a check for index in hclge_get_rss_key() Yufeng Mo <moyufeng(a)huawei.com> net: hns3: add a check for tqp_index in hclge_get_ring_chain_from_mbx() Yufeng Mo <moyufeng(a)huawei.com> net: hns3: add a check for queue_id in hclge_reset_vf_queue() Vladimir Oltean <vladimir.oltean(a)nxp.com> net: dsa: felix: implement port flushing on .phylink_mac_link_down Borislav Petkov <bp(a)suse.de> x86/build: Disable CET instrumentation in the kernel for 32-bit too Maurizio Lombardi <mlombard(a)redhat.com> scsi: scsi_debug: Fix a memory leak Florian Westphal <fw(a)strlen.de> netfilter: conntrack: skip identical origin tuple in same zone only Sukadev Bhattiprolu <sukadev(a)linux.ibm.com> ibmvnic: Clear failover_pending if unable to schedule Mohammad Athari Bin Ismail <mohammad.athari.ismail(a)intel.com> net: stmmac: set TxQ mode back to DCB after disabling CBS Vadim Fedorenko <vfedorenko(a)novek.ru> selftests: txtimestamp: fix compilation issue Vladimir Oltean <vladimir.oltean(a)nxp.com> net: enetc: initialize the RFS and RSS memories Andrea Parri (Microsoft) <parri.andrea(a)gmail.com> hv_netvsc: Reset the RSC count if NVSP_STAT_FAIL in netvsc_receive() Alex Elder <elder(a)linaro.org> net: ipa: set error code in gsi_channel_setup() Xie He <xie.he.0141(a)gmail.com> net: hdlc_x25: Return meaningful error code in x25_open Juergen Gross <jgross(a)suse.com> xen/netback: avoid race in xenvif_rx_ring_slots_available() Sven Auhagen <sven.auhagen(a)voleatech.de> netfilter: flowtable: fix tcp and udp header checksum update Pablo Neira Ayuso <pablo(a)netfilter.org> netfilter: nftables: fix possible UAF over chains from packet path in netns Fabian Frederick <fabf(a)skynet.be> selftests: netfilter: fix current year Jozsef Kadlecsik <kadlec(a)mail.kfki.hu> netfilter: xt_recent: Fix attempt to update deleted entry Bui Quang Minh <minhquangbui99(a)gmail.com> bpf: Check for integer overflow when using roundup_pow_of_two() Alexei Starovoitov <ast(a)kernel.org> bpf: Unbreak BPF_PROG_TYPE_KPROBE when kprobe is called via do_int3 Dave Jiang <dave.jiang(a)intel.com> dmaengine: idxd: check device state before issue command Maxime Ripard <maxime(a)cerno.tech> drm/vc4: hvs: Fix buffer overflow with the dlist handling Lorenzo Bianconi <lorenzo(a)kernel.org> mt76: dma: fix a possible memory leak in mt76_add_fragment() Arnd Bergmann <arnd(a)arndb.de> ath9k: fix build error with LEDS_CLASS=m Dave Jiang <dave.jiang(a)intel.com> dmaengine: idxd: fix misc interrupt completion Chen Zhou <chenzhou10(a)huawei.com> cgroup-v1: add disabled controller check in cgroup1_parse_param() Paolo Bonzini <pbonzini(a)redhat.com> KVM: x86: cleanup CR3 reserved bits checks Mark Rutland <mark.rutland(a)arm.com> lkdtm: don't move ctors to .rodata Borislav Petkov <bp(a)suse.de> x86/efi: Remove EFI PGD build time checks Thomas Gleixner <tglx(a)linutronix.de> Revert "lib: Restrict cpumask_local_spread to houskeeping CPUs" Nathan Chancellor <nathan(a)kernel.org> ubsan: implement __ubsan_handle_alignment_assumption Vincenzo Frascino <vincenzo.frascino(a)arm.com> kasan: add explicit preconditions to kasan_report() Russell King <rmk+kernel(a)armlinux.org.uk> ARM: kexec: fix oops after TLB are invalidated Russell King <rmk+kernel(a)armlinux.org.uk> ARM: ensure the signal page contains defined contents Arnd Bergmann <arnd(a)arndb.de> kallsyms: fix nonconverging kallsyms table with lld Alexandre Belloni <alexandre.belloni(a)bootlin.com> ARM: dts: lpc32xx: Revert set default clock rate of HCLK PLL Lin Feng <linf(a)wangsu.com> bfq-iosched: Revert "bfq: Fix computation of shallow depth" Alexandre Ghiti <alex(a)ghiti.fr> riscv: virt_addr_valid must check the address belongs to linear mapping Victor Lu <victorchengchi.lu(a)amd.com> drm/amd/display: Decrement refcount of dc_sink before reassignment Victor Lu <victorchengchi.lu(a)amd.com> drm/amd/display: Free atomic state after drm_atomic_commit Victor Lu <victorchengchi.lu(a)amd.com> drm/amd/display: Fix dc_sink kref count in emulated_link_detect Mikita Lipski <mikita.lipski(a)amd.com> drm/amd/display: Release DSC before acquiring Sung Lee <sung.lee(a)amd.com> drm/amd/display: Add more Clock Sources to DCN2.1 George Shen <george.shen(a)amd.com> drm/amd/display: Fix DPCD translation for LTTPR AUX_RD_INTERVAL Claus Stovgaard <claus.stovgaard(a)gmail.com> nvme-pci: ignore the subsysem NQN on Phison E16 Fenghua Yu <fenghua.yu(a)intel.com> x86/split_lock: Enable the split lock feature on another Alder Lake CPU James Smart <jsmart2021(a)gmail.com> scsi: lpfc: Fix EEH encountering oops with NVMe traffic Amir Goldstein <amir73il(a)gmail.com> ovl: skip getxattr of security labels Miklos Szeredi <mszeredi(a)redhat.com> cap: fix conversions on getxattr Miklos Szeredi <mszeredi(a)redhat.com> ovl: perform vfs_getxattr() with mounter creds Robin Murphy <robin.murphy(a)arm.com> arm64: dts: rockchip: Disable display for NanoPi R2S Hans de Goede <hdegoede(a)redhat.com> platform/x86: hp-wmi: Disable tablet-mode reporting by default Masahiro Yamada <masahiroy(a)kernel.org> kbuild: simplify GCC_PLUGINS enablement in dummy-tools/gcc Johan Jonker <jbx6244(a)gmail.com> arm64: dts: rockchip: remove interrupt-names property from rk3399 vdec node Tony Lindgren <tony(a)atomide.com> ARM: OMAP2+: Fix suspcious RCU usage splats for omap_enter_idle_coupled Bjorn Andersson <bjorn.andersson(a)linaro.org> arm64: dts: qcom: sdm845: Reserve LPASS clocks in gcc Marc Zyngier <maz(a)kernel.org> arm64: dts: rockchip: Fix PCIe DT properties on rk3399 Tony Lindgren <tony(a)atomide.com> soc: ti: omap-prm: Fix boot time errors for rst_map_012 bits 0 and 1 Seth Forshee <seth.forshee(a)canonical.com> tmpfs: disallow CONFIG_TMPFS_INODE64 on alpha Seth Forshee <seth.forshee(a)canonical.com> tmpfs: disallow CONFIG_TMPFS_INODE64 on s390 Dave Jiang <dave.jiang(a)intel.com> dmaengine: move channel device_node deletion to driver Imre Deak <imre.deak(a)intel.com> drm/dp_mst: Don't report ports connected if nothing is attached to them Imre Deak <imre.deak(a)intel.com> drm/i915/tgl+: Make sure TypeC FIA is powered up when initializing it Alex Deucher <alexander.deucher(a)amd.com> Revert "drm/amd/display: Update NV1x SR latency values" Odin Ugedal <odin(a)uged.al> cgroup: fix psi monitor for root cgroup Julien Grall <jgrall(a)amazon.com> arm/xen: Don't probe xenbus as part of an early initcall Ville Syrjälä <ville.syrjala(a)linux.intel.com> drm/i915: Fix overlay frontbuffer tracking Steven Rostedt (VMware) <rostedt(a)goodmis.org> tracing: Check length before giving out the filter buffer Steven Rostedt (VMware) <rostedt(a)goodmis.org> tracing: Do not count ftrace events in top level enable output Nikita Shubin <nikita.shubin(a)maquefel.me> gpio: ep93xx: Fix single irqchip with multi gpiochips Nikita Shubin <nikita.shubin(a)maquefel.me> gpio: ep93xx: fix BUG_ON port F usage Geert Uytterhoeven <geert+renesas(a)glider.be> gpio: mxs: GPIO_MXS should not default to y unconditionally Palmer Dabbelt <palmerdabbelt(a)google.com> Revert "dts: phy: add GPIO number and active state used for phy reset" Josh Poimboeuf <jpoimboe(a)redhat.com> objtool: Fix seg fault with Clang non-section symbols ------------- Diffstat: Makefile | 4 +- arch/arm/boot/dts/lpc32xx.dtsi | 3 - arch/arm/include/asm/kexec-internal.h | 12 ++ arch/arm/kernel/asm-offsets.c | 5 + arch/arm/kernel/machine_kexec.c | 20 +- arch/arm/kernel/relocate_kernel.S | 38 ++-- arch/arm/kernel/signal.c | 14 +- arch/arm/mach-omap2/cpuidle44xx.c | 16 +- arch/arm/xen/enlighten.c | 2 - arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 +- .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 +- arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts | 4 + arch/arm64/boot/dts/rockchip/rk3399.dtsi | 3 +- arch/arm64/kernel/cpufeature.c | 6 +- arch/arm64/kernel/mte.c | 3 +- arch/h8300/kernel/asm-offsets.c | 3 + .../riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 - arch/riscv/include/asm/page.h | 5 +- arch/x86/Makefile | 6 +- arch/x86/kernel/cpu/intel.c | 1 + arch/x86/kernel/smpboot.c | 1 + arch/x86/kvm/svm/nested.c | 13 +- arch/x86/kvm/svm/svm.h | 3 - arch/x86/kvm/x86.c | 2 + arch/x86/pci/init.c | 15 +- arch/x86/platform/efi/efi_64.c | 19 -- block/bfq-iosched.c | 8 +- drivers/clk/sunxi-ng/ccu_mp.c | 2 +- drivers/cpufreq/acpi-cpufreq.c | 115 +++++++++-- drivers/dma/dmaengine.c | 1 - drivers/dma/idxd/device.c | 23 ++- drivers/dma/idxd/dma.c | 5 +- drivers/dma/idxd/idxd.h | 2 +- drivers/dma/idxd/init.c | 5 +- drivers/dma/idxd/irq.c | 36 +++- drivers/gpio/Kconfig | 3 +- drivers/gpio/gpio-ep93xx.c | 216 +++++++++++---------- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 22 +-- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 +- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 6 +- .../gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 4 +- .../gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 10 + drivers/gpu/drm/drm_dp_mst_topology.c | 1 + drivers/gpu/drm/i915/display/intel_overlay.c | 17 +- drivers/gpu/drm/i915/display/intel_tc.c | 67 ++++--- drivers/gpu/drm/sun4i/sun4i_tcon.c | 25 +++ drivers/gpu/drm/sun4i/sun4i_tcon.h | 6 + drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 10 +- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h | 1 - drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c | 26 +-- drivers/gpu/drm/vc4/vc4_plane.c | 18 +- drivers/i2c/busses/i2c-stm32f7.c | 11 +- drivers/misc/lkdtm/Makefile | 2 +- drivers/misc/lkdtm/rodata.c | 2 +- drivers/net/dsa/ocelot/felix.c | 17 +- drivers/net/ethernet/freescale/enetc/enetc_hw.h | 2 + drivers/net/ethernet/freescale/enetc/enetc_pf.c | 59 ++++++ .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 7 + .../net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 29 ++- drivers/net/ethernet/ibm/ibmvnic.c | 17 +- drivers/net/ethernet/mscc/ocelot.c | 54 ++++++ drivers/net/ethernet/mscc/ocelot_io.c | 8 + drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c | 7 +- drivers/net/hyperv/netvsc.c | 5 +- drivers/net/hyperv/rndis_filter.c | 2 - drivers/net/ipa/gsi.c | 1 + drivers/net/wan/hdlc_x25.c | 6 +- drivers/net/wireless/ath/ath9k/Kconfig | 8 +- drivers/net/wireless/mediatek/mt76/dma.c | 8 +- drivers/net/xen-netback/rx.c | 9 +- drivers/nvme/host/pci.c | 2 + drivers/platform/x86/hp-wmi.c | 14 +- drivers/scsi/lpfc/lpfc_nvme.c | 3 + drivers/scsi/scsi_debug.c | 1 + drivers/soc/ti/omap_prm.c | 11 ++ drivers/usb/core/hcd.c | 11 +- drivers/xen/xenbus/xenbus.h | 1 - drivers/xen/xenbus/xenbus_probe.c | 2 +- fs/Kconfig | 2 +- fs/overlayfs/copy_up.c | 15 +- fs/overlayfs/inode.c | 2 + fs/overlayfs/super.c | 13 +- include/asm-generic/vmlinux.lds.h | 2 +- include/linux/kasan.h | 7 + include/linux/netdevice.h | 2 + include/linux/uio.h | 8 +- include/net/switchdev.h | 2 - include/soc/mscc/ocelot.h | 2 + include/xen/xenbus.h | 2 - kernel/bpf/stackmap.c | 2 + kernel/cgroup/cgroup-v1.c | 3 + kernel/cgroup/cgroup.c | 4 +- kernel/trace/bpf_trace.c | 3 - kernel/trace/trace.c | 2 +- kernel/trace/trace_events.c | 3 +- lib/cpumask.c | 16 +- lib/iov_iter.c | 24 ++- lib/ubsan.c | 31 +++ lib/ubsan.h | 6 + net/bridge/br_mrp.c | 9 +- net/bridge/br_mrp_switchdev.c | 7 +- net/bridge/br_private_mrp.h | 3 +- net/core/datagram.c | 12 +- net/core/dev.c | 11 +- net/dsa/dsa2.c | 7 +- net/mac80211/Kconfig | 2 +- net/netfilter/nf_conntrack_core.c | 3 +- net/netfilter/nf_flow_table_core.c | 4 +- net/netfilter/nf_tables_api.c | 25 ++- net/netfilter/xt_recent.c | 12 +- net/qrtr/tun.c | 6 + net/rds/rdma.c | 3 + net/rxrpc/call_object.c | 2 - net/sctp/proc.c | 16 +- net/vmw_vsock/af_vsock.c | 15 +- net/vmw_vsock/hyperv_transport.c | 4 - net/vmw_vsock/virtio_transport_common.c | 4 +- scripts/Makefile | 1 + scripts/dummy-tools/gcc | 10 +- scripts/kallsyms.c | 6 + security/commoncap.c | 67 ++++--- tools/objtool/check.c | 11 +- tools/objtool/elf.c | 26 +++ tools/objtool/elf.h | 2 + tools/objtool/orc_gen.c | 29 +-- tools/testing/selftests/net/txtimestamp.c | 6 +- tools/testing/selftests/netfilter/nft_meta.sh | 2 +- 127 files changed, 1080 insertions(+), 517 deletions(-)

3 years, 10 months

10
120
0 0

[PATCH v2] virtio/s390: implement virtio-ccw revision 2 correctly

by Cornelia Huck

CCW_CMD_READ_STATUS was introduced with revision 2 of virtio-ccw, and drivers should only rely on it being implemented when they negotiated at least that revision with the device. However, virtio_ccw_get_status() issued READ_STATUS for any device operating at least at revision 1. If the device accepts READ_STATUS regardless of the negotiated revision (which some implementations like QEMU do, even though the spec currently does not allow it), everything works as intended. While a device rejecting the command should also be handled gracefully, we will not be able to see any changes the device makes to the status, such as setting NEEDS_RESET or setting the status to zero after a completed reset. We negotiated the revision to at most 1, as we never bumped the maximum revision; let's do that now and properly send READ_STATUS only if we are operating at least at revision 2. Cc: stable(a)vger.kernel.org Fixes: 7d3ce5ab9430 ("virtio/s390: support READ_STATUS command for virtio-ccw") Reviewed-by: Halil Pasic <pasic(a)linux.ibm.com> Signed-off-by: Cornelia Huck <cohuck(a)redhat.com> --- v1->v2: tweak patch description and cc:stable --- drivers/s390/virtio/virtio_ccw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c index 5730572b52cd..54e686dca6de 100644 --- a/drivers/s390/virtio/virtio_ccw.c +++ b/drivers/s390/virtio/virtio_ccw.c @@ -117,7 +117,7 @@ struct virtio_rev_info { }; /* the highest virtio-ccw revision we support */ -#define VIRTIO_CCW_REV_MAX 1 +#define VIRTIO_CCW_REV_MAX 2 struct virtio_ccw_vq_info { struct virtqueue *vq; @@ -952,7 +952,7 @@ static u8 virtio_ccw_get_status(struct virtio_device *vdev) u8 old_status = vcdev->dma_area->status; struct ccw1 *ccw; - if (vcdev->revision < 1) + if (vcdev->revision < 2) return vcdev->dma_area->status; ccw = ccw_device_dma_zalloc(vcdev->cdev, sizeof(*ccw)); -- 2.26.2

3 years, 10 months

2
2
0 0

+ ntfs-check-for-valid-standard-information-attribute.patch added to -mm tree

by akpm＠linux-foundation.org

The patch titled Subject: ntfs: check for valid standard information attribute has been added to the -mm tree. Its filename is ntfs-check-for-valid-standard-information-attribute.patch This patch should soon appear at https://ozlabs.org/~akpm/mmots/broken-out/ntfs-check-for-valid-standard-inf… and later at https://ozlabs.org/~akpm/mmotm/broken-out/ntfs-check-for-valid-standard-inf… Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Rustam Kovhaev <rkovhaev(a)gmail.com> Subject: ntfs: check for valid standard information attribute Mounting a corrupted filesystem with NTFS resulted in a kernel crash. We should check for valid STANDARD_INFORMATION attribute offset and length before trying to access it Link: https://lkml.kernel.org/r/20210217155930.1506815-1-rkovhaev@gmail.com Link: https://syzkaller.appspot.com/bug?extid=c584225dabdea2f71969 Signed-off-by: Rustam Kovhaev <rkovhaev(a)gmail.com> Reported-by: syzbot+c584225dabdea2f71969(a)syzkaller.appspotmail.com Tested-by: syzbot+c584225dabdea2f71969(a)syzkaller.appspotmail.com Acked-by: Anton Altaparmakov <anton(a)tuxera.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- fs/ntfs/inode.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/fs/ntfs/inode.c~ntfs-check-for-valid-standard-information-attribute +++ a/fs/ntfs/inode.c @@ -629,6 +629,12 @@ static int ntfs_read_locked_inode(struct } a = ctx->attr; /* Get the standard information attribute value. */ + if ((u8 *)a + le16_to_cpu(a->data.resident.value_offset) + + le32_to_cpu(a->data.resident.value_length) > + (u8 *)ctx->mrec + vol->mft_record_size) { + ntfs_error(vi->i_sb, "Corrupt standard information attribute in inode."); + goto unm_err_out; + } si = (STANDARD_INFORMATION*)((u8*)a + le16_to_cpu(a->data.resident.value_offset)); _ Patches currently in -mm which might be from rkovhaev(a)gmail.com are ntfs-check-for-valid-standard-information-attribute.patch

3 years, 10 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror February 2021