December 2021 - Linux-stable-mirror

[PATCH] parisc stable patch: parisc: Mark cr16 CPU clocksource unstable on all SMP machines

by Helge Deller

Hello stable team, can you please apply this patch to stable kernels from v4.14 up to v5.14 (both including). It's a backport of upstream commit: commit afdb4a5b1d340e4afffc65daa21cc71890d7d589 parisc: Mark cr16 CPU clocksource unstable on all SMP machines The upstream commit doesn't apply cleanly to those kernels, so this patch has been adjusted so that it now applies. Thanks! Helge ------------- Author: Helge Deller <deller(a)gmx.de> Date: Sat Dec 4 21:21:46 2021 +0100 parisc: Mark cr16 CPU clocksource unstable on all SMP machines In commit c8c3735997a3 ("parisc: Enhance detection of synchronous cr16 clocksources") I assumed that CPUs on the same physical core are syncronous. While booting up the kernel on two different C8000 machines, one with a dual-core PA8800 and one with a dual-core PA8900 CPU, this turned out to be wrong. The symptom was that I saw a jump in the internal clocks printed to the syslog and strange overall behaviour. On machines which have 4 cores (2 dual-cores) the problem isn't visible, because the current logic already marked the cr16 clocksource unstable in this case. This patch now marks the cr16 interval timers unstable if we have more than one CPU in the system, and it fixes this issue. Fixes: c8c3735997a3 ("parisc: Enhance detection of synchronous cr16 clocksources") Signed-off-by: Helge Deller <deller(a)gmx.de> Cc: <stable(a)vger.kernel.org> # v5.15+ diff --git a/arch/parisc/kernel/time.c b/arch/parisc/kernel/time.c index 08e4d480abe1..f26c9f466cdd 100644 --- a/arch/parisc/kernel/time.c +++ b/arch/parisc/kernel/time.c @@ -249,27 +249,13 @@ void __init time_init(void) static int __init init_cr16_clocksource(void) { /* - * The cr16 interval timers are not syncronized across CPUs on - * different sockets, so mark them unstable and lower rating on - * multi-socket SMP systems. + * The cr16 interval timers are not syncronized across CPUs, even if + * they share the same socket. */ if (num_online_cpus() > 1 && !running_on_qemu) { - int cpu; - unsigned long cpu0_loc; - cpu0_loc = per_cpu(cpu_data, 0).cpu_loc; - - for_each_online_cpu(cpu) { - if (cpu == 0) - continue; - if ((cpu0_loc != 0) && - (cpu0_loc == per_cpu(cpu_data, cpu).cpu_loc)) - continue; - - clocksource_cr16.name = "cr16_unstable"; - clocksource_cr16.flags = CLOCK_SOURCE_UNSTABLE; - clocksource_cr16.rating = 0; - break; - } + clocksource_cr16.name = "cr16_unstable"; + clocksource_cr16.flags = CLOCK_SOURCE_UNSTABLE; + clocksource_cr16.rating = 0; } /* XXX: We may want to mark sched_clock stable here if cr16 clocks are

3 years

2
1
0 0

Re: [PATCH 5.10] Revert "drm: meson_drv add shutdown function"

by Art Nikpal

On Sun, Dec 5, 2021 at 5:32 AM Jerome Brunet <jbrunet(a)baylibre.com> wrote: > > This reverts commit d66083c0d6f5125a4d982aa177dd71ab4cd3d212 > and commit d4ec1ffbdaa8939a208656e9c1440742c457ef16. > > On v5.10 stable, reboot gets stuck on gxl and g12a chip family (at least). > This was tested on the aml-s905x-cc from libretch and the u200 reference > design. What about the rate ? it's 100% stuck for any reboot try ! > > Bisecting on the v5.10 stable branch lead to > commit d4ec1ffbdaa8 ("drm: meson_drv add shutdown function"). > > Reverting it (and a fixes on the it) sloves the problem. > > Signed-off-by: Jerome Brunet <jbrunet(a)baylibre.com> > --- > > Hi Greg, > > Things are fine on master but it breaks on v5.10-y. > I did not check v5.14-y yet. I'll try next week. > > > drivers/gpu/drm/meson/meson_drv.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c > index 2753067c08e6..3d1de9cbb1c8 100644 > --- a/drivers/gpu/drm/meson/meson_drv.c > +++ b/drivers/gpu/drm/meson/meson_drv.c > @@ -482,17 +482,6 @@ static int meson_probe_remote(struct platform_device *pdev, > return count; > } > > -static void meson_drv_shutdown(struct platform_device *pdev) > -{ > - struct meson_drm *priv = dev_get_drvdata(&pdev->dev); > - > - if (!priv) > - return; > - > - drm_kms_helper_poll_fini(priv->drm); > - drm_atomic_helper_shutdown(priv->drm); > -} > - > static int meson_drv_probe(struct platform_device *pdev) > { > struct component_match *match = NULL; > @@ -564,7 +553,6 @@ static const struct dev_pm_ops meson_drv_pm_ops = { > > static struct platform_driver meson_drm_platform_driver = { > .probe = meson_drv_probe, > - .shutdown = meson_drv_shutdown, > .driver = { > .name = "meson-drm", > .of_match_table = dt_match, > -- > 2.34.0 >

3 years

1
0
0 0

stable-rc/queue/4.14 baseline: 106 runs, 1 regressions (v4.14.256-96-gecce7fba8d835)

by kernelci.org bot

stable-rc/queue/4.14 baseline: 106 runs, 1 regressions (v4.14.256-96-gecce7fba8d835) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ---------+------+---------------+----------+---------------------+------------ panda | arm | lab-collabora | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F4.14/kernel/v4.14.25… Test: baseline Tree: stable-rc Branch: queue/4.14 Describe: v4.14.256-96-gecce7fba8d835 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: ecce7fba8d835eecf8baa237cf9787ba19355046 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ---------+------+---------------+----------+---------------------+------------ panda | arm | lab-collabora | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/plan/id/61adbdb26cce7cbeab1a9482 Results: 4 PASS, 1 FAIL, 1 SKIP Full config: omap2plus_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.14/v4.14.256-96-gecce7fba8d… HTML log: https://storage.kernelci.org//stable-rc/queue-4.14/v4.14.256-96-gecce7fba8d… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.dmesg.emerg: https://kernelci.org/test/case/id/61adbdb26cce7cbeab1a9485 failing since 0 day (last pass: v4.14.256-86-gce5b7722e4968, first fail: v4.14.256-96-g0a8417bc52507) 2 lines 2021-12-06T07:36:58.644853 kern :emerg : BUG: spinlock bad magic on CPU#0, udevd/101 2021-12-06T07:36:58.654188 kern :emerg : lock: emif_lock+0x0/0xffffed3c [emif], .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0

3 years

1
0
0 0

✅ PASS: Test report for kernel 5.15.6 (stable-queue, 9da49635)

by CKI Project

Check out this report and any autotriaged failures in our web dashboard: https://datawarehouse.cki-project.org/kcidb/checkouts/26163 Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: 9da496353308 - serial: 8250_bcm7271: UART errors after resuming from S2 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK Targeted tests: NO All kernel binaries, config files, and logs are available for download here: https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefi… Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: make options: make -j24 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: make -j24 INSTALL_MOD_STRIP=1 targz-pkg s390x: make options: make -j24 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: make -j24 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ Reboot test ⚡⚡⚡ Networking bridge: sanity - mlx5 ⚡⚡⚡ Ethernet drivers sanity - mlx5 Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test ✅ Reboot test ✅ ACPI table test ✅ ACPI enabled test ✅ LTP - cve ✅ LTP - sched ⚡⚡⚡ LTP - syscalls ⚡⚡⚡ LTP - can ⚡⚡⚡ LTP - commands ⚡⚡⚡ LTP - containers ⚡⚡⚡ LTP - dio ⚡⚡⚡ LTP - fs ⚡⚡⚡ LTP - fsx ⚡⚡⚡ LTP - math ⚡⚡⚡ LTP - hugetlb ⚡⚡⚡ LTP - mm ⚡⚡⚡ LTP - nptl ⚡⚡⚡ LTP - pty ⚡⚡⚡ LTP - ipc ⚡⚡⚡ LTP - tracing ⚡⚡⚡ LTP: openposix test suite ⚡⚡⚡ CIFS Connectathon ⚡⚡⚡ POSIX pjd-fstest suites ⚡⚡⚡ NFS Connectathon ⚡⚡⚡ Loopdev Sanity ⚡⚡⚡ jvm - jcstress tests ⚡⚡⚡ Memory: fork_mem ⚡⚡⚡ Memory function: memfd_create ⚡⚡⚡ AMTU (Abstract Machine Test Utility) ⚡⚡⚡ Networking bridge: sanity ⚡⚡⚡ Ethernet drivers sanity ⚡⚡⚡ Networking socket: fuzz ⚡⚡⚡ Networking route: pmtu ⚡⚡⚡ Networking route_func - local ⚡⚡⚡ Networking route_func - forward ⚡⚡⚡ Networking TCP: keepalive test ⚡⚡⚡ Networking UDP: socket ⚡⚡⚡ Networking cki netfilter test ⚡⚡⚡ Networking tunnel: geneve basic test ⚡⚡⚡ Networking tunnel: gre basic ⚡⚡⚡ L2TP basic test ⚡⚡⚡ Networking tunnel: vxlan basic ⚡⚡⚡ Networking ipsec: basic netns - transport ⚡⚡⚡ Networking ipsec: basic netns - tunnel ⚡⚡⚡ Libkcapi AF_ALG test ⚡⚡⚡ pciutils: update pci ids test ⚡⚡⚡ ALSA PCM loopback test ⚡⚡⚡ ALSA Control (mixer) Userspace Element test ⚡⚡⚡ storage: dm/common ⚡⚡⚡ lvm snapper test ⚡⚡⚡ storage: SCSI VPD ⚡⚡⚡ trace: ftrace/tracer 🚧 ⚡⚡⚡ xarray-idr-radixtree-test 🚧 ⚡⚡⚡ i2c: i2cdetect sanity 🚧 ⚡⚡⚡ Firmware test suite 🚧 ⚡⚡⚡ Memory function: kaslr 🚧 ⚡⚡⚡ Networking: igmp conformance test 🚧 ⚡⚡⚡ audit: audit testsuite test Host 3: ✅ Boot test ✅ Reboot test 🚧 ✅ Storage blktests - nvmeof-mp Host 4: ✅ Boot test ✅ Reboot test 🚧 ✅ Storage blktests - srp Host 5: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test ✅ Reboot test ✅ xfstests - ext4 ✅ xfstests - xfs ⚡⚡⚡ IPMI driver test ⚡⚡⚡ IPMItool loop stress test ⚡⚡⚡ selinux-policy: serge-testsuite ⚡⚡⚡ Storage blktests - blk ⚡⚡⚡ Storage block - filesystem fio test ⚡⚡⚡ Storage block - queue scheduler test ⚡⚡⚡ storage: software RAID testing ⚡⚡⚡ Storage: swraid mdadm raid_module test ⚡⚡⚡ stress: stress-ng - interrupt ⚡⚡⚡ stress: stress-ng - cpu ⚡⚡⚡ stress: stress-ng - cpu-cache ⚡⚡⚡ stress: stress-ng - memory 🚧 ⚡⚡⚡ Podman system test - as root 🚧 ⚡⚡⚡ Podman system test - as user 🚧 ⚡⚡⚡ xfstests - btrfs 🚧 ⚡⚡⚡ Storage blktests - nvme-tcp 🚧 ⚡⚡⚡ lvm cache test 🚧 ⚡⚡⚡ stress: stress-ng - os Host 6: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ Reboot test ⚡⚡⚡ Networking bridge: sanity - mlx5 ⚡⚡⚡ Ethernet drivers sanity - mlx5 Host 7: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ Reboot test ⚡⚡⚡ Networking bridge: sanity - mlx5 ⚡⚡⚡ Ethernet drivers sanity - mlx5 ppc64le: Host 1: ✅ Boot test ✅ Reboot test ✅ LTP - cve ✅ LTP - sched ✅ LTP - syscalls ✅ LTP - can ✅ LTP - commands ✅ LTP - containers ✅ LTP - dio ✅ LTP - fs ✅ LTP - fsx ✅ LTP - math ✅ LTP - hugetlb ✅ LTP - mm ✅ LTP - nptl ✅ LTP - pty ✅ LTP - ipc ✅ LTP - tracing ✅ LTP: openposix test suite ✅ CIFS Connectathon ✅ POSIX pjd-fstest suites ✅ NFS Connectathon ✅ Loopdev Sanity ✅ jvm - jcstress tests ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking cki netfilter test ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ pciutils: update pci ids test ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test ✅ storage: dm/common ✅ lvm snapper test ✅ trace: ftrace/tracer 🚧 ✅ xarray-idr-radixtree-test 🚧 ✅ Memory function: kaslr 🚧 ✅ audit: audit testsuite test Host 2: ✅ Boot test ✅ Reboot test 🚧 ✅ Storage blktests - nvmeof-mp Host 3: ✅ Boot test ✅ Reboot test ✅ xfstests - ext4 ✅ xfstests - xfs ✅ IPMI driver test ✅ IPMItool loop stress test ✅ selinux-policy: serge-testsuite ✅ Storage blktests - blk ✅ Storage block - filesystem fio test ✅ Storage block - queue scheduler test ✅ storage: software RAID testing ✅ Storage: swraid mdadm raid_module test 🚧 ✅ Podman system test - as root 🚧 ✅ Podman system test - as user 🚧 ✅ xfstests - btrfs 🚧 ✅ Storage blktests - nvme-tcp 🚧 ✅ Storage: lvm device-mapper test - upstream 🚧 ✅ lvm cache test Host 4: ✅ Boot test ✅ Reboot test 🚧 ❌ Storage blktests - srp s390x: Host 1: ✅ Boot test ✅ Reboot test ✅ LTP - cve ✅ LTP - sched ✅ LTP - syscalls ✅ LTP - can ✅ LTP - commands ✅ LTP - containers ✅ LTP - dio ✅ LTP - fs ✅ LTP - fsx ✅ LTP - math ✅ LTP - hugetlb ✅ LTP - mm ✅ LTP - nptl ✅ LTP - pty ✅ LTP - ipc ✅ LTP - tracing ✅ LTP: openposix test suite ✅ CIFS Connectathon ✅ POSIX pjd-fstest suites ✅ NFS Connectathon ✅ Loopdev Sanity ✅ jvm - jcstress tests ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking cki netfilter test ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - transport ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ storage: dm/common ✅ lvm snapper test ✅ trace: ftrace/tracer 🚧 ❌ xarray-idr-radixtree-test 🚧 ✅ Memory function: kaslr 🚧 ✅ audit: audit testsuite test Host 2: ✅ Boot test ✅ Reboot test ✅ selinux-policy: serge-testsuite ✅ Storage blktests - blk ✅ Storage: swraid mdadm raid_module test ✅ stress: stress-ng - interrupt ✅ stress: stress-ng - cpu ✅ stress: stress-ng - cpu-cache ✅ stress: stress-ng - memory 🚧 ✅ Podman system test - as root 🚧 ✅ Podman system test - as user 🚧 ✅ Storage blktests - nvme-tcp 🚧 ✅ lvm cache test 🚧 ✅ stress: stress-ng - os Host 3: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test ✅ Reboot test 🚧 ⚡⚡⚡ Storage blktests - srp Host 4: ✅ Boot test ✅ Reboot test 🚧 ✅ Storage blktests - nvmeof-mp x86_64: Host 1: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ Reboot test ⚡⚡⚡ xfstests - ext4 ⚡⚡⚡ xfstests - xfs ⚡⚡⚡ xfstests - nfsv4.2 ⚡⚡⚡ xfstests - cifsv3.11 ⚡⚡⚡ IPMI driver test ⚡⚡⚡ IPMItool loop stress test ⚡⚡⚡ selinux-policy: serge-testsuite ⚡⚡⚡ Storage blktests - blk ⚡⚡⚡ Storage block - filesystem fio test ⚡⚡⚡ Storage block - queue scheduler test ⚡⚡⚡ storage: software RAID testing ⚡⚡⚡ Storage: swraid mdadm raid_module test ⚡⚡⚡ stress: stress-ng - interrupt ⚡⚡⚡ stress: stress-ng - cpu ⚡⚡⚡ stress: stress-ng - cpu-cache ⚡⚡⚡ stress: stress-ng - memory 🚧 ⚡⚡⚡ Podman system test - as root 🚧 ⚡⚡⚡ Podman system test - as user 🚧 ⚡⚡⚡ CPU: Idle Test 🚧 ⚡⚡⚡ xfstests - btrfs 🚧 ⚡⚡⚡ Storage blktests - nvme-tcp 🚧 ⚡⚡⚡ Storage: lvm device-mapper test - upstream 🚧 ⚡⚡⚡ lvm cache test 🚧 ⚡⚡⚡ stress: stress-ng - os Host 2: ✅ Boot test ✅ Reboot test 🚧 ✅ Storage blktests - srp Host 3: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test ✅ Reboot test ✅ ACPI table test ✅ LTP - cve ✅ LTP - sched ✅ LTP - syscalls ⚡⚡⚡ LTP - can ⚡⚡⚡ LTP - commands ⚡⚡⚡ LTP - containers ⚡⚡⚡ LTP - dio ⚡⚡⚡ LTP - fs ⚡⚡⚡ LTP - fsx ⚡⚡⚡ LTP - math ⚡⚡⚡ LTP - hugetlb ⚡⚡⚡ LTP - mm ⚡⚡⚡ LTP - nptl ⚡⚡⚡ LTP - pty ⚡⚡⚡ LTP - ipc ⚡⚡⚡ LTP - tracing ⚡⚡⚡ LTP: openposix test suite ⚡⚡⚡ CIFS Connectathon ⚡⚡⚡ POSIX pjd-fstest suites ⚡⚡⚡ NFS Connectathon ⚡⚡⚡ Loopdev Sanity ⚡⚡⚡ jvm - jcstress tests ⚡⚡⚡ Memory: fork_mem ⚡⚡⚡ Memory function: memfd_create ⚡⚡⚡ AMTU (Abstract Machine Test Utility) ⚡⚡⚡ Networking bridge: sanity ⚡⚡⚡ Ethernet drivers sanity ⚡⚡⚡ Networking socket: fuzz ⚡⚡⚡ Networking route: pmtu ⚡⚡⚡ Networking route_func - local ⚡⚡⚡ Networking route_func - forward ⚡⚡⚡ Networking TCP: keepalive test ⚡⚡⚡ Networking UDP: socket ⚡⚡⚡ Networking cki netfilter test ⚡⚡⚡ Networking tunnel: geneve basic test ⚡⚡⚡ Networking tunnel: gre basic ⚡⚡⚡ L2TP basic test ⚡⚡⚡ Networking tunnel: vxlan basic ⚡⚡⚡ Networking ipsec: basic netns - transport ⚡⚡⚡ Networking ipsec: basic netns - tunnel ⚡⚡⚡ Libkcapi AF_ALG test ⚡⚡⚡ pciutils: sanity smoke test ⚡⚡⚡ pciutils: update pci ids test ⚡⚡⚡ ALSA PCM loopback test ⚡⚡⚡ ALSA Control (mixer) Userspace Element test ⚡⚡⚡ storage: dm/common ⚡⚡⚡ lvm snapper test ⚡⚡⚡ storage: SCSI VPD ⚡⚡⚡ trace: ftrace/tracer 🚧 ⚡⚡⚡ xarray-idr-radixtree-test 🚧 ⚡⚡⚡ i2c: i2cdetect sanity 🚧 ⚡⚡⚡ Firmware test suite 🚧 ⚡⚡⚡ Memory function: kaslr 🚧 ⚡⚡⚡ Networking: igmp conformance test 🚧 ⚡⚡⚡ audit: audit testsuite test Host 4: ✅ Boot test ✅ Reboot test 🚧 ✅ Storage blktests - nvmeof-mp Host 5: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ Reboot test ⚡⚡⚡ xfstests - ext4 ⚡⚡⚡ xfstests - xfs ⚡⚡⚡ xfstests - nfsv4.2 ⚡⚡⚡ xfstests - cifsv3.11 ⚡⚡⚡ IPMI driver test ⚡⚡⚡ IPMItool loop stress test ⚡⚡⚡ selinux-policy: serge-testsuite ⚡⚡⚡ Storage blktests - blk ⚡⚡⚡ Storage block - filesystem fio test ⚡⚡⚡ Storage block - queue scheduler test ⚡⚡⚡ storage: software RAID testing ⚡⚡⚡ Storage: swraid mdadm raid_module test ⚡⚡⚡ stress: stress-ng - interrupt ⚡⚡⚡ stress: stress-ng - cpu ⚡⚡⚡ stress: stress-ng - cpu-cache ⚡⚡⚡ stress: stress-ng - memory 🚧 ⚡⚡⚡ Podman system test - as root 🚧 ⚡⚡⚡ Podman system test - as user 🚧 ⚡⚡⚡ CPU: Idle Test 🚧 ⚡⚡⚡ xfstests - btrfs 🚧 ⚡⚡⚡ Storage blktests - nvme-tcp 🚧 ⚡⚡⚡ Storage: lvm device-mapper test - upstream 🚧 ⚡⚡⚡ lvm cache test 🚧 ⚡⚡⚡ stress: stress-ng - os Host 6: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ Reboot test ⚡⚡⚡ xfstests - ext4 ⚡⚡⚡ xfstests - xfs ⚡⚡⚡ xfstests - nfsv4.2 ⚡⚡⚡ xfstests - cifsv3.11 ⚡⚡⚡ IPMI driver test ⚡⚡⚡ IPMItool loop stress test ⚡⚡⚡ selinux-policy: serge-testsuite ⚡⚡⚡ Storage blktests - blk ⚡⚡⚡ Storage block - filesystem fio test ⚡⚡⚡ Storage block - queue scheduler test ⚡⚡⚡ storage: software RAID testing ⚡⚡⚡ Storage: swraid mdadm raid_module test ⚡⚡⚡ stress: stress-ng - interrupt ⚡⚡⚡ stress: stress-ng - cpu ⚡⚡⚡ stress: stress-ng - cpu-cache ⚡⚡⚡ stress: stress-ng - memory 🚧 ⚡⚡⚡ Podman system test - as root 🚧 ⚡⚡⚡ Podman system test - as user 🚧 ⚡⚡⚡ CPU: Idle Test 🚧 ⚡⚡⚡ xfstests - btrfs 🚧 ⚡⚡⚡ Storage blktests - nvme-tcp 🚧 ⚡⚡⚡ Storage: lvm device-mapper test - upstream 🚧 ⚡⚡⚡ lvm cache test 🚧 ⚡⚡⚡ stress: stress-ng - os Test sources: https://gitlab.com/cki-project/kernel-tests 💚 Pull requests are welcome for new tests or improvements to existing tests! Aborted tests ------------- Tests that didn't complete running successfully are marked with ⚡⚡⚡. If this was caused by an infrastructure issue, we try to mark that explicitly in the report. Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed. Testing timeout --------------- We aim to provide a report within reasonable timeframe. Tests that haven't finished running yet are marked with ⏱. Targeted tests -------------- Test runs for patches always include a set of base tests, plus some tests chosen based on the file paths modified by the patch. The latter are called "targeted tests". If no targeted tests are run, that means no patch-specific tests are available. Please, consider contributing a targeted test for related patches to increase test coverage. See https://docs.engineering.redhat.com/x/_wEZB for more details.

3 years

1
0
0 0

stable-rc/queue/4.9 baseline: 93 runs, 3 regressions (v4.9.291-57-gb208f4ab2d641)

by kernelci.org bot

stable-rc/queue/4.9 baseline: 93 runs, 3 regressions (v4.9.291-57-gb208f4ab2d641) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ----------------+-------+---------------+----------+---------------------+------------ i945gsex-qs | i386 | lab-clabbe | gcc-10 | i386_defconfig | 1 meson-gxbb-p200 | arm64 | lab-baylibre | gcc-10 | defconfig | 1 panda | arm | lab-collabora | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F4.9/kernel/v4.9.291-… Test: baseline Tree: stable-rc Branch: queue/4.9 Describe: v4.9.291-57-gb208f4ab2d641 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: b208f4ab2d6418b1ac2821460ee5e5c6571435c0 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ----------------+-------+---------------+----------+---------------------+------------ i945gsex-qs | i386 | lab-clabbe | gcc-10 | i386_defconfig | 1 Details: https://kernelci.org/test/plan/id/61ada73bc6851b74a21a94b4 Results: 4 PASS, 1 FAIL, 1 SKIP Full config: i386_defconfig Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.291-57-gb208f4ab2d64… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.291-57-gb208f4ab2d64… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.dmesg.emerg: https://kernelci.org/test/case/id/61ada73bc6851b74a21a94b9 new failure (last pass: v4.9.291-57-g86c90b21b24d) 1 lines 2021-12-06T06:01:10.438899 kern :emerg : do_IRQ: 0.236 No irq handler for vector 2021-12-06T06:01:10.447921 [ 12.003657] <LAVA_SIGNAL_TESTCASE TEST_CASE_ID=emerg RESULT=fail UNITS=lines MEASUREMENT=1> platform | arch | lab | compiler | defconfig | regressions ----------------+-------+---------------+----------+---------------------+------------ meson-gxbb-p200 | arm64 | lab-baylibre | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/61ada8b86f3aecc35c1a9482 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.291-57-gb208f4ab2d64… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.291-57-gb208f4ab2d64… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.login: https://kernelci.org/test/case/id/61ada8b86f3aecc35c1a9483 new failure (last pass: v4.9.291-57-g86c90b21b24d) platform | arch | lab | compiler | defconfig | regressions ----------------+-------+---------------+----------+---------------------+------------ panda | arm | lab-collabora | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/plan/id/61ada83e98939b91b01a948e Results: 4 PASS, 1 FAIL, 1 SKIP Full config: omap2plus_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.291-57-gb208f4ab2d64… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.291-57-gb208f4ab2d64… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.dmesg.emerg: https://kernelci.org/test/case/id/61ada83e98939b91b01a9491 failing since 1 day (last pass: v4.9.291-47-g43f5262d9792, first fail: v4.9.291-51-g9e9032945598a) 2 lines 2021-12-06T06:05:23.797304 kern :emerg : BUG: spinlock bad magic on CPU#0, udevd/119 2021-12-06T06:05:23.806597 kern :emerg : lock: emif_lock+0x0/0xfffff230 [emif], .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0

3 years

1
0
0 0

stable-rc/queue/4.19 baseline: 123 runs, 2 regressions (v4.19.219-36-g0ade2b16b7cf2)

by kernelci.org bot

stable-rc/queue/4.19 baseline: 123 runs, 2 regressions (v4.19.219-36-g0ade2b16b7cf2) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ----------------+-------+---------------+----------+---------------------+------------ meson-gxbb-p200 | arm64 | lab-baylibre | gcc-10 | defconfig | 1 panda | arm | lab-collabora | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F4.19/kernel/v4.19.21… Test: baseline Tree: stable-rc Branch: queue/4.19 Describe: v4.19.219-36-g0ade2b16b7cf2 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 0ade2b16b7cf2a90f8a7120e39f2856bd46d8ff1 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ----------------+-------+---------------+----------+---------------------+------------ meson-gxbb-p200 | arm64 | lab-baylibre | gcc-10 | defconfig | 1 Details: https://kernelci.org/test/plan/id/61adacb418af1cbc631a949d Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-10 (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.219-36-g0ade2b16b7… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.219-36-g0ade2b16b7… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.login: https://kernelci.org/test/case/id/61adacb518af1cbc631a949e new failure (last pass: v4.19.219-36-gd334ce8fcda5) platform | arch | lab | compiler | defconfig | regressions ----------------+-------+---------------+----------+---------------------+------------ panda | arm | lab-collabora | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/plan/id/61adace22586f5e9bc1a9483 Results: 5 PASS, 1 FAIL, 0 SKIP Full config: omap2plus_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.219-36-g0ade2b16b7… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.219-36-g0ade2b16b7… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.dmesg.emerg: https://kernelci.org/test/case/id/61adace22586f5e9bc1a9486 failing since 2 days (last pass: v4.19.219-3-g91f80b6b7a49a, first fail: v4.19.219-3-g04afdf3600b5e) 2 lines 2021-12-06T06:25:11.961817 <6>[ 20.971405] [drm] Cannot find any crtc or sizes 2021-12-06T06:25:12.012792 kern :emerg : BUG: spinlock bad magic on CPU#0, udevd/104 2021-12-06T06:25:12.021901 kern :emerg : lock: emif_lock+0x0/0xffffecfc [emif], .magic: dead4ead, .owner: <none>/-1, .owner_cpu: -1

3 years

1
0
0 0

stable-rc/queue/4.4 baseline: 77 runs, 3 regressions (v4.4.293-48-g1b8de9fa79c0)

by kernelci.org bot

stable-rc/queue/4.4 baseline: 77 runs, 3 regressions (v4.4.293-48-g1b8de9fa79c0) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ----------+------+---------------+----------+---------------------+------------ beagle-xm | arm | lab-baylibre | gcc-10 | omap2plus_defconfig | 2 panda | arm | lab-collabora | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F4.4/kernel/v4.4.293-… Test: baseline Tree: stable-rc Branch: queue/4.4 Describe: v4.4.293-48-g1b8de9fa79c0 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 1b8de9fa79c044b9833336f32293fedb3ed4b12a Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ----------+------+---------------+----------+---------------------+------------ beagle-xm | arm | lab-baylibre | gcc-10 | omap2plus_defconfig | 2 Details: https://kernelci.org/test/plan/id/61ada534f8a92ada2f1a9490 Results: 3 PASS, 2 FAIL, 1 SKIP Full config: omap2plus_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.293-48-g1b8de9fa79c0… HTML log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.293-48-g1b8de9fa79c0… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.dmesg.crit: https://kernelci.org/test/case/id/61ada534f8a92ada2f1a9493 new failure (last pass: v4.4.293-48-g52d38a062535) 1 lines 2021-12-06T05:52:40.581147 / 2021-12-06T05:52:40.684834 # # 2021-12-06T05:52:40.685454 2021-12-06T05:52:40.786731 / # #export SHELL=/bin/sh 2021-12-06T05:52:40.787086 2021-12-06T05:52:40.888220 / # export SHELL=/bin/sh. /lava-1194355/environment 2021-12-06T05:52:40.888560 2021-12-06T05:52:40.989702 / # . /lava-1194355/environment/lava-1194355/bin/lava-test-runner /lava-1194355/0 2021-12-06T05:52:40.990816 2021-12-06T05:52:40.991487 / # /lava-1194355/bin/lava-test-runner /lava-1194355/0 ... (8 line(s) more) * baseline.dmesg.emerg: https://kernelci.org/test/case/id/61ada534f8a92ada2f1a9495 new failure (last pass: v4.4.293-48-g52d38a062535) 29 lines 2021-12-06T05:52:41.419404 kern :emerg : Internal error: Oops - BUG: 0 [#1] SMP ARM 2021-12-06T05:52:41.425513 kern :emerg : Process udevd (pid: 113, stack limit = 0xcb9a6218) 2021-12-06T05:52:41.431970 kern :emerg : Stack: (0xcb9a7cf8 to 0xcb9a8000) 2021-12-06T05:52:41.437211 kern :emerg : 7ce0: bf02bdc4 60000013 2021-12-06T05:52:41.445875 kern :emerg : 7d00: bf02bdc8 c06a38e4 00000001 00000000 bf010250 00000002 60000093 00000002 platform | arch | lab | compiler | defconfig | regressions ----------+------+---------------+----------+---------------------+------------ panda | arm | lab-collabora | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/plan/id/61ada56615266152191a94ac Results: 4 PASS, 1 FAIL, 1 SKIP Full config: omap2plus_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.293-48-g1b8de9fa79c0… HTML log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.293-48-g1b8de9fa79c0… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.dmesg.emerg: https://kernelci.org/test/case/id/61ada56615266152191a94af failing since 4 days (last pass: v4.4.293-33-g845bf34b777ca, first fail: v4.4.293-33-gfe2c5280cbbe0) 2 lines 2021-12-06T05:53:14.822718 kern :emerg : BUG: spinlock bad magic on CPU#0, udevd/114 2021-12-06T05:53:14.833717 kern :emerg : lock: emif_lock+0x0/0xfffff25c [emif], .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0

3 years

1
0
0 0

Re: [PATCH 5.10] Revert "drm: meson_drv add shutdown function"

by Art Nikpal

hi all i have test it on (VIM1 VIM2 VIM3 VIM3L) its works on my side + 5.10.11 + 5.11.x + 5.13.x + 5.14.x + 5.15.x + 5.16.x can u share your kernel config (i know for some kernel configuration drivers still have problem with reboot ) On Sun, Dec 5, 2021 at 5:32 AM Jerome Brunet <jbrunet(a)baylibre.com> wrote: > > This reverts commit d66083c0d6f5125a4d982aa177dd71ab4cd3d212 > and commit d4ec1ffbdaa8939a208656e9c1440742c457ef16. > > On v5.10 stable, reboot gets stuck on gxl and g12a chip family (at least). > This was tested on the aml-s905x-cc from libretch and the u200 reference > design. > > Bisecting on the v5.10 stable branch lead to > commit d4ec1ffbdaa8 ("drm: meson_drv add shutdown function"). > > Reverting it (and a fixes on the it) sloves the problem. > > Signed-off-by: Jerome Brunet <jbrunet(a)baylibre.com> > --- > > Hi Greg, > > Things are fine on master but it breaks on v5.10-y. > I did not check v5.14-y yet. I'll try next week. > > > drivers/gpu/drm/meson/meson_drv.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c > index 2753067c08e6..3d1de9cbb1c8 100644 > --- a/drivers/gpu/drm/meson/meson_drv.c > +++ b/drivers/gpu/drm/meson/meson_drv.c > @@ -482,17 +482,6 @@ static int meson_probe_remote(struct platform_device *pdev, > return count; > } > > -static void meson_drv_shutdown(struct platform_device *pdev) > -{ > - struct meson_drm *priv = dev_get_drvdata(&pdev->dev); > - > - if (!priv) > - return; > - > - drm_kms_helper_poll_fini(priv->drm); > - drm_atomic_helper_shutdown(priv->drm); > -} > - > static int meson_drv_probe(struct platform_device *pdev) > { > struct component_match *match = NULL; > @@ -564,7 +553,6 @@ static const struct dev_pm_ops meson_drv_pm_ops = { > > static struct platform_driver meson_drm_platform_driver = { > .probe = meson_drv_probe, > - .shutdown = meson_drv_shutdown, > .driver = { > .name = "meson-drm", > .of_match_table = dt_match, > -- > 2.34.0 >

3 years

2
1
0 0

FAILED: patch "[PATCH] net/tls: Fix authentication failure in CCM mode" failed to apply to 5.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 5961060692f8b17cd2080620a3d27b95d2ae05ca Mon Sep 17 00:00:00 2001 From: Tianjia Zhang <tianjia.zhang(a)linux.alibaba.com> Date: Mon, 29 Nov 2021 17:32:12 +0800 Subject: [PATCH] net/tls: Fix authentication failure in CCM mode When the TLS cipher suite uses CCM mode, including AES CCM and SM4 CCM, the first byte of the B0 block is flags, and the real IV starts from the second byte. The XOR operation of the IV and rec_seq should be skip this byte, that is, add the iv_offset. Fixes: f295b3ae9f59 ("net/tls: Add support of AES128-CCM based ciphers") Signed-off-by: Tianjia Zhang <tianjia.zhang(a)linux.alibaba.com> Cc: Vakul Garg <vakul.garg(a)nxp.com> Cc: stable(a)vger.kernel.org # v5.2+ Signed-off-by: David S. Miller <davem(a)davemloft.net> diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c index d3e7ff90889e..dfe623a4e72f 100644 --- a/net/tls/tls_sw.c +++ b/net/tls/tls_sw.c @@ -521,7 +521,7 @@ static int tls_do_encryption(struct sock *sk, memcpy(&rec->iv_data[iv_offset], tls_ctx->tx.iv, prot->iv_size + prot->salt_size); - xor_iv_with_seq(prot, rec->iv_data, tls_ctx->tx.rec_seq); + xor_iv_with_seq(prot, rec->iv_data + iv_offset, tls_ctx->tx.rec_seq); sge->offset += prot->prepend_size; sge->length -= prot->prepend_size; @@ -1499,7 +1499,7 @@ static int decrypt_internal(struct sock *sk, struct sk_buff *skb, else memcpy(iv + iv_offset, tls_ctx->rx.iv, prot->salt_size); - xor_iv_with_seq(prot, iv, tls_ctx->rx.rec_seq); + xor_iv_with_seq(prot, iv + iv_offset, tls_ctx->rx.rec_seq); /* Prepare AAD */ tls_make_aad(aad, rxm->full_len - prot->overhead_size +

3 years

2
1
0 0

[git:media_stage/master] media: cec-pin: fix interrupt en/disable handling

by Mauro Carvalho Chehab

This is an automatic generated email to let you know that the following patch were queued: Subject: media: cec-pin: fix interrupt en/disable handling Author: Hans Verkuil <hverkuil-cisco(a)xs4all.nl> Date: Wed Dec 1 13:41:25 2021 +0100 The en/disable_irq() functions keep track of the 'depth': i.e. if interrupts are disabled twice, then it needs to enable_irq() calls to enable them again. The cec-pin framework didn't take this into accound and could disable irqs multiple times, and it expected that a single enable_irq() would enable them again. Move all calls to en/disable_irq() to the kthread where it is easy to keep track of the current irq state and ensure that multiple en/disable_irq calls never happen. If interrupts where disabled twice, then they would never turn on again, leaving the CEC adapter in a dead state. Signed-off-by: Hans Verkuil <hverkuil-cisco(a)xs4all.nl> Fixes: 865463fc03ed (media: cec-pin: add error injection support) Cc: <stable(a)vger.kernel.org> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org> drivers/media/cec/core/cec-pin.c | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-) --- diff --git a/drivers/media/cec/core/cec-pin.c b/drivers/media/cec/core/cec-pin.c index 2b6459df1e94..21f0f749713e 100644 --- a/drivers/media/cec/core/cec-pin.c +++ b/drivers/media/cec/core/cec-pin.c @@ -1033,6 +1033,7 @@ static int cec_pin_thread_func(void *_adap) { struct cec_adapter *adap = _adap; struct cec_pin *pin = adap->pin; + bool irq_enabled = false; for (;;) { wait_event_interruptible(pin->kthread_waitq, @@ -1060,6 +1061,7 @@ static int cec_pin_thread_func(void *_adap) ns_to_ktime(pin->work_rx_msg.rx_ts)); msg->len = 0; } + if (pin->work_tx_status) { unsigned int tx_status = pin->work_tx_status; @@ -1083,27 +1085,39 @@ static int cec_pin_thread_func(void *_adap) switch (atomic_xchg(&pin->work_irq_change, CEC_PIN_IRQ_UNCHANGED)) { case CEC_PIN_IRQ_DISABLE: - pin->ops->disable_irq(adap); + if (irq_enabled) { + pin->ops->disable_irq(adap); + irq_enabled = false; + } cec_pin_high(pin); cec_pin_to_idle(pin); hrtimer_start(&pin->timer, ns_to_ktime(0), HRTIMER_MODE_REL); break; case CEC_PIN_IRQ_ENABLE: + if (irq_enabled) + break; pin->enable_irq_failed = !pin->ops->enable_irq(adap); if (pin->enable_irq_failed) { cec_pin_to_idle(pin); hrtimer_start(&pin->timer, ns_to_ktime(0), HRTIMER_MODE_REL); + } else { + irq_enabled = true; } break; default: break; } - if (kthread_should_stop()) break; } + if (pin->ops->disable_irq && irq_enabled) + pin->ops->disable_irq(adap); + hrtimer_cancel(&pin->timer); + cec_pin_read(pin); + cec_pin_to_idle(pin); + pin->state = CEC_ST_OFF; return 0; } @@ -1129,13 +1143,7 @@ static int cec_pin_adap_enable(struct cec_adapter *adap, bool enable) hrtimer_start(&pin->timer, ns_to_ktime(0), HRTIMER_MODE_REL); } else { - if (pin->ops->disable_irq) - pin->ops->disable_irq(adap); - hrtimer_cancel(&pin->timer); kthread_stop(pin->kthread); - cec_pin_read(pin); - cec_pin_to_idle(pin); - pin->state = CEC_ST_OFF; } return 0; } @@ -1156,11 +1164,8 @@ void cec_pin_start_timer(struct cec_pin *pin) if (pin->state != CEC_ST_RX_IRQ) return; - atomic_set(&pin->work_irq_change, CEC_PIN_IRQ_UNCHANGED); - pin->ops->disable_irq(pin->adap); - cec_pin_high(pin); - cec_pin_to_idle(pin); - hrtimer_start(&pin->timer, ns_to_ktime(0), HRTIMER_MODE_REL); + atomic_set(&pin->work_irq_change, CEC_PIN_IRQ_DISABLE); + wake_up_interruptible(&pin->kthread_waitq); } static int cec_pin_adap_transmit(struct cec_adapter *adap, u8 attempts,

3 years

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror December 2021