August 2020 - Linux-stable-mirror

Re: [PATCH 3/9] crypto: caam/qi2 - add fallback for XTS with more than 8B IV

by Sasha Levin

Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: 226853ac3ebe ("crypto: caam/qi2 - add skcipher algorithms"). The bot has tested the following trees: v5.8.1, v5.7.15, v5.4.58. v5.8.1: Failed to apply! Possible dependencies: 528f776df67c ("crypto: qat - allow xts requests not multiple of block") a85211f36f3d ("crypto: qat - fallback for xts with 192 bit keys") b185a68710e0 ("crypto: qat - validate xts key") b8aa7dc5c753 ("crypto: drivers - set the flag CRYPTO_ALG_ALLOCATES_MEMORY") da6a66853a38 ("crypto: caam - silence .setkey in case of bad key length") v5.7.15: Failed to apply! Possible dependencies: 528f776df67c ("crypto: qat - allow xts requests not multiple of block") a85211f36f3d ("crypto: qat - fallback for xts with 192 bit keys") b185a68710e0 ("crypto: qat - validate xts key") b8aa7dc5c753 ("crypto: drivers - set the flag CRYPTO_ALG_ALLOCATES_MEMORY") da6a66853a38 ("crypto: caam - silence .setkey in case of bad key length") v5.4.58: Failed to apply! Possible dependencies: 64db5e7439fb ("crypto: sparc/aes - convert to skcipher API") 66d7fb94e4ff ("crypto: blake2s - generic C library implementation and selftest") 674f368a952c ("crypto: remove CRYPTO_TFM_RES_BAD_KEY_LEN") 746b2e024c67 ("crypto: lib - tidy up lib/crypto Kconfig and Makefile") 7988fb2c03c8 ("crypto: s390/aes - convert to skcipher API") 7f725f41f627 ("crypto: powerpc - convert SPE AES algorithms to skcipher API") 7f9b0880925f ("crypto: blake2s - implement generic shash driver") 91d689337fe8 ("crypto: blake2b - add blake2b generic implementation") b4d0c0aad57a ("crypto: arm - use Kconfig based compiler checks for crypto opcodes") b95bba5d0114 ("crypto: skcipher - rename the crypto_blkcipher module and kconfig option") d00c06398154 ("crypto: s390/paes - convert to skcipher API") da6a66853a38 ("crypto: caam - silence .setkey in case of bad key length") ed0356eda153 ("crypto: blake2s - x86_64 SIMD implementation") NOTE: The patch will not be queued to stable trees until it is upstream. How should we proceed with this patch? -- Thanks Sasha

4 years, 4 months

1
0
0 0

Re: [PATCH 2/9] crypto: caam/qi - add fallback for XTS with more than 8B IV

by Sasha Levin

Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: b189817cf789 ("crypto: caam/qi - add ablkcipher and authenc algorithms"). The bot has tested the following trees: v5.8.1, v5.7.15, v5.4.58, v4.19.139, v4.14.193. v5.8.1: Failed to apply! Possible dependencies: 528f776df67c ("crypto: qat - allow xts requests not multiple of block") a85211f36f3d ("crypto: qat - fallback for xts with 192 bit keys") b185a68710e0 ("crypto: qat - validate xts key") b8aa7dc5c753 ("crypto: drivers - set the flag CRYPTO_ALG_ALLOCATES_MEMORY") da6a66853a38 ("crypto: caam - silence .setkey in case of bad key length") v5.7.15: Failed to apply! Possible dependencies: 528f776df67c ("crypto: qat - allow xts requests not multiple of block") a85211f36f3d ("crypto: qat - fallback for xts with 192 bit keys") b185a68710e0 ("crypto: qat - validate xts key") b8aa7dc5c753 ("crypto: drivers - set the flag CRYPTO_ALG_ALLOCATES_MEMORY") da6a66853a38 ("crypto: caam - silence .setkey in case of bad key length") v5.4.58: Failed to apply! Possible dependencies: 64db5e7439fb ("crypto: sparc/aes - convert to skcipher API") 66d7fb94e4ff ("crypto: blake2s - generic C library implementation and selftest") 674f368a952c ("crypto: remove CRYPTO_TFM_RES_BAD_KEY_LEN") 746b2e024c67 ("crypto: lib - tidy up lib/crypto Kconfig and Makefile") 7988fb2c03c8 ("crypto: s390/aes - convert to skcipher API") 7f725f41f627 ("crypto: powerpc - convert SPE AES algorithms to skcipher API") 7f9b0880925f ("crypto: blake2s - implement generic shash driver") 91d689337fe8 ("crypto: blake2b - add blake2b generic implementation") b4d0c0aad57a ("crypto: arm - use Kconfig based compiler checks for crypto opcodes") b95bba5d0114 ("crypto: skcipher - rename the crypto_blkcipher module and kconfig option") d00c06398154 ("crypto: s390/paes - convert to skcipher API") da6a66853a38 ("crypto: caam - silence .setkey in case of bad key length") ed0356eda153 ("crypto: blake2s - x86_64 SIMD implementation") v4.19.139: Failed to apply! Possible dependencies: 0a5dff9882e5 ("crypto: arm/ghash - provide a synchronous version") 1ca1b917940c ("crypto: chacha20-generic - refactor to allow varying number of rounds") 5ca7badb1f62 ("crypto: caam/jr - ablkcipher -> skcipher conversion") 674f368a952c ("crypto: remove CRYPTO_TFM_RES_BAD_KEY_LEN") 8a5a79d5556b ("crypto: x86/chacha20 - Add a 4-block AVX2 variant") 99680c5e9182 ("crypto: arm - convert to use crypto_simd_usable()") 9b17608f15b9 ("crypto: x86/chacha20 - Use larger block functions more aggressively") 9dbe3072c6b1 ("crypto: caam/qi - ablkcipher -> skcipher conversion") a5dd97f86211 ("crypto: x86/chacha20 - Add a 2-block AVX2 variant") aec48adce85d ("crypto: caam/qi - remove ablkcipher IV generation") c3b734dd325d ("crypto: x86/chacha20 - Support partial lengths in 8-block AVX2 variant") cf5448b5c3d8 ("crypto: caam/jr - remove ablkcipher IV generation") da6a66853a38 ("crypto: caam - silence .setkey in case of bad key length") db8e15a24957 ("crypto: x86/chacha20 - Support partial lengths in 4-block SSSE3 variant") e4e72063d3c0 ("crypto: x86/chacha20 - Support partial lengths in 1-block SSSE3 variant") v4.14.193: Failed to apply! Possible dependencies: 5ca7badb1f62 ("crypto: caam/jr - ablkcipher -> skcipher conversion") 662f70ede597 ("crypto: caam - remove needless ablkcipher key copy") 7e0880b9fbbe ("crypto: caam - add Derived Key Protocol (DKP) support") 87ec3a0b1c2d ("crypto: caam - prepare for gcm(aes) support over QI interface") 9dbe3072c6b1 ("crypto: caam/qi - ablkcipher -> skcipher conversion") cf5448b5c3d8 ("crypto: caam/jr - remove ablkcipher IV generation") NOTE: The patch will not be queued to stable trees until it is upstream. How should we proceed with this patch? -- Thanks Sasha

4 years, 4 months

1
0
0 0

[PATCH nf 1/2] nft_set_rbtree: Handle outcomes of tree rotations in overlap detection

by Stefano Brivio

Checks for partial overlaps on insertion assume that end elements are always descendant nodes of their corresponding start, because they are inserted later. However, this is not the case if a previous delete operation caused a tree rotation as part of rebalancing. Taking the issue reported by Andreas Fischer as an example, if we omit delete operations, the existing procedure works because, equivalently, we are inserting a start item with value 40 in the this region of the red-black tree with single-sized intervals: overlap flag 10 (start) / \ false 20 (start) / \ false 30 (start) / \ false 60 (start) / \ false 50 (end) / \ false 20 (end) / \ false 40 (start) if we now delete interval 30 - 30, the tree can be rearranged in a way similar to this (note the rotation involving 50 - 50): overlap flag 10 (start) / \ false 20 (start) / \ false 25 (start) / \ false 70 (start) / \ false 50 (end) / \ true (from rule a1.) 50 (start) / \ true 40 (start) and we traverse interval 50 - 50 from the opposite direction compared to what was expected. To deal with those cases, add a start-before-start rule, b4., that covers traversal of existing intervals from the right. We now need to restrict start-after-end rule b3. to cases where there are no occurring nodes between existing start and end elements, because addition of rule b4. isn't sufficient to ensure that the pre-existing end element we encounter while descending the tree corresponds to a start element of an interval that we already traversed entirely. Different types of overlap detection on trees with rotations resulting from re-balancing will be covered by nft test case sets/0044interval_overlap_1. Reported-by: Andreas Fischer <netfilter(a)d9c.eu> Bugzilla: https://bugzilla.netfilter.org/show_bug.cgi?id=1449 Cc: <stable(a)vger.kernel.org> # 5.6.x Fixes: 7c84d41416d8 ("netfilter: nft_set_rbtree: Detect partial overlaps on insertion") Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com> --- net/netfilter/nft_set_rbtree.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/net/netfilter/nft_set_rbtree.c b/net/netfilter/nft_set_rbtree.c index 4b2834fd17b2..27668f4e44ea 100644 --- a/net/netfilter/nft_set_rbtree.c +++ b/net/netfilter/nft_set_rbtree.c @@ -238,21 +238,27 @@ static int __nft_rbtree_insert(const struct net *net, const struct nft_set *set, * * b1. _ _ __>| !_ _ __| (insert end before existing start) * b2. _ _ ___| !_ _ _>| (insert end after existing start) - * b3. _ _ ___! >|_ _ __| (insert start after existing end) + * b3. _ _ ___! >|_ _ __| (insert start after existing end, as a leaf) + * '--' no nodes falling in this range + * b4. >|_ _ ! (insert start before existing start) * * Case a3. resolves to b3.: * - if the inserted start element is the leftmost, because the '0' * element in the tree serves as end element - * - otherwise, if an existing end is found. Note that end elements are - * always inserted after corresponding start elements. + * - otherwise, if an existing end is found immediately to the left. If + * there are existing nodes in between, we need to further descend the + * tree before we can conclude the new start isn't causing an overlap + * + * or to b4., which, preceded by a3., means we already traversed one or + * more existing intervals entirely, from the right. * * For a new, rightmost pair of elements, we'll hit cases b3. and b2., * in that order. * * The flag is also cleared in two special cases: * - * b4. |__ _ _!|<_ _ _ (insert start right before existing end) - * b5. |__ _ >|!__ _ _ (insert end right after existing start) + * b5. |__ _ _!|<_ _ _ (insert start right before existing end) + * b6. |__ _ >|!__ _ _ (insert end right after existing start) * * which always happen as last step and imply that no further * overlapping is possible. @@ -272,7 +278,7 @@ static int __nft_rbtree_insert(const struct net *net, const struct nft_set *set, if (nft_rbtree_interval_start(new)) { if (nft_rbtree_interval_end(rbe) && nft_set_elem_active(&rbe->ext, genmask) && - !nft_set_elem_expired(&rbe->ext)) + !nft_set_elem_expired(&rbe->ext) && !*p) overlap = false; } else { overlap = nft_rbtree_interval_end(rbe) && @@ -288,10 +294,9 @@ static int __nft_rbtree_insert(const struct net *net, const struct nft_set *set, nft_set_elem_active(&rbe->ext, genmask) && !nft_set_elem_expired(&rbe->ext); - } else if (nft_rbtree_interval_end(rbe) && - nft_set_elem_active(&rbe->ext, genmask) && + } else if (nft_set_elem_active(&rbe->ext, genmask) && !nft_set_elem_expired(&rbe->ext)) { - overlap = true; + overlap = nft_rbtree_interval_end(rbe); } } else { if (nft_rbtree_interval_end(rbe) && -- 2.28.0

4 years, 4 months

1
0
0 0

stable-rc/linux-5.4.y baseline: 139 runs, 1 regressions (v5.4.59-75-gbdc7345fed30)

by kernelci.org bot

stable-rc/linux-5.4.y baseline: 139 runs, 1 regressions (v5.4.59-75-gbdc7345fed30) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | results ----------------------+------+--------------+----------+-----------------+-------- at91-sama5d4_xplained | arm | lab-baylibre | gcc-8 | sama5_defconfig | 0/1 Details: https://kernelci.org/test/job/stable-rc/branch/linux-5.4.y/kernel/v5.4.59-7… Test: baseline Tree: stable-rc Branch: linux-5.4.y Describe: v5.4.59-75-gbdc7345fed30 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: bdc7345fed30e646d8df2dbb480b9f8b801fc784 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | results ----------------------+------+--------------+----------+-----------------+-------- at91-sama5d4_xplained | arm | lab-baylibre | gcc-8 | sama5_defconfig | 0/1 Details: https://kernelci.org/test/plan/id/5f3d5da475ecfef29ed99a39 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: sama5_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/linux-5.4.y/v5.4.59-75-gbdc7345fed3… HTML log: https://storage.kernelci.org//stable-rc/linux-5.4.y/v5.4.59-75-gbdc7345fed3… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05/armel/basel… * baseline.login: https://kernelci.org/test/case/id/5f3d5da475ecfef29ed99a3a failing since 129 days (last pass: v5.4.30-54-g6f04e8ca5355, first fail: v5.4.30-81-gf163418797b9)

4 years, 4 months

1
0
0 0

stable-rc/linux-5.7.y baseline: 195 runs, 1 regressions (v5.7.16-99-gc5aad81e7f2d)

by kernelci.org bot

stable-rc/linux-5.7.y baseline: 195 runs, 1 regressions (v5.7.16-99-gc5aad81e7f2d) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | results ----------------------+------+--------------+----------+-----------------+-------- at91-sama5d4_xplained | arm | lab-baylibre | gcc-8 | sama5_defconfig | 0/1 Details: https://kernelci.org/test/job/stable-rc/branch/linux-5.7.y/kernel/v5.7.16-9… Test: baseline Tree: stable-rc Branch: linux-5.7.y Describe: v5.7.16-99-gc5aad81e7f2d URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: c5aad81e7f2df22cbf7b4e5305b8c372d7f8ac4c Test Regressions ---------------- platform | arch | lab | compiler | defconfig | results ----------------------+------+--------------+----------+-----------------+-------- at91-sama5d4_xplained | arm | lab-baylibre | gcc-8 | sama5_defconfig | 0/1 Details: https://kernelci.org/test/plan/id/5f3d58541e79dfd1d6d99a47 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: sama5_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/linux-5.7.y/v5.7.16-99-gc5aad81e7f2… HTML log: https://storage.kernelci.org//stable-rc/linux-5.7.y/v5.7.16-99-gc5aad81e7f2… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05/armel/basel… * baseline.login: https://kernelci.org/test/case/id/5f3d58541e79dfd1d6d99a48 failing since 34 days (last pass: v5.7.8-167-gc2fb28a4b6e4, first fail: v5.7.9)

4 years, 4 months

1
0
0 0

stable-rc/linux-4.4.y baseline: 114 runs, 2 regressions (v4.4.232-134-g2e631f07fd55)

by kernelci.org bot

stable-rc/linux-4.4.y baseline: 114 runs, 2 regressions (v4.4.232-134-g2e631f07fd55) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | results ----------------+------+--------------+----------+---------------------+-------- omap3-beagle-xm | arm | lab-baylibre | gcc-8 | omap2plus_defconfig | 1/4 Details: https://kernelci.org/test/job/stable-rc/branch/linux-4.4.y/kernel/v4.4.232-… Test: baseline Tree: stable-rc Branch: linux-4.4.y Describe: v4.4.232-134-g2e631f07fd55 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 2e631f07fd55892e1fababf1f5c72a56679bbf40 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | results ----------------+------+--------------+----------+---------------------+-------- omap3-beagle-xm | arm | lab-baylibre | gcc-8 | omap2plus_defconfig | 1/4 Details: https://kernelci.org/test/plan/id/5f3d4e5282db7b7651d99a42 Results: 1 PASS, 2 FAIL, 1 SKIP Full config: omap2plus_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/linux-4.4.y/v4.4.232-134-g2e631f07f… HTML log: https://storage.kernelci.org//stable-rc/linux-4.4.y/v4.4.232-134-g2e631f07f… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05/armel/basel… * baseline.dmesg.crit: https://kernelci.org/test/case/id/5f3d4e5282db7b7651d99a44 failing since 2 days (last pass: v4.4.232, first fail: v4.4.232-120-g11806ba5e43a) 1 lines 2020-08-19 16:07:40.302000 / 2020-08-19 16:07:40.412000 # # 2020-08-19 16:07:40.414000 2020-08-19 16:07:40.516000 / # #export SHELL=/bin/sh 2020-08-19 16:07:40.518000 2020-08-19 16:07:40.620000 / # export SHELL=/bin/sh. /lava-6716/environment 2020-08-19 16:07:40.621000 2020-08-19 16:07:40.723000 / # . /lava-6716/environment/lava-6716/bin/lava-test-runner /lava-6716/0 2020-08-19 16:07:40.726000 2020-08-19 16:07:40.727000 / # /lava-6716/bin/lava-test-runner /lava-6716/0 ... (8 line(s) more) * baseline.dmesg.emerg: https://kernelci.org/test/case/id/5f3d4e5282db7b7651d99a46 failing since 2 days (last pass: v4.4.232, first fail: v4.4.232-120-g11806ba5e43a) 28 lines 2020-08-19 16:07:41.211000 kern :emerg : Internal error: Oops - BUG: 0 [#1] SMP ARM 2020-08-19 16:07:41.217000 kern :emerg : Process udevd (pid: 113, stack limit = 0xcba14218) 2020-08-19 16:07:41.221000 kern :emerg : Stack: (0xcba15d10 to 0xcba16000) 2020-08-19 16:07:41.229000 kern :emerg : 5d00: bf02b8fc bf010b84 cb991810 bf02b988 2020-08-19 16:07:41.238000 kern :emerg : 5d20: cb991810 bf2240a8 00000002 cb89b010 cb991810 bf23cb54 cbc10270 cbc10270 2020-08-19 16:07:41.246000 kern :emerg : 5d40: 00000000 00000000 ce228930 c01fafd0 ce228930 ce228930 c085646c 00000001 2020-08-19 16:07:41.254000 kern :emerg : 5d60: ce228930 cbc10270 cbc10330 00000000 ce228930 c085646c 00000001 c095f2c0 2020-08-19 16:07:41.262000 kern :emerg : 5d80: ffffffed bf240ff4 fffffdfb 00000021 00000001 c00ce2e4 bf241188 c0407550 2020-08-19 16:07:41.270000 kern :emerg : 5da0: c095f2c0 c120aa70 bf240ff4 00000000 00000021 c0405a24 c095f2c0 c095f2f4 2020-08-19 16:07:41.279000 kern :emerg : 5dc0: bf240ff4 00000000 00000000 c0405bcc 00000000 bf240ff4 c0405b40 c0403ef0 ... (18 line(s) more)

4 years, 4 months

1
0
0 0

+ mm-thp-swap-fix-allocating-cluster-for-swapfile-by-mistake.patch added to -mm tree

by Andrew Morton

The patch titled Subject: mm, THP, swap: fix allocating cluster for swapfile by mistake has been added to the -mm tree. Its filename is mm-thp-swap-fix-allocating-cluster-for-swapfile-by-mistake.patch This patch should soon appear at https://ozlabs.org/~akpm/mmots/broken-out/mm-thp-swap-fix-allocating-cluste… and later at https://ozlabs.org/~akpm/mmotm/broken-out/mm-thp-swap-fix-allocating-cluste… Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Gao Xiang <hsiangkao(a)redhat.com> Subject: mm, THP, swap: fix allocating cluster for swapfile by mistake SWP_FS doesn't mean the device is file-backed swap device, which just means each writeback request should go through fs by DIO. Or it'll just use extents added by .swap_activate(), but it also works as file-backed swap device. So in order to achieve the goal of the original patch, SWP_BLKDEV should be used instead. FS corruption can be observed with SSD device + XFS + fragmented swapfile due to CONFIG_THP_SWAP=y. I reproduced the issue with the following details: Environment: QEMU + upstream kernel + buildroot + NVMe (2 GB) Kernel config: CONFIG_BLK_DEV_NVME=y CONFIG_THP_SWAP=y Some reproducable steps: mkfs.xfs -f /dev/nvme0n1 mkdir /tmp/mnt mount /dev/nvme0n1 /tmp/mnt bs="32k" sz="1024m" # doesn't matter too much, I also tried 16m xfs_io -f -c "pwrite -R -b $bs 0 $sz" -c "fdatasync" /tmp/mnt/sw xfs_io -f -c "pwrite -R -b $bs 0 $sz" -c "fdatasync" /tmp/mnt/sw xfs_io -f -c "pwrite -R -b $bs 0 $sz" -c "fdatasync" /tmp/mnt/sw xfs_io -f -c "pwrite -F -S 0 -b $bs 0 $sz" -c "fdatasync" /tmp/mnt/sw xfs_io -f -c "pwrite -R -b $bs 0 $sz" -c "fsync" /tmp/mnt/sw mkswap /tmp/mnt/sw swapon /tmp/mnt/sw stress --vm 2 --vm-bytes 600M # doesn't matter too much as well Symptoms: - FS corruption (e.g. checksum failure) - memory corruption at: 0xd2808010 - segfault Link: https://lkml.kernel.org/r/20200819195613.24269-1-hsiangkao@redhat.com Fixes: f0eea189e8e9 ("mm, THP, swap: Don't allocate huge cluster for file backed swap device") Fixes: 38d8b4e6bdc8 ("mm, THP, swap: delay splitting THP during swap out") Signed-off-by: Gao Xiang <hsiangkao(a)redhat.com> Cc: "Huang, Ying" <ying.huang(a)intel.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/swapfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/swapfile.c~mm-thp-swap-fix-allocating-cluster-for-swapfile-by-mistake +++ a/mm/swapfile.c @@ -1078,7 +1078,7 @@ start_over: goto nextsi; } if (size == SWAPFILE_CLUSTER) { - if (!(si->flags & SWP_FS)) + if (si->flags & SWP_BLKDEV) n_ret = swap_alloc_cluster(si, swp_entries); } else n_ret = scan_swap_map_slots(si, SWAP_HAS_CACHE, _ Patches currently in -mm which might be from hsiangkao(a)redhat.com are mm-thp-swap-fix-allocating-cluster-for-swapfile-by-mistake.patch

4 years, 4 months

1
0
0 0

[PATCH 1/2] riscv: ptrace: Use the correct API for `fcsr' access

by Maciej W. Rozycki

Adjust the calls to `user_regset_copyout' and `user_regset_copyin' in `riscv_fpr_get' and `riscv_fpr_set' respectively so as to use @start_pos and @end_pos according to API documentation in <linux/regset.h>, that is to point at the beginning and the end respectively of the data chunk to be copied. Update @data accordingly, also for the first call, to make it clear which structure member is accessed. We currently have @start_pos fixed at 0 across all calls, which works as a result of the implementation, in particular because we have no padding between the FP general registers and the FP control and status register, but appears not to have been the intent of the API and is not what other ports do, requiring one to study the copy handlers to understand what is going on here. Signed-off-by: Maciej W. Rozycki <macro(a)wdc.com> Fixes: b8c8a9590e4f ("RISC-V: Add FP register ptrace support for gdb.") Cc: stable(a)vger.kernel.org # 4.20+ --- arch/riscv/kernel/ptrace.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) linux-riscv-ptrace-fcsr.diff Index: linux-hv/arch/riscv/kernel/ptrace.c =================================================================== --- linux-hv.orig/arch/riscv/kernel/ptrace.c +++ linux-hv/arch/riscv/kernel/ptrace.c @@ -61,10 +61,13 @@ static int riscv_fpr_get(struct task_str int ret; struct __riscv_d_ext_state *fstate = &target->thread.fstate; - ret = user_regset_copyout(&pos, &count, &kbuf, &ubuf, fstate, 0, + ret = user_regset_copyout(&pos, &count, &kbuf, &ubuf, &fstate->f, 0, offsetof(struct __riscv_d_ext_state, fcsr)); if (!ret) { - ret = user_regset_copyout(&pos, &count, &kbuf, &ubuf, fstate, 0, + ret = user_regset_copyout(&pos, &count, &kbuf, &ubuf, + &fstate->fcsr, + offsetof(struct __riscv_d_ext_state, + fcsr), offsetof(struct __riscv_d_ext_state, fcsr) + sizeof(fstate->fcsr)); } @@ -80,10 +83,13 @@ static int riscv_fpr_set(struct task_str int ret; struct __riscv_d_ext_state *fstate = &target->thread.fstate; - ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, fstate, 0, + ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, &fstate->f, 0, offsetof(struct __riscv_d_ext_state, fcsr)); if (!ret) { - ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, fstate, 0, + ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, + &fstate->fcsr, + offsetof(struct __riscv_d_ext_state, + fcsr), offsetof(struct __riscv_d_ext_state, fcsr) + sizeof(fstate->fcsr)); }

4 years, 4 months

3
8
0 0

stable-rc/linux-4.14.y baseline: 154 runs, 2 regressions (v4.14.193-195-gf27c69846742)

by kernelci.org bot

stable-rc/linux-4.14.y baseline: 154 runs, 2 regressions (v4.14.193-195-gf27c69846742) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | results ----------------------+-------+--------------+----------+-----------------+-------- at91-sama5d4_xplained | arm | lab-baylibre | gcc-8 | sama5_defconfig | 0/1 meson-gxbb-p200 | arm64 | lab-baylibre | gcc-8 | defconfig | 0/1 Details: https://kernelci.org/test/job/stable-rc/branch/linux-4.14.y/kernel/v4.14.19… Test: baseline Tree: stable-rc Branch: linux-4.14.y Describe: v4.14.193-195-gf27c69846742 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: f27c69846742bc00deca1ed0f6a9d4fb99519149 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | results ----------------------+-------+--------------+----------+-----------------+-------- at91-sama5d4_xplained | arm | lab-baylibre | gcc-8 | sama5_defconfig | 0/1 Details: https://kernelci.org/test/plan/id/5f3d4bcc3e3bbc2c51d99a5f Results: 0 PASS, 1 FAIL, 0 SKIP Full config: sama5_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/linux-4.14.y/v4.14.193-195-gf27c698… HTML log: https://storage.kernelci.org//stable-rc/linux-4.14.y/v4.14.193-195-gf27c698… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05/armel/basel… * baseline.login: https://kernelci.org/test/case/id/5f3d4bcc3e3bbc2c51d99a60 failing since 26 days (last pass: v4.14.188-126-g5b1e982af0f8, first fail: v4.14.189) platform | arch | lab | compiler | defconfig | results ----------------------+-------+--------------+----------+-----------------+-------- meson-gxbb-p200 | arm64 | lab-baylibre | gcc-8 | defconfig | 0/1 Details: https://kernelci.org/test/plan/id/5f3d4bed4a3b68b88ed99a3c Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-8 (aarch64-linux-gnu-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/linux-4.14.y/v4.14.193-195-gf27c698… HTML log: https://storage.kernelci.org//stable-rc/linux-4.14.y/v4.14.193-195-gf27c698… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05/arm64/basel… * baseline.login: https://kernelci.org/test/case/id/5f3d4bed4a3b68b88ed99a3d failing since 141 days (last pass: v4.14.172-114-g734382e2d26e, first fail: v4.14.174-131-g234ce78cac23)

4 years, 4 months

1
0
0 0

NETDEV WATCHDOG: WARNING: at net/sched/sch_generic.c:442 dev_watchdog

by Naresh Kamboju

kernel warning noticed on x86_64 while running LTP tracing ftrace-stress-test case. started noticing on the stable-rc linux-5.8.y branch. This device booted with KASAN config and DYNAMIC tracing configs and more. This reported issue is not easily reproducible. metadata: git branch: linux-5.8.y git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git commit: ad8c735b1497520df959f675718f39dca8cb8019 git describe: v5.8.2 make_kernelversion: 5.8.2 kernel-config: https://builds.tuxbuild.com/bOz0eAwkcraRiWALTW9D3Q/kernel.config [ 88.139387] Scheduler tracepoints stat_sleep, stat_iowait, stat_blocked and stat_runtime require the kernel parameter schedstats=enable or kernel.sched_schedstats=1 [ 88.139387] Scheduler tracepoints stat_sleep, stat_iowait, stat_blocked and stat_runtime require the kernel parameter schedstats=enable or kernel.sched_schedstats=1 [ 107.507991] ------------[ cut here ]------------ [ 107.513103] NETDEV WATCHDOG: eth0 (igb): transmit queue 2 timed out [ 107.519973] WARNING: CPU: 1 PID: 331 at net/sched/sch_generic.c:442 dev_watchdog+0x4c7/0x4d0 [ 107.528907] Modules linked in: x86_pkg_temp_thermal [ 107.534541] CPU: 1 PID: 331 Comm: systemd-journal Not tainted 5.8.2 #1 [ 107.541480] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.2 05/23/2018 [ 107.549314] RIP: 0010:dev_watchdog+0x4c7/0x4d0 [ 107.554226] Code: ff ff 48 8b 5d c8 c6 05 6d f7 94 01 01 48 89 df e8 9e b4 f8 ff 44 89 e9 48 89 de 48 c7 c7 20 49 51 9c 48 89 c2 e8 91 7e e9 fe <0f> 0b e9 03 ff ff ff 66 90 e8 9b 23 db fe 55 48 89 e5 41 57 41 56 [ 107.573476] RSP: 0018:ffff888230889d88 EFLAGS: 00010286 [ 107.579264] RAX: 0000000000000000 RBX: ffff88822bbb0000 RCX: dffffc0000000000 [ 107.586928] RDX: 1ffff11046114c99 RSI: ffffffff9a7e4dbe RDI: ffffffff9b7a6da7 [ 107.594473] RBP: ffff888230889de0 R08: ffffffff9a7e4dd3 R09: ffffed1044de2529 [ 107.602101] R10: ffff888226f12943 R11: ffffed1044de2528 R12: ffff88822bbb0440 [ 107.609648] R13: 0000000000000002 R14: ffff88822bbb0388 R15: ffff88822bbb0380 [ 107.617197] FS: 00007f8b471bb480(0000) GS:ffff888230880000(0000) knlGS:0000000000000000 [ 107.625698] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 107.631944] CR2: 0000000000000008 CR3: 0000000226a64001 CR4: 00000000003606e0 [ 107.639496] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 107.647092] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 107.654661] Call Trace: [ 107.657735] <IRQ> [ 107.663155] ? ftrace_graph_caller+0xc0/0xc0 [ 107.667929] call_timer_fn+0x3b/0x1b0 [ 107.672238] ? netif_carrier_off+0x70/0x70 [ 107.677771] ? netif_carrier_off+0x70/0x70 [ 107.682656] ? ftrace_graph_caller+0xc0/0xc0 [ 107.687379] run_timer_softirq+0x3e8/0xa10 [ 107.694653] ? call_timer_fn+0x1b0/0x1b0 [ 107.699382] ? trace_event_raw_event_softirq+0xdd/0x150 [ 107.706768] ? ring_buffer_unlock_commit+0xf5/0x210 [ 107.712213] ? call_timer_fn+0x1b0/0x1b0 [ 107.716625] ? __do_softirq+0x155/0x467 Aug 22 04:21:44 intel-corei7-64 [ 107.721972] ? run_timer_softirq+0x5/0xa10 user.warn kernel[ 107.727997] ? asm_call_on_stack+0x12/0x20 : [ 107.507991] ------------[ c[ 107.735546] ? ftrace_graph_caller+0xc0/0xc0 ut here ]-------[ 107.740453] __do_softirq+0x160/0x467 ----- [ 107.745737] ? hrtimer_interrupt+0x5/0x340 [ 107.753961] asm_call_on_stack+0x12/0x20 [ 107.758672] </IRQ> [ 107.761555] do_softirq_own_stack+0x3f/0x50 [ 107.766521] ? ftrace_graph_caller+0xc0/0xc0 [ 107.771246] irq_exit_rcu+0xff/0x110 [ 107.776116] ? ftrace_graph_caller+0xc0/0xc0 [ 107.780808] sysvec_apic_timer_interrupt+0x38/0x90 [ 107.786971] asm_sysvec_apic_timer_interrupt+0x12/0x20 [ 107.792598] RIP: 0010:profile_graph_return+0x111/0x1d0 [ 107.798204] Code: 75 e1 48 8b 45 d0 f6 c4 02 75 16 50 9d e8 f7 ff 02 00 48 83 c4 10 5b 41 5c 41 5d 41 5e 41 5f 5d c3 e8 c3 fb 02 00 ff 75 d0 9d <48> 83 c4 10 5b 41 5c 41 5d 41 5e 41 5f 5d c3 48 8d 7b 20 e8 77 78 [ 107.817416] RSP: 0018:ffff8882269b73a0 EFLAGS: 00000286 [ 107.823201] RAX: ffff8882269b73d8 RBX: ffff8882269b7428 RCX: dffffc0000000000 [ 107.830785] RDX: dffffc0000000000 RSI: ffffffff9a7e4dbe RDI: ffffffff9a7a955d [ 107.838411] RBP: ffff8882269b73d8 R08: ffffffff9a7e4dd3 R09: ffffed1044de2529 [ 107.846072] R10: ffff888226f12943 R11: ffffed1044de2528 R12: ffff8882308a67c0 [ 107.853621] R13: ffff888226f12930 R14: ffff8882308a67c8 R15: ffff88822c7e4000 [ 107.863449] ? ftrace_return_to_handler+0x1a3/0x230 Aug 22 04:21:44 [ 107.869545] ? ftrace_return_to_handler+0x18e/0x230 intel-corei7-64 [ 107.875178] ? profile_graph_return+0x10d/0x1d0 user.info kernel: [ 107.513103][ 107.882521] ? unwind_dump+0x100/0x100 NETDEV WATCHDOG: eth0 (igb): tr[ 107.889054] ? unwind_next_frame.part.0+0xe0/0x360 ansmit queue 2 t[ 107.895638] ftrace_return_to_handler+0x18e/0x230 imed out [ 107.902594] ? function_graph_enter+0x2d0/0x2d0 [ 107.907616] ? unwind_next_frame+0x23/0x30 [ 107.912633] ? unwind_dump+0x100/0x100 [ 107.919304] ? update_stack_state+0x1d4/0x290 [ 107.926042] return_to_handler+0x15/0x30 [ 107.931071] ? ftrace_graph_caller+0xc0/0xc0 [ 107.935763] ? unwind_next_frame.part.0+0xe0/0x360 [ 107.941175] ? unwind_next_frame.part.0+0x5/0x360 [ 107.947344] ? profile_setup.cold+0x9b/0x9b [ 107.953253] ? ftrace_graph_caller+0xc0/0xc0 [ 107.958020] unwind_next_frame+0x23/0x30 [ 107.963015] ? ftrace_graph_caller+0xc0/0xc0 [ 107.967701] arch_stack_walk+0x8c/0xf0 [ 107.974194] ? vfs_open+0x58/0x60 [ 107.979965] ? ftrace_graph_caller+0xc0/0xc0 [ 107.984652] stack_trace_save+0x94/0xc0 [ 107.989565] ? stack_trace_consume_entry+0x90/0x90 [ 107.995792] ? stack_trace_save+0x5/0xc0 [ 108.000536] ? trace_hardirqs_on+0x3a/0x120 [ 108.005959] ? stack_trace_save+0x5/0xc0 [ 108.007220] ? ftrace_graph_caller+0xc0/0xc0 [ 108.007464] save_stack+0x23/0x50 [ 108.007909] ? save_stack+0x23/0x50 [ 108.008225] ? __kasan_kmalloc.constprop.0+0xcf/0xe0 [ 108.008517] ? kasan_kmalloc+0x9/0x10 Aug 22 04:21:44 [ 108.008809] ? kmem_cache_alloc_trace+0xf6/0x270 intel-corei7-64 [ 108.009207] ? single_open+0x3b/0xf0 user.warn kernel[ 108.044913] ? proc_single_open+0x1b/0x20 : [ 107.519973][ 108.050304] ? do_dentry_open+0x2a6/0x6f0 WARNING: CPU: 1 PID: 331 at net[ 108.057406] ? __kasan_check_read+0x11/0x20 /sched/sch_gener[ 108.063044] ? rb_commit+0xef/0x630 ic.c:442 dev_watchdog+0x4c7/0x4d0 [ 108.070497] ? __kasan_check_read+0x11/0x20 [ 108.075391] ? ring_buffer_unlock_commit+0x102/0x210 [ 108.082301] ? trace_buffer_unlock_commit_regs+0x171/0x1d0 [ 108.090197] ? trace_event_buffer_commit+0xfb/0x3d0 [ 108.097668] ? ftrace_graph_caller+0xc0/0xc0 [ 108.102681] ? trace_event_raw_event_kmem_alloc+0x7c/0xe0 [ 108.109083] ? kasan_unpoison_shadow+0x38/0x50 [ 108.114780] __kasan_kmalloc.constprop.0+0xcf/0xe0 [ 108.121927] kasan_kmalloc+0x9/0x10 [ 108.126280] kmem_cache_alloc_trace+0xf6/0x270 [ 108.131499] ? ftrace_graph_caller+0xc0/0xc0 [ 108.136690] ? proc_cwd_link+0x140/0x140 [ 108.141797] ? ftrace_graph_caller+0xc0/0xc0 [ 108.146568] single_open+0x3b/0xf0 [ 108.151695] ? ftrace_graph_caller+0xc0/0xc0 [ 108.156386] proc_single_open+0x1b/0x20 [ 108.161083] ? ftrace_graph_caller+0xc0/0xc0 [ 108.165772] do_dentry_open+0x2a6/0x6f0 [ 108.170282] ? vfs_open+0x4a/0x60 [ 108.175328] ? sched_open+0x20/0x20 [ 108.181406] ? ftrace_graph_caller+0xc0/0xc0 [ 108.186131] vfs_open+0x58/0x60 [ 108.190568] ? ftrace_graph_caller+0xc0/0xc0 [ 108.195258] path_openat+0x153b/0x1ab0 [ 108.202219] ? __srcu_read_lock+0x50/0x50 [ 108.209143] ? vfs_mkobj+0x270/0x270 [ 108.210188] ? ftrace_graph_caller+0x81/0xc0 [ 108.210721] ? ftrace_return_to_handler+0x1a3/0x230 [ 108.212065] ? function_graph_enter+0x2d0/0x2d0 [ 108.212812] ? do_filp_open+0x91/0x1b0 [ 108.213426] ? do_filp_open+0x107/0x1b0 [ 108.214662] ? path_openat+0x5/0x1ab0 [ 108.217377] ? ftrace_graph_caller+0xc0/0xc0 [ 108.217621] do_filp_open+0x124/0x1b0 [ 108.219009] ? may_open_dev+0x50/0x50 [ 108.222371] ? prepare_ftrace_return+0x7b/0xa0 [ 108.224144] ? ftrace_graph_caller+0x81/0xc0 [ 108.224461] ? function_graph_enter+0x2d0/0x2d0 [ 108.226641] ? ftrace_return_to_handler+0x1a3/0x230 [ 108.228414] ? do_filp_open+0x5/0x1b0 [ 108.231132] ? ftrace_graph_caller+0xc0/0xc0 [ 108.231376] do_sys_openat2+0x31d/0x410 [ 108.233412] ? file_open_root+0x210/0x210 [ 108.235616] ? do_sys_openat2+0x5/0x410 [ 108.236230] ? ftrace_graph_caller+0x81/0xc0 [ 108.238435] ? ftrace_graph_caller+0xc0/0xc0 [ 108.238678] do_sys_open+0x99/0xf0 [ 108.239555] ? filp_open+0x60/0x60 [ 108.240816] ? do_sys_open+0x5/0xf0 [ 108.242372] ? do_sys_open+0x5/0xf0 [ 108.243632] ? ftrace_graph_caller+0xc0/0xc0 [ 108.243959] __x64_sys_openat+0x59/0x70 [ 108.245508] ? ftrace_graph_caller+0xc0/0xc0 [ 108.245752] do_syscall_64+0x51/0x90 [ 108.246951] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 108.247244] RIP: 0033:0x7f8b46680d20 [ 108.247512] Code: 25 00 00 41 00 3d 00 00 41 00 74 36 48 8d 05 ef eb 2c 00 8b 00 85 c0 75 5a 89 f2 b8 01 01 00 00 48 89 fe bf 9c ff ff ff 0f 05 <48> 3d 00 f0 ff ff 0f 87 84 00 00 00 48 83 c4 68 5b 5d c3 0f 1f 44 [ 108.247777] RSP: 002b:00007ffd2d0f21d0 EFLAGS: 00000246 ORIG_RAX: 0000000000000101 [ 108.248248] RAX: ffffffffffffffda RBX: 00005635a1dcc260 RCX: 00007f8b46680d20 [ 108.248466] RDX: 0000000000080000 RSI: 00007ffd2d0f2380 RDI: 00000000ffffff9c [ 108.248684] RBP: 0000000000000008 R08: 0000000000000008 R09: 0000000000000001 [ 108.248984] R10: 0000000000000000 R11: 0000000000000246 R12: 00007f8b46cb2977 [ 108.249226] R13: 00007f8b46cb2977 R14: 0000000000000001 R15: 0000000000000000 [ 108.254504] ---[ end trace 743b6da37b9f0ee8 ]--- full test log link, https://qa-reports.linaro.org/lkft/linux-stable-rc-5.8-oe/build/v5.8.2/test… Reported-by: Naresh Kamboju <naresh.kamboju(a)linaro.org> -- Linaro LKFT https://lkft.linaro.org

4 years, 4 months

3
3
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror August 2020