August 2020 - Linux-stable-mirror

[PATCH AUTOSEL 5.7 01/54] spi: stm32: clear only asserted irq flags on interrupt

by Sasha Levin

From: Tobias Schramm <t.schramm(a)manjaro.org> [ Upstream commit ae1ba50f1e706dfd7ce402ac52c1f1f10becad68 ] Previously the stm32h7 interrupt thread cleared all non-masked interrupts. If an interrupt was to occur during the handling of another interrupt its flag would be unset, resulting in a lost interrupt. This patches fixes the issue by clearing only the currently set interrupt flags. Signed-off-by: Tobias Schramm <t.schramm(a)manjaro.org> Link: https://lore.kernel.org/r/20200804195136.1485392-1-t.schramm@manjaro.org Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/spi/spi-stm32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c index 44ac6eb3298d4..ef3be03574e80 100644 --- a/drivers/spi/spi-stm32.c +++ b/drivers/spi/spi-stm32.c @@ -964,7 +964,7 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id) if (!spi->cur_usedma && (spi->rx_buf && (spi->rx_len > 0))) stm32h7_spi_read_rxfifo(spi, false); - writel_relaxed(mask, spi->base + STM32H7_SPI_IFCR); + writel_relaxed(sr & mask, spi->base + STM32H7_SPI_IFCR); spin_unlock_irqrestore(&spi->lock, flags); -- 2.25.1

4 years, 4 months

2
55
0 0

stable-rc/linux-4.14.y build: 201 builds: 0 failed, 201 passed, 66 warnings (v4.14.194-52-g376e60828efb)

by kernelci.org bot

stable-rc/linux-4.14.y build: 201 builds: 0 failed, 201 passed, 66 warnings (v4.14.194-52-g376e60828efb) Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.14.y/kernel/v4.14.194-5… Tree: stable-rc Branch: linux-4.14.y Git Describe: v4.14.194-52-g376e60828efb Git Commit: 376e60828efba537a502fdb54d35e2805852dbb4 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Built: 6 unique architectures Warnings Detected: arc: allnoconfig (gcc-8): 1 warning axs103_defconfig (gcc-8): 1 warning axs103_smp_defconfig (gcc-8): 1 warning haps_hs_defconfig (gcc-8): 1 warning haps_hs_smp_defconfig (gcc-8): 1 warning hsdk_defconfig (gcc-8): 1 warning nsim_hs_defconfig (gcc-8): 1 warning nsim_hs_smp_defconfig (gcc-8): 1 warning nsimosci_hs_defconfig (gcc-8): 1 warning nsimosci_hs_smp_defconfig (gcc-8): 1 warning tinyconfig (gcc-8): 1 warning vdk_hs38_defconfig (gcc-8): 1 warning vdk_hs38_smp_defconfig (gcc-8): 1 warning arm64: allnoconfig (gcc-8): 1 warning tinyconfig (gcc-8): 1 warning arm: allnoconfig (gcc-8): 1 warning am200epdkit_defconfig (gcc-8): 1 warning clps711x_defconfig (gcc-8): 1 warning cm_x2xx_defconfig (gcc-8): 1 warning colibri_pxa300_defconfig (gcc-8): 1 warning corgi_defconfig (gcc-8): 1 warning efm32_defconfig (gcc-8): 1 warning eseries_pxa_defconfig (gcc-8): 1 warning h5000_defconfig (gcc-8): 1 warning integrator_defconfig (gcc-8): 1 warning lpc32xx_defconfig (gcc-8): 1 warning lpd270_defconfig (gcc-8): 1 warning lubbock_defconfig (gcc-8): 1 warning magician_defconfig (gcc-8): 1 warning mainstone_defconfig (gcc-8): 1 warning multi_v4t_defconfig (gcc-8): 1 warning palmz72_defconfig (gcc-8): 1 warning pcm027_defconfig (gcc-8): 1 warning prima2_defconfig (gcc-8): 1 warning pxa168_defconfig (gcc-8): 1 warning pxa255-idp_defconfig (gcc-8): 1 warning pxa3xx_defconfig (gcc-8): 1 warning pxa910_defconfig (gcc-8): 1 warning raumfeld_defconfig (gcc-8): 1 warning s3c2410_defconfig (gcc-8): 1 warning s3c6400_defconfig (gcc-8): 1 warning s5pv210_defconfig (gcc-8): 1 warning spitz_defconfig (gcc-8): 1 warning stm32_defconfig (gcc-8): 1 warning tango4_defconfig (gcc-8): 1 warning tct_hammer_defconfig (gcc-8): 1 warning tinyconfig (gcc-8): 1 warning versatile_defconfig (gcc-8): 1 warning viper_defconfig (gcc-8): 1 warning vt8500_v6_v7_defconfig (gcc-8): 1 warning xcep_defconfig (gcc-8): 1 warning zeus_defconfig (gcc-8): 1 warning i386: mips: db1xxx_defconfig (gcc-8): 1 warning jmr3927_defconfig (gcc-8): 1 warning malta_defconfig (gcc-8): 1 warning malta_kvm_guest_defconfig (gcc-8): 1 warning malta_qemu_32r6_defconfig (gcc-8): 2 warnings maltaaprp_defconfig (gcc-8): 1 warning maltasmvp_defconfig (gcc-8): 1 warning maltasmvp_eva_defconfig (gcc-8): 1 warning maltaup_defconfig (gcc-8): 1 warning maltaup_xpa_defconfig (gcc-8): 1 warning pic32mzda_defconfig (gcc-8): 1 warning xilfpga_defconfig (gcc-8): 1 warning x86_64: tinyconfig (gcc-8): 1 warning Warnings summary: 64 /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] 1 {standard input}:29: Warning: macro instruction expanded into multiple instructions 1 .config:1028:warning: override: UNWINDER_GUESS changes choice state ================================================================================ Detailed per-defconfig build reports: -------------------------------------------------------------------------------- 32r2el_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- acs5k_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- acs5k_tiny_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- allnoconfig (arm64, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- allnoconfig (arc, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- allnoconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- allnoconfig (i386, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- allnoconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- allnoconfig (x86_64, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- am200epdkit_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- ar7_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- aspeed_g4_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- aspeed_g5_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- assabet_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- at91_dt_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- ath25_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- ath79_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- axm55xx_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- axs103_defconfig (arc, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- axs103_smp_defconfig (arc, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- badge4_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- bcm2835_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- bcm47xx_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- bcm63xx_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- bigsur_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- bmips_be_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- bmips_stb_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- capcella_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- cavium_octeon_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- cerfcube_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- ci20_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- clps711x_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- cm_x2xx_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- cm_x300_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- cns3420vb_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- cobalt_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- colibri_pxa270_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- colibri_pxa300_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- collie_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- corgi_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- davinci_all_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- db1xxx_defconfig (mips, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- decstation_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- defconfig (arm64, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- dove_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- e55_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- ebsa110_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- efm32_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- em_x270_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- ep93xx_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- eseries_pxa_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- exynos_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- ezx_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- footbridge_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- fuloong2e_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- gemini_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- gpr_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- h3600_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- h5000_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- hackkit_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- haps_hs_defconfig (arc, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- haps_hs_smp_defconfig (arc, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- hisi_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- hsdk_defconfig (arc, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- i386_defconfig (i386, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- imote2_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- imx_v4_v5_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- imx_v6_v7_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- integrator_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- iop13xx_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- iop32x_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- iop33x_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- ip22_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- ip27_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- ip28_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- ip32_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- ixp4xx_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- jazz_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- jmr3927_defconfig (mips, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- jornada720_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- keystone_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- ks8695_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- lart_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- lasat_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- lemote2f_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- loongson1b_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- loongson1c_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- loongson3_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- lpc18xx_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- lpc32xx_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- lpd270_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- lubbock_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- magician_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- mainstone_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- malta_defconfig (mips, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- malta_kvm_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- malta_kvm_guest_defconfig (mips, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- malta_qemu_32r6_defconfig (mips, gcc-8) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: {standard input}:29: Warning: macro instruction expanded into multiple instructions /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- maltaaprp_defconfig (mips, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- maltasmvp_defconfig (mips, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- maltasmvp_eva_defconfig (mips, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- maltaup_defconfig (mips, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- maltaup_xpa_defconfig (mips, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- markeins_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- mini2440_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- mips_paravirt_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- mmp2_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- moxart_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- mpc30x_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- mps2_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- msp71xx_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- mtx1_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- multi_v4t_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- multi_v5_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- multi_v7_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- mv78xx0_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- mvebu_v5_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- mvebu_v7_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- mxs_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- neponset_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- netwinder_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- netx_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- nhk8815_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- nlm_xlp_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- nlm_xlr_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- nsim_hs_defconfig (arc, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- nsim_hs_smp_defconfig (arc, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- nsimosci_hs_defconfig (arc, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- nsimosci_hs_smp_defconfig (arc, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- nuc910_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- nuc950_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- nuc960_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- omap1_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- omap2plus_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- omega2p_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- orion5x_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- palmz72_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- pcm027_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- pic32mzda_defconfig (mips, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- pistachio_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- pleb_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- pnx8335_stb225_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- prima2_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- pxa168_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- pxa255-idp_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- pxa3xx_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- pxa910_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- pxa_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- qcom_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- qi_lb60_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- raumfeld_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- rb532_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- rbtx49xx_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- realview_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- rm200_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- rpc_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- rt305x_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- s3c2410_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- s3c6400_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- s5pv210_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- sama5_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- sb1250_swarm_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- shannon_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- shmobile_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- simpad_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- socfpga_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- spear13xx_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- spear3xx_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- spear6xx_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- spitz_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- stm32_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- sunxi_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- tango4_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- tb0219_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- tb0226_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- tb0287_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- tct_hammer_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- tegra_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- tinyconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- tinyconfig (arm64, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- tinyconfig (x86_64, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: .config:1028:warning: override: UNWINDER_GUESS changes choice state -------------------------------------------------------------------------------- tinyconfig (arc, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- tinyconfig (i386, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- tinyconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- trizeps4_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- u300_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- u8500_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- vdk_hs38_defconfig (arc, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- vdk_hs38_smp_defconfig (arc, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- versatile_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- vexpress_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- viper_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- vocore2_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- vt8500_v6_v7_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- workpad_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- x86_64_defconfig (x86_64, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- xcep_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- xilfpga_defconfig (mips, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- xway_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- zeus_defconfig (arm, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: /scratch/linux/drivers/clk/clk.c:48:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] -------------------------------------------------------------------------------- zx_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches --- For more info write to <info(a)kernelci.org>

4 years, 4 months

1
0
0 0

+ mm-slub-fix-conversion-of-freelist_corrupted.patch added to -mm tree

by akpm＠linux-foundation.org

The patch titled Subject: mm: slub: fix conversion of freelist_corrupted() has been added to the -mm tree. Its filename is mm-slub-fix-conversion-of-freelist_corrupted.patch This patch should soon appear at https://ozlabs.org/~akpm/mmots/broken-out/mm-slub-fix-conversion-of-freelis… and later at https://ozlabs.org/~akpm/mmotm/broken-out/mm-slub-fix-conversion-of-freelis… Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Eugeniu Rosca <erosca(a)de.adit-jv.com> Subject: mm: slub: fix conversion of freelist_corrupted() Commit 52f23478081ae0 ("mm/slub.c: fix corrupted freechain in deactivate_slab()") suffered an update when picked up from LKML [1]. Specifically, relocating 'freelist = NULL' into 'freelist_corrupted()' created a no-op statement. Fix it by sticking to the behavior intended in the original patch [1]. In addition, make freelist_corrupted() immune to passing NULL instead of &freelist. The issue has been spotted via static analysis and code review. [1] https://lore.kernel.org/linux-mm/20200331031450.12182-1-dongli.zhang@oracle… Link: https://lkml.kernel.org/r/20200824130643.10291-1-erosca@de.adit-jv.com Fixes: 52f23478081ae0 ("mm/slub.c: fix corrupted freechain in deactivate_slab()") Signed-off-by: Eugeniu Rosca <erosca(a)de.adit-jv.com> Cc: Dongli Zhang <dongli.zhang(a)oracle.com> Cc: Joe Jin <joe.jin(a)oracle.com> Cc: Christoph Lameter <cl(a)linux.com> Cc: Pekka Enberg <penberg(a)kernel.org> Cc: David Rientjes <rientjes(a)google.com> Cc: Joonsoo Kim <iamjoonsoo.kim(a)lge.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/slub.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- a/mm/slub.c~mm-slub-fix-conversion-of-freelist_corrupted +++ a/mm/slub.c @@ -672,12 +672,12 @@ static void slab_fix(struct kmem_cache * } static bool freelist_corrupted(struct kmem_cache *s, struct page *page, - void *freelist, void *nextfree) + void **freelist, void *nextfree) { if ((s->flags & SLAB_CONSISTENCY_CHECKS) && - !check_valid_pointer(s, page, nextfree)) { - object_err(s, page, freelist, "Freechain corrupt"); - freelist = NULL; + !check_valid_pointer(s, page, nextfree) && freelist) { + object_err(s, page, *freelist, "Freechain corrupt"); + *freelist = NULL; slab_fix(s, "Isolate corrupted freechain"); return true; } @@ -1494,7 +1494,7 @@ static inline void dec_slabs_node(struct int objects) {} static bool freelist_corrupted(struct kmem_cache *s, struct page *page, - void *freelist, void *nextfree) + void **freelist, void *nextfree) { return false; } @@ -2184,7 +2184,7 @@ static void deactivate_slab(struct kmem_ * 'freelist' is already corrupted. So isolate all objects * starting at 'freelist'. */ - if (freelist_corrupted(s, page, freelist, nextfree)) + if (freelist_corrupted(s, page, &freelist, nextfree)) break; do { _ Patches currently in -mm which might be from erosca(a)de.adit-jv.com are mm-slub-fix-conversion-of-freelist_corrupted.patch

4 years, 4 months

1
0
0 0

[to-be-updated] mm-slub-fix-conversion-of-freelist_corrupted.patch removed from -mm tree

by akpm＠linux-foundation.org

The patch titled Subject: mm: slub: fix conversion of freelist_corrupted() has been removed from the -mm tree. Its filename was mm-slub-fix-conversion-of-freelist_corrupted.patch This patch was dropped because an updated version will be merged ------------------------------------------------------ From: Eugeniu Rosca <erosca(a)de.adit-jv.com> Subject: mm: slub: fix conversion of freelist_corrupted() Commit 52f23478081ae0 ("mm/slub.c: fix corrupted freechain in deactivate_slab()") suffered an update when picked up from LKML [1]. Specifically, relocating 'freelist = NULL' into 'freelist_corrupted()' created a no-op statement. Fix it by sticking to the behavior intended in the original patch [1]. Prefer the lowest-line-count solution. The issue popped up as a result of static analysis and code review. Therefore, I lack any specific runtime behavior example being fixed. [1] https://lore.kernel.org/linux-mm/20200331031450.12182-1-dongli.zhang@oracle… Link: http://lkml.kernel.org/r/20200811124656.10308-1-erosca@de.adit-jv.com Fixes: 52f23478081ae0 ("mm/slub.c: fix corrupted freechain in deactivate_slab()") Signed-off-by: Eugeniu Rosca <erosca(a)de.adit-jv.com> Cc: Dongli Zhang <dongli.zhang(a)oracle.com> Cc: Joe Jin <joe.jin(a)oracle.com> Cc: Christoph Lameter <cl(a)linux.com> Cc: Pekka Enberg <penberg(a)kernel.org> Cc: David Rientjes <rientjes(a)google.com> Cc: Joonsoo Kim <iamjoonsoo.kim(a)lge.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/slub.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/mm/slub.c~mm-slub-fix-conversion-of-freelist_corrupted +++ a/mm/slub.c @@ -677,7 +677,6 @@ static bool freelist_corrupted(struct km if ((s->flags & SLAB_CONSISTENCY_CHECKS) && !check_valid_pointer(s, page, nextfree)) { object_err(s, page, freelist, "Freechain corrupt"); - freelist = NULL; slab_fix(s, "Isolate corrupted freechain"); return true; } @@ -2184,8 +2183,10 @@ static void deactivate_slab(struct kmem_ * 'freelist' is already corrupted. So isolate all objects * starting at 'freelist'. */ - if (freelist_corrupted(s, page, freelist, nextfree)) + if (freelist_corrupted(s, page, freelist, nextfree)) { + freelist = NULL; break; + } do { prior = page->freelist; _ Patches currently in -mm which might be from erosca(a)de.adit-jv.com are

4 years, 4 months

1
0
0 0

[PATCH] powerpc: Fix a bug in __div64_32 if divisor is zero

by Guohua Zhong

When cat /proc/pid/stat, do_task_stat will call into cputime_adjust, which call stack is like this: [17179954.674326]BookE Watchdog detected hard LOCKUP on cpu 0 [17179954.674331]dCPU: 0 PID: 1262 Comm: TICK Tainted: P W O 4.4.176 #1 [17179954.674339]dtask: dc9d7040 task.stack: d3cb4000 [17179954.674344]NIP: c001b1a8 LR: c006a7ac CTR: 00000000 [17179954.674349]REGS: e6fe1f10 TRAP: 3202 Tainted: P W O (4.4.176) [17179954.674355]MSR: 00021002 <CE,ME> CR: 28002224 XER: 00000000 [17179954.674364] GPR00: 00000016 d3cb5cb0 dc9d7040 d3cb5cc0 00000000 0000025d ffe15b24 ffffffff GPR08: de86aead 00000000 000003ff ffffffff 28002222 0084d1c0 00000000 ffffffff GPR16: b5929ca0 b4bb7a48 c0863c08 0000048d 00000062 00000062 00000000 0000000f GPR24: 00000000 d3cb5d08 d3cb5d60 d3cb5d64 00029002 d3e9c214 fffff30e d3e9c20c [17179954.674410]NIP [c001b1a8] __div64_32+0x60/0xa0 [17179954.674422]LR [c006a7ac] cputime_adjust+0x124/0x138 [17179954.674434]Call Trace: [17179961.832693]Call Trace: [17179961.832695][d3cb5cb0] [c006a6dc] cputime_adjust+0x54/0x138 (unreliable) [17179961.832705][d3cb5cf0] [c006a818] task_cputime_adjusted+0x58/0x80 [17179961.832713][d3cb5d20] [c01dab44] do_task_stat+0x298/0x870 [17179961.832720][d3cb5de0] [c01d4948] proc_single_show+0x60/0xa4 [17179961.832728][d3cb5e10] [c01963d8] seq_read+0x2d8/0x52c [17179961.832736][d3cb5e80] [c01702fc] __vfs_read+0x40/0x114 [17179961.832744][d3cb5ef0] [c0170b1c] vfs_read+0x9c/0x10c [17179961.832751][d3cb5f10] [c0171440] SyS_read+0x68/0xc4 [17179961.832759][d3cb5f40] [c0010a40] ret_from_syscall+0x0/0x3c do_task_stat->task_cputime_adjusted->cputime_adjust->scale_stime->div_u64 ->div_u64_rem->do_div->__div64_32 In some corner case, stime + utime = 0 if overflow. Even in v5.8.2 kernel the cputime has changed from unsigned long to u64 data type. About 200 days, the lowwer 32 bit will be 0x00000000. Because divisor for __div64_32 is unsigned long data type,which is 32 bit for powepc 32, the bug still exists. So it is also a bug in the cputime_adjust which does not check if stime + utime = 0 time = scale_stime((__force u64)stime, (__force u64)rtime, (__force u64)(stime + utime)); The commit 3dc167ba5729 ("sched/cputime: Improve cputime_adjust()") in mainline kernel may has fixed this case. But it is also better to check if divisor is 0 in __div64_32 for other situation. Signed-off-by: Guohua Zhong <zhongguohua1(a)huawei.com> Fixes:14cf11af6cf6 "( powerpc: Merge enough to start building in arch/powerpc.)" Fixes:94b212c29f68 "( powerpc: Move ppc64 boot wrapper code over to arch/powerpc)" Cc: stable(a)vger.kernel.org # v2.6.15+ --- arch/powerpc/boot/div64.S | 4 ++++ arch/powerpc/lib/div64.S | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/arch/powerpc/boot/div64.S b/arch/powerpc/boot/div64.S index 4354928ed62e..39a25b9712d1 100644 --- a/arch/powerpc/boot/div64.S +++ b/arch/powerpc/boot/div64.S @@ -13,6 +13,9 @@ .globl __div64_32 __div64_32: + li r9,0 + cmplw r4,r9 # check if divisor r4 is zero + beq 5f # jump to label 5 if r4(divisor) is zero lwz r5,0(r3) # get the dividend into r5/r6 lwz r6,4(r3) cmplw r5,r4 @@ -52,6 +55,7 @@ __div64_32: 4: stw r7,0(r3) # return the quotient in *r3 stw r8,4(r3) mr r3,r6 # return the remainder in r3 +5: # return if divisor r4 is zero blr /* diff --git a/arch/powerpc/lib/div64.S b/arch/powerpc/lib/div64.S index 3d5426e7dcc4..1cc9bcabf678 100644 --- a/arch/powerpc/lib/div64.S +++ b/arch/powerpc/lib/div64.S @@ -13,6 +13,9 @@ #include <asm/processor.h> _GLOBAL(__div64_32) + li r9,0 + cmplw r4,r9 # check if divisor r4 is zero + beq 5f # jump to label 5 if r4(divisor) is zero lwz r5,0(r3) # get the dividend into r5/r6 lwz r6,4(r3) cmplw r5,r4 @@ -52,4 +55,5 @@ _GLOBAL(__div64_32) 4: stw r7,0(r3) # return the quotient in *r3 stw r8,4(r3) mr r3,r6 # return the remainder in r3 +5: # return if divisor r4 is zero blr -- 2.12.3

4 years, 4 months

5
11
0 0

WARNING: kernel stack regs at 00000000d9dac8ad in fork13:28354 has bad 'bp' value 0000000000000000

by Naresh Kamboju

on x86_64 kasan enabled build this kernel warning noticed while running LTP syscalls fork13 test case. metadata: git branch: linux-5.8.y git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git commit: 8960c0bf1993f3bdce3a3de5f03aaf5755f661e5 git describe: v5.8.3-149-g8960c0bf1993 make_kernelversion: 5.8.4-rc1 kernel-config: https://builds.tuxbuild.com/VSP7j-bv11LJRxPxnvOq_w/kernel.config steps to reproduce: - boot x86_64 kasan enabled kernel - run ltp fork13 test case - cd /opt/ltp/testcases/bin - ./fork13 -i 1000000 [ 928.754534] WARNING: kernel stack regs at 00000000d9dac8ad in fork13:28354 has bad 'bp' value 0000000000000000 [ 928.754536] unwind stack type:0 next_sp:0000000000000000 mask:0x6 graph_idx:0 [ 928.754541] 00000000908d9a89: ffff88841fb89ad0 (0xffff88841fb89ad0) [ 928.754546] 00000000713a6f3f: ffffffffb6b2524c (arch_stack_walk+0x8c/0xf0) [ 928.754548] 00000000a333e33a: 0000000000000000 ... [ 928.754550] 000000001f131381: ffff888410c68000 (0xffff888410c68000) [ 928.754553] 00000000ac56adaf: ffff888410c70000 (0xffff888410c70000) [ 928.754554] 00000000499c7993: 0000000000000000 ... [ 928.754556] 0000000066f48100: 0000000000000006 (0x6) [ 928.754558] 0000000040f166c1: ffff888370a0de80 (0xffff888370a0de80) [ 928.754560] 00000000c1358a0a: 0000010100000000 (0x10100000000) [ 928.754561] 00000000443f0920: 0000000000000000 ... [ 928.754564] 00000000f5fcc5eb: ffff88841fb89a38 (0xffff88841fb89a38) [ 928.754568] 000000000ef6da08: ffffffffb6a02be0 (ret_from_fork+0x10/0x30) [ 928.754569] 000000009addfc01: 0000000000000000 ... [ 928.754571] 0000000022937aad: ffff888410c6fea8 (0xffff888410c6fea8) [ 928.754574] 0000000087461b55: 664ad2b25ee06300 (0x664ad2b25ee06300) [ 928.754576] 00000000f22c5014: ffffed1083f7135c (0xffffed1083f7135c) [ 928.754578] 00000000107b8b83: 0000000000000800 (0x800) [ 928.754580] 000000004da2ec53: ffff88840506bc40 (0xffff88840506bc40) [ 928.754582] 000000005cd5c950: ffff88841dc03800 (0xffff88841dc03800) [ 928.754585] 000000009a4f2b77: ffff88841fb89b68 (0xffff88841fb89b68) [ 928.754590] 0000000004a910d6: ffffffffb6d1f9c4 (stack_trace_save+0x94/0xc0) [ 928.754592] 00000000f32d9cce: 0000000041b58ab3 (0x41b58ab3) [ 928.754597] 0000000098ca7ca5: ffffffffb8e094cc (.LC0+0x3362/0xd896) [ 928.754601] 000000000d66da7d: ffffffffb6d1f930 (stack_trace_consume_entry+0x90/0x90) [ 928.754603] 00000000b7422065: 0000000000000131 (0x131) [ 928.754605] 00000000d72ffaa0: ffff88841fb89b78 (0xffff88841fb89b78) [ 928.754607] 000000000a6419c1: 0000000000000040 (0x40) [ 928.754609] 0000000037248aa1: 000000000000000f (0xf) [ 928.754610] 00000000abdbdb84: 0000000000000000 ... [ 928.754612] 0000000003573c3a: ffff88841dd7f400 (0xffff88841dd7f400) [ 928.754617] 00000000e5cbebfd: ffffffffb6c43c10 (child_wait_callback+0x100/0x100) [ 928.754619] 000000009cd94b8b: ffff88841fb89d50 (0xffff88841fb89d50) [ 928.754623] 00000000ef01908b: ffffffffb6f1ef52 (save_stack+0x42/0x50) [ 928.754626] 00000000f51ece9d: ffffffffb6f1ef33 (save_stack+0x23/0x50) [ 928.754629] 0000000008f796f9: ffff88841df15600 (0xffff88841df15600) [ 928.754631] 000000002a34dcbb: 664ad2b25ee06300 (0x664ad2b25ee06300) [ 928.754633] 0000000075fa49a4: 0000000000000001 (0x1) [ 928.754635] 0000000072ccf51e: ffff88841fb89d80 (0xffff88841fb89d80) [ 928.754638] 00000000db7a013f: ffffffffb6f1ef33 (save_stack+0x23/0x50) [ 928.754642] 00000000c99d8de7: ffffffffb6f1ef33 (save_stack+0x23/0x50) [ 928.754645] 00000000f5b105c3: ffffffffb6f1f097 (__kasan_slab_free+0x137/0x180) [ 928.754649] 00000000a195921a: ffffffffb6f1f70e (kasan_slab_free+0xe/0x10) [ 928.754652] 00000000eaf32c2c: ffffffffb6f1cea8 (kfree+0x98/0x240) [ 928.754657] 0000000003a3d4ee: ffffffffb722793a (security_cred_free+0x6a/0x90) [ 928.754661] 0000000081df44fc: ffffffffb6c86eb9 (put_cred_rcu+0x49/0x160) [ 928.754664] 00000000def4eebb: ffffffffb6d13e8a (rcu_core+0x37a/0xc80) [ 928.754668] 00000000ccf0e376: ffffffffb6d1479e (rcu_core_si+0xe/0x10) [ 928.754672] 0000000081e253b5: ffffffffb8400160 (__do_softirq+0x160/0x467) [ 928.754675] 00000000a4956b3b: ffffffffb8200f82 (asm_call_on_stack+0x12/0x20) [ 928.754680] 000000006f1e3f6a: ffffffffb6b0e9af (do_softirq_own_stack+0x3f/0x50) [ 928.754684] 00000000d6c45a50: ffffffffb6c4a69f (irq_exit_rcu+0xff/0x110) [ 928.754688] 000000008d42b2e0: ffffffffb81aca68 (sysvec_apic_timer_interrupt+0x38/0x90) [ 928.754692] 0000000064c4c87d: ffffffffb8200c42 (asm_sysvec_apic_timer_interrupt+0x12/0x20) [ 928.754695] 0000000053a861de: ffffffffb6a02be0 (ret_from_fork+0x10/0x30) [ 928.754696] 00000000d3e710f8: 0000000000000000 ... [ 928.754698] 00000000939b28dd: 0000000100000001 (0x100000001) [ 928.754700] 00000000166726c9: 0000000000000000 ... [ 928.754702] 000000004a199aa9: 0000000000204000 (0x204000) [ 928.754706] 0000000001bd65d9: ffffffffb901a400 (root_mountflags+0x1c60/0x1c60) [ 928.754708] 000000008a52f042: 0000000000000000 ... [ 928.754710] 00000000e32080da: ffff88841fb89c30 (0xffff88841fb89c30) [ 928.754713] 00000000c125a613: ffffffffb6f1ef04 (__kasan_check_write+0x14/0x20) [ 928.754716] 0000000008596419: ffff88841fb89c50 (0xffff88841fb89c50) [ 928.754719] 00000000572202ef: ffffffffb6c8fcac (set_nr_if_polling+0x2c/0x60) [ 928.754722] 00000000b05e066e: ffff88841fa31380 (0xffff88841fa31380) [ 928.754723] 00000000465aa8dc: 0000000000000000 ... [ 928.754725] 00000000c3b0a1f0: ffff88841fb89c78 (0xffff88841fb89c78) [ 928.754730] 00000000dcd6ae89: ffffffffb6c9dc08 (send_call_function_single_ipi+0x48/0xf0) [ 928.754732] 00000000f47550ca: 0000000000032280 (0x32280) [ 928.754734] 0000000066af3953: ffff88841fa313a0 (0xffff88841fa313a0) [ 928.754736] 00000000057c28b8: ffff88841fa313a0 (0xffff88841fa313a0) [ 928.754739] 00000000937ead47: ffff88841fb89ca8 (0xffff88841fb89ca8) [ 928.754743] 000000002b02c73b: ffffffffb6d4e275 (__smp_call_single_queue+0x55/0x60) [ 928.754744] 00000000b602744d: 0000000000000000 ... [ 928.754746] 0000000053fef878: ffff88841fb89ce0 (0xffff88841fb89ce0) [ 928.754750] 00000000df88a55e: ffffffffb6d1a024 (rcu_segcblist_accelerate+0xf4/0x160) [ 928.754753] 00000000ac50318b: ffff888370a0a8d0 (0xffff888370a0a8d0) [ 928.754754] 000000005dff8b79: 0000000000000002 (0x2) [ 928.754757] 000000001e23ce54: ffff88841fbb20c0 (0xffff88841fbb20c0) [ 928.754759] 00000000cfe3366f: 00000000bfab7701 (0xbfab7701) [ 928.754761] 00000000445fd255: ffff88841fbb2110 (0xffff88841fbb2110) [ 928.754763] 0000000054eaac2b: ffff88841fbb2110 (0xffff88841fbb2110) [ 928.754765] 00000000bf54e941: ffff88841fbb20c0 (0xffff88841fbb20c0) [ 928.754768] 0000000019f1e2f6: ffff88841fb89d88 (0xffff88841fb89d88) [ 928.754771] 0000000026e375a0: ffffffffb6d12996 (rcu_accelerate_cbs+0x96/0xbe0) [ 928.754774] 00000000433e4156: ffffffffb8e0acc8 (.LC0+0x4b5e/0xd896) [ 928.754779] 00000000bff23f74: ffffffffb6d3d2c0 (posix_cpu_timers_exit_group+0x30/0x30) [ 928.754781] 000000007f6445da: ffff88841fb89d40 (0xffff88841fb89d40) [ 928.754784] 00000000c896ef50: ffffffffb6ca608d (kick_ilb+0x12d/0x140) [ 928.754788] 00000000ce36df4f: ffffffffb8ebd6e0 (intel_graphics_stolen_res+0x40/0x40) [ 928.754791] 00000000ebc96e1c: ffff88841dc3c500 (0xffff88841dc3c500) [ 928.754793] 00000000651157d2: ffff88841dc3c504 (0xffff88841dc3c504) [ 928.754797] 00000000c9e845c7: ffffffffb9129548 (rcu_state+0x8/0xc20) [ 928.754799] 000000004e722d83: ffff88841fb89d28 (0xffff88841fb89d28) [ 928.754801] 0000000048052b14: 00000000ffffff01 (0xffffff01) [ 928.754803] 0000000034d84484: 00000000000ac013 (0xac013) [ 928.754806] 000000007b2eac65: ffff88841fbb20c0 (0xffff88841fbb20c0) [ 928.754809] 00000000d50a50cf: ffffffffb9129540 (use_softirq+0x60/0x60) [ 928.754811] 00000000486acfa2: 00000000000ac014 (0xac014) [ 928.754813] 000000006daca0b4: ffff88841fbb20c0 (0xffff88841fbb20c0) [ 928.754815] 0000000015cc7f50: ffff88841fbb20c0 (0xffff88841fbb20c0) [ 928.754819] 0000000033fc3ffa: ffffffffb9129540 (use_softirq+0x60/0x60) [ 928.754821] 000000008d4ada29: ffff88840506bc60 (0xffff88840506bc60) [ 928.754823] 00000000b72c7012: ffff88841fb89db0 (0xffff88841fb89db0) [ 928.754827] 0000000013131ed6: ffffffffb6f1f097 (__kasan_slab_free+0x137/0x180) [ 928.754829] 00000000141ace5e: ffff88840506bc40 (0xffff88840506bc40) [ 928.754832] 000000008f18ed6b: ffffea0010141ac0 (0xffffea0010141ac0) [ 928.754834] 00000000854484b9: ffff88841dc03800 (0xffff88841dc03800) [ 928.754838] 00000000d8e6fa3d: ffffffffb722793a (security_cred_free+0x6a/0x90) [ 928.754840] 00000000cd0db824: ffff88841fb89dc0 (0xffff88841fb89dc0) [ 928.754843] 00000000d12cc674: ffffffffb6f1f70e (kasan_slab_free+0xe/0x10) [ 928.754846] 00000000d2fe93eb: ffff88841fb89df0 (0xffff88841fb89df0) [ 928.754849] 000000002f99711c: ffffffffb6f1cea8 (kfree+0x98/0x240) [ 928.754850] 000000001e270a90: 0000000000000000 ... [ 928.754852] 00000000337178b6: ffff888370c1e700 (0xffff888370c1e700) [ 928.754854] 000000005c3c88e3: ffff888370c1e778 (0xffff888370c1e778) [ 928.754857] 000000007f105a7c: ffff888370c1e790 (0xffff888370c1e790) [ 928.754859] 000000007b44dd80: ffff88841fb89e18 (0xffff88841fb89e18) [ 928.754863] 0000000063bf068a: ffffffffb722793a (security_cred_free+0x6a/0x90) [ 928.754865] 000000003f216245: ffff888370c1e798 (0xffff888370c1e798) [ 928.754867] 000000008589c9e2: ffff888370c1e700 (0xffff888370c1e700) [ 928.754870] 0000000037fdebf4: ffff888370c1e7a0 (0xffff888370c1e7a0) [ 928.754872] 0000000011170bcd: ffff88841fb89e48 (0xffff88841fb89e48) [ 928.754876] 0000000096cc7c1a: ffffffffb6c86eb9 (put_cred_rcu+0x49/0x160) [ 928.754878] 0000000070879447: ffff888370a0de80 (0xffff888370a0de80) [ 928.754880] 00000000682e6d5c: ffff888370c1e798 (0xffff888370c1e798) [ 928.754882] 0000000017bd914a: ffff888370c1e7a0 (0xffff888370c1e7a0) [ 928.754885] 00000000e9fdeb0a: ffff88841fbb2110 (0xffff88841fbb2110) [ 928.754887] 00000000878de49a: ffff88841fb89f50 (0xffff88841fb89f50) [ 928.754890] 0000000087802692: ffffffffb6d13e8a (rcu_core+0x37a/0xc80) [ 928.754892] 00000000877e0f44: 000000001fb89f40 (0x1fb89f40) [ 928.754894] 000000002fbb38c9: ffff88841fbb2110 (0xffff88841fbb2110) [ 928.754897] 0000000018de5cdc: ffff88841fbb20c0 (0xffff88841fbb20c0) [ 928.754899] 00000000241aa4ea: ffff88841fbb2178 (0xffff88841fbb2178) [ 928.754901] 000000004062f053: ffff88841fbb2158 (0xffff88841fbb2158) [ 928.754903] 00000000a414ceab: 000000000000000a (0xa) [ 928.754904] 00000000c8e44445: 0000000000000000 ... [ 928.754906] 0000000041c7dc5a: ffff88841fb89ec8 (0xffff88841fb89ec8) [ 928.754908] 00000000c535acba: 0000000000000202 (0x202) [ 928.754910] 000000003ae773c1: 1ffff11083f713d5 (0x1ffff11083f713d5) [ 928.754912] 00000000142abd02: 0000000041b58ab3 (0x41b58ab3) [ 928.754916] 000000001e373199: ffffffffb8e08c03 (.LC0+0x2a99/0xd896) [ 928.754919] 00000000c1de8fa0: ffffffffb6d13b10 (rcu_accelerate_cbs_unlocked+0xa0/0xa0) [ 928.754922] 0000000034ba5504: ffff88841fb9f480 (0xffff88841fb9f480) [ 928.754924] 00000000f8bf3cbb: ffff888370c1e198 (0xffff888370c1e198) [ 928.754926] 00000000c67e6ed5: ffff888370c1e198 (0xffff888370c1e198) [ 928.754929] 000000009738e749: ffffffffffffffff (0xffffffffffffffff) [ 928.754933] 00000000de4b30f7: ffffffffb6d41049 (clockevents_program_event+0xf9/0x160) [ 928.754934] 000000005c5e2481: 0000000000000000 ... [ 928.754936] 000000001c17fec4: 000000d7ff8aaaca (0xd7ff8aaaca) [ 928.754939] 000000004eb3090f: ffff88841fb9f480 (0xffff88841fb9f480) [ 928.754941] 00000000c5a20623: ffff888370a0de80 (0xffff888370a0de80) [ 928.754944] 00000000d725334d: ffffffffb84000e1 (__do_softirq+0xe1/0x467) [ 928.754946] 00000000a6e6a75b: 0000000000000000 ... [ 928.754949] 000000008550bcb4: ffffffffb8200f82 (asm_call_on_stack+0x12/0x20) [ 928.754951] 00000000b72a8966: 664ad2b25ee06300 (0x664ad2b25ee06300) [ 928.754954] 000000009e71c01b: ffffffffb9009108 (softirq_vec+0x48/0x80) [ 928.754956] 000000008e3f22f5: 0000000000000009 (0x9) [ 928.754958] 000000002f829dec: 000000000000000a (0xa) [ 928.754960] 000000002b9e876f: 0000000000000009 (0x9) [ 928.754961] 00000000939823af: 0000000000000009 (0x9) [ 928.754964] 000000004caecea0: ffff88841fb89f60 (0xffff88841fb89f60) [ 928.754967] 000000003f0196cf: ffffffffb6d1479e (rcu_core_si+0xe/0x10) [ 928.754969] 00000000e36b5944: ffff88841fb89fe8 (0xffff88841fb89fe8) [ 928.754973] 000000004accbdfe: ffffffffb8400160 (__do_softirq+0x160/0x467) [ 928.754975] 00000000b0a2d50d: ffff88841fb89fa0 (0xffff88841fb89fa0) [ 928.754977] 00000000ff468aa1: 01ffffff00404040 (0x1ffffff00404040) [ 928.754979] 00000000e7a176a7: ffff888370a0de80 (0xffff888370a0de80) [ 928.754982] 0000000077951761: 00000001000990ef (0x1000990ef) [ 928.754984] 0000000011ba65e6: ffff888370a0de80 (0xffff888370a0de80) [ 928.754985] 000000009e2e350a: 0000000000000009 (0x9) [ 928.754987] 00000000dab4e498: 0000000000000050 (0x50) [ 928.754989] 000000000316aa9d: 000001000000000a (0x1000000000a) [ 928.754992] 00000000d9349f42: ffffffffb90090c0 (tasklist_lock+0x40/0x40) [ 928.754995] 0000000048c95adf: 000002000000000a (0x2000000000a) [ 928.754996] 00000000253ce758: 0000000000000000 ... [ 928.754998] 00000000c7bd4c18: ffff888410c6fea8 (0xffff888410c6fea8) [ 928.754999] 00000000a3d59497: 0000000000000000 ... [ 928.755002] 000000009d07f93e: ffff888410c6fe48 (0xffff888410c6fe48) [ 928.755005] 000000005450b87d: ffffffffb8200f82 (asm_call_on_stack+0x12/0x20) [ 928.755007] 00000000602e6f06: ffff888410c6fe48 (0xffff888410c6fe48) [ 928.755010] 000000007a1ceca1: ffff888410c6fe58 (0xffff888410c6fe58) [ 928.755014] 00000000fac24b13: ffffffffb6b0e9af (do_softirq_own_stack+0x3f/0x50) [ 928.755016] 00000000f0ab3a1a: ffff888410c6fe78 (0xffff888410c6fe78) [ 928.755019] 000000009d4da3e0: ffffffffb6c4a69f (irq_exit_rcu+0xff/0x110) [ 928.755021] 00000000ad2e8d71: 0000000000000000 ... [ 928.755023] 000000002ae1c7a1: ffff888410c6fea8 (0xffff888410c6fea8) [ 928.755025] 000000002253613e: ffff888410c6fe98 (0xffff888410c6fe98) [ 928.755029] 00000000c9123cb8: ffffffffb81aca68 (sysvec_apic_timer_interrupt+0x38/0x90) [ 928.755030] 0000000016819571: 0000000000000000 ... [ 928.755032] 0000000005613fad: ffff888410c6fea9 (0xffff888410c6fea9) [ 928.755036] 000000008ce730cd: ffffffffb8200c42 (asm_sysvec_apic_timer_interrupt+0x12/0x20) [ 928.755037] 00000000d9dac8ad: 0000000000000000 ... [ 928.755040] 00000000b6032801: ffffed106e141bd0 (0xffffed106e141bd0) [ 928.755042] 00000000bfa496b0: ffff888370a0de87 (0xffff888370a0de87) [ 928.755044] 000000006b980fc2: ffffed106e141bd1 (0xffffed106e141bd1) [ 928.755046] 0000000074e46078: 0000000000000001 (0x1) [ 928.755048] 000000002aab3b34: ffff888410c6ff20 (0xffff888410c6ff20) [ 928.755052] 00000000fce3bf98: ffffffffb6c5876d (calculate_sigpending+0x5d/0x70) [ 928.755054] 0000000018ef6c93: 1ffff11080c16d20 (0x1ffff11080c16d20) [ 928.755058] 000000009d1359d5: ffffffffb6c9f1cb (schedule_tail+0x7b/0x90) [ 928.755060] 000000002fc55bea: ffff888410c6ff58 (0xffff888410c6ff58) [ 928.755063] 0000000030fd457b: ffffffffffffffff (0xffffffffffffffff) [ 928.755066] 00000000d49034b8: ffffffffb6a02be0 (ret_from_fork+0x10/0x30) [ 928.755067] 00000000f6bd93cf: 0000000000000010 (0x10) [ 928.755069] 000000003a683af5: 0000000000000246 (0x246) [ 928.755072] 00000000b0490886: ffff888410c6ff58 (0xffff888410c6ff58) [ 928.755073] 0000000067f6e028: 0000000000000018 (0x18) [ 928.755076] 00000000a41e2047: ffffffffb6a02bd8 (ret_from_fork+0x8/0x30) [ 928.755078] 0000000044a1e2e9: 0000000000000000 ... [ 928.755080] 000000001dcd6329: 00007f43e4063000 (0x7f43e4063000) [ 928.755082] 000000002cfa998b: 00007ffd5fa4e5d0 (0x7ffd5fa4e5d0) [ 928.755083] 0000000026dbca06: 0000000000000000 ... [ 928.755085] 000000001ea8b60c: 0000000000000246 (0x246) [ 928.755087] 000000000694b3b3: 00007f43e405c850 (0x7f43e405c850) [ 928.755089] 000000008c89cce5: 00007ffd5fa4e463 (0x7ffd5fa4e463) [ 928.755091] 00000000dc105046: 00007f43e405c580 (0x7f43e405c580) [ 928.755092] 00000000617a0390: 0000000000000000 ... [ 928.755095] 00000000c5f510bf: 00007f43e3b4c54d (0x7f43e3b4c54d) [ 928.755096] 00000000cb6c8d60: 0000000000000000 ... [ 928.755098] 000000001fc7e35f: 0000000001200011 (0x1200011) [ 928.755100] 00000000b9ac1c0b: 0000000000000038 (0x38) [ 928.755102] 000000004f3f3b5b: 00007f43e3b4c54d (0x7f43e3b4c54d) [ 928.755104] 000000005506661c: 0000000000000033 (0x33) [ 928.755105] 00000000e6c2599e: 0000000000000246 (0x246) [ 928.755108] 000000008306f770: 00007ffd5fa4e590 (0x7ffd5fa4e590) [ 928.755109] 000000003a4ebad9: 000000000000002b (0x2b) ref: https://lkft.validation.linaro.org/scheduler/job/1703012#L6510 -- Linaro LKFT https://lkft.linaro.org

4 years, 4 months

2
1
0 0

Re: [PATCH 0/1] Netfilter OOB memory access security patch

by Will McVicker

Adding stable(a)vger.kernel.org. Please see the original message regarding this OOB memory access security fix. The patch is intended for the LTS branches 4.19.y, 4.14.y, 4.9.y and 4.4.y. Thanks, Will

4 years, 4 months

3
4
0 0

[PATCH backport to v5.4] EDAC/{i7core, sb, pnd2, skx}: Fix error event severity

by Tony Luck

commit 45bc6098a3e279d8e391d22428396687562797e2 upstream IA32_MCG_STATUS.RIPV indicates whether the return RIP value pushed onto the stack as part of machine check delivery is valid or not. Various drivers copied a code fragment that uses the RIPV bit to determine the severity of the error as either HW_EVENT_ERR_UNCORRECTED or HW_EVENT_ERR_FATAL, but this check is reversed (marking errors where RIPV is set as "FATAL"). Reverse the tests so that the error is marked fatal when RIPV is not set. Reported-by: Gabriele Paoloni <gabriele.paoloni(a)intel.com> Signed-off-by: Tony Luck <tony.luck(a)intel.com> Signed-off-by: Borislav Petkov <bp(a)suse.de> --- drivers/edac/i7core_edac.c | 4 ++-- drivers/edac/pnd2_edac.c | 2 +- drivers/edac/sb_edac.c | 6 +++--- drivers/edac/skx_common.c | 6 +++--- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c index a71cca6eeb33..6be7e65f7389 100644 --- a/drivers/edac/i7core_edac.c +++ b/drivers/edac/i7core_edac.c @@ -1711,9 +1711,9 @@ static void i7core_mce_output_error(struct mem_ctl_info *mci, if (uncorrected_error) { core_err_cnt = 1; if (ripv) - tp_event = HW_EVENT_ERR_FATAL; - else tp_event = HW_EVENT_ERR_UNCORRECTED; + else + tp_event = HW_EVENT_ERR_FATAL; } else { tp_event = HW_EVENT_ERR_CORRECTED; } diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c index b1193be1ef1d..dac45e2071b3 100644 --- a/drivers/edac/pnd2_edac.c +++ b/drivers/edac/pnd2_edac.c @@ -1155,7 +1155,7 @@ static void pnd2_mce_output_error(struct mem_ctl_info *mci, const struct mce *m, u32 optypenum = GET_BITFIELD(m->status, 4, 6); int rc; - tp_event = uc_err ? (ripv ? HW_EVENT_ERR_FATAL : HW_EVENT_ERR_UNCORRECTED) : + tp_event = uc_err ? (ripv ? HW_EVENT_ERR_UNCORRECTED : HW_EVENT_ERR_FATAL) : HW_EVENT_ERR_CORRECTED; /* diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c index f743502ca9b7..d2f02e539b68 100644 --- a/drivers/edac/sb_edac.c +++ b/drivers/edac/sb_edac.c @@ -2981,11 +2981,11 @@ static void sbridge_mce_output_error(struct mem_ctl_info *mci, if (uncorrected_error) { core_err_cnt = 1; if (ripv) { - type = "FATAL"; - tp_event = HW_EVENT_ERR_FATAL; - } else { type = "NON_FATAL"; tp_event = HW_EVENT_ERR_UNCORRECTED; + } else { + type = "FATAL"; + tp_event = HW_EVENT_ERR_FATAL; } } else { type = "CORRECTED"; diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c index 2177ad765bd1..1b5253e88303 100644 --- a/drivers/edac/skx_common.c +++ b/drivers/edac/skx_common.c @@ -490,11 +490,11 @@ static void skx_mce_output_error(struct mem_ctl_info *mci, if (uncorrected_error) { core_err_cnt = 1; if (ripv) { - type = "FATAL"; - tp_event = HW_EVENT_ERR_FATAL; - } else { type = "NON_FATAL"; tp_event = HW_EVENT_ERR_UNCORRECTED; + } else { + type = "FATAL"; + tp_event = HW_EVENT_ERR_FATAL; } } else { type = "CORRECTED"; -- 2.21.1

4 years, 4 months

1
0
0 0

[PATCH 5.8 000/148] 5.8.4-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.8.4 release. There are 148 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 26 Aug 2020 08:23:34 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.8.4-rc1.… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.8.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.8.4-rc1 Al Viro <viro(a)zeniv.linux.org.uk> do_epoll_ctl(): clean the failure exits up a bit Arvind Sankar <nivedita(a)alum.mit.edu> efi/libstub: Handle unterminated cmdline Arvind Sankar <nivedita(a)alum.mit.edu> efi/libstub: Handle NULL cmdline Arvind Sankar <nivedita(a)alum.mit.edu> efi/libstub: Stop parsing arguments at "--" Li Heng <liheng40(a)huawei.com> efi: add missed destroy_workqueue when efisubsys_init fails Arvind Sankar <nivedita(a)alum.mit.edu> efi/x86: Mark kernel rodata non-executable for mixed mode Tony Luck <tony.luck(a)intel.com> EDAC/{i7core,sb,pnd2,skx}: Fix error event severity Vasant Hegde <hegdevasant(a)linux.vnet.ibm.com> powerpc/pseries: Do not initiate shutdown when system is running on UPS Michael Neuling <mikey(a)neuling.org> powerpc: Fix P10 PVR revision in /proc/cpuinfo for SMT4 cores Marc Zyngier <maz(a)kernel.org> epoll: Keep a reference on files added to the check list Tom Rix <trix(a)redhat.com> net: dsa: b53: check for timeout Haiyang Zhang <haiyangz(a)microsoft.com> hv_netvsc: Fix the queue_mapping in netvsc_vf_xmit() Veronika Kabatova <vkabatov(a)redhat.com> selftests/bpf: Remove test_align leftovers Wang Hai <wanghai38(a)huawei.com> net: gemini: Fix missing free_netdev() in error path of gemini_ethernet_port_probe() Shay Agroskin <shayagr(a)amazon.com> net: ena: Change WARN_ON expression in ena_del_napi_in_range() Shay Agroskin <shayagr(a)amazon.com> net: ena: Prevent reset after device destruction Jiri Wiesner <jwiesner(a)suse.com> bonding: fix active-backup failover for current ARP slave Michael Roth <mdroth(a)linux.vnet.ibm.com> powerpc/pseries/hotplug-cpu: wait indefinitely for vCPU death Yonghong Song <yhs(a)fb.com> bpf: Use get_file_rcu() instead of get_file() for task_file iterator Christophe Leroy <christophe.leroy(a)csgroup.eu> powerpc/fixmap: Fix the size of the early debug area Madhavan Srinivasan <maddy(a)linux.ibm.com> powerpc: Add POWER10 raw mode cputable entry Stephen Boyd <swboyd(a)chromium.org> ARM64: vdso32: Install vdso32 from vdso_install David Howells <dhowells(a)redhat.com> afs: Fix NULL deref in afs_dynroot_depopulate() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: qconf: remove qInfo() to get back Qt4 support David Howells <dhowells(a)redhat.com> afs: Fix key ref leak in afs_put_operation() Weihang Li <liweihang(a)huawei.com> Revert "RDMA/hns: Reserve one sge in order to avoid local length error" Selvin Xavier <selvin.xavier(a)broadcom.com> RDMA/bnxt_re: Do not add user qps to flushlist Randy Dunlap <rdunlap(a)infradead.org> Fix build error when CONFIG_ACPI is not set/enabled: Juergen Gross <jgross(a)suse.com> efi: avoid error message when booting under Xen Masahiro Yamada <masahiroy(a)kernel.org> kconfig: qconf: fix signal connection to invalid slots Masahiro Yamada <masahiroy(a)kernel.org> kconfig: qconf: do not limit the pop-up menu to the first row Quinn Tran <qutran(a)marvell.com> Revert "scsi: qla2xxx: Disable T10-DIF feature with FC-NVMe during probe" Adrian Hunter <adrian.hunter(a)intel.com> scsi: ufs: Fix interrupt error message for shared interrupts Adrian Hunter <adrian.hunter(a)intel.com> scsi: ufs-pci: Add quirk for broken auto-hibernate for Intel EHL Kiwoong Kim <kwmad.kim(a)samsung.com> scsi: ufs: Add quirk to fix abnormal ocs fatal error Alim Akhtar <alim.akhtar(a)samsung.com> scsi: ufs: Introduce UFSHCD_QUIRK_PRDT_BYTE_GRAN quirk Alim Akhtar <alim.akhtar(a)samsung.com> scsi: ufs: Add quirk to enable host controller without hce Alim Akhtar <alim.akhtar(a)samsung.com> scsi: ufs: Add quirk to disallow reset of interrupt aggregation Alim Akhtar <alim.akhtar(a)samsung.com> scsi: ufs: Add quirk to fix mishandling utrlclr/utmrlclr Jing Xiangfeng <jingxiangfeng(a)huawei.com> scsi: ufs: ti-j721e-ufs: Fix error return in ti_j721e_ufs_probe() Colin Ian King <colin.king(a)canonical.com> of/address: check for invalid range.cpu_addr Jim Mattson <jmattson(a)google.com> kvm: x86: Toggling CR4.PKE does not load PDPTEs in PAE mode Jim Mattson <jmattson(a)google.com> kvm: x86: Toggling CR4.SMAP does not load PDPTEs in PAE mode Jessica Clarke <jrtc27(a)jrtc27.com> arch/ia64: Restore arch-specific pgd_offset_k implementation Alex Williamson <alex.williamson(a)redhat.com> vfio/type1: Add proper error unwind for vfio_iommu_replay() Alex Williamson <alex.williamson(a)redhat.com> vfio-pci: Avoid recursive read-lock usage David Howells <dhowells(a)redhat.com> watch_queue: Limit the number of watches a user can hold Dinghao Liu <dinghao.liu(a)zju.edu.cn> ASoC: intel: Fix memleak in sst_media_open Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> ASoC: msm8916-wcd-analog: fix register Interrupt offset Heiko Carstens <hca(a)linux.ibm.com> s390/ptrace: fix storage key handling Heiko Carstens <hca(a)linux.ibm.com> s390/runtime_instrumentation: fix storage key handling Mahesh Bandewar <maheshb(a)google.com> ipvlan: fix device features Cong Wang <xiyou.wangcong(a)gmail.com> bonding: fix a potential double-unregister Zhang Changzhong <zhangchangzhong(a)huawei.com> can: j1939: add rxtimer for multipacket broadcast session Zhang Changzhong <zhangchangzhong(a)huawei.com> can: j1939: abort multipacket broadcast session when timeout occurs Zhang Changzhong <zhangchangzhong(a)huawei.com> can: j1939: cancel rxtimer on multipacket broadcast session complete Zhang Changzhong <zhangchangzhong(a)huawei.com> can: j1939: fix support for multipacket broadcast message Jarod Wilson <jarod(a)redhat.com> bonding: show saner speed for broadcast mode Fugang Duan <fugang.duan(a)nxp.com> net: fec: correct the error path for regulator disable in probe Grzegorz Szczurek <grzegorzx.szczurek(a)intel.com> i40e: Fix crash during removing i40e driver Przemyslaw Patynowski <przemyslawx.patynowski(a)intel.com> i40e: Set RX_ONLY mode for unicast promiscuous on VLAN Vinicius Costa Gomes <vinicius.gomes(a)intel.com> igc: Fix PTP initialization Oleksij Rempel <linux(a)rempel-privat.de> can: j1939: transport: add j1939_session_skb_find_by_offset() function Oleksij Rempel <linux(a)rempel-privat.de> can: j1939: transport: j1939_simple_recv(): ignore local J1939 messages send not by J1939 stack Eric Dumazet <edumazet(a)google.com> can: j1939: fix kernel-infoleak in j1939_sk_sock2sockaddr_can() Andrii Nakryiko <andriin(a)fb.com> libbpf: Fix BTF-defined map-in-map initialization on 32-bit host arches John Fastabend <john.fastabend(a)gmail.com> bpf: sock_ops sk access may stomp registers when dst_reg = src_reg John Fastabend <john.fastabend(a)gmail.com> bpf: sock_ops ctx access may stomp registers in corner case Andrii Nakryiko <andriin(a)fb.com> tools/bpftool: Make skeleton code C++17-friendly by dropping typeof() Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> ASoC: q6routing: add dummy register read/write function Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> ASoC: q6afe-dai: mark all widgets registers as SND_SOC_NOPM Amelie Delaunay <amelie.delaunay(a)st.com> spi: stm32: fixes suspend/resume management Stephen Suryaputra <ssuryaextr(a)gmail.com> netfilter: nf_tables: nft_exthdr: the presence return value should be little-endian Jan Kara <jack(a)suse.cz> ext4: check journal inode extents more carefully Jan Kara <jack(a)suse.cz> ext4: don't allow overlapping system zones Qi Liu <liuqi.16(a)bytedance.com> drm/virtio: fix missing dma_fence_put() in virtio_gpu_execbuffer_ioctl() Eric Sandeen <sandeen(a)redhat.com> ext4: fix potential negative array index in do_split() Helge Deller <deller(a)gmx.de> fs/signalfd.c: fix inconsistent return codes for signalfd4 OGAWA Hirofumi <hirofumi(a)mail.parknet.co.jp> fat: fix fat_ra_init() for data clusters == 0 Luc Van Oostenryck <luc.vanoostenryck(a)gmail.com> alpha: fix annotation of io{read,write}{16,32}be() Eiichi Tsukata <devel(a)etsukata.com> xfs: Fix UBSAN null-ptr-deref in xfs_sysfs_init Gaurav Singh <gaurav1086(a)gmail.com> tools/testing/selftests/cgroup/cgroup_util.c: cg_read_strcmp: fix null pointer dereference Evgeny Novikov <novikov(a)ispras.ru> media: camss: fix memory leaks on error handling paths in probe Mao Wenan <wenan.mao(a)linux.alibaba.com> virtio_ring: Avoid loop when vq is broken in virtqueue_poll Javed Hasan <jhasan(a)marvell.com> scsi: libfc: Free skb in fc_disc_gpn_id_resp() for valid cases Srinivas Pandruvada <srinivas.pandruvada(a)linux.intel.com> cpufreq: intel_pstate: Fix cpuinfo_max_freq when MSR_TURBO_RATIO_LIMIT is 0 Boris Ostrovsky <boris.ostrovsky(a)oracle.com> swiotlb-xen: use vmalloc_to_page on vmalloc virt addresses Xiubo Li <xiubli(a)redhat.com> ceph: fix use-after-free for fsc->mdsc Zhe Li <lizhe67(a)huawei.com> jffs2: fix UAF problem Guo Ren <guoren(a)linux.alibaba.com> riscv: Fixup static_obj() fail Felix Kuehling <Felix.Kuehling(a)amd.com> drm/ttm: fix offset in VMAs with a pg_offs in ttm_bo_vm_access Darrick J. Wong <darrick.wong(a)oracle.com> xfs: fix inode quota reservation checks Chuck Lever <chuck.lever(a)oracle.com> svcrdma: Fix another Receive buffer leak Greg Ungerer <gerg(a)linux-m68k.org> m68knommu: fix overwriting of bits in ColdFire V3 cache control Jinyang He <hejinyang(a)loongson.cn> MIPS: Fix unable to reserve memory for Crash kernel Xiongfeng Wang <wangxiongfeng2(a)huawei.com> Input: psmouse - add a newline when printing 'proto' by sysfs Jaegeuk Kim <jaegeuk(a)kernel.org> f2fs: should avoid inode eviction in synchronous path Evgeny Novikov <novikov(a)ispras.ru> media: vpss: clean up resources in init Huacai Chen <chenhc(a)lemote.com> rtc: goldfish: Enable interrupt in set_alarm() when necessary Chao Yu <chao(a)kernel.org> f2fs: fix to check page dirty status before writeback Chen Zhou <chenzhou10(a)huawei.com> media: coda: jpeg: add NULL check after kmalloc Chuhong Yuan <hslester96(a)gmail.com> media: budget-core: Improve exception handling in budget_register() Bodo Stroesser <bstroesser(a)ts.fujitsu.com> scsi: target: tcmu: Fix crash in tcmu_flush_dcache_range on ARM Stanley Chu <stanley.chu(a)mediatek.com> scsi: ufs: Add DELAY_BEFORE_LPM quirk for Micron devices Chris Wilson <chris(a)chris-wilson.co.uk> drm/i915: Provide the perf pmu.module Pankaj Bharadiya <pankaj.laxminarayan.bharadiya(a)intel.com> drm/i915/pmu: Prefer drm_WARN_ON over WARN_ON Krunoslav Kovac <Krunoslav.Kovac(a)amd.com> drm/amd/display: fix pow() crashing when given base 0 Paul Hsieh <paul.hsieh(a)amd.com> drm/amd/display: Fix DFPstate hang due to view port changed Jaehyun Chung <jaehyun.chung(a)amd.com> drm/amd/display: Blank stream before destroying HDCP session Stylon Wang <stylon.wang(a)amd.com> drm/amd/display: Fix EDID parsing after resume from suspend Aric Cyr <aric.cyr(a)amd.com> drm/amd/display: Fix incorrect backlight register offset for DCN Daniel Kolesa <daniel(a)octaforge.org> drm/amdgpu/display: use GFP_ATOMIC in dcn20_validate_bandwidth_internal Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> drm: amdgpu: Use the correct size when allocating memory Yang Shi <shy828301(a)gmail.com> mm/memory.c: skip spurious TLB flush for retried page fault Niklas Schnelle <schnelle(a)linux.ibm.com> s390/pci: ignore stale configuration request event Niklas Schnelle <schnelle(a)linux.ibm.com> s390/pci: fix PF/VF linking on hot plug Niklas Schnelle <schnelle(a)linux.ibm.com> s390/pci: re-introduce zpci_remove_device() Niklas Schnelle <schnelle(a)linux.ibm.com> s390/pci: fix zpci_bus_link_virtfn() Yang Weijiang <weijiang.yang(a)intel.com> selftests: kvm: Use a shorter encoding to clear RAX Will Deacon <will(a)kernel.org> KVM: Pass MMU notifier range flags to kvm_unmap_hva_range() Steffen Maier <maier(a)linux.ibm.com> scsi: zfcp: Fix use-after-free in request timeout handlers zhangyi (F) <yi.zhang(a)huawei.com> jbd2: add the missing unlock_buffer() in the error path of jbd2_write_superblock() Jan Kara <jack(a)suse.cz> ext4: fix checking of directory entry validity for inline directories Jan Kara <jack(a)suse.cz> ext4: do not block RWF_NOWAIT dio write on unallocated space Stephen Boyd <swboyd(a)chromium.org> opp: Put opp table in dev_pm_opp_set_rate() if _set_opp_bw() fails Stephen Boyd <swboyd(a)chromium.org> opp: Put opp table in dev_pm_opp_set_rate() for empty tables Rajendra Nayak <rnayak(a)codeaurora.org> opp: Enable resources again if they were disabled earlier Kaike Wan <kaike.wan(a)intel.com> RDMA/hfi1: Correct an interlock issue for TID RDMA WRITE request Hui Wang <hui.wang(a)canonical.com> ASoC: amd: renoir: restore two more registers during resume Charan Teja Reddy <charante(a)codeaurora.org> mm, page_alloc: fix core hung in free_pcppages_bulk() Doug Berger <opendmb(a)gmail.com> mm: include CMA pages in lowmem_reserve at boot Phillip Lougher <phillip(a)squashfs.org.uk> squashfs: avoid bio_alloc() failure with 1Mbyte blocks Hugh Dickins <hughd(a)google.com> uprobes: __replace_page() avoid BUG in munlock_vma_page() Wei Yongjun <weiyongjun1(a)huawei.com> kernel/relay.c: fix memleak on destroy relay channel Jann Horn <jannh(a)google.com> romfs: fix uninitialized memory leak in romfs_dev_read() Aneesh Kumar K.V <aneesh.kumar(a)linux.ibm.com> mm/vunmap: add cond_resched() in vunmap_pmd_range Jens Axboe <axboe(a)kernel.dk> io_uring: find and cancel head link async work on files exit Lukas Wunner <lukas(a)wunner.de> spi: Prevent adding devices below an unregistering controller Oleksij Rempel <linux(a)rempel-privat.de> can: j1939: socket: j1939_sk_bind(): make sure ml_priv is allocated Oleksij Rempel <linux(a)rempel-privat.de> can: j1939: transport: j1939_session_tx_dat(): fix use-after-free read in j1939_tp_txtimer() Mike Pozulp <pozulp.kernel(a)gmail.com> ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion Mike Pozulp <pozulp.kernel(a)gmail.com> ALSA: hda/realtek: Add quirk for Samsung Galaxy Flex Book Sameer Pujar <spujar(a)nvidia.com> ALSA: hda: avoid reset of sdo_limit Hugh Dickins <hughd(a)google.com> khugepaged: adjust VM_BUG_ON_MM() in __khugepaged_enter() Thomas Zimmermann <tzimmermann(a)suse.de> drm/ast: Initialize DRAM type before posting GPU Thomas Zimmermann <tzimmermann(a)suse.de> drm/ast: Remove unused code paths for AST 1180 Paul Cercueil <paul(a)crapouillou.net> drm/panel-simple: Fix inverted V/H SYNC for Frida FRD350H54004 panel Chris Wilson <chris(a)chris-wilson.co.uk> drm/vgem: Replace opencoded version of drm_gem_dumb_map_offset() ------------- Diffstat: Makefile | 4 +- arch/alpha/include/asm/io.h | 8 +- arch/arm64/Makefile | 1 + arch/arm64/include/asm/kvm_host.h | 2 +- arch/arm64/kernel/vdso32/Makefile | 2 +- arch/arm64/kvm/mmu.c | 2 +- arch/ia64/include/asm/pgtable.h | 9 + arch/m68k/include/asm/m53xxacr.h | 6 +- arch/mips/include/asm/kvm_host.h | 2 +- arch/mips/kernel/setup.c | 2 +- arch/mips/kvm/mmu.c | 3 +- arch/powerpc/include/asm/fixmap.h | 2 +- arch/powerpc/include/asm/kvm_host.h | 3 +- arch/powerpc/kernel/cputable.c | 20 ++ arch/powerpc/kernel/setup-common.c | 1 + arch/powerpc/kvm/book3s.c | 3 +- arch/powerpc/kvm/e500_mmu_host.c | 3 +- arch/powerpc/platforms/pseries/hotplug-cpu.c | 18 +- arch/powerpc/platforms/pseries/ras.c | 1 - arch/riscv/kernel/vmlinux.lds.S | 2 +- arch/s390/kernel/ptrace.c | 7 +- arch/s390/kernel/runtime_instr.c | 2 +- arch/s390/pci/pci.c | 22 ++- arch/s390/pci/pci_bus.c | 52 ++--- arch/s390/pci/pci_bus.h | 13 ++ arch/s390/pci/pci_event.c | 7 +- arch/x86/include/asm/kvm_host.h | 3 +- arch/x86/kvm/mmu/mmu.c | 3 +- arch/x86/kvm/x86.c | 2 +- arch/x86/pci/xen.c | 1 + arch/x86/platform/efi/efi_64.c | 2 + drivers/cpufreq/intel_pstate.c | 1 + drivers/edac/i7core_edac.c | 4 +- drivers/edac/pnd2_edac.c | 2 +- drivers/edac/sb_edac.c | 4 +- drivers/edac/skx_common.c | 4 +- drivers/firmware/efi/efi.c | 2 + drivers/firmware/efi/libstub/efi-stub-helper.c | 12 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 +- .../gpu/drm/amd/display/dc/dce/dce_panel_cntl.h | 2 +- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 4 +- .../gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 2 +- drivers/gpu/drm/amd/display/include/fixed31_32.h | 3 + drivers/gpu/drm/ast/ast_drv.c | 1 - drivers/gpu/drm/ast/ast_drv.h | 2 - drivers/gpu/drm/ast/ast_main.c | 91 ++++----- drivers/gpu/drm/ast/ast_mode.c | 11 +- drivers/gpu/drm/ast/ast_post.c | 10 +- drivers/gpu/drm/i915/i915_pmu.c | 17 +- drivers/gpu/drm/panel/panel-simple.c | 2 +- drivers/gpu/drm/ttm/ttm_bo_vm.c | 4 +- drivers/gpu/drm/vgem/vgem_drv.c | 27 --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 1 + drivers/infiniband/hw/bnxt_re/main.c | 3 +- drivers/infiniband/hw/hfi1/tid_rdma.c | 1 + drivers/infiniband/hw/hns/hns_roce_device.h | 2 - drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 9 +- drivers/infiniband/hw/hns/hns_roce_hw_v2.h | 4 +- drivers/infiniband/hw/hns/hns_roce_qp.c | 5 +- drivers/infiniband/hw/hns/hns_roce_srq.c | 2 +- drivers/input/mouse/psmouse-base.c | 2 +- drivers/media/pci/ttpci/budget-core.c | 11 +- drivers/media/platform/coda/coda-jpeg.c | 5 +- drivers/media/platform/davinci/vpss.c | 20 +- drivers/media/platform/qcom/camss/camss.c | 30 ++- drivers/net/bonding/bond_main.c | 42 ++++- drivers/net/dsa/b53/b53_common.c | 2 + drivers/net/ethernet/amazon/ena/ena_netdev.c | 30 ++- drivers/net/ethernet/cortina/gemini.c | 4 +- drivers/net/ethernet/freescale/fec_main.c | 4 +- drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h | 2 +- drivers/net/ethernet/intel/i40e/i40e_common.c | 35 +++- drivers/net/ethernet/intel/i40e/i40e_main.c | 3 + drivers/net/ethernet/intel/igc/igc_main.c | 5 +- drivers/net/ethernet/intel/igc/igc_ptp.c | 2 - drivers/net/hyperv/netvsc_drv.c | 2 +- drivers/net/ipvlan/ipvlan_main.c | 27 ++- drivers/of/address.c | 5 + drivers/opp/core.c | 19 +- drivers/pci/hotplug/s390_pci_hpc.c | 12 +- drivers/rtc/rtc-goldfish.c | 1 + drivers/s390/scsi/zfcp_fsf.c | 4 +- drivers/scsi/libfc/fc_disc.c | 12 +- drivers/scsi/qla2xxx/qla_os.c | 4 - drivers/scsi/ufs/ti-j721e-ufs.c | 1 + drivers/scsi/ufs/ufs_quirks.h | 1 + drivers/scsi/ufs/ufshcd-pci.c | 16 +- drivers/scsi/ufs/ufshcd.c | 130 +++++++++++-- drivers/scsi/ufs/ufshcd.h | 38 +++- drivers/spi/Kconfig | 3 + drivers/spi/spi-stm32.c | 27 ++- drivers/spi/spi.c | 21 ++- drivers/target/target_core_user.c | 2 +- drivers/vfio/pci/vfio_pci_private.h | 2 + drivers/vfio/pci/vfio_pci_rdwr.c | 120 +++++++++--- drivers/vfio/vfio_iommu_type1.c | 71 ++++++- drivers/video/fbdev/efifb.c | 2 +- drivers/virtio/virtio_ring.c | 3 + drivers/xen/swiotlb-xen.c | 8 +- fs/afs/dynroot.c | 20 +- fs/afs/fs_operation.c | 1 + fs/ceph/mds_client.c | 3 +- fs/eventpoll.c | 26 +-- fs/ext4/block_validity.c | 87 ++++----- fs/ext4/ext4.h | 6 +- fs/ext4/extents.c | 16 +- fs/ext4/file.c | 4 + fs/ext4/indirect.c | 6 +- fs/ext4/inode.c | 5 +- fs/ext4/mballoc.c | 4 +- fs/ext4/namei.c | 22 ++- fs/f2fs/compress.c | 6 + fs/f2fs/node.c | 10 +- fs/fat/fatent.c | 3 + fs/io_uring.c | 33 +++- fs/jbd2/journal.c | 4 +- fs/jffs2/dir.c | 6 +- fs/romfs/storage.c | 4 +- fs/signalfd.c | 10 +- fs/squashfs/block.c | 6 +- fs/xfs/xfs_sysfs.h | 6 +- fs/xfs/xfs_trans_dquot.c | 2 +- include/linux/pgtable.h | 2 + include/linux/sched/user.h | 3 + kernel/bpf/task_iter.c | 3 +- kernel/events/uprobes.c | 2 +- kernel/relay.c | 1 + kernel/watch_queue.c | 8 + mm/khugepaged.c | 2 +- mm/memory.c | 3 + mm/page_alloc.c | 7 +- mm/vmalloc.c | 2 + net/can/j1939/socket.c | 14 ++ net/can/j1939/transport.c | 89 +++++++-- net/core/filter.c | 75 ++++++-- net/netfilter/nft_exthdr.c | 4 +- net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 2 + scripts/kconfig/qconf.cc | 72 ++++--- sound/hda/hdac_bus.c | 12 ++ sound/hda/hdac_controller.c | 11 -- sound/pci/hda/patch_realtek.c | 2 + sound/soc/amd/renoir/acp3x-pdm-dma.c | 29 +-- sound/soc/codecs/msm8916-wcd-analog.c | 4 +- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 5 +- sound/soc/qcom/qdsp6/q6afe-dai.c | 210 ++++++++++----------- sound/soc/qcom/qdsp6/q6routing.c | 16 ++ tools/bpf/bpftool/gen.c | 8 +- tools/lib/bpf/libbpf.c | 16 +- tools/testing/selftests/bpf/.gitignore | 1 - tools/testing/selftests/bpf/Makefile | 2 +- tools/testing/selftests/cgroup/cgroup_util.c | 2 +- tools/testing/selftests/kvm/x86_64/debug_regs.c | 4 +- virt/kvm/kvm_main.c | 3 +- 155 files changed, 1385 insertions(+), 693 deletions(-)

4 years, 4 months

5
152
0 0

[PATCH stable v4.9 v2] arm64: entry: Place an SB sequence following an ERET instruction

by Florian Fainelli

From: Will Deacon <will.deacon(a)arm.com> commit 679db70801da9fda91d26caf13bf5b5ccc74e8e8 upstream Some CPUs can speculate past an ERET instruction and potentially perform speculative accesses to memory before processing the exception return. Since the register state is often controlled by a lower privilege level at the point of an ERET, this could potentially be used as part of a side-channel attack. This patch emits an SB sequence after each ERET so that speculation is held up on exception return. Signed-off-by: Will Deacon <will.deacon(a)arm.com> [florian: Adjust hyp-entry.S to account for the label added change to hyp/entry.S] Signed-off-by: Florian Fainelli <f.fainelli(a)gmail.com> --- Changes in v2: - added missing hunk in hyp/entry.S per Will's feedback arch/arm64/kernel/entry.S | 2 ++ arch/arm64/kvm/hyp/entry.S | 2 ++ arch/arm64/kvm/hyp/hyp-entry.S | 4 ++++ 3 files changed, 8 insertions(+) diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S index ca978d7d98eb..3408c782702c 100644 --- a/arch/arm64/kernel/entry.S +++ b/arch/arm64/kernel/entry.S @@ -255,6 +255,7 @@ alternative_insn eret, nop, ARM64_UNMAP_KERNEL_AT_EL0 .else eret .endif + sb .endm .macro get_thread_info, rd @@ -945,6 +946,7 @@ __ni_sys_trace: mrs x30, far_el1 .endif eret + sb .endm .align 11 diff --git a/arch/arm64/kvm/hyp/entry.S b/arch/arm64/kvm/hyp/entry.S index a360ac6e89e9..93704e6894d2 100644 --- a/arch/arm64/kvm/hyp/entry.S +++ b/arch/arm64/kvm/hyp/entry.S @@ -83,6 +83,7 @@ ENTRY(__guest_enter) // Do not touch any register after this! eret + sb ENDPROC(__guest_enter) ENTRY(__guest_exit) @@ -195,4 +196,5 @@ alternative_endif ldp x0, x1, [sp], #16 eret + sb ENDPROC(__fpsimd_guest_restore) diff --git a/arch/arm64/kvm/hyp/hyp-entry.S b/arch/arm64/kvm/hyp/hyp-entry.S index bf4988f9dae8..3675e7f0ab72 100644 --- a/arch/arm64/kvm/hyp/hyp-entry.S +++ b/arch/arm64/kvm/hyp/hyp-entry.S @@ -97,6 +97,7 @@ el1_sync: // Guest trapped into EL2 do_el2_call 2: eret + sb el1_hvc_guest: /* @@ -147,6 +148,7 @@ wa_epilogue: mov x0, xzr add sp, sp, #16 eret + sb el1_trap: get_vcpu_ptr x1, x0 @@ -198,6 +200,7 @@ el2_error: b.ne __hyp_panic mov x0, #(1 << ARM_EXIT_WITH_SERROR_BIT) eret + sb ENTRY(__hyp_do_panic) mov lr, #(PSR_F_BIT | PSR_I_BIT | PSR_A_BIT | PSR_D_BIT |\ @@ -206,6 +209,7 @@ ENTRY(__hyp_do_panic) ldr lr, =panic msr elr_el2, lr eret + sb ENDPROC(__hyp_do_panic) ENTRY(__hyp_panic) -- 2.17.1

4 years, 4 months

4
11
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror August 2020