August 2020 - Linux-stable-mirror

by Greg Kroah-Hartman

I'm announcing the release of the 5.7.14 kernel. All users of the 5.7 kernel series must upgrade. The updated 5.7.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.7.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 arch/arm/include/asm/percpu.h | 2 arch/arm64/include/asm/archrandom.h | 1 arch/arm64/include/asm/pointer_auth.h | 8 +++ arch/arm64/kernel/kaslr.c | 2 drivers/char/random.c | 1 include/linux/prandom.h | 78 ++++++++++++++++++++++++++++++++++ include/linux/random.h | 63 +-------------------------- kernel/time/timer.c | 8 +++ lib/random32.c | 2 10 files changed, 103 insertions(+), 64 deletions(-) Greg Kroah-Hartman (1): Linux 5.7.14 Grygorii Strashko (1): ARM: percpu.h: fix build error Linus Torvalds (3): random32: remove net_rand_state from the latent entropy gcc plugin random32: move the pseudo-random 32-bit definitions to prandom.h random: random.h should include archrandom.h, not the other way around Marc Zyngier (1): arm64: Workaround circular dependency in pointer_auth.h Willy Tarreau (2): random32: update the net random state on interrupt and activity random: fix circular include dependency on arm64 after addition of percpu.h

4 years, 5 months

1
1
0 0

Linux 5.4.57

by Greg Kroah-Hartman

I'm announcing the release of the 5.4.57 kernel. All users of the 5.4 kernel series must upgrade. The updated 5.4.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.4.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 arch/arm/include/asm/percpu.h | 2 arch/arm64/include/asm/pointer_auth.h | 8 ++- drivers/char/random.c | 1 fs/ext4/inode.c | 5 ++ include/linux/bpf.h | 13 ++++- include/linux/prandom.h | 78 ++++++++++++++++++++++++++++++++ include/linux/random.h | 63 +------------------------ include/linux/skmsg.h | 13 +++++ kernel/bpf/syscall.c | 4 - kernel/time/timer.c | 8 +++ lib/random32.c | 2 net/core/sock_map.c | 50 ++++++++++++++++++-- tools/testing/selftests/bpf/test_maps.c | 12 ++-- 14 files changed, 184 insertions(+), 77 deletions(-) Greg Kroah-Hartman (1): Linux 5.4.57 Grygorii Strashko (1): ARM: percpu.h: fix build error Jiang Ying (1): ext4: fix direct I/O read error Linus Torvalds (2): random32: remove net_rand_state from the latent entropy gcc plugin random32: move the pseudo-random 32-bit definitions to prandom.h Lorenz Bauer (2): selftests: bpf: Fix detach from sockmap tests bpf: sockmap: Require attach_bpf_fd when detaching a program Marc Zyngier (1): arm64: Workaround circular dependency in pointer_auth.h Willy Tarreau (2): random32: update the net random state on interrupt and activity random: fix circular include dependency on arm64 after addition of percpu.h

4 years, 5 months

1
1
0 0

Linux 4.19.138

by Greg Kroah-Hartman

I'm announcing the release of the 4.19.138 kernel. All users of the 4.19 kernel series must upgrade. The updated 4.19.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.19.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 - arch/arm/include/asm/percpu.h | 2 + drivers/char/random.c | 1 fs/ext4/inode.c | 5 ++ include/linux/prandom.h | 78 ++++++++++++++++++++++++++++++++++++++++++ include/linux/random.h | 63 ++------------------------------- kernel/time/timer.c | 8 ++++ lib/random32.c | 2 - 8 files changed, 100 insertions(+), 61 deletions(-) Greg Kroah-Hartman (1): Linux 4.19.138 Grygorii Strashko (1): ARM: percpu.h: fix build error Jiang Ying (1): ext4: fix direct I/O read error Linus Torvalds (2): random32: remove net_rand_state from the latent entropy gcc plugin random32: move the pseudo-random 32-bit definitions to prandom.h Willy Tarreau (2): random32: update the net random state on interrupt and activity random: fix circular include dependency on arm64 after addition of percpu.h

4 years, 5 months

1
1
0 0

Linux 4.14.193

by Greg Kroah-Hartman

I'm announcing the release of the 4.14.193 kernel. All users of the 4.14 kernel series must upgrade. The updated 4.14.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.14.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 arch/arm/include/asm/percpu.h | 2 arch/arm/kernel/head-common.S | 1 drivers/char/random.c | 1 drivers/scsi/libsas/sas_ata.c | 1 drivers/scsi/libsas/sas_discover.c | 32 ++++++--------- drivers/scsi/libsas/sas_expander.c | 8 ++- drivers/scsi/libsas/sas_internal.h | 1 drivers/scsi/libsas/sas_port.c | 3 - fs/ext4/inode.c | 5 ++ include/linux/prandom.h | 78 +++++++++++++++++++++++++++++++++++++ include/linux/random.h | 63 +---------------------------- include/scsi/libsas.h | 3 - include/scsi/scsi_transport_sas.h | 1 kernel/time/timer.c | 8 +++ lib/random32.c | 2 16 files changed, 123 insertions(+), 88 deletions(-) Geert Uytterhoeven (1): ARM: 8702/1: head-common.S: Clear lr before jumping to start_kernel() Greg Kroah-Hartman (2): Revert "scsi: libsas: direct call probe and destruct" Linux 4.14.193 Grygorii Strashko (1): ARM: percpu.h: fix build error Jiang Ying (1): ext4: fix direct I/O read error Linus Torvalds (2): random32: remove net_rand_state from the latent entropy gcc plugin random32: move the pseudo-random 32-bit definitions to prandom.h Willy Tarreau (2): random32: update the net random state on interrupt and activity random: fix circular include dependency on arm64 after addition of percpu.h

4 years, 5 months

1
1
0 0

[PATCH 5.7 0/7] 5.7.14-rc2 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.7.14 release. There are 7 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Fri, 07 Aug 2020 19:59:06 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.7.14-rc2… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.7.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.7.14-rc2 Linus Torvalds <torvalds(a)linux-foundation.org> random: random.h should include archrandom.h, not the other way around Marc Zyngier <maz(a)kernel.org> arm64: Workaround circular dependency in pointer_auth.h Linus Torvalds <torvalds(a)linux-foundation.org> random32: move the pseudo-random 32-bit definitions to prandom.h Linus Torvalds <torvalds(a)linux-foundation.org> random32: remove net_rand_state from the latent entropy gcc plugin Willy Tarreau <w(a)1wt.eu> random: fix circular include dependency on arm64 after addition of percpu.h Grygorii Strashko <grygorii.strashko(a)ti.com> ARM: percpu.h: fix build error Willy Tarreau <w(a)1wt.eu> random32: update the net random state on interrupt and activity ------------- Diffstat: Makefile | 4 +- arch/arm/include/asm/percpu.h | 2 + arch/arm64/include/asm/archrandom.h | 1 - arch/arm64/include/asm/pointer_auth.h | 8 +++- arch/arm64/kernel/kaslr.c | 2 +- drivers/char/random.c | 1 + include/linux/prandom.h | 78 +++++++++++++++++++++++++++++++++++ include/linux/random.h | 63 ++-------------------------- kernel/time/timer.c | 8 ++++ lib/random32.c | 2 +- 10 files changed, 104 insertions(+), 65 deletions(-)

4 years, 5 months

5
8
0 0

[PATCH 4.19 0/6] 4.19.138-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.138 release. There are 6 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Fri, 07 Aug 2020 15:34:53 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.138-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.138-rc1 Jiang Ying <jiangying8582(a)126.com> ext4: fix direct I/O read error Linus Torvalds <torvalds(a)linux-foundation.org> random32: move the pseudo-random 32-bit definitions to prandom.h Linus Torvalds <torvalds(a)linux-foundation.org> random32: remove net_rand_state from the latent entropy gcc plugin Willy Tarreau <w(a)1wt.eu> random: fix circular include dependency on arm64 after addition of percpu.h Grygorii Strashko <grygorii.strashko(a)ti.com> ARM: percpu.h: fix build error Willy Tarreau <w(a)1wt.eu> random32: update the net random state on interrupt and activity ------------- Diffstat: Makefile | 4 +-- arch/arm/include/asm/percpu.h | 2 ++ drivers/char/random.c | 1 + fs/ext4/inode.c | 5 +++ include/linux/prandom.h | 78 +++++++++++++++++++++++++++++++++++++++++++ include/linux/random.h | 63 +++------------------------------- kernel/time/timer.c | 8 +++++ lib/random32.c | 2 +- 8 files changed, 101 insertions(+), 62 deletions(-)

4 years, 5 months

6
12
0 0

[patch 161/163] khugepaged: khugepaged_test_exit() check mmget_still_valid()

by Andrew Morton

From: Hugh Dickins <hughd(a)google.com> Subject: khugepaged: khugepaged_test_exit() check mmget_still_valid() Move collapse_huge_page()'s mmget_still_valid() check into khugepaged_test_exit() itself. collapse_huge_page() is used for anon THP only, and earned its mmget_still_valid() check because it inserts a huge pmd entry in place of the page table's pmd entry; whereas collapse_file()'s retract_page_tables() or collapse_pte_mapped_thp() merely clears the page table's pmd entry. But core dumping without mmap lock must have been as open to mistaking a racily cleared pmd entry for a page table at physical page 0, as exit_mmap() was. And we certainly have no interest in mapping as a THP once dumping core. Link: http://lkml.kernel.org/r/alpine.LSU.2.11.2008021217020.27773@eggly.anvils Fixes: 59ea6d06cfa9 ("coredump: fix race condition between collapse_huge_page() and core dumping") Signed-off-by: Hugh Dickins <hughd(a)google.com> Cc: Andrea Arcangeli <aarcange(a)redhat.com> Cc: Song Liu <songliubraving(a)fb.com> Cc: Mike Kravetz <mike.kravetz(a)oracle.com> Cc: Kirill A. Shutemov <kirill.shutemov(a)linux.intel.com> Cc: <stable(a)vger.kernel.org> [4.8+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/khugepaged.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/mm/khugepaged.c~khugepaged-khugepaged_test_exit-check-mmget_still_valid +++ a/mm/khugepaged.c @@ -431,7 +431,7 @@ static void insert_to_mm_slots_hash(stru static inline int khugepaged_test_exit(struct mm_struct *mm) { - return atomic_read(&mm->mm_users) == 0; + return atomic_read(&mm->mm_users) == 0 || !mmget_still_valid(mm); } static bool hugepage_vma_check(struct vm_area_struct *vma, @@ -1100,9 +1100,6 @@ static void collapse_huge_page(struct mm * handled by the anon_vma lock + PG_lock. */ mmap_write_lock(mm); - result = SCAN_ANY_PROCESS; - if (!mmget_still_valid(mm)) - goto out; result = hugepage_vma_revalidate(mm, address, &vma); if (result) goto out; _

4 years, 5 months

1
0
0 0

[patch 160/163] khugepaged: retract_page_tables() remember to test exit

by Andrew Morton

From: Hugh Dickins <hughd(a)google.com> Subject: khugepaged: retract_page_tables() remember to test exit Only once have I seen this scenario (and forgot even to notice what forced the eventual crash): a sequence of "BUG: Bad page map" alerts from vm_normal_page(), from zap_pte_range() servicing exit_mmap(); pmd:00000000, pte values corresponding to data in physical page 0. The pte mappings being zapped in this case were supposed to be from a huge page of ext4 text (but could as well have been shmem): my belief is that it was racing with collapse_file()'s retract_page_tables(), found *pmd pointing to a page table, locked it, but *pmd had become 0 by the time start_pte was decided. In most cases, that possibility is excluded by holding mmap lock; but exit_mmap() proceeds without mmap lock. Most of what's run by khugepaged checks khugepaged_test_exit() after acquiring mmap lock: khugepaged_collapse_pte_mapped_thps() and hugepage_vma_revalidate() do so, for example. But retract_page_tables() did not: fix that. The fix is for retract_page_tables() to check khugepaged_test_exit(), after acquiring mmap lock, before doing anything to the page table. Getting the mmap lock serializes with __mmput(), which briefly takes and drops it in __khugepaged_exit(); then the khugepaged_test_exit() check on mm_users makes sure we don't touch the page table once exit_mmap() might reach it, since exit_mmap() will be proceeding without mmap lock, not expecting anyone to be racing with it. Link: http://lkml.kernel.org/r/alpine.LSU.2.11.2008021215400.27773@eggly.anvils Fixes: f3f0e1d2150b ("khugepaged: add support of collapse for tmpfs/shmem pages") Signed-off-by: Hugh Dickins <hughd(a)google.com> Acked-by: Kirill A. Shutemov <kirill.shutemov(a)linux.intel.com> Cc: Andrea Arcangeli <aarcange(a)redhat.com> Cc: Mike Kravetz <mike.kravetz(a)oracle.com> Cc: Song Liu <songliubraving(a)fb.com> Cc: <stable(a)vger.kernel.org> [4.8+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/khugepaged.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) --- a/mm/khugepaged.c~khugepaged-retract_page_tables-remember-to-test-exit +++ a/mm/khugepaged.c @@ -1532,6 +1532,7 @@ out: static void retract_page_tables(struct address_space *mapping, pgoff_t pgoff) { struct vm_area_struct *vma; + struct mm_struct *mm; unsigned long addr; pmd_t *pmd, _pmd; @@ -1560,7 +1561,8 @@ static void retract_page_tables(struct a continue; if (vma->vm_end < addr + HPAGE_PMD_SIZE) continue; - pmd = mm_find_pmd(vma->vm_mm, addr); + mm = vma->vm_mm; + pmd = mm_find_pmd(mm, addr); if (!pmd) continue; /* @@ -1570,17 +1572,19 @@ static void retract_page_tables(struct a * mmap_lock while holding page lock. Fault path does it in * reverse order. Trylock is a way to avoid deadlock. */ - if (mmap_write_trylock(vma->vm_mm)) { - spinlock_t *ptl = pmd_lock(vma->vm_mm, pmd); - /* assume page table is clear */ - _pmd = pmdp_collapse_flush(vma, addr, pmd); - spin_unlock(ptl); - mmap_write_unlock(vma->vm_mm); - mm_dec_nr_ptes(vma->vm_mm); - pte_free(vma->vm_mm, pmd_pgtable(_pmd)); + if (mmap_write_trylock(mm)) { + if (!khugepaged_test_exit(mm)) { + spinlock_t *ptl = pmd_lock(mm, pmd); + /* assume page table is clear */ + _pmd = pmdp_collapse_flush(vma, addr, pmd); + spin_unlock(ptl); + mm_dec_nr_ptes(mm); + pte_free(mm, pmd_pgtable(_pmd)); + } + mmap_write_unlock(mm); } else { /* Try again later */ - khugepaged_add_pte_mapped_thp(vma->vm_mm, addr); + khugepaged_add_pte_mapped_thp(mm, addr); } } i_mmap_unlock_write(mapping); _

4 years, 5 months

1
0
0 0

[patch 159/163] khugepaged: collapse_pte_mapped_thp() protect the pmd lock

by Andrew Morton

From: Hugh Dickins <hughd(a)google.com> Subject: khugepaged: collapse_pte_mapped_thp() protect the pmd lock When retract_page_tables() removes a page table to make way for a huge pmd, it holds huge page lock, i_mmap_lock_write, mmap_write_trylock and pmd lock; but when collapse_pte_mapped_thp() does the same (to handle the case when the original mmap_write_trylock had failed), only mmap_write_trylock and pmd lock are held. That's not enough. One machine has twice crashed under load, with "BUG: spinlock bad magic" and GPF on 6b6b6b6b6b6b6b6b. Examining the second crash, page_vma_mapped_walk_done()'s spin_unlock of pvmw->ptl (serving page_referenced() on a file THP, that had found a page table at *pmd) discovers that the page table page and its lock have already been freed by the time it comes to unlock. Follow the example of retract_page_tables(), but we only need one of huge page lock or i_mmap_lock_write to secure against this: because it's the narrower lock, and because it simplifies collapse_pte_mapped_thp() to know the hpage earlier, choose to rely on huge page lock here. Link: http://lkml.kernel.org/r/alpine.LSU.2.11.2008021213070.27773@eggly.anvils Fixes: 27e1f8273113 ("khugepaged: enable collapse pmd for pte-mapped THP") Signed-off-by: Hugh Dickins <hughd(a)google.com> Acked-by: Kirill A. Shutemov <kirill.shutemov(a)linux.intel.com> Cc: Andrea Arcangeli <aarcange(a)redhat.com> Cc: Mike Kravetz <mike.kravetz(a)oracle.com> Cc: Song Liu <songliubraving(a)fb.com> Cc: <stable(a)vger.kernel.org> [5.4+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/khugepaged.c | 44 +++++++++++++++++++------------------------- 1 file changed, 19 insertions(+), 25 deletions(-) --- a/mm/khugepaged.c~khugepaged-collapse_pte_mapped_thp-protect-the-pmd-lock +++ a/mm/khugepaged.c @@ -1412,7 +1412,7 @@ void collapse_pte_mapped_thp(struct mm_s { unsigned long haddr = addr & HPAGE_PMD_MASK; struct vm_area_struct *vma = find_vma(mm, haddr); - struct page *hpage = NULL; + struct page *hpage; pte_t *start_pte, *pte; pmd_t *pmd, _pmd; spinlock_t *ptl; @@ -1432,9 +1432,17 @@ void collapse_pte_mapped_thp(struct mm_s if (!hugepage_vma_check(vma, vma->vm_flags | VM_HUGEPAGE)) return; + hpage = find_lock_page(vma->vm_file->f_mapping, + linear_page_index(vma, haddr)); + if (!hpage) + return; + + if (!PageHead(hpage)) + goto drop_hpage; + pmd = mm_find_pmd(mm, haddr); if (!pmd) - return; + goto drop_hpage; start_pte = pte_offset_map_lock(mm, pmd, haddr, &ptl); @@ -1453,30 +1461,11 @@ void collapse_pte_mapped_thp(struct mm_s page = vm_normal_page(vma, addr, *pte); - if (!page || !PageCompound(page)) - goto abort; - - if (!hpage) { - hpage = compound_head(page); - /* - * The mapping of the THP should not change. - * - * Note that uprobe, debugger, or MAP_PRIVATE may - * change the page table, but the new page will - * not pass PageCompound() check. - */ - if (WARN_ON(hpage->mapping != vma->vm_file->f_mapping)) - goto abort; - } - /* - * Confirm the page maps to the correct subpage. - * - * Note that uprobe, debugger, or MAP_PRIVATE may change - * the page table, but the new page will not pass - * PageCompound() check. + * Note that uprobe, debugger, or MAP_PRIVATE may change the + * page table, but the new page will not be a subpage of hpage. */ - if (WARN_ON(hpage + i != page)) + if (hpage + i != page) goto abort; count++; } @@ -1495,7 +1484,7 @@ void collapse_pte_mapped_thp(struct mm_s pte_unmap_unlock(start_pte, ptl); /* step 3: set proper refcount and mm_counters. */ - if (hpage) { + if (count) { page_ref_sub(hpage, count); add_mm_counter(vma->vm_mm, mm_counter_file(hpage), -count); } @@ -1506,10 +1495,15 @@ void collapse_pte_mapped_thp(struct mm_s spin_unlock(ptl); mm_dec_nr_ptes(mm); pte_free(mm, pmd_pgtable(_pmd)); + +drop_hpage: + unlock_page(hpage); + put_page(hpage); return; abort: pte_unmap_unlock(start_pte, ptl); + goto drop_hpage; } static int khugepaged_collapse_pte_mapped_thps(struct mm_slot *mm_slot) _

4 years, 5 months

1
0
0 0

[patch 158/163] khugepaged: collapse_pte_mapped_thp() flush the right range

by Andrew Morton

From: Hugh Dickins <hughd(a)google.com> Subject: khugepaged: collapse_pte_mapped_thp() flush the right range pmdp_collapse_flush() should be given the start address at which the huge page is mapped, haddr: it was given addr, which at that point has been used as a local variable, incremented to the end address of the extent. Found by source inspection while chasing a hugepage locking bug, which I then could not explain by this. At first I thought this was very bad; then saw that all of the page translations that were not flushed would actually still point to the right pages afterwards, so harmless; then realized that I know nothing of how different architectures and models cache intermediate paging structures, so maybe it matters after all - particularly since the page table concerned is immediately freed. Much easier to fix than to think about. Link: http://lkml.kernel.org/r/alpine.LSU.2.11.2008021204390.27773@eggly.anvils Fixes: 27e1f8273113 ("khugepaged: enable collapse pmd for pte-mapped THP") Signed-off-by: Hugh Dickins <hughd(a)google.com> Acked-by: Kirill A. Shutemov <kirill.shutemov(a)linux.intel.com> Cc: Andrea Arcangeli <aarcange(a)redhat.com> Cc: Mike Kravetz <mike.kravetz(a)oracle.com> Cc: Song Liu <songliubraving(a)fb.com> Cc: <stable(a)vger.kernel.org> [5.4+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/khugepaged.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/khugepaged.c~khugepaged-collapse_pte_mapped_thp-flush-the-right-range +++ a/mm/khugepaged.c @@ -1502,7 +1502,7 @@ void collapse_pte_mapped_thp(struct mm_s /* step 4: collapse pmd */ ptl = pmd_lock(vma->vm_mm, pmd); - _pmd = pmdp_collapse_flush(vma, addr, pmd); + _pmd = pmdp_collapse_flush(vma, haddr, pmd); spin_unlock(ptl); mm_dec_nr_ptes(mm); pte_free(mm, pmd_pgtable(_pmd)); _

4 years, 5 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror August 2020