June 2020 - Linux-stable-mirror

[PATCH AUTOSEL 5.4 01/14] Input: mms114 - fix handling of mms345l

by Sasha Levin

From: Stephan Gerhold <stephan(a)gerhold.net> [ Upstream commit 3f8f770575d911c989043d8f0fb8dec96360c41c ] MMS345L is another first generation touch screen from Melfas, which uses the same registers as MMS152. However, using I2C_M_NOSTART for it causes errors when reading: i2c i2c-0: sendbytes: NAK bailout. mms114 0-0048: __mms114_read_reg: i2c transfer failed (-5) The driver works fine as soon as I2C_M_NOSTART is removed. Reviewed-by: Andi Shyti <andi(a)etezian.org> Signed-off-by: Stephan Gerhold <stephan(a)gerhold.net> Link: https://lore.kernel.org/r/20200405170904.61512-1-stephan@gerhold.net [dtor: removed separate mms345l handling, made everyone use standard transfer mode, propagated the 10bit addressing flag to the read part of the transfer as well.] Signed-off-by: Dmitry Torokhov <dmitry.torokhov(a)gmail.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/input/touchscreen/mms114.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c index a5ab774da4cc..fca908ba4841 100644 --- a/drivers/input/touchscreen/mms114.c +++ b/drivers/input/touchscreen/mms114.c @@ -91,15 +91,15 @@ static int __mms114_read_reg(struct mms114_data *data, unsigned int reg, if (reg <= MMS114_MODE_CONTROL && reg + len > MMS114_MODE_CONTROL) BUG(); - /* Write register: use repeated start */ + /* Write register */ xfer[0].addr = client->addr; - xfer[0].flags = I2C_M_TEN | I2C_M_NOSTART; + xfer[0].flags = client->flags & I2C_M_TEN; xfer[0].len = 1; xfer[0].buf = &buf; /* Read data */ xfer[1].addr = client->addr; - xfer[1].flags = I2C_M_RD; + xfer[1].flags = (client->flags & I2C_M_TEN) | I2C_M_RD; xfer[1].len = len; xfer[1].buf = val; @@ -428,10 +428,8 @@ static int mms114_probe(struct i2c_client *client, const void *match_data; int error; - if (!i2c_check_functionality(client->adapter, - I2C_FUNC_PROTOCOL_MANGLING)) { - dev_err(&client->dev, - "Need i2c bus that supports protocol mangling\n"); + if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { + dev_err(&client->dev, "Not supported I2C adapter\n"); return -ENODEV; } -- 2.25.1

4 years, 7 months

1
13
0 0

[PATCH AUTOSEL 5.6 01/17] Input: mms114 - fix handling of mms345l

by Sasha Levin

From: Stephan Gerhold <stephan(a)gerhold.net> [ Upstream commit 3f8f770575d911c989043d8f0fb8dec96360c41c ] MMS345L is another first generation touch screen from Melfas, which uses the same registers as MMS152. However, using I2C_M_NOSTART for it causes errors when reading: i2c i2c-0: sendbytes: NAK bailout. mms114 0-0048: __mms114_read_reg: i2c transfer failed (-5) The driver works fine as soon as I2C_M_NOSTART is removed. Reviewed-by: Andi Shyti <andi(a)etezian.org> Signed-off-by: Stephan Gerhold <stephan(a)gerhold.net> Link: https://lore.kernel.org/r/20200405170904.61512-1-stephan@gerhold.net [dtor: removed separate mms345l handling, made everyone use standard transfer mode, propagated the 10bit addressing flag to the read part of the transfer as well.] Signed-off-by: Dmitry Torokhov <dmitry.torokhov(a)gmail.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/input/touchscreen/mms114.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c index 69c6d559eeb0..2ef1adaed9af 100644 --- a/drivers/input/touchscreen/mms114.c +++ b/drivers/input/touchscreen/mms114.c @@ -91,15 +91,15 @@ static int __mms114_read_reg(struct mms114_data *data, unsigned int reg, if (reg <= MMS114_MODE_CONTROL && reg + len > MMS114_MODE_CONTROL) BUG(); - /* Write register: use repeated start */ + /* Write register */ xfer[0].addr = client->addr; - xfer[0].flags = I2C_M_TEN | I2C_M_NOSTART; + xfer[0].flags = client->flags & I2C_M_TEN; xfer[0].len = 1; xfer[0].buf = &buf; /* Read data */ xfer[1].addr = client->addr; - xfer[1].flags = I2C_M_RD; + xfer[1].flags = (client->flags & I2C_M_TEN) | I2C_M_RD; xfer[1].len = len; xfer[1].buf = val; @@ -428,10 +428,8 @@ static int mms114_probe(struct i2c_client *client, const void *match_data; int error; - if (!i2c_check_functionality(client->adapter, - I2C_FUNC_PROTOCOL_MANGLING)) { - dev_err(&client->dev, - "Need i2c bus that supports protocol mangling\n"); + if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { + dev_err(&client->dev, "Not supported I2C adapter\n"); return -ENODEV; } -- 2.25.1

4 years, 7 months

1
16
0 0

[PATCH] ovl: explicitly initialize error in ovl_copy_xattr()

by glider＠google.com

Under certain circumstances (we found this out running Docker on a Clang-built kernel with CONFIG_INIT_STACK_ALL) ovl_copy_xattr() may return uninitialized value of |error| from ovl_copy_xattr(). It is then returned by ovl_create() to lookup_open(), which casts it to an invalid dentry pointer, that can be further read or written by the lookup_open() callers. The uninitialized value is returned when all the xattr on the file are ovl_is_private_xattr(), which is actually a successful case, therefore we initialize |error| with 0. Signed-off-by: Alexander Potapenko <glider(a)google.com> Cc: Kees Cook <keescook(a)chromium.org> Cc: Roy Yang <royyang(a)google.com> Cc: <stable(a)vger.kernel.org> # 4.1 --- The bug seem to date back to at least v4.1 where the annotation has been introduced (i.e. the compilers started noticing error could be used before being initialized). I hovever didn't try to prove that the problem is actually reproducible on such ancient kernels. We've seen it on a real machine running v4.4 as well. v2: -- Per Vivek Goyal's suggestion, changed |error| to be 0 --- fs/overlayfs/copy_up.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c index 9709cf22cab3..07e0d1961e96 100644 --- a/fs/overlayfs/copy_up.c +++ b/fs/overlayfs/copy_up.c @@ -47,7 +47,7 @@ int ovl_copy_xattr(struct dentry *old, struct dentry *new) { ssize_t list_size, size, value_size = 0; char *buf, *name, *value = NULL; - int uninitialized_var(error); + int error = 0; size_t slen; if (!(old->d_inode->i_opflags & IOP_XATTR) || -- 2.27.0.278.ge193c7cf3a9-goog

4 years, 7 months

4
5
0 0

✅ PASS: Test report for kernel 5.6.16-e4d3ad1.cki (stable-queue)

by CKI Project

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: e4d3ad101947 - media: dvbdev: Fix tuner->demod media controller link The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK All kernel binaries, config files, and logs are available for download here: https://cki-artifacts.s3.us-east-2.amazonaws.com/index.html?prefix=dataware… Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg s390x: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ✅ Boot test ✅ Podman system integration test - as root ✅ Podman system integration test - as user ✅ LTP ✅ Loopdev Sanity ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking: igmp conformance test ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - transport ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ pciutils: update pci ids test ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test ✅ storage: SCSI VPD 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ jvm - DaCapo Benchmark Suite 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Networking firewall: basic netfilter test 🚧 ✅ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer 🚧 ✅ kdump - kexec_boot Host 2: ✅ Boot test ✅ xfstests - ext4 ✅ xfstests - xfs ✅ selinux-policy: serge-testsuite ✅ storage: software RAID testing ✅ stress: stress-ng 🚧 ✅ IPMI driver test 🚧 ✅ IPMItool loop stress test 🚧 ✅ Storage blktests ppc64le: Host 1: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test ⚡⚡⚡ Podman system integration test - as root ⚡⚡⚡ Podman system integration test - as user ⚡⚡⚡ LTP ⚡⚡⚡ Loopdev Sanity ⚡⚡⚡ Memory function: memfd_create ⚡⚡⚡ AMTU (Abstract Machine Test Utility) ⚡⚡⚡ Networking bridge: sanity ⚡⚡⚡ Ethernet drivers sanity ⚡⚡⚡ Networking socket: fuzz ⚡⚡⚡ Networking route: pmtu ⚡⚡⚡ Networking route_func - local ⚡⚡⚡ Networking route_func - forward ⚡⚡⚡ Networking TCP: keepalive test ⚡⚡⚡ Networking UDP: socket ⚡⚡⚡ Networking tunnel: geneve basic test ⚡⚡⚡ Networking tunnel: gre basic ⚡⚡⚡ L2TP basic test ⚡⚡⚡ Networking tunnel: vxlan basic ⚡⚡⚡ Networking ipsec: basic netns - tunnel ⚡⚡⚡ Libkcapi AF_ALG test ⚡⚡⚡ pciutils: update pci ids test ⚡⚡⚡ ALSA PCM loopback test ⚡⚡⚡ ALSA Control (mixer) Userspace Element test 🚧 ⚡⚡⚡ CIFS Connectathon 🚧 ⚡⚡⚡ POSIX pjd-fstest suites 🚧 ⚡⚡⚡ jvm - DaCapo Benchmark Suite 🚧 ⚡⚡⚡ jvm - jcstress tests 🚧 ⚡⚡⚡ Memory function: kaslr 🚧 ⚡⚡⚡ Networking firewall: basic netfilter test 🚧 ⚡⚡⚡ audit: audit testsuite test 🚧 ⚡⚡⚡ trace: ftrace/tracer Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test 🚧 ⚡⚡⚡ kdump - sysrq-c s390x: Host 1: ✅ Boot test ✅ selinux-policy: serge-testsuite ✅ stress: stress-ng 🚧 ✅ Storage blktests Host 2: ✅ Boot test 🚧 ✅ kdump - sysrq-c Host 3: ✅ Boot test ✅ Podman system integration test - as root ✅ Podman system integration test - as user ✅ LTP ✅ Loopdev Sanity ✅ Memory function: memfd_create ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - transport ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ jvm - DaCapo Benchmark Suite 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Networking firewall: basic netfilter test 🚧 ❌ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer 🚧 ✅ kdump - kexec_boot x86_64: Host 1: ✅ Boot test 🚧 ✅ kdump - sysrq-c Host 2: ✅ Boot test ✅ xfstests - ext4 ✅ xfstests - xfs ✅ selinux-policy: serge-testsuite ✅ storage: software RAID testing ✅ stress: stress-ng 🚧 ✅ CPU: Frequency Driver Test 🚧 ✅ CPU: Idle Test 🚧 ✅ IOMMU boot test 🚧 ✅ IPMI driver test 🚧 ✅ IPMItool loop stress test 🚧 ✅ Storage blktests Host 3: ✅ Boot test ✅ Podman system integration test - as root ✅ Podman system integration test - as user ✅ LTP ✅ Loopdev Sanity ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking: igmp conformance test ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - transport ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ pciutils: sanity smoke test ✅ pciutils: update pci ids test ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test ✅ storage: SCSI VPD 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ jvm - DaCapo Benchmark Suite 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Networking firewall: basic netfilter test 🚧 ✅ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer 🚧 ✅ kdump - kexec_boot Test sources: https://github.com/CKI-project/tests-beaker 💚 Pull requests are welcome for new tests or improvements to existing tests! Aborted tests ------------- Tests that didn't complete running successfully are marked with ⚡⚡⚡. If this was caused by an infrastructure issue, we try to mark that explicitly in the report. Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed. Testing timeout --------------- We aim to provide a report within reasonable timeframe. Tests that haven't finished running yet are marked with ⏱.

4 years, 7 months

1
0
0 0

[PATCH 4.19 00/80] 4.19.124-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.124 release. There are 80 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 20 May 2020 17:32:42 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.124-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.124-rc1 Sergei Trofimovich <slyfox(a)gentoo.org> Makefile: disallow data races on gcc-10 as well Jim Mattson <jmattson(a)google.com> KVM: x86: Fix off-by-one error in kvm_vcpu_ioctl_x86_setup_mce Geert Uytterhoeven <geert+renesas(a)glider.be> ARM: dts: r8a7740: Add missing extal2 to CPG node Yoshihiro Shimoda <yoshihiro.shimoda.uh(a)renesas.com> arm64: dts: renesas: r8a77980: Fix IPMMU VIP[01] nodes Geert Uytterhoeven <geert+renesas(a)glider.be> ARM: dts: r8a73a4: Add missing CMT1 interrupts Chen-Yu Tsai <wens(a)csie.org> arm64: dts: rockchip: Rename dwc3 device nodes on rk3399 to make dtc happy Chen-Yu Tsai <wens(a)csie.org> arm64: dts: rockchip: Replace RK805 PMIC node name with "pmic" on rk3328 boards Marc Zyngier <maz(a)kernel.org> clk: Unlink clock if failed to prepare or enable Kai-Heng Feng <kai.heng.feng(a)canonical.com> Revert "ALSA: hda/realtek: Fix pop noise on ALC225" Wei Yongjun <weiyongjun1(a)huawei.com> usb: gadget: legacy: fix error return code in cdc_bind() Wei Yongjun <weiyongjun1(a)huawei.com> usb: gadget: legacy: fix error return code in gncm_bind() Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> usb: gadget: audio: Fix a missing error return value in audio_bind() Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> usb: gadget: net2272: Fix a memory leak in an error handling path in 'net2272_plat_probe()' John Stultz <john.stultz(a)linaro.org> dwc3: Remove check for HWO flag in dwc3_gadget_ep_reclaim_trb_sg() Justin Swartz <justin.swartz(a)risingedge.co.za> clk: rockchip: fix incorrect configuration of rk3228 aclk_gpu* clocks Eric W. Biederman <ebiederm(a)xmission.com> exec: Move would_dump into flush_old_exec Josh Poimboeuf <jpoimboe(a)redhat.com> x86/unwind/orc: Fix error handling in __unwind_start() Borislav Petkov <bp(a)suse.de> x86: Fix early boot crash on gcc-10, third try Adam McCoy <adam(a)forsedomani.com> cifs: fix leaked reference on requeued write Fabio Estevam <festevam(a)gmail.com> ARM: dts: imx27-phytec-phycard-s-rdk: Fix the I2C1 pinctrl entries Kishon Vijay Abraham I <kishon(a)ti.com> ARM: dts: dra7: Fix bus_dma_limit for PCIe Sriharsha Allenki <sallenki(a)codeaurora.org> usb: xhci: Fix NULL pointer dereference when enqueuing trbs from urb sg list Kyungtae Kim <kt0755(a)gmail.com> USB: gadget: fix illegal array access in binding with UDC Li Jun <jun.li(a)nxp.com> usb: host: xhci-plat: keep runtime active when removing host Eugeniu Rosca <erosca(a)de.adit-jv.com> usb: core: hub: limit HUB_QUIRK_DISABLE_AUTOSUSPEND to USB5534B Jesus Ramos <jesus-ramos(a)live.com> ALSA: usb-audio: Add control message quirk delay for Kingston HyperX headset Takashi Iwai <tiwai(a)suse.de> ALSA: rawmidi: Fix racy buffer resize under concurrent accesses Takashi Iwai <tiwai(a)suse.de> ALSA: hda/realtek - Limit int mic boost for Thinkpad T530 Linus Torvalds <torvalds(a)linux-foundation.org> gcc-10: avoid shadowing standard library 'free()' in crypto Linus Torvalds <torvalds(a)linux-foundation.org> gcc-10: disable 'restrict' warning for now Linus Torvalds <torvalds(a)linux-foundation.org> gcc-10: disable 'stringop-overflow' warning for now Linus Torvalds <torvalds(a)linux-foundation.org> gcc-10: disable 'array-bounds' warning for now Linus Torvalds <torvalds(a)linux-foundation.org> gcc-10: disable 'zero-length-bounds' warning for now Linus Torvalds <torvalds(a)linux-foundation.org> Stop the ad-hoc games with -Wno-maybe-initialized Masahiro Yamada <yamada.masahiro(a)socionext.com> kbuild: compute false-positive -Wmaybe-uninitialized cases in Kconfig Linus Torvalds <torvalds(a)linux-foundation.org> gcc-10 warnings: fix low-hanging fruit Jason Gunthorpe <jgg(a)ziepe.ca> pnp: Use list_for_each_entry() instead of open coding Samu Nuutamo <samu.nuutamo(a)vincit.fi> hwmon: (da9052) Synchronize access with mfd Jack Morgenstein <jackm(a)dev.mellanox.co.il> IB/mlx4: Test return value of calls to ib_get_cached_pkey Stefano Brivio <sbrivio(a)redhat.com> netfilter: nft_set_rbtree: Introduce and use nft_rbtree_interval_start() Christoph Hellwig <hch(a)lst.de> arm64: fix the flush_icache_range arguments in machine_kexec Arnd Bergmann <arnd(a)arndb.de> netfilter: conntrack: avoid gcc-10 zero-length-bounds warning Dave Wysochanski <dwysocha(a)redhat.com> NFSv4: Fix fscache cookie aux_data to ensure change_attr is included Arnd Bergmann <arnd(a)arndb.de> nfs: fscache: use timespec64 in inode auxdata Dave Wysochanski <dwysocha(a)redhat.com> NFS: Fix fscache super_cookie index_key from changing after umount Adrian Hunter <adrian.hunter(a)intel.com> mmc: block: Fix request completion in the CQE timeout path Veerabhadrarao Badiganti <vbadigan(a)codeaurora.org> mmc: core: Check request type before completing the request Dan Carpenter <dan.carpenter(a)oracle.com> i40iw: Fix error handling in i40iw_manage_arp_cache() Grace Kao <grace.kao(a)intel.com> pinctrl: cherryview: Add missing spinlock usage in chv_gpio_irq_handler Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> pinctrl: baytrail: Enable pin configuration setting for GPIO chip Andreas Gruenbacher <agruenba(a)redhat.com> gfs2: Another gfs2_walk_metadata fix Kai-Heng Feng <kai.heng.feng(a)canonical.com> ALSA: hda/realtek - Fix S3 pop noise on Dell Wyse Vasily Averin <vvs(a)virtuozzo.com> ipc/util.c: sysvipc_find_ipc() incorrectly updates position index Vasily Averin <vvs(a)virtuozzo.com> drm/qxl: lost qxl_bo_kunmap_atomic_page in qxl_image_init_helper() Kai Vehmanen <kai.vehmanen(a)linux.intel.com> ALSA: hda/hdmi: fix race in monitor detection during probe Chris Wilson <chris(a)chris-wilson.co.uk> cpufreq: intel_pstate: Only mention the BIOS disabling turbo mode once Lubomir Rintel <lkundrak(a)v3.sk> dmaengine: mmp_tdma: Reset channel error on release Madhuparna Bhowmik <madhuparnabhowmik10(a)gmail.com> dmaengine: pch_dma.c: Avoid data race between probe and irq handler Ilie Halip <ilie.halip(a)gmail.com> riscv: fix vdso build with lld Eric Dumazet <edumazet(a)google.com> tcp: fix SO_RCVLOWAT hangs with fat skbs Kelly Littlepage <kelly(a)onechronos.com> net: tcp: fix rx timestamp behavior for tcp_recvmsg Zefan Li <lizefan(a)huawei.com> netprio_cgroup: Fix unlimited memory leak of v2 cgroups Paolo Abeni <pabeni(a)redhat.com> net: ipv4: really enforce backoff for redirects Florian Fainelli <f.fainelli(a)gmail.com> net: dsa: loop: Add module soft dependency Luo bin <luobin9(a)huawei.com> hinic: fix a bug of ndo_stop Michael S. Tsirkin <mst(a)redhat.com> virtio_net: fix lockdep warning on 32 bit Eric Dumazet <edumazet(a)google.com> tcp: fix error recovery in tcp_zerocopy_receive() Maciej Żenczykowski <maze(a)google.com> Revert "ipv6: add mtu lock check in __ip6_rt_update_pmtu" Guillaume Nault <gnault(a)redhat.com> pppoe: only process PADT targeted at local interfaces Heiner Kallweit <hkallweit1(a)gmail.com> net: phy: fix aneg restart in phy_ethtool_set_eee Paolo Abeni <pabeni(a)redhat.com> netlabel: cope with NULL catmap Cong Wang <xiyou.wangcong(a)gmail.com> net: fix a potential recursive NETDEV_FEAT_CHANGE Raul E Rangel <rrangel(a)chromium.org> mmc: sdhci-acpi: Add SDHCI_QUIRK2_BROKEN_64_BIT_DMA for AMDI0040 Wu Bo <wubo40(a)huawei.com> scsi: sg: add sg_remove_request in sg_write Stefan Hajnoczi <stefanha(a)redhat.com> virtio-blk: handle block_device_operations callbacks after hot unplug Arnd Bergmann <arnd(a)arndb.de> drop_monitor: work around gcc-10 stringop-overflow warning Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> net: moxa: Fix a potential double 'free_irq()' Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()' Hugh Dickins <hughd(a)google.com> shmem: fix possible deadlocks on shmlock_user_lock Florian Fainelli <f.fainelli(a)gmail.com> net: dsa: Do not make user port errors fatal ------------- Diffstat: Makefile | 25 ++++--- arch/arm/boot/dts/dra7.dtsi | 4 +- arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts | 4 +- arch/arm/boot/dts/r8a73a4.dtsi | 9 ++- arch/arm/boot/dts/r8a7740.dtsi | 2 +- arch/arm64/boot/dts/renesas/r8a77980.dtsi | 2 + arch/arm64/boot/dts/rockchip/rk3328-evb.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 +- arch/arm64/kernel/machine_kexec.c | 1 + arch/riscv/kernel/vdso/Makefile | 6 +- arch/x86/include/asm/stackprotector.h | 7 +- arch/x86/kernel/smpboot.c | 8 +++ arch/x86/kernel/unwind_orc.c | 16 +++-- arch/x86/kvm/x86.c | 2 +- arch/x86/xen/smp_pv.c | 1 + crypto/lrw.c | 4 +- crypto/xts.c | 4 +- drivers/block/virtio_blk.c | 86 ++++++++++++++++++++--- drivers/clk/clk.c | 3 + drivers/clk/rockchip/clk-rk3228.c | 17 ++--- drivers/cpufreq/intel_pstate.c | 2 +- drivers/dma/mmp_tdma.c | 2 + drivers/dma/pch_dma.c | 2 +- drivers/gpu/drm/qxl/qxl_image.c | 3 +- drivers/hwmon/da9052-hwmon.c | 4 +- drivers/infiniband/hw/i40iw/i40iw_hw.c | 2 +- drivers/infiniband/hw/mlx4/qp.c | 14 +++- drivers/mmc/core/block.c | 3 +- drivers/mmc/core/queue.c | 3 +- drivers/mmc/host/sdhci-acpi.c | 10 +-- drivers/net/dsa/dsa_loop.c | 1 + drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c | 16 +++-- drivers/net/ethernet/huawei/hinic/hinic_main.c | 16 +---- drivers/net/ethernet/moxa/moxart_ether.c | 2 +- drivers/net/ethernet/natsemi/jazzsonic.c | 6 +- drivers/net/phy/phy.c | 8 ++- drivers/net/ppp/pppoe.c | 3 + drivers/net/virtio_net.c | 6 +- drivers/pinctrl/intel/pinctrl-baytrail.c | 1 + drivers/pinctrl/intel/pinctrl-cherryview.c | 4 ++ drivers/scsi/sg.c | 4 +- drivers/usb/core/hub.c | 6 +- drivers/usb/dwc3/gadget.c | 3 - drivers/usb/gadget/configfs.c | 3 + drivers/usb/gadget/legacy/audio.c | 4 +- drivers/usb/gadget/legacy/cdc2.c | 4 +- drivers/usb/gadget/legacy/ncm.c | 4 +- drivers/usb/gadget/udc/net2272.c | 2 + drivers/usb/host/xhci-plat.c | 4 +- drivers/usb/host/xhci-ring.c | 4 +- fs/cifs/cifssmb.c | 2 +- fs/exec.c | 4 +- fs/gfs2/bmap.c | 16 +++-- fs/nfs/fscache-index.c | 6 +- fs/nfs/fscache.c | 31 ++++---- fs/nfs/fscache.h | 8 ++- include/linux/compiler.h | 6 ++ include/linux/fs.h | 2 +- include/linux/pnp.h | 29 +++----- include/linux/tty.h | 2 +- include/net/netfilter/nf_conntrack.h | 2 +- include/net/tcp.h | 13 ++++ include/sound/rawmidi.h | 1 + init/main.c | 2 + ipc/util.c | 12 ++-- mm/shmem.c | 7 +- net/core/dev.c | 4 +- net/core/drop_monitor.c | 11 +-- net/core/netprio_cgroup.c | 2 + net/dsa/dsa2.c | 2 +- net/ipv4/cipso_ipv4.c | 6 +- net/ipv4/route.c | 2 +- net/ipv4/tcp.c | 27 ++++--- net/ipv4/tcp_input.c | 3 +- net/ipv6/calipso.c | 3 +- net/ipv6/route.c | 6 +- net/netfilter/nf_conntrack_core.c | 4 +- net/netfilter/nft_set_rbtree.c | 17 +++-- net/netlabel/netlabel_kapi.c | 6 ++ sound/core/rawmidi.c | 31 ++++++-- sound/pci/hda/patch_hdmi.c | 2 + sound/pci/hda/patch_realtek.c | 28 +++++++- sound/usb/quirks.c | 9 +-- 84 files changed, 452 insertions(+), 209 deletions(-)

4 years, 7 months

12
102
0 0

[patch 100/127] kernel/relay.c: handle alloc_percpu returning NULL in relay_open

by Andrew Morton

From: Daniel Axtens <dja(a)axtens.net> Subject: kernel/relay.c: handle alloc_percpu returning NULL in relay_open alloc_percpu() may return NULL, which means chan->buf may be set to NULL. In that case, when we do *per_cpu_ptr(chan->buf, ...), we dereference an invalid pointer: BUG: Unable to handle kernel data access at 0x7dae0000 Faulting instruction address: 0xc0000000003f3fec ... NIP [c0000000003f3fec] relay_open+0x29c/0x600 LR [c0000000003f3fc0] relay_open+0x270/0x600 Call Trace: [c000000054353a70] [c0000000003f3fb4] relay_open+0x264/0x600 (unreliable) [c000000054353b00] [c000000000451764] __blk_trace_setup+0x254/0x600 [c000000054353bb0] [c000000000451b78] blk_trace_setup+0x68/0xa0 [c000000054353c10] [c0000000010da77c] sg_ioctl+0x7bc/0x2e80 [c000000054353cd0] [c000000000758cbc] do_vfs_ioctl+0x13c/0x1300 [c000000054353d90] [c000000000759f14] ksys_ioctl+0x94/0x130 [c000000054353de0] [c000000000759ff8] sys_ioctl+0x48/0xb0 [c000000054353e20] [c00000000000bcd0] system_call+0x5c/0x68 Check if alloc_percpu returns NULL. This was found by syzkaller both on x86 and powerpc, and the reproducer it found on powerpc is capable of hitting the issue as an unprivileged user. Link: http://lkml.kernel.org/r/20191219121256.26480-1-dja@axtens.net Fixes: 017c59c042d0 ("relay: Use per CPU constructs for the relay channel buffer pointers") Signed-off-by: Daniel Axtens <dja(a)axtens.net> Reviewed-by: Michael Ellerman <mpe(a)ellerman.id.au> Reviewed-by: Andrew Donnellan <ajd(a)linux.ibm.com> Acked-by: David Rientjes <rientjes(a)google.com> Reported-by: syzbot+1e925b4b836afe85a1c6(a)syzkaller-ppc64.appspotmail.com Reported-by: syzbot+587b2421926808309d21(a)syzkaller-ppc64.appspotmail.com Reported-by: syzbot+58320b7171734bf79d26(a)syzkaller.appspotmail.com Reported-by: syzbot+d6074fb08bdb2e010520(a)syzkaller.appspotmail.com Cc: Akash Goel <akash.goel(a)intel.com> Cc: Andrew Donnellan <ajd(a)linux.ibm.com> Cc: Guenter Roeck <linux(a)roeck-us.net> Cc: Salvatore Bonaccorso <carnil(a)debian.org> Cc: <stable(a)vger.kernel.org> [4.10+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- kernel/relay.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/kernel/relay.c~relay-handle-alloc_percpu-returning-null-in-relay_open +++ a/kernel/relay.c @@ -581,6 +581,11 @@ struct rchan *relay_open(const char *bas return NULL; chan->buf = alloc_percpu(struct rchan_buf *); + if (!chan->buf) { + kfree(chan); + return NULL; + } + chan->version = RELAYFS_CHANNEL_VERSION; chan->n_subbufs = n_subbufs; chan->subbuf_size = subbuf_size; _

4 years, 7 months

1
0
0 0

[PATCH] net: sched: export __netdev_watchdog_up()

by Valentin Longchamp

Since the quiesce/activate rework, __netdev_watchdog_up() is directly called in the ucc_geth driver. Unfortunately, this function is not available for modules and thus ucc_geth cannot be built as a module anymore. Fix it by exporting __netdev_watchdog_up(). Since the commit introducing the regression was backported to stable branches, this one should ideally be as well. Fixes: 79dde73cf9bc ("net/ethernet/freescale: rework quiesce/activate for ucc_geth") Cc: <stable(a)vger.kernel.org> Signed-off-by: Valentin Longchamp <valentin(a)longchamp.me> --- net/sched/sch_generic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index 2efd5b61acef..f1816516f638 100644 --- a/net/sched/sch_generic.c +++ b/net/sched/sch_generic.c @@ -464,6 +464,7 @@ void __netdev_watchdog_up(struct net_device *dev) dev_hold(dev); } } +EXPORT_SYMBOL(__netdev_watchdog_up); static void dev_watchdog_up(struct net_device *dev) { -- 2.25.1

4 years, 7 months

2
1
0 0

[PATCH net] net: dsa: qca8k: Fix "Unexpected gfp" kernel exception

by Michal Vokáč

Commit 7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper") replaced the dsa_switch_alloc helper by devm_kzalloc in all DSA drivers. Unfortunately it introduced a typo in qca8k.c driver and wrong argument is passed to the devm_kzalloc function. This fix mitigates the following kernel exception: Unexpected gfp: 0x6 (__GFP_HIGHMEM|GFP_DMA32). Fixing up to gfp: 0x101 (GFP_DMA|__GFP_ZERO). Fix your code! CPU: 1 PID: 44 Comm: kworker/1:1 Not tainted 5.5.9-yocto-ua #1 Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree) Workqueue: events deferred_probe_work_func [<c0014924>] (unwind_backtrace) from [<c00123bc>] (show_stack+0x10/0x14) [<c00123bc>] (show_stack) from [<c04c8fb4>] (dump_stack+0x90/0xa4) [<c04c8fb4>] (dump_stack) from [<c00e1b10>] (new_slab+0x20c/0x214) [<c00e1b10>] (new_slab) from [<c00e1cd0>] (___slab_alloc.constprop.0+0x1b8/0x540) [<c00e1cd0>] (___slab_alloc.constprop.0) from [<c00e2074>] (__slab_alloc.constprop.0+0x1c/0x24) [<c00e2074>] (__slab_alloc.constprop.0) from [<c00e4538>] (__kmalloc_track_caller+0x1b0/0x298) [<c00e4538>] (__kmalloc_track_caller) from [<c02cccac>] (devm_kmalloc+0x24/0x70) [<c02cccac>] (devm_kmalloc) from [<c030d888>] (qca8k_sw_probe+0x94/0x1ac) [<c030d888>] (qca8k_sw_probe) from [<c0304788>] (mdio_probe+0x30/0x54) [<c0304788>] (mdio_probe) from [<c02c93bc>] (really_probe+0x1e0/0x348) [<c02c93bc>] (really_probe) from [<c02c9884>] (driver_probe_device+0x60/0x16c) [<c02c9884>] (driver_probe_device) from [<c02c7fb0>] (bus_for_each_drv+0x70/0x94) [<c02c7fb0>] (bus_for_each_drv) from [<c02c9708>] (__device_attach+0xb4/0x11c) [<c02c9708>] (__device_attach) from [<c02c8148>] (bus_probe_device+0x84/0x8c) [<c02c8148>] (bus_probe_device) from [<c02c8cec>] (deferred_probe_work_func+0x64/0x90) [<c02c8cec>] (deferred_probe_work_func) from [<c0033c14>] (process_one_work+0x1d4/0x41c) [<c0033c14>] (process_one_work) from [<c00340a4>] (worker_thread+0x248/0x528) [<c00340a4>] (worker_thread) from [<c0039148>] (kthread+0x124/0x150) [<c0039148>] (kthread) from [<c00090d8>] (ret_from_fork+0x14/0x3c) Exception stack(0xee1b5fb0 to 0xee1b5ff8) 5fa0: 00000000 00000000 00000000 00000000 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 qca8k 2188000.ethernet-1:0a: Using legacy PHYLIB callbacks. Please migrate to PHYLINK! qca8k 2188000.ethernet-1:0a eth2 (uninitialized): PHY [2188000.ethernet-1:01] driver [Generic PHY] qca8k 2188000.ethernet-1:0a eth1 (uninitialized): PHY [2188000.ethernet-1:02] driver [Generic PHY] Fixes: 7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper") Cc: <stable(a)vger.kernel.org> Signed-off-by: Michal Vokáč <michal.vokac(a)ysoft.com> --- drivers/net/dsa/qca8k.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 9f4205b4439b..d2b5ab403e06 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -1079,8 +1079,7 @@ qca8k_sw_probe(struct mdio_device *mdiodev) if (id != QCA8K_ID_QCA8337) return -ENODEV; - priv->ds = devm_kzalloc(&mdiodev->dev, sizeof(*priv->ds), - QCA8K_NUM_PORTS); + priv->ds = devm_kzalloc(&mdiodev->dev, sizeof(*priv->ds), GFP_KERNEL); if (!priv->ds) return -ENOMEM; -- 2.1.4

4 years, 7 months

3
3
0 0

[PATCH] dm crypt: avoid truncating the logical block size

by Eric Biggers

From: Eric Biggers <ebiggers(a)google.com> queue_limits::logical_block_size got changed from unsigned short to unsigned int, but it was forgotten to update crypt_io_hints() to use the new type. Fix it. Fixes: ad6bf88a6c19 ("block: fix an integer overflow in logical block size") Cc: stable(a)vger.kernel.org Signed-off-by: Eric Biggers <ebiggers(a)google.com> --- drivers/md/dm-crypt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c index 3df90daba89e..a1dcb8675484 100644 --- a/drivers/md/dm-crypt.c +++ b/drivers/md/dm-crypt.c @@ -3274,7 +3274,7 @@ static void crypt_io_hints(struct dm_target *ti, struct queue_limits *limits) limits->max_segment_size = PAGE_SIZE; limits->logical_block_size = - max_t(unsigned short, limits->logical_block_size, cc->sector_size); + max_t(unsigned, limits->logical_block_size, cc->sector_size); limits->physical_block_size = max_t(unsigned, limits->physical_block_size, cc->sector_size); limits->io_min = max_t(unsigned, limits->io_min, cc->sector_size); -- 2.27.0.278.ge193c7cf3a9-goog

4 years, 7 months

2
1
0 0

[merged] mm-call-cond_resched-from-deferred_init_memmap.patch removed from -mm tree

by akpm＠linux-foundation.org

The patch titled Subject: mm: call cond_resched() from deferred_init_memmap() has been removed from the -mm tree. Its filename was mm-call-cond_resched-from-deferred_init_memmap.patch This patch was dropped because it was merged into mainline or a subsystem tree ------------------------------------------------------ From: Pavel Tatashin <pasha.tatashin(a)soleen.com> Subject: mm: call cond_resched() from deferred_init_memmap() Now that deferred pages are initialized with interrupts enabled we can replace touch_nmi_watchdog() with cond_resched(), as it was before 3a2d7fa8a3d5. For now, we cannot do the same in deferred_grow_zone() as it is still initializes pages with interrupts disabled. This change fixes RCU problem described in https://lkml.kernel.org/r/20200401104156.11564-2-david@redhat.com [ 60.474005] rcu: INFO: rcu_sched detected stalls on CPUs/tasks: [ 60.475000] rcu: 1-...0: (0 ticks this GP) idle=02a/1/0x4000000000000000 softirq=1/1 fqs=15000 [ 60.475000] rcu: (detected by 0, t=60002 jiffies, g=-1199, q=1) [ 60.475000] Sending NMI from CPU 0 to CPUs 1: [ 1.760091] NMI backtrace for cpu 1 [ 1.760091] CPU: 1 PID: 20 Comm: pgdatinit0 Not tainted 4.18.0-147.9.1.el8_1.x86_64 #1 [ 1.760091] Hardware name: Red Hat KVM, BIOS 1.13.0-1.module+el8.2.0+5520+4e5817f3 04/01/2014 [ 1.760091] RIP: 0010:__init_single_page.isra.65+0x10/0x4f [ 1.760091] Code: 48 83 cf 63 48 89 f8 0f 1f 40 00 48 89 c6 48 89 d7 e8 6b 18 80 ff 66 90 5b c3 31 c0 b9 10 00 00 00 49 89 f8 48 c1 e6 33 f3 ab <b8> 07 00 00 00 48 c1 e2 36 41 c7 40 34 01 00 00 00 48 c1 e0 33 41 [ 1.760091] RSP: 0000:ffffba783123be40 EFLAGS: 00000006 [ 1.760091] RAX: 0000000000000000 RBX: fffffad34405e300 RCX: 0000000000000000 [ 1.760091] RDX: 0000000000000000 RSI: 0010000000000000 RDI: fffffad34405e340 [ 1.760091] RBP: 0000000033f3177e R08: fffffad34405e300 R09: 0000000000000002 [ 1.760091] R10: 000000000000002b R11: ffff98afb691a500 R12: 0000000000000002 [ 1.760091] R13: 0000000000000000 R14: 000000003f03ea00 R15: 000000003e10178c [ 1.760091] FS: 0000000000000000(0000) GS:ffff9c9ebeb00000(0000) knlGS:0000000000000000 [ 1.760091] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1.760091] CR2: 00000000ffffffff CR3: 000000a1cf20a001 CR4: 00000000003606e0 [ 1.760091] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 1.760091] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 1.760091] Call Trace: [ 1.760091] deferred_init_pages+0x8f/0xbf [ 1.760091] deferred_init_memmap+0x184/0x29d [ 1.760091] ? deferred_free_pages.isra.97+0xba/0xba [ 1.760091] kthread+0x112/0x130 [ 1.760091] ? kthread_flush_work_fn+0x10/0x10 [ 1.760091] ret_from_fork+0x35/0x40 [ 89.123011] node 0 initialised, 1055935372 pages in 88650ms Link: http://lkml.kernel.org/r/20200403140952.17177-4-pasha.tatashin@soleen.com Fixes: 3a2d7fa8a3d5 ("mm: disable interrupts while initializing deferred pages") Reported-by: Yiqian Wei <yiwei(a)redhat.com> Tested-by: David Hildenbrand <david(a)redhat.com> Signed-off-by: Pavel Tatashin <pasha.tatashin(a)soleen.com> Reviewed-by: Daniel Jordan <daniel.m.jordan(a)oracle.com> Acked-by: Michal Hocko <mhocko(a)suse.com> Reviewed-by: David Hildenbrand <david(a)redhat.com> Reviewed-by: Pankaj Gupta <pankaj.gupta.linux(a)gmail.com> Cc: Dan Williams <dan.j.williams(a)intel.com> Cc: James Morris <jmorris(a)namei.org> Cc: Kirill Tkhai <ktkhai(a)virtuozzo.com> Cc: Sasha Levin <sashal(a)kernel.org> Cc: Shile Zhang <shile.zhang(a)linux.alibaba.com> Cc: Vlastimil Babka <vbabka(a)suse.cz> Cc: <stable(a)vger.kernel.org> [4.17+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/page_alloc.c~mm-call-cond_resched-from-deferred_init_memmap +++ a/mm/page_alloc.c @@ -1870,7 +1870,7 @@ static int __init deferred_init_memmap(v */ while (spfn < epfn) { nr_pages += deferred_init_maxorder(&i, zone, &spfn, &epfn); - touch_nmi_watchdog(); + cond_resched(); } zone_empty: /* Sanity check that the next zone really is unpopulated */ _ Patches currently in -mm which might be from pasha.tatashin(a)soleen.com are

4 years, 7 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror June 2020