May 2020 - Linux-stable-mirror

[PATCH 5.4] bcache: initialize 'sb_page' in register_bcache()

by Tom Saeger

commit 393b8509be33 (bcache: rework error unwinding in register_bcache) introduced compile warning: warning: 'sb_page' may be used uninitialized in this function [-Wmaybe-uninitialized] Use 'sb_page' initialization prior to 393b8509be33. Fixes: 393b8509be33 (bcache: rework error unwinding in register_bcache) Cc: <stable(a)vger.kernel.org> # 5.4.x Signed-off-by: Tom Saeger <tom.saeger(a)oracle.com> --- This addresses warning only seen in 5.4.22+. Upstream avoids this in a different way. Compile test case: cp arch/arm64/configs/defconfig .config ./scripts/config -e BCACHE make ARCH=arm64 olddefconfig make ARCH=arm64 -j $(nproc) Regards, --Tom drivers/md/bcache/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 658b0f4a01f5..25cbc9e2f8e3 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -2376,7 +2376,7 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr, char *path = NULL; struct cache_sb *sb; struct block_device *bdev = NULL; - struct page *sb_page; + struct page *sb_page = NULL; ssize_t ret; ret = -EBUSY; -- 2.25.1

4 years, 7 months

2
3
0 0

Patches potentially missing from stable releases

by Henri Rosten

We did some work on analyzing patches potentially missing from stable releases based on the Fixes: and Revert references in the commit messages. Our script is based on similar idea as described by Guenter Roeck in this earlier mail: https://lore.kernel.org/stable/20190827171621.GA30360@roeck-us.net/. Although the list is not comprehensive, we figured it makes sense to publish it in case the results are of interest to someone else also. The below list of potentially missing commits is based on 4.19, but some of the commits might also apply to 5.4 and 5.6. For each potentially missing commit flagged by the script, we read the commit message and had a short look at the change. We then added comments on our own judgement if it might be stable material or not. No comments simply means the potentially missing patch appears stable material. "Based on commit" is the mainline patch that has been backported to 4.19 and is referenced by the missing commit. We did not check if the patch applies without changes, nor did we build or execute any tests. 6011002c1584 uio: make symbol 'uio_class_registered' static Based on commit: ae61cf5b9913 968339fad422 powerpc/boot: Delete unneeded .globl _zimage_start Based on commit: ee9d21b3b358 Comment: not stable material? ed4d81c4b3f2 net: aquantia: when cleaning hw cache it should be toggled Based on commit: 7a1bb49461b1 Comment: this was backported to 5.3, but for some reason not to older stable releases b27507bb59ed net/ibmvnic: unlock rtnl_lock in reset so linkwatch_event can ru Based on commit: a5681e20b541 61c347ba5511 afs: Clear AFS_VNODE_CB_PROMISED if we detect callback expiry Based on commit: ae3b7361dc0e Comment: likely requires manual backport 1a49b2fd8f58 kbuild: strip whitespace in cmd_record_mcount findstring Based on commit: 6977f95e63b9 Comment: not stable material? 669e859b5ea7 btrfs: drop the lock on error in btrfs_dev_replace_cancel Based on commit: d189dd70e255 Comment: earlier backport failed, this would likely require manual backport: https://lore.kernel.org/stable/15531096685894@kroah.com/ dddaf89e2fbc netfilter: ipt_CLUSTERIP: make symbol 'cip_netdev_notifier' stat Based on commit: 5a86d68bcf02 01091c496f92 acpi/nfit: improve bounds checking for 'func' Based on commit: 11189c1089da Comment: the missing commit was picked by AUTOSEL to 5.4, 5.5, and 5.6, but for some reason, it was not backported 4.19: https://lore.kernel.org/stable/?q=01091c496f92* 2b74c878b0ea IB/hfi1: Unreserve a flushed OPFN request Based on commit: ca95f802ef51 Comment: earlier backport failed, this would likely require manual backport: https://lore.kernel.org/stable/15649835016938@kroah.com/ 0b815023a1d4 bnxt_en: Fix ring checking logic on 57500 chips. Based on commit: 36d65be9a880 Comment: likely requires manual backport 6ae865615fc4 x86/uaccess: Dont leak the AC flag into __put_user() argument ev Based on commit: 2a418cf3f5f1 Comment: commit 9b8bd476e78e which mentions complementing 6ae865615fc4, has already been backported to 4.19 70db5b04cbe1 f2fs: give some messages for inline_xattr_size Based on commit: 500e0b28ecd3 Comment: not stable material? 2a06b8982f8f net: reorder 'struct net' fields to avoid false sharing Based on commit: 355b98553789 Comment: this was backported to 5.3, but for some reason not to older stable releases 0fbf21c3b36a ALSA: hda/realtek - Enable micmute LED for Huawei laptops Based on commit: 8ac51bbc4cfe Comment: not stable material? Thanks, -- Henri

4 years, 7 months

2
2
0 0

[PATCH 1/2] b43: Fix connection problem with WPA3

by Larry Finger

Since the driver was first introduced into the kernel, it has only handled the ciphers associated with WEP, WPA, and WPA2. It fails with WPA3 even though mac80211 can handle those additional ciphers in software, b43 did not report that it could handle them. By setting MFP_CAPABLE using ieee80211_set_hw(), the problem is fixed. With this change, b43 will handle the ciohers it knows in hardare, and let mac80211 handle the others in software. It is not necessary to use the module parameter NOHWCRYPT to turn hardware encryption off. Although this change essentially eliminates that module parameter, I am choosing to keep it for cases where the hardware is broken, and software encryption is required for all ciphers. This patch fixes a prooblem that has been in the driver since it was first merged with commit e4d6b7951812 ("[B43]: add mac80211-based driver for modern BCM43xx devices"). Fixes e4d6b7951812 ("[B43]: add mac80211-based driver for modern BCM43xx devices") Reported-and-tested-by: Rui Salvaterra <rsalvaterra(a)gmail.com> Signed-off-by: Larry Finger <Larry.Finger(a)lwfinger.net> Cc: Stable <stable(a)vger.kernel.org> --- drivers/net/wireless/broadcom/b43/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c index 39da1a4c30ac..3ad94dad2d89 100644 --- a/drivers/net/wireless/broadcom/b43/main.c +++ b/drivers/net/wireless/broadcom/b43/main.c @@ -5569,7 +5569,7 @@ static struct b43_wl *b43_wireless_init(struct b43_bus_dev *dev) /* fill hw info */ ieee80211_hw_set(hw, RX_INCLUDES_FCS); ieee80211_hw_set(hw, SIGNAL_DBM); - + ieee80211_hw_set(hw, MFP_CAPABLE); hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_AP) | BIT(NL80211_IFTYPE_MESH_POINT) | -- 2.26.2

4 years, 7 months

3
3
0 0

[PATCH 4.19 00/81] 4.19.125-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.125 release. There are 81 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 28 May 2020 18:36:22 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.125-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.125-rc1 Linus Torvalds <torvalds(a)linux-foundation.org> make 'user_access_begin()' do 'access_ok()' David Howells <dhowells(a)redhat.com> rxrpc: Fix ack discard David Howells <dhowells(a)redhat.com> rxrpc: Trace discarded ACKs Fabrice Gasnier <fabrice.gasnier(a)st.com> iio: adc: stm32-dfsdm: fix device used to request dma Peter Ujfalusi <peter.ujfalusi(a)ti.com> iio: adc: stm32-dfsdm: Use dma_request_chan() instead dma_request_slave_channel() Fabrice Gasnier <fabrice.gasnier(a)st.com> iio: adc: stm32-adc: fix device used to request dma Peter Ujfalusi <peter.ujfalusi(a)ti.com> iio: adc: stm32-adc: Use dma_request_chan() instead dma_request_slave_channel() Josh Poimboeuf <jpoimboe(a)redhat.com> x86/unwind/orc: Fix unwind_get_return_address_ptr() for inactive tasks Qiushi Wu <wu000273(a)umn.edu> rxrpc: Fix a memory leak in rxkad_verify_response() John Hubbard <jhubbard(a)nvidia.com> rapidio: fix an error in get_user_pages_fast() error handling Wei Yongjun <weiyongjun1(a)huawei.com> ipack: tpci200: fix error return code in tpci200_register() Alexander Usyskin <alexander.usyskin(a)intel.com> mei: release me_cl object reference Klaus Doth <kdlnx(a)doth.eu> misc: rtsx: Add short delay after exit from ASPM Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> iio: dac: vf610: Fix an error handling path in 'vf610_dac_probe()' Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> iio: sca3000: Remove an erroneous 'get_device()' Oscar Carter <oscar.carter(a)gmx.com> staging: greybus: Fix uninitialized scalar variable Dragos Bogdan <dragos.bogdan(a)analog.com> staging: iio: ad2s1210: Fix SPI reading Bob Peterson <rpeterso(a)redhat.com> Revert "gfs2: Don't demote a glock until its revokes are written" Guenter Roeck <linux(a)roeck-us.net> brcmfmac: abort and release host after error Matthias Kaehlcke <mka(a)chromium.org> tty: serial: qcom_geni_serial: Fix wrap around of TX buffer Arjun Vynipadath <arjun(a)chelsio.com> cxgb4/cxgb4vf: Fix mac_hlist initialization and free Arjun Vynipadath <arjun(a)chelsio.com> cxgb4: free mac_hlist properly Doug Berger <opendmb(a)gmail.com> net: bcmgenet: abort suspend on error Doug Berger <opendmb(a)gmail.com> net: bcmgenet: code movement Juliet Kim <julietk(a)linux.vnet.ibm.com> Revert "net/ibmvnic: Fix EOI when running in XIVE mode" Geert Uytterhoeven <geert+renesas(a)glider.be> media: fdp1: Fix R-Car M3-N naming in debug message Mika Westerberg <mika.westerberg(a)linux.intel.com> thunderbolt: Drop duplicated get_switch_at_route() Gustavo A. R. Silva <gustavo(a)embeddedor.com> staging: most: core: replace strcpy() by strscpy() Vishal Verma <vishal.l.verma(a)intel.com> libnvdimm/btt: Fix LBA masking during 'free list' population Vishal Verma <vishal.l.verma(a)intel.com> libnvdimm/btt: Remove unnecessary code in btt_freelist_init Dexuan Cui <decui(a)microsoft.com> nfit: Add Hyper-V NVDIMM DSM command set to white list Michael Ellerman <mpe(a)ellerman.id.au> powerpc/64s: Disable STRICT_KERNEL_RWX Russell Currey <ruscur(a)russell.cc> powerpc: Remove STRICT_KERNEL_RWX incompatibility with RELOCATABLE Colin Xu <colin.xu(a)intel.com> drm/i915/gvt: Init DPLL/DDI vreg for virtual display instead of inheritance. Cristian Ciocaltea <cristian.ciocaltea(a)gmail.com> dmaengine: owl: Use correct lock in owl_dma_get_pchan() Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> dmaengine: tegra210-adma: Fix an error handling path in 'tegra_adma_probe()' Xiyu Yang <xiyuyang19(a)fudan.edu.cn> apparmor: Fix aa_label refcnt leak in policy_update Xiyu Yang <xiyuyang19(a)fudan.edu.cn> apparmor: fix potential label refcnt leak in aa_change_profile Navid Emamdoost <navid.emamdoost(a)gmail.com> apparmor: Fix use-after-free in aa_audit_rule_init Christian Gmeiner <christian.gmeiner(a)gmail.com> drm/etnaviv: fix perfmon domain interation PeiSen Hou <pshou(a)realtek.com> ALSA: hda/realtek - Add more fixup entries for Clevo machines Christian Lachner <gladiac(a)gmail.com> ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Xtreme Brent Lu <brent.lu(a)intel.com> ALSA: pcm: fix incorrect hw_base increase Scott Bahling <sbahling(a)suse.com> ALSA: iec1712: Initialize STDSP24 properly when using the model=staudio option Daniel Jordan <daniel.m.jordan(a)oracle.com> padata: purge get_cpu and reorder_via_wq from padata_do_serial Daniel Jordan <daniel.m.jordan(a)oracle.com> padata: initialize pd->cpu with effective cpumask Herbert Xu <herbert(a)gondor.apana.org.au> padata: Replace delayed timer with immediate workqueue in padata_reorder Thomas Gleixner <tglx(a)linutronix.de> ARM: futex: Address build warning Hans de Goede <hdegoede(a)redhat.com> platform/x86: asus-nb-wmi: Do not load on Asus T100TA and T200TA Alan Stern <stern(a)rowland.harvard.edu> USB: core: Fix misleading driver bug report Maxim Petrov <mmrmaximuzz(a)gmail.com> stmmac: fix pointer check after utilization in stmmac_interrupt Wu Bo <wubo40(a)huawei.com> ceph: fix double unlock in handle_cap_export() Hans de Goede <hdegoede(a)redhat.com> HID: quirks: Add HID_QUIRK_NO_INIT_REPORTS quirk for Dell K12A keyboard-dock Yoshiyuki Kurauchi <ahochauwaaaaa(a)gmail.com> gtp: set NLM_F_MULTI flag in gtp_genl_dump_pdp() Thomas Gleixner <tglx(a)linutronix.de> x86/apic: Move TSC deadline timer debug printk Daniel Playfair Cal <daniel.playfair.cal(a)gmail.com> HID: i2c-hid: reset Synaptics SYNA2393 on resume Tyrel Datwyler <tyreld(a)linux.ibm.com> scsi: ibmvscsi: Fix WARN_ON during event pool release James Hilliard <james.hilliard1(a)gmail.com> component: Silence bind error on -EPROBE_DEFER Richard Clark <richard.xnu.clark(a)gmail.com> aquantia: Fix the media type of AQC100 ethernet controller in the driver Stefano Garzarella <sgarzare(a)redhat.com> vhost/vsock: fix packet delivery order to monitoring devices Xiyu Yang <xiyuyang19(a)fudan.edu.cn> configfs: fix config_item refcnt leak in configfs_rmdir() Quinn Tran <qutran(a)marvell.com> scsi: qla2xxx: Delete all sessions before unregister local nvme port Arun Easi <aeasi(a)marvell.com> scsi: qla2xxx: Fix hang when issuing nvme disconnect-all in NPIV Jiri Kosina <jkosina(a)suse.cz> HID: alps: ALPS_1657 is too specific; use U1_UNICORN_LEGACY instead Artem Borisov <dedsa2002(a)gmail.com> HID: alps: Add AUI1657 device ID Sebastian Reichel <sebastian.reichel(a)collabora.com> HID: multitouch: add eGalaxTouch P80H84 support Frédéric Pierret (fepitre) <frederic.pierret(a)qubes-os.org> gcc-common.h: Update for GCC 10 Richard Weinberger <richard(a)nod.at> ubi: Fix seq_file usage in detailed_erase_block_info debugfs file Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> i2c: mux: demux-pinctrl: Fix an error handling path in 'i2c_demux_pinctrl_probe()' Alexander Monakov <amonakov(a)ispras.ru> iommu/amd: Fix over-read of ACPI UID from IVRS table Christoph Hellwig <hch(a)lst.de> ubifs: remove broken lazytime support Al Viro <viro(a)zeniv.linux.org.uk> fix multiplication overflow in copy_fdtable() Miquel Raynal <miquel.raynal(a)bootlin.com> mtd: spinand: Propagate ECC information to the MTD structure Roberto Sassu <roberto.sassu(a)huawei.com> ima: Fix return value of ima_write_policy() Roberto Sassu <roberto.sassu(a)huawei.com> evm: Check also if *tfm is an error pointer in init_desc() Roberto Sassu <roberto.sassu(a)huawei.com> ima: Set file->f_mode instead of file->f_flags in ima_calc_file_hash() Vincent Chen <vincent.chen(a)sifive.com> riscv: set max_pfn to the PFN of the last page Miaohe Lin <linmiaohe(a)huawei.com> KVM: SVM: Fix potential memory leak in svm_cpu_init() Kevin Hao <haokexin(a)gmail.com> i2c: dev: Fix the race between the release of i2c_dev and cdev Arnd Bergmann <arnd(a)arndb.de> ubsan: build ubsan.c more conservatively Peter Zijlstra <peterz(a)infradead.org> x86/uaccess, ubsan: Fix UBSAN vs. SMAP ------------- Diffstat: Makefile | 4 +- arch/arm/include/asm/futex.h | 9 +- arch/powerpc/Kconfig | 2 +- arch/riscv/kernel/setup.c | 2 + arch/x86/include/asm/uaccess.h | 11 +- arch/x86/kernel/apic/apic.c | 27 ++--- arch/x86/kernel/unwind_orc.c | 7 ++ arch/x86/kvm/svm.c | 13 ++- drivers/acpi/nfit/core.c | 17 ++- drivers/acpi/nfit/nfit.h | 6 +- drivers/base/component.c | 8 +- drivers/dma/owl-dma.c | 8 +- drivers/dma/tegra210-adma.c | 2 +- drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 2 +- drivers/gpu/drm/i915/gvt/display.c | 49 ++++++++- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 15 ++- drivers/hid/hid-alps.c | 1 + drivers/hid/hid-ids.h | 7 +- drivers/hid/hid-multitouch.c | 3 + drivers/hid/hid-quirks.c | 1 + drivers/hid/i2c-hid/i2c-hid-core.c | 2 + drivers/i2c/i2c-dev.c | 48 +++++---- drivers/i2c/muxes/i2c-demux-pinctrl.c | 1 + drivers/iio/accel/sca3000.c | 2 +- drivers/iio/adc/stm32-adc.c | 20 +++- drivers/iio/adc/stm32-dfsdm-adc.c | 23 +++-- drivers/iio/dac/vf610_dac.c | 1 + drivers/iommu/amd_iommu_init.c | 9 +- drivers/ipack/carriers/tpci200.c | 1 + drivers/media/platform/rcar_fdp1.c | 2 +- drivers/misc/cardreader/rtsx_pcr.c | 3 + drivers/misc/mei/client.c | 2 + drivers/mtd/nand/spi/core.c | 4 + drivers/mtd/ubi/debug.c | 12 +-- .../net/ethernet/aquantia/atlantic/aq_pci_func.c | 2 +- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 63 ++++++------ drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c | 6 ++ drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 13 ++- .../net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 6 +- drivers/net/ethernet/ibm/ibmvnic.c | 8 +- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 7 +- drivers/net/gtp.c | 9 +- .../wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 + drivers/nvdimm/btt.c | 33 +++--- drivers/nvdimm/btt.h | 2 + drivers/nvdimm/btt_devs.c | 8 ++ drivers/platform/x86/asus-nb-wmi.c | 24 +++++ drivers/rapidio/devices/rio_mport_cdev.c | 5 + drivers/scsi/ibmvscsi/ibmvscsi.c | 4 - drivers/scsi/qla2xxx/qla_attr.c | 2 +- drivers/scsi/qla2xxx/qla_mbx.c | 2 +- drivers/staging/greybus/uart.c | 4 +- drivers/staging/iio/resolver/ad2s1210.c | 17 ++- drivers/staging/most/core.c | 2 +- drivers/thunderbolt/icm.c | 12 ++- drivers/thunderbolt/switch.c | 18 ---- drivers/thunderbolt/tb.c | 9 +- drivers/thunderbolt/tb.h | 1 - drivers/tty/serial/qcom_geni_serial.c | 12 ++- drivers/usb/core/message.c | 4 +- drivers/vhost/vsock.c | 10 +- fs/ceph/caps.c | 1 + fs/configfs/dir.c | 1 + fs/file.c | 2 +- fs/gfs2/glock.c | 3 - fs/ubifs/file.c | 6 +- include/linux/padata.h | 13 +-- include/linux/uaccess.h | 2 +- include/trace/events/rxrpc.h | 35 +++++++ include/uapi/linux/ndctl.h | 1 + kernel/compat.c | 6 +- kernel/exit.c | 6 +- kernel/padata.c | 114 ++++----------------- lib/Makefile | 2 + lib/strncpy_from_user.c | 9 +- lib/strnlen_user.c | 9 +- net/rxrpc/input.c | 38 ++++++- net/rxrpc/rxkad.c | 3 +- scripts/gcc-plugins/Makefile | 1 + scripts/gcc-plugins/gcc-common.h | 4 + security/apparmor/apparmorfs.c | 3 +- security/apparmor/audit.c | 3 +- security/apparmor/domain.c | 3 +- security/integrity/evm/evm_crypto.c | 2 +- security/integrity/ima/ima_crypto.c | 12 +-- security/integrity/ima/ima_fs.c | 3 +- sound/core/pcm_lib.c | 1 + sound/pci/hda/patch_realtek.c | 4 + sound/pci/ice1712/ice1712.c | 3 +- 89 files changed, 537 insertions(+), 362 deletions(-)

4 years, 7 months

7
92
0 0

[PATCH] sched/headers: Fix sched_setattr userspace compilation breakage

by Joel Fernandes (Google)

On a modern Linux distro, compiling the following program fails: #include<stdlib.h> #include<stdint.h> #include<pthread.h> #include<linux/sched/types.h> void main() { struct sched_attr sa; return; } with: /usr/include/linux/sched/types.h:8:8: \ error: redefinition of ‘struct sched_param’ 8 | struct sched_param { | ^~~~~~~~~~~ In file included from /usr/include/x86_64-linux-gnu/bits/sched.h:74, from /usr/include/sched.h:43, from /usr/include/pthread.h:23, from /tmp/s.c:4: /usr/include/x86_64-linux-gnu/bits/types/struct_sched_param.h:23:8: note: originally defined here 23 | struct sched_param | ^~~~~~~~~~~ This also causes a problem with using sched_attr in Chrome. The issue is sched_param is already provided by glibc. Guard the kernel's UAPI definition of sched_param with __KERNEL__ so that userspace can compile. Fixes: e2d1e2aec572a ("sched/headers: Move various ABI definitions to <uapi/linux/sched/types.h>" Signed-off-by: Joel Fernandes (Google) <joel(a)joelfernandes.org> --- include/uapi/linux/sched/types.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/sched/types.h b/include/uapi/linux/sched/types.h index c852153ddb0d3..1f10d935a63fe 100644 --- a/include/uapi/linux/sched/types.h +++ b/include/uapi/linux/sched/types.h @@ -4,9 +4,11 @@ #include <linux/types.h> +#if defined(__KERNEL__) struct sched_param { int sched_priority; }; +#endif #define SCHED_ATTR_SIZE_VER0 48 /* sizeof first published struct */ #define SCHED_ATTR_SIZE_VER1 56 /* add: util_{min,max} */ -- 2.26.2.761.g0e0b3e54be-goog

4 years, 7 months

3
6
0 0

[PATCH] virtio_vsock: Fix race condition in virtio_transport_recv_pkt

by Jia He

When client tries to connect(SOCK_STREAM) the server in the guest with NONBLOCK mode, there will be a panic on a ThunderX2 (armv8a server): [ 463.718844][ T5040] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 [ 463.718848][ T5040] Mem abort info: [ 463.718849][ T5040] ESR = 0x96000044 [ 463.718852][ T5040] EC = 0x25: DABT (current EL), IL = 32 bits [ 463.718853][ T5040] SET = 0, FnV = 0 [ 463.718854][ T5040] EA = 0, S1PTW = 0 [ 463.718855][ T5040] Data abort info: [ 463.718856][ T5040] ISV = 0, ISS = 0x00000044 [ 463.718857][ T5040] CM = 0, WnR = 1 [ 463.718859][ T5040] user pgtable: 4k pages, 48-bit VAs, pgdp=0000008f6f6e9000 [ 463.718861][ T5040] [0000000000000000] pgd=0000000000000000 [ 463.718866][ T5040] Internal error: Oops: 96000044 [#1] SMP [...] [ 463.718977][ T5040] CPU: 213 PID: 5040 Comm: vhost-5032 Tainted: G O 5.7.0-rc7+ #139 [ 463.718980][ T5040] Hardware name: GIGABYTE R281-T91-00/MT91-FS1-00, BIOS F06 09/25/2018 [ 463.718982][ T5040] pstate: 60400009 (nZCv daif +PAN -UAO) [ 463.718995][ T5040] pc : virtio_transport_recv_pkt+0x4c8/0xd40 [vmw_vsock_virtio_transport_common] [ 463.718999][ T5040] lr : virtio_transport_recv_pkt+0x1fc/0xd40 [vmw_vsock_virtio_transport_common] [ 463.719000][ T5040] sp : ffff80002dbe3c40 [...] [ 463.719025][ T5040] Call trace: [ 463.719030][ T5040] virtio_transport_recv_pkt+0x4c8/0xd40 [vmw_vsock_virtio_transport_common] [ 463.719034][ T5040] vhost_vsock_handle_tx_kick+0x360/0x408 [vhost_vsock] [ 463.719041][ T5040] vhost_worker+0x100/0x1a0 [vhost] [ 463.719048][ T5040] kthread+0x128/0x130 [ 463.719052][ T5040] ret_from_fork+0x10/0x18 The race condition as follows: Task1 Task2 ===== ===== __sock_release virtio_transport_recv_pkt __vsock_release vsock_find_bound_socket (found) lock_sock_nested vsock_remove_sock sock_orphan sk_set_socket(sk, NULL) ... release_sock lock_sock virtio_transport_recv_connecting sk->sk_socket->state (panic) This fixes it by checking vsk again whether it is in bound/connected table. Signed-off-by: Jia He <justin.he(a)arm.com> Cc: stable(a)vger.kernel.org --- net/vmw_vsock/virtio_transport_common.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c index 69efc891885f..0dbd6a45f0ed 100644 --- a/net/vmw_vsock/virtio_transport_common.c +++ b/net/vmw_vsock/virtio_transport_common.c @@ -1132,6 +1132,17 @@ void virtio_transport_recv_pkt(struct virtio_transport *t, lock_sock(sk); + /* Check it again if vsk is removed by vsock_remove_sock */ + spin_lock_bh(&vsock_table_lock); + if (!__vsock_in_bound_table(vsk) && !__vsock_in_connected_table(vsk)) { + spin_unlock_bh(&vsock_table_lock); + (void)virtio_transport_reset_no_sock(t, pkt); + release_sock(sk); + sock_put(sk); + goto free_pkt; + } + spin_unlock_bh(&vsock_table_lock); + /* Update CID in case it has changed after a transport reset event */ vsk->local_addr.svm_cid = dst.svm_cid; -- 2.17.1

4 years, 7 months

3
2
0 0

[PATCH] usb: dwc2: Fix shutdown callback in platform

by Minas Harutyunyan

To avoid lot of interrupts from dwc2 core, which can be asserted in specific conditions need to disable interrupts on HW level instead of disable IRQs on Kernel level, because of IRQ can be shared between drivers. Cc: stable(a)vger.kernel.org Fixes: a40a00318c7fc ("usb: dwc2: add shutdown callback to platform variant") Tested-by: Frank Mori Hess <fmh6jj(a)gmail.com> Signed-off-by: Minas Harutyunyan <hminas(a)synopsys.com> --- drivers/usb/dwc2/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index e571c8ae65ec..ada5b66b948e 100644 --- a/drivers/usb/dwc2/platform.c +++ b/drivers/usb/dwc2/platform.c @@ -342,7 +342,7 @@ static void dwc2_driver_shutdown(struct platform_device *dev) { struct dwc2_hsotg *hsotg = platform_get_drvdata(dev); - disable_irq(hsotg->irq); + dwc2_disable_global_interrupts(hsotg); } /** -- 2.11.0

4 years, 7 months

2
1
0 0

[PATCH V1] mmc: sdhci-msm: Clear tuning done flag while hs400 tuning

by Veerabhadrarao Badiganti

Clear tuning_done flag while executing tuning to ensure vendor specific HS400 settings are applied properly when the controller is re-initialized in HS400 mode. Without this, re-initialization of the qcom SDHC in HS400 mode fails while resuming the driver from runtime-suspend or system-suspend. Fixes: ff06ce4 ("mmc: sdhci-msm: Add HS400 platform support") Cc: stable(a)vger.kernel.org Signed-off-by: Veerabhadrarao Badiganti <vbadigan(a)codeaurora.org> --- drivers/mmc/host/sdhci-msm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 95cd973..b277dd7 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -1174,6 +1174,12 @@ static int sdhci_msm_execute_tuning(struct mmc_host *mmc, u32 opcode) msm_host->use_cdr = true; /* + * Clear tuning_done flag before tuning to ensure proper + * HS400 settings. + */ + msm_host->tuning_done = 0; + + /* * For HS400 tuning in HS200 timing requires: * - select MCLK/2 in VENDOR_SPEC * - program MCLK to 400MHz (or nearest supported) in GCC -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

4 years, 7 months

2
2
0 0

[PATCH] virtio_vsock: Fix race condition in virtio_transport_recv_pkt

by Jia He

When client tries to connect(SOCK_STREAM) the server in the guest with NONBLOCK mode, there will be a panic on a ThunderX2 (armv8a server): [ 463.718844][ T5040] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 [ 463.718848][ T5040] Mem abort info: [ 463.718849][ T5040] ESR = 0x96000044 [ 463.718852][ T5040] EC = 0x25: DABT (current EL), IL = 32 bits [ 463.718853][ T5040] SET = 0, FnV = 0 [ 463.718854][ T5040] EA = 0, S1PTW = 0 [ 463.718855][ T5040] Data abort info: [ 463.718856][ T5040] ISV = 0, ISS = 0x00000044 [ 463.718857][ T5040] CM = 0, WnR = 1 [ 463.718859][ T5040] user pgtable: 4k pages, 48-bit VAs, pgdp=0000008f6f6e9000 [ 463.718861][ T5040] [0000000000000000] pgd=0000000000000000 [ 463.718866][ T5040] Internal error: Oops: 96000044 [#1] SMP [...] [ 463.718977][ T5040] CPU: 213 PID: 5040 Comm: vhost-5032 Tainted: G O 5.7.0-rc7+ #139 [ 463.718980][ T5040] Hardware name: GIGABYTE R281-T91-00/MT91-FS1-00, BIOS F06 09/25/2018 [ 463.718982][ T5040] pstate: 60400009 (nZCv daif +PAN -UAO) [ 463.718995][ T5040] pc : virtio_transport_recv_pkt+0x4c8/0xd40 [vmw_vsock_virtio_transport_common] [ 463.718999][ T5040] lr : virtio_transport_recv_pkt+0x1fc/0xd40 [vmw_vsock_virtio_transport_common] [ 463.719000][ T5040] sp : ffff80002dbe3c40 [...] [ 463.719025][ T5040] Call trace: [ 463.719030][ T5040] virtio_transport_recv_pkt+0x4c8/0xd40 [vmw_vsock_virtio_transport_common] [ 463.719034][ T5040] vhost_vsock_handle_tx_kick+0x360/0x408 [vhost_vsock] [ 463.719041][ T5040] vhost_worker+0x100/0x1a0 [vhost] [ 463.719048][ T5040] kthread+0x128/0x130 [ 463.719052][ T5040] ret_from_fork+0x10/0x18 The race condition as follows: Task1 Task2 ===== ===== __sock_release virtio_transport_recv_pkt __vsock_release vsock_find_bound_socket (found) lock_sock_nested vsock_remove_sock sock_orphan sk_set_socket(sk, NULL) ... release_sock lock_sock virtio_transport_recv_connecting sk->sk_socket->state (panic) This fixes it by checking vsk again whether it is in bound/connected table. Signed-off-by: Jia He <justin.he(a)arm.com> Cc: stable(a)vger.kernel.org --- net/vmw_vsock/virtio_transport_common.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c index 69efc891885f..464eae44ef1f 100644 --- a/net/vmw_vsock/virtio_transport_common.c +++ b/net/vmw_vsock/virtio_transport_common.c @@ -1132,6 +1132,14 @@ void virtio_transport_recv_pkt(struct virtio_transport *t, lock_sock(sk); + /* Check it again if vsk is removed by vsock_remove_sock */ + if (!__vsock_in_bound_table(vsk) && !__vsock_in_connected_table(vsk)) { + (void)virtio_transport_reset_no_sock(t, pkt); + release_sock(sk); + sock_put(sk); + goto free_pkt; + } + /* Update CID in case it has changed after a transport reset event */ vsk->local_addr.svm_cid = dst.svm_cid; -- 2.17.1

4 years, 7 months

1
0
0 0

[PATCH] net: octeon: mgmt: Repair filling of RX ring

by Alexander A Sverdlin

From: Alexander Sverdlin <alexander.sverdlin(a)nokia.com> The removal of mips_swiotlb_ops exposed a problem in octeon_mgmt Ethernet driver. mips_swiotlb_ops had an mb() after most of the operations and the removal of the ops had broken the receive functionality of the driver. My code inspection has shown no other places except octeon_mgmt_rx_fill_ring() where an explicit barrier would be obviously missing. The latter function however has to make sure that "ringing the bell" doesn't happen before RX ring entry is really written. The patch has been successfully tested on Octeon II. Fixes: a999933db9ed ("MIPS: remove mips_swiotlb_ops") Cc: stable(a)vger.kernel.org Signed-off-by: Alexander Sverdlin <alexander.sverdlin(a)nokia.com> --- drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c index 07b960e..79c110a 100644 --- a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c +++ b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c @@ -235,6 +235,11 @@ static void octeon_mgmt_rx_fill_ring(struct net_device *netdev) /* Put it in the ring. */ p->rx_ring[p->rx_next_fill] = re.d64; + /* Make sure there is no reorder of filling the ring and ringing + * the bell + */ + wmb(); + dma_sync_single_for_device(p->dev, p->rx_ring_handle, ring_size_to_bytes(OCTEON_MGMT_RX_RING_SIZE), DMA_BIDIRECTIONAL); -- 2.10.2

4 years, 7 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror May 2020