May 2020 - Linux-stable-mirror

Re: ✓ Fi.CI.IGT: success for drm/dp_mst: Fix timeout handling of MST down messages

by Imre Deak

On Wed, May 13, 2020 at 02:40:29PM +0000, Patchwork wrote: > == Series Details == > > Series: drm/dp_mst: Fix timeout handling of MST down messages > URL : https://patchwork.freedesktop.org/series/77216/ > State : success Patch pushed to drm-misc-next, thanks for the review. > > == Summary == > > CI Bug Log - changes from CI_DRM_8472_full -> Patchwork_17643_full > ==================================================== > > Summary > ------- > > **SUCCESS** > > No regressions found. > > > > New tests > --------- > > New tests have been introduced between CI_DRM_8472_full and Patchwork_17643_full: > > ### New IGT tests (123) ### > > * igt@kms_cursor_crc@pipe-a-cursor-128x128-offscreen: > - Statuses : 7 pass(s) > - Exec time: [2.97, 4.97] s > > * igt@kms_cursor_crc@pipe-a-cursor-128x128-onscreen: > - Statuses : 8 pass(s) > - Exec time: [1.73, 2.92] s > > * igt@kms_cursor_crc@pipe-a-cursor-128x128-random: > - Statuses : 8 pass(s) > - Exec time: [2.74, 4.76] s > > * igt@kms_cursor_crc@pipe-a-cursor-128x128-rapid-movement: > - Statuses : 8 pass(s) > - Exec time: [0.19, 1.11] s > > * igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding: > - Statuses : 8 pass(s) > - Exec time: [2.59, 4.28] s > > * igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 4.96] s > > * igt@kms_cursor_crc@pipe-a-cursor-128x42-onscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 2.89] s > > * igt@kms_cursor_crc@pipe-a-cursor-128x42-random: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 4.46] s > > * igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 4.28] s > > * igt@kms_cursor_crc@pipe-a-cursor-256x256-offscreen: > - Statuses : 8 pass(s) > - Exec time: [2.97, 4.94] s > > * igt@kms_cursor_crc@pipe-a-cursor-256x256-onscreen: > - Statuses : 8 pass(s) > - Exec time: [1.73, 2.90] s > > * igt@kms_cursor_crc@pipe-a-cursor-256x256-random: > - Statuses : 1 fail(s) 7 pass(s) > - Exec time: [0.44, 4.41] s > > * igt@kms_cursor_crc@pipe-a-cursor-256x256-rapid-movement: > - Statuses : 7 pass(s) > - Exec time: [0.29, 1.14] s > > * igt@kms_cursor_crc@pipe-a-cursor-256x256-sliding: > - Statuses : 8 pass(s) > - Exec time: [2.61, 4.30] s > > * igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen: > - Statuses : 1 fail(s) 6 pass(s) 1 skip(s) > - Exec time: [0.0, 4.97] s > > * igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 2.87] s > > * igt@kms_cursor_crc@pipe-a-cursor-256x85-random: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 4.43] s > > * igt@kms_cursor_crc@pipe-a-cursor-256x85-sliding: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 4.26] s > > * igt@kms_cursor_crc@pipe-a-cursor-512x170-offscreen: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-a-cursor-512x170-onscreen: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-a-cursor-512x170-random: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-a-cursor-512x170-sliding: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-a-cursor-512x512-onscreen: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-a-cursor-512x512-random: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 4.96] s > > * igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 2.89] s > > * igt@kms_cursor_crc@pipe-a-cursor-64x21-random: > - Statuses : 1 fail(s) 6 pass(s) 1 skip(s) > - Exec time: [0.0, 4.45] s > > * igt@kms_cursor_crc@pipe-a-cursor-64x21-sliding: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 4.74] s > > * igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen: > - Statuses : 8 pass(s) > - Exec time: [2.95, 4.96] s > > * igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen: > - Statuses : 8 pass(s) > - Exec time: [1.76, 3.29] s > > * igt@kms_cursor_crc@pipe-a-cursor-64x64-random: > - Statuses : 8 pass(s) > - Exec time: [2.69, 4.51] s > > * igt@kms_cursor_crc@pipe-a-cursor-64x64-rapid-movement: > - Statuses : 8 pass(s) > - Exec time: [0.18, 1.13] s > > * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding: > - Statuses : 8 pass(s) > - Exec time: [2.64, 4.67] s > > * igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque: > - Statuses : 8 pass(s) > - Exec time: [0.26, 1.11] s > > * igt@kms_cursor_crc@pipe-a-cursor-alpha-transparent: > - Statuses : 8 pass(s) > - Exec time: [0.27, 1.08] s > > * igt@kms_cursor_crc@pipe-a-cursor-dpms: > - Statuses : 8 pass(s) > - Exec time: [0.83, 4.46] s > > * igt@kms_cursor_crc@pipe-a-cursor-size-change: > - Statuses : 8 pass(s) > - Exec time: [0.49, 1.89] s > > * igt@kms_cursor_crc@pipe-a-cursor-suspend: > - Statuses : 8 pass(s) > - Exec time: [2.05, 5.28] s > > * igt@kms_cursor_crc@pipe-b-cursor-128x128-offscreen: > - Statuses : 8 pass(s) > - Exec time: [4.10, 5.89] s > > * igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen: > - Statuses : 8 pass(s) > - Exec time: [2.26, 4.06] s > > * igt@kms_cursor_crc@pipe-b-cursor-128x128-random: > - Statuses : 8 pass(s) > - Exec time: [3.71, 5.48] s > > * igt@kms_cursor_crc@pipe-b-cursor-128x128-rapid-movement: > - Statuses : 8 pass(s) > - Exec time: [0.28, 2.23] s > > * igt@kms_cursor_crc@pipe-b-cursor-128x128-sliding: > - Statuses : 8 pass(s) > - Exec time: [3.60, 5.36] s > > * igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.89] s > > * igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 4.03] s > > * igt@kms_cursor_crc@pipe-b-cursor-128x42-random: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.92] s > > * igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.36] s > > * igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen: > - Statuses : 8 pass(s) > - Exec time: [4.09, 5.89] s > > * igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen: > - Statuses : 8 pass(s) > - Exec time: [2.25, 3.97] s > > * igt@kms_cursor_crc@pipe-b-cursor-256x256-random: > - Statuses : 8 pass(s) > - Exec time: [3.73, 5.49] s > > * igt@kms_cursor_crc@pipe-b-cursor-256x256-rapid-movement: > - Statuses : 8 pass(s) > - Exec time: [0.26, 2.23] s > > * igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding: > - Statuses : 8 pass(s) > - Exec time: [3.59, 5.36] s > > * igt@kms_cursor_crc@pipe-b-cursor-256x85-offscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.88] s > > * igt@kms_cursor_crc@pipe-b-cursor-256x85-onscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 4.45] s > > * igt@kms_cursor_crc@pipe-b-cursor-256x85-random: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.50] s > > * igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.36] s > > * igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-b-cursor-512x170-onscreen: > - Statuses : 7 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-b-cursor-512x170-random: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-b-cursor-512x170-sliding: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-b-cursor-512x512-offscreen: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-b-cursor-512x512-onscreen: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-b-cursor-512x512-random: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-b-cursor-512x512-rapid-movement: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-b-cursor-512x512-sliding: > - Statuses : 7 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.90] s > > * igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 4.02] s > > * igt@kms_cursor_crc@pipe-b-cursor-64x21-random: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.49] s > > * igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.33] s > > * igt@kms_cursor_crc@pipe-b-cursor-64x64-offscreen: > - Statuses : 8 pass(s) > - Exec time: [4.08, 6.38] s > > * igt@kms_cursor_crc@pipe-b-cursor-64x64-onscreen: > - Statuses : 8 pass(s) > - Exec time: [2.30, 4.51] s > > * igt@kms_cursor_crc@pipe-b-cursor-64x64-random: > - Statuses : 8 pass(s) > - Exec time: [3.72, 5.50] s > > * igt@kms_cursor_crc@pipe-b-cursor-64x64-rapid-movement: > - Statuses : 8 pass(s) > - Exec time: [0.26, 2.27] s > > * igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding: > - Statuses : 8 pass(s) > - Exec time: [3.59, 5.35] s > > * igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque: > - Statuses : 8 pass(s) > - Exec time: [0.37, 2.21] s > > * igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent: > - Statuses : 8 pass(s) > - Exec time: [0.42, 2.20] s > > * igt@kms_cursor_crc@pipe-b-cursor-dpms: > - Statuses : 8 pass(s) > - Exec time: [0.78, 5.30] s > > * igt@kms_cursor_crc@pipe-b-cursor-size-change: > - Statuses : 8 pass(s) > - Exec time: [0.52, 2.35] s > > * igt@kms_cursor_crc@pipe-b-cursor-suspend: > - Statuses : 8 pass(s) > - Exec time: [1.86, 6.19] s > > * igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen: > - Statuses : 1 fail(s) 6 pass(s) 1 skip(s) > - Exec time: [0.0, 5.41] s > > * igt@kms_cursor_crc@pipe-c-cursor-128x128-onscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 4.44] s > > * igt@kms_cursor_crc@pipe-c-cursor-128x128-random: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.95] s > > * igt@kms_cursor_crc@pipe-c-cursor-128x128-rapid-movement: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 2.23] s > > * igt@kms_cursor_crc@pipe-c-cursor-128x128-sliding: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.32] s > > * igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.88] s > > * igt@kms_cursor_crc@pipe-c-cursor-128x42-onscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 3.98] s > > * igt@kms_cursor_crc@pipe-c-cursor-128x42-random: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.46] s > > * igt@kms_cursor_crc@pipe-c-cursor-128x42-sliding: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.75] s > > * igt@kms_cursor_crc@pipe-c-cursor-256x256-offscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.88] s > > * igt@kms_cursor_crc@pipe-c-cursor-256x256-onscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 4.01] s > > * igt@kms_cursor_crc@pipe-c-cursor-256x256-random: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.46] s > > * igt@kms_cursor_crc@pipe-c-cursor-256x256-rapid-movement: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 2.24] s > > * igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding: > - Statuses : 6 pass(s) 1 skip(s) > - Exec time: [0.0, 6.68] s > > * igt@kms_cursor_crc@pipe-c-cursor-256x85-offscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 6.67] s > > * igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 3.98] s > > * igt@kms_cursor_crc@pipe-c-cursor-256x85-random: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.42] s > > * igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding: > - Statuses : 1 fail(s) 6 pass(s) 1 skip(s) > - Exec time: [0.0, 4.86] s > > * igt@kms_cursor_crc@pipe-c-cursor-512x170-offscreen: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-c-cursor-512x170-onscreen: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-c-cursor-512x170-random: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-c-cursor-512x170-sliding: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-c-cursor-512x512-offscreen: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-c-cursor-512x512-onscreen: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-c-cursor-512x512-random: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-c-cursor-512x512-rapid-movement: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-c-cursor-512x512-sliding: > - Statuses : 8 skip(s) > - Exec time: [0.0] s > > * igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.92] s > > * igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 3.97] s > > * igt@kms_cursor_crc@pipe-c-cursor-64x21-random: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.49] s > > * igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.35] s > > * igt@kms_cursor_crc@pipe-c-cursor-64x64-offscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.87] s > > * igt@kms_cursor_crc@pipe-c-cursor-64x64-onscreen: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 3.97] s > > * igt@kms_cursor_crc@pipe-c-cursor-64x64-random: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.48] s > > * igt@kms_cursor_crc@pipe-c-cursor-64x64-rapid-movement: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 2.27] s > > * igt@kms_cursor_crc@pipe-c-cursor-64x64-sliding: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 5.80] s > > * igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 2.64] s > > * igt@kms_cursor_crc@pipe-c-cursor-alpha-transparent: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 2.21] s > > * igt@kms_cursor_crc@pipe-c-cursor-dpms: > - Statuses : 6 pass(s) 1 skip(s) > - Exec time: [0.0, 5.33] s > > * igt@kms_cursor_crc@pipe-c-cursor-size-change: > - Statuses : 7 pass(s) 1 skip(s) > - Exec time: [0.0, 2.33] s > > * igt@kms_cursor_crc@pipe-c-cursor-suspend: > - Statuses : 1 incomplete(s) 6 pass(s) 1 skip(s) > - Exec time: [0.0, 6.39] s > > > > Known issues > ------------ > > Here are the changes found in Patchwork_17643_full that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@gem_workarounds@suspend-resume-fd: > - shard-apl: [PASS][1] -> [DMESG-WARN][2] ([i915#180]) > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-apl1/igt@gem_wor… > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17643/shard-apl4/igt@gem… > > * igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding (NEW): > - shard-skl: [PASS][3] -> [FAIL][4] ([i915#54]) > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-skl2/igt@kms_cur… > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17643/shard-skl3/igt@kms… > > * igt@kms_cursor_legacy@short-flip-before-cursor-toggle: > - shard-snb: [PASS][5] -> [SKIP][6] ([fdo#109271]) +1 similar issue > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-snb4/igt@kms_cur… > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17643/shard-snb4/igt@kms… > > * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: > - shard-skl: [PASS][7] -> [FAIL][8] ([fdo#108145] / [i915#265]) +1 similar issue > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-skl3/igt@kms_pla… > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17643/shard-skl7/igt@kms… > > * igt@kms_psr@psr2_cursor_mmap_cpu: > - shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109441]) +3 similar issues > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-iclb2/igt@kms_ps… > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17643/shard-iclb1/igt@km… > > > #### Possible fixes #### > > * igt@gem_eio@in-flight-suspend: > - shard-skl: [INCOMPLETE][11] ([i915#69]) -> [PASS][12] > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-skl4/igt@gem_eio… > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17643/shard-skl2/igt@gem… > > * igt@gem_softpin@noreloc-s3: > - shard-kbl: [DMESG-WARN][13] ([i915#180]) -> [PASS][14] > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-kbl4/igt@gem_sof… > [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17643/shard-kbl3/igt@gem… > > * igt@gen9_exec_parse@allowed-all: > - shard-apl: [DMESG-WARN][15] ([i915#1436] / [i915#716]) -> [PASS][16] > [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-apl4/igt@gen9_ex… > [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17643/shard-apl3/igt@gen… > > * igt@i915_selftest@live@execlists: > - shard-skl: [INCOMPLETE][17] ([i915#1874]) -> [PASS][18] > [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-skl6/igt@i915_se… > [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17643/shard-skl7/igt@i91… > > * {igt@kms_flip@flip-vs-suspend-interruptible@c-dp1}: > - shard-apl: [DMESG-WARN][19] ([i915#180]) -> [PASS][20] +2 similar issues > [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-apl8/igt@kms_fli… > [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17643/shard-apl7/igt@kms… > > * igt@kms_psr@psr2_primary_blt: > - shard-iclb: [SKIP][21] ([fdo#109441]) -> [PASS][22] > [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-iclb8/igt@kms_ps… > [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17643/shard-iclb2/igt@km… > > > #### Warnings #### > > * igt@kms_content_protection@lic: > - shard-apl: [FAIL][23] ([fdo#110321]) -> [TIMEOUT][24] ([i915#1319]) +1 similar issue > [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-apl8/igt@kms_con… > [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17643/shard-apl7/igt@kms… > > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 > [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 > [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 > [fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321 > [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 > [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 > [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 > [i915#1874]: https://gitlab.freedesktop.org/drm/intel/issues/1874 > [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 > [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 > [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69 > [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 > > > Participating hosts (11 -> 11) > ------------------------------ > > No changes in participating hosts > > > Build changes > ------------- > > * CI: CI-20190529 -> None > * Linux: CI_DRM_8472 -> Patchwork_17643 > > CI-20190529: 20190529 > CI_DRM_8472: 57acc5ba2cfb81691917a3da729573a99c893e5a @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_5651: e54e2642f1967ca3c488db32264607df670d1dfb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_17643: 211186b681ff1bc9c2f4f70d495e1072ae5ee0b4 @ git://anongit.freedesktop.org/gfx-ci/linux > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17643/index.html

4 years, 7 months

1
0
0 0

[PATCH] drm/etnaviv: fix perfmon domain interation

by Christian Gmeiner

The GC860 has one GPU device which has a 2d and 3d core. In this case we want to expose perfmon information for both cores. The driver has one array which contains all possible perfmon domains with some meta data - doms_meta. Here we can see that for the GC860 two elements of that array are relevant: doms_3d: is at index 0 in the doms_meta array with 8 perfmon domains doms_2d: is at index 1 in the doms_meta array with 1 perfmon domain The userspace driver wants to get a list of all perfmon domains and their perfmon signals. This is done by iterating over all domains and their signals. If the userspace driver wants to access the domain with id 8 the kernel driver fails and returns invalid data from doms_3d with and invalid offset. This results in: Unable to handle kernel paging request at virtual address 00000000 On such a device it is not possible to use the userspace driver at all. The fix for this off-by-one error is quite simple. Reported-by: Paul Cercueil <paul(a)crapouillou.net> Tested-by: Paul Cercueil <paul(a)crapouillou.net> Fixes: ed1dd899baa3 ("drm/etnaviv: rework perfmon query infrastructure") Cc: stable(a)vger.kernel.org Signed-off-by: Christian Gmeiner <christian.gmeiner(a)gmail.com> --- drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c index e6795bafcbb9..35f7171e779a 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c @@ -453,7 +453,7 @@ static const struct etnaviv_pm_domain *pm_domain(const struct etnaviv_gpu *gpu, if (!(gpu->identity.features & meta->feature)) continue; - if (meta->nr_domains < (index - offset)) { + if ((meta->nr_domains - 1) < (index - offset)) { offset += meta->nr_domains; continue; } -- 2.26.2

4 years, 7 months

3
7
0 0

[PATCH 5.6 000/118] 5.6.13-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.6.13 release. There are 118 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Fri, 15 May 2020 09:41:20 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.6.13-rc1… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.6.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.6.13-rc1 Amir Goldstein <amir73il(a)gmail.com> fanotify: merge duplicate events on parent and child Amir Goldstein <amir73il(a)gmail.com> fsnotify: replace inode pointer with an object id Max Kellermann <mk(a)cm4all.com> io_uring: don't use 'fd' for openat/openat2/statx Christoph Hellwig <hch(a)lst.de> bdi: add a ->dev_name field to struct backing_dev_info Christoph Hellwig <hch(a)lst.de> bdi: move bdi_dev_name out of line Yafang Shao <laoar.shao(a)gmail.com> mm, memcg: fix error return value of mem_cgroup_css_alloc() Ivan Delalande <colona(a)arista.com> scripts/decodecode: fix trapping instruction formatting Julia Lawall <Julia.Lawall(a)inria.fr> iommu/virtio: Reverse arguments to list_add Josh Poimboeuf <jpoimboe(a)redhat.com> objtool: Fix stack offset tracking for indirect CFAs Paolo Bonzini <pbonzini(a)redhat.com> kvm: ioapic: Restrict lazy EOI update to edge-triggered interrupts Arnd Bergmann <arnd(a)arndb.de> netfilter: nf_osf: avoid passing pointer to local var Guillaume Nault <gnault(a)redhat.com> netfilter: nat: never update the UDP checksum when it's 0 Janakarajan Natarajan <Janakarajan.Natarajan(a)amd.com> arch/x86/kvm/svm/sev.c: change flag passed to GUP fast in sev_pin_memory() Suravee Suthikulpanit <suravee.suthikulpanit(a)amd.com> KVM: x86: Fixes posted interrupt check for IRQs delivery modes Josh Poimboeuf <jpoimboe(a)redhat.com> x86/unwind/orc: Fix premature unwind stoppage due to IRET frames Josh Poimboeuf <jpoimboe(a)redhat.com> x86/unwind/orc: Fix error path for bad ORC entry type Josh Poimboeuf <jpoimboe(a)redhat.com> x86/unwind/orc: Prevent unwinding before ORC initialization Miroslav Benes <mbenes(a)suse.cz> x86/unwind/orc: Don't skip the first frame for inactive tasks Jann Horn <jannh(a)google.com> x86/entry/64: Fix unwind hints in rewind_stack_do_exit() Josh Poimboeuf <jpoimboe(a)redhat.com> x86/entry/64: Fix unwind hints in __switch_to_asm() Josh Poimboeuf <jpoimboe(a)redhat.com> x86/entry/64: Fix unwind hints in kernel exit path Josh Poimboeuf <jpoimboe(a)redhat.com> x86/entry/64: Fix unwind hints in register clearing code Rick Edgecombe <rick.p.edgecombe(a)intel.com> x86/mm/cpa: Flush direct map alias during cpa Xiyu Yang <xiyuyang19(a)fudan.edu.cn> batman-adv: Fix refcnt leak in batadv_v_ogm_process Xiyu Yang <xiyuyang19(a)fudan.edu.cn> batman-adv: Fix refcnt leak in batadv_store_throughput_override Xiyu Yang <xiyuyang19(a)fudan.edu.cn> batman-adv: Fix refcnt leak in batadv_show_throughput_override George Spelvin <lkml(a)sdf.org> batman-adv: fix batadv_nc_random_weight_tq Tejun Heo <tj(a)kernel.org> iocost: protect iocg->abs_vdebt with iocg->waitq.lock Vincent Chen <vincent.chen(a)sifive.com> riscv: set max_pfn to the PFN of the last page Luis Chamberlain <mcgrof(a)kernel.org> coredump: fix crash when umh is disabled Oscar Carter <oscar.carter(a)gmx.com> staging: gasket: Check the return value of gasket_get_bar_index() Luis Henriques <lhenriques(a)suse.com> ceph: demote quotarealm lookup warning to a debug message Jeff Layton <jlayton(a)kernel.org> ceph: fix endianness bug when handling MDS session feature bits Henry Willard <henry.willard(a)oracle.com> mm: limit boost_watermark on small zones David Hildenbrand <david(a)redhat.com> mm/page_alloc: fix watchdog soft lockups during set_zone_contiguous() Khazhismel Kumykov <khazhy(a)google.com> eventpoll: fix missing wakeup for ovflist in ep_poll_callback Roman Penyaev <rpenyaev(a)suse.de> epoll: atomically remove wait entry on wake up Oleg Nesterov <oleg(a)redhat.com> ipc/mqueue.c: change __do_notify() to bypass check_kill_permission() Daniel Kolesa <daniel(a)octaforge.org> drm/amd/display: work around fp code being emitted outside of DC_FP_START/END H. Nikolaus Schaller <hns(a)goldelico.com> drm: ingenic-drm: add MODULE_DEVICE_TABLE Tomas Winkler <tomas.winkler(a)intel.com> mei: me: disable mei interface on LBG servers. Ulf Hansson <ulf.hansson(a)linaro.org> amba: Initialize dma_parms for amba devices Ulf Hansson <ulf.hansson(a)linaro.org> driver core: platform: Initialize dma_parms for platform devices Mark Rutland <mark.rutland(a)arm.com> arm64: hugetlb: avoid potential NULL dereference Marc Zyngier <maz(a)kernel.org> KVM: arm64: Fix 32bit PC wrap-around Marc Zyngier <maz(a)kernel.org> KVM: arm: vgic: Fix limit condition when writing to GICD_I[CS]ACTIVER Sean Christopherson <sean.j.christopherson(a)intel.com> KVM: VMX: Explicitly clear RFLAGS.CF and RFLAGS.ZF in VM-Exit RSB path Christian Borntraeger <borntraeger(a)de.ibm.com> KVM: s390: Remove false WARN_ON_ONCE for the PQAP instruction Jason A. Donenfeld <Jason(a)zx2c4.com> crypto: arch/lib - limit simd usage to 4k chunks Jason A. Donenfeld <Jason(a)zx2c4.com> crypto: arch/nhpoly1305 - process in explicit 4k chunks Steven Rostedt (VMware) <rostedt(a)goodmis.org> tracing: Add a vmalloc_sync_mappings() for safe measure Steven Rostedt (VMware) <rostedt(a)goodmis.org> tracing: Wait for preempt irq delay thread to finish Masami Hiramatsu <mhiramat(a)kernel.org> tracing/kprobes: Reject new event if loc is NULL Masami Hiramatsu <mhiramat(a)kernel.org> tracing/boottime: Fix kprobe event API usage Oliver Neukum <oneukum(a)suse.com> USB: serial: garmin_gps: add sanity checking for data length Bryan O'Donoghue <bryan.odonoghue(a)linaro.org> usb: chipidea: msm: Ensure proper controller reset using role switch API Oliver Neukum <oneukum(a)suse.com> USB: uas: add quirk for LaCie 2Big Quadra Jason Gerecke <killertofu(a)gmail.com> HID: wacom: Report 2nd-gen Intuos Pro S center button status over BT Alan Stern <stern(a)rowland.harvard.edu> HID: usbhid: Fix race between usbhid_close() and usbhid_stop() Jason Gerecke <killertofu(a)gmail.com> Revert "HID: wacom: generic: read the number of expected touches on a per collection basis" Jere Leppänen <jere.leppanen(a)nokia.com> sctp: Fix bundling of SHUTDOWN with COOKIE-ACK Jason Gerecke <jason.gerecke(a)wacom.com> HID: wacom: Read HID_DG_CONTACTMAX directly for non-generic devices Jason A. Donenfeld <Jason(a)zx2c4.com> wireguard: send/receive: cond_resched() when processing worker ringbuffers Jason A. Donenfeld <Jason(a)zx2c4.com> wireguard: socket: remove errant restriction on looping to self Dejin Zheng <zhengdejin5(a)gmail.com> net: enetc: fix an issue about leak system resources Toke Høiland-Jørgensen <toke(a)redhat.com> wireguard: receive: use tunnel helpers for decapsulating ECN markings Jason A. Donenfeld <Jason(a)zx2c4.com> wireguard: queueing: cleanup ptr_ring in error path of packet_queue_init Dan Carpenter <dan.carpenter(a)oracle.com> net: mvpp2: cls: Prevent buffer overflow in mvpp2_ethtool_cls_rule_del() Dan Carpenter <dan.carpenter(a)oracle.com> net: mvpp2: prevent buffer overflow in mvpp22_rss_ctx() Roi Dayan <roid(a)mellanox.com> net/mlx5e: Fix q counters on uplink representors Moshe Shemesh <moshe(a)mellanox.com> net/mlx5: Fix command entry leak in Internal Error State Moshe Shemesh <moshe(a)mellanox.com> net/mlx5: Fix forced completion access non initialized command entry Erez Shitrit <erezsh(a)mellanox.com> net/mlx5: DR, On creation set CQ's arm_db member to right value Michael Chan <michael.chan(a)broadcom.com> bnxt_en: Fix VLAN acceleration handling in bnxt_fix_features(). Michael Chan <michael.chan(a)broadcom.com> bnxt_en: Return error when allocating zero size context memory. Michael Chan <michael.chan(a)broadcom.com> bnxt_en: Improve AER slot reset. Vasundhara Volam <vasundhara-v.volam(a)broadcom.com> bnxt_en: Reduce BNXT_MSIX_VEC_MAX value to supported CQs per PF. Michael Chan <michael.chan(a)broadcom.com> bnxt_en: Fix VF anti-spoof filter setup. Toke Høiland-Jørgensen <toke(a)redhat.com> tunnel: Propagate ECT(1) when decapsulating as recommended by RFC6040 Tuong Lien <tuong.t.lien(a)dektech.com.au> tipc: fix partial topology connection closure Eric Dumazet <edumazet(a)google.com> selftests: net: tcp_mmap: fix SO_RCVLOWAT setting Eric Dumazet <edumazet(a)google.com> selftests: net: tcp_mmap: clear whole tcp_zerocopy_receive struct Eric Dumazet <edumazet(a)google.com> sch_sfq: validate silly quantum values Eric Dumazet <edumazet(a)google.com> sch_choke: avoid potential panic in choke_reset() Qiushi Wu <wu000273(a)umn.edu> nfp: abm: fix a memory leak bug Matt Jolly <Kangie(a)footclan.ninja> net: usb: qmi_wwan: add support for DW5816e Xiyu Yang <xiyuyang19(a)fudan.edu.cn> net/tls: Fix sk_psock refcnt leak when in tls_data_ready() Xiyu Yang <xiyuyang19(a)fudan.edu.cn> net/tls: Fix sk_psock refcnt leak in bpf_exec_tx_verdict() Anthony Felice <tony.felice(a)timesys.com> net: tc35815: Fix phydev supported/advertising mask Willem de Bruijn <willemb(a)google.com> net: stricter validation of untrusted gso packets Eric Dumazet <edumazet(a)google.com> net_sched: sch_skbprio: add message validation to skbprio_change() Baruch Siach <baruch(a)tkos.co.il> net: phy: marvell10g: fix temperature sensor on 2110 Tariq Toukan <tariqt(a)mellanox.com> net/mlx4_core: Fix use of ENOSPC around mlx4_counter_alloc() Scott Dial <scott(a)scottdial.com> net: macsec: preserve ingress frame ordering Dejin Zheng <zhengdejin5(a)gmail.com> net: macb: fix an issue about leak related system resources Florian Fainelli <f.fainelli(a)gmail.com> net: dsa: Do not make user port errors fatal Florian Fainelli <f.fainelli(a)gmail.com> net: dsa: Do not leave DSA master with NULL netdev_ops Ido Schimmel <idosch(a)mellanox.com> net: bridge: vlan: Add a schedule point during VLAN processing Roman Mashak <mrv(a)mojatatu.com> neigh: send protocol value in neighbor create notification Jiri Pirko <jiri(a)mellanox.com> mlxsw: spectrum_acl_tcam: Position vchunk in a vregion list properly David Ahern <dsahern(a)kernel.org> ipv6: Use global sernum for dst validation with nexthop objects Eric Dumazet <edumazet(a)google.com> fq_codel: fix TCA_FQ_CODEL_DROP_BATCH_SIZE sanity checks Julia Lawall <Julia.Lawall(a)inria.fr> dp83640: reverse arguments to list_add_tail Jakub Kicinski <kuba(a)kernel.org> devlink: fix return value after hitting end in region read Aya Levin <ayal(a)mellanox.com> devlink: Fix reporter's recovery condition Rahul Lakkireddy <rahul.lakkireddy(a)chelsio.com> cxgb4: fix EOTID leak when disabling TC-MQPRIO offload Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> net: macb: Fix runtime PM refcounting Masami Hiramatsu <mhiramat(a)kernel.org> tracing/kprobes: Fix a double initialization typo Sagi Grimberg <sagi(a)grimberg.me> nvme: fix possible hang when ns scanning fails during error recovery Christoph Hellwig <hch(a)lst.de> nvme: refactor nvme_identify_ns_descs error handling Eric Whitney <enwlinux(a)gmail.com> ext4: disable dioread_nolock whenever delayed allocation is disabled Ritesh Harjani <riteshh(a)linux.ibm.com> ext4: don't set dioread_nolock by default for blocksize < pagesize Shubhrajyoti Datta <shubhrajyoti.datta(a)xilinx.com> tty: xilinx_uartps: Fix missing id assignment to the console Nicolas Pitre <nico(a)fluxnic.net> vt: fix unicode console freeing with a common interface Evan Quan <evan.quan(a)amd.com> drm/amdgpu: drop redundant cg/pg ungate on runpm enter Evan Quan <evan.quan(a)amd.com> drm/amdgpu: move kfd suspend after ip_suspend_phase1 Matt Jolly <Kangie(a)footclan.ninja> USB: serial: qcserial: Add DW5816e support Mika Westerberg <mika.westerberg(a)linux.intel.com> thunderbolt: Check return value of tb_sw_read() in usb4_switch_op() ------------- Diffstat: Makefile | 4 +- arch/arm/crypto/chacha-glue.c | 14 ++- arch/arm/crypto/nhpoly1305-neon-glue.c | 2 +- arch/arm/crypto/poly1305-glue.c | 15 ++- arch/arm64/crypto/chacha-neon-glue.c | 14 ++- arch/arm64/crypto/nhpoly1305-neon-glue.c | 2 +- arch/arm64/crypto/poly1305-glue.c | 15 ++- arch/arm64/kvm/guest.c | 7 ++ arch/arm64/mm/hugetlbpage.c | 2 + arch/riscv/mm/init.c | 3 +- arch/s390/kvm/priv.c | 4 +- arch/x86/crypto/blake2s-glue.c | 10 +- arch/x86/crypto/chacha_glue.c | 14 ++- arch/x86/crypto/nhpoly1305-avx2-glue.c | 2 +- arch/x86/crypto/nhpoly1305-sse2-glue.c | 2 +- arch/x86/crypto/poly1305_glue.c | 13 ++- arch/x86/entry/calling.h | 40 +++---- arch/x86/entry/entry_64.S | 14 +-- arch/x86/include/asm/kvm_host.h | 4 +- arch/x86/include/asm/unwind.h | 2 +- arch/x86/kernel/unwind_orc.c | 61 ++++++++--- arch/x86/kvm/ioapic.c | 10 +- arch/x86/kvm/svm.c | 2 +- arch/x86/kvm/vmx/vmenter.S | 3 + arch/x86/mm/pat/set_memory.c | 12 ++- block/blk-iocost.c | 117 +++++++++++++-------- drivers/amba/bus.c | 1 + drivers/base/platform.c | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +- .../gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 31 ++++-- drivers/gpu/drm/ingenic/ingenic-drm.c | 1 + drivers/hid/usbhid/hid-core.c | 37 +++++-- drivers/hid/usbhid/usbhid.h | 1 + drivers/hid/wacom_sys.c | 4 +- drivers/hid/wacom_wac.c | 88 ++++------------ drivers/iommu/virtio-iommu.c | 2 +- drivers/misc/mei/hw-me.c | 8 ++ drivers/misc/mei/hw-me.h | 4 + drivers/misc/mei/pci-me.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 20 ++-- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 - drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 10 +- drivers/net/ethernet/cadence/macb_main.c | 24 ++--- drivers/net/ethernet/chelsio/cxgb4/sge.c | 39 ++++++- .../net/ethernet/freescale/enetc/enetc_pci_mdio.c | 2 +- drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 3 + drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 + drivers/net/ethernet/mellanox/mlx4/main.c | 4 +- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 6 +- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 9 +- .../ethernet/mellanox/mlx5/core/steering/dr_send.c | 14 ++- .../ethernet/mellanox/mlxsw/spectrum_acl_tcam.c | 12 ++- drivers/net/ethernet/netronome/nfp/abm/main.c | 1 + drivers/net/ethernet/toshiba/tc35815.c | 2 +- drivers/net/macsec.c | 3 +- drivers/net/phy/dp83640.c | 2 +- drivers/net/phy/marvell10g.c | 27 ++++- drivers/net/usb/qmi_wwan.c | 1 + drivers/net/wireguard/queueing.c | 4 +- drivers/net/wireguard/receive.c | 8 +- drivers/net/wireguard/send.c | 4 + drivers/net/wireguard/socket.c | 12 --- drivers/nvme/host/core.c | 28 +++-- drivers/staging/gasket/gasket_core.c | 4 + drivers/thunderbolt/usb4.c | 3 + drivers/tty/serial/xilinx_uartps.c | 1 + drivers/tty/vt/vt.c | 9 +- drivers/usb/chipidea/ci_hdrc_msm.c | 2 +- drivers/usb/serial/garmin_gps.c | 4 +- drivers/usb/serial/qcserial.c | 1 + drivers/usb/storage/unusual_uas.h | 7 ++ fs/ceph/mds_client.c | 8 +- fs/ceph/quota.c | 4 +- fs/coredump.c | 8 ++ fs/eventpoll.c | 61 ++++++----- fs/ext4/ext4_jbd2.h | 3 + fs/ext4/super.c | 13 ++- fs/io_uring.c | 6 -- fs/notify/fanotify/fanotify.c | 9 +- fs/notify/inotify/inotify_fsnotify.c | 4 +- fs/notify/inotify/inotify_user.c | 2 +- include/linux/amba/bus.h | 1 + include/linux/backing-dev-defs.h | 1 + include/linux/backing-dev.h | 9 +- include/linux/fsnotify_backend.h | 7 +- include/linux/platform_device.h | 1 + include/linux/virtio_net.h | 26 ++++- include/net/inet_ecn.h | 57 +++++++++- include/net/ip6_fib.h | 4 + include/net/net_namespace.h | 7 ++ ipc/mqueue.c | 34 ++++-- kernel/trace/preemptirq_delay_test.c | 30 ++++-- kernel/trace/trace.c | 13 +++ kernel/trace/trace_boot.c | 20 ++-- kernel/trace/trace_kprobe.c | 8 +- kernel/umh.c | 5 + mm/backing-dev.c | 13 ++- mm/memcontrol.c | 15 +-- mm/page_alloc.c | 9 ++ net/batman-adv/bat_v_ogm.c | 2 +- net/batman-adv/network-coding.c | 9 +- net/batman-adv/sysfs.c | 3 +- net/bridge/br_netlink.c | 1 + net/core/devlink.c | 12 ++- net/core/neighbour.c | 6 +- net/dsa/dsa2.c | 2 +- net/dsa/master.c | 3 +- net/ipv6/route.c | 25 +++++ net/netfilter/nf_nat_proto.c | 4 +- net/netfilter/nfnetlink_osf.c | 12 ++- net/sched/sch_choke.c | 3 +- net/sched/sch_fq_codel.c | 2 +- net/sched/sch_sfq.c | 9 ++ net/sched/sch_skbprio.c | 3 + net/sctp/sm_statefuns.c | 6 +- net/tipc/topsrv.c | 5 +- net/tls/tls_sw.c | 7 +- scripts/decodecode | 2 +- tools/cgroup/iocost_monitor.py | 7 +- tools/objtool/check.c | 2 +- tools/testing/selftests/net/tcp_mmap.c | 7 +- tools/testing/selftests/wireguard/netns.sh | 54 +++++++++- virt/kvm/arm/hyp/aarch32.c | 8 +- virt/kvm/arm/vgic/vgic-mmio.c | 4 +- 125 files changed, 964 insertions(+), 459 deletions(-)

4 years, 7 months

5
126
0 0

[PATCH v2 for 4.4, 4.9] spi: spi-dw: Add lock protect dw_spi rx/tx to prevent concurrent calls

by Nobuhiro Iwamatsu

From: "wuxu.wu" <wuxu.wu(a)huawei.com> commit 19b61392c5a852b4e8a0bf35aecb969983c5932d upstream. dw_spi_irq() and dw_spi_transfer_one concurrent calls. I find a panic in dw_writer(): txw = *(u8 *)(dws->tx), when dw->tx==null, dw->len==4, and dw->tx_end==1. When tpm driver's message overtime dw_spi_irq() and dw_spi_transfer_one may concurrent visit dw_spi, so I think dw_spi structure lack of protection. Otherwise dw_spi_transfer_one set dw rx/tx buffer and then open irq, store dw rx/tx instructions and other cores handle irq load dw rx/tx instructions may out of order. [ 1025.321302] Call trace: ... [ 1025.321319] __crash_kexec+0x98/0x148 [ 1025.321323] panic+0x17c/0x314 [ 1025.321329] die+0x29c/0x2e8 [ 1025.321334] die_kernel_fault+0x68/0x78 [ 1025.321337] __do_kernel_fault+0x90/0xb0 [ 1025.321346] do_page_fault+0x88/0x500 [ 1025.321347] do_translation_fault+0xa8/0xb8 [ 1025.321349] do_mem_abort+0x68/0x118 [ 1025.321351] el1_da+0x20/0x8c [ 1025.321362] dw_writer+0xc8/0xd0 [ 1025.321364] interrupt_transfer+0x60/0x110 [ 1025.321365] dw_spi_irq+0x48/0x70 ... Signed-off-by: wuxu.wu <wuxu.wu(a)huawei.com> Link: https://lore.kernel.org/r/1577849981-31489-1-git-send-email-wuxu.wu@huawei.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Nobuhiro Iwamatsu (CIP) <nobuhiro1.iwamatsu(a)toshiba.co.jp> --- drivers/spi/spi-dw.c | 15 ++++++++++++--- drivers/spi/spi-dw.h | 1 + 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c index 87a0e47eeae64..4edd38d03b939 100644 --- a/drivers/spi/spi-dw.c +++ b/drivers/spi/spi-dw.c @@ -180,9 +180,11 @@ static inline u32 rx_max(struct dw_spi *dws) static void dw_writer(struct dw_spi *dws) { - u32 max = tx_max(dws); + u32 max; u16 txw = 0; + spin_lock(&dws->buf_lock); + max = tx_max(dws); while (max--) { /* Set the tx word if the transfer's original "tx" is not null */ if (dws->tx_end - dws->len) { @@ -194,13 +196,16 @@ static void dw_writer(struct dw_spi *dws) dw_write_io_reg(dws, DW_SPI_DR, txw); dws->tx += dws->n_bytes; } + spin_unlock(&dws->buf_lock); } static void dw_reader(struct dw_spi *dws) { - u32 max = rx_max(dws); + u32 max; u16 rxw; + spin_lock(&dws->buf_lock); + max = rx_max(dws); while (max--) { rxw = dw_read_io_reg(dws, DW_SPI_DR); /* Care rx only if the transfer's original "rx" is not null */ @@ -212,6 +217,7 @@ static void dw_reader(struct dw_spi *dws) } dws->rx += dws->n_bytes; } + spin_unlock(&dws->buf_lock); } static void int_error_stop(struct dw_spi *dws, const char *msg) @@ -284,6 +290,7 @@ static int dw_spi_transfer_one(struct spi_master *master, { struct dw_spi *dws = spi_master_get_devdata(master); struct chip_data *chip = spi_get_ctldata(spi); + unsigned long flags; u8 imask = 0; u16 txlevel = 0; u16 clk_div; @@ -291,12 +298,13 @@ static int dw_spi_transfer_one(struct spi_master *master, int ret; dws->dma_mapped = 0; - + spin_lock_irqsave(&dws->buf_lock, flags); dws->tx = (void *)transfer->tx_buf; dws->tx_end = dws->tx + transfer->len; dws->rx = transfer->rx_buf; dws->rx_end = dws->rx + transfer->len; dws->len = transfer->len; + spin_unlock_irqrestore(&dws->buf_lock, flags); spi_enable_chip(dws, 0); @@ -488,6 +496,7 @@ int dw_spi_add_host(struct device *dev, struct dw_spi *dws) dws->dma_inited = 0; dws->dma_addr = (dma_addr_t)(dws->paddr + DW_SPI_DR); snprintf(dws->name, sizeof(dws->name), "dw_spi%d", dws->bus_num); + spin_lock_init(&dws->buf_lock); ret = request_irq(dws->irq, dw_spi_irq, IRQF_SHARED, dws->name, master); if (ret < 0) { diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h index 35589a270468d..d05b216ea3f87 100644 --- a/drivers/spi/spi-dw.h +++ b/drivers/spi/spi-dw.h @@ -117,6 +117,7 @@ struct dw_spi { size_t len; void *tx; void *tx_end; + spinlock_t buf_lock; void *rx; void *rx_end; int dma_mapped; -- 2.26.0

4 years, 7 months

2
1
0 0

[PATCH v4.4..v5.4] scsi: sg: add sg_remove_request in sg_write

by Guenter Roeck

From: Wu Bo <wubo40(a)huawei.com> [ Upstream commit 83c6f2390040f188cc25b270b4befeb5628c1aee ] If the __copy_from_user function failed we need to call sg_remove_request in sg_write. Link: https://lore.kernel.org/r/610618d9-e983-fd56-ed0f-639428343af7@huawei.com Acked-by: Douglas Gilbert <dgilbert(a)interlog.com> Signed-off-by: Wu Bo <wubo40(a)huawei.com> Signed-off-by: Martin K. Petersen <martin.petersen(a)oracle.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> [groeck: Backport to v5.4.y and older kernels] Signed-off-by: Guenter Roeck <linux(a)roeck-us.net> --- This patch fixes CVE-2020-12770, and the problem it fixes looks like a valid bug. Please apply to v5.4.y and older kernel branches. drivers/scsi/sg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 94af30f768f7..9c6bf13daaee 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -689,8 +689,10 @@ sg_write(struct file *filp, const char __user *buf, size_t count, loff_t * ppos) hp->flags = input_size; /* structure abuse ... */ hp->pack_id = old_hdr.pack_id; hp->usr_ptr = NULL; - if (__copy_from_user(cmnd, buf, cmd_size)) + if (__copy_from_user(cmnd, buf, cmd_size)) { + sg_remove_request(sfp, srp); return -EFAULT; + } /* * SG_DXFER_TO_FROM_DEV is functionally equivalent to SG_DXFER_FROM_DEV, * but is is possible that the app intended SG_DXFER_TO_DEV, because there -- 2.17.1

4 years, 7 months

2
1
0 0

Re: stable/linux-4.4.y bisection: baseline.login on at91-sama5d4_xplained

by Guillaume Tucker

Please see the bisection report below about a boot failure. Reports aren't automatically sent to the public while we're trialing new bisection features on kernelci.org but this one looks valid. It appears to be due to the fact that the network interface is failing to get brought up: [ 114.385000] Waiting up to 10 more seconds for network. [ 124.355000] Sending DHCP requests ...# ..# .# timed out! [ 212.355000] IP-Config: Reopening network devices... [ 212.365000] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready # I guess the board would boot fine without network if it didn't have ip=dhcp in the command line, so it's not strictly a kernel boot failure but still an ethernet issue. There wasn't any failure reported by kernelci on linux-4.9.y so maybe this patch was applied by mistake on linux-4.4.y but I haven't investigated enough to prove this. Thanks, Guillaume On 10/05/2020 18:27, kernelci.org bot wrote: > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > * This automated bisection report was sent to you on the basis * > * that you may be involved with the breaking commit it has * > * found. No manual investigation has been done to verify it, * > * and the root cause of the problem may be somewhere else. * > * * > * If you do send a fix, please include this trailer: * > * Reported-by: "kernelci.org bot" <bot(a)kernelci.org> * > * * > * Hope this helps! * > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > > stable/linux-4.4.y bisection: baseline.login on at91-sama5d4_xplained > > Summary: > Start: e157447efd85b Linux 4.4.223 > Plain log: https://storage.kernelci.org/stable/linux-4.4.y/v4.4.223/arm/multi_v7_defco… > HTML log: https://storage.kernelci.org/stable/linux-4.4.y/v4.4.223/arm/multi_v7_defco… > Result: 0d1951fa23ba0 net: phy: Avoid polling PHY with PHY_IGNORE_INTERRUPTS > > Checks: > revert: PASS > verify: PASS > > Parameters: > Tree: stable > URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git > Branch: linux-4.4.y > Target: at91-sama5d4_xplained > CPU arch: arm > Lab: lab-baylibre > Compiler: gcc-8 > Config: multi_v7_defconfig > Test case: baseline.login > > Breaking commit found: > > ------------------------------------------------------------------------------- > commit 0d1951fa23ba0d35a4c5498ff28d1c5206d6fcdd > Author: Florian Fainelli <f.fainelli(a)gmail.com> > Date: Mon Jan 18 19:33:06 2016 -0800 > > net: phy: Avoid polling PHY with PHY_IGNORE_INTERRUPTS > > commit d5c3d84657db57bd23ecd58b97f1c99dd42a7b80 upstream. > > Commit 2c7b49212a86 ("phy: fix the use of PHY_IGNORE_INTERRUPT") changed > a hunk in phy_state_machine() in the PHY_RUNNING case which was not > needed. The change essentially makes the PHY library treat PHY devices > with PHY_IGNORE_INTERRUPT to keep polling for the PHY device, even > though the intent is not to do it. > > Fix this by reverting that specific hunk, which makes the PHY state > machine wait for state changes, and stay in the PHY_RUNNING state for as > long as needed. > > Fixes: 2c7b49212a86 ("phy: fix the use of PHY_IGNORE_INTERRUPT") > Signed-off-by: Florian Fainelli <f.fainelli(a)gmail.com> > Signed-off-by: David S. Miller <davem(a)davemloft.net> > Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> > > diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c > index 7d2cf015c5e76..b242bec834f4b 100644 > --- a/drivers/net/phy/phy.c > +++ b/drivers/net/phy/phy.c > @@ -912,10 +912,10 @@ void phy_state_machine(struct work_struct *work) > phydev->adjust_link(phydev->attached_dev); > break; > case PHY_RUNNING: > - /* Only register a CHANGE if we are polling or ignoring > - * interrupts and link changed since latest checking. > + /* Only register a CHANGE if we are polling and link changed > + * since latest checking. > */ > - if (!phy_interrupt_is_valid(phydev)) { > + if (phydev->irq == PHY_POLL) { > old_link = phydev->link; > err = phy_read_status(phydev); > if (err) > @@ -1015,8 +1015,13 @@ void phy_state_machine(struct work_struct *work) > dev_dbg(&phydev->dev, "PHY state change %s -> %s\n", > phy_state_to_str(old_state), phy_state_to_str(phydev->state)); > > - queue_delayed_work(system_power_efficient_wq, &phydev->state_queue, > - PHY_STATE_TIME * HZ); > + /* Only re-schedule a PHY state machine change if we are polling the > + * PHY, if PHY_IGNORE_INTERRUPT is set, then we will be moving > + * between states from phy_mac_interrupt() > + */ > + if (phydev->irq == PHY_POLL) > + queue_delayed_work(system_power_efficient_wq, &phydev->state_queue, > + PHY_STATE_TIME * HZ); > } > > void phy_mac_interrupt(struct phy_device *phydev, int new_link) > ------------------------------------------------------------------------------- > > > Git bisection log: > > ------------------------------------------------------------------------------- > git bisect start > # good: [b63f449e18b130fdc372b9717e72c19b83fc4876] Linux 4.4.222 > git bisect good b63f449e18b130fdc372b9717e72c19b83fc4876 > # bad: [e157447efd85bb2e6f8deaabbb62663bccd9bad2] Linux 4.4.223 > git bisect bad e157447efd85bb2e6f8deaabbb62663bccd9bad2 > # bad: [5733a9f4a3df384097c92c532aed34bc698a9acd] net: dsa: slave: fix of-node leak and phy priority > git bisect bad 5733a9f4a3df384097c92c532aed34bc698a9acd > # good: [1ce6993b857318a4b8c674b1bbaaf79aced34136] net/mlx5e: Fix blue flame quota logic > git bisect good 1ce6993b857318a4b8c674b1bbaaf79aced34136 > # good: [c32532162f8ea4beed50a20cf4f9b205c75fe1b1] serial: samsung: Fix possible out of bounds access on non-DT platform > git bisect good c32532162f8ea4beed50a20cf4f9b205c75fe1b1 > # good: [25e8aad6f491da6ae330148da09585371a3790f2] Revert "ACPI / LPSS: allow to use specific PM domain during ->probe()" > git bisect good 25e8aad6f491da6ae330148da09585371a3790f2 > # good: [2f3e56e4b6020812350190f1cada230d790ce0e8] powerpc/tm: Fix stack pointer corruption in __tm_recheckpoint() > git bisect good 2f3e56e4b6020812350190f1cada230d790ce0e8 > # bad: [0d1951fa23ba0d35a4c5498ff28d1c5206d6fcdd] net: phy: Avoid polling PHY with PHY_IGNORE_INTERRUPTS > git bisect bad 0d1951fa23ba0d35a4c5498ff28d1c5206d6fcdd > # good: [4ebef63e925e37f5de2f9da8fc86a545e4e0b945] sctp: fix the transports round robin issue when init is retransmitted > git bisect good 4ebef63e925e37f5de2f9da8fc86a545e4e0b945 > # good: [c175435fdf50c81ca2b6576f090cba31c3489209] NFC: nci: memory leak in nci_core_conn_create() > git bisect good c175435fdf50c81ca2b6576f090cba31c3489209 > # first bad commit: [0d1951fa23ba0d35a4c5498ff28d1c5206d6fcdd] net: phy: Avoid polling PHY with PHY_IGNORE_INTERRUPTS > ------------------------------------------------------------------------------- >

4 years, 7 months

6
6
0 0

[PATCH 5.4] selftests/bpf: fix goto cleanup label not defined

by Hangbin Liu

kernel test robot found a warning when build bpf selftest for 5.4.y stable tree: prog_tests/stacktrace_build_id_nmi.c:55:3: error: label ‘cleanup’ used but not defined goto cleanup; ^~~~ This is because we are lacking upstream commit dde53c1b763b ("selftests/bpf: Convert few more selftest to skeletons"). But this commit is too large and need more backports. To fix it, the easiest way is just use the current goto label 'close_prog'. Reported-by: kernel test robot <rong.a.chen(a)intel.com> Fixes: da43712a7262 ("selftests/bpf: Skip perf hw events test if the setup disabled it") Signed-off-by: Hangbin Liu <liuhangbin(a)gmail.com> --- .../testing/selftests/bpf/prog_tests/stacktrace_build_id_nmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/prog_tests/stacktrace_build_id_nmi.c b/tools/testing/selftests/bpf/prog_tests/stacktrace_build_id_nmi.c index 1735faf17536..437cb93e72ac 100644 --- a/tools/testing/selftests/bpf/prog_tests/stacktrace_build_id_nmi.c +++ b/tools/testing/selftests/bpf/prog_tests/stacktrace_build_id_nmi.c @@ -52,7 +52,7 @@ void test_stacktrace_build_id_nmi(void) if (pmu_fd < 0 && errno == ENOENT) { printf("%s:SKIP:no PERF_COUNT_HW_CPU_CYCLES\n", __func__); test__skip(); - goto cleanup; + goto close_prog; } if (CHECK(pmu_fd < 0, "perf_event_open", "err %d errno %d\n", pmu_fd, errno)) -- 2.25.4

4 years, 8 months

1
0
0 0

[PATCH] usb: core: hub: limit HUB_QUIRK_DISABLE_AUTOSUSPEND to USB5534B

by Eugeniu Rosca

On Tue, May 12, 2020 at 09:36:07PM +0800, Kai-Heng Feng wrote [1]: > This patch prevents my Raven Ridge xHCI from getting runtime suspend. The problem described in v5.6 commit 1208f9e1d758c9 ("USB: hub: Fix the broken detection of USB3 device in SMSC hub") applies solely to the USB5534B hub [2] present on the Kingfisher Infotainment Carrier Board, manufactured by Shimafuji Electric Inc [3]. Despite that, the aforementioned commit applied the quirk to _all_ hubs carrying vendor ID 0x424 (i.e. SMSC), of which there are more [4] than initially expected. Consequently, the quirk is now enabled on platforms carrying SMSC/Microchip hub models which potentially don't exhibit the original issue. To avoid reports like [1], further limit the quirk's scope to USB5534B [2], by employing both Vendor and Product ID checks. Tested on H3ULCB + Kingfisher rev. M05. [1] https://lore.kernel.org/linux-renesas-soc/73933975-6F0E-40F5-9584-D2B8F615C… [2] https://www.microchip.com/wwwproducts/en/USB5534B [3] http://www.shimafuji.co.jp/wp/wp-content/uploads/2018/08/SBEV-RCAR-KF-M06Bo… [4] https://devicehunt.com/search/type/usb/vendor/0424/device/any Fixes: 1208f9e1d758c9 ("USB: hub: Fix the broken detection of USB3 device in SMSC hub") Cc: stable(a)vger.kernel.org # v4.14+ Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: Alan Stern <stern(a)rowland.harvard.edu> Cc: Hardik Gajjar <hgajjar(a)de.adit-jv.com> Cc: linux-renesas-soc(a)vger.kernel.org Cc: linux-usb(a)vger.kernel.org Reported-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> Signed-off-by: Eugeniu Rosca <erosca(a)de.adit-jv.com> --- drivers/usb/core/hub.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 2b6565c06c23..fc748c731832 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -39,6 +39,7 @@ #define USB_VENDOR_GENESYS_LOGIC 0x05e3 #define USB_VENDOR_SMSC 0x0424 +#define USB_PRODUCT_USB5534B 0x5534 #define HUB_QUIRK_CHECK_PORT_AUTOSUSPEND 0x01 #define HUB_QUIRK_DISABLE_AUTOSUSPEND 0x02 @@ -5621,8 +5622,11 @@ static void hub_event(struct work_struct *work) } static const struct usb_device_id hub_id_table[] = { - { .match_flags = USB_DEVICE_ID_MATCH_VENDOR | USB_DEVICE_ID_MATCH_INT_CLASS, + { .match_flags = USB_DEVICE_ID_MATCH_VENDOR + | USB_DEVICE_ID_MATCH_PRODUCT + | USB_DEVICE_ID_MATCH_INT_CLASS, .idVendor = USB_VENDOR_SMSC, + .idProduct = USB_PRODUCT_USB5534B, .bInterfaceClass = USB_CLASS_HUB, .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND}, { .match_flags = USB_DEVICE_ID_MATCH_VENDOR -- 2.26.2

4 years, 8 months

2
1
0 0

[PATCH v2] scsi: target: put lun_ref at end of tmr processing

by Bodo Stroesser

Testing with Loopback I found, that after a Loopback LUN has executed a TMR, I can no longer unlink the LUN. The rm command hangs in transport_clear_lun_ref() at wait_for_completion(&lun->lun_shutdown_comp) The reason is, that transport_lun_remove_cmd() is not called at the end of target_tmr_work(). It seems, that in other fabrics this call happens implicitly when the fabric drivers call transport_generic_free_cmd() during their ->queue_tm_rsp(). Unfortunately Loopback seems to not comply to the common way of calling transport_generic_free_cmd() from ->queue_*(). Instead it calls transport_generic_free_cmd() from its ->check_stop_free() only. But the ->check_stop_free() is called by transport_cmd_check_stop_to_fabric() after it has reset the se_cmd->se_lun pointer. Therefore the following transport_generic_free_cmd() skips the transport_lun_remove_cmd(). So this patch re-adds the transport_lun_remove_cmd() at the end of target_tmr_work(), which was removed during commit 2c9fa49e100f962af988f1c0529231bf14905cda "scsi: target/core: Make ABORT and LUN RESET handling synchronous" For fabrics using transport_generic_free_cmd() in the usual way the double call to transport_lun_remove_cmd() doesn't harm, as transport_lun_remove_cmd() checks for this situation and does not release lun_ref twice. Fixes: 2c9fa49e100f ("scsi: target/core: Make ABORT and LUN RESET handling synchronous") Cc: stable(a)vger.kernel.org Signed-off-by: Bodo Stroesser <bstroesser(a)ts.fujitsu.com> Tested-by: Bryant G. Ly <bryangly(a)gmail.com> Reviewed-by: Bart van Assche <bvanassche(a)acm.org> --- v2: - Resend of the same patch with added tags "Fixes:", "Cc: stable@.." and "Reviewed-by:" drivers/target/target_core_transport.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index 594b724bbf79..264a822c0bfa 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -3350,6 +3350,7 @@ static void target_tmr_work(struct work_struct *work) cmd->se_tfo->queue_tm_rsp(cmd); + transport_lun_remove_cmd(cmd); transport_cmd_check_stop_to_fabric(cmd); return; -- 2.12.3

4 years, 8 months

2
1
0 0

[PATCH for 4.4, 4.9] spi: spi-dw: Add lock protect dw_spi rx/tx to prevent concurrent calls

by Nobuhiro Iwamatsu

From: "wuxu.wu" <wuxu.wu(a)huawei.com> commit 19b61392c5a852b4e8a0bf35aecb969983c5932d upstream. dw_spi_irq() and dw_spi_transfer_one concurrent calls. I find a panic in dw_writer(): txw = *(u8 *)(dws->tx), when dw->tx==null, dw->len==4, and dw->tx_end==1. When tpm driver's message overtime dw_spi_irq() and dw_spi_transfer_one may concurrent visit dw_spi, so I think dw_spi structure lack of protection. Otherwise dw_spi_transfer_one set dw rx/tx buffer and then open irq, store dw rx/tx instructions and other cores handle irq load dw rx/tx instructions may out of order. [ 1025.321302] Call trace: ... [ 1025.321319] __crash_kexec+0x98/0x148 [ 1025.321323] panic+0x17c/0x314 [ 1025.321329] die+0x29c/0x2e8 [ 1025.321334] die_kernel_fault+0x68/0x78 [ 1025.321337] __do_kernel_fault+0x90/0xb0 [ 1025.321346] do_page_fault+0x88/0x500 [ 1025.321347] do_translation_fault+0xa8/0xb8 [ 1025.321349] do_mem_abort+0x68/0x118 [ 1025.321351] el1_da+0x20/0x8c [ 1025.321362] dw_writer+0xc8/0xd0 [ 1025.321364] interrupt_transfer+0x60/0x110 [ 1025.321365] dw_spi_irq+0x48/0x70 ... Signed-off-by: wuxu.wu <wuxu.wu(a)huawei.com> Link: https://lore.kernel.org/r/1577849981-31489-1-git-send-email-wuxu.wu@huawei.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Nobuhiro Iwamatsu (CIP) <npbuhiro1.iwamatsu(a)toshiba.co.jp> --- drivers/spi/spi-dw.c | 15 ++++++++++++--- drivers/spi/spi-dw.h | 1 + 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c index 87a0e47eeae64..4edd38d03b939 100644 --- a/drivers/spi/spi-dw.c +++ b/drivers/spi/spi-dw.c @@ -180,9 +180,11 @@ static inline u32 rx_max(struct dw_spi *dws) static void dw_writer(struct dw_spi *dws) { - u32 max = tx_max(dws); + u32 max; u16 txw = 0; + spin_lock(&dws->buf_lock); + max = tx_max(dws); while (max--) { /* Set the tx word if the transfer's original "tx" is not null */ if (dws->tx_end - dws->len) { @@ -194,13 +196,16 @@ static void dw_writer(struct dw_spi *dws) dw_write_io_reg(dws, DW_SPI_DR, txw); dws->tx += dws->n_bytes; } + spin_unlock(&dws->buf_lock); } static void dw_reader(struct dw_spi *dws) { - u32 max = rx_max(dws); + u32 max; u16 rxw; + spin_lock(&dws->buf_lock); + max = rx_max(dws); while (max--) { rxw = dw_read_io_reg(dws, DW_SPI_DR); /* Care rx only if the transfer's original "rx" is not null */ @@ -212,6 +217,7 @@ static void dw_reader(struct dw_spi *dws) } dws->rx += dws->n_bytes; } + spin_unlock(&dws->buf_lock); } static void int_error_stop(struct dw_spi *dws, const char *msg) @@ -284,6 +290,7 @@ static int dw_spi_transfer_one(struct spi_master *master, { struct dw_spi *dws = spi_master_get_devdata(master); struct chip_data *chip = spi_get_ctldata(spi); + unsigned long flags; u8 imask = 0; u16 txlevel = 0; u16 clk_div; @@ -291,12 +298,13 @@ static int dw_spi_transfer_one(struct spi_master *master, int ret; dws->dma_mapped = 0; - + spin_lock_irqsave(&dws->buf_lock, flags); dws->tx = (void *)transfer->tx_buf; dws->tx_end = dws->tx + transfer->len; dws->rx = transfer->rx_buf; dws->rx_end = dws->rx + transfer->len; dws->len = transfer->len; + spin_unlock_irqrestore(&dws->buf_lock, flags); spi_enable_chip(dws, 0); @@ -488,6 +496,7 @@ int dw_spi_add_host(struct device *dev, struct dw_spi *dws) dws->dma_inited = 0; dws->dma_addr = (dma_addr_t)(dws->paddr + DW_SPI_DR); snprintf(dws->name, sizeof(dws->name), "dw_spi%d", dws->bus_num); + spin_lock_init(&dws->buf_lock); ret = request_irq(dws->irq, dw_spi_irq, IRQF_SHARED, dws->name, master); if (ret < 0) { diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h index 35589a270468d..d05b216ea3f87 100644 --- a/drivers/spi/spi-dw.h +++ b/drivers/spi/spi-dw.h @@ -117,6 +117,7 @@ struct dw_spi { size_t len; void *tx; void *tx_end; + spinlock_t buf_lock; void *rx; void *rx_end; int dma_mapped; -- 2.26.0

4 years, 8 months

2
1
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror May 2020