May 2020 - Linux-stable-mirror

by Greg Kroah-Hartman

I'm announcing the release of the 4.9.225 kernel. All users of the 4.9 kernel series must upgrade. The updated 4.9.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.9.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Documentation/networking/l2tp.txt | 8 Makefile | 2 arch/arm/include/asm/futex.h | 9 arch/arm64/kernel/machine_kexec.c | 3 drivers/base/component.c | 8 drivers/dma/tegra210-adma.c | 2 drivers/hid/hid-ids.h | 1 drivers/hid/hid-multitouch.c | 3 drivers/i2c/i2c-dev.c | 48 +-- drivers/i2c/muxes/i2c-demux-pinctrl.c | 1 drivers/iio/dac/vf610_dac.c | 1 drivers/iommu/amd_iommu_init.c | 9 drivers/misc/mei/client.c | 2 drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 13 drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 6 drivers/net/ethernet/intel/igb/igb_main.c | 4 drivers/net/gtp.c | 9 drivers/nvdimm/btt.c | 8 drivers/platform/x86/alienware-wmi.c | 17 - drivers/platform/x86/asus-nb-wmi.c | 24 + drivers/rapidio/devices/rio_mport_cdev.c | 5 drivers/staging/greybus/uart.c | 4 drivers/staging/iio/accel/sca3000_ring.c | 2 drivers/staging/iio/resolver/ad2s1210.c | 17 - drivers/usb/core/message.c | 4 drivers/watchdog/watchdog_dev.c | 67 +--- fs/ceph/caps.c | 1 fs/configfs/dir.c | 1 fs/file.c | 2 fs/gfs2/glock.c | 3 include/linux/net.h | 3 include/linux/padata.h | 13 include/uapi/linux/if_pppol2tp.h | 13 include/uapi/linux/l2tp.h | 17 + kernel/padata.c | 88 ++--- lib/Makefile | 2 net/l2tp/l2tp_core.c | 174 +++-------- net/l2tp/l2tp_core.h | 46 +- net/l2tp/l2tp_eth.c | 216 ++++++++----- net/l2tp/l2tp_netlink.c | 79 ++--- net/l2tp/l2tp_ppp.c | 309 +++++++++++--------- net/socket.c | 46 ++ scripts/gcc-plugins/Makefile | 1 scripts/gcc-plugins/gcc-common.h | 4 security/integrity/evm/evm_crypto.c | 2 security/integrity/ima/ima_fs.c | 3 sound/core/pcm_lib.c | 1 47 files changed, 733 insertions(+), 568 deletions(-) Al Viro (1): fix multiplication overflow in copy_fdtable() Alan Stern (1): USB: core: Fix misleading driver bug report Alexander Monakov (1): iommu/amd: Fix over-read of ACPI UID from IVRS table Alexander Usyskin (1): mei: release me_cl object reference Arjun Vynipadath (2): cxgb4: free mac_hlist properly cxgb4/cxgb4vf: Fix mac_hlist initialization and free Arnd Bergmann (1): ubsan: build ubsan.c more conservatively Asbjørn Sloth Tønnesen (3): net: l2tp: export debug flags to UAPI net: l2tp: deprecate PPPOL2TP_MSG_* in favour of L2TP_MSG_* net: l2tp: ppp: change PPPOL2TP_MSG_* => L2TP_MSG_* Bob Peterson (1): Revert "gfs2: Don't demote a glock until its revokes are written" Brent Lu (1): ALSA: pcm: fix incorrect hw_base increase Cao jin (1): igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr Christoph Hellwig (1): arm64: fix the flush_icache_range arguments in machine_kexec Christophe JAILLET (4): i2c: mux: demux-pinctrl: Fix an error handling path in 'i2c_demux_pinctrl_probe()' dmaengine: tegra210-adma: Fix an error handling path in 'tegra_adma_probe()' iio: dac: vf610: Fix an error handling path in 'vf610_dac_probe()' iio: sca3000: Remove an erroneous 'get_device()' Colin Ian King (1): platform/x86: alienware-wmi: fix kfree on potentially uninitialized pointer Daniel Jordan (2): padata: initialize pd->cpu with effective cpumask padata: purge get_cpu and reorder_via_wq from padata_do_serial Dragos Bogdan (1): staging: iio: ad2s1210: Fix SPI reading Frédéric Pierret (fepitre) (1): gcc-common.h: Update for GCC 10 Greg Kroah-Hartman (1): Linux 4.9.225 Guillaume Nault (17): l2tp: remove useless duplicate session detection in l2tp_netlink l2tp: remove l2tp_session_find() l2tp: define parameters of l2tp_session_get*() as "const" l2tp: define parameters of l2tp_tunnel_find*() as "const" l2tp: initialise session's refcount before making it reachable l2tp: hold tunnel while looking up sessions in l2tp_netlink l2tp: hold tunnel while processing genl delete command l2tp: hold tunnel while handling genl tunnel updates l2tp: hold tunnel while handling genl TUNNEL_GET commands l2tp: hold tunnel used while creating sessions with netlink l2tp: prevent creation of sessions on terminated tunnels l2tp: pass tunnel pointer to ->session_create() l2tp: fix l2tp_eth module loading l2tp: don't register sessions in l2tp_session_create() l2tp: initialise l2tp_eth sessions before registering them l2tp: protect sock pointer of struct pppol2tp_session with RCU l2tp: initialise PPP sessions before registering them Hans de Goede (1): platform/x86: asus-nb-wmi: Do not load on Asus T100TA and T200TA Herbert Xu (1): padata: Replace delayed timer with immediate workqueue in padata_reorder James Hilliard (1): component: Silence bind error on -EPROBE_DEFER Jason A. Donenfeld (1): padata: get_next is never NULL John Hubbard (1): rapidio: fix an error in get_user_pages_fast() error handling Kevin Hao (2): i2c: dev: Fix the race between the release of i2c_dev and cdev watchdog: Fix the race between the release of watchdog_core_data and cdev Mathias Krause (3): padata: ensure the reorder timer callback runs on the correct CPU padata: ensure padata_do_serial() runs on the correct CPU padata: set cpu_index of unused CPUs to -1 Oscar Carter (1): staging: greybus: Fix uninitialized scalar variable Peter Zijlstra (1): x86/uaccess, ubsan: Fix UBSAN vs. SMAP R. Parameswaran (3): New kernel function to get IP overhead on a socket. L2TP:Adjust intf MTU, add underlay L3, L2 hdrs. l2tp: device MTU setup, tunnel socket needs a lock Roberto Sassu (2): evm: Check also if *tfm is an error pointer in init_desc() ima: Fix return value of ima_write_policy() Sebastian Reichel (1): HID: multitouch: add eGalaxTouch P80H84 support Thomas Gleixner (1): ARM: futex: Address build warning Tobias Klauser (1): padata: Remove unused but set variables Vishal Verma (1): libnvdimm/btt: Remove unnecessary code in btt_freelist_init Wu Bo (1): ceph: fix double unlock in handle_cap_export() Xiyu Yang (1): configfs: fix config_item refcnt leak in configfs_rmdir() Yoshiyuki Kurauchi (1): gtp: set NLM_F_MULTI flag in gtp_genl_dump_pdp()

4 years, 7 months

1
0
0 0

Linux 4.4.225

by Greg Kroah-Hartman

I'm announcing the release of the 4.4.225 kernel. All users of the 4.4 kernel series must upgrade. The updated 4.4.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.4.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Documentation/networking/l2tp.txt | 8 Makefile | 2 arch/arm/include/asm/futex.h | 9 drivers/hid/hid-ids.h | 1 drivers/hid/hid-multitouch.c | 3 drivers/i2c/i2c-dev.c | 60 +++-- drivers/media/media-device.c | 43 +++- drivers/media/media-devnode.c | 168 +++++++++------- drivers/media/usb/uvc/uvc_driver.c | 2 drivers/misc/mei/client.c | 2 drivers/net/ethernet/intel/igb/igb_main.c | 4 drivers/nvdimm/btt.c | 8 drivers/platform/x86/alienware-wmi.c | 17 - drivers/platform/x86/asus-nb-wmi.c | 24 ++ drivers/staging/iio/accel/sca3000_ring.c | 2 drivers/staging/iio/resolver/ad2s1210.c | 17 + drivers/usb/core/message.c | 4 fs/ceph/caps.c | 1 fs/ext4/xattr.c | 66 +++--- fs/file.c | 2 fs/gfs2/glock.c | 3 include/linux/cpumask.h | 19 + include/linux/net.h | 3 include/linux/padata.h | 13 - include/media/media-device.h | 5 include/media/media-devnode.h | 32 ++- include/net/ipv6.h | 2 include/uapi/linux/if_pppol2tp.h | 13 - include/uapi/linux/l2tp.h | 17 + kernel/padata.c | 88 +++----- lib/cpumask.c | 32 +++ net/ipv6/datagram.c | 4 net/l2tp/l2tp_core.c | 181 +++++------------ net/l2tp/l2tp_core.h | 47 ++-- net/l2tp/l2tp_eth.c | 216 ++++++++++++-------- net/l2tp/l2tp_ip.c | 68 +++--- net/l2tp/l2tp_ip6.c | 82 +++---- net/l2tp/l2tp_netlink.c | 124 +++++++----- net/l2tp/l2tp_ppp.c | 309 +++++++++++++++++------------- net/socket.c | 46 ++++ security/integrity/evm/evm_crypto.c | 2 sound/core/pcm_lib.c | 1 42 files changed, 1015 insertions(+), 735 deletions(-) Al Viro (1): fix multiplication overflow in copy_fdtable() Alan Stern (1): USB: core: Fix misleading driver bug report Alexander Usyskin (1): mei: release me_cl object reference Asbjørn Sloth Tønnesen (3): net: l2tp: export debug flags to UAPI net: l2tp: deprecate PPPOL2TP_MSG_* in favour of L2TP_MSG_* net: l2tp: ppp: change PPPOL2TP_MSG_* => L2TP_MSG_* Bob Peterson (1): Revert "gfs2: Don't demote a glock until its revokes are written" Brent Lu (1): ALSA: pcm: fix incorrect hw_base increase Cao jin (1): igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr Christophe JAILLET (1): iio: sca3000: Remove an erroneous 'get_device()' Colin Ian King (1): platform/x86: alienware-wmi: fix kfree on potentially uninitialized pointer Dan Carpenter (1): i2c: dev: use after free in detach Daniel Jordan (2): padata: initialize pd->cpu with effective cpumask padata: purge get_cpu and reorder_via_wq from padata_do_serial Dragos Bogdan (1): staging: iio: ad2s1210: Fix SPI reading Erico Nunes (1): i2c: dev: switch from register_chrdev to cdev API Greg Kroah-Hartman (1): Linux 4.4.225 Guillaume Nault (22): l2tp: lock socket before checking flags in connect() l2tp: fix racy socket lookup in l2tp_ip and l2tp_ip6 bind() l2tp: hold session while sending creation notifications l2tp: take a reference on sessions used in genetlink handlers l2tp: don't use l2tp_tunnel_find() in l2tp_ip and l2tp_ip6 l2tp: remove useless duplicate session detection in l2tp_netlink l2tp: remove l2tp_session_find() l2tp: define parameters of l2tp_session_get*() as "const" l2tp: define parameters of l2tp_tunnel_find*() as "const" l2tp: initialise session's refcount before making it reachable l2tp: hold tunnel while looking up sessions in l2tp_netlink l2tp: hold tunnel while processing genl delete command l2tp: hold tunnel while handling genl tunnel updates l2tp: hold tunnel while handling genl TUNNEL_GET commands l2tp: hold tunnel used while creating sessions with netlink l2tp: prevent creation of sessions on terminated tunnels l2tp: pass tunnel pointer to ->session_create() l2tp: fix l2tp_eth module loading l2tp: don't register sessions in l2tp_session_create() l2tp: initialise l2tp_eth sessions before registering them l2tp: protect sock pointer of struct pppol2tp_session with RCU l2tp: initialise PPP sessions before registering them Hans de Goede (1): platform/x86: asus-nb-wmi: Do not load on Asus T100TA and T200TA Herbert Xu (1): padata: Replace delayed timer with immediate workqueue in padata_reorder Jason A. Donenfeld (1): padata: get_next is never NULL Kevin Hao (1): i2c: dev: Fix the race between the release of i2c_dev and cdev Mathias Krause (3): padata: ensure the reorder timer callback runs on the correct CPU padata: ensure padata_do_serial() runs on the correct CPU padata: set cpu_index of unused CPUs to -1 Mauro Carvalho Chehab (2): media-devnode: fix namespace mess media-device: dynamically allocate struct media_devnode Max Kellermann (2): drivers/media/media-devnode: clear private_data before put_device() media-devnode: add missing mutex lock in error handler Michael Kelley (1): cpumask: Make for_each_cpu_wrap() available on UP as well Peter Zijlstra (1): sched/fair, cpumask: Export for_each_cpu_wrap() R. Parameswaran (3): New kernel function to get IP overhead on a socket. L2TP:Adjust intf MTU, add underlay L3, L2 hdrs. l2tp: device MTU setup, tunnel socket needs a lock Roberto Sassu (1): evm: Check also if *tfm is an error pointer in init_desc() Sebastian Reichel (1): HID: multitouch: add eGalaxTouch P80H84 support Shuah Khan (3): media: Fix media_open() to clear filp->private_data in error leg media: fix use-after-free in cdev_put() when app exits after driver unbind media: fix media devnode ioctl/syscall and unregister race Theodore Ts'o (1): ext4: lock the xattr block before checksuming it Thomas Gleixner (1): ARM: futex: Address build warning Tobias Klauser (1): padata: Remove unused but set variables Vishal Verma (1): libnvdimm/btt: Remove unnecessary code in btt_freelist_init Wolfram Sang (1): i2c: dev: don't start function name with 'return' Wu Bo (1): ceph: fix double unlock in handle_cap_export() viresh kumar (1): i2c-dev: don't get i2c adapter via i2c_dev

4 years, 7 months

1
0
0 0

[PATCH v1] x86: Pin cr4 FSGSBASE

by Andi Kleen

From: Andi Kleen <ak(a)linux.intel.com> Since there seem to be kernel modules floating around that set FSGSBASE incorrectly, prevent this in the CR4 pinning. Currently CR4 pinning just checks that bits are set, this also checks that the FSGSBASE bit is not set, and if it is clears it again. Note this patch will need to be undone when the full FSGSBASE patches are merged. But it's a reasonable solution for v5.2+ stable at least. Sadly the older kernels don't have the necessary infrastructure for this (although a simpler version of this could be added there too) Cc: stable(a)vger.kernel.org # v5.2+ Signed-off-by: Andi Kleen <ak(a)linux.intel.com> --- arch/x86/kernel/cpu/common.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index bed0cb83fe24..1f5b7871ae9a 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -385,6 +385,11 @@ void native_write_cr4(unsigned long val) /* Warn after we've set the missing bits. */ WARN_ONCE(bits_missing, "CR4 bits went missing: %lx!?\n", bits_missing); + if (val & X86_CR4_FSGSBASE) { + WARN_ONCE(1, "CR4 unexpectedly set FSGSBASE!?\n"); + val &= ~X86_CR4_FSGSBASE; + goto set_register; + } } } EXPORT_SYMBOL(native_write_cr4); -- 2.25.4

4 years, 7 months

6
16
0 0

patch "vt: keyboard: avoid signed integer overflow in k_ascii" added to tty-testing

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled vt: keyboard: avoid signed integer overflow in k_ascii to my tty git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git in the tty-testing branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will be merged to the tty-next branch sometime soon, after it passes testing, and the merge window is open. If you have any questions about this process, please let me know. >From b86dab054059b970111b5516ae548efaae5b3aae Mon Sep 17 00:00:00 2001 From: Dmitry Torokhov <dmitry.torokhov(a)gmail.com> Date: Mon, 25 May 2020 16:27:40 -0700 Subject: vt: keyboard: avoid signed integer overflow in k_ascii When k_ascii is invoked several times in a row there is a potential for signed integer overflow: UBSAN: Undefined behaviour in drivers/tty/vt/keyboard.c:888:19 signed integer overflow: 10 * 1111111111 cannot be represented in type 'int' CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.6.11 #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 Call Trace: <IRQ> __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0xce/0x128 lib/dump_stack.c:118 ubsan_epilogue+0xe/0x30 lib/ubsan.c:154 handle_overflow+0xdc/0xf0 lib/ubsan.c:184 __ubsan_handle_mul_overflow+0x2a/0x40 lib/ubsan.c:205 k_ascii+0xbf/0xd0 drivers/tty/vt/keyboard.c:888 kbd_keycode drivers/tty/vt/keyboard.c:1477 [inline] kbd_event+0x888/0x3be0 drivers/tty/vt/keyboard.c:1495 While it can be worked around by using check_mul_overflow()/ check_add_overflow(), it is better to introduce a separate flag to signal that number pad is being used to compose a symbol, and change type of the accumulator from signed to unsigned, thus avoiding undefined behavior when it overflows. Reported-by: Kyungtae Kim <kt0755(a)gmail.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov(a)gmail.com> Cc: stable <stable(a)vger.kernel.org> Link: https://lore.kernel.org/r/20200525232740.GA262061@dtor-ws Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/tty/vt/keyboard.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c index 15d33fa0c925..568b2171f335 100644 --- a/drivers/tty/vt/keyboard.c +++ b/drivers/tty/vt/keyboard.c @@ -127,7 +127,11 @@ static DEFINE_SPINLOCK(func_buf_lock); /* guard 'func_buf' and friends */ static unsigned long key_down[BITS_TO_LONGS(KEY_CNT)]; /* keyboard key bitmap */ static unsigned char shift_down[NR_SHIFT]; /* shift state counters.. */ static bool dead_key_next; -static int npadch = -1; /* -1 or number assembled on pad */ + +/* Handles a number being assembled on the number pad */ +static bool npadch_active; +static unsigned int npadch_value; + static unsigned int diacr; static char rep; /* flag telling character repeat */ @@ -845,12 +849,12 @@ static void k_shift(struct vc_data *vc, unsigned char value, char up_flag) shift_state &= ~(1 << value); /* kludge */ - if (up_flag && shift_state != old_state && npadch != -1) { + if (up_flag && shift_state != old_state && npadch_active) { if (kbd->kbdmode == VC_UNICODE) - to_utf8(vc, npadch); + to_utf8(vc, npadch_value); else - put_queue(vc, npadch & 0xff); - npadch = -1; + put_queue(vc, npadch_value & 0xff); + npadch_active = false; } } @@ -868,7 +872,7 @@ static void k_meta(struct vc_data *vc, unsigned char value, char up_flag) static void k_ascii(struct vc_data *vc, unsigned char value, char up_flag) { - int base; + unsigned int base; if (up_flag) return; @@ -882,10 +886,12 @@ static void k_ascii(struct vc_data *vc, unsigned char value, char up_flag) base = 16; } - if (npadch == -1) - npadch = value; - else - npadch = npadch * base + value; + if (!npadch_active) { + npadch_value = 0; + npadch_active = true; + } + + npadch_value = npadch_value * base + value; } static void k_lock(struct vc_data *vc, unsigned char value, char up_flag) -- 2.26.2

4 years, 7 months

1
0
0 0

patch "nvmem: qfprom: remove incorrect write support" added to char-misc-testing

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled nvmem: qfprom: remove incorrect write support to my char-misc git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git in the char-misc-testing branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will be merged to the char-misc-next branch sometime soon, after it passes testing, and the merge window is open. If you have any questions about this process, please let me know. >From 8d9eb0d6d59a5d7028c80a30831143d3e75515a7 Mon Sep 17 00:00:00 2001 From: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> Date: Fri, 22 May 2020 12:33:41 +0100 Subject: nvmem: qfprom: remove incorrect write support qfprom has different address spaces for read and write. Reads are always done from corrected address space, where as writes are done on raw address space. Writing to corrected address space is invalid and ignored, so it does not make sense to have this support in the driver which only supports corrected address space regions at the moment. Fixes: 4ab11996b489 ("nvmem: qfprom: Add Qualcomm QFPROM support.") Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> Reviewed-by: Douglas Anderson <dianders(a)chromium.org> Cc: stable <stable(a)vger.kernel.org> Link: https://lore.kernel.org/r/20200522113341.7728-1-srinivas.kandagatla@linaro.… Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/nvmem/qfprom.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c index d057f1bfb2e9..8a91717600be 100644 --- a/drivers/nvmem/qfprom.c +++ b/drivers/nvmem/qfprom.c @@ -27,25 +27,11 @@ static int qfprom_reg_read(void *context, return 0; } -static int qfprom_reg_write(void *context, - unsigned int reg, void *_val, size_t bytes) -{ - struct qfprom_priv *priv = context; - u8 *val = _val; - int i = 0, words = bytes; - - while (words--) - writeb(*val++, priv->base + reg + i++); - - return 0; -} - static struct nvmem_config econfig = { .name = "qfprom", .stride = 1, .word_size = 1, .reg_read = qfprom_reg_read, - .reg_write = qfprom_reg_write, }; static int qfprom_probe(struct platform_device *pdev) -- 2.26.2

4 years, 7 months

1
0
0 0

stable-rc/linux-5.4.y boot: 151 boots: 2 failed, 139 passed with 5 offline, 5 untried/unknown (v5.4.42-112-g00dd3347ad64)

by kernelci.org bot

****************************************** * WARNING: Boot tests are now deprecated * ****************************************** As kernelci.org is expanding its functional testing capabilities, the concept of boot testing is now deprecated. Boot results are scheduled to be dropped on *5th June 2020*. The full schedule for boot tests deprecation is available on this GitHub issue: https://github.com/kernelci/kernelci-backend/issues/238 The new equivalent is the *baseline* test suite which also runs sanity checks using dmesg and bootrr: https://github.com/kernelci/bootrr See the *baseline results for this kernel revision* on this page: https://kernelci.org/test/job/stable-rc/branch/linux-5.4.y/kernel/v5.4.42-1… ------------------------------------------------------------------------------- stable-rc/linux-5.4.y boot: 151 boots: 2 failed, 139 passed with 5 offline, 5 untried/unknown (v5.4.42-112-g00dd3347ad64) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-5.4.y/kernel/v5.4.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-5.4.y/kernel/v5.4.42-112-… Tree: stable-rc Branch: linux-5.4.y Git Describe: v5.4.42-112-g00dd3347ad64 Git Commit: 00dd3347ad64830e7d9a5a6bd3036b9537887208 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 94 unique boards, 25 SoC families, 19 builds out of 166 Boot Regressions Detected: arm: multi_v7_defconfig: gcc-8: omap3-beagle-xm: lab-baylibre: new failure (last pass: v5.4.42-105-g3cb79944b65a) qcom_defconfig: gcc-8: qcom-apq8064-cm-qs600: lab-baylibre-seattle: failing since 108 days (last pass: v5.4.17-99-gbd0c6624a110 - first fail: v5.4.17-238-gbffcaa93483d) sama5_defconfig: gcc-8: at91-sama5d4_xplained: lab-baylibre: failing since 49 days (last pass: v5.4.30-37-g40da5db79b55 - first fail: v5.4.30-39-g23c04177b89f) Boot Failures Detected: arm: sama5_defconfig: gcc-8: at91-sama5d4_xplained: 1 failed lab multi_v7_defconfig: gcc-8: omap3-beagle-xm: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: gcc-8 exynos5800-peach-pi: 1 offline lab qcom-apq8064-cm-qs600: 1 offline lab stih410-b2120: 1 offline lab exynos_defconfig: gcc-8 exynos5800-peach-pi: 1 offline lab qcom_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab --- For more info write to <info(a)kernelci.org>

4 years, 7 months

1
0
0 0

patch "tty: hvc_console, fix crashes on parallel open/close" added to tty-testing

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled tty: hvc_console, fix crashes on parallel open/close to my tty git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git in the tty-testing branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will be merged to the tty-next branch sometime soon, after it passes testing, and the merge window is open. If you have any questions about this process, please let me know. >From 24eb2377f977fe06d84fca558f891f95bc28a449 Mon Sep 17 00:00:00 2001 From: Jiri Slaby <jslaby(a)suse.cz> Date: Tue, 26 May 2020 16:56:32 +0200 Subject: tty: hvc_console, fix crashes on parallel open/close hvc_open sets tty->driver_data to NULL when open fails at some point. Typically, the failure happens in hp->ops->notifier_add(). If there is a racing process which tries to open such mangled tty, which was not closed yet, the process will crash in hvc_open as tty->driver_data is NULL. All this happens because close wants to know whether open failed or not. But ->open should not NULL this and other tty fields for ->close to be happy. ->open should call tty_port_set_initialized(true) and close should check by tty_port_initialized() instead. So do this properly in this driver. So this patch removes these from ->open: * tty_port_tty_set(&hp->port, NULL). This happens on last close. * tty->driver_data = NULL. Dtto. * tty_port_put(&hp->port). This happens in shutdown and until now, this must have been causing a reference underflow, if I am not missing something. Signed-off-by: Jiri Slaby <jslaby(a)suse.cz> Cc: stable <stable(a)vger.kernel.org> Reported-and-tested-by: Raghavendra <rananta(a)codeaurora.org> Link: https://lore.kernel.org/r/20200526145632.13879-1-jslaby@suse.cz Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/tty/hvc/hvc_console.c | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index 436cc51c92c3..cdcc64ea2554 100644 --- a/drivers/tty/hvc/hvc_console.c +++ b/drivers/tty/hvc/hvc_console.c @@ -371,15 +371,14 @@ static int hvc_open(struct tty_struct *tty, struct file * filp) * tty fields and return the kref reference. */ if (rc) { - tty_port_tty_set(&hp->port, NULL); - tty->driver_data = NULL; - tty_port_put(&hp->port); printk(KERN_ERR "hvc_open: request_irq failed with rc %d.\n", rc); - } else + } else { /* We are ready... raise DTR/RTS */ if (C_BAUD(tty)) if (hp->ops->dtr_rts) hp->ops->dtr_rts(hp, 1); + tty_port_set_initialized(&hp->port, true); + } /* Force wakeup of the polling thread */ hvc_kick(); @@ -389,22 +388,12 @@ static int hvc_open(struct tty_struct *tty, struct file * filp) static void hvc_close(struct tty_struct *tty, struct file * filp) { - struct hvc_struct *hp; + struct hvc_struct *hp = tty->driver_data; unsigned long flags; if (tty_hung_up_p(filp)) return; - /* - * No driver_data means that this close was issued after a failed - * hvc_open by the tty layer's release_dev() function and we can just - * exit cleanly because the kref reference wasn't made. - */ - if (!tty->driver_data) - return; - - hp = tty->driver_data; - spin_lock_irqsave(&hp->port.lock, flags); if (--hp->port.count == 0) { @@ -412,6 +401,9 @@ static void hvc_close(struct tty_struct *tty, struct file * filp) /* We are done with the tty pointer now. */ tty_port_tty_set(&hp->port, NULL); + if (!tty_port_initialized(&hp->port)) + return; + if (C_HUPCL(tty)) if (hp->ops->dtr_rts) hp->ops->dtr_rts(hp, 0); @@ -428,6 +420,7 @@ static void hvc_close(struct tty_struct *tty, struct file * filp) * waking periodically to check chars_in_buffer(). */ tty_wait_until_sent(tty, HVC_CLOSE_WAIT); + tty_port_set_initialized(&hp->port, false); } else { if (hp->port.count < 0) printk(KERN_ERR "hvc_close %X: oops, count is %d\n", -- 2.26.2

4 years, 7 months

1
0
0 0

patch "serial: 8250: Enable 16550A variants by default on non-x86" added to tty-testing

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled serial: 8250: Enable 16550A variants by default on non-x86 to my tty git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git in the tty-testing branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will be merged to the tty-next branch sometime soon, after it passes testing, and the merge window is open. If you have any questions about this process, please let me know. >From 15a3f03d5ec0118f1e5db3fc1018686e72744e37 Mon Sep 17 00:00:00 2001 From: Josh Triplett <josh(a)joshtriplett.org> Date: Tue, 26 May 2020 09:13:57 -0700 Subject: serial: 8250: Enable 16550A variants by default on non-x86 Some embedded devices still use these serial ports; make sure they're still enabled by default on architectures more likely to have them, to avoid rendering someone's console unavailable. Reported-by: Vladimir Oltean <vladimir.oltean(a)nxp.com> Reported-by: Maxim Kochetkov <fido_max(a)inbox.ru> Fixes: dc56ecb81a0a ("serial: 8250: Support disabling mdelay-filled probes of 16550A variants") Cc: stable <stable(a)vger.kernel.org> Signed-off-by: Josh Triplett <josh(a)joshtriplett.org> Link: https://lore.kernel.org/r/a20b5fb7dd295cfb48160eecf4bdebd76332d67d.15905094… Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/tty/serial/8250/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig index af0688156dd0..8195a31519ea 100644 --- a/drivers/tty/serial/8250/Kconfig +++ b/drivers/tty/serial/8250/Kconfig @@ -63,6 +63,7 @@ config SERIAL_8250_PNP config SERIAL_8250_16550A_VARIANTS bool "Support for variants of the 16550A serial port" depends on SERIAL_8250 + default !X86 help The 8250 driver can probe for many variants of the venerable 16550A serial port. Doing so takes additional time at boot. -- 2.26.2

4 years, 7 months

1
0
0 0

patch "serial: imx: Initialize lock for non-registered console" added to tty-testing

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled serial: imx: Initialize lock for non-registered console to my tty git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git in the tty-testing branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will be merged to the tty-next branch sometime soon, after it passes testing, and the merge window is open. If you have any questions about this process, please let me know. >From 8f065acec7573672dd15916e31d1e9b2e785566c Mon Sep 17 00:00:00 2001 From: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> Date: Mon, 25 May 2020 13:59:52 +0300 Subject: serial: imx: Initialize lock for non-registered console The commit a3cb39d258ef ("serial: core: Allow detach and attach serial device for console") changed a bit logic behind lock initialization since for most of the console driver it's supposed to have lock already initialized even if console is not enabled. However, it's not the case for Freescale IMX console. Initialize lock explicitly in the ->probe(). Note, there is still an open question should or shouldn't not this driver register console properly. Fixes: a3cb39d258ef ("serial: core: Allow detach and attach serial device for console") Reported-by: Guenter Roeck <linux(a)roeck-us.net> Cc: stable <stable(a)vger.kernel.org> Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> Link: https://lore.kernel.org/r/20200525105952.13744-1-andriy.shevchenko@linux.in… Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/tty/serial/imx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 986d902fb7fe..6b078e395931 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -2404,6 +2404,9 @@ static int imx_uart_probe(struct platform_device *pdev) } } + /* We need to initialize lock even for non-registered console */ + spin_lock_init(&sport->port.lock); + imx_uart_ports[sport->port.line] = sport; platform_set_drvdata(pdev, sport); -- 2.26.2

4 years, 7 months

1
0
0 0

patch "CDC-ACM: heed quirk also in error handling" added to usb-testing

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled CDC-ACM: heed quirk also in error handling to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-testing branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will be merged to the usb-next branch sometime soon, after it passes testing, and the merge window is open. If you have any questions about this process, please let me know. >From 97fe809934dd2b0b37dfef3a2fc70417f485d7af Mon Sep 17 00:00:00 2001 From: Oliver Neukum <oneukum(a)suse.com> Date: Tue, 26 May 2020 14:44:20 +0200 Subject: CDC-ACM: heed quirk also in error handling If buffers are iterated over in the error case, the lower limits for quirky devices must be heeded. Signed-off-by: Oliver Neukum <oneukum(a)suse.com> Reported-by: Jean Rene Dawin <jdawin(a)math.uni-bielefeld.de> Fixes: a4e7279cd1d19 ("cdc-acm: introduce a cool down") Cc: stable <stable(a)vger.kernel.org> Link: https://lore.kernel.org/r/20200526124420.22160-1-oneukum@suse.com Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/usb/class/cdc-acm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index ded8d93834ca..f67088bb8218 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -584,7 +584,7 @@ static void acm_softint(struct work_struct *work) } if (test_and_clear_bit(ACM_ERROR_DELAY, &acm->flags)) { - for (i = 0; i < ACM_NR; i++) + for (i = 0; i < acm->rx_buflimit; i++) if (test_and_clear_bit(i, &acm->urbs_in_error_delay)) acm_submit_read_urb(acm, i, GFP_NOIO); } -- 2.26.2

4 years, 7 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror May 2020