March 2020 - Linux-stable-mirror

[stable-4.14 0/3] some backport for stable

by Jack Wang

Hi Greg, hi Sasha, Please consider following backport for next stable release. First patch for vhost_net has been tested with our in house regression tests with VM migration with kernel 4.14.171, but should be also applied to older stable tree. mce patch is to fix a call trace in EPYC Rome server during boot. EDAC one is to fix a regression backported to at least 4.14 and 4.19, should be applied to both tree, kernel 5.4/5.5 already have the patch. Regards, Jack Wang from IONOS SE. Eugenio Pérez (1): vhost: Check docket sk_family instead of call getname Yazen Ghannam (2): x86/mce: Handle varying MCA bank counts EDAC/amd64: Set grain per DIMM arch/x86/kernel/cpu/mcheck/mce-inject.c | 14 +++++++------- arch/x86/kernel/cpu/mcheck/mce.c | 22 +++++++--------------- drivers/edac/amd64_edac.c | 1 + drivers/vhost/net.c | 13 ++----------- 4 files changed, 17 insertions(+), 33 deletions(-) -- 2.17.1

4 years, 7 months

2
4
0 0

stable-rc/linux-5.4.y boot: 120 boots: 3 failed, 112 passed with 3 offline, 2 untried/unknown (v5.4.24)

by kernelci.org bot

stable-rc/linux-5.4.y boot: 120 boots: 3 failed, 112 passed with 3 offline, 2 untried/unknown (v5.4.24) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-5.4.y/kernel/v5.4.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-5.4.y/kernel/v5.4.24/ Tree: stable-rc Branch: linux-5.4.y Git Describe: v5.4.24 Git Commit: cff670b3eb68257029e2977a6bfeac7d9b829e9a Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 89 unique boards, 25 SoC families, 19 builds out of 200 Boot Regressions Detected: arc: hsdk_defconfig: gcc-8: hsdk: lab-baylibre: new failure (last pass: v5.4.22) arm: qcom_defconfig: gcc-8: qcom-apq8064-cm-qs600: lab-baylibre-seattle: failing since 26 days (last pass: v5.4.17-99-gbd0c6624a110 - first fail: v5.4.17-238-gbffcaa93483d) sunxi_defconfig: gcc-8: sun4i-a10-cubieboard: lab-baylibre-seattle: new failure (last pass: v5.4.23-153-g1254e88b4fc1) arm64: defconfig: gcc-8: meson-axg-s400: lab-baylibre-seattle: new failure (last pass: v5.4.23-153-g1254e88b4fc1) Boot Failures Detected: arm: multi_v7_defconfig: gcc-8: sun4i-a10-cubieboard: 1 failed lab sunxi_defconfig: gcc-8: sun4i-a10-cubieboard: 1 failed lab sama5_defconfig: gcc-8: at91-sama5d4_xplained: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab qcom_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab arm64: defconfig: gcc-8 meson-axg-s400: 1 offline lab --- For more info write to <info(a)kernelci.org>

4 years, 7 months

1
0
0 0

block, bfq: port of a series of fix commits to 5.4 and 5.5

by Paolo Valente

Hi, Fedora requested the following fix commits, currently available in 5.6-rc4, to be ported to 5.4 and 5.5 [1]: db37a34c563b block, bfq: get a ref to a group when adding it to a service tree 4d8340d0d4d9 block, bfq: remove ifdefs from around gets/puts of bfq groups 33a16a980468 block, bfq: extend incomplete name of field on_st ecedd3d7e199 block, bfq: get extra ref to prevent a queue from being freed during a group move 32c59e3a9a5a block, bfq: do not insert oom queue into position tree f718b093277d block, bfq: do not plug I/O for bfq_queues with no proc refs No change is needed for these commits to apply cleanly in 5.4 and 5.5. Fedora asked for this porting because it will allow them to include these commits in their kernels, and solve the crash that led me to the making of the commits themselves [1]. This is the first time I submit something for stable branches, I hope I did everything right (I'm following option 2 in [2]). Thanks, Paolo [1] https://bugzilla.redhat.com/show_bug.cgi?id=1767539 [2] https://github.com/torvalds/linux/blob/master/Documentation/process/stable-…

4 years, 7 months

3
3
0 0

Re: [patch 1/7] genirq/debugfs: Add missing sanity checks to interrupt injection

by Marc Zyngier

On 2020-03-06 13:03, Thomas Gleixner wrote: > Interrupts cannot be injected when the interrupt is not activated and > when > a replay is already in progress. > > Fixes: 536e2e34bd00 ("genirq/debugfs: Triggering of interrupts from > userspace") > Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> > Cc: stable(a)vger.kernel.org > --- > kernel/irq/debugfs.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > --- a/kernel/irq/debugfs.c > +++ b/kernel/irq/debugfs.c > @@ -206,8 +206,15 @@ static ssize_t irq_debug_write(struct fi > chip_bus_lock(desc); > raw_spin_lock_irqsave(&desc->lock, flags); > > - if (irq_settings_is_level(desc) || desc->istate & IRQS_NMI) { > - /* Can't do level nor NMIs, sorry */ > + /* > + * Don't allow injection when the interrupt is: > + * - Level or NMI type > + * - not activated > + * - replaying already > + */ > + if (irq_settings_is_level(desc) || > + !irqd_is_activated(&desc->irq_data) || > + (desc->istate & (IRQS_NMI | IRQS_REPLAY)) { > err = -EINVAL; > } else { > desc->istate |= IRQS_PENDING; Huh, nice catch. Acked-by: Marc Zyngier <maz(a)kernel.org> M. -- Jazz is not dead. It just smells funny...

4 years, 7 months

1
0
0 0

patch "tty: serial: fsl_lpuart: free IDs allocated by IDA" added to tty-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled tty: serial: fsl_lpuart: free IDs allocated by IDA to my tty git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git in the tty-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From 2b2e71fe657510a6f71aa16ef0309fa6bc20ab3d Mon Sep 17 00:00:00 2001 From: Michael Walle <michael(a)walle.cc> Date: Tue, 3 Mar 2020 18:42:59 +0100 Subject: tty: serial: fsl_lpuart: free IDs allocated by IDA Since commit 3bc3206e1c0f ("serial: fsl_lpuart: Remove the alias node dependence") the port line number can also be allocated by IDA, but in case of an error the ID will no be removed again. More importantly, any ID will be freed in remove(), even if it wasn't allocated but instead fetched by of_alias_get_id(). If it was not allocated by IDA there will be a warning: WARN(1, "ida_free called for id=%d which is not allocated.\n", id); Move the ID allocation more to the end of the probe() so that we still can use plain return in the first error cases. Fixes: 3bc3206e1c0f ("serial: fsl_lpuart: Remove the alias node dependence") Signed-off-by: Michael Walle <michael(a)walle.cc> Cc: stable <stable(a)vger.kernel.org> Link: https://lore.kernel.org/r/20200303174306.6015-3-michael@walle.cc Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/tty/serial/fsl_lpuart.c | 39 ++++++++++++++++++++------------- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 27fdc131c352..c31b8f3db6bf 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -264,6 +264,7 @@ struct lpuart_port { int rx_dma_rng_buf_len; unsigned int dma_tx_nents; wait_queue_head_t dma_wait; + bool id_allocated; }; struct lpuart_soc_data { @@ -2422,19 +2423,6 @@ static int lpuart_probe(struct platform_device *pdev) if (!sport) return -ENOMEM; - ret = of_alias_get_id(np, "serial"); - if (ret < 0) { - ret = ida_simple_get(&fsl_lpuart_ida, 0, UART_NR, GFP_KERNEL); - if (ret < 0) { - dev_err(&pdev->dev, "port line is full, add device failed\n"); - return ret; - } - } - if (ret >= ARRAY_SIZE(lpuart_ports)) { - dev_err(&pdev->dev, "serial%d out of range\n", ret); - return -EINVAL; - } - sport->port.line = ret; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); sport->port.membase = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(sport->port.membase)) @@ -2479,9 +2467,25 @@ static int lpuart_probe(struct platform_device *pdev) } } + ret = of_alias_get_id(np, "serial"); + if (ret < 0) { + ret = ida_simple_get(&fsl_lpuart_ida, 0, UART_NR, GFP_KERNEL); + if (ret < 0) { + dev_err(&pdev->dev, "port line is full, add device failed\n"); + return ret; + } + sport->id_allocated = true; + } + if (ret >= ARRAY_SIZE(lpuart_ports)) { + dev_err(&pdev->dev, "serial%d out of range\n", ret); + ret = -EINVAL; + goto failed_out_of_range; + } + sport->port.line = ret; + ret = lpuart_enable_clks(sport); if (ret) - return ret; + goto failed_clock_enable; sport->port.uartclk = lpuart_get_baud_clk_rate(sport); lpuart_ports[sport->port.line] = sport; @@ -2531,6 +2535,10 @@ static int lpuart_probe(struct platform_device *pdev) failed_attach_port: failed_irq_request: lpuart_disable_clks(sport); +failed_clock_enable: +failed_out_of_range: + if (sport->id_allocated) + ida_simple_remove(&fsl_lpuart_ida, sport->port.line); return ret; } @@ -2540,7 +2548,8 @@ static int lpuart_remove(struct platform_device *pdev) uart_remove_one_port(&lpuart_reg, &sport->port); - ida_simple_remove(&fsl_lpuart_ida, sport->port.line); + if (sport->id_allocated) + ida_simple_remove(&fsl_lpuart_ida, sport->port.line); lpuart_disable_clks(sport); -- 2.25.1

4 years, 7 months

1
0
0 0

5.5.y - apply "ASoC: intel/skl/hda - export number of digital microphones via control components"

by Jaroslav Kysela

Hi, could we cherry-pick patch 8cd9956f61c65022209ce6d1e55ed12aea12357d to the 5.5 stable tree? 8cd9956f61c65022209ce6d1e55ed12aea12357d : "ASoC: intel/skl/hda - export number of digital microphones via control components" Rerefences: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/817 Thank you, Jaroslav -- Jaroslav Kysela <perex(a)perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

4 years, 7 months

4
10
0 0

patch "serdev: Fix detection of UART devices on Apple machines." added to tty-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled serdev: Fix detection of UART devices on Apple machines. to my tty git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git in the tty-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From 35d4670aaec7206b5ef19c842ca33076bde562e4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ronald=20Tschal=C3=A4r?= <ronald(a)innovation.ch> Date: Tue, 11 Feb 2020 11:47:23 -0800 Subject: serdev: Fix detection of UART devices on Apple machines. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Apple devices the _CRS method returns an empty resource template, and the resource settings are instead provided by the _DSM method. But commit 33364d63c75d6182fa369cea80315cf1bb0ee38e (serdev: Add ACPI devices by ResourceSource field) changed the search for serdev devices to require valid, non-empty resource template, thereby breaking Apple devices and causing bluetooth devices to not be found. This expands the check so that if we don't find a valid template, and we're on an Apple machine, then just check for the device being an immediate child of the controller and having a "baud" property. Cc: <stable(a)vger.kernel.org> # 5.5 Fixes: 33364d63c75d ("serdev: Add ACPI devices by ResourceSource field") Signed-off-by: Ronald Tschalär <ronald(a)innovation.ch> Link: https://lore.kernel.org/r/20200211194723.486217-1-ronald@innovation.ch Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/tty/serdev/core.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c index 42345e79920c..c5f0d936b003 100644 --- a/drivers/tty/serdev/core.c +++ b/drivers/tty/serdev/core.c @@ -18,6 +18,7 @@ #include <linux/sched.h> #include <linux/serdev.h> #include <linux/slab.h> +#include <linux/platform_data/x86/apple.h> static bool is_registered; static DEFINE_IDA(ctrl_ida); @@ -631,6 +632,15 @@ static int acpi_serdev_check_resources(struct serdev_controller *ctrl, if (ret) return ret; + /* + * Apple machines provide an empty resource template, so on those + * machines just look for immediate children with a "baud" property + * (from the _DSM method) instead. + */ + if (!lookup.controller_handle && x86_apple_machine && + !acpi_dev_get_property(adev, "baud", ACPI_TYPE_BUFFER, NULL)) + acpi_get_parent(adev->handle, &lookup.controller_handle); + /* Make sure controller and ResourceSource handle match */ if (ACPI_HANDLE(ctrl->dev.parent) != lookup.controller_handle) return -ENODEV; -- 2.25.1

4 years, 7 months

1
0
0 0

stable-rc/linux-4.14.y boot: 52 boots: 2 failed, 49 passed with 1 untried/unknown (v4.14.172)

by kernelci.org bot

stable-rc/linux-4.14.y boot: 52 boots: 2 failed, 49 passed with 1 untried/unknown (v4.14.172) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.14.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.14.y/kernel/v4.14.172/ Tree: stable-rc Branch: linux-4.14.y Git Describe: v4.14.172 Git Commit: 78d697fc93f98054e36a3ab76dca1a88802ba7be Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 39 unique boards, 13 SoC families, 12 builds out of 201 Boot Regressions Detected: arm: sama5_defconfig: gcc-8: at91-sama5d4_xplained: lab-baylibre: failing since 9 days (last pass: v4.14.170-141-g00a0113414f7 - first fail: v4.14.171-29-g9cfe30e85240) sunxi_defconfig: gcc-8: sun8i-a33-olinuxino: lab-clabbe: new failure (last pass: v4.14.171-235-g7184e90f61c3) Boot Failures Detected: arm: sama5_defconfig: gcc-8: at91-sama5d4_xplained: 1 failed lab arm64: defconfig: gcc-8: meson-gxm-q200: 1 failed lab --- For more info write to <info(a)kernelci.org>

4 years, 7 months

1
0
0 0

[PATCH] sched/fair: fix enqueue_task_fair warning

by Vincent Guittot

When a cfs rq is throttled, the latter and its child are removed from the leaf list but their nr_running is not changed which includes staying higher than 1. When a task is enqueued in this throttled branch, the cfs rqs must be added back in order to ensure correct ordering in the list but this can only happens if nr_running == 1. When cfs bandwidth is used, we call unconditionnaly list_add_leaf_cfs_rq() when enqueuing an entity to make sure that the complete branch will be added. Reported-by: Christian Borntraeger <borntraeger(a)de.ibm.com> Tested-by: Christian Borntraeger <borntraeger(a)de.ibm.com> Cc: stable(a)vger.kernel.org #v5.1+ Signed-off-by: Vincent Guittot <vincent.guittot(a)linaro.org> --- kernel/sched/fair.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index fcc968669aea..bdc5bb72ab31 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -4117,6 +4117,7 @@ static inline void check_schedstat_required(void) #endif } +static inline bool cfs_bandwidth_used(void); /* * MIGRATION @@ -4195,10 +4196,16 @@ enqueue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags) __enqueue_entity(cfs_rq, se); se->on_rq = 1; - if (cfs_rq->nr_running == 1) { + /* + * When bandwidth control is enabled, cfs might have been removed because of + * a parent been throttled but cfs->nr_running > 1. Try to add it + * unconditionnally. + */ + if (cfs_rq->nr_running == 1 || cfs_bandwidth_used()) list_add_leaf_cfs_rq(cfs_rq); + + if (cfs_rq->nr_running == 1) check_enqueue_throttle(cfs_rq); - } } static void __clear_buddies_last(struct sched_entity *se) -- 2.17.1

4 years, 7 months

2
4
0 0

stable-rc/linux-4.4.y boot: 28 boots: 1 failed, 26 passed with 1 conflict (v4.4.215)

by kernelci.org bot

stable-rc/linux-4.4.y boot: 28 boots: 1 failed, 26 passed with 1 conflict (v4.4.215) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.4.y/kernel/v4.4.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.215/ Tree: stable-rc Branch: linux-4.4.y Git Describe: v4.4.215 Git Commit: 1721173ef18200e8e8265568f13942d6e19c2c83 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 19 unique boards, 7 SoC families, 9 builds out of 190 Boot Regressions Detected: x86_64: x86_64_defconfig: gcc-8: qemu_x86_64: lab-collabora: new failure (last pass: v4.4.215) Boot Failure Detected: arm: sama5_defconfig: gcc-8: at91-sama5d4_xplained: 1 failed lab Conflicting Boot Failure Detected: (These likely are not failures as other labs are reporting PASS. Needs review.) x86_64: x86_64_defconfig: qemu_x86_64: lab-collabora: PASS (gcc-8) lab-baylibre: FAIL (gcc-8) --- For more info write to <info(a)kernelci.org>

4 years, 7 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror March 2020