Hi Sasha,
> On Oct 26, 2020, at 13:09, Sasha Levin <sashal(a)kernel.org> wrote:
>
> This is a note to let you know that I've just added the patch titled
>
> drm/radeon: Prefer lower feedback dividers
>
> to the 5.9-stable tree which can be found at:
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum…
>
> The filename of the patch is:
> drm-radeon-prefer-lower-feedback-dividers.patch
> and it can be found in the queue-5.9 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable(a)vger.kernel.org> know about it.
Please drop this patch because it causes some regression.
Kai-Heng
>
>
>
> commit 3fa04dfbb55a95e7c6075d0644f64bcb6e7f4ef8
> Author: Kai-Heng Feng <kai.heng.feng(a)canonical.com>
> Date: Wed Aug 26 01:33:48 2020 +0800
>
> drm/radeon: Prefer lower feedback dividers
>
> [ Upstream commit 5150dd85bdfa08143cacf1b4249121651bed3c35 ]
>
> Commit 2e26ccb119bd ("drm/radeon: prefer lower reference dividers")
> fixed screen flicker for HP Compaq nx9420 but breaks other laptops like
> Asus X50SL.
>
> Turns out we also need to favor lower feedback dividers.
>
> Users confirmed this change fixes the regression and doesn't regress the
> original fix.
>
> Fixes: 2e26ccb119bd ("drm/radeon: prefer lower reference dividers")
> BugLink: https://bugs.launchpad.net/bugs/1791312
> BugLink: https://bugs.launchpad.net/bugs/1861554
> Reviewed-by: Christian König <christian.koenig(a)amd.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com>
> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com>
> Signed-off-by: Sasha Levin <sashal(a)kernel.org>
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index e0ae911ef427d..7b69d6dfe44a3 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -933,7 +933,7 @@ static void avivo_get_fb_ref_div(unsigned nom, unsigned den, unsigned post_div,
>
> /* get matching reference and feedback divider */
> *ref_div = min(max(den/post_div, 1u), ref_div_max);
> - *fb_div = DIV_ROUND_CLOSEST(nom * *ref_div * post_div, den);
> + *fb_div = max(nom * *ref_div * post_div / den, 1u);
>
> /* limit fb divider to its maximum */
> if (*fb_div > fb_div_max) {
On 26.10.20 07:35, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
>
> s390/qeth: strictly order bridge address events
>
> to the 5.8-stable tree which can be found at:
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum…
>
> The filename of the patch is:
> s390-qeth-strictly-order-bridge-address-events.patch
> and it can be found in the queue-5.8 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable(a)vger.kernel.org> know about it.
>
This requires
commit a04f0ecacdb0 ("s390/qeth: don't let HW override the configured port role").
>
>
> commit fb538911d11db15ff92e0588cba365eb92c9d4f2
> Author: Julian Wiedmann <jwi(a)linux.ibm.com>
> Date: Thu Aug 27 10:17:05 2020 +0200
>
> s390/qeth: strictly order bridge address events
>
> [ Upstream commit 9d6a569a4cbab5a8b4c959d4e312daeecb7c9f09 ]
>
[...]
Hi Sasha,
On 26/10/2020 06:18, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
>
> selftests: mptcp: depends on built-in IPv6
Thank you for backporting this patch.
(...)
> Fixes: 010b430d5df5 ("mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it")
This patch is not really needed because AFAICS this commit here above
has not been backported to v5.9. It is only in v5.10-rc1.
(...)
> diff --git a/tools/testing/selftests/net/mptcp/config b/tools/testing/selftests/net/mptcp/config
> index 8df5cb8f71ff9..741a1c4f4ae8f 100644
> --- a/tools/testing/selftests/net/mptcp/config
> +++ b/tools/testing/selftests/net/mptcp/config
> @@ -1,4 +1,5 @@
> CONFIG_MPTCP=y
> +CONFIG_IPV6=y
> CONFIG_MPTCP_IPV6=y
But you can also keep this patch, it doesn't hurt: without this commit
010b430d5df5 ("mptcp: MPTCP_IPV6 should depend on IPV6 instead of
selecting it"), CONFIG_MPTCP_IPV6=y selects CONFIG_IPV6=y. In other
words, adding "CONFIG_IPV6=y" here in the selftests config is redundant
if you don't have this commit 010b430d5df5 but not wrong.
Note that if you also want to backport this commit 010b430d5df5 ("mptcp:
MPTCP_IPV6 should depend on IPV6 instead of selecting it"), you will
need commit 0ed37ac586c0 ("mptcp: depends on IPV6 but not as a module")
as well.
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net