October 2020 - Linux-stable-mirror

[PATCH 3/3] KEYS: trusted: Fix migratable=1 failing

by Jarkko Sakkinen

Consider the following transcript: $ keyctl add trusted kmk "new 32 blobauth=helloworld keyhandle=80000000 migratable=1" @u add_key: Invalid argument The documentation has the following description: migratable= 0|1 indicating permission to reseal to new PCR values, default 1 (resealing allowed) The consequence is that "migratable=1" should succeed. Fix this by allowing this condition to pass instead of return -EINVAL. [*] Documentation/security/keys/trusted-encrypted.rst Cc: stable(a)vger.kernel.org Cc: "James E.J. Bottomley" <jejb(a)linux.ibm.com> Cc: Mimi Zohar <zohar(a)linux.ibm.com> Cc: David Howells <dhowells(a)redhat.com> Fixes: d00a1c72f7f4 ("keys: add new trusted key-type") Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen(a)linux.intel.com> --- security/keys/trusted-keys/trusted_tpm1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/keys/trusted-keys/trusted_tpm1.c b/security/keys/trusted-keys/trusted_tpm1.c index c1dfc32c780b..20ca18e17437 100644 --- a/security/keys/trusted-keys/trusted_tpm1.c +++ b/security/keys/trusted-keys/trusted_tpm1.c @@ -801,7 +801,7 @@ static int getoptions(char *c, struct trusted_key_payload *pay, case Opt_migratable: if (*args[0].from == '0') pay->migratable = 0; - else + else if (*args[0].from != '1') return -EINVAL; break; case Opt_pcrlock: -- 2.25.1

4 years, 3 months

1
0
0 0

[PATCH 1/3] KEYS: trusted: Fix incorrect handling of tpm_get_random()

by Jarkko Sakkinen

When tpm_get_random() was introduced, it defined the following API for the return value: 1. A positive value tells how many bytes of random data was generated. 2. A negative value on error. However, in the call sites the API was used incorrectly, i.e. as it would only return negative values and otherwise zero. Returning he positive read counts to the user space does not make any possible sense. Fix this by returning -EIO when tpm_get_random() returns a positive value. Fixes: 41ab999c80f1 ("tpm: Move tpm_get_random api into the TPM device driver") Cc: stable(a)vger.kernel.org Cc: Mimi Zohar <zohar(a)linux.ibm.com> Cc: "James E.J. Bottomley" <James.Bottomley(a)HansenPartnership.com> Cc: David Howells <dhowells(a)redhat.com> Cc: Kent Yoder <key(a)linux.vnet.ibm.com> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen(a)linux.intel.com> --- security/keys/trusted-keys/trusted_tpm1.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/security/keys/trusted-keys/trusted_tpm1.c b/security/keys/trusted-keys/trusted_tpm1.c index b9fe02e5f84f..c7b1701cdac5 100644 --- a/security/keys/trusted-keys/trusted_tpm1.c +++ b/security/keys/trusted-keys/trusted_tpm1.c @@ -403,9 +403,12 @@ static int osap(struct tpm_buf *tb, struct osapsess *s, int ret; ret = tpm_get_random(chip, ononce, TPM_NONCE_SIZE); - if (ret != TPM_NONCE_SIZE) + if (ret < 0) return ret; + if (ret != TPM_NONCE_SIZE) + return -EIO; + tpm_buf_reset(tb, TPM_TAG_RQU_COMMAND, TPM_ORD_OSAP); tpm_buf_append_u16(tb, type); tpm_buf_append_u32(tb, handle); @@ -496,8 +499,12 @@ static int tpm_seal(struct tpm_buf *tb, uint16_t keytype, goto out; ret = tpm_get_random(chip, td->nonceodd, TPM_NONCE_SIZE); + if (ret < 0) + return ret; + if (ret != TPM_NONCE_SIZE) - goto out; + return -EIO; + ordinal = htonl(TPM_ORD_SEAL); datsize = htonl(datalen); pcrsize = htonl(pcrinfosize); @@ -601,9 +608,12 @@ static int tpm_unseal(struct tpm_buf *tb, ordinal = htonl(TPM_ORD_UNSEAL); ret = tpm_get_random(chip, nonceodd, TPM_NONCE_SIZE); + if (ret < 0) + return ret; + if (ret != TPM_NONCE_SIZE) { pr_info("trusted_key: tpm_get_random failed (%d)\n", ret); - return ret; + return -EIO; } ret = TSS_authhmac(authdata1, keyauth, TPM_NONCE_SIZE, enonce1, nonceodd, cont, sizeof(uint32_t), @@ -1013,8 +1023,12 @@ static int trusted_instantiate(struct key *key, case Opt_new: key_len = payload->key_len; ret = tpm_get_random(chip, payload->key, key_len); + if (ret < 0) + goto out; + if (ret != key_len) { pr_info("trusted_key: key_create failed (%d)\n", ret); + ret = -EIO; goto out; } if (tpm2) -- 2.25.1

4 years, 3 months

1
0
0 0

✅ PASS: Test report for kernel 5.8.13 (stable-queue)

by CKI Project

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: 930d8bc68b5a - xen/events: don't use chip_data for legacy IRQs The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK All kernel binaries, config files, and logs are available for download here: https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefi… Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: make options: make -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: make -j30 INSTALL_MOD_STRIP=1 targz-pkg s390x: make options: make -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: make -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ xfstests - ext4 ⚡⚡⚡ xfstests - xfs ⚡⚡⚡ selinux-policy: serge-testsuite ⚡⚡⚡ storage: software RAID testing ⚡⚡⚡ stress: stress-ng 🚧 ⚡⚡⚡ xfstests - btrfs 🚧 ⚡⚡⚡ IPMI driver test 🚧 ⚡⚡⚡ IPMItool loop stress test 🚧 ⚡⚡⚡ Storage blktests 🚧 ⚡⚡⚡ Storage nvme - tcp Host 2: ✅ Boot test ✅ ACPI table test ✅ ACPI enabled test ✅ Podman system integration test - as root ✅ Podman system integration test - as user ✅ LTP ✅ Loopdev Sanity ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking: igmp conformance test ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - transport ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ pciutils: update pci ids test ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test ✅ storage: SCSI VPD 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ Firmware test suite 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Networking firewall: basic netfilter test 🚧 ✅ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer 🚧 ✅ kdump - kexec_boot Host 3: ✅ Boot test ✅ xfstests - ext4 ✅ xfstests - xfs ✅ selinux-policy: serge-testsuite ✅ storage: software RAID testing ✅ stress: stress-ng 🚧 ✅ xfstests - btrfs 🚧 ❌ IPMI driver test 🚧 ✅ IPMItool loop stress test 🚧 ✅ Storage blktests 🚧 ✅ Storage nvme - tcp ppc64le: Host 1: ✅ Boot test 🚧 ✅ kdump - sysrq-c Host 2: ✅ Boot test ✅ xfstests - ext4 ✅ xfstests - xfs ✅ selinux-policy: serge-testsuite ✅ storage: software RAID testing 🚧 ✅ xfstests - btrfs 🚧 ✅ IPMI driver test 🚧 ✅ IPMItool loop stress test 🚧 ✅ Storage blktests 🚧 ✅ Storage nvme - tcp Host 3: ✅ Boot test ✅ Podman system integration test - as root ✅ Podman system integration test - as user ✅ LTP ✅ Loopdev Sanity ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ pciutils: update pci ids test ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Networking firewall: basic netfilter test 🚧 ✅ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer s390x: Host 1: ✅ Boot test ✅ Podman system integration test - as root ✅ Podman system integration test - as user ✅ LTP ✅ Loopdev Sanity ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - transport ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Networking firewall: basic netfilter test 🚧 ✅ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer Host 2: ✅ Boot test ✅ selinux-policy: serge-testsuite ✅ stress: stress-ng 🚧 ✅ Storage blktests 🚧 ✅ Storage nvme - tcp x86_64: Host 1: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ xfstests - ext4 ⚡⚡⚡ xfstests - xfs ⚡⚡⚡ selinux-policy: serge-testsuite ⚡⚡⚡ storage: software RAID testing ⚡⚡⚡ stress: stress-ng 🚧 ⚡⚡⚡ CPU: Frequency Driver Test 🚧 ⚡⚡⚡ CPU: Idle Test 🚧 ⚡⚡⚡ xfstests - btrfs 🚧 ⚡⚡⚡ IOMMU boot test 🚧 ⚡⚡⚡ IPMI driver test 🚧 ⚡⚡⚡ IPMItool loop stress test 🚧 ⚡⚡⚡ power-management: cpupower/sanity test 🚧 ⚡⚡⚡ Storage blktests 🚧 ⚡⚡⚡ Storage nvme - tcp Host 2: ✅ Boot test ✅ ACPI table test ✅ Podman system integration test - as root ✅ Podman system integration test - as user ✅ LTP ✅ Loopdev Sanity ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking: igmp conformance test ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - transport ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ pciutils: sanity smoke test ✅ pciutils: update pci ids test ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test ✅ storage: SCSI VPD 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ Firmware test suite 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Networking firewall: basic netfilter test 🚧 ✅ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer 🚧 ✅ kdump - kexec_boot Host 3: ✅ Boot test 🚧 ✅ kdump - sysrq-c 🚧 ✅ kdump - file-load Host 4: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test ✅ xfstests - ext4 ✅ xfstests - xfs ✅ selinux-policy: serge-testsuite ✅ storage: software RAID testing ✅ stress: stress-ng 🚧 ✅ CPU: Frequency Driver Test 🚧 ✅ xfstests - btrfs 🚧 ⚡⚡⚡ IOMMU boot test 🚧 ⚡⚡⚡ IPMI driver test 🚧 ⚡⚡⚡ IPMItool loop stress test 🚧 ⚡⚡⚡ power-management: cpupower/sanity test 🚧 ⚡⚡⚡ Storage blktests 🚧 ⚡⚡⚡ Storage nvme - tcp Test sources: https://gitlab.com/cki-project/kernel-tests 💚 Pull requests are welcome for new tests or improvements to existing tests! Aborted tests ------------- Tests that didn't complete running successfully are marked with ⚡⚡⚡. If this was caused by an infrastructure issue, we try to mark that explicitly in the report. Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed. Testing timeout --------------- We aim to provide a report within reasonable timeframe. Tests that haven't finished running yet are marked with ⏱.

4 years, 3 months

1
0
0 0

stable-rc/queue/4.14 baseline: 92 runs, 1 regressions (v4.14.200-8-ge3aa1fb702c6)

by kernelci.org bot

stable-rc/queue/4.14 baseline: 92 runs, 1 regressions (v4.14.200-8-ge3aa1fb702c6) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | results ---------+------+---------------+----------+---------------------+-------- panda | arm | lab-collabora | gcc-8 | omap2plus_defconfig | 3/5 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F4.14/kernel/v4.14.20… Test: baseline Tree: stable-rc Branch: queue/4.14 Describe: v4.14.200-8-ge3aa1fb702c6 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: e3aa1fb702c6947e8e7dda62d34e68a934d42bf4 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | results ---------+------+---------------+----------+---------------------+-------- panda | arm | lab-collabora | gcc-8 | omap2plus_defconfig | 3/5 Details: https://kernelci.org/test/plan/id/5f79e70391d5982ca84ff3f3 Results: 3 PASS, 1 FAIL, 1 SKIP Full config: omap2plus_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.14/v4.14.200-8-ge3aa1fb702c… HTML log: https://storage.kernelci.org//stable-rc/queue-4.14/v4.14.200-8-ge3aa1fb702c… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-3-g27eeeac7… * baseline.dmesg.emerg: https://kernelci.org/test/case/id/5f79e70391d5982ca84ff3fa failing since 0 day (last pass: v4.14.200-4-g2338e5879b46, first fail: v4.14.200-8-gb1ab1c6f9ae9) 2 lines 2020-10-04 15:15:11.675000 kern :emerg : BUG: spinlock bad magic on CPU#0, udevd/99 2020-10-04 15:15:11.684000 kern :emerg : lock: emif_lock+0x0/0xffffed34 [emif], .magic: dead4ead, .owner: <none>/-1, .owner_cpu: -1

4 years, 3 months

1
0
0 0

stable-rc/queue/5.4 baseline: 74 runs, 4 regressions (v5.4.69-15-g134ae1b4b162)

by kernelci.org bot

stable-rc/queue/5.4 baseline: 74 runs, 4 regressions (v5.4.69-15-g134ae1b4b162) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | results -----------------+-------+---------------+----------+-----------+-------- bcm2837-rpi-3-b | arm64 | lab-baylibre | gcc-8 | defconfig | 3/4 rk3399-gru-kevin | arm64 | lab-collabora | gcc-8 | defconfig | 85/90 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F5.4/kernel/v5.4.69-1… Test: baseline Tree: stable-rc Branch: queue/5.4 Describe: v5.4.69-15-g134ae1b4b162 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 134ae1b4b162a205ae703f40f093485a84121700 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | results -----------------+-------+---------------+----------+-----------+-------- bcm2837-rpi-3-b | arm64 | lab-baylibre | gcc-8 | defconfig | 3/4 Details: https://kernelci.org/test/plan/id/5f79e0cef5fb7757b74ff3e0 Results: 3 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-8 (aarch64-linux-gnu-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.69-15-g134ae1b4b162/… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.69-15-g134ae1b4b162/… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-3-g27eeeac7… * baseline.dmesg.crit: https://kernelci.org/test/case/id/5f79e0cef5fb7757b74ff3e4 failing since 0 day (last pass: v5.4.69-3-gf31ade88ddd8, first fail: v5.4.69-16-gde6f85667998) 2 lines 2020-10-04 14:46:32.087000 Connected to bcm2837-rpi-3-b console [channel connected] (~$quit to exit) 2020-10-04 14:46:32.087000 (user:khilman) is already connected 2020-10-04 14:46:47.526000 2020-10-04 14:46:47.526000 2020-10-04 14:46:47.527000 U-Boot 2018.11 (Dec 04 2018 - 10:54:32 -0800) 2020-10-04 14:46:47.527000 2020-10-04 14:46:47.527000 DRAM: 948 MiB 2020-10-04 14:46:47.542000 RPI 3 Model B (0xa02082) 2020-10-04 14:46:47.630000 MMC: mmc@7e202000: 0, sdhci@7e300000: 1 2020-10-04 14:46:47.662000 Loading Environment from FAT... *** Warning - bad CRC, using default environment ... (384 line(s) more) platform | arch | lab | compiler | defconfig | results -----------------+-------+---------------+----------+-----------+-------- rk3399-gru-kevin | arm64 | lab-collabora | gcc-8 | defconfig | 85/90 Details: https://kernelci.org/test/plan/id/5f79e0b3c7e9c47c1a4ff3fd Results: 85 PASS, 5 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-8 (aarch64-linux-gnu-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.69-15-g134ae1b4b162/… HTML log: https://storage.kernelci.org//stable-rc/queue-5.4/v5.4.69-15-g134ae1b4b162/… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-3-g27eeeac7… * baseline.bootrr.cros-ec-sensors-accel0-probed: https://kernelci.org/test/case/id/5f79e0b3c7e9c47c1a4ff411 failing since 4 days (last pass: v5.4.68-384-g856fa448539c, first fail: v5.4.68-388-gcf92ab7a7853) 2020-10-04 14:48:11.278000 <8>[ 23.345843] <LAVA_SIGNAL_TESTCASE TEST_CASE_ID=cros-ec-sensors-accel0-probed RESULT=fail> * baseline.bootrr.cros-ec-sensors-accel1-probed: https://kernelci.org/test/case/id/5f79e0b3c7e9c47c1a4ff412 failing since 4 days (last pass: v5.4.68-384-g856fa448539c, first fail: v5.4.68-388-gcf92ab7a7853) 2020-10-04 14:48:12.300000 <8>[ 24.367838] <LAVA_SIGNAL_TESTCASE TEST_CASE_ID=cros-ec-sensors-accel1-probed RESULT=fail> * baseline.bootrr.cros-ec-sensors-gyro0-probed: https://kernelci.org/test/case/id/5f79e0b3c7e9c47c1a4ff413 failing since 4 days (last pass: v5.4.68-384-g856fa448539c, first fail: v5.4.68-388-gcf92ab7a7853) 2020-10-04 14:48:13.322000 <8>[ 25.389290] <LAVA_SIGNAL_TESTCASE TEST_CASE_ID=cros-ec-sensors-gyro0-probed RESULT=fail>

4 years, 3 months

1
0
0 0

[PATCH 4/7] ocfs2: Promote to unsigned long long before shifting

by Matthew Wilcox (Oracle)

On 32-bit systems, this shift will overflow for files larger than 4GB. Cc: stable(a)vger.kernel.org Fixes: 35edec1d52c0 ("ocfs2: update truncate handling of partial clusters") Signed-off-by: Matthew Wilcox (Oracle) <willy(a)infradead.org> --- fs/ocfs2/alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c index 4c1b90442d6f..26eff79ecb50 100644 --- a/fs/ocfs2/alloc.c +++ b/fs/ocfs2/alloc.c @@ -6867,7 +6867,7 @@ static void ocfs2_zero_cluster_pages(struct inode *inode, loff_t start, ocfs2_map_and_dirty_page(inode, handle, from, to, page, 1, &phys); - start = (page->index + 1) << PAGE_SHIFT; + start = (page->index + 1ULL) << PAGE_SHIFT; } out: if (pages) -- 2.28.0

4 years, 3 months

1
0
0 0

[PATCH 2/7] buffer: Promote to unsigned long long before shifting

by Matthew Wilcox (Oracle)

On 32-bit systems, this shift will overflow for files larger than 4GB. Cc: stable(a)vger.kernel.org Fixes: 5417169026c3 ("[FS] Implement block_page_mkwrite.") Signed-off-by: Matthew Wilcox (Oracle) <willy(a)infradead.org> --- fs/buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/buffer.c b/fs/buffer.c index 50bbc99e3d96..66f4765e60ee 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -2515,7 +2515,7 @@ int block_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf, } /* page is wholly or partially inside EOF */ - if (((page->index + 1) << PAGE_SHIFT) > size) + if (((page->index + 1ULL) << PAGE_SHIFT) > size) end = size & ~PAGE_MASK; else end = PAGE_SIZE; -- 2.28.0

4 years, 3 months

1
0
0 0

stable-rc/queue/5.8 baseline: 101 runs, 1 regressions (v5.8.13-23-g930d8bc68b5a)

by kernelci.org bot

stable-rc/queue/5.8 baseline: 101 runs, 1 regressions (v5.8.13-23-g930d8bc68b5a) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | results ----------------+-------+--------------+----------+-----------+-------- bcm2837-rpi-3-b | arm64 | lab-baylibre | gcc-8 | defconfig | 3/4 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F5.8/kernel/v5.8.13-2… Test: baseline Tree: stable-rc Branch: queue/5.8 Describe: v5.8.13-23-g930d8bc68b5a URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 930d8bc68b5af1572517260adc8bd29d2a8f0efa Test Regressions ---------------- platform | arch | lab | compiler | defconfig | results ----------------+-------+--------------+----------+-----------+-------- bcm2837-rpi-3-b | arm64 | lab-baylibre | gcc-8 | defconfig | 3/4 Details: https://kernelci.org/test/plan/id/5f79d5cd466c2348ff4ff3e0 Results: 3 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-8 (aarch64-linux-gnu-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-5.8/v5.8.13-23-g930d8bc68b5a/… HTML log: https://storage.kernelci.org//stable-rc/queue-5.8/v5.8.13-23-g930d8bc68b5a/… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-3-g27eeeac7… * baseline.dmesg.crit: https://kernelci.org/test/case/id/5f79d5cd466c2348ff4ff3e4 failing since 0 day (last pass: v5.8.12-99-g7910fecf197e, first fail: v5.8.13-3-g58c57ca2b2dd) 2 lines 2020-10-04 13:59:33.783000 Connected to bcm2837-rpi-3-b console [channel connected] (~$quit to exit) 2020-10-04 13:59:33.783000 (user:khilman) is already connected 2020-10-04 13:59:48.958000 2020-10-04 13:59:48.958000 2020-10-04 13:59:48.958000 U-Boot 2018.11 (Dec 04 2018 - 10:54:32 -0800) 2020-10-04 13:59:48.958000 2020-10-04 13:59:48.958000 DRAM: 948 MiB 2020-10-04 13:59:48.974000 RPI 3 Model B (0xa02082) 2020-10-04 13:59:49.060000 MMC: mmc@7e202000: 0, sdhci@7e300000: 1 2020-10-04 13:59:49.092000 Loading Environment from FAT... *** Warning - bad CRC, using default environment ... (387 line(s) more)

4 years, 3 months

1
0
0 0

stable-rc/queue/4.9 baseline: 59 runs, 1 regressions (v4.9.238-6-gba39fbe0586b)

by kernelci.org bot

stable-rc/queue/4.9 baseline: 59 runs, 1 regressions (v4.9.238-6-gba39fbe0586b) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | results ---------+------+---------------+----------+---------------------+-------- panda | arm | lab-collabora | gcc-8 | omap2plus_defconfig | 3/5 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F4.9/kernel/v4.9.238-… Test: baseline Tree: stable-rc Branch: queue/4.9 Describe: v4.9.238-6-gba39fbe0586b URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: ba39fbe0586b65f23ea817f1a3d09f16d302ba47 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | results ---------+------+---------------+----------+---------------------+-------- panda | arm | lab-collabora | gcc-8 | omap2plus_defconfig | 3/5 Details: https://kernelci.org/test/plan/id/5f79d1ff8d141b550a4ff3ee Results: 3 PASS, 1 FAIL, 1 SKIP Full config: omap2plus_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.238-6-gba39fbe0586b/… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.238-6-gba39fbe0586b/… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-3-g27eeeac7… * baseline.dmesg.emerg: https://kernelci.org/test/case/id/5f79d1ff8d141b550a4ff3f5 failing since 0 day (last pass: v4.9.238-4-ge285c292897c, first fail: v4.9.238-2-ga41cdac0290c) 2 lines

4 years, 3 months

1
0
0 0

stable-rc/queue/4.4 baseline: 87 runs, 6 regressions (v4.4.238-3-g44c1a5097bba)

by kernelci.org bot

stable-rc/queue/4.4 baseline: 87 runs, 6 regressions (v4.4.238-3-g44c1a5097bba) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | results ----------+------+---------------+----------+---------------------+-------- beagle-xm | arm | lab-baylibre | gcc-8 | omap2plus_defconfig | 1/4 panda | arm | lab-collabora | gcc-8 | omap2plus_defconfig | 3/5 peach-pi | arm | lab-collabora | gcc-8 | exynos_defconfig | 80/132 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F4.4/kernel/v4.4.238-… Test: baseline Tree: stable-rc Branch: queue/4.4 Describe: v4.4.238-3-g44c1a5097bba URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 44c1a5097bbad5cb5a86e30f46e29995d38af7e9 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | results ----------+------+---------------+----------+---------------------+-------- beagle-xm | arm | lab-baylibre | gcc-8 | omap2plus_defconfig | 1/4 Details: https://kernelci.org/test/plan/id/5f79c85145a391b1ef4ff41c Results: 1 PASS, 2 FAIL, 1 SKIP Full config: omap2plus_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.238-3-g44c1a5097bba/… HTML log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.238-3-g44c1a5097bba/… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-3-g27eeeac7… * baseline.dmesg.crit: https://kernelci.org/test/case/id/5f79c85145a391b1ef4ff420 new failure (last pass: v4.4.237-85-gcd7b2e899081) 1 lines 2020-10-04 13:02:25.660000 Connected to omap3-beagle-xm console [channel connected] (~$quit to exit) 2020-10-04 13:02:25.660000 (user:khilman) is already connected 2020-10-04 13:02:37.065000 2020-10-04 13:02:37.071000 U-Boot SPL 2018.09-rc2-00001-ge6aa9785acb2 (Aug 15 2018 - 09:41:52 -0700) 2020-10-04 13:02:37.076000 Trying to boot from MMC1 2020-10-04 13:02:37.265000 spl_load_image_fat_os: error reading image args, err - -2 2020-10-04 13:02:37.506000 2020-10-04 13:02:37.506000 2020-10-04 13:02:37.512000 U-Boot 2018.09-rc2-00001-ge6aa9785acb2 (Aug 15 2018 - 09:41:52 -0700) 2020-10-04 13:02:37.512000 ... (447 line(s) more) * baseline.dmesg.emerg: https://kernelci.org/test/case/id/5f79c85145a391b1ef4ff422 new failure (last pass: v4.4.237-85-gcd7b2e899081) 28 lines 2020-10-04 13:04:11.314000 kern :emerg : Stack: (0xcb995d10 to 0xcb996000) 2020-10-04 13:04:11.322000 kern :emerg : 5d00: bf02b8fc bf010b84 cb961010 bf02b988 2020-10-04 13:04:11.331000 kern :emerg : 5d20: cb961010 bf2200a8 00000002 cb8a6010 cb961010 bf246b54 cbbfa6f0 cbbfa6f0 2020-10-04 13:04:11.339000 kern :emerg : 5d40: 00000000 00000000 ce228930 c01fb3f0 ce228930 ce228930 c0859648 00000001 2020-10-04 13:04:11.347000 kern :emerg : 5d60: ce228930 cbbfa6f0 cbbfa7b0 00000000 ce228930 c0859648 00000001 c09632c0 2020-10-04 13:04:11.355000 kern :emerg : 5d80: ffffffed bf24aff4 fffffdfb 00000027 00000001 c00ce2e4 bf24b188 c0407090 2020-10-04 13:04:11.364000 kern :emerg : 5da0: c09632c0 c120ea30 bf24aff4 00000000 00000027 c0405564 c09632c0 c09632f4 2020-10-04 13:04:11.372000 kern :emerg : 5dc0: bf24aff4 00000000 00000000 c040570c 00000000 bf24aff4 c0405680 c0403a30 2020-10-04 13:04:11.380000 kern :emerg : 5de0: ce0b08a4 ce221910 bf24aff4 cbbde440 c09ddba8 c0404b7c bf249b6c c0960460 2020-10-04 13:04:11.388000 kern :emerg : 5e00: cbcdb200 bf24aff4 c0960460 cbcdb200 bf24e000 c0406144 c0960460 c0960460 ... (16 line(s) more) platform | arch | lab | compiler | defconfig | results ----------+------+---------------+----------+---------------------+-------- panda | arm | lab-collabora | gcc-8 | omap2plus_defconfig | 3/5 Details: https://kernelci.org/test/plan/id/5f79c84445a391b1ef4ff3f8 Results: 3 PASS, 1 FAIL, 1 SKIP Full config: omap2plus_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.238-3-g44c1a5097bba/… HTML log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.238-3-g44c1a5097bba/… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-3-g27eeeac7… * baseline.dmesg.emerg: https://kernelci.org/test/case/id/5f79c84445a391b1ef4ff3ff new failure (last pass: v4.4.237-85-gcd7b2e899081) 2 lines platform | arch | lab | compiler | defconfig | results ----------+------+---------------+----------+---------------------+-------- peach-pi | arm | lab-collabora | gcc-8 | exynos_defconfig | 80/132 Details: https://kernelci.org/test/plan/id/5f79c5d28568dad9414ff403 Results: 80 PASS, 51 FAIL, 1 SKIP Full config: exynos_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.238-3-g44c1a5097bba/… HTML log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.238-3-g44c1a5097bba/… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-3-g27eeeac7… * baseline.dmesg.crit: https://kernelci.org/test/case/id/5f79c5d28568dad9414ff487 new failure (last pass: v4.4.237-85-gcd7b2e899081) 1 lines 2020-10-04 12:51:44.563000 [Enter `^Ec?' for help] 2020-10-04 12:52:00.583000 2020-10-04 12:52:00.584000 2020-10-04 12:52:00.584000 U-Boot 2016.11 (Jan 07 2017 - 15:15:17 +0100) for Peach-Pi 2020-10-04 12:52:00.585000 2020-10-04 12:52:00.585000 CPU: Exynos5800 @ 1.8 GHz 2020-10-04 12:52:00.593000 Model: Samsung/Google Peach Pi board based on Exynos5800 2020-10-04 12:52:00.593000 Board: Samsung/Google Peach Pi board based on Exynos5800 2020-10-04 12:52:00.594000 DRAM: 3.5 GiB 2020-10-04 12:52:00.643000 EXYNOS_TMU: WARNING! Temperature sensing not done ... (662 line(s) more) * baseline.dmesg.alert: https://kernelci.org/test/case/id/5f79c5d28568dad9414ff488 new failure (last pass: v4.4.237-85-gcd7b2e899081) 4 lines 2020-10-04 12:52:43.339000 kern :alert : pgd = c0004000 2020-10-04 12:52:43.349000 kern :alert : [ffffffe0] *pgd=4fffd861, *pte=00000000, *ppte=00000000 2020-10-04 12:52:43.350000 kern :alert : Fixing recursive fault but reboot is needed! * baseline.dmesg.emerg: https://kernelci.org/test/case/id/5f79c5d28568dad9414ff489 new failure (last pass: v4.4.237-85-gcd7b2e899081) 39 lines 2020-10-04 12:52:43.372000 kern :emerg : Process irq/146-max9809 (pid: 1528, stack limit = 0xecc8e210) 2020-10-04 12:52:43.382000 kern :emerg : Stack: (0xecc8fec0 to 0xecc90000) 2020-10-04 12:52:43.383000 kern :emerg : fec0: ed5fb944 00000014 ed5fb944 60000013 00000008 edc78a00 00000014 c0036538 2020-10-04 12:52:43.394000 kern :emerg : fee0: 00000000 ed5fb910 ecc79a00 edeb3ca4 edeb3c80 c045568c 00000004 00000004 2020-10-04 12:52:43.406000 kern :emerg : ff00: edeb3c80 edead540 00000001 c0067b14 ffffe000 edead540 00000001 c0067e0c 2020-10-04 12:52:43.417000 kern :emerg : ff20: 00000000 c0067bf4 edeb3c80 00000000 edeb3cc0 ecc8e000 edeb3c80 c0067cc4 2020-10-04 12:52:43.417000 kern :emerg : ff40: 00000000 00000000 00000000 c003dd48 00000000 00000000 00000000 edeb3c80 2020-10-04 12:52:43.427000 kern :emerg : ff60: 00000000 00000000 dead4ead ffffffff ffffffff ecc8ff74 ecc8ff74 00000000 2020-10-04 12:52:43.438000 kern :emerg : ff80: 00000000 dead4ead ffffffff ffffffff ecc8ff90 ecc8ff90 edeb3cc0 c003dc40 2020-10-04 12:52:43.439000 kern :emerg : ffa0: 00000000 00000000 00000000 c000f650 00000000 00000000 00000000 00000000 ... (28 line(s) more)

4 years, 3 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror October 2020