September 2019 - Linux-stable-mirror

[PATCH 1/4] scsi: qla2xxx: Ignore NULL pointer in tcm_qla2xxx_free_mcmd

by Roman Bolshakov

If ABTS cannot be completed in target mode, the driver attempts to free related management command and crashes: NIP [d000000019181ee8] tcm_qla2xxx_free_mcmd+0x40/0x80 [tcm_qla2xxx] LR [d00000001dc1e6f8] qlt_response_pkt+0x190/0xa10 [qla2xxx] Call Trace: [c000003fff27bb50] [c000003fff27bc10] 0xc000003fff27bc10 (unreliable) [c000003fff27bb70] [d00000001dc1e6f8] qlt_response_pkt+0x190/0xa10 [qla2xxx] [c000003fff27bc10] [d00000001dbc2be0] qla24xx_process_response_queue+0x5d8/0xbd0 [qla2xxx] [c000003fff27bd50] [d00000001dbc632c] qla24xx_msix_rsp_q+0x64/0x150 [qla2xxx] [c000003fff27bde0] [c000000000187200] __handle_irq_event_percpu+0x90/0x310 [c000003fff27bea0] [c0000000001874b8] handle_irq_event_percpu+0x38/0x90 [c000003fff27bee0] [c000000000187574] handle_irq_event+0x64/0xb0 [c000003fff27bf10] [c00000000018cd38] handle_fasteoi_irq+0xe8/0x280 [c000003fff27bf40] [c000000000185ccc] generic_handle_irq+0x4c/0x70 [c000003fff27bf60] [c000000000016cec] __do_irq+0x7c/0x1d0 [c000003fff27bf90] [c00000000002a530] call_do_irq+0x14/0x24 [c00000207d2cba90] [c000000000016edc] do_IRQ+0x9c/0x130 [c00000207d2cbae0] [c000000000008bf4] hardware_interrupt_common+0x114/0x120 --- interrupt: 501 at arch_local_irq_restore+0x74/0x90 LR = arch_local_irq_restore+0x74/0x90 [c00000207d2cbdd0] [c0000000001c64fc] tick_broadcast_oneshot_control+0x4c/0x60 (unreliable) [c00000207d2cbdf0] [c0000000007ac840] cpuidle_enter_state+0xf0/0x450 [c00000207d2cbe50] [c00000000016b81c] call_cpuidle+0x4c/0x90 [c00000207d2cbe70] [c00000000016bc30] do_idle+0x2b0/0x330 [c00000207d2cbec0] [c00000000016beec] cpu_startup_entry+0x3c/0x50 [c00000207d2cbef0] [c00000000004a06c] start_secondary+0x63c/0x670 [c00000207d2cbf90] [c00000000000aa6c] start_secondary_prolog+0x10/0x14 The crash can be triggered by ACL deletion when there's active I/O. During ACL deletion, qla2xxx performs implicit LOGO that's invisible for the initiator. Only the driver and firmware are aware of the logout. Therefore the initiator continues to send SCSI commands and the target always responds with SAM STATUS BUSY as it can't find the session. The command times out after a while and initiator invokes ABORT TASK TMF for the command. The TMF is mapped to ABTS-LS in FCP. The target can't find session for S_ID originating ABTS-LS so it never allocates mcmd. And since N_Port handle was deleted after LOGO, it is no longer valid and ABTS Response IOCB is returned from firmware with status 31. Then free_mcmd is invoked on NULL pointer and the kernel crashes. [ 7734.578642] qla2xxx [0000:00:0c.0]-e837:6: ABTS_RECV_24XX: instance 0 [ 7734.578644] qla2xxx [0000:00:0c.0]-f811:6: qla_target(0): task abort (s_id=1:2:0, tag=1209504, param=0) [ 7734.578645] find_sess_by_s_id: 0x010200 [ 7734.578645] Unable to locate s_id: 0x010200 [ 7734.578646] qla2xxx [0000:00:0c.0]-f812:6: qla_target(0): task abort for non-existent session [ 7734.578648] qla2xxx [0000:00:0c.0]-e806:6: Sending task mgmt ABTS response (ha=c0000000d5819000, atio=c0000000d3fd4700, status=4 [ 7734.578730] qla2xxx [0000:00:0c.0]-e838:6: ABTS_RESP_24XX: compl_status 31 [ 7734.578732] qla2xxx [0000:00:0c.0]-e863:6: qla_target(0): ABTS_RESP_24XX failed 31 (subcode 19:a) [ 7734.578740] Unable to handle kernel paging request for data at address 0x00000200 Fixes: 6b0431d6fa20b ("scsi: qla2xxx: Fix out of order Termination and ABTS response") Cc: Quinn Tran <qtran(a)marvell.com> Cc: Himanshu Madhani <hmadhani(a)marvell.com> Cc: Bart Van Assche <bvanassche(a)acm.org> Cc: stable(a)vger.kernel.org Signed-off-by: Roman Bolshakov <r.bolshakov(a)yadro.com> --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c index 042a24314edc..bab2073c1f72 100644 --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c @@ -246,6 +246,8 @@ static void tcm_qla2xxx_complete_mcmd(struct work_struct *work) */ static void tcm_qla2xxx_free_mcmd(struct qla_tgt_mgmt_cmd *mcmd) { + if (!mcmd) + return; INIT_WORK(&mcmd->free_work, tcm_qla2xxx_complete_mcmd); queue_work(tcm_qla2xxx_free_wq, &mcmd->free_work); } -- 2.22.0

5 years, 4 months

1
0
0 0

✅ PASS: Test report for kernel 5.2.15-rc1-fda5311.cki (stable)

by CKI Project

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: fda53119ddbd - Linux 5.2.15-rc1 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK All kernel binaries, config files, and logs are available for download here: https://artifacts.cki-project.org/pipelines/157981 Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 3 architectures: aarch64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ✅ Boot test [0] ✅ xfstests: ext4 [1] ✅ xfstests: xfs [1] ✅ selinux-policy: serge-testsuite [2] ✅ lvm thinp sanity [3] ✅ storage: software RAID testing [4] 🚧 ✅ Storage blktests [5] Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test [0] ✅ Podman system integration test (as root) [6] ✅ Podman system integration test (as user) [6] ⚡⚡⚡ Loopdev Sanity [7] ✅ jvm test suite [8] ✅ Memory function: memfd_create [9] ✅ AMTU (Abstract Machine Test Utility) [10] ✅ LTP: openposix test suite [11] ✅ Ethernet drivers sanity [12] ✅ Networking socket: fuzz [13] ✅ Networking sctp-auth: sockopts test [14] ✅ Networking: igmp conformance test [15] ✅ Networking TCP: keepalive test [16] ✅ Networking UDP: socket [17] ✅ Networking tunnel: gre basic [18] ✅ Networking tunnel: vxlan basic [19] ✅ audit: audit testsuite test [20] ✅ httpd: mod_ssl smoke sanity [21] ✅ iotop: sanity [22] ✅ tuned: tune-processes-through-perf [23] ✅ Usex - version 1.9-29 [24] ✅ storage: SCSI VPD [25] ✅ stress: stress-ng [26] 🚧 ❌ LTP lite [27] 🚧 ✅ CIFS Connectathon [28] 🚧 ✅ Memory function: kaslr [29] 🚧 ✅ Networking bridge: sanity [30] 🚧 ✅ Networking MACsec: sanity [31] 🚧 ✅ Networking route: pmtu [32] 🚧 ✅ Networking tunnel: geneve basic test [33] 🚧 ✅ Networking vnic: ipvlan/basic [34] 🚧 ✅ ALSA PCM loopback test [35] 🚧 ✅ ALSA Control (mixer) Userspace Element test [36] 🚧 ✅ trace: ftrace/tracer [37] 🚧 ✅ Networking route_func: local [38] 🚧 ✅ Networking route_func: forward [38] 🚧 ✅ Networking ipsec: basic netns transport [39] 🚧 ✅ Networking ipsec: basic netns tunnel [39] ppc64le: Host 1: ✅ Boot test [0] ✅ xfstests: ext4 [1] ✅ xfstests: xfs [1] ✅ selinux-policy: serge-testsuite [2] ✅ lvm thinp sanity [3] ✅ storage: software RAID testing [4] 🚧 ✅ Storage blktests [5] Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test [0] ✅ Podman system integration test (as root) [6] ✅ Podman system integration test (as user) [6] ⚡⚡⚡ Loopdev Sanity [7] ✅ jvm test suite [8] ✅ Memory function: memfd_create [9] ✅ AMTU (Abstract Machine Test Utility) [10] ✅ LTP: openposix test suite [11] ✅ Ethernet drivers sanity [12] ✅ Networking socket: fuzz [13] ✅ Networking sctp-auth: sockopts test [14] ✅ Networking TCP: keepalive test [16] ✅ Networking UDP: socket [17] ✅ Networking tunnel: gre basic [18] ✅ Networking tunnel: vxlan basic [19] ✅ audit: audit testsuite test [20] ✅ httpd: mod_ssl smoke sanity [21] ✅ iotop: sanity [22] ✅ tuned: tune-processes-through-perf [23] ✅ Usex - version 1.9-29 [24] 🚧 ❌ LTP lite [27] 🚧 ✅ CIFS Connectathon [28] 🚧 ✅ Memory function: kaslr [29] 🚧 ✅ Networking bridge: sanity [30] 🚧 ✅ Networking MACsec: sanity [31] 🚧 ✅ Networking route: pmtu [32] 🚧 ✅ Networking tunnel: geneve basic test [33] 🚧 ⚡⚡⚡ Networking ipsec: basic netns tunnel [39] 🚧 ✅ Networking vnic: ipvlan/basic [34] 🚧 ✅ ALSA PCM loopback test [35] 🚧 ✅ ALSA Control (mixer) Userspace Element test [36] 🚧 ✅ trace: ftrace/tracer [37] 🚧 ✅ Networking route_func: local [38] 🚧 ✅ Networking route_func: forward [38] x86_64: Host 1: ✅ Boot test [0] ✅ Storage SAN device stress - mpt3sas driver [40] Host 2: ✅ Boot test [0] ✅ Storage SAN device stress - megaraid_sas [40] Host 3: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test [0] ✅ Podman system integration test (as root) [6] ✅ Podman system integration test (as user) [6] ⚡⚡⚡ Loopdev Sanity [7] ✅ jvm test suite [8] ✅ Memory function: memfd_create [9] ✅ AMTU (Abstract Machine Test Utility) [10] ✅ LTP: openposix test suite [11] ✅ Ethernet drivers sanity [12] ✅ Networking socket: fuzz [13] ✅ Networking sctp-auth: sockopts test [14] ✅ Networking: igmp conformance test [15] ✅ Networking TCP: keepalive test [16] ✅ Networking UDP: socket [17] ✅ Networking tunnel: gre basic [18] ✅ Networking tunnel: vxlan basic [19] ✅ audit: audit testsuite test [20] ✅ httpd: mod_ssl smoke sanity [21] ✅ iotop: sanity [22] ✅ tuned: tune-processes-through-perf [23] ✅ pciutils: sanity smoke test [41] ✅ Usex - version 1.9-29 [24] ✅ storage: SCSI VPD [25] ✅ stress: stress-ng [26] 🚧 ⚡⚡⚡ LTP lite [27] 🚧 ⚡⚡⚡ CIFS Connectathon [28] 🚧 ❌ Memory function: kaslr [29] 🚧 ✅ Networking bridge: sanity [30] 🚧 ✅ Networking MACsec: sanity [31] 🚧 ✅ Networking route: pmtu [32] 🚧 ✅ Networking tunnel: geneve basic test [33] 🚧 ✅ Networking vnic: ipvlan/basic [34] 🚧 ✅ ALSA PCM loopback test [35] 🚧 ✅ ALSA Control (mixer) Userspace Element test [36] 🚧 ✅ trace: ftrace/tracer [37] 🚧 ✅ Networking route_func: local [38] 🚧 ✅ Networking route_func: forward [38] 🚧 ✅ Networking ipsec: basic netns transport [39] 🚧 ✅ Networking ipsec: basic netns tunnel [39] Host 4: ✅ Boot test [0] ✅ xfstests: ext4 [1] ✅ xfstests: xfs [1] ✅ selinux-policy: serge-testsuite [2] ✅ lvm thinp sanity [3] ✅ storage: software RAID testing [4] 🚧 ✅ Storage blktests [5] 🚧 ✅ IOMMU boot test [42] Test source: 💚 Pull requests are welcome for new tests or improvements to existing tests! [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/lvm/… [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/swra… [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/blk [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/container/p… [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/jvm [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/memory/func… [10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [11]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [12]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [13]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [14]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/s… [15]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/i… [16]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/t… [17]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/u… [18]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [19]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [20]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [21]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [22]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [23]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [24]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… [25]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/scsi… [26]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres… [27]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [28]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [29]: https://github.com/CKI-project/tests-beaker/archive/master.zip#memory/funct… [30]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/b… [31]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/m… [32]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [33]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [34]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/v… [35]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/sound/aloop [36]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/sound/user-… [37]: https://github.com/CKI-project/tests-beaker/archive/master.zip#trace/ftrace… [38]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [39]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [40]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/hba/… [41]: https://github.com/CKI-project/tests-beaker/archive/master.zip#pciutils/san… [42]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/iommu/boot Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 4 months

1
0
0 0

[PATCH v3 2/3] powerpc: Avoid clang warnings around setjmp and longjmp

by Nathan Chancellor

Commit aea447141c7e ("powerpc: Disable -Wbuiltin-requires-header when setjmp is used") disabled -Wbuiltin-requires-header because of a warning about the setjmp and longjmp declarations. r367387 in clang added another diagnostic around this, complaining that there is no jmp_buf declaration. In file included from ../arch/powerpc/xmon/xmon.c:47: ../arch/powerpc/include/asm/setjmp.h:10:13: error: declaration of built-in function 'setjmp' requires the declaration of the 'jmp_buf' type, commonly provided in the header <setjmp.h>. [-Werror,-Wincomplete-setjmp-declaration] extern long setjmp(long *); ^ ../arch/powerpc/include/asm/setjmp.h:11:13: error: declaration of built-in function 'longjmp' requires the declaration of the 'jmp_buf' type, commonly provided in the header <setjmp.h>. [-Werror,-Wincomplete-setjmp-declaration] extern void longjmp(long *, long); ^ 2 errors generated. We are not using the standard library's longjmp/setjmp implementations for obvious reasons; make this clear to clang by using -ffreestanding on these files. Cc: stable(a)vger.kernel.org # 4.14+ Link: https://github.com/ClangBuiltLinux/linux/issues/625 Link: https://github.com/llvm/llvm-project/commit/3be25e79477db2d31ac46493d97eca8… Suggested-by: Segher Boessenkool <segher(a)kernel.crashing.org> Signed-off-by: Nathan Chancellor <natechancellor(a)gmail.com> --- v1 -> v3: * Use -ffreestanding instead of outright disabling the warning because it is legitimate. I skipped v2 because the first patch in the series already had a v2. arch/powerpc/kernel/Makefile | 4 ++-- arch/powerpc/xmon/Makefile | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile index c9cc4b689e60..19f19c8c874b 100644 --- a/arch/powerpc/kernel/Makefile +++ b/arch/powerpc/kernel/Makefile @@ -5,8 +5,8 @@ CFLAGS_ptrace.o += -DUTS_MACHINE='"$(UTS_MACHINE)"' -# Disable clang warning for using setjmp without setjmp.h header -CFLAGS_crash.o += $(call cc-disable-warning, builtin-requires-header) +# Avoid clang warnings around longjmp/setjmp declarations +CFLAGS_crash.o += -ffreestanding ifdef CONFIG_PPC64 CFLAGS_prom_init.o += $(NO_MINIMAL_TOC) diff --git a/arch/powerpc/xmon/Makefile b/arch/powerpc/xmon/Makefile index f142570ad860..c3842dbeb1b7 100644 --- a/arch/powerpc/xmon/Makefile +++ b/arch/powerpc/xmon/Makefile @@ -1,8 +1,8 @@ # SPDX-License-Identifier: GPL-2.0 # Makefile for xmon -# Disable clang warning for using setjmp without setjmp.h header -subdir-ccflags-y := $(call cc-disable-warning, builtin-requires-header) +# Avoid clang warnings around longjmp/setjmp declarations +subdir-ccflags-y := -ffreestanding GCOV_PROFILE := n KCOV_INSTRUMENT := n -- 2.23.0

5 years, 4 months

2
1
0 0

Product Order

by Nell, Mario, Dr [mdn＠sun.ac.za]

Hello Sir/Madam, We are interested in purchasing your products. Please send your catalog so we can make a quick purchase. Hope to hear from you soon. Best regards, Mrs. Juan Cheng | Sales manager SAH INDUSTRY&TRADE CO.,LTD No.4023, Wuhe Street, Bantian, Longgang District, Shenzhen, 518129, China [http://cdn.sun.ac.za/100/ProductionFooter.jpg]<http://www.sun.ac.za/english/about-us/strategic-documents> The integrity and confidentiality of this email are governed by these terms. Disclaimer<http://www.sun.ac.za/emaildisclaimer> Die integriteit en vertroulikheid van hierdie e-pos word deur die volgende bepalings bereël. Vrywaringsklousule<http://www.sun.ac.za/emaildisclaimer>

5 years, 4 months

1
0
0 0

[net-next v2 02/13] i40e: check __I40E_VF_DISABLE bit in i40e_sync_filters_subtask

by Jeff Kirsher

From: Stefan Assmann <sassmann(a)kpanic.de> While testing VF spawn/destroy the following panic occurred. BUG: unable to handle kernel NULL pointer dereference at 0000000000000029 [...] Workqueue: i40e i40e_service_task [i40e] RIP: 0010:i40e_sync_vsi_filters+0x6fd/0xc60 [i40e] [...] Call Trace: ? __switch_to_asm+0x35/0x70 ? __switch_to_asm+0x41/0x70 ? __switch_to_asm+0x35/0x70 ? _cond_resched+0x15/0x30 i40e_sync_filters_subtask+0x56/0x70 [i40e] i40e_service_task+0x382/0x11b0 [i40e] ? __switch_to_asm+0x41/0x70 ? __switch_to_asm+0x41/0x70 process_one_work+0x1a7/0x3b0 worker_thread+0x30/0x390 ? create_worker+0x1a0/0x1a0 kthread+0x112/0x130 ? kthread_bind+0x30/0x30 ret_from_fork+0x35/0x40 Investigation revealed a race where pf->vf[vsi->vf_id].trusted may get accessed by the watchdog via i40e_sync_filters_subtask() although i40e_free_vfs() already free'd pf->vf. To avoid this the call to i40e_sync_vsi_filters() in i40e_sync_filters_subtask() needs to be guarded by __I40E_VF_DISABLE, which is also used by i40e_free_vfs(). Note: put the __I40E_VF_DISABLE check after the __I40E_MACVLAN_SYNC_PENDING check as the latter is more likely to trigger. CC: stable(a)vger.kernel.org Signed-off-by: Stefan Assmann <sassmann(a)kpanic.de> Tested-by: Andrew Bowers <andrewx.bowers(a)intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher(a)intel.com> --- drivers/net/ethernet/intel/i40e/i40e_main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index e9f2f276bf27..3e2e465f43f9 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -2592,6 +2592,10 @@ static void i40e_sync_filters_subtask(struct i40e_pf *pf) return; if (!test_and_clear_bit(__I40E_MACVLAN_SYNC_PENDING, pf->state)) return; + if (test_and_set_bit(__I40E_VF_DISABLE, pf->state)) { + set_bit(__I40E_MACVLAN_SYNC_PENDING, pf->state); + return; + } for (v = 0; v < pf->num_alloc_vsi; v++) { if (pf->vsi[v] && @@ -2606,6 +2610,7 @@ static void i40e_sync_filters_subtask(struct i40e_pf *pf) } } } + clear_bit(__I40E_VF_DISABLE, pf->state); } /** -- 2.21.0

5 years, 4 months

1
0
0 0

[net 2/2] ixgbe: fix double clean of Tx descriptors with xdp

by Jeff Kirsher

From: Ilya Maximets <i.maximets(a)samsung.com> Tx code doesn't clear the descriptors' status after cleaning. So, if the budget is larger than number of used elems in a ring, some descriptors will be accounted twice and xsk_umem_complete_tx will move prod_tail far beyond the prod_head breaking the completion queue ring. Fix that by limiting the number of descriptors to clean by the number of used descriptors in the Tx ring. 'ixgbe_clean_xdp_tx_irq()' function refactored to look more like 'ixgbe_xsk_clean_tx_ring()' since we're allowed to directly use 'next_to_clean' and 'next_to_use' indexes. CC: stable(a)vger.kernel.org Fixes: 8221c5eba8c1 ("ixgbe: add AF_XDP zero-copy Tx support") Signed-off-by: Ilya Maximets <i.maximets(a)samsung.com> Tested-by: William Tu <u9012063(a)gmail.com> Tested-by: Eelco Chaudron <echaudro(a)redhat.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher(a)intel.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 29 ++++++++------------ 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c index 6b609553329f..a3b6d8c89127 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c @@ -633,19 +633,17 @@ static void ixgbe_clean_xdp_tx_buffer(struct ixgbe_ring *tx_ring, bool ixgbe_clean_xdp_tx_irq(struct ixgbe_q_vector *q_vector, struct ixgbe_ring *tx_ring, int napi_budget) { + u16 ntc = tx_ring->next_to_clean, ntu = tx_ring->next_to_use; unsigned int total_packets = 0, total_bytes = 0; - u32 i = tx_ring->next_to_clean, xsk_frames = 0; - unsigned int budget = q_vector->tx.work_limit; struct xdp_umem *umem = tx_ring->xsk_umem; union ixgbe_adv_tx_desc *tx_desc; struct ixgbe_tx_buffer *tx_bi; - bool xmit_done; + u32 xsk_frames = 0; - tx_bi = &tx_ring->tx_buffer_info[i]; - tx_desc = IXGBE_TX_DESC(tx_ring, i); - i -= tx_ring->count; + tx_bi = &tx_ring->tx_buffer_info[ntc]; + tx_desc = IXGBE_TX_DESC(tx_ring, ntc); - do { + while (ntc != ntu) { if (!(tx_desc->wb.status & cpu_to_le32(IXGBE_TXD_STAT_DD))) break; @@ -661,22 +659,18 @@ bool ixgbe_clean_xdp_tx_irq(struct ixgbe_q_vector *q_vector, tx_bi++; tx_desc++; - i++; - if (unlikely(!i)) { - i -= tx_ring->count; + ntc++; + if (unlikely(ntc == tx_ring->count)) { + ntc = 0; tx_bi = tx_ring->tx_buffer_info; tx_desc = IXGBE_TX_DESC(tx_ring, 0); } /* issue prefetch for next Tx descriptor */ prefetch(tx_desc); + } - /* update budget accounting */ - budget--; - } while (likely(budget)); - - i += tx_ring->count; - tx_ring->next_to_clean = i; + tx_ring->next_to_clean = ntc; u64_stats_update_begin(&tx_ring->syncp); tx_ring->stats.bytes += total_bytes; @@ -688,8 +682,7 @@ bool ixgbe_clean_xdp_tx_irq(struct ixgbe_q_vector *q_vector, if (xsk_frames) xsk_umem_complete_tx(umem, xsk_frames); - xmit_done = ixgbe_xmit_zc(tx_ring, q_vector->tx.work_limit); - return budget > 0 && xmit_done; + return ixgbe_xmit_zc(tx_ring, q_vector->tx.work_limit); } int ixgbe_xsk_async_xmit(struct net_device *dev, u32 qid) -- 2.21.0

5 years, 4 months

1
0
0 0

[net 1/2] ixgbe: Prevent u8 wrapping of ITR value to something less than 10us

by Jeff Kirsher

From: Alexander Duyck <alexander.h.duyck(a)linux.intel.com> There were a couple cases where the ITR value generated via the adaptive ITR scheme could exceed 126. This resulted in the value becoming either 0 or something less than 10. Switching back and forth between a value less than 10 and a value greater than 10 can cause issues as certain hardware features such as RSC to not function well when the ITR value has dropped that low. CC: stable(a)vger.kernel.org Fixes: b4ded8327fea ("ixgbe: Update adaptive ITR algorithm") Reported-by: Gregg Leventhal <gleventhal(a)janestreet.com> Signed-off-by: Alexander Duyck <alexander.h.duyck(a)linux.intel.com> Tested-by: Andrew Bowers <andrewx.bowers(a)intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher(a)intel.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 7882148abb43..77ca9005dc41 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -2621,7 +2621,7 @@ static void ixgbe_update_itr(struct ixgbe_q_vector *q_vector, /* 16K ints/sec to 9.2K ints/sec */ avg_wire_size *= 15; avg_wire_size += 11452; - } else if (avg_wire_size <= 1980) { + } else if (avg_wire_size < 1968) { /* 9.2K ints/sec to 8K ints/sec */ avg_wire_size *= 5; avg_wire_size += 22420; @@ -2654,6 +2654,8 @@ static void ixgbe_update_itr(struct ixgbe_q_vector *q_vector, case IXGBE_LINK_SPEED_2_5GB_FULL: case IXGBE_LINK_SPEED_1GB_FULL: case IXGBE_LINK_SPEED_10_FULL: + if (avg_wire_size > 8064) + avg_wire_size = 8064; itr += DIV_ROUND_UP(avg_wire_size, IXGBE_ITR_ADAPTIVE_MIN_INC * 64) * IXGBE_ITR_ADAPTIVE_MIN_INC; -- 2.21.0

5 years, 4 months

1
0
0 0

Re: Patch "ALSA: pcm: Return 0 when size < start_threshold in capture" has been added to the 4.19-stable tree

by Ricardo Biehl Pasquali

On Wed, Sep 11, 2019 at 05:30:33AM -0400, Sasha Levin wrote: > This is a note to let you know that I've just added the patch titled > > ALSA: pcm: Return 0 when size < start_threshold in capture > > to the 4.19-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… > > The filename of the patch is: > alsa-pcm-return-0-when-size-start_threshold-in-captu.patch > and it can be found in the queue-4.19 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let <stable(a)vger.kernel.org> know about it. Hi Sasha. This patch was reverted by the commit 932a81519572156a88db ("ALSA: pcm: Comment why read blocks when PCM is not running"): This avoids bringing back the problem introduced by 62ba568f7aef ("ALSA: pcm: Return 0 when size < start_threshold in capture") and fixed in 00a399cad1a0 ("ALSA: pcm: Revert capture stream behavior change in blocking mode"), which prevented the user from starting capture from another thread. Should this be queued anyway? If yes, I think it should also be queued the fix and the commit above. pasquali

5 years, 4 months

2
2
0 0

stable-rc/linux-4.9.y boot: 108 boots: 0 failed, 100 passed with 8 offline (v4.9.192-13-g16ee77790651)

by kernelci.org bot

stable-rc/linux-4.9.y boot: 108 boots: 0 failed, 100 passed with 8 offline (v4.9.192-13-g16ee77790651) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.9.y/kernel/v4.9.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.9.y/kernel/v4.9.192-13-… Tree: stable-rc Branch: linux-4.9.y Git Describe: v4.9.192-13-g16ee77790651 Git Commit: 16ee777906517071e80ccaf459debe0f51ba75e7 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 55 unique boards, 22 SoC families, 14 builds out of 197 Offline Platforms: arm64: defconfig: gcc-8 apq8016-sbc: 1 offline lab arm: multi_v7_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab qcom-apq8064-ifc6410: 1 offline lab sun5i-r8-chip: 1 offline lab davinci_all_defconfig: gcc-8 dm365evm,legacy: 1 offline lab qcom_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab qcom-apq8064-ifc6410: 1 offline lab sunxi_defconfig: gcc-8 sun5i-r8-chip: 1 offline lab --- For more info write to <info(a)kernelci.org>

5 years, 4 months

1
0
0 0

stable-rc/linux-4.14.y boot: 123 boots: 0 failed, 114 passed with 9 offline (v4.14.143-20-g570d97484537)

by kernelci.org bot

stable-rc/linux-4.14.y boot: 123 boots: 0 failed, 114 passed with 9 offline (v4.14.143-20-g570d97484537) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.14.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.14.y/kernel/v4.14.143-2… Tree: stable-rc Branch: linux-4.14.y Git Describe: v4.14.143-20-g570d97484537 Git Commit: 570d97484537c5a83b2e252ad55e56f1749d8c6e Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 66 unique boards, 23 SoC families, 13 builds out of 201 Offline Platforms: arm64: defconfig: gcc-8 apq8016-sbc: 1 offline lab arm: multi_v7_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab qcom-apq8064-ifc6410: 1 offline lab sun5i-r8-chip: 1 offline lab davinci_all_defconfig: gcc-8 dm365evm,legacy: 1 offline lab qcom_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab qcom-apq8064-ifc6410: 1 offline lab sunxi_defconfig: gcc-8 sun5i-r8-chip: 1 offline lab sun7i-a20-bananapi: 1 offline lab --- For more info write to <info(a)kernelci.org>

5 years, 4 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror September 2019