September 2019 - Linux-stable-mirror

Re: [PATCH 1/4] spi: mxic: Fix transmit path

by Mark Brown

On Thu, Sep 19, 2019 at 10:25:01PM +0200, Miquel Raynal wrote: > In certain circumstances, it is needed to check INT_TX_EMPTY and > INT_RX_NOT_EMPTY in the transmit path, not only in the receive > path. In both cases, the delay penalty is negligible. In which circumstances and why is this required?

5 years, 3 months

1
0
0 0

Re: [tip: timers/urgent] timer: Read jiffies once when forwarding base clk

by Thomas Gleixner

On Thu, 19 Sep 2019, Sasha Levin wrote: > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 236968383cf5 timers: Optimize collect_expired_timers() for NOHZ. > > The bot has tested the following trees: v5.2.15, v4.19.73, v4.14.144, v4.9.193. > > v5.2.15: Build OK! > v4.19.73: Build OK! > v4.14.144: Failed to apply! Possible dependencies: > c310ce4dcb9d ("timers: Avoid an unnecessary iteration in __run_timers()") > > v4.9.193: Failed to apply! Possible dependencies: > c310ce4dcb9d ("timers: Avoid an unnecessary iteration in __run_timers()") > > > NOTE: The patch will not be queued to stable trees until it is upstream. > > How should we proceed with this patch? The backport should be trivial. If you need help, please let me know. Thanks, tglx

5 years, 3 months

1
0
0 0

[PATCH] platform/x86: i2c-multi-instantiate: Derive the device name from parent

by Heikki Krogerus

When naming the new devices, instead of using the ACPI ID in the name as base, using the parent device's name. That makes it possible to support multiple multi-instance i2c devices of the same type in the same system. This fixes an issue seen on some Intel Kaby Lake based boards: sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-0/i2c-INT3515-tps6598x.0' Fixes: 2336dfadfb1e ("platform/x86: i2c-multi-instantiate: Allow to have same slaves") Cc: stable(a)vger.kernel.org Signed-off-by: Heikki Krogerus <heikki.krogerus(a)linux.intel.com> --- drivers/platform/x86/i2c-multi-instantiate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/i2c-multi-instantiate.c b/drivers/platform/x86/i2c-multi-instantiate.c index 61fe341a85aa..ea68f6ed66ae 100644 --- a/drivers/platform/x86/i2c-multi-instantiate.c +++ b/drivers/platform/x86/i2c-multi-instantiate.c @@ -90,7 +90,7 @@ static int i2c_multi_inst_probe(struct platform_device *pdev) for (i = 0; i < multi->num_clients && inst_data[i].type; i++) { memset(&board_info, 0, sizeof(board_info)); strlcpy(board_info.type, inst_data[i].type, I2C_NAME_SIZE); - snprintf(name, sizeof(name), "%s-%s.%d", match->id, + snprintf(name, sizeof(name), "%s-%s.%d", dev_name(dev), inst_data[i].type, i); board_info.dev_name = name; switch (inst_data[i].flags & IRQ_RESOURCE_TYPE) { -- 2.23.0

5 years, 3 months

2
1
0 0

✅ PASS: Stable queue: queue-5.2

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 1e2ba4a74fa7 - Linux 5.2.16 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK All kernel binaries, config files, and logs are available for download here: https://artifacts.cki-project.org/pipelines/175260 Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 1e2ba4a74fa7 - Linux 5.2.16 We grabbed the 5d06de98f77f commit of the stable queue repository. We then merged the patchset with `git am`: usb-usbcore-fix-slab-out-of-bounds-bug-during-device-reset.patch media-tm6000-double-free-if-usb-disconnect-while-streaming.patch phy-renesas-rcar-gen3-usb2-disable-clearing-vbus-in-over-current.patch net-hns3-adjust-hns3_uninit_phy-s-location-in-the-hns3_client_uninit.patch netfilter-nf_flow_table-set-default-timeout-after-successful-insertion.patch hid-wacom-generic-read-hid_dg_contactmax-from-any-feature-report.patch input-elan_i2c-remove-lenovo-legion-y7000-pnpid.patch sunrpc-handle-connection-breakages-correctly-in-call_status.patch media-stm32-dcmi-fix-irq-0-case.patch nfs-disable-client-side-deduplication.patch powerpc-mm-radix-use-the-right-page-size-for-vmemmap-mapping.patch scripts-decode_stacktrace-match-basepath-using-shell-prefix-operator-not-regex.patch net-hns-fix-led-configuration-for-marvell-phy.patch net-aquantia-fix-limit-of-vlan-filters.patch ip6_gre-fix-a-dst-leak-in-ip6erspan_tunnel_xmit.patch net-sched-fix-race-between-deactivation-and-dequeue-for-nolock-qdisc.patch net_sched-let-qdisc_put-accept-null-pointer.patch udp-correct-reuseport-selection-with-connected-sockets.patch xen-netfront-do-not-assume-sk_buff_head-list-is-empty-in-error-handling.patch net-dsa-fix-load-order-between-dsa-drivers-and-taggers.patch kvm-coalesced_mmio-add-bounds-checking.patch firmware-google-check-if-size-is-valid-when-decoding-vpd-data.patch serial-sprd-correct-the-wrong-sequence-of-arguments.patch tty-serial-atmel-reschedule-tx-after-rx-was-started.patch mwifiex-fix-three-heap-overflow-at-parsing-element-in-cfg80211_ap_settings.patch nl80211-fix-possible-spectre-v1-for-cqm-rssi-thresholds.patch ieee802154-hwsim-fix-error-handle-path-in-hwsim_init.patch ieee802154-hwsim-unregister-hw-while-hwsim_subscribe.patch arm-dts-am57xx-disable-voltage-switching-for-sd-card.patch arm-omap2-fix-missing-sysc_has_reset_status-for-dra7.patch bus-ti-sysc-fix-handling-of-forced-idle.patch bus-ti-sysc-fix-using-configured-sysc-mask-value.patch arm-dts-fix-flags-for-gpio7.patch arm-dts-fix-incorrect-dcan-register-mapping-for-am3-.patch arm64-dts-meson-g12a-add-missing-dwc2-phy-names.patch s390-bpf-fix-lcgr-instruction-encoding.patch arm-omap2-fix-omap4-errata-warning-on-other-socs.patch arm-dts-am335x-fix-uarts-length.patch arm-dts-dra74x-fix-iodelay-configuration-for-mmc3.patch arm-omap1-ams-delta-fiq-fix-missing-irq_ack.patch bus-ti-sysc-simplify-cleanup-upon-failures-in-sysc_p.patch arm-dts-fix-incomplete-dts-data-for-am3-and-am4-mmc.patch s390-bpf-use-32-bit-index-for-tail-calls.patch selftests-bpf-fix-bind-4-6-deny-specific-ip-port-on-.patch tools-bpftool-close-prog-fd-before-exit-on-showing-a.patch fpga-altera-ps-spi-fix-getting-of-optional-confd-gpi.patch netfilter-ebtables-fix-argument-order-to-add_counter.patch netfilter-nft_flow_offload-missing-netlink-attribute.patch netfilter-xt_nfacct-fix-alignment-mismatch-in-xt_nfa.patch nfsv4-fix-return-values-for-nfs4_file_open.patch nfsv4-fix-return-value-in-nfs_finish_open.patch nfs-fix-initialisation-of-i-o-result-struct-in-nfs_p.patch nfs-on-fatal-writeback-errors-we-need-to-call-nfs_in.patch kconfig-fix-the-reference-to-the-idt77105-phy-driver.patch xdp-unpin-xdp-umem-pages-in-error-path.patch selftests-bpf-fix-test_cgroup_storage-on-s390.patch selftests-bpf-add-config-fragment-bpf_jit.patch qed-add-cleanup-in-qed_slowpath_start.patch drm-omap-fix-port-lookup-for-sdi-output.patch drm-virtio-use-virtio_max_dma_size.patch arm-8874-1-mm-only-adjust-sections-of-valid-mm-struc.patch batman-adv-only-read-ogm2-tvlv_len-after-buffer-len-.patch flow_dissector-fix-potential-use-after-free-on-bpf_p.patch bpf-allow-narrow-loads-of-some-sk_reuseport_md-field.patch r8152-set-memory-to-all-0xffs-on-failed-reg-reads.patch x86-apic-fix-arch_dynirq_lower_bound-bug-for-dt-enab.patch pnfs-flexfiles-don-t-time-out-requests-on-hard-mount.patch nfs-fix-spurious-eio-read-errors.patch nfs-fix-writepage-s-error-handling-to-not-report-err.patch drm-amdgpu-fix-dma_fence_wait-without-reference.patch netfilter-xt_physdev-fix-spurious-error-message-in-p.patch netfilter-nf_conntrack_ftp-fix-debug-output.patch nfsv2-fix-eof-handling.patch nfsv2-fix-write-regression.patch nfs-remove-set-but-not-used-variable-mapping.patch kallsyms-don-t-let-kallsyms_lookup_size_offset-fail-.patch netfilter-conntrack-make-sysctls-per-namespace-again.patch drm-amd-powerplay-correct-vega20-dpm-level-related-s.patch cifs-set-domainname-when-a-domain-key-is-used-in-mul.patch cifs-use-kzfree-to-zero-out-the-password.patch libceph-don-t-call-crypto_free_sync_skcipher-on-a-nu.patch usb-host-xhci-tegra-set-dma-mask-correctly.patch risc-v-fix-fixmap-area-corruption-on-rv32-systems.patch arm-8901-1-add-a-criteria-for-pfn_valid-of-arm.patch ibmvnic-do-not-process-reset-during-or-after-device-.patch sky2-disable-msi-on-yet-another-asus-boards-p6xxxx.patch i2c-designware-synchronize-irqs-when-unregistering-s.patch perf-x86-intel-restrict-period-on-nehalem.patch perf-x86-amd-ibs-fix-sample-bias-for-dispatched-micr.patch i2c-iproc-stop-advertising-support-of-smbus-quick-cm.patch i2c-mediatek-disable-zero-length-transfers-for-mt818.patch amd-xgbe-fix-error-path-in-xgbe_mod_init.patch netfilter-nf_flow_table-clear-skb-tstamp-before-xmit.patch tools-power-x86_energy_perf_policy-fix-uninitialized.patch tools-power-x86_energy_perf_policy-fix-argument-pars.patch tools-power-turbostat-fix-leak-of-file-descriptor-on.patch tools-power-turbostat-fix-file-descriptor-leaks.patch tools-power-turbostat-fix-buffer-overrun.patch tools-power-turbostat-fix-haswell-core-systems.patch tools-power-turbostat-add-ice-lake-nnpi-support.patch tools-power-turbostat-fix-cpu-c1-display-value.patch net-aquantia-fix-removal-of-vlan-0.patch net-aquantia-reapply-vlan-filters-on-up.patch net-aquantia-linkstate-irq-should-be-oneshot.patch net-aquantia-fix-out-of-memory-condition-on-rx-side.patch net-dsa-microchip-add-ksz8563-compatibility-string.patch enetc-add-missing-call-to-pci_free_irq_vectors-in-pr.patch net-seeq-fix-the-function-used-to-release-some-memor.patch arm64-dts-renesas-r8a77995-draak-fix-backlight-regul.patch dmaengine-ti-dma-crossbar-fix-a-memory-leak-bug.patch dmaengine-ti-omap-dma-add-cleanup-in-omap_dma_probe.patch x86-uaccess-don-t-leak-the-ac-flags-into-__get_user-.patch x86-hyper-v-fix-overflow-bug-in-fill_gva_list.patch iommu-vt-d-remove-global-page-flush-support.patch dmaengine-sprd-fix-the-dma-link-list-configuration.patch dmaengine-rcar-dmac-fix-dmachclr-handling-if-iommu-i.patch keys-fix-missing-null-pointer-check-in-request_key_a.patch iommu-amd-flush-old-domains-in-kdump-kernel.patch iommu-amd-fix-race-in-increase_address_space.patch revert-arm64-remove-unnecessary-isbs-from-set_-pte-pmd-pud.patch ovl-fix-regression-caused-by-overlapping-layers-detection.patch floppy-fix-usercopy-direction.patch Compile testing --------------- We compiled the kernel for 3 architectures: aarch64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ppc64le: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. x86_64: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. Test sources: https://github.com/CKI-project/tests-beaker 💚 Pull requests are welcome for new tests or improvements to existing tests! Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 3 months

2
1
0 0

[PATCH v2 2/3] seccomp: avoid overflow in implicit constant conversion

by Christian Brauner

USER_NOTIF_MAGIC is assigned to int variables in this test so set it to INT_MAX to avoid warnings: seccomp_bpf.c: In function ‘user_notification_continue’: seccomp_bpf.c:3088:26: warning: overflow in implicit constant conversion [-Woverflow] #define USER_NOTIF_MAGIC 116983961184613L ^ seccomp_bpf.c:3572:15: note: in expansion of macro ‘USER_NOTIF_MAGIC’ resp.error = USER_NOTIF_MAGIC; ^~~~~~~~~~~~~~~~ Fixes: 6a21cc50f0c7 ("seccomp: add a return code to trap to userspace") Signed-off-by: Christian Brauner <christian.brauner(a)ubuntu.com> Reviewed-by: Tyler Hicks <tyhicks(a)canonical.com> Cc: Kees Cook <keescook(a)chromium.org> Cc: Andy Lutomirski <luto(a)amacapital.net> Cc: Will Drewry <wad(a)chromium.org> Cc: Shuah Khan <shuah(a)kernel.org> Cc: Alexei Starovoitov <ast(a)kernel.org> Cc: Daniel Borkmann <daniel(a)iogearbox.net> Cc: Martin KaFai Lau <kafai(a)fb.com> Cc: Song Liu <songliubraving(a)fb.com> Cc: Yonghong Song <yhs(a)fb.com> Cc: Tycho Andersen <tycho(a)tycho.ws> Cc: stable(a)vger.kernel.org Cc: linux-kselftest(a)vger.kernel.org Cc: netdev(a)vger.kernel.org Cc: bpf(a)vger.kernel.org --- /* v2 */ unchanged /* v1 */ Link: https://lore.kernel.org/r/20190919095903.19370-3-christian.brauner@ubuntu.c… unchanged /* v0 */ Link: https://lore.kernel.org/r/20190918084833.9369-4-christian.brauner@ubuntu.com --- tools/testing/selftests/seccomp/seccomp_bpf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c index 6ef7f16c4cf5..e996d7b7fd6e 100644 --- a/tools/testing/selftests/seccomp/seccomp_bpf.c +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c @@ -35,6 +35,7 @@ #include <stdbool.h> #include <string.h> #include <time.h> +#include <limits.h> #include <linux/elf.h> #include <sys/uio.h> #include <sys/utsname.h> @@ -3072,7 +3073,7 @@ static int user_trap_syscall(int nr, unsigned int flags) return seccomp(SECCOMP_SET_MODE_FILTER, flags, &prog); } -#define USER_NOTIF_MAGIC 116983961184613L +#define USER_NOTIF_MAGIC INT_MAX TEST(user_notification_basic) { pid_t pid; -- 2.23.0

5 years, 3 months

2
1
0 0

✅ PASS: Test report for kernel 5.3.1-rc1-0aa7f3d.cki (stable)

by CKI Project

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: 0aa7f3d6baae - Linux 5.3.1-rc1 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK All kernel binaries, config files, and logs are available for download here: https://artifacts.cki-project.org/pipelines/175799 Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 3 architectures: aarch64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ppc64le: Host 1: ✅ Boot test ✅ Podman system integration test (as root) ✅ Podman system integration test (as user) ✅ Loopdev Sanity ✅ jvm test suite ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ LTP: openposix test suite ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking sctp-auth: sockopts test ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: gre basic ✅ Networking tunnel: vxlan basic ✅ audit: audit testsuite test ✅ httpd: mod_ssl smoke sanity ✅ iotop: sanity ✅ tuned: tune-processes-through-perf ✅ Usex - version 1.9-29 🚧 ✅ LTP lite 🚧 ✅ CIFS Connectathon 🚧 ✅ Memory function: kaslr 🚧 ✅ Networking bridge: sanity 🚧 ✅ Networking MACsec: sanity 🚧 ✅ Networking route: pmtu 🚧 ✅ Networking tunnel: geneve basic test 🚧 ✅ Networking ipsec: basic netns tunnel 🚧 ✅ Networking vnic: ipvlan/basic 🚧 ✅ ALSA PCM loopback test 🚧 ✅ ALSA Control (mixer) Userspace Element test 🚧 ✅ trace: ftrace/tracer 🚧 ✅ Networking route_func: local 🚧 ✅ Networking route_func: forward Host 2: ✅ Boot test ✅ xfstests: ext4 ✅ xfstests: xfs ✅ selinux-policy: serge-testsuite ✅ lvm thinp sanity ✅ storage: software RAID testing 🚧 ✅ Storage blktests x86_64: Host 1: ✅ Boot test ✅ Storage SAN device stress - megaraid_sas Host 2: ✅ Boot test ✅ Storage SAN device stress - mpt3sas driver Host 3: ✅ Boot test ✅ Podman system integration test (as root) ✅ Podman system integration test (as user) ✅ Loopdev Sanity ✅ jvm test suite ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ LTP: openposix test suite ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking sctp-auth: sockopts test ✅ Networking: igmp conformance test ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: gre basic ✅ Networking tunnel: vxlan basic ✅ audit: audit testsuite test ✅ httpd: mod_ssl smoke sanity ✅ iotop: sanity ✅ tuned: tune-processes-through-perf ✅ pciutils: sanity smoke test ✅ Usex - version 1.9-29 ✅ storage: SCSI VPD ✅ stress: stress-ng 🚧 ✅ LTP lite 🚧 ✅ CIFS Connectathon 🚧 ✅ Memory function: kaslr 🚧 ✅ Networking bridge: sanity 🚧 ✅ Networking MACsec: sanity 🚧 ✅ Networking route: pmtu 🚧 ✅ Networking tunnel: geneve basic test 🚧 ✅ Networking vnic: ipvlan/basic 🚧 ✅ ALSA PCM loopback test 🚧 ✅ ALSA Control (mixer) Userspace Element test 🚧 ✅ trace: ftrace/tracer 🚧 ✅ Networking route_func: local 🚧 ✅ Networking route_func: forward 🚧 ✅ Networking ipsec: basic netns transport 🚧 ✅ Networking ipsec: basic netns tunnel Host 4: ✅ Boot test ✅ xfstests: ext4 ✅ xfstests: xfs ✅ selinux-policy: serge-testsuite ✅ lvm thinp sanity ✅ storage: software RAID testing 🚧 ✅ Storage blktests 🚧 ✅ IOMMU boot test Test sources: https://github.com/CKI-project/tests-beaker 💚 Pull requests are welcome for new tests or improvements to existing tests! Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 3 months

1
0
0 0

[PATCH v2 3/3] seccomp: test SECCOMP_USER_NOTIF_FLAG_CONTINUE

by Christian Brauner

Test whether a syscall can be performed after having been intercepted by the seccomp notifier. The test uses dup() and kcmp() since it allows us to nicely test whether the dup() syscall actually succeeded by comparing whether the fds refer to the same underlying struct file. Signed-off-by: Christian Brauner <christian.brauner(a)ubuntu.com> Cc: Kees Cook <keescook(a)chromium.org> Cc: Andy Lutomirski <luto(a)amacapital.net> Cc: Will Drewry <wad(a)chromium.org> Cc: Shuah Khan <shuah(a)kernel.org> Cc: Alexei Starovoitov <ast(a)kernel.org> Cc: Daniel Borkmann <daniel(a)iogearbox.net> Cc: Martin KaFai Lau <kafai(a)fb.com> Cc: Song Liu <songliubraving(a)fb.com> Cc: Yonghong Song <yhs(a)fb.com> Cc: Tycho Andersen <tycho(a)tycho.ws> CC: Tyler Hicks <tyhicks(a)canonical.com> Cc: stable(a)vger.kernel.org Cc: linux-kselftest(a)vger.kernel.org Cc: netdev(a)vger.kernel.org Cc: bpf(a)vger.kernel.org --- /* v2 */ - Shuah Khan <shuah(a)kernel.org>: - skip test on missing precondition /* v1 */ Link: https://lore.kernel.org/r/20190919095903.19370-4-christian.brauner@ubuntu.c… - Christian Brauner <christian.brauner(a)ubuntu.com>: - adapt to new flag name SECCOMP_USER_NOTIF_FLAG_CONTINUE /* v0 */ Link: https://lore.kernel.org/r/20190918084833.9369-5-christian.brauner@ubuntu.com --- tools/testing/selftests/seccomp/seccomp_bpf.c | 107 ++++++++++++++++++ 1 file changed, 107 insertions(+) diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c index e996d7b7fd6e..2519377ebda3 100644 --- a/tools/testing/selftests/seccomp/seccomp_bpf.c +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c @@ -44,6 +44,7 @@ #include <sys/times.h> #include <sys/socket.h> #include <sys/ioctl.h> +#include <linux/kcmp.h> #include <unistd.h> #include <sys/syscall.h> @@ -167,6 +168,10 @@ struct seccomp_metadata { #define SECCOMP_RET_USER_NOTIF 0x7fc00000U +#ifndef SECCOMP_USER_NOTIF_FLAG_CONTINUE +#define SECCOMP_USER_NOTIF_FLAG_CONTINUE 0x00000001 +#endif + #define SECCOMP_IOC_MAGIC '!' #define SECCOMP_IO(nr) _IO(SECCOMP_IOC_MAGIC, nr) #define SECCOMP_IOR(nr, type) _IOR(SECCOMP_IOC_MAGIC, nr, type) @@ -3481,6 +3486,108 @@ TEST(seccomp_get_notif_sizes) EXPECT_EQ(sizes.seccomp_notif_resp, sizeof(struct seccomp_notif_resp)); } +static int filecmp(pid_t pid1, pid_t pid2, int fd1, int fd2) +{ +#ifdef __NR_kcmp + return syscall(__NR_kcmp, pid1, pid2, KCMP_FILE, fd1, fd2); +#else + errno = ENOSYS; + return -1; +#endif +} + +TEST(user_notification_continue) +{ + pid_t pid; + long ret; + int status, listener; + struct seccomp_notif req = {}; + struct seccomp_notif_resp resp = {}; + struct pollfd pollfd; + + ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0); + ASSERT_EQ(0, ret) { + TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!"); + } + + listener = user_trap_syscall(__NR_dup, SECCOMP_FILTER_FLAG_NEW_LISTENER); + ASSERT_GE(listener, 0); + + pid = fork(); + ASSERT_GE(pid, 0); + + if (pid == 0) { + int dup_fd, pipe_fds[2]; + pid_t self; + + ret = pipe(pipe_fds); + if (ret < 0) + exit(1); + + dup_fd = dup(pipe_fds[0]); + if (dup_fd < 0) + exit(1); + + self = getpid(); + + ret = filecmp(self, self, pipe_fds[0], dup_fd); + if (ret) + exit(2); + + exit(0); + } + + pollfd.fd = listener; + pollfd.events = POLLIN | POLLOUT; + + EXPECT_GT(poll(&pollfd, 1, -1), 0); + EXPECT_EQ(pollfd.revents, POLLIN); + + EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0); + + pollfd.fd = listener; + pollfd.events = POLLIN | POLLOUT; + + EXPECT_GT(poll(&pollfd, 1, -1), 0); + EXPECT_EQ(pollfd.revents, POLLOUT); + + EXPECT_EQ(req.data.nr, __NR_dup); + + resp.id = req.id; + resp.flags = SECCOMP_USER_NOTIF_FLAG_CONTINUE; + + /* + * Verify that setting SECCOMP_USER_NOTIF_FLAG_CONTINUE enforces other + * args be set to 0. + */ + resp.error = 0; + resp.val = USER_NOTIF_MAGIC; + EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), -1); + EXPECT_EQ(errno, EINVAL); + + resp.error = USER_NOTIF_MAGIC; + resp.val = 0; + EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), -1); + EXPECT_EQ(errno, EINVAL); + + resp.error = 0; + resp.val = 0; + EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0) { + if (errno == EINVAL) + XFAIL(goto skip, "Kernel does not support SECCOMP_USER_NOTIF_FLAG_CONTINUE"); + } + +skip: + EXPECT_EQ(waitpid(pid, &status, 0), pid); + EXPECT_EQ(true, WIFEXITED(status)); + EXPECT_EQ(0, WEXITSTATUS(status)) { + if (WEXITSTATUS(status) == 2) { + XFAIL(return, "Kernel does not support kcmp() syscall"); + return; + } + } +} + /* * TODO: * - add microbenchmarks -- 2.23.0

5 years, 3 months

1
0
0 0

[PATCH] spi: spi-gpio: fix crash when num-chipselects is 0

by DENG Qingfang

If an spi-gpio was specified with num-chipselects = <0> in dts, kernel will crash: Unable to handle kernel paging request at virtual address 32697073 pgd = (ptrval) [32697073] *pgd=00000000 Internal error: Oops: 5 [# 1] SMP ARM Modules linked in: CPU: 2 PID: 1 Comm: swapper/0 Not tainted 4.19.72 #0 Hardware name: Generic DT based system PC is at validate_desc+0x28/0x80 LR is at gpiod_direction_output+0x14/0x128 ... [<c0544db4>] (validate_desc) from [<c0545228>] (gpiod_direction_output+0x14/0x128) [<c0545228>] (gpiod_direction_output) from [<c05fa714>] (spi_gpio_setup+0x58/0x64) [<c05fa714>] (spi_gpio_setup) from [<c05f7258>] (spi_setup+0x12c/0x148) [<c05f7258>] (spi_setup) from [<c05f7330>] (spi_add_device+0xbc/0x12c) [<c05f7330>] (spi_add_device) from [<c05f7f74>] (spi_register_controller+0x838/0x924) [<c05f7f74>] (spi_register_controller) from [<c05fa494>] (spi_bitbang_start+0x108/0x120) [<c05fa494>] (spi_bitbang_start) from [<c05faa34>] (spi_gpio_probe+0x314/0x338) [<c05faa34>] (spi_gpio_probe) from [<c05a844c>] (platform_drv_probe+0x34/0x70) The cause is spi_gpio_setup() did not check if the spi-gpio has chipselect pins before setting their direction and results in derefing an invalid pointer. The bug is spotted in kernel 4.19.72 on OpenWrt, and does not occur in 4.14. There is a similar fix upstream 249e2632dcd0509b8f8f296f5aabf4d48dfd6da8. Cc: Linus Walleij <linus.walleij(a)linaro.org> Cc: stable(a)vger.kernel.org Signed-off-by: DENG Qingfang <dqfext(a)gmail.com> --- drivers/spi/spi-gpio.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-gpio.c b/drivers/spi/spi-gpio.c index 77838d8fd..3b7f0d077 100644 --- a/drivers/spi/spi-gpio.c +++ b/drivers/spi/spi-gpio.c @@ -242,10 +242,12 @@ static int spi_gpio_setup(struct spi_device *spi) * The CS GPIOs have already been * initialized from the descriptor lookup. */ - cs = spi_gpio->cs_gpios[spi->chip_select]; - if (!spi->controller_state && cs) - status = gpiod_direction_output(cs, - !(spi->mode & SPI_CS_HIGH)); + if (spi_gpio->has_cs) { + cs = spi_gpio->cs_gpios[spi->chip_select]; + if (!spi->controller_state && cs) + status = gpiod_direction_output(cs, + !(spi->mode & SPI_CS_HIGH)); + } if (!status) status = spi_bitbang_setup(spi); -- 2.23.0

5 years, 3 months

2
1
0 0

[BACKPORT 4.14.y v2 0/6] Candidates from Spreadtrum 4.14 product kernel

by Baolin Wang

With Arnd's script [1] help, I found some bugfixes in Spreadtrum 4.14 product kernel, but missing in v4.14.141: 25a09ce79639 ppp: mppe: Revert "ppp: mppe: Add softdep to arc4" 47d3d7fdb10a ip6: fix skb leak in ip6frag_expire_frag_queue() 5b9cea15a3de serial: sprd: Modify the baud rate calculation formula 513e1073d52e locking/lockdep: Add debug_locks check in __lock_downgrade() 957063c92473 pinctrl: sprd: Use define directive for sprd_pinconf_params values 87a2b65fc855 power: supply: sysfs: ratelimit property read error message [1] https://lore.kernel.org/lkml/20190322154425.3852517-19-arnd@arndb.de/T/ Changes from v1: - Drop 2 unnecessary patches (patch 1 and patch 4) from v1 patch set. - Add upstream commit id in change log for each stable patch. David Lechner (1): power: supply: sysfs: ratelimit property read error message Eric Biggers (1): ppp: mppe: Revert "ppp: mppe: Add softdep to arc4" Eric Dumazet (1): ip6: fix skb leak in ip6frag_expire_frag_queue() Lanqing Liu (1): serial: sprd: Modify the baud rate calculation formula Nathan Chancellor (1): pinctrl: sprd: Use define directive for sprd_pinconf_params values Waiman Long (1): locking/lockdep: Add debug_locks check in __lock_downgrade() drivers/net/ppp/ppp_mppe.c | 1 - drivers/pinctrl/sprd/pinctrl-sprd.c | 6 ++---- drivers/power/supply/power_supply_sysfs.c | 3 ++- drivers/tty/serial/sprd_serial.c | 2 +- include/net/ipv6_frag.h | 1 - kernel/locking/lockdep.c | 3 +++ 6 files changed, 8 insertions(+), 8 deletions(-) -- 1.7.9.5

5 years, 3 months

4
13
0 0

✅ PASS: Stable queue: queue-5.3

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 4d856f72c10e - Linux 5.3 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK All kernel binaries, config files, and logs are available for download here: https://artifacts.cki-project.org/pipelines/175798 Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 4d856f72c10e - Linux 5.3 We grabbed the 0f46b1a42fe1 commit of the stable queue repository. We then merged the patchset with `git am`: usb-usbcore-fix-slab-out-of-bounds-bug-during-device-reset.patch media-tm6000-double-free-if-usb-disconnect-while-streaming.patch phy-renesas-rcar-gen3-usb2-disable-clearing-vbus-in-over-current.patch ip6_gre-fix-a-dst-leak-in-ip6erspan_tunnel_xmit.patch net-sched-fix-race-between-deactivation-and-dequeue-for-nolock-qdisc.patch net_sched-let-qdisc_put-accept-null-pointer.patch udp-correct-reuseport-selection-with-connected-sockets.patch xen-netfront-do-not-assume-sk_buff_head-list-is-empty-in-error-handling.patch net-dsa-fix-load-order-between-dsa-drivers-and-taggers.patch net-stmmac-hold-rtnl-lock-in-suspend-resume-callbacks.patch kvm-coalesced_mmio-add-bounds-checking.patch documentation-sphinx-add-missing-comma-to-list-of-strings.patch firmware-google-check-if-size-is-valid-when-decoding-vpd-data.patch serial-sprd-correct-the-wrong-sequence-of-arguments.patch tty-serial-atmel-reschedule-tx-after-rx-was-started.patch nl80211-fix-possible-spectre-v1-for-cqm-rssi-thresholds.patch revert-arm64-remove-unnecessary-isbs-from-set_-pte-pmd-pud.patch ovl-fix-regression-caused-by-overlapping-layers-detection.patch phy-qcom-qmp-correct-ready-status-again.patch floppy-fix-usercopy-direction.patch media-technisat-usb2-break-out-of-loop-at-end-of-buffer.patch Compile testing --------------- We compiled the kernel for 3 architectures: aarch64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ✅ Boot test ✅ Podman system integration test (as root) ✅ Podman system integration test (as user) ✅ Loopdev Sanity ✅ jvm test suite ✅ AMTU (Abstract Machine Test Utility) ✅ LTP: openposix test suite ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking UDP: socket ✅ Networking tunnel: gre basic ✅ audit: audit testsuite test ✅ httpd: mod_ssl smoke sanity ✅ iotop: sanity ✅ tuned: tune-processes-through-perf ✅ stress: stress-ng 🚧 ✅ LTP lite Host 2: ✅ Boot test ✅ selinux-policy: serge-testsuite 🚧 ✅ Storage blktests ppc64le: Host 1: ✅ Boot test ✅ Podman system integration test (as root) ✅ Podman system integration test (as user) ✅ Loopdev Sanity ✅ jvm test suite ✅ AMTU (Abstract Machine Test Utility) ✅ LTP: openposix test suite ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking UDP: socket ✅ Networking tunnel: gre basic ✅ audit: audit testsuite test ✅ httpd: mod_ssl smoke sanity ✅ iotop: sanity ✅ tuned: tune-processes-through-perf 🚧 ✅ LTP lite Host 2: ✅ Boot test ✅ selinux-policy: serge-testsuite 🚧 ✅ Storage blktests x86_64: Host 1: ✅ Boot test ✅ selinux-policy: serge-testsuite 🚧 ✅ Storage blktests Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test ✅ Podman system integration test (as root) ✅ Podman system integration test (as user) ✅ Loopdev Sanity ✅ jvm test suite ✅ AMTU (Abstract Machine Test Utility) ✅ LTP: openposix test suite ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking UDP: socket ✅ Networking tunnel: gre basic ✅ audit: audit testsuite test ✅ httpd: mod_ssl smoke sanity ✅ iotop: sanity ✅ tuned: tune-processes-through-perf ✅ pciutils: sanity smoke test ✅ stress: stress-ng 🚧 ⚡⚡⚡ LTP lite Test sources: https://github.com/CKI-project/tests-beaker 💚 Pull requests are welcome for new tests or improvements to existing tests! Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 3 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror September 2019