September 2019 - Linux-stable-mirror

[PATCH for 4.9.y] mtd: cfi_cmdset_0002: Use chip_good() to retry in do_write_oneword()

by Tokunori Ikegami

As reported by the OpenWRT team, write requests sometimes fail on some platforms. Currently to check the state chip_ready() is used correctly as described by the flash memory S29GL256P11TFI01 datasheet. Also chip_good() is used to check if the write is succeeded and it was implemented by the commit fb4a90bfcd6d8 ("[MTD] CFI-0002 - Improve error checking"). But actually the write failure is caused on some platforms and also it can be fixed by using chip_good() to check the state and retry instead. Also it seems that it is caused after repeated about 1,000 times to retry the write one word with the reset command. By using chip_good() to check the state to be done it can be reduced the retry with reset. It is depended on the actual flash chip behavior so the root cause is unknown. Cc: Chris Packham <chris.packham(a)alliedtelesis.co.nz> Cc: Joakim Tjernlund <Joakim.Tjernlund(a)infinera.com> Cc: linux-mtd(a)lists.infradead.org Cc: stable(a)vger.kernel.org Reported-by: Fabio Bettoni <fbettoni(a)gmail.com> Signed-off-by: Felix Fietkau <nbd(a)nbd.name> Signed-off-by: Hauke Mehrtens <hauke(a)hauke-m.de> Signed-off-by: Tokunori Ikegami <ikegami.t(a)gmail.com> [vigneshr(a)ti.com: Fix a checkpatch warning] Signed-off-by: Vignesh Raghavendra <vigneshr(a)ti.com> --- drivers/mtd/chips/cfi_cmdset_0002.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index de35a2a362f9..8725e406a9eb 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -1624,29 +1624,35 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip, continue; } - if (time_after(jiffies, timeo) && !chip_ready(map, adr)){ + /* + * We check "time_after" and "!chip_good" before checking + * "chip_good" to avoid the failure due to scheduling. + */ + if (time_after(jiffies, timeo) && !chip_good(map, adr, datum)) { xip_enable(map, chip, adr); printk(KERN_WARNING "MTD %s(): software timeout\n", __func__); xip_disable(map, chip, adr); + ret = -EIO; break; } - if (chip_ready(map, adr)) + if (chip_good(map, adr, datum)) break; /* Latency issues. Drop the lock, wait a while and retry */ UDELAY(map, chip, adr, 1); } + /* Did we succeed? */ - if (!chip_good(map, adr, datum)) { + if (ret) { /* reset on all failures. */ map_write( map, CMD(0xF0), chip->start ); /* FIXME - should have reset delay before continuing */ - if (++retry_cnt <= MAX_RETRIES) + if (++retry_cnt <= MAX_RETRIES) { + ret = 0; goto retry; - - ret = -EIO; + } } xip_enable(map, chip, adr); op_done: -- 2.11.0

5 years

1
0
0 0

[PATCH for 4.14.y] mtd: cfi_cmdset_0002: Use chip_good() to retry in do_write_oneword()

by Tokunori Ikegami

As reported by the OpenWRT team, write requests sometimes fail on some platforms. Currently to check the state chip_ready() is used correctly as described by the flash memory S29GL256P11TFI01 datasheet. Also chip_good() is used to check if the write is succeeded and it was implemented by the commit fb4a90bfcd6d8 ("[MTD] CFI-0002 - Improve error checking"). But actually the write failure is caused on some platforms and also it can be fixed by using chip_good() to check the state and retry instead. Also it seems that it is caused after repeated about 1,000 times to retry the write one word with the reset command. By using chip_good() to check the state to be done it can be reduced the retry with reset. It is depended on the actual flash chip behavior so the root cause is unknown. Cc: Chris Packham <chris.packham(a)alliedtelesis.co.nz> Cc: Joakim Tjernlund <Joakim.Tjernlund(a)infinera.com> Cc: linux-mtd(a)lists.infradead.org Cc: stable(a)vger.kernel.org Reported-by: Fabio Bettoni <fbettoni(a)gmail.com> Signed-off-by: Felix Fietkau <nbd(a)nbd.name> Signed-off-by: Hauke Mehrtens <hauke(a)hauke-m.de> Signed-off-by: Tokunori Ikegami <ikegami.t(a)gmail.com> [vigneshr(a)ti.com: Fix a checkpatch warning] Signed-off-by: Vignesh Raghavendra <vigneshr(a)ti.com> --- drivers/mtd/chips/cfi_cmdset_0002.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index af3d207c9cc4..e773dc6fdd3c 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -1628,29 +1628,35 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip, continue; } - if (time_after(jiffies, timeo) && !chip_ready(map, adr)){ + /* + * We check "time_after" and "!chip_good" before checking + * "chip_good" to avoid the failure due to scheduling. + */ + if (time_after(jiffies, timeo) && !chip_good(map, adr, datum)) { xip_enable(map, chip, adr); printk(KERN_WARNING "MTD %s(): software timeout\n", __func__); xip_disable(map, chip, adr); + ret = -EIO; break; } - if (chip_ready(map, adr)) + if (chip_good(map, adr, datum)) break; /* Latency issues. Drop the lock, wait a while and retry */ UDELAY(map, chip, adr, 1); } + /* Did we succeed? */ - if (!chip_good(map, adr, datum)) { + if (ret) { /* reset on all failures. */ map_write( map, CMD(0xF0), chip->start ); /* FIXME - should have reset delay before continuing */ - if (++retry_cnt <= MAX_RETRIES) + if (++retry_cnt <= MAX_RETRIES) { + ret = 0; goto retry; - - ret = -EIO; + } } xip_enable(map, chip, adr); op_done: -- 2.11.0

5 years

1
0
0 0

[PATCH for 4.19.y] mtd: cfi_cmdset_0002: Use chip_good() to retry in do_write_oneword()

by Tokunori Ikegami

As reported by the OpenWRT team, write requests sometimes fail on some platforms. Currently to check the state chip_ready() is used correctly as described by the flash memory S29GL256P11TFI01 datasheet. Also chip_good() is used to check if the write is succeeded and it was implemented by the commit fb4a90bfcd6d8 ("[MTD] CFI-0002 - Improve error checking"). But actually the write failure is caused on some platforms and also it can be fixed by using chip_good() to check the state and retry instead. Also it seems that it is caused after repeated about 1,000 times to retry the write one word with the reset command. By using chip_good() to check the state to be done it can be reduced the retry with reset. It is depended on the actual flash chip behavior so the root cause is unknown. Cc: Chris Packham <chris.packham(a)alliedtelesis.co.nz> Cc: Joakim Tjernlund <Joakim.Tjernlund(a)infinera.com> Cc: linux-mtd(a)lists.infradead.org Cc: stable(a)vger.kernel.org Reported-by: Fabio Bettoni <fbettoni(a)gmail.com> Signed-off-by: Felix Fietkau <nbd(a)nbd.name> Signed-off-by: Hauke Mehrtens <hauke(a)hauke-m.de> Signed-off-by: Tokunori Ikegami <ikegami.t(a)gmail.com> [vigneshr(a)ti.com: Fix a checkpatch warning] Signed-off-by: Vignesh Raghavendra <vigneshr(a)ti.com> --- drivers/mtd/chips/cfi_cmdset_0002.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index 72428b6bfc47..ba44ea6d497e 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -1627,29 +1627,35 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip, continue; } - if (time_after(jiffies, timeo) && !chip_ready(map, adr)){ + /* + * We check "time_after" and "!chip_good" before checking + * "chip_good" to avoid the failure due to scheduling. + */ + if (time_after(jiffies, timeo) && !chip_good(map, adr, datum)) { xip_enable(map, chip, adr); printk(KERN_WARNING "MTD %s(): software timeout\n", __func__); xip_disable(map, chip, adr); + ret = -EIO; break; } - if (chip_ready(map, adr)) + if (chip_good(map, adr, datum)) break; /* Latency issues. Drop the lock, wait a while and retry */ UDELAY(map, chip, adr, 1); } + /* Did we succeed? */ - if (!chip_good(map, adr, datum)) { + if (ret) { /* reset on all failures. */ map_write(map, CMD(0xF0), chip->start); /* FIXME - should have reset delay before continuing */ - if (++retry_cnt <= MAX_RETRIES) + if (++retry_cnt <= MAX_RETRIES) { + ret = 0; goto retry; - - ret = -EIO; + } } xip_enable(map, chip, adr); op_done: -- 2.11.0

5 years

1
0
0 0

Please apply commit 0f0727d971f6 ("drm/amd/display: readd -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines") to 4.19.y

by Nick Desaulniers

Please apply commit 0f0727d971f6 ("drm/amd/display: readd -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines") to 4.19.y. It will help with AMD based chromebooks for ChromeOS. -- Thanks, ~Nick Desaulniers

5 years

3
6
0 0

[PATCH AUTOSEL 4.4 01/44] ALSA: hda: Flush interrupts on disabling

by Sasha Levin

From: Chris Wilson <chris(a)chris-wilson.co.uk> [ Upstream commit caa8422d01e983782548648e125fd617cadcec3f ] I was looking at <4> [241.835158] general protection fault: 0000 [#1] PREEMPT SMP PTI <4> [241.835181] CPU: 1 PID: 214 Comm: kworker/1:3 Tainted: G U 5.2.0-CI-CI_DRM_6509+ #1 <4> [241.835199] Hardware name: Dell Inc. OptiPlex 745 /0GW726, BIOS 2.3.1 05/21/2007 <4> [241.835234] Workqueue: events snd_hdac_bus_process_unsol_events [snd_hda_core] <4> [241.835256] RIP: 0010:input_handle_event+0x16d/0x5e0 <4> [241.835270] Code: 48 8b 93 58 01 00 00 8b 52 08 89 50 04 8b 83 f8 06 00 00 48 8b 93 00 07 00 00 8d 70 01 48 8d 04 c2 83 e1 08 89 b3 f8 06 00 00 <66> 89 28 66 44 89 60 02 44 89 68 04 8b 93 f8 06 00 00 0f 84 fd fe <4> [241.835304] RSP: 0018:ffffc9000019fda0 EFLAGS: 00010046 <4> [241.835317] RAX: 6b6b6b6ec6c6c6c3 RBX: ffff8880290fefc8 RCX: 0000000000000000 <4> [241.835332] RDX: 000000006b6b6b6b RSI: 000000006b6b6b6c RDI: 0000000000000046 <4> [241.835347] RBP: 0000000000000005 R08: 0000000000000000 R09: 0000000000000001 <4> [241.835362] R10: ffffc9000019faa0 R11: 0000000000000000 R12: 0000000000000004 <4> [241.835377] R13: 0000000000000000 R14: ffff8880290ff1d0 R15: 0000000000000293 <4> [241.835392] FS: 0000000000000000(0000) GS:ffff88803de80000(0000) knlGS:0000000000000000 <4> [241.835409] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4> [241.835422] CR2: 00007ffe9a99e9b7 CR3: 000000002f588000 CR4: 00000000000006e0 <4> [241.835436] Call Trace: <4> [241.835449] input_event+0x45/0x70 <4> [241.835464] snd_jack_report+0xdc/0x100 <4> [241.835490] snd_hda_jack_report_sync+0x83/0xc0 [snd_hda_codec] <4> [241.835512] snd_hdac_bus_process_unsol_events+0x5a/0x70 [snd_hda_core] <4> [241.835530] process_one_work+0x245/0x610 which has the hallmarks of a worker queued from interrupt after it was supposedly cancelled (note the POISON_FREE), and I could not see where the interrupt would be flushed on shutdown so added the likely suspects. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111174 Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/hda/hdac_controller.c | 2 ++ sound/pci/hda/hda_intel.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c index 4727f5b80e76d..acc2c7dbfb151 100644 --- a/sound/hda/hdac_controller.c +++ b/sound/hda/hdac_controller.c @@ -340,6 +340,8 @@ static void azx_int_disable(struct hdac_bus *bus) list_for_each_entry(azx_dev, &bus->stream_list, list) snd_hdac_stream_updateb(azx_dev, SD_CTL, SD_INT_MASK, 0); + synchronize_irq(bus->irq); + /* disable SIE for all streams */ snd_hdac_chip_writeb(bus, INTCTL, 0); diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index ef8955abd9186..96ccab15da836 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1274,9 +1274,9 @@ static int azx_free(struct azx *chip) } if (bus->chip_init) { + azx_stop_chip(chip); azx_clear_irq_pending(chip); azx_stop_all_streams(chip); - azx_stop_chip(chip); } if (bus->irq >= 0) -- 2.20.1

5 years

1
43
0 0

[PATCH AUTOSEL 4.9 01/60] ALSA: hda: Flush interrupts on disabling

by Sasha Levin

From: Chris Wilson <chris(a)chris-wilson.co.uk> [ Upstream commit caa8422d01e983782548648e125fd617cadcec3f ] I was looking at <4> [241.835158] general protection fault: 0000 [#1] PREEMPT SMP PTI <4> [241.835181] CPU: 1 PID: 214 Comm: kworker/1:3 Tainted: G U 5.2.0-CI-CI_DRM_6509+ #1 <4> [241.835199] Hardware name: Dell Inc. OptiPlex 745 /0GW726, BIOS 2.3.1 05/21/2007 <4> [241.835234] Workqueue: events snd_hdac_bus_process_unsol_events [snd_hda_core] <4> [241.835256] RIP: 0010:input_handle_event+0x16d/0x5e0 <4> [241.835270] Code: 48 8b 93 58 01 00 00 8b 52 08 89 50 04 8b 83 f8 06 00 00 48 8b 93 00 07 00 00 8d 70 01 48 8d 04 c2 83 e1 08 89 b3 f8 06 00 00 <66> 89 28 66 44 89 60 02 44 89 68 04 8b 93 f8 06 00 00 0f 84 fd fe <4> [241.835304] RSP: 0018:ffffc9000019fda0 EFLAGS: 00010046 <4> [241.835317] RAX: 6b6b6b6ec6c6c6c3 RBX: ffff8880290fefc8 RCX: 0000000000000000 <4> [241.835332] RDX: 000000006b6b6b6b RSI: 000000006b6b6b6c RDI: 0000000000000046 <4> [241.835347] RBP: 0000000000000005 R08: 0000000000000000 R09: 0000000000000001 <4> [241.835362] R10: ffffc9000019faa0 R11: 0000000000000000 R12: 0000000000000004 <4> [241.835377] R13: 0000000000000000 R14: ffff8880290ff1d0 R15: 0000000000000293 <4> [241.835392] FS: 0000000000000000(0000) GS:ffff88803de80000(0000) knlGS:0000000000000000 <4> [241.835409] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4> [241.835422] CR2: 00007ffe9a99e9b7 CR3: 000000002f588000 CR4: 00000000000006e0 <4> [241.835436] Call Trace: <4> [241.835449] input_event+0x45/0x70 <4> [241.835464] snd_jack_report+0xdc/0x100 <4> [241.835490] snd_hda_jack_report_sync+0x83/0xc0 [snd_hda_codec] <4> [241.835512] snd_hdac_bus_process_unsol_events+0x5a/0x70 [snd_hda_core] <4> [241.835530] process_one_work+0x245/0x610 which has the hallmarks of a worker queued from interrupt after it was supposedly cancelled (note the POISON_FREE), and I could not see where the interrupt would be flushed on shutdown so added the likely suspects. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111174 Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/hda/hdac_controller.c | 2 ++ sound/pci/hda/hda_intel.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c index 00c6af2ae1c29..433f3280f7098 100644 --- a/sound/hda/hdac_controller.c +++ b/sound/hda/hdac_controller.c @@ -441,6 +441,8 @@ static void azx_int_disable(struct hdac_bus *bus) list_for_each_entry(azx_dev, &bus->stream_list, list) snd_hdac_stream_updateb(azx_dev, SD_CTL, SD_INT_MASK, 0); + synchronize_irq(bus->irq); + /* disable SIE for all streams */ snd_hdac_chip_writeb(bus, INTCTL, 0); diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index f2f1d9fd848c8..3d4ea5fd75bf5 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1239,9 +1239,9 @@ static int azx_free(struct azx *chip) } if (bus->chip_init) { + azx_stop_chip(chip); azx_clear_irq_pending(chip); azx_stop_all_streams(chip); - azx_stop_chip(chip); } if (bus->irq >= 0) -- 2.20.1

5 years

1
59
0 0

[PATCH AUTOSEL 4.14 01/89] ALSA: hda: Flush interrupts on disabling

by Sasha Levin

From: Chris Wilson <chris(a)chris-wilson.co.uk> [ Upstream commit caa8422d01e983782548648e125fd617cadcec3f ] I was looking at <4> [241.835158] general protection fault: 0000 [#1] PREEMPT SMP PTI <4> [241.835181] CPU: 1 PID: 214 Comm: kworker/1:3 Tainted: G U 5.2.0-CI-CI_DRM_6509+ #1 <4> [241.835199] Hardware name: Dell Inc. OptiPlex 745 /0GW726, BIOS 2.3.1 05/21/2007 <4> [241.835234] Workqueue: events snd_hdac_bus_process_unsol_events [snd_hda_core] <4> [241.835256] RIP: 0010:input_handle_event+0x16d/0x5e0 <4> [241.835270] Code: 48 8b 93 58 01 00 00 8b 52 08 89 50 04 8b 83 f8 06 00 00 48 8b 93 00 07 00 00 8d 70 01 48 8d 04 c2 83 e1 08 89 b3 f8 06 00 00 <66> 89 28 66 44 89 60 02 44 89 68 04 8b 93 f8 06 00 00 0f 84 fd fe <4> [241.835304] RSP: 0018:ffffc9000019fda0 EFLAGS: 00010046 <4> [241.835317] RAX: 6b6b6b6ec6c6c6c3 RBX: ffff8880290fefc8 RCX: 0000000000000000 <4> [241.835332] RDX: 000000006b6b6b6b RSI: 000000006b6b6b6c RDI: 0000000000000046 <4> [241.835347] RBP: 0000000000000005 R08: 0000000000000000 R09: 0000000000000001 <4> [241.835362] R10: ffffc9000019faa0 R11: 0000000000000000 R12: 0000000000000004 <4> [241.835377] R13: 0000000000000000 R14: ffff8880290ff1d0 R15: 0000000000000293 <4> [241.835392] FS: 0000000000000000(0000) GS:ffff88803de80000(0000) knlGS:0000000000000000 <4> [241.835409] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4> [241.835422] CR2: 00007ffe9a99e9b7 CR3: 000000002f588000 CR4: 00000000000006e0 <4> [241.835436] Call Trace: <4> [241.835449] input_event+0x45/0x70 <4> [241.835464] snd_jack_report+0xdc/0x100 <4> [241.835490] snd_hda_jack_report_sync+0x83/0xc0 [snd_hda_codec] <4> [241.835512] snd_hdac_bus_process_unsol_events+0x5a/0x70 [snd_hda_core] <4> [241.835530] process_one_work+0x245/0x610 which has the hallmarks of a worker queued from interrupt after it was supposedly cancelled (note the POISON_FREE), and I could not see where the interrupt would be flushed on shutdown so added the likely suspects. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111174 Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/hda/hdac_controller.c | 2 ++ sound/pci/hda/hda_intel.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c index 778b42ba90b80..3377f0bc28280 100644 --- a/sound/hda/hdac_controller.c +++ b/sound/hda/hdac_controller.c @@ -442,6 +442,8 @@ static void azx_int_disable(struct hdac_bus *bus) list_for_each_entry(azx_dev, &bus->stream_list, list) snd_hdac_stream_updateb(azx_dev, SD_CTL, SD_INT_MASK, 0); + synchronize_irq(bus->irq); + /* disable SIE for all streams */ snd_hdac_chip_writeb(bus, INTCTL, 0); diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 682f9657c16c6..a5314a08cfa85 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1413,9 +1413,9 @@ static int azx_free(struct azx *chip) } if (bus->chip_init) { + azx_stop_chip(chip); azx_clear_irq_pending(chip); azx_stop_all_streams(chip); - azx_stop_chip(chip); } if (bus->irq >= 0) -- 2.20.1

5 years

1
88
0 0

Weigh18

by 8413138308882787451

开发瓢 v:ⓍⓍⓑⓑ①④③② eople using this calendar will see your email address if you join. To join a shared calendar, you must have iCloud. Learn More

5 years

1
0
0 0

✅ PASS: Stable queue: queue-5.3

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: c9a59a82366b - Linux 5.3.1 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK All kernel binaries, config files, and logs are available for download here: https://artifacts.cki-project.org/pipelines/180445 Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: c9a59a82366b - Linux 5.3.1 We grabbed the 7f2f9d496c3b commit of the stable queue repository. We then merged the patchset with `git am`: netfilter-add-missing-is_enabled-config_nf_tables-check-to-header-file.patch clocksource-drivers-timer-of-do-not-warn-on-deferred-probe.patch clocksource-drivers-do-not-warn-on-probe-defer.patch drm-amd-display-allow-cursor-async-updates-for-framebuffer-swaps.patch drm-amd-display-skip-determining-update-type-for-async-updates.patch drm-amd-display-don-t-replace-the-dc_state-for-fast-updates.patch drm-amd-display-readd-msse2-to-prevent-clang-from-emitting-libcalls-to-undefined-sw-fp-routines.patch Compile testing --------------- We compiled the kernel for 3 architectures: aarch64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ✅ Boot test ✅ Podman system integration test (as root) ✅ Podman system integration test (as user) ✅ jvm test suite ✅ AMTU (Abstract Machine Test Utility) ✅ LTP: openposix test suite ✅ audit: audit testsuite test ✅ httpd: mod_ssl smoke sanity ✅ iotop: sanity ✅ tuned: tune-processes-through-perf ✅ stress: stress-ng 🚧 ✅ LTP lite Host 2: ✅ Boot test ✅ selinux-policy: serge-testsuite ppc64le: Host 1: ✅ Boot test ✅ Podman system integration test (as root) ✅ Podman system integration test (as user) ✅ jvm test suite ✅ AMTU (Abstract Machine Test Utility) ✅ LTP: openposix test suite ✅ audit: audit testsuite test ✅ httpd: mod_ssl smoke sanity ✅ iotop: sanity ✅ tuned: tune-processes-through-perf 🚧 ✅ LTP lite Host 2: ✅ Boot test ✅ selinux-policy: serge-testsuite x86_64: Host 1: ✅ Boot test ✅ Podman system integration test (as root) ✅ Podman system integration test (as user) ✅ jvm test suite ✅ AMTU (Abstract Machine Test Utility) ✅ LTP: openposix test suite ✅ audit: audit testsuite test ✅ httpd: mod_ssl smoke sanity ✅ iotop: sanity ✅ tuned: tune-processes-through-perf ✅ pciutils: sanity smoke test ✅ stress: stress-ng 🚧 ✅ LTP lite Host 2: ✅ Boot test ✅ selinux-policy: serge-testsuite Test sources: https://github.com/CKI-project/tests-beaker 💚 Pull requests are welcome for new tests or improvements to existing tests! Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years

1
0
0 0

[PATCH 4.19 00/79] 4.19.75-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.75 release. There are 79 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat 21 Sep 2019 09:44:25 PM UTC. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.75-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.75-rc1 Sean Young <sean(a)mess.org> media: technisat-usb2: break out of loop at end of buffer Will Deacon <will.deacon(a)arm.com> arm64: kpti: Whitelist Cortex-A CPUs that don't implement the CSV3 field Kees Cook <keescook(a)chromium.org> binfmt_elf: move brk out of mmap when doing direct loader exec Jann Horn <jannh(a)google.com> floppy: fix usercopy direction Amir Goldstein <amir73il(a)gmail.com> ovl: fix regression caused by overlapping layers detection Nathan Chancellor <natechancellor(a)gmail.com> PCI: kirin: Fix section mismatch warning Joerg Roedel <jroedel(a)suse.de> iommu/amd: Fix race in increase_address_space() Stuart Hayes <stuart.w.hayes(a)gmail.com> iommu/amd: Flush old domains in kdump kernel Hillf Danton <hdanton(a)sina.com> keys: Fix missing null pointer check in request_key_auth_describe() Tianyu Lan <Tianyu.Lan(a)microsoft.com> x86/hyper-v: Fix overflow bug in fill_gva_list() Peter Zijlstra <peterz(a)infradead.org> x86/uaccess: Don't leak the AC flags into __get_user() argument evaluation Wenwen Wang <wenwen(a)cs.uga.edu> dmaengine: ti: omap-dma: Add cleanup in omap_dma_probe() Wenwen Wang <wenwen(a)cs.uga.edu> dmaengine: ti: dma-crossbar: Fix a memory leak bug Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> net: seeq: Fix the function used to release some memory in an error handling path Dmitry Bogdanov <dmitry.bogdanov(a)aquantia.com> net: aquantia: fix out of memory condition on rx side Naoya Horiguchi <n-horiguchi(a)ah.jp.nec.com> tools/power turbostat: fix buffer overrun Zephaniah E. Loss-Cutler-Hull <zephaniah(a)gmail.com> tools/power x86_energy_perf_policy: Fix argument parsing Ben Hutchings <ben(a)decadent.org.uk> tools/power x86_energy_perf_policy: Fix "uninitialized variable" warnings at -O2 YueHaibing <yuehaibing(a)huawei.com> amd-xgbe: Fix error path in xgbe_mod_init() Kim Phillips <kim.phillips(a)amd.com> perf/x86/amd/ibs: Fix sample bias for dispatched micro-ops Josh Hunt <johunt(a)akamai.com> perf/x86/intel: Restrict period on Nehalem Jarkko Nikula <jarkko.nikula(a)linux.intel.com> i2c: designware: Synchronize IRQs when unregistering slave client Takashi Iwai <tiwai(a)suse.de> sky2: Disable MSI on yet another ASUS boards (P6Xxxx) Thomas Falcon <tlfalcon(a)linux.ibm.com> ibmvnic: Do not process reset during or after device removal zhaoyang <huangzhaoyang(a)gmail.com> ARM: 8901/1: add a criteria for pfn_valid of arm Nagarjuna Kristam <nkristam(a)nvidia.com> usb: host: xhci-tegra: Set DMA mask correctly Dan Carpenter <dan.carpenter(a)oracle.com> cifs: Use kzfree() to zero out the password Ronnie Sahlberg <lsahlber(a)redhat.com> cifs: set domainName when a domain-key is used in multiuser Marc Zyngier <maz(a)kernel.org> kallsyms: Don't let kallsyms_lookup_size_offset() fail on retrieving the first symbol Trond Myklebust <trond.myklebust(a)hammerspace.com> NFSv2: Fix write regression Trond Myklebust <trond.myklebust(a)hammerspace.com> NFSv2: Fix eof handling Thomas Jarosch <thomas.jarosch(a)intra2net.com> netfilter: nf_conntrack_ftp: Fix debug output Todd Seidelmann <tseidelmann(a)linode.com> netfilter: xt_physdev: Fix spurious error message in physdev_mt_check Thomas Gleixner <tglx(a)linutronix.de> x86/apic: Fix arch_dynirq_lower_bound() bug for DT enabled machines Prashant Malani <pmalani(a)chromium.org> r8152: Set memory to all 0xFFs on failed reg reads Ilya Leoshkevich <iii(a)linux.ibm.com> bpf: allow narrow loads of some sk_reuseport_md fields with offset > 0 Sven Eckelmann <sven(a)narfation.org> batman-adv: Only read OGM2 tvlv_len after buffer len check Doug Berger <opendmb(a)gmail.com> ARM: 8874/1: mm: only adjust sections of valid mm structures Wenwen Wang <wenwen(a)cs.uga.edu> qed: Add cleanup in qed_slowpath_start() Ivan Khoronzhuk <ivan.khoronzhuk(a)linaro.org> xdp: unpin xdp umem pages in error path Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> Kconfig: Fix the reference to the IDT77105 Phy driver in the description of ATM_NICSTAR_USE_IDT77105 Trond Myklebust <trond.myklebust(a)hammerspace.com> NFS: Fix initialisation of I/O result struct in nfs_pgio_rpcsetup Trond Myklebust <trond.myklebust(a)hammerspace.com> NFSv4: Fix return value in nfs_finish_open() Trond Myklebust <trond.myklebust(a)hammerspace.com> NFSv4: Fix return values for nfs4_file_open() Juliana Rodrigueiro <juliana.rodrigueiro(a)intra2net.com> netfilter: xt_nfacct: Fix alignment mismatch in xt_nfacct_match_info Pablo Neira Ayuso <pablo(a)netfilter.org> netfilter: nft_flow_offload: missing netlink attribute policy Todd Seidelmann <tseidelmann(a)linode.com> netfilter: ebtables: Fix argument order to ADD_COUNTER Phil Reid <preid(a)electromag.com.au> fpga: altera-ps-spi: Fix getting of optional confd gpio Quentin Monnet <quentin.monnet(a)netronome.com> tools: bpftool: close prog FD before exit on showing a single program Ilya Leoshkevich <iii(a)linux.ibm.com> selftests/bpf: fix "bind{4, 6} deny specific IP & port" on s390 Ilya Leoshkevich <iii(a)linux.ibm.com> s390/bpf: use 32-bit index for tail calls Suman Anna <s-anna(a)ti.com> bus: ti-sysc: Simplify cleanup upon failures in sysc_probe() Janusz Krzysztofik <jmkrzyszt(a)gmail.com> ARM: OMAP1: ams-delta-fiq: Fix missing irq_ack Faiz Abbas <faiz_abbas(a)ti.com> ARM: dts: dra74x: Fix iodelay configuration for mmc3 Tony Lindgren <tony(a)atomide.com> ARM: OMAP2+: Fix omap4 errata warning on other SoCs Ilya Leoshkevich <iii(a)linux.ibm.com> s390/bpf: fix lcgr instruction encoding Tony Lindgren <tony(a)atomide.com> bus: ti-sysc: Fix using configured sysc mask value Tony Lindgren <tony(a)atomide.com> ARM: OMAP2+: Fix missing SYSC_HAS_RESET_STATUS for dra7 epwmss Faiz Abbas <faiz_abbas(a)ti.com> ARM: dts: am57xx: Disable voltage switching for SD card YueHaibing <yuehaibing(a)huawei.com> ieee802154: hwsim: unregister hw while hwsim_subscribe_all_others fails YueHaibing <yuehaibing(a)huawei.com> ieee802154: hwsim: Fix error handle path in hwsim_init_module Masashi Honma <masashi.honma(a)gmail.com> nl80211: Fix possible Spectre-v1 for CQM RSSI thresholds Wen Huang <huangwenabc(a)gmail.com> mwifiex: Fix three heap overflow at parsing element in cfg80211_ap_settings Razvan Stefanescu <razvan.stefanescu(a)microchip.com> tty/serial: atmel: reschedule TX after RX was started Chunyan Zhang <chunyan.zhang(a)unisoc.com> serial: sprd: correct the wrong sequence of arguments Hung-Te Lin <hungte(a)chromium.org> firmware: google: check if size is valid when decoding VPD data Matt Delco <delco(a)chromium.org> KVM: coalesced_mmio: add bounds checking Cong Wang <xiyou.wangcong(a)gmail.com> net_sched: let qdisc_put() accept NULL pointer Dongli Zhang <dongli.zhang(a)oracle.com> xen-netfront: do not assume sk_buff_head list is empty in error handling Willem de Bruijn <willemb(a)google.com> udp: correct reuseport selection with connected sockets Xin Long <lucien.xin(a)gmail.com> ip6_gre: fix a dst leak in ip6erspan_tunnel_xmit Yoshihiro Shimoda <yoshihiro.shimoda.uh(a)renesas.com> phy: renesas: rcar-gen3-usb2: Disable clearing VBUS in over-current Sean Young <sean(a)mess.org> media: tm6000: double free if usb disconnect while streaming Alan Stern <stern(a)rowland.harvard.edu> USB: usbcore: Fix slab-out-of-bounds bug during device reset Aneesh Kumar K.V <aneesh.kumar(a)linux.ibm.com> powerpc/mm/radix: Use the right page size for vmemmap mapping Benjamin Tissoires <benjamin.tissoires(a)redhat.com> Input: elan_i2c - remove Lenovo Legion Y7000 PnpID Leon Romanovsky <leon(a)kernel.org> RDMA/restrack: Release task struct which was hold by CM_ID object Aaron Armstrong Skomra <skomra(a)gmail.com> HID: wacom: generic: read HID_DG_CONTACTMAX from any feature report Pablo Neira Ayuso <pablo(a)netfilter.org> netfilter: nf_flow_table: set default timeout after successful insertion ------------- Diffstat: Documentation/filesystems/overlayfs.txt | 2 +- Makefile | 4 +- arch/arm/boot/dts/am571x-idk.dts | 7 +-- arch/arm/boot/dts/am572x-idk.dts | 7 +-- arch/arm/boot/dts/am574x-idk.dts | 7 +-- arch/arm/boot/dts/am57xx-beagle-x15-common.dtsi | 1 + arch/arm/boot/dts/am57xx-beagle-x15-revb1.dts | 7 +-- arch/arm/boot/dts/am57xx-beagle-x15-revc.dts | 7 +-- arch/arm/boot/dts/dra74x-mmc-iodelay.dtsi | 50 +++++++-------- arch/arm/mach-omap1/ams-delta-fiq-handler.S | 3 +- arch/arm/mach-omap1/ams-delta-fiq.c | 4 +- arch/arm/mach-omap2/omap4-common.c | 3 + arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 3 +- arch/arm/mm/init.c | 8 ++- arch/arm64/kernel/cpufeature.c | 6 ++ arch/powerpc/mm/pgtable-radix.c | 16 +++-- arch/s390/net/bpf_jit_comp.c | 12 ++-- arch/x86/events/amd/ibs.c | 13 +++- arch/x86/events/intel/core.c | 6 ++ arch/x86/hyperv/mmu.c | 8 ++- arch/x86/include/asm/perf_event.h | 12 ++-- arch/x86/include/asm/uaccess.h | 4 +- arch/x86/kernel/apic/io_apic.c | 8 ++- drivers/atm/Kconfig | 2 +- drivers/block/floppy.c | 4 +- drivers/bus/ti-sysc.c | 19 +++--- drivers/dma/ti/dma-crossbar.c | 4 +- drivers/dma/ti/omap-dma.c | 4 +- drivers/firmware/google/vpd.c | 4 +- drivers/firmware/google/vpd_decode.c | 55 +++++++++------- drivers/firmware/google/vpd_decode.h | 6 +- drivers/fpga/altera-ps-spi.c | 11 ++-- drivers/hid/wacom_sys.c | 10 +-- drivers/hid/wacom_wac.c | 4 ++ drivers/i2c/busses/i2c-designware-slave.c | 1 + drivers/infiniband/core/cma.c | 7 +-- drivers/infiniband/core/restrack.c | 6 +- drivers/input/mouse/elan_i2c_core.c | 2 +- drivers/iommu/amd_iommu.c | 40 ++++++++++-- drivers/media/usb/dvb-usb/technisat-usb2.c | 22 +++---- drivers/media/usb/tm6000/tm6000-dvb.c | 3 + drivers/net/ethernet/amd/xgbe/xgbe-main.c | 10 ++- drivers/net/ethernet/aquantia/atlantic/aq_vec.c | 3 +- drivers/net/ethernet/ibm/ibmvnic.c | 6 +- drivers/net/ethernet/marvell/sky2.c | 7 +++ drivers/net/ethernet/qlogic/qed/qed_main.c | 4 +- drivers/net/ethernet/seeq/sgiseeq.c | 7 ++- drivers/net/ieee802154/mac802154_hwsim.c | 8 ++- drivers/net/usb/r8152.c | 5 +- drivers/net/wireless/marvell/mwifiex/ie.c | 3 + drivers/net/wireless/marvell/mwifiex/uap_cmd.c | 9 ++- drivers/net/xen-netfront.c | 2 +- drivers/pci/controller/dwc/pcie-kirin.c | 4 +- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 2 + drivers/tty/serial/atmel_serial.c | 1 - drivers/tty/serial/sprd_serial.c | 2 +- drivers/usb/core/config.c | 12 ++-- drivers/usb/host/xhci-tegra.c | 10 +++ fs/binfmt_elf.c | 11 ++++ fs/cifs/connect.c | 22 +++++++ fs/nfs/dir.c | 2 +- fs/nfs/nfs4file.c | 12 ++-- fs/nfs/pagelist.c | 2 +- fs/nfs/proc.c | 7 ++- fs/overlayfs/ovl_entry.h | 1 + fs/overlayfs/super.c | 73 ++++++++++++++-------- include/net/sock_reuseport.h | 21 ++++++- include/uapi/linux/netfilter/xt_nfacct.h | 5 ++ kernel/kallsyms.c | 6 +- net/batman-adv/bat_v_ogm.c | 18 ++++-- net/bridge/netfilter/ebtables.c | 8 +-- net/core/filter.c | 8 +-- net/core/sock_reuseport.c | 15 ++++- net/ipv4/datagram.c | 2 + net/ipv4/udp.c | 5 +- net/ipv6/datagram.c | 2 + net/ipv6/ip6_gre.c | 2 +- net/ipv6/udp.c | 5 +- net/netfilter/nf_conntrack_ftp.c | 2 +- net/netfilter/nf_flow_table_core.c | 2 +- net/netfilter/nft_flow_offload.c | 6 ++ net/netfilter/xt_nfacct.c | 36 +++++++---- net/netfilter/xt_physdev.c | 6 +- net/sched/sch_generic.c | 3 + net/wireless/nl80211.c | 4 +- net/xdp/xdp_umem.c | 4 +- security/keys/request_key_auth.c | 6 ++ tools/bpf/bpftool/prog.c | 4 +- tools/power/x86/turbostat/turbostat.c | 2 +- .../x86_energy_perf_policy.c | 28 +++++---- tools/testing/selftests/bpf/test_sock.c | 7 ++- virt/kvm/coalesced_mmio.c | 17 ++--- 92 files changed, 561 insertions(+), 290 deletions(-)

5 years

7
88
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror September 2019