August 2019 - Linux-stable-mirror

[PATCH 4.9 000/103] 4.9.190-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.9.190 release. There are 103 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat 24 Aug 2019 05:15:44 PM UTC. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.190-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.9.190-rc1 YueHaibing <yuehaibing(a)huawei.com> bonding: Add vlan tx offload to hw_enc_features YueHaibing <yuehaibing(a)huawei.com> team: Add vlan tx offload to hw_enc_features Maxim Mikityanskiy <maximmi(a)mellanox.com> net/mlx5e: Use flow keys dissector to parse packets for ARFS Huy Nguyen <huyn(a)mellanox.com> net/mlx5e: Only support tx/rx pause setting for port owner Ross Lagerwall <ross.lagerwall(a)citrix.com> xen/netback: Reset nr_frags before freeing skb Xin Long <lucien.xin(a)gmail.com> sctp: fix the transport error_count check Eric Dumazet <edumazet(a)google.com> net/packet: fix race in tpacket_snd() Manish Chopra <manishc(a)marvell.com> bnx2x: Fix VF's VLAN reconfiguration in reload. Joerg Roedel <jroedel(a)suse.de> iommu/amd: Move iommu_init_pci() to .init section YueHaibing <yuehaibing(a)huawei.com> Input: psmouse - fix build error of multiple definition Dirk Morris <dmorris(a)metaloft.com> netfilter: conntrack: Use consistent ct id hash calculation Will Deacon <will(a)kernel.org> arm64: compat: Allow single-byte watchpoints on all addresses Daniel Borkmann <daniel(a)iogearbox.net> bpf: fix bpf_jit_limit knob for PAGE_SIZE >= 64K Qian Cai <cai(a)lca.pw> asm-generic: fix -Wtype-limits compiler warnings Tony Lindgren <tony(a)atomide.com> USB: serial: option: Add Motorola modem UARTs Bob Ham <bob.ham(a)puri.sm> USB: serial: option: add the BroadMobi BM818 card Yoshiaki Okamoto <yokamoto(a)allied-telesis.co.jp> USB: serial: option: Add support for ZTE MF871A Rogan Dawes <rogan(a)dawes.za.net> USB: serial: option: add D-Link DWM-222 device ID Oliver Neukum <oneukum(a)suse.com> USB: CDC: fix sanity checks in CDC union parser Oliver Neukum <oneukum(a)suse.com> usb: cdc-acm: make sure a refcount is taken early enough Alan Stern <stern(a)rowland.harvard.edu> USB: core: Fix races in character device registration and deregistraion Ian Abbott <abbotti(a)mev.co.uk> staging: comedi: dt3000: Fix rounding up of timer divisor Ian Abbott <abbotti(a)mev.co.uk> staging: comedi: dt3000: Fix signed integer overflow 'divider * base' YueHaibing <yuehaibing(a)huawei.com> ocfs2: remove set but not used variable 'last_hash' Jack Morgenstein <jackm(a)dev.mellanox.co.il> IB/mad: Fix use-after-free in ib mad completion handling Tony Luck <tony.luck(a)intel.com> IB/core: Add mitigation for Spectre V1 Qian Cai <cai(a)lca.pw> arm64/mm: fix variable 'pud' set but not used Qian Cai <cai(a)lca.pw> arm64/efi: fix variable 'si' set but not used Masahiro Yamada <yamada.masahiro(a)socionext.com> kbuild: modpost: handle KBUILD_EXTRA_SYMBOLS only for external modules Miquel Raynal <miquel.raynal(a)bootlin.com> ata: libahci: do not complain in case of deferred probe Don Brace <don.brace(a)microsemi.com> scsi: hpsa: correct scsi command status issue after reset Kees Cook <keescook(a)chromium.org> libata: zpodd: Fix small read overflow in zpodd_get_mech_type() Numfor Mbiziwo-Tiapo <nums(a)google.com> perf header: Fix use of unitialized value warning Vince Weaver <vincent.weaver(a)maine.edu> perf header: Fix divide by zero error if f_header.attr_size==0 Lucas Stach <l.stach(a)pengutronix.de> irqchip/irq-imx-gpcv2: Forward irq type to parent YueHaibing <yuehaibing(a)huawei.com> xen/pciback: remove set but not used variable 'old_state' Denis Kirjanov <kda(a)linux-powerpc.org> net: usb: pegasus: fix improper read if get_registers() fail Oliver Neukum <oneukum(a)suse.com> Input: iforce - add sanity checks Oliver Neukum <oneukum(a)suse.com> Input: kbtab - sanity check for endpoint type Hillf Danton <hdanton(a)sina.com> HID: hiddev: do cleanup in failure of opening a device Hillf Danton <hdanton(a)sina.com> HID: hiddev: avoid opening a disconnected device Oliver Neukum <oneukum(a)suse.com> HID: holtek: test for sanity of intfdata Hui Wang <hui.wang(a)canonical.com> ALSA: hda - Let all conexant codec enter D3 when rebooting Hui Wang <hui.wang(a)canonical.com> ALSA: hda - Add a generic reboot_notify Wenwen Wang <wenwen(a)cs.uga.edu> ALSA: hda - Fix a memory leak bug Max Filippov <jcmvbkbc(a)gmail.com> xtensa: add missing isync to the cpu_reset TLB code Florian Westphal <fw(a)strlen.de> netfilter: ctnetlink: don't use conntrack/expect object addresses as id Eric Dumazet <edumazet(a)google.com> inet: switch IP ID generator to siphash Jason A. Donenfeld <Jason(a)zx2c4.com> siphash: implement HalfSipHash1-3 for hash tables Jason A. Donenfeld <Jason(a)zx2c4.com> siphash: add cryptographically secure PRF Jason Wang <jasowang(a)redhat.com> vhost: scsi: add weight support Jason Wang <jasowang(a)redhat.com> vhost_net: fix possible infinite loop Jason Wang <jasowang(a)redhat.com> vhost: introduce vhost_exceeds_weight() Jason Wang <jasowang(a)redhat.com> vhost_net: introduce vhost_exceeds_weight() Paolo Abeni <pabeni(a)redhat.com> vhost_net: use packet weight for rx handler, too haibinzhang(张海斌) <haibinzhang(a)tencent.com> vhost-net: set packet weight of tx polling to 2 * vq size Daniel Borkmann <daniel(a)iogearbox.net> bpf: add bpf_jit_limit knob to restrict unpriv allocations Daniel Borkmann <daniel(a)iogearbox.net> bpf: restrict access to core bpf sysctls Daniel Borkmann <daniel(a)iogearbox.net> bpf: get rid of pure_initcall dependency to enable jits Miles Chen <miles.chen(a)mediatek.com> mm/memcontrol.c: fix use after free in mem_cgroup_iter() Isaac J. Manjarres <isaacm(a)codeaurora.org> mm/usercopy: use memory range to be accessed for wraparound check Gustavo A. R. Silva <gustavo(a)embeddedor.com> sh: kernel: hw_breakpoint: Fix missing break in switch statement Suganath Prabu <suganath-prabu.subramani(a)broadcom.com> scsi: mpt3sas: Use 63-bit DMA addressing on SAS35 HBA Emmanuel Grumbach <emmanuel.grumbach(a)intel.com> iwlwifi: don't unmap as page memory that was mapped as single Brian Norris <briannorris(a)chromium.org> mwifiex: fix 802.11n/WPA detection Steve French <stfrench(a)microsoft.com> smb3: send CAP_DFS capability during session setup Pavel Shilovsky <pshilov(a)microsoft.com> SMB3: Fix deadlock in validate negotiate hits reconnect Brian Norris <briannorris(a)chromium.org> mac80211: don't WARN on short WMM parameters from AP Takashi Iwai <tiwai(a)suse.de> ALSA: hda - Don't override global PCM hw info flag Wenwen Wang <wenwen(a)cs.uga.edu> ALSA: firewire: fix a memory leak bug Guenter Roeck <linux(a)roeck-us.net> hwmon: (nct7802) Fix wrong detection of in4 presence Tomas Bortoli <tomasbortoli(a)gmail.com> can: peak_usb: pcan_usb_fd: Fix info-leaks to USB devices Tomas Bortoli <tomasbortoli(a)gmail.com> can: peak_usb: pcan_usb_pro: Fix info-leaks to USB devices Leonard Crestez <leonard.crestez(a)nxp.com> perf/core: Fix creating kernel counters for PMUs that override event->cpu Peter Zijlstra <peterz(a)infradead.org> tty/ldsem, locking/rwsem: Add missing ACQUIRE to read_failed sleep loop Hannes Reinecke <hare(a)suse.de> scsi: scsi_dh_alua: always use a 2 second delay before retrying RTPG Tyrel Datwyler <tyreld(a)linux.vnet.ibm.com> scsi: ibmvfc: fix WARN_ON during event pool release Junxiao Bi <junxiao.bi(a)oracle.com> scsi: megaraid_sas: fix panic on loading firmware crashdump Arnd Bergmann <arnd(a)arndb.de> ARM: davinci: fix sleep.S build error on ARMv4 Lorenzo Pieralisi <lorenzo.pieralisi(a)arm.com> ACPI/IORT: Fix off-by-one check in iort_dev_find_its_id() Arnd Bergmann <arnd(a)arndb.de> drbd: dynamically allocate shash descriptor Arnaldo Carvalho de Melo <acme(a)redhat.com> perf probe: Avoid calling freeing routine multiple times for same pointer Charles Keepax <ckeepax(a)opensource.cirrus.com> ALSA: compress: Be more restrictive about when a drain is allowed Charles Keepax <ckeepax(a)opensource.cirrus.com> ALSA: compress: Don't allow paritial drain operations on capture streams Charles Keepax <ckeepax(a)opensource.cirrus.com> ALSA: compress: Prevent bypasses of set_params Charles Keepax <ckeepax(a)opensource.cirrus.com> ALSA: compress: Fix regression on compressed capture streams Julian Wiedmann <jwi(a)linux.ibm.com> s390/qdio: add sanity checks to the fast-requeue path Wen Yang <wen.yang99(a)zte.com.cn> cpufreq/pasemi: fix use-after-free in pas_cpufreq_cpu_init() Björn Gerhart <gerhart(a)posteo.de> hwmon: (nct6775) Fix register address and added missed tolerance for nct6106 Brian Norris <briannorris(a)chromium.org> mac80211: don't warn about CW params when not using them Thomas Tai <thomas.tai(a)oracle.com> iscsi_ibft: make ISCSI_IBFT dependson ACPI instead of ISCSI_IBFT_FIND Florian Westphal <fw(a)strlen.de> netfilter: nfnetlink: avoid deadlock due to synchronous request_module Stephane Grosjean <s.grosjean(a)peak-system.com> can: peak_usb: fix potential double kfree_skb() Suzuki K Poulose <suzuki.poulose(a)arm.com> usb: yurex: Fix use-after-free in yurex_delete Thomas Richter <tmricht(a)linux.ibm.com> perf record: Fix module size on s390 Adrian Hunter <adrian.hunter(a)intel.com> perf db-export: Fix thread__exec_comm() Thomas Richter <tmricht(a)linux.vnet.ibm.com> perf record: Fix wrong size in perf_record_mmap for last kernel module Joerg Roedel <jroedel(a)suse.de> mm/vmalloc: Sync unmappings in __purge_vmap_area_lazy() Joerg Roedel <jroedel(a)suse.de> x86/mm: Sync also unmappings in vmalloc_sync_all() Joerg Roedel <jroedel(a)suse.de> x86/mm: Check for pfn instead of page in vmalloc_sync_one() Wenwen Wang <wenwen(a)cs.uga.edu> sound: fix a memory leak bug Oliver Neukum <oneukum(a)suse.com> usb: iowarrior: fix deadlock on disconnect Gavin Li <git(a)thegavinli.com> usb: usbfs: fix double-free of usb memory upon submiturb error ------------- Diffstat: Documentation/siphash.txt | 175 +++++++ Documentation/sysctl/net.txt | 8 + MAINTAINERS | 7 + Makefile | 4 +- arch/arm/mach-davinci/sleep.S | 1 + arch/arm/net/bpf_jit_32.c | 2 - arch/arm64/include/asm/efi.h | 6 +- arch/arm64/include/asm/pgtable.h | 4 +- arch/arm64/kernel/hw_breakpoint.c | 7 +- arch/arm64/net/bpf_jit_comp.c | 2 - arch/mips/net/bpf_jit.c | 2 - arch/powerpc/net/bpf_jit_comp.c | 2 - arch/powerpc/net/bpf_jit_comp64.c | 2 - arch/s390/net/bpf_jit_comp.c | 2 - arch/sh/kernel/hw_breakpoint.c | 1 + arch/sparc/net/bpf_jit_comp.c | 2 - arch/x86/mm/fault.c | 15 +- arch/x86/net/bpf_jit_comp.c | 2 - arch/xtensa/kernel/setup.c | 1 + drivers/acpi/arm64/iort.c | 4 +- drivers/ata/libahci_platform.c | 3 + drivers/ata/libata-zpodd.c | 2 +- drivers/block/drbd/drbd_receiver.c | 14 +- drivers/cpufreq/pasemi-cpufreq.c | 23 +- drivers/firmware/Kconfig | 5 +- drivers/firmware/iscsi_ibft.c | 4 + drivers/hid/hid-holtek-kbd.c | 9 +- drivers/hid/usbhid/hiddev.c | 12 + drivers/hwmon/nct6775.c | 3 +- drivers/hwmon/nct7802.c | 6 +- drivers/infiniband/core/mad.c | 20 +- drivers/infiniband/core/user_mad.c | 6 +- drivers/input/joystick/iforce/iforce-usb.c | 5 + drivers/input/mouse/trackpoint.h | 3 +- drivers/input/tablet/kbtab.c | 6 +- drivers/iommu/amd_iommu_init.c | 2 +- drivers/irqchip/irq-imx-gpcv2.c | 1 + drivers/net/bonding/bond_main.c | 4 +- drivers/net/can/usb/peak_usb/pcan_usb_core.c | 8 +- drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 2 +- drivers/net/can/usb/peak_usb/pcan_usb_pro.c | 2 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 7 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 2 + drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 17 +- drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 97 ++-- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 3 + drivers/net/team/team.c | 4 +- drivers/net/usb/pegasus.c | 2 +- drivers/net/wireless/intel/iwlwifi/pcie/tx.c | 2 + drivers/net/wireless/marvell/mwifiex/main.h | 1 + drivers/net/wireless/marvell/mwifiex/scan.c | 3 +- drivers/net/xen-netback/netback.c | 2 + drivers/s390/cio/qdio_main.c | 12 +- drivers/scsi/device_handler/scsi_dh_alua.c | 7 +- drivers/scsi/hpsa.c | 12 +- drivers/scsi/ibmvscsi/ibmvfc.c | 2 +- drivers/scsi/megaraid/megaraid_sas_base.c | 3 + drivers/scsi/mpt3sas/mpt3sas_base.c | 12 +- drivers/staging/comedi/drivers/dt3000.c | 8 +- drivers/tty/tty_ldsem.c | 5 +- drivers/usb/class/cdc-acm.c | 12 +- drivers/usb/core/devio.c | 2 - drivers/usb/core/file.c | 10 +- drivers/usb/core/message.c | 4 +- drivers/usb/misc/iowarrior.c | 7 +- drivers/usb/misc/yurex.c | 2 +- drivers/usb/serial/option.c | 10 + drivers/vhost/net.c | 34 +- drivers/vhost/scsi.c | 15 +- drivers/vhost/vhost.c | 20 +- drivers/vhost/vhost.h | 6 +- drivers/vhost/vsock.c | 12 +- drivers/xen/xen-pciback/conf_space_capability.c | 3 +- fs/cifs/smb2pdu.c | 7 +- fs/ocfs2/xattr.c | 3 - include/asm-generic/getorder.h | 50 +- include/linux/filter.h | 1 + include/linux/siphash.h | 145 ++++++ include/net/netfilter/nf_conntrack.h | 2 + include/net/netns/ipv4.h | 2 + include/sound/compress_driver.h | 5 +- kernel/bpf/core.c | 73 ++- kernel/events/core.c | 2 +- lib/Kconfig.debug | 6 +- lib/Makefile | 5 +- lib/siphash.c | 551 +++++++++++++++++++++ lib/test_siphash.c | 223 +++++++++ mm/memcontrol.c | 39 +- mm/usercopy.c | 2 +- mm/vmalloc.c | 9 + net/core/sysctl_net_core.c | 71 ++- net/ipv4/route.c | 12 +- net/ipv6/output_core.c | 30 +- net/mac80211/driver-ops.c | 13 +- net/mac80211/mlme.c | 10 + net/netfilter/nf_conntrack_core.c | 35 ++ net/netfilter/nf_conntrack_netlink.c | 34 +- net/netfilter/nfnetlink.c | 2 +- net/packet/af_packet.c | 7 + net/sctp/sm_sideeffect.c | 2 +- net/socket.c | 9 - scripts/Makefile.modpost | 2 +- sound/core/compress_offload.c | 60 ++- sound/firewire/packets-buffer.c | 2 +- sound/pci/hda/hda_controller.c | 6 +- sound/pci/hda/hda_generic.c | 21 +- sound/pci/hda/hda_generic.h | 1 + sound/pci/hda/patch_conexant.c | 15 +- sound/pci/hda/patch_realtek.c | 11 +- sound/sound_core.c | 3 +- tools/perf/arch/s390/util/machine.c | 14 +- tools/perf/builtin-probe.c | 10 + tools/perf/util/header.c | 9 +- tools/perf/util/machine.c | 7 +- tools/perf/util/machine.h | 2 +- tools/perf/util/symbol-elf.c | 2 +- tools/perf/util/symbol.c | 21 +- tools/perf/util/symbol.h | 2 +- tools/perf/util/thread.c | 12 +- 119 files changed, 1894 insertions(+), 383 deletions(-)

5 years, 4 months

6
108
0 0

[PATCH 4.14 00/71] 4.14.140-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.14.140 release. There are 71 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat 24 Aug 2019 05:15:46 PM UTC. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.140-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.14.140-rc1 Florian Westphal <fw(a)strlen.de> xfrm: policy: remove pcpu policy cache Michal Simek <michal.simek(a)xilinx.com> mmc: sdhci-of-arasan: Do now show error message in case of deffered probe YueHaibing <yuehaibing(a)huawei.com> bonding: Add vlan tx offload to hw_enc_features YueHaibing <yuehaibing(a)huawei.com> team: Add vlan tx offload to hw_enc_features Maxim Mikityanskiy <maximmi(a)mellanox.com> net/mlx5e: Use flow keys dissector to parse packets for ARFS Huy Nguyen <huyn(a)mellanox.com> net/mlx5e: Only support tx/rx pause setting for port owner Ross Lagerwall <ross.lagerwall(a)citrix.com> xen/netback: Reset nr_frags before freeing skb Xin Long <lucien.xin(a)gmail.com> sctp: fix the transport error_count check Eric Dumazet <edumazet(a)google.com> net/packet: fix race in tpacket_snd() Wenwen Wang <wenwen(a)cs.uga.edu> net/mlx4_en: fix a memory leak bug Manish Chopra <manishc(a)marvell.com> bnx2x: Fix VF's VLAN reconfiguration in reload. Joerg Roedel <jroedel(a)suse.de> iommu/amd: Move iommu_init_pci() to .init section YueHaibing <yuehaibing(a)huawei.com> Input: psmouse - fix build error of multiple definition Dirk Morris <dmorris(a)metaloft.com> netfilter: conntrack: Use consistent ct id hash calculation Will Deacon <will(a)kernel.org> arm64: ftrace: Ensure module ftrace trampoline is coherent with I-side Will Deacon <will(a)kernel.org> arm64: compat: Allow single-byte watchpoints on all addresses Sasha Levin <sashal(a)kernel.org> Revert "tcp: Clear sk_send_head after purging the write queue" Daniel Borkmann <daniel(a)iogearbox.net> bpf: fix bpf_jit_limit knob for PAGE_SIZE >= 64K Tony Lindgren <tony(a)atomide.com> USB: serial: option: Add Motorola modem UARTs Bob Ham <bob.ham(a)puri.sm> USB: serial: option: add the BroadMobi BM818 card Yoshiaki Okamoto <yokamoto(a)allied-telesis.co.jp> USB: serial: option: Add support for ZTE MF871A Rogan Dawes <rogan(a)dawes.za.net> USB: serial: option: add D-Link DWM-222 device ID Oliver Neukum <oneukum(a)suse.com> USB: CDC: fix sanity checks in CDC union parser Oliver Neukum <oneukum(a)suse.com> usb: cdc-acm: make sure a refcount is taken early enough Yoshihiro Shimoda <yoshihiro.shimoda.uh(a)renesas.com> usb: gadget: udc: renesas_usb3: Fix sysfs interface of "role" Alan Stern <stern(a)rowland.harvard.edu> USB: core: Fix races in character device registration and deregistraion Jacopo Mondi <jacopo+renesas(a)jmondi.org> iio: adc: max9611: Fix temperature reading in probe Ian Abbott <abbotti(a)mev.co.uk> staging: comedi: dt3000: Fix rounding up of timer divisor Ian Abbott <abbotti(a)mev.co.uk> staging: comedi: dt3000: Fix signed integer overflow 'divider * base' Marc Zyngier <maz(a)kernel.org> KVM: arm/arm64: Sync ICH_VMCR_EL2 back when about to block Qian Cai <cai(a)lca.pw> asm-generic: fix -Wtype-limits compiler warnings YueHaibing <yuehaibing(a)huawei.com> ocfs2: remove set but not used variable 'last_hash' Jeffrey Hugo <jeffrey.l.hugo(a)gmail.com> drm: msm: Fix add_gpu_components Jack Morgenstein <jackm(a)dev.mellanox.co.il> IB/mad: Fix use-after-free in ib mad completion handling Tony Luck <tony.luck(a)intel.com> IB/core: Add mitigation for Spectre V1 Qian Cai <cai(a)lca.pw> arm64/mm: fix variable 'pud' set but not used Masami Hiramatsu <mhiramat(a)kernel.org> arm64: unwind: Prohibit probing on return_address() Qian Cai <cai(a)lca.pw> arm64/efi: fix variable 'si' set but not used Masahiro Yamada <yamada.masahiro(a)socionext.com> kbuild: modpost: handle KBUILD_EXTRA_SYMBOLS only for external modules Miquel Raynal <miquel.raynal(a)bootlin.com> ata: libahci: do not complain in case of deferred probe Jia-Ju Bai <baijiaju1990(a)gmail.com> scsi: qla2xxx: Fix possible fcport null-pointer dereferences Don Brace <don.brace(a)microsemi.com> scsi: hpsa: correct scsi command status issue after reset YueHaibing <yuehaibing(a)huawei.com> drm/bridge: lvds-encoder: Fix build error while CONFIG_DRM_KMS_HELPER=m Kees Cook <keescook(a)chromium.org> libata: zpodd: Fix small read overflow in zpodd_get_mech_type() Numfor Mbiziwo-Tiapo <nums(a)google.com> perf header: Fix use of unitialized value warning Vince Weaver <vincent.weaver(a)maine.edu> perf header: Fix divide by zero error if f_header.attr_size==0 Lucas Stach <l.stach(a)pengutronix.de> irqchip/irq-imx-gpcv2: Forward irq type to parent Nianyao Tang <tangnianyao(a)huawei.com> irqchip/gic-v3-its: Free unused vpt_page when alloc vpe table fail YueHaibing <yuehaibing(a)huawei.com> xen/pciback: remove set but not used variable 'old_state' Geert Uytterhoeven <geert+renesas(a)glider.be> clk: renesas: cpg-mssr: Fix reset control race condition Codrin Ciubotariu <codrin.ciubotariu(a)microchip.com> clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1 Florian Westphal <fw(a)strlen.de> netfilter: ebtables: also count base chain policies Denis Kirjanov <kda(a)linux-powerpc.org> net: usb: pegasus: fix improper read if get_registers() fail Oliver Neukum <oneukum(a)suse.com> Input: iforce - add sanity checks Oliver Neukum <oneukum(a)suse.com> Input: kbtab - sanity check for endpoint type Hillf Danton <hdanton(a)sina.com> HID: hiddev: do cleanup in failure of opening a device Hillf Danton <hdanton(a)sina.com> HID: hiddev: avoid opening a disconnected device Oliver Neukum <oneukum(a)suse.com> HID: holtek: test for sanity of intfdata Hui Wang <hui.wang(a)canonical.com> ALSA: hda - Let all conexant codec enter D3 when rebooting Hui Wang <hui.wang(a)canonical.com> ALSA: hda - Add a generic reboot_notify Wenwen Wang <wenwen(a)cs.uga.edu> ALSA: hda - Fix a memory leak bug Takashi Iwai <tiwai(a)suse.de> ALSA: hda - Apply workaround for another AMD chip 1022:1487 Max Filippov <jcmvbkbc(a)gmail.com> xtensa: add missing isync to the cpu_reset TLB code Nadav Amit <namit(a)vmware.com> x86/mm: Use WRITE_ONCE() when setting PTEs Daniel Borkmann <daniel(a)iogearbox.net> bpf: add bpf_jit_limit knob to restrict unpriv allocations Daniel Borkmann <daniel(a)iogearbox.net> bpf: restrict access to core bpf sysctls Daniel Borkmann <daniel(a)iogearbox.net> bpf: get rid of pure_initcall dependency to enable jits Miles Chen <miles.chen(a)mediatek.com> mm/memcontrol.c: fix use after free in mem_cgroup_iter() Isaac J. Manjarres <isaacm(a)codeaurora.org> mm/usercopy: use memory range to be accessed for wraparound check Gustavo A. R. Silva <gustavo(a)embeddedor.com> sh: kernel: hw_breakpoint: Fix missing break in switch statement Suganath Prabu <suganath-prabu.subramani(a)broadcom.com> scsi: mpt3sas: Use 63-bit DMA addressing on SAS35 HBA ------------- Diffstat: Documentation/sysctl/net.txt | 8 ++ Makefile | 4 +- arch/arm/net/bpf_jit_32.c | 2 - arch/arm64/include/asm/efi.h | 6 +- arch/arm64/include/asm/pgtable.h | 4 +- arch/arm64/kernel/ftrace.c | 21 ++-- arch/arm64/kernel/hw_breakpoint.c | 7 +- arch/arm64/kernel/return_address.c | 3 + arch/arm64/kernel/stacktrace.c | 3 + arch/arm64/net/bpf_jit_comp.c | 2 - arch/mips/net/bpf_jit.c | 2 - arch/mips/net/ebpf_jit.c | 2 - arch/powerpc/net/bpf_jit_comp.c | 2 - arch/powerpc/net/bpf_jit_comp64.c | 2 - arch/s390/net/bpf_jit_comp.c | 2 - arch/sh/kernel/hw_breakpoint.c | 1 + arch/sparc/net/bpf_jit_comp_32.c | 2 - arch/sparc/net/bpf_jit_comp_64.c | 2 - arch/x86/include/asm/pgtable_64.h | 22 ++-- arch/x86/mm/pgtable.c | 8 +- arch/x86/net/bpf_jit_comp.c | 2 - arch/xtensa/kernel/setup.c | 1 + drivers/ata/libahci_platform.c | 3 + drivers/ata/libata-zpodd.c | 2 +- drivers/clk/at91/clk-generated.c | 2 + drivers/clk/renesas/renesas-cpg-mssr.c | 16 +-- drivers/gpu/drm/bridge/Kconfig | 1 + drivers/gpu/drm/msm/msm_drv.c | 3 +- drivers/hid/hid-holtek-kbd.c | 9 +- drivers/hid/usbhid/hiddev.c | 12 ++ drivers/iio/adc/max9611.c | 2 +- drivers/infiniband/core/mad.c | 20 +-- drivers/infiniband/core/user_mad.c | 6 +- drivers/input/joystick/iforce/iforce-usb.c | 5 + drivers/input/mouse/trackpoint.h | 3 +- drivers/input/tablet/kbtab.c | 6 +- drivers/iommu/amd_iommu_init.c | 2 +- drivers/irqchip/irq-gic-v3-its.c | 2 +- drivers/irqchip/irq-imx-gpcv2.c | 1 + drivers/mmc/host/sdhci-of-arasan.c | 3 +- drivers/net/bonding/bond_main.c | 4 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 7 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 2 + drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 17 ++- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 3 +- drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 97 +++++---------- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 3 + drivers/net/team/team.c | 4 +- drivers/net/usb/pegasus.c | 2 +- drivers/net/xen-netback/netback.c | 2 + drivers/scsi/hpsa.c | 12 +- drivers/scsi/mpt3sas/mpt3sas_base.c | 12 +- drivers/scsi/qla2xxx/qla_init.c | 2 +- drivers/staging/comedi/drivers/dt3000.c | 8 +- drivers/usb/class/cdc-acm.c | 12 +- drivers/usb/core/file.c | 10 +- drivers/usb/core/message.c | 4 +- drivers/usb/gadget/udc/renesas_usb3.c | 5 +- drivers/usb/serial/option.c | 10 ++ drivers/xen/xen-pciback/conf_space_capability.c | 3 +- fs/ocfs2/xattr.c | 3 - include/asm-generic/getorder.h | 50 +++----- include/kvm/arm_vgic.h | 1 + include/linux/filter.h | 1 + include/net/tcp.h | 3 - include/net/xfrm.h | 1 - kernel/bpf/core.c | 77 ++++++++++-- mm/memcontrol.c | 39 ++++-- mm/usercopy.c | 2 +- net/bridge/netfilter/ebtables.c | 28 +++-- net/core/sysctl_net_core.c | 75 +++++++++-- net/netfilter/nf_conntrack_core.c | 16 +-- net/packet/af_packet.c | 7 ++ net/sctp/sm_sideeffect.c | 2 +- net/socket.c | 9 -- net/xfrm/xfrm_device.c | 10 -- net/xfrm/xfrm_policy.c | 138 +-------------------- net/xfrm/xfrm_state.c | 5 +- scripts/Makefile.modpost | 2 +- sound/pci/hda/hda_generic.c | 21 +++- sound/pci/hda/hda_generic.h | 1 + sound/pci/hda/hda_intel.c | 3 + sound/pci/hda/patch_conexant.c | 15 +-- sound/pci/hda/patch_realtek.c | 11 +- tools/perf/util/header.c | 9 +- virt/kvm/arm/arm.c | 10 ++ virt/kvm/arm/vgic/vgic-v2.c | 11 +- virt/kvm/arm/vgic/vgic-v3.c | 7 +- virt/kvm/arm/vgic/vgic.c | 11 ++ virt/kvm/arm/vgic/vgic.h | 2 + 90 files changed, 532 insertions(+), 463 deletions(-)

5 years, 4 months

7
78
0 0

[PATCH 4.19 00/85] 4.19.68-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.68 release. There are 85 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat 24 Aug 2019 05:15:49 PM UTC. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.68-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.68-rc1 Michal Simek <michal.simek(a)xilinx.com> mmc: sdhci-of-arasan: Do now show error message in case of deffered probe Maxim Mikityanskiy <maximmi(a)mellanox.com> net/mlx5e: Use flow keys dissector to parse packets for ARFS Huy Nguyen <huyn(a)mellanox.com> net/mlx5e: Only support tx/rx pause setting for port owner Ross Lagerwall <ross.lagerwall(a)citrix.com> xen/netback: Reset nr_frags before freeing skb Chris Packham <chris.packham(a)alliedtelesis.co.nz> tipc: initialise addr_trail_end when setting node addresses YueHaibing <yuehaibing(a)huawei.com> team: Add vlan tx offload to hw_enc_features Xin Long <lucien.xin(a)gmail.com> sctp: fix the transport error_count check zhengbin <zhengbin13(a)huawei.com> sctp: fix memleak in sctp_send_reset_streams Eric Dumazet <edumazet(a)google.com> net/packet: fix race in tpacket_snd() Wenwen Wang <wenwen(a)cs.uga.edu> net/mlx4_en: fix a memory leak bug Chen-Yu Tsai <wens(a)csie.org> net: dsa: Check existence of .port_mdb_add callback before calling it YueHaibing <yuehaibing(a)huawei.com> bonding: Add vlan tx offload to hw_enc_features Manish Chopra <manishc(a)marvell.com> bnx2x: Fix VF's VLAN reconfiguration in reload. Joerg Roedel <jroedel(a)suse.de> iommu/amd: Move iommu_init_pci() to .init section YueHaibing <yuehaibing(a)huawei.com> Input: psmouse - fix build error of multiple definition Dirk Morris <dmorris(a)metaloft.com> netfilter: conntrack: Use consistent ct id hash calculation Will Deacon <will(a)kernel.org> arm64: ftrace: Ensure module ftrace trampoline is coherent with I-side Mike Snitzer <snitzer(a)redhat.com> dm: disable DISCARD if the underlying storage no longer supports it Rodrigo Vivi <rodrigo.vivi(a)intel.com> drm/i915/cfl: Add a new CFL PCI ID. Tony Lindgren <tony(a)atomide.com> USB: serial: option: Add Motorola modem UARTs Bob Ham <bob.ham(a)puri.sm> USB: serial: option: add the BroadMobi BM818 card Yoshiaki Okamoto <yokamoto(a)allied-telesis.co.jp> USB: serial: option: Add support for ZTE MF871A Rogan Dawes <rogan(a)dawes.za.net> USB: serial: option: add D-Link DWM-222 device ID Oliver Neukum <oneukum(a)suse.com> USB: CDC: fix sanity checks in CDC union parser Oliver Neukum <oneukum(a)suse.com> usb: cdc-acm: make sure a refcount is taken early enough Yoshihiro Shimoda <yoshihiro.shimoda.uh(a)renesas.com> usb: gadget: udc: renesas_usb3: Fix sysfs interface of "role" Alan Stern <stern(a)rowland.harvard.edu> USB: core: Fix races in character device registration and deregistraion Jacopo Mondi <jacopo+renesas(a)jmondi.org> iio: adc: max9611: Fix temperature reading in probe Ian Abbott <abbotti(a)mev.co.uk> staging: comedi: dt3000: Fix rounding up of timer divisor Ian Abbott <abbotti(a)mev.co.uk> staging: comedi: dt3000: Fix signed integer overflow 'divider * base' Marc Zyngier <maz(a)kernel.org> KVM: arm/arm64: Sync ICH_VMCR_EL2 back when about to block Anders Roxell <anders.roxell(a)linaro.org> arm64: KVM: regmap: Fix unexpected switch fall-through Qian Cai <cai(a)lca.pw> asm-generic: fix -Wtype-limits compiler warnings YueHaibing <yuehaibing(a)huawei.com> ocfs2: remove set but not used variable 'last_hash' Yang Shi <yang.shi(a)linux.alibaba.com> Revert "kmemleak: allow to coexist with fault injection" Colin Ian King <colin.king(a)canonical.com> drm/exynos: fix missing decrement of retry counter Jeffrey Hugo <jeffrey.l.hugo(a)gmail.com> drm: msm: Fix add_gpu_components Jack Morgenstein <jackm(a)dev.mellanox.co.il> IB/mad: Fix use-after-free in ib mad completion handling Guy Levi <guyle(a)mellanox.com> IB/mlx5: Fix MR registration flow to use UMR properly Tony Luck <tony.luck(a)intel.com> IB/core: Add mitigation for Spectre V1 Qian Cai <cai(a)lca.pw> arm64/mm: fix variable 'pud' set but not used Masami Hiramatsu <mhiramat(a)kernel.org> arm64: unwind: Prohibit probing on return_address() Qian Cai <cai(a)lca.pw> arm64/efi: fix variable 'si' set but not used Stephen Boyd <swboyd(a)chromium.org> kbuild: Check for unknown options with cc-option usage in Kconfig and clang Masahiro Yamada <yamada.masahiro(a)socionext.com> kbuild: modpost: handle KBUILD_EXTRA_SYMBOLS only for external modules Miquel Raynal <miquel.raynal(a)bootlin.com> ata: libahci: do not complain in case of deferred probe Wang Xiayang <xywang.sjtu(a)sjtu.edu.cn> drm/amdgpu: fix a potential information leaking bug Jia-Ju Bai <baijiaju1990(a)gmail.com> scsi: qla2xxx: Fix possible fcport null-pointer dereferences Don Brace <don.brace(a)microsemi.com> scsi: hpsa: correct scsi command status issue after reset Filipe Manana <fdmanana(a)suse.com> Btrfs: fix deadlock between fiemap and transaction commits YueHaibing <yuehaibing(a)huawei.com> drm/bridge: lvds-encoder: Fix build error while CONFIG_DRM_KMS_HELPER=m Kees Cook <keescook(a)chromium.org> libata: zpodd: Fix small read overflow in zpodd_get_mech_type() Numfor Mbiziwo-Tiapo <nums(a)google.com> perf header: Fix use of unitialized value warning Vince Weaver <vincent.weaver(a)maine.edu> perf header: Fix divide by zero error if f_header.attr_size==0 Lucas Stach <l.stach(a)pengutronix.de> irqchip/irq-imx-gpcv2: Forward irq type to parent Nianyao Tang <tangnianyao(a)huawei.com> irqchip/gic-v3-its: Free unused vpt_page when alloc vpe table fail YueHaibing <yuehaibing(a)huawei.com> xen/pciback: remove set but not used variable 'old_state' Geert Uytterhoeven <geert+renesas(a)glider.be> clk: renesas: cpg-mssr: Fix reset control race condition Chunyan Zhang <chunyan.zhang(a)unisoc.com> clk: sprd: Select REGMAP_MMIO to avoid compile errors Codrin Ciubotariu <codrin.ciubotariu(a)microchip.com> clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1 Vincent Chen <vincent.chen(a)sifive.com> riscv: Make __fstate_clean() work correctly. Florian Westphal <fw(a)strlen.de> netfilter: ebtables: also count base chain policies Denis Kirjanov <kda(a)linux-powerpc.org> net: usb: pegasus: fix improper read if get_registers() fail Oliver Neukum <oneukum(a)suse.com> Input: iforce - add sanity checks Oliver Neukum <oneukum(a)suse.com> Input: kbtab - sanity check for endpoint type Hillf Danton <hdanton(a)sina.com> HID: hiddev: do cleanup in failure of opening a device Hillf Danton <hdanton(a)sina.com> HID: hiddev: avoid opening a disconnected device Oliver Neukum <oneukum(a)suse.com> HID: holtek: test for sanity of intfdata Hui Wang <hui.wang(a)canonical.com> ALSA: hda - Let all conexant codec enter D3 when rebooting Hui Wang <hui.wang(a)canonical.com> ALSA: hda - Add a generic reboot_notify Wenwen Wang <wenwen(a)cs.uga.edu> ALSA: hda - Fix a memory leak bug Takashi Iwai <tiwai(a)suse.de> ALSA: hda - Apply workaround for another AMD chip 1022:1487 Hui Peng <benquike(a)gmail.com> ALSA: usb-audio: Fix an OOB bug in parse_audio_mixer_unit Hui Peng <benquike(a)gmail.com> ALSA: usb-audio: Fix a stack buffer overflow bug in check_input_term Takashi Iwai <tiwai(a)suse.de> ALSA: hda/realtek - Add quirk for HP Envy x360 Max Filippov <jcmvbkbc(a)gmail.com> xtensa: add missing isync to the cpu_reset TLB code Viresh Kumar <viresh.kumar(a)linaro.org> cpufreq: schedutil: Don't skip freq update when limits change Fabrice Gasnier <fabrice.gasnier(a)st.com> Revert "pwm: Set class for exported channels in sysfs" Isaac J. Manjarres <isaacm(a)codeaurora.org> mm/usercopy: use memory range to be accessed for wraparound check Miles Chen <miles.chen(a)mediatek.com> mm/memcontrol.c: fix use after free in mem_cgroup_iter() Yang Shi <yang.shi(a)linux.alibaba.com> mm: mempolicy: handle vma with unmovable pages mapped correctly in mbind Yang Shi <yang.shi(a)linux.alibaba.com> mm: mempolicy: make the behavior consistent when MPOL_MF_MOVE* and MPOL_MF_STRICT were specified Ralph Campbell <rcampbell(a)nvidia.com> mm/hmm: fix bad subpage pointer in try_to_unmap_one NeilBrown <neilb(a)suse.com> seq_file: fix problem when seeking mid-record Gustavo A. R. Silva <gustavo(a)embeddedor.com> sh: kernel: hw_breakpoint: Fix missing break in switch statement ------------- Diffstat: Makefile | 4 +- arch/arm64/include/asm/efi.h | 6 +- arch/arm64/include/asm/pgtable.h | 4 +- arch/arm64/kernel/ftrace.c | 21 +++-- arch/arm64/kernel/return_address.c | 3 + arch/arm64/kernel/stacktrace.c | 3 + arch/arm64/kvm/regmap.c | 5 ++ arch/riscv/include/asm/switch_to.h | 2 +- arch/sh/kernel/hw_breakpoint.c | 1 + arch/xtensa/kernel/setup.c | 1 + drivers/ata/libahci_platform.c | 3 + drivers/ata/libata-zpodd.c | 2 +- drivers/clk/at91/clk-generated.c | 2 + drivers/clk/renesas/renesas-cpg-mssr.c | 16 +--- drivers/clk/sprd/Kconfig | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- drivers/gpu/drm/bridge/Kconfig | 1 + drivers/gpu/drm/exynos/exynos_drm_scaler.c | 4 +- drivers/gpu/drm/msm/msm_drv.c | 3 +- drivers/hid/hid-holtek-kbd.c | 9 +- drivers/hid/usbhid/hiddev.c | 12 +++ drivers/iio/adc/max9611.c | 2 +- drivers/infiniband/core/mad.c | 20 ++--- drivers/infiniband/core/user_mad.c | 6 +- drivers/infiniband/hw/mlx5/mr.c | 27 ++---- drivers/input/joystick/iforce/iforce-usb.c | 5 ++ drivers/input/mouse/trackpoint.h | 3 +- drivers/input/tablet/kbtab.c | 6 +- drivers/iommu/amd_iommu_init.c | 2 +- drivers/irqchip/irq-gic-v3-its.c | 2 +- drivers/irqchip/irq-imx-gpcv2.c | 1 + drivers/md/dm-core.h | 1 + drivers/md/dm-rq.c | 11 ++- drivers/md/dm.c | 20 ++++- drivers/mmc/host/sdhci-of-arasan.c | 3 +- drivers/net/bonding/bond_main.c | 2 + drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 7 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 2 + drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 17 ++-- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 3 +- drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 97 +++++++------------- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 3 + drivers/net/team/team.c | 2 + drivers/net/usb/pegasus.c | 2 +- drivers/net/xen-netback/netback.c | 2 + drivers/pwm/sysfs.c | 1 - drivers/scsi/hpsa.c | 12 ++- drivers/scsi/qla2xxx/qla_init.c | 2 +- drivers/staging/comedi/drivers/dt3000.c | 8 +- drivers/usb/class/cdc-acm.c | 12 +-- drivers/usb/core/file.c | 10 +-- drivers/usb/core/message.c | 4 +- drivers/usb/gadget/udc/renesas_usb3.c | 5 +- drivers/usb/serial/option.c | 10 +++ drivers/xen/xen-pciback/conf_space_capability.c | 3 +- fs/btrfs/backref.c | 2 +- fs/btrfs/transaction.c | 22 ++++- fs/btrfs/transaction.h | 3 + fs/ocfs2/xattr.c | 3 - fs/seq_file.c | 2 +- include/asm-generic/getorder.h | 50 +++++------ include/drm/i915_pciids.h | 1 + include/kvm/arm_vgic.h | 1 + kernel/sched/cpufreq_schedutil.c | 14 ++- mm/kmemleak.c | 2 +- mm/memcontrol.c | 39 +++++--- mm/mempolicy.c | 100 +++++++++++++++------ mm/rmap.c | 8 ++ mm/usercopy.c | 2 +- net/bridge/netfilter/ebtables.c | 28 +++--- net/dsa/switch.c | 3 + net/netfilter/nf_conntrack_core.c | 16 ++-- net/packet/af_packet.c | 7 ++ net/sctp/sm_sideeffect.c | 2 +- net/sctp/stream.c | 1 + net/tipc/addr.c | 1 + scripts/Kconfig.include | 2 +- scripts/Makefile.modpost | 2 +- sound/pci/hda/hda_generic.c | 21 ++++- sound/pci/hda/hda_generic.h | 1 + sound/pci/hda/hda_intel.c | 3 + sound/pci/hda/patch_conexant.c | 15 +--- sound/pci/hda/patch_realtek.c | 12 +-- sound/usb/mixer.c | 37 ++++++-- tools/perf/util/header.c | 9 +- virt/kvm/arm/arm.c | 11 +++ virt/kvm/arm/vgic/vgic-v2.c | 9 +- virt/kvm/arm/vgic/vgic-v3.c | 7 +- virt/kvm/arm/vgic/vgic.c | 11 +++ virt/kvm/arm/vgic/vgic.h | 2 + 90 files changed, 551 insertions(+), 316 deletions(-)

5 years, 4 months

6
90
0 0

[PATCH] ext4: fix punch hole for inline_data file systems

by Theodore Ts'o

If a program attempts to punch a hole on an inline data file, we need to convert it to a normal file first. This was detected using ext4/032 using the adv configuration. Simple reproducer: mke2fs -Fq -t ext4 -O inline_data /dev/vdc mount /vdc echo "" > /vdc/testfile xfs_io -c 'truncate 33554432' /vdc/testfile xfs_io -c 'fpunch 0 1048576' /vdc/testfile umount /vdc e2fsck -fy /dev/vdc Cc: stable(a)vger.kernel.org Signed-off-by: Theodore Ts'o <tytso(a)mit.edu> --- fs/ext4/inode.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 2b1c58da8d1e..e567f0229d4e 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -4236,6 +4236,15 @@ int ext4_punch_hole(struct inode *inode, loff_t offset, loff_t length) trace_ext4_punch_hole(inode, offset, length, 0); + ext4_clear_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA); + if (ext4_has_inline_data(inode)) { + down_write(&EXT4_I(inode)->i_mmap_sem); + ret = ext4_convert_inline_data(inode); + up_write(&EXT4_I(inode)->i_mmap_sem); + if (ret) + return ret; + } + /* * Write out all dirty pages to avoid race conditions * Then release them. -- 2.23.0

5 years, 4 months

1
0
0 0

[PATCH v2] x86/mm/pti: in pti_clone_pgtable(), increase addr properly

by Song Liu

Before 32-bit support, pti_clone_pmds() always adds PMD_SIZE to addr. This behavior changes after the 32-bit support: pti_clone_pgtable() increases addr by PUD_SIZE for pud_none(*pud) case, and increases addr by PMD_SIZE for pmd_none(*pmd) case. However, this is not accurate because addr may not be PUD_SIZE/PMD_SIZE aligned. Fix this issue by properly rounding up addr to next PUD_SIZE/PMD_SIZE in these two cases. The following explains how we debugged this issue: We use huge page for hot text and thus reduces iTLB misses. As we benchmark 5.2 based kernel (vs. 4.16 based), we found ~2.5x more iTLB misses. To figure out the issue, I use a debug patch that dumps page table for a pid. The following are information from the workload pid. For the 4.16 based kernel: host-4.16 # grep "x pmd" /sys/kernel/debug/page_tables/dump_pid 0x0000000000600000-0x0000000000e00000 8M USR ro PSE x pmd 0xffffffff81a00000-0xffffffff81c00000 2M ro PSE x pmd For the 5.2 based kernel before this patch: host-5.2-before # grep "x pmd" /sys/kernel/debug/page_tables/dump_pid 0x0000000000600000-0x0000000000e00000 8M USR ro PSE x pmd The 8MB text in pmd is from user space. 4.16 kernel has 1 pmd for the irq entry table; while 4.16 kernel doesn't have it. For the 5.2 based kernel after this patch: host-5.2-after # grep "x pmd" /sys/kernel/debug/page_tables/dump_pid 0x0000000000600000-0x0000000000e00000 8M USR ro PSE x pmd 0xffffffff81000000-0xffffffff81e00000 14M ro PSE GLB x pmd So after this patch, the 5.2 based kernel has 7 PMDs instead of 1 PMD in 4.16 kernel. This further reduces iTLB miss rate Cc: stable(a)vger.kernel.org # v4.19+ Fixes: 16a3fe634f6a ("x86/mm/pti: Clone kernel-image on PTE level for 32 bit") Reviewed-by: Rik van Riel <riel(a)surriel.com> Signed-off-by: Song Liu <songliubraving(a)fb.com> Cc: Joerg Roedel <jroedel(a)suse.de> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: Dave Hansen <dave.hansen(a)linux.intel.com> Cc: Andy Lutomirski <luto(a)kernel.org> Cc: Peter Zijlstra <peterz(a)infradead.org> --- arch/x86/mm/pti.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c index b196524759ec..1337494e22ef 100644 --- a/arch/x86/mm/pti.c +++ b/arch/x86/mm/pti.c @@ -330,13 +330,13 @@ pti_clone_pgtable(unsigned long start, unsigned long end, pud = pud_offset(p4d, addr); if (pud_none(*pud)) { - addr += PUD_SIZE; + addr = round_up(addr + 1, PUD_SIZE); continue; } pmd = pmd_offset(pud, addr); if (pmd_none(*pmd)) { - addr += PMD_SIZE; + addr = round_up(addr + 1, PMD_SIZE); continue; } -- 2.17.1

5 years, 4 months

3
7
0 0

❌ FAIL: Test report for kernel 5.2.10-rc1-f5284fb.cki (stable)

by CKI Project

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: f5284fbdcd34 - Linux 5.2.10-rc1 The results of these automated tests are provided below. Overall result: FAILED (see details below) Merge: OK Compile: OK Tests: FAILED All kernel binaries, config files, and logs are available for download here: https://artifacts.cki-project.org/pipelines/117364 One or more kernel tests failed: x86_64: ❌ stress: stress-ng We hope that these logs can help you find the problem quickly. For the full detail on our testing procedures, please scroll to the bottom of this message. Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg s390x: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test [0] ✅ xfstests: ext4 [1] ✅ xfstests: xfs [1] ✅ selinux-policy: serge-testsuite [2] ✅ lvm thinp sanity [3] ✅ storage: software RAID testing [4] 🚧 ✅ Storage blktests [5] 🚧 ⚡⚡⚡ IOMMU boot test [6] Host 2: ✅ Boot test [0] ✅ Podman system integration test (as root) [7] ✅ Podman system integration test (as user) [7] ✅ LTP lite [8] ✅ Loopdev Sanity [9] ✅ jvm test suite [10] ✅ Memory function: memfd_create [11] ✅ AMTU (Abstract Machine Test Utility) [12] ✅ LTP: openposix test suite [13] ✅ Ethernet drivers sanity [14] ✅ Networking socket: fuzz [15] ✅ Networking sctp-auth: sockopts test [16] ✅ Networking: igmp conformance test [17] ✅ Networking TCP: keepalive test [18] ✅ Networking UDP: socket [19] ✅ Networking tunnel: gre basic [20] ✅ Networking tunnel: vxlan basic [21] ✅ audit: audit testsuite test [22] ✅ httpd: mod_ssl smoke sanity [23] ✅ iotop: sanity [24] ✅ tuned: tune-processes-through-perf [25] ✅ Usex - version 1.9-29 [26] ✅ storage: SCSI VPD [27] ✅ stress: stress-ng [28] 🚧 ✅ Networking route: pmtu [29] 🚧 ✅ Networking route_func: local [30] 🚧 ✅ Networking route_func: forward [30] 🚧 ✅ Networking tunnel: geneve basic test [31] 🚧 ✅ Networking ipsec: basic netns transport [32] 🚧 ✅ Networking ipsec: basic netns tunnel [32] 🚧 ✅ trace: ftrace/tracer [33] ppc64le: Host 1: ✅ Boot test [0] ✅ xfstests: ext4 [1] ✅ xfstests: xfs [1] ✅ selinux-policy: serge-testsuite [2] ✅ lvm thinp sanity [3] ✅ storage: software RAID testing [4] 🚧 ✅ Storage blktests [5] Host 2: ✅ Boot test [0] ✅ Podman system integration test (as root) [7] ✅ Podman system integration test (as user) [7] ✅ LTP lite [8] ✅ Loopdev Sanity [9] ✅ jvm test suite [10] ✅ Memory function: memfd_create [11] ✅ AMTU (Abstract Machine Test Utility) [12] ✅ LTP: openposix test suite [13] ✅ Ethernet drivers sanity [14] ✅ Networking socket: fuzz [15] ✅ Networking sctp-auth: sockopts test [16] ✅ Networking TCP: keepalive test [18] ✅ Networking UDP: socket [19] ✅ Networking tunnel: gre basic [20] ✅ Networking tunnel: vxlan basic [21] ✅ audit: audit testsuite test [22] ✅ httpd: mod_ssl smoke sanity [23] ✅ iotop: sanity [24] ✅ tuned: tune-processes-through-perf [25] ✅ Usex - version 1.9-29 [26] 🚧 ✅ Networking route: pmtu [29] 🚧 ✅ Networking route_func: local [30] 🚧 ✅ Networking route_func: forward [30] 🚧 ✅ Networking tunnel: geneve basic test [31] 🚧 ✅ Networking ipsec: basic netns tunnel [32] 🚧 ✅ trace: ftrace/tracer [33] s390x: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. x86_64: Host 1: ✅ Boot test [0] ✅ xfstests: ext4 [1] ✅ xfstests: xfs [1] ✅ selinux-policy: serge-testsuite [2] ✅ lvm thinp sanity [3] ✅ storage: software RAID testing [4] 🚧 ✅ Storage blktests [5] 🚧 ✅ IOMMU boot test [6] Host 2: ✅ Boot test [0] ✅ Podman system integration test (as root) [7] ✅ Podman system integration test (as user) [7] ✅ LTP lite [8] ✅ Loopdev Sanity [9] ✅ jvm test suite [10] ✅ Memory function: memfd_create [11] ✅ AMTU (Abstract Machine Test Utility) [12] ✅ LTP: openposix test suite [13] ✅ Ethernet drivers sanity [14] ✅ Networking socket: fuzz [15] ✅ Networking sctp-auth: sockopts test [16] ✅ Networking: igmp conformance test [17] ✅ Networking TCP: keepalive test [18] ✅ Networking UDP: socket [19] ✅ Networking tunnel: gre basic [20] ✅ Networking tunnel: vxlan basic [21] ✅ audit: audit testsuite test [22] ✅ httpd: mod_ssl smoke sanity [23] ✅ iotop: sanity [24] ✅ tuned: tune-processes-through-perf [25] ✅ pciutils: sanity smoke test [34] ✅ Usex - version 1.9-29 [26] ✅ storage: SCSI VPD [27] ❌ stress: stress-ng [28] 🚧 ✅ Networking route: pmtu [29] 🚧 ✅ Networking route_func: local [30] 🚧 ✅ Networking route_func: forward [30] 🚧 ✅ Networking tunnel: geneve basic test [31] 🚧 ✅ Networking ipsec: basic netns transport [32] 🚧 ✅ Networking ipsec: basic netns tunnel [32] 🚧 ✅ trace: ftrace/tracer [33] Test source: 💚 Pull requests are welcome for new tests or improvements to existing tests! [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/lvm/… [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/swra… [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/blk [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/iommu/boot [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/container/p… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/jvm [11]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/memory/func… [12]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [13]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [14]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [15]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [16]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/s… [17]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/i… [18]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/t… [19]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/u… [20]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [21]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [22]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [23]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [24]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [25]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [26]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… [27]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/scsi… [28]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres… [29]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [30]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [31]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [32]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [33]: https://github.com/CKI-project/tests-beaker/archive/master.zip#trace/ftrace… [34]: https://github.com/CKI-project/tests-beaker/archive/master.zip#pciutils/san… Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 4 months

3
3
0 0

[PATCH v4] drm/i915: Call dma_set_max_seg_size() in i915_driver_hw_probe()

by Lyude Paul

Currently, we don't call dma_set_max_seg_size() for i915 because we intentionally do not limit the segment length that the device supports. However, this results in a warning being emitted if we try to map anything larger than SZ_64K on a kernel with CONFIG_DMA_API_DEBUG_SG enabled: [ 7.751926] DMA-API: i915 0000:00:02.0: mapping sg segment longer than device claims to support [len=98304] [max=65536] [ 7.751934] WARNING: CPU: 5 PID: 474 at kernel/dma/debug.c:1220 debug_dma_map_sg+0x20f/0x340 This was originally brought up on https://bugs.freedesktop.org/show_bug.cgi?id=108517 , and the consensus there was it wasn't really useful to set a limit (and that dma-debug isn't really all that useful for i915 in the first place). Unfortunately though, CONFIG_DMA_API_DEBUG_SG is enabled in the debug configs for various distro kernels. Since a WARN_ON() will disable automatic problem reporting (and cause any CI with said option enabled to start complaining), we really should just fix the problem. Note that as me and Chris Wilson discussed, the other solution for this would be to make DMA-API not make such assumptions when a driver hasn't explicitly set a maximum segment size. But, taking a look at the commit which originally introduced this behavior, commit 78c47830a5cb ("dma-debug: check scatterlist segments"), there is an explicit mention of this assumption and how it applies to devices with no segment size: Conversely, devices which are less limited than the rather conservative defaults, or indeed have no limitations at all (e.g. GPUs with their own internal MMU), should be encouraged to set appropriate dma_parms, as they may get more efficient DMA mapping performance out of it. So unless there's any concerns (I'm open to discussion!), let's just follow suite and call dma_set_max_seg_size() with UINT_MAX as our limit to silence any warnings. Changes since v3: * Drop patch for enabling CONFIG_DMA_API_DEBUG_SG in CI. It looks like just turning it on causes the kernel to spit out bogus WARN_ONs() during some igt tests which would otherwise require teaching igt to disable the various DMA-API debugging options causing this. This is too much work to be worth it, since DMA-API debugging is useless for us. So, we'll just settle with this single patch to squelch WARN_ONs() during driver load for users that have CONFIG_DMA_API_DEBUG_SG turned on for some reason. * Move dma_set_max_seg_size() call into i915_driver_hw_probe() - Chris Wilson Signed-off-by: Lyude Paul <lyude(a)redhat.com> Reviewed-by: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: <stable(a)vger.kernel.org> # v4.18+ --- drivers/gpu/drm/i915/i915_drv.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index b5b2a64753e6..020696726f9e 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -1279,6 +1279,12 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv) pci_set_master(pdev); + /* + * We don't have a max segment size, so set it to the max so sg's + * debugging layer doesn't complain + */ + dma_set_max_seg_size(&pdev->dev, UINT_MAX); + /* overlay on gen2 is broken and can't address above 1G */ if (IS_GEN(dev_priv, 2)) { ret = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(30)); -- 2.21.0

5 years, 4 months

1
0
0 0

[PATCH v2 1/2] drm/i915: Call dma_set_max_seg_size() in i915_ggtt_probe_hw()

by Lyude Paul

Currently, we don't call dma_set_max_seg_size() for i915 because we intentionally do not limit the segment length that the device supports. However, this results in a warning being emitted if we try to map anything larger than SZ_64K on a kernel with CONFIG_DMA_API_DEBUG_SG enabled: [ 7.751926] DMA-API: i915 0000:00:02.0: mapping sg segment longer than device claims to support [len=98304] [max=65536] [ 7.751934] WARNING: CPU: 5 PID: 474 at kernel/dma/debug.c:1220 debug_dma_map_sg+0x20f/0x340 This was originally brought up on https://bugs.freedesktop.org/show_bug.cgi?id=108517 , and the consensus there was it wasn't really useful to set a limit (and that dma-debug isn't really all that useful for i915 in the first place). Unfortunately though, CONFIG_DMA_API_DEBUG_SG is enabled in the debug configs for various distro kernels. Since a WARN_ON() will disable automatic problem reporting (and cause any CI with said option enabled to start complaining), we really should just fix the problem. Note that as me and Chris Wilson discussed, the other solution for this would be to make DMA-API not make such assumptions when a driver hasn't explicitly set a maximum segment size. But, taking a look at the commit which originally introduced this behavior, commit 78c47830a5cb ("dma-debug: check scatterlist segments"), there is an explicit mention of this assumption and how it applies to devices with no segment size: Conversely, devices which are less limited than the rather conservative defaults, or indeed have no limitations at all (e.g. GPUs with their own internal MMU), should be encouraged to set appropriate dma_parms, as they may get more efficient DMA mapping performance out of it. So unless there's any concerns (I'm open to discussion!), let's just follow suite and call dma_set_max_seg_size() with UINT_MAX as our limit to silence any warnings. Signed-off-by: Lyude Paul <lyude(a)redhat.com> Cc: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: <stable(a)vger.kernel.org> # v4.18+ --- drivers/gpu/drm/i915/i915_gem_gtt.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 0b81e0b64393..a1475039d182 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c @@ -3152,6 +3152,11 @@ static int ggtt_probe_hw(struct i915_ggtt *ggtt, struct intel_gt *gt) if (ret) return ret; + /* We don't have a max segment size, so set it to the max so sg's + * debugging layer doesn't complain + */ + dma_set_max_seg_size(ggtt->vm.dma, UINT_MAX); + if ((ggtt->vm.total - 1) >> 32) { DRM_ERROR("We never expected a Global GTT with more than 32bits" " of address space! Found %lldM!\n", -- 2.21.0

5 years, 4 months

2
1
0 0

[PATCH 1/2] platform/x86: intel_int0002_vgpio: Fix wakeups not working on Cherry Trail

by Hans de Goede

Commit 871f1f2bcb01 ("platform/x86: intel_int0002_vgpio: Only implement irq_set_wake on Bay Trail") removed the irq_set_wake method from the struct irq_chip used on Cherry Trail, but it did not set IRQCHIP_SKIP_SET_WAKE causing kernel/irq/manage.c: set_irq_wake_real() to return -ENXIO. This causes the kernel to no longer see PME events reported through the INT0002 device as wakeup events. Which e.g. breaks wakeup by the (USB) keyboard on many Cherry Trail 2-in-1 devices. Cc: stable(a)vger.kernel.org Fixes: 871f1f2bcb01 ("platform/x86: intel_int0002_vgpio: Only implement irq_set_wake on Bay Trail") Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- drivers/platform/x86/intel_int0002_vgpio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/intel_int0002_vgpio.c b/drivers/platform/x86/intel_int0002_vgpio.c index d9542c661ddc..9ea1a2a19f86 100644 --- a/drivers/platform/x86/intel_int0002_vgpio.c +++ b/drivers/platform/x86/intel_int0002_vgpio.c @@ -144,6 +144,7 @@ static struct irq_chip int0002_cht_irqchip = { * No set_wake, on CHT the IRQ is typically shared with the ACPI SCI * and we don't want to mess with the ACPI SCI irq settings. */ + .flags = IRQCHIP_SKIP_SET_WAKE, }; static const struct x86_cpu_id int0002_cpu_ids[] = { -- 2.22.0

5 years, 4 months

1
0
0 0

[tip: x86/urgent] x86/retpoline: Don't clobber RFLAGS during CALL_NOSPEC on i386

by tip-bot2 for Sean Christopherson

The following commit has been merged into the x86/urgent branch of tip: Commit-ID: b63f20a778c88b6a04458ed6ffc69da953d3a109 Gitweb: https://git.kernel.org/tip/b63f20a778c88b6a04458ed6ffc69da953d3a109 Author: Sean Christopherson <sean.j.christopherson(a)intel.com> AuthorDate: Thu, 22 Aug 2019 14:11:22 -07:00 Committer: Thomas Gleixner <tglx(a)linutronix.de> CommitterDate: Fri, 23 Aug 2019 17:38:13 +02:00 x86/retpoline: Don't clobber RFLAGS during CALL_NOSPEC on i386 Use 'lea' instead of 'add' when adjusting %rsp in CALL_NOSPEC so as to avoid clobbering flags. KVM's emulator makes indirect calls into a jump table of sorts, where the destination of the CALL_NOSPEC is a small blob of code that performs fast emulation by executing the target instruction with fixed operands. adcb_al_dl: 0x000339f8 <+0>: adc %dl,%al 0x000339fa <+2>: ret A major motiviation for doing fast emulation is to leverage the CPU to handle consumption and manipulation of arithmetic flags, i.e. RFLAGS is both an input and output to the target of CALL_NOSPEC. Clobbering flags results in all sorts of incorrect emulation, e.g. Jcc instructions often take the wrong path. Sans the nops... asm("push %[flags]; popf; " CALL_NOSPEC " ; pushf; pop %[flags]\n" 0x0003595a <+58>: mov 0xc0(%ebx),%eax 0x00035960 <+64>: mov 0x60(%ebx),%edx 0x00035963 <+67>: mov 0x90(%ebx),%ecx 0x00035969 <+73>: push %edi 0x0003596a <+74>: popf 0x0003596b <+75>: call *%esi 0x000359a0 <+128>: pushf 0x000359a1 <+129>: pop %edi 0x000359a2 <+130>: mov %eax,0xc0(%ebx) 0x000359b1 <+145>: mov %edx,0x60(%ebx) ctxt->eflags = (ctxt->eflags & ~EFLAGS_MASK) | (flags & EFLAGS_MASK); 0x000359a8 <+136>: mov -0x10(%ebp),%eax 0x000359ab <+139>: and $0x8d5,%edi 0x000359b4 <+148>: and $0xfffff72a,%eax 0x000359b9 <+153>: or %eax,%edi 0x000359bd <+157>: mov %edi,0x4(%ebx) For the most part this has gone unnoticed as emulation of guest code that can trigger fast emulation is effectively limited to MMIO when running on modern hardware, and MMIO is rarely, if ever, accessed by instructions that affect or consume flags. Breakage is almost instantaneous when running with unrestricted guest disabled, in which case KVM must emulate all instructions when the guest has invalid state, e.g. when the guest is in Big Real Mode during early BIOS. Fixes: 776b043848fd2 ("x86/retpoline: Add initial retpoline support") Fixes: 1a29b5b7f347a ("KVM: x86: Make indirect calls in emulator speculation safe") Signed-off-by: Sean Christopherson <sean.j.christopherson(a)intel.com> Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> Acked-by: Peter Zijlstra (Intel) <peterz(a)infradead.org> Cc: stable(a)vger.kernel.org Link: https://lkml.kernel.org/r/20190822211122.27579-1-sean.j.christopherson@inte… --- arch/x86/include/asm/nospec-branch.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/nospec-branch.h b/arch/x86/include/asm/nospec-branch.h index 109f974..80bc209 100644 --- a/arch/x86/include/asm/nospec-branch.h +++ b/arch/x86/include/asm/nospec-branch.h @@ -192,7 +192,7 @@ " lfence;\n" \ " jmp 902b;\n" \ " .align 16\n" \ - "903: addl $4, %%esp;\n" \ + "903: lea 4(%%esp), %%esp;\n" \ " pushl %[thunk_target];\n" \ " ret;\n" \ " .align 16\n" \

5 years, 4 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror August 2019