July 2019 - Linux-stable-mirror

[PATCH v2 2/4] net: mvmdio: allow up to four clocks to be specified for orion-mdio

by josua＠solid-run.com

From: Josua Mayer <josua(a)solid-run.com> Allow up to four clocks to be specified and enabled for the orion-mdio interface, which are required by the Armada 8k and defined in armada-cp110.dtsi. Fixes a hang in probing the mvmdio driver that was encountered on the Clearfog GT 8K with all drivers built as modules, but also affects other boards such as the MacchiatoBIN. Cc: stable(a)vger.kernel.org Fixes: 96cb43423822 ("net: mvmdio: allow up to three clocks to be specified for orion-mdio") Reviewed-by: Andrew Lunn <andrew(a)lunn.ch> Signed-off-by: Josua Mayer <josua(a)solid-run.com> --- drivers/net/ethernet/marvell/mvmdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c index c5dac6bd2be4..e17d563e97a6 100644 --- a/drivers/net/ethernet/marvell/mvmdio.c +++ b/drivers/net/ethernet/marvell/mvmdio.c @@ -64,7 +64,7 @@ struct orion_mdio_dev { void __iomem *regs; - struct clk *clk[3]; + struct clk *clk[4]; /* * If we have access to the error interrupt pin (which is * somewhat misnamed as it not only reflects internal errors -- 2.16.4

5 years, 6 months

1
0
0 0

[tip:x86/urgent] Revert "x86/build: Move _etext to actual end of .text"

by tip-bot for Ross Zwisler

Commit-ID: 013c66edf207ddb78422b8b636f56c87939c9e34 Gitweb: https://git.kernel.org/tip/013c66edf207ddb78422b8b636f56c87939c9e34 Author: Ross Zwisler <zwisler(a)chromium.org> AuthorDate: Mon, 1 Jul 2019 09:52:08 -0600 Committer: Ingo Molnar <mingo(a)kernel.org> CommitDate: Tue, 9 Jul 2019 13:57:31 +0200 Revert "x86/build: Move _etext to actual end of .text" This reverts commit 392bef709659abea614abfe53cf228e7a59876a4. Per the discussion here: https://lkml.kernel.org/r/201906201042.3BF5CD6@keescook the above referenced commit breaks kernel compilation with old GCC toolchains as well as current versions of the Gold linker. Revert it to fix the regression and to keep the ability to compile the kernel with these tools. Signed-off-by: Ross Zwisler <zwisler(a)google.com> Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> Reviewed-by: Guenter Roeck <groeck(a)chromium.org> Cc: <stable(a)vger.kernel.org> Cc: "H. Peter Anvin" <hpa(a)zytor.com> Cc: Borislav Petkov <bp(a)alien8.de> Cc: Kees Cook <keescook(a)chromium.org> Cc: Johannes Hirte <johannes.hirte(a)datenkhaos.de> Cc: Klaus Kusche <klaus.kusche(a)computerix.info> Cc: samitolvanen(a)google.com Cc: Guenter Roeck <groeck(a)google.com> Link: https://lkml.kernel.org/r/20190701155208.211815-1-zwisler@google.com Signed-off-by: Ingo Molnar <mingo(a)kernel.org> --- arch/x86/kernel/vmlinux.lds.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S index 0850b5149345..4d1517022a14 100644 --- a/arch/x86/kernel/vmlinux.lds.S +++ b/arch/x86/kernel/vmlinux.lds.S @@ -141,10 +141,10 @@ SECTIONS *(.text.__x86.indirect_thunk) __indirect_thunk_end = .; #endif - } :text = 0x9090 - /* End of text section */ - _etext = .; + /* End of text section */ + _etext = .; + } :text = 0x9090 NOTES :text :note

5 years, 6 months

1
0
0 0

[PATCH] binder: Set end of SG buffer area properly.

by Martijn Coenen

In case the target node requests a security context, the extra_buffers_size is increased with the size of the security context. But, that size is not available for use by regular scatter-gather buffers; make sure the ending of that buffer is marked correctly. Acked-by: Todd Kjos <tkjos(a)google.com> Fixes: ec74136ded79 ("binder: create node flag to request sender's security context") Signed-off-by: Martijn Coenen <maco(a)android.com> Cc: stable(a)vger.kernel.org # 5.1+ --- drivers/android/binder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index 38a59a630cd4c..5bde08603fbc2 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -3239,7 +3239,8 @@ static void binder_transaction(struct binder_proc *proc, buffer_offset = off_start_offset; off_end_offset = off_start_offset + tr->offsets_size; sg_buf_offset = ALIGN(off_end_offset, sizeof(void *)); - sg_buf_end_offset = sg_buf_offset + extra_buffers_size; + sg_buf_end_offset = sg_buf_offset + extra_buffers_size - + ALIGN(secctx_sz, sizeof(u64)); off_min = 0; for (buffer_offset = off_start_offset; buffer_offset < off_end_offset; buffer_offset += sizeof(binder_size_t)) { -- 2.22.0.410.gd8fdbe21b5-goog

5 years, 6 months

1
0
0 0

[PATCH v2] mtd: rawnand: stm32_fmc2: avoid warnings when building with W=1 option

by Christophe Kerello

This patch solves warnings detected by setting W=1 when building. Warnings type detected: drivers/mtd/nand/raw/stm32_fmc2_nand.c: In function ‘stm32_fmc2_calc_timings’: drivers/mtd/nand/raw/stm32_fmc2_nand.c:1417:23: warning: comparison is always false due to limited range of data type [-Wtype-limits] else if (tims->twait > FMC2_PMEM_PATT_TIMING_MASK) Signed-off-by: Christophe Kerello <christophe.kerello(a)st.com> Cc: stable(a)vger.kernel.org Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver") --- Changes in v2: - Fixes/stable tag added drivers/mtd/nand/raw/stm32_fmc2_nand.c | 90 +++++++++++----------------------- 1 file changed, 29 insertions(+), 61 deletions(-) diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c index e63acc0..8cc852d 100644 --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c @@ -1427,21 +1427,16 @@ static void stm32_fmc2_calc_timings(struct nand_chip *chip, struct stm32_fmc2_timings *tims = &nand->timings; unsigned long hclk = clk_get_rate(fmc2->clk); unsigned long hclkp = NSEC_PER_SEC / (hclk / 1000); - int tar, tclr, thiz, twait, tset_mem, tset_att, thold_mem, thold_att; - - tar = hclkp; - if (tar < sdrt->tAR_min) - tar = sdrt->tAR_min; - tims->tar = DIV_ROUND_UP(tar, hclkp) - 1; - if (tims->tar > FMC2_PCR_TIMING_MASK) - tims->tar = FMC2_PCR_TIMING_MASK; - - tclr = hclkp; - if (tclr < sdrt->tCLR_min) - tclr = sdrt->tCLR_min; - tims->tclr = DIV_ROUND_UP(tclr, hclkp) - 1; - if (tims->tclr > FMC2_PCR_TIMING_MASK) - tims->tclr = FMC2_PCR_TIMING_MASK; + unsigned long timing, tar, tclr, thiz, twait; + unsigned long tset_mem, tset_att, thold_mem, thold_att; + + tar = max_t(unsigned long, hclkp, sdrt->tAR_min); + timing = DIV_ROUND_UP(tar, hclkp) - 1; + tims->tar = min_t(unsigned long, timing, FMC2_PCR_TIMING_MASK); + + tclr = max_t(unsigned long, hclkp, sdrt->tCLR_min); + timing = DIV_ROUND_UP(tclr, hclkp) - 1; + tims->tclr = min_t(unsigned long, timing, FMC2_PCR_TIMING_MASK); tims->thiz = FMC2_THIZ; thiz = (tims->thiz + 1) * hclkp; @@ -1451,18 +1446,11 @@ static void stm32_fmc2_calc_timings(struct nand_chip *chip, * tWAIT > tWP * tWAIT > tREA + tIO */ - twait = hclkp; - if (twait < sdrt->tRP_min) - twait = sdrt->tRP_min; - if (twait < sdrt->tWP_min) - twait = sdrt->tWP_min; - if (twait < sdrt->tREA_max + FMC2_TIO) - twait = sdrt->tREA_max + FMC2_TIO; - tims->twait = DIV_ROUND_UP(twait, hclkp); - if (tims->twait == 0) - tims->twait = 1; - else if (tims->twait > FMC2_PMEM_PATT_TIMING_MASK) - tims->twait = FMC2_PMEM_PATT_TIMING_MASK; + twait = max_t(unsigned long, hclkp, sdrt->tRP_min); + twait = max_t(unsigned long, twait, sdrt->tWP_min); + twait = max_t(unsigned long, twait, sdrt->tREA_max + FMC2_TIO); + timing = DIV_ROUND_UP(twait, hclkp); + tims->twait = clamp_val(timing, 1, FMC2_PMEM_PATT_TIMING_MASK); /* * tSETUP_MEM > tCS - tWAIT @@ -1477,20 +1465,15 @@ static void stm32_fmc2_calc_timings(struct nand_chip *chip, if (twait > thiz && (sdrt->tDS_min > twait - thiz) && (tset_mem < sdrt->tDS_min - (twait - thiz))) tset_mem = sdrt->tDS_min - (twait - thiz); - tims->tset_mem = DIV_ROUND_UP(tset_mem, hclkp); - if (tims->tset_mem == 0) - tims->tset_mem = 1; - else if (tims->tset_mem > FMC2_PMEM_PATT_TIMING_MASK) - tims->tset_mem = FMC2_PMEM_PATT_TIMING_MASK; + timing = DIV_ROUND_UP(tset_mem, hclkp); + tims->tset_mem = clamp_val(timing, 1, FMC2_PMEM_PATT_TIMING_MASK); /* * tHOLD_MEM > tCH * tHOLD_MEM > tREH - tSETUP_MEM * tHOLD_MEM > max(tRC, tWC) - (tSETUP_MEM + tWAIT) */ - thold_mem = hclkp; - if (thold_mem < sdrt->tCH_min) - thold_mem = sdrt->tCH_min; + thold_mem = max_t(unsigned long, hclkp, sdrt->tCH_min); if (sdrt->tREH_min > tset_mem && (thold_mem < sdrt->tREH_min - tset_mem)) thold_mem = sdrt->tREH_min - tset_mem; @@ -1500,11 +1483,8 @@ static void stm32_fmc2_calc_timings(struct nand_chip *chip, if ((sdrt->tWC_min > tset_mem + twait) && (thold_mem < sdrt->tWC_min - (tset_mem + twait))) thold_mem = sdrt->tWC_min - (tset_mem + twait); - tims->thold_mem = DIV_ROUND_UP(thold_mem, hclkp); - if (tims->thold_mem == 0) - tims->thold_mem = 1; - else if (tims->thold_mem > FMC2_PMEM_PATT_TIMING_MASK) - tims->thold_mem = FMC2_PMEM_PATT_TIMING_MASK; + timing = DIV_ROUND_UP(thold_mem, hclkp); + tims->thold_mem = clamp_val(timing, 1, FMC2_PMEM_PATT_TIMING_MASK); /* * tSETUP_ATT > tCS - tWAIT @@ -1526,11 +1506,8 @@ static void stm32_fmc2_calc_timings(struct nand_chip *chip, if (twait > thiz && (sdrt->tDS_min > twait - thiz) && (tset_att < sdrt->tDS_min - (twait - thiz))) tset_att = sdrt->tDS_min - (twait - thiz); - tims->tset_att = DIV_ROUND_UP(tset_att, hclkp); - if (tims->tset_att == 0) - tims->tset_att = 1; - else if (tims->tset_att > FMC2_PMEM_PATT_TIMING_MASK) - tims->tset_att = FMC2_PMEM_PATT_TIMING_MASK; + timing = DIV_ROUND_UP(tset_att, hclkp); + tims->tset_att = clamp_val(timing, 1, FMC2_PMEM_PATT_TIMING_MASK); /* * tHOLD_ATT > tALH @@ -1545,17 +1522,11 @@ static void stm32_fmc2_calc_timings(struct nand_chip *chip, * tHOLD_ATT > tRC - (tSETUP_ATT + tWAIT) * tHOLD_ATT > tWC - (tSETUP_ATT + tWAIT) */ - thold_att = hclkp; - if (thold_att < sdrt->tALH_min) - thold_att = sdrt->tALH_min; - if (thold_att < sdrt->tCH_min) - thold_att = sdrt->tCH_min; - if (thold_att < sdrt->tCLH_min) - thold_att = sdrt->tCLH_min; - if (thold_att < sdrt->tCOH_min) - thold_att = sdrt->tCOH_min; - if (thold_att < sdrt->tDH_min) - thold_att = sdrt->tDH_min; + thold_att = max_t(unsigned long, hclkp, sdrt->tALH_min); + thold_att = max_t(unsigned long, thold_att, sdrt->tCH_min); + thold_att = max_t(unsigned long, thold_att, sdrt->tCLH_min); + thold_att = max_t(unsigned long, thold_att, sdrt->tCOH_min); + thold_att = max_t(unsigned long, thold_att, sdrt->tDH_min); if ((sdrt->tWB_max + FMC2_TIO + FMC2_TSYNC > tset_mem) && (thold_att < sdrt->tWB_max + FMC2_TIO + FMC2_TSYNC - tset_mem)) thold_att = sdrt->tWB_max + FMC2_TIO + FMC2_TSYNC - tset_mem; @@ -1574,11 +1545,8 @@ static void stm32_fmc2_calc_timings(struct nand_chip *chip, if ((sdrt->tWC_min > tset_att + twait) && (thold_att < sdrt->tWC_min - (tset_att + twait))) thold_att = sdrt->tWC_min - (tset_att + twait); - tims->thold_att = DIV_ROUND_UP(thold_att, hclkp); - if (tims->thold_att == 0) - tims->thold_att = 1; - else if (tims->thold_att > FMC2_PMEM_PATT_TIMING_MASK) - tims->thold_att = FMC2_PMEM_PATT_TIMING_MASK; + timing = DIV_ROUND_UP(thold_att, hclkp); + tims->thold_att = clamp_val(timing, 1, FMC2_PMEM_PATT_TIMING_MASK); } static int stm32_fmc2_setup_interface(struct nand_chip *chip, int chipnr, -- 1.9.1

5 years, 6 months

1
0
0 0

[PATCH] drm/i915/userptr: Acquire the page lock around set_page_dirty()

by Chris Wilson

set_page_dirty says: For pages with a mapping this should be done under the page lock for the benefit of asynchronous memory errors who prefer a consistent dirty state. This rule can be broken in some special cases, but should be better not to. If the mapping doesn't provide a set_page_dirty a_op, then just fall through and assume that it wants buffer_heads. Under those rules, it only safe for us to use the plain set_page_dirty() calls for shmemfs/anonymous memory. Userptr may be used with real mappings and so needs to use the locked version (set_page_dirty_lock). Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=203317 Fixes: 5cc9ed4b9a7a ("drm/i915: Introduce mapping of user pages into video memory (userptr) ioctl") Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin(a)intel.com> Cc: stable(a)vger.kernel.org --- drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c index 16ccec7fb7da..32d208ede343 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c @@ -665,7 +665,15 @@ i915_gem_userptr_put_pages(struct drm_i915_gem_object *obj, for_each_sgt_page(page, sgt_iter, pages) { if (obj->mm.dirty) - set_page_dirty(page); + /* + * As this may not be anonymous memory (e.g. shmem) + * but exist on a real mapping, we have to lock + * the page in order to dirty it -- holding + * the page reference is not sufficient to + * prevent the inode from being truncated. + * Play safe and take the lock. + */ + set_page_dirty_lock(page); mark_page_accessed(page); put_page(page); -- 2.20.1

5 years, 6 months

2
1
0 0

❌ FAIL: Stable queue: queue-5.1

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 8584aaf1c326 - Linux 5.1.16 The results of these automated tests are provided below. Overall result: FAILED (see details below) Merge: OK Compile: OK Tests: FAILED One or more kernel tests failed: aarch64: ❌ xfstests: xfs ppc64le: ❌ xfstests: xfs x86_64: ❌ xfstests: xfs We hope that these logs can help you find the problem quickly. For the full detail on our testing procedures, please scroll to the bottom of this message. Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 8584aaf1c326 - Linux 5.1.16 We grabbed the e8dcb4c0c161 commit of the stable queue repository. We then merged the patchset with `git am`: bluetooth-fix-faulty-expression-for-minimum-encryption-key-size-check.patch signal-remove-the-wrong-signal_pending-check-in-restore_user_sigmask.patch netfilter-nf_flow_table-ignore-df-bit-setting.patch netfilter-nft_flow_offload-set-liberal-tracking-mode-for-tcp.patch netfilter-nft_flow_offload-don-t-offload-when-sequence-numbers-need-adjustment.patch netfilter-nft_flow_offload-ipcb-is-only-valid-for-ipv4-family.patch idr-fix-idr_get_next-race-with-idr_remove.patch hid-i2c-hid-add-iball-aer3-to-descriptor-override.patch asoc-cs4265-readable-register-too-low.patch asoc-ak4458-add-return-value-for-ak4458_probe.patch asoc-soc-pcm-be-dai-needs-prepare-when-pause-release.patch asoc-ak4458-rstn_control-return-a-non-zero-on-error-.patch spi-bitbang-fix-null-pointer-dereference-in-spi_unre.patch asoc-core-lock-client_mutex-while-removing-link-comp.patch iommu-vt-d-set-the-right-field-for-page-walk-snoop.patch hid-a4tech-fix-horizontal-scrolling.patch asoc-intel-baytrail-add-quirk-for-aegex-10-ru2-table.patch asoc-hda-fix-unbalanced-codec-dev-refcount-for-hda_d.patch drm-mediatek-fix-unbind-functions.patch drm-mediatek-unbind-components-in-mtk_drm_unbind.patch drm-mediatek-call-drm_atomic_helper_shutdown-when-un.patch drm-mediatek-clear-num_pipes-when-unbind-driver.patch drm-mediatek-call-mtk_dsi_stop-after-mtk_drm_crtc_at.patch asoc-max98090-remove-24-bit-format-support-if-rj-is-.patch asoc-sun4i-i2s-fix-sun8i-tx-channel-offset-mask.patch asoc-sun4i-i2s-add-offset-to-rx-channel-select.patch x86-cpu-add-more-icelake-model-numbers.patch usb-gadget-fusb300_udc-fix-memory-leak-of-fusb300-ep.patch usb-gadget-udc-lpc32xx-allocate-descriptor-with-gfp_.patch usb-gadget-dwc2-fix-zlp-handling.patch asoc-intel-cht_bsw_max98090-fix-kernel-oops-with-pla.patch asoc-intel-bytcht_es8316-fix-kernel-oops-with-platfo.patch asoc-intel-cht_bsw_nau8824-fix-kernel-oops-with-plat.patch asoc-intel-cht_bsw_rt5672-fix-kernel-oops-with-platf.patch asoc-core-move-dai-pre-links-initiation-to-snd_soc_i.patch alsa-hdac-fix-memory-release-for-sst-and-sof-drivers.patch soc-rt274-fix-internal-jack-assignment-in-set_jack-c.patch scsi-hpsa-correct-ioaccel2-chaining.patch gpio-pca953x-hack-to-fix-24-bit-gpio-expanders.patch drm-panel-orientation-quirks-add-quirk-for-gpd-pocke.patch drm-panel-orientation-quirks-add-quirk-for-gpd-micro.patch asoc-core-fix-deadlock-in-snd_soc_instantiate_card.patch asoc-intel-sst-fix-kmalloc-call-with-wrong-flags.patch platform-x86-asus-wmi-only-tell-ec-the-os-will-handl.patch platform-x86-intel-vbtn-report-switch-events-when-ev.patch platform-x86-mlx-platform-fix-parent-device-in-i2c-m.patch platform-mellanox-mlxreg-hotplug-add-devm_free_irq-c.patch i2c-pca-platform-fix-gpio-lookup-code.patch arm64-tlbflush-ensure-start-end-of-address-range-are.patch cpuset-restore-sanity-to-cpuset_cpus_allowed_fallbac.patch scripts-decode_stacktrace.sh-prefix-addr2line-with-c.patch mm-mlock.c-change-count_mm_mlocked_page_nr-return-ty.patch tracing-avoid-build-warning-with-have_nop_mcount.patch module-fix-livepatch-ftrace-module-text-permissions-.patch ftrace-fix-null-pointer-dereference-in-free_ftrace_f.patch ptrace-fix-ptracer_cred-handling-for-ptrace_traceme.patch crypto-user-prevent-operating-on-larval-algorithms.patch crypto-cryptd-fix-skcipher-instance-memory-leak.patch alsa-seq-fix-incorrect-order-of-dest_client-dest_ports-arguments.patch alsa-firewire-lib-fireworks-fix-miss-detection-of-received-midi-messages.patch alsa-line6-fix-write-on-zero-sized-buffer.patch alsa-usb-audio-fix-sign-unintended-sign-extension-on-left-shifts.patch alsa-hda-realtek-add-quirks-for-several-clevo-notebook-barebones.patch alsa-hda-realtek-change-front-mic-location-for-lenovo-m710q.patch dax-fix-xarray-entry-association-for-mixed-mappings.patch lib-mpi-fix-karactx-leak-in-mpi_powm.patch fs-userfaultfd.c-disable-irqs-for-fault_pending-and-event-locks.patch swap_readpage-avoid-blk_wake_io_task-if-synchronous.patch tracing-snapshot-resize-spare-buffer-if-size-changed.patch arm-dts-armada-xp-98dx3236-switch-to-armada-38x-uart-serial-node.patch arm64-kaslr-keep-modules-inside-module-region-when-kasan-is-enabled.patch drm-i915-ringbuffer-emit_invalidate-before-switch-context.patch drm-amd-powerplay-use-hardware-fan-control-if-no-powerplay-fan-table.patch drm-amdgpu-don-t-skip-display-settings-in-hwmgr_resume.patch drm-amdgpu-gfx9-use-reset-default-for-pa_sc_fifo_size.patch drm-virtio-move-drm_connector_update_edid_property-call.patch drm-etnaviv-add-missing-failure-path-to-destroy-suballoc.patch drm-imx-notify-drm-core-before-sending-event-during-crtc-disable.patch drm-imx-only-send-event-on-crtc-disable-if-kept-disabled.patch ftrace-x86-remove-possible-deadlock-between-register_kprobe-and-ftrace_run_update_code.patch mm-vmscan.c-prevent-useless-kswapd-loops.patch btrfs-ensure-replaced-device-doesn-t-have-pending-chunk-allocation.patch tty-rocket-fix-incorrect-forward-declaration-of-rp_i.patch s390-mm-fix-pxd_bad-with-folded-page-tables.patch kvm-x86-degrade-warn-to-pr_warn_ratelimited.patch kvm-lapic-fix-pending-interrupt-in-irr-blocked-by-software-disable-lapic.patch nfsd-fix-overflow-causing-non-working-mounts-on-1-tb-machines.patch svcrdma-ignore-source-port-when-computing-drc-hash.patch mips-fix-bounds-check-virt_addr_valid.patch mips-add-missing-ehb-in-mtc0-mfc0-sequence.patch mips-have-plain-make-calls-build-dtbs-for-selected-platforms.patch dmaengine-qcom-bam_dma-fix-completed-descriptors-count.patch dmaengine-imx-sdma-remove-bd_intr-for-channel0.patch dmaengine-jz4780-fix-an-endian-bug-in-irq-handler.patch fs-validate_fs_parser-should-default-to-n.patch Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_5.1-aa… kernel build: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_5.1-aa… ppc64le: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_5.1-pp… kernel build: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_5.1-pp… s390x: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_5.1-s390… kernel build: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_5.1-s390… x86_64: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_5.1-x86… kernel build: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_5.1-x86… Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ✅ Boot test [0] ❌ xfstests: xfs [1] 🚧 ✅ selinux-policy: serge-testsuite [2] Host 2: ✅ Boot test [0] ✅ LTP lite [3] ✅ Loopdev Sanity [4] ✅ AMTU (Abstract Machine Test Utility) [5] ✅ LTP: openposix test suite [6] ✅ audit: audit testsuite test [7] ✅ httpd: mod_ssl smoke sanity [8] ✅ iotop: sanity [9] ✅ Usex - version 1.9-29 [10] 🚧 ✅ Networking socket: fuzz [11] 🚧 ✅ tuned: tune-processes-through-perf [12] 🚧 ✅ storage: SCSI VPD [13] 🚧 ✅ stress: stress-ng [14] ppc64le: Host 1: ✅ Boot test [0] ✅ LTP lite [3] ✅ Loopdev Sanity [4] ✅ AMTU (Abstract Machine Test Utility) [5] ✅ LTP: openposix test suite [6] ✅ audit: audit testsuite test [7] ✅ httpd: mod_ssl smoke sanity [8] ✅ iotop: sanity [9] ✅ Usex - version 1.9-29 [10] 🚧 ✅ Networking socket: fuzz [11] 🚧 ✅ tuned: tune-processes-through-perf [12] Host 2: ✅ Boot test [0] ❌ xfstests: xfs [1] 🚧 ✅ selinux-policy: serge-testsuite [2] s390x: Host 1: ✅ Boot test [0] 🚧 ✅ selinux-policy: serge-testsuite [2] Host 2: ✅ Boot test [0] ✅ LTP lite [3] ✅ Loopdev Sanity [4] ✅ LTP: openposix test suite [6] ✅ audit: audit testsuite test [7] ✅ httpd: mod_ssl smoke sanity [8] ✅ iotop: sanity [9] 🚧 ✅ Networking socket: fuzz [11] 🚧 ✅ tuned: tune-processes-through-perf [12] 🚧 ✅ stress: stress-ng [14] x86_64: Host 1: ✅ Boot test [0] ✅ LTP lite [3] ✅ Loopdev Sanity [4] ✅ AMTU (Abstract Machine Test Utility) [5] ✅ LTP: openposix test suite [6] ✅ audit: audit testsuite test [7] ✅ httpd: mod_ssl smoke sanity [8] ✅ iotop: sanity [9] ✅ Usex - version 1.9-29 [10] 🚧 ✅ Networking socket: fuzz [11] 🚧 ✅ tuned: tune-processes-through-perf [12] 🚧 ✅ storage: SCSI VPD [13] 🚧 ✅ stress: stress-ng [14] Host 2: ✅ Boot test [0] ❌ xfstests: xfs [1] 🚧 ✅ selinux-policy: serge-testsuite [2] Test source: 💚 Pull requests are welcome for new tests or improvements to existing tests! [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… [11]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [12]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [13]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/scsi… [14]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres… Waived tests (marked with 🚧) ----------------------------- This test run included waived tests. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 6 months

3
2
0 0

[4.4.y PATCH 0/4] Backported fixes for 4.4 stable tree

by Srivatsa S. Bhat

Hi, This patchset includes a few backported fixes for the 4.4 stable tree. I would appreciate if you could kindly consider including them in the next release. Thank you! Regards, Srivatsa --- Gen Zhang (2): ip_sockglue: Fix missing-check bug in ip_ra_control() ipv6_sockglue: Fix a missing-check bug in ip6_ra_control() Vivek Goyal (1): ovl: modify ovl_permission() to do checks on two inodes Wanpeng Li (1): KVM: X86: Fix scan ioapic use-before-initialization arch/x86/kvm/x86.c | 3 ++- fs/overlayfs/inode.c | 13 +++++++++++++ net/ipv4/ip_sockglue.c | 2 ++ net/ipv6/ipv6_sockglue.c | 2 ++ 4 files changed, 19 insertions(+), 1 deletion(-)

5 years, 6 months

3
8
0 0

+ fs-fix-the-default-values-of-i_uid-i_gid-on-proc-sys-inodes.patch added to -mm tree

by akpm＠linux-foundation.org

The patch titled Subject: fs/proc/proc_sysctl.c: fix the default values of i_uid/i_gid on /proc/sys inodes. has been added to the -mm tree. Its filename is fs-fix-the-default-values-of-i_uid-i_gid-on-proc-sys-inodes.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/fs-fix-the-default-values-of-i_uid… and later at http://ozlabs.org/~akpm/mmotm/broken-out/fs-fix-the-default-values-of-i_uid… Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Radoslaw Burny <rburny(a)google.com> Subject: fs/proc/proc_sysctl.c: fix the default values of i_uid/i_gid on /proc/sys inodes. Normally, the inode's i_uid/i_gid are translated relative to s_user_ns, but this is not a correct behavior for proc. Since sysctl permission check in test_perm is done against GLOBAL_ROOT_[UG]ID, it makes more sense to use these values in u_[ug]id of proc inodes. In other words: although uid/gid in the inode is not read during test_perm, the inode logically belongs to the root of the namespace. I have confirmed this with Eric Biederman at LPC and in this thread: https://lore.kernel.org/lkml/87k1kzjdff.fsf@xmission.com Consequences ============ Since the i_[ug]id values of proc nodes are not used for permissions checks, this change usually makes no functional difference. However, it causes an issue in a setup where: * a namespace container is created without root user in container - hence the i_[ug]id of proc nodes are set to INVALID_[UG]ID * container creator tries to configure it by writing /proc/sys files, e.g. writing /proc/sys/kernel/shmmax to configure shared memory limit Kernel does not allow to open an inode for writing if its i_[ug]id are invalid, making it impossible to write shmmax and thus - configure the container. Using a container with no root mapping is apparently rare, but we do use this configuration at Google. Also, we use a generic tool to configure the container limits, and the inability to write any of them causes a failure. History ======= The invalid uids/gids in inodes first appeared due to 81754357770e (fs: Update i_[ug]id_(read|write) to translate relative to s_user_ns). However, AFAIK, this did not immediately cause any issues. The inability to write to these "invalid" inodes was only caused by a later commit 0bd23d09b874 (vfs: Don't modify inodes with a uid or gid unknown to the vfs). Tested: Used a repro program that creates a user namespace without any mapping and stat'ed /proc/$PID/root/proc/sys/kernel/shmmax from outside. Before the change, it shows the overflow uid, with the change it's 0. The overflow uid indicates that the uid in the inode is not correct and thus it is not possible to open the file for writing. Link: http://lkml.kernel.org/r/20190708115130.250149-1-rburny@google.com Fixes: 0bd23d09b874 ("vfs: Don't modify inodes with a uid or gid unknown to the vfs") Signed-off-by: Radoslaw Burny <rburny(a)google.com> Acked-by: Luis Chamberlain <mcgrof(a)kernel.org> Cc: Kees Cook <keescook(a)chromium.org> Cc: "Eric W . Biederman" <ebiederm(a)xmission.com> Cc: Seth Forshee <seth.forshee(a)canonical.com> Cc: John Sperbeck <jsperbeck(a)google.com> Cc: Alexey Dobriyan <adobriyan(a)gmail.com> Cc: <stable(a)vger.kernel.org> [4.8+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- fs/proc/proc_sysctl.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/fs/proc/proc_sysctl.c~fs-fix-the-default-values-of-i_uid-i_gid-on-proc-sys-inodes +++ a/fs/proc/proc_sysctl.c @@ -499,6 +499,10 @@ static struct inode *proc_sys_make_inode if (root->set_ownership) root->set_ownership(head, table, &inode->i_uid, &inode->i_gid); + else { + inode->i_uid = GLOBAL_ROOT_UID; + inode->i_gid = GLOBAL_ROOT_GID; + } return inode; } _ Patches currently in -mm which might be from rburny(a)google.com are fs-fix-the-default-values-of-i_uid-i_gid-on-proc-sys-inodes.patch

5 years, 6 months

1
0
0 0

stable-rc/linux-4.4.y boot: 86 boots: 4 failed, 82 passed (v4.4.184-74-g1ef1d6e05dcd)

by kernelci.org bot

stable-rc/linux-4.4.y boot: 86 boots: 4 failed, 82 passed (v4.4.184-74-g1ef1d6e05dcd) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.4.y/kernel/v4.4.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.184-74-… Tree: stable-rc Branch: linux-4.4.y Git Describe: v4.4.184-74-g1ef1d6e05dcd Git Commit: 1ef1d6e05dcd8a34ef188796843b380d0d4e4408 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 44 unique boards, 19 SoC families, 14 builds out of 190 Boot Failures Detected: arm: sunxi_defconfig: gcc-8: sun7i-a20-bananapi: 1 failed lab multi_v7_defconfig: gcc-8: stih410-b2120: 1 failed lab sun7i-a20-bananapi: 1 failed lab arm64: defconfig: gcc-8: qcom-qdf2400: 1 failed lab --- For more info write to <info(a)kernelci.org>

5 years, 6 months

1
0
0 0

stable-rc/linux-4.14.y boot: 105 boots: 4 failed, 101 passed (v4.14.132-57-g5c87156a66f2)

by kernelci.org bot

stable-rc/linux-4.14.y boot: 105 boots: 4 failed, 101 passed (v4.14.132-57-g5c87156a66f2) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.14.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.14.y/kernel/v4.14.132-5… Tree: stable-rc Branch: linux-4.14.y Git Describe: v4.14.132-57-g5c87156a66f2 Git Commit: 5c87156a66f25c493e12b023972fc2ccae813204 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 61 unique boards, 24 SoC families, 15 builds out of 201 Boot Failures Detected: arm: sunxi_defconfig: gcc-8: sun7i-a20-bananapi: 1 failed lab multi_v7_defconfig: gcc-8: exynos5250-snow: 1 failed lab sun7i-a20-bananapi: 1 failed lab arm64: defconfig: gcc-8: rk3399-firefly: 1 failed lab --- For more info write to <info(a)kernelci.org>

5 years, 6 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror July 2019